nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-15 07:43:31 +01:00
Code Issues Packages Projects Releases Wiki Activity
23,389 Commits 53 Branches 630 Tags 125 MiB
171981f8a0
Commit Graph

1476 Commits

Author SHA1 Message Date
Nick Mathewson
820159cac5 r15530@tombo: nickm | 2007-12-17 16:54:03 -0500 
First wodge of geoip code so bridges can figure out which countries are blocking them.


svn:r12845
 2007-12-17 22:44:11 +00:00
Roger Dingledine
1d8a8063b9 clean up copyrights, and assign 2007 copyrights to The Tor Project, Inc 
svn:r12786
 2007-12-12 21:09:01 +00:00
Roger Dingledine
d46b8a3eac Stop being so aggressive about fetching dir info if your DirPort is 
on but your ORPort is off.

Add a new config option BridgeRelay that specifies you want to
be a bridge relay. Right now the only difference is that it makes
you answer begin_dir requests, and it makes you cache dir info,
even if your DirPort isn't on.

Refactor directory_caches_dir_info() into some more functions.


svn:r12668
 2007-12-04 18:35:03 +00:00
Roger Dingledine
9b1b8199df backport candidate: 
Start purging old entries from the "rephist" database, and the
hidden service descriptor databases, even when DirPort is zero.


svn:r12628
 2007-12-01 22:38:58 +00:00
Roger Dingledine
c26c54836f download the (admittedly tiny) v1 dir blobs even less often. 
we can't make them totally obsolete yet but we can get closer.


svn:r12626
 2007-12-01 20:02:05 +00:00
Roger Dingledine
f8df8d791e start to refactor dirserver_mode() 
svn:r12621
 2007-12-01 04:58:53 +00:00
Roger Dingledine
91bb09cb28 Only update guard status (usable / not usable) once we have 
enough directory information. This was causing us to always pick
two new guards on startup (bugfix on 0.2.0.9-alpha), and it was
causing us to discard all our guards on startup if we hadn't been
running for a few weeks (bugfix on 0.1.2.x). Fixes bug 448.


svn:r12570
 2007-11-26 02:18:57 +00:00
Nick Mathewson
1bdbd3b98e r16582@catbus: nickm | 2007-11-08 13:14:16 -0500 
Try to bulletproof the parse logic for router-stability.


svn:r12441
 2007-11-08 18:15:49 +00:00
Nick Mathewson
c3a745951b r16570@catbus: nickm | 2007-11-08 11:04:20 -0500 
Keep track, for each OR connection, of the last time we added a non-padding cell to its outbuf.  Use this timestamp, not "lastwritten" to tell if it is time to close a circuitless connection.  (We can'tuse lastwritten, since lastwritten is updated when ever the connection flushes anything, and by that point we can no longer tell what is a padding cell and what is not.)


svn:r12437
 2007-11-08 16:19:07 +00:00
Nick Mathewson
6aeca5237d r14631@tombo: nickm | 2007-11-02 00:18:17 -0400 
Better log messages for "not enough to build a circuit" message.


svn:r12324
 2007-11-02 04:18:28 +00:00
Nick Mathewson
832ef9562f r14623@tombo: nickm | 2007-11-01 22:25:18 -0400 
More tweaks from karsten, with some cleanup and commentary.


svn:r12319
 2007-11-02 02:25:28 +00:00
Nick Mathewson
2645219b4c r16322@catbus: nickm | 2007-11-01 00:26:15 -0400 
Implement --quiet.


svn:r12306
 2007-11-01 04:38:43 +00:00
Nick Mathewson
2c1d7cf674 r16194@catbus: nickm | 2007-10-26 18:37:02 -0400 
Keep circuitless TLS connections open for 1.5 x MaxCircuitDirtiness: this ensures that we don't thrash closing and repoening connections to our guards.


svn:r12218
 2007-10-26 22:50:40 +00:00
Roger Dingledine
f43b9638e4 Don't complain that "your server has not managed to confirm that its 
ports are reachable" if we haven't been able to build any circuits
yet. Bug found by spending four hours without a v3 consensus.


svn:r12133
 2007-10-23 15:44:13 +00:00
Nick Mathewson
5bfb422157 r15934@catbus: nickm | 2007-10-18 15:32:56 -0400 
When we have plenty of directory information, don't try to launch descriptor downloads quite so eagerly.


svn:r12033
 2007-10-18 19:51:14 +00:00
Nick Mathewson
192e3d71d4 r15915@catbus: nickm | 2007-10-18 10:26:44 -0400 
Stop incessant notices about when we think the expected valid-after time should be, if we are not an authority.


svn:r12022
 2007-10-18 14:27:42 +00:00
Nick Mathewson
54ac72f6b0 r15887@catbus: nickm | 2007-10-17 17:25:32 -0400 
When a networkstatus consensus download fails, do not wait 60 seconds to decide whether to retry. (Also, log the time at which we'll try to replace the current networkstatus.)


svn:r12005
 2007-10-17 21:26:22 +00:00
Nick Mathewson
9d7eba6ecc r15868@catbus: nickm | 2007-10-16 14:18:29 -0400 
Remove nearly all calls to routerlist_remove_old().  Backport candidate.


svn:r11994
 2007-10-16 18:19:02 +00:00
Nick Mathewson
3ad6dc0e2e r15806@catbus: nickm | 2007-10-15 19:14:57 -0400 
Implement v3 networkstatus client code.  Remove v2 networkstatus client code, except as needed for caches to fetch and serve v2 networkstatues and the routers they list.


svn:r11957
 2007-10-15 23:15:24 +00:00
Roger Dingledine
39902e93f7 Stop publishing a new server descriptor just because we HUP or 
when we find our DirPort to be reachable but won't actually publish
it. Extra descriptors without any real changes are dropped by the
authorities, and can screw up our "publish every 18 hours" schedule.


svn:r11915
 2007-10-13 22:31:35 +00:00
Nick Mathewson
9a56b17c54 r15679@catbus: nickm | 2007-10-11 09:51:33 -0400 
Remove code to generate v1 directories.


svn:r11866
 2007-10-11 13:56:33 +00:00
Nick Mathewson
8b71a76dd3 r15598@catbus: nickm | 2007-10-09 16:37:35 -0400 
Turn all "Is DirPort nonzero? Because if it is, we must be a directory" logic into calls to dirserver_mode().


svn:r11817
 2007-10-09 20:44:47 +00:00
Nick Mathewson
18ec603861 r14802@Kushana: nickm | 2007-10-08 17:21:30 -0400 
Refactor out about a third of routerlist.c into a new networkstatus.c.  I\m not sure that I got everything that needed to move, but so far so good.


svn:r11791
 2007-10-08 21:21:50 +00:00
Nick Mathewson
6f7847b378 r15530@catbus: nickm | 2007-10-04 12:16:27 -0400 
Add a bunch of function documentation; clean up a little code; fix some XXXXs; tag the nonsensical EXTRAINFO_PURPOSE_GENERAL as nonsesnse; note another bit of "do not cache special routers" code to nuke.


svn:r11761
 2007-10-04 16:21:58 +00:00
Nick Mathewson
973502d290 r15046@catbus: nickm | 2007-09-11 13:38:36 -0400 
Check V3 authority certificates for expiry, and warn the authority op as they get old.


svn:r11427
 2007-09-11 20:17:22 +00:00
Nick Mathewson
1c8bd05c70 Fix compilation of ntmain.c. 
svn:r11395
 2007-09-06 18:19:09 +00:00
Nick Mathewson
f17a38ab04 r14940@catbus: nickm | 2007-09-06 13:22:26 -0400 
Move NT services code into its own C file.  Probably will not build happily on win32 yet; more hacking needed.


svn:r11388
 2007-09-06 17:42:05 +00:00
Nick Mathewson
3effc8b267 r14733@catbus: nickm | 2007-08-20 12:32:44 -0400 
Clean up MTBF storage code. Do not count times that we have been down toward the current run.  Handle backward timewarps correctly.  Store MTBF data on exit in addition to periodically.


svn:r11225
 2007-08-20 16:34:17 +00:00
Nick Mathewson
9958dc8d53 r14729@catbus: nickm | 2007-08-20 11:58:02 -0400 
Trigger load and save of MTBF data.


svn:r11219
 2007-08-20 15:59:31 +00:00
Roger Dingledine
3f186e6510 help nick work on proposal 108 
svn:r11148
 2007-08-17 01:29:58 +00:00
Nick Mathewson
357b4645cf r14612@catbus: nickm | 2007-08-16 15:23:35 -0400 
Initial work on proposal 108: have rephist.c track the information we want to be tracking for OR stability.


svn:r11147
 2007-08-16 19:32:29 +00:00
Nick Mathewson
ce1f01c3e6 r14531@catbus: nickm | 2007-08-13 14:46:25 -0400 
Cache v3 networkstatus consensuses on disk.


svn:r11086
 2007-08-13 18:47:22 +00:00
Nick Mathewson
45c82b1d85 r14024@catbus: nickm | 2007-07-30 14:13:58 -0400 
Glibc (and maybe others) define a mallinfo() that can be used to see how the platform malloc is acting inside.  When we have it, dump its output on dumpmemusage().


svn:r10996
 2007-07-30 18:14:14 +00:00
Nick Mathewson
915c4c3ab8 r14001@catbus: nickm | 2007-07-29 21:31:53 -0400 
Try to call time(NULL) a little less.


svn:r10980
 2007-07-30 01:32:12 +00:00
Nick Mathewson
77508edd36 r13989@catbus: nickm | 2007-07-29 19:11:07 -0400 
More directory voting code.  Now, if everything works, and I haven't forgotten anything, it is possible to set up some v3 authorities and start voting. Of course, I have probably forgotten something, and there are probably bugs in there somewhere too.


svn:r10976
 2007-07-29 23:11:44 +00:00
Roger Dingledine
9895d840f5 When running with dmalloc, dump more stats on hup and exit. 
svn:r10961
 2007-07-29 01:18:00 +00:00
Nick Mathewson
bc9a7be943 r13939@catbus: nickm | 2007-07-27 14:33:22 -0400 
When dumping memory usage, list bytes used in buffer memory free-lists.


svn:r10947
 2007-07-27 18:33:37 +00:00
Nick Mathewson
10f166045b r13937@catbus: nickm | 2007-07-27 12:43:36 -0400 
Maintain a detached-signatures document along with pending consensus document.  Add a dirvote_free_all() to clean up static vars in dirvote.c


svn:r10945
 2007-07-27 18:33:30 +00:00
Nick Mathewson
1b7a704c34 r13901@catbus: nickm | 2007-07-25 16:23:51 -0400 
Make all code to generate v1 directories into conditional code.


svn:r10926
 2007-07-25 22:56:40 +00:00
Nick Mathewson
4d2f45978f r13875@catbus: nickm | 2007-07-22 18:56:30 -0400 
Once more with feeling.


svn:r10907
 2007-07-22 22:56:33 +00:00
Nick Mathewson
6640fdeeee r13872@catbus: nickm | 2007-07-22 18:51:02 -0400 
esc_router_info static field should not be cleared postfork, to avoid races.


svn:r10906
 2007-07-22 22:51:07 +00:00
Nick Mathewson
701fce8e5c r13858@catbus: nickm | 2007-07-22 18:44:02 -0400 
Fix/note some relatively trivial mem usage issues


svn:r10905
 2007-07-22 22:49:49 +00:00
Roger Dingledine
0104882e9b dump dmalloc stats on sighup 
svn:r10903
 2007-07-22 07:05:43 +00:00
Roger Dingledine
5190916670 free a small static string on exit. 
svn:r10902
 2007-07-22 06:32:28 +00:00
Roger Dingledine
6fc336d217 handle fetching bridge descriptors from the bridge authority too. 
svn:r10898
 2007-07-22 00:16:48 +00:00
Roger Dingledine
50487c249d timeout and retry schedules for fetching bridge descriptors 
svn:r10867
 2007-07-18 10:06:03 +00:00
Roger Dingledine
fcbb817db5 free another string, and the buffer freelists, on exit. 
svn:r10851
 2007-07-17 09:26:45 +00:00
Roger Dingledine
6d2cb32d10 free some more memory on exit 
svn:r10837
 2007-07-16 04:33:47 +00:00
Nick Mathewson
74711479eb r13666@catbus: nickm | 2007-07-10 13:10:00 -0400 
Get the RESOLVE controller code working.


svn:r10781
 2007-07-10 17:14:51 +00:00
Nick Mathewson
92b6e09082 r13633@catbus: nickm | 2007-07-06 11:08:19 -0400 
Call tor_init_threads() from tor_init().


svn:r10751
 2007-07-06 18:20:52 +00:00
Nick Mathewson
5adfa09fce r13477@catbus: nickm | 2007-06-17 14:22:03 -0400 
Sun CC likes to give warnings for the do { } while(0) construction for making statement-like macros.  Define STMT_BEGIN/STMT_END macros that do the right thing, and use them everywhere.


svn:r10645
 2007-06-17 18:22:39 +00:00
Roger Dingledine
3d641bde0e Refine r10571: more work on bridge stuff. 
- Only listen to responses for "authority" fetches if we're configured
    to use Bridges. Otherwise it's safe (and maybe smarter) to silently
    discard them like we used to.
  - React faster to download networkstatuses after the first bridge
    descriptor arrives.
  - Don't do dir fetches before we have any bridges, even when our 
    dirport is open.


svn:r10604
 2007-06-15 02:12:15 +00:00
Nick Mathewson
c2ea3e9aea r13406@catbus: nickm | 2007-06-13 17:05:30 -0400 
Oops; linked connections get read/write events too.


svn:r10596
 2007-06-13 21:05:32 +00:00
Nick Mathewson
4b162fd1f4 r13401@catbus: nickm | 2007-06-13 15:50:16 -0400 
Add dnsport connection to the global connection list. (Bug found by mwenge.)


svn:r10592
 2007-06-13 19:50:18 +00:00
Roger Dingledine
af658b7828 More work towards making bridge users able to connect via bridges: 
- demand options->Bridges and options->TunnelDirConns if 
    options->UseBridges is set.
  - after directory fetches, accept descriptors that aren't referenced by
    our networkstatuses, *if* they're for a configured bridge.
  - delay directory fetching until we have at least one bridge descriptor.
  - learn how to build a one-hop circuit when we have neither routerinfo
    nor routerstatus for our destination.
  - teach directory connections how to pick a bridge as the destination
    directory when doing non-anonymous fetches.
  - tolerate directory commands for which the dir_port is 0.
  - remember descriptors when the requested_resource was "authority", 
    rather than just ignoring them.
  - put bridges on our entry_guards list once we have a descriptor for them.
    When UseBridges is set, only pick entry guards that are bridges. Else
    vice versa.


svn:r10571
 2007-06-12 09:17:23 +00:00
Roger Dingledine
a97c3b8c2d Be clearer on the various roles for auth dir types. 
Bridge authorities no longer write bridge descriptors to their
cached-routers file -- this gets complex because of extrainfo documents.


svn:r10545
 2007-06-09 07:05:19 +00:00
Nick Mathewson
1866ad3506 r13274@catbus: nickm | 2007-06-05 19:06:30 -0400 
Remove some deadcode that seems unlikely to return


svn:r10509
 2007-06-06 04:51:25 +00:00
Peter Palfrader
502879e0b4 Remove force flag from retry_all_listeners() and retry_listeners(). It always was 0. 
svn:r10486
 2007-06-04 16:54:42 +00:00
Nick Mathewson
9d1af71b70 r13053@catbus: nickm | 2007-05-29 13:35:33 -0400 
Move connection_should_read_from_linked_conn into main.c, which is the only file that uses it.


svn:r10394
 2007-05-29 18:20:56 +00:00
Nick Mathewson
f89a3b1448 r13050@catbus: nickm | 2007-05-29 13:31:11 -0400 
Resolve all but 3 DOCDOCs.


svn:r10393
 2007-05-29 17:31:13 +00:00
Nick Mathewson
a312afd67e r12936@catbus: nickm | 2007-05-24 14:12:34 -0400 
Review XXXX comments without a version; upgrade some to XXXX020.


svn:r10315
 2007-05-24 18:12:52 +00:00
Nick Mathewson
6975a093e9 r12853@catbus: nickm | 2007-05-22 11:36:54 -0400 
Make connection_array into a smartlist.


svn:r10292
 2007-05-22 15:49:14 +00:00
Nick Mathewson
e935d73b34 r12852@catbus: nickm | 2007-05-22 11:00:27 -0400 
Use svn revisions consistently throughout all log messages.


svn:r10291
 2007-05-22 15:48:46 +00:00
Roger Dingledine
ddd0054a85 point out two remote crash bugs, a memory leak, and a few other 
items we should probably look into.


svn:r10227
 2007-05-20 14:15:23 +00:00
Nick Mathewson
ec55cf526d r12981@Kushana: nickm | 2007-05-18 14:12:19 -0400 
First cut at code to download extra-info docs.  Also note a bad bug in directory.c (look for the string BUG BUG BUG).


svn:r10209
 2007-05-18 21:19:19 +00:00
Roger Dingledine
440b7f0c70 polish r9726-r9903 
svn:r10182
 2007-05-13 09:25:06 +00:00
Nick Mathewson
34a09c24b5 r12706@catbus: nickm | 2007-05-09 18:39:46 -0400 
Keep two freelists for buffer ram chunks: one of 4k chunks, and one of 16k chunks.  Also, document the whole business.


svn:r10150
 2007-05-09 22:39:49 +00:00
Nick Mathewson
b248ed620f r12704@catbus: nickm | 2007-05-09 17:43:34 -0400 
Periodically clean the freelist of buffer memory chunks.


svn:r10149
 2007-05-09 21:43:41 +00:00
Roger Dingledine
d112e7b1ad fix some code comments, a wrapper, and add a todo item 
svn:r10111
 2007-05-04 07:24:01 +00:00
Roger Dingledine
dfe93fb386 whoops, i missed main.c in my r10092 
svn:r10098
 2007-05-02 21:56:32 +00:00
Nick Mathewson
744d955bb3 r12632@catbus: nickm | 2007-05-02 14:59:55 -0400 
Fix compilation-breaking r10092.


svn:r10093
 2007-05-02 18:59:57 +00:00
Roger Dingledine
e9c4dd1304 more cleanups on the hsusage patch 
svn:r10077
 2007-04-30 23:25:22 +00:00
Nick Mathewson
18ba9fe81f r12580@catbus: nickm | 2007-04-30 13:29:05 -0400 
Initial version of patch from Karsten Loesing: Add an HSAuthorityRecordStats option to track statistics of overall hidden service usage without logging information that would be useful to an attacker.


svn:r10067
 2007-04-30 17:46:13 +00:00
Roger Dingledine
3d00738ec7 simplify connection_watch_events() 
hope this doesn't break it


svn:r10025
 2007-04-25 07:20:04 +00:00
Nick Mathewson
473c266fc2 r12496@catbus: nickm | 2007-04-22 23:04:05 -0400 
When logging memory usage, break down memory used in buffers by buffer type.


svn:r10004
 2007-04-23 03:04:46 +00:00
Nick Mathewson
648065fcb4 r12763@Kushana: nickm | 2007-04-20 18:42:58 -0400 
Initial version of code to stop using socket pairs for linked connections.  Superficially, it seems to work, but it probably needs a lot more testing and attention.


svn:r9995
 2007-04-21 17:26:12 +00:00
Nick Mathewson
227b2e0226 r12759@Kushana: nickm | 2007-04-20 08:47:20 -0400 
Track the number of connection_t separately from the number of open sockets.  It is already possible to have connections that do not count: resolving conns, for one.  Once we move from socketpairs to linked conns, and once we do dns proxying, there will be lots of such connections.


svn:r9994
 2007-04-21 17:24:18 +00:00
Nick Mathewson
7392464b88 r12456@catbus: nickm | 2007-04-19 14:47:01 -0400 
Make dumpmemusage() dump cell pool usage information.


svn:r9991
 2007-04-19 18:47:04 +00:00
Nick Mathewson
38a5f09502 r12349@catbus: nickm | 2007-04-11 09:18:15 -0400 
Add code to shrink the cell memory pool by discarding empty chunks that have been empty for the last 60 seconds.  Also, instead of having test.c duplicate declarations for exposed functions, put them inside #ifdef foo_PRIVATE blocks in the headers.  This prevents bugs where test.c gets out of sync.


svn:r9944
 2007-04-11 13:18:25 +00:00
Nick Mathewson
28de06b8e6 r12337@catbus: nickm | 2007-04-10 17:55:26 -0400 
Add support for using memory pools to allocate queued cell; pass --disable-cell-pool to configure to disable this.


svn:r9939
 2007-04-11 00:30:29 +00:00
Nick Mathewson
306d5400c3 r12643@0-41-wifi: nickm | 2007-03-23 14:56:35 -0400 
Refactor a bunch of functions that take edge_connection_t not to also take a crypt_path_t; the cpath is implicit.


svn:r9899
 2007-03-24 15:57:51 +00:00
Roger Dingledine
b4f743562f Add a separate set of token buckets for relayed traffic. Right 
now that's just defined as answers to directory requests.


svn:r9881
 2007-03-20 02:55:31 +00:00
Roger Dingledine
d374616301 clean up some minor typos and log confusions 
svn:r9832
 2007-03-15 22:47:21 +00:00
Roger Dingledine
4ca75ecc49 holy cow, those windows unames are long. don't distract so 
much from the important part of this log message.


svn:r9789
 2007-03-10 06:33:44 +00:00
Nick Mathewson
02ce8e6b12 r12474@Kushana: nickm | 2007-03-06 16:10:05 -0500 
We have a PATH_SEPARATOR macro.  How about we use it?


svn:r9782
 2007-03-09 21:39:30 +00:00
Roger Dingledine
fe94914b98 Put a platform string (e.g. "Linux i686") in the startup log 
message, so when people paste just their logs, we know if it's
openbsd or windows or what.


svn:r9775
 2007-03-09 08:56:39 +00:00
Roger Dingledine
78cbfcf651 and one more not-really-an-error case 
svn:r9743
 2007-03-06 19:37:18 +00:00
Roger Dingledine
5217d3680e clean up a log message, and stop calling it an error when 
we exit cleanly


svn:r9742
 2007-03-06 19:33:43 +00:00
Nick Mathewson
52713788b4 r12080@catbus: nickm | 2007-03-04 21:40:55 -0500 
Remove dnsworkers and related code. there goes another 550 lines of code.


svn:r9736
 2007-03-05 02:40:58 +00:00
Nick Mathewson
7fcceb2c25 r12074@catbus: nickm | 2007-03-04 15:11:43 -0500 
Make all LD_BUG log messsages get prefixed with "Bug: ".  Remove manually-generated "Bug: "s from log-messages.  (Apparently, we remembered to add them about 40% of the time.)


svn:r9733
 2007-03-04 20:11:46 +00:00
Nick Mathewson
70e5a83a77 r12057@catbus: nickm | 2007-03-04 13:58:32 -0500 
Clarify some log messages; note others that could be improved later.


svn:r9724
 2007-03-04 18:58:38 +00:00
Nick Mathewson
5f9f62daa2 r12053@catbus: nickm | 2007-03-03 16:45:38 -0500 
Remove some XXX012s: leave a check in connection_or_set_identity_digest it costs basically nothing to do on average.  Forget about reinstating the user check on NT Service creation.  Note that a notice message in main.c ("Is something wrong with your network connection?") is really useless.


svn:r9721
 2007-03-03 21:55:31 +00:00
Nick Mathewson
25508347ec r12051@catbus: nickm | 2007-03-03 16:15:52 -0500 
nt_service_is_stopping should not load the NT service library calls: if they are not loaded, we cannot possibly be a service trying to shut own.  Bug found by "norvid" on or-talk.  Also, rename function to something slightly less error-prone.


svn:r9720
 2007-03-03 21:16:07 +00:00
Roger Dingledine
9fd669c339 note another wishlist item for the arma 
svn:r9689
 2007-02-28 20:49:09 +00:00
Nick Mathewson
f38240435a r12001@catbus: nickm | 2007-02-28 15:24:12 -0500 
Try to build without warnings on mingw with verbose warnings on.  First attempt.


svn:r9688
 2007-02-28 20:24:27 +00:00
Roger Dingledine
522a97098b more cleanups; getting closer 
svn:r9655
 2007-02-26 05:36:02 +00:00
Roger Dingledine
d6c21ab8a7 tell the user if we're delaying his newnym request. also, pick 
a different set of fenceposts.


svn:r9647
 2007-02-24 21:21:38 +00:00
Roger Dingledine
50f22e858a doc pedant 
svn:r9634
 2007-02-24 07:50:38 +00:00
Roger Dingledine
9946bb7fbd cosmetic, comment, and todo fixes 
svn:r9627
 2007-02-24 01:12:53 +00:00
Nick Mathewson
b3392559d4 r11873@catbus: nickm | 2007-02-22 01:21:14 -0500 
twiddle signewnym rate-limiting patch so every signal gets handled eventually.  document it in control-spec. add a changelog.


svn:r9615
 2007-02-22 06:21:19 +00:00
Nick Mathewson
fe9224dabc r11872@catbus: nickm | 2007-02-22 01:08:46 -0500 
patch from mwenge: rate-limit newnym.


svn:r9614
 2007-02-22 06:21:16 +00:00
Nick Mathewson
d2893398f6 r11832@catbus: nickm | 2007-02-16 15:31:59 -0500 
Fix 35 remaining DOCDOC comments. Yowza.


svn:r9596
 2007-02-16 20:39:37 +00:00
Nick Mathewson
4a74812c70 r11812@catbus: nickm | 2007-02-14 11:22:08 -0500 
Apply stream_bw patch from Robert Hogan.


svn:r9585
 2007-02-14 16:46:49 +00:00
Nick Mathewson
b16c544509 r11779@catbus: nickm | 2007-02-12 16:52:29 -0500 
Do not try to load advapi32.dll except when the user asks us to do something with NT services.  When we _do_ try, always treat failure to load service functions as an exit-worthy error.  Needs testing. (Fixes bug 389)


svn:r9571
 2007-02-12 21:52:32 +00:00
Nick Mathewson
759c58151e r11775@catbus: nickm | 2007-02-12 16:39:09 -0500 
Update copyright dates.


svn:r9570
 2007-02-12 21:39:53 +00:00
Nick Mathewson
295f6d4e0f r11676@catbus: nickm | 2007-02-07 00:10:00 -0500 
(Hopefully) final changes for 0.1.2.7-alpha: disable checking for whether the user account in question exists on --service install, since that seems to make windows go boom.  We can figure out why later.  Also, let the admin specify a password for the target user.


svn:r9506
 2007-02-07 05:10:58 +00:00
Nick Mathewson
534baec4a1 r11674@catbus: nickm | 2007-02-06 17:00:22 -0500 
Remove a now-bogus assert() from nt_service_command_line(), and change option handling.  (Now that we no longer force a -f, it is possible to have no command-line options for Tor-as-service.)


svn:r9503
 2007-02-06 22:00:25 +00:00
Nick Mathewson
c4faebfa6d r11667@catbus: nickm | 2007-02-06 13:36:18 -0500 
The --service install code can no longer default to adding an -f option for the appdata directory of the current user, since the target user probably will not be able to read it.  Instead, warn the user if no explicit torrc filename is given.


svn:r9502
 2007-02-06 18:36:26 +00:00
Nick Mathewson
0c4ab00658 r11664@catbus: nickm | 2007-02-06 11:55:37 -0500 
More win32 account flumdummery: when LocalService exists, you can't detect it via LookupAccountName.  The only good test is to see whether we're on win2k or earlier.
 Apparently, somebody wouldn't know where to draw the line between implementation and interface if you gave them tracing paper and a copy of Stevens.


svn:r9499
 2007-02-06 16:55:42 +00:00
Roger Dingledine
da5cd33ab8 stop crashing on nt service install; but matt says still not right 
svn:r9496
 2007-02-06 04:58:56 +00:00
Nick Mathewson
e0acb45b86 r11650@catbus: nickm | 2007-02-05 17:02:54 -0500 
Resolve (I hope) remaining nt service compilation issues.


svn:r9489
 2007-02-05 22:02:58 +00:00
Nick Mathewson
d930440ae5 r11648@catbus: nickm | 2007-02-05 16:48:50 -0500 
Fix bugs in last nt services patch: syntax, typename.


svn:r9488
 2007-02-05 21:48:53 +00:00
Nick Mathewson
8b238404de r11646@catbus: nickm | 2007-02-05 16:15:48 -0500 
Make default NT service user be LocalService.  Again, I have no idea if this compiles, let alone if it works.


svn:r9487
 2007-02-05 21:15:52 +00:00
Nick Mathewson
337fdb7eb6 r11643@catbus: nickm | 2007-02-05 15:44:59 -0500 
Fix bug 254, sort of: make the default NT service user NetworkService rather than NULL (system).  Also, add a --user argument to --service install so that admins can override this default: this latter point should take care of most of my objections to NetworkService.  I have no idea whether this even compiles.


svn:r9486
 2007-02-05 20:45:02 +00:00
Nick Mathewson
fefba95363 r11629@catbus: nickm | 2007-02-02 15:06:17 -0500 
Removing the last DOCDOC comment hurt so much that I had to use Doxygen to identify undocumented macros and comments, and add 150 more DOCDOCs to point out where they were.  Oops.  Hey, kids!  Fixing some of these could be your first Tor patch!


svn:r9477
 2007-02-02 20:06:43 +00:00
Nick Mathewson
8507699256 r11624@catbus: nickm | 2007-02-01 13:17:35 -0500 
Note a few questionable bits pointed out by RATS.  (And no, RATS, I'm not about to stop having fixed-sized local buffers for you.  I know how to use them, thankyouverymuch.)


svn:r9474
 2007-02-01 18:33:02 +00:00
Nick Mathewson
84790d059f r9715@catbus: nickm | 2007-01-22 02:51:04 -0500 
Document a few undocumented functions and arguments.


svn:r9385
 2007-01-22 07:51:06 +00:00
Roger Dingledine
bcbd289af5 If our system clock jumps back in time, don't publish a negative 
uptime in the descriptor. Also, don't let the global rate limiting
buckets go absurdly negative.


svn:r9377
 2007-01-21 06:24:05 +00:00
Nick Mathewson
75eca91459 r11786@Kushana: nickm | 2007-01-02 14:32:54 -0500 
Add a comment about a possible refactoring in main.c


svn:r9238
 2007-01-02 20:07:54 +00:00
Nick Mathewson
26c0d6ec58 r11743@Kushana: nickm | 2006-12-28 23:13:21 -0500 
Refactor _connection_controller_force_write back into conncetion_handle_write.  Again, the line count goes down: groovy!


svn:r9208
 2006-12-29 05:06:47 +00:00
Nick Mathewson
d9f1f3533d r11724@Kushana: nickm | 2006-12-28 14:22:35 -0500 
Refactor and unify my-ip-addr-changed logic.  Make change in IP address or in nameservers reset and relaunch DNS hijacking tests.


svn:r9200
 2006-12-28 21:29:20 +00:00
Nick Mathewson
e5f5b96ca6 r11723@Kushana: nickm | 2006-12-28 13:52:48 -0500 
Fix bug 364: check for whether popular hostnames (curently google, yahoo, mit, and slashdot) are getting wildcarded.  If they are, we are probably behind a DNS server that is useless: change our exit policy to reject *:*.


svn:r9199
 2006-12-28 21:29:11 +00:00
Nick Mathewson
3ab84c5f48 r11711@Kushana: nickm | 2006-12-24 21:42:57 -0500 
Stop counting 503s against the total number of failures allowed for a download.


svn:r9190
 2006-12-25 02:47:37 +00:00
Nick Mathewson
a71a5d4bf2 r11706@Kushana: nickm | 2006-12-24 01:50:52 -0500 
Fix 2 bugs in last patch.  (VS has weird ideas about const, and I have weird ideas about block structure.)


svn:r9186
 2006-12-24 06:50:57 +00:00
Nick Mathewson
bae366eff0 r11702@Kushana: nickm | 2006-12-24 01:31:59 -0500 
Patch from Edmanm, slightly modified.  Original change list:
   - Support running the Tor service with a torrc not in the
     same directory as tor.exe (Bug #356) and default to using the torrc
     located in the %appdata%\Tor\ of the user who installed the service
   - Removed the supposedly misleading error message mentioned in Bug #294
   - Fixed some CloseHandle()s that should've been CloseServiceHandle()s
   - Fixed some nt_service_foo() return values to be consistent
   - Resolved some nt_service_foo() DOCDOCs
   - Fixed one trivial typo that I happened to randomly notice
 
 Changes:
   - Make more comments into "imperative" house style.
   - Remove special handling for "-f"; only use --options.
   - Quote all options.
   - Clean up whitespace
 


svn:r9185
 2006-12-24 06:32:24 +00:00
Roger Dingledine
04409f202d reenable write limiting. nick finally convinced me this was 
a smart move.

more todo sub-items remain for it.


svn:r9101
 2006-12-13 07:08:36 +00:00
Nick Mathewson
7c79495137 r11468@Kushana: nickm | 2006-12-07 14:56:57 -0500 
Revise logic used to flush state to disk. Now, we try to batch non-urgent changes so that we do not do too many writes, and we save very-non-urgent changes every once in a rare while, and we never save more than once per second.


svn:r9047
 2006-12-07 20:11:30 +00:00
Nick Mathewson
6c8075d8a0 r11462@Kushana: nickm | 2006-12-07 13:42:21 -0500 
Make bandwidth accounting information get stored to the state file as well as bw_accounting.  Read from the state file if it is more recent than bw_accounting, or if bw_accounting is not there.


svn:r9044
 2006-12-07 18:57:37 +00:00
Nick Mathewson
a91c12f2e7 r9855@Kushana: nickm | 2006-12-04 00:55:09 -0500 
Merge circuit_about_to_close_connection and connection_about_to_close_connection.


svn:r9021
 2006-12-04 05:55:40 +00:00
Roger Dingledine
c5b90daf86 cleanups, bump to 0.1.2.4-alpha 
svn:r9015
 2006-12-02 22:47:46 +00:00
Nick Mathewson
d1fdabf1c7 r9843@Kushana: nickm | 2006-11-30 17:22:25 -0500 
Turn an xxxx0124 into an #ifdef; avoid leaking memory.


svn:r9013
 2006-11-30 22:23:01 +00:00
Nick Mathewson
0f6402f17b r9309@totoro: nickm | 2006-11-13 19:05:41 -0500 
Whitespace fixes, and clean up code from last natd patch.


svn:r8947
 2006-11-14 00:06:45 +00:00
Nick Mathewson
5d7ca19b44 r9465@auth3-479: nickm | 2006-11-01 13:16:21 -0500 
Add some temporary code to count  how many *distinct* router digests we verify.  (I have a sneaking suspicion that the numbers look way way high.)


svn:r8890
 2006-11-01 18:16:44 +00:00
Nick Mathewson
1bf1f9d2fc r9449@Kushana: nickm | 2006-10-31 00:12:02 -0500 
Dump breakdown of PK operations when we get a USR2 signal.  This should help us figure out of we are doing some of them for stupid reasons.


svn:r8881
 2006-10-31 19:17:07 +00:00
Nick Mathewson
3fbb292bff r9389@Kushana: nickm | 2006-10-25 17:46:16 -0400 
Add a CLEARDNSCACHE signal to clear the client-side DNS cache.


svn:r8829
 2006-10-25 21:46:21 +00:00
Nick Mathewson
5c670a186c r9386@Kushana: nickm | 2006-10-25 17:35:38 -0400 
Resolve bug 347: translate v0 controller signal numbers into internal signal numbers; leave v1 signal numbers alone.


svn:r8828
 2006-10-25 21:39:42 +00:00
Roger Dingledine
77c8c0ee51 spec and implement some more status events. start to build 
some conventions.


svn:r8805
 2006-10-23 10:16:43 +00:00
Roger Dingledine
2a1c294717 implement a few status events, so we can make sure they work, 
and so vidalia can start handling them if it wants.


svn:r8802
 2006-10-23 05:51:46 +00:00
Nick Mathewson
b27cb38dee r9307@Kushana: nickm | 2006-10-20 13:53:54 -0400 
Have connection_about_to_close use an end_reason field in edge_connection_t to tell what reason to tell the controller for closing the stream.  Set end_reason in connection_edge_end, connection_mark_unattached_ap, and everwhere we set edge_has_sent_end.  Add a changelog entry.


svn:r8779
 2006-10-20 17:54:48 +00:00
Roger Dingledine
584d598e8a move the 'time jump' warning back to a higher threshold. 
this still occurs on moria sometimes if it's swapping to death.
so be it.


svn:r8725
 2006-10-15 02:32:16 +00:00
Roger Dingledine
86263acf95 Security bugfixes: 
When the user sends a NEWNYM signal, clear the client-side DNS
  cache too. Otherwise we continue to act on previous information.


svn:r8679
 2006-10-09 21:11:50 +00:00
Roger Dingledine
81dd9720f2 whitespace tweaks 
svn:r8677
 2006-10-09 20:54:51 +00:00
Nick Mathewson
829bf4dcd0 r8970@totoro: nickm | 2006-10-09 10:12:53 -0400 
Win32 patch from Matt Edman: fix compilation bugs by casting to int; defining SSIZE_T; defining USE_TWOS_COMPLEMENT in windows orconfig.h; and using the proper names for win32 functions on GetProcAddress. Also fixes bug 295.


svn:r8669
 2006-10-09 15:46:21 +00:00
Roger Dingledine
538c54e376 try dirport reachability testing five times less often. 
it's already so darn thorough per test -- it chews through
like four circuits before giving up.


svn:r8646
 2006-10-08 06:33:02 +00:00
Nick Mathewson
1c01797c16 r8932@totoro: nickm | 2006-10-07 20:29:03 -0400 
Try to make mingw capable of producing a working tor binary for win98: make all NT-service-related functions get lazy-loaded on demand.  I have no idea if this even compiles.


svn:r8643
 2006-10-08 00:33:35 +00:00
Roger Dingledine
1d4bd3990f fetch all the v1 directory stuff way less often. plus, move 
around some housecleaning calls so they still occur often.
are some of these redundant or in the wrong order? there are
so many of them, maybe they should be put into a separate
function that has better documentation.


svn:r8607
 2006-10-06 09:04:11 +00:00
Nick Mathewson
7d366f61cb r9025@Kushana: nickm | 2006-09-29 18:33:13 -0400 
Differentiate more duplicated log entries


svn:r8542
 2006-09-29 22:33:40 +00:00
Nick Mathewson
95132f836a r8750@totoro: nickm | 2006-09-27 20:52:01 -0400 
Fix some warnings on mingw; hopefully this should let us build on mingw without warnings.


svn:r8509
 2006-09-28 00:53:02 +00:00
Nick Mathewson
01f9e97d43 Minor fix: add code to eventdns so it can free memory on shutdown. This should help valgrind and dmalloc freak out less. 
svn:r8503
 2006-09-25 20:38:58 +00:00
Nick Mathewson
52e179b942 Trivial fix to make dmalloc happier: release memory held in static member of escaped(). 
svn:r8502
 2006-09-25 18:46:29 +00:00
Nick Mathewson
7c21dabef1 r8878@Kushana: nickm | 2006-09-21 17:15:47 -0400 
Trivial whitespace cleanups.


svn:r8443
 2006-09-21 21:48:55 +00:00
Nick Mathewson
e4a9b4de4e r8875@Kushana: nickm | 2006-09-21 16:46:28 -0400 
Resolve bug 330: detect ISPs that want to hijack failing DNS requests and basically domain-squat the entire internet.


svn:r8440
 2006-09-21 21:48:22 +00:00
Nick Mathewson
65974f82fa r8839@Kushana: nickm | 2006-09-17 16:11:59 -0400 
Add some client performance XXXXs; try to move some common case tests higher on their decision trees.


svn:r8410
 2006-09-17 20:12:10 +00:00
Roger Dingledine
c22dc94fe6 make my bandwidth exercises actually happen 
svn:r8400
 2006-09-15 05:53:00 +00:00
Peter Palfrader
9d9e31dcf4 r9752@danube: weasel | 2006-09-14 07:06:49 +0200 
Fix some dead code that is on occasion useful


svn:r8389
 2006-09-14 05:07:26 +00:00
Peter Palfrader
984e8f6efb r9736@danube: weasel | 2006-09-14 05:53:06 +0200 
Refactor dirserv_parse_fingerprint_file(fname) into dirserv_load_fingerprint_file():
 There is not need to put together the path to the approved-routers file in more than one place.


svn:r8386
 2006-09-14 04:53:23 +00:00
Mike Chiussi
6ec9c1092a - made configure check if we are building for win32 
- made configure link to required system dll's if building for win32
- added diffs for libevent 1.1b
- forced user to turn off eventdns if win32 is set 
- cleaned up tor_mmap_file()_win32 (not sure if it's stable)
- cleaned up some warnings and typos




svn:r8322
 2006-09-06 01:49:55 +00:00
Roger Dingledine
2499d1db7c and make the comment better, while i'm at it 
svn:r8273
 2006-08-28 19:02:57 +00:00
Roger Dingledine
2a4d5782ef an even better check -- now servers hang up if they can't write 
for a while, and clients hang up if they can't read for a while.


svn:r8272
 2006-08-28 19:00:17 +00:00
Roger Dingledine
f75ef94f27 fix bug found by Adam J. Richter: directory clients shouldn't 
hang up five minutes after they begin. but directory servers
should still hang up after 5 minutes of failing to deliver
any bytes.


svn:r8271
 2006-08-28 18:51:36 +00:00
Nick Mathewson
54ca0387a5 r8608@Kushana: nickm | 2006-08-27 16:57:47 -0400 
Make it possible to change nameserver options while Tor is running.


svn:r8255
 2006-08-28 03:15:55 +00:00
Roger Dingledine
24ad1e06cf i'm guessing nick meant to check the return value of dns_init. 
and revise some log severities to match the convention.


svn:r8234
 2006-08-27 01:41:08 +00:00
Roger Dingledine
9ebaf01096 clean up logging conventions in do_list_fingerprint() 
svn:r8222
 2006-08-24 00:54:18 +00:00
Roger Dingledine
41d8d77c8b tor --verify-config now exits with -1(255) or 0 depending on whether 
the config options are bad or good.


svn:r8221
 2006-08-23 23:45:03 +00:00
Nick Mathewson
0f5bfc1521 r7411@Kushana: nickm | 2006-08-17 19:00:25 -0400 
patch suggested by Karsten Loesing: respond to SIGNAL command before we execute the signal, in case the signal shuts us down.


svn:r7072
 2006-08-17 23:00:32 +00:00
Roger Dingledine
5647e5c7e6 fix typo, add explanatory comment 
svn:r7026
 2006-08-11 07:31:16 +00:00
Nick Mathewson
09a895e222 r7324@Kushana: nickm | 2006-08-10 23:23:15 -0700 
Add more warnings to the list of those we tolerate. Start using GCC attributes more, for better error checking and better code generation.


svn:r7020
 2006-08-11 07:09:17 +00:00
Nick Mathewson
85f381153b r6949@Kushana: nickm | 2006-07-28 10:17:38 -0400 
Shave another 8 bytes from connection_t: turn inbuf_reached_eof into a bit, and lower timestamp_lastempty to or_connection_t


svn:r6934
 2006-07-28 15:11:20 +00:00
Nick Mathewson
5227395aba r6922@Kushana: nickm | 2006-07-26 16:32:24 -0400 
Rename some fields, compress a bitfield, and document some structs and fields


svn:r6919
 2006-07-27 05:03:57 +00:00
Nick Mathewson
ec82db6995 r6909@Kushana: nickm | 2006-07-26 13:05:58 -0400 
Clean up wide lines from last patch.


svn:r6907
 2006-07-26 19:07:37 +00:00
Nick Mathewson
4ff4577beb r6908@Kushana: nickm | 2006-07-26 12:38:52 -0400 
Refactor connection_t into edge, or, dir, control, and base subtypes.  This might save some RAM on busy exit servers, but really matters most in terms of correctness.


svn:r6906
 2006-07-26 19:07:26 +00:00
Roger Dingledine
c9b8458f59 publish a new descriptor after we hup. this is important if our 
config has changed such that we'll want to start advertising our
dirport now, etc.


svn:r6819
 2006-07-23 11:50:03 +00:00
Roger Dingledine
00aefaab6b think harder about my logic 
svn:r6806
 2006-07-22 07:19:11 +00:00
Roger Dingledine
2d6a4d283b i lied, that won't work at all. maybe this will. 
svn:r6805
 2006-07-22 07:15:34 +00:00
Roger Dingledine
444f096d2d more bulletproof reachability testing 
svn:r6804
 2006-07-22 05:29:31 +00:00
Roger Dingledine
2249180b60 bugfix: if you find yourself reachable, then don't ever make any client 
requests (so you stop predicting circuits), then hup, then later your
IP changes, you won't think circuits are working so you won't try to
test reachability, so you won't publish.


svn:r6800
 2006-07-21 07:55:35 +00:00
Nick Mathewson
7fcb267e24 Oh. And apparently, msvc6 doesnt think very much of doing u64-and-double arithmetic either. 
svn:r6785
 2006-07-18 02:24:01 +00:00
Roger Dingledine
42e2057d67 fix some more places where we shouldn't crash if we can't build 
our own descriptor yet.


svn:r6775
 2006-07-17 06:54:28 +00:00
Nick Mathewson
e572d5990c MSVC6 is apparently terrified of unnatural cross-breeding between uint64_t and double, and needs more persuasion than usual to cast one to the other. Issue identified by Frediano Ziglio; patch revised for minimal impact on non-MSVC6 compilers. 
svn:r6768
 2006-07-17 00:39:05 +00:00
Roger Dingledine
05d0b70573 Get rid of the router_retry_connections notion. Now routers no longer 
try to rebuild long-term connections to directory authorities, and
directory authorities no longer try to rebuild long-term connections to
all servers.

We still don't hang up connections in these two cases though -- we need
to look at it more carefully to avoid flapping, and we likely need to
wait til 0.1.1.x is obsolete.


svn:r6712
 2006-07-04 03:31:27 +00:00
Roger Dingledine
4e4cc9aa27 lower the number of seconds before we yell about clock jump. 
and make the yelling only happen if you're a server.


svn:r6625
 2006-06-15 09:03:15 +00:00
Roger Dingledine
0bfef523df simplify the tortls api: we only support being a "server", that 
is, even tor clients do the same sort of handshake.

this has been true for years, so it's best to get rid of the
stale code.


svn:r6557
 2006-06-07 06:10:54 +00:00
Nick Mathewson
853e2d99b6 Add a new warning to our "warn a lot" list: unused parameters. This means we have to explicitly "use" unuseds, but it can catch bugs. (It caught two coding mistakes so far.) 
svn:r6532
 2006-06-04 22:42:13 +00:00
Roger Dingledine
48be472e4f clean up a comment 
svn:r6508
 2006-05-28 16:07:44 +00:00
Roger Dingledine
27624a3024 stop telling people that "tor -h" will help them in any way. 
svn:r6447
 2006-05-08 04:28:49 +00:00
Roger Dingledine
3c86402cc2 petty cleanups 
svn:r6421
 2006-04-25 07:00:04 +00:00
Roger Dingledine
07ff409876 no need to escape the address for our connections -- they are 
always IP addresses.


svn:r6389
 2006-04-16 22:34:00 +00:00
Peter Palfrader
beb9e0721a Stop assuming every authority is a v1 authority 
svn:r6377
 2006-04-10 21:29:29 +00:00
Roger Dingledine
12d461a245 make DirFetchPeriod and StatusFetchPeriod truly obsolete. 
svn:r6373
 2006-04-10 20:16:46 +00:00
Roger Dingledine
6f08d121d9 Refactor and consolidate addr/exit policies into a new policies.c. 
Fix some minor bugs and memory leaks along the way.


svn:r6246
 2006-03-27 02:25:34 +00:00
Roger Dingledine
51a3981d10 stop caching the v1 directory so often. 
svn:r6226
 2006-03-22 06:18:27 +00:00
Roger Dingledine
1db263ac3c stop writing the "router.desc" file, ever. nothing uses it anymore. 
svn:r6224
 2006-03-22 03:45:17 +00:00
Roger Dingledine
a3329036a8 Bugfix: looks like clients since 0.1.1.10-alpha have been 
expiring connections whenever 5 minutes pass and they *do*
have circuits on them.


svn:r6213
 2006-03-21 21:58:00 +00:00
Roger Dingledine
d1d0813cf3 Allow non-printable characters for exit streams (both for 
connecting and for resolving). Now we tolerate applications
that don't follow the RFCs. But continue to block malformed
names at the socks side.


svn:r6193
 2006-03-19 03:55:48 +00:00
Roger Dingledine
903183ea28 if we as a directory mirror don't know of any v1 directory 
authorities, then don't try to cache any v1 directories.


svn:r6162
 2006-03-15 00:10:13 +00:00
Roger Dingledine
499eeced44 when event_add or event_del fail, tell us why. 
svn:r6156
 2006-03-13 19:33:46 +00:00
Nick Mathewson
bd8ffccae7 More cleanups noticed by weasel; also, remove macros that nobody uses. 
svn:r6143
 2006-03-12 23:31:16 +00:00
Nick Mathewson
474c60b743 Cleanup on time-relaqted constants. New conventions: 
1) Surround all constants by (parens), whether we'll be using them
     in a denominator or not.
  2) Express all time periods as products (24*60*60), not as multiplied-out
     constants (86400).
  3) Comments like "(60*60) /* one hour */" are as pointless as comments
     like "c = a + b; /* set c to the sum of a and b */".  Remove them.
  4) All time periods should be #defined constants, not given inline.
  5) All time periods should have doxygen comments.
  6) All time periods, unless specified, are in seconds.  It's not necessary
     to say so.

To summarize, the old (lack of) style would allow:

  #define FOO_RETRY_INTERVAL 60*60 /* one hour (seconds) */
  next_try = now + 3600;

The new style is:

  /** How often do we reattempt foo? */
  #define FOO_RETRY_INTERVAL (60*60)

  next_try = now + RETRY_INTERVAL;


svn:r6142
 2006-03-12 22:48:18 +00:00
Roger Dingledine
ef447507ff a better clean-up 
svn:r6139
 2006-03-12 20:51:02 +00:00
Roger Dingledine
a98b25137c and another fix 
svn:r6138
 2006-03-12 20:48:59 +00:00
Roger Dingledine
e11f900a2a stop printing a log message at every iteration through the 
event loop when holding open a conn for flushing but it
doesn't want to flush any more bytes yet.


svn:r6114
 2006-03-09 06:34:33 +00:00
Roger Dingledine
44107f6ec4 Implement NEWNYM. Nick, did I do a bad thing? 
svn:r6105
 2006-03-09 00:18:16 +00:00
Roger Dingledine
0f39033b9f clean up typo 
svn:r6103
 2006-03-09 00:10:28 +00:00
Peter Palfrader
0bab094d5d Explain why we only expire open connections 
svn:r6015
 2006-02-14 17:30:04 +00:00
Peter Palfrader
84295f9f43 Do not mark connections obsolete before they have done their TLS handshake or are at least 60 seconds old 
svn:r6013
 2006-02-14 04:23:05 +00:00
Roger Dingledine
aa63a84fe1 the things we do for our windows users. 
i hope they appreciate it.


svn:r6004
 2006-02-13 09:37:53 +00:00
Roger Dingledine
5f051574d5 Happy new year! 
svn:r5949
 2006-02-09 05:46:49 +00:00
Roger Dingledine
fd0fcdf17c stop calling it a "libevent poll" -- the word "poll" has 
other meaning in this context that are confusing.


svn:r5936
 2006-02-09 03:09:52 +00:00
Roger Dingledine
555a64e06d as soon as we've fetched some more directory info, that's time 
to think about downloading more server descriptors. this way
we don't have a 10 second pause in initial bootstrapping.


svn:r5916
 2006-02-05 03:42:34 +00:00
Roger Dingledine
a53a73a782 forward-port the part where ordinary users try to fetch directories 
less often. not critical but might as well stay in sync with stable.


svn:r5910
 2006-02-05 01:57:07 +00:00
Roger Dingledine
686508a04a don't try to upload hidden service descriptors until we have 
established a circuit.


svn:r5884
 2006-02-01 02:19:46 +00:00
Roger Dingledine
8fc44169e5 only start testing reachability once we've established a circuit. 
this will make startup on dirservers less noisy.
it may also break things in subtle ways.


svn:r5878
 2006-01-29 01:11:41 +00:00
Roger Dingledine
35f91db15f a slightly more useful message when you get a sighup 
svn:r5869
 2006-01-26 19:11:06 +00:00
Roger Dingledine
de13ddd26f Stop complaining loudly whenever some poor client falls off 
the network before we finish writing to him.


svn:r5850
 2006-01-23 09:23:04 +00:00
Roger Dingledine
54a7285e99 oh hey. we were hanging up on every tor client because he 
was obsolete as soon as he started. big oops.


svn:r5807
 2006-01-11 22:34:07 +00:00
Nick Mathewson
8907391ad6 Fix wide lines 
svn:r5793
 2006-01-11 04:04:42 +00:00
Roger Dingledine
7d1f675c85 entry nodes are now entry guards. 
this is our last easy chance for a wholesale change. heave ho.


svn:r5782
 2006-01-10 22:42:44 +00:00
Roger Dingledine
c8e6003412 balance the reachability testing so a smidgen of it happens 
every 10 seconds. this way we don't try to do 500 tls's at
once every 20 minutes.


svn:r5763
 2006-01-10 07:21:01 +00:00
Roger Dingledine
1dd8ebf615 bugfix: we were leaving open duplicate connections to other ORs 
for a week, rather than closing them once we detect a duplicate.

also, avoid some duplicate mark-for-closes in connection-housekeeping.


svn:r5752
 2006-01-07 03:56:56 +00:00
Roger Dingledine
af54b73985 and get the log arguments right 
svn:r5747
 2006-01-07 01:43:09 +00:00
Roger Dingledine
ba339b8a4d a more correct log message 
svn:r5746
 2006-01-07 01:41:17 +00:00
Roger Dingledine
e9e7dc176c Some tor servers process billions of cells in a matter of days. 
These statistics need to be uint64_t's.


svn:r5686
 2005-12-31 08:09:26 +00:00
Roger Dingledine
dbd7b97eff helper nodes are dead. long live entry nodes. 
(config options EntryNodes and StrictEntryNodes still not
implemented.)


svn:r5673
 2005-12-28 09:07:31 +00:00
Nick Mathewson
d94b9fd7d2 normalize spaces 
svn:r5658
 2005-12-27 04:52:34 +00:00
Peter Palfrader
4bd65f0f98 Keep bandwidth history accross restarts/crashes 
svn:r5637
 2005-12-23 23:56:42 +00:00
Nick Mathewson
6b5fc9d46f Instead of "Network down", say "Is your network connection down?" 
svn:r5607
 2005-12-15 22:10:03 +00:00
Nick Mathewson
ce71b17224 Clean fake_status a bit. Switch from has_fetched_directory to have_minimum_dir_info, and make the latter function smarter. 
svn:r5591
 2005-12-15 20:44:15 +00:00
Nick Mathewson
1af630d32c Bite the bullet and limit all our source lines to 80 characters, the way IBM intended. 
svn:r5582
 2005-12-14 20:40:40 +00:00
Roger Dingledine
58366ffd24 when we changed from log_fn to debug/info/notice/warn/err, 
we screwed up the formatting in wild and unpredictable ways.

fix it before it becomes convention to format logs in wild and
unpredictable ways.

still need to do src/common/ someday.


svn:r5551
 2005-12-10 09:36:26 +00:00
Nick Mathewson
39265dd72e In my private little universe, terminals are still 80 columns. Impose a 160-character-per-line limit; this will creep down. 
svn:r5548
 2005-12-09 05:37:26 +00:00
Roger Dingledine
8730190914 when we're checking reachability, make it clearer in the logs 
what to expect.


svn:r5538
 2005-12-08 21:12:47 +00:00
Nick Mathewson
77a494dd55 Expunge remaining places where we used "tree" to mean "associative array". 
svn:r5490
 2005-12-03 02:21:31 +00:00
Nick Mathewson
a6eb8cd2a0 Move connection_or_remove_from_identity_map() to connection_unlink, but dont remove the other; just make it warn. 
svn:r5470
 2005-11-30 04:28:41 +00:00
Roger Dingledine
f94f4c1686 when event_add or event_del fail, tell us why. 
(nick, do i have my libevent strerror dance moves correct?)


svn:r5462
 2005-11-26 09:37:00 +00:00
Nick Mathewson
652e1899ac "How about 'never'? Does 'never' work for you?" 
Weasel says circuit_get_by_conn is his main timesink.  Most of its
users were just checking whether OR conns had circuits, so add a
circuit count to OR conns, and check that. One was
circuit_about_to_close_conn, which was doing an O(n^2) series of calls
to get all circs on an OR conn, so make an O(n) function for that.
Finally, circuit_get_by_edge_conn was using it as a sanity test that
has been around for a while but never found any actualy insanity, so
kill that.

circuit_get_by_conn is finally dead, which is good, since it was never
sane to begin with.


svn:r5460
 2005-11-26 01:43:57 +00:00
Nick Mathewson
fbf8a8c25f Dump bytes held to store descriptors. 
svn:r5443
 2005-11-23 06:00:58 +00:00
Roger Dingledine
7aae63994f Recover better from TCP connections to Tor servers that are broken but 
don't tell you (it happens!); and rotate TLS connections once a week.

1) If an OR conn becomes more than a week old, make it obsolete.
2) If it's obsolete and empty, kill it.
3) When an OR makes a second connection to you, allow it.
4) If we want to send a new create cell, but the best conn we've
   got is obsolete, and the router is 0.1.1.9-alpha-cvs or later, ask
   for a new conn instead.
5) When we time out on circuit building on the first hop, make that
   connection obsolete.


svn:r5429
 2005-11-19 06:57:44 +00:00
Peter Palfrader
6734371234 15*60 is 15 minutes, not 5 
svn:r5424
 2005-11-18 21:57:49 +00:00
Peter Palfrader
901712ee59 Remove ip address change flapping detection. It is not really needed and I do not think it works quite right. 
svn:r5423
 2005-11-18 19:28:34 +00:00
Nick Mathewson
9b432311c4 Make new logging stuff work on windows; fix a couple of windows typos. 
svn:r5375
 2005-11-15 03:05:23 +00:00
Roger Dingledine
4ea6d71a26 shorten more of the startup log messages 
svn:r5368
 2005-11-14 04:39:49 +00:00
Nick Mathewson
a913cb3536 prevent duplicat mark-for-close 
svn:r5347
 2005-11-04 05:00:12 +00:00
Nick Mathewson
9e82f0cdb7 enable code to remove members of old_routers when it gets big. 
svn:r5345
 2005-11-01 17:34:17 +00:00
Roger Dingledine
bf2be9abd7 Do round-robin writes of at most 16 kB per write. This might 
be more fair on loaded Tor servers, and it might resolve our
Windows crash bug. It might also slow things down.


svn:r5332
 2005-10-29 18:19:37 +00:00
Nick Mathewson
5d85560d9e Remove last vestiges of old logging interface. 
svn:r5317
 2005-10-25 18:01:01 +00:00
Nick Mathewson
e7e170a59e Change more files to new loggin interface. 3 left. 
svn:r5310
 2005-10-25 08:20:10 +00:00
Roger Dingledine
102df4a982 fix some typos 
svn:r5283
 2005-10-18 21:39:00 +00:00
Peter Palfrader
7b15f77dd6 Make a few INFO log lines into DEBUG 
svn:r5257
 2005-10-17 02:13:36 +00:00
Roger Dingledine
ae92a91d96 more log uncluttering 
svn:r5254
 2005-10-17 01:29:28 +00:00
Roger Dingledine
03dcef4c78 start the process of reducing clutter in server logs 
svn:r5253
 2005-10-17 00:35:53 +00:00
Roger Dingledine
aca6fb5f5f cut out a warning that doesn't need to warn 
svn:r5252
 2005-10-16 19:47:01 +00:00
Nick Mathewson
998cf8d622 Try to extract as many descriptors as possible from truncated http responses. (when DIR_PURPOSE_FETCH_ROUTERDESC) 
svn:r5249
 2005-10-14 02:26:13 +00:00
Peter Palfrader
8808b26206 Check if our IP address has changed every 5 minutes. If it has, update our server descriptor, but not too often 
svn:r5246
 2005-10-12 22:41:16 +00:00
Nick Mathewson
a89daaeca9 Once an hour (not just on startup) give OpenSSL some more entropy. 
Add entropy in 512-bit chunks, not 160-bit chunks.  (This latter
change is voodoo.)


svn:r5211
 2005-10-06 22:22:22 +00:00
Nick Mathewson
5cf758764e Rate-limit warnings related to unrecognized MyFamily elements. 
svn:r5204
 2005-10-05 23:20:45 +00:00
Roger Dingledine
f12663a4ce call circuit_expire_all_dirty_circs() on do_hup(). 
there, now we use it.


svn:r5202
 2005-10-05 22:36:33 +00:00
Nick Mathewson
370e4abdc9 replace former relaunches of directory downloads with reset of failure count and relaunch of status downloads. Fix memory leak in trusted_dir_server_t. Reset "last download attempted" time when resetting failure counts. 
svn:r5195
 2005-10-05 05:03:52 +00:00
Roger Dingledine
adf04f121e size_t int printf mucking 
svn:r5194
 2005-10-05 04:52:55 +00:00
Nick Mathewson
96c47c8478 Note the two places where clients will still try to fetch old-style (v1) directory info. These should be fixed, I think. 
svn:r5193
 2005-10-05 02:25:59 +00:00
Nick Mathewson
509de69a7e reset warning flags on SIGHUP. arma: is this everything? 
svn:r5192
 2005-10-05 02:20:46 +00:00
Nick Mathewson
8434595584 Fix verbose compiler warnings, including one in routerlist.c that would have been an actual error. Normalize whitespace. Enforce convention that "address" is a hostname and "addr" is an IPv4 address. 
svn:r5190
 2005-10-05 02:06:36 +00:00
Nick Mathewson
a608905070 Give a less frequent and more helpful warning on failed serverdesc downloads 
svn:r5187
 2005-10-05 00:22:56 +00:00
Nick Mathewson
42e17182da When we get an EOF or a timeout on a directory connection, note how many bytes of serverdesc we are dropping. This will help us determine whether it is smart to parse incomplete serverdesc responses. 
svn:r5186
 2005-10-04 22:34:09 +00:00
Nick Mathewson
c5ee3e961e Reorganize some quick-and-dirty code to find out what openssl stuff is leaking, using dmalloc. 
svn:r5178
 2005-10-03 20:20:38 +00:00
Nick Mathewson
9e54e2e293 free helper node status info on shutdown 
svn:r5177
 2005-09-30 21:38:57 +00:00
Nick Mathewson
23864ad423 Try to hunt down a few more leaks 
svn:r5172
 2005-09-30 21:22:25 +00:00
Nick Mathewson
de198d800b Never call free() on tor_malloc()d memory. This is unlikely to be our current leak, but it may help dmalloc work. 
svn:r5168
 2005-09-30 20:47:58 +00:00
Nick Mathewson
92451f74a8 Reformat inconsistent function declarations. 
svn:r5160
 2005-09-30 01:09:52 +00:00
Roger Dingledine
f8d430653e better cleanups as i figure out what's going on 
svn:r5154
 2005-09-29 23:26:42 +00:00
Nick Mathewson
06625e779d Decouple router downloads from old directory downloads entirely 
svn:r5128
 2005-09-23 18:49:37 +00:00
Nick Mathewson
c345dab3bd Fix logic error (people who ask authorities should never split; others should always split). Also, fix timing error in main.c so retries really happen. 
svn:r5127
 2005-09-23 18:17:37 +00:00
Nick Mathewson
f995edd516 Fix at least one overzealous download bug. (tor_malloc_zero new local_routerstatus_t objs); add a pile of logs back in; probe every 10sec; never autolaunch on failure. Let us see if this works better. 
svn:r5125
 2005-09-23 18:05:14 +00:00
Nick Mathewson
cdc912714e I love the smell of C in the morning. Make router-download rules smarter (download more so long as we dont duplicate existing requests; relaunch at staggered intervals); relaunch one a minute or on failure; reset 60 minutes; always open 3 requests if we can; add authority opinion to networkstatus; make naming rule correct. There is a remaining bug where we retry servers too quickly; We need to look at that harder. 
svn:r5110
 2005-09-22 06:34:29 +00:00
Nick Mathewson
87f6d526fe Refactor new directory code a bit. Keep a big list of rolled-up router status info, including # of download failures (not yet used). Update this list from networkstatuses when they arrive, then update routers from this list. Only download 128 routers at a time, to avoid gargantuan URLs. 
svn:r5089
 2005-09-18 02:24:42 +00:00
Nick Mathewson
6d15a73548 Resolve/expand some XXXXs and improve a log message or two 
svn:r5082
 2005-09-16 16:41:45 +00:00
Nick Mathewson
b70c229f6e make some functions static; clean dead networkstatus entries more often. 
svn:r5072
 2005-09-15 05:41:30 +00:00
Nick Mathewson
b16048917c Stop downloading directories and download routers instead. This still needs some work, but at last clients are finally on the new architecture. Next comes the tuning and bugfixing. 
svn:r5070
 2005-09-15 05:19:38 +00:00
Nick Mathewson
d4e0af7822 Fix a bunch of log messages. Deprecate some routerlist fields; remove others, and status_set_at from routerinfo_t. Compress routerlist.c cleanup functions. Update cached networkstatus mtime when we download the same one twice. Change some interfaces. 
svn:r5068
 2005-09-14 23:42:06 +00:00
Nick Mathewson
e3adcbdb95 Big commit: clients start downloading and using network-statuses. 
Only caches need to get running-routers; nobody needs to parse, store,
or use it.  Same for the router-status line in the directories.  Add
many #if 0's that can get removed once I'm convinced they don't
contain anything I'm forgetting.

Start all newly-parsed routers as non-running and non-valid; update
them from the list of network statuses.

Update all routers when a new networkstatus comes in.

After 3 tries for a networkstatus, clients give up until they're told
to try again.

     "Let's get those missles ready to **DESTROY THE UNIVERSE**!"
				-TMBG


svn:r5063
 2005-09-14 21:09:25 +00:00
Nick Mathewson
7c6679d8dc Add new config.c function to set options that can fail, and roll back if they do. This should solve the setconf-an-impossible-port bug. 
svn:r5046
 2005-09-14 02:36:29 +00:00
Nick Mathewson
059148f588 Only caches download network-status for now, and they use a different strategy. Add an element to connection_t to remember what we are downloading, and a function to recognize our own fingerprint. 
svn:r4944
 2005-09-08 20:18:15 +00:00
Nick Mathewson
f50ddfd4dd Download network-status at regular intervals. The code is probably iffy, and the constants need to be renamed. 
svn:r4921
 2005-09-08 06:22:44 +00:00
Nick Mathewson
5c6c88e76d More stuff for new directories. 
- Distinguish v1 authorities (all currently trusted directories) from
  v2 authorities (all trusted directories).
    - Add configuration option for which dirs are v1 authories.
    - Add configuration option for whether to be a v1 authority.
    - Make trusted dirserver selection functions take options to
      choose which functionality we need.
    - Remove option when getting directory cache to see whether they
      support running-routers; they all do now.  Replace it with one
      to see whether caches support v2 stuff.

- Parse, cache, and serve network-status objects properly.

- Serve compressed groups of router descriptors.  The compression logic
  here could be more memory-efficient.

-


svn:r4911
 2005-09-07 16:42:53 +00:00
Roger Dingledine
33b2abbc90 remove redundant logs about unreachable servers 
svn:r4905
 2005-09-03 04:37:30 +00:00
Nick Mathewson
0e649ac60a Remove descriptor_list and use routerlist instead. Make directories manage routerlist a little better. 
svn:r4854
 2005-08-26 20:59:04 +00:00
Nick Mathewson
cf90a36dd1 Add quotes around filenames in src/or 
svn:r4845
 2005-08-26 18:44:26 +00:00
Roger Dingledine
86f85f240c be much more conservative about logging reachability complaints. 
the ones it logs now are probably genuine problem servers.


svn:r4832
 2005-08-24 14:31:32 +00:00
Roger Dingledine
a120cc20c1 Dirservers now do their own external reachability testing of each 
Tor server, and only list them as running if they've been found to
be reachable.

Dirservers also log trouble servers, but only start complaining loudly
after they've been up for an hour, to reduce false positives. We still
need to do something about the fact that it is quite loud when there
are many trouble servers.


svn:r4829
 2005-08-24 02:31:02 +00:00
Roger Dingledine
675f6b5f3c that comma was important 
svn:r4820
 2005-08-23 01:00:30 +00:00
Roger Dingledine
ab112ca6ad and don't print the null string here either 
svn:r4816
 2005-08-22 22:59:54 +00:00
Roger Dingledine
676b330eb2 Make DirPostPeriod config option obsolete. 
Force new descriptor upload every 18 hours, not 24, to avoid races.
Change rate-limiting on new descriptors due to bandwidth changes, from
45 minutes to 20 minutes.


svn:r4814
 2005-08-22 21:53:12 +00:00
Roger Dingledine
d928411acd change log entry for unreachability to explicitly suggest /etc/hosts 
as the culprit


svn:r4807
 2005-08-22 05:33:49 +00:00
Nick Mathewson
dc09c7fc73 Implement new (reduced-frequency) upload rules. arma, you should review this. 
svn:r4806
 2005-08-22 03:10:53 +00:00
Roger Dingledine
04d42ea433 rotate dns and cpu workers if the controller changes options that 
will affect them.


svn:r4787
 2005-08-15 23:46:18 +00:00
Roger Dingledine
10ff723938 initialize the dns worker cache tree whether or not we start 
out as a server.


svn:r4785
 2005-08-15 10:27:37 +00:00
Nick Mathewson
299af3d393 Possibly broken implementation of persistant state; handles helper nodes; does not handle accounting info yet. 
svn:r4680
 2005-07-28 19:01:48 +00:00
Roger Dingledine
a32f936346 whoops, fix compile 
svn:r4674
 2005-07-25 10:36:01 +00:00
Roger Dingledine
1e0fdcae98 parameterize RephistTrackTime 
svn:r4673
 2005-07-25 10:29:21 +00:00
Nick Mathewson
2bd6040f62 Rename cross-format config.c stuff to config_* and or_options_t-specific stuff to option[s]_* 
svn:r4641
 2005-07-23 01:58:05 +00:00
Roger Dingledine
5fe18894b9 now that we're recommending 0.1.1.x-alpha for win32 and os x users, 
stop printing debug stuff once a minute


svn:r4596
 2005-07-18 19:16:17 +00:00
Roger Dingledine
e8a1b1d6a0 add a trivial tor-counting variable 
svn:r4593
 2005-07-18 06:09:04 +00:00
Nick Mathewson
441e02d4ac Merge patch from Matt Edman for bug 162 (service never stops) 
svn:r4578
 2005-07-15 19:09:36 +00:00
Roger Dingledine
306f7d320c make a notice-level log make more sense. 
svn:r4547
 2005-07-13 21:12:33 +00:00
Nick Mathewson
cf13b3e4a6 Macro-fu to get DEBUG events working. 
svn:r4539
 2005-07-13 05:14:42 +00:00
Nick Mathewson
e1db33971e NT service patch from Matt Edman to improve error messages, lightly cleaned; needs more testing. 
svn:r4527
 2005-07-09 16:37:12 +00:00
Roger Dingledine
2f1f0c8d21 be flexible in what you accept: when people type "tor --install" thinking 
they had typed "tor -install", make it work too.


svn:r4526
 2005-07-09 03:28:58 +00:00
Nick Mathewson
806da0d8b2 Compile on win32 
svn:r4496
 2005-06-27 23:35:04 +00:00
Nick Mathewson
2aff87caae Load hardware acceleration options when/where available. Can anybody test this? 
svn:r4467
 2005-06-20 18:56:35 +00:00
Nick Mathewson
5eef9177c5 Appease verbose GCC warnings. 
svn:r4466
 2005-06-20 09:38:29 +00:00
Roger Dingledine
b5fd75a063 forward-port the --hash-password bug, plus other nearby fixes 
svn:r4459
 2005-06-19 08:35:46 +00:00
Nick Mathewson
9b4aa8d2ab Implement all the easy bits of the new control protocol 
svn:r4449
 2005-06-17 20:37:21 +00:00
Nick Mathewson
2b8fd9ceda Allow a few EINVALs from libevent before dying. Warn on kqueue with libevent before 1.1a 
svn:r4419
 2005-06-13 00:35:19 +00:00
Nick Mathewson
232861ba42 Docment or add DOCDOC comments to undocumented functions in src/or. Make function definition format uniform. 
svn:r4411
 2005-06-11 18:52:12 +00:00
Roger Dingledine
fcd0fc3364 flesh out the source file descriptions for doxygen 
svn:r4404
 2005-06-11 05:31:17 +00:00
Nick Mathewson
0831823763 Change end-of-file NLNL convention. It turns out arma I and I agree. 
svn:r4382
 2005-06-09 19:03:31 +00:00
Nick Mathewson
a6f51001a5 New whitespace normalization rule: no blank line at EOF. 
svn:r4378
 2005-06-09 16:46:51 +00:00
Roger Dingledine
eeb6d6dba6 dump periodic memory usage stats 
svn:r4348
 2005-06-08 17:24:58 +00:00
Roger Dingledine
aff308e6d9 reenable the part of the code that tries to flush as soon as an OR outbuf 
has a full tls record available. perhaps this will make OR outbufs not grow
as huge except in rare cases, thus saving lots of cpu time plus memory.


svn:r4343
 2005-06-08 04:55:06 +00:00
Roger Dingledine
1a5c5452b4 when you send a USR2 signal, the log message now tells you to send 
a HUP signal if you want to change back to old log levels.


svn:r4332
 2005-06-07 18:16:14 +00:00
Nick Mathewson
2118e5798a Use correct errno from libevent on win32 
svn:r4327
 2005-06-07 17:32:33 +00:00
Nick Mathewson
e1c8aa8035 Fix win32 compilation: backport candidate 
svn:r4320
 2005-06-06 20:06:10 +00:00
Nick Mathewson
fc40f974c2 When RNG seeding fails, die. Backport candidate 
svn:r4319
 2005-06-06 20:02:33 +00:00
Nick Mathewson
baa10cbbfa Instrument buffers.c and rephist.c memory usage 
svn:r4317
 2005-06-06 17:03:21 +00:00
Roger Dingledine
4855990d37 clean up a few more log entries 
svn:r4304
 2005-05-27 17:43:43 +00:00
Roger Dingledine
bfc7838b97 downgrade the 'caught sigpipe' notice. 
we're going to pretend like all of these are fine.


svn:r4301
 2005-05-25 02:20:15 +00:00
Roger Dingledine
4f0d7b82ae make lucky's weird libevent poll einprogress bug just warn, not kill tor. 
svn:r4300
 2005-05-24 22:58:57 +00:00
Nick Mathewson
d2cdae221d Fix not-freed-on-exit event 
svn:r4298
 2005-05-24 17:13:15 +00:00
Roger Dingledine
5005f682ae Bugfix: we were checking to see if you want to send a keepalive, based 
on five minutes since last successful write. But if you have bytes queued
already, and they're not getting through, we were adding a new keepalive
every second. This was bad.


svn:r4296
 2005-05-23 22:20:54 +00:00
Roger Dingledine
040a748d87 i screwed up the dirport reachability testing when we don't yet 
have a cached version of the directory. hopefully now fixed.


svn:r4284
 2005-05-23 05:20:52 +00:00
Nick Mathewson
11a64692c3 Make hashed controller password encoding use hex not base64; this makes it possible to write a controller without base64 
svn:r4279
 2005-05-23 02:31:53 +00:00
Roger Dingledine
c95677725a a note for nick about other memory not freed at exit 
svn:r4275
 2005-05-20 22:11:46 +00:00
Roger Dingledine
2812d4a08c free some memory that is still reachable on exit 
svn:r4234
 2005-05-16 10:32:10 +00:00
Roger Dingledine
28195a0eb1 clean up some log entries 
svn:r4228
 2005-05-15 05:00:24 +00:00
Roger Dingledine
b92a77b1d2 move the periodic buffer shrinking interval from 3 mins to 1 min 
svn:r4204
 2005-05-14 01:11:45 +00:00
Nick Mathewson
bc51c8b074 Implement --verify-config command-line option to fix bug 69. 
svn:r4182
 2005-05-07 04:49:09 +00:00
Roger Dingledine
cc0b19888d log buffer sizes on kill -usr1 too. 
svn:r4180
 2005-05-06 08:32:37 +00:00
Roger Dingledine
5265bbd2b8 first iteration of scrubbing sensitive strings from logs. 
also generally clean up log messages.


svn:r4174
 2005-05-03 10:04:08 +00:00
Nick Mathewson
b35f7dacef Call tor_free_all instead of connections_free_all after forking 
svn:r4173
 2005-05-03 03:51:20 +00:00
Nick Mathewson
a312ce1d3b Change buffer shrinking strategy: only try to shrink once every 3 minutes. Do not try to read over buffer size unless buffer is nearly empty. 
svn:r4165
 2005-05-02 23:17:08 +00:00
Roger Dingledine
509405a5f7 clean up this TOR_FRAGILE business 
svn:r4116
 2005-04-26 18:52:16 +00:00
Roger Dingledine
4fafa81f32 help debug: when we close a conn due to timeout, tell us its 
file descriptor, not its connectionarray index.


svn:r4113
 2005-04-25 17:24:16 +00:00
Nick Mathewson
cf84759b4b zero-out errno before calling event_dispatch, just in case we have misdiagnosed poll(2)/EINVAL bug. 
svn:r4081
 2005-04-17 22:38:39 +00:00
Roger Dingledine
e2cdc87485 remove some redundant code 
svn:r4062
 2005-04-08 06:16:09 +00:00
Nick Mathewson
b897cb1ec3 Change conn_(type|state)_to_string from const arrays to switch functions so we (I) will not make Tor crash the next time we (I) add a new state. 
svn:r4045
 2005-04-07 20:25:22 +00:00
Roger Dingledine
46089c49c4 blow away most calls to assert_all_pending_dns_resolves_ok, since 
they're eating our cpu.


svn:r4034
 2005-04-06 20:05:34 +00:00
Roger Dingledine
9cbaf4603d fix an assert trigger: when we have the rare case of accepting 
a conn on 0.0.0.0:0, then when we look through the connection array,
we'll find any of the workers. this is no good.


svn:r4027
 2005-04-06 15:19:32 +00:00
Nick Mathewson
055ee7c323 Give better warnings if connection_close_unattached_ap gets called twice or called on a marked connection; rename it to connection_mark_unattached_ap. 
svn:r3990
 2005-04-02 22:11:24 +00:00
Nick Mathewson
0e81265359 update copyright notices. 
svn:r3982
 2005-04-01 20:15:56 +00:00
Nick Mathewson
efe9ca659a Use recent libevent features when possible 
svn:r3940
 2005-04-01 02:37:40 +00:00
Roger Dingledine
1f5c8335e8 still publish your descriptor if orport is reachable but dirport isn't 
when building testing circs for orport testing, require high-bandwidth
nodes, so fewer circs fail. complain about unreachable orport separately
from unreachable dirport.


svn:r3935
 2005-03-31 19:26:33 +00:00
Roger Dingledine
20a8eda31b don't check for reachability, and don't whine about it, while we're 
hibernating.


svn:r3919
 2005-03-29 03:48:31 +00:00
Roger Dingledine
9b5432214d but only do the rapid reachability testing if we're hoping to be a server. 
svn:r3902
 2005-03-27 11:52:15 +00:00
Roger Dingledine
92acd64da0 if your server hasn't found itself to be reachable, complain every 
20 minutes, not just once.


svn:r3897
 2005-03-27 06:50:36 +00:00
Roger Dingledine
7a79acd9f6 clean up socks reply stuff more. 
add a few more reasons so we can be more informative.


svn:r3895
 2005-03-27 06:37:56 +00:00
Roger Dingledine
36baf7219d stop most cases of hanging up on a socks connection without sending 
the socks reject. audit for remaining ones. also make things more
uniform so we always remember to hold-open-until-flushed, etc.


svn:r3891
 2005-03-27 04:55:13 +00:00
Roger Dingledine
b8d38dc57b try harder to establish reachability, in the first 20 minutes 
of uptime.


svn:r3884
 2005-03-26 05:54:50 +00:00
Roger Dingledine
1328383482 make it clearer to the human that his server is testing 
its reachability. tell him when it succeeds, or when 20
minutes pass and it hasn't succeeded yet.


svn:r3882
 2005-03-26 01:43:39 +00:00
Roger Dingledine
570da8a8e8 and fill in another missing socks reply 
svn:r3877
 2005-03-25 11:23:03 +00:00
Roger Dingledine
8945df8daa remove dead code 
svn:r3875
 2005-03-25 10:55:49 +00:00
Nick Mathewson
4ee6addf57 Fix bug 44: on HUP, if descriptor building fails (say, because router_get_my_address() fails), use old descriptor and warn. 
svn:r3839
 2005-03-23 20:28:40 +00:00
Roger Dingledine
21b1adefbb fix a 32bit/64bit sprintf mixup that weasel pointed out 
svn:r3823
 2005-03-22 23:27:29 +00:00
Nick Mathewson
ab1d0049a2 Prevent spurious closes when we put stuff on a conn that has not written for a while. 
svn:r3816
 2005-03-22 20:25:51 +00:00
Roger Dingledine
8a763b5ae3 cleanup and a question 
svn:r3815
 2005-03-22 20:04:00 +00:00
Nick Mathewson
2d662bf773 Clear up a couple of pedantic compiler warnings 
svn:r3812
 2005-03-22 18:56:11 +00:00
Nick Mathewson
c4470cbedf be more explicit about why we are expiring a conn; improve logic a bit too 
svn:r3808
 2005-03-22 06:21:35 +00:00
Roger Dingledine
4a497e5030 if our clock jumps forward by 100 seconds or more, assume something 
has gone wrong with our network and abandon all not-yet-used circs.


svn:r3792
 2005-03-19 23:58:42 +00:00
Roger Dingledine
856ab90ca8 stop logging at -l notice every single time a create cell successfully 
gets processed


svn:r3791
 2005-03-19 23:04:15 +00:00
Nick Mathewson
b004eda10c Enable NT service code by default 
svn:r3780
 2005-03-19 01:04:05 +00:00
Nick Mathewson
df9c8feac7 Commit fixes for several pending tor core tasks: document all DOCDOCed functions; time out uncontrolled unattached streams; feed reasons to SOCKS5 (refactoring connection_ap_handshake_socks_reply in the process); change DirFetchPeriod/StatusFetchPeriod to have a special "Be smart" value. 
svn:r3769
 2005-03-17 12:38:37 +00:00
Nick Mathewson
0197b47ce9 Fix some more obscure compiler warnings 
svn:r3758
 2005-03-14 03:28:46 +00:00
Nick Mathewson
97dad670ea Renormalize whitespace 
svn:r3757
 2005-03-14 03:18:35 +00:00
Nick Mathewson
777d3dde0c Get address map resetting implemented. 
svn:r3745
 2005-03-11 21:39:39 +00:00
Nick Mathewson
e14f812a67 Still more code to make sure we send the right number and kind of RELAY END cells 
svn:r3723
 2005-03-02 03:13:05 +00:00
Nick Mathewson
349ee1abea Clean up rend cache on shutdown 
svn:r3714
 2005-02-28 22:38:00 +00:00
Nick Mathewson
97bc49bd72 Try a little harder to avoid openssl SSL* double-free reports. 
svn:r3710
 2005-02-28 02:52:51 +00:00
Roger Dingledine
b3177d509e free some more memory at shutdown 
svn:r3707
 2005-02-28 01:59:18 +00:00
Roger Dingledine
a1f1fa6ab2 Checkpoint in-progress fixes: 
Add 'testing' circuit purpose, for reachability testing.
Notice when our IP changes, and reset stats.
Try to pull down a directory via Tor to see if our DirPort is working.
Try to extend a circuit back to us to see if our ORPort is working.
Only publish a descriptor if they're both reachable.

These mostly work, and I'd better get them in before I cause conflicts.


svn:r3703
 2005-02-27 09:47:01 +00:00
Nick Mathewson
26e6eb7539 Check returns from libevent calls better; stop poking at internals of events to see if they are live. 
svn:r3691
 2005-02-25 05:42:01 +00:00
Nick Mathewson
2ff6cfccd6 Forward-port fix to make dual-purpose NT executable work. 
svn:r3665
 2005-02-23 05:34:25 +00:00
Roger Dingledine
55c3f15ed1 Forward-port the trick to bump up ConnLimit as far as it can 
go, but not past MAXCONNECTIONS. Also throw away the FAKE_POLL
caveats since 0.1.0 doesn't need it any more.


svn:r3657
 2005-02-22 23:52:44 +00:00
Nick Mathewson
1a55422006 Fix windows build: juggle }s and #endifs around in main.c 
svn:r3645
 2005-02-22 02:57:43 +00:00
Roger Dingledine
8727acf2f1 Add a new AddressMap directive to rewrite incoming socks addresses. 
Add a new TrackHostExits directive to trigger addressmaps for
certain incoming socks addresses, for sites that break when your exit
keeps changing.
Redo the client-side dns cache so it's just an addressmap too.


svn:r3641
 2005-02-22 00:53:08 +00:00
Nick Mathewson
5d836c8140 Free tls resources on exit too 
svn:r3615
 2005-02-11 01:41:19 +00:00
Nick Mathewson
f672577bc6 Free even more things on shutdown. Temporarily move tor_free_all out from #ifdef so it gets tested more. 
svn:r3614
 2005-02-11 01:26:47 +00:00
Nick Mathewson
60f234f42b Add more functions to free things to help dmalloc allong. 
svn:r3613
 2005-02-10 23:18:39 +00:00
Roger Dingledine
c5c46d6fb6 don't list version in the win32 service display name or service name, 
since they'll keep changing and people will get messed up about which
one is installed.


svn:r3592
 2005-02-09 02:26:24 +00:00
Nick Mathewson
bb32fa86d7 Re-normalize whitespace; make "make check-spaces" happy 
svn:r3566
 2005-02-05 21:42:46 +00:00
Nick Mathewson
24ad6542c9 forward-port NT service patch 
svn:r3565
 2005-02-05 21:40:25 +00:00
Roger Dingledine
bcece3d8a7 another minor fix 
svn:r3511
 2005-02-03 07:30:00 +00:00
Peter Palfrader
ddd724ef94 Add --with-dmalloc configure option 
svn:r3508
 2005-02-03 07:25:10 +00:00
Peter Palfrader
dfa3a0220f Write a function header for Roger so he can fill it with life 
svn:r3507
 2005-02-03 07:23:48 +00:00
Roger Dingledine
0f5a198028 sometimes, a conn on the closeable_lst gets absolutely 
clobbered. maybe this will help me find out why.


svn:r3498
 2005-02-02 00:19:09 +00:00
Roger Dingledine
2e97593d25 define TOR_FRAGILE if you want tor to give you a core when 
something goes wrong. this should only be used by people actively
tracking bugs.


svn:r3487
 2005-02-01 00:37:16 +00:00
Roger Dingledine
d6489d8e41 lay a trap for situations where we connection_free something 
that's still on one of the lists.

in particular, this will detect situations where we mark-for-close
and then free it ourselves.


svn:r3475
 2005-01-31 00:33:32 +00:00
Roger Dingledine
75b45bcd4d stop the infinite loop of freeing the same connection_t over and 
over when it's not linked into the connection_array


svn:r3474
 2005-01-31 00:26:09 +00:00
Roger Dingledine
3969b6066e Stop crashing when we're asking to close_if_marked a conn that 
hasn't been connection_added yet. This happens when an exit conn
is in dns_wait and we get a relay end cell for it before it finishes.

We were silently leaking each of these marked conns in 0.0.9.x. Now
we actually free them.


svn:r3470
 2005-01-30 21:47:47 +00:00
Roger Dingledine
7ddeb7fae7 try to find the corrupt closeable_connection_lst entry early 
svn:r3468
 2005-01-30 20:31:08 +00:00
Roger Dingledine
8e7fc8d259 comment about a bug wrt clock skew 
svn:r3461
 2005-01-30 00:07:31 +00:00
Roger Dingledine
b2fbd834f0 forward-port the dns and maxconn fixes 
svn:r3448
 2005-01-28 08:53:47 +00:00
Nick Mathewson
e03f571ee3 Forward-port win32 service patch; try to clean it a touch. 
svn:r3438
 2005-01-27 21:45:32 +00:00
Nick Mathewson
6704093c0d Appease another 64-bit warning 
svn:r3392
 2005-01-20 20:21:34 +00:00
Nick Mathewson
5b45527851 Appease weasel's paranoid 64-bit compiler. 
svn:r3389
 2005-01-20 20:16:48 +00:00
Roger Dingledine
d2400a5afd Introduce a notion of 'internal' circs, which are chosen without regard 
to the exit policy of the last hop. Intro and rendezvous circs must
be internal circs, to avoid leaking information. Resolve and connect
streams can use internal circs if they want.

New circuit pooling algorithm: make sure to have enough circs around
to satisfy any predicted ports, and also make sure to have 2 internal
circs around if we've required internal circs lately (with high uptime
if we've seen that lately).

Split NewCircuitPeriod config option into NewCircuitPeriod (30 secs),
which describes how often we retry making new circuits if current ones
are dirty, and MaxCircuitDirtiness (10 mins), which describes how long
we're willing to make use of an already-dirty circuit.

Once rendezvous circuits are established, keep using the same circuit as
long as you attach a new stream to it at least every 10 minutes. (So web
browsing doesn't require you to build new rend circs every 30 seconds.)

Cannibalize GENERAL circs to be C_REND, C_INTRO, S_INTRO, and S_REND
circ as necessary, if there are any completed ones lying around when
we try to launch one.

Re-instate the ifdef's to use version-0 style introduce cells, since
there was yet another bug in handling version-1 style. We'll try switching
over again after 0.0.9 is obsolete.

Bugfix: when choosing an exit node for a new non-internal circ, don't take
into account whether it'll be useful for any pending x.onion addresses --
it won't.

Bugfix: we weren't actually publishing the hidden service descriptor when
it became dirty. So we only published it every 20 minutes or so, which
means when you first start your Tor, the hidden service will seem broken.


svn:r3360
 2005-01-17 18:13:09 +00:00
Nick Mathewson
a38bccdca7 Move call to event_init() immediately after start_daemon(); move start_daemon earlier. This should fix using libevent with RunAsDaemon. 
svn:r3354
 2005-01-13 21:32:08 +00:00
Roger Dingledine
abea142665 more cleanup 
svn:r3347
 2005-01-12 12:22:25 +00:00
Roger Dingledine
24a97d2c55 fix up some comments 
svn:r3345
 2005-01-12 12:18:46 +00:00
Roger Dingledine
3809c0ab91 tolerate bandwidtch buckets going negative (i hope) 
svn:r3344
 2005-01-12 10:00:38 +00:00
Nick Mathewson
324b192f68 Make Tor use Niels Provos's libevent instead of it's current 
poll-but-sometimes-select mess.  This will let us use faster async cores
(like epoll, kpoll, and /dev/poll), and hopefully work better on Windows
too.

There are some fairly nasty changes to main.c here; this will almost
certainly break something.  But hey, that's what alphas are for.


svn:r3341
 2005-01-12 06:42:32 +00:00
Roger Dingledine
70b3208f0a if somebody starts his tor server in jan 2004 and then fixes his 
clock, don't make his published uptime be a year.


svn:r3337
 2005-01-11 11:54:11 +00:00
Roger Dingledine
4b6d55afdf separate time_of_process_start from stats_n_seconds_uptime: 
now we reset uptime when a dir fetch entirely fails. this
hopefully has something to do with stability of being on the
network.


svn:r3333
 2005-01-10 05:10:22 +00:00
Roger Dingledine
3370f53010 it helps to use the correct name for the struct 
svn:r3331
 2005-01-10 04:32:59 +00:00
Roger Dingledine
10a81ccf18 when pruning circuit-wait streams when a dir fetch failed, 
refer in logs to the destination address, not the address of the
application connection.


svn:r3330
 2005-01-10 02:47:50 +00:00
Roger Dingledine
f468ff04ea when we haven't fetched a directory yet, or the last time we 
tried they were all unreachable, assume we are not connected to
the network.

when an application request comes in during this state, be
optimistic and assume we just reconnected. fetch a new directory
and if it works, begin making circuits.


svn:r3327
 2005-01-07 15:57:57 +00:00
Roger Dingledine
f8b517fa97 finish marking my comment in main.c 
svn:r3318
 2005-01-06 19:20:54 +00:00
Roger Dingledine
1f51809e65 clean up string printing in relay logs 
svn:r3317
 2005-01-06 19:19:13 +00:00
Nick Mathewson
dcd228585d Implement SIGNAL control command. 
svn:r3307
 2005-01-05 06:40:47 +00:00
Nick Mathewson
0c4186d6ee Use correct logic to decide whether there are more directory servers to retry. 
svn:r3257
 2005-01-03 20:51:24 +00:00
Roger Dingledine
e1ac30c2bb stop calling assert_connection_ok(conn, time(NULL)) on every single 
conn on every single loop.


svn:r3229
 2004-12-25 06:43:40 +00:00
Roger Dingledine
288f2ed59e stop telling win32 folks they have a bug just because we haven't finished 
making tor work on win32 yet.


svn:r3227
 2004-12-25 06:42:15 +00:00
Roger Dingledine
cf17d0d29c move network_init from or/main to common/compat 
call network_init in tor-resolve.c too
move tor_lookup_hostname from common/util to common/compat


svn:r3203
 2004-12-22 05:29:06 +00:00
Roger Dingledine
036384fd8e respond to an 009 XXX 
svn:r3201
 2004-12-22 02:55:26 +00:00
Nick Mathewson
e327b2f3a6 Clarify confusing message 
svn:r3151
 2004-12-16 05:23:48 +00:00
Roger Dingledine
a8582ae223 note a future thing we should do 
svn:r3141
 2004-12-13 01:30:41 +00:00
Roger Dingledine
011ad3cba5 clean up logging, 
make it clearer which warns are bugs,
make the control log event match its specification,
point out a bug in how we deal with failure when renewing the tls context.


svn:r3138
 2004-12-13 00:44:39 +00:00
Nick Mathewson
972124aab9 Only launch dns workers when we are actually starting a server. 
svn:r3137
 2004-12-13 00:09:00 +00:00
Roger Dingledine
29a8e80326 log bytes written with kill -USR1 too 
svn:r3112
 2004-12-07 16:50:47 +00:00
Roger Dingledine
41b809d2aa salvage another 300 bytes per hup 
svn:r3106
 2004-12-07 09:11:38 +00:00
Nick Mathewson
ac759adb43 Make unit tests work on win32 
svn:r3094
 2004-12-07 05:31:38 +00:00
Nick Mathewson
b457cfb5eb Spell-check strings and comments 
svn:r3052
 2004-12-01 03:48:14 +00:00
Roger Dingledine
bde1d5bfb2 do even less inside our signal handler, 
just to be extra paranoidly safe


svn:r3050
 2004-12-01 02:54:13 +00:00
Roger Dingledine
1d4af1930c Let resolve conns retry/expire also, rather than sticking around forever. 
Put the check-if-requested-exitrouter-will-reject-us code in the
circuit_attach loop, so it gets checked periodically and not just
once at the beginning. This is useful in case the routerlist changes,
but also in case the address gets resolved into something that we learn
we'll reject.


svn:r3039
 2004-11-30 08:39:14 +00:00
Nick Mathewson
7fbd297532 Suggestion from weasel: Make tor --version --version dump the cvs Id of every file. 
svn:r3019
 2004-11-29 22:25:31 +00:00
Roger Dingledine
22727b4edc wrong is ok, and right is fine, but in between is apparently 
totally unacceptable to me.


svn:r3005
 2004-11-28 11:39:53 +00:00
Nick Mathewson
6f5dbefa7e Normalize space: add one between every control keyword and control clause. 
svn:r3003
 2004-11-28 09:05:49 +00:00
Nick Mathewson
f77ff938b7 remember; tor_socket_errno has side effects! 
svn:r2997
 2004-11-28 05:48:02 +00:00
Roger Dingledine
e5e45fe980 inform him more sanely 
svn:r2993
 2004-11-26 04:19:03 +00:00
Roger Dingledine
a7f92d7ffe inform the user that you noticed when he sent a USR2 
svn:r2992
 2004-11-26 04:17:57 +00:00
Roger Dingledine
f9a0ab62b7 if you want to handle -USR2, you should catch it too. 
svn:r2990
 2004-11-26 04:03:19 +00:00
Roger Dingledine
7c9a707900 remove emacs droppings, since nick says he doesn't need them anymore 
svn:r2989
 2004-11-26 04:00:55 +00:00
Nick Mathewson
f91152ce6a Clarify a bunch of log messages 
svn:r2983
 2004-11-25 04:20:10 +00:00
Roger Dingledine
090c84627c patch to nick's patch 
svn:r2969
 2004-11-24 03:58:45 +00:00
Nick Mathewson
74f74a06c6 make nt service version match actual version 
svn:r2968
 2004-11-24 00:55:39 +00:00
Roger Dingledine
57a392d8d8 initialize rephist before we init_from_config, since init_from_config 
can make us init_keys if we're going to hibernate, which makes us build
a router_desc.


svn:r2953
 2004-11-23 09:00:55 +00:00
Nick Mathewson
f17c08beed Apply NT service patch from Osamu Fujino. This still has some problems (indicated in a comment adapted from the patch submission email), but it is better than before and better than nothing. 
svn:r2938
 2004-11-22 22:10:37 +00:00
Nick Mathewson
bb18d4238f Dont keep rephist info for routers that havent had activity for 24 hours. 
svn:r2926
 2004-11-21 05:14:46 +00:00
Nick Mathewson
36f4e15e81 Call init_keys() where needed; fix hibernate bug. 
svn:r2924
 2004-11-21 04:19:04 +00:00
Roger Dingledine
a4b1eb5630 allow StrictEntryNode and StrictExitNode to be singular 
svn:r2922
 2004-11-20 23:16:03 +00:00
Roger Dingledine
6322287dc1 printfs want carriage returns 
svn:r2917
 2004-11-20 08:00:57 +00:00
Roger Dingledine
dd19cf6ba3 kill -USR2 now moves all logs to loglevel debug 
plus fix some typos


svn:r2914
 2004-11-20 07:33:55 +00:00
Roger Dingledine
2e4763655d bugfix: when our poll is interrupted, we believed the revents values. 
svn:r2907
 2004-11-17 20:26:39 +00:00
Roger Dingledine
4b76fe8036 Break DirFetchPostPeriod into: 
- DirFetchPeriod for fetching full directory,
  - StatusFetchPeriod for fetching running-routers,
  - DirPostPeriod for posting server descriptor,
  - RendPostPeriod for posting hidden service descriptors.

Also make sure the hidden service descriptors are at a random
offset from each other, to hinder linkability.


svn:r2889
 2004-11-15 09:05:54 +00:00
Nick Mathewson
c909a8a64b Only record bandwidth usage when accounting is enabled 
svn:r2886
 2004-11-15 04:48:53 +00:00
Roger Dingledine
ee591be3f2 fix a bug in configuring accounting in options_act() 
svn:r2881
 2004-11-15 04:01:31 +00:00
Nick Mathewson
5109159ff9 Fix compilation. Duh. 
svn:r2876
 2004-11-14 22:53:51 +00:00
Nick Mathewson
3e6edf20cc Resolve some hibernating-related XXXX009s. 
svn:r2875
 2004-11-14 22:21:23 +00:00
Nick Mathewson
57536f138a Fetch running-routers. 
Split logic to initiate dirfetch, running-routers fetch, and
descriptor post.  arma: There are some XXXs here that raise design
questions which we should solve before the next release.

The biggest problem is this: Right now, the directory is about 50X as
large as running-routers uncompressed, and about 36X as large
compressed.  Assuming:

    - everybody gets the compressed version of everything,

    - everybody gets cached directories from random dirservers and
      uncached r-r from authdirservers

    - everybody downloads r-r at the same rate they now download dirs,

then using r-r from will *increase* authdirserver directory bandwidth usage
if there are significantly more caches than authdirservers.

I think it's safe to leave this in for now, since there aren't 3x36 caching
dirservers, but we should make everybody with a dirport cache running-routers
soon.  But I could be wrong.


svn:r2872
 2004-11-14 21:46:40 +00:00
Roger Dingledine
846f71dcca make kill -USR1 work again 
svn:r2853
 2004-11-14 13:35:47 +00:00
Roger Dingledine
3f5c113815 clean a comment 
svn:r2844
 2004-11-14 04:55:02 +00:00
Nick Mathewson
08627d5d87 Track whether descriptor is dirty/uploaded. When any options are set, mark it dirty. Once a minute, regenerate and upload the server descriptor if it is dirty. 
svn:r2832
 2004-11-13 16:53:48 +00:00
Nick Mathewson
0b42e31fe0 Comment a confusing conditional 
svn:r2828
 2004-11-13 02:54:30 +00:00
Nick Mathewson
60880cda84 Resolve a bunch of FIXME items; mark a lot more for attention; ask for clarification on some. Turn all XXXX008 ("showstopper for 0.0.8 release") items into XXXX009 or XXXX, since plainly they were not showstoppers for 0.0.8. Add/clean some docs. 
svn:r2808
 2004-11-12 16:39:03 +00:00
Roger Dingledine
90e0ad517e dfc caught a SIGXFSZ error when his debugfile reached 2GB. 
so if they exist, catch them and ignore them.
write() will fail normally and we'll look at errno like
normal human beings.


svn:r2804
 2004-11-12 04:59:37 +00:00
Roger Dingledine
fde595feb7 when clients do --list-fingerprint, it's misleading to 
give them one, because it will never be the same again


svn:r2800
 2004-11-11 13:24:10 +00:00
Roger Dingledine
c03a3eaed0 weaken our anonymity warning a little bit more 
svn:r2771
 2004-11-10 02:58:27 +00:00
Nick Mathewson
5a5be93f80 Normalize whitespace; add a "tell me about all the unnormalized whitespace" target; fix a braino in dirserv.c 
svn:r2758
 2004-11-09 20:04:00 +00:00
Nick Mathewson
cd753df7bf Resolve many XXXs and all DOCDOCs 
svn:r2755
 2004-11-09 18:22:17 +00:00
Roger Dingledine
6a504efdd3 mark_logs_temp() before init'ing new ones. 
we were seeing double, triple, etc each time we setconf'ed.


svn:r2738
 2004-11-09 08:01:39 +00:00
Roger Dingledine
9f3e3d2b71 stop wanting to split init_keys() 
svn:r2735
 2004-11-09 07:29:05 +00:00
Roger Dingledine
6521c2ce51 Stop using the wrong DataDirectory when we're validating. 
Also validate/normalize the DataDirectory better.


svn:r2732
 2004-11-09 07:05:53 +00:00
Roger Dingledine
90b47172bd Make an options_act() where we do all the things a new options set 
needs.
Still needs more work.


svn:r2716
 2004-11-09 04:28:18 +00:00
Roger Dingledine
394554cfbf Clean up copyrights. 
Break connection_consider_empty_buckets() out of
connection_read_bucket_decrement().


svn:r2698
 2004-11-07 01:33:06 +00:00
Roger Dingledine
efad93feb4 tor --list-fingerprint as a client shouldn't try to print null 
svn:r2697
 2004-11-06 09:22:08 +00:00
Roger Dingledine
28a297ebe7 only play the accounting game if it's possible you'll choose to hibernate 
svn:r2694
 2004-11-06 06:56:28 +00:00
Roger Dingledine
6c61ed4fb5 Make options no longer a global variable. 
Now we can try setting an option but back out if it fails to parse, or
  if it's disallowed (e.g. changing RunAsDaemon from 1 to 0).
Use parse_line_from_str rather than parse_line_from_file.


svn:r2692
 2004-11-06 05:18:11 +00:00
Nick Mathewson
19868fe968 Move accounting code into hibernate; start adding logic to track bandwidth-per-seconds-active 
svn:r2680
 2004-11-04 22:33:06 +00:00
Roger Dingledine
a4753283dd better interface for connection_ap_handshake_socks_reply() 
make --list-fingerprint print the fingerprint again


svn:r2668
 2004-11-03 23:13:28 +00:00
Nick Mathewson
cea9125d71 Implement two flavors of authentication for control connections: one for trusted FS, one for untrusted FS. 
svn:r2664
 2004-11-03 19:49:03 +00:00
Nick Mathewson
451f8b5045 - Implement all of control interface except authentication, setconfig, 
and actually making the sockets.
- Make sure that identity-based nicknames start with $.
- Use new string_join interface.


svn:r2661
 2004-11-03 18:33:07 +00:00
Nick Mathewson
4fdaa5de51 Streamline the two redundant "Has the second rolled over?" checks in prepare_for_poll and connection_bucket_refill; also, generate BANDWIDTH control events 
svn:r2657
 2004-11-03 16:38:04 +00:00
Nick Mathewson
d63d420930 Fix another typo 
svn:r2651
 2004-11-03 01:31:42 +00:00
Nick Mathewson
8db0abb687 First attempt at hibernation code. It needs more work around the XXXXs, but first I want arma to review the basic approach while I meditate on how to fix them. 
svn:r2649
 2004-11-02 23:47:32 +00:00
Nick Mathewson
ad4dc74482 Use a stricter set of warnings; make them all pass. 
svn:r2645
 2004-11-02 03:02:17 +00:00
Roger Dingledine
4689243242 make sure options.MaxConn can be reached 
svn:r2638
 2004-11-01 08:24:34 +00:00
Roger Dingledine
984ffec105 implement first piece of hibernation 
still need to track bandwidth, and make decisions based on bandwidth


svn:r2630
 2004-10-31 20:28:41 +00:00
Nick Mathewson
9510d9a792 tor --list-fingerprint to print fingerprint and exit 
svn:r2627
 2004-10-30 19:18:37 +00:00
Nick Mathewson
11d330be5e Tweaks to prevent obsolete restarting tors from hammering the dirservers. (1) Cache a received directory as soon as the signature checks out. (2) Treat a cached directory as "recent" based on its mtime. (3) If we have a recent directory, we dont need to fetch a newer one for DirFetchPostPeriod. This needs review! 
svn:r2618
 2004-10-28 18:37:52 +00:00
Nick Mathewson
2fbf31533b Tricksy compiler warnings! We hates them, hates them forever, my precious! 
svn:r2615
 2004-10-27 21:14:11 +00:00
Nick Mathewson
44d4516155 Use tor_snprintf, not snprintf 
svn:r2609
 2004-10-27 06:37:34 +00:00
Nick Mathewson
bc62f8e983 Replace sprintf with snprintf 
svn:r2602
 2004-10-27 05:53:07 +00:00
Nick Mathewson
57f09573f5 Every 60 seconds, check whether the listeners are still alive, and relaunch the dead ones. 
svn:r2581
 2004-10-24 01:22:40 +00:00
Roger Dingledine
54c432bd93 pay attention to the return value of do_hup, and exit 
when it fails


svn:r2577
 2004-10-23 17:06:25 +00:00
Nick Mathewson
88cffc3c5f Use bitwise masking to turn off bits, not compare-and-subtract 
svn:r2572
 2004-10-20 23:15:49 +00:00
Roger Dingledine
97a0a43511 start the process of making 0.0.7* obsolete 
svn:r2565
 2004-10-17 21:51:20 +00:00
Roger Dingledine
de65052312 don't assert multiple things in the same tor_assert() 
svn:r2544
 2004-10-16 22:14:52 +00:00
Nick Mathewson
1c9426d6e0 Build without warnings on mac gcc 3.3 
svn:r2487
 2004-10-14 03:18:14 +00:00
Nick Mathewson
b7bddcac75 Windows requires a different cast uint64_t format 
svn:r2424
 2004-10-07 20:15:56 +00:00
Roger Dingledine
3f4b544b77 use size_t rather than int for directory lengths in memory 
this might fix a bug with amd64


svn:r2410
 2004-10-01 21:02:12 +00:00
Roger Dingledine
136d4e5739 prefer tor_free to free 
plus complain more loudly when we fail to parse a dir we just fetched


svn:r2401
 2004-09-29 06:52:36 +00:00
Roger Dingledine
6ed095b177 print the IP if a conn fails badly, to see if there are any trends 
svn:r2400
 2004-09-29 05:59:55 +00:00
Roger Dingledine
d381aa4696 Fix an evil bug: when we failed to write to our log, fputs() 
gave us a sigpipe, and we logged that we were ignoring it,
causing us to fail to log that, and delete the log entry. Then
when the signal handler exited, we proceeded to delete the log
entry that had already been deleted.

Now we make sure to only log inside our signal handler if we'll
be exit()ing right after.


svn:r2388
 2004-09-28 21:14:40 +00:00
Roger Dingledine
8727a28119 bugfix: we were starting to daemonize before we opened our logs, 
so if there were any problems opening logs, we would complain to
stderr (which wouldn't work) and then mysteriously exit.


svn:r2366
 2004-09-23 04:32:43 +00:00
Roger Dingledine
c0db9fa803 fix confusing cut-n-paste mistake 
svn:r2364
 2004-09-22 04:08:05 +00:00
Nick Mathewson
0ef85f6dba Some platforms have weird translations when you open files in "test" mode; make read/write_str_to_file aware. 
svn:r2336
 2004-09-08 07:16:34 +00:00
Nick Mathewson
c66e4c4870 Flush more changes from sandbox 
- make clients cache directories and use them to seed their router lists
   at startup.  This means clients have a datadir again.
 - Introduce a global_write_bucket.  We need to respond better to exhausting
   it.
 - Remove the last vestiges of LinkPadding and TrafficShaping.
 - Configuration infrastructure support for warning on obsolete options.
 - Refactor directory header parsing to use smartlist_split_string.
 - Respond to content-encoding headers by trying to uncompress as appropriate.
 - Reply with a deflated directory when a client asks for "dir.z".
   (We could use allow-encodings instead, but allow-encodings isn't
   specified in HTTP 1.0.)


svn:r2335
 2004-09-08 06:52:33 +00:00
Nick Mathewson
ecf414f05e Stop using separate defaults for no-config-file and empty-config-file 
svn:r2329
 2004-09-02 22:08:36 +00:00
Nick Mathewson
4b4bfd500a Improve log message to make it obvious _why_ reading the configuration has failed. 
svn:r2308
 2004-08-24 20:46:42 +00:00
Roger Dingledine
99e367f045 authdirservers don't need to be treated specially on hup for 
making intro points


svn:r2277
 2004-08-18 06:48:45 +00:00
Roger Dingledine
6e9e467b1d dirservers now don't build circuits until they have fetched a 
directory from somebody else. this means they have time to
build their connections first.


svn:r2275
 2004-08-18 06:29:58 +00:00
Nick Mathewson
e19af3fa0f We are an OR if ORPort *or* ORBindAddress is set; similarly for being an OP 
svn:r2237
 2004-08-15 20:16:26 +00:00
Roger Dingledine
cd3da3fc12 o clients choose nodes proportional to advertised bandwidth 
o and/or while avoiding unreliable nodes, depending on goals
o 'fascistfirewall' option to pick dirservers on port 80 and ORs on
  port 443.
o if a begin failed due to exit policy, but we believe the IP should                       have been allowed, switch that router to exitpolicy reject *:* until                     we get our next directory.


svn:r2231
 2004-08-15 08:15:12 +00:00
Roger Dingledine
dda2e44222 compile again on win32 (i think) 
svn:r2222
 2004-08-09 23:45:11 +00:00
Roger Dingledine
1e415817a3 minor fix 
svn:r2215
 2004-08-09 07:41:32 +00:00
Roger Dingledine
7068dd8e87 make "%llu" less likely to warn on weird platforms 
svn:r2209
 2004-08-09 05:25:19 +00:00
Roger Dingledine
05790d1722 let children survive sigint, sigterm, etc. 
this was biting us because ^c would get delivered to all of them,
maybe because they were all still listening to stdin?


svn:r2197
 2004-08-08 07:25:45 +00:00
Nick Mathewson
f6cc218742 Refactor ISO-style (yyyy-mm-dd hh:mm:ss) time parsing into util.c; rename format/parse_rfc1123_time; make rephist remember used bandwidth; published used bandwidth in descriptors in 15-minute chunks. Breaks unittests. 
svn:r2182
 2004-08-07 02:46:16 +00:00
Roger Dingledine
e95ae1c9ad let purging routerinfos and descriptors take an age argument 
svn:r2171
 2004-08-06 22:15:25 +00:00
Roger Dingledine
967a762fe1 they're uint64 and uint32, not int and int 
svn:r2152
 2004-08-06 08:40:55 +00:00
Roger Dingledine
f32e34044f list total traffic and total uptime in -usr1 stats 
svn:r2151
 2004-08-06 08:37:13 +00:00
Roger Dingledine
0c8542d889 fix rare race condition that causes infinite loop 
if we get a sigchld but all our children are gone by the time we get
around to reaping them (i don't think this should ever happen, but it
just did), then we'd loop forever trying to reap them.


svn:r2141
 2004-08-04 06:49:17 +00:00
Nick Mathewson
75684a48d5 <arma> did you get it working on win32? or just compiling 
svn:r2136
 2004-08-04 04:58:30 +00:00
Roger Dingledine
a328aab316 clean whitespace and tabs 
svn:r2115
 2004-07-22 23:21:12 +00:00
Roger Dingledine
aebec8ab9e stop using atexit() to remove our pid, since it's called 
immediately when we daemonize.

also drop our retry period for hidserv desc uploads from 10m to 5m


svn:r2111
 2004-07-22 22:15:36 +00:00
Roger Dingledine
06b72cc8f2 publish advertised_bandwidth in descriptor 
svn:r2095
 2004-07-22 04:20:27 +00:00
Roger Dingledine
6c56f34aaf clients shouldn't create datadir until we have something to put there 
svn:r2092
 2004-07-22 00:13:42 +00:00
Roger Dingledine
3c2c8ed42b 0.0.8 ORs should autoconnect to authdirservers and 0.0.7 servers 
svn:r2091
 2004-07-21 23:43:47 +00:00
Roger Dingledine
ce7fcd110c solve the authdirserver initialization precedence problem 
svn:r2085
 2004-07-21 18:53:56 +00:00
Roger Dingledine
3e97c12f24 rearrange to prepare to solve the authdirserver initialization 
precedence problem. doesn't actually solve it yet.


svn:r2079
 2004-07-21 07:50:06 +00:00
Roger Dingledine
30d6b1479b clients exit immediately on interrupt; they don't wait 
svn:r2076
 2004-07-21 03:15:32 +00:00
Nick Mathewson
334de84cbe Misc small code cleanups; remove exit_server_mode(); change tor_tls_verify behavior 
svn:r2073
 2004-07-21 00:44:04 +00:00
Roger Dingledine
73ffcc5cef add a new advertised_server_mode() to distinguish ORs that 
are willing to become servers from ones that really are servers.


svn:r2071
 2004-07-21 00:12:42 +00:00
Roger Dingledine
0da256ef97 when we get a sigint, don't accept new connections/circuits, 
but delay 30 seconds until exiting.
if we get a second sigint, exit immediately.


svn:r2070
 2004-07-20 23:31:00 +00:00
Roger Dingledine
d5999a24af also don't hang up on him if we're an OR and he's an authdirserver 
otherwise we keep getting taken out of the running-routers list


svn:r2063
 2004-07-20 19:45:29 +00:00
Roger Dingledine
66fc6cf04a if you're an OR and he's an OR and he's running 0.0.7, 
don't expire your connections to him.


svn:r2062
 2004-07-20 19:28:02 +00:00
Roger Dingledine
dc7951a5a7 a whole swath of fixes 
introduce an authdir_mode() macro to match the others.
don't initialize uptime to the number of seconds since 1970.
non-authoritative dirservers don't cache their directory on disk.
make only authdirservers use clique_mode.
only read approved-routers file if you're an authdirserver.
even authdirservers fetch a new directory in do_hup.
retry_all_connections() is now called retry_all_listeners().
router_parse_list_from_string() correctly reports the router number
  it's working on.
only call dirserv_add_own_fingerprint() and
   dirserv_add_descriptor() on startup if we're an authdirserver.
if AuthDir and !ORPort then fail.
if AuthDir and ClientOnly then fail.


svn:r2061
 2004-07-20 10:17:43 +00:00
Nick Mathewson
54c129d8dc abstract ORPort/SocksPort checks into server_mode(), proxy_mode(), clique_mode(), etc. Dont change underlying comments. 
svn:r2054
 2004-07-18 21:47:04 +00:00
Nick Mathewson
e9365f9ed5 Bugfix: some things (like ctrl-z) can make a second take more than one second 
svn:r2042
 2004-07-13 18:07:57 +00:00
Roger Dingledine
d37850bb98 only count bytes transmitted to/from non-local IPs 
svn:r2041
 2004-07-13 16:58:01 +00:00
Roger Dingledine
86e0ede07e checkpoint: start working on bandwidth tracking and 
letting clients evaluate whether they're suitable servers


svn:r2037
 2004-07-13 07:42:20 +00:00
Roger Dingledine
3294b514d3 when you expire a wedged dir conn, conn_close_if_marked will take 
care of trying to flush before it closes


svn:r2035
 2004-07-13 00:38:08 +00:00
Roger Dingledine
cbf73b2bc5 touchups all over 
put uptime in descriptor


svn:r2011
 2004-07-04 22:48:11 +00:00
Roger Dingledine
f42f04c859 cleanups on 008pre1 items 
svn:r1993
 2004-06-30 21:48:02 +00:00
Nick Mathewson
b1e9adf056 Always use get_data_directory() instead of options.DataDirectory; fix a memory leak in router.c 
svn:r1991
 2004-06-30 16:37:08 +00:00
Nick Mathewson
76f769deb9 Remaining 008pre1 items done; deferred where more design is needed. 
More docs and (way more!) testing needed.

Done:
 - Authdirservers down directories from others.
 - Generate and use running-routers lists
 - Cache directories; store across reboots.
 - Refactor directory parsing a bit; note potential trouble spots.


svn:r1985
 2004-06-25 00:29:31 +00:00
Nick Mathewson
8aec3a7301 Implement several 008pre1 items: needs more testing 
svn:r1981
 2004-06-21 04:37:27 +00:00
Nick Mathewson
a788981399 Implement code to run tor as an NT service. More testing is needed, as is code to install the service. 
svn:r1966
 2004-06-12 21:43:02 +00:00
Nick Mathewson
125b351970 Break tor_main into startup/loop/shutdown portions, to make NT service refactoring possible. 
svn:r1965
 2004-06-12 19:45:46 +00:00
Nick Mathewson
184f4e6044 Rotate dnsworkers and cpuworkers on SIGHUP, so they get new config settings too 
svn:r1950
 2004-06-06 03:38:31 +00:00
Nick Mathewson
605e10a650 Stop multiplying logs on sighup. 
svn:r1936
 2004-06-02 19:18:37 +00:00
Nick Mathewson
0d20fee2fb Add more asserts to dns-pending connections; fix a couple seeming bugs. 
svn:r1931
 2004-06-01 22:09:58 +00:00
Roger Dingledine
4181d18b3d declare the epipe bug a non-bug. 
now we catch and ignore epipe signals, and when write returns epipe,
we simply return -1 and close the socket/connection.


svn:r1928
 2004-06-01 17:31:13 +00:00
Roger Dingledine
834ffa358f bugfix: if the wedged dir conn has no bytes to flush, then we never 
close it.


svn:r1924
 2004-05-28 17:56:17 +00:00
Roger Dingledine
8064807896 dirservers try to reconnect periodically too, in case connections have failed 
svn:r1922
 2004-05-28 15:01:47 +00:00
Nick Mathewson
9b4e8486ce Keep temporary log in place while configuring logs 
svn:r1919
 2004-05-24 02:28:15 +00:00
Nick Mathewson
ccb825128e Tinker with log behavior: never send error messages about logs into the bitbucket 
svn:r1912
 2004-05-20 19:47:28 +00:00
Roger Dingledine
66dd21b7a4 some more patching 
svn:r1910
 2004-05-20 08:41:54 +00:00
Roger Dingledine
30a07b2ecd non-dirservers expire routerinfo's that are more than a day old 
svn:r1907
 2004-05-20 05:10:30 +00:00
Nick Mathewson
9d2cd7fc6e Allow multiple logfiles at different severity ranges 
svn:r1899
 2004-05-19 20:07:08 +00:00
Roger Dingledine
d2de7120fa fix a seg fault, add another XXX for nick ;) 
svn:r1892
 2004-05-18 16:54:04 +00:00
Nick Mathewson
7511fbf993 Resolve some XXXs 
svn:r1889
 2004-05-18 15:35:21 +00:00
Nick Mathewson
50b7ebcf9e Make directory functions update routerlist, not replace it. Add notion of OR-is-trusted-to-be-a-dirserver. Arma, please review: does this handle being a dirserver right? 
svn:r1880
 2004-05-17 20:31:01 +00:00
Roger Dingledine
5ba9235873 clean up directory.c API 
svn:r1860
 2004-05-12 23:48:57 +00:00
Roger Dingledine
1cf1836990 break connection_edge_end out of connection_mark_for_close 
svn:r1858
 2004-05-12 21:12:33 +00:00
Roger Dingledine
32c42a0ee2 break rend_client_desc_fetched out of connection_mark_for_close 
svn:r1856
 2004-05-12 20:36:44 +00:00
Roger Dingledine
4c9138d640 calling flush_buf and not checking for return value is bad 
svn:r1851
 2004-05-12 18:41:32 +00:00
Nick Mathewson
3e2f889a29 Add an extra flush attempt when closing wedged dir conns, in an attempt to isolate the EPIPE bug 
svn:r1848
 2004-05-11 01:55:32 +00:00
Roger Dingledine
3cdf2d67da it's amazing what a bit of punctuation can do for appearances 
svn:r1843
 2004-05-10 10:27:54 +00:00
Nick Mathewson
81922a125c More doxygenation. 
svn:r1832
 2004-05-10 04:34:48 +00:00
Roger Dingledine
c6d4a00c5f more doxygen markup 
plenty more remains


svn:r1824
 2004-05-09 16:47:25 +00:00
Roger Dingledine
b384c5a18d bugfix: do directory_send_command only after we've established a socket 
also many comments, cleaning, etc


svn:r1823
 2004-05-09 16:33:04 +00:00
Roger Dingledine
9bf9ca4d09 bugfix: add a circ->resolving_streams field, and make dns resolving streams not actually in the connection_array until they're done resolving. 
bugfix: actually complain if we duplicate mark-for-close a circuit

add more logging for relay ends that claim dns resolve failed, so we can
find out why they're not being retried.


svn:r1798
 2004-05-06 11:08:04 +00:00
Nick Mathewson
e6477a8e16 Document the rest of main.c 
svn:r1797
 2004-05-05 21:35:12 +00:00
Nick Mathewson
682a805092 Comments for nearly all non-tricky files 
svn:r1796
 2004-05-05 21:32:43 +00:00
Nick Mathewson
2ba0776b02 Only connection_add connections once they have conn->s sett; refactor code around this. Should make stuff more bulletproof. 
svn:r1788
 2004-05-05 01:26:57 +00:00
Roger Dingledine
608c156820 must close marked connections at the end of run_scheduled_events. 
otherwise they might have a socket -1, and if we leave them around
they'll muck up poll/select.

i think this was the cause of our win32 and os x fakepoll crashes,
and probably would cause other errors down the road.


svn:r1786
 2004-05-05 00:59:42 +00:00
Nick Mathewson
af08c4f878 Working strerror for windows socket errors, plus some snide comments. 
svn:r1775
 2004-05-02 20:18:21 +00:00
Nick Mathewson
908ccb9dcd Handle windows socket errors correctly; comment most of common. 
svn:r1756
 2004-05-01 20:46:28 +00:00
Roger Dingledine
fff89216a9 tell us when we're rotating things 
svn:r1712
 2004-04-26 09:32:51 +00:00
Roger Dingledine
25d54257fb use tor_assert 
remove obsolete BUF_OK macro


svn:r1697
 2004-04-25 20:37:37 +00:00
Nick Mathewson
cb3897e5ab remove spurious router_rebuild_descriptor 
svn:r1692
 2004-04-25 19:01:49 +00:00
Roger Dingledine
0b31d0d4e8 more touch-ups 
svn:r1687
 2004-04-24 23:32:24 +00:00
Nick Mathewson
c44016e86e Merge flagday into main branch. 
svn:r1683
 2004-04-24 22:17:50 +00:00
Roger Dingledine
3c250a2fed only expire wedged dir conns that haven't already been expired 
svn:r1676
 2004-04-20 17:27:54 +00:00
Roger Dingledine
5cfec379ae expire wedged dir conns after 5min without write, not simply after 5min 
svn:r1673
 2004-04-19 20:08:42 +00:00
Roger Dingledine
d40e9f453f give wedged dir conns a last chance to flush 
svn:r1671
 2004-04-19 01:59:20 +00:00
Roger Dingledine
8d86f8abf5 reverse the logic, captain 
svn:r1664
 2004-04-18 06:42:13 +00:00
Roger Dingledine
7a7baf0552 expire dir connections that live for more than 5 minutes 
svn:r1663
 2004-04-18 06:35:31 +00:00
Roger Dingledine
01e594e512 clean up some warnings 
svn:r1651
 2004-04-17 06:34:20 +00:00
Nick Mathewson
baaf58fe1d only consider uploading descriptors every 5 sec 
svn:r1612
 2004-04-13 19:53:25 +00:00
Nick Mathewson
a2ece0fc08 Separate "start-establishing-introduction" from "upload descriptors"; only upload descriptors containing fully established intro points. 
svn:r1607
 2004-04-13 17:16:47 +00:00
Roger Dingledine
e0ce205a76 clean up circuit rebuilding some; fix some bugs we hadn't hit yet 
svn:r1606
 2004-04-13 05:20:52 +00:00
Roger Dingledine
f4ff5a75c1 break circuit_build_needed_circs into its own func 
svn:r1596
 2004-04-12 22:47:12 +00:00
Roger Dingledine
48e0228f1e expire old CIRCUIT_PURPOSE_C_REND_READY circs too 
svn:r1585
 2004-04-09 20:08:13 +00:00
Nick Mathewson
4e1b65f53d Dump introduction point status on kill -USR1 
svn:r1584
 2004-04-09 20:02:16 +00:00
Nick Mathewson
f9ade70cf9 Resolve init-services-in-do-hup issue 
svn:r1583
 2004-04-09 19:37:50 +00:00
Roger Dingledine
c80b42e17c don't call rend_services_init right before we fetch the 
dir, because we call it right after now.


svn:r1582
 2004-04-09 19:34:55 +00:00
Roger Dingledine
c5bef32d95 call directory_has_arrived has arrived every time we get 
a new directory, not just the first time


svn:r1581
 2004-04-09 19:30:38 +00:00
Nick Mathewson
c256f2c3a1 Make comment more sensible. Still uncertain about when to call rend_services_init, though. 
svn:r1580
 2004-04-09 17:54:20 +00:00
Nick Mathewson
facb5d4221 Reload rendezvous service keys on sighup; otherwise, we wind up with a 
bunch of half-initialized services.  This should solve half of
weasel's current bug.  The crash is the other half.

(arma: should we also call rend_services_init on hup?)


svn:r1578
 2004-04-09 17:48:09 +00:00
Roger Dingledine
4011906b6b get more serious about hunting The Bug 
(it has been haunting us since the days of 0.0.2preX)


svn:r1576
 2004-04-09 09:39:42 +00:00
Roger Dingledine
63cde97253 don't try to build intro circs until you've fetched the directory 
svn:r1541
 2004-04-07 22:48:06 +00:00
Nick Mathewson
4d14b786da Make sure we have our own keys before we initialize our routerlist 
svn:r1535
 2004-04-07 21:44:46 +00:00
Roger Dingledine
4df06ab5bb let bob replenish his intro points and republish service desc 
as necessary


svn:r1528
 2004-04-07 20:47:50 +00:00
Roger Dingledine
4a9587a486 we were uploading our server descriptor to each the dirservers 
when we boot, and then also on the first iteration of the main loop


svn:r1520
 2004-04-07 19:30:22 +00:00
Roger Dingledine
7793078dff alice can now look up bob's service descriptor, 
choose an intro point, connect to it,
choose a rend point, connect to it and establish a cookie,
get an ack from the rendezvous point,
and know when both circs are ready for her.

APConns don't use conn->purpose anymore

don't initiate a renddesc lookup if one is already in progress

also fix a buffer overflow in nickname parsing (only exploitable
by the operator though)


svn:r1471
 2004-04-05 00:47:48 +00:00
Roger Dingledine
4e996a4ce8 tabs 
svn:r1456
 2004-04-03 02:14:20 +00:00
Roger Dingledine
f34e6da3e7 now circuit_get_newest returns an appropriate circ for your purpose 
connection_ap_handshake_attach_circuit attaches to a circ of the
right purpose

add a skeletal rendclient.c


svn:r1441
 2004-04-02 22:23:15 +00:00
Roger Dingledine
64cb3a027f teach directory servers to handle renddesc responses 
svn:r1434
 2004-04-01 21:32:01 +00:00
Roger Dingledine
cc3c4245cb let the circuit-launcher choose the exit node (if he wants) 
svn:r1428
 2004-04-01 03:44:49 +00:00
Roger Dingledine
d01497cf3c outline what bob does to initialize his hidden services 
let circuit_launch_new return the circ it just made


svn:r1424
 2004-04-01 03:23:28 +00:00
Roger Dingledine
d13857a3f0 put in hooks for alice and bob logic when circuits finish/fail 
let you specify the purpose of circuits you launch

bugfix: we used to be declaring the first successful circuit too                               early -- when the first hop finished. now we're more accurate.


svn:r1421
 2004-04-01 01:57:22 +00:00
Roger Dingledine
ee45ae575d allow conns to demand to be attached to a clean circuit 
(nobody uses this yet)


svn:r1417
 2004-03-31 23:06:16 +00:00
Roger Dingledine
a0b0d16981 Add an ap_bridge function to do a socketpair and skip socks. 
This allows us to do a directory connection *through* tor just
as if we're doing it as an application.

Make ap_conns tolerate it when the application sends stuff before
The socks handshake is done (it just buffers it).

Tell directory_initiate_command the length of the payload (because
it might include nuls).

Add a directory_has_arrived function to, for example, start building
the rendezvous service descriptor.


svn:r1412
 2004-03-31 22:02:13 +00:00
Nick Mathewson
bf83b1e345 Add code to configure hidden services, parse configuration, generate keys and service IDs, and store/load them from disk 
svn:r1410
 2004-03-31 21:35:23 +00:00
Nick Mathewson
8fedefe6cb rename hidserv_xx 
svn:r1406
 2004-03-31 04:10:10 +00:00
Nick Mathewson
b32440a028 Implement hidserv_XX functions; there is still an XXX in directory_handle_command 
svn:r1404
 2004-03-31 03:42:56 +00:00
Roger Dingledine
2d3ac08633 Refactor directory servers 
* read all the time (before we would ignore eof sometimes, oops)
* we can handle different urls now
* send back 404 for an un-handled url
* commands initiated by the client can handle payloads now
* introduce conn->purpose to avoid exponential state-space explosion


svn:r1400
 2004-03-30 22:57:49 +00:00
Roger Dingledine
524312494b use 'notice' loglevel for things the operator should hear 
but that aren't warnings


svn:r1384
 2004-03-30 03:15:53 +00:00
Nick Mathewson
0e6084d751 Remove descriptors that are older than 24 hours from the directory. Use strlcat instead of strncat to generate directories. 
svn:r1361
 2004-03-29 19:28:16 +00:00
Roger Dingledine
2ba9901cb4 oh, i forgot to enable the find-munged-conn function 
svn:r1357
 2004-03-28 21:14:05 +00:00
Roger Dingledine
47b40de0aa only build circuits after we've fetched the directory 
this resolves a subtle bug where tor clients were preferentially using
the directory servers, since when they start building circuits they
know only about the directory servers

on the other hand, it now takes longer after startup before there's
a working circuit. so it goes.


svn:r1350
 2004-03-27 00:15:09 +00:00
Nick Mathewson
b7c2b18bd6 Add a RunTesting option to try to learn link state by creating test circuits, even when SocksPort is off. 
svn:r1327
 2004-03-21 03:03:10 +00:00
Roger Dingledine
3d2c6c7cfa catch signals in a more portable way, so solaris can catch them too 
svn:r1324
 2004-03-20 23:27:22 +00:00
Nick Mathewson
2ba2f02181 Integrate the new "rephist" [rep(utation) hist(ory)] module to trace 
successful/failed connections, successful/failed extends, and
connection uptimes.

It's still not done: more tests are needed, and not everything calls
connection/circuit_mark_for_close properly.  This skews the results.

Also, there needs to be a 'testing' mode for non-OP ORs, where they
periodically build circuits just to test whether extends work.


svn:r1313
 2004-03-20 04:59:29 +00:00
Roger Dingledine
208625ae31 clean up some presentation and comments 
svn:r1294
 2004-03-18 19:22:56 +00:00
Roger Dingledine
74ef3a63ae bugfix: decrement OR connections from global_bucket too 
bugfix: don't return immediately for has_pending_tls_data unless
        the conn is allowed to read


svn:r1270
 2004-03-14 17:06:29 +00:00
Roger Dingledine
703b2d3cf8 refactor bandwidth-control token buckets 
this is a checkpoint commit; there still remain some
bugs, er, somewhere.


svn:r1269
 2004-03-14 16:00:52 +00:00
Roger Dingledine
87797bcde5 get rid of those pesky tabs 
svn:r1264
 2004-03-12 13:00:34 +00:00
Roger Dingledine
623cb0e311 more details when a conn is closed before it's done flushing 
svn:r1262
 2004-03-12 08:16:48 +00:00
Roger Dingledine
52e813951a start tracking the 'broken pipe' error 
svn:r1261
 2004-03-11 20:15:53 +00:00
Nick Mathewson
9b4203266e Make OP work on windows! (Also misc logging tweaks) 
svn:r1258
 2004-03-11 06:19:08 +00:00
Nick Mathewson
d877aac5ad Make windows version correct; initialize windows foolishness so that gethostbyname works. 
svn:r1250
 2004-03-10 06:26:38 +00:00
Roger Dingledine
416993afc1 bugfix: only set conn->hold_open_until_flushed after marking 
svn:r1245
 2004-03-08 01:19:57 +00:00
Roger Dingledine
10cee8b7f7 fix a rare race condition: when we send a cell and then 
mark an OR connection expired, we might close it before
finishing a flush if the other side isn't reading.


svn:r1240
 2004-03-06 06:05:00 +00:00
Roger Dingledine
6c9d78b319 stop asserting that computers always go forward in time 
it's simply not true


svn:r1236
 2004-03-06 01:43:37 +00:00
Roger Dingledine
5e2e6555a2 and a minor patch 
svn:r1215
 2004-03-03 08:48:32 +00:00
Roger Dingledine
419a672222 holding until flush was borked 
we were never writing anything when hold_open_until_flushed was set,
since conn_write returns early if marked_for_conn is set.

seems a bit better now.


svn:r1214
 2004-03-03 08:46:18 +00:00
Roger Dingledine
6022bfea11 better debugging for lonely flushes 
svn:r1213
 2004-03-03 07:26:58 +00:00
Roger Dingledine
3c71d09402 use conn->hold_open_until_flushed for streams 
and also note/fix a variety of other stream-based bugs


svn:r1210
 2004-03-03 06:26:34 +00:00
Nick Mathewson
f4e4dac801 Implement hold_open_until_flushed. I may have missed something important. 
svn:r1209
 2004-03-03 05:08:01 +00:00
Roger Dingledine
8275e2302c make socks5 not give a spurious warning 
also rename AP_CONN_STATE_CONNECTING to _CONNECT_WAIT


svn:r1208
 2004-03-03 04:54:16 +00:00
Nick Mathewson
5a053a6a81 remove redundant check 
svn:r1204
 2004-03-03 02:14:35 +00:00
Nick Mathewson
6379dbbe2a warn more when losing data on closed/marked connections. 
svn:r1203
 2004-03-03 02:07:57 +00:00
Nick Mathewson
6f3c6d1289 Split out mark_for_close with circuits. Seems to work for me. 
svn:r1197
 2004-03-02 17:48:17 +00:00
Roger Dingledine
2c341cd032 put switch_id and start_daemon earlier 
svn:r1188
 2004-02-29 22:34:38 +00:00
Roger Dingledine
ef5f917e9e print a statement when the first circ is finished, 
so the user knows it's working


svn:r1179
 2004-02-29 03:52:38 +00:00
Roger Dingledine
4716d4d871 bugfix: only warn about an unrouter router after we've fetched a directory 
svn:r1178
 2004-02-29 01:31:33 +00:00
Roger Dingledine
928db6dadc cwd to datadir if it's defined, rather than / 
this way people can get cores if they want to


svn:r1171
 2004-02-28 23:23:06 +00:00
Nick Mathewson
f039eca658 Stop trying to flush on broken sockets marked for close. 
svn:r1163
 2004-02-28 19:14:11 +00:00
Roger Dingledine
80410fa8dc some comments to point nick at the latest bugs 
svn:r1162
 2004-02-28 11:48:22 +00:00
Roger Dingledine
e59f19ca03 some more small fixes 
svn:r1152
 2004-02-28 04:44:48 +00:00
Nick Mathewson
b4a7883c90 make code more readable; arrbitrarily change a -1 to a 0. 
svn:r1151
 2004-02-28 04:34:27 +00:00
Nick Mathewson
4e89c6661a Push responsibility for connection marking down as far as possible; have only a close path; add some missing end cells; change return conventions a little. 
svn:r1149
 2004-02-28 04:11:53 +00:00
Roger Dingledine
611f117ce1 patches/answers to nick's commit 
svn:r1146
 2004-02-27 23:23:33 +00:00
Nick Mathewson
c5bbb571d2 Refactor mark_for_close, connection_edge_end and friends. Now, everybody 
who wants to shut down a connection calls connection_mark_for_close instead
of setting marked_for_close to 1.  This automatically removes the connection
from the DNS cache if needed, sends a RELAY END cell if appropriate, and can
be changed to do whatever else is needed.

Still to do:
  - The same for circuits, maybe.
  - Add some kind of hold_connection_open_until_flushed flag, maybe.
  - Change stuff that closes connections with return -1 to use mark_for_close,
    maybe.


svn:r1145
 2004-02-27 22:00:26 +00:00
Roger Dingledine
195dfd35a8 Fix a bug where you might flush some data on a tls connection, and then 
add some more data to be flushed but never turn POLLOUT on. not sure
how commonly this bug was hit, but it would be a doozy.

Also add some asserts to see if it happens elsewhere.


svn:r1142
 2004-02-27 04:42:14 +00:00
Roger Dingledine
4c48359ece break out the operations done on sighup into their own function 
svn:r1129
 2004-02-26 22:30:44 +00:00
Roger Dingledine
43156904ce dump a new router.desc on hup 
svn:r1128
 2004-02-26 22:20:00 +00:00
Roger Dingledine
0b27ae0c2d if the default torrc isn't there, just use some default defaults 
plus provide an internal dirservers file if they don't have one

having no config files will make it easier to run on windows


svn:r1124
 2004-02-26 21:25:51 +00:00
Nick Mathewson
67a273962a On OSX, decline to use the built-in select-baed poll wrapper, since it seems to sometimes not work. 
svn:r1114
 2004-02-20 23:41:45 +00:00
Roger Dingledine
afdaff63ef turn some knobs, add more debugging 
svn:r1023
 2004-01-30 19:31:39 +00:00
Roger Dingledine
3516ae1a26 add an ap_conn connecting state; report connecting delay 
svn:r1011
 2004-01-20 09:21:46 +00:00
Roger Dingledine
fb81a32c68 setuid to User _before_ complaining about running as root 
svn:r1006
 2004-01-19 06:12:32 +00:00
Roger Dingledine
561c6236af fix some errors in logs and comments 
svn:r999
 2004-01-16 08:27:17 +00:00
Roger Dingledine
5086300815 split the token bucket into 'rate' and 'burst' params 
we're not entirely migrated to burst yet, for backward compatibility

note some win32 probable-bugs

clean up routerlist.c


svn:r982
 2004-01-10 23:40:38 +00:00
Roger Dingledine
607078cf70 print an entry at the top of the logfile so you know it's working 
clean up a minor bug in a debugfile log entry


svn:r970
 2004-01-05 05:22:04 +00:00
Nick Mathewson
cacacfe2b1 Integrate new daemon code, adapted from submission by christian grothoff 
svn:r969
 2004-01-03 22:40:49 +00:00
Roger Dingledine
55a94cd497 correct a warn message in mark_if_closed 
svn:r956
 2003-12-23 07:42:01 +00:00
Roger Dingledine
a5aa80cc41 make --debuglogfile (or any second log file) work 
svn:r935
 2003-12-14 09:58:43 +00:00
Roger Dingledine
36ea39ec9c on hup, close and rebind listener ports too (in case their config has changed) 
svn:r926
 2003-12-14 06:03:46 +00:00
Roger Dingledine
2997ef8dd9 warn if you're running tor as root 
svn:r921
 2003-12-14 04:39:23 +00:00
Roger Dingledine
25e7e97d73 on HUP, retry OR connections, and stop clobbering the dirserver's routerlist 
svn:r920
 2003-12-14 04:33:18 +00:00
Roger Dingledine
c25fbd2676 break routers.c into router.c for stuff the router does, 
and routerlist.c for handling routerlist.


svn:r887
 2003-12-06 05:54:04 +00:00
Roger Dingledine
e0952d0773 terminology shift: 
directory is the string that dirserv.c and directory.c deal with
routerlist is routerinfo's that are bundled together in routers.c

rename some of the get_routerlist functions to set_routerlist

preparing to break into router.c for stuff the router does,
and routerlist.c for handling routerlist.


svn:r886
 2003-12-05 09:51:49 +00:00
Roger Dingledine
975bb68010 simplify: options.OnionRouter==1 iff options.ORPort>0 
svn:r857
 2003-11-20 17:49:45 +00:00
Roger Dingledine
d6601f8cff make pidfile default to null rather than writing to your cwd 
svn:r853
 2003-11-19 22:45:06 +00:00
Nick Mathewson
fd07872a72 Separate failure-count tracking from circuit-launching. 
Increment failure counts only when circuits close without having been built.
Reset failure counts only on the second, and when circuits are done building.


svn:r847
 2003-11-19 02:22:52 +00:00
Peter Palfrader
9a676b04dd Check that we can write to the logfile and log a warning to stderr if we can't 
Move writing of pidfile after daemonizing, and also after setting the [ug]id:
This means that the tor user needs write priviliges to the pidfile location.
It needs it for unlinking the pidfile anyway.


svn:r846
 2003-11-19 02:09:43 +00:00
Roger Dingledine
f0cccc567e bugfix: don't ask for ->next of an expired circuit 
bugfix: keep going when a circ fails in circuit_n_conn_open
        (make circuit_enumerate_by_naddr_nport obsolete)
bugfix: make circuit_n_conn_open only look at circ's that start at us
bugfix: only try circuit_n_conn_open if we're an OP. Otherwise we
        expect connections to always already be up.
bugfix: when choosing path length, pay attention to whether the directory
        says a router is down.
bugfix: when picking good exit, skip routers which are known to be down
        (more work needs to be done on this one)


svn:r838
 2003-11-18 09:53:03 +00:00
Roger Dingledine
a3e39b0ceb don't build too many circs at once 
expire circs that have been building for too long


svn:r835
 2003-11-18 07:48:00 +00:00
Roger Dingledine
4aede010b9 recognize in-progress circs and don't start redundant ones 
quickly notice streams that don't have a circ on the way, and start one


svn:r819
 2003-11-17 00:57:56 +00:00
Roger Dingledine
6d0e611fde change when circuits are built and expired 
not quite happy with it yet


svn:r817
 2003-11-16 21:49:52 +00:00
Roger Dingledine
fe856406be initial patches on patches 
svn:r814
 2003-11-16 17:00:02 +00:00
Roger Dingledine
56cd147eb9 let getconfig survive repeated calls. now we call it again when we hup. 
change RecommendedVersions into a config option, so dirservers can hup
  for a new one


svn:r809
 2003-11-13 06:49:25 +00:00
Roger Dingledine
aac29076da warn on startup that we don't provide anonymity 
make exit dns cache entries last 15 minutes


svn:r807
 2003-11-13 04:51:34 +00:00
Roger Dingledine
52589289fe add DirBindAddress, parse the BindAddress's when you bind 
exit if bind fails
add usage printfs
rearrange config options for readability


svn:r674
 2003-10-25 12:01:09 +00:00
Steven Hazel
4139c1c86a - fixed a bug in the id switching code -- setgid has to happen before 
setuid, because after we setuid we don't have the priviledges we
  need to setgid anymore, duh.  merged switch_user() and
  switch_group() into switch_id(), since that code has to be wound
  together.

- return -1 from switch_id() if it's not defined to do anything else.

- moved daemoinize(), write_pidfile(), and switch_id() from main.c to
  util.c


svn:r656
 2003-10-22 11:21:29 +00:00
Steven Hazel
b1eca56b77 added User and Group options -- if you set them, tor will try to 
setuid and setgid respectively, and die if it can't.

(If the User option is set, tor will setgid to the user's gid as well.)

This happens after the pidfile is created, so that in cases where tor
needs to be root to work with the pidfile, it will at least be able to
create it, although it won't be able to delete it.  That sucks, but
it's somewhat better than not being able to create the pidfile in the
first place.


svn:r652
 2003-10-22 06:03:11 +00:00
Roger Dingledine
e4127e4d36 move closer to being able to reload config on HUP 
rename APPort to SocksPort
introduce new tor_free() macro


svn:r642
 2003-10-21 09:48:17 +00:00
Roger Dingledine
b40d0bffa7 a skeletal print_usage() function 
svn:r634
 2003-10-20 01:19:54 +00:00
Roger Dingledine
193383b70a log to stdout while parsing config, 
otherwise we log to nothing and give no feedback!


svn:r617
 2003-10-18 00:13:08 +00:00
Roger Dingledine
0b1afa951e reload the fingerprints file on HUP 
svn:r611
 2003-10-17 05:23:48 +00:00
Roger Dingledine
b3471bbc55 closing stdout *should* be safe (we'll see) 
svn:r601
 2003-10-15 19:27:51 +00:00
Nick Mathewson
ba9b542e93 Report delivery cell fullness correctly 
svn:r600
 2003-10-15 19:25:28 +00:00
Roger Dingledine
11a23fc280 clean up logging, allow user to specify log files 
If DebugLogFile is specified, log to it at -l debug
If LogFile is specified, log to it at the -l from the commandline
  (default info)
If no LogFile *and* not a Daemon, then log to stdout.
Make conn->s = -1 by default (this might break things)
When kill -USR1, prefer to log at INFO, but make sure they always see it.


svn:r596
 2003-10-15 18:50:16 +00:00
Nick Mathewson
7432d97336 Make last commit build 
svn:r593
 2003-10-15 18:37:19 +00:00
Nick Mathewson
959b5585a5 Stop using stdout for non-debugging cases 
svn:r592
 2003-10-15 18:28:32 +00:00
Roger Dingledine
b9628f266f change WARNING to WARN 
and fix a few typos


svn:r571
 2003-10-10 01:48:32 +00:00
Nick Mathewson
ecfb36823e Refactor, rename, and clarify 
svn:r569
 2003-10-09 18:45:14 +00:00
Roger Dingledine
746d64e631 add in basic support for pidfiles 
(patch courtesy aaron turner)


svn:r565
 2003-10-08 08:54:52 +00:00
Nick Mathewson
36939303c9 Update LICENSE and copyright dates. 
svn:r560
 2003-10-08 02:04:08 +00:00