nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-10 21:23:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

must close marked connections at the end of run_scheduled_events.

Browse Source 
otherwise they might have a socket -1, and if we leave them around
they'll muck up poll/select.

i think this was the cause of our win32 and os x fakepoll crashes,
and probably would cause other errors down the road.


svn:r1786
This commit is contained in:
Roger Dingledine 2004-05-05 00:59:42 +00:00
parent efdb356a81
commit 608c156820
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/or/main.c
View File

@ -445,16 +445,12 @@ static void run_scheduled_events(time_t now) {
last_uploaded_services = now;
}
#if 0
/* 6. and blow away any connections that need to die. can't do this later
* because we might open up a circuit and not realize we're about to cull
* the connection it's running over.
* XXX we can remove this step once we audit circuit-building to make sure
* it doesn't pick a marked-for-close conn. -RD
/* 6. and blow away any connections that need to die. have to do this now,
* because if we marked a conn for close and left its socket -1, then
* we'll pass it to poll/select and bad things will happen.
*/
for(i=0;i<nfds;i++)
conn_close_if_marked(i);
#endif
}
static int prepare_for_poll(void) {