nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-09-22 05:54:58 +02:00
Code Issues Packages Projects Releases Wiki Activity
7,866 Commits 53 Branches 629 Tags 108 MiB
e91cab20dd
Commit Graph

697 Commits

Author SHA1 Message Date
Nick Mathewson
6b716fdfb9 NEEDS REVIEW. Act on previous comment, and handle named servers differently: now, we allow multiple servers with the same name in the routerlist even if that name is reserved, but we check whether names are reserved when we try to look up routers by nickname. This is a minor security fix. This makes router_add_to_routerlist O(1). This is a backport candidate. 
svn:r8433
 2006-09-19 23:48:14 +00:00
Nick Mathewson
5ebb949c9f Stop searching routerlist for routers with the same identity as other routers (on router insert): we already have a map for that. (We need to add an index field to routerinfo_t so we can figure out which point in the routerlist to replace.) Also, add a comment to routerlist.c; arma, please advise? 
svn:r8432
 2006-09-19 23:18:30 +00:00
Nick Mathewson
7b0ec744bc Switch routerlist.c to using memcmp on digests rather than crypto_pk_cmp_keys(); speed up find_whitespace a lot (8x for me) by using a switch statement. This should speed parsing a lot of routers at once by a lot. 
svn:r8430
 2006-09-19 22:20:09 +00:00
Nick Mathewson
65974f82fa r8839@Kushana: nickm | 2006-09-17 16:11:59 -0400 
Add some client performance XXXXs; try to move some common case tests higher on their decision trees.


svn:r8410
 2006-09-17 20:12:10 +00:00
Roger Dingledine
769f9201a6 Send out a burst of long-range drop cells after we've established that 
we're reachable. Spread them over 4 circuits, so hopefully a few will
be fast. This exercises our bandwidth and bootstraps us quicker.


svn:r8399
 2006-09-15 05:30:25 +00:00
Peter Palfrader
ba091ae5d7 r9770@danube: weasel | 2006-09-15 07:20:05 +0200 
router_set_networkstatus() gets a list of status documents we asked for from
 connection_dir_client_reached_eof().  However, as a cache we (sometimes?) just
 ask for "all".  router_set_networkstatus() would freak out over that, meaning
 it would log a warning and drop the status document instead of caching it
 as it is supposed to.  Now we let router_set_networkstatus() know if the
 data comes from an all-request so it can do the right thing.


svn:r8398
 2006-09-15 05:20:16 +00:00
Peter Palfrader
5beb114744 r9767@danube: weasel | 2006-09-15 06:27:48 +0200 
Minor documentation fix


svn:r8397
 2006-09-15 04:29:36 +00:00
Nick Mathewson
21a7880358 r8695@Kushana: nickm | 2006-08-31 14:35:36 -0400 
Fix two corner cases in router_dir_info_changed().  This should have no observable effect.


svn:r8311
 2006-08-31 18:46:46 +00:00
Roger Dingledine
94afe807ac stop a big memory leak: we were leaking the whole contents 
of cached-routers.new every time we read it.


svn:r8236
 2006-08-27 02:12:12 +00:00
Roger Dingledine
9f5856c03d stop three memory leaks. nick, fix these if i'm wrong. 
svn:r8235
 2006-08-27 02:07:54 +00:00
Roger Dingledine
6650470575 automatically avoid picking more than one node from the same 
/16 network when constructing a circuit.


svn:r7068
 2006-08-16 03:44:13 +00:00
Nick Mathewson
273ee3e814 r7392@Kushana: nickm | 2006-08-14 23:50:32 -0400 
Only do the expensive version of router_have_minimum_dir_info() when the dir info has changed.  Backport candidate, since oprofile suggests that this function and ones it calls account for 25-35% of oprofile samples.


svn:r7062
 2006-08-15 03:54:09 +00:00
Nick Mathewson
7c596c166b r7029@Kushana: nickm | 2006-08-04 14:08:41 -0700 
Remove now-spurious size and data arguments from tor_mmap_file


svn:r6987
 2006-08-05 17:53:21 +00:00
Nick Mathewson
bf72878cad r7012@Kushana: nickm | 2006-08-03 19:21:25 -0700 
Add an "mmap handle" type to encapsulate bookkeeping elements of mmap issues; add prelim win32 impl


svn:r6980
 2006-08-04 18:32:43 +00:00
Nick Mathewson
ec82db6995 r6909@Kushana: nickm | 2006-07-26 13:05:58 -0400 
Clean up wide lines from last patch.


svn:r6907
 2006-07-26 19:07:37 +00:00
Nick Mathewson
4ff4577beb r6908@Kushana: nickm | 2006-07-26 12:38:52 -0400 
Refactor connection_t into edge, or, dir, control, and base subtypes.  This might save some RAM on busy exit servers, but really matters most in terms of correctness.


svn:r6906
 2006-07-26 19:07:26 +00:00
Roger Dingledine
ee5f512e13 parameterize the loudness of resolve_my_address(), and call things 
IP addresses, not IPs.


svn:r6764
 2006-07-15 20:26:05 +00:00
Nick Mathewson
a7a1d4e3d3 First part of making mmap-based stuff work on win32: save descriptors as "binary" (no LF->CRLF tanslation) so that we can mmap them properly later. Patch from Frediano Ziglio. 
svn:r6748
 2006-07-09 22:28:12 +00:00
Roger Dingledine
c22c7b96f5 tab-man strikes again 
svn:r6699
 2006-06-28 15:39:02 +00:00
Nick Mathewson
8b08ab52fd Fix another idiot bug causing symptom 309. Why cant I program? 
svn:r6698
 2006-06-28 15:36:28 +00:00
Nick Mathewson
96bfefeeb6 Add a check to try to make cache rebuild fail fast if it is going to fail 
svn:r6697
 2006-06-28 11:03:34 +00:00
Nick Mathewson
4dac383f5a Aaand re-disable the bogus test in get_body() 
svn:r6696
 2006-06-28 08:57:41 +00:00
Nick Mathewson
d547ecc916 Make sure that our calculated offsets for routers is correct; again. This time bug 309 may be gone gone gone. 
svn:r6695
 2006-06-28 08:55:53 +00:00
Nick Mathewson
d3784ff1df Likely fix for bug 309: when we calculate offsets after rebuilding the descriptor cache, do not reset the offset pointer half-way through. 
svn:r6693
 2006-06-27 15:52:51 +00:00
Nick Mathewson
52b8dfa95a Fix a bunch of spaces. 
svn:r6678
 2006-06-22 07:25:15 +00:00
Nick Mathewson
58b05fc84d #if out test that was failing because of an extra newline. 
svn:r6676
 2006-06-22 07:10:37 +00:00
Nick Mathewson
b7910202a3 Next batch of memory miserdom: mmap cached-routers file. This is sure to break somewhere. 
svn:r6675
 2006-06-22 07:01:54 +00:00
Nick Mathewson
e2697a62ac When requesting or serving resources via fingerprint/digest, request and respond in-order, removing duplicates. 
svn:r6673
 2006-06-21 04:57:12 +00:00
Nick Mathewson
b5c599412f Backport candidate: implement the "is this uptime change cosmetic" test properly. 
svn:r6654
 2006-06-18 16:05:54 +00:00
Roger Dingledine
30f6c57fd7 and forward-port too. 
svn:r6573
 2006-06-09 06:52:49 +00:00
Roger Dingledine
a91be49402 fix a bootstrapping check we ignored that prevents us from running 
with only one dir authority.


svn:r6570
 2006-06-09 02:45:39 +00:00
Roger Dingledine
bb18168fae ok, ok, maybe *this* time my rep_hist_circbuilding_dormant() will work. 
svn:r6568
 2006-06-08 22:36:13 +00:00
Nick Mathewson
853e2d99b6 Add a new warning to our "warn a lot" list: unused parameters. This means we have to explicitly "use" unuseds, but it can catch bugs. (It caught two coding mistakes so far.) 
svn:r6532
 2006-06-04 22:42:13 +00:00
Roger Dingledine
9000a5aff1 and get grammar right 
svn:r6517
 2006-05-30 06:19:48 +00:00
Roger Dingledine
ae2648fb1c stop fetching descriptors if we're not a dir mirror and we 
haven't tried to establish any circuits lately.


svn:r6516
 2006-05-30 06:19:06 +00:00
Roger Dingledine
60abe23158 tentative change: if you have your dirport set, you are a directory 
mirror, whether or not your orport is set.


svn:r6513
 2006-05-30 06:11:36 +00:00
Roger Dingledine
f579478687 correct a false log message, since we actually reset all our 
downloading stats every hour, and sometimes more often.


svn:r6505
 2006-05-26 16:29:20 +00:00
Roger Dingledine
295ad74fda Tor servers are also giving spurious "you're invalid" warnings. 
This is because we get a lot of network statuses that don't list
us at all, and we conclude that they all think we're invalid.
The long-term fix is to get better logic, and the short-term fix
is to downgrade the log severity.


svn:r6448
 2006-05-09 09:47:47 +00:00
Nick Mathewson
2b720b5746 Start remembering *where* we are storing routerdescs. This will make us easier to move from a RAM-mirrors-disk model to a RAM-caches-disk model, and save maybe around 10MB on a directory server. 
svn:r6427
 2006-04-29 18:42:26 +00:00
Nick Mathewson
15dbe02c04 shorten some too-wide lines 
svn:r6426
 2006-04-29 17:44:31 +00:00
Nick Mathewson
5bce102cd2 Only warn about a down node once 
svn:r6420
 2006-04-25 06:20:47 +00:00
Nick Mathewson
5f9612216c you wanted it spelled properly too? And me not even funded! 
svn:r6418
 2006-04-25 06:02:46 +00:00
Nick Mathewson
d6c04216ef fix a segfault in last bug-285-related commit. 
svn:r6417
 2006-04-25 05:59:31 +00:00
Nick Mathewson
c70f1e7eb3 Possible partial fix for 285; needs review 
svn:r6414
 2006-04-24 17:51:31 +00:00
Roger Dingledine
47d3e23155 note another bug: we complain that a router doesn't exist, 
because it's down so we never fetched it so it doesn't exist.


svn:r6394
 2006-04-17 06:46:20 +00:00
Roger Dingledine
34bc0866d4 slightly clearer log message when you use a nickname rather than 
a key for an unnamed server.


svn:r6393
 2006-04-17 06:43:27 +00:00
Roger Dingledine
3791d3daaa forward-port the n_named log severity downgrade. 
svn:r6385
 2006-04-14 20:19:33 +00:00
Peter Palfrader
beb9e0721a Stop assuming every authority is a v1 authority 
svn:r6377
 2006-04-10 21:29:29 +00:00
Roger Dingledine
f89b0ea09f be willing to add our own routerinfo into the routerlist. 
this means authorities will include themselves in their
directories and network-statuses.


svn:r6369
 2006-04-10 20:00:31 +00:00
Roger Dingledine
b190c451b8 and one more kick to consider all live network statuses for versions 
svn:r6359
 2006-04-10 08:40:16 +00:00
Roger Dingledine
a9e7737c3a consider all live network statuses we have when deciding whether 
our version is bad. also, unfix one of the unbugs from before.


svn:r6358
 2006-04-10 08:37:16 +00:00
Nick Mathewson
71f1a77371 fix bugs in compute_recommended_versions 
svn:r6356
 2006-04-10 08:02:56 +00:00
Roger Dingledine
acc2eb445d and get rid of an extra variable 
svn:r6349
 2006-04-10 05:48:04 +00:00
Roger Dingledine
ac2070b35b stop being so picky about when we can start building circuits. 
now clients are more likely to have circuits up soon after their
tor starts.


svn:r6346
 2006-04-10 05:44:54 +00:00
Nick Mathewson
e258276c2b Change a dumb interface. Also, increment trusted_dir_server_t.n_networkstatus_failures when an all.z download fails entirely or partially. 
svn:r6345
 2006-04-10 01:35:56 +00:00
Roger Dingledine
b6b534c9dd quiet a bootstrapping message 
svn:r6342
 2006-04-09 20:19:56 +00:00
Roger Dingledine
b18d20ce32 Here is an attempted fix for directory mirrors that are frozen 
in fear because they don't have all the networkstatuses. There's
no reason not to proceed if all the other checks are ok -- we just
shouldn't warn about certain things yet.


svn:r6337
 2006-04-09 10:10:09 +00:00
Roger Dingledine
a589650496 i like the name FetchUselessDescriptors better. 
svn:r6327
 2006-04-08 21:48:14 +00:00
Roger Dingledine
2a94c8b493 add a new config option FetchUselessRouters, off by default, for 
when you plan to run "exitlist" on this client and you want to know
about even the non-running descriptors.


svn:r6326
 2006-04-08 21:35:17 +00:00
Roger Dingledine
3a5758e212 If we think of ourselves as authoritative, even if we're not 
in the DirServers config lines, then we still are. This way we
give ourselves the "Authority" flag in our network-status.


svn:r6325
 2006-04-08 21:19:40 +00:00
Roger Dingledine
557b174b8d Break out the checks to see if a routerstatus is something we 
would use. This way when we're deciding if we have "enough" descriptors
to start building circuits, we can count them accurately.


svn:r6320
 2006-04-08 06:56:38 +00:00
Nick Mathewson
7a804572ab fix an infinite loop; answer a question 
svn:r6316
 2006-04-07 22:55:46 +00:00
Nick Mathewson
c6d010b218 Dont warn about our own status unless weve tried and failed 4 times (or succeeded) for each authority. 
svn:r6315
 2006-04-07 04:52:32 +00:00
Roger Dingledine
c4fb9d22cf if there's more than one match for router-get-my-nickname, 
try to pick one that's running.


svn:r6313
 2006-04-04 03:46:40 +00:00
Roger Dingledine
0825f61102 fix crash bug reported in flyspray 279. 
svn:r6312
 2006-04-04 03:25:36 +00:00
Roger Dingledine
453062b028 fix typo, remove extraneous variable 
svn:r6311
 2006-04-03 11:24:14 +00:00
Roger Dingledine
7198af7fbe one more edge case that could paralyze a client with fear 
svn:r6310
 2006-04-03 06:59:07 +00:00
Roger Dingledine
a324871603 phrase the threshold comparison in the way we've been 
phrasing it. these are equivalent, right?


svn:r6309
 2006-04-03 06:37:35 +00:00
Nick Mathewson
eba6204315 fix some xxxs. 
svn:r6307
 2006-04-03 06:23:24 +00:00
Roger Dingledine
2cb3aeb4e1 another point that needs more thinking 
svn:r6306
 2006-04-03 06:22:54 +00:00
Roger Dingledine
9549d81d95 two more thresholds to look at 
svn:r6305
 2006-04-03 06:10:33 +00:00
Roger Dingledine
64a40b5137 nick: there *is* no MAX_SERVER_INTERVAL_WITHOUT_REQUEST. true? 
svn:r6300
 2006-04-03 02:20:32 +00:00
Nick Mathewson
4130460f8e Change networkstatus dl logic: try to have all networkstatuses live; insist on having all of them live or tried-at-least-once. Also, answer a XXXX comment. 
svn:r6297
 2006-04-02 23:02:52 +00:00
Roger Dingledine
1f4d0d2479 When deciding whether a router is Fast or Guard-worthy, consider 
his advertised BandwidthRate and not just the BandwidthCapacity.

This is a bug in 0.1.0.x as well, but let's not bother backporting.


svn:r6266
 2006-03-28 12:01:58 +00:00
Nick Mathewson
685bceed1c Make the max number of old descriptors to hold rise with the number of authorities. 
svn:r6254
 2006-03-27 17:29:53 +00:00
Nick Mathewson
cd271dbca9 re-order to avoid free-then-use. Thank goodness tor_free() zeroes things. 
svn:r6249
 2006-03-27 05:27:47 +00:00
Nick Mathewson
c74bd877e2 Oops. We may not have a networkstatus list when we first parse the cached routers. 
svn:r6248
 2006-03-27 05:12:07 +00:00
Nick Mathewson
3e8c9a485f Fix for "but need_to_mirror=1" annoyance; is bug 273 fixed? 
svn:r6247
 2006-03-27 05:07:57 +00:00
Roger Dingledine
6f08d121d9 Refactor and consolidate addr/exit policies into a new policies.c. 
Fix some minor bugs and memory leaks along the way.


svn:r6246
 2006-03-27 02:25:34 +00:00
Roger Dingledine
e20aad8d46 remove obsolete address policy code 
svn:r6243
 2006-03-26 09:38:17 +00:00
Roger Dingledine
f2abd7a69b fix a wordo, don't be so quick to yell at servers, and ask a question. 
svn:r6235
 2006-03-24 21:11:14 +00:00
Peter Palfrader
444e3b8eb2 Note a magic 2 that probably should be replaced now that we have more dirservers 
svn:r6232
 2006-03-23 20:21:54 +00:00
Roger Dingledine
0d7efbe65d Note a vulnerability with our current recommended-version concensus 
building.

Make the warnings about invalid and unnamed nodes scale better, and
update the text of the warnings.

Change router_have_minimum_dir_info() to only be happy when it has
enough network-statuses ("more than half") to be willing to actually
build circuits.

Not yet done: when we fail to get a networkstatus that we wanted, and
!router_have_minimum_dir_info(), we should retry it quicker than a whole
minute from now.


svn:r6227
 2006-03-22 06:22:12 +00:00
Roger Dingledine
073d574a3f Point out a potential DoS flaw in caching untrusted network 
statuses to disk. We should resolve sometime.


svn:r6206
 2006-03-21 05:27:35 +00:00
Roger Dingledine
c06e6ddadd Finish the transition from the word 'verified' to the words 
'named' and 'valid'.


svn:r6188
 2006-03-19 01:21:59 +00:00
Roger Dingledine
67b61fe475 authdirs shouldn't complain about unreachability when they 
fetch a descriptor from somebody else. this is not the right
time to increment the failure count.


svn:r6184
 2006-03-18 05:37:15 +00:00
Roger Dingledine
581795f41d auth dir servers were only modifying a server's is_running field 
when they created a network status. so if nobody asked for a
network status, they would never discover that any servers are
is_running, so they could never build a circuit.


svn:r6183
 2006-03-18 01:24:04 +00:00
Roger Dingledine
cf6ba3e76f let an authdir that's not a naming authdir start even 
if it doesn't have an approved-routers file. if it does,
read it and parse it as usual.


svn:r6182
 2006-03-18 00:22:23 +00:00
Roger Dingledine
817556315a Implement router purposes, and don't choose a non-general 
purpose router when picking random nodes for a circuit.

Also implement SETROUTERPURPOSE and modify +POSTDESCRIPTOR.

This concludes bug 250 assuming it all works.


svn:r6178
 2006-03-17 22:08:59 +00:00
Nick Mathewson
053411e827 Comments: cleanups and additions. 
svn:r6174
 2006-03-17 05:50:41 +00:00
Nick Mathewson
215e377224 Only warn about lack of name binding for self if we have tried downloading every networkstatus. 
svn:r6172
 2006-03-17 04:41:57 +00:00
Nick Mathewson
13cf54b9c1 Interim fix for 272: Only warn that we are not named if we have status docs from some naming authorities. 
svn:r6166
 2006-03-15 05:37:27 +00:00
Roger Dingledine
903183ea28 if we as a directory mirror don't know of any v1 directory 
authorities, then don't try to cache any v1 directories.


svn:r6162
 2006-03-15 00:10:13 +00:00
Peter Palfrader
a4ec555228 change INET_NTOA_BUF_LEN+1 to INET_NTOA_BUF_LEN 
add a comment in a few places where we add weird numbers to buffer lengths


svn:r6161
 2006-03-14 23:40:37 +00:00
Nick Mathewson
bd8ffccae7 More cleanups noticed by weasel; also, remove macros that nobody uses. 
svn:r6143
 2006-03-12 23:31:16 +00:00
Nick Mathewson
474c60b743 Cleanup on time-relaqted constants. New conventions: 
1) Surround all constants by (parens), whether we'll be using them
     in a denominator or not.
  2) Express all time periods as products (24*60*60), not as multiplied-out
     constants (86400).
  3) Comments like "(60*60) /* one hour */" are as pointless as comments
     like "c = a + b; /* set c to the sum of a and b */".  Remove them.
  4) All time periods should be #defined constants, not given inline.
  5) All time periods should have doxygen comments.
  6) All time periods, unless specified, are in seconds.  It's not necessary
     to say so.

To summarize, the old (lack of) style would allow:

  #define FOO_RETRY_INTERVAL 60*60 /* one hour (seconds) */
  next_try = now + 3600;

The new style is:

  /** How often do we reattempt foo? */
  #define FOO_RETRY_INTERVAL (60*60)

  next_try = now + RETRY_INTERVAL;


svn:r6142
 2006-03-12 22:48:18 +00:00
Roger Dingledine
c8e2a051ac huge warning sign for esc_router_info() 
svn:r6124
 2006-03-11 17:52:55 +00:00
Nick Mathewson
4d3e709c4b Use escaped() for remaining cases. 
svn:r6117
 2006-03-11 02:21:30 +00:00
Nick Mathewson
1ce3713889 Possible bug 265 fix: authorities must be more strict than clients about age of acceptable routers; make routers publish every 12 hours; client ROUTER_MAX_AGE must be greater than NETWORKSTATUS_MAX_AGE+authoirty ROUTER_MAX_AGE. 
svn:r6095
 2006-03-08 06:29:52 +00:00
Roger Dingledine
89b07b458b i missed the other half of that grammar fix 
svn:r6058
 2006-02-21 03:55:47 +00:00
Peter Palfrader
c4f389420c Improve the "we have been waiting for 1140377851 seconds" log 
svn:r6046
 2006-02-19 19:44:09 +00:00
Roger Dingledine
f6d80d60e0 don't warn when we get a server descriptor from the controller 
but it's too old. that's not something tor should fix.


svn:r6019
 2006-02-15 03:01:53 +00:00
Peter Palfrader
5eea6c76df Split ReachableAddresses into ReachableDirAddresses and ReachableORAddresses 
svn:r6009
 2006-02-13 21:17:20 +00:00
Roger Dingledine
259c65ab08 the last of the log convention conversion. finally. 
svn:r6005
 2006-02-13 10:33:00 +00:00
Roger Dingledine
b7781ea208 bugfix: we were ignoring the IS_FAST flag in the directory 
status, meaning we were willing to pick trivial-bandwidth nodes
for "fast" connections.


svn:r5992
 2006-02-13 00:09:30 +00:00
Roger Dingledine
3c4e68488b Clients now honor the "guard" flag in the router status when 
picking entry guards, rather than looking at is_fast or is_stable.

Now dirservers can change how they define it and clients will
automatically use their new definition.


svn:r5979
 2006-02-12 03:43:39 +00:00
Roger Dingledine
85a64b4fd0 get our grammar right when complaining about un-recommended versions 
svn:r5950
 2006-02-09 06:08:59 +00:00
Roger Dingledine
5f051574d5 Happy new year! 
svn:r5949
 2006-02-09 05:46:49 +00:00
Nick Mathewson
e5a574ce2e Move "sort list of versions" logic into routerparse.c; make version-checking code say which versions it would have accepted. (not tested.) 
svn:r5927
 2006-02-06 05:04:27 +00:00
Roger Dingledine
a9c87fe251 more typos and nits 
svn:r5918
 2006-02-05 05:28:52 +00:00
Nick Mathewson
157e6a025a Stupid cut-and-paste bug. 
svn:r5917
 2006-02-05 05:11:24 +00:00
Roger Dingledine
d602d0d298 cosmetic fix 
svn:r5915
 2006-02-05 03:42:04 +00:00
Roger Dingledine
640882c76c clean up tabs and wide-lines from weasel's commit 
svn:r5914
 2006-02-05 03:23:16 +00:00
Roger Dingledine
53f86cdf5d fix bug: we were caching the newest descriptor for each server, 
well, forever. i imagine this just keeps growing in size.


svn:r5912
 2006-02-05 02:07:28 +00:00
Peter Palfrader
390bbb0a0c Try to make tor work better through squid: Limit number of descriptors we fetch 
to 96 (was 128 previously).

We limit this number even when we do not have a http proxy explicitly
configured as some people mistakenly believe transparent proxies are a neat
idea.


svn:r5901
 2006-02-03 15:17:48 +00:00
Roger Dingledine
92ef9e37e7 Add a new config option ExitPolicyRejectPrivate which defaults to 1. 
This means all exit policies will begin with rejecting private addresses,
unless the server operator explicitly turns it off.

Also, make our code to remove redundancies in the exit policy smarter,
so it can detect "reject foo, reject bar, reject *" patterns.

Lastly, we can get rid of the "exit policy implicitly accepts" code,
since we make everything more explicit now.


svn:r5888
 2006-02-01 03:53:52 +00:00
Peter Palfrader
bf514e5dc5 Try to fix policy_includes_addr_mask_implicitly() 
svn:r5886
 2006-02-01 02:52:55 +00:00
Peter Palfrader
61ea27620a Also catch 0/8 in exit_policy_implicitly_allows_local_networks() 
svn:r5885
 2006-02-01 02:31:27 +00:00
Roger Dingledine
2eabf190e9 make it louder when we're running an unrecommended version. 
also, we need to tell them what versions *are* recommended.
i'll add that to the todo.


svn:r5859
 2006-01-24 03:45:58 +00:00
Nick Mathewson
9f42c9d650 Make dirservers generate a separate "guard" flag to mean, "would make a good entry guard". Make clients parse it and vote on it. 
svn:r5856
 2006-01-24 00:31:16 +00:00
Roger Dingledine
b9540285af remove unused code 
svn:r5847
 2006-01-20 20:54:42 +00:00
Roger Dingledine
d5acef191c add another assert to make sure we're not scribbling on the stack. 
svn:r5837
 2006-01-17 04:14:04 +00:00
Nick Mathewson
1057516a07 Clients should not download descriptors for non-running descriptors. 
svn:r5830
 2006-01-16 20:52:30 +00:00
Nick Mathewson
2dd566d5d5 Indirect access to the signed_descriptor field to make it easier to keep them lazily on disk. 
svn:r5827
 2006-01-12 18:04:17 +00:00
Roger Dingledine
0e51d5d274 When the controller was submitting a descriptor, we were checking to make 
sure some network-status we had referred to it, and refusing it if not.
This is bad for people who want to insert descriptors that aren't part of
the current Tor network. Now we accept them, and also give a more useful
warn message if we ask a dir mirror for a given descriptor and it gives us
one we weren't expecting.


svn:r5824
 2006-01-12 03:43:39 +00:00
Nick Mathewson
eb78295e4e Fix memory leak in routerlist_remove_old_routers(). 
svn:r5790
 2006-01-11 03:58:07 +00:00
Roger Dingledine
7d1f675c85 entry nodes are now entry guards. 
this is our last easy chance for a wholesale change. heave ho.


svn:r5782
 2006-01-10 22:42:44 +00:00
Nick Mathewson
43a4f8c7f3 Be more aggressive about throwing away expired router descriptors: they are of no use to anybody. Better still: dont serve expired descriptors by fingerprint. The only people who ask for them are busted 0.1.1.10 Tors that will throw them away and re-request them after 30 minutes. 
svn:r5762
 2006-01-10 04:57:12 +00:00
Nick Mathewson
56c55c343e When picking a random directory, prefer non-authorities if any are known. 
svn:r5761
 2006-01-09 23:39:07 +00:00
Nick Mathewson
e30516f33f Fix bug 236: caches should cache up to 16 unrecognized network-status docs. 
svn:r5754
 2006-01-08 21:26:33 +00:00
Nick Mathewson
50b6b3258d Dont call directory_get_from_dirserver when you have a particular dirserver in mind; remove fetch-from-authority special-case in directory_get_from_dirserver. 
svn:r5741
 2006-01-06 18:19:17 +00:00
Roger Dingledine
6aaa92f736 short-circuit half the cost of node-picking in the general case. 
svn:r5732
 2006-01-05 10:59:46 +00:00
Roger Dingledine
f8a59965a1 cleanups, and remove some unreachable code. 
svn:r5727
 2006-01-04 06:43:03 +00:00
Roger Dingledine
485aa9415d authdirs now stop whining so loudly about bad descriptors that they fetch 
from other dirservers. now when there's a log complaint, it's for sure
from a freshly uploaded descriptor.


svn:r5726
 2006-01-04 04:42:10 +00:00
Roger Dingledine
f6f65c66b5 oh, it was supposed to compile? 
svn:r5721
 2006-01-03 13:12:17 +00:00
Roger Dingledine
da06f3553c don't try to build circuits until we have 3 running servers; 
and for networks that are very small, having more than a quarter
of the descriptors is much harder than having equal to or more than
a quarter of the descriptors -- follow the spec.


svn:r5720
 2006-01-03 13:09:49 +00:00
Roger Dingledine
9af33ef39c when we choose not to use a server descriptor from our cache, don't 
log it so loudly.


svn:r5713
 2006-01-03 10:42:20 +00:00
Roger Dingledine
5947388968 Finish implementing config's EntryNodes and StrictEntryNodes option. 
The logging is way verbose for now.


svn:r5683
 2005-12-31 06:32:57 +00:00
Roger Dingledine
0dc8e284f8 load balance a bit better by taking some load off the really 
fast servers.
this might slow things down more, or it might not. hm.


svn:r5681
 2005-12-30 04:46:43 +00:00
Roger Dingledine
c051e82f69 fix a typo 
svn:r5680
 2005-12-30 04:44:10 +00:00
Nick Mathewson
fc850273bd Appease some verbose GCC warnings. 
svn:r5679
 2005-12-29 20:25:53 +00:00
Roger Dingledine
dbd7b97eff helper nodes are dead. long live entry nodes. 
(config options EntryNodes and StrictEntryNodes still not
implemented.)


svn:r5673
 2005-12-28 09:07:31 +00:00
Nick Mathewson
9ef54a3d0c Make directory caches a little less chatty when logging 
svn:r5662
 2005-12-27 06:05:54 +00:00
Nick Mathewson
fa0d5aa894 Make insert_old try hard to never add a duplicate. 
svn:r5661
 2005-12-27 05:58:12 +00:00
Nick Mathewson
ece9865020 Implement new directory logic: download by descriptor digest, not by key digest. Caches try to download all listed digests from authorities; clients try to download "best" digests from caches. 
svn:r5659
 2005-12-27 05:26:03 +00:00
Roger Dingledine
34249e8861 fix segfault when specifying DirServer without nickname 
(reported by weasel)


svn:r5614
 2005-12-18 22:45:27 +00:00
Nick Mathewson
6b5fc9d46f Instead of "Network down", say "Is your network connection down?" 
svn:r5607
 2005-12-15 22:10:03 +00:00
Roger Dingledine
edde3fcf25 ah ha, that variable was static. not useless after all. 
svn:r5604
 2005-12-15 21:44:23 +00:00
Roger Dingledine
002c9b3589 clean up a lot message, and remove a line that does nothing. 
svn:r5603
 2005-12-15 21:41:27 +00:00
Nick Mathewson
cf8c70b79c fix compile 
svn:r5600
 2005-12-15 21:38:59 +00:00
Nick Mathewson
280c62314e Make clients look at the fast and stable flags in networkstatus, not at the bandwidth and uptime declared in the router descriptors. 
svn:r5599
 2005-12-15 21:30:57 +00:00
Roger Dingledine
3489066433 put back in a todo comment, so we don't forget. 
svn:r5598
 2005-12-15 21:26:52 +00:00
Nick Mathewson
24e79df0b6 Whitespace fixes; comments. 
svn:r5596
 2005-12-15 21:17:40 +00:00
Nick Mathewson
6b1305aeeb Flip a misplaced not 
svn:r5593
 2005-12-15 20:56:46 +00:00
Nick Mathewson
ce71b17224 Clean fake_status a bit. Switch from has_fetched_directory to have_minimum_dir_info, and make the latter function smarter. 
svn:r5591
 2005-12-15 20:44:15 +00:00
Roger Dingledine
25e1ad02fa implement weasel's suggestion to fix the bug that newly bootstrapped 
tor networks couldn't do hidden services until they had nodes with high
uptime: if you're trying to pick a node for your circuit and you demand
uptime or capacity and nothing works, then abandon your need for uptime
and capacity.


svn:r5589
 2005-12-15 09:53:00 +00:00
Nick Mathewson
7af95e5c06 When we mark a router as down, also mark its local_routerstatus as not running. This way, we do not use directories that are believed to be down. 
svn:r5587
 2005-12-14 22:05:10 +00:00
Nick Mathewson
9482b1b9d5 Choose directory servers from routerstatus list, not from routerinfo list. This way, as soon was we have a networkstatus, we can ask a cache to give us routers, rather than needing to ask the directories. 
svn:r5586
 2005-12-14 22:00:58 +00:00
Nick Mathewson
1af630d32c Bite the bullet and limit all our source lines to 80 characters, the way IBM intended. 
svn:r5582
 2005-12-14 20:40:40 +00:00
Nick Mathewson
32126cced1 Make directory authorities ignore router uploads that have only cosmetic differences: now regardless of version! 
svn:r5573
 2005-12-12 01:02:08 +00:00
Roger Dingledine
58366ffd24 when we changed from log_fn to debug/info/notice/warn/err, 
we screwed up the formatting in wild and unpredictable ways.

fix it before it becomes convention to format logs in wild and
unpredictable ways.

still need to do src/common/ someday.


svn:r5551
 2005-12-10 09:36:26 +00:00
Roger Dingledine
9b0a40ec78 crank the max line limit down to 150 chars. 
svn:r5550
 2005-12-10 08:27:01 +00:00
Nick Mathewson
39265dd72e In my private little universe, terminals are still 80 columns. Impose a 160-character-per-line limit; this will creep down. 
svn:r5548
 2005-12-09 05:37:26 +00:00
Nick Mathewson
b1d034d2ab Fix bug 212: Directory authorities should not try to download server descriptors that they know they will reject. 
svn:r5514
 2005-12-06 06:55:43 +00:00
Nick Mathewson
9cec3a13f5 remove some functions that are not used; #if0 out some files that are not likely to be used. 
svn:r5471
 2005-11-30 06:27:59 +00:00
Nick Mathewson
3bd613b44d Rename connection_get_by_identity_digest to reflect that it is OR-only. Make it use a hashtable instead of a linear search. 
svn:r5469
 2005-11-30 03:01:16 +00:00
Nick Mathewson
7de0c33857 Avoid a segfault in routerlist_reset_warnings() 
svn:r5464
 2005-11-28 16:29:27 +00:00
Roger Dingledine
0118a236a4 comment that scary-looking function. 
svn:r5447
 2005-11-23 07:30:44 +00:00
Nick Mathewson
eb0021b06e Fix dumb logic error that kept some old descripttors from getting the axe. 
svn:r5446
 2005-11-23 07:28:54 +00:00
Nick Mathewson
061ef582a1 Make dropping very old descriptors faster (remove old correctness check). Track bytes dropped that are still in our store or journal, and rebuild when it gets very high. 
svn:r5445
 2005-11-23 07:24:59 +00:00
Nick Mathewson
36109fea33 e more aggressive about calling routerlist_remove_old_routers() 
svn:r5444
 2005-11-23 07:06:36 +00:00
Nick Mathewson
fbf8a8c25f Dump bytes held to store descriptors. 
svn:r5443
 2005-11-23 06:00:58 +00:00
Nick Mathewson
7d7bb95f36 Track how many bytes we have in signed descriptors. Try to make sure we are tracking this right. Somebody should valgrind a dirserver on an example net. There should be code to dump this value. 
svn:r5442
 2005-11-23 05:47:51 +00:00
Nick Mathewson
50ce5e1932 Avoid spurious re-launch of first pending requested descriptor 
svn:r5439
 2005-11-22 02:20:05 +00:00
Roger Dingledine
f28770b639 be less eager to decide that the entire network is down 
svn:r5434
 2005-11-19 11:04:00 +00:00
Roger Dingledine
859d1c902a and another instance where i was trying to be too sneaky 
svn:r5433
 2005-11-19 10:38:23 +00:00
Roger Dingledine
5c949fce51 Start obeying our firewall options more rigorously: 
- If we can't get to a dirserver directly, try going via Tor.
  - Don't ever try to connect (as a client) to a place our firewall
    options forbid.
  - If we specify a proxy and also firewall options, obey the firewall
    options even when we're using the proxy: some proxies can only proxy
    to certain destinations.


svn:r5431
 2005-11-19 10:12:10 +00:00
Roger Dingledine
7aae63994f Recover better from TCP connections to Tor servers that are broken but 
don't tell you (it happens!); and rotate TLS connections once a week.

1) If an OR conn becomes more than a week old, make it obsolete.
2) If it's obsolete and empty, kill it.
3) When an OR makes a second connection to you, allow it.
4) If we want to send a new create cell, but the best conn we've
   got is obsolete, and the router is 0.1.1.9-alpha-cvs or later, ask
   for a new conn instead.
5) When we time out on circuit building on the first hop, make that
   connection obsolete.


svn:r5429
 2005-11-19 06:57:44 +00:00
Roger Dingledine
afb1c79879 Leave options->DirServers alone -- if the user didn't specify any, 
just add the default ones directly to the trusted dirserver list.
This fixes a bug where people running controllers would setconf or
the equivalent, and Tor would start yelling at them about setting
their own DirServer lines.


svn:r5418
 2005-11-18 02:47:09 +00:00
Roger Dingledine
aa53190ed5 and another one 
svn:r5416
 2005-11-17 22:23:18 +00:00
Roger Dingledine
9111a3fb48 comment out some really popular log lines 
svn:r5415
 2005-11-17 22:19:35 +00:00
Roger Dingledine
fe7b07754f make it even more clear that i didn't screw up the logic 
svn:r5378
 2005-11-15 09:57:58 +00:00
Roger Dingledine
53269f696d fix logic error: not unnamed is good. 
svn:r5377
 2005-11-15 09:15:43 +00:00
Nick Mathewson
9b432311c4 Make new logging stuff work on windows; fix a couple of windows typos. 
svn:r5375
 2005-11-15 03:05:23 +00:00
Roger Dingledine
4d1c6bbfc4 fix function comment 
svn:r5356
 2005-11-11 17:16:24 +00:00
Roger Dingledine
c074f528c1 fix a harmless warn and mark two points where we should 
maybe change our approach.


svn:r5352
 2005-11-11 17:01:20 +00:00
Nick Mathewson
75d85c8214 On directory servers, old_routers was wasting hundreds of bytes per superseded router descriptor. Roll the signed descriptor info and identifying info into a cache_info struct, and use only that for old_routers. 
svn:r5349
 2005-11-05 20:15:27 +00:00
Nick Mathewson
757def59b6 Fix bugs in routerlist_remove_old_cached_routers_with_id() 
svn:r5348
 2005-11-04 16:47:26 +00:00
Nick Mathewson
9e82f0cdb7 enable code to remove members of old_routers when it gets big. 
svn:r5345
 2005-11-01 17:34:17 +00:00
Roger Dingledine
6dafca62f0 remove redundant checking for . and .. now that 
tor_listdir() checks for this too.


svn:r5337
 2005-11-01 03:50:14 +00:00
Roger Dingledine
1991f6cf48 more doc cleanups and reorganizing 
svn:r5336
 2005-11-01 03:48:51 +00:00
Roger Dingledine
862e8a1bd1 fix typo 
svn:r5331
 2005-10-29 18:00:25 +00:00
Nick Mathewson
ed32d85a04 router_add_to_routerlist() really needs to free not-added routers. 
svn:r5328
 2005-10-28 18:44:51 +00:00
Nick Mathewson
7643c5254c Fix an annoying rep violation bug 
svn:r5325
 2005-10-27 23:06:09 +00:00
Nick Mathewson
e594ce92fe Start making directory caches retain old routerinfo_t. The code to remove old ones is definitely some textbook C problem. 
svn:r5323
 2005-10-27 00:34:39 +00:00
Nick Mathewson
b39d03116b remove some commented-out code that may tempt us to do ill 
svn:r5320
 2005-10-25 18:38:44 +00:00
Nick Mathewson
5d85560d9e Remove last vestiges of old logging interface. 
svn:r5317
 2005-10-25 18:01:01 +00:00
Nick Mathewson
f9b0be526e Use LD_BUG as appropriate; convert rend* and router* to new logging interface; use new circ_log_path interface 
svn:r5302
 2005-10-24 19:39:45 +00:00
Roger Dingledine
d6dcd973c3 Oct 19 13:27:24.391 [info] router_reload_networkstatus(): Skipping cached-status file with unexpected name "." 
Oct 19 13:27:24.391 [info] router_reload_networkstatus(): Skipping cached-status file with unexpected name ".."


svn:r5291
 2005-10-20 17:22:00 +00:00
Nick Mathewson
52eaccce44 Crank down the frequency for replacing unchanged descriptors 
svn:r5290
 2005-10-19 16:21:19 +00:00