1164 Commits

Author	SHA1	Message	Date
Nick Mathewson	c43fee131d	Adjust EWMA patch to conform to whitespace style.	2009-12-12 19:06:38 -05:00
Can Tang	d3be00e0f4	Favor quiet circuits when choosing which order to relay cells in. ... Each circuit is ranked in terms of how many cells from it have been relayed recently, using a time-weighted average. This patch has been tested this on a private Tor network on PlanetLab, and gotten improvements of 12-35% in time it takes to fetch a small web page while there's a simultaneous large data transfer going on simultaneously. [Commit msg by nickm based on mail from Ian Goldberg.]	2009-12-12 19:06:38 -05:00
Nick Mathewson	0c1b3070cf	Now that FOO_free(NULL) always works, remove checks before calling it.	2009-12-12 02:07:59 -05:00
Sebastian Hahn	3807db001d	*_free functions now accept NULL ... Some *_free functions threw asserts when passed NULL. Now all of them accept NULL as input and perform no action when called that way. This gains us consistence for our free functions, and allows some code simplifications where an explicit null check is no longer necessary.	2009-12-12 03:29:44 +01:00
Sebastian Hahn	f258647433	Allow SafeLogging to exclude client related information	2009-12-12 02:26:11 +01:00
Roger Dingledine	4f8b36a1e2	clobber connections with different number than we clobber circuits	2009-11-21 23:02:10 -05:00
Roger Dingledine	7b6b931ccc	stop assuming that our downcasts have a struct offset of 0 ... shouldn't actually change anything, but who knows.	2009-11-21 22:59:18 -05:00
Nick Mathewson	5e4d53d535	Remove checks for array existence. (CID 410..415) ... In C, the code "char x[10]; if (x) {...}" always takes the true branch of the if statement. Coverity notices this now. In some cases, we were testing arrays to make sure that an operation we wanted to do would suceed. Those cases are now always-true. In some cases, we were testing arrays to see if something was _set_. Those caes are now tests for strlen(s), or tests for !tor_mem_is_zero(d,len).	2009-10-26 22:40:41 -04:00
Roger Dingledine	1c62b9d5fa	fix a bug where we were decrementing the wrong bucket ... i think this doesn't actually affect anything, since linked conns usually don't impact buckets	2009-10-10 14:52:41 -04:00
Roger Dingledine	86af2ecbda	minor fixes in some comments	2009-09-06 20:09:08 -04:00
Nick Mathewson	1d9b8a1e16	Merge commit 'karsten/proposal-166-impl-master'	2009-08-26 11:36:40 -04:00
Nick Mathewson	707a6bd659	Merge commit 'public/socks-client' ... Resolved conflict in: src/or/or.h	2009-08-26 11:27:19 -04:00
Nick Mathewson	903f9ef50e	Clean up a couple of style issues in the socks-client branch.	2009-08-25 10:30:54 -04:00
Karsten Loesing	4e29f33427	Write all statistics to disk exactly every 24 hours.	2009-08-19 15:41:12 +02:00
Karsten Loesing	dccadb30cd	Clean up proposal 166 and its implementation.	2009-08-18 15:53:08 +02:00
Karsten Loesing	ab7729f472	Remove ./configure option for entry and dir request statistics.	2009-08-17 13:29:50 +02:00
Karsten Loesing	8c496d1660	Some tweaks to statistics. ... Changes to directory request statistics: - Rename GEOIP statistics to DIRREQ statistics, because they now include more than only GeoIP-based statistics, whereas other statistics are GeoIP-dependent, too. - Rename output file from geoip-stats to dirreq-stats. - Add new config option DirReqStatistics that is required to measure directory request statistics. - Clean up ChangeLog. Also ensure that entry guards statistics have access to a local GeoIP database.	2009-07-15 16:32:40 +02:00
Karsten Loesing	416940d93b	Some tweaks to directory request download times. ... - Use common prefixes DIRREQ_* and dirreq_*. - Replace enums in structs with bitfields.	2009-07-15 16:14:14 +02:00
Karsten Loesing	3c05132575	Directories now also measure download times of network statuses.	2009-07-15 16:12:45 +02:00
Karsten Loesing	4d6af73db8	If configured, write per-port exit statistics to disk periodically. ... [Original patch series from Karsten, revised and squashed by Nick]	2009-07-02 12:37:05 -04:00
Christopher Davis	75472c19c3	Enable Tor to connect through SOCKS 4/5 proxies ... Added a sanity check in config.c and a check in directory.c directory_initiate_command_rend() to catch any direct connection attempts when a socks proxy is configured.	2009-06-19 12:16:15 -04:00
Nick Mathewson	1e709c79d1	Isolate Libevent API dependency to just main.c and dns.c in src/or. ... The rest of the code was only including event.h so that it could see EV_READ and EV_WRITE, which we were using as part of the connection_watch_events interface for no very good reason.	2009-06-12 14:27:53 -04:00
Nick Mathewson	cb18fc2190	Merge commit 'origin/maint-0.2.1'	2009-05-27 18:12:18 -04:00
Nick Mathewson	ec7e054668	Spell-check Tor.	2009-05-27 17:55:51 -04:00
Mike Perry	29bf271ba2	Fix misreporting of stream bandwidths.	2009-05-14 17:52:26 -04:00
potentiate	1b61c8bf37	Fix misreporting of stream bandwidths.	2009-05-14 17:50:06 -04:00
Karsten Loesing	948835c680	Remove unused rendversion parameters. YAGNI.	2009-05-04 13:46:30 -04:00
Karsten Loesing	f79688ddef	Clients do not request version 0 hidserv descs anymore.	2009-05-04 13:46:30 -04:00
Karsten Loesing	9b32e8c141	Update copyright to 2009.	2009-05-04 11:28:27 -04:00
Karsten Loesing	4ebcc4da34	Update copyright to 2009.	2009-05-02 22:00:54 +02:00
Roger Dingledine	decdf4537a	If we're using bridges and our network goes away, be more willing ... to forgive our bridges and try again when we get an application request. Bugfix on 0.2.0.x. svn:r18396	2009-02-04 23:27:35 +00:00
Nick Mathewson	c4b8fef362	Remove svn $Id$s from our source, and remove tor --version --version. ... The subversion $Id$ fields made every commit force a rebuild of whatever file got committed. They were not actually useful for telling the version of Tor files in the wild. svn:r17867	2009-01-04 00:35:51 +00:00
Nick Mathewson	3a8a2cb2de	Downgrade some xxx021s, comment more on others, etc ... svn:r17823	2008-12-29 20:17:24 +00:00
Nick Mathewson	f7fb1bf931	Refactor sockaddr family match check into a new function ... svn:r17820	2008-12-29 19:57:17 +00:00
Nick Mathewson	ae71b52945	remove the responsibility for setting listensocklen to the function that made the sockaddr ... svn:r17799	2008-12-27 15:46:13 +00:00
Nick Mathewson	a87335472c	Make connection_create_listener take a sockaddr_len, not just a sockaddr whose length we try to divine. ... svn:r17792	2008-12-27 00:20:06 +00:00
Nick Mathewson	df5e8f65bc	Add more missing documentation, and correct an error in container.c documentation: Don't introduce two parameters called n when you're calling an algorithm O(n). ... svn:r17783	2008-12-26 17:35:08 +00:00
Nick Mathewson	b68379b13b	Add DOCDOC entries for undocumented static and global variables. ... svn:r17739	2008-12-22 19:00:05 +00:00
Nick Mathewson	1e5f457461	Fix most DOCDOCs remaining and/or added by redox. ... svn:r17734	2008-12-22 17:53:04 +00:00
Nick Mathewson	1725c0c8a5	Add DOCDOC comments for all undocumented functions. Add missing *s to other comments so that they will get recognized as doxygen. ... svn:r17729	2008-12-22 14:56:28 +00:00
Nick Mathewson	bf80e2df3f	Replace calls to time(NULL) that occur on the order of once per read, one per write, or once per cell with calls to a function that looks at a cached value of time. This is tricksy to benchmark, since it will only help on systems where time() is a syscall and syscalls are relatively slow. ... svn:r17690	2008-12-18 17:19:04 +00:00
Nick Mathewson	122170c1d3	Downlgrade tweak, and answer lots of XXX021s. No actual code fixes in this patch. ... svn:r17686	2008-12-18 16:11:24 +00:00
Nick Mathewson	ecaee1d927	Remove fixed xxx020s; downgrade unfixed ones. ... (The unfixed ones are being downgraded to regular XXXs mainly on the rationale that they don't seem to be exploding Tor, and they were apparently not showstoppers for 0.2.0.x-final.) svn:r17682	2008-12-18 16:11:03 +00:00
Nick Mathewson	7678ac5193	Move edge-only flags from connection_t to edge_connection_t. ... svn:r17643	2008-12-17 14:59:28 +00:00
Nick Mathewson	04ec7d1f98	Now that tor_assert is no longer using a broken force-to-boolean formulation, we can tor_assert a bitfield without a gcc compile error. ... svn:r17598	2008-12-11 20:28:50 +00:00
Nick Mathewson	ae33d3ead7	Apply rovv's fix for bug 824. ... svn:r16975	2008-09-26 15:30:26 +00:00
Nick Mathewson	8bc1536a9e	Add patch 4 from Karsten for proposal 121, slightly modified. Karsten should definitely re-review the bits I changed. ... svn:r16955	2008-09-24 14:44:29 +00:00
Roger Dingledine	4fd9880540	give rend_client_desc_here a slightly more accurate name ... svn:r16916	2008-09-16 10:26:15 +00:00
Roger Dingledine	38f2272d5d	patch from karsten for bug 814. whew. ... svn:r16915	2008-09-16 10:17:04 +00:00
Roger Dingledine	2bde30efa6	read_to_buf should take an int *error_socket and return it. ... svn:r16909	2008-09-14 08:35:41 +00:00
Karsten Loesing	52fbfc5d45	Correct indentation. ... svn:r16819	2008-09-09 22:19:41 +00:00
Roger Dingledine	d37fae2f4e	Catch and report a few more bootstrapping failure cases when Tor ... fails to establish a TCP connection. Cleanup on 0.2.1.x. svn:r16803	2008-09-09 06:25:39 +00:00
Nick Mathewson	baeb260ad1	Refactor use of connection_new so that we get more verifiable typesafety. ... svn:r16785	2008-09-05 22:09:44 +00:00
Nick Mathewson	3f2b7078d2	Use warn_too_many_conns() when accept() fails with a resource limit. ... svn:r16751	2008-09-04 15:22:55 +00:00
Nick Mathewson	730f1b6d3f	Oops. Make warn_too_many_conns() actually work. ... svn:r16686	2008-08-29 17:01:15 +00:00
Nick Mathewson	fcf817f897	Switch global_identifier on connections to a 64-bit field and move it to connection_t. When procession onionskins, look up the connection by this field rather than by addr:port. This will keep us from dropping onionskins. How many dropped circuits are dropped because of this bug? ... svn:r16558	2008-08-15 13:55:01 +00:00
Nick Mathewson	30422b5df1	Rate-limit "too-many-sockets" messages; they can get needlessly verbose. ... svn:r16480	2008-08-09 15:35:37 +00:00
Nick Mathewson	60a0ae198d	Patch cleanups from karsten ... svn:r16479	2008-08-09 15:13:28 +00:00
Nick Mathewson	d9601c65e0	r17666@tombo: nickm | 2008-08-07 15:12:30 -0400 ... Make tor_addr_from_sockaddr also give away the port in a useful format svn:r16458	2008-08-07 19:13:35 +00:00
Nick Mathewson	9855c1d06f	r17645@31-33-44: nickm | 2008-08-05 16:28:01 -0400 ... Make unspecified addresses also cause connection_is_rate_limited to say 0. svn:r16437	2008-08-05 20:28:03 +00:00
Nick Mathewson	960a0f0a99	r17641@31-33-44: nickm | 2008-08-05 16:07:53 -0400 ... Initial conversion of uint32_t addr to tor_addr_t addr in connection_t and related types. Most of the Tor wire formats using these new types are in, but the code to generate and use it is not. This is a big patch. Let me know what it breaks for you. svn:r16435	2008-08-05 20:08:19 +00:00
Nick Mathewson	3ce6e2fba2	r17346@aud-055: nickm | 2008-07-24 15:37:19 +0200 ... Make generic address manipulation functions work better. Switch address policy code to use tor_addr_t, so it can handle IPv6. That is a good place to start. svn:r16178	2008-07-24 13:44:04 +00:00
Roger Dingledine	8fa912a8c5	If we close our OR connection because there's been a circuit ... pending on it for too long, we were telling our bootstrap status events "REASON=NONE". Now tell them "REASON=TIMEOUT". svn:r15369	2008-06-20 04:42:17 +00:00
Roger Dingledine	94dabd2c23	If you're using bridges, generate "bootstrap problem" warnings ... as soon as you run out of working bridges, rather than waiting for ten failures -- which will never happen if you have less than ten bridges. svn:r15368	2008-06-20 04:34:39 +00:00
Roger Dingledine	c6a94718cd	Directory authorities shouldn't complain about bootstrapping ... problems just because they do a lot of reachability testing and some of the connection attempts fail. svn:r15348	2008-06-18 07:34:04 +00:00
Roger Dingledine	8c85eef9b0	start sending "bootstrap problem" status events when we're having troubles ... reaching relays. svn:r15116	2008-06-11 01:14:23 +00:00
Roger Dingledine	42f21007a3	consolidate all our edge/circ/orconn reason-to-foo-or-back functions ... svn:r15115	2008-06-11 00:17:02 +00:00
Roger Dingledine	baa3cea213	Start noticing and reporting bootstrapping failures too. It looks like ... we never bothered learning why OR conns fail, so next step is to add some infrastructure for that. svn:r15091	2008-06-09 18:32:43 +00:00
Roger Dingledine	5dc8062afa	what, we went from v4 to v6? ... svn:r14428	2008-04-23 18:37:24 +00:00
Roger Dingledine	5e299b5e01	minor fixes that have been accumulating ... svn:r14378	2008-04-16 00:12:44 +00:00
Roger Dingledine	20f927c2dd	forward-port r14373 ... svn:r14374	2008-04-15 23:06:31 +00:00
Nick Mathewson	e6b617bf05	r18872@catbus: nickm | 2008-03-16 23:56:48 -0400 ... Only dump all guard node status to the log when the guard node status actually changes. Downgrade the 4 most common remaining INFO log messages to DEBUG. svn:r14069	2008-03-17 04:07:51 +00:00
Nick Mathewson	11e464c331	r18753@catbus: nickm | 2008-03-11 14:56:39 -0400 ... Make some assert()s into tor_assert()s. Make some tor_assert()s called from logging into assert()s, and document why. svn:r13977	2008-03-11 18:56:41 +00:00
Nick Mathewson	eefe2a3562	r18462@catbus: nickm | 2008-02-27 14:15:57 -0500 ... Add better warnings for the error that produced bug 614, and downgrade from a tor_assert() to a tor_fragile_assert(). svn:r13752	2008-02-27 19:19:34 +00:00
Nick Mathewson	3452486ac6	r14422@tombo: nickm | 2008-02-24 17:09:56 -0500 ... Whitespace fixes svn:r13700	2008-02-24 22:11:18 +00:00
Nick Mathewson	dde81de3dd	r14419@tombo: nickm | 2008-02-24 16:55:11 -0500 ... Patch from tup: use sizeof sockaddr_un as the size of a unix sockaddr. Fixes unix controlsocket binding on openbsd. svn:r13697	2008-02-24 22:11:00 +00:00
Nick Mathewson	e0de72dd87	r14410@tombo: nickm | 2008-02-23 16:51:46 -0500 ... Fix the last of the -Wshorten-64-to-32 warnings. svn:r13696	2008-02-24 22:10:08 +00:00
Nick Mathewson	e7db789e82	r14399@tombo: nickm | 2008-02-22 14:09:38 -0500 ... More 64-to-32 fixes. Partial backport candidate. still not done. svn:r13680	2008-02-22 19:09:45 +00:00
Nick Mathewson	e68760ac0f	r14388@tombo: nickm | 2008-02-21 22:44:28 -0500 ... More 64-to-32 fixes. svn:r13672	2008-02-22 03:44:36 +00:00
Nick Mathewson	0ba2bfeef6	r14363@31-33-219: nickm | 2008-02-21 11:11:33 -0500 ... Answer the next-to-last XXX020rc item. svn:r13658	2008-02-21 16:12:01 +00:00
Nick Mathewson	e2f25558b9	r14362@31-33-219: nickm | 2008-02-21 11:01:10 -0500 ... Change some of our log messages related to closed TLS connections in order to better reflect reality. svn:r13657	2008-02-21 16:11:58 +00:00
Roger Dingledine	a60f7caa54	start allowing clients to give up on trackhostexits targets if ... five circuit attempts fail for a given stream. part of the fix for bug 437. still an XXX020rc remaining. svn:r13648	2008-02-21 09:00:54 +00:00
Roger Dingledine	b28a342e35	resolve one more, and leave two for nick. ... svn:r13644	2008-02-21 05:53:50 +00:00
Nick Mathewson	063ced8903	r18296@catbus: nickm | 2008-02-20 23:30:11 -0500 ... Answer one xxx020 item; move 7 other ones to a new "XXX020rc" category: they should get fixed before we cut a release candidate. arma: please review these to see whether you have fixes/answers for any. Please check out the other 14 XXX020s to see if any look critical for the release candidate. svn:r13640	2008-02-21 04:30:14 +00:00
Roger Dingledine	1c8bd320be	pass bucket sizes num_read and num_written around as size_ts ... rather than ints svn:r13610	2008-02-20 02:17:41 +00:00
Roger Dingledine	0977c29196	notice an integer overflow if we ever get source files with more ... than 65k lines in them. also pointed out by veracode. svn:r13606	2008-02-20 00:46:09 +00:00
Nick Mathewson	0399538b90	r18233@catbus: nickm | 2008-02-19 18:46:07 -0500 ... Count sockets returned from socketpair() too. This is probably not the socket counting bug. svn:r13600	2008-02-19 23:46:08 +00:00
Nick Mathewson	9479dd3768	r18226@catbus: nickm | 2008-02-19 18:01:01 -0500 ... Brown-paper-bag time. We were failing to count all the sockets from accept(). svn:r13595	2008-02-19 23:01:07 +00:00
Roger Dingledine	4c1e516a09	cleanups and changelog entry for r13540 ... svn:r13542	2008-02-17 16:52:24 +00:00
Roger Dingledine	bd959adcb7	patch from karsten: ... Resolved problems with (re-)fetching hidden service descriptors. Before, v0 descriptors were not fetched at all (fix on 0.2.0.18-alpha), re-fetching of v2 descriptors did not stop when a v0 descriptor was received (fix on 0.2.0.18-alpha), and re-fetching of v2 descriptors did not work in all cases (fix on 0.2.0.19-alpha). svn:r13540	2008-02-17 16:47:47 +00:00
Nick Mathewson	ca4eb987c8	r14182@tombo: nickm | 2008-02-15 17:20:51 -0500 ... Defer, downgrade, or address more XXX020s. The remaining ones are all ones we should deal with before release. svn:r13530	2008-02-15 23:39:08 +00:00
Nick Mathewson	d48f6425e5	r18066@catbus: nickm | 2008-02-13 11:22:19 -0500 ... Bugfix from Karsten: "Reversed r13439; v2 rendezvous descriptors were only re-fetched when a directory connection did not finish, not when a directory correctly replied with an error code like 404; bug found by nwf. svn:r13492	2008-02-13 16:23:28 +00:00
Nick Mathewson	be1e577d5e	Re-fetch v2 rendezvous descriptor only when first try failed. Patch from karsten. ... svn:r13439	2008-02-09 02:51:20 +00:00
Nick Mathewson	272d37deb3	r17989@catbus: nickm | 2008-02-08 18:09:23 -0500 ... Fix a new segfault when poisoning a non-present socks request. svn:r13433	2008-02-08 23:09:26 +00:00
Nick Mathewson	eecc44dab8	r17963@catbus: nickm | 2008-02-07 10:14:25 -0500 ... Be more thorough about memory poisoning and clearing. Add an in-place version of aes_crypt in order to remove a memcpy from relay_crypt_one_payload. svn:r13414	2008-02-07 16:10:33 +00:00
Nick Mathewson	842a33ff20	Update some copyright notices: it is now 2008. ... svn:r13412	2008-02-07 05:31:47 +00:00
Nick Mathewson	4d70094b6e	r17951@catbus: nickm | 2008-02-06 14:34:13 -0500 ... Add more documentation; change the behavior of read_to_buf_tls to be more consistent. Note a longstanding problem with current read/write interfaces. svn:r13407	2008-02-06 19:34:32 +00:00
Nick Mathewson	6e2946fb5d	r17949@catbus: nickm | 2008-02-06 13:21:12 -0500 ... Fix bandwidth bucked calculations again, I think. Bugfix on 0.1.2.x. Backport candidate. svn:r13406	2008-02-06 18:21:16 +00:00
Nick Mathewson	a869574c56	r17947@catbus: nickm | 2008-02-06 11:57:53 -0500 ... Fix a bunch of DOCDOC items; document the --quiet flag; refactor a couple of XXXX020 items. svn:r13405	2008-02-06 16:58:05 +00:00
Nick Mathewson	9c7eaa7a9d	r17918@catbus: nickm | 2008-02-05 16:39:17 -0500 ... Remove a few #if-0d items. svn:r13392	2008-02-05 21:39:56 +00:00
Nick Mathewson	91bac90310	r17863@catbus: nickm | 2008-02-01 00:27:07 -0500 ... Bugfix from weasel: possible fix for 593: make connection_write_to_buf("") work when using zlib compression. svn:r13347	2008-02-01 05:27:12 +00:00
Roger Dingledine	c973eb5e23	start to clean up r13250: retry v2 renddesc fetches when we ... fail to reach the dirserver too. svn:r13251	2008-01-24 04:45:30 +00:00
Roger Dingledine	a49f14d0d4	When we setconf ClientOnly to 1, close any current OR and Dir ... listeners. Reported by mwenge. svn:r13214	2008-01-21 21:21:19 +00:00
Roger Dingledine	b79850d574	Make "ClientOnly 1" config option disable directory ports too. ... svn:r13213	2008-01-21 21:00:50 +00:00
Nick Mathewson	edf5e70784	r15891@tombo: nickm | 2008-01-12 19:20:24 -0500 ... Basic hacks to get TLS handshakes working: remove dead code; fix post-handshake logic; keep servers from writing while the client is supposed to be renegotiating. This may work. Needs testing. svn:r13122	2008-01-13 00:20:47 +00:00
Nick Mathewson	a7ef07b4bd	r15693@tombo: nickm | 2007-12-25 19:11:29 -0500 ... Here, have some terribly clever new buffer code. It uses a mbuf-like strategy rather than a ring buffer strategy, so it should require far far less extra memory to hold any given amount of data. Also, it avoids access patterns like x=malloc(1024);x=realloc(x,1048576);x=realloc(x,1024);append_to_freelist(x) that might have been contributing to memory fragmentation. I've tested it out a little on peacetime, and it seems to work so far. If you want to benchmark it for speed, make sure to remove the #define PARANOIA; #define NOINLINE macros at the head of the module. svn:r12983	2007-12-26 00:12:08 +00:00
Roger Dingledine	1d8a8063b9	clean up copyrights, and assign 2007 copyrights to The Tor Project, Inc ... svn:r12786	2007-12-12 21:09:01 +00:00
Nick Mathewson	d8ad247dfd	r15088@tombo: nickm | 2007-11-30 23:47:29 -0500 ... Add support to get a callback invoked when the client renegotiate a connection. Also, make clients renegotiate. (not enabled yet, until they detect that the server acted like a v2 server) svn:r12623	2007-12-01 08:09:48 +00:00
Nick Mathewson	c3a745951b	r16570@catbus: nickm | 2007-11-08 11:04:20 -0500 ... Keep track, for each OR connection, of the last time we added a non-padding cell to its outbuf. Use this timestamp, not "lastwritten" to tell if it is time to close a circuitless connection. (We can'tuse lastwritten, since lastwritten is updated when ever the connection flushes anything, and by that point we can no longer tell what is a padding cell and what is not.) svn:r12437	2007-11-08 16:19:07 +00:00
Nick Mathewson	0e993e6008	r16523@catbus: nickm | 2007-11-07 11:35:49 -0500 ... Improve "tls error. breaking" message a little. svn:r12411	2007-11-07 16:37:08 +00:00
Nick Mathewson	47fd6f7267	r16464@catbus: nickm | 2007-11-06 14:53:28 -0500 ... Also avoid overflow on or_conn->read_bucket svn:r12401	2007-11-06 19:54:32 +00:00
Nick Mathewson	be1a5191f8	r16462@catbus: nickm | 2007-11-06 14:40:58 -0500 ... Fix bug 544: do not allow buckets to overflow. Backportable. svn:r12400	2007-11-06 19:42:37 +00:00
Nick Mathewson	e94fad36ac	r16409@catbus: nickm | 2007-11-05 10:38:25 -0500 ... Split handshake state into its own structure. Revise versions and netinfo code to use this structure. svn:r12380	2007-11-05 18:15:44 +00:00
Roger Dingledine	5c4a00e796	minor cleanups ... svn:r11890	2007-10-11 22:19:18 +00:00
Nick Mathewson	b62d379f92	r15689@catbus: nickm | 2007-10-11 16:40:25 -0400 ... Fix bug 451. This was a nasty bug, so let's fix it twice: first, by banning recursive calls to connection_handle_write from connection_flushed_some; and second, by not calling connection_finished_flushing() on a closed connection. Backport candidate. svn:r11882	2007-10-11 20:45:26 +00:00
Roger Dingledine	919f421c6c	get rid of the spurious "Freeing linked %s connection" complaints. ... they happen whenever we fail to establish a connection. svn:r11854	2007-10-10 22:59:34 +00:00
Nick Mathewson	1f4eafdb91	r15619@catbus: nickm | 2007-10-10 00:23:45 -0400 ... Fix bug 483: downgrade a harmless "Hey your accept() implementation sucks" warning to an info. svn:r11828	2007-10-10 04:24:02 +00:00
Nick Mathewson	8439c4ec2f	r15512@catbus: nickm | 2007-10-02 16:27:43 -0400 ... Make some functions static; remove some dead code. svn:r11750	2007-10-02 20:35:23 +00:00
Nick Mathewson	113367bc01	r14722@catbus: nickm | 2007-08-20 10:54:29 -0400 ... Add debugging warning to not abort in the case of bug 483. This is probably not an actual error case, so we should figure out what is really causing it and do something more sensible. svn:r11215	2007-08-20 14:59:05 +00:00
Nick Mathewson	1f244d3943	r14639@catbus: nickm | 2007-08-17 17:45:28 -0400 ... Compile without warnings on MinGW, even with --enable-gcc-warnings enabled. svn:r11157	2007-08-17 21:46:34 +00:00
Nick Mathewson	915c4c3ab8	r14001@catbus: nickm | 2007-07-29 21:31:53 -0400 ... Try to call time(NULL) a little less. svn:r10980	2007-07-30 01:32:12 +00:00
Roger Dingledine	ca7c53d3cc	Be even more aggressive about separating local traffic from relayed ... traffic when RelayBandwidthRate is set. (Refines proposal 111.) svn:r10974	2007-07-29 22:13:44 +00:00
Nick Mathewson	7f3e2378b6	r13908@catbus: nickm | 2007-07-25 18:55:47 -0400 ... Patch from Robert Hogan: set conn->dns_server_port correctly so that we can close dns server ports when they change, thus avoiding crashes and dangling references and other sources of unhappiness. svn:r10933	2007-07-25 22:57:07 +00:00
Nick Mathewson	483c1e9017	r13774@catbus: nickm | 2007-07-16 12:23:28 -0400 ... Tweaks on constrained socket buffers patch from coderman: Add a changelog; rename some variables; fix some long lines and whitespace; make ConstrainedSockSize a memunit; pass setsockopt a void. svn:r10843	2007-07-16 16:23:36 +00:00
Nick Mathewson	f4a6673758	r13773@catbus: nickm | 2007-07-16 11:58:25 -0400 ... Initial "constrained socket buffers" patch from coderman. needs tweaking. svn:r10842	2007-07-16 16:23:34 +00:00
Roger Dingledine	2c2f7ee6a4	fix a memory leak from r10504 (i think) ... svn:r10829	2007-07-15 08:11:56 +00:00
Nick Mathewson	19389a3674	r13328@catbus: nickm | 2007-06-08 17:14:55 -0400 ... Arg. Irix apparently #defines sa_family to something. Thus, naming fields or variables "sa_family" will not work. svn:r10541	2007-06-08 21:14:58 +00:00
Nick Mathewson	1866ad3506	r13274@catbus: nickm | 2007-06-05 19:06:30 -0400 ... Remove some deadcode that seems unlikely to return svn:r10509	2007-06-06 04:51:25 +00:00
Nick Mathewson	210beff55a	r13266@catbus: nickm | 2007-06-05 16:38:08 -0400 ... Patch from peter palfrader: control interface via unix domain socket svn:r10504	2007-06-05 20:54:49 +00:00
Peter Palfrader	b6c6dd7e55	Change an assert into a tor_assert ... svn:r10495	2007-06-05 01:09:09 +00:00
Peter Palfrader	32d12dcfbc	Fix retry_all_listeners() and retry_listeners() description to match code. We are smarter than comparing lengths of want- and have-listeners. ... svn:r10487	2007-06-04 16:58:57 +00:00
Peter Palfrader	502879e0b4	Remove force flag from retry_all_listeners() and retry_listeners(). It always was 0. ... svn:r10486	2007-06-04 16:54:42 +00:00
Nick Mathewson	147e439c94	r13174@catbus: nickm | 2007-06-03 17:39:20 -0400 ... Patch from robert hogan: avoid crash when DNS port is set more than once. svn:r10471	2007-06-03 21:39:24 +00:00
Nick Mathewson	9d1af71b70	r13053@catbus: nickm | 2007-05-29 13:35:33 -0400 ... Move connection_should_read_from_linked_conn into main.c, which is the only file that uses it. svn:r10394	2007-05-29 18:20:56 +00:00
Nick Mathewson	f89a3b1448	r13050@catbus: nickm | 2007-05-29 13:31:11 -0400 ... Resolve all but 3 DOCDOCs. svn:r10393	2007-05-29 17:31:13 +00:00
Roger Dingledine	0c047b87f5	polish r9933-r9994 ... svn:r10335	2007-05-25 19:41:31 +00:00
Roger Dingledine	32f5e19168	remove an obsolete notion that we judge runningness based on ... whether we have a connection open to the server right now. svn:r10333	2007-05-25 19:22:26 +00:00
Nick Mathewson	703bf19620	r12942@catbus: nickm | 2007-05-24 16:31:22 -0400 ... Well, that was easier than I thought it would be. Tor is now a DNS proxy as well as a socks proxy. Probably some bugs remain, but since it A) has managed to resolve one address for me successfully, and B) will not affect anybody who leaves DNSPort unset, it feel like a good time to commit. svn:r10317	2007-05-24 20:31:30 +00:00
Nick Mathewson	6975a093e9	r12853@catbus: nickm | 2007-05-22 11:36:54 -0400 ... Make connection_array into a smartlist. svn:r10292	2007-05-22 15:49:14 +00:00
Nick Mathewson	b837191fd0	r12768@catbus: nickm | 2007-05-16 17:25:33 -0400 ... Fix GCC warnings related to local parameters/variables getting shadowed. svn:r10198	2007-05-16 22:15:14 +00:00
Nick Mathewson	473c266fc2	r12496@catbus: nickm | 2007-04-22 23:04:05 -0400 ... When logging memory usage, break down memory used in buffers by buffer type. svn:r10004	2007-04-23 03:04:46 +00:00
Nick Mathewson	bbd63a9ae0	r12482@catbus: nickm | 2007-04-21 13:30:24 -0400 ... Rename a couple of confusing fields svn:r9996	2007-04-21 17:30:42 +00:00
Nick Mathewson	648065fcb4	r12763@Kushana: nickm | 2007-04-20 18:42:58 -0400 ... Initial version of code to stop using socket pairs for linked connections. Superficially, it seems to work, but it probably needs a lot more testing and attention. svn:r9995	2007-04-21 17:26:12 +00:00
Nick Mathewson	227b2e0226	r12759@Kushana: nickm | 2007-04-20 08:47:20 -0400 ... Track the number of connection_t separately from the number of open sockets. It is already possible to have connections that do not count: resolving conns, for one. Once we move from socketpairs to linked conns, and once we do dns proxying, there will be lots of such connections. svn:r9994	2007-04-21 17:24:18 +00:00
Nick Mathewson	d1381aef82	r12652@Kushana: nickm | 2007-03-25 15:01:48 -0400 ... A surprisingly simple patch to stop reading on edge connections when their circuits get too full, and start again when they empty out. This lets us remove the logic to block begin_dir conns when the corresponding or conns get full: it was already broken by cell queues anyway. svn:r9905	2007-03-26 14:08:18 +00:00
Nick Mathewson	306d5400c3	r12643@0-41-wifi: nickm | 2007-03-23 14:56:35 -0400 ... Refactor a bunch of functions that take edge_connection_t not to also take a crypt_path_t; the cpath is implicit. svn:r9899	2007-03-24 15:57:51 +00:00
Roger Dingledine	2cf63f8a62	Don't save non-general-purpose router descriptors to the disk cache, ... because we have no way of remembering what their purpose was when we restart. svn:r9894	2007-03-21 15:37:30 +00:00
Roger Dingledine	93e7627694	a stopgap measure while we wait for proposal 111: apply the ... stricter rate limiting to all OR conns except those that have been touched by local circuits. svn:r9882	2007-03-20 03:21:51 +00:00
Roger Dingledine	b4f743562f	Add a separate set of token buckets for relayed traffic. Right ... now that's just defined as answers to directory requests. svn:r9881	2007-03-20 02:55:31 +00:00
Nick Mathewson	52713788b4	r12080@catbus: nickm | 2007-03-04 21:40:55 -0500 ... Remove dnsworkers and related code. there goes another 550 lines of code. svn:r9736	2007-03-05 02:40:58 +00:00
Nick Mathewson	92f62b3684	r12077@catbus: nickm | 2007-03-04 16:08:23 -0500 ... Remove support for v0 control protocol from 0.2.0.x trunk; send back error when we receive a v0 control message. (Leave "if(v1){...}"blocks indented for now so this patch is easier to read.) ((Finally, the linecount goes _down_ a little.)) svn:r9735	2007-03-04 21:08:28 +00:00
Nick Mathewson	7fcceb2c25	r12074@catbus: nickm | 2007-03-04 15:11:43 -0500 ... Make all LD_BUG log messsages get prefixed with "Bug: ". Remove manually-generated "Bug: "s from log-messages. (Apparently, we remembered to add them about 40% of the time.) svn:r9733	2007-03-04 20:11:46 +00:00
Nick Mathewson	938de88e3b	r11942@catbus: nickm | 2007-02-25 11:22:12 -0500 ... Fix connection_get_by_type_state_rendquery(): This has been bogus for most of 0.1.2.x. Thanks to Karsten Loesing for finding the bug; fixes bug 399. svn:r9651	2007-02-25 16:22:36 +00:00
Nick Mathewson	6e35b11851	r11813@catbus: nickm | 2007-02-14 11:42:58 -0500 ... Tweak stream_bw patch: Remove a couple of redundant checks, save 8 bytes per edge connection, fix spelling in the changelog; expand spec. svn:r9586	2007-02-14 16:46:55 +00:00
Nick Mathewson	4a74812c70	r11812@catbus: nickm | 2007-02-14 11:22:08 -0500 ... Apply stream_bw patch from Robert Hogan. svn:r9585	2007-02-14 16:46:49 +00:00
Nick Mathewson	759c58151e	r11775@catbus: nickm | 2007-02-12 16:39:09 -0500 ... Update copyright dates. svn:r9570	2007-02-12 21:39:53 +00:00
Roger Dingledine	731d37f717	more useful log messages when we give up on a stream ... svn:r9552	2007-02-11 02:15:42 +00:00
Nick Mathewson	e00a1cbf16	r11726@catbus: nickm | 2007-02-08 16:04:53 -0500 ... Resolve some XXXX012 items: - Remove PathlenCoinWeight: if we want it again, we can add it back in. - Ditto with RelayBandwidth*. - Decide to leave in the "hey, you didn't set end_reason!" BUG log message, but stop telling people to bug me personally. - Postpone strengthening assert_connection_ok(): it's important, but it's also a good way to introduce weird bugs. - Move some expensive consistency checking from dns_free_all() into assert_cache_ok(). svn:r9533	2007-02-08 22:07:56 +00:00
Nick Mathewson	6149ab01f8	r12129@Kushana: nickm | 2007-02-03 09:57:36 -0500 ... Update assert_connection_ok() to match the "block tunnelled dir conn if the or conn is full" logic. This may fix bug 385. svn:r9479	2007-02-03 14:57:47 +00:00
Nick Mathewson	76f896e714	r11607@catbus: nickm | 2007-01-30 17:19:27 -0500 ... Audit non-const char arguments; make a lot more of them const. svn:r9466	2007-01-30 22:19:41 +00:00
Nick Mathewson	9984cad6e8	r11552@catbus: nickm | 2007-01-27 03:55:02 -0500 ... This one is a little tricky. Our BEGIN_DIR implementation has a problem: the dirserv conns will decide they can flush all their data immediately, since the edge_conns will read greedily. For our 0.1.2 workaround, we track which or_conn a bridged dirserv conn is attached to, and stop writing when its outbuf is too full, and start writing again when the or_conn's outbuf empties out a little. This requires a bit of pointer management. Let's hope it works. svn:r9432	2007-01-27 08:55:06 +00:00
Roger Dingledine	75a5fde460	Stop saying !is_internal_IP() when we really meant ... connection_is_rate_limited(). One day this will be useful. svn:r9422	2007-01-26 08:13:53 +00:00
Roger Dingledine	99c1771432	never refuse directory requests from local addresses ... svn:r9421	2007-01-26 08:01:29 +00:00
Nick Mathewson	c0c67d28f5	r9727@catbus: nickm | 2007-01-22 16:12:39 -0500 ... Remove redundant check for whether _connection_write_to_buf_impl is called with a zlib and a non-directory connection: TO_DIR_CONN will already assert if it gets a non-dir connection. svn:r9390	2007-01-23 19:22:46 +00:00
Roger Dingledine	ab838bddb8	Flush local controller connection buffers periodically as we're ... writing to them, so we avoid queueing 4+ megabytes of data before trying to flush. Also add a new XXX012. svn:r9382	2007-01-22 06:07:51 +00:00
Roger Dingledine	bcbd289af5	If our system clock jumps back in time, don't publish a negative ... uptime in the descriptor. Also, don't let the global rate limiting buckets go absurdly negative. svn:r9377	2007-01-21 06:24:05 +00:00
Roger Dingledine	060be4c62b	man, i could have sworn that compiled ... svn:r9369	2007-01-18 03:42:45 +00:00
Roger Dingledine	a3eaabfeb2	Be willing to read or write on local connections (e.g. controller ... connections) even when the global rate limiting buckets are empty. svn:r9368	2007-01-18 03:38:24 +00:00
Roger Dingledine	cb472fc550	break out the big guns: reject dir requests much more ... aggressively. my vidalia bandwidth graph, when rate limiting to 32kB/s, has the "write" line constantly at 32kB. I can't imagine what's going on with the relay latency but it can't be good. svn:r9366	2007-01-17 01:29:54 +00:00
Nick Mathewson	11ed4500de	r11975@Kushana: nickm | 2007-01-15 17:11:15 -0500 ... set or_conn->tls_error to 0 on non-error to avoid looking at stale errors. svn:r9359	2007-01-15 22:11:21 +00:00
Nick Mathewson	380f8983c7	r11966@Kushana: nickm | 2007-01-15 16:12:17 -0500 ... Tidy up ORCONN reason patch from Mike Perry. Changes: make some of the handling of TLS error codes less error prone. Enforce house style wrt spaces. Make it compile with --enable-gcc-warnings. Only set or_conn->tls_error in the case of an actual error. Add a changelog entry. svn:r9355	2007-01-15 21:21:05 +00:00
Nick Mathewson	ead35ef944	r11957@Kushana: nickm | 2007-01-15 15:25:57 -0500 ... Patch from Mike Perry: Track reasons for OR connection failure; display them in control events. Needs review and revision. svn:r9354	2007-01-15 21:13:37 +00:00
Nick Mathewson	d6073cc7fa	r11864@Kushana: nickm | 2007-01-06 01:25:59 -0500 ... Fix an XXXX012 in connection.c: prevent overflows on unfeasibly-high-bandwidth servers on 32-bit architectures. svn:r9282	2007-01-06 06:27:15 +00:00
Roger Dingledine	48a9fe4bbd	be a bit less eager to reject v1 dir requests due to load ... svn:r9271	2007-01-05 06:59:36 +00:00
Roger Dingledine	658c09c06f	more progress and cleanups ... svn:r9269	2007-01-05 06:03:10 +00:00
Nick Mathewson	8728e2826f	r11744@Kushana: nickm | 2006-12-28 23:43:53 -0500 ... Refactor connection_write_to_buf_zlib back into connection_write_to_buf. Hooray for dumping duplicate code. svn:r9209	2006-12-29 05:07:04 +00:00
Nick Mathewson	26c0d6ec58	r11743@Kushana: nickm | 2006-12-28 23:13:21 -0500 ... Refactor _connection_controller_force_write back into conncetion_handle_write. Again, the line count goes down: groovy! svn:r9208	2006-12-29 05:06:47 +00:00
Nick Mathewson	361998d0f3	r11741@Kushana: nickm | 2006-12-28 22:41:29 -0500 ... Count TLS bytes accurately: previously, we counted only the number of bytes read or transmitted via tls, not the number of extra bytes used to do so. This has been a lonstanding wart. The fix "Works for me". svn:r9207	2006-12-29 03:42:46 +00:00
Nick Mathewson	b59573949e	r11736@Kushana: nickm | 2006-12-28 17:46:23 -0500 ... Mark a pile of XXXX comments as targetted for 0.1.2: some because they look important, some because they look easy. svn:r9205	2006-12-29 02:47:51 +00:00
Nick Mathewson	d9f1f3533d	r11724@Kushana: nickm | 2006-12-28 14:22:35 -0500 ... Refactor and unify my-ip-addr-changed logic. Make change in IP address or in nameservers reset and relaunch DNS hijacking tests. svn:r9200	2006-12-28 21:29:20 +00:00
Roger Dingledine	488b4726a7	reinstate the most important dead chickens for limiting ... impact of directory writes now that we're write limiting. a few more dead chickens remain. svn:r9170	2006-12-23 08:48:16 +00:00
Roger Dingledine	04409f202d	reenable write limiting. nick finally convinced me this was ... a smart move. more todo sub-items remain for it. svn:r9101	2006-12-13 07:08:36 +00:00
Roger Dingledine	ee144598c8	minor cleanups and notes ... svn:r9093	2006-12-12 20:19:54 +00:00
Nick Mathewson	a91c12f2e7	r9855@Kushana: nickm | 2006-12-04 00:55:09 -0500 ... Merge circuit_about_to_close_connection and connection_about_to_close_connection. svn:r9021	2006-12-04 05:55:40 +00:00
Roger Dingledine	c5b90daf86	cleanups, bump to 0.1.2.4-alpha ... svn:r9015	2006-12-02 22:47:46 +00:00
Nick Mathewson	1913cb915e	r9308@totoro: nickm | 2006-11-13 18:41:23 -0500 ... Add support for (Free?)BSD's natd, which was an old way to let you have your firewall automatically redirect traffic. (Original patch from Zajcev Evgeny, updated for 0.1.2.x by tup.) svn:r8946	2006-11-14 00:06:31 +00:00
Nick Mathewson	fa6fbbc150	r9307@totoro: nickm | 2006-11-13 18:25:56 -0500 ... Patch from tup based on patch from Zajcev Evgeny: Make TransPort work even when the server wants to talk before the client. svn:r8945	2006-11-14 00:06:02 +00:00
Nick Mathewson	b27cb38dee	r9307@Kushana: nickm | 2006-10-20 13:53:54 -0400 ... Have connection_about_to_close use an end_reason field in edge_connection_t to tell what reason to tell the controller for closing the stream. Set end_reason in connection_edge_end, connection_mark_unattached_ap, and everwhere we set edge_has_sent_end. Add a changelog entry. svn:r8779	2006-10-20 17:54:48 +00:00
Nick Mathewson	12af87539b	r9303@Kushana: nickm | 2006-10-20 12:07:34 -0400 ... Start implementing reason extension for stream events to match the one one used by circuit events. (Not a complete implementation yet; actual reasons are not passed to control.c) svn:r8777	2006-10-20 17:54:36 +00:00
Roger Dingledine	1cf37f90c4	bugfix and cleanups re: entry guards. ... svn:r8620	2006-10-06 23:37:07 +00:00
Nick Mathewson	4c56ac93ca	r8851@totoro: nickm | 2006-10-02 18:13:27 -0400 ... Remove/clarify some XXXs for no longer being accurate; for begin things we do not indend to fix; for already being parts of big todo issues (like "/* XXX ipv6 */"); etc. Also fix some spaces. svn:r8580	2006-10-02 22:13:42 +00:00
Nick Mathewson	bff83b666c	r8846@totoro: nickm | 2006-10-02 16:59:57 -0400 ... Move is_local_IP to config.c; have it check for same-/24; make it used only for reachability (not for banwidth, because that is probably not what we want). Fixes an XXX. svn:r8578	2006-10-02 21:00:35 +00:00
Roger Dingledine	3fcf736c83	misc touchups ... svn:r8568	2006-10-01 21:42:44 +00:00
Nick Mathewson	2cb956d1f5	r9036@Kushana: nickm | 2006-09-29 18:59:51 -0400 ... I am glad that arma reviews my patches. svn:r8546	2006-09-29 22:59:59 +00:00
Nick Mathewson	7d366f61cb	r9025@Kushana: nickm | 2006-09-29 18:33:13 -0400 ... Differentiate more duplicated log entries svn:r8542	2006-09-29 22:33:40 +00:00
Nick Mathewson	8308a37908	r9023@Kushana: nickm | 2006-09-29 17:27:24 -0400 ... Make distinct all non-bug messages at notice or higher that appear 3 or more times. svn:r8541	2006-09-29 22:33:34 +00:00
Nick Mathewson	9988112c87	r8973@Kushana: nickm | 2006-09-28 16:53:19 -0400 ... Refactor entry guard status logic a lot; allow more factors [like not having a Guard flag or being listed in ExcludeNodes] to render a guard "unlisted" (now called "unusable"); track guard down status (now called "unreachable") separately from is_running. svn:r8519	2006-09-28 23:57:44 +00:00
Roger Dingledine	9af3175687	parameterize the loudness of get_interface_address() ... svn:r8358	2006-09-09 19:20:27 +00:00
Roger Dingledine	6fdc63aed2	simplify the connection_write_to_buf_zlib() wrapper. ... svn:r7042	2006-08-13 23:38:30 +00:00
Nick Mathewson	5cff4164a0	r7299@Kushana: nickm | 2006-08-10 01:08:58 -0700 ... Patch from Tup to add support for transparent AP connections: this basically bundles the functionality of trans-proxy-tor into the tor mainline. Now hosts with compliant pf/netfilter implementations can redirect TCP connections straight to Tor without diverting through SOCKS. svn:r7007	2006-08-10 09:01:37 +00:00
Nick Mathewson	85f381153b	r6949@Kushana: nickm | 2006-07-28 10:17:38 -0400 ... Shave another 8 bytes from connection_t: turn inbuf_reached_eof into a bit, and lower timestamp_lastempty to or_connection_t svn:r6934	2006-07-28 15:11:20 +00:00
Nick Mathewson	6dc13cdbeb	r6948@Kushana: nickm | 2006-07-28 10:10:35 -0400 ... Identify some likely target fields for lowering; lower global_identifier (since we only use it for AP streams and origin circs). svn:r6933	2006-07-28 15:11:11 +00:00
Nick Mathewson	5227395aba	r6922@Kushana: nickm | 2006-07-26 16:32:24 -0400 ... Rename some fields, compress a bitfield, and document some structs and fields svn:r6919	2006-07-27 05:03:57 +00:00
Nick Mathewson	dd779d99ea	Fix comments that implied that only dir connections had a purpose field, and the code that believed in those comments. ... svn:r6918	2006-07-27 04:10:51 +00:00
Nick Mathewson	ec82db6995	r6909@Kushana: nickm | 2006-07-26 13:05:58 -0400 ... Clean up wide lines from last patch. svn:r6907	2006-07-26 19:07:37 +00:00
Nick Mathewson	4ff4577beb	r6908@Kushana: nickm | 2006-07-26 12:38:52 -0400 ... Refactor connection_t into edge, or, dir, control, and base subtypes. This might save some RAM on busy exit servers, but really matters most in terms of correctness. svn:r6906	2006-07-26 19:07:26 +00:00
Roger Dingledine	97a14b2018	tweak ... svn:r6795	2006-07-20 23:33:11 +00:00
Roger Dingledine	fad85f173a	when an exit node gets a malformed begin cell, don't complain to ... the node operator, since he can't do anything about it. svn:r6733	2006-07-06 02:44:07 +00:00
Nick Mathewson	337ad6420b	Make connection_write_to_buf_zlib set outbuf_flushlen right. ... svn:r6651	2006-06-18 08:53:09 +00:00
Nick Mathewson	537104c908	write_to_buf != connection_write_to_buf. Also, add a connection_write_to_buf_zlib wrapper that sucks. ... svn:r6650	2006-06-18 08:46:55 +00:00
Nick Mathewson	1d9923da7c	Instead of adding servers and v1 directories to buffers en masse, directory servers add them on the fly as their outbufs are depleted. This will save ram on busy dirservers. ... svn:r6641	2006-06-18 07:38:55 +00:00
Roger Dingledine	91bd12c20d	re-enable per-connection rate limiting. get rid of the "OP bandwidth" ... concept. lay groundwork for "bandwidth classes" -- separate global buckets that apply depending on what sort of conn it is. svn:r6563	2006-06-07 09:18:53 +00:00
Roger Dingledine	45065f1466	simplify code now that libevent considers all sockets pollable. ... what we really mean now is ">= 0", which is clearer to test for. svn:r6543	2006-06-05 09:08:10 +00:00
Nick Mathewson	853e2d99b6	Add a new warning to our "warn a lot" list: unused parameters. This means we have to explicitly "use" unuseds, but it can catch bugs. (It caught two coding mistakes so far.) ... svn:r6532	2006-06-04 22:42:13 +00:00
Roger Dingledine	1bf0f99b66	connection_t kept the identity_pkey but all it did was store it and ... free it. perhaps we don't need it after all? svn:r6518	2006-05-30 06:23:44 +00:00
Roger Dingledine	e24e5475fb	forward-port the ORPort==0 patch ... svn:r6430	2006-05-03 18:29:44 +00:00
Roger Dingledine	e754664d62	bugfix: when we fail to bind or listen on an incoming or outgoing ... socket, we should close it before failing. otherwise we just leak it. (thanks to weasel for finding.) svn:r6284	2006-04-01 10:22:57 +00:00
Roger Dingledine	d1d0813cf3	Allow non-printable characters for exit streams (both for ... connecting and for resolving). Now we tolerate applications that don't follow the RFCs. But continue to block malformed names at the socks side. svn:r6193	2006-03-19 03:55:48 +00:00
Roger Dingledine	581795f41d	auth dir servers were only modifying a server's is_running field ... when they created a network status. so if nobody asked for a network status, they would never discover that any servers are is_running, so they could never build a circuit. svn:r6183	2006-03-18 01:24:04 +00:00
Nick Mathewson	bd8ffccae7	More cleanups noticed by weasel; also, remove macros that nobody uses. ... svn:r6143	2006-03-12 23:31:16 +00:00
Roger Dingledine	946317ae13	start using OR_CONN_EVENT_NEW. ... also fixes a seg fault in tor (bug 261). svn:r6101	2006-03-08 22:29:08 +00:00
Nick Mathewson	5777ee0e1a	Add some functions to escape values from the network before sending them to the log. Use them everywhere except for routerinfo->plaftorm, routerinfo->contact_info, and rend*.c. (need sleep now) ... svn:r6087	2006-03-05 09:50:26 +00:00
Roger Dingledine	d113b75da6	more log conversions. ... whee. svn:r6003	2006-02-13 09:02:35 +00:00
Roger Dingledine	350313d77a	Let the users set ControlListenAddress in the torrc. ... This can be dangerous, but there are some cases (like a secured LAN) where it makes sense. svn:r5997	2006-02-13 06:25:16 +00:00
Nick Mathewson	ae4f0467c8	enforce whitespace style ... svn:r5984	2006-02-12 22:27:09 +00:00
Roger Dingledine	e847085c04	When a client asks for an old-style directory and our write bucket ... is empty, don't give it to him. This way small servers can continue to serve the directory *sometimes*, without getting overloaded. svn:r5968	2006-02-11 23:15:40 +00:00
Roger Dingledine	5f051574d5	Happy new year! ... svn:r5949	2006-02-09 05:46:49 +00:00
Roger Dingledine	31f2705d9a	and make sure that never happens again ... svn:r5932	2006-02-09 02:42:33 +00:00
Nick Mathewson	2bb4fd24de	char *x = "y"; is not good C. ... svn:r5926	2006-02-06 05:01:44 +00:00
Roger Dingledine	640c555f02	Fix a major load balance bug: we were round-robining in 16 KB chunks, and ... servers with bandwidthrate of 20 KB, while downloading a 600 KB directory, would starve their other connections. Now we try to be a bit more fair. svn:r5906	2006-02-04 08:58:51 +00:00
Roger Dingledine	a1dd751f30	when we fail to bind a listener, try to provide a more useful log msg. ... svn:r5900	2006-02-03 12:26:10 +00:00
Roger Dingledine	d682c84e79	attempted patch for bug 220: don't assert when we've tried all the ... intro points for a hidden service and we try fetching the service descriptor again. svn:r5838	2006-01-17 04:16:59 +00:00
Roger Dingledine	7d1f675c85	entry nodes are now entry guards. ... this is our last easy chance for a wholesale change. heave ho. svn:r5782	2006-01-10 22:42:44 +00:00
Roger Dingledine	d4d7a49411	fix typo ... svn:r5750	2006-01-07 02:12:38 +00:00
Nick Mathewson	878962bee1	Add reasons to DESTROY and RELAY_TRUNCATED cells. ... svn:r5734	2006-01-05 21:23:03 +00:00
Roger Dingledine	d8e3bc0288	fix a wrong string ... svn:r5733	2006-01-05 12:18:34 +00:00
Roger Dingledine	dbd7b97eff	helper nodes are dead. long live entry nodes. ... (config options EntryNodes and StrictEntryNodes still not implemented.) svn:r5673	2005-12-28 09:07:31 +00:00
Roger Dingledine	4088f7dfd1	fix typo ... svn:r5667	2005-12-27 09:04:36 +00:00
Nick Mathewson	1af630d32c	Bite the bullet and limit all our source lines to 80 characters, the way IBM intended. ... svn:r5582	2005-12-14 20:40:40 +00:00
Roger Dingledine	58366ffd24	when we changed from log_fn to debug/info/notice/warn/err, ... we screwed up the formatting in wild and unpredictable ways. fix it before it becomes convention to format logs in wild and unpredictable ways. still need to do src/common/ someday. svn:r5551	2005-12-10 09:36:26 +00:00
Nick Mathewson	b03e8733f3	Change how OR conns get removed from the identity map; fix some warnings on shutdown. ... svn:r5509	2005-12-05 19:15:27 +00:00
Nick Mathewson	a6eb8cd2a0	Move connection_or_remove_from_identity_map() to connection_unlink, but dont remove the other; just make it warn. ... svn:r5470	2005-11-30 04:28:41 +00:00
Nick Mathewson	3bd613b44d	Rename connection_get_by_identity_digest to reflect that it is OR-only. Make it use a hashtable instead of a linear search. ... svn:r5469	2005-11-30 03:01:16 +00:00
Nick Mathewson	652e1899ac	"How about 'never'? Does 'never' work for you?" ... Weasel says circuit_get_by_conn is his main timesink. Most of its users were just checking whether OR conns had circuits, so add a circuit count to OR conns, and check that. One was circuit_about_to_close_conn, which was doing an O(n^2) series of calls to get all circs on an OR conn, so make an O(n) function for that. Finally, circuit_get_by_edge_conn was using it as a sanity test that has been around for a while but never found any actualy insanity, so kill that. circuit_get_by_conn is finally dead, which is good, since it was never sane to begin with. svn:r5460	2005-11-26 01:43:57 +00:00
Nick Mathewson	31d5d96739	Cut down a common call to circuit_get_by_conn by about half. ... svn:r5459	2005-11-26 00:53:51 +00:00
Roger Dingledine	6452aecedb	when calling connection_get_by_identity_digest, don't do a memcmp ... for non-OR conns. this should save a bit of time. svn:r5456	2005-11-25 06:43:53 +00:00
Roger Dingledine	7aae63994f	Recover better from TCP connections to Tor servers that are broken but ... don't tell you (it happens!); and rotate TLS connections once a week. 1) If an OR conn becomes more than a week old, make it obsolete. 2) If it's obsolete and empty, kill it. 3) When an OR makes a second connection to you, allow it. 4) If we want to send a new create cell, but the best conn we've got is obsolete, and the router is 0.1.1.9-alpha-cvs or later, ask for a new conn instead. 5) When we time out on circuit building on the first hop, make that connection obsolete. svn:r5429	2005-11-19 06:57:44 +00:00
Roger Dingledine	26d8c3498c	and another overly common log entry ... svn:r5417	2005-11-18 00:35:29 +00:00
Roger Dingledine	e6fd88c698	simplify a log entry ... svn:r5353	2005-11-11 17:03:35 +00:00
Nick Mathewson	80758473f8	fix a signed/unsigned warning ... svn:r5344	2005-11-01 17:28:49 +00:00
Roger Dingledine	bf2be9abd7	Do round-robin writes of at most 16 kB per write. This might ... be more fair on loaded Tor servers, and it might resolve our Windows crash bug. It might also slow things down. svn:r5332	2005-10-29 18:19:37 +00:00
Nick Mathewson	5d85560d9e	Remove last vestiges of old logging interface. ... svn:r5317	2005-10-25 18:01:01 +00:00
Nick Mathewson	452f4cfa09	Convert circuituse, command, config, connection, relay, router, test to new logging interface ... svn:r5308	2005-10-25 07:04:36 +00:00
Peter Palfrader	0d9aedfcea	Downgrade a few INFO level logs to DEBUG again. Also add two or three new ... logs in cases where a calling function's log was downgraded and we wouldn't get any log message otherwise. svn:r5263	2005-10-17 16:21:42 +00:00
Roger Dingledine	fd165329b8	start calling it *ListenAddress rather than *BindAddress, ... since none of our users know what it means to bind an address or port. svn:r5260	2005-10-17 03:17:29 +00:00
Peter Palfrader	7b15f77dd6	Make a few INFO log lines into DEBUG ... svn:r5257	2005-10-17 02:13:36 +00:00
Roger Dingledine	ae92a91d96	more log uncluttering ... svn:r5254	2005-10-17 01:29:28 +00:00
Roger Dingledine	78edd804ff	fix a malformed warning entry ... svn:r5219	2005-10-07 19:49:48 +00:00
Peter Palfrader	14934dece2	Print address too when we say we cannot bind/listen ... svn:r5213	2005-10-07 18:48:31 +00:00
Nick Mathewson	cc35e1720f	Using RAND_pseudo_bytes instead of RAND_bytes is an accident waiting to happen, and does not really speed us up much when we do it. So stop doing it. ... svn:r5210	2005-10-06 22:18:01 +00:00
Nick Mathewson	039edb3dbb	Downgrade too-frequent "nothing happened" message from info to debug ... svn:r5200	2005-10-05 22:32:59 +00:00
Nick Mathewson	6e4608701d	and another leak. ... svn:r5175	2005-09-30 21:31:26 +00:00
Roger Dingledine	ae30c8101b	by convention, addr is a uint32_t and address is a string. ... that's why we hadn't caught that leak. svn:r5174	2005-09-30 21:30:04 +00:00
Nick Mathewson	5c5d2e82e6	Fix a leak when launching listeners. ... svn:r5173	2005-09-30 21:28:00 +00:00
Nick Mathewson	92451f74a8	Reformat inconsistent function declarations. ... svn:r5160	2005-09-30 01:09:52 +00:00
Nick Mathewson	5c53545d81	Add a bunch more warnings to out warning suite; resolve them; pack structs a little better. ... svn:r5150	2005-09-29 22:59:17 +00:00
Nick Mathewson	7c6679d8dc	Add new config.c function to set options that can fail, and roll back if they do. This should solve the setconf-an-impossible-port bug. ... svn:r5046	2005-09-14 02:36:29 +00:00
Roger Dingledine	63bb27f19d	be more thorough about noticing when a directory request has failed: ... it has failed not only when the connection attempt fails, but also if the conn reaches eof before we get a response that we're happy with. svn:r5013	2005-09-12 07:36:26 +00:00
Nick Mathewson	3dc5e77b58	Numerous changes to move towards client-side v2 directories. ... connection.c: - Add some more connection accessor functions to make directory download redundancy checking work. directory.c, or.h, router.c, routerlist.c: - Start on logic to note when networkstatus downloads fail. dirserv.c, routerlist.c, routerparse.c: - Start maintaining an is_named field in routerstatus_t. Don't actually look at it yet. dirserv.c, routerlist.c: - Remove expired networkstatus objects. or.h: - Make some booleans into bitfields - Add prototypes routerlist.c: - Sort networkstatus list by publication time - Function to remove old (older than 10 days) networkstatus objects. - Function to set a list of routerinfo_ts' status info from the current set of networkstatus objects. - Function to tell which routerinfos we need to download based no the current set of networkstatus objects. - Do not launch a networkstatus download if a redundant one is in progress. routerparse.c: - Keep router entries in networkstatus sorted by digest. svn:r5012	2005-09-12 06:56:42 +00:00
Nick Mathewson	4ce0e01848	add conn->requested_resource to connection_t checks. ... svn:r4951	2005-09-08 21:21:54 +00:00
Nick Mathewson	059148f588	Only caches download network-status for now, and they use a different strategy. Add an element to connection_t to remember what we are downloading, and a function to recognize our own fingerprint. ... svn:r4944	2005-09-08 20:18:15 +00:00
Roger Dingledine	893acb3acc	Make a new AssumeReachable config option that will publish anyway. ... Also, let authdirservers start without setting their Address field. Something is still not working though. Will fix in morning. svn:r4839	2005-08-26 07:41:19 +00:00
Nick Mathewson	4e735da5da	Also set event_mask=0 in connection_free_all, and dont send events to marked control conns (for good measure) ... svn:r4729	2005-08-07 19:27:38 +00:00
Roger Dingledine	5c4da9dec6	incomplete patch for matt's info controller signal term bug ... svn:r4728	2005-08-07 19:20:55 +00:00
Nick Mathewson	303258972b	Fix idiot bug. The "free the IP history" code belons in connection_free_all(), not in connection_free(). You can all mock me now. ... svn:r4691	2005-08-04 18:29:01 +00:00
Nick Mathewson	11ff0aba80	Make clients regenerate their keys when their IP address changes. ... svn:r4688	2005-08-03 20:42:17 +00:00
Nick Mathewson	18c11eb3bc	Be consistent about preferring foo* to struct foo* ... svn:r4637	2005-07-22 21:12:10 +00:00
Nick Mathewson	c3a62c1739	Initial, somewhat dodgy implementation of helper nodes. It has too many XXXXs, it logs too verbosely, and it doesnt do persistence. ... svn:r4633	2005-07-22 17:32:25 +00:00
Roger Dingledine	452c98058f	missed one ... svn:r4567	2005-07-14 23:08:55 +00:00
Roger Dingledine	d8d0feb633	tell us what kind of listener it is, too ... svn:r4566	2005-07-14 23:07:05 +00:00
Nick Mathewson	f86a1e634f	fix opening listener log msg ... svn:r4565	2005-07-14 23:04:31 +00:00
Nick Mathewson	e94f95a716	Populate address field of listeners with an actually sane value. ... svn:r4564	2005-07-14 22:56:17 +00:00
Roger Dingledine	2259032ea1	trivial changes on nick's rendezvous commit ... svn:r4553	2005-07-14 08:43:19 +00:00
Nick Mathewson	cf13b3e4a6	Macro-fu to get DEBUG events working. ... svn:r4539	2005-07-13 05:14:42 +00:00
Nick Mathewson	658e1196d0	Change retry_listeners: when force is false, close and re-open a minimal set of listeners (i.e., those that do not match the configuration). This fixes a possible bug on some windowses. Maybe. ... svn:r4528	2005-07-11 17:20:22 +00:00
Nick Mathewson	f9f09f1c5e	Start implementing framework for revised control spec. ... svn:r4447	2005-06-17 18:49:55 +00:00
Nick Mathewson	d4972bd2e1	Remove code that has been #if-0ed for a long time. ... svn:r4435	2005-06-15 18:34:46 +00:00
Nick Mathewson	232861ba42	Docment or add DOCDOC comments to undocumented functions in src/or. Make function definition format uniform. ... svn:r4411	2005-06-11 18:52:12 +00:00
Roger Dingledine	2587fa09f9	move more docs into our code ... svn:r4406	2005-06-11 06:07:22 +00:00
Nick Mathewson	0831823763	Change end-of-file NLNL convention. It turns out arma I and I agree. ... svn:r4382	2005-06-09 19:03:31 +00:00
Roger Dingledine	cfc89f8753	pay more attention to the ClientOnly config option ... svn:r4367	2005-06-09 08:54:42 +00:00
Roger Dingledine	aff308e6d9	reenable the part of the code that tries to flush as soon as an OR outbuf ... has a full tls record available. perhaps this will make OR outbufs not grow as huge except in rare cases, thus saving lots of cpu time plus memory. svn:r4343	2005-06-08 04:55:06 +00:00
Roger Dingledine	040a748d87	i screwed up the dirport reachability testing when we don't yet ... have a cached version of the directory. hopefully now fixed. svn:r4284	2005-05-23 05:20:52 +00:00
Roger Dingledine	b86716b839	If a socks connection ends because read fails, don't warn that you're ... not sending a socks reply back. (bug reported by Warren Barrow) svn:r4277	2005-05-21 00:15:23 +00:00
Roger Dingledine	f0e309e5bd	add HttpProxyAuthenticator config option too ... svn:r4272	2005-05-20 08:51:45 +00:00
Roger Dingledine	b7d6b8a397	doxygeny goodness from tyranix ... svn:r4262	2005-05-17 17:01:36 +00:00
Nick Mathewson	10b2208d93	Make Tor compile with no warnings with gcc4.0 on OSX ... svn:r4184	2005-05-07 05:55:06 +00:00
Roger Dingledine	5265bbd2b8	first iteration of scrubbing sensitive strings from logs. ... also generally clean up log messages. svn:r4174	2005-05-03 10:04:08 +00:00
Nick Mathewson	a312ce1d3b	Change buffer shrinking strategy: only try to shrink once every 3 minutes. Do not try to read over buffer size unless buffer is nearly empty. ... svn:r4165	2005-05-02 23:17:08 +00:00
Nick Mathewson	fe65e57ca1	Re-do fragmented control message handling to work with new buf_t system. ... svn:r4144	2005-04-27 22:01:34 +00:00
Nick Mathewson	9ba2dd7ea1	Clean/renormalize whitespace ... svn:r4122	2005-04-26 20:55:32 +00:00
Roger Dingledine	509405a5f7	clean up this TOR_FRAGILE business ... svn:r4116	2005-04-26 18:52:16 +00:00
Nick Mathewson	74dc7eedc5	Add kludgy function to force controllers to flush EVENT_ERR_MSG events. ... svn:r4057	2005-04-08 03:36:39 +00:00
Nick Mathewson	31c12e265f	Move a quote, fix a log. ... svn:r4056	2005-04-08 03:26:44 +00:00
Roger Dingledine	dabafddb82	fix format bug ... svn:r4051	2005-04-07 22:03:56 +00:00
Nick Mathewson	8cc3307e0d	Improve conn_*_to_string; add circuit_state_to_string; make skewed-descriptor messages better. ... svn:r4047	2005-04-07 21:07:19 +00:00
Nick Mathewson	b897cb1ec3	Change conn_(type|state)_to_string from const arrays to switch functions so we (I) will not make Tor crash the next time we (I) add a new state. ... svn:r4045	2005-04-07 20:25:22 +00:00
Roger Dingledine	620419b421	oh, and accept() into the right place, too. ... svn:r4029	2005-04-06 16:16:31 +00:00
Roger Dingledine	70f3b3ef86	Forward-port the checking of ... sin_addr.s_addr == 0 || sin->sin_port == 0. This just happened on moria2, so I guess it happens rarely on Linux as well as OS X. We can't afford to accept OR conns from 0.0.0.0:0, since we send created cells back to the first addr:port that matches, and we'd better not send them to the wrong place. So, let's drop them all for now, and see if we can find a pattern later. svn:r4028	2005-04-06 15:42:35 +00:00
Roger Dingledine	9cbaf4603d	fix an assert trigger: when we have the rare case of accepting ... a conn on 0.0.0.0:0, then when we look through the connection array, we'll find any of the workers. this is no good. svn:r4027	2005-04-06 15:19:32 +00:00
Nick Mathewson	88dc243bb5	Rename circuit_get_by_stream to circuit_get_by_edge_conn, and actually start using it. Watch out, kids! ... svn:r4026	2005-04-06 06:43:21 +00:00
Roger Dingledine	5f0a84cbe2	update conn-type-state-strings to handle https states for ORs ... svn:r4018	2005-04-06 04:55:17 +00:00
Nick Mathewson	ac268a8340	Fix Tor for no-threading compilation: move connection_unregister from _connection_free to connection_free. ... svn:r4013	2005-04-06 00:46:57 +00:00
Nick Mathewson	0dc02328af	Move most of *_mark_for_close out of macros. ... svn:r3992	2005-04-03 05:22:33 +00:00
Nick Mathewson	0e81265359	update copyright notices. ... svn:r3982	2005-04-01 20:15:56 +00:00
Roger Dingledine	c2a05e1ca9	redo the state descriptors now that we have a controller-wait state ... svn:r3934	2005-03-31 17:36:24 +00:00
Roger Dingledine	36baf7219d	stop most cases of hanging up on a socks connection without sending ... the socks reject. audit for remaining ones. also make things more uniform so we always remember to hold-open-until-flushed, etc. svn:r3891	2005-03-27 04:55:13 +00:00
Roger Dingledine	1328383482	make it clearer to the human that his server is testing ... its reachability. tell him when it succeeds, or when 20 minutes pass and it hasn't succeeded yet. svn:r3882	2005-03-26 01:43:39 +00:00
Roger Dingledine	9b9dbad0b7	fix another case where we need to send a socks reply (reject) ... back before we close the conn. svn:r3876	2005-03-25 11:12:14 +00:00
Roger Dingledine	9685164fe5	don't mark a router down just because your httpsproxy is unreachable ... svn:r3874	2005-03-25 10:55:06 +00:00
Nick Mathewson	d26bcfab92	Note where connection that hasnt sent end was marked. ... svn:r3872	2005-03-25 05:54:50 +00:00
Roger Dingledine	bd37c9a3bd	REUSEADDR on normal places means you can rebind to the port ... right after somebody else has let it go. But REUSEADDR on win32 means to let you bind to the port _even when somebody else already has it bound_. So, don't do that on Win32. svn:r3867	2005-03-24 23:20:06 +00:00
Roger Dingledine	0dc91fd9c0	fix an assert -- we're not allowed to write onto a conn after we've ... connection_unregistered it. there's still more work to be done here, since we need to make sure to send back the socks-reply as soon as we know what it will be -- we can't just wait until connection-about-to-close to deal with it. svn:r3847	2005-03-23 23:19:18 +00:00
Roger Dingledine	fb8a319ffe	fix an over-eager assert, to make httpsproxy get a little farther ... svn:r3846	2005-03-23 22:11:59 +00:00
Roger Dingledine	a799dad937	forward-port the commenting out of the assert that glenn fink was ... triggering. we still don't know why he was triggering it. svn:r3841	2005-03-23 20:42:37 +00:00
Roger Dingledine	7373042a7b	fix assert triggers (bugs 109 and 96), and put in some ... debugging logs to notice future repeat bugs. svn:r3826	2005-03-23 02:52:55 +00:00
Roger Dingledine	e28b8aaa40	make httpsproxy more likely to work ... (don't let OR conns do tls until they've finished connecting and doing the proxy dance.) svn:r3824	2005-03-22 23:57:18 +00:00
Nick Mathewson	df9c8feac7	Commit fixes for several pending tor core tasks: document all DOCDOCed functions; time out uncontrolled unattached streams; feed reasons to SOCKS5 (refactoring connection_ap_handshake_socks_reply in the process); change DirFetchPeriod/StatusFetchPeriod to have a special "Be smart" value. ... svn:r3769	2005-03-17 12:38:37 +00:00
Nick Mathewson	97dad670ea	Renormalize whitespace ... svn:r3757	2005-03-14 03:18:35 +00:00
Nick Mathewson	115271f65e	Implement the common case of ATTACHSTREAM. ... svn:r3751	2005-03-12 04:22:01 +00:00
Nick Mathewson	afe414f070	Revise all calls to connection_edge_end to avoid sending MISC, and to take errno into account where possible. ... svn:r3720	2005-03-01 22:42:31 +00:00
Nick Mathewson	4ddf768a4f	Forward-port new reasons; clean up code more; add code to convert new reasons to SOCKS5 reply codes; add code to convert errnos to reasons. New code still needs to get invoked. ... svn:r3719	2005-03-01 22:16:15 +00:00
Nick Mathewson	b7b05dc1b2	make control interface stream IDs monotonically increasing to prevent possible races ... svn:r3715	2005-03-01 01:15:01 +00:00
Nick Mathewson	97bc49bd72	Try a little harder to avoid openssl SSL* double-free reports. ... svn:r3710	2005-02-28 02:52:51 +00:00
Nick Mathewson	26e6eb7539	Check returns from libevent calls better; stop poking at internals of events to see if they are live. ... svn:r3691	2005-02-25 05:42:01 +00:00
Nick Mathewson	24d7ae6fe8	Insert missing ! in assert_connection_ok; test was accidentally reversed in revision 1.329 yesterday. Should fix bug 102 ... svn:r3685	2005-02-24 17:08:27 +00:00
Nick Mathewson	22c38b0f9b	Clarify comment. Use CONN_IS_EDGE more. Try to be more zealous about calling connection_edge_end when things go bad with edge conns in connection.c ... svn:r3671	2005-02-23 20:35:26 +00:00
Nick Mathewson	6e6d95b3db	Change from inet_ntoa to a threadproof tor_inet_ntoa. ... svn:r3656	2005-02-22 08:18:36 +00:00
Nick Mathewson	c2d5b67dd2	After we successfully connect, try handling pending stuff immediately, rather than waiting for the next call to connection_handle_write. Roger: is this right? ... svn:r3647	2005-02-22 03:02:33 +00:00
Roger Dingledine	cbb4803ec8	forward-port some fixes ... svn:r3631	2005-02-17 01:12:50 +00:00
Roger Dingledine	37ca621301	when a client asks us for a dir mirror and we don't have one, ... launch an attempt to get a fresh one. svn:r3609	2005-02-10 06:31:34 +00:00
Roger Dingledine	07a3307460	remove redundant lines ... svn:r3607	2005-02-09 23:54:30 +00:00
Nick Mathewson	89d422914a	Patch from adam langley: always remove sockets from libevent before closing them. Should fix epoll-related bugs. ... svn:r3606	2005-02-09 23:16:31 +00:00
Roger Dingledine	efa9bb5535	fix the latest bug: don't explode when some router declares a ... bandwidthburst of 500 gigabytes. this bug seems to have taken down most of the network. oops. svn:r3523	2005-02-03 22:58:22 +00:00
Roger Dingledine	2e97593d25	define TOR_FRAGILE if you want tor to give you a core when ... something goes wrong. this should only be used by people actively tracking bugs. svn:r3487	2005-02-01 00:37:16 +00:00
Roger Dingledine	a0312f3590	don't double-detach a closing exit conn that's waiting for dns resolve ... svn:r3477	2005-01-31 01:27:49 +00:00
Roger Dingledine	692a57c8e8	but don't spring the trip on worker children, because it turns ... out they don't actually remove anything before freeing the conns. svn:r3476	2005-01-31 01:02:20 +00:00
Roger Dingledine	d6489d8e41	lay a trap for situations where we connection_free something ... that's still on one of the lists. in particular, this will detect situations where we mark-for-close and then free it ourselves. svn:r3475	2005-01-31 00:33:32 +00:00
Roger Dingledine	38be533c69	Handle unavailable hidden services better. We try each intro point ... until none are left, then we try to refetch the descriptor. If it's the same one we had before, then close streams right then. Whenever a new stream arrives, even if it's right after, optimistically try refetching the descriptor, just in case. svn:r3379	2005-01-19 23:15:59 +00:00
Roger Dingledine	bafb3e4a5b	fix another integer underflow caused by buckets going negative ... svn:r3346	2005-01-12 12:19:00 +00:00
Roger Dingledine	3809c0ab91	tolerate bandwidtch buckets going negative (i hope) ... svn:r3344	2005-01-12 10:00:38 +00:00
Nick Mathewson	324b192f68	Make Tor use Niels Provos's libevent instead of it's current ... poll-but-sometimes-select mess. This will let us use faster async cores (like epoll, kpoll, and /dev/poll), and hopefully work better on Windows too. There are some fairly nasty changes to main.c here; this will almost certainly break something. But hey, that's what alphas are for. svn:r3341	2005-01-12 06:42:32 +00:00
Nick Mathewson	65c4fa2614	Split mark-dir-failed-and-retry logic into separate function; make it retry runningrouters as well as directory fetches; note that the do-we-need-to-give-up test is wrong. ... svn:r3256	2005-01-03 20:07:07 +00:00
Nick Mathewson	5f40d6bf72	Make directory fail-and-retry logic happen in connection_about_to_close(); fixes win32 bug. ... svn:r3253	2005-01-03 19:51:10 +00:00
Roger Dingledine	036384fd8e	respond to an 009 XXX ... svn:r3201	2004-12-22 02:55:26 +00:00
Roger Dingledine	011ad3cba5	clean up logging, ... make it clearer which warns are bugs, make the control log event match its specification, point out a bug in how we deal with failure when renewing the tls context. svn:r3138	2004-12-13 00:44:39 +00:00
Roger Dingledine	012255fe60	fix the other half of the pipe race ... svn:r3111	2004-12-07 16:37:32 +00:00
Roger Dingledine	2532e9405e	Now we allow writing to the buffer even when the stream if marked for ... close, if we're planning to wait to flush it. This is important because we were sending a socks reject back if we're closing and hadn't already sent one, but it wasn't actually getting written since the conn was already marked-for-close. svn:r3074	2004-12-04 07:13:37 +00:00
Roger Dingledine	ef04cfcbad	one more typo ... svn:r3054	2004-12-01 04:13:15 +00:00
Nick Mathewson	b457cfb5eb	Spell-check strings and comments ... svn:r3052	2004-12-01 03:48:14 +00:00
Nick Mathewson	6e88abf418	If we are using select, make sure we stay within FD_SETSIZE. ... svn:r3051	2004-12-01 03:15:59 +00:00
Nick Mathewson	7fbd297532	Suggestion from weasel: Make tor --version --version dump the cvs Id of every file. ... svn:r3019	2004-11-29 22:25:31 +00:00
Roger Dingledine	c1dc17e6e2	put in initial support for ".nickname.exit" addresses, to let alice ... decide what exit node to use; based on a patch by geoff goodell. needs more work: e.g. it goes bananas building new circuits when the chosen exit node's exit policy rejects the connection. svn:r3015	2004-11-29 08:34:54 +00:00
Roger Dingledine	22727b4edc	wrong is ok, and right is fine, but in between is apparently ... totally unacceptable to me. svn:r3005	2004-11-28 11:39:53 +00:00
Nick Mathewson	6f5dbefa7e	Normalize space: add one between every control keyword and control clause. ... svn:r3003	2004-11-28 09:05:49 +00:00
Nick Mathewson	f77ff938b7	remember; tor_socket_errno has side effects! ... svn:r2997	2004-11-28 05:48:02 +00:00
Roger Dingledine	7c9a707900	remove emacs droppings, since nick says he doesn't need them anymore ... svn:r2989	2004-11-26 04:00:55 +00:00
Roger Dingledine	914d346095	update conn_state_to_string ... svn:r2979	2004-11-24 07:58:15 +00:00
Roger Dingledine	83e7043eb8	don't process marked-for-close conns further. ... (fix assert trigger -- if we're lucky.) svn:r2975	2004-11-24 06:41:58 +00:00
Nick Mathewson	fe32c2d141	Fix sign-related warnings ... svn:r2942	2004-11-22 22:50:17 +00:00
Nick Mathewson	d4754b334c	Compile cleanly on windows; prevent some insane bandwidth cases (e.g., "BandwidthBurst 1000 TB" from occuring. ... svn:r2941	2004-11-22 22:24:10 +00:00
Roger Dingledine	310a8da0d2	break reached_eof() out of process_inbuf() ... svn:r2930	2004-11-21 10:14:57 +00:00
Roger Dingledine	6a516dfdd3	be more greedy about filling up all relay cells. ... this may have some bugs in it still. and it may end up not being what we want to do. svn:r2928	2004-11-21 07:43:12 +00:00
Roger Dingledine	dd19cf6ba3	kill -USR2 now moves all logs to loglevel debug ... plus fix some typos svn:r2914	2004-11-20 07:33:55 +00:00
Nick Mathewson	8acaf8e187	Add "MEMUNIT" and "INTERVAL" types to configuration. Also tweak Accounting setup. More docs needed ... svn:r2911	2004-11-20 00:37:00 +00:00
Roger Dingledine	67aa3b66c5	clean up socks handling, refuse connections to port 0 ... svn:r2888	2004-11-15 07:50:15 +00:00
Nick Mathewson	08627d5d87	Track whether descriptor is dirty/uploaded. When any options are set, mark it dirty. Once a minute, regenerate and upload the server descriptor if it is dirty. ... svn:r2832	2004-11-13 16:53:48 +00:00
Nick Mathewson	60880cda84	Resolve a bunch of FIXME items; mark a lot more for attention; ask for clarification on some. Turn all XXXX008 ("showstopper for 0.0.8 release") items into XXXX009 or XXXX, since plainly they were not showstoppers for 0.0.8. Add/clean some docs. ... svn:r2808	2004-11-12 16:39:03 +00:00
Nick Mathewson	2a5bcb29e6	Resolve FIXME: Possible solution to note_disconnect problem; needs thought and review. ... svn:r2807	2004-11-12 05:52:19 +00:00
Nick Mathewson	0faab62cd9	Resolve FIXMES: sometimes an error code is just an error code ... svn:r2805	2004-11-12 05:03:50 +00:00
Nick Mathewson	5a5be93f80	Normalize whitespace; add a "tell me about all the unnormalized whitespace" target; fix a braino in dirserv.c ... svn:r2758	2004-11-09 20:04:00 +00:00
Roger Dingledine	394554cfbf	Clean up copyrights. ... Break connection_consider_empty_buckets() out of connection_read_bucket_decrement(). svn:r2698	2004-11-07 01:33:06 +00:00
Roger Dingledine	6c61ed4fb5	Make options no longer a global variable. ... Now we can try setting an option but back out if it fails to parse, or if it's disallowed (e.g. changing RunAsDaemon from 1 to 0). Use parse_line_from_str rather than parse_line_from_file. svn:r2692	2004-11-06 05:18:11 +00:00
Roger Dingledine	59453ac6ef	add a ControlPort and control listener conn. ... note that print_usage is obsolete. svn:r2671	2004-11-04 06:41:49 +00:00
Roger Dingledine	d0c158c8d6	clarify the bandwidthburst and bandwidthrate are in bytes ... (niels had thought they were in bits, or kb, or something) svn:r2669	2004-11-04 03:25:43 +00:00
Roger Dingledine	a4753283dd	better interface for connection_ap_handshake_socks_reply() ... make --list-fingerprint print the fingerprint again svn:r2668	2004-11-03 23:13:28 +00:00
Nick Mathewson	451f8b5045	- Implement all of control interface except authentication, setconfig, ... and actually making the sockets. - Make sure that identity-based nicknames start with $. - Use new string_join interface. svn:r2661	2004-11-03 18:33:07 +00:00
Nick Mathewson	4fdaa5de51	Streamline the two redundant "Has the second rolled over?" checks in prepare_for_poll and connection_bucket_refill; also, generate BANDWIDTH control events ... svn:r2657	2004-11-03 16:38:04 +00:00
Roger Dingledine	12e92eb82f	connection_read_bucket_decrement() has a side-effect that ... we need to get even if we just read 0 bytes svn:r2656	2004-11-03 10:18:31 +00:00
Nick Mathewson	347d3f9d62	Start implementing control interface. ... svn:r2652	2004-11-03 01:32:26 +00:00
Nick Mathewson	8db0abb687	First attempt at hibernation code. It needs more work around the XXXXs, but first I want arma to review the basic approach while I meditate on how to fix them. ... svn:r2649	2004-11-02 23:47:32 +00:00
Nick Mathewson	ad4dc74482	Use a stricter set of warnings; make them all pass. ... svn:r2645	2004-11-02 03:02:17 +00:00
Roger Dingledine	984ffec105	implement first piece of hibernation ... still need to track bandwidth, and make decisions based on bandwidth svn:r2630	2004-10-31 20:28:41 +00:00
Nick Mathewson	2fbf31533b	Tricksy compiler warnings! We hates them, hates them forever, my precious! ... svn:r2615	2004-10-27 21:14:11 +00:00
Roger Dingledine	0113a643a2	quick-and-dirty dir policy since the dirservers are getting hammered ... nick, could you abstract this sometime so we don't repeat the sockspolicy code twice? svn:r2589	2004-10-25 06:16:26 +00:00
Nick Mathewson	ef4ac65f5e	Document the swiss-army-knife that retry_listeners has become ... svn:r2584	2004-10-24 01:50:33 +00:00
Nick Mathewson	0df2d383d1	Many non-native speakers use Tor. It is our duty to ensure that our log messages set an example of good English spelling. ... svn:r2583	2004-10-24 01:29:01 +00:00
Nick Mathewson	57f09573f5	Every 60 seconds, check whether the listeners are still alive, and relaunch the dead ones. ... svn:r2581	2004-10-24 01:22:40 +00:00
Nick Mathewson	5d53828c57	Handle more errnos from accept() without closing the connection. This may fix a bug that could close OR listeners when (a) TCP connections were hung up before accept() could be called, or (b) during FD exhaustion. ... svn:r2579	2004-10-24 00:55:18 +00:00
Roger Dingledine	de65052312	don't assert multiple things in the same tor_assert() ... svn:r2544	2004-10-16 22:14:52 +00:00
Nick Mathewson	25a046df74	Fix unit tests, make it compile ... svn:r2543	2004-10-16 21:57:24 +00:00
Nick Mathewson	47dc024f7e	Change interface of parse_addr_port() to return address in host order, since most users seem to want that. ... svn:r2542	2004-10-16 21:53:30 +00:00
Nick Mathewson	0f144d6a04	fix warning on win32 ... svn:r2518	2004-10-14 15:41:41 +00:00
Roger Dingledine	cf9664151d	bugfix on a really old bug: ... if read() fails on a stream, send back an end cell before you close it down. svn:r2509	2004-10-14 09:28:31 +00:00
Nick Mathewson	1c9426d6e0	Build without warnings on mac gcc 3.3 ... svn:r2487	2004-10-14 03:18:14 +00:00
Roger Dingledine	aebc3a03ba	more int to size_t conversions, fixing one or more amd64 bugs ... plus a whitespace patch on config.c from vicman svn:r2482	2004-10-14 02:47:09 +00:00
Nick Mathewson	0d5a847f12	Remove need for dirservers file: now, we note trusted dirservers in configuration options, and only need to remember addr:port and key digest for each one. ... svn:r2479	2004-10-14 01:44:32 +00:00
Roger Dingledine	2b7b86f5e6	stop trying to print a NULL ... plus make router_nickname_is_approved() more obviously unused svn:r2469	2004-10-13 20:17:45 +00:00
Nick Mathewson	e0cce8fba8	Unify tests for "did I originate this nonopen OR connection?" ... svn:r2468	2004-10-13 20:05:57 +00:00
Nick Mathewson	508970f85d	fix typo ... svn:r2466	2004-10-13 19:55:40 +00:00
Nick Mathewson	149f57bdef	answer question about rep_hist_note_connect_failed ... svn:r2464	2004-10-13 19:42:36 +00:00
Nick Mathewson	0383afac9a	Use parse_addr_port() function instead of ad-hoc variants ... svn:r2441	2004-10-12 15:52:09 +00:00
Roger Dingledine	136d4e5739	prefer tor_free to free ... plus complain more loudly when we fail to parse a dir we just fetched svn:r2401	2004-09-29 06:52:36 +00:00
Nick Mathewson	c66e4c4870	Flush more changes from sandbox ... - make clients cache directories and use them to seed their router lists at startup. This means clients have a datadir again. - Introduce a global_write_bucket. We need to respond better to exhausting it. - Remove the last vestiges of LinkPadding and TrafficShaping. - Configuration infrastructure support for warning on obsolete options. - Refactor directory header parsing to use smartlist_split_string. - Respond to content-encoding headers by trying to uncompress as appropriate. - Reply with a deflated directory when a client asks for "dir.z". (We could use allow-encodings instead, but allow-encodings isn't specified in HTTP 1.0.) svn:r2335	2004-09-08 06:52:33 +00:00
Nick Mathewson	9836ccda8c	Move a paren 4 characters to the left; fix a bug in OutboundBindAddress ... svn:r2330	2004-09-02 23:25:23 +00:00
Roger Dingledine	2d8a1f208a	if they ask for exactly one entrynode, don't pick it as an exitnode. ... also, fix part of the zero-identity-router-in-stats bug svn:r2252	2004-08-17 07:09:02 +00:00
Roger Dingledine	0a6e27208b	o Handle servers with dynamic IP addresses: don't replace ... options->Address with the resolved one at startup. o detect our address right before we make a routerinfo each time. o external IP vs bind-IP. Already done, just use options->Address. o OutboundBindAddress config option, to bind to a specific IP address for outgoing connect()s. svn:r2241	2004-08-16 11:43:18 +00:00
Roger Dingledine	699a9d8b46	commit some minor fixes from this sandbox so i can commit the next one ... svn:r2229	2004-08-15 05:28:09 +00:00
Roger Dingledine	7506cce649	stop wasting cpu time on authdirservers ... we were making a new directory only when the old one was dirty, but every time we made one, we'd dirty it by testing it right then. svn:r2199	2004-08-08 11:15:38 +00:00
Roger Dingledine	b2c7b5adfb	fix a race condition in 008pre2: don't try to extend onto a connection ... that's still handshaking. for servers in clique mode, require the conn to be open before you'll choose it for your path. svn:r2198	2004-08-08 10:32:36 +00:00
Roger Dingledine	276d953b22	fix an assert: check the sockspolicy before we make/add the connection, ... else we close a connection without assigning it a state, which is bad because it fails assert_conn_ok() svn:r2156	2004-08-06 09:56:36 +00:00
Roger Dingledine	0da256ef97	when we get a sigint, don't accept new connections/circuits, ... but delay 30 seconds until exiting. if we get a second sigint, exit immediately. svn:r2070	2004-07-20 23:31:00 +00:00
Roger Dingledine	dc7951a5a7	a whole swath of fixes ... introduce an authdir_mode() macro to match the others. don't initialize uptime to the number of seconds since 1970. non-authoritative dirservers don't cache their directory on disk. make only authdirservers use clique_mode. only read approved-routers file if you're an authdirserver. even authdirservers fetch a new directory in do_hup. retry_all_connections() is now called retry_all_listeners(). router_parse_list_from_string() correctly reports the router number it's working on. only call dirserv_add_own_fingerprint() and dirserv_add_descriptor() on startup if we're an authdirserver. if AuthDir and !ORPort then fail. if AuthDir and ClientOnly then fail. svn:r2061	2004-07-20 10:17:43 +00:00
Roger Dingledine	a5ff0527e6	it turns out we weren't looking at the result from getsockopt(). ... now we do. but i'm not sure it matters, since we also poll for reads, and if there's an error with the connecting socket, poll is supposed to return readable, so we should notice it then. who knows. svn:r2057	2004-07-19 23:26:21 +00:00
Nick Mathewson	54c129d8dc	abstract ORPort/SocksPort checks into server_mode(), proxy_mode(), clique_mode(), etc. Dont change underlying comments. ... svn:r2054	2004-07-18 21:47:04 +00:00
Nick Mathewson	c2103eb63a	Finish most pre2 items: make running-routers list work right; rename secret key files; make even more lookup-by-nickname use lookup-by-id; default nicknames to hostname. ... svn:r2043	2004-07-13 18:23:40 +00:00
Roger Dingledine	d37850bb98	only count bytes transmitted to/from non-local IPs ... svn:r2041	2004-07-13 16:58:01 +00:00
Roger Dingledine	86e0ede07e	checkpoint: start working on bandwidth tracking and ... letting clients evaluate whether they're suitable servers svn:r2037	2004-07-13 07:42:20 +00:00
Roger Dingledine	2325050b1b	tor now tolerates down dirservers better ... svn:r2031	2004-07-12 20:39:40 +00:00
Roger Dingledine	538655cd80	if connecting to an OR fails immediately, mark it as down ... svn:r2029	2004-07-12 18:19:55 +00:00
Roger Dingledine	cbf73b2bc5	touchups all over ... put uptime in descriptor svn:r2011	2004-07-04 22:48:11 +00:00
Nick Mathewson	7d8de8cd10	More digest/nickname fixes ... svn:r2000	2004-07-02 23:40:03 +00:00
Nick Mathewson	541add90a1	Track routers by hash of identity key; use hex hash of identity key in place of nickname; accept (and use) hash of identity key in EXTEND cells. ... svn:r1994	2004-07-01 01:16:59 +00:00
Nick Mathewson	3708886939	Implement RESOLVE/RESOLVED cells and socks resolve code ... svn:r1978	2004-06-17 18:13:09 +00:00
Nick Mathewson	17b5b3685f	Make tor build on win32 again; handle locking for server ... svn:r1948	2004-06-05 01:50:35 +00:00
Roger Dingledine	69931106f8	be sure to detach streams from the circuit linked list before freeing them ... also, don't bother marking a conn for close if you're about to free it svn:r1935	2004-06-02 18:32:24 +00:00
Roger Dingledine	f51061439b	when the dns resolve is cancelled, or fails, be sure to remove ... conn from circ->resolving_streams otherwise it gets freed and stays there, causing seg faults. svn:r1915	2004-05-21 12:25:15 +00:00
Roger Dingledine	b6faca2268	enable checking the socks policy ... svn:r1906	2004-05-20 04:16:43 +00:00
Nick Mathewson	80365b9897	Allow multiple exit policy lines; mostly add support for AP policies ... svn:r1905	2004-05-20 02:42:50 +00:00
Roger Dingledine	b37450ce55	do all the heavy lifting in connection_about_to_close_connection, ... not in _connection_mark_for_close this will hopefully clean up the huge cyclical function mess svn:r1903	2004-05-19 23:32:20 +00:00
Nick Mathewson	d95f347b14	Add Port to *bindAddress. ... svn:r1901	2004-05-19 20:25:44 +00:00
Roger Dingledine	630e930799	don't flush the buf from inside connection_write_to_buf ... svn:r1859	2004-05-12 22:56:26 +00:00
Roger Dingledine	1cf1836990	break connection_edge_end out of connection_mark_for_close ... svn:r1858	2004-05-12 21:12:33 +00:00
Nick Mathewson	537fb82cbb	Make some functions static ... svn:r1857	2004-05-12 20:58:27 +00:00
Roger Dingledine	32c42a0ee2	break rend_client_desc_fetched out of connection_mark_for_close ... svn:r1856	2004-05-12 20:36:44 +00:00
Roger Dingledine	7ee6194f3a	break part of circuit.c into relay.c ... svn:r1854	2004-05-12 19:49:48 +00:00
Nick Mathewson	f1bc7af9f5	Make "connected" a different case from "finished_flushing"; always close_immediate whhen connect() fails. ... svn:r1852	2004-05-12 19:17:09 +00:00
Roger Dingledine	3cdf2d67da	it's amazing what a bit of punctuation can do for appearances ... svn:r1843	2004-05-10 10:27:54 +00:00
Roger Dingledine	341d6f2cab	more cleanup, including fleshing out or.h more ... svn:r1839	2004-05-10 07:37:10 +00:00
Nick Mathewson	81922a125c	More doxygenation. ... svn:r1832	2004-05-10 04:34:48 +00:00
Roger Dingledine	397466a23d	give connection.c a skeletal file/brief header ... svn:r1831	2004-05-10 03:56:58 +00:00
Roger Dingledine	8f6aa6688f	function header comments for connection.c, including doxygen markup ... svn:r1825	2004-05-10 01:32:57 +00:00
Roger Dingledine	b384c5a18d	bugfix: do directory_send_command only after we've established a socket ... also many comments, cleaning, etc svn:r1823	2004-05-09 16:33:04 +00:00
Roger Dingledine	9bf9ca4d09	bugfix: add a circ->resolving_streams field, and make dns resolving streams not actually in the connection_array until they're done resolving. ... bugfix: actually complain if we duplicate mark-for-close a circuit add more logging for relay ends that claim dns resolve failed, so we can find out why they're not being retried. svn:r1798	2004-05-06 11:08:04 +00:00
Nick Mathewson	2ba0776b02	Only connection_add connections once they have conn->s sett; refactor code around this. Should make stuff more bulletproof. ... svn:r1788	2004-05-05 01:26:57 +00:00
Nick Mathewson	af08c4f878	Working strerror for windows socket errors, plus some snide comments. ... svn:r1775	2004-05-02 20:18:21 +00:00
Roger Dingledine	25909c2c29	patches on patches ... svn:r1763	2004-05-02 03:15:55 +00:00
Nick Mathewson	f6fe336ad4	Documenmt buffers.c; remove function that nobody ever calls. ... svn:r1760	2004-05-01 22:08:43 +00:00
Nick Mathewson	6fa2ded74c	Fix windows compile ... svn:r1757	2004-05-01 20:55:31 +00:00
Nick Mathewson	908ccb9dcd	Handle windows socket errors correctly; comment most of common. ... svn:r1756	2004-05-01 20:46:28 +00:00
Nick Mathewson	9322641710	Use socketclose on windows as appropriate; end pid files with newline ... svn:r1745	2004-04-28 21:14:56 +00:00
Roger Dingledine	dd335d9bb2	use tor_lookup_hostname for binding local addresses too ... svn:r1744	2004-04-28 20:57:03 +00:00
Roger Dingledine	80d0b634a4	add a debugging entry, to find the wants-to-read-but-can't bug ... svn:r1719	2004-04-26 21:15:06 +00:00
Roger Dingledine	fb2279b90b	since we don't support truncateds much, don't bother sending them; ... just close the circ. (this wasn't relevant before, because we were mis-handling destroys.) svn:r1711	2004-04-26 04:32:01 +00:00
Roger Dingledine	10f3b74cb9	tell us the nickname of the OR that hung up on us ... svn:r1706	2004-04-26 01:50:08 +00:00
Roger Dingledine	482d7e7cd3	resolve a double-mark-for-close when things die inside connection_handle_write ... svn:r1702	2004-04-25 22:23:54 +00:00
Roger Dingledine	25d54257fb	use tor_assert ... remove obsolete BUF_OK macro svn:r1697	2004-04-25 20:37:37 +00:00
Nick Mathewson	0fca143ea1	Remove onion_pkey from connection, since onion keys can change more often than connections. Also add more log messages ... svn:r1693	2004-04-25 19:04:11 +00:00
Roger Dingledine	e355ed0e15	log correctly if decoding onion failed ... svn:r1690	2004-04-25 04:49:11 +00:00
Nick Mathewson	c44016e86e	Merge flagday into main branch. ... svn:r1683	2004-04-24 22:17:50 +00:00
Roger Dingledine	8e686d0c72	we added more AP conns, oops ... svn:r1569	2004-04-08 07:25:54 +00:00
Roger Dingledine	e79a578fec	if the rend desc cache entry was fetched more than 15 mins ago, ... then try to fetch a new one. but if the new fetch fails, use the old one. svn:r1540	2004-04-07 22:41:00 +00:00
Nick Mathewson	3d60cd1d61	Delete trailing whitespace and expand tabs; remove unused aes decrypt code ... svn:r1522	2004-04-07 19:57:40 +00:00
Roger Dingledine	7793078dff	alice can now look up bob's service descriptor, ... choose an intro point, connect to it, choose a rend point, connect to it and establish a cookie, get an ack from the rendezvous point, and know when both circs are ready for her. APConns don't use conn->purpose anymore don't initiate a renddesc lookup if one is already in progress also fix a buffer overflow in nickname parsing (only exploitable by the operator though) svn:r1471	2004-04-05 00:47:48 +00:00
Roger Dingledine	bbc9484957	fix some bugs; more remain ... svn:r1450	2004-04-03 00:55:53 +00:00
Roger Dingledine	2d3ac08633	Refactor directory servers ... * read all the time (before we would ignore eof sometimes, oops) * we can handle different urls now * send back 404 for an un-handled url * commands initiated by the client can handle payloads now * introduce conn->purpose to avoid exponential state-space explosion svn:r1400	2004-03-30 22:57:49 +00:00
Roger Dingledine	bcda3ebaef	bugfix: we were closing socks-request connections immediately, rather ... than flushing them, if they were timing out before we marked them svn:r1366	2004-03-29 20:04:09 +00:00
Roger Dingledine	e6a2e03524	hold socks reply open until flushed (if possible) ... svn:r1356	2004-03-28 09:48:21 +00:00
Roger Dingledine	56dfc3151f	work around a tsocks bug ... when an AP connection dies early, be sure to do a socks reject for it. if you just hang up, tsocks goes into an infinite loop. svn:r1352	2004-03-27 05:45:52 +00:00
Roger Dingledine	9ab5f3c067	fix an assert trigger where an OP would fail to handshake, and we'd ... expect it to have a nickname. svn:r1351	2004-03-27 01:28:14 +00:00
Roger Dingledine	4d747cd954	a missing comma could wreak all sorts of havoc. ... svn:r1335	2004-03-26 18:29:05 +00:00
Nick Mathewson	2ba2f02181	Integrate the new "rephist" [rep(utation) hist(ory)] module to trace ... successful/failed connections, successful/failed extends, and connection uptimes. It's still not done: more tests are needed, and not everything calls connection/circuit_mark_for_close properly. This skews the results. Also, there needs to be a 'testing' mode for non-OP ORs, where they periodically build circuits just to test whether extends work. svn:r1313	2004-03-20 04:59:29 +00:00
Roger Dingledine	74ef3a63ae	bugfix: decrement OR connections from global_bucket too ... bugfix: don't return immediately for has_pending_tls_data unless the conn is allowed to read svn:r1270	2004-03-14 17:06:29 +00:00
Roger Dingledine	703b2d3cf8	refactor bandwidth-control token buckets ... this is a checkpoint commit; there still remain some bugs, er, somewhere. svn:r1269	2004-03-14 16:00:52 +00:00
Roger Dingledine	87797bcde5	get rid of those pesky tabs ... svn:r1264	2004-03-12 13:00:34 +00:00
Nick Mathewson	9b4203266e	Make OP work on windows! (Also misc logging tweaks) ... svn:r1258	2004-03-11 06:19:08 +00:00
Nick Mathewson	0e5a134709	Fix DOS line endings; autoconfize checks for strptime and inet_aton ... svn:r1248	2004-03-09 22:09:13 +00:00
Nick Mathewson	2da54de968	Make tor build on windows again. More work still needed ... svn:r1247	2004-03-09 22:01:17 +00:00
Roger Dingledine	6c9d78b319	stop asserting that computers always go forward in time ... it's simply not true svn:r1236	2004-03-06 01:43:37 +00:00
Nick Mathewson	b7633e2e67	Try to find out early if buffers get trashed or double-freed. ... svn:r1225	2004-03-03 22:49:15 +00:00
Roger Dingledine	419a672222	holding until flush was borked ... we were never writing anything when hold_open_until_flushed was set, since conn_write returns early if marked_for_conn is set. seems a bit better now. svn:r1214	2004-03-03 08:46:18 +00:00
Roger Dingledine	d8e5f3a3a2	close immediately when write() fails too, else things will turn bad ... svn:r1212	2004-03-03 07:26:34 +00:00
Roger Dingledine	3c71d09402	use conn->hold_open_until_flushed for streams ... and also note/fix a variety of other stream-based bugs svn:r1210	2004-03-03 06:26:34 +00:00
Nick Mathewson	f4e4dac801	Implement hold_open_until_flushed. I may have missed something important. ... svn:r1209	2004-03-03 05:08:01 +00:00
Nick Mathewson	6379dbbe2a	warn more when losing data on closed/marked connections. ... svn:r1203	2004-03-03 02:07:57 +00:00
Roger Dingledine	49281424ae	bugfix: close_immediate called buf_clear but listeners don't have bufs ... svn:r1202	2004-03-03 01:58:45 +00:00
Nick Mathewson	a1e4c6dc85	Fix assertion failure spotted by arma. ... Apparently, when a DNS failure was already cached, then when we tried to mark the exit connection as closed, we'd try to remove it from the pending queue anyway, and hit an assert. Now, we put failed-resolve connections in a separate state so that mark_for_close does the right thing. svn:r1196	2004-03-02 07:24:11 +00:00
Roger Dingledine	195ee8c845	create a separate connection_edge_destroy() function ... svn:r1176	2004-02-29 00:11:37 +00:00
Roger Dingledine	ae67c48805	bugfix: in some cases, connection_mark_for_close wasn't marking the conn ... svn:r1174	2004-02-28 23:52:56 +00:00
Nick Mathewson	0a673f4491	Split dns_cancel_pending_resolve into dns_cancel_pending_resolve (kill a ... resolve in response to a DNS worker dying) and connection_dns_remove (remove a pending connection from the resolve structure.) svn:r1168	2004-02-28 22:23:44 +00:00
Nick Mathewson	f039eca658	Stop trying to flush on broken sockets marked for close. ... svn:r1163	2004-02-28 19:14:11 +00:00
Roger Dingledine	80410fa8dc	some comments to point nick at the latest bugs ... svn:r1162	2004-02-28 11:48:22 +00:00
Roger Dingledine	cec2eee533	enable assert_connection_ok() ... we weren't actually asserting much. oops. svn:r1160	2004-02-28 07:51:30 +00:00
Roger Dingledine	70c43e152a	note bug in assert_connection_ok ... svn:r1159	2004-02-28 07:48:28 +00:00
Roger Dingledine	dd632e697e	clean up some log messages and severities ... still plenty more left to clean svn:r1158	2004-02-28 07:01:22 +00:00
Roger Dingledine	e59f19ca03	some more small fixes ... svn:r1152	2004-02-28 04:44:48 +00:00
Nick Mathewson	4e89c6661a	Push responsibility for connection marking down as far as possible; have only a close path; add some missing end cells; change return conventions a little. ... svn:r1149	2004-02-28 04:11:53 +00:00
Nick Mathewson	88e222ff76	Make has_sent_end irrelevant: only try to send end if reason is nonzero ... svn:r1148	2004-02-28 03:06:31 +00:00
Roger Dingledine	d0ad9b147a	and another one ... svn:r1147	2004-02-27 23:30:27 +00:00
Roger Dingledine	611f117ce1	patches/answers to nick's commit ... svn:r1146	2004-02-27 23:23:33 +00:00
Nick Mathewson	c5bbb571d2	Refactor mark_for_close, connection_edge_end and friends. Now, everybody ... who wants to shut down a connection calls connection_mark_for_close instead of setting marked_for_close to 1. This automatically removes the connection from the DNS cache if needed, sends a RELAY END cell if appropriate, and can be changed to do whatever else is needed. Still to do: - The same for circuits, maybe. - Add some kind of hold_connection_open_until_flushed flag, maybe. - Change stuff that closes connections with return -1 to use mark_for_close, maybe. svn:r1145	2004-02-27 22:00:26 +00:00
Roger Dingledine	195dfd35a8	Fix a bug where you might flush some data on a tls connection, and then ... add some more data to be flushed but never turn POLLOUT on. not sure how commonly this bug was hit, but it would be a doozy. Also add some asserts to see if it happens elsewhere. svn:r1142	2004-02-27 04:42:14 +00:00
Nick Mathewson	496e414e52	Basic RAM poisoning and magic-checking to notice connection and circuit ... corruption faster; also, check for corruption in dns.c so we can fail fast for the bug that's nailing Lucky and moria3. svn:r1123	2004-02-25 07:31:46 +00:00
Roger Dingledine	1b25794a56	bugfix: if the exit stream is pending on the resolve, and a destroy ... arrives, then the stream wasn't getting removed from the pending list. this may have been the lucky-bug. this commit may also not actually fix the bug. it's darn hard to reproduce. svn:r1122	2004-02-25 06:57:57 +00:00
Roger Dingledine	7985f525ec	fix some bugs in assert_connection_ok ... svn:r1118	2004-02-24 22:33:30 +00:00
Roger Dingledine	f00dc6fe1e	last minute fix: don't early-flush non-tls streams ... e.g., this breaks directory service svn:r1033	2004-01-31 00:36:00 +00:00
Roger Dingledine	3516ae1a26	add an ap_conn connecting state; report connecting delay ... svn:r1011	2004-01-20 09:21:46 +00:00
Roger Dingledine	f5ebf4c712	push out a tls record's worth of data once you've got it ... svn:r1009	2004-01-20 02:14:51 +00:00
Roger Dingledine	c485725c5a	Fix the dns bug: children weren't dying ... We were telling a child to die by closing the parent's file descriptor to him. But newer children were inheriting the open file descriptor from the parent, and since they weren't closing them, the socket never closed, so the child never read eof, so he never knew to exit. As a side effect to this bug, we were probably failing to properly close connections to remote hosts, ORs, and OPs, after a dns child was born. I'm surprised Tor worked at all. svn:r974	2004-01-06 07:53:40 +00:00
Roger Dingledine	f3fdbadfdf	randomize the initial circ_id and stream_id, so an adversary who ... breaks in part-way through can't learn how many circs/streams have been made svn:r960	2003-12-28 04:46:09 +00:00
Roger Dingledine	a5e6ec244f	rename circ_id_t to uint16_t for code clarity ... change message when using non-recommended tor version svn:r954	2003-12-19 19:55:02 +00:00
Roger Dingledine	45a66c6955	make a relay_header_t struct and pack/unpack funcs ... split 7-byte stream_id string into 2-byte recognized and 2-byte stream_id fix two seg faults in fetch_from_buf_http fix several lurking seg faults in handling unexpected relay cells still need to * clean up relay_crypt * use relay dummies if there's going to be a conflict with rh.recognized * check for a conflict when generating stream_ids svn:r953	2003-12-19 05:09:51 +00:00
Roger Dingledine	6a19e64066	remove trailing whitespace ... svn:r951	2003-12-17 21:09:31 +00:00
Roger Dingledine	21cc01299b	infrastructure for integrity-checks in relay cells ... make circuit_consider_sending_sendme use connection_edge_send_command fix endian bug in relay length handling (maybe) svn:r946	2003-12-16 22:56:50 +00:00
Roger Dingledine	08534a6271	start tracking the 'It appears I've already sent the end' warning ... svn:r932	2003-12-14 08:32:14 +00:00
Roger Dingledine	36ea39ec9c	on hup, close and rebind listener ports too (in case their config has changed) ... svn:r926	2003-12-14 06:03:46 +00:00
Roger Dingledine	48e42e9346	back out the broken change from yesterday ... svn:r891	2003-12-09 01:04:11 +00:00
Roger Dingledine	8bd7c94bf6	general cleanups ... svn:r889	2003-12-07 22:03:47 +00:00
Roger Dingledine	d172fdd300	fix vicious bug in connection_ap_attach_pending that caused it to ... never work. fix vicious bug in choose_good_exit_server that caused it to *skip over* pending circuits, and look only at *non-pending circuits*, when choosing a good exit node for the new circuit. bugfix: remove incorrect asserts in circuit_get_newest() svn:r876	2003-12-03 09:50:02 +00:00
Roger Dingledine	02ec2cdb34	bugfix: we were writing to stderr even when it's closed ... svn:r868	2003-11-30 09:51:35 +00:00
Roger Dingledine	3818776f62	remove a conn_close_if_marked warning ... Nov 27 15:45:19.003 [warn] connection_write_to_buf(): write_to_buf failed. Closing connection (fd 42). Nov 27 15:45:19.010 [warn] conn_close_if_marked(): Conn (socket 42) still wants to flush. Losing 0 bytes! svn:r866	2003-11-30 09:35:26 +00:00
Roger Dingledine	00de055f43	bugfix: an offline OP would leak all its sockets and stop working ... svn:r865	2003-11-29 02:50:12 +00:00
Nick Mathewson	1155ae9b03	Bring assert_connection_ok up to date ... svn:r863	2003-11-23 18:14:19 +00:00
Roger Dingledine	c00953d2a1	make more sure we can't end up with two connections to the same OR ... fix leaked pk in connection_tls_finish_handshake svn:r839	2003-11-18 10:17:52 +00:00
Roger Dingledine	ac56486bf6	use the tor_malloc_zero wrapper ... svn:r837	2003-11-18 08:20:19 +00:00
Nick Mathewson	7bde42676b	Rename aci to circ_id throughout. ... svn:r784	2003-11-11 03:01:48 +00:00
Nick Mathewson	dafb0e6a6e	Make AP connections wait for a circuit if none exists. ... Also: - Refactor socks request into a separate struct - Add a separate 'waiting for circuit' state to AP connections between 'waiting for socks' and 'open'. Arma: can you check out the XXX's I've added to connection_edge? I may be mishandling some async and close logic. svn:r783	2003-11-11 02:41:31 +00:00
Roger Dingledine	1969c8a92f	client now survives going offline better ... fix badness in usage() if neither socksport nor orrport is defined, quit obsolete connection_flush_buf() svn:r780	2003-11-10 08:06:55 +00:00
Roger Dingledine	52589289fe	add DirBindAddress, parse the BindAddress's when you bind ... exit if bind fails add usage printfs rearrange config options for readability svn:r674	2003-10-25 12:01:09 +00:00
Roger Dingledine	c6b442a346	make end relay cells have payloads ... move default exit policy into config files svn:r653	2003-10-22 07:55:44 +00:00
Roger Dingledine	e4127e4d36	move closer to being able to reload config on HUP ... rename APPort to SocksPort introduce new tor_free() macro svn:r642	2003-10-21 09:48:17 +00:00
Roger Dingledine	4a66865d0b	send the end cell when we realize we're going to end, ... not when we're closing the stream. this lets us put a payload in the end cell if we want to, to describe why we're closing the stream. there are still some places where we don't send the end cell immediately. i need to track them down. but it's a low priority, since i've made it send the end cell when we close the stream if we haven't already sent it. svn:r640	2003-10-21 08:37:07 +00:00
Roger Dingledine	11a23fc280	clean up logging, allow user to specify log files ... If DebugLogFile is specified, log to it at -l debug If LogFile is specified, log to it at the -l from the commandline (default info) If no LogFile *and* not a Daemon, then log to stdout. Make conn->s = -1 by default (this might break things) When kill -USR1, prefer to log at INFO, but make sure they always see it. svn:r596	2003-10-15 18:50:16 +00:00
Nick Mathewson	959b5585a5	Stop using stdout for non-debugging cases ... svn:r592	2003-10-15 18:28:32 +00:00
Roger Dingledine	58ec05877a	make the buffer resize stuff work ... and make listener connections not have bufs svn:r584	2003-10-14 03:06:48 +00:00
Roger Dingledine	b9628f266f	change WARNING to WARN ... and fix a few typos svn:r571	2003-10-10 01:48:32 +00:00
Nick Mathewson	ecfb36823e	Refactor, rename, and clarify ... svn:r569	2003-10-09 18:45:14 +00:00
Nick Mathewson	36939303c9	Update LICENSE and copyright dates. ... svn:r560	2003-10-08 02:04:08 +00:00
Roger Dingledine	de6cbe53c0	some early bugfixes ... our log() conflicts with log(3) distribute only the correct files from doc/ and src/config/ sometimes laptops go back in time. i guess that's ok for now. and bump the version number because we're live. svn:r544	2003-10-07 16:30:05 +00:00
Roger Dingledine	be874358a4	wrap strdup; prefer time() to gettimeofday() ... svn:r538	2003-10-04 03:29:09 +00:00