nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-24 04:13:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug 8845: check the right length of memory in aes unit tests

Browse Source 
This couldn't actually be a buffer overrun unless AES somehow turned
into memcpy, but still it's good to fix it.
This commit is contained in:
Nick Mathewson 2013-05-08 12:59:08 -04:00
parent a1d7f7ea50
commit 7d3fd85838
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
changes/bug8845 Normal file
View File

@ -0,0 +1,3 @@
o Minor bugfixes (test):
- Fix an impossible buffer overrun in the AES unit tests. Fixes bug 8845;
bugfix on 0.2.0.7-alpha. Found by eugenis.

2
src/test/test_crypto.c
View File

@ -730,7 +730,7 @@ test_crypto_aes_iv(void *arg)
/* Decrypt with the wrong key. */ /* Decrypt with the wrong key. */
decrypted_size = crypto_cipher_decrypt_with_iv(key2, decrypted2, 4095, decrypted_size = crypto_cipher_decrypt_with_iv(key2, decrypted2, 4095,
encrypted1, encrypted_size); encrypted1, encrypted_size);
test_memneq(plain, decrypted2, encrypted_size); test_memneq(plain, decrypted2, decrypted_size);
/* Alter the initialization vector. */ /* Alter the initialization vector. */
encrypted1[0] += 42; encrypted1[0] += 42;
decrypted_size = crypto_cipher_decrypt_with_iv(key1, decrypted1, 4095, decrypted_size = crypto_cipher_decrypt_with_iv(key1, decrypted1, 4095,