From 2995e26a81997c3972382fbba0dfaf26d5b38c68 Mon Sep 17 00:00:00 2001 From: pokkst Date: Sun, 3 Dec 2023 17:51:46 -0600 Subject: [PATCH] Add content description to image buttons for accessibility purposes --- app/src/main/res/layout/fragment_home.xml | 1 + app/src/main/res/layout/fragment_onboarding.xml | 1 + app/src/main/res/layout/fragment_receive.xml | 2 ++ app/src/main/res/layout/fragment_send.xml | 2 ++ app/src/main/res/layout/fragment_transaction.xml | 2 ++ app/src/main/res/layout/transaction_output_item.xml | 4 ++++ .../res/layout/wallet_keys_bottom_sheet_dialog.xml | 1 + app/src/main/res/values/strings.xml | 11 +++++++++++ 8 files changed, 24 insertions(+) diff --git a/app/src/main/res/layout/fragment_home.xml b/app/src/main/res/layout/fragment_home.xml index a6b5065..0ba92ae 100644 --- a/app/src/main/res/layout/fragment_home.xml +++ b/app/src/main/res/layout/fragment_home.xml @@ -165,6 +165,7 @@ android:minWidth="48dp" android:minHeight="48dp" android:padding="8dp" + android:contentDescription="@string/settings" android:src="@drawable/ic_settings" app:layout_constraintBottom_toBottomOf="@id/balance_unlocked_textview" app:layout_constraintEnd_toEndOf="parent" diff --git a/app/src/main/res/layout/fragment_onboarding.xml b/app/src/main/res/layout/fragment_onboarding.xml index dd01c2c..ee7dfe3 100644 --- a/app/src/main/res/layout/fragment_onboarding.xml +++ b/app/src/main/res/layout/fragment_onboarding.xml @@ -93,6 +93,7 @@ android:layout_height="wrap_content" android:minWidth="24dp" android:minHeight="24dp" + android:contentDescription="@string/display_advanced_wallet_creation_options" android:src="@drawable/ic_keyboard_arrow_down" app:layout_constraintBottom_toBottomOf="@id/advanced_settings_dropdown_textview" app:layout_constraintStart_toEndOf="@id/advanced_settings_dropdown_textview" diff --git a/app/src/main/res/layout/fragment_receive.xml b/app/src/main/res/layout/fragment_receive.xml index af4b654..cb24800 100644 --- a/app/src/main/res/layout/fragment_receive.xml +++ b/app/src/main/res/layout/fragment_receive.xml @@ -28,6 +28,7 @@ android:src="@drawable/ic_refresh" android:minWidth="48dp" android:minHeight="48dp" + android:contentDescription="@string/generate_fresh_wallet_address" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintTop_toTopOf="@id/recv_monero_textview" app:layout_constraintBottom_toBottomOf="@id/recv_monero_textview" @@ -94,6 +95,7 @@ android:layout_marginTop="16dp" android:minWidth="48dp" android:minHeight="48dp" + android:contentDescription="@string/copy_selected_wallet_address" android:src="@drawable/ic_content_copy_24dp" app:layout_constraintBottom_toTopOf="@id/address_list_recyclerview" app:layout_constraintEnd_toEndOf="parent" diff --git a/app/src/main/res/layout/fragment_send.xml b/app/src/main/res/layout/fragment_send.xml index 37a0f3b..dd5357b 100644 --- a/app/src/main/res/layout/fragment_send.xml +++ b/app/src/main/res/layout/fragment_send.xml @@ -45,6 +45,7 @@ android:background="@android:color/transparent" android:minWidth="48dp" android:minHeight="48dp" + android:contentDescription="@string/add_recipient_to_transaction" android:src="@android:drawable/ic_input_add" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintTop_toTopOf="parent" @@ -219,6 +220,7 @@ app:slider_height="72dp" app:slider_locked="false" app:text="@string/slide_to_send" + android:focusable="true" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintStart_toStartOf="parent" app:text_size="18sp" diff --git a/app/src/main/res/layout/fragment_transaction.xml b/app/src/main/res/layout/fragment_transaction.xml index 1246159..e56cc82 100644 --- a/app/src/main/res/layout/fragment_transaction.xml +++ b/app/src/main/res/layout/fragment_transaction.xml @@ -81,6 +81,7 @@ android:background="@android:color/transparent" android:minWidth="48dp" android:minHeight="48dp" + android:contentDescription="@string/copy_transaction_addr" android:src="@drawable/ic_content_copy_24dp" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toEndOf="@id/transaction_address_textview" @@ -120,6 +121,7 @@ android:background="@android:color/transparent" android:minWidth="48dp" android:minHeight="48dp" + android:contentDescription="@string/copy_transaction_hash" android:src="@drawable/ic_content_copy_24dp" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toEndOf="@id/transaction_hash_textview" diff --git a/app/src/main/res/layout/transaction_output_item.xml b/app/src/main/res/layout/transaction_output_item.xml index 0a3ac91..9d28cdb 100644 --- a/app/src/main/res/layout/transaction_output_item.xml +++ b/app/src/main/res/layout/transaction_output_item.xml @@ -72,6 +72,7 @@ android:background="@android:color/transparent" android:minWidth="48dp" android:minHeight="48dp" + android:contentDescription="@string/paste_clipboard_into_amount_field" android:src="@drawable/ic_content_paste_24dp" app:layout_constraintBottom_toBottomOf="@id/amount_edittext" app:layout_constraintEnd_toStartOf="@id/remove_output_imagebutton" @@ -87,6 +88,7 @@ android:background="@android:color/transparent" android:minWidth="48dp" android:minHeight="48dp" + android:contentDescription="@string/paste_clipboard_into_address_field" android:src="@drawable/ic_content_paste_24dp" app:layout_constraintBottom_toBottomOf="@id/address_edittext" app:layout_constraintEnd_toStartOf="@id/scan_address_imagebutton" @@ -103,6 +105,7 @@ android:minHeight="48dp" android:layout_marginEnd="24dp" android:src="@drawable/ic_scan" + android:contentDescription="@string/scan_qr_code_for_address_field" app:layout_constraintBottom_toBottomOf="@id/address_edittext" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toEndOf="@id/paste_address_imagebutton" @@ -117,6 +120,7 @@ android:minWidth="48dp" android:minHeight="48dp" android:layout_marginEnd="24dp" + android:contentDescription="@string/remove_recipient_from_transaction" android:src="@android:drawable/ic_delete" app:layout_constraintBottom_toBottomOf="@id/amount_edittext" app:layout_constraintEnd_toEndOf="parent" diff --git a/app/src/main/res/layout/wallet_keys_bottom_sheet_dialog.xml b/app/src/main/res/layout/wallet_keys_bottom_sheet_dialog.xml index 21f071d..0fe1f2c 100644 --- a/app/src/main/res/layout/wallet_keys_bottom_sheet_dialog.xml +++ b/app/src/main/res/layout/wallet_keys_bottom_sheet_dialog.xml @@ -122,6 +122,7 @@ android:background="@android:color/transparent" android:minWidth="48dp" android:minHeight="48dp" + android:contentDescription="@string/copy_wallet_s_private_view_key" android:src="@drawable/ic_content_copy_24dp" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintVertical_bias="0.0" diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 604339c..230186b 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -140,5 +140,16 @@ Maximum allowed outputs Cannot send to integrated addresses in a pay-to-many transaction Slide to send + Display advanced wallet creation options + Generate fresh wallet address + Copy selected wallet address + Add recipient to transaction + Copy wallet\'s private view-key + Paste clipboard into amount field + Paste clipboard into address field + Remove recipient from transaction + Scan QR code for address field + Copy transaction hash + Copy transaction address