Kevin Barbour
85db1734e7
Remove unused variables in monero codebase
...
There are quite a few variables in the code that are no longer
(or perhaps never were) in use. These were discovered by enabling
compiler warnings for unused variables and cleaning them up.
In most cases where the unused variables were the result
of a function call the call was left but the variable
assignment removed, unless it was obvious that it was
a simple getter with no side effects.
2021-02-09 08:05:05 +01:00
luigi1111
5c497ed22f
Merge pull request #7112
...
47590fc
rpc: report target height as 0 when synced (moneromooo-monero)
2021-01-15 23:43:46 -05:00
moneromooo-monero
1eb14af1a3
rpc: limit the number of txes for get_blocks.bin
2020-12-29 04:31:58 +00:00
moneromooo-monero
d2fda6c25f
restrict public node checks a little
...
do not include blocked hosts in peer lists or public node lists by default,
warn about no https on clearnet and about untrusted peers likely being spies
2020-12-22 23:39:07 +00:00
moneromooo-monero
5a1ac9c0ef
rpc: add a busy_syncing field to get_info
...
true if and pretty much only if new blocks are being added
2020-12-17 18:03:11 +00:00
moneromooo-monero
d660f22ed1
protocol: drop origin IP if a block fails to verify in sync mode
...
It would otherwise be possible for a peer to send bad blocks,
then disconnect and reconnect again, escaping bans
2020-12-10 21:59:18 +00:00
moneromooo-monero
47590fc80b
rpc: report target height as 0 when synced
...
since it only makes sense when syncing, and it confuses people
2020-12-10 17:05:34 +00:00
Alexander Blair
ce564e7ebf
Merge pull request #7030
...
0363476ee
rpc: get_info - add 'synchronized' field (xiphon)
2020-12-04 13:21:36 -08:00
Alexander Blair
976fcb5985
Merge pull request #7024
...
aaf837cf5
rpc: skip non-synced bootstrap daemons in --no-sync mode too (xiphon)
2020-12-01 14:23:21 -08:00
Alexander Blair
7cd0c64210
Merge pull request #6948
...
65903d2cf
Add rpc-restricted-bind-ip option (Howard Chu)
2020-12-01 14:21:19 -08:00
luigi1111
ad843541d5
Merge pull request #7008
...
3247f11
Silence stupid warnings (Howard Chu)
2020-11-29 01:57:24 -06:00
luigi1111
9945ca7a62
Merge pull request #6960
...
5569a8e
rpc: on_send_raw_tx (bootstrap) - send to bootstrap daemon and P2P (xiphon)
2020-11-29 01:53:12 -06:00
luigi1111
bb56248acd
Merge pull request #6949
...
aad780b
Fix CLI and unrestricted RPC relay_tx with stempool (Lee Clagett)
2020-11-29 01:52:23 -06:00
luigi1111
7539d4ac74
Merge pull request #6895
...
b49f489
fix next_seed_height regression in getblocktemplate rpc (xnbya)
2020-11-29 00:41:42 -06:00
luigi1111
678237835f
Merge pull request #6892
...
ad7ea2c
core_rpc_server: on_send_raw_tx - fix bootstrap daemon mode check (xiphon)
2020-11-29 00:40:03 -06:00
luigi1111
d45a4ba106
Merge pull request #6849
...
f4b2382
rpc_private_headers declaration fix (malbit)
2020-11-28 22:31:25 -06:00
xiphon
0363476ee3
rpc: get_info - add 'synchronized' field
2020-11-19 12:51:31 +00:00
xiphon
aaf837cf5f
rpc: skip non-synced bootstrap daemons in --no-sync mode too
2020-11-17 23:15:36 +00:00
xiphon
5569a8e426
rpc: on_send_raw_tx (bootstrap) - send to bootstrap daemon and P2P
2020-11-15 03:13:07 +00:00
Howard Chu
3247f11638
Silence stupid warnings
2020-11-11 02:34:14 +00:00
Lee Clagett
aad780bcfa
Fix CLI and unrestricted RPC relay_tx with stempool
2020-10-29 00:17:55 -04:00
Howard Chu
65903d2cfc
Add rpc-restricted-bind-ip option
...
Fixes #6369
2020-10-29 00:22:18 +00:00
Alexis Enston
b49f48962b
fix next_seed_height regression in getblocktemplate rpc
2020-10-13 11:07:59 +01:00
xiphon
4cf3545a31
core_rpc_server: on_get_blocks - forward bootstrap daemon error
2020-10-13 00:44:59 +00:00
xiphon
ad7ea2c60c
core_rpc_server: on_send_raw_tx - fix bootstrap daemon mode check
2020-10-12 23:49:37 +00:00
Michal m@lbit Malicki
f4b2382713
rpc_private_headers declaration fix
2020-09-27 13:41:44 +01:00
TheCharlatan
80e535c95a
wallet2: adapt to deterministic unlock time
2020-09-15 11:40:31 +00:00
moneromooo-monero
5498142e8f
rpc: assume randomx from v13 onwards
2020-09-07 01:13:06 +00:00
Riccardo Spagni
aefa7740c3
Merge pull request #6111
...
d20ff4f64
functional_tests: add a large (many randomx epochs) p2p reorg test (moneromooo-monero)
6a0b3b1f8
functional_tests: add randomx tests (moneromooo-monero)
9d42649d5
core: fix mining from a block that's not the current top (moneromooo-monero)
2020-09-06 15:49:37 +02:00
luigi1111
a51ccc036f
Merge pull request #6770
...
bdc6b10
Fix ZMQ pruned bulletproof transactions (vtnerd)
2020-08-31 16:50:18 -05:00
moneromooo-monero
9d42649d58
core: fix mining from a block that's not the current top
2020-08-27 15:13:00 +00:00
moneromooo-monero
82ee01699c
Integrate CLSAGs into monero
...
They are allowed from v12, and MLSAGs are rejected from v13.
2020-08-27 12:44:04 +00:00
Alexander Blair
27b49033fd
Merge pull request #6763
...
728ba38b1
rpc: always send raw txes through P2P (don't use bootstrap daemon) (xiphon)
2020-08-27 03:02:30 -07:00
Lee Clagett
bdc6b10d62
Fix ZMQ pruned bulletproof transactions
2020-08-19 00:36:06 -04:00
moneromooo-monero
7175dcb107
replace most boost serialization with existing monero serialization
...
This reduces the attack surface for data that can come from
malicious sources (exported output and key images, multisig
transactions...) since the monero serialization is already
exposed to the outside, and the boost lib we were using had
a few known crashers.
For interoperability, a new load-deprecated-formats wallet
setting is added (off by default). This allows loading boost
format data if there is no alternative. It will likely go
at some point, along with the ability to load those.
Notably, the peer lists file still uses the boost serialization
code, as the data it stores is define in epee, while the new
serialization code is in monero, and migrating it was fairly
hairy. Since this file is local and not obtained from anyone
else, the marginal risk is minimal, but it could be migrated
later if needed.
Some tests and tools also do, this will stay as is for now.
2020-08-17 16:23:58 +00:00
Alexander Blair
d73b1b6560
Merge pull request #6727
...
13eee1d6a
rpc: reject wrong sized txid (moneromooo-monero)
92e6b7df2
easylogging++: fix crash with reentrant logging (moneromooo-monero)
6dd95d530
epee: guard against exceptions in RPC handlers (moneromooo-monero)
90016ad74
blockchain: guard against exceptions in add_new_block/children (moneromooo-monero)
2020-08-16 12:55:25 -07:00
Alexander Blair
569d07d60b
Merge pull request #6722
...
c1b03fb1a
rpc: return empty txid get_outs rather than 00..00 when not requested (moneromooo-monero)
2020-08-16 12:54:42 -07:00
Alexander Blair
a08df6eb1b
Merge pull request #6603
...
4e2377995
Change ZMQ-JSON txextra to hex and remove unnecessary base fields (Lee Clagett)
2020-08-16 12:43:38 -07:00
xiphon
728ba38b11
rpc: always send raw txes through P2P (don't use bootstrap daemon)
...
It turns out that some remote (bootstrap) nodes silently drop /
don't broadcast client's transactions.
2020-08-16 17:34:28 +00:00
Lee Clagett
4e2377995d
Change ZMQ-JSON txextra to hex and remove unnecessary base fields
2020-08-14 23:01:00 +00:00
Lee Clagett
60627c9f24
Switch to insitu parsing for ZMQ-JSON; GetBlocksFast reads 13%+ faster
2020-08-14 19:46:59 +00:00
Lee Clagett
fe96e66ebe
Fix pruned tx for ZMQ's GetBlocksFast
2020-08-14 19:46:33 +00:00
moneromooo-monero
13eee1d6ab
rpc: reject wrong sized txid
...
Reporter requested credit to be given to Decred
2020-07-30 22:52:14 +00:00
moneromooo-monero
c1b03fb1a6
rpc: return empty txid get_outs rather than 00..00 when not requested
...
It's more obvious there's no txid, and it saves space
2020-07-25 17:01:21 +00:00
Alexander Blair
a0d179e528
Merge pull request #6512
...
5ef0607da
Update copyright year to 2020 (SomaticFanatic)
2020-07-19 03:32:59 -07:00
luigi1111
e8d87fccc2
Merge pull request #6627
...
4df8f9c
rpc: fix loading rpc payment data from file (moneromooo-monero)
2020-07-08 17:22:33 -05:00
luigi1111
0376195015
Merge pull request #6611
...
dc1a053
rpc: fix comparison of seconds vs microseconds (moneromooo-monero)
2020-07-08 17:21:31 -05:00
luigi1111
3057f52f89
Merge pull request #6599
...
6e4a55b
rpc: fix relay_tx error return mixup (moneromooo-monero)
9b86e14
functional_tests: add simple relay_tx test (moneromooo-monero)
2020-07-08 17:20:29 -05:00
luigi1111
be170c485c
Merge pull request #6584
...
78d435a
rpc: don't display invalid json errors on default log level (moneromooo-monero)
2020-07-08 17:12:43 -05:00
luigi1111
8b3fa2d373
Merge pull request #6574
...
7ebb351
rpc: lock access to the rpc payment object (moneromooo-monero)
2020-07-08 17:11:32 -05:00