rottenwheel/monero
1
0
Fork 0
mirror of https://codeberg.org/anoncontributorxmr/monero.git synced 2024-11-24 03:43:27 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
9,295 Commits 1 Branch 0 Tags 178 MiB
81c5943453
Commit Graph

1178 Commits

Author SHA1 Message Date
moneromooo-monero
2ec455df1f
wallet: fix mismatch between two concepts of "balance" 
One considers the blockchain, while the other considers the
blockchain and some recent actions, such as a recently created
transaction which spend some outputs, but isn't yet mined.

Typically, the "balance" command wants the latter, to reflect
the recent action, but things like proving ownership wants
the former.

This fixes a crash in get_reserve_proof, where a preliminary
check and the main code used two concepts of "balance".
 2019-09-05 11:19:34 +00:00
luigi1111
a567e884b2
Merge pull request #5822 
839fc62 reject setting lookahead major or minor to 0 (moneromoo-monero)
 2019-09-04 09:39:07 -05:00
Lev Sizov
4ad191ffa9 Removed unused boost/value_init header 2019-09-02 14:38:29 +02:00
Jesus Ramirez
2cd4fd8972 Changed the use of boost:value_initialized for C++ list initializer 2019-09-02 14:16:29 +02:00
moneromooo-monero
1a367d6a22
simplewallet: lock console on inactivity 2019-08-28 19:01:48 +00:00
moneromooo-monero
21f6c80fcd
rpc: move a leftover light wallet RPC out of daemon RPC 2019-08-28 15:51:28 +00:00
luigi1111
8f6f674753
Merge pull request #5609 
1dc3b1a wallet: add --extra-entropy command line flag (moneromooo-monero)
 2019-08-27 15:14:15 -05:00
moneromooo-monero
c4da1a25c3
wallet2: fix unset_ring tx retrieval checks 2019-08-24 14:46:31 +00:00
moneromooo-monero
894cc81e83
wallet2: fix cold signing losing tx keys 2019-08-23 16:38:20 +00:00
Tadeas Moravec
63186a01ce
Wallet: Option to export data to ASCII 
New CLI wallet variable: export-format with options "binary" (the default),
or "ascii". "Binary" behaves as before, "ascii" forces the wallet to convert
data to ASCII using base64.

Reading files from the disk tries to auto detect what format has been
used (using a magic string added when exporting the data).

Implements https://github.com/monero-project/monero/issues/2859
 2019-08-22 16:03:22 +02:00
moneromooo-monero
1dc3b1a516
wallet: add --extra-entropy command line flag 
It lets the user add custom entropy to the PRNG.
It does this by hashing the new data and xoring the resulting
hash with the PRNG state.
 2019-08-22 11:12:57 +00:00
luigi1111
65e937168e
Merge pull request #5722 
8be5fea simplewallet: optional all flag to export_outputs/export_key_images (moneromooo-monero)
 2019-08-21 15:08:10 -05:00
luigi1111
f205d28e96
Merge pull request #5727 
7b9a420 Replace std::random_shuffle with std::shuffle (tomsmeding)
 2019-08-19 17:31:39 -05:00
moneromooo-monero
839fc6256b
reject setting lookahead major or minor to 0 2019-08-19 15:35:12 +00:00
luigi1111
1a259a1c70
Merge pull request #5672 
b2bfcab wallet2: fix change subaddress mixup when sending pre rct outputs (moneromooo-monero)
 2019-08-15 17:20:18 -05:00
luigi1111
739b02ef38
Merge pull request #5662 
64fb0f8 device: tx_key caching fixed, store recovered txkey (ph4r05)
 2019-08-15 17:19:12 -05:00
Tom Smeding
7b9a420787 Replace std::random_shuffle with std::shuffle 
According to [1], std::random_shuffle is deprecated in C++14 and removed
in C++17. Since std::shuffle is available since C++11 as a replacement
and monero already requires C++11, this is a good replacement.

A cryptographically secure random number generator is used in all cases
to prevent people from perhaps copying an insecure std::shuffle call
over to a place where a secure one would be warranted. A form of
defense-in-depth.

[1]: https://en.cppreference.com/w/cpp/algorithm/random_shuffle
 2019-08-15 16:33:15 +02:00
luigi1111
2258551ef9
Merge pull request #5487 
df83ed7 consensus: from v12, enforce >= 2 outputs (moneromooo-monero)
 2019-08-14 15:26:55 -05:00
luigi1111
c4071a00fb
Merge pull request #5600 
dd58057 Remember RPC version on initial connect (hyc)
 2019-07-24 14:29:10 -05:00
luigi1111
8ae2681e08
Merge pull request #5594 
f074b6b device: show address on device display (ph4r05)
 2019-07-24 14:24:40 -05:00
luigi1111
7138f9d347
Merge pull request #5514 
e4d100b wallet2: don't wait a day before using new version fees (moneromooo-monero)
 2019-07-24 14:00:54 -05:00
luigi1111
407683a38c
Merge pull request #5513 
bc94ba4 wallet: distinguish between empty and absent attributes (moneromooo-monero)
 2019-07-24 13:59:19 -05:00
luigi1111
e3de4aa68b
Merge pull request #5502 
25a7cfd add a few checks where it seems appropriate (moneromooo-monero)
1a66a86 remove unused code (moneromooo-monero)
 2019-07-24 13:57:06 -05:00
moneromooo-monero
8be5fea1de
simplewallet: optional all flag to export_outputs/export_key_images 2019-07-02 19:42:28 +00:00
moneromooo-monero
b2bfcab618
wallet2: fix change subaddress mixup when sending pre rct outputs 2019-06-19 09:39:16 +00:00
Dusan Klinec
f074b6b571
device: show address on device display 
- Trezor: support for device address display (subaddress, integrated address)
- Wallet::API support added
- Simplewallet:
  - address device [<index>]
  - address new <label>  // shows address on device also
  - integrated_address [device] <payment_id|address>  // new optional "device" arg to display also on the device
 2019-06-17 16:49:04 +02:00
Dusan Klinec
64fb0f872a
device: tx_key caching fixed, store recovered txkey 2019-06-17 14:53:39 +02:00
Howard Chu
dd58057126
Remember RPC version on initial connect 
Don't keep asking for it on an intact connection
Wallet is too chatty over the wire
 2019-06-02 09:31:50 +01:00
Riccardo Spagni
14d3295649
Merge pull request #5561 
9bfa4c20 Fix allow any cert mode in wallet rpc when configured over rpc (Lee Clagett)
3544596f Add ssl_options support to monerod's rpc mode. (Lee Clagett)
c9aaccf3 Fix configuration bug; wallet2 --daemon-ssl-allow-any-cert now works. (Lee Clagett)
 2019-06-01 20:21:45 +02:00
Lee Clagett
c9aaccf346 Fix configuration bug; wallet2 --daemon-ssl-allow-any-cert now works. 2019-05-21 15:43:27 -04:00
moneromooo-monero
915f59e3c0
wallet: add unlock_time details to show_transfers 
also add a note when receiving the tx, because the user
might not notice the "XXX blocks to unlock" in the balance.
 2019-05-16 21:37:05 +00:00
moneromooo-monero
615f287aec
wallet: fix certificate fingerprint length check 
Fixed by crCr62U0
 2019-05-11 13:05:06 +00:00
Riccardo Spagni
97cb1c9436
Merge pull request #5508 
1c44e658 wallet2: reject standalone short payment IDs in monero: URI API (moneromooo-monero)
 2019-05-07 17:35:28 +02:00
Riccardo Spagni
ebb1c03e8c
Merge pull request #5501 
b4ca72dd wallet2: fix infinite loop picking outputs in corner case (moneromooo-monero)
 2019-05-07 17:32:33 +02:00
moneromooo-monero
e4d100b062
wallet2: don't wait a day before using new version fees 
30 blocks should be more than enough to drain the txpool of
transactions made with the old fee scheme
 2019-05-02 18:00:25 +00:00
moneromooo-monero
bc94ba4d14
wallet: distinguish between empty and absent attributes 2019-05-02 13:00:08 +00:00
Riccardo Spagni
77f9bfa4d5
Merge pull request #5493 
5e0da6fb change SSL certificate fingerprint whitelisting from SHA1 to SHA-256 (moneromooo-monero)
 2019-05-02 11:30:28 +02:00
Riccardo Spagni
efd2412e77
Merge pull request #5489 
64983fce wallet2: default to trying to keep 5 outputs of 2+ monero (moneromooo-monero)
 2019-05-02 11:29:25 +02:00
moneromooo-monero
1c44e65863
wallet2: reject standalone short payment IDs in monero: URI API 2019-05-01 18:41:39 +00:00
moneromooo-monero
1a66a86f94
remove unused code 2019-04-29 20:52:40 +00:00
moneromooo-monero
b4ca72dde9
wallet2: fix infinite loop picking outputs in corner case 
If we have fewer outputs available on the chain than what we
require, but the output we're spending already has a ring,
it would loop picking outputs randomly, but never find enough.
Also tune logs for better debugging this kind of thing.
 2019-04-29 10:02:20 +00:00
moneromooo-monero
5e0da6fb68
change SSL certificate fingerprint whitelisting from SHA1 to SHA-256 
SHA1 is too close to bruteforceable
 2019-04-26 11:37:15 +00:00
Riccardo Spagni
581994b61c
Merge pull request #5486 
4be18df3 tx_sanity_check: relax uniqueness check a bit (moneromooo-monero)
b386ae57 wallet2: add missing "sanity check failed" reason message (moneromooo-monero)
 2019-04-24 22:41:40 +02:00
Riccardo Spagni
2e2ee3d823
Merge pull request #5485 
c519d1df wallet2: fix wrong change being recorded in sweep_all (moneromooo-monero)
 2019-04-24 22:41:18 +02:00
moneromooo-monero
64983fcee4
wallet2: default to trying to keep 5 outputs of 2+ monero 
In the case where previously a second unneeded output would be
added to a transaction. This should help *some* of the cases
where outputs are slowly being consolidated, leading to the
whole balance being locked when sending monero.
 2019-04-24 12:25:43 +00:00
moneromooo-monero
df83ed74e4
consensus: from v12, enforce >= 2 outputs 2019-04-23 22:09:35 +00:00
moneromooo-monero
b386ae5725
wallet2: add missing "sanity check failed" reason message 2019-04-23 21:59:57 +00:00
moneromooo-monero
c519d1df34
wallet2: fix wrong change being recorded in sweep_all 
leading to the sanity check triggering
 2019-04-23 21:58:55 +00:00
Dusan Klinec
97e1c9278c
wallet: fix key image computation signaling to the device 2019-04-22 16:14:50 +02:00
moneromooo-monero
588e670089
simplewallet: fix output representation offset 2019-04-18 15:14:41 +00:00
moneromooo-monero
35e0a968bd
wallet2: "output lineup" fake out selection 
Based on python code by sarang:
https://github.com/SarangNoether/skunkworks/blob/outputs/outputs/simulate.py
 2019-04-18 15:14:38 +00:00
Riccardo Spagni
c8ce4217cf
Merge pull request #5445 
b18f0b10 wallet: new --offline option (moneromooo-monero)
 2019-04-16 22:46:53 +02:00
Riccardo Spagni
1f01070a0c
Merge pull request #5434 
ccb996af rpc: new sanity check on relayed transactions (moneromooo-monero)
 2019-04-16 22:41:40 +02:00
Riccardo Spagni
8966ac314c
Merge pull request #5422 
2c221d1b wallet2: update estimate_rct_tx_size for smaller rct proofs (moneromooo-monero)
 2019-04-16 22:38:11 +02:00
Riccardo Spagni
96696d1e75
Merge pull request #5418 
374f388d wallet_rpc_server: add a all flag to export_outputs (moneromooo-monero)
 2019-04-16 22:37:52 +02:00
moneromooo-monero
b18f0b1051
wallet: new --offline option 
It will avoid connecting to a daemon (so useful for cold signing
using a RPC wallet), and not perform DNS queries.
 2019-04-15 09:14:12 +00:00
Riccardo Spagni
8bf0a3f123
Merge pull request #5396 
b40392fb wallet2: add --no-dns flag (moneromooo-monero)
 2019-04-15 09:17:26 +02:00
Riccardo Spagni
98f4c8af98
Merge pull request #5395 
15f27c80 wallet2: support multi out txes without change in sanity check (moneromooo-monero)
 2019-04-15 09:17:07 +02:00
Riccardo Spagni
89b8ecfc7c
Merge pull request #5392 
a2195b9b crypto: replace rand<T>()%N idiom with unbiased rand_idx(N) (stoffu)
 2019-04-15 09:14:28 +02:00
Riccardo Spagni
37aea526a9
Merge pull request #5355 
c68fe787 device/trezor: add button pressed request (Dusan Klinec)
827f52ad wallet: API changes to enable passphrase entry (Dusan Klinec)
 2019-04-15 09:12:20 +02:00
moneromooo-monero
ccb996afc6
rpc: new sanity check on relayed transactions 
This will weed out some transactions with silly rings
 2019-04-12 20:22:09 +00:00
moneromooo-monero
2c221d1b6c
wallet2: update estimate_rct_tx_size for smaller rct proofs 2019-04-11 17:31:18 +00:00
Riccardo Spagni
5db72d12b4
Merge pull request #5388 
0be5b2ee simplewallet: new unset_ring command (moneromooo-monero)
 2019-04-11 13:05:43 +02:00
Riccardo Spagni
5c02316598
Merge pull request #5382 
c12b43cb wallet: add number of blocks required for the balance to fully unlock (moneromooo-monero)
3f1e9e84 wallet2: set confirmations to 0 for pool txes in proofs (moneromooo-monero)
36c037ec wallet_rpc_server: error out on getting the spend key from a hot wallet (moneromooo-monero)
cd1eaff2 wallet_rpc_server: always fill out subaddr_indices in get_transfers (moneromooo-monero)
 2019-04-11 13:03:55 +02:00
Riccardo Spagni
3a4008f0fc
Merge pull request #5374 
a2561653 wallet: new option to start background mining (moneromooo-monero)
 2019-04-11 13:01:30 +02:00
moneromooo-monero
9f8dc4ce51
simplewallet: new net_stats command 
displays total sent and received bytes
 2019-04-11 10:46:41 +00:00
moneromooo-monero
374f388de2
wallet_rpc_server: add a all flag to export_outputs 
if we don't want to export new outputs only
 2019-04-10 10:37:34 +00:00
Lee Clagett
2e578b8214 Enabling daemon-rpc SSL now requires non-system CA verification 
If `--daemon-ssl enabled` is set in the wallet, then a user certificate,
fingerprint, or onion/i2p address must be provided.
 2019-04-07 13:02:43 -04:00
Dusan Klinec
c68fe7873b
device/trezor: add button pressed request 2019-04-07 13:35:49 +02:00
Lee Clagett
d58f368289 Require manual override for user chain certificates. 
An override for the wallet to daemon connection is provided, but not for
other SSL contexts. The intent is to prevent users from supplying a
system CA as the "user" whitelisted certificate, which is less secure
since the key is controlled by a third party.
 2019-04-07 00:44:37 -04:00
Lee Clagett
21eb1b0725 Pass SSL arguments via one class and use shared_ptr instead of reference 2019-04-07 00:44:37 -04:00
Lee Clagett
1f5ed328aa Change default SSL to "enabled" if user specifies fingerprint/certificate 
Currently if a user specifies a ca file or fingerprint to verify peer,
the default behavior is SSL autodetect which allows for mitm downgrade
attacks. It should be investigated whether a manual override should be
allowed - the configuration is likely always invalid.
 2019-04-06 23:47:07 -04:00
Lee Clagett
a3b0284837 Change SSL certificate file list to OpenSSL builtin load_verify_location 
Specifying SSL certificates for peer verification does an exact match,
making it a not-so-obvious alias for the fingerprints option. This
changes the checks to OpenSSL which loads concatenated certificate(s)
from a single file and does a certificate-authority (chain of trust)
check instead. There is no drop in security - a compromised exact match
fingerprint has the same worse case failure. There is increased security
in allowing separate long-term CA key and short-term SSL server keys.

This also removes loading of the system-default CA files if a custom
CA file or certificate fingerprint is specified.
 2019-04-06 23:47:06 -04:00
Riccardo Spagni
c7e536db23
Merge pull request #5350 
050bb337 wallet2: factor the watchonly/multisig/etc fields on creation (moneromooo-monero)
 2019-04-06 16:00:40 +02:00
Riccardo Spagni
cd8fe937ad
Merge pull request #5347 
d45b85e1 wallet2: skip derivation precalc for blocks we know we'll skip (moneromooo-monero)
 2019-04-06 15:59:56 +02:00
Riccardo Spagni
4ac78e1612
Merge pull request #5346 
c84ea299 cryptonote_basic: some more minor speedups (moneromooo-monero)
e40eb2ad cryptonote_basic: speedup calculate_block_hash (moneromooo-monero)
547a9708 cryptonote: block parsing + hash calculation speedup (moneromooo-monero)
11604b6d blockchain: avoid unneeded block copy (moneromooo-monero)
8461df04 save some database calls when getting top block hash and height (moneromooo-monero)
3bbc3661 Avoid repeated (de)serialization when syncing (moneromooo-monero)
 2019-04-06 15:59:43 +02:00
Riccardo Spagni
9e72f785d6
Merge pull request #5343 
cafa15b9 wallet2: set confirmations to 0 for pool txes in proofs (moneromooo-monero)
 2019-04-06 15:58:25 +02:00
moneromooo-monero
a2561653cb
wallet: new option to start background mining 
The setup-background-mining option can be used to select
background mining when a wallet loads. The user will be asked
the first time the wallet is created.
 2019-04-04 18:10:45 +00:00
moneromooo-monero
b40392fb02
wallet2: add --no-dns flag 2019-04-04 14:32:40 +00:00
stoffu
a2195b9b7f
crypto: replace rand<T>()%N idiom with unbiased rand_idx(N) 2019-04-04 22:38:19 +09:00
moneromooo-monero
15f27c80b9
wallet2: support multi out txes without change in sanity check 2019-04-03 20:58:21 +00:00
moneromooo-monero
0be5b2ee78
simplewallet: new unset_ring command 
Useful when debugging, though not much for users
 2019-04-02 14:18:07 +00:00
moneromooo-monero
c12b43cb5a
wallet: add number of blocks required for the balance to fully unlock 2019-04-01 19:31:19 +00:00
moneromooo-monero
3f1e9e84c0
wallet2: set confirmations to 0 for pool txes in proofs 
It makes more sense than (uint64_t)-1, which is going to look
like very much confirmed when not checking in_pool
 2019-04-01 19:31:10 +00:00
Riccardo Spagni
b6726aaa6c
Merge pull request #5319 
f825055d wallet_rpc_server: error out on getting the spend key from a hot wallet (moneromooo-monero)
67aa4adc wallet_rpc_server: add a set_daemon RPC (moneromooo-monero)
705acbac wallet2: init some variables to default values if loading old wallets (moneromooo-monero)
f82bc29e wallet_rpc_server: always fill out subaddr_indices in get_transfers (moneromooo-monero)
01efdc6a wallet_rpc_server: set confirmations to 0 for pending/pool txes (moneromooo-monero)
 2019-04-01 20:56:52 +02:00
moneromooo-monero
67aa4adcfc
wallet_rpc_server: add a set_daemon RPC 2019-04-01 16:03:25 +00:00
moneromooo-monero
705acbac4d
wallet2: init some variables to default values if loading old wallets 2019-04-01 16:03:23 +00:00
Riccardo Spagni
286dec012d
Merge pull request #5333 
18faa6da wallet: add freeze/thaw/frozen commands (moneromooo-monero)
 2019-04-01 17:36:16 +02:00
Riccardo Spagni
b8ab510f23
Merge pull request #5332 
7c440915 Add get_tx_proof support, needed for new sanity check (cslashm)
98fdcb2a Add support for V11 protocol with BulletProofV2 and short amount. New scheme key destination contrfol Fix dummy decryption in debug mode (cslashm)
3a981a33 Add application version compatibility check. (cslashm)
 2019-04-01 17:35:12 +02:00
Riccardo Spagni
3b52940471
Merge pull request #5349 
f1a3796a wallet2: fix tx sanity check change test for the sweep_all case (moneromooo-monero)
 2019-04-01 17:34:43 +02:00
Riccardo Spagni
8b57e33789
Merge pull request #5305 
4500236f wallet2: make use_fork_rules handle chain heights lower than leeway (moneromooo-monero)
 2019-04-01 17:26:23 +02:00
Riccardo Spagni
30a3a73609
Merge pull request #5303 
0a6cb30d wallet: flush output cache upon reorg (moneromooo-monero)
 2019-04-01 17:26:10 +02:00
Riccardo Spagni
4a06b3ee62
Merge pull request #5298 
8fd7452b wallet: move light wallet RPC out of core RPC (moneromooo-monero)
 2019-04-01 17:24:13 +02:00
Riccardo Spagni
f13d38350a
Merge pull request #5297 
a8b98a0b wallet: fix memory only wallets (moneromooo-monero)
 2019-04-01 17:23:37 +02:00
Riccardo Spagni
6cb0a26d9d
Merge pull request #5292 
328d291f wallet2: set seed language when creating from json (moneromooo-monero)
 2019-04-01 17:22:22 +02:00
Riccardo Spagni
a6b798e72f
Merge pull request #5291 
a52366c1 wallet2: fix generation from json when restore height is not set (moneromooo-monero)
 2019-04-01 17:21:14 +02:00
cslashm
7c44091541 Add get_tx_proof support, needed for new sanity check 
Enhance debug info
 2019-03-28 18:26:15 +01:00
moneromooo-monero
050bb337d7
wallet2: factor the watchonly/multisig/etc fields on creation 
There's half a dozen calls, and it's easy to miss some when
adding a new field.
 2019-03-27 08:51:16 +00:00
moneromooo-monero
f1a3796a43
wallet2: fix tx sanity check change test for the sweep_all case 2019-03-25 22:41:22 +00:00
moneromooo-monero
d45b85e170
wallet2: skip derivation precalc for blocks we know we'll skip 2019-03-25 14:28:05 +00:00