Commit Graph

7001 Commits

Author SHA1 Message Date
Alexander Blair
dbaf95ac77
Merge pull request #7271
4e74385a1 fix accessing an network address in a deleted context (moneromooo-monero)
2021-01-03 18:24:50 -08:00
Alexander Blair
71f7d4e71e
Merge pull request #7268
1e27f7101 blockchain: lock access to m_blocks_hash_of_hashes (moneromooo-monero)
2021-01-03 18:24:22 -08:00
moneromooo-monero
b652d598d1
add a max levin packet size by command type 2021-01-03 14:07:45 +00:00
moneromooo-monero
4e74385a1a
fix accessing an network address in a deleted context
Both drop_connection and add_host_fail can drop the connection,
which invalidates the context, and thus the address it contains.

Thanks to wfaressuissia[m] for lots of help and prodding when
debugging this
2021-01-03 13:04:55 +00:00
rbrunner7
e7f5845ce8 Only INFO log for short seed words with ALLOW_SHORT_WORDS active 2021-01-03 11:04:53 +01:00
moneromooo-monero
1e27f7101e
blockchain: lock access to m_blocks_hash_of_hashes
it is accessed both when adding and when prevalidating a set
of new hashes from a peer
2021-01-02 22:19:54 +00:00
moneromooo-monero
38a6e6eb26
protocol: handle receiving a block hash we've not added yet 2021-01-02 22:10:31 +00:00
Ben Evanoff
bdabcd01b7
wallet_api: store fee for incoming txs in history 2021-01-02 13:56:57 -06:00
Alexander Blair
16c780d568
Merge pull request #7250
61b6e4cc6 Add aggressive restrictions to pre-handshake p2p buffer limit (Lee Clagett)
2021-01-01 22:35:59 -08:00
Alexander Blair
3bf0721ae6
Merge pull request #7246
0aa541b36 protocol: more sanity checks in new chain block hashes (moneromooo-monero)
2021-01-01 22:33:27 -08:00
Alexander Blair
2d60232355
Merge pull request #7237
656b2f7ce p2p: fix deadlock banning while updating peer lists (moneromooo)
2021-01-01 22:32:34 -08:00
moneromooo-monero
c5c278c339
p2p: only log to global when a blocked IP is not already blocked 2021-01-01 19:54:51 +00:00
moneromooo-monero
f208d98492
p2p: ignore empty IP from DNS block list
ie, if the list ends in ;
2021-01-01 12:30:45 +00:00
Denis Goddard
46cc4a253b Header row for peer list in sync_info 2020-12-31 20:09:35 -05:00
moneromooo-monero
0aa541b361
protocol: more sanity checks in new chain block hashes 2020-12-31 23:33:18 +00:00
Steff Richards
021a28137d simplewallet: Add input file parameter to sign_transfer 2020-12-31 16:54:01 +01:00
moneromooo
656b2f7ce1
p2p: fix deadlock banning while updating peer lists 2020-12-31 03:09:37 +00:00
moneromooo-monero
ab5e185140
protocol: fix wrong command in logs
this is not a levin packet, this is just its payload
2020-12-30 21:08:28 +00:00
moneromooo-monero
31c69923ba
protocol: don't reset last request time on an idle timer
this prevents losing time of "idle time" for a peer, which could
otherwise be reset by another timed sync command from the peer
2020-12-30 14:22:10 +00:00
moneromooo-monero
1eb14af1a3
rpc: limit the number of txes for get_blocks.bin 2020-12-29 04:31:58 +00:00
Alexander Blair
2bccbeecb3
Merge pull request #7205
bcdc6c62b protocol: fix false positives dropping peers (moneromooo-monero)
2020-12-28 11:39:01 -08:00
Alexander Blair
faaec08fa4
Merge pull request #7196
4310780c0 cryptonote_basic: guess what got lost porting patches to branches again (moneromooo-monero)
2020-12-28 11:38:07 -08:00
moneromooo-monero
bcdc6c62b7
protocol: fix false positives dropping peers
it'd trigger on reorgs
2020-12-27 14:41:19 +00:00
luigi1111
025db3d2b4
Revert "Reject existing claimed blocks in sync mode" 2020-12-27 00:18:05 -05:00
moneromooo-monero
4310780c08
cryptonote_basic: guess what got lost porting patches to branches again 2020-12-26 23:43:59 +00:00
Alexander Blair
d61fdebaac
Merge pull request #7188
efe83982d protocol: drop nodes if they claim new data but only give stale data (moneromooo-monero)
2020-12-26 13:43:13 -08:00
Alexander Blair
5402121323
Merge pull request #7180
56748e1d7 ban lists may now include subnets (moneromooo-monero)
2020-12-26 13:42:37 -08:00
Alexander Blair
d06bae56b3
Merge pull request #7173
d2fda6c25 restrict public node checks a little (moneromooo-monero)
2020-12-26 13:41:42 -08:00
Alexander Blair
609dbe6b92
Merge pull request #7154
cf7e1571d protocol: reject claimed block hashes that already are in the chain (moneromooo-monero)
af0a25544 protocol: drop peers we can't download anything from in sync mode (moneromooo-monero)
2020-12-26 13:40:36 -08:00
Alexander Blair
cb712bf4f8
Merge pull request #7145
68637bca3 p2p: remove peers from grey and anchors lists when blocked (moneromooo-monero)
2020-12-26 13:40:19 -08:00
Alexander Blair
69ed0e0001
Merge pull request #7138
e9abfea16 Optional DNS based blocklist (moneromooo-monero)
2020-12-26 13:38:50 -08:00
Alexander Blair
b9e444da5e
Merge pull request #7098
c0c75ac19 Fixed issues found by static analysis (SChernykh)
2020-12-26 13:36:01 -08:00
Alexander Blair
133056f625
Merge pull request #7086
14bc5c095 db_lmdb: move spammy "not found in db" message to TRACE (moneromooo-monero)
2020-12-26 13:35:42 -08:00
Alexander Blair
d365f2409a
Merge pull request #6931
fbb03ef2a simplewallet: add "address mnew" command (codesoap)
2020-12-26 13:35:24 -08:00
codesoap
fbb03ef2a0 simplewallet: add "address mnew" command 2020-12-26 19:33:11 +01:00
moneromooo-monero
efe83982d3
protocol: drop nodes if they claim new data but only give stale data
Some joker is spending time actually doing this
2020-12-25 20:30:39 +00:00
benevanoff
50ff1066f5 wallet api: allow wallet to fetch all key images via api 2020-12-25 00:40:50 -06:00
moneromooo-monero
d2fda6c25f
restrict public node checks a little
do not include blocked hosts in peer lists or public node lists by default,
warn about no https on clearnet and about untrusted peers likely being spies
2020-12-22 23:39:07 +00:00
Lee Clagett
927141bcc4 Command max_bytes moved from dynamic map to static switch 2020-12-22 20:54:16 +00:00
moneromooo-monero
56748e1d74
ban lists may now include subnets 2020-12-22 02:12:41 +00:00
moneromooo-monero
e9abfea165
Optional DNS based blocklist
If enabled, pulls IPs to block on blocklist.moneropulse.*, and
blocks then for 8 days (so IPs dropping from the list will
eventually get unblocked, and DNS failures don't result in
instant clearing of the blocklist).

Enable with --enable-dns-blocklist
2020-12-20 02:09:58 +00:00
luigi1111
0dac64afb3
Merge pull request #7143
58651d1 p2p: ignore incoming peer list entries when we have them blocked (moneromooo-monero)
2020-12-19 17:24:21 -06:00
luigi1111
e0d8af253e
Merge pull request #7141
9de3787 daemon: the ban command can now load IPs from a file (ban @filename) (moneromooo-monero)
2020-12-19 17:22:01 -06:00
luigi1111
7ee37e4b38
Merge pull request #7075
f3c0d4f protocol: remove unused (and cunningly uninitialized) field (moneromooo-monero)
8e62362 p2p: ifx getting seed nodes for uncommon cases (moneromooo-monero)
2020-12-19 17:20:29 -06:00
moneromooo-monero
5a1ac9c0ef
rpc: add a busy_syncing field to get_info
true if and pretty much only if new blocks are being added
2020-12-17 18:03:11 +00:00
moneromooo-monero
cf7e1571d3
protocol: reject claimed block hashes that already are in the chain 2020-12-17 02:54:02 +00:00
Lee Clagett
61b6e4cc67 Add aggressive restrictions to pre-handshake p2p buffer limit 2020-12-17 00:36:10 +00:00
moneromooo-monero
af0a25544e
protocol: drop peers we can't download anything from in sync mode
instead of the (incorrect) check for whether we think we might have
a user for it at some point in the near future. We can reconnect.
2020-12-16 20:19:52 +00:00
moneromooo-monero
f3c0d4f9df
protocol: remove unused (and cunningly uninitialized) field 2020-12-15 01:32:18 +00:00
moneromooo-monero
8e62362cd3
p2p: ifx getting seed nodes for uncommon cases
The code is technically correct, but liable to easily become incorrect with changes
2020-12-15 01:32:15 +00:00
moneromooo-monero
9de3787c47
daemon: the ban command can now load IPs from a file (ban @filename) 2020-12-14 12:26:23 +00:00
moneromooo-monero
68637bca3f
p2p: remove peers from grey and anchors lists when blocked 2020-12-13 23:27:44 +00:00
moneromooo-monero
58651d16c0
p2p: ignore incoming peer list entries when we have them blocked 2020-12-13 23:14:05 +00:00
luigi1111
e5decd0cde
Merge pull request #7130
543733d protocol: include first new block in chain entry response (moneromooo-monero)
2020-12-12 22:05:02 -06:00
luigi1111
a57c95b2f1
Merge pull request #7127
5d1849a protocol: stricter checks on received chain hash list (moneromooo)
2020-12-12 22:03:12 -06:00
moneromooo-monero
543733d42c
protocol: include first new block in chain entry response 2020-12-12 01:36:35 +00:00
moneromooo
5d1849a9eb
protocol: stricter checks on received chain hash list 2020-12-11 18:47:40 +00:00
moneromooo-monero
62e8ca5eaf
protocol: revert incoming chain height check against local chain
We can actually request a chain that's further away from what we
have as we buffer more and more
2020-12-11 02:37:15 +00:00
Alexander Blair
0f67569279
Merge pull request #7121
cd7e9769d protocol: one more sanity check on usable data from a peer (moneromooo-monero)
2020-12-10 17:44:54 -08:00
Alexander Blair
bdaadf85dc
Merge pull request #7117
5dee031b2 protocol: add a sanity check to the number of block hashes sent (moneromooo-monero)
2020-12-10 17:43:41 -08:00
Alexander Blair
bb6d2d4b05
Merge pull request #7114
eb77790df protocol: fix asking for pruned blocks for v10 (moneromooo-monero)
2020-12-10 17:42:48 -08:00
Alexander Blair
28e5e42986
Merge pull request #7110
d660f22ed protocol: drop origin IP if a block fails to verify in sync mode (moneromooo-monero)
2020-12-10 17:41:59 -08:00
Alexander Blair
5b62a6f316
Merge pull request #7106
0f34cabb9 protocol: more restrictive checks on chain entry response (moneromooo-monero)
2020-12-10 17:40:46 -08:00
Alexander Blair
1e9483a2d5
Merge pull request #7009
7414e2bac Change epee binary output from std::stringstream to byte_stream (Lee Clagett)
2020-12-10 17:34:50 -08:00
moneromooo-monero
cd7e9769d8
protocol: one more sanity check on usable data from a peer 2020-12-10 23:02:06 +00:00
moneromooo-monero
d660f22ed1
protocol: drop origin IP if a block fails to verify in sync mode
It would otherwise be possible for a peer to send bad blocks,
then disconnect and reconnect again, escaping bans
2020-12-10 21:59:18 +00:00
moneromooo-monero
dd5e689533
protocol: add calls to reserve where appropriate 2020-12-10 20:47:35 +00:00
moneromooo-monero
5dee031b25
protocol: add a sanity check to the number of block hashes sent 2020-12-10 19:26:12 +00:00
moneromooo-monero
eb77790dfb
protocol: fix asking for pruned blocks for v10
Old format is still alloewd there, this is a two fork update
2020-12-10 18:10:45 +00:00
moneromooo-monero
7f30c49731
simplewallet: don't complain about connecting to the daemon when offline 2020-12-10 17:57:13 +00:00
moneromooo-monero
0f34cabb98
protocol: more restrictive checks on chain entry response 2020-12-10 17:23:50 +00:00
moneromooo-monero
47590fc80b
rpc: report target height as 0 when synced
since it only makes sense when syncing, and it confuses people
2020-12-10 17:05:34 +00:00
moneromooo-monero
19f77578e0
protocol: fix switchting to adding blocks if noone's adding the next span 2020-12-10 15:46:48 +00:00
SChernykh
c0c75ac19d Fixed issues found by static analysis
- rolling_median: tried to free uninitialized pointer in a constructor
- net_node.inl: erase-remove idiom was used incorrectly. remove_if doesn't actually remove elements, see http://cpp.sh/6fcjv
- bulletproofs.cc: call to sizeof() instead of vector.size(), luckily it only impacts performance and not code logic there
2020-12-08 18:43:44 +01:00
luigi1111
b7425c14c8
Merge pull request #7072
bc7cd78 p2p: drop peers that spam peer lists (moneromooo-monero)
2020-12-07 10:24:30 -06:00
luigi1111
fb73f2b2be
Merge pull request #7070
281b42a p2p: fix race condition accessing a deleted context (moneromooo-monero)
2020-12-07 10:23:24 -06:00
luigi1111
3d2a50a5c0
Merge pull request #7055
ff7fdf6 protocol: drop peers that don't reply to queries (moneromooo-monero)
89e984d keep only the last seen node on a given host in the white list (moneromooo-monero)
c74d8ff protocol: drop peers that decrease claimed height (moneromooo-monero)
61f5001 protocol: add scoring system to drop peers that don't behave (moneromooo-monero)
2020-12-07 10:07:33 -06:00
moneromooo
ff7fdf6db2
protocol: drop peers that don't reply to queries 2020-12-06 15:57:40 +00:00
moneromooo-monero
281b42a281
p2p: fix race condition accessing a deleted context 2020-12-06 12:40:07 +00:00
moneromooo-monero
14bc5c095c
db_lmdb: move spammy "not found in db" message to TRACE
These are functions that check whether a tx is in the db, so whether
it is there or not is really not interesting, and it seems to scare
people from time to time
2020-12-06 01:46:21 +00:00
moneromooo-monero
bc7cd78870
p2p: drop peers that spam peer lists
There's always some people who just want to abuse things
2020-12-05 13:12:58 +00:00
Alexander Blair
7ca4ef0d74
Merge pull request #7068
2395e0e67 p2p: add a tor seed node (moneromooo-monero)
2020-12-04 13:28:02 -08:00
Alexander Blair
42aa1a6aca
Merge pull request #7062
5ed604fe5 crypto: fix non zero scalar being 0 after reducing (moneromooo-monero)
2020-12-04 13:27:05 -08:00
Alexander Blair
6b8db83149
Merge pull request #7043
17c537039 wallet2: check imported multisig curve points are in main subgroup (Crypto City)
2020-12-04 13:25:01 -08:00
Alexander Blair
ce564e7ebf
Merge pull request #7030
0363476ee rpc: get_info - add 'synchronized' field (xiphon)
2020-12-04 13:21:36 -08:00
Alexander Blair
1eae7574b5
Merge pull request #7017
13350f79d Do not use peer_id tracking method over i2p/tor (Lee Clagett)
2020-12-04 13:21:13 -08:00
moneromooo
89e984d93b
keep only the last seen node on a given host in the white list 2020-12-04 01:55:22 +00:00
moneromooo
c74d8ffd63
protocol: drop peers that decrease claimed height 2020-12-04 01:55:22 +00:00
moneromooo
61f5001c3f
protocol: add scoring system to drop peers that don't behave 2020-12-04 01:55:21 +00:00
moneromooo-monero
5ed604fe5b
crypto: fix non zero scalar being 0 after reducing 2020-12-04 01:00:03 +00:00
moneromooo-monero
2395e0e678
p2p: add a tor seed node 2020-12-03 23:45:38 +00:00
Alexander Blair
f83203ecef
Merge pull request #7058
89bbb802c wallet2: set propagation timeout to current max timeout (selsta)
2020-12-03 12:19:39 -08:00
Alexander Blair
e78669257e
Merge pull request #7056
c64b94bd1 p2p: fix endianness when checking IPv6 addresses mapping to IPv4 (moneromooo-monero)
67f2bec2d p2p: make this work with boost <= 1.65 (pffff) (moneromooo-monero)
ffdf1fb1d p2p: rewrite boost's make_address_v4 to cater for < 1.66 (moneromooo)
2020-12-03 12:19:15 -08:00
Alexander Blair
84bae315f8
Merge pull request #6984
7a5e11645 net_node: add tor / i2p seed nodes (selsta)
2020-12-03 12:17:44 -08:00
selsta
89bbb802c0
wallet2: set propagation timeout to current max timeout 2020-12-03 02:18:58 +01:00
moneromooo-monero
c64b94bd14
p2p: fix endianness when checking IPv6 addresses mapping to IPv4 2020-12-03 00:31:32 +00:00
moneromooo-monero
67f2bec2df
p2p: make this work with boost <= 1.65 (pffff) 2020-12-03 00:31:32 +00:00
moneromooo
ffdf1fb1de
p2p: rewrite boost's make_address_v4 to cater for < 1.66 2020-12-03 00:31:29 +00:00
Alexander Blair
4f401f6fca
Merge pull request #7025
b10878f10 Change Dandelion++ fluff probability to 20%, and embargo timeout to 39s (Lee Clagett)
2020-12-01 14:23:49 -08:00
Alexander Blair
976fcb5985
Merge pull request #7024
aaf837cf5 rpc: skip non-synced bootstrap daemons in --no-sync mode too (xiphon)
2020-12-01 14:23:21 -08:00