Michał Sałaban
0d149f708f
Add out-of-bound exceptions and handle them in RPC
2017-11-15 16:35:14 +01:00
moneromooo-monero
93c3398503
simplewallet: translate ring size 0 to mixin 0 (default values)
...
Avoids turning it to a huge number
2017-11-15 15:07:10 +00:00
stoffu
c4587e83f8
simplewallet: wrong ns for input_line in sweep_single ( fix #2634 )
2017-11-15 20:45:58 +09:00
flozilla
f9fad18608
blockchain_db: sanity check on tx/hash vector sizes
...
It could trip on a corrupt/crafted file if the user has disabled
input verification.
2017-11-15 10:02:23 +00:00
Riccardo Spagni
cd070874bf
Merge pull request #2778
...
c957795b
fix output_stream_header memory leak (MaxXor)
2017-11-15 11:40:38 +02:00
Riccardo Spagni
3abd6f1fd0
Merge pull request #2773
...
ffe5b857
Correct totals computation (Michał Sałaban)
2017-11-15 11:24:08 +02:00
Riccardo Spagni
c9a410e394
Merge pull request #2772
...
5d92c7cc
wallet2: typo fix in error message (moneromooo-monero)
2017-11-15 11:23:22 +02:00
Riccardo Spagni
5c2dfe157b
Merge pull request #2771
...
e3e838d0
kaccak: remove unused return value (moneromooo-monero)
4877aca2
keccak: some paranoid "can't happen" checks (moneromooo-monero)
2017-11-15 11:22:56 +02:00
Riccardo Spagni
0d4d628805
Merge pull request #2634
...
b738f4b5
wallet: add sweep_single command (stoffu)
2017-11-15 11:17:01 +02:00
Riccardo Spagni
39bc39b86e
Merge pull request #2628
...
7cb303a4
wallet2: simplify incoming tx processing code (moneromooo-monero)
2017-11-15 11:14:58 +02:00
stoffu
b738f4b59d
wallet: add sweep_single command
2017-11-15 17:51:54 +09:00
stoffu
a17b8233da
wallet2 bugfix: loading old m_unconfirmed_payments
2017-11-15 17:30:49 +09:00
Howard Chu
987eb662bf
More missed readline dependencies thru scoped_message_writer
2017-11-14 22:43:52 +00:00
Howard Chu
29cee4ec4f
Fix 383ff4f689
...
Missed a crypto::null_pkey in PR#2629
2017-11-14 20:36:21 +00:00
Howard Chu
b85e82bf6a
Fix e89994e98f
...
Missed an input_line() change
2017-11-14 20:34:32 +00:00
Howard Chu
95e784ad00
Fix 437421ce42
...
Missing an error argument for an exception
2017-11-14 20:29:05 +00:00
Riccardo Spagni
86a35eeed2
Merge pull request #2789
...
b0416f07
checkpoints: add a testnet checkpoint at 1000000 (moneromooo-monero)
2017-11-14 22:17:07 +02:00
Riccardo Spagni
0c4df51bbb
Merge pull request #2765
...
fc85d7a9
simplewallet: fix in show_transfer passing wrong arg to wallet2::get_payments etc (stoffu)
2017-11-14 22:16:37 +02:00
anonimal
a3ea62f209
CMake: include RPC when building GUI deps
2017-11-14 19:45:58 +00:00
Riccardo Spagni
10a237783a
Merge pull request #2692
...
0f2c2d4c
rpc: remove obsolete busy core checks (moneromooo-monero)
2017-11-14 21:32:33 +02:00
Riccardo Spagni
815e158bdf
Merge pull request #2739
...
99f398a2
wallet2: avoid growing the short history when refreshing in a loop (moneromooo-monero)
2017-11-14 21:32:13 +02:00
Riccardo Spagni
edebe4e3b6
Merge pull request #2736
...
0d9c0db9
Do not build against epee_readline if it was not built (Howard Chu)
178014c9
split off readline code into epee_readline (moneromooo-monero)
a9e14a19
link against readline only for monerod and wallet-wallet-{rpc,cli} (moneromooo-monero)
437421ce
wallet: move some scoped_message_writer calls from the libs (moneromooo-monero)
e89994e9
wallet: rejig to avoid prompting in wallet2 (moneromooo-monero)
ec5135e5
move input_line from command_line to simplewallet (moneromooo-monero)
082db75f
move cryptonote command line options to cryptonote_core (moneromooo-monero)
2017-11-14 21:31:51 +02:00
Riccardo Spagni
922aaf4e2a
Merge pull request #2644
...
a17efcb0
make this build on SunOS/Solaris (Pavel Maryanov)
2017-11-14 21:31:09 +02:00
Riccardo Spagni
41a8bf4f4c
Merge pull request #2636
...
ad03f778
simplewallet: factor transfer related exception handling (moneromooo-monero)
2017-11-14 21:30:25 +02:00
Riccardo Spagni
5de492be40
Merge pull request #2629
...
383ff4f6
remove "using namespace std" from headers (moneromooo-monero)
2017-11-14 21:29:49 +02:00
moneromooo-monero
0f2c2d4c34
rpc: remove obsolete busy core checks
2017-11-14 17:15:19 +00:00
moneromooo-monero
99f398a25e
wallet2: avoid growing the short history when refreshing in a loop
2017-11-14 17:09:11 +00:00
Howard Chu
0d9c0db996
Do not build against epee_readline if it was not built
2017-11-14 17:06:37 +00:00
moneromooo-monero
178014c995
split off readline code into epee_readline
2017-11-14 17:06:35 +00:00
moneromooo-monero
a9e14a19dc
link against readline only for monerod and wallet-wallet-{rpc,cli}
2017-11-14 17:06:32 +00:00
moneromooo-monero
437421ce42
wallet: move some scoped_message_writer calls from the libs
2017-11-14 17:06:29 +00:00
moneromooo-monero
e89994e98f
wallet: rejig to avoid prompting in wallet2
...
wallet2 is a library, and should not prompt for stdin. Instead,
pass a function so simplewallet can prompt on stdin, and a GUI
might display a window, etc.
2017-11-14 17:06:26 +00:00
moneromooo-monero
ec5135e5b7
move input_line from command_line to simplewallet
...
It was only used there, and this removes one part of the common
dependency on libreadline
2017-11-14 17:06:23 +00:00
moneromooo-monero
082db75f28
move cryptonote command line options to cryptonote_core
...
Those have no reason to be in a generic module
2017-11-14 17:06:19 +00:00
Pavel Maryanov
a17efcb039
make this build on SunOS/Solaris
2017-11-14 17:03:48 +00:00
moneromooo-monero
ad03f77856
simplewallet: factor transfer related exception handling
...
This ensures they don't go out of sync when adding/changing them,
and makes the code easier to deal with.
2017-11-14 17:00:39 +00:00
moneromooo-monero
383ff4f689
remove "using namespace std" from headers
...
It's nasty, and actually breaks on Solaris, where if.h fails to
build due to:
struct map *if_memmap;
2017-11-14 16:56:10 +00:00
stoffu
fc85d7a998
simplewallet: fix in show_transfer passing wrong arg to wallet2::get_payments etc
2017-11-15 00:25:17 +09:00
Riccardo Spagni
f48aeab5c4
Merge pull request #2756
...
0bf09154
Fix file permission issue (Tim L)
2017-11-14 16:02:28 +02:00
Riccardo Spagni
910218b14e
Merge pull request #2755
...
d70515fc
Used declared default refresh status as default rather than it's current value (Maxime THIEBAUT)
2017-11-14 15:57:25 +02:00
Riccardo Spagni
a2241e8151
Merge pull request #2753
...
fa514082
RPC: get_info add rpc_connections_count (Tim L)
2017-11-14 15:54:33 +02:00
Riccardo Spagni
68d5952f6a
Merge pull request #2752
...
68c01782
updates: add a special case for "install-" build tags on windows (moneromooo-monero)
2017-11-14 15:49:53 +02:00
Riccardo Spagni
95c34e17cd
Merge pull request #2750
...
424852a6
Fix 'sweep_all' command when called with no args (Leon Klingele)
2017-11-14 15:49:15 +02:00
Riccardo Spagni
a2b427b1bf
Merge pull request #2749
...
f732e723
Disguise password length in prompt (Leon Klingele)
2017-11-14 15:35:47 +02:00
Riccardo Spagni
1e874186b3
Merge pull request #2747
...
37e1fd94
simplewallet: mark the active account in print_accounts (moneromooo-monero)
2017-11-14 15:32:29 +02:00
Riccardo Spagni
55603627c9
Merge pull request #2745
...
6cf33446
Remove wallet dependency on p2p (moneromooo-monero)
2017-11-14 15:31:40 +02:00
Riccardo Spagni
0d0ce8c21e
Merge pull request #2742
...
7c7d3672
Increase LMDB maxreaders if large number of threads in use (Howard Chu)
6738753b
Use max_concurrency as-is (Howard Chu)
2017-11-14 15:30:03 +02:00
Riccardo Spagni
e0e6e375bb
Merge pull request #2738
...
4a17f0c2
rpc: add performance timers (moneromooo-monero)
2017-11-14 15:28:47 +02:00
Riccardo Spagni
e759c78a17
Merge pull request #2735
...
a524b750
rpc: added miner_tx_hash to resp of getblock (stoffu)
2017-11-14 15:27:51 +02:00
Riccardo Spagni
29d77e5686
Merge pull request #2727
...
9d6c6c5d
wallet2: do not bother downloading block hashes below last checkpoint (moneromooo-monero)
2017-11-14 15:21:58 +02:00
moneromooo-monero
7cb303a44b
wallet2: simplify incoming tx processing code
2017-11-14 13:20:51 +00:00
Riccardo Spagni
25b97ee937
Merge pull request #2624
...
2677ade5
simplewallet: forbid 0 ring size (moneromooo-monero)
da8b60cb
simplewallet: reject attempts to use too low mixin early (moneromooo-monero)
2017-11-14 15:20:45 +02:00
Riccardo Spagni
cdab85db41
Merge pull request #2701
...
867b67c4
Wallet API: override update subdir when built from src (Jaquee)
2017-11-14 15:15:25 +02:00
Riccardo Spagni
2458ff1a6d
Merge pull request #2697
...
d269bff2
wallet2: use a vector, not a list, for selected_transfers (moneromooo-monero)
2017-11-14 15:14:07 +02:00
Riccardo Spagni
8df6b010eb
Merge pull request #2696
...
937e7f8a
Initialize openssl on startup (moneromooo-monero)
2017-11-14 15:13:44 +02:00
moneromooo-monero
2677ade502
simplewallet: forbid 0 ring size
...
It'd be interpreted as a huge one (~0 fake outs)
2017-11-14 13:12:42 +00:00
moneromooo-monero
da8b60cbbf
simplewallet: reject attempts to use too low mixin early
...
This yields a clear error message rather then some possibly
confusing more technical errors down the line
2017-11-14 13:12:39 +00:00
Riccardo Spagni
6172248acf
Merge pull request #2685
...
1ff638e9
protocol: drop connections which don't handshake after some time (moneromooo-monero)
2017-11-14 15:04:40 +02:00
Riccardo Spagni
f4fded6fcf
Merge pull request #2683
...
105425b7
simplewallet: reject invalid argument for boolean parameter (stoffu)
2017-11-14 15:04:15 +02:00
Riccardo Spagni
f1ca1f35d1
Merge pull request #2682
...
8ddcf1e7
simplewallet: remove XMR mentions (moneromooo-monero)
2017-11-14 15:03:15 +02:00
Riccardo Spagni
48ff10f77f
Merge pull request #2681
...
ec48e8d8
core: do not forbid txes without destination (moneromooo-monero)
523084bc
core: don't add empty additional pub keys field to extra (moneromooo-monero)
2017-11-14 15:02:55 +02:00
Riccardo Spagni
256a1d9ead
Merge pull request #2675
...
00cc1fdd
subaddress: remove unneeded scalarmultBase (kenshi84)
2017-11-14 15:02:14 +02:00
Riccardo Spagni
2ddb894607
Merge pull request #2661
...
ac4018a7
wallet2: workaround for lightwallet before supporting subaddress (followup #2656 ) (kenshi84)
2017-11-14 15:01:25 +02:00
Riccardo Spagni
474e02ccde
Merge pull request #2651
...
118a1bed
rpc: make get_coinbase_tx_sum a restricted RPC (moneromooo-monero)
2017-11-14 15:00:39 +02:00
Riccardo Spagni
395025bb23
Merge pull request #2633
...
ad96c478
wallet-cli: added --generate-from-spend-key option (stoffu)
2017-11-14 14:56:07 +02:00
Riccardo Spagni
f26e7a84a6
Merge pull request #2620
...
6bd4dac6
util: ignore SIGPIPE (moneromooo-monero)
2017-11-14 14:54:42 +02:00
Riccardo Spagni
9317c9c57e
Merge pull request #2617
...
7dbf76d0
Fix an object lifetime bug in net load tests (moneromooo-monero)
2017-11-14 14:54:05 +02:00
Riccardo Spagni
fd0740e5e7
Merge pull request #2615
...
10013e94
Protect node privacy by proper filtering in restricted-mode RPC answers (binaryFate)
2017-11-14 14:53:10 +02:00
Riccardo Spagni
3fff292dc1
Merge pull request #2509
...
ccf53a56
track double spending in the txpool (moneromooo-monero)
2017-11-14 14:50:03 +02:00
moneromooo-monero
43f27c7d43
core: warn when free disk space is low
2017-11-14 10:21:34 +00:00
binaryFate
da706b6102
Fix false GCC warning '‘*((void*)& subaddr_account +4)’ may be used unitialized'
2017-11-14 09:45:43 +01:00
stoffu
105425b7f6
simplewallet: reject invalid argument for boolean parameter
2017-11-14 16:33:17 +09:00
stoffu
a524b7508e
rpc: added miner_tx_hash to resp of getblock
2017-11-14 16:31:46 +09:00
stoffu
ad96c478b1
wallet-cli: added --generate-from-spend-key option
2017-11-14 16:30:59 +09:00
moneromooo-monero
d269bff2ab
wallet2: use a vector, not a list, for selected_transfers
...
Friendlier on memory/speed, we know in advance the max amount
of items, which are small and constant size, and there's a lot
of list walking involved.
2017-11-13 19:36:18 +00:00
moneromooo-monero
7e387fb1ad
wallet2: only add a dummy 0 output if there's one output otherwise
2017-11-13 14:08:10 +00:00
binaryFate
b42ee213e8
Wallet: update ring size in outdated error msgs with set_default_ring_size
2017-11-13 09:53:18 +01:00
Vasil Dimov
47c0948ab0
Implement missing miner functions on FreeBSD
...
cryptonote::miner::get_system_times(): Fetch the system's total and
idle time using sysctl kern.cp_time.
cryptonote::miner::get_process_time(): Use the same implementation as
Linux and OSX, the times(3) function conforms to POSIX.1 and is
available on FreeBSD.
cryptonote::miner::on_battery_power(): Try to fetch the battery status
using sysctl hw.acpi.acline. If that fails (if ACPI is not enabled on
the system), then try querying /dev/apm.
2017-11-11 16:27:19 +02:00
Vasil Dimov
fdb5bd161d
Remove unused variables and fix typos in comments
2017-11-11 16:17:19 +02:00
moneromooo-monero
e3e838d0cf
kaccak: remove unused return value
2017-11-11 11:20:48 +00:00
moneromooo-monero
b0416f070e
checkpoints: add a testnet checkpoint at 1000000
...
Makes working on testnet a lot easier (much less I/O when loading
and saving wallets, and exercises the hashchain code before any
changes are merged)
2017-11-11 11:16:48 +00:00
binaryFate
416a793326
Print msg upon success for commands that were silent
2017-11-10 09:42:40 +01:00
Riccardo Spagni
af448d3883
Merge pull request #2694
...
11e0deef
cmake: add dep of version lib on version.cpp (redfish)
35340259
.gitignore: do not ignore cmake source files (redfish)
2017-11-09 18:22:25 +02:00
moneromooo-monero
2d1ccc1b88
mnemonics: support for arbitrary (if multiple of 4 bytes) length data
2017-11-09 10:58:10 +00:00
MaxXor
c957795bfa
fix output_stream_header memory leak
2017-11-08 19:59:09 +01:00
binaryFate
10013e9434
Protect node privacy by proper filtering in restricted-mode RPC answers
...
This patch allows to filter out sensitive information for queries that rely on the pool state, when running in restricted mode.
This filtering is only applied to data sent back to RPC queries. Results of inline commands typed locally in the daemon are not affected.
In practice, when running with `--restricted-rpc`:
* get_transaction_pool will list relayed transactions with the fields "last relayed time" and "received time" set to zero.
* get_transaction_pool will not list transaction that have do_not_relay set to true, and will not list key images that are used only for such transactions
* get_transaction_pool_hashes.bin will not list such transaction
* get_transaction_pool_stats will not count such transactions in any of the aggregated values that are computed
The implementation does not make filtering the default, so developers should be mindful of this if they add new RPC functionality.
Fixes #2590 .
2017-11-08 13:07:07 +01:00
Michał Sałaban
ffe5b857e1
Correct totals computation
2017-11-08 12:09:50 +01:00
Tim L
fa51408272
RPC: get_info add rpc_connections_count
2017-11-07 16:34:49 -05:00
moneromooo-monero
5d92c7ccf6
wallet2: typo fix in error message
2017-11-07 14:04:40 +00:00
moneromooo-monero
4877aca2b6
keccak: some paranoid "can't happen" checks
2017-11-07 14:02:37 +00:00
stoffu
37c3792b00
wallet2 bugfix: supply missing subaddr_account arg to balance() and unlocked balance()
2017-11-06 10:15:38 +09:00
moneromooo-monero
ccf53a566c
track double spending in the txpool
...
Transactions in the txpool are marked when another transaction
is seen double spending one or more of its inputs.
This is then exposed wherever appropriate.
Note that being marked with this "double spend seen" flag does
NOT mean this transaction IS a double spend and will never be
mined: it just means that the network has seen at least another
transaction spending at least one of the same inputs, so care
should be taken to wait for a few confirmations before acting
upon that transaction (ie, mostly of use for merchants wanting
to accept unconfirmed transactions).
2017-11-06 00:05:44 +00:00
Riccardo Spagni
3dd31d33fa
Merge pull request #2605
...
b370ef54
Wallet: Descriptions through new commands 'set_description', 'get_description' (rbrunner7)
2017-11-06 01:56:06 +02:00
Riccardo Spagni
f960ef9454
Merge pull request #2595
...
8041b4e9
wallet-cli: allow priority argument for sweep_all and donate (stoffu)
2017-11-06 01:55:15 +02:00
Riccardo Spagni
7452359d8f
Merge pull request #2591
...
93ad1f87
Fix #2559 : more flexible print_tx daemon command (binaryFate)
2017-11-06 01:54:48 +02:00
Riccardo Spagni
32b083d8bd
Merge pull request #2546
...
b2d416f2
Distinguish "not enough money" and "not enough unlocked money" (binaryFate)
2017-11-06 01:53:43 +02:00
Riccardo Spagni
4022a0a57e
Merge pull request #2729
...
161401dd
Fix JSON-RPC response object over ZMQ (Lee Clagett)
2017-11-06 01:42:55 +02:00
stoffu
8041b4e901
wallet-cli: allow priority argument for sweep_all and donate
2017-11-04 12:11:04 +09:00
Tim L
0bf0915446
Fix file permission issue
...
This branch fixes a file permission issue introduced by 69c37200aa
2017-11-03 11:27:50 -04:00
Maxime THIEBAUT
d70515fca4
Used declared default refresh status as default rather than it's current value
2017-11-03 16:15:02 +01:00