luigi1111
fb2f822c52
Merge pull request #7153
...
354e1d9
Make the wallet name optional when locked. (Norman Moeschter)
2022-04-05 23:48:18 -04:00
j-berman
83bb02745a
Make RPC server functions that read db thread safe
...
- grab an lmdb db_rtxn_guard to ensure consistent data from the db
- fixed on_getblockhash error resp when requested height >= blockchain height
- left functions that read shared memory untouched for now
2022-04-05 20:20:12 -07:00
moneromooo-monero
5acdd0e2cb
bulletproofs+: some minor cleanup from vtnerd's review
2022-04-05 18:50:23 +00:00
moneromooo-monero
4c94cfecfc
store outPk/8 in the tx for speed
...
It avoids dividing by 8 when deserializing a tx, which is a slow
operation, and multiplies by 8 when verifying and extracing the
amount, which is much faster as well as less frequent
2022-04-05 18:50:22 +00:00
moneromooo-monero
a345060ace
ringct: port some of vtnerd's review changes from BP+ to BP
2022-04-05 18:50:21 +00:00
moneromooo-monero
75bd004f4e
ringct: a few minor optimizations from review
2022-04-05 18:50:21 +00:00
moneromooo-monero
a0d80b1f95
plug bulletproofs plus into consensus
2022-04-05 18:50:17 +00:00
Sarang Noether
b535d662b9
Updates from security audit
...
https://suyash67.github.io/homepage/assets/pdfs/bulletproofs_plus_audit_report_v1.1.pdf
2022-04-04 08:23:21 +00:00
Sarang Noether
b7713cce26
Precompute initial transcript hash
2022-04-04 08:23:21 +00:00
Sarang Noether
bd27debb2d
Bulletproofs+
2022-04-04 08:23:21 +00:00
Mathias Herberts
0f7b20a1ce
Added support for Ledger Nano S Plus
2022-03-31 18:25:09 +02:00
Jeffrey
17772ef53e
Eliminate dependence on boost::interprocess #8223
...
In this repo, `boost::interprocess` was being used soley to make `uint32_t` operations atomic. So I replaced each instance of
`boost::interprocess::ipcdetail::atomic(...)32` with `std::atomic` methods. I replaced member declarations as applicable. For example,
when I needed to change a `volatile uint32_t` into a `std::atomic<uint32_t>`. Sometimes, a member was being used a boolean flag, so
I replaced it with `std::atomic<bool>`.
You may notice that I didn't touch `levin_client_async.h`. That is because this file is entirely unused and will be deleted in PR monero-project#8211.
Additional changes from review:
* Make some local variables const
* Change postfix operators to prefix operators where value was not need
2022-03-30 13:18:32 -05:00
moneromooo-monero
ae0a840fda
wallet2: decrease the amount of data exchanged for output export
2022-03-29 08:40:32 +00:00
luigi1111
70ceab6c10
Merge pull request #8216
...
f22051d
replace erciccione's seednode with one on haveno's infrastructure (erciccione)
2022-03-18 16:34:16 -05:00
luigi1111
427bd85893
Merge pull request #8187
...
9bde2db
Fixes: Don't require --rpc-login with --rpc-access-control-origins #8168 (Jeffrey)
2022-03-18 16:32:25 -05:00
luigi1111
0ea8519895
Merge pull request #8169
...
5e201fe
rpc: add explicit restricted flag to /get_info (tobtoht)
2022-03-18 16:30:00 -05:00
luigi1111
d9e6baac42
Merge pull request #8158
...
e5000a9
Balance includes unconfirmed transfers to self (woodser)
2022-03-18 16:28:16 -05:00
reemuru
d1f1947995
wallet_rpc_server: support regex for get_accounts tag
...
This commit adds a 'regexp' boolean field to the get_accounts
request. The flag is set to false by default and maintains backwards
compatibility. When set to true the user can search tags by regular
expression filters. An additional error message was added for failed
regular expression searches. Bump minor version to 25.
2022-03-13 11:30:48 -04:00
erciccione
f22051d382
replace erciccione's seednode with one on haveno's infrastructure
2022-03-13 13:15:01 +01:00
moneromooo-monero
7dcfccbaaf
wallet_rpc_server: fix make_integrated_address with no payment id
2022-03-11 17:23:19 +00:00
Luke Parker
591c174235
Remove footgun doc comment in miner TX validation
...
This comment suggests this check is unnecessary, when it is completely necessary as miner TXs can have multiple outputs *which is a statement directly, and incorrectly, contradicted by this comment*. While I don't ever see someone removing this code and getting their edits merged into Monero, someone inexperienced who thinks they're cleaning old code may break their own work, and then there's really just zero benefit to keeping this around.
2022-03-10 14:08:30 -06:00
Norman Moeschter
354e1d9c65
Make the wallet name optional when locked.
2022-03-10 08:16:14 +00:00
mj-xmr
0d6fce8995
Compil. time: cryptonote_core minus portable_storage header
2022-03-04 12:48:35 +01:00
mj-xmr
da9aa1f7f8
Copyright: Update to 2022
2022-03-04 06:59:20 +01:00
luigi1111
27f1d43547
Merge pull request #8145
...
fb5b2b3
support authentication in monero-wallet-rpc set_daemon (woodser)
2022-03-02 18:53:34 -05:00
luigi1111
abae63c37d
Merge pull request #8052
...
c36ea26
fix ge_p3_is_point_at_infinity(), which is evaluating field elements that haven't been reduced by the field order (koe)
2022-03-02 18:52:51 -05:00
luigi1111
5eaa4434e8
Merge pull request #7877
...
e08abaa
multisig key exchange update and refactor (koe)
2022-03-02 18:51:54 -05:00
selsta
3c829586be
wallet2: update stagenet rollback blocks
2022-03-01 00:25:41 +01:00
reemuru
3f88fddbfa
simplewallet: add option for exporting tx keys
...
This commit adds an option to export transaction
keys when performing export_transfers all. By passing
option=with_keys a new column 'tx key' will be
populated with respective keys.
2022-02-24 22:22:35 -05:00
koe
e08abaa43f
multisig key exchange update and refactor
2022-02-22 16:37:42 -06:00
Jeffrey
9bde2dbfed
Fixes: Don't require --rpc-login with --rpc-access-control-origins #8168
...
This PR removes the requirement for --rpc-login to be specified if --rpc-access-control-origins is.
This will allow public nodes to serve cross-origin requests. You can still use --rpc-login with
--rpc-access-control-origins, but it is no longer mandatory.
Original Issue: #8168
2022-02-19 13:49:38 -06:00
moneromooo-monero
06e6c8bf4a
crypto: fix constant randomx exceptions in large page allocator
...
If allocating large pages fails, we don't try again.
This has the obvious drawback of not being able to use large pages
if they fail once.
2022-02-19 13:15:10 +00:00
tobtoht
5e201fedc5
rpc: add explicit restricted flag to /get_info
2022-02-07 17:59:22 +01:00
woodser
e5000a9f0c
Balance includes unconfirmed transfers to self
2022-01-31 07:52:38 -05:00
koe
c36ea26e5c
fix ge_p3_is_point_at_infinity(), which is evaluating field elements that haven't been reduced by the field order
2022-01-25 07:14:46 -06:00
luigi1111
357dbd2032
Merge pull request #8130
...
1051276
Update net_node.inl (Gingeropolous)
2022-01-24 15:16:52 -05:00
luigi1111
d94715fd71
Merge pull request #8123
...
4446cc8
wallet inits cache if file and blob missing (woodser)
2022-01-24 15:15:11 -05:00
luigi1111
5283cf51ef
Merge pull request #8044
...
a02b342
Avoid unnecessary 'Invalid hashing blob' error message (rbrunner7)
2022-01-24 15:10:55 -05:00
woodser
fb5b2b352a
support authentication in monero-wallet-rpc set_daemon
2022-01-17 17:03:56 -05:00
Gingeropolous
1051276425
Update net_node.inl
2022-01-04 16:31:59 -05:00
woodser
4446cc88c3
wallet inits cache if file and blob missing
2021-12-24 09:22:57 -05:00
luigi1111
3ed0cc6e20
Merge pull request #8067
...
53be72c
make_uri disallows standalone payment ids (woodser)
2021-11-30 17:05:48 -05:00
luigi1111
c0cf5bb339
Merge pull request #8057
...
1efe624
device_ledger: fix incorrect macro (selsta)
2021-11-30 17:03:46 -05:00
luigi1111
55fc2335a4
Merge pull request #7943
...
3a90be4
rpc: don't set error code as status string (selsta)
2021-11-30 17:00:20 -05:00
woodser
53be72c08a
make_uri
disallows standalone payment ids
2021-11-30 09:28:45 -05:00
luigi1111
105e2304a2
Merge pull request #8083
...
e8e507f
rpc: fix DoS vector in get_output_distribution (moneromooo-monero)
2021-11-26 23:05:31 -06:00
luigi1111
9a17f53489
Merge pull request #8070
...
a4ebec9
Add python method (Howard Chu)
0221b01
Add calcpow RPC (Howard Chu)
2021-11-26 23:01:08 -06:00
Howard Chu
0221b01519
Add calcpow RPC
...
Calculate PoW hash for a block candidate
2021-11-20 18:52:05 +00:00
selsta
82828bfcb6
cryptonote_core: fix unused lambda warning
2021-11-16 05:21:56 +01:00
selsta
1efe624e30
device_ledger: fix incorrect macro
...
The current code does work by accident, but it might break if
someone uses ASSERT_SW in a different place, or if variables
get renamed.
2021-11-12 02:56:20 +01:00
luigi1111
97ff1938a3
Merge pull request #8038
...
fbe8358
device: fix ledger error strings, add human friendly messages (selsta)
2021-11-09 22:53:47 -06:00
luigi1111
2844b5b8db
Merge pull request #8031
...
187633c
slow_hash: don't blow out Mac stack on ARM64 (Howard Chu)
2021-11-09 22:50:36 -06:00
luigi1111
c3b1b94453
Merge pull request #7169
...
bbe3b27
tx_pool: full tx revalidation on fork boundaries (moneromooo-monero)
2021-11-09 22:44:39 -06:00
im
cf44349a86
account info text alignment
2021-11-10 02:27:14 +08:00
rbrunner7
a02b342347
Avoid unnecessary 'Invalid hashing blob' error message
2021-11-05 14:19:21 +01:00
selsta
fbe8358c9f
device: fix ledger error strings, add human friendly messages
2021-11-03 00:10:12 +01:00
moneromooo-monero
bbe3b276b8
tx_pool: full tx revalidation on fork boundaries
...
avoids mining txes after a fork that are invalid by this fork's
rules, but were valid by the previous fork rules at the time
they were verified and added to the txpool.
2021-11-01 20:56:38 +00:00
luigi1111
e22ec26be4
Merge pull request #8029
...
548cfc8
crypto: fix typo in ifdef (selsta)
2021-11-01 12:32:24 -05:00
luigi1111
d573b3d76c
Merge pull request #8020
...
47e7a43
wallet_api: enable set_strict_default_file_permissions (tobtoht)
2021-11-01 12:31:32 -05:00
luigi1111
ff4ede9356
Merge pull request #8017
...
a15466d
wallet2: remove 2 unused variables (selsta)
2021-11-01 12:29:22 -05:00
luigi1111
f405bf3d58
Merge pull request #8013
...
2cad563
wallet2: fix key encryption when changing ask-password from 0/1 to 2 (moneromooo-monero)
2021-11-01 12:25:20 -05:00
Howard Chu
187633c0ca
slow_hash: don't blow out Mac stack on ARM64
2021-10-30 22:24:55 +01:00
selsta
548cfc8d68
crypto: fix typo in ifdef
2021-10-29 17:55:51 +02:00
luigi1111
b328fbecc2
Merge pull request #8019
...
e106bdc
epee: add missing header (selsta)
2021-10-25 19:02:49 -05:00
luigi1111
ff96482e38
Merge pull request #8018
...
1f81f5f
protocol: fix spurious rejection of downloaded blocks (moneromooo-monero)
2021-10-25 19:02:22 -05:00
luigi1111
e5710b1898
Merge pull request #8004
...
ace4669
simplewallet: fix incoming_transfers index error (selsta)
2021-10-25 18:59:54 -05:00
luigi1111
e7d571c526
Merge pull request #8003
...
75d05b9
download: fix leak (moneromooo-monero)
2021-10-25 18:59:18 -05:00
luigi1111
00ac048958
Merge pull request #7995
...
797ca97
socks: ignore any exceptions in shutdown/close (selsta)
2021-10-25 18:53:34 -05:00
moneromooo-monero
e8e507f36f
rpc: fix DoS vector in get_output_distribution
...
This will prevent people spending old pre-rct outputs using a
stranger's node, which may be a good thing
2021-10-24 17:17:12 +00:00
selsta
797ca974ab
socks: ignore any exceptions in shutdown/close
2021-10-22 22:00:29 +02:00
tobtoht
47e7a43270
wallet_api: enable set_strict_default_file_permissions
2021-10-22 05:40:23 +02:00
selsta
e106bdc1fc
epee: add missing header
2021-10-22 04:14:25 +02:00
moneromooo-monero
1f81f5f5c1
protocol: fix spurious rejection of downloaded blocks
...
when kicking a peer for inactivity, clear the set of requested blocks,
or next time we requests blocks from it, we'll probably reject the
incoming blocks due to missing the previous requested blocks
2021-10-21 20:34:06 +00:00
selsta
a15466d850
wallet2: remove 2 unused variables
2021-10-20 22:19:15 +02:00
moneromooo-monero
2cad563060
wallet2: fix key encryption when changing ask-password from 0/1 to 2
...
we reuse the wallet_keys_unlocker object, which does the right thing
in conjunction with other users of decrypt/encrypt (ie, refresh).
2021-10-19 22:01:45 +00:00
luigi1111
753dc901a1
Merge pull request #8001
...
9973edd
ARMv8: detect AES support dynamically (Howard Chu)
2021-10-17 23:39:50 -05:00
luigi1111
99507da993
Merge pull request #7994
...
84c5257
Decrease the 'recent spend window' in gamma re-select to 15 blocks (j-berman)
2021-10-17 23:38:47 -05:00
luigi1111
adb2542a6c
Merge pull request #7876
...
5e63f6c
Ledger: member 'mode' was shadowing that of base class (mj-xmr)
2021-10-17 23:29:17 -05:00
luigi1111
ebc655c6ad
Merge pull request #7869
...
ad9fde4
UB: virtual methods in destructor at Trezor (mj-xmr)
2021-10-17 23:28:04 -05:00
luigi1111
19a6cc26fc
Merge pull request #7867
...
eed7e79
UB: Not calling virtual method in destructor of WalletImpl (mj-xmr)
2021-10-17 23:26:50 -05:00
luigi1111
e165fdb27c
Merge pull request #7859
...
514f8fa
LMDB: protection against UB, by not calling virtual methods from destructor (mj-xmr)
2021-10-17 23:25:34 -05:00
luigi1111
308e601966
Merge pull request #7799
...
76542ea
Fix precision of average_output_time (j-berman)
2021-10-17 23:23:15 -05:00
luigi1111
3d9c805e23
Merge pull request #7975
...
48a0997
blockchain: fix pedantic assert (selsta)
2021-10-11 13:00:27 -05:00
luigi1111
a6367693c7
Merge pull request #7960
...
2e8936f
rpc: Fix get_transactions failing when not found (Nathan Dorfman)
2021-10-11 12:59:32 -05:00
luigi1111
872d6f86bc
Merge pull request #7958
...
5f54dea
LMDB: fix deadlock in resized detection (Howard Chu)
2021-10-11 12:57:53 -05:00
luigi1111
45920c36f1
Merge pull request #7874
...
9154883
node_server: fix race condition (anon)
8922f96
node_server: add race condition demo (anon)
2021-10-11 12:56:14 -05:00
luigi1111
7f477c1902
Merge pull request #7793
...
13a8a57
trezor: try empty passphrase first (Dusan Klinec)
2021-10-11 12:54:17 -05:00
selsta
48a0997d8c
blockchain: fix pedantic assert
2021-10-11 19:09:45 +02:00
selsta
ace4669543
simplewallet: fix incoming_transfers index error
2021-10-10 23:17:16 +02:00
moneromooo-monero
75d05b9448
download: fix leak
...
A shared_ptr as by value capture will keep the object alive
2021-10-10 19:14:17 +00:00
Howard Chu
9973edd4c3
ARMv8: detect AES support dynamically
2021-10-10 16:52:30 +01:00
mj-xmr
5e63f6c292
Ledger: member 'mode' was shadowing that of base class
2021-10-07 12:03:17 +02:00
j-berman
84c52571ed
Decrease the "recent spend window" in gamma re-select to 15 blocks
...
- combined with patching integer truncation (#7798 ), this gets the algorithm marginally closer to mirroring empirically observed output ages
- 50 was originally chosen assuming integer truncation would remain in the client for that client release version. But patching integer truncation causes the client to select more outputs in the 10-100 block range, and therefore the benefit of choosing a larger recent spend window of 50 has less merit
- 15 seems well-suited to cover the somewhat sizable observable gap in the early window of blocks
2021-10-04 20:12:42 -07:00
luigi1111
298c9a357f
Merge pull request #7891
...
dfee15e
RPC and ZeroMQ APIs to support p2pool (SChernykh)
2021-09-23 22:10:03 -05:00
luigi1111
237acd120e
Merge pull request #7890
...
2a8a511
Quicker resource cleanup on p2p socks timeout (Lee *!* Clagett)
2021-09-23 22:06:35 -05:00
Howard Chu
5f54dea4ec
LMDB: fix deadlock in resized detection
2021-09-22 15:47:04 +01:00
Nathan Dorfman
2e8936f614
rpc: Fix get_transactions failing when not found
2021-09-20 17:32:01 -06:00
anon
9154883f3e
node_server: fix race condition
2021-09-20 20:58:23 +00:00
selsta
3a90be4bd6
rpc: don't set error code as status string
2021-09-15 08:57:41 +02:00
j-berman
76542ea709
Fix precision of average_output_time
...
The fix as suggested by <jberman> on IRC. Before the fix, it would truncate 1.9 to 1 skewing the output selection.
2021-09-12 10:07:31 +02:00