rottenwheel/monero
1
0
Fork 0
mirror of https://codeberg.org/anoncontributorxmr/monero.git synced 2024-11-27 21:33:27 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
8,108 Commits 1 Branch 0 Tags 178 MiB
1f809e7485
Commit Graph

1069 Commits

Author SHA1 Message Date
Riccardo Spagni
164ba3ef1c
Merge pull request #4731 
f26ce08c wallet: add a non destructive blockchain rescan (moneromooo-monero)
 2018-11-06 21:30:12 +02:00
Riccardo Spagni
b789f7e10d
Merge pull request #4729 
e86af52e wallet2: rewrite keys file in a safer manner (Nathan Dorfman)
 2018-11-06 15:09:45 +02:00
moneromooo-monero
6e1282b600
wallet2: fix off by one in output picking 
and take into account wallet level minimum spend age
 2018-11-05 20:13:00 +00:00
moneromooo-monero
8d71b2b1b3
wallet2: only export necessary outputs and key images 
and disable annoying test that requires ridiculous amounts
of skullduggery every time some format changes
 2018-11-04 22:27:01 +00:00
moneromooo-monero
769ae42a7b
wallet2: faster output and key image import/export 2018-11-04 22:26:59 +00:00
Riccardo Spagni
7e2483e1d5
Merge pull request #4702 
70877b1d wallet2/create_transactions_2: removed obsolete '/ 1024' on min_fee calc (Paul Shapiro)
 2018-11-04 20:47:25 +02:00
Riccardo Spagni
ae919a1e15
Merge pull request #4691 
7f0dd094 wallet2: sanity check rct output distribution from the daemon (moneromooo-monero)
 2018-11-04 20:45:59 +02:00
Riccardo Spagni
0c7086bf7f
Merge pull request #4687 
6097472a Update ZMQ fee estimate and add ZMQ output distribution (Lee Clagett)
 2018-11-04 20:44:49 +02:00
Riccardo Spagni
d394c50f7b
Merge pull request #4686 
cf646e3a wallet2/create_transactions_2: removed extraneous shuffle before sort of unused_*_indices_per_subaddr (Paul Shapiro)
 2018-11-04 20:44:27 +02:00
Riccardo Spagni
9cf0e67978
Merge pull request #4685 
76681b9b wallet2/create_transactions_2: fixed typo in try_tx=true's estimate_fee args (Paul Shapiro)
 2018-11-04 20:44:00 +02:00
Hasan Pekdemir
e198b06e7a Fix: out_of_hashchain_bounds_error in refresh 
15:43 < hahsun> Im on stagenet and I suddenly get this exception: 2018-11-04 14:42:52.416 [RPC0] ERROR wallet.wallet2 src/wallet/wallet2.cpp:2070 !m_blockchain.is_in_bounds(current_index). THROW EXCEPTION: error::out_of_hashchain_bounds_error
16:01 <+moneromooo> OK, possibly because the blckchain is always seeded with the genesis block hash...
16:02 <+moneromooo> So that case should be allowed, assuming it doesn't break the code around it.
16:05 <+moneromooo> OK if stop_height == size || (size==1 && stop_heigt ==0)
16:05 <+moneromooo> Throw if not that.
16:06 < hahsun> k
 2018-11-04 17:07:30 +01:00
moneromooo-monero
f26ce08c8a
wallet: add a non destructive blockchain rescan 2018-11-03 15:04:37 +00:00
moneromooo-monero
8f3963d200
wallet2: demote a few uninteresting recurring logs to TRACE 2018-11-03 11:51:03 +00:00
moneromooo-monero
0afdb00b9d
wallet2: fix print_ring printing double entries for transactions 
When a tx gets from unconfirmed to conirmed, the rings for that
transaction were being added twice
 2018-11-03 11:50:38 +00:00
Dusan Klinec
29ffb6bba8
device/trezor: trezor support added 2018-11-02 21:36:39 +01:00
stoffu
1598f01caf
wallet2: use padded bulletproofs for multisig signing 
Analogous to #4540
 2018-10-31 20:01:25 +09:00
Nathan Dorfman
e86af52e2f wallet2: rewrite keys file in a safer manner 2018-10-28 09:58:54 -06:00
moneromooo-monero
9335d5a297
wallet2: save ring in the ringdb once a tx is created 
Even if it is never relayed, it ensures a daemon supplying
fake outs on demand will never be asked for a set with the
real input being the only intersecting member (only a problem
with people who trust their privacy to some stranger's node,
but it seems to be a massively common thing, even in Monero)
 2018-10-27 17:59:56 +00:00
moneromooo-monero
107f33985d
wallet2: fix ring reuse breaking when using histogram 2018-10-27 14:35:00 +00:00
Riccardo Spagni
fc06c5daf8
Merge pull request #4617 
3ffbec15 rpc: init m_rpc_version in Message ctor (moneromooo-monero)
bfa2dce1 rpc: remove unused ctors (moneromooo-monero)
7cc39845 account: init creation timestamp to 0 (moneromooo-monero)
32123789 wallet2: initialize some scalar fields in ctor where appropriate (moneromooo-monero)
4eca42b2 blockchain_db: initialize m_hardfork in ctor just in case (moneromooo-monero)
 2018-10-26 22:39:00 +02:00
Riccardo Spagni
c761bee764
Merge pull request #4561 
04ddf02e Return appropriate RPC error code when key image signature check fails (Michał Sałaban)
 2018-10-26 22:33:35 +02:00
Riccardo Spagni
169e6e9074
Merge pull request #4552 
67e76aa0 wallet_rpc_server: optionally return tx keys in sign_transfer (moneromooo-monero)
 2018-10-26 22:32:34 +02:00
Lee Clagett
6097472a19 Update ZMQ fee estimate and add ZMQ output distribution 2018-10-23 23:46:31 -04:00
moneromooo-monero
61f83316b3
wallet2: extend fake out picks away from the gamma pick 
in order to unbias selection from blocks with few txes
 2018-10-23 09:06:47 +00:00
Paul Shapiro
70877b1d91 wallet2/create_transactions_2: removed obsolete '/ 1024' on min_fee calc 2018-10-22 18:51:45 -05:00
moneromooo-monero
7f0dd094e7
wallet2: sanity check rct output distribution from the daemon 2018-10-22 14:01:46 +00:00
Paul Shapiro
76681b9bda wallet2/create_transactions_2: fixed typo in try_tx=true's estimate_fee args 2018-10-21 12:44:22 -05:00
Paul Shapiro
cf646e3afe wallet2/create_transactions_2: removed extraneous shuffle before sort of unused_*_indices_per_subaddr 2018-10-21 12:43:31 -05:00
Riccardo Spagni
ed4b953bb7
Merge pull request #4518 
92a0827e wallet2: make fake out selection messages less spammy (moneromooo-monero)
 2018-10-20 20:39:36 +02:00
moneromooo-monero
99cd6f961a
Rename "blackball" for clarity 
Apparently some people seem to think it's a censorship list...
 2018-10-18 18:45:45 +00:00
moneromooo-monero
3212378912
wallet2: initialize some scalar fields in ctor where appropriate 
Coverity 188336
 2018-10-16 11:58:48 +00:00
m2049r
d886b97fe2
SOFTWARE is the default wallet device 2018-10-13 09:25:49 +02:00
Michał Sałaban
04ddf02e3a Return appropriate RPC error code when key image signature check fails 2018-10-11 18:12:17 +02:00
moneromooo-monero
67e76aa06c
wallet_rpc_server: optionally return tx keys in sign_transfer 2018-10-10 15:55:35 +00:00
moneromooo-monero
92a0827eea
wallet2: make fake out selection messages less spammy 2018-10-09 21:46:33 +00:00
moneromooo-monero
8833aec083
wallet2: fix cold signing using non padded bulletproofs 
This code was deciding which bulletproof configuration to use
based on ptx which weren't created yet.
 2018-10-09 14:32:38 +00:00
Riccardo Spagni
e19652df51
Merge pull request #4036 
9acf42d3 Multisig M/N functionality core tests added (naughtyfox)
9f3963e8 Arbitrary M/N multisig schemes: * support in wallet2 * support in monero-wallet-cli * support in monero-wallet-rpc * support in wallet api * support in monero-gen-trusted-multisig * unit tests for multisig wallets creation (naughtyfox)
 2018-10-07 19:57:26 +02:00
Guillaume LE VAILLANT
977df6315f Fix some calls to the translation function 
Some strings were not detected by lupdate because "tr() cannot be called without
context".
 2018-10-06 10:26:06 +02:00
moneromooo-monero
34a85e0cc3
wallet2: disable height based segregation 
It can still be enable via DNS if a key reusing fork pops up
 2018-10-03 20:44:48 +00:00
Riccardo Spagni
932a17018a
Merge pull request #4490 
bccd88dd wallet2: clear found out for every tx key (doy-lee)
 2018-10-02 22:41:24 +02:00
doy-lee
bccd88ddf5
wallet2: clear found out for every tx key 
Avoids triggering the sanity check
 2018-10-02 08:53:28 +00:00
naughtyfox
9f3963e823 Arbitrary M/N multisig schemes: 
* support in wallet2
* support in monero-wallet-cli
* support in monero-wallet-rpc
* support in wallet api
* support in monero-gen-trusted-multisig
* unit tests for multisig wallets creation
 2018-10-01 19:16:56 +03:00
moneromooo-monero
25e5890d37
wallet: fix --generate-from-json using wrong password 2018-10-01 12:32:26 +00:00
Riccardo Spagni
83d8f03c23
Merge pull request #4333 
73403004 add --block-notify to monerod and --tx-notify to monero-wallet-{cli,rpc} (moneromooo-monero)
 2018-09-29 22:20:44 +02:00
Riccardo Spagni
4a2664f743
Merge pull request #4461 
7dd11711 wallet2: fix transfers between subaddresses hitting the sanity check (moneromooo-monero)
 2018-09-29 22:20:41 +02:00
Riccardo Spagni
e951258543
Merge pull request #4456 
06d05c21 device: set device name correctly if key_on_device is set (Dusan Klinec)
 2018-09-29 22:20:27 +02:00
Riccardo Spagni
ff0d7a7678
Merge pull request #4406 
7964d4f8 wallet2: handle corner case in picking fake outputs (moneromooo-monero)
 2018-09-29 22:09:46 +02:00
moneromooo-monero
e350cc5ad5
wallet2: fix duplicate output making it to the RPC 2018-09-25 11:28:39 +00:00
Riccardo Spagni
85110b42ab
Merge pull request #4401 
66901901 README: harmonize command formatting inside README.md (Andrea)
8cd98408 disable AES on s390x architecture (Tuan M. Hoang)
4ed30bab wallet: implement coin splitting for sweep_* 'outputs' option (whythat)
24f52396 wallet: add 'outputs' option for sweep_* commands (whythat)
52e19d69 README: Compile boost with cxxflags=-fPIC cflags=-fPIC (Italocoin Project)
0c77523d README: fill in libsodium package name for Arch (phloatingman)
 2018-09-21 20:46:22 +02:00
m2049r
bce474be7d
query backing device 2018-09-19 18:25:38 +02:00
Riccardo Spagni
08f0c60ffc
Merge pull request #4360 
7a76354c wallet2: import_multisig forward refresh exception (naughtyfox)
 2018-09-18 17:58:14 +02:00
Riccardo Spagni
b174527f1d
Merge pull request #4302 
ba8dd347 api/wallet: properly disable key encryption (stoffu)
 2018-09-18 17:31:35 +02:00
whythat
4ed30bab50
wallet: implement coin splitting for sweep_* 'outputs' option 
Implemented strategy splits total amount into N equal parts,
where N is a specified number of outputs. If N > 1, dummy
change output is NOT created.

rebased by moneromooo
 2018-09-18 11:02:03 +00:00
whythat
24f5239693
wallet: add 'outputs' option for sweep_* commands 
'outputs' option allows to specify the number of
separate outputs of smaller denomination that will
be created by sweep operation.

rebased by moneromooo
 2018-09-18 11:01:59 +00:00
stoffu
ba8dd3479d
api/wallet: properly disable key encryption 2018-09-17 22:15:29 +09:00
Dusan Klinec
f9b22a7b01
hw_device: support for multiple devices added [for review] 
- device name is a new wallet property
- full device name is now a bit more structured so we can address particular device vendor + device path. Example: 'Ledger', 'Trezor:udp', 'Trezor:udp:127.0.0.1:21324', 'Trezor:bridge:usb01'. The part before ':' identifies HW device implementation, the optional part after ':' is device path to look for.
- new --hw-device parameter added to the wallet, can name the hardware device
- device reconnect added
 2018-09-14 16:02:00 +02:00
Riccardo Spagni
d743994086
Merge pull request #4324 
44259e56 wallet: ask-password can now ask without encrypting the secret spend key (moneromooo-monero)
 2018-09-14 13:15:41 +02:00
moneromooo-monero
44259e560e
wallet: ask-password can now ask without encrypting the secret spend key 2018-09-14 11:14:21 +00:00
Riccardo Spagni
fd194aaa4d
Merge pull request #4347 
df0e7c2f wallet2: fix secondary partially signed multisig txes (moneromooo-monero)
 2018-09-14 13:06:38 +02:00
Riccardo Spagni
b182dc8262
Merge pull request #4336 
5f8f5631 wallet2.get_reserve_proof: throw when specified amount is zero (stoffu)
 2018-09-14 13:06:06 +02:00
Riccardo Spagni
dd2fc3afe3
Merge pull request #4332 
20171746 wallet2: factor the creation of a new wallet keys file (moneromooo-monero)
be6acfd5 wallet2: factor new blockchain setup (moneromooo-monero)
 2018-09-14 13:05:43 +02:00
Riccardo Spagni
1396b65bbc
Merge pull request #4331 
88fbc4a5 wallet2: fill in v2 height for stagenet (moneromooo-monero)
 2018-09-14 13:05:02 +02:00
Riccardo Spagni
239a7e10ff
Merge pull request #4253 
be001326 remove obsolete daemon selection of fake outs and old tx construction (moneromooo-monero)
 2018-09-14 12:54:25 +02:00
moneromooo-monero
be001326d1
remove obsolete daemon selection of fake outs and old tx construction 2018-09-14 10:51:45 +00:00
Riccardo Spagni
c74d9057f8
Merge pull request #4260 
a54dbaee blockchain_blackball: add --force-chain-reaction-pass flag (moneromooo-monero)
44439c32 record blackballs as amount/offset, and add export ability (moneromooo-monero)
4bce935b blockchain_blackball: more optimizations (moneromooo-monero)
b66ba783 blockchain_blackball: do not process duplicate blockchains parts (moneromooo-monero)
639a3c01 blockchain_blackball: make it clear secondary passes are not incremental (moneromooo-monero)
eb8a51be blockchain_blackball: detect spent outputs by partial ring reuse (moneromooo-monero)
d6d276c6 blockchain_blackball: fix chain reaction phase in incremental mode (moneromooo-monero)
2b2a681b blockchain_blackball: avoid false positives for different amounts (moneromooo-monero)
80e4fef3 blockchain_blackball: set transaction looping txn to read only (moneromooo-monero)
4801d6b5 blockchain_blackball: add stats (moneromooo-monero)
846190fd blockchain_blackball: support pre-v2 databases (moneromooo-monero)
daa6cc7d blockchain_blackball: use LMDB for the cache (moneromooo-monero)
50cb370d ringdb: allow blackballing many outputs at once (moneromooo-monero)
 2018-09-14 12:45:18 +02:00
Riccardo Spagni
438781afc4
Merge pull request #4221 
62511df6 wallet2: fix refresh retry when a block/tx fails to parse (moneromooo-monero)
b219c24c wallet2: trim hash chain after fast refresh of hashes (moneromooo-monero)
5b6bcca3 wallet2: fix checking the wrong vector when adding hashes (moneromooo-monero)
 2018-09-14 12:38:36 +02:00
moneromooo-monero
ac4f71c200
wallet2: bump testnet rollback to account for coming reorg 2018-09-11 13:38:35 +00:00
moneromooo-monero
a1359ad43c
Check inputs to addKeys are in range 
Reported by QuarksLab.
 2018-09-11 13:38:09 +00:00
moneromooo-monero
5ffb2ff9b7
v8: per byte fee, pad bulletproofs, fixed 11 ring size 2018-09-11 13:38:07 +00:00
moneromooo-monero
2a8fcb421b
Bulletproof aggregated verification and tests 
Also constrains bulletproofs to simple rct, for simplicity
 2018-09-11 13:37:37 +00:00
moneromooo-monero
9ce9f8caf6
bulletproofs: add multi output bulletproofs to rct 2018-09-11 13:37:28 +00:00
naughtyfox
7a76354c8b wallet2: import_multisig forward refresh exception 2018-09-10 18:45:37 +03:00
moneromooo-monero
44439c3208
record blackballs as amount/offset, and add export ability 2018-09-10 09:04:18 +00:00
moneromooo-monero
50cb370d5b
ringdb: allow blackballing many outputs at once 
It cuts down on txn commits, and speeds up blackballing substantially
 2018-09-09 12:01:43 +00:00
moneromooo-monero
df0e7c2feb
wallet2: fix secondary partially signed multisig txes 2018-09-08 23:12:06 +00:00
luigi1111
77ed11e627
Merge pull request #4270 
29dea03 epee: resize vectors where possible in serialization (moneromooo-monero)
76affd9 epee: some speedup in parsing (moneromooo-monero)
dc6c069 db_lmdb: speedup the get_output_distribution common case (moneromooo-monero)
76ac5a8 wallet2: ask for a binary output distribution, for speed (moneromooo-monero)
 2018-09-04 13:19:58 -05:00
luigi1111
5f1bbe3bce
Merge pull request #4268 
1f2409e Do memwipe for critical secret keys copied to rct::key (stoffu)
 2018-09-04 13:16:04 -05:00
luigi1111
6d4d4ddb68
Merge pull request #4252 
ac09cfa wallet2: remove obsolete pruned/unpruned case (moneromooo-monero)
 2018-09-04 13:05:12 -05:00
stoffu
5f8f56315c
wallet2.get_reserve_proof: throw when specified amount is zero 2018-09-04 13:00:38 +09:00
moneromooo-monero
20171746de
wallet2: factor the creation of a new wallet keys file 2018-09-03 11:27:46 +00:00
moneromooo-monero
be6acfd5be
wallet2: factor new blockchain setup 2018-09-03 11:27:43 +00:00
moneromooo-monero
88fbc4a567
wallet2: fill in v2 height for stagenet 2018-09-03 11:26:28 +00:00
stoffu
8ca1215f25
wallet: store trusted-daemon flag in wallet2 2018-08-23 14:55:09 +09:00
luigi1111
1db7a29e12
Merge pull request #4247 
10475ab node_rpc_proxy: fix fork earliest height caching [RYO backport] (fireice-uk)
 2018-08-22 21:04:34 -05:00
luigi1111
6e8e4fb3b7
Merge pull request #4202 
8439306 wallet2: do not divide by 0 on invalid daemon response (moneromooo-monero)
 2018-08-22 20:42:20 -05:00
moneromooo-monero
62511df622
wallet2: fix refresh retry when a block/tx fails to parse 
It would switch to a new set of blocks and fail, getting out of sync
with the hash chain in the process
 2018-08-22 09:57:46 +00:00
moneromooo-monero
b219c24c3a
wallet2: trim hash chain after fast refresh of hashes 
This ensures it can't end up filled with the actual placeholders
 2018-08-22 09:57:42 +00:00
moneromooo-monero
5b6bcca32a
wallet2: fix checking the wrong vector when adding hashes 
The two vectors should be the same size anyway, so add an assert
to catch any case where they aren't
 2018-08-22 09:57:39 +00:00
moneromooo-monero
76ac5a8fbe
wallet2: ask for a binary output distribution, for speed 2018-08-19 15:58:25 +00:00
stoffu
1f2409e9e2
Do memwipe for critical secret keys copied to rct::key 2018-08-16 22:26:30 +09:00
moneromooo-monero
ab74dc277a
crypto: make secret_key automatically mlock 2018-08-16 11:57:49 +00:00
moneromooo-monero
e9ffa91257
store secret keys encrypted where possible 
The secret spend key is kept encrypted in memory, and
decrypted on the fly when needed.

Both spend and view secret keys are kept encrypted in a JSON
field in the keys file. This avoids leaving the keys in
memory due to being manipulated by the JSON I/O API.
 2018-08-16 11:57:43 +00:00
moneromooo-monero
ea37614efe
wallet: wipe seed from memory where appropriate 2018-08-16 09:17:52 +00:00
stoffu
a64f57fe42
wallet2: make --restricted-rpc available for wallet RPC only 2018-08-16 09:54:23 +09:00
luigi1111
e69e0e9e34
Merge pull request #4194 
0f75717 wallet2: avoid using arbitrary random values when unknown (moneromooo-monero)
 2018-08-15 17:56:23 -05:00
luigi1111
1c55a3756b
Merge pull request #4193 
4520cfd wallet2: guard against bad outputs in import_outputs (moneromooo-monero)
 2018-08-15 17:54:49 -05:00
luigi1111
8d2e454929
Merge pull request #4188 
a3fe1c5 simplewallet: add set_tx_key for importing tx keys from 3rd party wallets (stoffu)
 2018-08-15 17:47:05 -05:00
luigi1111
7aa2030cee
Merge pull request #4174 
ff37bd0 wallet2: fix O(n^2) behaviour in import_key_images (moneromooo-monero)
 2018-08-15 17:40:55 -05:00
luigi1111
564e9c3b5f
Merge pull request #4170 
1c6cfd3 wallet-rpc: add get_address_index command (stoffu)
 2018-08-15 17:35:49 -05:00
luigi1111
5e795ee7af
Merge pull request #4153 
37f0799 wallet: distinguish coinbase from other txes in show_transfers (moneromooo-monero)
 2018-08-15 17:23:56 -05:00
luigi1111
2a44c2defd
Merge pull request #4150 
f2e65c6 wallet2: consider minimum fee when testing if balance is sufficient (stoffu)
 2018-08-15 17:22:36 -05:00
luigi1111
017e07a035
Merge pull request #4103 
bcab579 wallet: allow adjusting number of rounds for the key derivation function (stoffu)
 2018-08-15 17:09:52 -05:00
luigi1111
4cde4cb946
Merge pull request #3528 
34d4b79 wallet2: use a gamma distribution to pick fake outs (moneromooo-monero)
 2018-08-15 17:00:32 -05:00
fireice-uk
10475ab23f node_rpc_proxy: fix fork earliest height caching [RYO backport] 
xref https://github.com/ryo-currency/ryo-currency/pull/86
 2018-08-13 22:16:17 +02:00
moneromooo-monero
ac09cfa6be
wallet2: remove obsolete pruned/unpruned case 
All daemons will not support pruned blocks
 2018-08-13 13:17:27 +00:00
stoffu
bcab579864
wallet: allow adjusting number of rounds for the key derivation function 2018-08-08 01:56:54 +09:00
moneromooo-monero
37f0799284
wallet: distinguish coinbase from other txes in show_transfers 2018-08-03 12:48:16 +00:00
moneromooo-monero
8439306212
wallet2: do not divide by 0 on invalid daemon response 2018-07-31 14:26:00 +00:00
stoffu
1c6cfd34f4
wallet-rpc: add get_address_index command 2018-07-31 21:36:12 +09:00
moneromooo-monero
0f757177fe
wallet2: avoid using arbitrary random values when unknown 2018-07-30 13:34:15 +01:00
moneromooo-monero
4520cfd978
wallet2: guard against bad outputs in import_outputs 
also some minor speedup
 2018-07-30 13:21:58 +01:00
stoffu
a3fe1c56ee
simplewallet: add set_tx_key for importing tx keys from 3rd party wallets 2018-07-30 20:50:05 +09:00
luigi1111
f739a3cbb8
Merge pull request #4109 
2951436 wallet: warn when payment IDs are used (moneromooo-monero)
 2018-07-27 14:27:47 -05:00
luigi1111
92b5d6c204
Merge pull request #4091 
a4272de wallet2: unlock keys file before calling verify_password (needed for Windows) (stoffu)
 2018-07-27 14:22:34 -05:00
moneromooo-monero
ff37bd00bc
wallet2: fix O(n^2) behaviour in import_key_images 
That takes a lot of time for even not so large wallets
 2018-07-24 14:34:19 +01:00
luigi1111
702a41034d
Merge pull request #4088 
8c4db68 node_rpc_proxy: factor a few RPC calls using get_info (moneromooo-monero)
 2018-07-19 14:15:16 -05:00
luigi1111
5c102c60dc
Merge pull request #4087 
d6440ab wallet2: recover from index out of hashchain bounds error (moneromooo-monero)
 2018-07-19 14:14:10 -05:00
luigi1111
be81a27fa4
Merge pull request #4071 
d6d78f1 Allow fractional outputs to be ignored (stoffu)
 2018-07-19 14:06:54 -05:00
luigi1111
9315e12d34
Merge pull request #4033 
3e46db9 rpc: add a non binary get_transaction_pool_hashes RPC (moneromooo-monero)
 2018-07-19 13:55:37 -05:00
stoffu
f2e65c6e50
wallet2: consider minimum fee when testing if balance is sufficient 2018-07-19 20:31:07 +09:00
moneromooo-monero
d6440ab319
wallet2: recover from index out of hashchain bounds error 
This can happen when there's a very large reorg on the daemon
(ie, on testnet)
 2018-07-16 23:13:56 +01:00
moneromooo-monero
2951436704
wallet: warn when payment IDs are used 
Subaddresses are better for privacy
 2018-07-12 19:37:29 +01:00
moneromooo-monero
fc39d3b23c
wallet2: ensure outputs are processed only once 
This should be proof against any way one might get to multiple
processing, such as generating the same derivation from the
same pubkey, etc
 2018-07-08 12:56:51 +01:00
moneromooo-monero
34d4b798d4
wallet2: use a gamma distribution to pick fake outs 
as per "An Empirical Analysis of Linkability in the Monero
Blockchain", by Miller et al.
 2018-07-03 18:10:48 +01:00
Riccardo Spagni
40f85f478e
Merge pull request #3985 
58cceaad wallet2: fix double counting outs if the tx pubkey is duplicated (moneromooo-monero)
 2018-07-03 15:51:41 +02:00
Riccardo Spagni
f449dbe8eb
Merge pull request #4041 
df9d50a8 wallet2: fix read buffer overflow in import_key_images (moneromooo-monero)
 2018-07-03 15:20:42 +02:00
Riccardo Spagni
97f5a130d6
Merge pull request #4028 
2a19697b wallet2: fix double header in unsigned transfer file (moneromooo-monero)
 2018-07-03 15:19:24 +02:00
Riccardo Spagni
27ca6ca594
Merge pull request #4004 
bc443494 wallet2: fix out of sync account tag cache (moneromooo-monero)
 2018-07-03 15:16:37 +02:00
moneromooo-monero
58cceaad71
wallet2: fix double counting outs if the tx pubkey is duplicated 2018-07-03 14:16:30 +01:00
stoffu
a4272de797
wallet2: unlock keys file before calling verify_password (needed for Windows) 
Also added notes to WalletManager::verifyWalletPassword (which afaik seems unused
by anyone at the moment) regarding the need to unlock the keys file beforehand.
 2018-07-03 18:07:20 +09:00
stoffu
d6d78f157b
Allow fractional outputs to be ignored 2018-07-03 18:04:31 +09:00
moneromooo-monero
8c4db68ff7
node_rpc_proxy: factor a few RPC calls using get_info 
Takes advantage of caching
 2018-07-02 17:59:44 +01:00
luigi1111
a9b83f5a6e
Merge pull request #4067 
9a39b7d wallet2: fix build for windows (std::max again) (moneromooo-monero)
 2018-06-27 21:28:34 -05:00
stoffu
3d623a86d1
wallet: prevent the same wallet file from being opened by multiple processes 2018-06-28 09:41:43 +09:00
moneromooo-monero
9a39b7dd7f
wallet2: fix build for windows (std::max again) 2018-06-28 00:47:48 +01:00
luigi1111
2329d2f4c8
Merge pull request #3907 
dcbc17e wallet: include a suggested number of confirmations based on amount (moneromooo-monero)
 2018-06-27 16:32:33 -05:00
luigi1111
8a27caeb22
Merge pull request #3998 
8db23df wallet: on first refresh, start off with a quantized height (moneromooo-monero)
 2018-06-27 16:30:38 -05:00
luigi1111
9453573581
Merge pull request #3995 
0a5292c wallet2: use decoded amount when reporting repeated output key (stoffu)
 2018-06-27 16:28:57 -05:00
luigi1111
c28a2b0d7d
Merge pull request #3992 
25c15dc wallet2: use correct fee for split txes (stoffu)
 2018-06-27 16:26:23 -05:00
luigi1111
5eb2e01216
Merge pull request #3991 
798dfcf wallet: allow unspendable unmixable outputs to be discarded (stoffu)
 2018-06-27 16:25:03 -05:00
luigi1111
3ad4ecd4ff
Merge pull request #3982 
08b85a8 cryptonote_config: add get_config to refactor x = testnet ? config::testnet::X : stagenet ? config::stagenet::X : config::X (stoffu)
0cf80ba net_node: resolve host for node addresses given via command line flags (stoffu)
 2018-06-27 15:38:23 -05:00
moneromooo-monero
dcbc17e97e
wallet: include a suggested number of confirmations based on amount 
This is based on how much an attacking miner stands to lose in block
rewardy by mining a private chain which double spends a payment.
This is not foolproof, since mining is based on luck, and breaks
down as the attacking miner nears 50% of the network hash rate,
and the estimation is based on a constant block reward.
 2018-06-27 21:38:21 +01:00
luigi1111
a844844cda
Merge pull request #3716 
a2b557f 6795bd0 209ec96 ed2c81e a830db2 57ea902 31a895e ba8331c f7f1917 41be339 f025ae9 ef2cb63 dcfd299 5d3e702 2704624 2771a18 0e4c7d0 (moneromooo-monero)
 2018-06-27 15:33:01 -05:00
moneromooo-monero
0e4c7d0fae
wallet2: cache ringdb key while refreshing 
Speeds up syncing with a lot of outgoing outputs as key generation
runs Cryptonight.
 2018-06-26 22:15:38 +01:00
moneromooo-monero
2771a18e85
threadpool: allow leaf functions to run concurrently 
Decrease the number of worker threads by one to account
for the fact the calling thread acts as a worker thread now
 2018-06-26 22:15:22 +01:00
moneromooo-monero
2704624eae
wallet2: remove unneeded divisions 2018-06-26 22:15:20 +01:00
moneromooo-monero
5d3e70229e
wallet2: remove old blockchain size cache hack 2018-06-26 22:15:18 +01:00
moneromooo-monero
dcfd299239
wallet2: speedup refresh 
key derivation and checking for incoming outputs are threaded
in batch before adding blocks to the local blockchain. Other
minor bits and bobs are also cached.
 2018-06-26 22:15:16 +01:00
moneromooo-monero
f025ae9760
wallet2: avoid re-parsing blocks when refreshing in a loop 2018-06-26 22:15:12 +01:00
moneromooo-monero
41be339655
wallet2: avoid duplicate parsing of tx extra 2018-06-26 22:15:10 +01:00
moneromooo-monero
f7f1917ed4
wallet2: remove useless device locking 2018-06-26 22:14:35 +01:00
moneromooo-monero
ba8331ce41
wallet2: parse blocks in the RPC thread, not the processing thread 
Processing typically is the bottleneck
 2018-06-26 22:14:33 +01:00
moneromooo-monero
31a895e876
wallet2: simplify/speedup process_blocks 2018-06-26 22:14:31 +01:00
moneromooo-monero
57ea90285c
wallet: don't process miner tx if we're refreshing with no-coinbase 2018-06-26 22:14:26 +01:00
moneromooo-monero
ed2c81ed95
replace std::list with std::vector on some hot paths 
also use reserve where appropriate
 2018-06-26 22:14:21 +01:00
moneromooo-monero
6795bd0d4e
rpc: add option to skip coinbase info in get_blocks.bin 2018-06-26 22:14:16 +01:00
moneromooo-monero
a2b557fe5c
wallet2: use std::move on containers where appropriate 2018-06-26 22:14:14 +01:00
luigi1111
506be80601
Merge pull request #3955 
d7a6b72 wallet2: fix bulletproof cold signing (moneromooo-monero)
 2018-06-25 15:09:48 -05:00
luigi1111
26562e9f3c
Merge pull request #3941 
bf26920 wallet2: fix get_approximate_blockchain_height for stagenet (stoffu)
 2018-06-25 14:54:54 -05:00
moneromooo-monero
df9d50a8a4
wallet2: fix read buffer overflow in import_key_images 2018-06-23 09:22:20 +01:00
moneromooo-monero
3e46db97e5
rpc: add a non binary get_transaction_pool_hashes RPC 2018-06-21 09:02:42 +01:00
stoffu
8fc0cdb96f
wallet2: lower default for subaddress lookahead when restoring with hardware 2018-06-21 12:35:23 +09:00
moneromooo-monero
2a19697bd4
wallet2: fix double header in unsigned transfer file 2018-06-19 22:30:02 +01:00
luigi1111
896512b2b6
Merge pull request #3878 
5a412b7 disable file size sanity check when loading the wallet cache (moneromooo-monero)
 2018-06-19 12:57:59 -05:00
luigi1111
9226acca4b
Merge pull request #3804 
89e51ec simple-wallet-cli: Add warnings about inaccurate balances to to watch-only wallet (jcktm)
 2018-06-16 14:15:52 -05:00
luigi1111
4e7897e57c
Merge pull request #3780 
9c2a7b4 wallet-rpc: watch-only and cold wallet features added (ph4r05)
 2018-06-16 14:12:57 -05:00
luigi1111
e3012444fb
Merge pull request #3762 
eb9f3a3 check_spend_proof (itssteven)
 2018-06-16 14:10:11 -05:00
moneromooo-monero
bc443494f3
wallet2: fix out of sync account tag cache 
This would cause crashes when trying to tag an account that was
just created
 2018-06-15 20:18:12 +01:00
moneromooo-monero
8db23df581
wallet: on first refresh, start off with a quantized height 
for privacy reasons, so an untrusted node can't easily track
wallets from IP address to IP address, etc. The granularity
is 1024 blocks, which is about a day and a half.
 2018-06-13 22:44:27 +01:00
stoffu
798dfcfe79
wallet: allow unspendable unmixable outputs to be discarded 2018-06-13 11:56:40 +09:00
stoffu
0a5292c339
wallet2: use decoded amount when reporting repeated output key 2018-06-13 01:06:44 +09:00
stoffu
25c15dca5c
wallet2: use correct fee for split txes 2018-06-12 12:06:51 +09:00
stoffu
08b85a8e00
cryptonote_config: add get_config to refactor x = testnet ? config::testnet::X : stagenet ? config::stagenet::X : config::X 2018-06-11 20:17:02 +09:00
luigi1111
00635bd68b
Merge pull request #3598 
b21bc00 Wallet: added methods to sign and verify arbitrary message with multisig public signer's key (libwallet & wallet api) (naughtyfox)
 2018-06-08 14:40:06 -05:00
luigi1111
1af890287b
Merge pull request #3890 
f80b157 wallet2: don't ask for pruned txes yet, we still parse the entire tx (moneromooo-monero)
 2018-06-07 12:12:28 -05:00
moneromooo-monero
d7a6b72c15
wallet2: fix bulletproof cold signing 
Cold signing was always using Borromean range proofs, causing
a larger tx, and an incorrect fee
 2018-06-07 12:29:30 +01:00
stoffu
bf26920f27
wallet2: fix get_approximate_blockchain_height for stagenet 2018-06-06 20:33:01 +09:00
Dusan Klinec
9c2a7b4638 wallet-rpc: watch-only and cold wallet features added 
- unsigned_txset, signed_txset in transfer / submit_transfer / sign_transfer
- export_outputs, import_outputs

Squashed commits:
[f4d9f3d4] wallet-rpc: do_not_relay removed from submit_transfer
[5b16a86f] wallet-rpc: review-fix - method signature changes, renaming
[b7fbb10a] wallet-rpc: naming fixes (unsigned vs signed), consts renamed
[8c7d2727] wallet-rpc: sign_transfer added
[481d024a] wallet2: sign_tx splitted to work with strings and structs, more granular
[2a474db9] wallet-rpc: wallet2::load_unsigned_tx split to load from str, file
[b1e3a018] wallet-rpc: review fix, load_tx_from_str variable rename
[1f6373be] wallet-rpc: review fix: save_tx_to_{str,file}
[2a08eafc] wallet-rpc: review comments fixes
- redundant this removed from wallet2.cpp
- load_tx_from_str, load_tx_from_file
[43498052] wallet-rpc: submit_transfer added
[9c45d1ad] wallet-rpc: watch_only check, return unsigned_txset
[62831396] wallet2: added string variants to load_tx, save_tx

- analogously to save_multisig_tx
- required for monero-wallet-rpc to support watch-only wallet
 2018-06-03 13:21:00 +02:00
luigi1111
3a373c3d3a
Merge pull request #3489 
47fdb74 WalletApi: getMultisigInfo entry for gui wallets... (naughtyfox)
47fdb74 Refactored: work with wallet api statuses to make setting and getting operations atomic along with error strings (naughtyfox)
 2018-05-31 14:34:34 -05:00
moneromooo-monero
f80b1571c6
wallet2: don't ask for pruned txes yet, we still parse the entire tx 2018-05-31 16:46:58 +01:00
stoffu
0da5d37bf3
wallet: fix shared ring db path 2018-05-31 08:16:45 +09:00
luigi1111
5b189ce2a8
Merge pull request #3405 
80d2f80 wallet2: Update function parameter documentation (leonklingele)
 2018-05-29 12:52:43 -05:00
moneromooo-monero
5a412b7a3f
disable file size sanity check when loading the wallet cache 2018-05-28 14:58:22 +01:00
stoffu
cb9c7972b6
Fix output shuffling for multisig 2018-05-20 09:38:41 +09:00
jcktm
89e51ecd38 simple-wallet-cli: Add warnings about inaccurate balances to to watch-only wallet 2018-05-15 15:28:42 +10:00
moneromooo-monero
a58d9738c9
wallet2: consider 6 outputs or less to be unmixable from v7 2018-05-10 21:19:33 +01:00
itssteven
eb9f3a3294
check_spend_proof 
My intention is to mitigate #3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: https://github.com/monero-integrations/monerophp/issues/72 & my temp fix: https://github.com/monero-integrations/monerophp/pull/74
 2018-05-06 17:42:27 +01:00
Riccardo Spagni
93e76e14a2
Merge pull request #3685 
ffeeefde speedup get_output_histogram for all amounts when min_count > 0 (moneromooo-monero)
2dae0f20 wallet2: add missing parameters to get_output_histogram (moneromooo-monero)
 2018-04-28 16:56:22 +02:00
Riccardo Spagni
35299644b2
Merge pull request #3650 
5bd7f760 import_multisig_info: fix sanity check crash in detach_blockchain (Mikhail Mitkevichl)
 2018-04-28 16:54:37 +02:00
naughtyfox
b21bc00704 Wallet: added methods to sign and verify arbitrary message with multisig public signer's key (libwallet & wallet api) 2018-04-25 17:55:54 +03:00
moneromooo-monero
2dae0f203a
wallet2: add missing parameters to get_output_histogram 2018-04-23 10:54:25 +01:00
Mikhail Mitkevichl
5bd7f760e9 import_multisig_info: fix sanity check crash in detach_blockchain 2018-04-21 23:25:01 +03:00
Riccardo Spagni
03ff3be10e
Merge pull request #3672 
875c1cab wallet2: increase rpc timeout for get_output_distribution (moneromooo-monero)
70f23217 add top height to get_output_distribution, and cache it for rct (moneromooo-monero)
8c7363fb rpc: add missing perf timer for get_output_distribution (moneromooo-monero)
 2018-04-21 21:54:08 +02:00
moneromooo-monero
875c1cabb9
wallet2: increase rpc timeout for get_output_distribution 2018-04-19 16:06:26 +01:00
moneromooo-monero
70f2321763
add top height to get_output_distribution, and cache it for rct 
This should cache the vast majority of calls for long running wallets
 2018-04-19 16:06:22 +01:00
stoffu
b5d6c723e9
wallet2: store subaddress lookahead settings 2018-04-12 22:23:53 +09:00
cslashm
94b899db26 Use 'boost' mutex instead of 'std' mutex 2018-04-12 13:58:57 +02:00
cslashm
2c274e05fe Fix sub-address tx scan. 
When additional keys was needed, the TX scan failed because the
derivation data was always recomputed with the main tx_key and not
the corresponding additional one.

Moreover this patch avoid perf decreasing when not using HW device.
 2018-04-12 13:58:57 +02:00
Riccardo Spagni
5e08fd89ea
Merge pull request #3549 
73951cbd wallet2: request transactions in slices when scanning for known rings (moneromooo-monero)
25fe67e4 rpc: allow getting pruned blocks from gettransactions (moneromooo-monero)
 2018-04-12 13:49:33 +02:00
Riccardo Spagni
14c870ee5f
Merge pull request #3615 
24acb66e wallet2: fix misc issues when the ringdb can't be initialized (moneromooo-monero)
 2018-04-12 13:47:54 +02:00