rottenwheel/monero
1
0
Fork 0
mirror of https://codeberg.org/anoncontributorxmr/monero.git synced 2024-11-23 11:23:26 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #6157

Browse Source 
402dd207 db_lmdb: guard against non NUL terminated keys (moneromooo-monero)
This commit is contained in:
Alexander Blair 2020-01-24 20:07:36 -08:00
commit e51ce477db
No known key found for this signature in database
GPG Key ID: C64552D877C32479
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/blockchain_db/lmdb/db_lmdb.cpp
View File

@ -163,7 +163,15 @@ int BlockchainLMDB::compare_string(const MDB_val *a, const MDB_val *b)
{ {
const char *va = (const char*) a->mv_data; const char *va = (const char*) a->mv_data;
const char *vb = (const char*) b->mv_data; const char *vb = (const char*) b->mv_data;
return strcmp(va, vb); const size_t sz = std::min(a->mv_size, b->mv_size);
int ret = strncmp(va, vb, sz);
if (ret)
return ret;
if (a->mv_size < b->mv_size)
return -1;
if (a->mv_size > b->mv_size)
return 1;
return 0;
} }
} }