rottenwheel/monero
1
0
Fork 0
mirror of https://codeberg.org/anoncontributorxmr/monero.git synced 2024-11-27 05:13:25 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

blockchain: avoid exception if asked for a block we do not have

Browse Source 
This can happen if a peer tries to obtain the next span from other
peers if that span is needed for not downloaded yet. Also if the
peer maliciously requests a non existent block hash.
This commit is contained in:
moneromooo-monero 2018-04-29 11:41:54 +01:00
parent 52f6b33890
commit b5cb1bc403
No known key found for this signature in database
GPG Key ID: 686F07454D6CEFC3
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/cryptonote_core/blockchain.cpp
View File

@ -2032,16 +2032,19 @@ bool Blockchain::get_blocks(const t_ids_container& block_ids, t_blocks_container
{ {
try try
{ {
blocks.push_back(std::make_pair(m_db->get_block_blob(block_hash), block())); uint64_t height = 0;
if (!parse_and_validate_block_from_blob(blocks.back().first, blocks.back().second)) if (m_db->block_exists(block_hash, &height))
{ {
LOG_ERROR("Invalid block"); blocks.push_back(std::make_pair(m_db->get_block_blob_from_height(height), block()));
return false; if (!parse_and_validate_block_from_blob(blocks.back().first, blocks.back().second))
{
LOG_ERROR("Invalid block: " << block_hash);
blocks.pop_back();
missed_bs.push_back(block_hash);
}
} }
} else
catch (const BLOCK_DNE& e) missed_bs.push_back(block_hash);
{
missed_bs.push_back(block_hash);
} }
catch (const std::exception& e) catch (const std::exception& e)
{ {