rottenwheel/monero
1
0
Fork 0
mirror of https://codeberg.org/anoncontributorxmr/monero.git synced 2024-11-26 21:03:28 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

download: fix leak

Browse Source 
A shared_ptr as by value capture will keep the object alive
This commit is contained in:
moneromooo-monero 2021-10-10 19:13:50 +00:00
parent b58a9fb12e
commit 75d05b9448
No known key found for this signature in database
GPG Key ID: 686F07454D6CEFC3
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/common/download.cpp
View File

@ -53,7 +53,7 @@ namespace tools
download_thread_control(const std::string &path, const std::string &uri, std::function<void(const std::string&, const std::string&, bool)> result_cb, std::function<bool(const std::string&, const std::string&, size_t, ssize_t)> progress_cb): download_thread_control(const std::string &path, const std::string &uri, std::function<void(const std::string&, const std::string&, bool)> result_cb, std::function<bool(const std::string&, const std::string&, size_t, ssize_t)> progress_cb):
path(path), uri(uri), result_cb(result_cb), progress_cb(progress_cb), stop(false), stopped(false), success(false) {} path(path), uri(uri), result_cb(result_cb), progress_cb(progress_cb), stop(false), stopped(false), success(false) {}
~download_thread_control() { if (thread.joinable()) thread.detach(); } ~download_thread_control() { if (thread.joinable()) { thread.detach(); thread = {}; } }
}; };
static void download_thread(download_async_handle control) static void download_thread(download_async_handle control)
@ -293,9 +293,13 @@ namespace tools
{ {
boost::lock_guard<boost::mutex> lock(control->mutex); boost::lock_guard<boost::mutex> lock(control->mutex);
if (control->stopped) if (control->stopped)
{
control->thread = {};
return true; return true;
} }
}
control->thread.join(); control->thread.join();
control->thread = {};
return true; return true;
} }
@ -305,10 +309,14 @@ namespace tools
{ {
boost::lock_guard<boost::mutex> lock(control->mutex); boost::lock_guard<boost::mutex> lock(control->mutex);
if (control->stopped) if (control->stopped)
{
control->thread = {};
return true; return true;
}
control->stop = true; control->stop = true;
} }
control->thread.join(); control->thread.join();
control->thread = {};
return true; return true;
} }
} }