tor/changes
David Goulet ea339227c2 conn: Remove assert on new listener connection when retrying
Opening a new listener connection can fail in many ways like a bind()
permission denied on a low port for instance.

And thus, we should expect to handle an error when creating a new one instead
of assert() on it.

To hit the removed assert:

  ORPort 80
  KeepBindCapabilities 0

Start tor. Then edit torrc:

  ORPort <some-IP>:80

HUP tor and the assert is hit.

Fixes #40073

Signed-off-by: David Goulet <dgoulet@torproject.org>
2020-09-01 10:01:21 -04:00
..
.dummy Add a .dummy file in the changes directory to stop git from removing it 2015-05-11 11:41:48 -04:00
29241_diagnostic NSS: Log an error message when SSL_ExportKeyingMaterial() fails 2019-04-06 11:06:22 +10:00
bug12399 Change loglevel of message 'Hash of session info was not as expected' 2019-09-02 14:09:39 -04:00
bug13221 Fix some error-checking logic and a misleading error message 2019-02-25 16:03:42 -06:00
bug16016 Downgrade "Bug: No entry found in extrainfo map" message. 2020-06-30 11:54:13 -04:00
bug22619 Fix a logic error in deciding whether to accept SessionGroup= 2019-05-31 08:26:10 -04:00
bug23507 changes: file for 23507, v3 onion service fix 2019-08-23 16:25:33 +10:00
bug23818_v2 changes: file for 23818, v2 onion service fix 2019-08-23 15:08:43 +10:00
bug23818_v3 changes: file for 23818, v3 onion service fix 2019-08-23 15:10:45 +10:00
bug24661 Entry Nodes: Use a reasonably live consensus to select guards 2018-11-22 16:54:22 +10:00
bug27197 rust/protover: reject extra commas 2018-09-15 23:19:31 +00:00
bug27199 rust: abort on panic in all profiles 2018-08-18 19:23:28 +00:00
bug27740 rust/protover: return C-allocated string in protover_all_supported() 2018-09-21 05:16:22 +00:00
bug27741 Remove extraneous argument from Rust protover_compute_vote() 2018-09-17 11:57:56 -04:00
bug27750 conn: Close the read side of a closing connection when write limit is reached 2018-11-14 15:42:52 -05:00
bug27800 Log more info for duplicate ed25519 IDs 2018-10-17 15:39:55 -05:00
bug27804 rust/protover: fix null deref in protover_all_supported() 2018-09-21 04:57:26 +00:00
bug27841 At intro points, don't close circuits on NACKs 2018-11-06 17:04:08 -05:00
bug27948 Treat backtrace test failures as expected on most BSD-derived systems 2018-10-23 11:21:10 +10:00
bug27963_timeradd Add timeval.h include to compat_pthreads.c for timeradd() 2018-10-10 12:19:56 -04:00
bug27968 Avoid a race condition in test_rebind.py 2018-11-02 13:14:23 -04:00
bug28096 Windows: fix uname on recent Windows versions 2018-11-15 12:19:11 +10:00
bug28115 Fix a misspelled macro test that was breaking big-endian OPE 2018-10-19 08:41:25 -04:00
bug28127 Add changes file for Bug #28127 2018-10-30 10:49:03 -04:00
bug28183 seccomp2: Add "shutdown" to the list of permitted system calls. 2018-11-12 08:23:58 -05:00
bug28202 Fix possible UB in an end-of-string check in get_next_token(). 2018-10-25 09:06:13 -04:00
bug28245 Always declare groups when building with openssl 1.1.1 APIs 2018-11-09 10:10:25 -05:00
bug28298 refuse to start with relative paths + RunAsDaemon 2018-11-06 15:50:56 +01:00
bug28303 Add a changes file for bug 28303 2018-11-06 15:17:19 -05:00
bug28348_034 Actually disable NEED_NET periodic events when DisableNetwork is set 2018-11-06 07:40:02 -05:00
bug28399 Appveyor: remove incorrect OpenSSL path 2018-11-15 19:23:33 +10:00
bug28413 Fix a compiler warning in aes.c. 2018-11-12 15:39:28 -05:00
bug28419 Changes file for bug 28419 2018-11-14 07:51:36 -05:00
bug28435 Fix Doxyfile for 0.3.5 source tree moves 2018-11-14 07:45:55 -05:00
bug28441 log: stop talking about the Named flag in log messages 2018-11-14 18:16:34 +10:00
bug28454 Appveyor: manually add zstd flags to configure 2018-11-15 19:23:37 +10:00
bug28485 Add missing library to build tor-print-ed-signing-cert. 2018-11-19 10:18:44 -05:00
bug28524 Update control_free_all() for #27169 2018-11-19 15:48:08 -06:00
bug28525 Fix #28525 changes file that is breaking CI. 2019-08-09 13:55:31 +10:00
bug28554 Test: Fix memory leaks and missing unmocks in entry guard tests 2018-11-22 16:42:32 +10:00
bug28562 Changes file for 28562 2018-12-17 10:57:47 -05:00
bug28568 Stop running stem's unit tests as part of "make test-stem" 2018-12-20 13:01:18 +10:00
bug28569 Entry Nodes: Mark outdated dirservers in reasonably live consensuses 2018-11-22 16:54:34 +10:00
bug28612 Call run_tor_main_loop() in ntmain.c, rather than do_main_loop(). 2018-12-18 13:55:08 -05:00
bug28619 hs-v3: Do not close RP circuits when deleting an ephemeral service 2018-11-26 14:45:53 -05:00
bug28656 Stop logging a BUG() warning when tor is waiting for exit descriptors 2019-03-15 08:57:28 -04:00
bug28698 Add circuit time check before logging about relaxing circuit time 2019-02-19 11:24:51 -05:00
bug28895 Stop logging 'Your Guard' in circpathbias.c 2019-01-09 09:35:36 -05:00
bug28920 Rework rep_hist_log_link_protocol_counts() 2019-01-14 14:01:55 -05:00
bug28938 Add changes file for bug 28938 2019-01-09 08:52:05 -05:00
bug28974 Add an errno.h include to freespace.c to fix bug 28974. 2019-01-02 15:19:52 -05:00
bug28979 Fix documentation for ClientAuth on HSv3. 2019-01-16 16:10:20 -05:00
bug28981 Add changes file for bug 28981 2019-01-16 14:40:31 -05:00
bug28995 Fix tor_ersatz_socketpair on IPv6-only systems 2019-01-07 17:28:21 -06:00
bug29017 stats: Make PaddingStatistics depend on ExtraInfoStatistics 2019-01-08 18:21:10 +10:00
bug29029 rend: stop warning when clients send multiple rend establish cells 2019-01-10 07:59:59 +10:00
bug29034 Bug 29034: Cleanup hs circuitmap when purpose changes. 2019-06-05 12:56:49 -07:00
bug29036 changes: Use the first Tor version with CI coverage for the 29036 changes file 2019-04-01 13:40:16 +10:00
bug29040 Add changes file for bug 29040. 2019-02-08 08:37:23 -05:00
bug29042 correct bug number in 29042 changelog 2019-01-22 12:27:46 -05:00
bug29135 Log an HSDesc we failed to parse at Debug loglevel 2019-01-23 10:37:10 -05:00
bug29144 Log the correct "auto" port number for listening sockets 2019-03-01 12:34:21 +10:00
bug29145 Fix a compiler warning on OpenBSD 2019-02-19 11:38:32 -05:00
bug29161 Capture more BUG warnings in util/time test 2019-01-23 12:37:12 -05:00
bug29175_035 Allow empty username/password in SOCKS5 username/password auth message 2019-01-26 11:06:33 +02:00
bug29241 changes: Ticket 29241 is actually a bug on NSS in 0.3.5.1-alpha 2019-04-06 11:07:20 +10:00
bug29244 Update Cargo.lock with new comment; suppress 29244. 2019-02-01 16:38:23 +01:00
bug29530_035 Changes file for backporting 29530 to 0.3.5 2019-02-26 09:58:52 +10:00
bug29599 test/shared-random: Stop leaking shared random state in the unit tests 2019-02-27 15:04:40 +10:00
bug29601 appveyor: skip two redundant builds to speed up CI on Windows 2019-02-28 07:43:57 +10:00
bug29665 relays shouldn't close idle rend circuits 2019-03-14 12:54:16 +02:00
bug29670 Make get_proxy_type() connection-specific 2019-05-29 11:00:09 -04:00
bug29703 test: Backport the 0.3.4 src/test/test-network.sh to 0.2.9 2019-03-22 13:20:23 +10:00
bug29706_minimal test/sr: Free SRVs before replacing them in test_sr_setup_srv() 2019-03-09 11:59:52 +10:00
bug29819 Correct how we use libseccomp 2019-12-17 09:47:28 -05:00
bug29875 changes file for bug 29875. 2019-05-31 12:39:52 -04:00
bug29922 Detect and suppress an additional gmtime() warning in test_util.c 2019-04-08 17:02:14 -04:00
bug30011 Travis: Terminate test-stem if it takes more than 9.5 minutes to run 2019-04-04 13:21:35 +10:00
bug30021 Do not cache bogus results from classifying client ciphers 2019-04-04 11:24:55 -04:00
bug30040 Add changes file for #30040. 2019-04-10 12:46:27 +03:00
bug30041 Changes file for bug30041 2019-04-09 12:05:33 -04:00
bug30148 Fix a memory leak on failure to create keys directory. 2019-04-11 18:18:14 -04:00
bug30189 Use a tor_abort_() wrapper in our util_bug.h macros 2019-04-15 14:16:23 -04:00
bug30190 Do not warn about compatible OpenSSL upgrades 2019-04-17 01:55:04 +02:00
bug30316 Move bandwidth-file-headers line to appear in the correct vote section 2019-04-29 14:31:09 -04:00
bug30344 Stop libevent from reading data from closed connections. 2019-10-09 16:24:49 -04:00
bug30452 Add a --list-modules command 2019-05-14 19:19:53 -04:00
bug30475 Don't pass a NULL into a %s when logging client auth file load failure 2019-05-10 17:47:43 -04:00
bug30561 Tweak comments in tor_vasprintf(), and add a changes file for 30651 2019-05-29 09:38:57 -04:00
bug30713 Travis: Skip test_rebind on macOS builds 2019-06-10 20:49:59 +10:00
bug30744 Travis: allow the test-stem job to fail 2019-06-10 19:18:35 +10:00
bug30781 dirparse: Stop crashing when parsing unknown descriptor purpose annotations 2019-06-06 09:51:24 +10:00
bug30894 Fix memleak when failing to parse a CSV_INTERVAL. 2019-06-15 16:47:16 -04:00
bug30916 Avoid a crash if our "current" and "old" ntor onion keys are equal 2019-09-18 11:14:45 -04:00
bug31003 Set 'routerlist' global to NULL before freeing it. 2019-07-19 09:49:52 -04:00
bug31036 Use _lseeki64() on windows. 2020-07-28 11:30:47 -04:00
bug31107 Treat an unexpected constant-sized VERSIONS cell as a PROTOCOL_WARN. 2019-09-17 09:13:25 -04:00
bug31343 Avoid using labs() on time_t in channeltls.c 2019-08-06 11:11:06 -04:00
bug31408 changes: use correct bugfix release, and reword changes file for 31408 2019-09-24 11:06:20 +10:00
bug31463 Fix gcc build exclude on travis 2019-08-22 22:09:32 +10:00
bug31571 torerr: Try harder to flush raw assert messages before process termination 2019-08-30 21:51:11 +10:00
bug31657 entrynodes: Make routine descriptor expiry notice logs less alarming 2019-09-06 16:43:14 +10:00
bug31837 test/rebind: Make control formatting and log parsing more robust 2019-10-20 20:09:35 +10:00
bug31884 Appveyor: Avoid spurious errors in Appveyor CI builds 2019-09-30 15:14:21 +10:00
bug31939 tls: Log TLS read buffer length bugs once 2019-10-04 12:33:34 +10:00
bug32449 Appveyor: Install OpenSSL to resolve a header/library mismatch 2019-11-11 13:19:15 +10:00
bug32753 Lowercase the BridgeDistribution value from torrc in descriptors. 2020-02-12 12:21:41 +10:00
bug32884 When initializing pthreads, always set the main thread. 2020-01-06 09:37:12 -05:00
bug33032 pem_decode(): Tolerate CRLF line endings 2020-03-11 10:35:17 -04:00
bug33093_logging Change BUG() messages in buf_flush_to_tls() to IF_BUG_ONCE() 2020-01-29 08:31:22 -05:00
bug33119 Fix out-of-bound memory read in tor_tls_cert_matches_key() for NSS. 2020-07-06 16:19:16 -04:00
bug33673 Appveyor: Copy required DLLs to test and app 2020-03-20 14:48:31 +10:00
bug34078 changes file for bug 34078. 2020-05-06 16:58:06 -04:00
bug34303 Preemptive circs should work with UseEntryGuards 0 2020-05-30 02:20:48 -04:00
bug40028 Resolve a compiler warning from a 32-bit signed/unsigned comparison 2020-07-07 15:05:38 -04:00
bug40076 Fix a bug in buf_move_all() when the input buffer is empty. 2020-07-30 14:24:25 -04:00
bug40099 Fix allocation counting in clean_v2_descs_as_dir test. 2020-08-12 14:25:46 -04:00
chutney_ci Add a chutney mode to travis.yml. 2019-06-12 08:55:38 -04:00
cid1444119 Fix CID 1444119 2019-03-26 12:24:45 +10:00
doc31089 Hardcode the image into tor-exit-notice.html 2019-08-08 22:46:51 +10:00
geoip-2018-11-06 Update geoip and geoip6 to the November 6 2018 database. 2018-11-11 11:25:59 +01:00
geoip-2018-12-05 Update geoip and geoip6 to the December 5 2018 database. 2018-12-05 21:02:39 +01:00
geoip-2019-01-03 Update geoip and geoip6 to the January 3 2019 database. 2019-01-07 09:00:29 +01:00
geoip-2019-02-05 Update geoip and geoip6 to the February 5 2019 database. 2019-02-12 14:40:42 +01:00
geoip-2019-03-04 Update geoip and geoip6 to the March 4 2019 database. 2019-03-06 11:45:27 +01:00
geoip-2019-04-02 Update geoip and geoip6 to the April 2 2019 database. 2019-04-03 09:26:28 +02:00
geoip-2019-05-13 Update geoip and geoip6 to the May 13 2019 database. 2019-05-17 08:52:13 +02:00
geoip-2019-06-10 Update geoip and geoip6 to the June 10 2019 database. 2019-06-11 16:12:50 +02:00
geoip-2019-10-01 Update geoip and geoip6 to the October 1 2019 database. 2019-10-02 11:11:27 +02:00
geoip-2019-11-06 Update geoip and geoip6 to the November 6 2019 database. 2019-11-09 10:10:19 +01:00
geoip-2019-12-03 Update geoip and geoip6 to the December 3 2019 database. 2019-12-06 11:50:35 +01:00
rust_asan Add a changes file for Alex Crichton's rust fixes. 2018-10-30 08:45:37 -04:00
ticket19566 sr: Switch from tor_assert() to BUG() 2018-11-30 12:16:18 -05:00
ticket24803 Note ticket number in changes file for 24803 2018-12-11 10:00:19 -05:00
ticket27471 hs-v3: Close client intro circuits if the descriptor is replaced 2018-10-18 12:56:51 -04:00
ticket27751 add --enable-nss build to Travis CI 2018-09-25 18:43:23 +00:00
ticket27838 hs-v3: Create desc signing key cert before uploading 2018-10-22 16:34:41 -04:00
ticket27913 Add changes file 2018-10-29 15:18:07 -04:00
ticket27995 hs-v3: Always generate the descriptor cookie 2018-10-18 11:46:07 -04:00
ticket28026 hs-v3: Add changes file for 28026 2018-10-30 11:28:53 -04:00
ticket28113 systemd: allow tor some time to shut down after ShutdownWaitLength expires 2018-11-05 11:49:19 +10:00
ticket28128 man: ClientOnionAuthDir can't be reloaded with Sandbox 1 2018-11-15 14:36:39 -05:00
ticket28229_diag Add changes file 2018-12-01 11:18:03 -05:00
ticket28275 man: Document HSv3 client authorization revocation 2018-12-04 18:49:19 +02:00
ticket28318 Appveyor: Add Windows Server 2016 to tor's build matrix 2018-11-05 16:21:58 +10:00
ticket28459 Appveyor: always show the logs, and upload them as build artifacts 2018-11-15 21:04:17 +10:00
ticket28574 Explicitly specify path to OpenSSL for Appveyor. 2018-11-27 14:53:50 +01:00
ticket28668 Fail any unit test that causes an unhandled LD_BUG or LOG_ERR 2019-01-16 15:47:33 -05:00
ticket28669 hs-v3: Don't BUG() if descriptor is found on SOCKS connection retry 2018-12-04 14:34:04 -05:00
ticket28795 changes: file for 28795 2019-06-28 21:38:33 +10:00
ticket28838 Lower the loop_max constant in curve25519_basepoint_spot_check() 2018-12-13 11:26:09 -05:00
ticket28851 Stop re-checking our hardcoded dh parameters on every startup 2019-01-03 09:45:43 -05:00
ticket28879 Check hostname before using it in send_resolved_hostname_cell() 2018-12-17 09:15:37 -05:00
ticket28881 Always initialize addr in parse_port_config() 2018-12-18 13:52:25 -05:00
ticket28883 test_rebind: wait for tor to timeout, even if it is logging a lot 2018-12-17 09:53:17 -05:00
ticket28912 mainloop: Reactivate the linked connection event with a non empty list 2018-12-21 11:25:23 -05:00
ticket28924 ticket 28924 deserves a changes file. I made one, but I guess I forgot to git add 2019-01-02 16:09:10 -05:00
ticket28970 hs-v3: Remove a BUG() caused by an acceptable race 2019-10-24 08:50:01 -04:00
ticket28973 Detect openssl bug 7712 and work around it. 2019-01-03 09:00:47 -05:00
ticket28992 hs-v3: Remove BUG() that can occur normally 2020-02-12 14:09:40 +10:00
ticket29026 Changes file for ticket29026. 2019-02-08 08:52:46 -05:00
ticket29160 If address/get_if_addrs6 can't findipv6, log WARN, not ERR 2019-01-23 12:04:57 -05:00
ticket29168 kist: Don't write above the highwater outbuf mark 2019-02-21 10:07:34 -05:00
ticket29435 Fix coverage script. 2019-02-08 10:43:38 -05:00
ticket29617 OOM-purge the DNS cache one part at a time 2019-05-17 10:03:41 -04:00
ticket29702 test: Also avoid reading the system default torrc in integration tests 2019-04-10 19:03:43 +10:00
ticket29806 bwauth: Ignore bandwidth file lines with "vote=0" 2019-03-21 12:00:45 +10:00
ticket29962 Add changes file 2019-04-01 14:08:24 +10:00
ticket30117 changes: file for 30117 2019-04-12 08:38:30 -04:00
ticket30213 Add changes file 2019-04-30 09:15:35 +03:00
ticket30234 Travis: Show stem's tor log after failure 2019-04-22 11:48:07 +10:00
ticket30454 hs: Add changes file for #30454 2019-05-20 08:56:34 -04:00
ticket30591 Travis: make stem log a controller trace, and tail stem's tor log 2019-05-28 10:20:36 +10:00
ticket30694 Travis: only run the stem tests that use a tor binary 2019-05-30 20:05:03 +10:00
ticket30860 Travis: Add a macOS chutney job, but don't wait for it to finish 2019-09-30 23:58:38 +10:00
ticket30871 guard: Ignore marked for close circuit when changing state to open 2019-06-19 07:40:05 -04:00
ticket31372_appveyor Try using make -k in the Appveyor configuration 2019-09-23 15:08:34 -04:00
ticket31372_travis Try using make -k in Travis configuration 2019-09-23 15:05:08 -04:00
ticket31374 Fix a warning about casting the results of GetProcAddress. 2019-08-08 11:44:19 -04:00
ticket31406 dirauth: Change dizum IP address 2019-08-15 08:20:47 -04:00
ticket31466 Add a rate-limit to our warning about the disabled .exit notation 2019-09-18 15:38:33 -04:00
ticket31548 hs-v3: Make service pick the exact amount of intro points 2019-10-07 10:20:09 -04:00
ticket31554 test: Change "make test-stem" so it only runs the stem tests that use tor 2019-08-29 21:56:16 +10:00
ticket31673 build: The <sys/sysctl.h> is now deprecated on Linux 2019-09-09 17:07:08 -04:00
ticket31687_1 fp.c: Suppress float-conversion warnings on FreeBSD. 2019-09-10 10:55:44 -04:00
ticket31687_2 pf: when extracting an IPv6 address, make sure we got an IPv6 address 2019-09-10 11:07:25 -04:00
ticket31859 Travis: Add a macOS chutney job, but don't wait for it to finish 2019-09-30 23:58:38 +10:00
ticket31919_bionic changes: file for 31919's bionic Travis image change 2019-10-25 09:53:11 +10:00
ticket32058 mainloop: Disable periodic events before a destroy 2019-10-17 10:11:32 -04:00
ticket32086 Appveyor: Use Windows Server 2019 2019-10-20 22:04:08 +10:00
ticket32240 changes: file for 32240 2019-12-16 09:06:25 +10:00
ticket32241 Travis: Use macOS 10.14 with Xcode 11.2 2019-10-24 11:44:43 +10:00
ticket32242 Travis: Use zstd in our Travis Linux builds 2019-10-24 09:26:54 +10:00
ticket32407 Do not try to shut down the event loop when it is not initialized. 2019-11-06 11:33:23 -05:00
ticket32500 Travis: use -std=gnu99 in some jobs 2019-12-03 12:42:39 +10:00
ticket32629 changes: file for 32629 2019-12-06 10:51:43 +10:00
ticket32792 Travis: Produce detailed chutney diagnostics 2020-03-16 16:04:51 +10:00
ticket33075 Travis: Stop allowing stem test failures 2020-01-28 19:56:56 +10:00
ticket33119 changes file for 33119 aka TROVE-2020-002 2020-02-05 12:02:32 -05:00
ticket33194 Travis: Sort jobs in order of speed 2020-02-13 13:52:41 +10:00
ticket33195 Travis: Require the macOS IPv6 chutney job 2020-02-13 13:43:59 +10:00
ticket33212 Fix a Rust compilation warning; resolve bug 33212. 2020-02-10 13:32:09 -05:00
ticket33361 config: Warn if ContactInfo is not set 2020-03-12 12:43:00 -04:00
ticket33491 dos: Pass transport name on new client connection 2020-03-10 14:45:13 -04:00
ticket33643 Add a TOR_SKIP_TESTCASES environment variable for suppressing tests. 2020-03-19 18:36:36 -04:00
ticket33643_part2 Appveyor: disable crypto/openssl_version 2020-03-19 18:36:36 -04:00
ticket40026 CI: Fix Appveyor printf format error 2020-07-07 09:53:54 -04:00
ticket40061 More info in the fallbackdir changes file 2020-07-23 10:08:42 -04:00
ticket40073 conn: Remove assert on new listener connection when retrying 2020-09-01 10:01:21 -04:00
trove_2020_003 Fix TROVE-2020-003. 2020-03-17 11:44:45 -04:00