tor/src/or
Karsten Loesing b7d8a1e141 Report complete directory request statistics on bridges.
When we wrote the directory request statistics code in August 2009, we
thought that these statistics were only relevant for bridges, and that
bridges should not report them.  That's why we added a switch to discard
relevant observations made by bridges.  This code was first released in
0.2.2.1-alpha.

In May 2012 we learned that we didn't fully disable directory request
statistics on bridges.  Bridges did report directory request statistics,
but these statistics contained empty dirreq-v3-ips and dirreq-v3-reqs
lines.  But the remaining dirreq-* lines have always been non-empty.  (We
didn't notice for almost three years, because directory-request statistics
were disabled by default until 0.2.3.1-alpha, and all statistics have been
removed from bridge descriptors before publishing them on the metrics
website.)

Proposal 201, created in May 2012, suggests to add a new line called
bridge-v3-reqs that is similar to dirreq-v3-reqs, but that is published
only by bridges.  This proposal is still open as of December 2013.

Since October 2012 we're using dirreq-v3-resp (not -reqs) lines in
combination with bridge-ips lines to estimate bridge user numbers; see
task 8462.  This estimation method has superseded the older approach that
was only based on bridge-ips lines in November 2013.  Using dirreq-v3-resp
and bridge-ips lines is a workaround.  The cleaner approach would be to
use dirreq-v3-reqs instead.

This commit makes bridges report the same directory request statistics as
relays, including dirreq-v3-ips and dirreq-v3-reqs lines.  It makes
proposal 201 obsolete.
2013-12-18 18:02:10 +01:00
..
addressmap.c Completely refactor how FILENAME_PRIVATE works 2013-07-10 15:20:10 -04:00
addressmap.h Completely refactor how FILENAME_PRIVATE works 2013-07-10 15:20:10 -04:00
buffers.c Move Extended ORPort code to its own module. 2013-07-18 14:59:56 -04:00
buffers.h Unit tests for fetch_ext_or_cmd 2013-08-15 12:03:36 -04:00
channel.c Merge remote-tracking branch 'origin/maint-0.2.4' 2013-10-02 22:40:01 -04:00
channel.h Merge remote-tracking branch 'origin/maint-0.2.4' 2013-10-02 22:40:01 -04:00
channeltls.c Merge remote-tracking branch 'public/bug10131_024' 2013-12-09 11:06:20 -05:00
channeltls.h Update the copyright date to 201. 2013-01-16 01:54:56 -05:00
circpathbias.c Appease make check-spaces 2013-10-31 14:45:20 -04:00
circpathbias.h Make circpathbias and circuitbuild compile. 2013-10-31 14:28:49 -04:00
circuitbuild.c Merge branch 'prop221_squashed_024' 2013-11-01 10:28:01 -04:00
circuitbuild.h Move pathbias functions into a new file. 2013-10-31 14:17:49 -04:00
circuitlist.c Merge remote-tracking branch 'origin/maint-0.2.4' 2013-11-15 15:35:00 -05:00
circuitlist.h Rename circuit_get_global_list to remove trailing _ 2013-08-15 15:37:23 -04:00
circuitmux_ewma.c Update the copyright date to 201. 2013-01-16 01:54:56 -05:00
circuitmux_ewma.h Update the copyright date to 201. 2013-01-16 01:54:56 -05:00
circuitmux.c Merge branch 'morestats4' into morestats5 2013-10-28 12:09:42 +01:00
circuitmux.h Appease "make check-spaces" 2013-07-15 17:35:56 -04:00
circuitstats.c Cleanup whitespaces 2013-08-25 12:22:20 -04:00
circuitstats.h Cleanup whitespaces 2013-08-25 12:22:20 -04:00
circuituse.c Merge branch 'prop221_squashed_024' 2013-11-01 10:28:01 -04:00
circuituse.h Stop frobbing timestamp_dirty as our sole means to mark circuits unusable 2013-02-19 18:29:17 -05:00
command.c Merge branch 'prop221_squashed_024' 2013-11-01 10:28:01 -04:00
command.h Tweak CELL_STATS event based on comments by nickm. 2013-05-25 19:51:38 +02:00
config_codedigest.c Resolve about 24 DOCDOCs 2012-06-05 00:17:54 -04:00
config.c Disable (Cell,Entry,ExitPort)Statistics on bridges 2013-12-18 18:01:25 +01:00
config.h Whoops; make options_validate conform to validate_fn_t. 2013-09-13 12:36:40 -04:00
confparse.c Free the smartlist after parsing csv config option 2013-10-09 23:16:57 +00:00
confparse.h Add a --dump-config option to help testing option parsing. 2013-09-13 12:36:40 -04:00
connection_edge.c Add missing includes for circpathbias.h 2013-10-31 14:33:34 -04:00
connection_edge.h Completely refactor how FILENAME_PRIVATE works 2013-07-10 15:20:10 -04:00
connection_or.c Merge remote-tracking branch 'origin/maint-0.2.4' 2013-09-24 10:47:26 -04:00
connection_or.h White-box tests for the succeeding case of ext_or_port handshake. 2013-08-15 12:03:37 -04:00
connection.c Move other #9731 check to start of its functions 2013-10-31 14:29:18 -04:00
connection.h Merge branch 'morestats4' into morestats5 2013-10-28 12:09:42 +01:00
control.c Merge branch 'morestats4' into morestats5 2013-10-28 12:09:42 +01:00
control.h Merge branch 'morestats4' into morestats5 2013-10-28 12:09:42 +01:00
cpuworker.c collect and log statistics about onionskins received/processed 2013-09-05 01:44:52 -04:00
cpuworker.h Merge branch 'time_based_onionqueue_v2' of ssh://git-rw.torproject.org/nickm/tor 2013-01-24 08:10:12 -08:00
directory.c Merge remote-tracking branch 'origin/maint-0.2.4' 2013-10-08 13:38:47 -04:00
directory.h Tougher validation for parsing urls from HTTP headers. Fixes #2767. 2013-09-03 01:14:43 +01:00
dirserv.c A Bridge Authority should compute flag thresholds 2013-10-21 17:49:33 +00:00
dirserv.h A Bridge Authority should compute flag thresholds 2013-10-21 17:49:33 +00:00
dirvote.c Merge remote-tracking branch 'origin/maint-0.2.4' 2013-12-17 13:18:00 -05:00
dirvote.h Completely refactor how FILENAME_PRIVATE works 2013-07-10 15:20:10 -04:00
dns.c Fix compilation with libevent 1 2013-09-19 20:25:05 -04:00
dns.h Update the copyright date to 201. 2013-01-16 01:54:56 -05:00
dnsserv.c When launching a resolve request on behalf of an AF_UNIX control, omit the address field of the new entry connection. Fixes bug 8639. 2013-05-31 15:35:51 -07:00
dnsserv.h Fix some wide lines 2013-03-18 15:39:11 -04:00
entrynodes.c Fix get_configured_bridge_by_addr_port_digest(.,.,NULL) 2013-12-09 11:22:22 -05:00
entrynodes.h Merge remote-tracking branch 'public/bug5018' 2013-10-29 01:29:59 -04:00
eventdns_tor.h Update the copyright date to 201. 2013-01-16 01:54:56 -05:00
ext_orport.c Fix some #5040 bugs found by Nick's tests. 2013-08-15 12:03:38 -04:00
ext_orport.h Write some free_all functions to free the auth. cookies. 2013-08-15 12:03:38 -04:00
fp_pair.c Implement fp_pair_map_t 2013-05-09 10:54:55 -07:00
fp_pair.h Implement fp_pair_map_t 2013-05-09 10:54:55 -07:00
geoip.c Report complete directory request statistics on bridges. 2013-12-18 18:02:10 +01:00
geoip.h Write extra-info bridge-ip-transports lines. 2013-07-18 14:59:57 -04:00
hibernate.c Tweak/cleanup 5526 fix. 2013-08-21 13:41:53 -04:00
hibernate.h Print accounting information in heartbeat messages. 2013-08-21 13:26:57 -04:00
include.am Move pathbias functions into a new file. 2013-10-31 14:17:49 -04:00
main.c Merge branch 'backtrace_squashed' 2013-11-18 11:00:16 -05:00
main.h White-box tests for the succeeding case of ext_or_port handshake. 2013-08-15 12:03:37 -04:00
Makefile.nmake Merge bug5595-v2-squashed into maint-0.2.4 2013-05-10 19:39:48 -07:00
microdesc.c Merge remote-tracking branch 'origin/maint-0.2.4' 2013-12-17 13:54:02 -05:00
microdesc.h Log fname:lineno in log messages for #7164 2013-03-13 10:42:58 -04:00
networkstatus.c A Bridge Authority should compute flag thresholds 2013-10-21 17:49:33 +00:00
networkstatus.h Remove some totally unused functions 2013-02-23 23:31:31 -05:00
nodelist.c Report bootstrapping progress correctly when downloading microdescs 2013-10-10 21:39:21 -04:00
nodelist.h On END_REASON_EXITPOLICY, mark circuit as unusable for that address. 2013-03-11 23:37:47 -04:00
ntmain.c Fix a windows compilation warning from 4647 branch 2013-09-13 13:10:17 -04:00
ntmain.h Update the copyright date to 201. 2013-01-16 01:54:56 -05:00
onion_fast.c fix typos 2013-08-23 21:43:57 -04:00
onion_fast.h Wrap more macro definitions in (parentheses) 2013-02-09 00:16:04 -05:00
onion_ntor.c Update the copyright date to 201. 2013-01-16 01:54:56 -05:00
onion_ntor.h Update the copyright date to 201. 2013-01-16 01:54:56 -05:00
onion_tap.c Update the copyright date to 201. 2013-01-16 01:54:56 -05:00
onion_tap.h Update the copyright date to 201. 2013-01-16 01:54:56 -05:00
onion.c Merge branch 'maint-0.2.4' 2013-09-05 02:34:58 -04:00
onion.h refactor and give it unit tests 2013-09-04 23:21:45 -04:00
or.h Merge branch 'finish_prop157' 2013-11-18 13:27:06 -05:00
policies.c On END_REASON_EXITPOLICY, mark circuit as unusable for that address. 2013-03-11 23:37:47 -04:00
policies.h Increase POLICY_BUF_LEN to 72 to accomodate IPv6 exit policy items. 2013-08-26 11:30:09 -04:00
reasons.c When we get an END cell before CONNECTED, don't report SOCKS success 2013-01-16 12:09:49 -05:00
reasons.h Update the copyright date to 201. 2013-01-16 01:54:56 -05:00
relay.c Remove 'struct timeval now' that was shadowing 'struct timeval now'. 2013-11-18 11:20:35 -05:00
relay.h Merge branch 'morestats4' into morestats5 2013-10-28 12:09:42 +01:00
rendclient.c Add missing includes for circpathbias.h 2013-10-31 14:33:34 -04:00
rendclient.h Update the copyright date to 201. 2013-01-16 01:54:56 -05:00
rendcommon.c Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4 2013-06-18 14:45:29 -04:00
rendcommon.h Remove some totally unused functions 2013-02-23 23:31:31 -05:00
rendmid.c Fix 8447: use %u to format circid_t. 2013-03-10 19:52:06 -04:00
rendmid.h Update the copyright date to 201. 2013-01-16 01:54:56 -05:00
rendservice.c Add missing includes for circpathbias.h 2013-10-31 14:33:34 -04:00
rendservice.h Fix an uninitialized-read when parsing v3 introduction requests. 2013-08-10 17:49:51 -04:00
rephist.c Merge branch 'maint-0.2.4' 2013-09-05 02:34:58 -04:00
rephist.h collect and log statistics about onionskins received/processed 2013-09-05 01:44:52 -04:00
replaycache.c Use size_t for length in replaycache_add_test_and_elapsed() 2013-08-04 09:29:22 -04:00
replaycache.h Use size_t for length in replaycache_add_test_and_elapsed() 2013-08-04 09:29:22 -04:00
router.c Merge remote-tracking branch 'origin/maint-0.2.4' 2013-11-10 12:24:12 -05:00
router.h Completely refactor how FILENAME_PRIVATE works 2013-07-10 15:20:10 -04:00
routerlist.c Merge branch 'bug1376' 2013-10-11 12:51:15 -04:00
routerlist.h Completely refactor how FILENAME_PRIVATE works 2013-07-10 15:20:10 -04:00
routerparse.c Merge remote-tracking branch 'origin/maint-0.2.4' 2013-12-17 13:18:00 -05:00
routerparse.h Merge remote-tracking branch 'public/bug10409_023' into maint-0.2.4 2013-12-17 13:15:45 -05:00
routerset.c Fix typos in a few log messages 2013-03-10 22:59:19 -04:00
routerset.h When excluding nodes by country, exclude {??} and {A1} too 2013-01-17 18:07:36 -05:00
statefile.c Whoops; make or_state_validate conform to validate_fn_t. 2013-09-13 12:56:14 -04:00
statefile.h Also test that server transports get written to Tor's state. 2013-08-05 21:05:39 +03:00
status.c Tweak/cleanup 5526 fix. 2013-08-21 13:41:53 -04:00
status.h Tweak/cleanup 5526 fix. 2013-08-21 13:41:53 -04:00
tor_main.c Fix a comment in tor_main.c 2013-02-25 03:24:53 -05:00
transports.c Fix an always-true assert in PT code. 2013-10-29 22:49:37 +00:00
transports.h Merge branch 'bug9288_rebased' 2013-07-31 13:51:15 -04:00