mirror of
https://gitlab.torproject.org/tpo/core/tor.git
synced 2024-11-13 14:43:46 +01:00
53a3b39da1
This is a big-ish patch, but it's very straightforward. Under this
clang warning, we're not actually allowed to have a global variable
without a previous extern declaration for it. The cases where we
violated this rule fall into three roughly equal groups:
* Stuff that should have been static.
* Stuff that was global but where the extern was local to some
other C file.
* Stuff that was only global when built for the unit tests, that
needed a conditional extern in the headers.
The first two were IMO genuine problems; the last is a wart of how
we build tests.
39 lines
920 B
C
39 lines
920 B
C
/* Copyright 2001-2004 Roger Dingledine.
|
|
* Copyright (c) 2004-2006, Roger Dingledine, Nick Mathewson.
|
|
* Copyright (c) 2007-2016, The Tor Project, Inc. */
|
|
/* See LICENSE for licensing information */
|
|
|
|
extern const char tor_git_revision[];
|
|
|
|
/** String describing which Tor Git repository version the source was
|
|
* built from. This string is generated by a bit of shell kludging in
|
|
* src/or/include.am, and is usually right.
|
|
*/
|
|
const char tor_git_revision[] =
|
|
#ifndef _MSC_VER
|
|
#include "micro-revision.i"
|
|
#endif
|
|
"";
|
|
|
|
/**
|
|
* \file tor_main.c
|
|
* \brief Stub module containing a main() function. Allows unit
|
|
* test binary to link against main.c.
|
|
**/
|
|
|
|
int tor_main(int argc, char *argv[]);
|
|
|
|
/** We keep main() in a separate file so that our unit tests can use
|
|
* functions from main.c)
|
|
*/
|
|
int
|
|
main(int argc, char *argv[])
|
|
{
|
|
int r = tor_main(argc, argv);
|
|
if (r < 0 || r > 255)
|
|
return 1;
|
|
else
|
|
return r;
|
|
}
|
|
|