mirror of
https://gitlab.torproject.org/tpo/core/tor.git
synced 2024-09-21 13:34:59 +02:00
959da6b7f2
Using strncpy meant that if listenaddress were ever >= sizeof(sockaddr_un.sun_path), we would fail to nul-terminate sun_path. This isn't a big deal: we never read sun_path, and the kernel is smart enough to reject the sockaddr_un if it isn't nul-terminated. Nonetheless, it's a dumb failure mode. Instead, we should reject addresses that don't fit in sockaddr_un.sun_path. Coverity found this; it's CID 428. Bugfix on 0.2.0.3-alpha.
6 lines
270 B
Plaintext
6 lines
270 B
Plaintext
o Minor bugfixes:
|
|
- Always NUL-terminate the sun_path field of a sockaddr_un before
|
|
passing it to the kernel. (Not a security issue: kernels are
|
|
smart enough to reject bad sockaddr_uns.) Found by Coverity; CID
|
|
# 428. Bugfix on Tor 0.2.0.3-alpha.
|