tor/changes/bug20307
David Goulet 955d4b7abd circuit: Change close reasons from uint16_t to int
When marking for close a circuit, the reason value, a integer, was assigned to
a uint16_t converting any negative reasons (internal) to the wrong value. On
the HS side, this was causing the client to flag introduction points to be
unreachable as the internal reason was wrongfully converted to a positive
16bit value leading to flag 2 out of 3 intro points to be unreachable.

Fixes #20307 and partially fixes #21056

Signed-off-by: David Goulet <dgoulet@torproject.org>
2016-12-22 12:37:42 -05:00

8 lines
502 B
Plaintext

o Minor bugfixes (circuit, hidden service)
- When closing a circuit, the reason for doing so was assigned from a int
value to a uint16_t which is quite a problem for negative value that are
our internal reasons (ex: END_CIRC_REASON_IP_NOW_REDUNDANT). On the HS
side, this was causing introduction point to be flagged as unusable
because the reason wasn't the right one due to the bad conversion.
Partially fixes #21056 and fixes #20307; Bugfix on tor-0.2.8.1-alpha.