tor/changes
David Goulet 6507ecb7e8 hs: Fix the intro circuit max retry
Some parentheses were missing making the rend_max_intro_circs_per_period()
return a lower value than it was suppose to.

The calculation is that a service at most will open a number of intro points
that it wants which is 3 by default or HiddenServiceNumIntroductionPoints. Two
extra are launched for performance reason. Finally, this can happen twice for
two descriptors for the current and next time period.

From:
  2 * n_intro_wanted + 2

...which resulted in 8 for 3 intro points, this commit fixes it to:

  (n_intro_wanted + 2) * 2

... resulting in 12 possible intro point circuit which is the correct maximum
intro circuit allowed per period.

Last, this commit rate limits the the log message if we ever go above that
limit else over a INTRO_CIRC_RETRY_PERIOD, we can print it often!

Fixes #22159

Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-08-28 14:43:42 -04:00
..
.dummy Add a .dummy file in the changes directory to stop git from removing it 2015-05-11 11:41:48 -04:00
bug16082 Note that bw_accounting is obsoleted by values in the state file 2017-06-20 14:18:10 -04:00
bug19418 Make sure we always wind up checking i2d_*'s output. 2017-08-09 09:24:16 -04:00
bug20247 Allow setsockopt(IPV6_V6ONLY) in sandbox. 2017-07-05 13:09:21 -04:00
bug22159 hs: Fix the intro circuit max retry 2017-08-28 14:43:42 -04:00
bug22212 Changes file for Bug 22212. 2017-06-26 11:26:59 -04:00
bug22286 chages file on 22286 2017-08-08 10:09:54 -04:00
bug22347 Document key-pinning-journal 2017-06-16 14:26:50 -04:00
bug22349 Mark descriptors as undownloadable when dirserv_add_() rejects them 2017-06-27 12:01:46 -04:00
bug22356 Downgrade "assign_to_cpuworker failed" to INFO. 2017-06-19 15:24:33 -04:00
bug22400_01 Don't expand guard sample set unless consensus is "reasonably live" 2017-06-19 15:48:47 -04:00
bug22502_part1 add a changes file for 22626, 22628, and 22629 (parts of 22502) 2017-06-20 10:12:40 -04:00
bug22516 Permit the fchmod system call. 2017-06-16 14:03:02 -04:00
bug22520 Use LANG_ENGLISH in windows error messages 2017-07-07 13:12:45 -04:00
bug22636 Add a changes file for bug22636. 2017-07-17 21:44:59 +00:00
bug22669 Send the correct content-encoding when serving cached_dir_t objects 2017-06-20 11:26:51 -04:00
bug22670 If a _guessed_ compression method fails, it is never PROTOCOL_WARN. 2017-06-20 12:08:11 -04:00
bug22670_02 It should be a PROTOCOL_WARN when we have an incorrect content-encoding. 2017-06-20 12:08:11 -04:00
bug22670_03 If we successfully decompress an HTTP body, return immediately. 2017-06-20 12:08:12 -04:00
bug22672 Enforce the rule that COMPRESS_OK means progress was made. 2017-06-20 12:26:57 -04:00
bug22702 Add changes file for bug #22702. 2017-06-27 18:25:48 -04:00
bug22719 changes file for bug 22719 2017-06-27 10:31:03 -04:00
bug22720 Patch for 22720 from huyvq: exit(1) more often 2017-06-26 14:14:56 -04:00
bug22737 Fix an errant memset() into the middle of a struct in cell_pack(). 2017-06-27 10:47:20 -04:00
bug22751 Fix crash in LZMA module when the Sandbox is enabled. 2017-06-28 10:00:24 -04:00
bug22753 Consider the exit family when applying guard restrictions. 2017-06-29 09:57:00 -04:00
bug22789 Mention TROVE-2017-007 in changes file for 22789 2017-07-07 10:51:25 -04:00
bug22797 Always allow extra file descriptors when setting the connection maximum 2017-07-05 11:15:10 -04:00
bug22801 Fix -Wfloat-conversion C warnings on mingw in clamp_double_to_int64. 2017-07-03 10:59:31 -04:00
bug22803 Fix unit test memory leak in certs_ok_ed25519. 2017-07-05 15:42:25 -04:00
bug22830 Add a changes file for bug22830. 2017-07-13 18:16:22 +00:00
bug22883-config New configuration option MaxConsensusAgeForDiffs 2017-07-12 13:15:16 -04:00
bug22883-priority Queue consensus diffs at LOW priority. 2017-07-27 16:28:59 -04:00
bug22892 Restore openssl and libscrypt includes in test_crypto_slow.c 2017-07-12 09:23:15 -04:00
bug22915 Suppress clang4-specific -Wdouble-promotion warnings 2017-07-26 12:53:00 -04:00
bug22916_027 Fix compiler warnings with openssl-scrypt/libscrypt test on clang 2017-07-13 17:49:48 -04:00
bug22927 Fix zstd 1.3.0 trouble: Be more respectful of its state machine 2017-07-14 16:31:29 -04:00
bug23030_029 Fix build warnings from Coverity related to our BUG macro 2017-07-26 12:57:49 -04:00
bug23053 Fix a small memory leak when parsing unix: ports twice 2017-07-28 09:49:42 -04:00
bug23071 Fix the hs_ntor integration tests to work with the pysha3 module 2017-07-31 20:28:42 -04:00
bug23078 hs: Cleanup logging statement in hs_intropoint.c 2017-08-01 14:15:47 -04:00
bug23081 In ntmain, call set_main_thread() before running the loop. 2017-08-03 09:09:08 -04:00
bug23139 Fix a memory leak in consdiffmgr.c 2017-08-08 09:13:45 -04:00
bug23155 Use a single free-and-exit strategy in config_process_include. 2017-08-08 20:08:43 -04:00
bug23233 Fix triggerable BUG() when decoding hsv3 descriptors. 2017-08-21 19:16:45 +03:00
bug23291 changes file for bug 23291 2017-08-21 15:04:35 -04:00
diagnose_22752 Changes file for bug22752 diagnostics 2017-06-28 14:27:52 -04:00
geoip-august2017 Update geoip and geoip6 to the August 3 2017 database. 2017-08-03 10:00:54 +02:00
geoip-july2017 Update geoip and geoip6 to the July 4 2017 database. 2017-07-07 16:27:54 +02:00
geoip-june2017 Update geoip and geoip6 to the June 8 2017 database. 2017-06-09 15:47:49 +02:00
more-files Document more files in the datadirectory. 2017-06-19 09:57:57 -04:00
more-threads Always start with one additional worker thread 2017-07-27 16:28:59 -04:00
multi-priority Add support for multi-priority workqueues 2017-07-27 16:28:05 -04:00
new_requirement_pkgconfig Note that pkgconfig is now needed, and has been for a few releases. 2017-06-20 13:54:30 -04:00
task-22207 Add "fingerprint" line to bridge network status. 2017-06-11 10:21:36 +02:00
ticket22348 Improve the keypin failure message 2017-07-31 20:40:23 -04:00
ticket22870 Make consdiff tests pass on OS X too 2017-07-10 15:27:01 -04:00