tor/bug32673 at 56c54a66bdc01a9e8b857f22650ca88d8eff5466 - tor - Git with a cup of Datura seeds

nihilist/tor

mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-13 06:33:44 +01:00

Nick Mathewson 2985a6018f buf_read_from_tls: Return ERROR_MISC, not WANTWRITE, on BUG().

Fixes bug 32673; bugfix on 0.3.0.4-alpha.  We introduced these
checks in ee5471f9aa to help diagnose 21369, but we used "-1"
when "TOR_TLS_ERROR_MISC" would have been correct.  Found by opara.

I don't think that this is actually getting triggered in the wild,
but if it were, it could cause nasty behavior: spurious
WANTREAD/WANTWRITE returns have a way of turning into CPU-eating
busy-loops.

2020-01-29 08:50:03 -05:00

6 lines

315 B

Plaintext

Raw Blame History

   o Minor bugfixes (TLS bug handling):
     - When encountering a bug in buf_read_freom_tls(), return a
       "MISC" error code rather than "WANTWRITE".  This change might
       help avoid some CPU-wasting loops if the bug is ever triggered.
       Bug reported by opara.    Fixes bug 32673; bugfix on 0.3.0.4-alpha.