mirror of
https://gitlab.torproject.org/tpo/core/tor.git
synced 2024-09-23 14:34:58 +02:00
74c1e44746
It looks to be the case that Rust's standard allocator, jemalloc, is incompatible with sanitizers. The incompatibility, for whatever reason, seems to cause segfaults at runtime when jemalloc is linked with sanitizers. Without actually trying to figure out what's going on here this commit instead takes the hammer of "let's remove jemalloc when testing". The `tor_allocate` crate now by default switches to the system allocator (eventually this will want to be the tor allocator). Most crates then link to `tor_allocate` ot pick this up, but the `smartlist` crate had to manually switch to the system allocator in testing and the `external` crate had to be sure to link to `tor_allocate`. The final gotcha here is that this patch also switches to unconditionally passing `--target` to Cargo. For weird and arcane reasons passing `--target` with the host target of the compiler (which Cargo otherwise uses as the default) is different than not passing `--target` at all. This ensure that our custom `RUSTFLAGS` with sanitizer options doesn't make its way into build scripts, just the final testing artifacts.
28 lines
1.0 KiB
Bash
Executable File
28 lines
1.0 KiB
Bash
Executable File
#!/bin/sh
|
|
# Test all Rust crates
|
|
|
|
set -e
|
|
|
|
export LSAN_OPTIONS=suppressions=${abs_top_srcdir:-../../..}/src/test/rust_supp.txt
|
|
|
|
# When testing Cargo we pass a number of very specific linker flags down
|
|
# through Cargo. We do not, however, want these flags to affect things like
|
|
# build scripts, only the tests that we're compiling. To ensure this happens
|
|
# we unconditionally pass `--target` into Cargo, ensuring that `RUSTFLAGS` in
|
|
# the environment won't make their way into build scripts.
|
|
rustc_host=$(rustc -vV | grep host | sed 's/host: //')
|
|
|
|
for cargo_toml_dir in "${abs_top_srcdir:-../../..}"/src/rust/*; do
|
|
if [ -e "${cargo_toml_dir}/Cargo.toml" ]; then
|
|
cd "${abs_top_builddir:-../../..}/src/rust" && \
|
|
CARGO_TARGET_DIR="${abs_top_builddir:-../../..}/src/rust/target" \
|
|
"${CARGO:-cargo}" test ${CARGO_ONLINE-"--frozen"} \
|
|
--features "test_linking_hack" \
|
|
--target $rustc_host \
|
|
${EXTRA_CARGO_OPTIONS} \
|
|
--manifest-path "${cargo_toml_dir}/Cargo.toml" || exitcode=1
|
|
fi
|
|
done
|
|
|
|
exit $exitcode
|