tor/bug31810 at 33414e5494b56f3f677d022bfb4bb1ed99191032 - tor - Git with a cup of Datura seeds

nihilist/tor

mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-10 13:13:44 +01:00

Alexander Færøy 85b4a5c276 Handle errors from execve() in the Unix process backend more gracefully.

This patch removes a call to tor_assert_unreached() after execve()
failed. This assertion leads to the child process emitting a stack trace
on its standard output, which makes the error harder for the user to
demystify, since they think it is an internal error in Tor instead of
"just" being a "no such file or directory" error.

The process will now instead output "Error from child process: X" where
X is the stringified version of the errno value.

See: https://bugs.torproject.org/31810

2019-10-17 20:52:22 +02:00

5 lines

289 B

Plaintext

Raw Blame History

   o Minor bugfixes (process management):
     - Remove assertion in the Unix process backend. This assertion would trigger
       when a new process is spawned where the executable is not found leading to
       a stack trace from the child process. Fixes bug 31810; bugfix on 0.4.0.1-alpha.