mirror of
https://gitlab.torproject.org/tpo/core/tor.git
synced 2024-11-24 20:33:31 +01:00
9b344628ed
The underlying strtoX functions handle overflow by saturating and
setting errno to ERANGE. If the min/max arguments to the
tor_parse_* functions are equal to the minimum/maximum of the
underlying type, then with the old approach, we wouldn't treat a
too-large value as genuinely broken.
Found this while looking at bug 5786; bugfix on 19da1f36 (in Tor
0.0.9), which introduced these functions.
8 lines
477 B
Plaintext
8 lines
477 B
Plaintext
o Minor bugfixes:
|
|
- Make our number-parsing functions always treat too-large values
|
|
as an error, even when those values exceed the width of the
|
|
underlying type. Previously, if the caller provided these
|
|
functions with minima or maxima set to the extreme values of the
|
|
underlying integer type, these functions would return those
|
|
values on overflow rather than treating overflow as an error.
|
|
Fix for part of bug 5786; bugfix on Tor 0.0.9. |