tor/bug21027 at 1582adabbb13871bcf6f91be4fa8523aeb36f79a - tor - Git with a cup of Datura seeds

nihilist/tor

mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-24 12:23:32 +01:00

Nick Mathewson 1582adabbb Change approach to preventing duplicate guards.

Previously I'd made a bad assumption in the implementation of
prop271 in 0.3.0.1-alpha: I'd assumed that there couldn't be two
guards with the same identity.  That's true for non-bridges, but in
the bridge case, we allow two bridges to have the same ID if they
have different addr:port combinations -- in order to have the same
bridge ID running multiple PTs.

Fortunately, this assumption wasn't deeply ingrained: we stop
enforcing the "one guard per ID" rule in the bridge case, and
instead enforce "one guard per <id,addr,port>".

We also needed to tweak our implementation of
get_bridge_info_for_guard, since it made the same incorrect
assumption.

Fixes bug 21027; bugfix on 0.3.0.1-alpha.

2017-02-28 08:16:33 -05:00

9 lines

369 B

Plaintext

Raw Blame History

   o Major bugfixes (bridges):
     - When the same bridge is configured multiple times at different
       address:port combinations (but with the same identity), treat
       those bridge instances as separate guards. This allows clients to
       configure the same bridge with multiple pluggable transports, once
       again. Fixes bug 21027; bugfix on 0.3.0.1-alpha.