Merge branch 'ticket40637_047_01' into 'main'

relay: Keep geoip cache entry if connection attempts are seen Closes #40637 See merge request tpo/core/tor!609
test: Disable unit test causing issue with nightly package
2024-12-03 09:03:32 +01:00 · 2024-03-20 23:19:53 +00:00 · 2024-03-20 09:23:24 -04:00
2 changed files with 14 additions and 1 deletions
--- a/changes/ticket40918
+++ b/changes/ticket40918
@ -0,0 +1,3 @@
+  o Minor bugfix (relay, sandbox):
+    - Disable a sandbox unit test that is failing on Debian Sid breaking our
+      nightly packages. Fixes bug 40918; bugfix on 0.3.5.1-alpha.
--- a/src/test/test_sandbox.c
+++ b/src/test/test_sandbox.c
@ -377,9 +377,19 @@ struct testcase_t sandbox_tests[] = {
 #else
  SANDBOX_TEST_IN_SANDBOX(open_filename),
  SANDBOX_TEST_IN_SANDBOX(openat_filename),
-  SANDBOX_TEST_IN_SANDBOX(opendir_dirname),
 #endif /* defined(ENABLE_FRAGILE_HARDENING) */

+  /* Ok why... Quick answer is #40918. This has been failing on Debian SID
+   * making us unable to have nightly packages which is a problem as we have
+   * several relay operators using them and actively reporting us issues with
+   * them. This test fails due to the sandbox denying it.
+   *
+   * We are deprecating C-tor slowly and honestly, the Sandbox feature has
+   * always been a source of pain and unhappiness. Disable this as finding why,
+   * fixing it and hoping it doesn't come back will mostly be a waste of our
+   * time at this point. */
+  SANDBOX_TEST_SKIPPED(opendir_dirname),
+
  SANDBOX_TEST_IN_SANDBOX(chmod_filename),
  SANDBOX_TEST_IN_SANDBOX(chown_filename),
  SANDBOX_TEST_IN_SANDBOX(rename_filename),
Author	SHA1	Message	Date
David Goulet	d21d6f8d35	Merge branch 'ticket40637_047_01' into 'main' relay: Keep geoip cache entry if connection attempts are seen Closes #40637 See merge request tpo/core/tor!609	2024-03-20 23:19:53 +00:00
David Goulet	51ef4ce094	test: Disable unit test causing issue with nightly package Signed-off-by: David Goulet <dgoulet@torproject.org>	2024-03-20 09:23:24 -04:00