nihilist/tor - tor - Git with a cup of Datura seeds

mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-15 07:43:31 +01:00

Author	SHA1	Message	Date
Roger Dingledine	868d456c3b	make it so there is one place to edit for new dirservers, not two. svn:r6186	2006-03-18 22:37:27 +00:00
Roger Dingledine	cc37c2f71e	fix some typos svn:r6185	2006-03-18 09:29:05 +00:00
Roger Dingledine	67b61fe475	authdirs shouldn't complain about unreachability when they fetch a descriptor from somebody else. this is not the right time to increment the failure count. svn:r6184	2006-03-18 05:37:15 +00:00
Roger Dingledine	581795f41d	auth dir servers were only modifying a server's is_running field when they created a network status. so if nobody asked for a network status, they would never discover that any servers are is_running, so they could never build a circuit. svn:r6183	2006-03-18 01:24:04 +00:00
Roger Dingledine	cf6ba3e76f	let an authdir that's not a naming authdir start even if it doesn't have an approved-routers file. if it does, read it and parse it as usual. svn:r6182	2006-03-18 00:22:23 +00:00
Roger Dingledine	4f14826cb3	Actually, only v1 auth dir servers need to define recommendedversions. But versioning dirservers do need to cause recommendclientversions and recommendedserverversions to somehow be non-empty. svn:r6181	2006-03-17 23:25:40 +00:00
Roger Dingledine	c7839a17f5	when we're an auth dir server but don't claim to be a versioning auth dir server, don't demand that we define RecommendedVersions. svn:r6180	2006-03-17 23:21:42 +00:00
Roger Dingledine	51fc6799ad	right now we don't support entryguards on auth dirservers, but that doesn't mean we need to remind them every time they start up. svn:r6179	2006-03-17 23:19:51 +00:00
Roger Dingledine	817556315a	Implement router purposes, and don't choose a non-general purpose router when picking random nodes for a circuit. Also implement SETROUTERPURPOSE and modify +POSTDESCRIPTOR. This concludes bug 250 assuming it all works. svn:r6178	2006-03-17 22:08:59 +00:00
Roger Dingledine	7d141c6776	but i made the line too long svn:r6176	2006-03-17 19:25:36 +00:00
Roger Dingledine	f1bcc2d6f8	stop tricking server operators into thinking they got their torrc perfect, just because tor could build a circuit. svn:r6175	2006-03-17 19:20:07 +00:00
Nick Mathewson	053411e827	Comments: cleanups and additions. svn:r6174	2006-03-17 05:50:41 +00:00
Nick Mathewson	0f0e14c6e3	normalize whitespace. svn:r6173	2006-03-17 04:43:37 +00:00
Nick Mathewson	215e377224	Only warn about lack of name binding for self if we have tried downloading every networkstatus. svn:r6172	2006-03-17 04:41:57 +00:00
Roger Dingledine	9a5df4cef5	resume being printist: if the hostname contains non-printable characters, then fail. this time don't even bother telling the server operator about these cases, because what's he going to do? if it turns out that some significant population somewhere in the world uses non-printable hostnames and wants to use tor, then i hereby assume that they will contact us. svn:r6171	2006-03-15 23:36:57 +00:00
Roger Dingledine	8d1f65a222	quiet another entry guard log message svn:r6169	2006-03-15 22:48:48 +00:00
Roger Dingledine	e8fd871d8b	Stop being printist: just because our local platform doesn't consider an alleged destination to be printable doesn't mean nobody in the world will want to use it. svn:r6167	2006-03-15 19:17:34 +00:00
Nick Mathewson	13cf54b9c1	Interim fix for 272: Only warn that we are not named if we have status docs from some naming authorities. svn:r6166	2006-03-15 05:37:27 +00:00
Nick Mathewson	fb7b5545ce	Implement GETINFO(dir/server/foo); status will be harder. svn:r6165	2006-03-15 05:06:56 +00:00
Nick Mathewson	d0f24b1e46	(Missing header change) Do not warn about unknown servers in our family when they are given as hex digests. svn:r6164	2006-03-15 05:06:26 +00:00
Nick Mathewson	3c0a5f6365	Do not warn about unknown servers in our family when they are given as hex digests. svn:r6163	2006-03-15 05:04:11 +00:00
Roger Dingledine	903183ea28	if we as a directory mirror don't know of any v1 directory authorities, then don't try to cache any v1 directories. svn:r6162	2006-03-15 00:10:13 +00:00
Peter Palfrader	a4ec555228	change INET_NTOA_BUF_LEN+1 to INET_NTOA_BUF_LEN add a comment in a few places where we add weird numbers to buffer lengths svn:r6161	2006-03-14 23:40:37 +00:00
Peter Palfrader	866f6293ff	I wonder what an internal internet protocol is svn:r6159	2006-03-14 22:52:20 +00:00
Peter Palfrader	86a964d868	When we try to be a server and Address is not explicitly set and our hostname resolves to a private IP address, try to use an interface address if it has a public address. svn:r6158	2006-03-14 22:51:15 +00:00
Peter Palfrader	2ef8f772a1	Fix an off-by-one buffer size in dirserv.c that magically never hit our three authorities but broke sjmurdoch's own tor network. svn:r6157	2006-03-14 22:43:52 +00:00
Roger Dingledine	499eeced44	when event_add or event_del fail, tell us why. svn:r6156	2006-03-13 19:33:46 +00:00
Peter Palfrader	ebfb3fea6d	Fix minor semantic error with no real effect: we were doing "is_internal_IP(htonl(in.s_addr))" but in.s_addr is in network order and is_internal_IP wants host order. Change to "is_internal_IP(ntohl(in.s_addr))". svn:r6155	2006-03-13 19:09:52 +00:00
Nick Mathewson	dad60905a8	Be a little more careful when our calculated bandwidth is so high that we could never ever exhaust our bandwidth limit. This should resolve bug 130. svn:r6146	2006-03-13 01:06:55 +00:00
Nick Mathewson	bd8ffccae7	More cleanups noticed by weasel; also, remove macros that nobody uses. svn:r6143	2006-03-12 23:31:16 +00:00
Nick Mathewson	474c60b743	Cleanup on time-relaqted constants. New conventions: 1) Surround all constants by (parens), whether we'll be using them in a denominator or not. 2) Express all time periods as products (246060), not as multiplied-out constants (86400). 3) Comments like "(6060) / one hour /" are as pointless as comments like "c = a + b; / set c to the sum of a and b /". Remove them. 4) All time periods should be #defined constants, not given inline. 5) All time periods should have doxygen comments. 6) All time periods, unless specified, are in seconds. It's not necessary to say so. To summarize, the old (lack of) style would allow: #define FOO_RETRY_INTERVAL 6060 /* one hour (seconds) / next_try = now + 3600; The new style is: /* How often do we reattempt foo? / #define FOO_RETRY_INTERVAL (6060) next_try = now + RETRY_INTERVAL; svn:r6142	2006-03-12 22:48:18 +00:00
Roger Dingledine	b67a5ba498	lower the reachability timeout, so we're more likely to act quickly if a server stops being reachable. svn:r6141	2006-03-12 21:24:03 +00:00
Roger Dingledine	1fc5eb329b	We screwed up in anticipating how to add new dirservers: Old servers won't realize they're supposed to stay connected to the new dirservers, so they'll expire connections to them, but that means the dirservers will list them as unreachable. So the fix is to stop requiring an open connection when deciding if a server is reachable. This makes us slightly less accurate, but at least it will work. svn:r6140	2006-03-12 20:57:52 +00:00
Roger Dingledine	ef447507ff	a better clean-up svn:r6139	2006-03-12 20:51:02 +00:00
Roger Dingledine	a98b25137c	and another fix svn:r6138	2006-03-12 20:48:59 +00:00
Roger Dingledine	98476c71d2	make tor --verify-config closer to working svn:r6137	2006-03-12 20:46:00 +00:00
Roger Dingledine	a4da44c2b9	Now do address rewriting when the controller asks us to attach to a particular circuit too. This will let Blossom specify "moria2.exit" without having to learn what moria2's IP address is. It may also cause other controller authors some angst. Let us know. svn:r6136	2006-03-12 05:04:16 +00:00
Roger Dingledine	d80d5370e0	when we get funny-looking lines on our dirport, shut up about it. svn:r6135	2006-03-12 04:36:17 +00:00
Roger Dingledine	b5c6a990d3	fix assert while attachstream'ing a connect-wait or resolve-wait stream. svn:r6134	2006-03-12 04:33:29 +00:00
Roger Dingledine	80f0492a65	avoid shadowing a variable so we don't get sad later. svn:r6133	2006-03-12 04:07:21 +00:00
Roger Dingledine	0bd46086c3	fix bug reported by gozu: if we get a linelist or linelist_s config option from the torrc and it has no value, warn and skip rather than silently resetting it to its default. svn:r6125	2006-03-11 18:40:33 +00:00
Roger Dingledine	c8e2a051ac	huge warning sign for esc_router_info() svn:r6124	2006-03-11 17:52:55 +00:00
Nick Mathewson	4d3e709c4b	Use escaped() for remaining cases. svn:r6117	2006-03-11 02:21:30 +00:00
Roger Dingledine	86a72f73b9	make entry guard logs even quieter svn:r6116	2006-03-10 16:51:26 +00:00
Roger Dingledine	e11f900a2a	stop printing a log message at every iteration through the event loop when holding open a conn for flushing but it doesn't want to flush any more bytes yet. svn:r6114	2006-03-09 06:34:33 +00:00
Roger Dingledine	5f8d26496d	Let the controller attachstream conns that are in connect_wait or resolve_wait: we detach them first and then act as before. Resolves bug 264. svn:r6112	2006-03-09 06:29:53 +00:00
Roger Dingledine	82d1fdbaea	don't abandon entry guards until they've been dead a whole month. make entry guard log messages quieter. svn:r6106	2006-03-09 00:55:55 +00:00
Roger Dingledine	44107f6ec4	Implement NEWNYM. Nick, did I do a bad thing? svn:r6105	2006-03-09 00:18:16 +00:00
Roger Dingledine	0f39033b9f	clean up typo svn:r6103	2006-03-09 00:10:28 +00:00
Roger Dingledine	946317ae13	start using OR_CONN_EVENT_NEW. also fixes a seg fault in tor (bug 261). svn:r6101	2006-03-08 22:29:08 +00:00
Roger Dingledine	8db1e363c9	remove some redundant code now that we compress exit policies after parsing them svn:r6099	2006-03-08 19:34:34 +00:00
Nick Mathewson	1ce3713889	Possible bug 265 fix: authorities must be more strict than clients about age of acceptable routers; make routers publish every 12 hours; client ROUTER_MAX_AGE must be greater than NETWORKSTATUS_MAX_AGE+authoirty ROUTER_MAX_AGE. svn:r6095	2006-03-08 06:29:52 +00:00
Roger Dingledine	a2d71f917e	mark bug 261 svn:r6089	2006-03-06 19:47:54 +00:00
Nick Mathewson	5dc5380984	Add some "to-be-safe" escaped() wrappers to log statements in rend*.c, though I am not 100% sure that each one is necessary. svn:r6088	2006-03-06 00:25:39 +00:00
Nick Mathewson	5777ee0e1a	Add some functions to escape values from the network before sending them to the log. Use them everywhere except for routerinfo->plaftorm, routerinfo->contact_info, and rend*.c. (need sleep now) svn:r6087	2006-03-05 09:50:26 +00:00
Nick Mathewson	6a4e304d9e	Allow private:* in routerdescs; not generated yet (because older Tors do not understand it); needs testing. svn:r6086	2006-03-05 05:27:59 +00:00
Roger Dingledine	329af979e0	Add a new circuit purpose 'controller' to let the controller ask for a circuit that Tor won't try to use. Extend the EXTENDCIRCUIT controller command to let you specify the purpose if you're starting a new circuit. Add a new SETCIRCUITPURPOSE controller command to let you change a circuit's purpose after it's been created. svn:r6075	2006-02-23 06:51:09 +00:00
Roger Dingledine	2bfd2a2400	clean up a log message svn:r6074	2006-02-21 17:54:56 +00:00
Roger Dingledine	25ed4b66e3	be quieter about hidserv descriptors that are too old or too new. we can't do anything about them anyway. svn:r6073	2006-02-21 06:23:57 +00:00
Roger Dingledine	89b07b458b	i missed the other half of that grammar fix svn:r6058	2006-02-21 03:55:47 +00:00
Roger Dingledine	16f265fa0d	when saveconf fails in controller v1, we were returning a malformed error string. svn:r6053	2006-02-20 01:24:26 +00:00
Roger Dingledine	498c13b4df	make the NoPublish option obsolete. svn:r6052	2006-02-20 01:21:48 +00:00
Roger Dingledine	0408adb728	tweak svn:r6051	2006-02-20 01:15:38 +00:00
Roger Dingledine	276a7bd038	the other half of fixing bug 257. catch an error in more places. svn:r6050	2006-02-20 01:06:27 +00:00
Roger Dingledine	57bcdcecf1	try to address bug 257: if rename() fails during saveconf, tell the controller. svn:r6049	2006-02-19 23:12:26 +00:00
Roger Dingledine	6a52867846	New config options to address bug 251: FetchServerDescriptors and FetchHidServDescriptors for whether to fetch server info and hidserv info or let the controller do it, and also PublishServerDescriptor and PublishHidServDescriptors. Add AllDirActionsPrivate undocumented option -- if you set it, you'll need the controller to bootstrap you enough to build your first circuits. svn:r6047	2006-02-19 22:02:02 +00:00
Peter Palfrader	c4f389420c	Improve the "we have been waiting for 1140377851 seconds" log svn:r6046	2006-02-19 19:44:09 +00:00
Roger Dingledine	266254f42b	clean up the Reachable*Addresses changes svn:r6041	2006-02-19 08:31:47 +00:00
Roger Dingledine	a9fcf4ced2	this is why you're not supposed to cut-and-paste code svn:r6037	2006-02-18 06:46:01 +00:00
Peter Palfrader	aa5443551d	Make it compile with VC7. It does not yet link. svn:r6033	2006-02-18 02:02:21 +00:00
Roger Dingledine	42cd0dcde8	fix typo found in phobos's logs svn:r6020	2006-02-15 03:47:38 +00:00
Roger Dingledine	f6d80d60e0	don't warn when we get a server descriptor from the controller but it's too old. that's not something tor should fix. svn:r6019	2006-02-15 03:01:53 +00:00
Peter Palfrader	c7f2970777	Just because both are obsolete does not mean we prefer the newer svn:r6016	2006-02-14 17:48:51 +00:00
Peter Palfrader	0bab094d5d	Explain why we only expire open connections svn:r6015	2006-02-14 17:30:04 +00:00
Roger Dingledine	ae249fc5a3	document the frequency for reachability testing by the directory authorities. svn:r6014	2006-02-14 04:33:59 +00:00
Peter Palfrader	84295f9f43	Do not mark connections obsolete before they have done their TLS handshake or are at least 60 seconds old svn:r6013	2006-02-14 04:23:05 +00:00
Peter Palfrader	761da5b97f	Our connection_or_get_by_identity_digest() was slightly wrong. If best didn't have any circuits on it, but conn had circuits, we would not make conn our new best unless it was also newer. Also, restructure the code a bit to maybe make it clearer. svn:r6012	2006-02-14 00:08:19 +00:00
Peter Palfrader	0cc2390f8c	Warn if ReachableAddresses is set when also ReachableDirAddresses and ReachableORAddresses are set. svn:r6010	2006-02-13 22:29:37 +00:00
Peter Palfrader	5eea6c76df	Split ReachableAddresses into ReachableDirAddresses and ReachableORAddresses svn:r6009	2006-02-13 21:17:20 +00:00
Roger Dingledine	259c65ab08	the last of the log convention conversion. finally. svn:r6005	2006-02-13 10:33:00 +00:00
Roger Dingledine	aa63a84fe1	the things we do for our windows users. i hope they appreciate it. svn:r6004	2006-02-13 09:37:53 +00:00
Roger Dingledine	d113b75da6	more log conversions. whee. svn:r6003	2006-02-13 09:02:35 +00:00
Roger Dingledine	36484f873a	convert some more source files to the new log convention svn:r6002	2006-02-13 08:28:42 +00:00
Roger Dingledine	7d80921afa	resolve too-long-lines svn:r6001	2006-02-13 08:22:57 +00:00
Nick Mathewson	2a4555fedd	Style on config_addr_policy_intersectes, which looks ok to me. svn:r5998	2006-02-13 07:16:32 +00:00
Roger Dingledine	350313d77a	Let the users set ControlListenAddress in the torrc. This can be dangerous, but there are some cases (like a secured LAN) where it makes sense. svn:r5997	2006-02-13 06:25:16 +00:00
Peter Palfrader	6c4d873591	Compress exit policies even more. please review svn:r5995	2006-02-13 01:54:31 +00:00
Nick Mathewson	2cc66125b8	try to fix bug with spurious "everything is broken" warning svn:r5994	2006-02-13 00:26:43 +00:00
Roger Dingledine	b7781ea208	bugfix: we were ignoring the IS_FAST flag in the directory status, meaning we were willing to pick trivial-bandwidth nodes for "fast" connections. svn:r5992	2006-02-13 00:09:30 +00:00
Nick Mathewson	dba155ecff	Generate 18.0.0.0/8 address policy format in descs when we can; warn when the mask is not reducible to a bit-prefix. svn:r5991	2006-02-12 23:58:22 +00:00
Roger Dingledine	b99f903e34	and don't warn when it happens here either, unless the user wants to hear it. svn:r5990	2006-02-12 23:44:02 +00:00
Roger Dingledine	97571a1cb4	don't tell ordinary users about broken directory servers. it's a shame that they're broken, but most people are just confused by the warning. svn:r5988	2006-02-12 23:31:47 +00:00
Nick Mathewson	98ec124c6a	Drop redundant exit policy entries, not just identical ones. svn:r5987	2006-02-12 22:59:38 +00:00
Nick Mathewson	e7b2d5cd47	Retain unrecognized options in state file, so that we can be forward-compatible. svn:r5985	2006-02-12 22:28:30 +00:00
Nick Mathewson	ae4f0467c8	enforce whitespace style svn:r5984	2006-02-12 22:27:09 +00:00
Roger Dingledine	3c4e68488b	Clients now honor the "guard" flag in the router status when picking entry guards, rather than looking at is_fast or is_stable. Now dirservers can change how they define it and clients will automatically use their new definition. svn:r5979	2006-02-12 03:43:39 +00:00
Roger Dingledine	b5ac6fc707	more helpful log message when running servers on obsolete windows. svn:r5975	2006-02-12 00:14:58 +00:00
Roger Dingledine	094ccd34a9	bump up the period for forcing a hidden service descriptor upload from 20 minutes to 1 hour. svn:r5972	2006-02-12 00:12:36 +00:00
Roger Dingledine	981815146a	compress exit policies even more -- look for duplicate lines and remove them. svn:r5971	2006-02-12 00:03:06 +00:00
Roger Dingledine	6c093a17a9	bugfix in config_cmp_addr_policies() -- we were treating a pair of exit policies if they were equal even if one said accept and the other said reject. svn:r5970	2006-02-11 23:47:24 +00:00
Roger Dingledine	fdf18fbbdb	stop leaking that svn:r5969	2006-02-11 23:16:13 +00:00
Roger Dingledine	e847085c04	When a client asks for an old-style directory and our write bucket is empty, don't give it to him. This way small servers can continue to serve the directory sometimes, without getting overloaded. svn:r5968	2006-02-11 23:15:40 +00:00
Nick Mathewson	f1b91924b2	Keep running if we ask for an impossible stdout log; just warn. svn:r5964	2006-02-11 21:56:03 +00:00
Nick Mathewson	1dc90be4f0	Retry pending server downloads as well as pending networkstatus downloads when we unexpectedly get an app connection svn:r5962	2006-02-11 21:29:12 +00:00
Nick Mathewson	91847124bf	Warn if running obsolete windows as a server. svn:r5961	2006-02-11 21:26:40 +00:00
Roger Dingledine	85a64b4fd0	get our grammar right when complaining about un-recommended versions svn:r5950	2006-02-09 06:08:59 +00:00
Roger Dingledine	5f051574d5	Happy new year! svn:r5949	2006-02-09 05:46:49 +00:00
Roger Dingledine	fd0fcdf17c	stop calling it a "libevent poll" -- the word "poll" has other meaning in this context that are confusing. svn:r5936	2006-02-09 03:09:52 +00:00
Roger Dingledine	dbea401305	correct the comments that don't realize it's the opposite svn:r5934	2006-02-09 02:59:26 +00:00
Roger Dingledine	31f2705d9a	and make sure that never happens again svn:r5932	2006-02-09 02:42:33 +00:00
Roger Dingledine	2c221dd8db	fix bug 245: When modifying the orconn_circid_map map, we would sometimes decrement conn->n_circuits even when there was no circuit originally. This caused conn->n_circuits to go negative. We noticed this because we were checking if connections can be closed based on conn->n_circuits == 0, so we were never closing any connection that had ever had a circuit on it. svn:r5931	2006-02-09 02:42:15 +00:00
Roger Dingledine	1c596156aa	tweak comment svn:r5930	2006-02-09 00:08:23 +00:00
Nick Mathewson	e5a574ce2e	Move "sort list of versions" logic into routerparse.c; make version-checking code say which versions it would have accepted. (not tested.) svn:r5927	2006-02-06 05:04:27 +00:00
Nick Mathewson	2bb4fd24de	char *x = "y"; is not good C. svn:r5926	2006-02-06 05:01:44 +00:00
Nick Mathewson	50e1005327	Only v1 authorities get hidden service descriptors with current protocol svn:r5924	2006-02-06 04:56:18 +00:00
Nick Mathewson	97bff8edaa	Fix a const-non-const warning svn:r5923	2006-02-06 04:55:27 +00:00
Roger Dingledine	a9c87fe251	more typos and nits svn:r5918	2006-02-05 05:28:52 +00:00
Nick Mathewson	157e6a025a	Stupid cut-and-paste bug. svn:r5917	2006-02-05 05:11:24 +00:00
Roger Dingledine	555a64e06d	as soon as we've fetched some more directory info, that's time to think about downloading more server descriptors. this way we don't have a 10 second pause in initial bootstrapping. svn:r5916	2006-02-05 03:42:34 +00:00
Roger Dingledine	d602d0d298	cosmetic fix svn:r5915	2006-02-05 03:42:04 +00:00
Roger Dingledine	640882c76c	clean up tabs and wide-lines from weasel's commit svn:r5914	2006-02-05 03:23:16 +00:00
Roger Dingledine	6535087845	when building v2 statuses or v1 running-routers, don't admit the existence of descriptors older than a day. we still cache them in case anybody asks, but we don't actively mention them. svn:r5913	2006-02-05 02:33:40 +00:00
Roger Dingledine	53f86cdf5d	fix bug: we were caching the newest descriptor for each server, well, forever. i imagine this just keeps growing in size. svn:r5912	2006-02-05 02:07:28 +00:00
Roger Dingledine	4c1fa73c7e	typos and nits svn:r5911	2006-02-05 01:57:27 +00:00
Roger Dingledine	a53a73a782	forward-port the part where ordinary users try to fetch directories less often. not critical but might as well stay in sync with stable. svn:r5910	2006-02-05 01:57:07 +00:00
Roger Dingledine	640c555f02	Fix a major load balance bug: we were round-robining in 16 KB chunks, and servers with bandwidthrate of 20 KB, while downloading a 600 KB directory, would starve their other connections. Now we try to be a bit more fair. svn:r5906	2006-02-04 08:58:51 +00:00
Peter Palfrader	94fb3f06b3	Fix compiler warning on 64 bit archs svn:r5903	2006-02-03 22:26:43 +00:00
Peter Palfrader	390bbb0a0c	Try to make tor work better through squid: Limit number of descriptors we fetch to 96 (was 128 previously). We limit this number even when we do not have a http proxy explicitly configured as some people mistakenly believe transparent proxies are a neat idea. svn:r5901	2006-02-03 15:17:48 +00:00
Roger Dingledine	a1dd751f30	when we fail to bind a listener, try to provide a more useful log msg. svn:r5900	2006-02-03 12:26:10 +00:00
Roger Dingledine	1800fbe486	don't warn when we receive a 503 from a dirserver/cache -- this will pave the way for them being able to tell us to screw off if they're busy. svn:r5898	2006-02-03 12:08:31 +00:00
Roger Dingledine	0fadf0aad6	Fix bug 225: now "attachstream 0" treats conn like it just connected, doing address remapping, handling .exit and .onion idioms, and so on. Now we are more uniform in making sure that the controller hears about all new connections, and making sure it hears when they close. svn:r5897	2006-02-03 11:37:19 +00:00
Roger Dingledine	92ef9e37e7	Add a new config option ExitPolicyRejectPrivate which defaults to 1. This means all exit policies will begin with rejecting private addresses, unless the server operator explicitly turns it off. Also, make our code to remove redundancies in the exit policy smarter, so it can detect "reject foo, reject bar, reject *" patterns. Lastly, we can get rid of the "exit policy implicitly accepts" code, since we make everything more explicit now. svn:r5888	2006-02-01 03:53:52 +00:00
Roger Dingledine	bdba6e42dc	avoid a minor confusing log message svn:r5887	2006-02-01 03:05:52 +00:00
Peter Palfrader	bf514e5dc5	Try to fix policy_includes_addr_mask_implicitly() svn:r5886	2006-02-01 02:52:55 +00:00
Peter Palfrader	61ea27620a	Also catch 0/8 in exit_policy_implicitly_allows_local_networks() svn:r5885	2006-02-01 02:31:27 +00:00
Roger Dingledine	686508a04a	don't try to upload hidden service descriptors until we have established a circuit. svn:r5884	2006-02-01 02:19:46 +00:00
Roger Dingledine	e05d4e45d2	provide a more useful warn message when our onion queue gets full. svn:r5881	2006-01-31 08:17:00 +00:00
Roger Dingledine	8fc44169e5	only start testing reachability once we've established a circuit. this will make startup on dirservers less noisy. it may also break things in subtle ways. svn:r5878	2006-01-29 01:11:41 +00:00
Roger Dingledine	f8b9a8d457	bump the default bandwidthrate to 3 MB, and burst to 6 MB svn:r5874	2006-01-28 08:28:15 +00:00
Roger Dingledine	35f91db15f	a slightly more useful message when you get a sighup svn:r5869	2006-01-26 19:11:06 +00:00
Nick Mathewson	bfe285be61	Add a missing printf arg svn:r5861	2006-01-24 04:01:13 +00:00
Roger Dingledine	2eabf190e9	make it louder when we're running an unrecommended version. also, we need to tell them what versions are recommended. i'll add that to the todo. svn:r5859	2006-01-24 03:45:58 +00:00
Nick Mathewson	9f42c9d650	Make dirservers generate a separate "guard" flag to mean, "would make a good entry guard". Make clients parse it and vote on it. svn:r5856	2006-01-24 00:31:16 +00:00
Roger Dingledine	1756ebdd4e	Jan 23 02:39:44.856 [warn] rend_mid_rendezvous(): Rejecting RENDEZVOUS1 cell with unrecognized rendezvous cookie AFC097FD. This is not anything that the server admin can deal with, so don't complain this loudly. svn:r5851	2006-01-23 09:26:22 +00:00
Roger Dingledine	de13ddd26f	Stop complaining loudly whenever some poor client falls off the network before we finish writing to him. svn:r5850	2006-01-23 09:23:04 +00:00
Roger Dingledine	b9540285af	remove unused code svn:r5847	2006-01-20 20:54:42 +00:00
Roger Dingledine	f6084cf831	Jan 18 18:42:05.671 [debug] Encountered eof Jan 18 18:42:05.671 [debug] Got data, not eof. Leaving on inbuf. that's not very smart. svn:r5843	2006-01-19 11:21:28 +00:00
Roger Dingledine	4a66f5a896	when the controller asks for a signal we don't recognize, don't include the whitespace/newline/etc in our complaint. svn:r5841	2006-01-19 02:21:24 +00:00
Roger Dingledine	d682c84e79	attempted patch for bug 220: don't assert when we've tried all the intro points for a hidden service and we try fetching the service descriptor again. svn:r5838	2006-01-17 04:16:59 +00:00
Roger Dingledine	d5acef191c	add another assert to make sure we're not scribbling on the stack. svn:r5837	2006-01-17 04:14:04 +00:00
Roger Dingledine	cca9a2f7b0	oh, and the other bits of the commit svn:r5836	2006-01-17 04:03:23 +00:00
Roger Dingledine	21be9dc3c0	when you tried to set orport through the controller, it would trigger an assert because you hadn't made your onion keys yet you wanted to launch cpu workers. now init keys first, reset uptime, and tell the user that we're starting the reachability testing. svn:r5835	2006-01-17 04:01:32 +00:00
Roger Dingledine	76f1b7415b	try to detect an assert error earlier svn:r5834	2006-01-17 02:31:04 +00:00
Nick Mathewson	1057516a07	Clients should not download descriptors for non-running descriptors. svn:r5830	2006-01-16 20:52:30 +00:00
Roger Dingledine	f0d4b3d18f	turn crypto hardware acceleration off by default, until we find somebody smart who can test it for us. svn:r5829	2006-01-16 20:08:33 +00:00
Nick Mathewson	2dd566d5d5	Indirect access to the signed_descriptor field to make it easier to keep them lazily on disk. svn:r5827	2006-01-12 18:04:17 +00:00
Roger Dingledine	0e51d5d274	When the controller was submitting a descriptor, we were checking to make sure some network-status we had referred to it, and refusing it if not. This is bad for people who want to insert descriptors that aren't part of the current Tor network. Now we accept them, and also give a more useful warn message if we ask a dir mirror for a given descriptor and it gives us one we weren't expecting. svn:r5824	2006-01-12 03:43:39 +00:00
Roger Dingledine	54a7285e99	oh hey. we were hanging up on every tor client because he was obsolete as soon as he started. big oops. svn:r5807	2006-01-11 22:34:07 +00:00
Nick Mathewson	c562ca494a	add missing warning svn:r5806	2006-01-11 20:09:37 +00:00
Nick Mathewson	fefa34d525	Fix double-free of torrc_fname svn:r5805	2006-01-11 20:01:47 +00:00
Nick Mathewson	adbe0f0ada	Fix bug 240: dont dump descriptions when not dumping actual config lines. svn:r5804	2006-01-11 19:43:14 +00:00
Nick Mathewson	099b9ce2f9	Fix bug 230: add a rollback function to reverse all changes since the last mark_logs_temp(), and move log initialization into the two-phase part of option setting. svn:r5803	2006-01-11 19:40:14 +00:00
Roger Dingledine	5ca40affeb	we were leaking a smartlist every time we built a circuit svn:r5795	2006-01-11 04:14:10 +00:00
Nick Mathewson	d60faa7c93	Fix another memleak. I love you, valgrind! svn:r5794	2006-01-11 04:09:40 +00:00
Nick Mathewson	8907391ad6	Fix wide lines svn:r5793	2006-01-11 04:04:42 +00:00
Nick Mathewson	5c78c89471	Appease verbose gcc warning: make dirserv_compute_stable_uptime() static. svn:r5792	2006-01-11 03:59:55 +00:00
Roger Dingledine	284fe9cad5	if we learn that a down entry guard is up, count our working entry guards correctly when logging. svn:r5791	2006-01-11 03:58:59 +00:00
Nick Mathewson	eb78295e4e	Fix memory leak in routerlist_remove_old_routers(). svn:r5790	2006-01-11 03:58:07 +00:00
Nick Mathewson	6a9ca9e790	Convert some more ints to long longs in rephist.c, as suggested by windows compiler. svn:r5789	2006-01-11 03:57:01 +00:00
Roger Dingledine	d1baa0c4a6	we were leaking 3KB every time the entry guards changed, every time the controller called saveconf, and every 20 minutes. svn:r5788	2006-01-11 03:20:53 +00:00
Roger Dingledine	8f271f2f5a	we changed the name of AccountingBytesReadInInterval change its state file description too svn:r5785	2006-01-10 23:26:59 +00:00
Roger Dingledine	7d1f675c85	entry nodes are now entry guards. this is our last easy chance for a wholesale change. heave ho. svn:r5782	2006-01-10 22:42:44 +00:00
Roger Dingledine	210d9db54d	and even more so svn:r5776	2006-01-10 21:01:30 +00:00
Roger Dingledine	aea0a78254	make entry node logging slightly less chatty. still quite chatty. it's an alpha, that's ok. svn:r5775	2006-01-10 20:59:39 +00:00
Nick Mathewson	bef879540a	#undef FOO is cleaner than #define FOO_XX svn:r5774	2006-01-10 20:50:22 +00:00
Nick Mathewson	4a7ee9bd3d	Make unittests pass again. svn:r5773	2006-01-10 20:47:24 +00:00
Roger Dingledine	b2d79f278b	or_state_validate() needs an extra arg too or it will crash svn:r5772	2006-01-10 20:38:33 +00:00
Roger Dingledine	f4299f0f44	hack to address bug 238. needs a better fix, but not for 0.1.1.11. svn:r5771	2006-01-10 20:27:47 +00:00
Roger Dingledine	d114ea7125	implement getinfo desc/all-recent closes bug 237. svn:r5770	2006-01-10 20:09:31 +00:00
Roger Dingledine	f71273c216	fix bug 235 svn:r5768	2006-01-10 20:06:24 +00:00
Nick Mathewson	7fc62029d4	Refuse to use RunAsDaemon when torrc is a relative path. Fixes bug 229. svn:r5767	2006-01-10 20:00:20 +00:00
Nick Mathewson	e1d1ce3da8	Warn about actual offending hiddenservice* config option, now that more than one is possible. Closes bug 239. svn:r5766	2006-01-10 19:28:31 +00:00
Nick Mathewson	2fda7140e8	Fix bug 221 and bug 201: For 221, check return value from connection_add() when adding a rendezvous post connection. For 201, do not include a content-length 0 with a GET request. svn:r5765	2006-01-10 19:24:40 +00:00
Roger Dingledine	c8e6003412	balance the reachability testing so a smidgen of it happens every 10 seconds. this way we don't try to do 500 tls's at once every 20 minutes. svn:r5763	2006-01-10 07:21:01 +00:00
Nick Mathewson	43a4f8c7f3	Be more aggressive about throwing away expired router descriptors: they are of no use to anybody. Better still: dont serve expired descriptors by fingerprint. The only people who ask for them are busted 0.1.1.10 Tors that will throw them away and re-request them after 30 minutes. svn:r5762	2006-01-10 04:57:12 +00:00
Nick Mathewson	56c55c343e	When picking a random directory, prefer non-authorities if any are known. svn:r5761	2006-01-09 23:39:07 +00:00
Nick Mathewson	bec9b705cc	Instrument directory client bytes as well as server bytes. svn:r5760	2006-01-09 23:13:53 +00:00
Nick Mathewson	10100c4315	Make instrmentation code a little cleaner. svn:r5759	2006-01-08 22:19:41 +00:00
Roger Dingledine	fa05c1b21b	remove the loud logging of busted rendezvous descriptors svn:r5758	2006-01-08 22:16:30 +00:00
Roger Dingledine	6dcbbda43b	remove typo svn:r5757	2006-01-08 22:16:09 +00:00
Nick Mathewson	ff9cfa9644	Instrument how many directory bytes we are serving in what kind of request. svn:r5756	2006-01-08 22:09:54 +00:00
Nick Mathewson	5d709e8517	Fix bug in last commit. Also, fix bug 231: authorities should never treat their own descriptor changes as cosmetic. svn:r5755	2006-01-08 21:33:15 +00:00
Nick Mathewson	e30516f33f	Fix bug 236: caches should cache up to 16 unrecognized network-status docs. svn:r5754	2006-01-08 21:26:33 +00:00
Roger Dingledine	1dd8ebf615	bugfix: we were leaving open duplicate connections to other ORs for a week, rather than closing them once we detect a duplicate. also, avoid some duplicate mark-for-closes in connection-housekeeping. svn:r5752	2006-01-07 03:56:56 +00:00
Roger Dingledine	9796733e89	"Pending" is a bad term for a circuit that uses your server as its last hop. svn:r5751	2006-01-07 02:31:14 +00:00
Roger Dingledine	d4d7a49411	fix typo svn:r5750	2006-01-07 02:12:38 +00:00
Roger Dingledine	af54b73985	and get the log arguments right svn:r5747	2006-01-07 01:43:09 +00:00
Roger Dingledine	ba339b8a4d	a more correct log message svn:r5746	2006-01-07 01:41:17 +00:00
Roger Dingledine	654b61a2e8	Jan 05 19:39:27.356 [warn] connection_edge_process_end_not_open(): Got an end because of misc error, but we're not an AP. Closing. svn:r5744	2006-01-07 01:02:21 +00:00
Roger Dingledine	f88fa3efc1	helper nodes are dead svn:r5743	2006-01-07 00:41:50 +00:00
Nick Mathewson	50b6b3258d	Dont call directory_get_from_dirserver when you have a particular dirserver in mind; remove fetch-from-authority special-case in directory_get_from_dirserver. svn:r5741	2006-01-06 18:19:17 +00:00
Nick Mathewson	f0fb9f6b0c	Directory authorities should go to the proper authority when asking for a networkstatus, even when they want a compressed one. (Also, bullet-proof the logic in case we ever accidentally request a networkstatus for a non-authority.) svn:r5740	2006-01-06 18:05:48 +00:00
Nick Mathewson	65f76bad4f	Add descriptions for state variables; rename AccountingBytesRead{In}Interval; remove extraneous and unused struct member. svn:r5739	2006-01-06 15:43:03 +00:00
Nick Mathewson	447e6ffffd	Fix bug where OPs would try to generate descriptor and crash. svn:r5738	2006-01-06 15:40:34 +00:00
Nick Mathewson	878962bee1	Add reasons to DESTROY and RELAY_TRUNCATED cells. svn:r5734	2006-01-05 21:23:03 +00:00
Roger Dingledine	d8e3bc0288	fix a wrong string svn:r5733	2006-01-05 12:18:34 +00:00
Roger Dingledine	6aaa92f736	short-circuit half the cost of node-picking in the general case. svn:r5732	2006-01-05 10:59:46 +00:00
Roger Dingledine	f8a59965a1	cleanups, and remove some unreachable code. svn:r5727	2006-01-04 06:43:03 +00:00
Roger Dingledine	485aa9415d	authdirs now stop whining so loudly about bad descriptors that they fetch from other dirservers. now when there's a log complaint, it's for sure from a freshly uploaded descriptor. svn:r5726	2006-01-04 04:42:10 +00:00
Roger Dingledine	6b2a6a8239	Bugfix: dyndns tor servers were needing to wait 18 hours before they could start doing reachability testing using the new IP address and ports. This is because we were using the internal descriptor to learn what to test, yet we were only rebuilding the descriptor once we decided we were reachable. svn:r5723	2006-01-03 23:34:42 +00:00
Roger Dingledine	f6f65c66b5	oh, it was supposed to compile? svn:r5721	2006-01-03 13:12:17 +00:00
Roger Dingledine	da06f3553c	don't try to build circuits until we have 3 running servers; and for networks that are very small, having more than a quarter of the descriptors is much harder than having equal to or more than a quarter of the descriptors -- follow the spec. svn:r5720	2006-01-03 13:09:49 +00:00
Roger Dingledine	5d28b7b884	we're done with tree.h. long live ht.h. svn:r5715	2006-01-03 12:35:58 +00:00
Roger Dingledine	9af33ef39c	when we choose not to use a server descriptor from our cache, don't log it so loudly. svn:r5713	2006-01-03 10:42:20 +00:00
Roger Dingledine	16ee6830b6	only print bandwidth lines to the state file if we're being a server. otherwise this is pointless and probably bad for security. svn:r5704	2006-01-02 12:19:28 +00:00
Roger Dingledine	1d474e14d7	strictentrynodes means we should clear the current entry_nodes list. svn:r5703	2006-01-02 11:33:14 +00:00
Roger Dingledine	c5a5161fb5	prevent auth dir servers from enabling entry nodes. svn:r5702	2006-01-02 08:40:58 +00:00
Roger Dingledine	358052416d	bugfix: only try to use the EntryNodes config option if it is set. svn:r5701	2006-01-02 05:14:21 +00:00
Roger Dingledine	ddf070e204	bugfix: we were failing to parse a tor version that started with "Tor ", even though we said we could. svn:r5699	2006-01-02 05:11:31 +00:00
Roger Dingledine	ea6ea8ec22	Make UseEntryNodes true by default. Let the fun begin. svn:r5698	2006-01-02 05:00:03 +00:00
Roger Dingledine	aa604ef2c2	bugfix: only try to parse the TorVersion if there is one. svn:r5697	2006-01-02 04:58:12 +00:00
Roger Dingledine	839111b85a	tolerate a mal-formed or unrecognized tor version in the state file. svn:r5696	2006-01-02 04:45:18 +00:00
Roger Dingledine	0bd25f5d43	save and validate TorVersion in the state file. svn:r5694	2006-01-02 04:14:52 +00:00
Roger Dingledine	2efa056777	make the "stable" flag in network-status be the median of the uptimes of running valid servers. that way the cutoff adapts to the stability of the network as a whole. svn:r5693	2006-01-02 03:32:55 +00:00
Nick Mathewson	4868d77ab8	Possible fix to state-load bug reported by weasel. svn:r5692	2006-01-02 00:42:19 +00:00
Peter Palfrader	3dc69d3add	Make tor compile again svn:r5688	2005-12-31 11:52:13 +00:00
Roger Dingledine	6c693dbda6	add a TorVersion state string. not yet set to anything. svn:r5687	2005-12-31 08:16:07 +00:00
Roger Dingledine	e9e7dc176c	Some tor servers process billions of cells in a matter of days. These statistics need to be uint64_t's. svn:r5686	2005-12-31 08:09:26 +00:00
Roger Dingledine	1a11b97b15	get rid of the special case for 'testing' circuits svn:r5684	2005-12-31 06:37:34 +00:00
Roger Dingledine	5947388968	Finish implementing config's EntryNodes and StrictEntryNodes option. The logging is way verbose for now. svn:r5683	2005-12-31 06:32:57 +00:00
Roger Dingledine	0dc8e284f8	load balance a bit better by taking some load off the really fast servers. this might slow things down more, or it might not. hm. svn:r5681	2005-12-30 04:46:43 +00:00
Roger Dingledine	c051e82f69	fix a typo svn:r5680	2005-12-30 04:44:10 +00:00
Nick Mathewson	fc850273bd	Appease some verbose GCC warnings. svn:r5679	2005-12-29 20:25:53 +00:00
Roger Dingledine	2904c6f024	log how big the failed rend descriptor is, and if it's small, log a base16 of the whole thing. svn:r5678	2005-12-29 04:57:19 +00:00
Roger Dingledine	14ea2e0b56	when we reject a rend descriptor, tell us where it came from. svn:r5677	2005-12-29 04:43:24 +00:00
Roger Dingledine	dbd7b97eff	helper nodes are dead. long live entry nodes. (config options EntryNodes and StrictEntryNodes still not implemented.) svn:r5673	2005-12-28 09:07:31 +00:00
Roger Dingledine	5d9256a367	but only close the new conn if one of the earlier helper nodes that we mark up is actually reachable, fast enough, etc to use. svn:r5672	2005-12-28 07:27:41 +00:00
Roger Dingledine	c1145138ea	but only close it if we have marked an earlier helper as up. that way we don't close it too needlessly. svn:r5671	2005-12-28 07:20:33 +00:00
Roger Dingledine	60cd03069a	when we connect to a helper node for the first time, close that connection and its circuits. this lets us go back to using the old helper nodes rather than immediately using the last one in the list. svn:r5670	2005-12-28 07:19:55 +00:00
Roger Dingledine	bbc4c8cef8	fix a spacing problem introduced by our 80-column requirement svn:r5669	2005-12-27 10:11:29 +00:00
Roger Dingledine	d2171cb7a4	if the network is down, and we try to connect to a conn because we have a circuit in mind, and we timeout (30 seconds) because the network never answers, we were expiring the circuit, but we weren't obsoleting the connection or telling the helper functions. now do that. svn:r5668	2005-12-27 09:25:50 +00:00
Roger Dingledine	4088f7dfd1	fix typo svn:r5667	2005-12-27 09:04:36 +00:00
Roger Dingledine	f46c135fac	when we succeed at connecting to a helper that we've never connected to before, mark all the previous helpers as up. This is handy if the network went away and then returned. svn:r5666	2005-12-27 08:54:37 +00:00
Roger Dingledine	25fcb5fa9c	helpful log svn:r5665	2005-12-27 08:38:22 +00:00
Roger Dingledine	976bf06463	slightly more accurate log messages svn:r5664	2005-12-27 07:37:21 +00:00
Roger Dingledine	25052c6f4b	first cut of the new helper stuff. seems to work in the normal case, but many edge cases still need testing. svn:r5663	2005-12-27 07:23:52 +00:00
Nick Mathewson	9ef54a3d0c	Make directory caches a little less chatty when logging svn:r5662	2005-12-27 06:05:54 +00:00
Nick Mathewson	fa0d5aa894	Make insert_old try hard to never add a duplicate. svn:r5661	2005-12-27 05:58:12 +00:00
Nick Mathewson	ece9865020	Implement new directory logic: download by descriptor digest, not by key digest. Caches try to download all listed digests from authorities; clients try to download "best" digests from caches. svn:r5659	2005-12-27 05:26:03 +00:00
Nick Mathewson	d94b9fd7d2	normalize spaces svn:r5658	2005-12-27 04:52:34 +00:00
Roger Dingledine	94bff33357	and compiling would be good too svn:r5657	2005-12-27 02:48:35 +00:00
Roger Dingledine	370dcbc7ba	and some comments svn:r5656	2005-12-27 02:48:02 +00:00
Roger Dingledine	5807bd0635	make it clearer in the auto-generated config file that you probably shouldn't be editing this one yourself. svn:r5655	2005-12-27 02:46:53 +00:00
Roger Dingledine	b038dc9ecc	disambiguate some debug entries svn:r5654	2005-12-26 22:42:22 +00:00
Roger Dingledine	815df977cf	comments? i'll show you comments. svn:r5652	2005-12-26 05:52:44 +00:00
Roger Dingledine	40c267a89f	prevent a rare infinite loop on two-byte architectures, and be more thorough and starting over when the clock jumps. svn:r5647	2005-12-25 04:37:33 +00:00
Roger Dingledine	7e0d62b14a	stop being sneaky, especially if we're being incorrectly sneaky svn:r5646	2005-12-24 23:39:20 +00:00
Roger Dingledine	b0144276db	more comments, and start to use the made_contact entry. svn:r5645	2005-12-24 23:32:35 +00:00
Roger Dingledine	7cc53c2281	clean up some comments svn:r5644	2005-12-24 23:32:15 +00:00
Roger Dingledine	35986a2374	simplify because we weren't using those return values anyway svn:r5643	2005-12-24 22:48:12 +00:00
Roger Dingledine	3a2ce447b4	start to document the helper node functions svn:r5642	2005-12-24 20:07:19 +00:00
Peter Palfrader	4bd65f0f98	Keep bandwidth history accross restarts/crashes svn:r5637	2005-12-23 23:56:42 +00:00
Roger Dingledine	eecb835527	stop shipping tree.h, since we don't use anymore. (woo.) svn:r5628	2005-12-20 07:17:42 +00:00
Roger Dingledine	bb4662365b	when we fail three times to resolve or connect, we were telling the user it was because we failed to resolve. svn:r5620	2005-12-19 21:56:43 +00:00
Roger Dingledine	da01657c34	more asserts in case weasel can trigger them svn:r5616	2005-12-19 00:35:18 +00:00
Roger Dingledine	7cd46d7f95	fix a seg fault when you finish connecting to a server but at that moment you dump his server descriptor, and you also happen to be logging at loglevel info. (found by weasel) svn:r5615	2005-12-18 22:59:47 +00:00
Roger Dingledine	34249e8861	fix segfault when specifying DirServer without nickname (reported by weasel) svn:r5614	2005-12-18 22:45:27 +00:00
Roger Dingledine	a2186b9999	fix a ! that got left out svn:r5612	2005-12-18 22:34:24 +00:00
Nick Mathewson	6b5fc9d46f	Instead of "Network down", say "Is your network connection down?" svn:r5607	2005-12-15 22:10:03 +00:00
Roger Dingledine	a6afef700a	nother typo svn:r5605	2005-12-15 21:51:12 +00:00
Roger Dingledine	edde3fcf25	ah ha, that variable was static. not useless after all. svn:r5604	2005-12-15 21:44:23 +00:00
Roger Dingledine	002c9b3589	clean up a lot message, and remove a line that does nothing. svn:r5603	2005-12-15 21:41:27 +00:00
Nick Mathewson	89eded7b17	Add "panic" option to reject all servers not in fingerprint list. svn:r5601	2005-12-15 21:39:38 +00:00
Nick Mathewson	cf8c70b79c	fix compile svn:r5600	2005-12-15 21:38:59 +00:00
Nick Mathewson	280c62314e	Make clients look at the fast and stable flags in networkstatus, not at the bandwidth and uptime declared in the router descriptors. svn:r5599	2005-12-15 21:30:57 +00:00
Roger Dingledine	3489066433	put back in a todo comment, so we don't forget. svn:r5598	2005-12-15 21:26:52 +00:00
Roger Dingledine	dadcb19d17	fix typo svn:r5597	2005-12-15 21:26:39 +00:00
Nick Mathewson	24e79df0b6	Whitespace fixes; comments. svn:r5596	2005-12-15 21:17:40 +00:00
Nick Mathewson	713c995adb	Do not mark directories as down simply because they dont have the router descs we want. svn:r5595	2005-12-15 21:15:16 +00:00
Nick Mathewson	5965b3849e	Remove some redundant and obsolete code from routerparse svn:r5594	2005-12-15 20:58:51 +00:00
Nick Mathewson	6b1305aeeb	Flip a misplaced not svn:r5593	2005-12-15 20:56:46 +00:00
Nick Mathewson	3ea32f51cb	add a few clarifying comments svn:r5592	2005-12-15 20:49:01 +00:00
Nick Mathewson	ce71b17224	Clean fake_status a bit. Switch from has_fetched_directory to have_minimum_dir_info, and make the latter function smarter. svn:r5591	2005-12-15 20:44:15 +00:00
Roger Dingledine	25e1ad02fa	implement weasel's suggestion to fix the bug that newly bootstrapped tor networks couldn't do hidden services until they had nodes with high uptime: if you're trying to pick a node for your circuit and you demand uptime or capacity and nothing works, then abandon your need for uptime and capacity. svn:r5589	2005-12-15 09:53:00 +00:00
Nick Mathewson	7af95e5c06	When we mark a router as down, also mark its local_routerstatus as not running. This way, we do not use directories that are believed to be down. svn:r5587	2005-12-14 22:05:10 +00:00
Nick Mathewson	9482b1b9d5	Choose directory servers from routerstatus list, not from routerinfo list. This way, as soon was we have a networkstatus, we can ask a cache to give us routers, rather than needing to ask the directories. svn:r5586	2005-12-14 22:00:58 +00:00
Nick Mathewson	c02c6b5823	Shave off 8 bytes per connection and 4 bytes per circuit by paying attention to padding warnings, moving fields around, and acknowledging that we have no files with over 64 kilolines. svn:r5583	2005-12-14 21:03:51 +00:00
Nick Mathewson	1af630d32c	Bite the bullet and limit all our source lines to 80 characters, the way IBM intended. svn:r5582	2005-12-14 20:40:40 +00:00
Nick Mathewson	7e632a7564	another possible patch related to circuit_free and memory stomping. svn:r5580	2005-12-14 18:55:17 +00:00
Nick Mathewson	4f38670328	Fix a potential memory stomp on servers running hidden services. Found by weasel with valgrind. Backport candidate. svn:r5579	2005-12-14 02:19:27 +00:00
Roger Dingledine	86d69218ef	orconn_identity_map was another static variable that started out NULL and didn't change until it needed to change. svn:r5578	2005-12-14 01:02:35 +00:00
Roger Dingledine	c9f6e6b0a0	sometimes, when we just started tor, we haven't created that smartlist yet. so don't free it. svn:r5577	2005-12-14 00:52:15 +00:00
Roger Dingledine	d853c9a009	bugfix: when we removed a dead helper node, we never committed that change to disk. svn:r5576	2005-12-13 02:52:38 +00:00
Roger Dingledine	ea760fa149	extendcircuit and attachstream would complain about not enough arguments, but then just keep on going anyway. svn:r5575	2005-12-12 16:50:55 +00:00
Nick Mathewson	27a201ac80	Have dirctory authorites note which servers make good V2 directory caches in publishe network-status. svn:r5574	2005-12-12 01:03:28 +00:00
Nick Mathewson	32126cced1	Make directory authorities ignore router uploads that have only cosmetic differences: now regardless of version! svn:r5573	2005-12-12 01:02:08 +00:00
Roger Dingledine	bf4da967c1	Don't use helper nodes for circuits with purpose 'testing'. Also, when picking the helper node for a given circuit, exclude the circuit's exit from your choices. svn:r5569	2005-12-11 12:14:26 +00:00
Roger Dingledine	a131783c8b	when removing dead helpers, only write or_state to disk once at the end, not for every helper you remove. svn:r5568	2005-12-11 11:56:17 +00:00
Roger Dingledine	5981169440	mark the helper node as down if we time-out on the circuit handshake with him. svn:r5567	2005-12-11 11:55:41 +00:00
Roger Dingledine	dded1dd8bd	don't mark the helper node as down when we fail to connect to our https proxy. svn:r5566	2005-12-11 11:54:55 +00:00
Roger Dingledine	9c01fa3d59	fix yet another time comparison bug. we were abandoning helpers as soon as they became unavailable. (is this true?) svn:r5565	2005-12-11 11:23:36 +00:00
Roger Dingledine	f3349d6ed3	fix an error in reporting why we abandoned a helper node svn:r5564	2005-12-11 11:20:26 +00:00
Roger Dingledine	b974f67c01	choose helper nodes to have high capacity always svn:r5563	2005-12-11 11:20:01 +00:00
Roger Dingledine	77c0f6d456	a first go at fixing a bug matt edman reported: when he tries to "setconf log" via the controller, it is friendly and gives him a log to stdout, even though he didn't ask for one. svn:r5562	2005-12-11 10:01:21 +00:00
Roger Dingledine	79f09b2f17	setconf orport=9001 513 Unrecognized option value it's not unrecognized. it's unacceptable. (in this case, i still have to consult the logs to figure out why, but at least i have an inkling that maybe i should.) svn:r5561	2005-12-11 09:33:38 +00:00
Roger Dingledine	46d563fe00	whenever we hupped or did a controller setconf, we were prepending another reachableaddresses :80,:443 if fascistfirewall was set, and we were appending another reject : regardless. svn:r5560	2005-12-11 09:18:25 +00:00
Roger Dingledine	a4e1014f4d	i think fascistfirewall still has its uses. it's a synonym for a certain reachableaddresses line, but it's easier to remember and people already understand it. i think we should think about undeprecating it. svn:r5559	2005-12-11 08:59:02 +00:00
Roger Dingledine	defa3804cf	explain why 0.1.1.9-alpha-cvs is a special version. svn:r5552	2005-12-10 21:07:21 +00:00
Roger Dingledine	58366ffd24	when we changed from log_fn to debug/info/notice/warn/err, we screwed up the formatting in wild and unpredictable ways. fix it before it becomes convention to format logs in wild and unpredictable ways. still need to do src/common/ someday. svn:r5551	2005-12-10 09:36:26 +00:00
Roger Dingledine	9b0a40ec78	crank the max line limit down to 150 chars. svn:r5550	2005-12-10 08:27:01 +00:00
Nick Mathewson	39265dd72e	In my private little universe, terminals are still 80 columns. Impose a 160-character-per-line limit; this will creep down. svn:r5548	2005-12-09 05:37:26 +00:00
Nick Mathewson	95e471c9a6	Normalize whitespace svn:r5547	2005-12-09 05:22:15 +00:00
Nick Mathewson	33c4445846	For some bizarre reason, MSVC does not implement GCC extensions. Who would have thought? svn:r5546	2005-12-09 05:20:02 +00:00
Roger Dingledine	a438f2abcd	let the user configure a sockslistenaddress on other private IPs besides 127.x.y.z without complaining. and give a better message in the log. svn:r5544	2005-12-09 02:46:46 +00:00
Nick Mathewson	d57029ffe8	Make code to handle "private" alias work when assume_action is set. svn:r5542	2005-12-08 23:58:23 +00:00
Roger Dingledine	8730190914	when we're checking reachability, make it clearer in the logs what to expect. svn:r5538	2005-12-08 21:12:47 +00:00
Roger Dingledine	d3dcea08af	remove a redundant memcpy when extending to a new server and attaching circuits to it. svn:r5537	2005-12-08 20:33:57 +00:00
Nick Mathewson	338f23114f	Oops. 0.0.0.0/8 and 169.254.0.0/16 are also special. svn:r5536	2005-12-08 19:58:14 +00:00
Nick Mathewson	2d585941b8	Release memory from conn_circid_circuit_map on exit. svn:r5535	2005-12-08 19:46:22 +00:00
Nick Mathewson	1b770817c0	Add private:* as an alias in configuration for policies. svn:r5534	2005-12-08 19:40:24 +00:00
Nick Mathewson	898968b3ac	Warn when binding to a public address for socks. This warning needs to be improved. Also, make options_validate() only warn when an option is changed to a bad value.. (Previously, it warned when an option was bad and any option was changed.) svn:r5532	2005-12-08 18:56:32 +00:00
Nick Mathewson	e9b66ec906	Document CREATE_FAST better in the code. Move our key expansion algorithm into a separate function in crypto.c svn:r5530	2005-12-08 17:38:32 +00:00
Nick Mathewson	617f71e4ba	Whitespace normalization svn:r5528	2005-12-08 04:03:12 +00:00
Nick Mathewson	f031ee8246	Make clients use CREATE_FAST cells. add an option to disable this. svn:r5524	2005-12-07 22:09:02 +00:00
Roger Dingledine	4902ece698	what the heck is wrong with this little piece of code? why can none of us get it right? it looks so simple. svn:r5521	2005-12-07 04:43:39 +00:00
Roger Dingledine	b0ffa34219	tell the controller about new .onion streams too. svn:r5520	2005-12-06 23:43:52 +00:00
Roger Dingledine	5c0338dca3	the other half of weasel's patch, so old gcc's can build cvs again. svn:r5517	2005-12-06 21:03:48 +00:00
Peter Palfrader	0dbb622f26	Old gccs want you to do your variable declarations first svn:r5516	2005-12-06 17:01:36 +00:00
Roger Dingledine	3347762fa4	when we're giving up on a circuit and retrying on a new one, log the name of the exit node. perhaps people will find this useful, or see patterns, or something. svn:r5515	2005-12-06 07:21:17 +00:00
Nick Mathewson	b1d034d2ab	Fix bug 212: Directory authorities should not try to download server descriptors that they know they will reject. svn:r5514	2005-12-06 06:55:43 +00:00
Nick Mathewson	d2123388ad	Better fix for last bug: avoids trying to double-mark circuits. svn:r5511	2005-12-05 19:45:54 +00:00
Nick Mathewson	fedc9c8a60	We were neglecting to unlink marked circuits from soon-to-close OR connections. svn:r5510	2005-12-05 19:26:09 +00:00
Nick Mathewson	b03e8733f3	Change how OR conns get removed from the identity map; fix some warnings on shutdown. svn:r5509	2005-12-05 19:15:27 +00:00
Nick Mathewson	f0abb1a74b	Check magic when removing old connection from map. svn:r5508	2005-12-05 19:01:34 +00:00
Nick Mathewson	835f06a77c	Set chosen_exit_name to something we are not about to zero. svn:r5507	2005-12-05 06:16:24 +00:00
Nick Mathewson	98290e4115	When parsing foo.exit, if foo is unknown, and we are leaving circuits unattached, set the chosen_exit field and leave the address empty svn:r5504	2005-12-05 04:38:21 +00:00
Roger Dingledine	26b49dbc09	Bugfix for trackhostexits: write down the fingerprint of the chosen exit, not its nickname, because the chosen exit might not be verified. svn:r5499	2005-12-05 00:15:42 +00:00
Roger Dingledine	40cbe550f3	fix a log message to be mildly more helpful svn:r5498	2005-12-04 23:06:48 +00:00
Roger Dingledine	bb8dc691eb	Fix another time comparison bug in circuit_stream_is_being_handled(). Nick, can you confirm this one? This is also a backport candidate. svn:r5497	2005-12-04 22:23:24 +00:00
Roger Dingledine	ef000fd82e	ok, i know this one was a bug. we were expiring open general circuits after they had been around for 30 seconds. svn:r5496	2005-12-04 22:19:04 +00:00
Roger Dingledine	7d032bd300	take back half of my bugfix. comparing times sucks. but leave the other half. svn:r5495	2005-12-04 21:59:15 +00:00
Roger Dingledine	d60f514f4c	fix the first bug with our optimization to circuit_expire_building(): we were killing off rendezvous circuits unless they magically time-warped to be too old before we got around to killing them, in which case we would leave them alone. this made it hard to rendezvous with hidden services. svn:r5494	2005-12-04 21:51:50 +00:00
Nick Mathewson	1b0134dda8	Clean up some comments; remove some dead code svn:r5493	2005-12-03 16:32:29 +00:00
Nick Mathewson	61c5a9ae2b	Use a switch statement and some mild refactoring to try to speed up circuit_expire_building svn:r5492	2005-12-03 05:29:05 +00:00
Nick Mathewson	979fc3e69d	cvs diff -u src/or/circuitlist.c \| less almost never does what you want in C. svn:r5491	2005-12-03 03:36:32 +00:00
Nick Mathewson	77a494dd55	Expunge remaining places where we used "tree" to mean "associative array". svn:r5490	2005-12-03 02:21:31 +00:00
Nick Mathewson	148a1e969d	Shave off another 4.7%: remove a linear search when figuring out which circuits wanted us to open a given OR connection. svn:r5489	2005-12-03 02:12:37 +00:00
Nick Mathewson	502cb59611	Remove "tree" references from dns. svn:r5488	2005-12-03 02:01:18 +00:00
Nick Mathewson	6443e5ec7f	Add a benchmark-aes function to test.c. Off by default. svn:r5485	2005-12-01 04:35:58 +00:00
Nick Mathewson	fea19528a1	assert_buf_ok was showing up in the profile; remove it from critical-path functions, since it hasnt triggered for ages. svn:r5479	2005-11-30 22:48:58 +00:00
Nick Mathewson	d56a65c497	Fix some verbose warnings and remove an unneeded include. svn:r5472	2005-11-30 06:38:41 +00:00
Nick Mathewson	9cec3a13f5	remove some functions that are not used; #if0 out some files that are not likely to be used. svn:r5471	2005-11-30 06:27:59 +00:00
Nick Mathewson	a6eb8cd2a0	Move connection_or_remove_from_identity_map() to connection_unlink, but dont remove the other; just make it warn. svn:r5470	2005-11-30 04:28:41 +00:00
Nick Mathewson	3bd613b44d	Rename connection_get_by_identity_digest to reflect that it is OR-only. Make it use a hashtable instead of a linear search. svn:r5469	2005-11-30 03:01:16 +00:00
Nick Mathewson	447a3a7ff2	Funny. I could have sworn that it compiled. svn:r5467	2005-11-29 17:17:02 +00:00
Nick Mathewson	94e8dcef44	Fix a bug weasel found: when we are an authority and somebody requests "all" statuses, cconsider regenerating our own. svn:r5466	2005-11-29 17:14:10 +00:00
Nick Mathewson	c90d6c7e5f	Make arguments to circuit_set_circid_orconn match the connection that is closing in circuit_about_to_close_connection. This accounts for our mysterious "arbitrary ram gets decremented!" bug. svn:r5465	2005-11-29 17:13:34 +00:00
Nick Mathewson	7de0c33857	Avoid a segfault in routerlist_reset_warnings() svn:r5464	2005-11-28 16:29:27 +00:00
Roger Dingledine	1da454a42d	when returning a list of circuits, don't return a list of the same conn over and over. that's really bad for memory. svn:r5463	2005-11-28 02:52:17 +00:00
Roger Dingledine	f94f4c1686	when event_add or event_del fail, tell us why. (nick, do i have my libevent strerror dance moves correct?) svn:r5462	2005-11-26 09:37:00 +00:00
Roger Dingledine	97f748f680	clean up broken comment svn:r5461	2005-11-26 09:27:36 +00:00
Nick Mathewson	652e1899ac	"How about 'never'? Does 'never' work for you?" Weasel says circuit_get_by_conn is his main timesink. Most of its users were just checking whether OR conns had circuits, so add a circuit count to OR conns, and check that. One was circuit_about_to_close_conn, which was doing an O(n^2) series of calls to get all circs on an OR conn, so make an O(n) function for that. Finally, circuit_get_by_edge_conn was using it as a sanity test that has been around for a while but never found any actualy insanity, so kill that. circuit_get_by_conn is finally dead, which is good, since it was never sane to begin with. svn:r5460	2005-11-26 01:43:57 +00:00
Nick Mathewson	31d5d96739	Cut down a common call to circuit_get_by_conn by about half. svn:r5459	2005-11-26 00:53:51 +00:00
Roger Dingledine	fe221f3dff	Start the process of treating internal circuits and exit circuits separately. It's important to keep them separate because internal circuits have their last hops picked like middle hops, rather than like exit hops. So exiting on them will break the user's expectations. - Stop cannibalizing internal circuits for general exits, and stop cannibalizing exit circuits for rendezvous stuff. - Don't let new exit streams attach to internal circuits. - When deciding if we have enough circuits for internal and for exit, don't count the wrong ones. - Treat predicted resolves as predicted port 80 exits. svn:r5457	2005-11-25 08:08:56 +00:00
Roger Dingledine	6452aecedb	when calling connection_get_by_identity_digest, don't do a memcmp for non-OR conns. this should save a bit of time. svn:r5456	2005-11-25 06:43:53 +00:00
Roger Dingledine	2350e487a2	minor cleanup svn:r5454	2005-11-24 06:44:13 +00:00
Roger Dingledine	ea7fe0c267	Fix a bug found by Lasse Overlier: when we were making internal circuits (intended to be cannibalized later for rendezvous and introduction circuits), we were picking them so that they had useful exit nodes. There was no need for this, and it actually aids some statistical attacks. svn:r5453	2005-11-24 06:43:39 +00:00
Roger Dingledine	5b583073a1	remove some more dead code (found while hunting lasse's bug) svn:r5452	2005-11-24 06:06:50 +00:00
Roger Dingledine	23efc30776	get rid of some unused variables svn:r5451	2005-11-24 01:47:05 +00:00
Roger Dingledine	0118a236a4	comment that scary-looking function. svn:r5447	2005-11-23 07:30:44 +00:00
Nick Mathewson	eb0021b06e	Fix dumb logic error that kept some old descripttors from getting the axe. svn:r5446	2005-11-23 07:28:54 +00:00
Nick Mathewson	061ef582a1	Make dropping very old descriptors faster (remove old correctness check). Track bytes dropped that are still in our store or journal, and rebuild when it gets very high. svn:r5445	2005-11-23 07:24:59 +00:00
Nick Mathewson	36109fea33	e more aggressive about calling routerlist_remove_old_routers() svn:r5444	2005-11-23 07:06:36 +00:00
Nick Mathewson	fbf8a8c25f	Dump bytes held to store descriptors. svn:r5443	2005-11-23 06:00:58 +00:00
Nick Mathewson	7d7bb95f36	Track how many bytes we have in signed descriptors. Try to make sure we are tracking this right. Somebody should valgrind a dirserver on an example net. There should be code to dump this value. svn:r5442	2005-11-23 05:47:51 +00:00
Nick Mathewson	a39269572f	Replace balanced trees with hash tables: this should make stuff significantly faster. svn:r5441	2005-11-23 04:18:45 +00:00
Nick Mathewson	50ce5e1932	Avoid spurious re-launch of first pending requested descriptor svn:r5439	2005-11-22 02:20:05 +00:00
Peter Palfrader	a48b722432	Ancient gcc does not like you when you declare variables in the middle of a block svn:r5437	2005-11-20 16:53:49 +00:00
Peter Palfrader	b9d37a2d58	Add a new controller event type that allows controllers to get all server descriptors that were uploaded to a router in its role as authoritative dirserver. svn:r5436	2005-11-19 18:35:43 +00:00
Roger Dingledine	f28770b639	be less eager to decide that the entire network is down svn:r5434	2005-11-19 11:04:00 +00:00
Roger Dingledine	859d1c902a	and another instance where i was trying to be too sneaky svn:r5433	2005-11-19 10:38:23 +00:00
Roger Dingledine	98f353fa7c	actually listen when we try to route our dir connection via tor. svn:r5432	2005-11-19 10:33:34 +00:00
Roger Dingledine	5c949fce51	Start obeying our firewall options more rigorously: - If we can't get to a dirserver directly, try going via Tor. - Don't ever try to connect (as a client) to a place our firewall options forbid. - If we specify a proxy and also firewall options, obey the firewall options even when we're using the proxy: some proxies can only proxy to certain destinations. svn:r5431	2005-11-19 10:12:10 +00:00
Roger Dingledine	7aae63994f	Recover better from TCP connections to Tor servers that are broken but don't tell you (it happens!); and rotate TLS connections once a week. 1) If an OR conn becomes more than a week old, make it obsolete. 2) If it's obsolete and empty, kill it. 3) When an OR makes a second connection to you, allow it. 4) If we want to send a new create cell, but the best conn we've got is obsolete, and the router is 0.1.1.9-alpha-cvs or later, ask for a new conn instead. 5) When we time out on circuit building on the first hop, make that connection obsolete. svn:r5429	2005-11-19 06:57:44 +00:00
Roger Dingledine	700c370a3b	misc cleanups svn:r5428	2005-11-19 01:56:58 +00:00
Roger Dingledine	f824fb5f83	Bugfix: it looks like some middleman circuits were spending the first few moments of their existence in CIRCUIT_STATE_OPEN, then when Alice sent an extend request for a Tor that they're not connected to, they switched to CIRCUIT_STATE_OR_WAIT and spent the rest of their sorry little lives in that state, even when the connection was established and they were shuttling relay cells back and forth. And I'm not going to backport this (yet), because somehow it worked! svn:r5427	2005-11-19 01:55:58 +00:00
Roger Dingledine	0de8f4ee55	another case (i think) of redundant code. svn:r5426	2005-11-19 01:03:34 +00:00
Roger Dingledine	409294153f	remove some redundant (and misleading) code svn:r5425	2005-11-19 00:44:24 +00:00
Peter Palfrader	6734371234	15*60 is 15 minutes, not 5 svn:r5424	2005-11-18 21:57:49 +00:00
Peter Palfrader	901712ee59	Remove ip address change flapping detection. It is not really needed and I do not think it works quite right. svn:r5423	2005-11-18 19:28:34 +00:00
Roger Dingledine	4ddf2385a0	if it's not less than three does that mean it's more than two? svn:r5422	2005-11-18 11:35:23 +00:00
Roger Dingledine	9d6d6da883	and code the part where redirectstream can take a port. svn:r5421	2005-11-18 11:32:59 +00:00
Roger Dingledine	afb1c79879	Leave options->DirServers alone -- if the user didn't specify any, just add the default ones directly to the trusted dirserver list. This fixes a bug where people running controllers would setconf or the equivalent, and Tor would start yelling at them about setting their own DirServer lines. svn:r5418	2005-11-18 02:47:09 +00:00
Roger Dingledine	26d8c3498c	and another overly common log entry svn:r5417	2005-11-18 00:35:29 +00:00
Roger Dingledine	aa53190ed5	and another one svn:r5416	2005-11-17 22:23:18 +00:00
Roger Dingledine	9111a3fb48	comment out some really popular log lines svn:r5415	2005-11-17 22:19:35 +00:00
Roger Dingledine	d2b93df26c	and now we actually do it, too. svn:r5414	2005-11-17 22:01:46 +00:00
Roger Dingledine	7dbf2511c3	when you type 'getinfo' with no arguments, it doesn't give you any answer at all. this is clearly a bug. the more interesting bug is whether things like setconf, getconf, and so on should return 250 OK if you give them no arguments. should we have a new "you didn't ask me anything" response code, or just leave it as is? svn:r5412	2005-11-17 21:45:38 +00:00
Roger Dingledine	af86345b74	we used to kill the circuit when we receive a relay command we don't recognize. now we just drop it. perhaps this will make us more forward-compatible? or perhaps it will bite us? one day we will find out. svn:r5405	2005-11-17 03:40:20 +00:00
Roger Dingledine	298da4497a	help the term "OP" become obsolete svn:r5403	2005-11-17 01:17:53 +00:00
Roger Dingledine	279e29a1f2	bugfix: the controller doesn't mention it's a .onion if it is. svn:r5400	2005-11-16 23:54:24 +00:00
Roger Dingledine	c4aa9e7941	Add a new config option TestSocks so people can see if their applications are using socks4, socks4a, socks5-with-ip, or socks5-with-hostname. This way they don't have to keep mucking with tcpdump and wondering if something got cached somewhere. svn:r5399	2005-11-16 23:37:35 +00:00
Nick Mathewson	22aea0757e	Verify that router fingerprint lines match identity keys. (We dont use them, but others might.) svn:r5389	2005-11-15 21:24:32 +00:00
Roger Dingledine	74d1ca66c0	another case where the poor server operator doesn't need to hear about lexi's bugs. svn:r5388	2005-11-15 20:40:32 +00:00
Roger Dingledine	fe7b07754f	make it even more clear that i didn't screw up the logic svn:r5378	2005-11-15 09:57:58 +00:00
Roger Dingledine	53269f696d	fix logic error: not unnamed is good. svn:r5377	2005-11-15 09:15:43 +00:00
Nick Mathewson	9b432311c4	Make new logging stuff work on windows; fix a couple of windows typos. svn:r5375	2005-11-15 03:05:23 +00:00
Nick Mathewson	669fdde91b	Fix number in error message svn:r5369	2005-11-14 19:17:28 +00:00
Roger Dingledine	4ea6d71a26	shorten more of the startup log messages svn:r5368	2005-11-14 04:39:49 +00:00
Roger Dingledine	6fc30a65fd	when a stream times out, provide less (but better) explanation of what happened. don't bother printing the path, since i don't know of any person who has gotten anything useful out of that. svn:r5367	2005-11-14 04:13:43 +00:00
Roger Dingledine	014c6bfe00	We were refusing to start if you define SocksListenAddress but define SocksPort to be 0. But this is a standard configuration! So don't fail. svn:r5361	2005-11-11 22:41:07 +00:00
Roger Dingledine	a3c53e0af9	speed up the lookup-by-circid-orconn now that it seems that our code works. svn:r5358	2005-11-11 19:28:32 +00:00
Roger Dingledine	862a997495	when we were cannibalizing a circuit with a particular exit node in mind, we weren't checking to see if that exit node was already present earlier in the circuit. oops. svn:r5357	2005-11-11 19:25:30 +00:00
Roger Dingledine	4d1c6bbfc4	fix function comment svn:r5356	2005-11-11 17:16:24 +00:00
Roger Dingledine	c136bbe505	stop discouraging the old *BindAddress config options. we will just confuse our users when they upgrade. svn:r5354	2005-11-11 17:04:14 +00:00
Roger Dingledine	e6fd88c698	simplify a log entry svn:r5353	2005-11-11 17:03:35 +00:00
Roger Dingledine	c074f528c1	fix a harmless warn and mark two points where we should maybe change our approach. svn:r5352	2005-11-11 17:01:20 +00:00
Nick Mathewson	b76f61ee66	If we stop knowing about a dirserver between request and answer, do not die. svn:r5351	2005-11-08 22:30:17 +00:00
Peter Palfrader	43c253958e	Tor26's IP has changed to 86.59.21.38 svn:r5350	2005-11-05 20:20:51 +00:00
Nick Mathewson	75d85c8214	On directory servers, old_routers was wasting hundreds of bytes per superseded router descriptor. Roll the signed descriptor info and identifying info into a cache_info struct, and use only that for old_routers. svn:r5349	2005-11-05 20:15:27 +00:00
Nick Mathewson	757def59b6	Fix bugs in routerlist_remove_old_cached_routers_with_id() svn:r5348	2005-11-04 16:47:26 +00:00
Nick Mathewson	a913cb3536	prevent duplicat mark-for-close svn:r5347	2005-11-04 05:00:12 +00:00
Nick Mathewson	9e82f0cdb7	enable code to remove members of old_routers when it gets big. svn:r5345	2005-11-01 17:34:17 +00:00
Nick Mathewson	80758473f8	fix a signed/unsigned warning svn:r5344	2005-11-01 17:28:49 +00:00
Roger Dingledine	40ecaf4857	answer nick's XXX, and muck with some log domain choices svn:r5339	2005-11-01 06:13:12 +00:00
Roger Dingledine	6dafca62f0	remove redundant checking for . and .. now that tor_listdir() checks for this too. svn:r5337	2005-11-01 03:50:14 +00:00
Roger Dingledine	1991f6cf48	more doc cleanups and reorganizing svn:r5336	2005-11-01 03:48:51 +00:00
Roger Dingledine	44b3f3060a	make circ->onionskin a pointer, not a static array. moria2 was using 125000 circuit_t's after it had been up for a few weeks, which translates to 20+ megs of wasted space. svn:r5333	2005-10-29 19:13:48 +00:00
Roger Dingledine	bf2be9abd7	Do round-robin writes of at most 16 kB per write. This might be more fair on loaded Tor servers, and it might resolve our Windows crash bug. It might also slow things down. svn:r5332	2005-10-29 18:19:37 +00:00
Roger Dingledine	862e8a1bd1	fix typo svn:r5331	2005-10-29 18:00:25 +00:00
Nick Mathewson	f2617c6b79	Free the v2 directory networkstatus on exit. (Not a leak.) svn:r5330	2005-10-29 05:01:12 +00:00
Nick Mathewson	4cb2435388	aaand another leak. Oops, I guess I lied to weasel when I told him there was no leak here. svn:r5329	2005-10-28 19:10:53 +00:00
Nick Mathewson	ed32d85a04	router_add_to_routerlist() really needs to free not-added routers. svn:r5328	2005-10-28 18:44:51 +00:00
Nick Mathewson	76988bafbe	Fix bug when parsing list of router descriptors containing a truncated entry. (Found by Lasse) svn:r5327	2005-10-28 15:56:19 +00:00
Nick Mathewson	267af9ecf9	Fix a fun bug that was probably causing unnecessary downloads, and that coupld possibly have caused some segfaults: When post-processing a split fingerprint URL, we were trying to base16_decode() entries already in the fingerprint list, failing, and removing them. Ow. svn:r5326	2005-10-27 23:16:08 +00:00
Nick Mathewson	7643c5254c	Fix an annoying rep violation bug svn:r5325	2005-10-27 23:06:09 +00:00
Nick Mathewson	e594ce92fe	Start making directory caches retain old routerinfo_t. The code to remove old ones is definitely some textbook C problem. svn:r5323	2005-10-27 00:34:39 +00:00
Nick Mathewson	9492424d3f	Per comments at the bottom of openssl/FAQ, call even more functions to clean up OpenSSL's toys when it's done playing. (Why isn't there an OpenSSL_free_everything() function?) svn:r5321	2005-10-25 19:01:48 +00:00
Nick Mathewson	b39d03116b	remove some commented-out code that may tempt us to do ill svn:r5320	2005-10-25 18:38:44 +00:00
Nick Mathewson	e5633c2e66	fix a nasty corruption bug svn:r5319	2005-10-25 18:33:33 +00:00
Nick Mathewson	35f1b7fa26	fix minor memory leak in config svn:r5318	2005-10-25 18:06:29 +00:00
Nick Mathewson	5d85560d9e	Remove last vestiges of old logging interface. svn:r5317	2005-10-25 18:01:01 +00:00
Nick Mathewson	049f6c0131	Switch remaining files to new log interface. svn:r5315	2005-10-25 17:52:14 +00:00
Nick Mathewson	a38aa81bf8	fix another segv, this time in circid fix. svn:r5312	2005-10-25 15:31:25 +00:00
Nick Mathewson	9b6c5614c6	fix a segv svn:r5311	2005-10-25 15:30:02 +00:00
Nick Mathewson	e7e170a59e	Change more files to new loggin interface. 3 left. svn:r5310	2005-10-25 08:20:10 +00:00
Nick Mathewson	932106f54c	Efficiency hack: call tor_fix_source_file late, not early. Add "BUG" domain. Domains are now bitmasks... just in case. Make some err msgs non-general. svn:r5309	2005-10-25 07:05:03 +00:00
Nick Mathewson	452f4cfa09	Convert circuituse, command, config, connection, relay, router, test to new logging interface svn:r5308	2005-10-25 07:04:36 +00:00
Nick Mathewson	81dd50a942	Fix memory leak when retrieving networkstatus or routerdesc by malformed fingerprint svn:r5307	2005-10-25 07:03:22 +00:00
Nick Mathewson	91a666064a	Fix possible free(NULL) in control.c svn:r5306	2005-10-25 07:02:13 +00:00
Nick Mathewson	26caf69555	Fix possible minor memory leak when parsing helpernode state svn:r5305	2005-10-25 07:00:03 +00:00
Nick Mathewson	f9b0be526e	Use LD_BUG as appropriate; convert rend* and router* to new logging interface; use new circ_log_path interface svn:r5302	2005-10-24 19:39:45 +00:00
Nick Mathewson	fa338d85db	Fix one possible source of reuse-a-circuit-id bug; convert circuitbuild to new logging svn:r5301	2005-10-24 19:37:45 +00:00
Nick Mathewson	7f20dec1cd	When warning about a networkstatus fp, we need to put it in hex. svn:r5293	2005-10-24 03:25:12 +00:00
Nick Mathewson	37708e9b1b	Avoid potential infinite recursion when building a descriptor svn:r5292	2005-10-24 03:04:05 +00:00
Roger Dingledine	d6dcd973c3	Oct 19 13:27:24.391 [info] router_reload_networkstatus(): Skipping cached-status file with unexpected name "." Oct 19 13:27:24.391 [info] router_reload_networkstatus(): Skipping cached-status file with unexpected name ".." svn:r5291	2005-10-20 17:22:00 +00:00
Nick Mathewson	52eaccce44	Crank down the frequency for replacing unchanged descriptors svn:r5290	2005-10-19 16:21:19 +00:00
Nick Mathewson	7b8980a43c	Make it compile. appease roger and his thirst for documentation. svn:r5289	2005-10-19 03:08:50 +00:00
Nick Mathewson	74d9c92c49	We need a routerlist_replace as well. This should do something about those annoying mysterious segfaults. svn:r5288	2005-10-19 03:02:28 +00:00
Roger Dingledine	4df1892db1	solve the first half of bug 199: if we don't like the looks of an address, but it's the controller's job to handle it, don't refuse it first. svn:r5287	2005-10-19 02:07:11 +00:00
Nick Mathewson	1bd3f6cc9a	Update more files to new log stuff. svn:r5286	2005-10-18 22:56:40 +00:00
Nick Mathewson	55f2ab9cc3	Migrate a few more files to domained logging svn:r5285	2005-10-18 22:21:29 +00:00
Nick Mathewson	edf5698474	Start dividing log messages into logging domains. No, LD_ is not the best of identifiers. src/or has not been converted yet. Domains dont do anything yet. svn:r5284	2005-10-18 21:58:19 +00:00
Roger Dingledine	102df4a982	fix some typos svn:r5283	2005-10-18 21:39:00 +00:00
Peter Palfrader	e54efb1655	I think nick meant to compare r2->platform the second time svn:r5282	2005-10-18 21:19:48 +00:00
Peter Palfrader	0d5c007266	Fix tor26's first segfault svn:r5281	2005-10-18 21:19:02 +00:00
Nick Mathewson	d25873ae9c	Use a digestmap_t to speed up router_get_by_digest, which was previously a bottleneck (~~27% CPU) svn:r5280	2005-10-18 20:13:09 +00:00
Nick Mathewson	7a19588a43	Use digestmap_t instead of strmap_t where appropriate. Do less hex en/decoding svn:r5279	2005-10-18 20:12:22 +00:00
Nick Mathewson	3347c1741d	Refactor routerlist access slightly: always use router_get_by_routerlist(); change its interface; add modifier functions to add/remove elements from the current routerlist (so we can add indices). svn:r5276	2005-10-18 17:43:54 +00:00
Peter Palfrader	d8daa910a6	Make dirserv_get_routerdescs() return better http 404 error messages instead of a generic "Servers unavailable." svn:r5274	2005-10-18 17:09:57 +00:00
Peter Palfrader	551e3402a3	split send_control1_event() into the printf and the print/dispatch part. The printf part was and is limited to at most 1024 byte messages, so having the print part separately available makes sense. svn:r5273	2005-10-18 16:45:43 +00:00
Peter Palfrader	00e1709244	Fix download by SD digest svn:r5272	2005-10-18 15:58:40 +00:00
Peter Palfrader	6e8052e0f8	I wonder what a stautus is. svn:r5271	2005-10-18 15:25:10 +00:00
Peter Palfrader	64a631e187	Some http status lines ended in a dot, others did not. Make it all the same and remove the period from all svn:r5270	2005-10-18 14:57:46 +00:00
Peter Palfrader	0186cb283f	And close the double quote too svn:r5269	2005-10-18 14:34:49 +00:00
Peter Palfrader	d2f1cd4196	Fix documentation of dirserv_get_routerdescs: correct the path for queries by server key, add queries by SD digest svn:r5268	2005-10-18 14:33:19 +00:00
Nick Mathewson	27fcbf87f3	Add a missing struct initializer field svn:r5264	2005-10-17 23:00:08 +00:00
Peter Palfrader	0d9aedfcea	Downgrade a few INFO level logs to DEBUG again. Also add two or three new logs in cases where a calling function's log was downgraded and we wouldn't get any log message otherwise. svn:r5263	2005-10-17 16:21:42 +00:00
Roger Dingledine	bec2271029	fix a few comments svn:r5262	2005-10-17 08:41:58 +00:00
Roger Dingledine	fd165329b8	start calling it ListenAddress rather than BindAddress, since none of our users know what it means to bind an address or port. svn:r5260	2005-10-17 03:17:29 +00:00
Nick Mathewson	22c72bd9c5	Add ability to warn when using abbrev mechanism to deprecate option names svn:r5259	2005-10-17 03:06:00 +00:00
Roger Dingledine	435fb973c2	when providing content-type application/octet-stream for providing server descriptors with .z, we were leaving out the content-encoding header. oops. (everything tolerated this just fine, but that doesn't mean we need to be part of the problem.) svn:r5258	2005-10-17 02:32:33 +00:00
Peter Palfrader	7b15f77dd6	Make a few INFO log lines into DEBUG svn:r5257	2005-10-17 02:13:36 +00:00
Roger Dingledine	1be5f4a81b	start hunting down why servers keep getting so many duplicate create cells svn:r5255	2005-10-17 01:46:47 +00:00
Roger Dingledine	ae92a91d96	more log uncluttering svn:r5254	2005-10-17 01:29:28 +00:00
Roger Dingledine	03dcef4c78	start the process of reducing clutter in server logs svn:r5253	2005-10-17 00:35:53 +00:00
Roger Dingledine	aca6fb5f5f	cut out a warning that doesn't need to warn svn:r5252	2005-10-16 19:47:01 +00:00
Roger Dingledine	2a82182243	remove obsolete IgnoreVersion config from or.h svn:r5251	2005-10-16 18:43:41 +00:00
Nick Mathewson	6101468cbe	Enable trivial "download by descriptor digest" functionality. svn:r5250	2005-10-14 04:56:20 +00:00
Nick Mathewson	998cf8d622	Try to extract as many descriptors as possible from truncated http responses. (when DIR_PURPOSE_FETCH_ROUTERDESC) svn:r5249	2005-10-14 02:26:13 +00:00
Nick Mathewson	11b76b9ca5	Allow tor_gzip_uncompress to extract as much as possible from truncated compressed data. Also, fix a bug where truncated compressed data could break tor_gzip_uncompress. [This last part is a backport candidate.] svn:r5247	2005-10-13 22:48:09 +00:00
Peter Palfrader	8808b26206	Check if our IP address has changed every 5 minutes. If it has, update our server descriptor, but not too often svn:r5246	2005-10-12 22:41:16 +00:00
Peter Palfrader	640211e59a	Be a bit more verbose in our AUTHENTICATE error messages in the control protocol so the next guy doesn't blame Nick again svn:r5245	2005-10-12 19:45:35 +00:00
Nick Mathewson	aac738d2be	When no descriptors changed, do not send a NEWDESC event. svn:r5244	2005-10-12 19:41:16 +00:00
Nick Mathewson	905ef987e2	Make --hash-password not craash on exit. svn:r5243	2005-10-12 19:08:48 +00:00
Nick Mathewson	9a1d204318	Avoid warning on end-of-function svn:r5242	2005-10-12 18:43:03 +00:00
Nick Mathewson	972b7512c7	authorities do not replace server descriptors where nothing semantically relevant has changed since the last upload. svn:r5240	2005-10-12 18:25:25 +00:00
Nick Mathewson	fd9bfef13b	Funny. I could have sworn it compiled this morning when I checked it in. svn:r5239	2005-10-12 17:16:25 +00:00
Nick Mathewson	a7ca56b537	More work towards a sane digest-based liveness testing. svn:r5238	2005-10-12 13:49:13 +00:00
Nick Mathewson	2b3a7b818f	Add an as-yet-unused "EXTENDED" flag to SETEVENTS to indicate that the client can handle extra labeled info in its events. Add moreinfo to the "what is ready for downloading" msg so we can investigate digest-related download rules svn:r5237	2005-10-12 04:31:44 +00:00
Nick Mathewson	bf9ff1c1e7	Do not check whether DirPort is reachable when we are suppressing it because of hibernation. (Backport candidate) svn:r5235	2005-10-12 04:07:10 +00:00
Nick Mathewson	08e4f132a8	add some docs; if warn_if_unnamed is 0, really do not warn. svn:r5234	2005-10-11 01:57:28 +00:00
Nick Mathewson	c48ccf9db4	Insert a newline between all router descriptors when generating (old style) signed directories, in case somebody was counting on that. svn:r5231	2005-10-08 06:02:41 +00:00
Nick Mathewson	2f49e058d0	Now that directory admins assure me they have adjested teir configs, it is safe to make authorities be non-versioning, non-naming by default. svn:r5230	2005-10-08 05:47:58 +00:00
Nick Mathewson	d7b04a8788	do not try to download a routerdesc if we would immediately reject it as obsolete. svn:r5225	2005-10-07 22:00:09 +00:00
Nick Mathewson	2572db2472	Warn less about intro nodes by nickname; remember our own intro nodes by key. svn:r5224	2005-10-07 21:38:44 +00:00
Roger Dingledine	78edd804ff	fix a malformed warning entry svn:r5219	2005-10-07 19:49:48 +00:00
Roger Dingledine	83e119154b	doxygen fix svn:r5217	2005-10-07 19:25:01 +00:00
Roger Dingledine	46af2d26d0	you can't declare variables in the middle of a block svn:r5214	2005-10-07 18:56:21 +00:00
Peter Palfrader	14934dece2	Print address too when we say we cannot bind/listen svn:r5213	2005-10-07 18:48:31 +00:00
Nick Mathewson	4c7113d26a	Strip extra trailing newlines when parsing router descriptors. svn:r5212	2005-10-07 18:33:30 +00:00
Nick Mathewson	a89daaeca9	Once an hour (not just on startup) give OpenSSL some more entropy. Add entropy in 512-bit chunks, not 160-bit chunks. (This latter change is voodoo.) svn:r5211	2005-10-06 22:22:22 +00:00
Nick Mathewson	cc35e1720f	Using RAND_pseudo_bytes instead of RAND_bytes is an accident waiting to happen, and does not really speed us up much when we do it. So stop doing it. svn:r5210	2005-10-06 22:18:01 +00:00
Roger Dingledine	0e5b6a84eb	without braces, what will hold up the code? svn:r5209	2005-10-06 05:08:00 +00:00
Nick Mathewson	ba24193ab5	Make doxygen marginally happier svn:r5208	2005-10-06 04:33:40 +00:00
Nick Mathewson	5cf758764e	Rate-limit warnings related to unrecognized MyFamily elements. svn:r5204	2005-10-05 23:20:45 +00:00
Nick Mathewson	ba67d14d40	On sighup, if usehelpernodes changed to 1, use new circuits. svn:r5203	2005-10-05 23:02:40 +00:00
Roger Dingledine	f12663a4ce	call circuit_expire_all_dirty_circs() on do_hup(). there, now we use it. svn:r5202	2005-10-05 22:36:33 +00:00
Nick Mathewson	56be5a9706	I knew something was wrong here. Flip some comparison operators and make download-rate-limiting sane again. svn:r5201	2005-10-05 22:36:18 +00:00
Nick Mathewson	039edb3dbb	Downgrade too-frequent "nothing happened" message from info to debug svn:r5200	2005-10-05 22:32:59 +00:00
Roger Dingledine	c3aac3ff6b	infrastructure for the 'change pseudonym' button. not used yet. svn:r5199	2005-10-05 22:31:21 +00:00
Nick Mathewson	1ebbaf5c3a	improve INFO-level logging for directory downloads. This is still too chatty, but it will help us analyze things. svn:r5197	2005-10-05 20:45:18 +00:00
Nick Mathewson	370e4abdc9	replace former relaunches of directory downloads with reset of failure count and relaunch of status downloads. Fix memory leak in trusted_dir_server_t. Reset "last download attempted" time when resetting failure counts. svn:r5195	2005-10-05 05:03:52 +00:00
Roger Dingledine	adf04f121e	size_t int printf mucking svn:r5194	2005-10-05 04:52:55 +00:00
Nick Mathewson	96c47c8478	Note the two places where clients will still try to fetch old-style (v1) directory info. These should be fixed, I think. svn:r5193	2005-10-05 02:25:59 +00:00
Nick Mathewson	509de69a7e	reset warning flags on SIGHUP. arma: is this everything? svn:r5192	2005-10-05 02:20:46 +00:00
Roger Dingledine	be478bb56c	stutter therapy lessons svn:r5191	2005-10-05 02:09:27 +00:00
Nick Mathewson	8434595584	Fix verbose compiler warnings, including one in routerlist.c that would have been an actual error. Normalize whitespace. Enforce convention that "address" is a hostname and "addr" is an IPv4 address. svn:r5190	2005-10-05 02:06:36 +00:00
Nick Mathewson	0924094042	resolve some directory-related XXXXs; downgrade naming conflict messages from WARN to INFO for non-authorities; do not repeat naming conflict messages. svn:r5189	2005-10-05 01:53:44 +00:00
Nick Mathewson	1223310b69	Downgrade noisy log messages in preparation for an alpha release. svn:r5188	2005-10-05 01:27:08 +00:00
Nick Mathewson	a608905070	Give a less frequent and more helpful warning on failed serverdesc downloads svn:r5187	2005-10-05 00:22:56 +00:00
Nick Mathewson	42e17182da	When we get an EOF or a timeout on a directory connection, note how many bytes of serverdesc we are dropping. This will help us determine whether it is smart to parse incomplete serverdesc responses. svn:r5186	2005-10-04 22:34:09 +00:00
Nick Mathewson	61ea516885	Check for named servers when looking them up by nickname; warn when we'recalling a non-named server by its nickname; don't warn twice about the same name. Fix a bug in routers_update_status_from_networkstatus that made nearly all clients never update routerinfo_t.is_named. Try to list MyFamily elements by key, not by nickname. Only warn about names that we generated ourself, or got from the local user. On TLS handshake, only check the other router's nickname against its expected nickname if is_named is set. svn:r5185	2005-10-04 22:23:31 +00:00
Nick Mathewson	2d203fdcf3	link nicknames to trusted directory servers; log these nicknames when mentioning servers; also, when we get a naming conflict; log which nicknames or keys are supposed to bind. svn:r5184	2005-10-04 21:21:09 +00:00
Nick Mathewson	b10df0d595	cosmetic fix: only have one local to hold smartlist_len(downloadable), not too. svn:r5183	2005-10-04 20:18:26 +00:00
Nick Mathewson	e4a6a03249	switch semantics of authdirinvalid/reject svn:r5182	2005-10-04 19:52:58 +00:00
Roger Dingledine	88c37f2d24	comment cleanups svn:r5181	2005-10-04 06:53:59 +00:00
Nick Mathewson	c5ee3e961e	Reorganize some quick-and-dirty code to find out what openssl stuff is leaking, using dmalloc. svn:r5178	2005-10-03 20:20:38 +00:00
Nick Mathewson	9e54e2e293	free helper node status info on shutdown svn:r5177	2005-09-30 21:38:57 +00:00
Nick Mathewson	808e584a87	remove a never-used smartlist in routerlist.c svn:r5176	2005-09-30 21:38:45 +00:00
Nick Mathewson	6e4608701d	and another leak. svn:r5175	2005-09-30 21:31:26 +00:00
Roger Dingledine	ae30c8101b	by convention, addr is a uint32_t and address is a string. that's why we hadn't caught that leak. svn:r5174	2005-09-30 21:30:04 +00:00
Nick Mathewson	5c5d2e82e6	Fix a leak when launching listeners. svn:r5173	2005-09-30 21:28:00 +00:00
Nick Mathewson	23864ad423	Try to hunt down a few more leaks svn:r5172	2005-09-30 21:22:25 +00:00
Nick Mathewson	80f2e10228	Stop leaking or_state_t on shutdown. svn:r5171	2005-09-30 21:16:47 +00:00
Nick Mathewson	5333a3b838	fix a small filename leak svn:r5170	2005-09-30 21:11:22 +00:00
Nick Mathewson	8408006318	fix a memory leak on exit in routerlist.c svn:r5169	2005-09-30 21:04:52 +00:00
Nick Mathewson	de198d800b	Never call free() on tor_malloc()d memory. This is unlikely to be our current leak, but it may help dmalloc work. svn:r5168	2005-09-30 20:47:58 +00:00
Nick Mathewson	fc3c0197f9	Resolve several DOCDOCs. Make non-mirrors only launch routerdesc downloads when they have more than 16 router descriptors to download, or when 10 minutes have passed since the last download. svn:r5166	2005-09-30 20:04:55 +00:00
Roger Dingledine	e28c31ebce	we were leaking some memory every time the client changes IPs svn:r5165	2005-09-30 06:03:04 +00:00
Nick Mathewson	ab245746a9	Hey kids, guess why connection_mark_for_close() started giving an assert when called for an even-numbered line? Right, because I made it a bitfield, when it was really a line number. Why did I think it was a bitfield? A stale comment. Let that be a lesson to us all. svn:r5164	2005-09-30 04:43:42 +00:00
Roger Dingledine	13e709a0ff	resolve nick's comment svn:r5163	2005-09-30 02:08:57 +00:00
Nick Mathewson	26e7a05725	even better function start checks; give dmalloc a chance of working. svn:r5162	2005-09-30 01:39:24 +00:00
Nick Mathewson	edd15cb781	Note that there is incorrect behavior in directory.c code. Arma, please check this too. svn:r5161	2005-09-30 01:38:09 +00:00
Nick Mathewson	92451f74a8	Reformat inconsistent function declarations. svn:r5160	2005-09-30 01:09:52 +00:00
Roger Dingledine	609af664ac	resolve a docdoc svn:r5157	2005-09-30 00:43:40 +00:00
Roger Dingledine	ea18827cee	do the other half of dirport reachability testing. it should be back and working now. svn:r5155	2005-09-29 23:59:36 +00:00
Roger Dingledine	f8d430653e	better cleanups as i figure out what's going on svn:r5154	2005-09-29 23:26:42 +00:00
Roger Dingledine	d4d8adaa6d	move some code around when we're succeeding or failing at fetching server descs. also clean up some formatting. svn:r5153	2005-09-29 23:06:48 +00:00
Roger Dingledine	54a662a542	re-enable dirport testing again (still need the other half, to notice when it has worked.) svn:r5152	2005-09-29 23:04:01 +00:00
Roger Dingledine	8fc9330686	fix typo svn:r5151	2005-09-29 23:03:34 +00:00
Nick Mathewson	5c53545d81	Add a bunch more warnings to out warning suite; resolve them; pack structs a little better. svn:r5150	2005-09-29 22:59:17 +00:00
Nick Mathewson	c6347cdb0e	suppress all our usual compiler warnings, including a longstanding one from tree.h svn:r5149	2005-09-29 20:49:41 +00:00
Roger Dingledine	8ae6e1c226	Be more conservative about whether to advertise our dirport. The main change is to not advertise if we're running at capacity and either a) we could hibernate or b) our capacity is low and we're using a default dirport. svn:r5148	2005-09-29 06:45:03 +00:00
Roger Dingledine	3559f821a1	clean up some doxygen stuff svn:r5147	2005-09-29 02:54:09 +00:00
Nick Mathewson	126a1e3e32	Fix crash-on-wakeup bug in networkstatus download. svn:r5144	2005-09-26 16:37:39 +00:00
Roger Dingledine	fba01c3cc0	bugfix: we were whining about using socks4 or socks5-with-local-lookup even when they used an IP in the "virtual" range we designed exactly for this case. svn:r5142	2005-09-24 21:56:04 +00:00
Nick Mathewson	abb8576538	But, of course, mirrors should get the most up-to-date server in any case. svn:r5135	2005-09-23 21:33:59 +00:00
Nick Mathewson	b726507d36	Log even less verbosely. Also, do not download old (frequently-updating) servers more than once every 2 hours. svn:r5134	2005-09-23 21:25:29 +00:00
Nick Mathewson	ebf6476e8e	Provide dire warnings to any users who set DirServer; move it out of torrc.sample and into torrc.complete. svn:r5132	2005-09-23 20:44:22 +00:00
Nick Mathewson	18a0a0e458	Oops. It looks like some old GCCs dislike #if inside a macro argument. svn:r5131	2005-09-23 20:31:07 +00:00
Roger Dingledine	0ef18a0fba	put a log message so we can start confirming socks5-with-remote-dns vs socks5-with-local-dns svn:r5130	2005-09-23 19:56:34 +00:00
Nick Mathewson	06625e779d	Decouple router downloads from old directory downloads entirely svn:r5128	2005-09-23 18:49:37 +00:00
Nick Mathewson	c345dab3bd	Fix logic error (people who ask authorities should never split; others should always split). Also, fix timing error in main.c so retries really happen. svn:r5127	2005-09-23 18:17:37 +00:00
Nick Mathewson	a1f1c4bf6b	Re-enable autosplitting, but authorities and mirrors should not do it, and make the cutoff higher than 1. svn:r5126	2005-09-23 18:08:31 +00:00
Nick Mathewson	f995edd516	Fix at least one overzealous download bug. (tor_malloc_zero new local_routerstatus_t objs); add a pile of logs back in; probe every 10sec; never autolaunch on failure. Let us see if this works better. svn:r5125	2005-09-23 18:05:14 +00:00
Nick Mathewson	9050480339	Fix some compiler warnings svn:r5124	2005-09-23 17:11:20 +00:00
Nick Mathewson	faa4f420de	Remove extraneous space on read-history lines. svn:r5123	2005-09-23 17:02:50 +00:00
Roger Dingledine	03d0f62da0	make the numbers in read-history and write-history into uint64s, so they don't overflow and publish negatives in the descriptor. fixes bug 193. svn:r5119	2005-09-23 08:29:58 +00:00
Roger Dingledine	512d6ccdc1	and a minor log cleanup svn:r5115	2005-09-23 00:04:53 +00:00
Roger Dingledine	e286c4267e	there was no need to die when we failed to spawn a cpuworker. it handles it fine if we decide not to die. svn:r5114	2005-09-23 00:04:44 +00:00
Roger Dingledine	479886fce2	remove another loud debug msg svn:r5113	2005-09-22 23:56:56 +00:00
Roger Dingledine	d050ff7906	resolve lucky's recent bug: tor was exiting if we failed to spawn a new dns worker (e.g. because we were out of fd's). svn:r5112	2005-09-22 23:43:41 +00:00
Roger Dingledine	2d6b36a001	get rid of a noisy debug log svn:r5111	2005-09-22 20:51:45 +00:00
Nick Mathewson	cdc912714e	I love the smell of C in the morning. Make router-download rules smarter (download more so long as we dont duplicate existing requests; relaunch at staggered intervals); relaunch one a minute or on failure; reset 60 minutes; always open 3 requests if we can; add authority opinion to networkstatus; make naming rule correct. There is a remaining bug where we retry servers too quickly; We need to look at that harder. svn:r5110	2005-09-22 06:34:29 +00:00
Nick Mathewson	6693031947	Use a separate type for "local view of router status". Also, even though I told arma there was no need, replace an ugly O ( n lg n ) algorithm with a nice O ( n ) algorithm when stepping through servers. Some ugliness is just too bad to stand. svn:r5109	2005-09-22 01:51:14 +00:00
Roger Dingledine	959598fae6	content-type bugfixes: http://seppia.noreply.org/tor/dir.z was being declared text/plain and http://seppia.noreply.org/tor/server/fp/719BE45DE224B607C53707D0E2143E2D423E74CF was being declared application/octet-stream svn:r5108	2005-09-22 00:17:41 +00:00
Roger Dingledine	f011b12df2	bugfix: nobody ever implemented EVENT_ADDRMAP for control protocol version 0, so don't let version 0 controllers ask for it. svn:r5107	2005-09-21 23:30:15 +00:00
Nick Mathewson	f99b91505b	Make write_escaped_data more bulletproof; backport candidate. svn:r5106	2005-09-21 23:13:29 +00:00
Roger Dingledine	1cfcc4b351	clean up misleading comment on authdir_wants_to_reject_router() svn:r5105	2005-09-21 21:10:36 +00:00
Nick Mathewson	72915546cd	Only check versions from versioning authdirs. svn:r5101	2005-09-21 02:38:51 +00:00
Nick Mathewson	20b9111266	Implement new version handling code. svn:r5100	2005-09-21 00:41:06 +00:00
Roger Dingledine	94ff09af23	clean up a bit more code svn:r5098	2005-09-20 19:50:43 +00:00
Roger Dingledine	19f04ae9c3	make router_is_general_exit match its documentation but it's still wrong maybe svn:r5095	2005-09-20 03:40:54 +00:00
Nick Mathewson	837b223c8c	remove some debugging garbage svn:r5092	2005-09-18 04:32:58 +00:00
Nick Mathewson	283032960d	Make give-up-on-failure actually work: it seems the servers gave me a real test case. svn:r5091	2005-09-18 04:15:39 +00:00
Nick Mathewson	d118d5069a	Prevent a "try forever to download an unobtainable descriptor" bug. Still remaining: the "give up forever" bug. svn:r5090	2005-09-18 02:51:12 +00:00
Nick Mathewson	87f6d526fe	Refactor new directory code a bit. Keep a big list of rolled-up router status info, including # of download failures (not yet used). Update this list from networkstatuses when they arrive, then update routers from this list. Only download 128 routers at a time, to avoid gargantuan URLs. svn:r5089	2005-09-18 02:24:42 +00:00
Nick Mathewson	e86893e87b	Move to new base64 digest functions. Switch to new router digest calculation. Make sure there are no duplicates in router status lists. svn:r5088	2005-09-18 02:22:21 +00:00
Nick Mathewson	1fbe499bfe	Remove a bunch of #if0d code that I no longer need to look at. svn:r5083	2005-09-16 16:47:20 +00:00
Nick Mathewson	6d15a73548	Resolve/expand some XXXXs and improve a log message or two svn:r5082	2005-09-16 16:41:45 +00:00
Roger Dingledine	cce469c5ce	simplify svn:r5081	2005-09-16 06:15:34 +00:00
Nick Mathewson	538740e362	Fix the never-marked-anything-as-running bug. Now Tor builds circuts again. Woo. svn:r5080	2005-09-16 04:53:28 +00:00
Nick Mathewson	d45badd9f4	Add a missing return svn:r5079	2005-09-16 04:52:53 +00:00
Nick Mathewson	1a786a297f	Fix the confusing bug where we were downloading only the first n/2-1 of the servers we actually wanted. svn:r5078	2005-09-16 04:43:21 +00:00
Nick Mathewson	9c2ca40df3	Unify our "figure out which fingerprints we were downloading" code. svn:r5077	2005-09-16 04:42:45 +00:00
Nick Mathewson	05bab28c7d	Add some (notice, for now) log messages that imply confusing things are happening. svn:r5076	2005-09-15 21:11:48 +00:00
Nick Mathewson	51da58eccf	fix braino in dirserv. svn:r5075	2005-09-15 21:10:58 +00:00
Nick Mathewson	e72e76cad6	Make authdirs smarter. Reject/invalidate by key and IP. Remember that not every authdir has to be a naming authdir. svn:r5074	2005-09-15 14:39:05 +00:00
Nick Mathewson	ed21abfe87	And some documentation before bed. svn:r5073	2005-09-15 06:15:31 +00:00
Nick Mathewson	b70c229f6e	make some functions static; clean dead networkstatus entries more often. svn:r5072	2005-09-15 05:41:30 +00:00
Nick Mathewson	3dcc4630b9	Make unittests not die svn:r5071	2005-09-15 05:28:18 +00:00
Nick Mathewson	b16048917c	Stop downloading directories and download routers instead. This still needs some work, but at last clients are finally on the new architecture. Next comes the tuning and bugfixing. svn:r5070	2005-09-15 05:19:38 +00:00
Nick Mathewson	e83e1df811	separate validation from naming in authoritative directory servers; simplify some router-management code. svn:r5069	2005-09-15 00:51:42 +00:00
Nick Mathewson	d4e0af7822	Fix a bunch of log messages. Deprecate some routerlist fields; remove others, and status_set_at from routerinfo_t. Compress routerlist.c cleanup functions. Update cached networkstatus mtime when we download the same one twice. Change some interfaces. svn:r5068	2005-09-14 23:42:06 +00:00
Nick Mathewson	bc0af7046a	Oops. directory_set_dirty() needs to mark networkstatus as dirty too. svn:r5066	2005-09-14 23:14:37 +00:00
Nick Mathewson	27bbfe9dcf	Would you believe that the software_versions field of routerlist_t was never actually used for anything? svn:r5064	2005-09-14 21:38:05 +00:00
Nick Mathewson	e3adcbdb95	Big commit: clients start downloading and using network-statuses. Only caches need to get running-routers; nobody needs to parse, store, or use it. Same for the router-status line in the directories. Add many #if 0's that can get removed once I'm convinced they don't contain anything I'm forgetting. Start all newly-parsed routers as non-running and non-valid; update them from the list of network statuses. Update all routers when a new networkstatus comes in. After 3 tries for a networkstatus, clients give up until they're told to try again. "Let's get those missles ready to DESTROY THE UNIVERSE!" -TMBG svn:r5063	2005-09-14 21:09:25 +00:00
Nick Mathewson	922cee3d0c	Clean up a few warnings that make gcc twig out a bit. svn:r5062	2005-09-14 20:59:25 +00:00
Nick Mathewson	d9ee94543e	Declare 0.1.1.7 as The Version With The Good Dirservers. svn:r5061	2005-09-14 19:12:35 +00:00
Roger Dingledine	ca727ba6e1	bugfix: when we try to determine the reachability of our dirport, and it doesn't work, don't freak out and mark ourselves as down and try somewhere else. just calmly fail. svn:r5050	2005-09-14 03:49:17 +00:00
Nick Mathewson	7c6679d8dc	Add new config.c function to set options that can fail, and roll back if they do. This should solve the setconf-an-impossible-port bug. svn:r5046	2005-09-14 02:36:29 +00:00
Roger Dingledine	93be26a74a	stop the call duplication inside config_assign() svn:r5045	2005-09-14 02:35:06 +00:00
Nick Mathewson	6aa8850d90	note that routerstatus_t.entries is sorted. svn:r5044	2005-09-14 02:28:35 +00:00
Roger Dingledine	10893e7254	simplify svn:r5043	2005-09-14 02:18:28 +00:00
Roger Dingledine	c78aafe4b5	and take the bang out svn:r5042	2005-09-14 02:13:35 +00:00
Roger Dingledine	62fe24c40c	ok, ok, csv's get replaced even when we assign them from the torrc. svn:r5041	2005-09-14 02:12:29 +00:00
Roger Dingledine	1f930a9a70	checkpoint: clean up and document the three ways to call config_assign() and reduce code duplication in config_free() and option_is_same(). svn:r5040	2005-09-14 02:07:35 +00:00
Roger Dingledine	8585599965	correct "your server is reachable" log entries to indicate that it was self-testing that told us so. svn:r5034	2005-09-13 21:39:42 +00:00
Roger Dingledine	26cc51ffea	a bit more code cleanup svn:r5033	2005-09-13 21:24:51 +00:00
Nick Mathewson	890847d232	I forgot -- smart kids make their code compile. svn:r5032	2005-09-13 21:18:00 +00:00
Nick Mathewson	4efa652a98	add docs, fix whitespace, and make ANY rule in routerparse a little tighter. svn:r5031	2005-09-13 21:14:55 +00:00
Nick Mathewson	76351b8416	Fix DOCDOC entries in routerlist.c. Make more functions use SMARTLIST_FOREACH instead of raw loops. Replace router_list_superseded implementation with one that has a prayer of working. svn:r5027	2005-09-13 15:32:03 +00:00
Nick Mathewson	29c57b54d4	Add functions to extend and compress new router store logic. (Basic idea: use a journal of newly received router descriptors, and periodically replace the old file. This avoids the "too many files" problem and the "too many rewrites" problem.) svn:r5025	2005-09-13 06:21:10 +00:00
Roger Dingledine	82b3b6249c	fix a seg fault if we ask an authdirserver for a descriptor by fingerprint but he doesn't know about him. svn:r5023	2005-09-13 01:20:26 +00:00
Roger Dingledine	8b0d37096b	when the user asked for a rendezvous port that the hidden service didn't want to provide, we were sending an IP address back along with the end cell. fortunately, it was zero. but stop that anyway. svn:r5022	2005-09-12 22:05:17 +00:00
Roger Dingledine	569efe61c0	make the patch less likely to bite us later svn:r5021	2005-09-12 21:42:59 +00:00
Nick Mathewson	93c1d37d5f	Resolve stack corruption identified by edmanw in connection_edge_end(). Thanks! svn:r5020	2005-09-12 20:57:16 +00:00
Nick Mathewson	39e29738b1	Maybe I should pay more attention to return values and less to clever comments. Fortunately, the aforementioned comments came out against smacking upside the head. svn:r5018	2005-09-12 08:49:21 +00:00
Nick Mathewson	a6271650d5	Versions should be sorted by version. Lexical sorting should be used only as a last resort. svn:r5017	2005-09-12 08:46:37 +00:00
Roger Dingledine	689cb28098	when writing the recommended*versions lines, sort them first. this is because weasel put his out of order and told me the code should take care of it. svn:r5016	2005-09-12 08:31:47 +00:00
Roger Dingledine	63bb27f19d	be more thorough about noticing when a directory request has failed: it has failed not only when the connection attempt fails, but also if the conn reaches eof before we get a response that we're happy with. svn:r5013	2005-09-12 07:36:26 +00:00
Nick Mathewson	3dc5e77b58	Numerous changes to move towards client-side v2 directories. connection.c: - Add some more connection accessor functions to make directory download redundancy checking work. directory.c, or.h, router.c, routerlist.c: - Start on logic to note when networkstatus downloads fail. dirserv.c, routerlist.c, routerparse.c: - Start maintaining an is_named field in routerstatus_t. Don't actually look at it yet. dirserv.c, routerlist.c: - Remove expired networkstatus objects. or.h: - Make some booleans into bitfields - Add prototypes routerlist.c: - Sort networkstatus list by publication time - Function to remove old (older than 10 days) networkstatus objects. - Function to set a list of routerinfo_ts' status info from the current set of networkstatus objects. - Function to tell which routerinfos we need to download based no the current set of networkstatus objects. - Do not launch a networkstatus download if a redundant one is in progress. routerparse.c: - Keep router entries in networkstatus sorted by digest. svn:r5012	2005-09-12 06:56:42 +00:00
Roger Dingledine	5cebd8df70	remove temporary network-status keyword svn:r5007	2005-09-12 06:14:41 +00:00
Roger Dingledine	89d516f95c	clean up the log entry for when a server posts a server descriptor that the dirserver doesn't like svn:r5005	2005-09-12 06:08:48 +00:00
Nick Mathewson	63dfe2447e	Fix bug found by "ca": looking up a non-existent stream for a v1 control connection would cause a segfault. (No backport needed since 0.1.0 had only v0 connections.) svn:r5001	2005-09-12 03:32:30 +00:00
Roger Dingledine	d7d4d4cbbf	fix comment and return value for check_software_version_against_directory() svn:r4996	2005-09-11 22:36:50 +00:00
Roger Dingledine	b0a5ba4248	downgrade the dirserver log messages when whining about unreachability svn:r4991	2005-09-10 20:40:16 +00:00
Roger Dingledine	cfe34812eb	bugfix: if you gave tor an odd number of command-line arguments, we were silently ignoring the last one. now we complain and fail. svn:r4988	2005-09-10 04:40:27 +00:00
Roger Dingledine	9b54cd349d	break out a new function config_assign_value() that just assigns the value it's given, and doesn't do any of their weird clearing or resetting stuff. use that when we're trying to clear or reset values. svn:r4984	2005-09-10 02:42:32 +00:00
Nick Mathewson	d26523e089	Use tor_listdir in test.c instead of duplicating ode. svn:r4981	2005-09-10 01:42:42 +00:00
Roger Dingledine	1d9786a392	generalize route length to three plus one if the exit node is risky. svn:r4978	2005-09-10 01:01:40 +00:00
Nick Mathewson	035b1953eb	Add sorting/searching to smartlist svn:r4977	2005-09-09 23:12:54 +00:00
Roger Dingledine	cfa321374d	reject ports 465 and 587 by default now too svn:r4974	2005-09-09 22:46:43 +00:00
Nick Mathewson	dcf1e14190	downgrade warning to info svn:r4967	2005-09-09 21:03:57 +00:00
Roger Dingledine	a5ea401b2e	a few more hints on a rare but mysterious warning svn:r4966	2005-09-09 20:58:44 +00:00
Nick Mathewson	047e105daf	Fix a bug in config_dump: we want to run options_validate on the defaults, not (again, uselessly) on the configuration. This was introduced when we made the config code more generic. svn:r4965	2005-09-09 20:08:26 +00:00
Roger Dingledine	35b78b2d8e	clean up the rendezvous warn log msgs, and downgrade some to info svn:r4964	2005-09-09 19:54:28 +00:00
Nick Mathewson	0de64f224e	Warn in more detail when network-status serving and fetching fails. Also, fix a small leak. svn:r4963	2005-09-09 19:37:12 +00:00
Roger Dingledine	42f752a0a5	bugfix: we were automatically condemning an exit node (concluding its advertised exit policy is different from its real one) as soon as it refused any requests. After fixing that bug, another bug appeared: we would try the same server again and again, since once we learned an IP address for a hostname, we still kept think of it as the hostname. now pass it to the remapper before trying to reattach. svn:r4962	2005-09-09 06:11:37 +00:00
Roger Dingledine	843550721a	stop notifying people about dns worker spawning and culling it just freaks them out svn:r4960	2005-09-09 02:03:31 +00:00
Roger Dingledine	2065c5f7aa	when printing x-forwarded-by headers, don't print the \r svn:r4959	2005-09-09 02:02:20 +00:00
Nick Mathewson	bd911d8612	Fix segfault and memleak when getting many compressed server descs. svn:r4956	2005-09-08 22:00:29 +00:00
Nick Mathewson	659491bbc6	Fix some messages that say "failing". svn:r4955	2005-09-08 21:46:31 +00:00
Nick Mathewson	d410c49965	Clean up some more fingerprint-checking logic svn:r4954	2005-09-08 21:39:39 +00:00
Roger Dingledine	587b513ec0	remove obsolete kludge svn:r4953	2005-09-08 21:36:27 +00:00
Nick Mathewson	9df4716ac3	make it work correctly when we download multiple network-status objects. svn:r4952	2005-09-08 21:28:45 +00:00
Nick Mathewson	4ce0e01848	add conn->requested_resource to connection_t checks. svn:r4951	2005-09-08 21:21:54 +00:00
Nick Mathewson	a938190bdb	Iteration is happier when you stop. svn:r4950	2005-09-08 21:20:20 +00:00
Roger Dingledine	e28931dc94	unused variable svn:r4949	2005-09-08 21:12:53 +00:00
Nick Mathewson	4528bbfd9f	Resolve some XXXs. Add some others. svn:r4947	2005-09-08 21:01:24 +00:00
Nick Mathewson	c523e106b5	Do not generate more than 2 of each directory type per minute. svn:r4946	2005-09-08 20:47:11 +00:00
Nick Mathewson	18e4d78354	Fix an assert in directory.c. Check received network-status objects against the list we expected to get. Do not let anyone else update our network-status object. svn:r4945	2005-09-08 20:36:40 +00:00
Nick Mathewson	059148f588	Only caches download network-status for now, and they use a different strategy. Add an element to connection_t to remember what we are downloading, and a function to recognize our own fingerprint. svn:r4944	2005-09-08 20:18:15 +00:00
Nick Mathewson	6c4d43c724	Special-case for retrieving own networkstatus by fingerprint: regenerate if dirty! svn:r4943	2005-09-08 19:29:21 +00:00
Roger Dingledine	465aec04c1	when reporting results from a dirserver fetch/post, tell us the port for the dirserver too svn:r4942	2005-09-08 19:21:48 +00:00
Nick Mathewson	df79dc673b	Remove sneaky double declaration. svn:r4941	2005-09-08 19:18:55 +00:00
Nick Mathewson	0f94aa2ea1	Write status to disk in the right place svn:r4940	2005-09-08 19:16:16 +00:00
Nick Mathewson	cc16fb7636	oops -- that log should have been removed svn:r4939	2005-09-08 19:12:55 +00:00
Nick Mathewson	e5f117606f	Fix network-status parsing. svn:r4938	2005-09-08 19:10:36 +00:00
Nick Mathewson	b43a720bd4	Fix another reversed inet_aton svn:r4937	2005-09-08 18:53:57 +00:00
Nick Mathewson	1e2f1679c8	Fix some more bugs; add a temporary log. svn:r4936	2005-09-08 18:46:25 +00:00
Nick Mathewson	eab005c948	Ensure case match, not mismatch. svn:r4935	2005-09-08 18:34:41 +00:00
Nick Mathewson	810572a5de	Stop dying when we get a directory from tor26; workaround for change in networkstatus format svn:r4933	2005-09-08 18:24:26 +00:00
Roger Dingledine	4633b271f9	fix spacing svn:r4932	2005-09-08 18:15:57 +00:00
Nick Mathewson	548a863779	Avoid assertion failure svn:r4931	2005-09-08 18:14:23 +00:00
Nick Mathewson	ff9452e900	Clean up should-i-go-to-the-dirserv logic a little: All servers with DirPorts should get their directories from the source svn:r4930	2005-09-08 18:14:01 +00:00
Nick Mathewson	3a99927859	Make directory download code slightly less likely to segfault or assert. svn:r4929	2005-09-08 16:18:28 +00:00
Roger Dingledine	022f23249f	make doxygen output look prettier svn:r4928	2005-09-08 07:10:12 +00:00
Roger Dingledine	dbeb8e7863	it really does help with the functions end. svn:r4927	2005-09-08 06:59:58 +00:00
Roger Dingledine	74fb086210	if you give a config option in the torrc or the commandline with no value, and reset is false, then it clears it entirely. svn:r4926	2005-09-08 06:55:53 +00:00
Roger Dingledine	36fa360c11	and fix grammar svn:r4925	2005-09-08 06:49:23 +00:00
Roger Dingledine	69da0ef757	add punctuation svn:r4924	2005-09-08 06:49:02 +00:00
Nick Mathewson	8f37357193	Make GCC v4 happy with heavy warnings enabled. svn:r4922	2005-09-08 06:37:50 +00:00
Nick Mathewson	f50ddfd4dd	Download network-status at regular intervals. The code is probably iffy, and the constants need to be renamed. svn:r4921	2005-09-08 06:22:44 +00:00
Roger Dingledine	2f6664ce80	MonthlyAccountingStart is dead. svn:r4920	2005-09-08 05:38:47 +00:00
Roger Dingledine	c9e1c41873	dirserv_add_descriptor() doesn't chew up its argument anymore, so we can stop protecting it. svn:r4919	2005-09-08 05:37:22 +00:00
Roger Dingledine	03ddeb2620	strip obsolete code svn:r4918	2005-09-08 05:32:41 +00:00
Roger Dingledine	0ac3c58480	clean up comments for router_is_general_exit() svn:r4917	2005-09-08 05:23:55 +00:00
Roger Dingledine	08348ae66e	add a RESETCONF controller command, and make setconf with a null option actually mean to set it to "" svn:r4916	2005-09-08 03:18:51 +00:00
Roger Dingledine	0a8a8ba546	fix some typos svn:r4915	2005-09-08 03:17:50 +00:00
Nick Mathewson	4aca47268d	Logic to launch connections for new directory types. svn:r4914	2005-09-07 20:03:02 +00:00
Nick Mathewson	9e76eae810	add missing return svn:r4913	2005-09-07 17:18:52 +00:00
Nick Mathewson	eac917fd6a	clean whitespace. svn:r4912	2005-09-07 17:15:46 +00:00
Nick Mathewson	5c6c88e76d	More stuff for new directories. - Distinguish v1 authorities (all currently trusted directories) from v2 authorities (all trusted directories). - Add configuration option for which dirs are v1 authories. - Add configuration option for whether to be a v1 authority. - Make trusted dirserver selection functions take options to choose which functionality we need. - Remove option when getting directory cache to see whether they support running-routers; they all do now. Replace it with one to see whether caches support v2 stuff. - Parse, cache, and serve network-status objects properly. - Serve compressed groups of router descriptors. The compression logic here could be more memory-efficient. - svn:r4911	2005-09-07 16:42:53 +00:00
Roger Dingledine	c384fa706d	stop using the v1 rend desc format. we're going to change v1 some more before we switch to it. svn:r4909	2005-09-06 06:14:38 +00:00
Nick Mathewson	1e37ec4782	Comment structs, reload a field, start making network status caches work svn:r4908	2005-09-04 23:12:27 +00:00
Roger Dingledine	d2a5b614eb	if you're an auth dir server, start yourself out as verified. svn:r4907	2005-09-03 23:10:28 +00:00
Roger Dingledine	33b2abbc90	remove redundant logs about unreachable servers svn:r4905	2005-09-03 04:37:30 +00:00
Nick Mathewson	467fd6e4e6	fix order of items in network-status svn:r4904	2005-09-03 02:38:39 +00:00
Nick Mathewson	3485a497fe	Fix another ntohl svn:r4903	2005-09-03 02:23:53 +00:00
Nick Mathewson	ae726e659e	and another byte counting error. svn:r4902	2005-09-03 02:14:31 +00:00
Nick Mathewson	9b949cc1d2	Excellent. We have at least 8 bytes, so I can safely get the 9th. svn:r4901	2005-09-03 02:12:53 +00:00
Nick Mathewson	bcbff6dcd7	Note to self: htonl(htonl(X)) is not "twice as good as htonl(X)". Spotted by arma. svn:r4900	2005-09-03 01:47:39 +00:00
Nick Mathewson	815c092b22	Make structs for (v2) network-status and its per-router components. Add functions to parse them. Re-do the parsing logic a litt.e. Change signatures in or.h to support new DNS TTL logic. svn:r4898	2005-09-02 20:37:31 +00:00
Nick Mathewson	9bc3d34682	Add contact field to generated network-status objects svn:r4897	2005-09-02 20:30:03 +00:00
Nick Mathewson	09e8521236	Make ContactInfo mandatory for authoritative directories. svn:r4896	2005-09-02 20:29:29 +00:00
Nick Mathewson	a6a45b7713	Add TTLs to RESOLVED, CONNECTED, and END_REASON_EXITPOLICY cells. Also, add a missing ntohl in connection_ap_handshake_socks_resolved. svn:r4894	2005-09-02 18:53:31 +00:00
Roger Dingledine	93179f4e7e	bugfix: moria2 wasn't listing itself as verified in its directory svn:r4893	2005-09-02 06:19:31 +00:00
Roger Dingledine	ba899d0648	when we're shutting down and we do something like try to post a server descriptor or rendezvous descriptor, don't complain that we seem to be unreachable. of course we are, we're shutting down. svn:r4892	2005-09-01 08:19:49 +00:00
Roger Dingledine	1b04f38145	subtle change to avoid some false positives: if a server went down for six hours and then came back, we would complain to it that it's unreachable. now we wait until the third consecutive descriptor post that we thought it was unreachable, before complaining to it. svn:r4891	2005-09-01 08:13:40 +00:00
Roger Dingledine	3b6ab71929	and notify the dirserver operator whenever we do svn:r4890	2005-08-31 06:18:19 +00:00
Roger Dingledine	711cad94ed	when we think a router is unreachable, pass the message back to the server's logs, and make it a 'warn'. also, fix a memory leak for rejected router descriptors. svn:r4889	2005-08-31 06:14:37 +00:00
Nick Mathewson	0b92c28d84	Actually set is_hibernating when parsing router descriptors. svn:r4888	2005-08-30 15:04:24 +00:00
Roger Dingledine	6a52aa52fe	fix a pair of hard-coded urls svn:r4887	2005-08-30 07:01:30 +00:00
Roger Dingledine	4240410a9d	don't whine about reachability if the guy is hibernating now. speaking of which, we don't actually parse is_hibernating out of the router descriptor right now. nick, can you fix this? svn:r4886	2005-08-30 06:48:24 +00:00
Roger Dingledine	e9524f9d2d	refactor -- no actual changes svn:r4885	2005-08-30 06:43:07 +00:00
Roger Dingledine	a8c0c51e0b	a bit of cleanup svn:r4884	2005-08-30 06:01:13 +00:00
Nick Mathewson	0691c7221e	Update routerinfo_t.is_running when generating network status on authdirserver. svn:r4883	2005-08-29 18:42:36 +00:00
Nick Mathewson	29a6c17d67	Allow tor_gzip_uncompress to handle multiple concatenated compressed strings. svn:r4882	2005-08-29 18:01:38 +00:00
Nick Mathewson	e3a058f33a	Change semantics of set_cached_dir; fix massive authdir memleak. svn:r4880	2005-08-28 04:20:37 +00:00
Nick Mathewson	26d2301c76	Make unit tests (and others) run without launching listeners, creating subdirectories, and so on. svn:r4876	2005-08-26 23:22:27 +00:00
Nick Mathewson	cd2bb915ed	Fix a warning, add an assert. svn:r4875	2005-08-26 23:12:13 +00:00
Nick Mathewson	70fe2a6cee	Crashing dirservers on startup is often considered bad form. svn:r4874	2005-08-26 23:04:12 +00:00
Nick Mathewson	e863771485	Log when falling back to nonfast/nonstabl routers svn:r4869	2005-08-26 22:16:32 +00:00
Nick Mathewson	ed070b0fdb	Set a variable that exists. That works better. svn:r4868	2005-08-26 22:16:09 +00:00
Roger Dingledine	6577e08e38	when we're trying to build a circuit and we're being picky about what sort we get but there aren't any suitable servers, try being less picky rather than simply failing. svn:r4867	2005-08-26 22:10:22 +00:00
Nick Mathewson	a74ad8efea	Remember to mark v2 networkstatus non-dirty when we generate it; also, fix spaces. svn:r4866	2005-08-26 22:08:24 +00:00
Nick Mathewson	3cc960c7dd	Make sure that cached-status directory exists. svn:r4865	2005-08-26 22:03:57 +00:00
Roger Dingledine	77f52e3467	fix some logs and comments svn:r4864	2005-08-26 21:55:38 +00:00
Nick Mathewson	ae4a183ed8	Change the return values on dirserv_add_descriptor svn:r4863	2005-08-26 21:46:24 +00:00
Roger Dingledine	53431a4950	fix compile complaints (and a bug) svn:r4862	2005-08-26 21:30:52 +00:00
Nick Mathewson	e24d540d81	We no longer need dirserv_load_from_directory_string, so dirserv_add_descriptor no longer has to keep track of where each descriptor ends. svn:r4861	2005-08-26 21:28:16 +00:00
Nick Mathewson	208bdf5f27	No need to load cached directory twice svn:r4860	2005-08-26 21:19:58 +00:00
Roger Dingledine	715b972300	disarm a trap svn:r4859	2005-08-26 21:12:53 +00:00
Nick Mathewson	47669fa0fd	Fix assert failure on directory startup. svn:r4858	2005-08-26 21:12:34 +00:00
Nick Mathewson	f559c49c39	Make network-status strings wellformed svn:r4857	2005-08-26 21:11:53 +00:00
Nick Mathewson	47aa42fc17	Remove a field that nobody sets or uses. svn:r4856	2005-08-26 21:11:34 +00:00
Nick Mathewson	9a3be928e9	Note that a descriptor has changed when we receive a new directory. svn:r4855	2005-08-26 21:02:18 +00:00
Nick Mathewson	0e649ac60a	Remove descriptor_list and use routerlist instead. Make directories manage routerlist a little better. svn:r4854	2005-08-26 20:59:04 +00:00
Roger Dingledine	a47765a16d	stop freeing the new global options list whenever we update it. svn:r4853	2005-08-26 20:26:20 +00:00
Roger Dingledine	237f58524f	make it clearer which elements of routerinfo_t are for reachability testing svn:r4852	2005-08-26 20:22:32 +00:00
Roger Dingledine	f3bccdce73	if dirservers set assumereachable, it overrides their individual reachability testing svn:r4851	2005-08-26 20:08:12 +00:00
Roger Dingledine	61f728f4fe	fix an infinite loop at hup svn:r4850	2005-08-26 20:07:55 +00:00
Nick Mathewson	7f78be1659	Clean up the "add myself as a trusted dirserver" code. svn:r4849	2005-08-26 19:31:51 +00:00
Nick Mathewson	43488472ec	The circus music begins playing as nickm and arma juggle an ntohl. Hoop-lah! svn:r4848	2005-08-26 19:25:36 +00:00
Nick Mathewson	ee76baae3d	move a wandering ntohl svn:r4847	2005-08-26 19:23:52 +00:00
Nick Mathewson	0239249160	Only free strmap if it is allocated. svn:r4846	2005-08-26 18:48:13 +00:00
Nick Mathewson	cf90a36dd1	Add quotes around filenames in src/or svn:r4845	2005-08-26 18:44:26 +00:00
Nick Mathewson	ff25a7707a	fix syntax err svn:r4843	2005-08-26 18:35:52 +00:00
Nick Mathewson	88989be99b	More documenting svn:r4842	2005-08-26 18:02:49 +00:00
Nick Mathewson	e204dd5d2a	Remove accidentally added printf svn:r4841	2005-08-26 15:35:43 +00:00
Nick Mathewson	d54d7b7ec1	Add some documentation; move the signature generation logic into routerparse.c along with the hash generation logic; make router signing use it as well. svn:r4840	2005-08-26 15:34:53 +00:00
Roger Dingledine	893acb3acc	Make a new AssumeReachable config option that will publish anyway. Also, let authdirservers start without setting their Address field. Something is still not working though. Will fix in morning. svn:r4839	2005-08-26 07:41:19 +00:00
Nick Mathewson	e68bed8782	Fall back to routerlist instead of descriptor_list when we are a cache. svn:r4837	2005-08-25 20:54:12 +00:00
Nick Mathewson	4dc3cb9fd9	Fix a segfault when starting a dir cache svn:r4836	2005-08-25 20:45:53 +00:00
Nick Mathewson	54a6a8f0ef	Start implementing the server side of the new directory protocol. Probably very buggy, since I can't actually run an authdir. Features - Generate and publish new network-status format - Code to cache and re-serve network-status objects generated by others. - Publish individual descriptors (by fingerprint, by "all", and by "tell me yours.") [Still needs compression logic] - Publish client and server recommended versions seprately. - Add digest of descriptor to routerinfo_t, so we can track them better, and length, so we can server them more easily. Cleanups - Unify code to sign directory-like things - Make resolve_my_address() able to tell you which name it wound up resolving. - Unify code to store and serve directory-like things so it all uses cached_dir_t. - Unify code to set the value of cached_dir_t objects. svn:r4835	2005-08-25 20:33:17 +00:00
Roger Dingledine	86f85f240c	be much more conservative about logging reachability complaints. the ones it logs now are probably genuine problem servers. svn:r4832	2005-08-24 14:31:32 +00:00
Roger Dingledine	e54e970a82	ha ha, that infinite loop was fun. but dirservers aren't supposed to have infinite loops. svn:r4831	2005-08-24 12:14:44 +00:00
Roger Dingledine	a120cc20c1	Dirservers now do their own external reachability testing of each Tor server, and only list them as running if they've been found to be reachable. Dirservers also log trouble servers, but only start complaining loudly after they've been up for an hour, to reduce false positives. We still need to do something about the fact that it is quite loud when there are many trouble servers. svn:r4829	2005-08-24 02:31:02 +00:00
Nick Mathewson	5d590861c4	TOR_ISSPACE, not isspace. svn:r4828	2005-08-24 02:20:31 +00:00
Nick Mathewson	b72ab23ded	check [X-]Forwarded-For headers in HTTP requests when generating log messages. Implements feature for bug 181. Arma--please review? svn:r4826	2005-08-23 22:27:17 +00:00
Nick Mathewson	50452c32ec	fix bug 180: handle duplicate lines in approved-routers files. svn:r4825	2005-08-23 22:00:35 +00:00
Roger Dingledine	f35ef825f9	Our logic to decide if the OR we connected to was the right guy was brittle and maybe open to a mitm for unverified routers. Now we be sure to check the digest, and if the nickname he claims is not a verified one then we don't care what nickname he claims. svn:r4823	2005-08-23 09:50:51 +00:00
Roger Dingledine	675f6b5f3c	that comma was important svn:r4820	2005-08-23 01:00:30 +00:00
Roger Dingledine	8b766d1b7e	fix bad logic that has been lurking for eons, that now prevented us from uploading descriptors after the first one. svn:r4818	2005-08-23 00:47:44 +00:00
Roger Dingledine	ab112ca6ad	and don't print the null string here either svn:r4816	2005-08-22 22:59:54 +00:00
Roger Dingledine	23ed3c9786	whoops, avoid printing a null string sometimes svn:r4815	2005-08-22 22:58:38 +00:00
Roger Dingledine	676b330eb2	Make DirPostPeriod config option obsolete. Force new descriptor upload every 18 hours, not 24, to avoid races. Change rate-limiting on new descriptors due to bandwidth changes, from 45 minutes to 20 minutes. svn:r4814	2005-08-22 21:53:12 +00:00
Roger Dingledine	fa64d73fc7	fix function headers from the descriptor-frequency commit svn:r4809	2005-08-22 06:45:18 +00:00
Roger Dingledine	435d2d8fde	when we begin reachability testing, log the address:port for each port we're testing, so people are more likely to notice that they're using the wrong ip address. svn:r4808	2005-08-22 05:46:02 +00:00
Roger Dingledine	d928411acd	change log entry for unreachability to explicitly suggest /etc/hosts as the culprit svn:r4807	2005-08-22 05:33:49 +00:00
Nick Mathewson	dc09c7fc73	Implement new (reduced-frequency) upload rules. arma, you should review this. svn:r4806	2005-08-22 03:10:53 +00:00
Nick Mathewson	9b6eeb81aa	Make unit tests run without segfaulting svn:r4804	2005-08-22 00:34:42 +00:00
Nick Mathewson	7a442c2c48	Make set_options a little smarter: have options_act handle transitions on its own, and only dirty our descriptor when we really want to. svn:r4802	2005-08-22 00:18:45 +00:00
Roger Dingledine	5e76bac1dd	the tor-spec says router->address must be an IP address. so refuse it if it's not. (this also fixes some potential security problems with people providing hostnames as their address and then preferentially resolving them and partitioning users.) svn:r4790	2005-08-16 02:52:27 +00:00
Roger Dingledine	04d42ea433	rotate dns and cpu workers if the controller changes options that will affect them. svn:r4787	2005-08-15 23:46:18 +00:00
Roger Dingledine	b1d3f124c4	Permit transitioning from ORPort=0 to ORPort!=0, and back. This is actually a bit more subtle, because we need to rotate the dnsworkers and cpuworkers if certain options (logs, orport, etc) change. Maybe set_options() should detect this and notify the caller that it should rotate them. Expect some mysterious crashes. svn:r4786	2005-08-15 10:30:45 +00:00
Roger Dingledine	10ff723938	initialize the dns worker cache tree whether or not we start out as a server. svn:r4785	2005-08-15 10:27:37 +00:00
Roger Dingledine	157f013d83	fix typo svn:r4784	2005-08-15 09:25:36 +00:00
Roger Dingledine	00c2ba4841	resolve a XXX svn:r4783	2005-08-15 09:19:55 +00:00
Roger Dingledine	11bc97801d	clean up some confusing logs. make MonthlyAccountingStart truly obsolete now. svn:r4782	2005-08-15 09:17:47 +00:00
Roger Dingledine	79e3f5600a	hey, we have a function for that svn:r4781	2005-08-15 08:51:20 +00:00
Roger Dingledine	3728011f36	after failing from resolve failed or misc, reset the num failures. svn:r4780	2005-08-15 03:35:15 +00:00
Roger Dingledine	f57d062d9c	Implement exit enclaves: if we know an IP address for the destination, and there's a running Tor server at that address which allows exit to the destination, then extend the circuit to that exit first. Also, if the user asks for a .exit node, cannibalize general circs for it. svn:r4779	2005-08-15 03:25:40 +00:00
Roger Dingledine	cc1b82ade8	when listing min-bandwidth servers in the controller, don't get fooled by a low bandwidthrate svn:r4777	2005-08-14 08:38:34 +00:00
Roger Dingledine	ff54050fda	let unregistered-servers take a parameter (the min bandwidth) nick, is this an ugly hack of your protocol? svn:r4775	2005-08-13 02:20:00 +00:00
Roger Dingledine	66b21a19db	Add a 'quit' command for the controller. Add a 'getinfo unregistered-servers' for arma's internal use. svn:r4774	2005-08-13 01:55:23 +00:00
Roger Dingledine	6d875b7d58	i'm sick of having my streams fail because of a confused exit node. try this band-aid to see if it gets better. svn:r4773	2005-08-13 00:31:41 +00:00
Roger Dingledine	87fcd60aa2	predict required circuits better, with an eye toward making hidden services faster on the service end. svn:r4772	2005-08-13 00:22:07 +00:00
Nick Mathewson	789374dbbd	Make GCC very happy, even with lots of warnings set. Also, try to fix some reported Solaris x86 warnings. svn:r4770	2005-08-12 17:24:53 +00:00
Nick Mathewson	21959c1bfd	start using new renddesc code svn:r4769	2005-08-12 15:05:05 +00:00
Roger Dingledine	aab541c852	We weren't cannibilizing circuits correctly for CIRCUIT_PURPOSE_C_ESTABLISH_REND and CIRCUIT_PURPOSE_S_ESTABLISH_INTRO so we were being forced to build those from scratch. This should save us a bit of time. Also fixes bug 173. svn:r4763	2005-08-12 01:26:21 +00:00
Roger Dingledine	2caa74e6ff	quiet a noisy debug svn:r4762	2005-08-12 00:34:50 +00:00
Nick Mathewson	16528aa070	Add a config-file GETINFO entry; fix a minor memory leak on some SAVECONF calls. svn:r4761	2005-08-10 18:05:20 +00:00
Nick Mathewson	c031d14633	Fix segfault in unit tests svn:r4760	2005-08-09 18:49:43 +00:00
Nick Mathewson	18abdfdf58	Replace ADDR_POLICY_ACCEPT/REJECT with its own enum svn:r4756	2005-08-09 05:22:23 +00:00
Nick Mathewson	05bced6139	check_software_version_against_directory needs a return value. svn:r4755	2005-08-09 05:20:14 +00:00
Nick Mathewson	742796c19f	Avoid sending blank lines when GETINFO replies should be empty svn:r4754	2005-08-09 05:16:29 +00:00
Nick Mathewson	943ef5256b	fix whitespace issues svn:r4752	2005-08-08 21:59:48 +00:00
Nick Mathewson	249b72f53e	Replace (Fascist)Firewall* with a new ReachableAddresses option that understands address policies. svn:r4751	2005-08-08 21:58:48 +00:00
Roger Dingledine	3ac34ae329	get rid of IgnoreVersion and the forced auto-exit mis-feature svn:r4746	2005-08-08 21:52:57 +00:00
Roger Dingledine	588e80fdcd	fix a function comment svn:r4743	2005-08-08 17:48:23 +00:00
Nick Mathewson	50cfcbe157	Note which directory server said 400 to a renddesc. svn:r4742	2005-08-08 17:32:17 +00:00
Roger Dingledine	2e918af35d	a few typo fixes svn:r4738	2005-08-07 21:58:23 +00:00
Nick Mathewson	01d0788950	Generalize FirewallPorts to FirewallIPs so I can run happily when locked in net 18. svn:r4737	2005-08-07 21:24:00 +00:00
Nick Mathewson	4e735da5da	Also set event_mask=0 in connection_free_all, and dont send events to marked control conns (for good measure) svn:r4729	2005-08-07 19:27:38 +00:00
Roger Dingledine	5c4da9dec6	incomplete patch for matt's info controller signal term bug svn:r4728	2005-08-07 19:20:55 +00:00
Nick Mathewson	999b7951c3	Shorten hidden service port config parsing; fix bug 174 svn:r4725	2005-08-06 21:35:04 +00:00
Nick Mathewson	52475ee19b	Alphebetize config variables svn:r4714	2005-08-05 01:35:43 +00:00
Nick Mathewson	4870877231	Add SOCKSAndDNS link to appropriate log message, since we wind up pointing everybody to it anyway svn:r4695	2005-08-04 20:12:44 +00:00
Nick Mathewson	4cb89fd557	Implement some more GETINFO goodness: expose helper nodes, config options, getinfo keys. svn:r4694	2005-08-04 19:56:41 +00:00
Nick Mathewson	303258972b	Fix idiot bug. The "free the IP history" code belons in connection_free_all(), not in connection_free(). You can all mock me now. svn:r4691	2005-08-04 18:29:01 +00:00
Nick Mathewson	11ff0aba80	Make clients regenerate their keys when their IP address changes. svn:r4688	2005-08-03 20:42:17 +00:00
Nick Mathewson	ceb02cee2c	If they havent told us by now, they probably never will. svn:r4687	2005-08-03 20:37:13 +00:00
Nick Mathewson	d90841ff5a	Fix bug in state parsing svn:r4681	2005-07-28 19:08:51 +00:00
Nick Mathewson	299af3d393	Possibly broken implementation of persistant state; handles helper nodes; does not handle accounting info yet. svn:r4680	2005-07-28 19:01:48 +00:00
Roger Dingledine	a32f936346	whoops, fix compile svn:r4674	2005-07-25 10:36:01 +00:00
Roger Dingledine	1e0fdcae98	parameterize RephistTrackTime svn:r4673	2005-07-25 10:29:21 +00:00
Roger Dingledine	9385a96235	fix typos svn:r4645	2005-07-23 04:35:58 +00:00
Nick Mathewson	bb4ebaac6f	document code for hibernation svn:r4644	2005-07-23 04:12:35 +00:00
Nick Mathewson	2bd6040f62	Rename cross-format config.c stuff to config_* and or_options_t-specific stuff to option[s]_* svn:r4641	2005-07-23 01:58:05 +00:00
Nick Mathewson	3cb7b97660	Fix out-of-place declaration svn:r4640	2005-07-23 01:52:24 +00:00
Nick Mathewson	18c11eb3bc	Be consistent about preferring foo* to struct foo* svn:r4637	2005-07-22 21:12:10 +00:00
Nick Mathewson	c252a76f0b	Parameterize configuration parsing functions svn:r4635	2005-07-22 20:37:42 +00:00
Nick Mathewson	c3a62c1739	Initial, somewhat dodgy implementation of helper nodes. It has too many XXXXs, it logs too verbosely, and it doesnt do persistence. svn:r4633	2005-07-22 17:32:25 +00:00
Nick Mathewson	5b4e11fa5d	Add getinfo logic for accounting; add options for helper nodes svn:r4632	2005-07-22 14:55:09 +00:00
Roger Dingledine	3333d27f41	we were mangling memory because we weren't allocing enough for the hidserv desc nick can you check that this is enough now? svn:r4628	2005-07-22 00:18:25 +00:00
Roger Dingledine	1efeb3908a	let hidden service descriptors publish 0 intro points nick, please check the logic here svn:r4627	2005-07-22 00:14:58 +00:00
Roger Dingledine	11bd4bc521	in circuit_list_path(), don't redundantly print the intended exit nickname when the circuit is open. svn:r4622	2005-07-20 20:33:13 +00:00
Roger Dingledine	eedb7c243e	be consistent about printing out key digest $'s when we're getting a different key than we expect svn:r4609	2005-07-19 21:26:24 +00:00
Roger Dingledine	7ac36a9a74	unit tests to prove i didn't screw up svn:r4602	2005-07-18 23:36:12 +00:00
Roger Dingledine	e479cc935e	stop asserting if we have a controller listening for circuit events and we're offline so we fail to make a circuit and it tries to notify us about the zero-length circuit. svn:r4600	2005-07-18 23:18:00 +00:00
Roger Dingledine	5fe18894b9	now that we're recommending 0.1.1.x-alpha for win32 and os x users, stop printing debug stuff once a minute svn:r4596	2005-07-18 19:16:17 +00:00
Roger Dingledine	e8a1b1d6a0	add a trivial tor-counting variable svn:r4593	2005-07-18 06:09:04 +00:00
Roger Dingledine	43a28a4ca9	make event streams work with control v1 too svn:r4590	2005-07-17 22:28:01 +00:00
Roger Dingledine	6ac245793c	downgrade a warning that could plausibly happen sometimes now that we have controllers. svn:r4589	2005-07-17 21:43:47 +00:00
Roger Dingledine	090836d171	correct error message in closestream svn:r4588	2005-07-17 21:36:33 +00:00
Roger Dingledine	ebf13c6282	not not zero means zero svn:r4587	2005-07-17 21:22:18 +00:00
Roger Dingledine	5643532bd9	if the controller asks to extendcircuit to circid 0, we need to init the circuit before we can add hops to its cpath. svn:r4586	2005-07-17 21:13:36 +00:00
Roger Dingledine	fe7535c5e2	arguments in EXTENDCIRCUIT were reversed and an error message was misleading and we were leaking memory on some errors more bugs remain svn:r4585	2005-07-17 21:06:00 +00:00
Nick Mathewson	2cff73e7a4	Make "Couldnt add router to list" message more descriptive. Make messages consistenly punctuated. svn:r4582	2005-07-15 19:40:38 +00:00
Nick Mathewson	f8b48176ed	Fix several bugs in read_escaped_data; add a unit test and a few docs svn:r4580	2005-07-15 19:31:11 +00:00
Nick Mathewson	441e02d4ac	Merge patch from Matt Edman for bug 162 (service never stops) svn:r4578	2005-07-15 19:09:36 +00:00
Roger Dingledine	545c2c6c87	the other half of the bugfix: tolerate a trusted dirserver claiming dirport 0 in its descriptor. svn:r4576	2005-07-15 18:56:59 +00:00
Roger Dingledine	97174b67c2	if you're an auth dir server, always publish your dirport, even if you haven't yet found yourself to be reachable. this is the cause of Jan Tore Morken's recent or-talk bug. svn:r4575	2005-07-15 18:49:35 +00:00
Roger Dingledine	83dc42055d	point out some bugs for nick, noticed by whiteout svn:r4574	2005-07-15 18:48:38 +00:00
Roger Dingledine	452c98058f	missed one svn:r4567	2005-07-14 23:08:55 +00:00
Roger Dingledine	d8d0feb633	tell us what kind of listener it is, too svn:r4566	2005-07-14 23:07:05 +00:00
Nick Mathewson	f86a1e634f	fix opening listener log msg svn:r4565	2005-07-14 23:04:31 +00:00
Nick Mathewson	e94f95a716	Populate address field of listeners with an actually sane value. svn:r4564	2005-07-14 22:56:17 +00:00
Roger Dingledine	ceae96a3a0	put in tor26's new IP address svn:r4560	2005-07-14 22:37:52 +00:00
Nick Mathewson	331942870e	fix problems noticed by arma in rendservice.c svn:r4558	2005-07-14 16:41:47 +00:00
Nick Mathewson	149e9a5900	remove pointless XXXX. It was there to remind me to do something I already did. svn:r4557	2005-07-14 16:37:33 +00:00
Roger Dingledine	4a6bf116e7	substantive changes on nick's rendezvous commit. nick, can you fix these? svn:r4554	2005-07-14 08:45:19 +00:00
Roger Dingledine	2259032ea1	trivial changes on nick's rendezvous commit svn:r4553	2005-07-14 08:43:19 +00:00
Roger Dingledine	19810ba38e	make it more pleasant to be told you're using libevent svn:r4548	2005-07-13 21:22:34 +00:00
Roger Dingledine	306f7d320c	make a notice-level log make more sense. svn:r4547	2005-07-13 21:12:33 +00:00
Nick Mathewson	97c58f066a	whitespace fixes svn:r4544	2005-07-13 17:24:55 +00:00
Nick Mathewson	cf13b3e4a6	Macro-fu to get DEBUG events working. svn:r4539	2005-07-13 05:14:42 +00:00
Roger Dingledine	ddecb1a04d	looks like we were never delivering deflated running-routers lists svn:r4536	2005-07-12 22:56:22 +00:00
Roger Dingledine	7c7c95c3f6	anonymous bugfix on our pointer arithmetic svn:r4535	2005-07-12 22:56:06 +00:00
Nick Mathewson	0828feaf7c	Add belt-and-suspenders fix to coredump from yesterday; document more functions in buffers.c svn:r4532	2005-07-12 18:19:30 +00:00
Roger Dingledine	8f9790a023	fix a seg fault with autodetecting which controller version is being used svn:r4531	2005-07-12 05:48:15 +00:00
Nick Mathewson	63f9a8baa2	Canonicalize option names even on defaulted options. svn:r4530	2005-07-11 18:11:54 +00:00
Nick Mathewson	50a206e800	Do not reverse command-line configuration options; Use new minimal-listener-close code; Add code to canonicalize configuration names. svn:r4529	2005-07-11 17:35:36 +00:00
Nick Mathewson	658e1196d0	Change retry_listeners: when force is false, close and re-open a minimal set of listeners (i.e., those that do not match the configuration). This fixes a possible bug on some windowses. Maybe. svn:r4528	2005-07-11 17:20:22 +00:00
Nick Mathewson	e1db33971e	NT service patch from Matt Edman to improve error messages, lightly cleaned; needs more testing. svn:r4527	2005-07-09 16:37:12 +00:00
Roger Dingledine	2f1f0c8d21	be flexible in what you accept: when people type "tor --install" thinking they had typed "tor -install", make it work too. svn:r4526	2005-07-09 03:28:58 +00:00
Roger Dingledine	5c1ba5dcf7	fix compile error in cvs svn:r4520	2005-07-02 00:18:09 +00:00
Nick Mathewson	b11e314f2e	Be more explicit about which IP we are connecting to; expose future exit policy problems better. svn:r4519	2005-07-01 13:40:29 +00:00
Roger Dingledine	271d49958e	fix another compile warn svn:r4516	2005-07-01 02:02:24 +00:00
Roger Dingledine	3bb756b93b	forward-port the 0.1.0.11 stuff svn:r4515	2005-07-01 02:01:21 +00:00
Roger Dingledine	055477f121	fix compile error (and likely a a crash bug in resolves) svn:r4514	2005-07-01 01:59:37 +00:00
Nick Mathewson	d85bfe83bf	Make errors retrievable from tor_socketpair; resolve bug 163. svn:r4509	2005-06-30 07:17:38 +00:00
Nick Mathewson	ec83652357	Logic to implement rendezvous/introduction via unknown servers. - Add a new extend_info_t datatype to hold information needed to extend a circuit (addr,port,keyid,onion_key). Use it in cpath and build_state. Make appropriate functions take or return it instead of routerinfo_t or keyid. - #if 0 needless check in circuit_get_by_edge_conn; if nobody triggers this error in 0.1.0.10, nobody will trigger it. - Implement new hidden service descriptor format, which contains "extend info" for introduction points, along with protocol version list. - Parse new format. - Generate new format - Cache old and new formats alongside each other. - Directories serve "old" format if asked in old way, "newest available" format if asked in new way. - Use new format to find introduction points if possible; otherwise fall back. Keep nickname lists and extendinfo lists in sync. - Tests for new format. - Implement new "v2" INTRODUCE cell format. - Accept new format - Use new format if we have a versioned service descriptor that says the server accepts the new format. - Add documentation for functions and data types. svn:r4506	2005-06-29 21:46:55 +00:00
Roger Dingledine	6b21c8e74f	make the local and private network masks explicit when we complain svn:r4501	2005-06-29 19:15:23 +00:00
Roger Dingledine	caf7af26d7	whitespace fix svn:r4500	2005-06-28 01:53:15 +00:00
Nick Mathewson	806da0d8b2	Compile on win32 svn:r4496	2005-06-27 23:35:04 +00:00
Nick Mathewson	30571317dd	Fix unit tests that used old signature for add_fingerprint_to_dir svn:r4495	2005-06-27 22:25:09 +00:00
Nick Mathewson	b759fe4b8d	It is not the end of the world when a router descriptor has an unrecognized kwd svn:r4480	2005-06-24 23:42:15 +00:00
Roger Dingledine	00a7a37c94	we were printing the number of idle dns workers incorrectly. svn:r4477	2005-06-23 07:57:43 +00:00
Roger Dingledine	9808fbd884	make the log message less scary when all the dirservers are temporarily unreachable svn:r4476	2005-06-22 21:59:11 +00:00
Nick Mathewson	3ff473b47b	Appease the hungry god of GCC: it wants functions to be static or prototyped! svn:r4471	2005-06-21 01:08:01 +00:00
Roger Dingledine	419d647353	more cleanups before i go wild svn:r4469	2005-06-21 01:00:42 +00:00
Roger Dingledine	9c67ae34f1	overall cleanup and streamlining and doccing also fix a DoS avenue on dirservers svn:r4468	2005-06-20 23:04:13 +00:00
Nick Mathewson	2aff87caae	Load hardware acceleration options when/where available. Can anybody test this? svn:r4467	2005-06-20 18:56:35 +00:00
Nick Mathewson	5eef9177c5	Appease verbose GCC warnings. svn:r4466	2005-06-20 09:38:29 +00:00
Nick Mathewson	eb327e7660	Add feature to handle unset (default) configuration options in GETCONF control messages svn:r4461	2005-06-19 22:38:36 +00:00
Nick Mathewson	64fc1f7bae	Implement all the rest of the new controller protocol, debug a little, add some new features, add ADDRMAP events. svn:r4460	2005-06-19 20:40:41 +00:00
Roger Dingledine	b5fd75a063	forward-port the --hash-password bug, plus other nearby fixes svn:r4459	2005-06-19 08:35:46 +00:00
Roger Dingledine	cc57e1cab1	fix stray funny-character svn:r4458	2005-06-19 08:35:16 +00:00
Nick Mathewson	d38c696d5a	The new protocol is implemented. Except for the pesky string unquoting business. And the cleanups. And the docs. And the testing. And the debugging. And the new features. Hm, I think it is time to sleep. svn:r4456	2005-06-18 03:50:08 +00:00
Nick Mathewson	3f2339d1d3	Implement EXTENDCIRCUIT and ATTACHCIRCUIT. Only SETCONFIG and AUTHENTICATE remain. svn:r4455	2005-06-18 03:09:43 +00:00
Nick Mathewson	c2f6fe9b85	Implement even more control functionality svn:r4454	2005-06-18 02:39:25 +00:00
Nick Mathewson	9b4aa8d2ab	Implement all the easy bits of the new control protocol svn:r4449	2005-06-17 20:37:21 +00:00
Nick Mathewson	f9f09f1c5e	Start implementing framework for revised control spec. svn:r4447	2005-06-17 18:49:55 +00:00
Nick Mathewson	d4972bd2e1	Remove code that has been #if-0ed for a long time. svn:r4435	2005-06-15 18:34:46 +00:00
Roger Dingledine	a3c66475f3	compile fix by agl, for code that is always commented out svn:r4427	2005-06-13 17:33:12 +00:00
Nick Mathewson	2b8fd9ceda	Allow a few EINVALs from libevent before dying. Warn on kqueue with libevent before 1.1a svn:r4419	2005-06-13 00:35:19 +00:00
Roger Dingledine	91b1fb7ff7	some more cleaning and docing svn:r4415	2005-06-11 21:17:38 +00:00
Nick Mathewson	beae4d0d32	whitespace fix svn:r4414	2005-06-11 18:59:24 +00:00
Nick Mathewson	44107b6b13	fix typo in last patch svn:r4413	2005-06-11 18:56:16 +00:00
Nick Mathewson	232861ba42	Docment or add DOCDOC comments to undocumented functions in src/or. Make function definition format uniform. svn:r4411	2005-06-11 18:52:12 +00:00
Roger Dingledine	2587fa09f9	move more docs into our code svn:r4406	2005-06-11 06:07:22 +00:00
Roger Dingledine	fcd0fc3364	flesh out the source file descriptions for doxygen svn:r4404	2005-06-11 05:31:17 +00:00
Roger Dingledine	b349e60543	don't tell people you're publishing the server descriptor if you're actually not. svn:r4387	2005-06-09 21:23:54 +00:00
Nick Mathewson	0831823763	Change end-of-file NLNL convention. It turns out arma I and I agree. svn:r4382	2005-06-09 19:03:31 +00:00
Nick Mathewson	a6f51001a5	New whitespace normalization rule: no blank line at EOF. svn:r4378	2005-06-09 16:46:51 +00:00
Roger Dingledine	15f937c95e	when a dirserver gets a mismatched fingerprint, log the expected fp and the received fp svn:r4372	2005-06-09 10:21:55 +00:00
Roger Dingledine	cfc89f8753	pay more attention to the ClientOnly config option svn:r4367	2005-06-09 08:54:42 +00:00
Roger Dingledine	d922fa7b10	fix another underflow in keeping stats these size_ts are subtle buggers svn:r4364	2005-06-09 03:57:54 +00:00
Nick Mathewson	87caad5445	Fix an underflow in buffer use conting. svn:r4360	2005-06-08 21:55:02 +00:00
Roger Dingledine	43709a9c3d	clean up the log warn a bit svn:r4357	2005-06-08 20:45:29 +00:00
Nick Mathewson	c45845204a	Fix warning about unused function when compiling with ancient libevent svn:r4355	2005-06-08 20:35:28 +00:00
Roger Dingledine	44e85544e4	absolutely refuse to let people pick internal IP addresses if they're using the default dirservers. we're getting a big pile of a dozen or so servers that have picked private IP addresses despite the warning (presumably they don't even know they have logs) svn:r4354	2005-06-08 20:32:22 +00:00
Nick Mathewson	b0538591c7	Reset buf->highwater every time buf_shrink is called, not just on suffessful shrink. svn:r4353	2005-06-08 20:17:32 +00:00
Roger Dingledine	9ed7b53143	don't upload your descriptor if rebuilding it failed svn:r4352	2005-06-08 19:45:17 +00:00
Roger Dingledine	4c43789435	Some play code to throw away old buffers sometimes rather than constantly reallocing them; just in case this is our memory problem. It looks for now like it isn't, so disabled. svn:r4349	2005-06-08 17:27:11 +00:00
Roger Dingledine	eeb6d6dba6	dump periodic memory usage stats svn:r4348	2005-06-08 17:24:58 +00:00
Nick Mathewson	be1c81a767	Fix syntax error. svn:r4346	2005-06-08 16:26:44 +00:00
Nick Mathewson	ec07e1195f	add patch for 143 and code to check for known-bad/slow libevent versions. Needs more testing. svn:r4344	2005-06-08 13:53:19 +00:00
Roger Dingledine	aff308e6d9	reenable the part of the code that tries to flush as soon as an OR outbuf has a full tls record available. perhaps this will make OR outbufs not grow as huge except in rare cases, thus saving lots of cpu time plus memory. svn:r4343	2005-06-08 04:55:06 +00:00
Roger Dingledine	1a5c5452b4	when you send a USR2 signal, the log message now tells you to send a HUP signal if you want to change back to old log levels. svn:r4332	2005-06-07 18:16:14 +00:00
Nick Mathewson	621ab95e59	Fix for 152: reject malformed .onion addresses rather then passing them on svn:r4329	2005-06-07 18:01:46 +00:00
Nick Mathewson	2118e5798a	Use correct errno from libevent on win32 svn:r4327	2005-06-07 17:32:33 +00:00
Nick Mathewson	e1c8aa8035	Fix win32 compilation: backport candidate svn:r4320	2005-06-06 20:06:10 +00:00
Nick Mathewson	fc40f974c2	When RNG seeding fails, die. Backport candidate svn:r4319	2005-06-06 20:02:33 +00:00
Nick Mathewson	baa10cbbfa	Instrument buffers.c and rephist.c memory usage svn:r4317	2005-06-06 17:03:21 +00:00
Nick Mathewson	9f24078452	Fix buffer overlow when checking hashed passwords svn:r4308	2005-06-05 14:28:47 +00:00
Nick Mathewson	3c58cdf280	Add unit test for openpgp s2k svn:r4306	2005-06-04 13:43:03 +00:00
Roger Dingledine	4855990d37	clean up a few more log entries svn:r4304	2005-05-27 17:43:43 +00:00
Roger Dingledine	bfc7838b97	downgrade the 'caught sigpipe' notice. we're going to pretend like all of these are fine. svn:r4301	2005-05-25 02:20:15 +00:00
Roger Dingledine	4f0d7b82ae	make lucky's weird libevent poll einprogress bug just warn, not kill tor. svn:r4300	2005-05-24 22:58:57 +00:00
Nick Mathewson	d2cdae221d	Fix not-freed-on-exit event svn:r4298	2005-05-24 17:13:15 +00:00
Roger Dingledine	5005f682ae	Bugfix: we were checking to see if you want to send a keepalive, based on five minutes since last successful write. But if you have bytes queued already, and they're not getting through, we were adding a new keepalive every second. This was bad. svn:r4296	2005-05-23 22:20:54 +00:00
Roger Dingledine	040a748d87	i screwed up the dirport reachability testing when we don't yet have a cached version of the directory. hopefully now fixed. svn:r4284	2005-05-23 05:20:52 +00:00
Nick Mathewson	751db63a17	Always disable kqueue on OSX. It seems linked to kernel panics svn:r4282	2005-05-23 04:28:58 +00:00
Nick Mathewson	11a64692c3	Make hashed controller password encoding use hex not base64; this makes it possible to write a controller without base64 svn:r4279	2005-05-23 02:31:53 +00:00
Roger Dingledine	b86716b839	If a socks connection ends because read fails, don't warn that you're not sending a socks reply back. (bug reported by Warren Barrow) svn:r4277	2005-05-21 00:15:23 +00:00
Roger Dingledine	d22c141659	we were leaking 616 bytes every time somebody established us as an intro point for their hidden service. svn:r4276	2005-05-20 22:14:33 +00:00
Roger Dingledine	c95677725a	a note for nick about other memory not freed at exit svn:r4275	2005-05-20 22:11:46 +00:00
Roger Dingledine	f0e309e5bd	add HttpProxyAuthenticator config option too svn:r4272	2005-05-20 08:51:45 +00:00
Roger Dingledine	0fa1890e0e	fix the assumption that uninitialized variables are 0 clean up router_load_single_router() more svn:r4266	2005-05-18 03:52:07 +00:00
Roger Dingledine	fe78aac027	fix seg faults when router_load_single_router fails svn:r4265	2005-05-18 03:42:46 +00:00
Nick Mathewson	e7354725bb	Handle relay cells with rh.length too large. svn:r4264	2005-05-17 20:00:24 +00:00
Roger Dingledine	9abef5e483	allow the middle hop of the testing circuit to be running any version, now that most of them have the bugfix to let them connect to unknown servers. svn:r4263	2005-05-17 19:46:43 +00:00
Roger Dingledine	b7d6b8a397	doxygeny goodness from tyranix svn:r4262	2005-05-17 17:01:36 +00:00
Roger Dingledine	ec1331d49e	fix a comment that tyranix noticed svn:r4239	2005-05-17 01:55:53 +00:00
Roger Dingledine	2812d4a08c	free some memory that is still reachable on exit svn:r4234	2005-05-16 10:32:10 +00:00
Nick Mathewson	530da0e772	Normalize whitespace svn:r4233	2005-05-16 01:04:28 +00:00
Roger Dingledine	28195a0eb1	clean up some log entries svn:r4228	2005-05-15 05:00:24 +00:00
Nick Mathewson	9bc6e3aa6c	Add an explanatory comment svn:r4222	2005-05-15 02:05:45 +00:00
Roger Dingledine	3c9ec416f6	fix a case error in suppressing a bogus libevent warning. nick, was this lower-case for a reason? have both cases appeared? or was this just a typo. svn:r4206	2005-05-14 05:14:36 +00:00
Roger Dingledine	07230a698c	if router_resolve fails on the descriptor the controller gives us, we shouldn't leave the routerinfo in the list. svn:r4205	2005-05-14 05:01:41 +00:00
Roger Dingledine	b92a77b1d2	move the periodic buffer shrinking interval from 3 mins to 1 min svn:r4204	2005-05-14 01:11:45 +00:00
Nick Mathewson	00f2a09380	Append default exit policy before checking for implicit internal addresses: fix bug 129. svn:r4201	2005-05-14 00:13:17 +00:00
Nick Mathewson	776b411dc9	Fix a segfault svn:r4191	2005-05-11 04:14:17 +00:00
Nick Mathewson	3893b3c7ac	Patch for task 133 svn:r4189	2005-05-10 22:33:45 +00:00
Nick Mathewson	d0c0d6c86a	Apply patch from Geoff for bug 132. Clean it up a little to fix a memory leak and to avoid unnecessary parse/unparse code. svn:r4188	2005-05-10 22:12:48 +00:00
Nick Mathewson	13126eeb0f	Patch from goodell for task 131: Do not die on internal address if we are not publishing. svn:r4186	2005-05-09 04:31:00 +00:00
Nick Mathewson	10b2208d93	Make Tor compile with no warnings with gcc4.0 on OSX svn:r4184	2005-05-07 05:55:06 +00:00
Nick Mathewson	6567ec9ccf	Functions work better when you call them. Resolve a bug which would prevent unreachable dirports from getting suppressed. svn:r4183	2005-05-07 05:17:36 +00:00
Nick Mathewson	bc51c8b074	Implement --verify-config command-line option to fix bug 69. svn:r4182	2005-05-07 04:49:09 +00:00
Roger Dingledine	cee7c5988c	fix massive memory leak (50 megabytes over a couple of days, on the dirservers) svn:r4181	2005-05-06 08:53:23 +00:00
Roger Dingledine	cc0b19888d	log buffer sizes on kill -usr1 too. svn:r4180	2005-05-06 08:32:37 +00:00
Roger Dingledine	1f263bf6f5	whine at you if you're a server and you don't set your contactinfo svn:r4178	2005-05-04 20:45:38 +00:00
Roger Dingledine	68ba303323	fix compile error if you're not multithreaded svn:r4177	2005-05-03 18:44:20 +00:00
Roger Dingledine	6ea839265d	remove archaic debugging aid that was probably unsafe svn:r4176	2005-05-03 10:17:38 +00:00
Roger Dingledine	87850c47b0	cleanup now that 0.0.9pre1 is obsolete svn:r4175	2005-05-03 10:12:08 +00:00
Roger Dingledine	5265bbd2b8	first iteration of scrubbing sensitive strings from logs. also generally clean up log messages. svn:r4174	2005-05-03 10:04:08 +00:00
Nick Mathewson	b35f7dacef	Call tor_free_all instead of connections_free_all after forking svn:r4173	2005-05-03 03:51:20 +00:00
Nick Mathewson	8b9ae25224	Change some >=s to >s in buf_resize, so that we do not denormalize buffers on resize. svn:r4172	2005-05-03 03:25:04 +00:00
Nick Mathewson	4666b801fa	If DataDir is ~/.tor, and that expands to /.tor, then default to LOCALSTATEDIR/tor instead. svn:r4170	2005-05-03 00:36:57 +00:00
Nick Mathewson	14bac4dad4	Elaborate on buf_shrink comment. svn:r4169	2005-05-02 23:41:39 +00:00
Roger Dingledine	aa6bcd50ca	comment buf_shrink svn:r4168	2005-05-02 23:39:09 +00:00
Nick Mathewson	ad547cbb8c	Correct and simplify buf_shrink logic svn:r4167	2005-05-02 23:36:13 +00:00
Nick Mathewson	d6a6c8785b	When removing all bytes from a buffer, reset buf->cur=buf->mem svn:r4166	2005-05-02 23:32:23 +00:00
Nick Mathewson	a312ce1d3b	Change buffer shrinking strategy: only try to shrink once every 3 minutes. Do not try to read over buffer size unless buffer is nearly empty. svn:r4165	2005-05-02 23:17:08 +00:00
Nick Mathewson	9c683c7613	Make buffer shrinking algorithm a little smarter. svn:r4164	2005-05-02 22:49:24 +00:00
Nick Mathewson	830ac87611	Actually, dont send CREATE_FAST cells at all for now svn:r4163	2005-05-02 22:39:59 +00:00
Nick Mathewson	ab34901263	New and frightening code to implement fast-path first-hop CREATE_FAST cells. Watch out when we bump the version to 0.1.0.6-rc! svn:r4162	2005-05-02 22:35:18 +00:00
Roger Dingledine	978648bff8	also print the platform string for rejected descriptors svn:r4160	2005-05-02 22:06:04 +00:00
Roger Dingledine	15c1853bd6	don't print nulls svn:r4159	2005-05-02 21:54:16 +00:00
Roger Dingledine	c9e83eb1b4	when we refuse a router descriptor, log contactinfo and source address. svn:r4156	2005-05-02 21:48:54 +00:00
Roger Dingledine	57b7427c2d	reformat routerparse a bit svn:r4155	2005-05-02 21:48:25 +00:00
Nick Mathewson	69dc4e1675	Remove support for looking at old directory/routerdesc elements; mark non-new elements optional; switch to new format for dir-signing-key; start accepting newer elements so we can mark them as non-opt later; make tor-spec say the right stuff. svn:r4154	2005-05-02 21:22:31 +00:00
Roger Dingledine	729e720095	workaround for user error: some people were putting "Address " in their torrc, and they had a buggy resolver that resolved " " to 0.0.0.0. Oops. svn:r4150	2005-04-29 18:52:05 +00:00
Nick Mathewson	fe65e57ca1	Re-do fragmented control message handling to work with new buf_t system. svn:r4144	2005-04-27 22:01:34 +00:00
Nick Mathewson	d0a9a8bdd3	Appease VC7. It has a strangely puritanical attitude about what programmers are allowed to do a consenting void*. svn:r4140	2005-04-27 20:02:52 +00:00
Nick Mathewson	53607d3bb3	Turn SENTINELS back on; give NOINLINE a name and turn it off. svn:r4139	2005-04-27 19:40:31 +00:00
Roger Dingledine	4c4a14e3cb	turn off the mongo debugging stuff, for performance tests svn:r4137	2005-04-27 17:21:42 +00:00
Roger Dingledine	543d31c89a	bump the default bandwidthrate from 1mb to 2mb svn:r4131	2005-04-27 04:13:59 +00:00
Nick Mathewson	52376dc9e8	Rename buf->start to buf->cur; fix bug in read_to_buf; still debug with paranoia. svn:r4130	2005-04-27 02:55:21 +00:00
Nick Mathewson	746768df5d	Add even more debugging code; temporarily disable inlines in buffers.c svn:r4129	2005-04-27 00:53:44 +00:00
Roger Dingledine	914ee87e07	stop re-reading and re-parsing the directory as soon as we make it. it was nice for checking if we've got bugs, but it's really quite expensive too. it was also nice for updating our routerinfo's immediately, but we'll update them like everybody else when we fetch a new dir from somebody else. svn:r4128	2005-04-27 00:48:05 +00:00
Roger Dingledine	adaf3d31e6	hidden service client connections were using some of their 60 seconds fetching the hidserv descriptor, which made them more likely to fail on the first attempt, yet they work fine on the second. so now give them extra time for the first try. svn:r4127	2005-04-26 22:36:00 +00:00
Roger Dingledine	2a7aec0ffd	fix function prototype, fix typo svn:r4126	2005-04-26 21:29:20 +00:00
Nick Mathewson	ecc76d8245	Avoid overflow on wrapping a TLS read. svn:r4125	2005-04-26 21:20:22 +00:00
Nick Mathewson	e6794e5808	Fix unit tests for buffers. svn:r4124	2005-04-26 21:10:31 +00:00
Nick Mathewson	9ba2dd7ea1	Clean/renormalize whitespace svn:r4122	2005-04-26 20:55:32 +00:00
Nick Mathewson	ef2409e4ed	Change the implementation of buf_t a lot: make it a ring buffer to minimize memmove on flush. This may break the universe, but it is probably Necessary For Perfomance. svn:r4121	2005-04-26 20:53:22 +00:00
Roger Dingledine	4eb3cf9330	a bit more debug info svn:r4119	2005-04-26 20:05:15 +00:00
Roger Dingledine	953cf91ecd	add more debugging info to help us find the weird dns freebsd pthreads bug. svn:r4117	2005-04-26 19:08:06 +00:00
Roger Dingledine	509405a5f7	clean up this TOR_FRAGILE business svn:r4116	2005-04-26 18:52:16 +00:00
Roger Dingledine	5e86e87124	Add basic HttpsProxyAuthenticator support, based on patch from Adam Langley. svn:r4115	2005-04-26 18:33:33 +00:00
Roger Dingledine	4fafa81f32	help debug: when we close a conn due to timeout, tell us its file descriptor, not its connectionarray index. svn:r4113	2005-04-25 17:24:16 +00:00
Roger Dingledine	662cfc976d	only call the connection open once we've decided we like the cert. svn:r4112	2005-04-25 17:23:52 +00:00
Roger Dingledine	f3ea883ccd	bugfix: stop trying to print a null pointer if an OR conn fails because we didn't like its cert. svn:r4111	2005-04-25 15:43:37 +00:00
Roger Dingledine	12ea3a26b2	bugfix: make a debug log stop lying svn:r4110	2005-04-25 15:43:05 +00:00
Roger Dingledine	92b970d2a6	only complain about wedged cpuworkers after an hour, not 100 secs svn:r4100	2005-04-23 20:58:44 +00:00
Roger Dingledine	6128cdead0	let NumCpus be singular without whining svn:r4097	2005-04-23 19:29:09 +00:00
Nick Mathewson	5827e2e216	Fix "JAP-client" hideous ASN1 bug, twice. (Fix1: check more thoroughly for TLS errors when handling certs. Fix2: stop assert(0)ing on uncaught TLS errors.) svn:r4085	2005-04-23 14:26:02 +00:00
Roger Dingledine	ad4eca60ec	add geoff's NoPublish patch svn:r4084	2005-04-21 10:40:48 +00:00
Nick Mathewson	ce9995a579	Replace an infinite-stack-recursion bug with a generate-infinite-debug-messages bug. Maybe it isnt such a good idea to send LOG_DEBUG messages to the controller after all? svn:r4082	2005-04-17 22:52:02 +00:00
Nick Mathewson	cf84759b4b	zero-out errno before calling event_dispatch, just in case we have misdiagnosed poll(2)/EINVAL bug. svn:r4081	2005-04-17 22:38:39 +00:00
Roger Dingledine	769541ff7e	be willing to load balance over up to 2mB, not 1mB, of advertised capacity svn:r4080	2005-04-12 22:09:47 +00:00
Roger Dingledine	bf79b5266f	those should be notices, not warns svn:r4079	2005-04-12 22:09:04 +00:00
Nick Mathewson	f1dfa30064	Fix postdescriptor behavior: on non-complete success, only say "done" once. svn:r4073	2005-04-11 02:52:09 +00:00
Roger Dingledine	e2cdc87485	remove some redundant code svn:r4062	2005-04-08 06:16:09 +00:00
Nick Mathewson	656e31ba33	If it has not been 100 seconds since we told the cpuworker about an onion, complain! Oh, wait... svn:r4059	2005-04-08 04:59:34 +00:00
Nick Mathewson	74dc7eedc5	Add kludgy function to force controllers to flush EVENT_ERR_MSG events. svn:r4057	2005-04-08 03:36:39 +00:00
Nick Mathewson	31c12e265f	Move a quote, fix a log. svn:r4056	2005-04-08 03:26:44 +00:00
Nick Mathewson	c6769a80fb	Fixs a signed/unsigned comparison svn:r4055	2005-04-08 03:26:23 +00:00
Nick Mathewson	6face4f482	Add missing "char" svn:r4054	2005-04-08 03:07:07 +00:00
Roger Dingledine	97637549bb	tie MAX_DIR_SIZE to MAX_BUF_SIZE resolve bug 80 svn:r4052	2005-04-07 22:13:17 +00:00
Roger Dingledine	dabafddb82	fix format bug svn:r4051	2005-04-07 22:03:56 +00:00
Roger Dingledine	ec3650f00f	only whine about clock skew from the dirserver if he's a trusted dirserver. svn:r4048	2005-04-07 21:09:19 +00:00
Nick Mathewson	8cc3307e0d	Improve conn_*_to_string; add circuit_state_to_string; make skewed-descriptor messages better. svn:r4047	2005-04-07 21:07:19 +00:00
Roger Dingledine	dd98412ce1	allow servers to publish descriptors from 12 hours in the future. hopefully this will allow more slack and let crummier servers help out too. svn:r4046	2005-04-07 21:01:00 +00:00
Nick Mathewson	b897cb1ec3	Change conn_(type\|state)_to_string from const arrays to switch functions so we (I) will not make Tor crash the next time we (I) add a new state. svn:r4045	2005-04-07 20:25:22 +00:00
Roger Dingledine	6bdfd97272	add function comment svn:r4043	2005-04-07 20:07:34 +00:00
Roger Dingledine	ab8a0bb52c	We have a bug that I can't find. Sometimes, very rarely, cpuworkers get stuck in the 'busy' state, even though the cpuworker process thinks of itself as idle. I don't know why. But here's a workaround to kill any cpuworker that's been busy for more than 100 seconds. svn:r4042	2005-04-07 20:02:00 +00:00
Nick Mathewson	c92a2620d4	Try RB_TREE instead of SPLAY_TREE, but with a single-entry caching optimization. svn:r4041	2005-04-07 05:09:19 +00:00
Nick Mathewson	a035b8e3c3	Make compare_orconn_circid_entries marginally faster and inlined, if that helps svn:r4040	2005-04-07 04:50:25 +00:00
Nick Mathewson	7709547c08	When we connect and finish TLS negotiation with address:port, it is obvious that any other key or nickname we might know about (as an authdirserver) does not actually exist at address:port. svn:r4036	2005-04-06 21:09:47 +00:00
Roger Dingledine	03720b39fd	stop wasting time doing a case insensitive comparison for every dns name every time we do any lookup. canonicalize the names to lowercase and be done with it. svn:r4035	2005-04-06 20:25:21 +00:00
Roger Dingledine	46089c49c4	blow away most calls to assert_all_pending_dns_resolves_ok, since they're eating our cpu. svn:r4034	2005-04-06 20:05:34 +00:00
Roger Dingledine	652dde72f1	bugfix: chdir to your datadirectory at the end of the daemonize process, not the beginning. this was a problem because the first time you run tor, if your datadir isn't there, and you have runasdaemon set to 1, it will try to chdir to it before it tries to create it. oops. svn:r4033	2005-04-06 19:07:38 +00:00
Roger Dingledine	8596947ee2	quiet another instance where we whine to an innocent OR operator's logs when some other server switches keys unexpectedly. svn:r4032	2005-04-06 18:55:14 +00:00
Roger Dingledine	620419b421	oh, and accept() into the right place, too. svn:r4029	2005-04-06 16:16:31 +00:00
Roger Dingledine	70f3b3ef86	Forward-port the checking of sin_addr.s_addr == 0 \|\| sin->sin_port == 0. This just happened on moria2, so I guess it happens rarely on Linux as well as OS X. We can't afford to accept OR conns from 0.0.0.0:0, since we send created cells back to the first addr:port that matches, and we'd better not send them to the wrong place. So, let's drop them all for now, and see if we can find a pattern later. svn:r4028	2005-04-06 15:42:35 +00:00
Roger Dingledine	9cbaf4603d	fix an assert trigger: when we have the rare case of accepting a conn on 0.0.0.0:0, then when we look through the connection array, we'll find any of the workers. this is no good. svn:r4027	2005-04-06 15:19:32 +00:00
Nick Mathewson	88dc243bb5	Rename circuit_get_by_stream to circuit_get_by_edge_conn, and actually start using it. Watch out, kids! svn:r4026	2005-04-06 06:43:21 +00:00
Roger Dingledine	716d9bc99a	when using preferred entry or exit nodes, ignore whether the circuit wants uptime or capacity. they asked for the nodes, they get the nodes. svn:r4025	2005-04-06 06:17:35 +00:00
Nick Mathewson	4453e3794a	Add a pointer from edge connections to their corresponding circuit (ulp!); add some debugging sanity-checking for cirid_orconn_map stuff svn:r4024	2005-04-06 06:13:49 +00:00
Nick Mathewson	2a0b1025e5	Fix bug in last commit when no circid can be found svn:r4023	2005-04-06 05:45:07 +00:00
Nick Mathewson	b34d9adb59	Fix format warning svn:r4022	2005-04-06 05:44:05 +00:00
Roger Dingledine	94cecc712d	note some features we intend to add. svn:r4021	2005-04-06 05:35:06 +00:00
Nick Mathewson	b7cdcf3462	Hopefully, this will make ORs much faster, and not break them: keep a big splay tree of (circid,orconn)->circuit mappings to make circuit_get_by_circid_conn much faster. svn:r4020	2005-04-06 05:33:32 +00:00
Roger Dingledine	712d05c19a	a bit more data on gene's dns threading bug svn:r4019	2005-04-06 05:32:24 +00:00
Roger Dingledine	5f0a84cbe2	update conn-type-state-strings to handle https states for ORs svn:r4018	2005-04-06 04:55:17 +00:00
Nick Mathewson	3014b03b67	Add missing comma. Oops svn:r4017	2005-04-06 03:20:06 +00:00
Nick Mathewson	88fe4d6292	Handle changed router status correctly when reloading fingerprint file svn:r4016	2005-04-06 01:09:26 +00:00
Nick Mathewson	1b5e2182fa	Log msg spelling fix svn:r4015	2005-04-06 00:53:13 +00:00
Roger Dingledine	f860b490be	When we're connecting to an OR and he's got a different nickname/key than we were expecting, only complain loudly if we're an OP or an authdirserver. Complaining loudly to OR admins just confuses people. svn:r4014	2005-04-06 00:50:40 +00:00
Nick Mathewson	ac268a8340	Fix Tor for no-threading compilation: move connection_unregister from _connection_free to connection_free. svn:r4013	2005-04-06 00:46:57 +00:00
Nick Mathewson	374edd356e	Change replacement semantics for directory entries: fix bug 121. svn:r4012	2005-04-06 00:01:35 +00:00
Nick Mathewson	4991290935	Revise control spec and implementation to allow all log messages to be sent to controller with their severities intact. svn:r4010	2005-04-05 22:56:17 +00:00
Nick Mathewson	46be0fa999	Make last fix work on windows too. svn:r4009	2005-04-04 21:53:26 +00:00
Nick Mathewson	0fff263a46	Fix possible bug on threading platforms with running out of fds do to cpuworkers and dnsworkers. svn:r4008	2005-04-04 21:46:08 +00:00
Roger Dingledine	f1edeebf7d	client now retries when streams end early for 'hibernating' or 'resource limit' reasons; refactor. svn:r4004	2005-04-04 03:30:49 +00:00
Roger Dingledine	823b7d4d8b	automatically approve nodes running 0.1.0.2-rc or later svn:r4001	2005-04-03 19:01:47 +00:00
Nick Mathewson	1aedf3daf5	Only warn once per nickname from add_nickname_list_to_smartlist per failure. svn:r3997	2005-04-03 05:53:34 +00:00
Nick Mathewson	11d20d78a0	Adjust maximum skew and age for rendezvous descriptors: adjust code to make skew add to age. svn:r3995	2005-04-03 05:36:23 +00:00
Roger Dingledine	658463a751	clean up the circuit-mark-for-close patch svn:r3994	2005-04-03 05:31:41 +00:00
Roger Dingledine	096879687a	start sending 'truncated' cells back rather than destroy cells, if the circuit closes in front of you. svn:r3993	2005-04-03 05:25:26 +00:00
Nick Mathewson	0dc02328af	Move most of *_mark_for_close out of macros. svn:r3992	2005-04-03 05:22:33 +00:00
Nick Mathewson	055ee7c323	Give better warnings if connection_close_unattached_ap gets called twice or called on a marked connection; rename it to connection_mark_unattached_ap. svn:r3990	2005-04-02 22:11:24 +00:00
Nick Mathewson	4a90d37229	Better messages when POSTDESCRIPTOR fails svn:r3989	2005-04-02 22:02:13 +00:00
Roger Dingledine	13e211de17	We're printing the host mask wrong in exit policies in server descriptors. I believe this isn't a critical bug tho, since we're still obeying the exit policy internally. svn:r3987	2005-04-02 08:55:31 +00:00
Roger Dingledine	8dbdbfb831	improved log error message svn:r3986	2005-04-02 08:30:40 +00:00
Nick Mathewson	0e81265359	update copyright notices. svn:r3982	2005-04-01 20:15:56 +00:00
Nick Mathewson	0d6c9c47b3	Short-term fix: prevent possible segfault in connection_close_unattached_ap svn:r3970	2005-04-01 16:04:45 +00:00
Roger Dingledine	453a822425	when you decide you're reachable, actually publish your descriptor right then. svn:r3968	2005-04-01 09:28:14 +00:00
Roger Dingledine	1ff62dbd18	require exactly 0.0.9.7 for middle hops of testing circs, for now svn:r3967	2005-04-01 09:23:51 +00:00
Roger Dingledine	e786e5dedb	when building testing circuits, always use middle hops running at least 0.0.9.7 svn:r3966	2005-04-01 08:42:26 +00:00
Roger Dingledine	a28ae7a70c	fix assert: if our dirport isn't reachable yet, don't trick ourselves into thinking the dirport is zero. but continue to tell other people that it is. svn:r3952	2005-04-01 07:42:32 +00:00
Roger Dingledine	cd25e56ad2	when the or-connect succeeded and the tls handshake succeeded but we didn't like the result, we were closing the connection without sending any destroys back for the pending circuits. now send those destroys anyway; i hope this doesn't break too much. svn:r3951	2005-04-01 07:25:18 +00:00
Nick Mathewson	73f6c1531e	fix typo in earlier libevent mmessage suppress patch svn:r3950	2005-04-01 07:16:52 +00:00
Roger Dingledine	003d9df6b0	authdirservers shouldn't do orport reachability detection, since they're in clique mode, so it will be rare to find a server not already connected to them. svn:r3949	2005-04-01 07:09:18 +00:00
Nick Mathewson	410ecfcc71	Add code to suppress spurious libevent log msgs; use it to resolve bug 68. svn:r3948	2005-04-01 07:05:21 +00:00
Roger Dingledine	2ff2db8d2a	fix some log spacing problems svn:r3942	2005-04-01 06:23:21 +00:00
Nick Mathewson	efe9ca659a	Use recent libevent features when possible svn:r3940	2005-04-01 02:37:40 +00:00
Nick Mathewson	e04a82ecaf	Patch: when extending to an unknown router, compare identity to expected identity; not nickname-to-expected identity. svn:r3937	2005-03-31 23:30:13 +00:00
Roger Dingledine	801d5ef1de	spell recommended correctly svn:r3936	2005-03-31 20:52:43 +00:00
Roger Dingledine	1f5c8335e8	still publish your descriptor if orport is reachable but dirport isn't when building testing circs for orport testing, require high-bandwidth nodes, so fewer circs fail. complain about unreachable orport separately from unreachable dirport. svn:r3935	2005-03-31 19:26:33 +00:00
Roger Dingledine	c2a05e1ca9	redo the state descriptors now that we have a controller-wait state svn:r3934	2005-03-31 17:36:24 +00:00
Roger Dingledine	4f5192b280	...and use it to make sure we only conclude reachability if we didn't initiate the conn. svn:r3932	2005-03-31 07:46:59 +00:00
Nick Mathewson	1bf1f44e74	Fix bug in redirectstream. svn:r3926	2005-03-31 06:06:02 +00:00
Roger Dingledine	5bdab005c9	mark two more bugs. nick, can you take a look? svn:r3920	2005-03-29 05:27:32 +00:00
Roger Dingledine	20a8eda31b	don't check for reachability, and don't whine about it, while we're hibernating. svn:r3919	2005-03-29 03:48:31 +00:00
Roger Dingledine	7cf33ed495	resolve another 'hasn't sent end yet' bug svn:r3911	2005-03-29 00:35:35 +00:00
Nick Mathewson	1612df7b2c	Fix a couple more places where we use ->new_address without checking that it is there. svn:r3907	2005-03-28 02:03:51 +00:00
Roger Dingledine	0e26973c02	make calls to address_is_in_virtual_range more bullet-proof. might fix the assert failure i just got. svn:r3906	2005-03-28 01:56:12 +00:00
Nick Mathewson	4246f6f8bc	Clarify that we don't, and why we don't, need to redefine FD_SETSIZE. svn:r3904	2005-03-28 01:07:14 +00:00
Roger Dingledine	96c331e4ed	we seem to have lost our define for FD_SETSIZE on win32 in the change from fakepoll to libevent. be sure to define it before we include winsock. svn:r3903	2005-03-27 22:52:48 +00:00
Roger Dingledine	9b5432214d	but only do the rapid reachability testing if we're hoping to be a server. svn:r3902	2005-03-27 11:52:15 +00:00
Roger Dingledine	b8fe866a9d	forward-port the fixing of the crash bug. svn:r3900	2005-03-27 07:18:30 +00:00
Roger Dingledine	92acd64da0	if your server hasn't found itself to be reachable, complain every 20 minutes, not just once. svn:r3897	2005-03-27 06:50:36 +00:00
Roger Dingledine	7a79acd9f6	clean up socks reply stuff more. add a few more reasons so we can be more informative. svn:r3895	2005-03-27 06:37:56 +00:00
Nick Mathewson	ce854906db	Rename ManageConnections to LeaveStreamsUnattached. Apparently, there was a missing "TorShould" that was mistaken for an "IWantTo". svn:r3894	2005-03-27 06:25:33 +00:00
Roger Dingledine	36baf7219d	stop most cases of hanging up on a socks connection without sending the socks reject. audit for remaining ones. also make things more uniform so we always remember to hold-open-until-flushed, etc. svn:r3891	2005-03-27 04:55:13 +00:00
Roger Dingledine	4533a46e41	move the assert higher up so the error message makes more sense next time. svn:r3887	2005-03-26 06:27:51 +00:00
Roger Dingledine	fcfe6d2e8b	fix assert: stop trying to send a socks reply to an exit connection when we get an end cell before it's finished opening. svn:r3886	2005-03-26 06:27:04 +00:00
Roger Dingledine	b8d38dc57b	try harder to establish reachability, in the first 20 minutes of uptime. svn:r3884	2005-03-26 05:54:50 +00:00
Roger Dingledine	1328383482	make it clearer to the human that his server is testing its reachability. tell him when it succeeds, or when 20 minutes pass and it hasn't succeeded yet. svn:r3882	2005-03-26 01:43:39 +00:00
Roger Dingledine	570da8a8e8	and fill in another missing socks reply svn:r3877	2005-03-25 11:23:03 +00:00
Roger Dingledine	9b9dbad0b7	fix another case where we need to send a socks reply (reject) back before we close the conn. svn:r3876	2005-03-25 11:12:14 +00:00
Roger Dingledine	8945df8daa	remove dead code svn:r3875	2005-03-25 10:55:49 +00:00
Roger Dingledine	9685164fe5	don't mark a router down just because your httpsproxy is unreachable svn:r3874	2005-03-25 10:55:06 +00:00
Nick Mathewson	d26bcfab92	Note where connection that hasnt sent end was marked. svn:r3872	2005-03-25 05:54:50 +00:00
Roger Dingledine	bd37c9a3bd	REUSEADDR on normal places means you can rebind to the port right after somebody else has let it go. But REUSEADDR on win32 means to let you bind to the port _even when somebody else already has it bound_. So, don't do that on Win32. svn:r3867	2005-03-24 23:20:06 +00:00
Roger Dingledine	4abb54a876	forward-port the circuit_resume_edge_reading_helper fix. svn:r3863	2005-03-24 21:57:45 +00:00
Roger Dingledine	fa3c9d94bc	when you attachstream to a circid of 0, send back an answer svn:r3857	2005-03-24 06:28:21 +00:00
Roger Dingledine	09ef2b7e41	cleanup so connection_ap_handshake_attach_chosen_circuit() always gets open circs. svn:r3856	2005-03-24 06:18:59 +00:00
Nick Mathewson	13fdf51bc1	Bulletproof connection_ap_handshake_attach_chosen_circuit svn:r3855	2005-03-24 06:05:14 +00:00
Nick Mathewson	8e8915f3ca	Fix SOCKS5 bug: Set replylen to 0 after sending hanshake back svn:r3850	2005-03-24 01:11:28 +00:00
Nick Mathewson	0cfdeb01c8	Debug EXTENDCIRCUIT svn:r3849	2005-03-24 01:08:25 +00:00
Roger Dingledine	0dc91fd9c0	fix an assert -- we're not allowed to write onto a conn after we've connection_unregistered it. there's still more work to be done here, since we need to make sure to send back the socks-reply as soon as we know what it will be -- we can't just wait until connection-about-to-close to deal with it. svn:r3847	2005-03-23 23:19:18 +00:00
Roger Dingledine	fb8a319ffe	fix an over-eager assert, to make httpsproxy get a little farther svn:r3846	2005-03-23 22:11:59 +00:00
Roger Dingledine	a799dad937	forward-port the commenting out of the assert that glenn fink was triggering. we still don't know why he was triggering it. svn:r3841	2005-03-23 20:42:37 +00:00
Nick Mathewson	4ee6addf57	Fix bug 44: on HUP, if descriptor building fails (say, because router_get_my_address() fails), use old descriptor and warn. svn:r3839	2005-03-23 20:28:40 +00:00
Nick Mathewson	6e4bccc4ac	Make GETINFO for "network-status" work on non-authdirs svn:r3837	2005-03-23 19:15:10 +00:00
Nick Mathewson	b9016bd18f	Fix several bugs (including some crashes) related to control interface; implement missing desc/name functionality. svn:r3836	2005-03-23 08:40:11 +00:00
Nick Mathewson	0b7a9e2e7b	Be willing to cache directories from up to ROUTER_MAX_AGE seconds into the future, now that we are more tolerant of skew. svn:r3832	2005-03-23 06:39:53 +00:00
Nick Mathewson	631ab5c69b	Add a magic value to cpath_layer_t to make sure that we can tell valid cpaths from freed ones. I audited this once; it could use another audit. svn:r3831	2005-03-23 06:21:48 +00:00
Nick Mathewson	905c16846a	Fix a few more instances of memory not freed on exit (found by weasel). svn:r3830	2005-03-23 06:20:50 +00:00
Nick Mathewson	b7ce4d1d3d	Correct fix for self-to-self addressmap; simplify replace-old-entry logic; add missing case. svn:r3829	2005-03-23 05:32:06 +00:00
Roger Dingledine	22386ecf1e	whoops, fix seg fault i just introduced svn:r3828	2005-03-23 03:02:44 +00:00
Roger Dingledine	7373042a7b	fix assert triggers (bugs 109 and 96), and put in some debugging logs to notice future repeat bugs. svn:r3826	2005-03-23 02:52:55 +00:00
Roger Dingledine	a523439cbc	maybe resolve an assert trigger i just got: connection_edge.c:643 address_is_in_virtual_range: Assertion addr failed; aborting. nick, what do you think? svn:r3825	2005-03-23 00:19:51 +00:00
Roger Dingledine	e28b8aaa40	make httpsproxy more likely to work (don't let OR conns do tls until they've finished connecting and doing the proxy dance.) svn:r3824	2005-03-22 23:57:18 +00:00
Roger Dingledine	21b1adefbb	fix a 32bit/64bit sprintf mixup that weasel pointed out svn:r3823	2005-03-22 23:27:29 +00:00
Roger Dingledine	ad5f5ddf7e	remove a duplicate circuit_mark_for_close() when picking a path for the circuit fails. svn:r3822	2005-03-22 23:20:33 +00:00
Roger Dingledine	6659cd5e8e	options->MaxAdvertisedBandwidth only replaces advertised bandwidthrate, not advertised bandwidthcapacity svn:r3818	2005-03-22 20:41:28 +00:00
Nick Mathewson	ab1d0049a2	Prevent spurious closes when we put stuff on a conn that has not written for a while. svn:r3816	2005-03-22 20:25:51 +00:00
Roger Dingledine	8a763b5ae3	cleanup and a question svn:r3815	2005-03-22 20:04:00 +00:00
Nick Mathewson	7a0072cc1a	Specify and implement close-stream and close-circuit control messages svn:r3814	2005-03-22 19:36:38 +00:00
Nick Mathewson	ec81f87018	Implement an option to cap bandwidth-to-advertise. Arma: can you improve the manpage entry by explaining why you would want to do this? svn:r3813	2005-03-22 19:01:46 +00:00
Nick Mathewson	2d662bf773	Clear up a couple of pedantic compiler warnings svn:r3812	2005-03-22 18:56:11 +00:00
Nick Mathewson	2d40991427	Report HTTP reasons to directory clients. (Also, fix format on new TODO items) svn:r3811	2005-03-22 18:43:24 +00:00
Roger Dingledine	d6a0e5bcc9	when reporting events about streams, use the "real" address for the stream, including the requested .exit address. svn:r3810	2005-03-22 10:34:23 +00:00
Roger Dingledine	e07e0a4732	remove obsolete code svn:r3809	2005-03-22 10:34:00 +00:00
Nick Mathewson	c4470cbedf	be more explicit about why we are expiring a conn; improve logic a bit too svn:r3808	2005-03-22 06:21:35 +00:00
Nick Mathewson	f5989afde2	Add opt hibernating; fix bug 78 svn:r3807	2005-03-22 06:08:28 +00:00
Roger Dingledine	76a03e8635	handle_control_getinfo() was counting msg_len itself, when that's actually smartlist_join_strings2()'s job. svn:r3806	2005-03-22 05:41:05 +00:00
Roger Dingledine	ed9524a626	Remove controller getinfo support for "desc/all-ids". Replace it with getinfo "network-status" just like in directories. This way the controller can learn which servers are running, which are verified, etc. svn:r3801	2005-03-22 03:27:51 +00:00
Roger Dingledine	8d1460c858	tell me the address of the guy who's trying to attack my dirserver svn:r3799	2005-03-22 01:18:50 +00:00
Roger Dingledine	f1ba4296c1	clean up and refactor some more svn:r3798	2005-03-22 01:01:15 +00:00
Roger Dingledine	35953edae0	Implement controller's "extendcircuit" directive. Also refactor circuit building so we plan the whole path ahead of time. svn:r3797	2005-03-22 00:42:38 +00:00
Roger Dingledine	4a497e5030	if our clock jumps forward by 100 seconds or more, assume something has gone wrong with our network and abandon all not-yet-used circs. svn:r3792	2005-03-19 23:58:42 +00:00
Roger Dingledine	856ab90ca8	stop logging at -l notice every single time a create cell successfully gets processed svn:r3791	2005-03-19 23:04:15 +00:00
Roger Dingledine	fbeaeb138e	and forward-port the missing space svn:r3789	2005-03-19 20:30:23 +00:00
Nick Mathewson	b88c4ba11c	Turn addr_policy_compare from a tristate to a quadstate; this should help address our "Ah, you allow 1.2.3.4:80. You are a good choice for google.com" problem. svn:r3786	2005-03-19 06:57:16 +00:00
Nick Mathewson	07a7b6af64	Implement redirectstream in control interface. svn:r3785	2005-03-19 06:05:55 +00:00
Roger Dingledine	963ddf2953	fix typo svn:r3784	2005-03-19 05:09:13 +00:00
Nick Mathewson	11aa682812	Split version info into separate spec doc. svn:r3783	2005-03-19 05:07:19 +00:00
Roger Dingledine	ec7f232b24	make hidden services more likely to work from the server-side svn:r3781	2005-03-19 04:38:59 +00:00
Nick Mathewson	b004eda10c	Enable NT service code by default svn:r3780	2005-03-19 01:04:05 +00:00
Nick Mathewson	df9c8feac7	Commit fixes for several pending tor core tasks: document all DOCDOCed functions; time out uncontrolled unattached streams; feed reasons to SOCKS5 (refactoring connection_ap_handshake_socks_reply in the process); change DirFetchPeriod/StatusFetchPeriod to have a special "Be smart" value. svn:r3769	2005-03-17 12:38:37 +00:00
Roger Dingledine	229761465c	re-enable reachability testing stuff. also, consider your ORPort reachable after you've processed a create cell from any non-local address. svn:r3763	2005-03-15 01:44:46 +00:00
Roger Dingledine	316afb6d09	fix an assert trigger in cvs: if a resolve request fails, and the circuit has vanished in the meantime, then we would both mark it for close (i.e. put it on the closeable list) and also immediately free it. svn:r3759	2005-03-14 04:42:52 +00:00
Nick Mathewson	0197b47ce9	Fix some more obscure compiler warnings svn:r3758	2005-03-14 03:28:46 +00:00
Nick Mathewson	97dad670ea	Renormalize whitespace svn:r3757	2005-03-14 03:18:35 +00:00
Nick Mathewson	fd150459b3	Raise common code for "detach this stream and try it with a different circuit" into a separate function; make that function handle controller-managed streams right. svn:r3756	2005-03-14 03:12:59 +00:00
Roger Dingledine	cabb8624e2	bugfix: now that we don't do the client dns thing, our checks to see if somebody was contradicting his exit policy were wrong. svn:r3755	2005-03-13 05:53:17 +00:00
Roger Dingledine	01f0b31432	ShutdownWaitLength should be an interval, not a uint svn:r3753	2005-03-12 20:16:52 +00:00
Roger Dingledine	fe768d1d2a	change SHUTDOWN_WAIT_LENGTH from a fixed 30 secs to a config option svn:r3752	2005-03-12 20:13:38 +00:00
Nick Mathewson	115271f65e	Implement the common case of ATTACHSTREAM. svn:r3751	2005-03-12 04:22:01 +00:00
Nick Mathewson	2b7907ef42	Increment step of a for loop should only happen once. svn:r3746	2005-03-11 21:42:32 +00:00
Nick Mathewson	777d3dde0c	Get address map resetting implemented. svn:r3745	2005-03-11 21:39:39 +00:00
Nick Mathewson	b17bb918ac	Remove unused macro; add a comment on remaining macros. svn:r3744	2005-03-11 21:38:06 +00:00
Roger Dingledine	5254c4e63a	remove duplicate function prototype svn:r3743	2005-03-11 20:47:23 +00:00
Geoff Goodell	af15c711c9	redefining default exit policy as per or-talk discussion svn:r3739	2005-03-11 05:07:31 +00:00
Nick Mathewson	99cc6bae0d	Fix error codes to work on windows svn:r3738	2005-03-10 18:48:13 +00:00
Nick Mathewson	6394f77edb	Initialize msg_len svn:r3737	2005-03-10 18:46:11 +00:00
Nick Mathewson	aaf70df3bd	Fix signed/unsigned warning svn:r3736	2005-03-10 18:45:42 +00:00
Nick Mathewson	a308353600	Fix const-ness warning svn:r3733	2005-03-10 06:15:46 +00:00
Nick Mathewson	c185825585	Finish implementing GETINFO; make it easy to query address maps. svn:r3732	2005-03-03 06:37:54 +00:00
Nick Mathewson	f90ccf5648	Implement new controller events for changed descriptors and new (not-yet-attached) streams. svn:r3731	2005-03-02 22:29:58 +00:00
Nick Mathewson	4b5e213a0b	Separate reverse-virtual-address-map entries into ipv4 and hostname slots. Otherwise if you ask me to map "some IPv4 address" to foo.onion, I might tell you that I already mapped "bar.virtual" to foo.onion svn:r3730	2005-03-02 22:01:10 +00:00
Nick Mathewson	5315b61e13	Fix some log messages to refer to correct control type. svn:r3729	2005-03-02 21:59:36 +00:00
Nick Mathewson	5f8e2c2bc4	Rename unused-address functions to virtual address; this is more accurate. Also, include almost-right implementation of reusing dont-care mappings. (It is still kind of wrong because it does not take type into account.) svn:r3728	2005-03-02 21:02:11 +00:00
Nick Mathewson	b494c2223d	Specify and implement fragmented control messages to allow for (among other things) long GETINFO replies. Otherwise we could hit the 64K barrier on questions like "please dump your client-side DNS cache." svn:r3726	2005-03-02 20:22:10 +00:00
Nick Mathewson	65230fd39f	Implement "Dont-Care" from addresses to MapAddress control message. For safety, refuse to launch connections to unmapped addresses in the dont-care range. svn:r3725	2005-03-02 19:26:46 +00:00
Nick Mathewson	e14f812a67	Still more code to make sure we send the right number and kind of RELAY END cells svn:r3723	2005-03-02 03:13:05 +00:00
Nick Mathewson	afe414f070	Revise all calls to connection_edge_end to avoid sending MISC, and to take errno into account where possible. svn:r3720	2005-03-01 22:42:31 +00:00
Nick Mathewson	4ddf768a4f	Forward-port new reasons; clean up code more; add code to convert new reasons to SOCKS5 reply codes; add code to convert errnos to reasons. New code still needs to get invoked. svn:r3719	2005-03-01 22:16:15 +00:00
Nick Mathewson	83743d64ab	Change version parsing logic: a version is "obsolete" if it is not recommended and (1) there is a newer recommended version in the same series, or (2) there are no recommended versions in the same series, but there are some recommended versions in a newer series. A version is "new" if it is newer than any recommended version in the same series. svn:r3716	2005-03-01 01:44:57 +00:00
Nick Mathewson	b7b05dc1b2	make control interface stream IDs monotonically increasing to prevent possible races svn:r3715	2005-03-01 01:15:01 +00:00
Nick Mathewson	349ee1abea	Clean up rend cache on shutdown svn:r3714	2005-02-28 22:38:00 +00:00
Roger Dingledine	b961d1c3bd	disable the reachability detection stuff in cvs, so people can run servers from cvs while i'm gone. svn:r3712	2005-02-28 09:39:12 +00:00
Nick Mathewson	c5091e7134	When copying routerinfo, copy descriptor too to prevent later double-free. svn:r3711	2005-02-28 03:37:27 +00:00
Nick Mathewson	97bc49bd72	Try a little harder to avoid openssl SSL* double-free reports. svn:r3710	2005-02-28 02:52:51 +00:00
Roger Dingledine	b3177d509e	free some more memory at shutdown svn:r3707	2005-02-28 01:59:18 +00:00
Roger Dingledine	25ff3a5042	fix bug in control mapaddress svn:r3705	2005-02-27 23:20:48 +00:00
Roger Dingledine	3cef60a0f7	fix a minor memory leak svn:r3704	2005-02-27 22:08:01 +00:00
Roger Dingledine	a1f1fa6ab2	Checkpoint in-progress fixes: Add 'testing' circuit purpose, for reachability testing. Notice when our IP changes, and reset stats. Try to pull down a directory via Tor to see if our DirPort is working. Try to extend a circuit back to us to see if our ORPort is working. Only publish a descriptor if they're both reachable. These mostly work, and I'd better get them in before I cause conflicts. svn:r3703	2005-02-27 09:47:01 +00:00
Nick Mathewson	8efb2a957d	Make sure that router_get_by_* can always return "me" svn:r3702	2005-02-27 07:23:42 +00:00
Nick Mathewson	bbaa3c7792	Implement more control spec functionality - Mapaddress - Postdescriptor - GetInfo on descriptors Required changes elsewhere: - Keep the most recent running_routers_t in the routerlist_t. That way we can learn about new routers and remember whether we were last told that they were up or down. Also enables more simplifications. - Keep the signed descriptor inside routerinfo_t. This makes descriptor_entry_t in dirservers.c unneeded. - Rename AddressMap (the verb) to MapAddress. Keep AddressMap as a noun. - Check addresses for plausibility before mapping them. svn:r3696	2005-02-25 20:46:13 +00:00
Nick Mathewson	8396105d84	Implement some of GETINFO control message svn:r3694	2005-02-25 06:37:07 +00:00
Nick Mathewson	81d2c2d8e5	Stub functions for new control-spec logic. svn:r3693	2005-02-25 06:16:28 +00:00
Nick Mathewson	26e6eb7539	Check returns from libevent calls better; stop poking at internals of events to see if they are live. svn:r3691	2005-02-25 05:42:01 +00:00
Roger Dingledine	6329811a88	fix a seg fault from tor_free_all svn:r3690	2005-02-24 23:01:26 +00:00
Nick Mathewson	24d7ae6fe8	Insert missing ! in assert_connection_ok; test was accidentally reversed in revision 1.329 yesterday. Should fix bug 102 svn:r3685	2005-02-24 17:08:27 +00:00
Roger Dingledine	5b24ca6cde	cache .exit address better (i think) svn:r3684	2005-02-24 11:44:08 +00:00
Roger Dingledine	6faaac2706	add support for CONNECTing through https proxies. not sure if it works. i don't have an https proxy. svn:r3682	2005-02-24 10:56:55 +00:00
Roger Dingledine	8054f82992	stop a potential overflow (pointed out by ilja) svn:r3681	2005-02-24 10:22:00 +00:00
Nick Mathewson	2adee31a26	Improve log message on unrecognized encoding to indicate that we can cope. svn:r3676	2005-02-23 22:14:34 +00:00
Nick Mathewson	22c38b0f9b	Clarify comment. Use CONN_IS_EDGE more. Try to be more zealous about calling connection_edge_end when things go bad with edge conns in connection.c svn:r3671	2005-02-23 20:35:26 +00:00
Nick Mathewson	69a36e352e	clarify comment svn:r3667	2005-02-23 06:46:54 +00:00
Nick Mathewson	e0387d1322	Addressmap tweak: Make "addressmap x x" remove any mapping from the address x. svn:r3666	2005-02-23 06:40:48 +00:00
Nick Mathewson	2ff6cfccd6	Forward-port fix to make dual-purpose NT executable work. svn:r3665	2005-02-23 05:34:25 +00:00
Roger Dingledine	55c3f15ed1	Forward-port the trick to bump up ConnLimit as far as it can go, but not past MAXCONNECTIONS. Also throw away the FAKE_POLL caveats since 0.1.0 doesn't need it any more. svn:r3657	2005-02-22 23:52:44 +00:00
Nick Mathewson	6e6d95b3db	Change from inet_ntoa to a threadproof tor_inet_ntoa. svn:r3656	2005-02-22 08:18:36 +00:00
Nick Mathewson	70c3580f81	Patch to localtime/gmtime handling: use the _r variants where available. Use mutexes to fake _r where necessary. Make mutexes no-ops where no threading is enabled. svn:r3653	2005-02-22 07:03:03 +00:00
Nick Mathewson	d01718841e	Remove assumptions that maximum path length is anything like 1024. From comments by Chris Palmer svn:r3652	2005-02-22 06:38:39 +00:00
Nick Mathewson	a68fcbf807	Initial IRIX compatibility fixes: check for inttypes.h; check for platform cell_t. svn:r3648	2005-02-22 04:26:45 +00:00
Nick Mathewson	c2d5b67dd2	After we successfully connect, try handling pending stuff immediately, rather than waiting for the next call to connection_handle_write. Roger: is this right? svn:r3647	2005-02-22 03:02:33 +00:00
Nick Mathewson	e673536e3f	Print uname on start of unittests. svn:r3646	2005-02-22 03:01:31 +00:00
Nick Mathewson	1a55422006	Fix windows build: juggle }s and #endifs around in main.c svn:r3645	2005-02-22 02:57:43 +00:00
Roger Dingledine	8991af604c	make the addressmap internals less noisy svn:r3643	2005-02-22 00:55:50 +00:00
Roger Dingledine	8727acf2f1	Add a new AddressMap directive to rewrite incoming socks addresses. Add a new TrackHostExits directive to trigger addressmaps for certain incoming socks addresses, for sites that break when your exit keeps changing. Redo the client-side dns cache so it's just an addressmap too. svn:r3641	2005-02-22 00:53:08 +00:00
Roger Dingledine	38f53cff41	forward-port the onion queue thing svn:r3639	2005-02-20 09:27:48 +00:00
Roger Dingledine	cbb4803ec8	forward-port some fixes svn:r3631	2005-02-17 01:12:50 +00:00
Roger Dingledine	797419a62c	remove unused code svn:r3629	2005-02-16 02:06:54 +00:00
Nick Mathewson	0289144229	Fix another crash bug found by Jaroslaw--it is possible for dns_resolve to mark a connection to be freed, if the circuit it was attached to fails for some reason. svn:r3623	2005-02-14 21:16:27 +00:00
Nick Mathewson	427e246a10	Add a missing prototype to or.h svn:r3621	2005-02-13 22:31:26 +00:00
Nick Mathewson	d90ab823ea	remove redundant unpack in critical path svn:r3620	2005-02-13 16:17:32 +00:00
Nick Mathewson	58540dde50	Do not try to double-aquire lock when rotating keys. May fix deadlock bug found by weasel. svn:r3616	2005-02-11 07:56:10 +00:00
Nick Mathewson	5d836c8140	Free tls resources on exit too svn:r3615	2005-02-11 01:41:19 +00:00
Nick Mathewson	f672577bc6	Free even more things on shutdown. Temporarily move tor_free_all out from #ifdef so it gets tested more. svn:r3614	2005-02-11 01:26:47 +00:00
Nick Mathewson	60f234f42b	Add more functions to free things to help dmalloc allong. svn:r3613	2005-02-10 23:18:39 +00:00
Roger Dingledine	33569e40d7	if we're hibernating and we get a sigint, exit immediately. closes bug 91. svn:r3611	2005-02-10 07:34:19 +00:00
Roger Dingledine	236aa86ae7	stop picking unverified dir mirrors, ever. it only leads to misery. svn:r3610	2005-02-10 07:00:23 +00:00
Roger Dingledine	37ca621301	when a client asks us for a dir mirror and we don't have one, launch an attempt to get a fresh one. svn:r3609	2005-02-10 06:31:34 +00:00
Roger Dingledine	07a3307460	remove redundant lines svn:r3607	2005-02-09 23:54:30 +00:00
Nick Mathewson	89d422914a	Patch from adam langley: always remove sockets from libevent before closing them. Should fix epoll-related bugs. svn:r3606	2005-02-09 23:16:31 +00:00
Roger Dingledine	c5c46d6fb6	don't list version in the win32 service display name or service name, since they'll keep changing and people will get messed up about which one is installed. svn:r3592	2005-02-09 02:26:24 +00:00
Nick Mathewson	a64b03a4fd	Avoid double-free on tor-resolve failure svn:r3567	2005-02-05 23:55:21 +00:00
Nick Mathewson	bb32fa86d7	Re-normalize whitespace; make "make check-spaces" happy svn:r3566	2005-02-05 21:42:46 +00:00
Nick Mathewson	24ad6542c9	forward-port NT service patch svn:r3565	2005-02-05 21:40:25 +00:00
Nick Mathewson	322c728e97	Fix tor-resolve implementation to prevent crashes and send resolves when we should. svn:r3561	2005-02-05 21:03:24 +00:00
Roger Dingledine	56d4b99491	forward-port the logic skew and double-free thing svn:r3549	2005-02-04 01:49:58 +00:00
Roger Dingledine	efa9bb5535	fix the latest bug: don't explode when some router declares a bandwidthburst of 500 gigabytes. this bug seems to have taken down most of the network. oops. svn:r3523	2005-02-03 22:58:22 +00:00
Roger Dingledine	bcece3d8a7	another minor fix svn:r3511	2005-02-03 07:30:00 +00:00
Peter Palfrader	ddd724ef94	Add --with-dmalloc configure option svn:r3508	2005-02-03 07:25:10 +00:00
Peter Palfrader	dfa3a0220f	Write a function header for Roger so he can fill it with life svn:r3507	2005-02-03 07:23:48 +00:00
Roger Dingledine	f575d29a59	note a bug that wmf just found svn:r3503	2005-02-02 06:28:45 +00:00
Roger Dingledine	c1656f41b4	bugfix: tor-resolve requests were ignoring .exit if there was a working circuit they could use instead. svn:r3502	2005-02-02 06:26:52 +00:00
Roger Dingledine	0551e3a814	reject more default filesharing ports by default. svn:r3500	2005-02-02 04:15:40 +00:00
Roger Dingledine	976bee4a3f	only check if exit_policy_implicitly_allows if you're a server. also, put a comment next to an interesting undocumented 'feature'. svn:r3499	2005-02-02 01:59:16 +00:00
Roger Dingledine	0f5a198028	sometimes, a conn on the closeable_lst gets absolutely clobbered. maybe this will help me find out why. svn:r3498	2005-02-02 00:19:09 +00:00
Roger Dingledine	850c300e46	bump the default rate limit to 1 MB svn:r3494	2005-02-01 13:44:10 +00:00
Roger Dingledine	b90983e44f	reject odd-looking addresses at the client, rather than having the server drop them because they're malformed. svn:r3493	2005-02-01 12:19:44 +00:00
Roger Dingledine	1447145470	give a bit more load to servers that claim to be able to handle a whole lot. svn:r3489	2005-02-01 02:56:31 +00:00
Roger Dingledine	1e847aebb1	Go into soft hibernation after 95% of the bandwidth is used, not 99%. This is especially important for daily hibernators who have a small accounting max. Hopefully it will result in fewer cut connections when the hard hibernation starts. svn:r3488	2005-02-01 02:45:28 +00:00
Roger Dingledine	2e97593d25	define TOR_FRAGILE if you want tor to give you a core when something goes wrong. this should only be used by people actively tracking bugs. svn:r3487	2005-02-01 00:37:16 +00:00
Roger Dingledine	e7e77d6d8e	fix an edge case in parsing config options (thanks weasel) svn:r3486	2005-02-01 00:05:57 +00:00
Peter Palfrader	d19aaa9a46	Fix arma's fix for my leak svn:r3485	2005-01-31 23:47:25 +00:00
Roger Dingledine	ab8691c343	fix a minor memory leak found by weasel svn:r3484	2005-01-31 20:38:57 +00:00
Roger Dingledine	d232831135	stop a sigpipe. apparently when we get an eof, at least sometimes it does mean you'd better not try writing. svn:r3481	2005-01-31 08:12:30 +00:00
Roger Dingledine	9856e328c4	stop logging loudly when a client tries an old onion key. it's time to give up on that issue, at least for now. svn:r3479	2005-01-31 04:03:57 +00:00
Roger Dingledine	a7138f2535	fix another rogue connection_free that was causing us troubles there are no doubt more lurking. svn:r3478	2005-01-31 03:47:38 +00:00
Roger Dingledine	a0312f3590	don't double-detach a closing exit conn that's waiting for dns resolve svn:r3477	2005-01-31 01:27:49 +00:00
Roger Dingledine	692a57c8e8	but don't spring the trip on worker children, because it turns out they don't actually remove anything before freeing the conns. svn:r3476	2005-01-31 01:02:20 +00:00
Roger Dingledine	d6489d8e41	lay a trap for situations where we connection_free something that's still on one of the lists. in particular, this will detect situations where we mark-for-close and then free it ourselves. svn:r3475	2005-01-31 00:33:32 +00:00
Roger Dingledine	75b45bcd4d	stop the infinite loop of freeing the same connection_t over and over when it's not linked into the connection_array svn:r3474	2005-01-31 00:26:09 +00:00
Roger Dingledine	5d8659429e	be less noisy about complaining when a jap client tries to connect and we refuse him. svn:r3472	2005-01-30 23:52:47 +00:00
Roger Dingledine	3969b6066e	Stop crashing when we're asking to close_if_marked a conn that hasn't been connection_added yet. This happens when an exit conn is in dns_wait and we get a relay end cell for it before it finishes. We were silently leaking each of these marked conns in 0.0.9.x. Now we actually free them. svn:r3470	2005-01-30 21:47:47 +00:00
Roger Dingledine	20ecfc757b	be safe: if you got a resolvefailed end cell but you're not an AP, bail. svn:r3469	2005-01-30 21:46:42 +00:00
Roger Dingledine	7ddeb7fae7	try to find the corrupt closeable_connection_lst entry early svn:r3468	2005-01-30 20:31:08 +00:00
Roger Dingledine	e432d2ceea	we should handle the case where the client has no cert, for backwards compatibility with jap clients. svn:r3466	2005-01-30 08:02:33 +00:00
Roger Dingledine	cab0138e4c	give a better log message when we don't have a good mirror of the directory yet and somebody asks for it. svn:r3464	2005-01-30 06:08:42 +00:00
Roger Dingledine	8e7fc8d259	comment about a bug wrt clock skew svn:r3461	2005-01-30 00:07:31 +00:00
Roger Dingledine	d273891107	if we fetch the dir from a mirror that has a wildly skewed clock, then don't bother checking recommended-versions: it will just make us sad. as a side effect, people running obsolete versions and whose clocks are wildly skewed will not be auto-shut-down. but they will still get warns about their clock skew. svn:r3459	2005-01-29 11:48:37 +00:00
Roger Dingledine	191e52179c	distinguish between "well-formed and rejected" and "not well formed", when parsing server descriptors. svn:r3458	2005-01-29 11:23:34 +00:00
Roger Dingledine	7fd8dfe6ea	accept LDAP (389/tcp) and LDAPS (636/tcp) in default exit policy svn:r3457	2005-01-29 11:16:23 +00:00
Roger Dingledine	82d3894f3e	don't let a corrupt directory cache keep us from starting svn:r3456	2005-01-29 11:07:35 +00:00
Roger Dingledine	0b9b97aaf4	forward-port the shutting up svn:r3450	2005-01-28 10:00:29 +00:00
Roger Dingledine	b2fbd834f0	forward-port the dns and maxconn fixes svn:r3448	2005-01-28 08:53:47 +00:00
Nick Mathewson	e03f571ee3	Forward-port win32 service patch; try to clean it a touch. svn:r3438	2005-01-27 21:45:32 +00:00
Nick Mathewson	fbb7f869c5	fwd-port win32 isprint fix svn:r3410	2005-01-22 00:42:58 +00:00
Nick Mathewson	1dc4d9a0ce	Fix dumb bug in unittests. svn:r3409	2005-01-22 00:42:40 +00:00
Nick Mathewson	de9b46ad64	clean a couple of messages svn:r3401	2005-01-21 23:16:07 +00:00
Roger Dingledine	4826718eac	special case so we don't yell when an empty http body doesn't specify a content-encoding svn:r3397	2005-01-21 03:18:49 +00:00
Roger Dingledine	b137f6d19f	if we get an incredibly skewed timestamp from a dirserver mirror that isn't a verified OR, don't complain very loudly -- it's probably him that's wrong. svn:r3395	2005-01-21 00:45:18 +00:00
Nick Mathewson	8115ca5f99	Log the offending policy, not the first policy svn:r3394	2005-01-20 20:42:45 +00:00
Nick Mathewson	6704093c0d	Appease another 64-bit warning svn:r3392	2005-01-20 20:21:34 +00:00
Nick Mathewson	fd41cbcadf	Have reason string for serverdesc post requests contain actual serverdesc status. Also fix return values of dirserv_add_descriptor to work as advertised. svn:r3391	2005-01-20 20:18:32 +00:00
Nick Mathewson	5b45527851	Appease weasel's paranoid 64-bit compiler. svn:r3389	2005-01-20 20:16:48 +00:00
Roger Dingledine	67f0babfd4	start to fix http status stuff, more work needed svn:r3387	2005-01-20 20:07:36 +00:00
Nick Mathewson	80e8359ccf	Give better reason phrases in HTTP status lines. Start resolving task #67 . (Messages still need to be better.) svn:r3386	2005-01-20 19:46:02 +00:00
Nick Mathewson	129e754ae4	Warn when exit policy implicitly allows local addresses. svn:r3383	2005-01-20 18:39:48 +00:00
Roger Dingledine	a6e91f8157	The crowning hidden-service patch: prefer non-internal circuits for normal connections, so we don't spend our internal circs on other stuff and not have them when we need them. svn:r3380	2005-01-20 07:02:24 +00:00
Roger Dingledine	38be533c69	Handle unavailable hidden services better. We try each intro point until none are left, then we try to refetch the descriptor. If it's the same one we had before, then close streams right then. Whenever a new stream arrives, even if it's right after, optimistically try refetching the descriptor, just in case. svn:r3379	2005-01-19 23:15:59 +00:00
Roger Dingledine	ff48179372	make cannibalizing for rend circs prey on the pleb circs first if possible, rather than the elite ones. svn:r3378	2005-01-19 23:13:20 +00:00
Nick Mathewson	1eddb28f82	Add unittests for compression detection. Make all rendezvous descriptors "plausible". svn:r3375	2005-01-19 22:47:48 +00:00
Nick Mathewson	69fa5be7b6	Workaround for webservers that lie about Content-Encoding: Tor now tries to autodetect compressed directories and compression itself. (resolves bug 65) svn:r3374	2005-01-19 22:40:33 +00:00
Nick Mathewson	e0bf597665	Give more useful log messages when the tor process closes dns/cpuworker connections. "Error: Success!" makes us seem like crazy people." svn:r3373	2005-01-19 21:34:42 +00:00
Roger Dingledine	75d83827e0	fix another bug where general exit circs were looking at rendezvous streams. consolidate the looking into one function so it doesn't happen again. svn:r3372	2005-01-19 17:59:37 +00:00
Roger Dingledine	cfcc93296c	bugfix for cvs: we were needing a rendezvous circ, so we cannibalized a general circ, and called rend_client_rendcirc_has_opened(), which called connection_ap_attach_pending(), which was needing a rendezvous circ, so it cannibalized a general circuit, and called ... svn:r3370	2005-01-19 17:13:11 +00:00
Nick Mathewson	7d4a167c81	Basic windows libevent fixes svn:r3366	2005-01-18 23:44:55 +00:00
Roger Dingledine	4e369bc9e8	allow bandwidthburst to be smaller, but whine if it's small. svn:r3364	2005-01-18 19:34:22 +00:00
Roger Dingledine	ea24dc31bc	remove some extra-verbose logs svn:r3361	2005-01-17 18:49:13 +00:00
Roger Dingledine	d2400a5afd	Introduce a notion of 'internal' circs, which are chosen without regard to the exit policy of the last hop. Intro and rendezvous circs must be internal circs, to avoid leaking information. Resolve and connect streams can use internal circs if they want. New circuit pooling algorithm: make sure to have enough circs around to satisfy any predicted ports, and also make sure to have 2 internal circs around if we've required internal circs lately (with high uptime if we've seen that lately). Split NewCircuitPeriod config option into NewCircuitPeriod (30 secs), which describes how often we retry making new circuits if current ones are dirty, and MaxCircuitDirtiness (10 mins), which describes how long we're willing to make use of an already-dirty circuit. Once rendezvous circuits are established, keep using the same circuit as long as you attach a new stream to it at least every 10 minutes. (So web browsing doesn't require you to build new rend circs every 30 seconds.) Cannibalize GENERAL circs to be C_REND, C_INTRO, S_INTRO, and S_REND circ as necessary, if there are any completed ones lying around when we try to launch one. Re-instate the ifdef's to use version-0 style introduce cells, since there was yet another bug in handling version-1 style. We'll try switching over again after 0.0.9 is obsolete. Bugfix: when choosing an exit node for a new non-internal circ, don't take into account whether it'll be useful for any pending x.onion addresses -- it won't. Bugfix: we weren't actually publishing the hidden service descriptor when it became dirty. So we only published it every 20 minutes or so, which means when you first start your Tor, the hidden service will seem broken. svn:r3360	2005-01-17 18:13:09 +00:00
Roger Dingledine	c6771e5ce4	reset published uptime when you wake up from hibernation, since if you hibernate daily a published uptime of >1day will be misleading. svn:r3356	2005-01-14 17:49:25 +00:00
Roger Dingledine	dcf8b18215	when the hidden service launches a rendezvous circ, make sure it provides good uptime if any virtual_port of the service wants that. svn:r3355	2005-01-14 04:35:53 +00:00
Nick Mathewson	a38bccdca7	Move call to event_init() immediately after start_daemon(); move start_daemon earlier. This should fix using libevent with RunAsDaemon. svn:r3354	2005-01-13 21:32:08 +00:00
Roger Dingledine	0aff4ff4cb	get rid of 0.0.8 backwards compatibility svn:r3353	2005-01-13 20:22:38 +00:00
Roger Dingledine	22f7934718	start generating version 1 style introduce cells svn:r3352	2005-01-13 20:21:11 +00:00
Roger Dingledine	49fe4cba74	when deciding if a port is handled and the port demands uptime, don't consider it handled if there's a circ that fits but isn't high-uptime. svn:r3349	2005-01-13 07:23:19 +00:00
Roger Dingledine	abea142665	more cleanup svn:r3347	2005-01-12 12:22:25 +00:00
Roger Dingledine	bafb3e4a5b	fix another integer underflow caused by buckets going negative svn:r3346	2005-01-12 12:19:00 +00:00
Roger Dingledine	24a97d2c55	fix up some comments svn:r3345	2005-01-12 12:18:46 +00:00
Roger Dingledine	3809c0ab91	tolerate bandwidtch buckets going negative (i hope) svn:r3344	2005-01-12 10:00:38 +00:00
Nick Mathewson	324b192f68	Make Tor use Niels Provos's libevent instead of it's current poll-but-sometimes-select mess. This will let us use faster async cores (like epoll, kpoll, and /dev/poll), and hopefully work better on Windows too. There are some fairly nasty changes to main.c here; this will almost certainly break something. But hey, that's what alphas are for. svn:r3341	2005-01-12 06:42:32 +00:00
Roger Dingledine	9b578f2fe2	add more chat and interactive protocols to LongLivedPorts svn:r3340	2005-01-12 05:18:14 +00:00
Roger Dingledine	84c81e0783	Annotate circuits w/ whether they aim to contain high uptime nodes and/or high capacity nodes. When building circuits, choose appropriate nodes. New config option LongLivedPorts to indicate application streams that will want high uptime circuits. When attaching a stream to a circuit, pay attention to its requirements. This means that every single node in an intro rend circuit, not just the last one, will have a minimum uptime. Boost the min uptime from an hour to 24 hours. svn:r3339	2005-01-12 04:58:23 +00:00
Roger Dingledine	70b3208f0a	if somebody starts his tor server in jan 2004 and then fixes his clock, don't make his published uptime be a year. svn:r3337	2005-01-11 11:54:11 +00:00
Roger Dingledine	45eb8d9660	if you're a server and the auth dirservers are down, go to any other server. only give up hope on network reachability when no other servers are reachable either. svn:r3335	2005-01-10 17:39:41 +00:00
Roger Dingledine	4b6d55afdf	separate time_of_process_start from stats_n_seconds_uptime: now we reset uptime when a dir fetch entirely fails. this hopefully has something to do with stability of being on the network. svn:r3333	2005-01-10 05:10:22 +00:00
Roger Dingledine	3370f53010	it helps to use the correct name for the struct svn:r3331	2005-01-10 04:32:59 +00:00
Roger Dingledine	10a81ccf18	when pruning circuit-wait streams when a dir fetch failed, refer in logs to the destination address, not the address of the application connection. svn:r3330	2005-01-10 02:47:50 +00:00
Roger Dingledine	f468ff04ea	when we haven't fetched a directory yet, or the last time we tried they were all unreachable, assume we are not connected to the network. when an application request comes in during this state, be optimistic and assume we just reconnected. fetch a new directory and if it works, begin making circuits. svn:r3327	2005-01-07 15:57:57 +00:00
Roger Dingledine	608caffc64	fix unit tests: address has to be a non-private IP, and socksport needs to be 0. svn:r3324	2005-01-07 01:12:30 +00:00
Roger Dingledine	cd1f50d2f0	new config option DirAllowPrivateAddresses for authdirservers. now by default they refuse router descriptors that have non-IP or private-IP addresses. svn:r3321	2005-01-06 21:03:27 +00:00
Nick Mathewson	91bafc476e	Fix a fun bug: do not rewrite a cached directory back to the cache; otherwise we will think it is recent and not fetch a newer one. svn:r3319	2005-01-06 20:11:52 +00:00
Roger Dingledine	f8b517fa97	finish marking my comment in main.c svn:r3318	2005-01-06 19:20:54 +00:00
Roger Dingledine	1f51809e65	clean up string printing in relay logs svn:r3317	2005-01-06 19:19:13 +00:00
Roger Dingledine	6d2859c2e5	fix trivial typo in log entry svn:r3316	2005-01-06 19:17:01 +00:00
Nick Mathewson	a6e587305f	typo spotted by chris svn:r3308	2005-01-05 06:48:39 +00:00
Nick Mathewson	dcd228585d	Implement SIGNAL control command. svn:r3307	2005-01-05 06:40:47 +00:00
Nick Mathewson	b4fedc7f14	Stop reversing and re-reversing config lines: keep them in order all the time. Removes needless confusion and fixes bug #50 . svn:r3305	2005-01-05 06:05:37 +00:00
Nick Mathewson	e99f79fa4d	Remove broken and undocumented wart where multiple CSV config lines are appended rather than replaced. Resolves bug #49 svn:r3301	2005-01-05 02:51:04 +00:00
Roger Dingledine	814dd946f0	fix duplicate dns_cancel_pending_resolve reported by Giorgos Pallas svn:r3293	2005-01-04 11:26:08 +00:00
Roger Dingledine	ba7c74e742	bandaid: make Giorgos Pallas's dns assert bug not actually crash on him. one day we should try to figure out what's actually going on here. svn:r3280	2005-01-04 06:21:06 +00:00
Nick Mathewson	6dd91de3bd	Nothing actually _uses_ socks_port, so why publish it? For backward compatibility, publish a socks_port of 0, and never read socks_port. svn:r3279	2005-01-04 05:46:54 +00:00
Roger Dingledine	e6c1ab2daf	post 0.0.9.x, demand that servers declare at least 20000 bytes/s for bandwidthrate svn:r3277	2005-01-04 03:46:50 +00:00
Nick Mathewson	4d30e2f4b8	Make sequence of log messages when starting on win32 with no config file more reasonable. svn:r3275	2005-01-04 02:25:36 +00:00
Roger Dingledine	82c5381ecb	forward-port the fix for the compiler warning svn:r3273	2005-01-04 01:16:20 +00:00
Roger Dingledine	d7a0f1a629	update print_usage to use new url svn:r3267	2005-01-03 23:21:32 +00:00
Roger Dingledine	a005509c9d	update url for when users try to use socksport as an http proxy svn:r3265	2005-01-03 23:19:15 +00:00
Nick Mathewson	d1fc7ad94b	Log when we retry a directory connection svn:r3258	2005-01-03 21:14:09 +00:00
Nick Mathewson	0c4186d6ee	Use correct logic to decide whether there are more directory servers to retry. svn:r3257	2005-01-03 20:51:24 +00:00
Nick Mathewson	65c4fa2614	Split mark-dir-failed-and-retry logic into separate function; make it retry runningrouters as well as directory fetches; note that the do-we-need-to-give-up test is wrong. svn:r3256	2005-01-03 20:07:07 +00:00
Nick Mathewson	858eda4736	Fix an unused function warning svn:r3255	2005-01-03 20:03:49 +00:00
Nick Mathewson	5f40d6bf72	Make directory fail-and-retry logic happen in connection_about_to_close(); fixes win32 bug. svn:r3253	2005-01-03 19:51:10 +00:00
Nick Mathewson	b50263f740	More work on task #43 : fix race conditions on multithreaded (win32) servers. svn:r3251	2005-01-03 19:07:25 +00:00
Nick Mathewson	ead52e0bdc	Possible fix for task #43 : when running on a multithreaded environment (currently only windows), threads should not close opposite sides of their socketpairs, and workers should not call connection_free_all(). This may fix win32 servers. svn:r3247	2005-01-03 18:06:51 +00:00
Nick Mathewson	fca7ba9777	Resolve task 42: find where 19-char nicknames were getting truncated when read from certs, and fix it. Also audit use of MAX_NICKNAME_LEN; no other badness found, but some docs/code cleaned up a touch. svn:r3244	2005-01-03 17:53:20 +00:00
Roger Dingledine	59504f4831	bugfix: if a server uploads a descriptor that's unapproved, actually tell him so. svn:r3243	2005-01-03 17:47:32 +00:00
Roger Dingledine	70075933c6	stop checking for clock skew, even for servers. this means we are vulnerable to an attack where somebody recovers and uses a really old certificate. however, if they do that, they probably can get our identity key just as easily. svn:r3241	2005-01-03 17:10:32 +00:00
Roger Dingledine	b4dad0e6a4	fix the assert bug reported by bassclef@163.com svn:r3237	2005-01-02 06:16:46 +00:00
Roger Dingledine	a4ad47df86	Fix a double-mark-for-close bug, where we were finding a conn for a cell even if that conn is already marked for close. Don't back-port to 0.0.9.x, since this fix could have weird implications. svn:r3235	2005-01-01 07:54:01 +00:00
Roger Dingledine	35d5a5b712	when a dirserver causes you to give a warn, mention which dirserver it was svn:r3234	2005-01-01 07:40:59 +00:00
Roger Dingledine	e29d7329b3	...but only if you're a server svn:r3233	2004-12-31 21:49:20 +00:00
Roger Dingledine	95f3e6161b	require BandwidthRate to be at least 10kB/s svn:r3232	2004-12-31 21:47:54 +00:00
Roger Dingledine	717fe4993e	actually make it stop keeping track of times. whoops. svn:r3230	2004-12-25 07:19:48 +00:00
Roger Dingledine	e1ac30c2bb	stop calling assert_connection_ok(conn, time(NULL)) on every single conn on every single loop. svn:r3229	2004-12-25 06:43:40 +00:00
Roger Dingledine	288f2ed59e	stop telling win32 folks they have a bug just because we haven't finished making tor work on win32 yet. svn:r3227	2004-12-25 06:42:15 +00:00
Roger Dingledine	be72937ab0	initial profiling by phobos says we spend a whole lot of time measuring how long each cell takes to process. make that optional. svn:r3226	2004-12-25 06:10:34 +00:00
Roger Dingledine	53105cdae5	when you're loading the rendezvous service keys in options_act(), don't call it 'reloading'. svn:r3225	2004-12-24 20:45:45 +00:00
Roger Dingledine	3a572fcffa	don't connection_edge_end() on eof if we're already marked for close, because if we are then it's because we already got an end. svn:r3223	2004-12-24 09:43:57 +00:00
Nick Mathewson	ded8e79979	remove sentence-fragment comment refering to a design that never happened. svn:r3220	2004-12-24 02:50:27 +00:00
Nick Mathewson	e8585dfe97	Remove length restriction when generating directories. svn:r3218	2004-12-24 02:17:32 +00:00
Nick Mathewson	7117366810	Fix for running-routers length bug svn:r3216	2004-12-24 01:41:52 +00:00
Roger Dingledine	f50b785c3b	and forward port the cleanup svn:r3211	2004-12-22 10:04:50 +00:00
Roger Dingledine	18320557a1	fix a crash: if you do socks4 with an IP of 0.0.0.x then we get tricked into thinking you're doing socks4a, and we look for the next byte. thanks to aphex for finding this. svn:r3207	2004-12-22 09:52:29 +00:00
Roger Dingledine	cf17d0d29c	move network_init from or/main to common/compat call network_init in tor-resolve.c too move tor_lookup_hostname from common/util to common/compat svn:r3203	2004-12-22 05:29:06 +00:00
Roger Dingledine	036384fd8e	respond to an 009 XXX svn:r3201	2004-12-22 02:55:26 +00:00
Nick Mathewson	32978afa54	Workaround for brain-damaged __FILE__ handling on MSVC: keep Nick's name out of the warning messages. svn:r3199	2004-12-22 02:32:26 +00:00
Roger Dingledine	f9fd101869	forward port: fix a fencepost: we were blowing away the \n when reporting confvalue items svn:r3194	2004-12-21 02:57:25 +00:00
Roger Dingledine	308ffa8a05	When listing circuits that are pending on an opening OR connection, if we're an OR we were listing circuits that end at us as being pending on every listener, dns/cpu worker, etc. Stop that. svn:r3171	2004-12-17 23:17:00 +00:00
Nick Mathewson	bbc10c2ea1	Make split(..., NULL) split on horizontal space; fix bug with tabs in config file. svn:r3155	2004-12-16 21:10:51 +00:00
Nick Mathewson	e327b2f3a6	Clarify confusing message svn:r3151	2004-12-16 05:23:48 +00:00
Roger Dingledine	e1bc3f097e	bugfix: when we're reporting event circuit status, don't call it a stream. while we're at it, include ":port" in the stream event string. svn:r3148	2004-12-14 03:36:33 +00:00
Roger Dingledine	b6173b7b68	0.0.9 broke hibernation. darn it. svn:r3147	2004-12-13 19:42:46 +00:00
Nick Mathewson	75cefd8989	Remove bugfixes that did not actually do anything, before we start a cargo cult. svn:r3145	2004-12-13 18:48:12 +00:00
Nick Mathewson	1e71b83890	Fix a bug in parsing HashedControlPassword. svn:r3143	2004-12-13 18:32:29 +00:00
Roger Dingledine	6cc7d32afc	clarify a log entry svn:r3142	2004-12-13 02:23:22 +00:00
Roger Dingledine	a8582ae223	note a future thing we should do svn:r3141	2004-12-13 01:30:41 +00:00
Roger Dingledine	011ad3cba5	clean up logging, make it clearer which warns are bugs, make the control log event match its specification, point out a bug in how we deal with failure when renewing the tls context. svn:r3138	2004-12-13 00:44:39 +00:00
Nick Mathewson	972124aab9	Only launch dns workers when we are actually starting a server. svn:r3137	2004-12-13 00:09:00 +00:00
Roger Dingledine	464338b250	when hibernating, don't advertise any ports this is important for the dirport, because clients will still ask you for a directory, and they'll be sad when you're down. and do the other ports too, because hey, they're not listening. svn:r3133	2004-12-11 23:53:59 +00:00
Roger Dingledine	470cdea7f8	make the 64 bit args print correctly on 64 bit archs svn:r3123	2004-12-08 12:30:20 +00:00
Nick Mathewson	fe6eb34a10	Solaris CC freaks out if isspace and friends get anything other than an int. We learned that, so we casted. But it is also a bad idea to cast a signed char to an int and expect things to work on win32. Now we cast to unsigned char, then to int, then pass to isspace. Ug svn:r3120	2004-12-08 00:42:50 +00:00
Nick Mathewson	fc8a2596e1	Log contents of bw_accounting when we read it; fix memory leak. svn:r3118	2004-12-07 23:20:10 +00:00
Roger Dingledine	ca95ed74ac	resolve tequila's crash bug: you can't free something and then keep using it. svn:r3117	2004-12-07 21:57:37 +00:00
Roger Dingledine	ad4f440e10	rearrange debug logs to make more sense svn:r3116	2004-12-07 21:57:10 +00:00
Roger Dingledine	33cf6f2f61	clean two more minor memory leaks svn:r3115	2004-12-07 19:42:45 +00:00
Nick Mathewson	06ce31b948	Only set a cookie when we intend to. svn:r3114	2004-12-07 19:36:43 +00:00
Roger Dingledine	e93077c82a	fix a minor leak for people offering hidden services svn:r3113	2004-12-07 17:49:14 +00:00
Roger Dingledine	29a8e80326	log bytes written with kill -USR1 too svn:r3112	2004-12-07 16:50:47 +00:00
Roger Dingledine	012255fe60	fix the other half of the pipe race svn:r3111	2004-12-07 16:37:32 +00:00
Roger Dingledine	538c3b0c26	avoid a sigpipe from a race: if we get the end right after the app has hung up on us, we shouldn't hold-open-until-flush. svn:r3109	2004-12-07 15:31:54 +00:00
Roger Dingledine	802d374a99	I'm a bad person. Stop treating the uint16_t's as null-terminated strings, and stop looking at the byte after them to see if it's null, because sometimes you're not allowed to look there. svn:r3108	2004-12-07 15:29:54 +00:00
Roger Dingledine	a2d80ec767	were we on crack?? svn:r3107	2004-12-07 09:18:25 +00:00
Roger Dingledine	41b809d2aa	salvage another 300 bytes per hup svn:r3106	2004-12-07 09:11:38 +00:00
Roger Dingledine	d9f86e2782	and bust another memory leak svn:r3105	2004-12-07 08:58:26 +00:00
Roger Dingledine	5d961c2c06	plug another memory leak svn:r3104	2004-12-07 08:51:10 +00:00
Nick Mathewson	a6aa5eebd6	Fix some memory leaks and unlikely segfaults svn:r3103	2004-12-07 07:48:16 +00:00
Roger Dingledine	8f01b643c3	ORPort must be defined if ORBindAddress is defined. svn:r3100	2004-12-07 06:51:46 +00:00
Roger Dingledine	2ff38fdf83	when recommending new-format log lines, if the upper bound is LOG_ERR, leave it implicit. svn:r3097	2004-12-07 06:27:39 +00:00
Nick Mathewson	d19648b314	Renormalize whitespace svn:r3095	2004-12-07 05:33:55 +00:00
Nick Mathewson	ac759adb43	Make unit tests work on win32 svn:r3094	2004-12-07 05:31:38 +00:00
Nick Mathewson	08e3090aff	More win32 fixes: 1) tolerate extra "readable" events better. 2) when being multithreaded, leave parent fdarray open. svn:r3092	2004-12-06 23:19:55 +00:00
Roger Dingledine	f00631e6b9	answer resolved ip in network order svn:r3087	2004-12-06 06:14:45 +00:00
Roger Dingledine	f10f24a61c	avoid using uninitialized variable svn:r3086	2004-12-06 06:07:57 +00:00
Roger Dingledine	0859d09352	don't use cache for resolving .foo.exit names, but do reply immediately if we're asked to resolve an IP.foo.exit. svn:r3085	2004-12-06 06:06:13 +00:00
Roger Dingledine	577665f608	fix indenting svn:r3084	2004-12-06 05:26:19 +00:00
Roger Dingledine	f21564eb29	send an end to the streams we close when we hibernate, rather than just chopping them off svn:r3083	2004-12-05 13:02:18 +00:00
Roger Dingledine	1c9c813866	check if we have a cached resolve for a tor-resolve address after we remove the .foo.exit part of the address. svn:r3082	2004-12-05 12:47:46 +00:00
Roger Dingledine	5ba3328172	fix a minor leak in my recent commit svn:r3081	2004-12-05 12:35:00 +00:00
Roger Dingledine	469135e7e2	talk about quotas rather than bandwidths, in the logs svn:r3080	2004-12-05 12:26:02 +00:00
Roger Dingledine	ef6c9d18e7	New circuit building strategy: keep a list of ports that we've used in the past 6 hours, and always try to have 2 circuits open or on the way that will handle each such port. (We can extend this to include addresses if exit policies shift to require that.) Seed us with port 80 so web browsers won't complain that Tor is "slow to start up". This was necessary because our old circuit building strategy just involved counting circuits, and as time went by we would build up a big pile of circuits that had peculiar exit policies (e.g. only exit to 9001-9100) which would take up space in the circuit pile but never get used. Fix router_compare_addr_to_addr_policy: it was not treating a port of * as always matching, so we were picking reject : nodes as exit nodes too. If you haven't used a clean circuit in an hour, throw it away, just to be on the safe side. This means after 6 hours a totally unused Tor client will have no circuits open. svn:r3078	2004-12-05 07:10:08 +00:00
Roger Dingledine	02b3229a04	plus add a comment re: the previous bug svn:r3076	2004-12-04 10:18:41 +00:00
Roger Dingledine	52676364b9	bugfix: router_exit_policy_rejects_all() was broken, so we were sometimes picking middleman nodes as our last hop, which wasn't very useful. svn:r3075	2004-12-04 08:56:59 +00:00
Roger Dingledine	2532e9405e	Now we allow writing to the buffer even when the stream if marked for close, if we're planning to wait to flush it. This is important because we were sending a socks reject back if we're closing and hadn't already sent one, but it wasn't actually getting written since the conn was already marked-for-close. svn:r3074	2004-12-04 07:13:37 +00:00
Roger Dingledine	5a6e117caf	React to eof immediately on non-open edge connections. Stop keeping track of num_retries for apconns, since they expire after 60 seconds anyway. When warning about retrying or giving up, print the address, so the user knows which one it's talking about. svn:r3073	2004-12-04 03:26:35 +00:00
Roger Dingledine	c644886c38	bugfix: When we were checking to see if an ap_conn should time out waiting for its connected cell, we were calculating time from when the ap_conn was created. So if it waited say 20 seconds before being attached, then we would immediately decide that the circuit had timed out. Also, make circuit_dump_by_conn() display actual circuit progress, including circuits that haven't been attached to the conn yet but hope to when it finishes connecting. svn:r3072	2004-12-04 02:51:11 +00:00
Roger Dingledine	675f60aa13	whoops just because it says snprintf doesn't mean it's a noop svn:r3071	2004-12-04 01:23:04 +00:00
Nick Mathewson	fc87758ff3	Add function to check that addr_policy_t is okay; change struct addr_policy_t to addr_policy_t. svn:r3070	2004-12-04 01:14:36 +00:00
Roger Dingledine	8d69dc472b	make circuit building and router parsing less noisy svn:r3068	2004-12-04 00:25:54 +00:00
Roger Dingledine	f79a7d8d62	while hibernating, hup should not regrow our listeners. svn:r3067	2004-12-03 23:53:35 +00:00
Roger Dingledine	db5e100cde	clean up 3 more underflow possibilities svn:r3063	2004-12-02 04:31:52 +00:00
Roger Dingledine	0799804c60	fix redundant (and dangerous) NUL termination svn:r3062	2004-12-02 04:16:18 +00:00
Nick Mathewson	e3f6f92cf7	check for duplicate circuit ID _after_ updating circ_id_type. svn:r3058	2004-12-01 04:55:03 +00:00
Roger Dingledine	82f3ebf195	move StatusFetchPeriod to 15 minutes so it's within bounds by default svn:r3055	2004-12-01 04:27:11 +00:00
Roger Dingledine	ef04cfcbad	one more typo svn:r3054	2004-12-01 04:13:15 +00:00
Nick Mathewson	b457cfb5eb	Spell-check strings and comments svn:r3052	2004-12-01 03:48:14 +00:00
Nick Mathewson	6e88abf418	If we are using select, make sure we stay within FD_SETSIZE. svn:r3051	2004-12-01 03:15:59 +00:00
Roger Dingledine	bde1d5bfb2	do even less inside our signal handler, just to be extra paranoidly safe svn:r3050	2004-12-01 02:54:13 +00:00
Nick Mathewson	a889926e1c	Clarify chosen tag progression svn:r3047	2004-11-30 16:07:20 +00:00
Roger Dingledine	3929f58018	clean obsolete circuit_log_path code svn:r3046	2004-11-30 10:47:48 +00:00
Roger Dingledine	eb558d0a84	clean up the other "Tell Roger" log that dfc keeps getting svn:r3042	2004-11-30 09:02:25 +00:00
Roger Dingledine	19ada3f7fa	write down our "how to have two defaults for dirfetchperiod" issue, so we don't forget about it. svn:r3040	2004-11-30 08:44:19 +00:00
Roger Dingledine	1d4af1930c	Let resolve conns retry/expire also, rather than sticking around forever. Put the check-if-requested-exitrouter-will-reject-us code in the circuit_attach loop, so it gets checked periodically and not just once at the beginning. This is useful in case the routerlist changes, but also in case the address gets resolved into something that we learn we'll reject. svn:r3039	2004-11-30 08:39:14 +00:00
Roger Dingledine	d383c23e73	refuse .exit addresses immediately if the requested node would refuse the request (e.g. due to exit policy or wrong version) svn:r3038	2004-11-30 08:15:09 +00:00
Nick Mathewson	bec7a1c6e8	use shorter minimum key lifetime until 008 is dead svn:r3035	2004-11-30 06:44:07 +00:00
Nick Mathewson	f19e9b8577	doxygen uses backslashes, not forward-slashes svn:r3033	2004-11-30 06:17:35 +00:00
Nick Mathewson	a5d3325c5c	Fix last patch svn:r3031	2004-11-30 06:12:21 +00:00
Nick Mathewson	c8abe1907d	Rename parse_address to parse_extended_hostname (since we have other kinds of addresses); make its output an enum; support HEXDIGEST.exit hostnames. svn:r3029	2004-11-30 03:44:10 +00:00
Nick Mathewson	ebab451eed	Make version parsing tests pass svn:r3028	2004-11-30 03:41:06 +00:00
Nick Mathewson	ee7bef1458	Enforce coding style. svn:r3025	2004-11-30 02:26:41 +00:00
Nick Mathewson	e764d00e15	If anybody set DirFetchPostPeriod, give them StatuFetchPeriod instead. Impose minima and maxima for all *Period options; impose even tighter maxima for fetching if we are a caching dirserver. Clip rather than rejecting. arma: are these good? svn:r3024	2004-11-30 02:23:51 +00:00
Nick Mathewson	ce505f5033	note possible alternative for how to do CVS versions; ask arma which he likes. svn:r3023	2004-11-29 23:06:51 +00:00
Nick Mathewson	6507be4290	Implement new version format for post 0.1. svn:r3022	2004-11-29 23:04:26 +00:00
Nick Mathewson	7fbd297532	Suggestion from weasel: Make tor --version --version dump the cvs Id of every file. svn:r3019	2004-11-29 22:25:31 +00:00
Nick Mathewson	aff5122685	Fetch cached running-routers from servers that serve it (that is, authdirservers, and servers running 0.0.9rc5-cvs or later.) svn:r3018	2004-11-29 21:01:34 +00:00
Roger Dingledine	c1dc17e6e2	put in initial support for ".nickname.exit" addresses, to let alice decide what exit node to use; based on a patch by geoff goodell. needs more work: e.g. it goes bananas building new circuits when the chosen exit node's exit policy rejects the connection. svn:r3015	2004-11-29 08:34:54 +00:00
Nick Mathewson	9ba7311c1c	After implementing a feature, remember to disable the error message you used to get when requesting it. svn:r3013	2004-11-29 07:59:00 +00:00
Roger Dingledine	7fc30fc1e6	accept *:706 (silc) by default svn:r3006	2004-11-28 15:49:12 +00:00
Roger Dingledine	22727b4edc	wrong is ok, and right is fine, but in between is apparently totally unacceptable to me. svn:r3005	2004-11-28 11:39:53 +00:00
Nick Mathewson	f7c6ad065e	correct multiple internal spaces svn:r3004	2004-11-28 09:14:07 +00:00
Nick Mathewson	6f5dbefa7e	Normalize space: add one between every control keyword and control clause. svn:r3003	2004-11-28 09:05:49 +00:00
Roger Dingledine	dad760ddd1	one of the debugging aids was misleading svn:r3000	2004-11-28 06:33:14 +00:00
Nick Mathewson	f77ff938b7	remember; tor_socket_errno has side effects! svn:r2997	2004-11-28 05:48:02 +00:00
Roger Dingledine	e5e45fe980	inform him more sanely svn:r2993	2004-11-26 04:19:03 +00:00
Roger Dingledine	a7f92d7ffe	inform the user that you noticed when he sent a USR2 svn:r2992	2004-11-26 04:17:57 +00:00
Roger Dingledine	f9a0ab62b7	if you want to handle -USR2, you should catch it too. svn:r2990	2004-11-26 04:03:19 +00:00
Roger Dingledine	7c9a707900	remove emacs droppings, since nick says he doesn't need them anymore svn:r2989	2004-11-26 04:00:55 +00:00
Roger Dingledine	02a30a348a	give up trying to track down the reason we're calling package_inbuf with a package window of 0. it's safe to just catch the error cases there and do the right thing. svn:r2988	2004-11-26 03:43:54 +00:00
Roger Dingledine	179ad27b34	call set_max_file_descriptors() after we configure logs, so it doesn't always do loglevel info logs on windows. svn:r2987	2004-11-26 03:05:55 +00:00
Roger Dingledine	e24057b2bf	when warning that a version is too new, don't use the confusing text "is_obsolete_version():". svn:r2986	2004-11-25 05:49:13 +00:00
Nick Mathewson	f91152ce6a	Clarify a bunch of log messages svn:r2983	2004-11-25 04:20:10 +00:00
Roger Dingledine	914d346095	update conn_state_to_string svn:r2979	2004-11-24 07:58:15 +00:00
Roger Dingledine	83e7043eb8	don't process marked-for-close conns further. (fix assert trigger -- if we're lucky.) svn:r2975	2004-11-24 06:41:58 +00:00
Roger Dingledine	7d55f3685e	make tor-resolve work, uh, more. this time for sure! svn:r2974	2004-11-24 06:16:36 +00:00
Roger Dingledine	cca469ec58	make tor-resolve work again svn:r2973	2004-11-24 06:01:52 +00:00
Roger Dingledine	0eebfe3558	bugfix: let socks do multiple rounds of negotiation again (which is needed for socks5) svn:r2970	2004-11-24 04:35:28 +00:00
Roger Dingledine	090c84627c	patch to nick's patch svn:r2969	2004-11-24 03:58:45 +00:00
Nick Mathewson	74f74a06c6	make nt service version match actual version svn:r2968	2004-11-24 00:55:39 +00:00
Nick Mathewson	1bec1b3d37	Better notice for hibernate interval spans; when estimate is 0, start out awake. svn:r2963	2004-11-23 22:34:23 +00:00
Nick Mathewson	5fa55c8317	Bugfix: when no units are given, default to seconds or bytes. svn:r2960	2004-11-23 10:52:27 +00:00
Roger Dingledine	a284b0db8f	another slightly less confusing message nick: we need to figure out if we should say anything different here when the wake-up time and the expected back-to-sleep time have both passed. svn:r2956	2004-11-23 10:05:56 +00:00
Roger Dingledine	b6cb547667	less confusing message upon hibernation svn:r2955	2004-11-23 09:21:03 +00:00
Roger Dingledine	921c40abe7	fail more gracefully next time svn:r2954	2004-11-23 09:01:37 +00:00
Roger Dingledine	57a392d8d8	initialize rephist before we init_from_config, since init_from_config can make us init_keys if we're going to hibernate, which makes us build a router_desc. svn:r2953	2004-11-23 09:00:55 +00:00
Roger Dingledine	d7fb38cfe3	update unit tests to reflect changed interface svn:r2952	2004-11-23 08:36:26 +00:00
Roger Dingledine	7ed738b34c	fix some typos; move to 0.0.9rc1 svn:r2951	2004-11-23 07:37:25 +00:00
Nick Mathewson	f5319a010d	Dr. Seuss on iterating circular lists: "It's fun to have fun, but you have to know how." svn:r2948	2004-11-23 06:08:08 +00:00
Nick Mathewson	0a58bbe0dd	Fix critical bug in circuit_list_path: cpath is a circular list! (Also reimplement circuit_log_cpath using circuit_list_cpath). svn:r2946	2004-11-23 00:11:36 +00:00
Nick Mathewson	cd70264377	Clean up some logging and interfaces svn:r2945	2004-11-23 00:08:26 +00:00
Nick Mathewson	22dba27d8d	Normalize a few more kinds of whitespace. We now dislike: - func (args) - if (x){ This doesn't normalize if(x), for(x); while(x), and friends. svn:r2943	2004-11-22 23:28:26 +00:00
Nick Mathewson	fe32c2d141	Fix sign-related warnings svn:r2942	2004-11-22 22:50:17 +00:00
Nick Mathewson	d4754b334c	Compile cleanly on windows; prevent some insane bandwidth cases (e.g., "BandwidthBurst 1000 TB" from occuring. svn:r2941	2004-11-22 22:24:10 +00:00
Nick Mathewson	983a335f3b	Normalize space svn:r2939	2004-11-22 22:13:34 +00:00
Nick Mathewson	f17c08beed	Apply NT service patch from Osamu Fujino. This still has some problems (indicated in a comment adapted from the patch submission email), but it is better than before and better than nothing. svn:r2938	2004-11-22 22:10:37 +00:00
Nick Mathewson	956b463dfe	Implement weekly/monthly/daily accounting svn:r2936	2004-11-22 21:56:51 +00:00
Nick Mathewson	805c9e3673	Absolutely never call close_temp_logs while validating log options. svn:r2934	2004-11-22 20:08:07 +00:00
Roger Dingledine	4f2c2c9948	The crowning bugfix. The problem was that with high load, circuit package window was reaching 0. Whenever we got a circuit-level sendme, we were reading a lot on each socket, but only writing out a bit. So we would eventually reach eof. This would be noticed and acted on even when there are still bytes sitting in the inbuf. svn:r2932	2004-11-21 11:30:33 +00:00
Roger Dingledine	27b8797245	clean up some more. i think i'm getting closer. svn:r2931	2004-11-21 11:20:28 +00:00
Roger Dingledine	310a8da0d2	break reached_eof() out of process_inbuf() svn:r2930	2004-11-21 10:14:57 +00:00
Roger Dingledine	671d84dc2f	some more debugging aids svn:r2929	2004-11-21 09:39:01 +00:00
Roger Dingledine	6a516dfdd3	be more greedy about filling up all relay cells. this may have some bugs in it still. and it may end up not being what we want to do. svn:r2928	2004-11-21 07:43:12 +00:00
Nick Mathewson	bb18d4238f	Dont keep rephist info for routers that havent had activity for 24 hours. svn:r2926	2004-11-21 05:14:46 +00:00
Nick Mathewson	bdb61f2a04	fix typo svn:r2925	2004-11-21 05:06:22 +00:00
Nick Mathewson	36f4e15e81	Call init_keys() where needed; fix hibernate bug. svn:r2924	2004-11-21 04:19:04 +00:00
Roger Dingledine	a4b1eb5630	allow StrictEntryNode and StrictExitNode to be singular svn:r2922	2004-11-20 23:16:03 +00:00
Roger Dingledine	73da4bad46	stop some more seg faults svn:r2921	2004-11-20 12:55:41 +00:00
Roger Dingledine	63353462f8	if your requested exit node has bandwidth 0, pick it anyway svn:r2920	2004-11-20 12:41:05 +00:00
Roger Dingledine	6322287dc1	printfs want carriage returns svn:r2917	2004-11-20 08:00:57 +00:00
Roger Dingledine	dd19cf6ba3	kill -USR2 now moves all logs to loglevel debug plus fix some typos svn:r2914	2004-11-20 07:33:55 +00:00
Nick Mathewson	8acaf8e187	Add "MEMUNIT" and "INTERVAL" types to configuration. Also tweak Accounting setup. More docs needed svn:r2911	2004-11-20 00:37:00 +00:00
Roger Dingledine	2e4763655d	bugfix: when our poll is interrupted, we believed the revents values. svn:r2907	2004-11-17 20:26:39 +00:00
Nick Mathewson	647c076c8f	add a TODO item and some comment changes. svn:r2904	2004-11-16 03:32:01 +00:00
Roger Dingledine	abdf073f14	minor fixes svn:r2901	2004-11-16 03:12:53 +00:00
Nick Mathewson	7a8ac5dfef	Tweak on patch to make authoritative directory servers cache directories on disk. Make authdirservers cache their own directories instead of the ones they download. This gives better liveness, and marginally better resistance to broken authdirservers. Authdirservers don't cache running-routers at all: r-r isn't stored to disk, so there's no point right now. svn:r2893	2004-11-15 16:17:59 +00:00
Roger Dingledine	dbd4dadff7	Authoritative dirservers now also cache the directory, since they weren't writing anything into their datadirectory, so when they stop and start, they would know nothing until they fetched a directory from another authdirserver. svn:r2891	2004-11-15 09:38:17 +00:00
Roger Dingledine	50c15943a2	move second stat to a cleaner place svn:r2890	2004-11-15 09:22:01 +00:00
Roger Dingledine	4b76fe8036	Break DirFetchPostPeriod into: - DirFetchPeriod for fetching full directory, - StatusFetchPeriod for fetching running-routers, - DirPostPeriod for posting server descriptor, - RendPostPeriod for posting hidden service descriptors. Also make sure the hidden service descriptors are at a random offset from each other, to hinder linkability. svn:r2889	2004-11-15 09:05:54 +00:00
Roger Dingledine	67aa3b66c5	clean up socks handling, refuse connections to port 0 svn:r2888	2004-11-15 07:50:15 +00:00
Roger Dingledine	72dd656b88	a first cut at a print_usage() svn:r2887	2004-11-15 07:29:27 +00:00
Nick Mathewson	c909a8a64b	Only record bandwidth usage when accounting is enabled svn:r2886	2004-11-15 04:48:53 +00:00
Nick Mathewson	930464c889	Change "warn if unverified routers are very skewed" to "never warn about unverified router skew" svn:r2885	2004-11-15 04:28:24 +00:00
Nick Mathewson	22a0d82749	Cache running-routers; compress running-routers; serve compressed running-routers.z svn:r2883	2004-11-15 04:04:20 +00:00
Nick Mathewson	076f120951	Patch to patch: do not send both error and done for one command. svn:r2882	2004-11-15 04:02:59 +00:00
Roger Dingledine	ee591be3f2	fix a bug in configuring accounting in options_act() svn:r2881	2004-11-15 04:01:31 +00:00
Roger Dingledine	47993ae6fb	some fixes so far svn:r2880	2004-11-15 03:53:03 +00:00
Nick Mathewson	5109159ff9	Fix compilation. Duh. svn:r2876	2004-11-14 22:53:51 +00:00
Nick Mathewson	3e6edf20cc	Resolve some hibernating-related XXXX009s. svn:r2875	2004-11-14 22:21:23 +00:00
Nick Mathewson	402c75fb06	Allow more clock skew from unrecognized hosts than from recognized ones. svn:r2874	2004-11-14 22:08:25 +00:00
Nick Mathewson	57536f138a	Fetch running-routers. Split logic to initiate dirfetch, running-routers fetch, and descriptor post. arma: There are some XXXs here that raise design questions which we should solve before the next release. The biggest problem is this: Right now, the directory is about 50X as large as running-routers uncompressed, and about 36X as large compressed. Assuming: - everybody gets the compressed version of everything, - everybody gets cached directories from random dirservers and uncached r-r from authdirservers - everybody downloads r-r at the same rate they now download dirs, then using r-r from will increase authdirserver directory bandwidth usage if there are significantly more caches than authdirservers. I think it's safe to leave this in for now, since there aren't 3x36 caching dirservers, but we should make everybody with a dirport cache running-routers soon. But I could be wrong. svn:r2872	2004-11-14 21:46:40 +00:00
Nick Mathewson	2078b136f6	Make running-routers fetch (apparently) work svn:r2871	2004-11-14 21:35:30 +00:00
Nick Mathewson	bb80d60fe7	Hibernate if we start tor during the "wait for wakeup-time" phase of an accounting interval. Log our hibernation plans better. svn:r2869	2004-11-14 21:11:06 +00:00
Nick Mathewson	a732727a2b	Add simpler option_is_same, as suggested by arma. Finish implementing SAVECONF svn:r2868	2004-11-14 20:51:28 +00:00
Nick Mathewson	26973578bf	Fix windows whitespace svn:r2860	2004-11-14 18:21:17 +00:00
Nick Mathewson	aba71028be	Add an unreachable return 0. svn:r2859	2004-11-14 18:20:12 +00:00
Nick Mathewson	4f835673be	Remove redundant declaration svn:r2855	2004-11-14 17:22:10 +00:00
Roger Dingledine	846f71dcca	make kill -USR1 work again svn:r2853	2004-11-14 13:35:47 +00:00
Roger Dingledine	5dcc6fd8b2	ok ok the stat wasn't redundant but the warn was svn:r2852	2004-11-14 13:35:39 +00:00
Roger Dingledine	4564367b2a	Remove redundant stat() for reading cached directory, and remove confusing warn when the cached directory isn't there yet. svn:r2847	2004-11-14 09:40:07 +00:00
Roger Dingledine	3f5c113815	clean a comment svn:r2844	2004-11-14 04:55:02 +00:00
Nick Mathewson	ed4fa18699	normalize whitespace svn:r2839	2004-11-13 23:34:01 +00:00
Nick Mathewson	aab929abe0	Use the data, then free it. It works so much better. svn:r2837	2004-11-13 23:27:50 +00:00
Nick Mathewson	dc48e7aeed	Document remaining configuration options; add a ccheck for redundant authentication mechanisms in options_validate; add TODO items for post-009 hibernation features svn:r2833	2004-11-13 17:17:04 +00:00
Nick Mathewson	08627d5d87	Track whether descriptor is dirty/uploaded. When any options are set, mark it dirty. Once a minute, regenerate and upload the server descriptor if it is dirty. svn:r2832	2004-11-13 16:53:48 +00:00
Nick Mathewson	0b42e31fe0	Comment a confusing conditional svn:r2828	2004-11-13 02:54:30 +00:00
Roger Dingledine	5864f4ac01	fix a seg fault when fetching rendezvous descs svn:r2825	2004-11-12 21:59:27 +00:00
Nick Mathewson	a8f9ba91db	Nobody was using the return values from smartlist_(set\|del\|del_keeporder), so remove them. svn:r2823	2004-11-12 21:14:06 +00:00
Nick Mathewson	eabcf6618e	Write most of the implementation for SAVECONF. svn:r2820	2004-11-12 20:09:54 +00:00
Nick Mathewson	5109de5626	Rename exit_policy to addr_policy, since it gets used for SOCKS and directory connections too. Make all policies get validated in options_validate, and make SOCKS/directory policies get set in options_act. svn:r2819	2004-11-12 19:39:13 +00:00
Nick Mathewson	60880cda84	Resolve a bunch of FIXME items; mark a lot more for attention; ask for clarification on some. Turn all XXXX008 ("showstopper for 0.0.8 release") items into XXXX009 or XXXX, since plainly they were not showstoppers for 0.0.8. Add/clean some docs. svn:r2808	2004-11-12 16:39:03 +00:00
Nick Mathewson	2a5bcb29e6	Resolve FIXME: Possible solution to note_disconnect problem; needs thought and review. svn:r2807	2004-11-12 05:52:19 +00:00
Nick Mathewson	5d92fbe30e	Use autoconf to enable largefile support where necessary. Use ftello where available, since ftell can fail at 2GB. svn:r2806	2004-11-12 05:05:41 +00:00
Nick Mathewson	0faab62cd9	Resolve FIXMES: sometimes an error code is just an error code svn:r2805	2004-11-12 05:03:50 +00:00
Roger Dingledine	90e0ad517e	dfc caught a SIGXFSZ error when his debugfile reached 2GB. so if they exist, catch them and ignore them. write() will fail normally and we'll look at errno like normal human beings. svn:r2804	2004-11-12 04:59:37 +00:00
Roger Dingledine	fde595feb7	when clients do --list-fingerprint, it's misleading to give them one, because it will never be the same again svn:r2800	2004-11-11 13:24:10 +00:00
Nick Mathewson	6252cba522	apply patch from Andre Eisenbach: include event code with events, as required by control-spec.txt svn:r2799	2004-11-11 00:54:53 +00:00
Nick Mathewson	e69d9647ed	Remove XXXX009 comment telling us to do the last (circID-related) fix svn:r2798	2004-11-10 20:19:45 +00:00
Nick Mathewson	954570486f	Resolve a FIXME: use identity comparison, not nickname comparison, to choose circuit ID types. This is important because our view of "the nickname of the router on the other side of this connection" is skewed, and depends on whether we think the other rotuer is verified--and there's no way to know whether another router thinks you are verified. For backward compatibility, we notice when the other router chooses the same circuit ID type as us (because it's running an old version), and switch our type to be polite. svn:r2797	2004-11-10 20:14:37 +00:00
Nick Mathewson	ec49905fb8	When we think we have no bandwidth, guess that we will run for 1 day. svn:r2795	2004-11-10 19:32:44 +00:00
Nick Mathewson	9c22b428bf	Clarify a warning about /.tor svn:r2794	2004-11-10 14:29:18 +00:00
Nick Mathewson	a43db78e8d	Resolve FIXME items: make the kill-unattached-AP timeout symbolic svn:r2793	2004-11-10 14:28:47 +00:00
Nick Mathewson	c9af37d1ba	Resolve FIXME items: make circuit_free_cpath_node static svn:r2792	2004-11-10 14:28:04 +00:00
Nick Mathewson	fde4129ac3	Resolve FIXME items: clarify two XXXX comments for 009 svn:r2791	2004-11-10 14:27:26 +00:00
Nick Mathewson	aa1c0c4d67	Resolve FIXME items: fix assert failure on malformed socks4a qreuests. (bug reported by Anna Shubina wrt old Netscapes) svn:r2790	2004-11-10 14:26:34 +00:00
Nick Mathewson	c1bf171ed8	Fix a few bugs in accounting: parse bw_accounting correctly; set end time of continued interval; record used bandwidth on state change. svn:r2785	2004-11-10 04:19:53 +00:00
Roger Dingledine	646903542a	make nick's config patch build svn:r2783	2004-11-10 03:48:38 +00:00
Nick Mathewson	1013abd27f	Validate log options during options_validate(). Reject unrecognized log types like "Log notice magic-twanger". Also, make sure User and Group stay the same, and do not crash when somebody tries to change PidFile to NULL. svn:r2778	2004-11-10 03:40:30 +00:00
Roger Dingledine	af9683501c	make abbreviations case-insensitive (thanks weasel) svn:r2773	2004-11-10 03:22:49 +00:00
Roger Dingledine	d9a74cd0af	make it more obvious that we have just told them their new torrc log line. svn:r2772	2004-11-10 03:08:03 +00:00
Roger Dingledine	c03a3eaed0	weaken our anonymity warning a little bit more svn:r2771	2004-11-10 02:58:27 +00:00
Nick Mathewson	4cdddcc13d	Remvove an XXX svn:r2769	2004-11-10 02:02:06 +00:00
Roger Dingledine	ab951fc828	remove extraneous variable svn:r2765	2004-11-10 00:19:18 +00:00
Roger Dingledine	7528e8b86a	don't check permissions on our datadirectory until we switch uid/gid svn:r2759	2004-11-10 00:11:37 +00:00
Nick Mathewson	5a5be93f80	Normalize whitespace; add a "tell me about all the unnormalized whitespace" target; fix a braino in dirserv.c svn:r2758	2004-11-09 20:04:00 +00:00
Nick Mathewson	7daab4034d	Fix windows build for VC6; centralize newline-fiasco-damage-control logic svn:r2756	2004-11-09 19:13:08 +00:00
Nick Mathewson	cd753df7bf	Resolve many XXXs and all DOCDOCs svn:r2755	2004-11-09 18:22:17 +00:00
Nick Mathewson	b960574556	Change interface to config_trial_assign even more; have it use get_options() instead svn:r2754	2004-11-09 17:15:17 +00:00
Nick Mathewson	a2079c074f	Add some documentation to routerlist svn:r2753	2004-11-09 17:14:15 +00:00
Nick Mathewson	548d4174ef	When listing router status, include ourself if we are awake svn:r2752	2004-11-09 17:12:56 +00:00
Roger Dingledine	3ce3d6eead	resolve a 64-bit warning svn:r2750	2004-11-09 11:36:38 +00:00
Roger Dingledine	ca070e7de6	bugfix: ^c ought to work even while hibernating svn:r2748	2004-11-09 11:14:34 +00:00
Roger Dingledine	b773045a58	only non-authdirservers cache the dir they just fetched svn:r2747	2004-11-09 10:38:42 +00:00
Roger Dingledine	3235c72f6c	control event logs include loglevel notice svn:r2746	2004-11-09 10:32:02 +00:00
Roger Dingledine	a972589bdb	allow BandwidthRate and Burst to be abbrevs in the torrc too svn:r2744	2004-11-09 10:30:06 +00:00
Roger Dingledine	8d8d6b5661	raise your hand if you can spell svn:r2743	2004-11-09 10:21:19 +00:00
Roger Dingledine	233f516d61	if you're going to ask it to use a body of length 0, don't give it a body. svn:r2742	2004-11-09 10:18:41 +00:00
Roger Dingledine	dd3a12c929	fix a memory-squashing bug that was causing an infinite loop svn:r2741	2004-11-09 10:08:42 +00:00
Roger Dingledine	6a504efdd3	mark_logs_temp() before init'ing new ones. we were seeing double, triple, etc each time we setconf'ed. svn:r2738	2004-11-09 08:01:39 +00:00
Roger Dingledine	3901473bf3	change the interface to config_trial_assign() svn:r2737	2004-11-09 07:55:48 +00:00
Roger Dingledine	2d18d9eefb	when you try a new set of options, and you like them, make sure they stick svn:r2736	2004-11-09 07:45:24 +00:00
Roger Dingledine	9f3e3d2b71	stop wanting to split init_keys() svn:r2735	2004-11-09 07:29:05 +00:00
Roger Dingledine	cad26b343d	once normalized, DataDirectory is always defined svn:r2734	2004-11-09 07:20:21 +00:00
Nick Mathewson	180e0a9326	Make check_private_dir trimodal (check/create/ignore), not bimodal (create/ignore). svn:r2733	2004-11-09 07:12:31 +00:00
Roger Dingledine	6521c2ce51	Stop using the wrong DataDirectory when we're validating. Also validate/normalize the DataDirectory better. svn:r2732	2004-11-09 07:05:53 +00:00
Nick Mathewson	48a0b6c476	Separate is-recognized-option from get-option-value, since NULL is ambiguous and returning "" misrepresents. svn:r2731	2004-11-09 06:40:32 +00:00
Roger Dingledine	005b02fd57	when rejecting an old-style router descriptor, tell us its nickname svn:r2730	2004-11-09 06:37:58 +00:00
Roger Dingledine	677124fd0c	During options_dup, don't copy LINELIST_S or OBSOLETE options. And recognize obsolete options now in config_get_assigned_option(). svn:r2729	2004-11-09 06:18:17 +00:00
Roger Dingledine	94b9525f6e	EntryNodess is not the plural of EntryNodes svn:r2728	2004-11-09 06:09:06 +00:00
Roger Dingledine	3c6b6a53a9	and another svn:r2727	2004-11-09 06:03:20 +00:00
Roger Dingledine	5c2278aea8	fix some dereferences svn:r2726	2004-11-09 05:59:22 +00:00
Roger Dingledine	ef6bdd6c1e	make datadirectory work again svn:r2724	2004-11-09 05:35:49 +00:00
Nick Mathewson	2677395aaf	Normalize DataDirectory in options_validate, making SIGHUP survivable. svn:r2722	2004-11-09 05:26:49 +00:00
Nick Mathewson	a5903b737a	Document accounting svn:r2721	2004-11-09 05:18:15 +00:00
Nick Mathewson	929b172955	Stop DataDirectory from changing; also stop using new as an identifier? svn:r2717	2004-11-09 04:46:24 +00:00
Roger Dingledine	90b47172bd	Make an options_act() where we do all the things a new options set needs. Still needs more work. svn:r2716	2004-11-09 04:28:18 +00:00
Roger Dingledine	3805221262	stop breaking the get_options() abstraction in config.c svn:r2715	2004-11-09 02:12:55 +00:00
Roger Dingledine	e3a067c73a	fix comments in hibernate.c svn:r2714	2004-11-09 02:12:41 +00:00
Roger Dingledine	8c7b2ff7ed	various fixes svn:r2712	2004-11-09 01:24:10 +00:00
Nick Mathewson	cb5de85585	Separate validate from activate. Document undocumented stuff in config.c. svn:r2711	2004-11-08 23:12:40 +00:00
Roger Dingledine	8b9d7da59f	while we hibernate, our declared bandwidth capacity is 0 svn:r2710	2004-11-07 23:19:12 +00:00
Nick Mathewson	2640be28fa	Document hibernate.c. Also fix handling of corner case where we hit the end of the interval while we are in HIBERNATE_STATE_LOWBANDWIDTH svn:r2709	2004-11-07 23:14:47 +00:00
Nick Mathewson	fc9c6e7c95	Fix compile errors svn:r2708	2004-11-07 23:11:29 +00:00
Nick Mathewson	f9c85c4d1c	Make set-option functions distinguish between bad keys and bad values, in case the caller cares svn:r2707	2004-11-07 22:59:30 +00:00
Nick Mathewson	c514a06663	Fix up error codes svn:r2706	2004-11-07 22:58:35 +00:00
Nick Mathewson	0059ee5fea	More tests for split svn:r2705	2004-11-07 22:58:16 +00:00
Roger Dingledine	dac5d6715e	add saveconf control command. allow authentication by localhost, but if tor demands more, require more. svn:r2704	2004-11-07 22:37:59 +00:00
Nick Mathewson	66779137bf	Add missing dereference; stop throwing zeroes around. svn:r2702	2004-11-07 22:18:00 +00:00
Nick Mathewson	2cacb4e0f9	Document control.c svn:r2700	2004-11-07 21:37:50 +00:00
Roger Dingledine	3236ee3127	allow unauth control connections for now let control connections recognize eof svn:r2699	2004-11-07 11:33:04 +00:00
Roger Dingledine	394554cfbf	Clean up copyrights. Break connection_consider_empty_buckets() out of connection_read_bucket_decrement(). svn:r2698	2004-11-07 01:33:06 +00:00
Roger Dingledine	efad93feb4	tor --list-fingerprint as a client shouldn't try to print null svn:r2697	2004-11-06 09:22:08 +00:00
Roger Dingledine	53a2b22742	fix the next subtle memory-crunching bug now hup works svn:r2696	2004-11-06 08:55:22 +00:00
Roger Dingledine	e2e6d19e76	fix subtle bug that was causing logs to not show anything svn:r2695	2004-11-06 07:40:20 +00:00
Roger Dingledine	28a297ebe7	only play the accounting game if it's possible you'll choose to hibernate svn:r2694	2004-11-06 06:56:28 +00:00
Roger Dingledine	6c61ed4fb5	Make options no longer a global variable. Now we can try setting an option but back out if it fails to parse, or if it's disallowed (e.g. changing RunAsDaemon from 1 to 0). Use parse_line_from_str rather than parse_line_from_file. svn:r2692	2004-11-06 05:18:11 +00:00
Nick Mathewson	f490e5cdb6	Update log documentation svn:r2691	2004-11-05 21:22:38 +00:00
Nick Mathewson	7c0792d89a	Write hibernation code. Needs docs and tests. svn:r2689	2004-11-05 17:55:34 +00:00
Nick Mathewson	2e8353e2f4	Use new log format; convert old format to new format. svn:r2684	2004-11-05 05:50:35 +00:00
Roger Dingledine	2ba3a9de16	make the default default options.FirewallPorts be the default svn:r2683	2004-11-04 23:39:57 +00:00
Nick Mathewson	19868fe968	Move accounting code into hibernate; start adding logic to track bandwidth-per-seconds-active svn:r2680	2004-11-04 22:33:06 +00:00
Nick Mathewson	1b49198081	Support code for resettable options, and option sets. Still needs validate-and-then-replace logic svn:r2679	2004-11-04 22:31:50 +00:00
Nick Mathewson	d9e0f3f9bc	Make sure control command bodies are always followed by a NUL svn:r2678	2004-11-04 22:30:49 +00:00
Nick Mathewson	9d604ec615	Add code to read configuration lines from a string as well as a file svn:r2676	2004-11-04 22:29:45 +00:00
Roger Dingledine	f7a30fa73e	break out validate_options leave options.FirewallPorts NULL if it's NULL svn:r2673	2004-11-04 10:23:30 +00:00
Roger Dingledine	cadbae6aa5	make free_options() and init_options() use the big array. also remove obsolete config_assign_defaults(). svn:r2672	2004-11-04 08:26:34 +00:00
Roger Dingledine	59453ac6ef	add a ControlPort and control listener conn. note that print_usage is obsolete. svn:r2671	2004-11-04 06:41:49 +00:00
Nick Mathewson	b74b72a5ce	Fix windows build svn:r2670	2004-11-04 04:01:19 +00:00
Roger Dingledine	d0c158c8d6	clarify the bandwidthburst and bandwidthrate are in bytes (niels had thought they were in bits, or kb, or something) svn:r2669	2004-11-04 03:25:43 +00:00
Roger Dingledine	a4753283dd	better interface for connection_ap_handshake_socks_reply() make --list-fingerprint print the fingerprint again svn:r2668	2004-11-03 23:13:28 +00:00
Nick Mathewson	5b312541d7	fix windows warnings svn:r2667	2004-11-03 21:53:54 +00:00
Nick Mathewson	cea9125d71	Implement two flavors of authentication for control connections: one for trusted FS, one for untrusted FS. svn:r2664	2004-11-03 19:49:03 +00:00
Nick Mathewson	451f8b5045	- Implement all of control interface except authentication, setconfig, and actually making the sockets. - Make sure that identity-based nicknames start with $. - Use new string_join interface. svn:r2661	2004-11-03 18:33:07 +00:00
Nick Mathewson	86ba00290b	Add function to generate/copy the config_lines, given the name of an option svn:r2660	2004-11-03 18:29:29 +00:00
Nick Mathewson	4fdaa5de51	Streamline the two redundant "Has the second rolled over?" checks in prepare_for_poll and connection_bucket_refill; also, generate BANDWIDTH control events svn:r2657	2004-11-03 16:38:04 +00:00
Roger Dingledine	12e92eb82f	connection_read_bucket_decrement() has a side-effect that we need to get even if we just read 0 bytes svn:r2656	2004-11-03 10:18:31 +00:00
Roger Dingledine	e541319dcb	lay the groundwork for a default value for each config option. tolerate null exitnodes, entrynodes, etc config options. svn:r2655	2004-11-03 10:08:44 +00:00
Nick Mathewson	347d3f9d62	Start implementing control interface. svn:r2652	2004-11-03 01:32:26 +00:00
Nick Mathewson	d63d420930	Fix another typo svn:r2651	2004-11-03 01:31:42 +00:00
Nick Mathewson	8db0abb687	First attempt at hibernation code. It needs more work around the XXXXs, but first I want arma to review the basic approach while I meditate on how to fix them. svn:r2649	2004-11-02 23:47:32 +00:00
Nick Mathewson	ad4dc74482	Use a stricter set of warnings; make them all pass. svn:r2645	2004-11-02 03:02:17 +00:00
Roger Dingledine	85c79ffbc7	canonicalize "src" and "dest" arg order in crypto.c (and others) svn:r2644	2004-11-02 02:28:51 +00:00
Roger Dingledine	b390786582	Hidden service operators had a bug in version 1 style INTRODUCE cells that made them fail. Fix the bug, and revert clients to use version 0 until 0.0.9pre4 is obsolete. svn:r2641	2004-11-01 21:46:27 +00:00
Nick Mathewson	ce79bab7f1	Split util into util (general utilities), container (smartlist and strmap), and compat (cross-platform compatability). svn:r2640	2004-11-01 20:41:47 +00:00
Roger Dingledine	4689243242	make sure options.MaxConn can be reached svn:r2638	2004-11-01 08:24:34 +00:00
Roger Dingledine	282816b498	change min required number of fd's to 1024 svn:r2636	2004-11-01 08:09:59 +00:00
Roger Dingledine	790349c645	oh, and add the actual file too svn:r2631	2004-10-31 20:29:25 +00:00
Roger Dingledine	984ffec105	implement first piece of hibernation still need to track bandwidth, and make decisions based on bandwidth svn:r2630	2004-10-31 20:28:41 +00:00
Nick Mathewson	ae7495dd55	Only tor and test binaries need to link against openssl and zlib; tor-resolve can be smaller. svn:r2629	2004-10-30 19:27:06 +00:00
Nick Mathewson	9510d9a792	tor --list-fingerprint to print fingerprint and exit svn:r2627	2004-10-30 19:18:37 +00:00
Roger Dingledine	51e16233cb	Fix paul gardner's assert bug. Turns out when circuit_launch_by_nickname() failed at the first hop, it would try to relaunch another circ right then, even though the first circuit hadn't been populated yet with its pending_final_cpath. svn:r2624	2004-10-30 05:04:52 +00:00
Nick Mathewson	11d330be5e	Tweaks to prevent obsolete restarting tors from hammering the dirservers. (1) Cache a received directory as soon as the signature checks out. (2) Treat a cached directory as "recent" based on its mtime. (3) If we have a recent directory, we dont need to fetch a newer one for DirFetchPostPeriod. This needs review! svn:r2618	2004-10-28 18:37:52 +00:00
Nick Mathewson	36bbab2f2b	Fix in warning fix svn:r2617	2004-10-27 21:54:44 +00:00
Nick Mathewson	f8771625c6	Check return of tor_snprintf svn:r2616	2004-10-27 21:30:47 +00:00
Nick Mathewson	2fbf31533b	Tricksy compiler warnings! We hates them, hates them forever, my precious! svn:r2615	2004-10-27 21:14:11 +00:00
Nick Mathewson	ce5709184b	Pass with -Wstrict-prototypes svn:r2614	2004-10-27 18:16:37 +00:00
Nick Mathewson	6874c39904	Fix windows build svn:r2613	2004-10-27 18:14:38 +00:00
Nick Mathewson	c5eb95b644	Add ability for some-but-not-all abbrevs to work in config file. Add a bunch of singular/plural abbrevs suggested by arma svn:r2612	2004-10-27 17:37:01 +00:00
Roger Dingledine	75ad4615d1	stop freeing arbitrary memory fix a couple of memory leaks svn:r2611	2004-10-27 12:34:02 +00:00
Nick Mathewson	6980929e64	Use strlcpy, not strcpy. svn:r2610	2004-10-27 06:48:16 +00:00
Nick Mathewson	44d4516155	Use tor_snprintf, not snprintf svn:r2609	2004-10-27 06:37:34 +00:00
Nick Mathewson	06fa8fc05f	Avoid strcat; use snprintf or strlcat instead svn:r2605	2004-10-27 06:25:29 +00:00
Nick Mathewson	f67f83b1fa	Use strlcpy, not strncpy svn:r2603	2004-10-27 06:03:28 +00:00
Nick Mathewson	bc62f8e983	Replace sprintf with snprintf svn:r2602	2004-10-27 05:53:07 +00:00
Nick Mathewson	5369ee921e	Make it compile on Linux svn:r2600	2004-10-27 03:42:09 +00:00
Nick Mathewson	482c309db9	Document new config code svn:r2596	2004-10-27 03:08:04 +00:00
Nick Mathewson	a24eb4db91	Re-write configuration option lookup code: use a table, not a big if( \|\| \|\| \|\| \|\|). Deprecate unoffical abbrevs and abbrevs not on the command line. svn:r2594	2004-10-27 02:30:28 +00:00
Nick Mathewson	b90b2bb848	Add and document router-status line using new unified liveness/verifiedness format; continue to generate running-routers; continue to parse running-routers when no router-status line is found svn:r2592	2004-10-27 00:48:51 +00:00
Nick Mathewson	26f3cb8652	Add SysLog option to direct log messages to the system log instead of a FILE*. svn:r2591	2004-10-26 21:48:41 +00:00
Roger Dingledine	0113a643a2	quick-and-dirty dir policy since the dirservers are getting hammered nick, could you abstract this sometime so we don't repeat the sockspolicy code twice? svn:r2589	2004-10-25 06:16:26 +00:00
Roger Dingledine	20cdc0a517	fix a memory leak svn:r2587	2004-10-24 23:09:48 +00:00
Roger Dingledine	defe1e5f3c	start generating new version of introduce1 cells svn:r2586	2004-10-24 19:08:07 +00:00
Roger Dingledine	0b36c29c4d	fix wrong comment svn:r2585	2004-10-24 17:11:44 +00:00
Nick Mathewson	ef4ac65f5e	Document the swiss-army-knife that retry_listeners has become svn:r2584	2004-10-24 01:50:33 +00:00
Nick Mathewson	0df2d383d1	Many non-native speakers use Tor. It is our duty to ensure that our log messages set an example of good English spelling. svn:r2583	2004-10-24 01:29:01 +00:00
Nick Mathewson	57f09573f5	Every 60 seconds, check whether the listeners are still alive, and relaunch the dead ones. svn:r2581	2004-10-24 01:22:40 +00:00
Nick Mathewson	04ca660b2a	Fix typo in last windows patch svn:r2580	2004-10-24 00:58:29 +00:00
Nick Mathewson	5d53828c57	Handle more errnos from accept() without closing the connection. This may fix a bug that could close OR listeners when (a) TCP connections were hung up before accept() could be called, or (b) during FD exhaustion. svn:r2579	2004-10-24 00:55:18 +00:00
Nick Mathewson	78a2c3aa39	Make windows fall back to CWD if SHGetSpecialFolderLocation is borked svn:r2578	2004-10-24 00:52:10 +00:00
Roger Dingledine	54c432bd93	pay attention to the return value of do_hup, and exit when it fails svn:r2577	2004-10-23 17:06:25 +00:00
Nick Mathewson	6899b8001a	Check for low _MSC_VER, not high. On windows, always use winsock. svn:r2575	2004-10-20 23:30:38 +00:00
Nick Mathewson	88cffc3c5f	Use bitwise masking to turn off bits, not compare-and-subtract svn:r2572	2004-10-20 23:15:49 +00:00
Nick Mathewson	e5049d5aa3	Remove routerinfo_t->is_trusted_dir, and all the twisted machinery used to maintain it. Have clients default to the nickname "client" in their certificates. Give a less frightening warning on obsolete (pre-0.0.8) routerinfo_t's. svn:r2568	2004-10-19 18:19:59 +00:00
Nick Mathewson	c7151d8bed	Add "pass" target for RedirectExit, to make it easier to break out of a sequence of rules svn:r2566	2004-10-19 17:46:06 +00:00
Roger Dingledine	97a0a43511	start the process of making 0.0.7* obsolete svn:r2565	2004-10-17 21:51:20 +00:00
Roger Dingledine	640544ae3e	use connection_edge_is_rendezvous_stream() more svn:r2564	2004-10-17 21:10:41 +00:00
Roger Dingledine	695cdb10fe	whoops, resolve cells were probably broken svn:r2562	2004-10-17 20:31:19 +00:00
Nick Mathewson	b130aa3c8f	Fix segfault in unit tests. (Main program is unaffected) svn:r2559	2004-10-17 15:45:54 +00:00
Roger Dingledine	e66d5f897a	fix a seg fault with exitredirect svn:r2555	2004-10-17 04:44:02 +00:00
Roger Dingledine	560a4a1407	switch conn->addr and conn->dir_port to reflect the final destination, not the http proxy svn:r2553	2004-10-17 04:06:48 +00:00
Nick Mathewson	6d1e1b7f46	Unify windows special-dir handling svn:r2552	2004-10-17 03:38:02 +00:00
Nick Mathewson	8d27385c23	Implement RedirectExit. svn:r2550	2004-10-17 01:57:34 +00:00
Roger Dingledine	7c3ab346f6	various tweaks and fixes svn:r2548	2004-10-16 22:56:46 +00:00
Nick Mathewson	a1bf39f698	Code to parse (but not yet actually use) RedirectExit lines svn:r2546	2004-10-16 22:37:08 +00:00
Roger Dingledine	de65052312	don't assert multiple things in the same tor_assert() svn:r2544	2004-10-16 22:14:52 +00:00
Nick Mathewson	25a046df74	Fix unit tests, make it compile svn:r2543	2004-10-16 21:57:24 +00:00
Nick Mathewson	47dc024f7e	Change interface of parse_addr_port() to return address in host order, since most users seem to want that. svn:r2542	2004-10-16 21:53:30 +00:00
Nick Mathewson	8300c4ae6a	Make unit tests pass; refactor most of exit policy parfsing out into new function svn:r2541	2004-10-16 21:42:09 +00:00
Nick Mathewson	a42adce362	fix memory leak in router.c; start relying on NULL==(zero bytes) svn:r2538	2004-10-16 20:38:57 +00:00
Nick Mathewson	56a592dbe3	Fix memory leak svn:r2535	2004-10-16 08:39:56 +00:00
Nick Mathewson	9d5831341e	Implement user-declared node families. svn:r2534	2004-10-15 20:52:09 +00:00
Nick Mathewson	f882bd92ed	Remove unused locals svn:r2533	2004-10-15 20:50:43 +00:00
Nick Mathewson	99f7955372	Use the real default exit policy, not reject : svn:r2531	2004-10-15 19:18:08 +00:00
Nick Mathewson	fa9c121343	Add a comment svn:r2530	2004-10-15 19:17:36 +00:00
Nick Mathewson	28dd458eaf	Upload to trusted dir servers based on DirServer config options, not on routerinfos. svn:r2529	2004-10-15 19:04:38 +00:00
Nick Mathewson	01eacbca9e	Make RecommendedVersions a CONFIG_TYPE_LINELIST option, and have it tolerate whitespace a little better. svn:r2528	2004-10-15 05:09:48 +00:00
Nick Mathewson	88e0c080cf	Ignore fascistfirewall when dealing with service descriptors; obey fascistfirewall when posting server descriptors; ignore fascistfirewall on directory connections when httpproxy is set. svn:r2527	2004-10-15 04:57:36 +00:00
Nick Mathewson	ff38cc06e1	Fix search-and-replace in comments: Friends->family does not imply friendship->familyhip. svn:r2525	2004-10-15 03:55:53 +00:00
Nick Mathewson	7fa5d224d4	Implement "families" of coadministered nodes; prevent them all from appearing on the same circuit. svn:r2523	2004-10-15 01:58:11 +00:00
Nick Mathewson	c5964d6738	Basic string-join functionality svn:r2521	2004-10-14 19:51:47 +00:00
Nick Mathewson	0f144d6a04	fix warning on win32 svn:r2518	2004-10-14 15:41:41 +00:00
Roger Dingledine	56e151eb41	advertise moria2's dirport as 18.244.0.114:80 svn:r2511	2004-10-14 10:05:22 +00:00
Roger Dingledine	cf9664151d	bugfix on a really old bug: if read() fails on a stream, send back an end cell before you close it down. svn:r2509	2004-10-14 09:28:31 +00:00
Roger Dingledine	572714a458	bugfix: parse_addr_port() bites us again -- it returns addr in network order. svn:r2508	2004-10-14 08:45:07 +00:00
Roger Dingledine	95644480c5	better warn message for the Content-Length attack svn:r2495	2004-10-14 04:50:33 +00:00
Nick Mathewson	55b811a259	Improve warnings for old-style directories. svn:r2494	2004-10-14 04:31:40 +00:00
Nick Mathewson	08c33f0b46	Compile without warnings on windows svn:r2491	2004-10-14 04:06:24 +00:00
Nick Mathewson	bd10bf4b5b	Try to always dtrt if routerlist==NULL svn:r2489	2004-10-14 03:44:45 +00:00
Roger Dingledine	89280e6c20	rename addr to address to we avoid this bug later svn:r2488	2004-10-14 03:31:40 +00:00
Nick Mathewson	1c9426d6e0	Build without warnings on mac gcc 3.3 svn:r2487	2004-10-14 03:18:14 +00:00
Roger Dingledine	3737566465	make it build on amd64 svn:r2486	2004-10-14 03:13:08 +00:00
Roger Dingledine	69830afc16	and another one svn:r2484	2004-10-14 02:49:48 +00:00
Roger Dingledine	aebc3a03ba	more int to size_t conversions, fixing one or more amd64 bugs plus a whitespace patch on config.c from vicman svn:r2482	2004-10-14 02:47:09 +00:00
Nick Mathewson	92bb360ad7	Add missing line; add similar check svn:r2481	2004-10-14 02:29:03 +00:00
Nick Mathewson	8b325c142e	Patch from "J Doe": Use SHGetSpecialFolderLocation instead of SHGetSpecialFolderPath in order to find application data folder. Apparently, until IE 4 (!?) came out, nobody realized that programmers might like to get paths as strings. Clearly, a fancy pseudo-OO list of "identifiers" is a far more convenient way to deal with these things. And while we're being OO, why return object that you can free with free()? Instead, let's make the user get a handle to an abstract allocation object, and ask it to free the fancy list, and then ask it to release itself. Won't that be fun and convenient? Navigating ancient Win32 APIs is like bikini-waxing creatures from HP Lovecraft: to do a good job you must understand what's going on... but the understanding itself can blast your sanity. svn:r2480	2004-10-14 02:04:43 +00:00
Nick Mathewson	0d5a847f12	Remove need for dirservers file: now, we note trusted dirservers in configuration options, and only need to remember addr:port and key digest for each one. svn:r2479	2004-10-14 01:44:32 +00:00
Nick Mathewson	55634e4eec	Fix comment in dirserv.c svn:r2470	2004-10-13 20:28:46 +00:00
Roger Dingledine	2b7b86f5e6	stop trying to print a NULL plus make router_nickname_is_approved() more obviously unused svn:r2469	2004-10-13 20:17:45 +00:00
Nick Mathewson	e0cce8fba8	Unify tests for "did I originate this nonopen OR connection?" svn:r2468	2004-10-13 20:05:57 +00:00
Nick Mathewson	30dd1c87a5	Add default trusted-dir-server entries only when no dirserver lines are given in the config file svn:r2467	2004-10-13 19:56:42 +00:00
Nick Mathewson	508970f85d	fix typo svn:r2466	2004-10-13 19:55:40 +00:00
Nick Mathewson	f14117bffd	fix warning about always-false comparison; detect too-large realport better svn:r2465	2004-10-13 19:53:34 +00:00
Nick Mathewson	149f57bdef	answer question about rep_hist_note_connect_failed svn:r2464	2004-10-13 19:42:36 +00:00
Nick Mathewson	afd8b650ee	hex-to-hex compare makes more sense than hex-to-bin. svn:r2463	2004-10-13 19:17:27 +00:00
Nick Mathewson	df3098367c	Make directories get generated properly again; debug key lookup. Also, it is hard to find entries in a table when you never put them there. svn:r2462	2004-10-13 18:28:39 +00:00
Roger Dingledine	a1041154eb	fix const char * vs char * issue plus unshadow some variables svn:r2460	2004-10-13 04:44:37 +00:00
Nick Mathewson	9dc72de41f	Omit any exit rules that follow a catch-all rule when writing a router descriptor. svn:r2459	2004-10-13 01:25:42 +00:00
Nick Mathewson	9c49947163	Check fingerprint list before generating running-routers lists; also add as-yet-uncalled function to update an OR connection nickname on the fly svn:r2458	2004-10-13 01:13:37 +00:00
Roger Dingledine	0b4d3c4df7	parse HttpProxy address in config fix a potential confusion in fetch_from_buf_http() make all our int config options non-negative better bounds checking on options that are ports svn:r2456	2004-10-12 20:22:09 +00:00
Nick Mathewson	7cc126e8a9	Appease overzealous gcc svn:r2454	2004-10-12 20:17:45 +00:00
Nick Mathewson	f7404f6bb9	Use tor_parse_long in more places svn:r2453	2004-10-12 19:33:03 +00:00
Nick Mathewson	e7241044e8	Better bounds checking on parsed ints svn:r2450	2004-10-12 19:01:53 +00:00
Nick Mathewson	e8748b3fa0	Add default directory servers svn:r2449	2004-10-12 19:01:28 +00:00
Nick Mathewson	f6fc2b9dd2	Add fix for remote-crash bug. svn:r2447	2004-10-12 18:38:36 +00:00
Roger Dingledine	578a3e25e5	fix a signed/unsigned comparison svn:r2446	2004-10-12 18:32:34 +00:00
Nick Mathewson	79636823b8	Oops, missed one svn:r2445	2004-10-12 16:04:25 +00:00
Nick Mathewson	a91fc48b39	Note byte-order on result for parse_addr_port() svn:r2444	2004-10-12 16:02:15 +00:00
Nick Mathewson	0068415b80	Add an implementation of trusted_dir_server logic to switch towards simply remembering an addr/port/keyid for each trusted dir server svn:r2443	2004-10-12 15:55:20 +00:00
Nick Mathewson	43ef5a3e37	Add long-term format for dir-signing-key fields (commented out) svn:r2442	2004-10-12 15:52:57 +00:00
Nick Mathewson	0383afac9a	Use parse_addr_port() function instead of ad-hoc variants svn:r2441	2004-10-12 15:52:09 +00:00
Nick Mathewson	8b037509f3	Add functions to parse addr[:port] consistently svn:r2440	2004-10-12 15:48:30 +00:00
Roger Dingledine	1efad74164	bugfix on my friday commit: make hidden services work again in cvs svn:r2439	2004-10-12 06:03:10 +00:00
Roger Dingledine	24f9946db1	fix paul gardner's assert bug. sometimes circuit_get_open_circ_or_launch() can return 0 but not return a circuit, e.g. because too many circuits have failed recently so the new one didn't launch. we need to tolerate that. svn:r2438	2004-10-11 22:19:12 +00:00
Roger Dingledine	5c53c63aa0	Fix a potential buffer overflow found by Ilja van Sprundel. We don't think this is exploitable, but best to fix it anyway. svn:r2437	2004-10-11 21:55:19 +00:00
Roger Dingledine	7798e3d770	fix the stale pointer assert bug reported by joe magic svn:r2436	2004-10-11 01:17:42 +00:00
Roger Dingledine	6468e049be	when a begin cell has an invalid port, give us a better hint of what went wrong svn:r2435	2004-10-10 01:47:24 +00:00
Roger Dingledine	1a4cb248f3	interim commit for http proxy support svn:r2431	2004-10-08 05:53:59 +00:00
Nick Mathewson	6c970aec94	Turn tor_strpartion into a swiss-army-knife function, so it can terminate or not-terminate appropriately. svn:r2429	2004-10-07 21:37:06 +00:00
Nick Mathewson	c7e8c2098a	Include a dir-signing-key token in directories to tell the parsing entity which key is being used to sign. This is the first step in obsoleting the dirservers file. svn:r2428	2004-10-07 21:10:40 +00:00
Nick Mathewson	dad7c71686	Workaround for bug on windows where cached-directories get crlf corruption. svn:r2426	2004-10-07 20:22:58 +00:00
Nick Mathewson	b7bddcac75	Windows requires a different cast uint64_t format svn:r2424	2004-10-07 20:15:56 +00:00
Nick Mathewson	ce3162d035	Make base-64-encoded DER work, including workaround for ugly openssl misfeature that makes base64 decoding fail when you strip out the newlines. svn:r2423	2004-10-07 03:11:42 +00:00
Nick Mathewson	2bba65148b	Refactor fingerprint handling: remember hex digests (no spaces) instead of beautified fingerprints svn:r2422	2004-10-06 13:31:48 +00:00
Nick Mathewson	b08ff7b1f7	Fix a couple of typos, one of which conceals a bug in parsing opt keywords with objects svn:r2421	2004-10-06 13:28:34 +00:00
Roger Dingledine	8b02610bd5	when an OR starts up, it loads its directory from cache. then it serves that directory to others who ask for a copy of the directory. it's better to serve no directory at all until you have a fresh copy. svn:r2418	2004-10-06 05:05:43 +00:00
Roger Dingledine	980b6169eb	use only 0.0.9pre1 and later servers for resolve cells svn:r2416	2004-10-03 19:39:29 +00:00
Nick Mathewson	9e8ae9766e	Only check versions against downloaded directories, not cached directories. svn:r2413	2004-10-03 02:37:52 +00:00
Roger Dingledine	5e74ce8d57	better warn message for failed hidserv desc fetch svn:r2412	2004-10-03 00:06:47 +00:00
Roger Dingledine	3f4b544b77	use size_t rather than int for directory lengths in memory this might fix a bug with amd64 svn:r2410	2004-10-01 21:02:12 +00:00
Nick Mathewson	91044765f2	Decode Content-Encoding header correctly. svn:r2403	2004-10-01 04:45:14 +00:00
Roger Dingledine	eff780c815	Fix a rare assert trigger, where routerinfos for entries in our cpath would expire while we're building the path. Thanks to Eugene Armstead for pointing it out. svn:r2402	2004-09-30 15:40:05 +00:00
Roger Dingledine	136d4e5739	prefer tor_free to free plus complain more loudly when we fail to parse a dir we just fetched svn:r2401	2004-09-29 06:52:36 +00:00
Roger Dingledine	6ed095b177	print the IP if a conn fails badly, to see if there are any trends svn:r2400	2004-09-29 05:59:55 +00:00
Roger Dingledine	1c47de319e	ha ha, thought the bugs were done don't stop writing the compressed directory just because you found a nul svn:r2399	2004-09-29 05:48:25 +00:00
Roger Dingledine	a31ba30ae6	if our local cached directory is new enough, go ahead and start building circuits while we're fetching a new one svn:r2394	2004-09-28 23:27:41 +00:00
Nick Mathewson	11384b6d92	Make sure that routerlists contain only routers; give a better error message if they start with a nonrouter. svn:r2393	2004-09-28 22:49:34 +00:00
Nick Mathewson	0c653e5cc7	cached-directory has a directory, not a router list svn:r2392	2004-09-28 22:43:11 +00:00
Roger Dingledine	4b3001a08c	fix some local buffer overflows fix a memory leak svn:r2391	2004-09-28 22:38:21 +00:00
Nick Mathewson	7eff786e4b	Fix messages for _UNRECOGNIZED tokens svn:r2390	2004-09-28 22:35:02 +00:00
Nick Mathewson	d20d10f360	If we are an authoritative dirserver, check out the fingerprint list when setting connection nicknames svn:r2389	2004-09-28 22:24:56 +00:00
Roger Dingledine	d381aa4696	Fix an evil bug: when we failed to write to our log, fputs() gave us a sigpipe, and we logged that we were ignoring it, causing us to fail to log that, and delete the log entry. Then when the signal handler exited, we proceeded to delete the log entry that had already been deleted. Now we make sure to only log inside our signal handler if we'll be exit()ing right after. svn:r2388	2004-09-28 21:14:40 +00:00
Roger Dingledine	0d2f9b9b4b	the tor clients in cvs can't speak to the current tor authdirservers for rendezvous publishes and fetches, since they're still running 0.0.8. so make them speak the old way until we've upgraded the authdirservers. svn:r2384	2004-09-28 03:30:28 +00:00
Roger Dingledine	9f9f0e5edd	fix another bug with cached compressed directories still not working svn:r2383	2004-09-27 07:28:48 +00:00
Roger Dingledine	d0edf8e8b5	fix two bugs with cached directories: - don't complain that you won't cache it, then cache it anyway. - change confusing terminology from 'deflate' to 'compress', so we'll stop getting our logic backwards. i assume the rfc author has shot himself by now. svn:r2382	2004-09-27 06:57:16 +00:00
Roger Dingledine	6e7e880438	put my fenceposts back in valid memory space svn:r2381	2004-09-27 06:45:32 +00:00
Roger Dingledine	a2517b4f07	checking only 0.0.7 and 0.0.8 didn't work, because some dirservers files have really old descriptors for the authdirservers, so we're asking them in the new format because they're too old. now we actually compare the version to a cutoff version, and act appropriately. also take this chance to use only >=0.0.8 servers for dns resolves, because of the recent bugs. we'll bump to >=0.0.9pre1 once there are some servers running that. svn:r2380	2004-09-27 06:00:43 +00:00
Roger Dingledine	a64d093339	post descriptors to 0.0.8 authdirservers the old way, to make the transition easier svn:r2379	2004-09-27 03:50:58 +00:00
Roger Dingledine	10df7d9afc	clients ask 0.0.9-and-later dirservers for a compressed dir dirservers rewrite url /foo/ to /tor/foo/, which will help us run things behind apache once 0.0.8 is obsolete svn:r2378	2004-09-27 03:39:30 +00:00
Roger Dingledine	57d7857def	don't mind empty exit policy entries svn:r2373	2004-09-23 22:57:32 +00:00
Roger Dingledine	fa0a1ec49f	cleanup: use strcmpstart() in more places svn:r2372	2004-09-23 22:18:50 +00:00
Roger Dingledine	185b9fddf2	protect dirservers from overzealous descriptor uploading wait 10 seconds after directory gets dirty, before regenerating svn:r2370	2004-09-23 19:58:44 +00:00
Roger Dingledine	02e3e3327c	discourage people from setting their dirfetchpostperiod more often than once per minute svn:r2369	2004-09-23 19:23:32 +00:00
Roger Dingledine	8727a28119	bugfix: we were starting to daemonize before we opened our logs, so if there were any problems opening logs, we would complain to stderr (which wouldn't work) and then mysteriously exit. svn:r2366	2004-09-23 04:32:43 +00:00
Roger Dingledine	c0db9fa803	fix confusing cut-n-paste mistake svn:r2364	2004-09-22 04:08:05 +00:00
Roger Dingledine	013104a1e2	people are starting to bump into the limit of 50 dns workers. raise it to 100 for now. we need a better solution long-term. but alas, there are no better solutions that are also portable. hm. svn:r2363	2004-09-22 03:56:41 +00:00
Nick Mathewson	9defe8a307	Attach dummy resolve connections to a circuit before calling dns_resolve(). This fixes a bug where cached answers would never be sent in RESOLVED cells. svn:r2360	2004-09-21 18:12:12 +00:00
Nick Mathewson	c20b24c952	clean up/bugfix deflate logic and log messages svn:r2359	2004-09-21 18:09:38 +00:00
Roger Dingledine	d977677aa8	bugfix: when a resolve fails for a begin request, actually send the end cell back. also, give a better reason for failure. svn:r2358	2004-09-21 17:33:05 +00:00
Roger Dingledine	ff622786f1	slightly better warn message svn:r2357	2004-09-21 17:14:47 +00:00
Nick Mathewson	431b33a2ca	Warn the user when we mark ourself as down. svn:r2356	2004-09-21 16:44:20 +00:00
Nick Mathewson	0dcc8c7048	Bugfix: When a dns request failed, we would detach any "resolving" streams from the circuit before we would send a the resolve_failed cells. svn:r2355	2004-09-21 16:42:07 +00:00
Roger Dingledine	802b203ff1	fix a rare seg fault for people running hidden services on intermittent connections svn:r2353	2004-09-20 03:07:11 +00:00
Roger Dingledine	959199340a	don't pick administrative-friends when picking your path (just a skeleton for now) svn:r2349	2004-09-10 21:40:29 +00:00
Roger Dingledine	a475ccf5b8	we should exit(1) if $HOME doesn't exist and we needed it svn:r2344	2004-09-10 19:16:01 +00:00
Nick Mathewson	0ef85f6dba	Some platforms have weird translations when you open files in "test" mode; make read/write_str_to_file aware. svn:r2336	2004-09-08 07:16:34 +00:00
Nick Mathewson	c66e4c4870	Flush more changes from sandbox - make clients cache directories and use them to seed their router lists at startup. This means clients have a datadir again. - Introduce a global_write_bucket. We need to respond better to exhausting it. - Remove the last vestiges of LinkPadding and TrafficShaping. - Configuration infrastructure support for warning on obsolete options. - Refactor directory header parsing to use smartlist_split_string. - Respond to content-encoding headers by trying to uncompress as appropriate. - Reply with a deflated directory when a client asks for "dir.z". (We could use allow-encodings instead, but allow-encodings isn't specified in HTTP 1.0.) svn:r2335	2004-09-08 06:52:33 +00:00
Nick Mathewson	9836ccda8c	Move a paren 4 characters to the left; fix a bug in OutboundBindAddress svn:r2330	2004-09-02 23:25:23 +00:00
Nick Mathewson	ecf414f05e	Stop using separate defaults for no-config-file and empty-config-file svn:r2329	2004-09-02 22:08:36 +00:00
Nick Mathewson	d6e47bec46	Keep a deflated version of each directory so we can deliver it when requested svn:r2328	2004-09-02 18:57:09 +00:00
Nick Mathewson	bda41ba3fd	Use new split function and strcmpstart correctly svn:r2327	2004-09-02 18:39:59 +00:00
Nick Mathewson	4c799ae731	Check for zlib; link with it. svn:r2326	2004-09-02 18:27:09 +00:00
Nick Mathewson	3590eb535a	Add basic wrappers for zlib/gzip svn:r2324	2004-09-02 18:22:51 +00:00
Roger Dingledine	444a01610c	make the compile work (and not complain) on sunos 5.9 svn:r2312	2004-08-25 17:31:47 +00:00
Roger Dingledine	be7909f670	Fix a symptom for a bug that straycat found. Apparently in rare cases poll() is returning POLLIN for an idle dns worker. It reads no bytes, presumably because the idle dns worker didn't write anything in the first place. Gosh, who knows. Now we only trigger the assert if the idle dns worker actually tries to send an answer to us. svn:r2311	2004-08-25 05:26:09 +00:00
Roger Dingledine	d91cacb839	agree with nick: this legal-chars-in-filename stuff gets us nothing svn:r2310	2004-08-24 21:57:12 +00:00
Nick Mathewson	015232bd39	As far as I can tell, CONFIG_LEGAL_FILENAME_CHARACTERS is both pointless and broken. #if it out, pending agreement from arma. This fixes a bug on win32 that rejected paths with a : in them. svn:r2309	2004-08-24 20:48:22 +00:00
Nick Mathewson	4b4bfd500a	Improve log message to make it obvious _why_ reading the configuration has failed. svn:r2308	2004-08-24 20:46:42 +00:00
Roger Dingledine	79df0aa18a	when picking unverified routers, skip those with bad uptime or bad bandwidth, depending on what properties you care about svn:r2302	2004-08-20 21:34:36 +00:00
Nick Mathewson	ae46b6b077	Fix some DOCDOCs svn:r2295	2004-08-18 21:56:45 +00:00
Roger Dingledine	cf6159abb9	fix a seg fault on hup when FascistFirewall is defined svn:r2294	2004-08-18 21:46:53 +00:00
Roger Dingledine	8ddc029d07	if options.FascistFirewall but none are running on port 80, try the others before giving up. svn:r2293	2004-08-18 21:13:58 +00:00
Roger Dingledine	2396c6bf71	remove last vestiges of this 'twin' concept svn:r2291	2004-08-18 20:35:11 +00:00
Roger Dingledine	9504db8ce8	be more aggressive about building circuits when we have no open circuits svn:r2290	2004-08-18 20:34:43 +00:00
Roger Dingledine	b500104cbe	tolerate old 0.0.7 clients that demand a certain ip:port for a router even though it's moved on to another one. also reduce some log verbosity. svn:r2288	2004-08-18 11:20:15 +00:00
Roger Dingledine	3937ecfaae	when we try to exclude our routerinfo from being picked in the path, it fails because we're using a pointer to the routerinfo we generate, not a pointer to the routerinfo in the routerlist. so look up the right one and use that. svn:r2286	2004-08-18 10:32:50 +00:00
Roger Dingledine	20b8819023	even better, only print extend attempts if there are any. svn:r2285	2004-08-18 09:57:50 +00:00
Roger Dingledine	a447570036	stop taking strlen of an uninitialized buffer we were (are?) printing garbage in the rephist stats svn:r2284	2004-08-18 09:49:17 +00:00
Roger Dingledine	b885db033e	remove crazy notion that clique_mode() means we are already connected to everybody we could be connected to. svn:r2283	2004-08-18 09:07:11 +00:00
Roger Dingledine	765530421e	be more aggressive about trying to make circuits: try once a second for 30 seconds, and only when the entire previous period has failed do we pause after MAX_CIRCUIT_FAILURES failures. svn:r2281	2004-08-18 08:51:04 +00:00
Roger Dingledine	6d661d1bc0	bugfix: make intro circuits work again svn:r2280	2004-08-18 07:53:43 +00:00
Nick Mathewson	555f8f30f4	Avoid segfault when freeing options_t without firewall_ports svn:r2279	2004-08-18 07:06:53 +00:00
Roger Dingledine	99e367f045	authdirservers don't need to be treated specially on hup for making intro points svn:r2277	2004-08-18 06:48:45 +00:00
Roger Dingledine	807a484b88	only establish intro points after we've gotten a directory svn:r2276	2004-08-18 06:47:01 +00:00
Roger Dingledine	6e9e467b1d	dirservers now don't build circuits until they have fetched a directory from somebody else. this means they have time to build their connections first. svn:r2275	2004-08-18 06:29:58 +00:00
Roger Dingledine	b294a037a4	choose exit nodes by bandwidth too svn:r2274	2004-08-18 06:10:12 +00:00
Nick Mathewson	6de61bd694	Revert dumb think-o. Just because _some_ INTRODUCE2 cells are now longer, doesn't mean we should raise the _minimum_ size. svn:r2273	2004-08-18 05:05:58 +00:00
Nick Mathewson	196e6c1cc2	Support new INTRODUCE2 cell format svn:r2270	2004-08-18 04:48:59 +00:00
Nick Mathewson	86980cf6e2	Functions to test nickname validity svn:r2269	2004-08-18 04:44:24 +00:00
Nick Mathewson	fffb4dbb8b	fix unix build: CONFDIR, not CONF_DIR svn:r2267	2004-08-18 04:04:08 +00:00
Nick Mathewson	8626c7724e	Clean windows whitespace svn:r2266	2004-08-18 03:47:55 +00:00
Nick Mathewson	17ce7d499f	On windows, default datadir is APPDATA/tor, and default config file is APPDATA/tor/torrc. (APPDATA is usually somedrive:/Documents and Settings/.../Application Data/) svn:r2265	2004-08-18 03:42:55 +00:00
Nick Mathewson	7cb93e5bb6	Move string-splitting into a separate function svn:r2263	2004-08-17 21:06:36 +00:00
Roger Dingledine	2c002b1533	deal better if we don't have enough available nodes to choose a path svn:r2262	2004-08-17 12:09:37 +00:00
Roger Dingledine	4c47e07a11	make csv parsing notice the last letter of each entry too svn:r2261	2004-08-17 11:55:47 +00:00
Roger Dingledine	0131d94a6c	bugfix: make receiving csv lines not seg fault svn:r2260	2004-08-17 11:52:20 +00:00
Roger Dingledine	6cf09a5dc0	people with no torrc allow unverified middle/rendezvous nodes by default svn:r2259	2004-08-17 11:42:22 +00:00
Roger Dingledine	aa1e518446	when a verified routerinfo arrives with a new key than the previous verified routerinfo with that name, close connections to the obsolete key to make way for connections to the new key. svn:r2257	2004-08-17 08:00:23 +00:00
Nick Mathewson	4e026f5b1d	Fix crash when looking for ~/.torrc with no $HOME set svn:r2256	2004-08-17 07:33:06 +00:00
Nick Mathewson	9bcd4a9c6a	make last patch compile svn:r2255	2004-08-17 07:14:45 +00:00
Nick Mathewson	525a4fc365	Stop logging events that happen to uninitialized digests svn:r2254	2004-08-17 07:12:05 +00:00
Roger Dingledine	2d8a1f208a	if they ask for exactly one entrynode, don't pick it as an exitnode. also, fix part of the zero-identity-router-in-stats bug svn:r2252	2004-08-17 07:09:02 +00:00
Roger Dingledine	9e5fc55564	now that we parse router->uptime, make use of it svn:r2251	2004-08-17 06:42:30 +00:00
Roger Dingledine	ee23b7a470	use unverified routers in the desired positions svn:r2249	2004-08-17 06:27:32 +00:00
Nick Mathewson	590cd621f8	Clean up last patch; implement (mostly) proper handling for verified/unverified name collisions. svn:r2248	2004-08-17 06:06:05 +00:00
Nick Mathewson	85a910e085	Parse uptime into routerinfo svn:r2247	2004-08-17 05:29:41 +00:00
Nick Mathewson	74621132a9	Implement AllowUnverifiedNodes svn:r2246	2004-08-17 05:13:58 +00:00
Roger Dingledine	76eadc6f0a	if a router claim huge bandwidth, don't believe it svn:r2245	2004-08-17 02:00:36 +00:00
Nick Mathewson	0b91fd1cbe	Add a generic Comma-separated-value config type, and a FirewallPorts option to tell FascistFirewall which ports are open. (Defaults to 80,443) svn:r2244	2004-08-16 20:47:00 +00:00
Roger Dingledine	0a6e27208b	o Handle servers with dynamic IP addresses: don't replace options->Address with the resolved one at startup. o detect our address right before we make a routerinfo each time. o external IP vs bind-IP. Already done, just use options->Address. o OutboundBindAddress config option, to bind to a specific IP address for outgoing connect()s. svn:r2241	2004-08-16 11:43:18 +00:00
Nick Mathewson	6514eb5d44	Update to new choose_random_node interface. svn:r2239	2004-08-15 20:31:11 +00:00
Nick Mathewson	bcf8ca5ba6	Check for time skew on http headers; report date in response to "GET /". svn:r2238	2004-08-15 20:30:15 +00:00
Nick Mathewson	e19af3fa0f	We are an OR if ORPort or ORBindAddress is set; similarly for being an OP svn:r2237	2004-08-15 20:16:26 +00:00
Nick Mathewson	416653271a	Implement strict{entry\|exit}nodes config options svn:r2236	2004-08-15 20:14:44 +00:00
Roger Dingledine	488aa52f25	fix assert triggers in 0.0.7.x: if the other side returns an address 0.0.0.0, don't put it into the client dns cache. svn:r2233	2004-08-15 20:05:35 +00:00
Roger Dingledine	cd3da3fc12	o clients choose nodes proportional to advertised bandwidth o and/or while avoiding unreliable nodes, depending on goals o 'fascistfirewall' option to pick dirservers on port 80 and ORs on port 443. o if a begin failed due to exit policy, but we believe the IP should have been allowed, switch that router to exitpolicy reject : until we get our next directory. svn:r2231	2004-08-15 08:15:12 +00:00
Roger Dingledine	699a9d8b46	commit some minor fixes from this sandbox so i can commit the next one svn:r2229	2004-08-15 05:28:09 +00:00
Nick Mathewson	ba7cc463d4	Clean up tempdir after finishing unittests; use tor_temp_$PID instead of tor_temp; quit if tor_temp_$PID exists. svn:r2226	2004-08-11 19:20:24 +00:00
Roger Dingledine	dda2e44222	compile again on win32 (i think) svn:r2222	2004-08-09 23:45:11 +00:00
Roger Dingledine	1e415817a3	minor fix svn:r2215	2004-08-09 07:41:32 +00:00
Roger Dingledine	7068dd8e87	make "%llu" less likely to warn on weird platforms svn:r2209	2004-08-09 05:25:19 +00:00
Nick Mathewson	98b8a89aa8	Fix comment svn:r2207	2004-08-09 04:27:42 +00:00
Nick Mathewson	6141097f6e	Fix bug in saving onion keys to disk when rotating; also survive short-term shutdowns better svn:r2206	2004-08-09 04:27:13 +00:00
Nick Mathewson	e6c34ad071	Make unittests pass svn:r2205	2004-08-09 04:26:25 +00:00
Nick Mathewson	0652a0e90a	Fix a fencepost error in the last bandwidth reporting fix svn:r2202	2004-08-08 19:14:44 +00:00
Roger Dingledine	7506cce649	stop wasting cpu time on authdirservers we were making a new directory only when the old one was dirty, but every time we made one, we'd dirty it by testing it right then. svn:r2199	2004-08-08 11:15:38 +00:00
Roger Dingledine	b2c7b5adfb	fix a race condition in 008pre2: don't try to extend onto a connection that's still handshaking. for servers in clique mode, require the conn to be open before you'll choose it for your path. svn:r2198	2004-08-08 10:32:36 +00:00
Roger Dingledine	05790d1722	let children survive sigint, sigterm, etc. this was biting us because ^c would get delivered to all of them, maybe because they were all still listening to stdin? svn:r2197	2004-08-08 07:25:45 +00:00
Roger Dingledine	292e9c5567	reject the default edonkey, kazaa, gnutella ports to slow the coming flood svn:r2195	2004-08-08 05:26:13 +00:00
Roger Dingledine	fb4b804c2c	Don't warn about being unverified if you're not in the running-routers list at all. svn:r2193	2004-08-07 09:01:56 +00:00
Roger Dingledine	44ff309c26	touch-ups svn:r2192	2004-08-07 09:01:04 +00:00
Nick Mathewson	28a6d0901f	Handle loop initialization for bandwidth tracking properly svn:r2190	2004-08-07 05:13:55 +00:00
Nick Mathewson	3de630ec67	Only warn about version newness once svn:r2189	2004-08-07 05:12:08 +00:00
Roger Dingledine	dbf150bd4e	list the port and socks version when complaining about unsafe socks svn:r2188	2004-08-07 04:03:01 +00:00
Nick Mathewson	bc24c3f47d	Allow multiple ORs with same nickname in routerlist svn:r2187	2004-08-07 03:38:07 +00:00
Nick Mathewson	05e9a2269c	Remove obsolete link-key keyword svn:r2186	2004-08-07 03:37:36 +00:00
Nick Mathewson	1ada52fe87	router_get_hash_impl would fail when end_str started with \n. Now it works. svn:r2185	2004-08-07 03:25:42 +00:00
Roger Dingledine	052537dad9	rotate onion keys every 12 hours, not every 2 hours svn:r2184	2004-08-07 03:03:23 +00:00
Nick Mathewson	b0c9ba99f8	Fix a leak svn:r2183	2004-08-07 02:59:46 +00:00
Nick Mathewson	f6cc218742	Refactor ISO-style (yyyy-mm-dd hh:mm:ss) time parsing into util.c; rename format/parse_rfc1123_time; make rephist remember used bandwidth; published used bandwidth in descriptors in 15-minute chunks. Breaks unittests. svn:r2182	2004-08-07 02:46:16 +00:00
Roger Dingledine	f47fe829dd	avoid racing the mark-for-close when the client hangs up on us at the same time we get an end relay cell. (thanks to wmf for reminding me) svn:r2181	2004-08-07 02:19:49 +00:00
Roger Dingledine	658e02a621	untwisting the logic, it would seem the pkey is always defined? svn:r2180	2004-08-07 01:48:50 +00:00
Nick Mathewson	6ceb351e31	Comment about n_args<1 is correct, since all directory servers are running post-007x versions svn:r2179	2004-08-07 01:30:23 +00:00
Roger Dingledine	8491d97b9c	print the name of the dirserver that told us we were unverified nick, please review this. svn:r2177	2004-08-07 01:17:38 +00:00
Nick Mathewson	f5f4314e2d	Always initialize hexid in rend_mid_rendezvous, no matter what svn:r2176	2004-08-07 01:12:04 +00:00
Nick Mathewson	380f32f07d	hex_encode is obsoleted by base16_encode, and never actually worked in the first place. (Thanks to Timo Lindfors for noticing the never-actually-worked part.) svn:r2175	2004-08-07 01:03:33 +00:00
Roger Dingledine	9952b37456	reject tor-resolve requests for .onion addresses early svn:r2174	2004-08-07 00:19:14 +00:00
Roger Dingledine	810ebc80d0	be willing to expire routers that have a dirport open it's just the authoritative dirservers we want to not forget svn:r2173	2004-08-06 22:47:41 +00:00
Roger Dingledine	e95ae1c9ad	let purging routerinfos and descriptors take an age argument svn:r2171	2004-08-06 22:15:25 +00:00
Nick Mathewson	bed5696185	Keep track of a whole day of bandwidth, not just 12 hrs svn:r2168	2004-08-06 20:46:50 +00:00
Nick Mathewson	3ca2728eb2	(size_t)-1 is never < 0; fix an XXXX008 by changing the interface for dirserv_get_runningrouters svn:r2165	2004-08-06 20:00:16 +00:00
Nick Mathewson	2ff6d6d8b9	There is no space after network-status; make router_get_hash_impl more bulletproof. svn:r2162	2004-08-06 19:54:20 +00:00
Roger Dingledine	6e9bdc862c	when they use tor as an http proxy, point them at a better url svn:r2161	2004-08-06 19:44:17 +00:00
Roger Dingledine	05e9fb5c44	and add a comment to that effect svn:r2159	2004-08-06 10:13:25 +00:00
Roger Dingledine	f8c14e5dce	make explicit that 'no socks policy' means 'accept' svn:r2158	2004-08-06 10:12:55 +00:00
Roger Dingledine	276d953b22	fix an assert: check the sockspolicy before we make/add the connection, else we close a connection without assigning it a state, which is bad because it fails assert_conn_ok() svn:r2156	2004-08-06 09:56:36 +00:00
Roger Dingledine	967a762fe1	they're uint64 and uint32, not int and int svn:r2152	2004-08-06 08:40:55 +00:00
Roger Dingledine	f32e34044f	list total traffic and total uptime in -usr1 stats svn:r2151	2004-08-06 08:37:13 +00:00
Roger Dingledine	1d41c0ee35	note a bug that adam found svn:r2150	2004-08-06 02:27:06 +00:00
Roger Dingledine	3b00c950c2	note a bug in our dns error handling. we should fix this sometime. svn:r2149	2004-08-05 19:33:54 +00:00
Roger Dingledine	de0f72ce2a	bugfix: when you finish answering a 'resolve' request, hold the connection open so you can flush the answer svn:r2148	2004-08-05 00:39:23 +00:00
Roger Dingledine	54dd90d391	bugfix: when tor-resolve asks to resolve an IP to an IP and we answer immediately, there's no need to send an 'end' relay cell when we close the conn. svn:r2147	2004-08-04 21:38:00 +00:00
Roger Dingledine	0c8542d889	fix rare race condition that causes infinite loop if we get a sigchld but all our children are gone by the time we get around to reaping them (i don't think this should ever happen, but it just did), then we'd loop forever trying to reap them. svn:r2141	2004-08-04 06:49:17 +00:00
Roger Dingledine	b51a444dd2	commit some odds and ends, so my tree is clean svn:r2137	2004-08-04 05:10:49 +00:00
Nick Mathewson	75684a48d5	<arma> did you get it working on win32? or just compiling svn:r2136	2004-08-04 04:58:30 +00:00
Nick Mathewson	78f12ffcca	Bugfix: "Okay, I just shut down like you told me. Now let me verify your signature." Also fix error message when running over-new version. svn:r2135	2004-08-04 02:35:06 +00:00
Roger Dingledine	d0cfbcf875	only pick a default nickname if you're a server svn:r2134	2004-08-04 02:15:22 +00:00
Roger Dingledine	a939796919	put a comment by routerlist_update_from_runningrouters() to remind me that it's not used yet svn:r2132	2004-08-04 01:25:21 +00:00
Roger Dingledine	da26a7a197	log a warning if you're running an unverified server, to let you know you might want to get it verified also, moved that whole block below the check-signature logic, so we don't execute it if the directory is a fake. (the recommended-versions logic is still executed before the signature is checked; we should fix that.) svn:r2131	2004-08-04 01:17:21 +00:00
Nick Mathewson	630e1e4b44	Hack: Include date with successful directory GETs. svn:r2130	2004-08-04 01:15:57 +00:00
Nick Mathewson	14d5478f29	Add functions to format and parse RFC1123-style times, for HTTP protocol. svn:r2129	2004-08-04 01:11:15 +00:00
Roger Dingledine	8b55f73bbe	put the have_warned_about_unsafe_socks static var inside the function svn:r2128	2004-08-04 01:08:10 +00:00
Nick Mathewson	5b61dd0457	Fix all warnings on win32 build svn:r2127	2004-08-03 23:57:05 +00:00
Roger Dingledine	8cb4124121	warn if we use an unsafe socks variant for now, warn every time. we should decide how often we want to warn; one problem here is that there are several scenarios where we use an unsafe socks variant safely, so the warning may be inaccurate. hm. svn:r2126	2004-08-03 23:42:33 +00:00
Roger Dingledine	5b54780df3	don't send an end back for a malformed resolved cell, since they don't establish streams svn:r2119	2004-07-23 06:28:12 +00:00
Roger Dingledine	cc54d9efe9	tor-resolve triggered a has_sent_end warning svn:r2116	2004-07-23 00:04:40 +00:00
Roger Dingledine	a328aab316	clean whitespace and tabs svn:r2115	2004-07-22 23:21:12 +00:00
Roger Dingledine	aebec8ab9e	stop using atexit() to remove our pid, since it's called immediately when we daemonize. also drop our retry period for hidserv desc uploads from 10m to 5m svn:r2111	2004-07-22 22:15:36 +00:00
Nick Mathewson	1391eafe67	Chek for overlong nicknames in add_nickname_list_to_smartlist svn:r2109	2004-07-22 21:36:03 +00:00
Nick Mathewson	7b4865ec33	Add notion of "longest nickname-or-hex-digest-with-$" svn:r2108	2004-07-22 21:31:04 +00:00
Nick Mathewson	0c990259de	Add noisy debug log to hunt for bug in router_update_status_from_smartlist svn:r2107	2004-07-22 21:20:23 +00:00
Nick Mathewson	d07d0a4e6b	Add fingerprint to router format in tests svn:r2106	2004-07-22 20:34:55 +00:00
Nick Mathewson	33fe5e362f	Never use time(NULL) as assumed publication time for a directory. svn:r2105	2004-07-22 20:30:02 +00:00
Roger Dingledine	7459d067a5	now base16_encode() and base32_encode() can't ever fail svn:r2103	2004-07-22 08:30:06 +00:00
Roger Dingledine	ea43172c11	make router_is_me() compare identity, not nickname svn:r2102	2004-07-22 08:08:25 +00:00
Roger Dingledine	f355a9c9f1	put our fingerprint into the descriptor, so we can match a desc to a running-routers entry svn:r2100	2004-07-22 06:22:04 +00:00
Roger Dingledine	c1450319f4	allow OPs to set a DirPort and cache/serve directories (hey, why not, it works) svn:r2099	2004-07-22 06:04:54 +00:00
Roger Dingledine	a403c1035e	getting an unknown descriptor is an info, not a warn, now svn:r2098	2004-07-22 06:04:13 +00:00
Roger Dingledine	b48cdc9d40	populate router_get_my_routerinfo()->is_verified svn:r2097	2004-07-22 06:03:53 +00:00
Roger Dingledine	06b72cc8f2	publish advertised_bandwidth in descriptor svn:r2095	2004-07-22 04:20:27 +00:00
Roger Dingledine	eb0a19c475	change 0.0.8 extend cell format so it's compatible with 0.0.7 svn:r2094	2004-07-22 03:47:20 +00:00
Roger Dingledine	6c56f34aaf	clients shouldn't create datadir until we have something to put there svn:r2092	2004-07-22 00:13:42 +00:00
Roger Dingledine	3c2c8ed42b	0.0.8 ORs should autoconnect to authdirservers and 0.0.7 servers svn:r2091	2004-07-21 23:43:47 +00:00
Roger Dingledine	f82a36508d	make router_nickname_is_approved() do the right thing svn:r2090	2004-07-21 22:54:27 +00:00
Roger Dingledine	3783d2e682	if johnny has three fenceposts, and jill takes four away... svn:r2089	2004-07-21 22:37:03 +00:00
Roger Dingledine	ce7fcd110c	solve the authdirserver initialization precedence problem svn:r2085	2004-07-21 18:53:56 +00:00
Roger Dingledine	1e62d24ddc	bugfix: only require the correct key if the nickname is for a verified router svn:r2084	2004-07-21 18:20:09 +00:00
Roger Dingledine	fd0fcc89e9	disallow picking unverified routers in circuits (for now) svn:r2082	2004-07-21 09:35:24 +00:00
Roger Dingledine	ecc9009256	authdirservers accept the uploading of unverified descriptors. fix a bunch of bugs in router_update_status_from_smartlist() (Nick, did I get them all, or was there a trickier one still hiding?) svn:r2081	2004-07-21 09:13:12 +00:00
Roger Dingledine	906d1aa99f	caching dirservers don't handle posts, running-routers, or rend descs svn:r2080	2004-07-21 08:40:57 +00:00
Roger Dingledine	3e97c12f24	rearrange to prepare to solve the authdirserver initialization precedence problem. doesn't actually solve it yet. svn:r2079	2004-07-21 07:50:06 +00:00
Roger Dingledine	ddb6eb35af	we were counting incorrectly when trying to figure out whether a given AP stream was being handled or not. (how did this work?) svn:r2077	2004-07-21 03:16:24 +00:00
Roger Dingledine	30d6b1479b	clients exit immediately on interrupt; they don't wait svn:r2076	2004-07-21 03:15:32 +00:00
Roger Dingledine	84b8f8e04a	fix some bool logic svn:r2075	2004-07-21 02:42:49 +00:00
Roger Dingledine	e547ab293b	make connection_tls_finish_handshake() more plausible. now we accept connections from unknown routers. svn:r2074	2004-07-21 02:25:14 +00:00
Nick Mathewson	334de84cbe	Misc small code cleanups; remove exit_server_mode(); change tor_tls_verify behavior svn:r2073	2004-07-21 00:44:04 +00:00
Roger Dingledine	99926813b1	get the function prototype right svn:r2072	2004-07-21 00:21:26 +00:00
Roger Dingledine	73ffcc5cef	add a new advertised_server_mode() to distinguish ORs that are willing to become servers from ones that really are servers. svn:r2071	2004-07-21 00:12:42 +00:00
Roger Dingledine	0da256ef97	when we get a sigint, don't accept new connections/circuits, but delay 30 seconds until exiting. if we get a second sigint, exit immediately. svn:r2070	2004-07-20 23:31:00 +00:00
Nick Mathewson	18d752e518	Correct "advance-time" logic svn:r2069	2004-07-20 23:25:00 +00:00
Nick Mathewson	2a339b7627	Split uptime into separate field svn:r2067	2004-07-20 21:13:11 +00:00
Nick Mathewson	e57698cc6e	Track bandwidth usage to estimate capacity svn:r2065	2004-07-20 20:57:46 +00:00
Nick Mathewson	d858a9e990	Remember list of digests for trusted dirservers; use this list to tell whether you are a trusted dirserver svn:r2064	2004-07-20 20:09:59 +00:00
Roger Dingledine	d5999a24af	also don't hang up on him if we're an OR and he's an authdirserver otherwise we keep getting taken out of the running-routers list svn:r2063	2004-07-20 19:45:29 +00:00
Roger Dingledine	66fc6cf04a	if you're an OR and he's an OR and he's running 0.0.7, don't expire your connections to him. svn:r2062	2004-07-20 19:28:02 +00:00
Roger Dingledine	dc7951a5a7	a whole swath of fixes introduce an authdir_mode() macro to match the others. don't initialize uptime to the number of seconds since 1970. non-authoritative dirservers don't cache their directory on disk. make only authdirservers use clique_mode. only read approved-routers file if you're an authdirserver. even authdirservers fetch a new directory in do_hup. retry_all_connections() is now called retry_all_listeners(). router_parse_list_from_string() correctly reports the router number it's working on. only call dirserv_add_own_fingerprint() and dirserv_add_descriptor() on startup if we're an authdirserver. if AuthDir and !ORPort then fail. if AuthDir and ClientOnly then fail. svn:r2061	2004-07-20 10:17:43 +00:00
Roger Dingledine	f54224ab35	clients can now pick non-authdirservers for fetching directories. servers still pick authdirservers, but they never pick themselves. but picking themselves for fetching rend descs is ok. svn:r2059	2004-07-20 06:44:16 +00:00
Roger Dingledine	b4d4a961b1	break connection_dir_client_finished_reading() into its own function svn:r2058	2004-07-20 02:44:26 +00:00
Roger Dingledine	a5ff0527e6	it turns out we weren't looking at the result from getsockopt(). now we do. but i'm not sure it matters, since we also poll for reads, and if there's an error with the connecting socket, poll is supposed to return readable, so we should notice it then. who knows. svn:r2057	2004-07-19 23:26:21 +00:00
Nick Mathewson	54c129d8dc	abstract ORPort/SocksPort checks into server_mode(), proxy_mode(), clique_mode(), etc. Dont change underlying comments. svn:r2054	2004-07-18 21:47:04 +00:00
Roger Dingledine	87d0948903	bugfix: hidden services were broken in cvs svn:r2053	2004-07-17 19:50:29 +00:00
Nick Mathewson	df3544422c	Change rule from "reject non-recommended versions" to "reject obsolete versions". A version is "obsolete" if it is non-recommended, and at least one recommended version is newer than it. svn:r2052	2004-07-16 23:33:42 +00:00
Nick Mathewson	1040762531	Remove 1024-router limit in routerparse.c; unify handling of running-routers lines in running-routers requests and in directories; set is_verified field of routerinfo_ts correctly; use most-recent-info rule to decide whether to change router-is-running status. svn:r2051	2004-07-16 23:05:40 +00:00
Nick Mathewson	bc36db351f	Resolve all DOCDOCs. svn:r2050	2004-07-16 22:23:18 +00:00
Nick Mathewson	656a664334	Revert cpuworker to use addr/port svn:r2049	2004-07-16 21:47:18 +00:00
Nick Mathewson	0b3357d573	Look in .torrc if no CONFDIR "torrc" is found. svn:r2048	2004-07-16 19:43:58 +00:00
Nick Mathewson	c458f33ef1	Fix warning svn:r2046	2004-07-15 01:59:18 +00:00
Nick Mathewson	5f7738d4cc	Code to parse tor version numbers so we can do an is-newer-than check. svn:r2044	2004-07-13 19:16:49 +00:00
Nick Mathewson	c2103eb63a	Finish most pre2 items: make running-routers list work right; rename secret key files; make even more lookup-by-nickname use lookup-by-id; default nicknames to hostname. svn:r2043	2004-07-13 18:23:40 +00:00
Nick Mathewson	e9365f9ed5	Bugfix: some things (like ctrl-z) can make a second take more than one second svn:r2042	2004-07-13 18:07:57 +00:00
Roger Dingledine	d37850bb98	only count bytes transmitted to/from non-local IPs svn:r2041	2004-07-13 16:58:01 +00:00
Roger Dingledine	86e0ede07e	checkpoint: start working on bandwidth tracking and letting clients evaluate whether they're suitable servers svn:r2037	2004-07-13 07:42:20 +00:00
Roger Dingledine	017d7d1fb3	refuse to build a circuit before the directory has arrived this will prevent a few of the 'couldn't decrypt onionskin' errors, maybe svn:r2036	2004-07-13 01:25:39 +00:00
Roger Dingledine	3294b514d3	when you expire a wedged dir conn, conn_close_if_marked will take care of trying to flush before it closes svn:r2035	2004-07-13 00:38:08 +00:00
Roger Dingledine	149115cc4e	bugfix: tell circuits what id_digest to look for, so n_conn_open() can find waiting circuits. svn:r2034	2004-07-12 23:53:16 +00:00
Roger Dingledine	a3aaff34b7	why does gcc not warn me about this at all? that's evil. svn:r2032	2004-07-12 20:41:20 +00:00
Roger Dingledine	2325050b1b	tor now tolerates down dirservers better svn:r2031	2004-07-12 20:39:40 +00:00
Roger Dingledine	63256c9e7a	make unit tests pass again but note a bug that i don't know how to address. nick? svn:r2030	2004-07-12 20:18:05 +00:00
Roger Dingledine	538655cd80	if connecting to an OR fails immediately, mark it as down svn:r2029	2004-07-12 18:19:55 +00:00
Roger Dingledine	e167eeb18e	add 'advertisedbandwidth' to router descriptor svn:r2028	2004-07-12 18:02:54 +00:00
Roger Dingledine	379768290e	fix a bug related to reading usernames for socks4 this hasn't bitten us yet, but hey. svn:r2026	2004-07-12 16:51:05 +00:00
Nick Mathewson	38c889c454	Remove spurious assert svn:r2018	2004-07-07 19:51:20 +00:00
Nick Mathewson	e9d81d873b	Fix the router_compare_to_my_exit_policy assertion failure once-and-for-all, by declaring 0.0.0.0 always denied. svn:r2017	2004-07-07 19:49:48 +00:00
Nick Mathewson	d5e275ddf4	Fix bug reported by peter palfrader: an empty address is unresolvable, but not an occasion for an assertion failure in a dnsworker. svn:r2015	2004-07-06 23:25:21 +00:00
Roger Dingledine	cbf73b2bc5	touchups all over put uptime in descriptor svn:r2011	2004-07-04 22:48:11 +00:00
Nick Mathewson	0f3fcfd1db	When tor_lookup_hostname says 0.0.0.0, treat it as an error. svn:r2003	2004-07-04 04:52:43 +00:00
Roger Dingledine	198e5f4c16	fix a seg fault when you try to launch a circ svn:r2002	2004-07-03 01:45:13 +00:00
Roger Dingledine	dc0a36d27b	populate circ->n_conn_id_digest when we set circ->n_conn svn:r2001	2004-07-03 01:37:59 +00:00
Nick Mathewson	7d8de8cd10	More digest/nickname fixes svn:r2000	2004-07-02 23:40:03 +00:00
Roger Dingledine	d58d4c0db6	another checkpoint toward letting ORs connect on demand svn:r1999	2004-07-02 23:08:59 +00:00
Roger Dingledine	62dcf9e20f	some of the infrastructure to let ORs connect on demand svn:r1998	2004-07-02 09:29:01 +00:00
Nick Mathewson	cbab134bd9	Switch most uses of _by_addr_port to _by_identity_digest svn:r1997	2004-07-01 23:13:04 +00:00
Roger Dingledine	e1ba0c4663	running-routers now lists down routers too (with a ! before their name) svn:r1996	2004-07-01 11:32:26 +00:00
Nick Mathewson	541add90a1	Track routers by hash of identity key; use hex hash of identity key in place of nickname; accept (and use) hash of identity key in EXTEND cells. svn:r1994	2004-07-01 01:16:59 +00:00
Roger Dingledine	f42f04c859	cleanups on 008pre1 items svn:r1993	2004-06-30 21:48:02 +00:00
Nick Mathewson	29818d5b6b	Use arguments to routerlist_update_from_runningrouters correctly svn:r1992	2004-06-30 16:48:36 +00:00
Nick Mathewson	b1e9adf056	Always use get_data_directory() instead of options.DataDirectory; fix a memory leak in router.c svn:r1991	2004-06-30 16:37:08 +00:00
Roger Dingledine	899bd4f471	stop leaking options->ContactInfo on hup svn:r1989	2004-06-29 19:46:06 +00:00
Nick Mathewson	76f769deb9	Remaining 008pre1 items done; deferred where more design is needed. More docs and (way more!) testing needed. Done: - Authdirservers down directories from others. - Generate and use running-routers lists - Cache directories; store across reboots. - Refactor directory parsing a bit; note potential trouble spots. svn:r1985	2004-06-25 00:29:31 +00:00
Nick Mathewson	f7976c1e9b	Terminate comment svn:r1982	2004-06-21 04:40:24 +00:00
Nick Mathewson	8aec3a7301	Implement several 008pre1 items: needs more testing svn:r1981	2004-06-21 04:37:27 +00:00
Roger Dingledine	207fcb35d1	tweaks and bugfix on resolve/resolved code svn:r1980	2004-06-17 21:11:09 +00:00
Nick Mathewson	3708886939	Implement RESOLVE/RESOLVED cells and socks resolve code svn:r1978	2004-06-17 18:13:09 +00:00
Roger Dingledine	ba5d48e852	router->is_trusted_dir implies router->dir_port>0 and add some infrastructure for fetching running-routers list svn:r1973	2004-06-16 21:08:29 +00:00
Roger Dingledine	80cee93f84	include <inttypes.h> if we have it openbsd on a sparc64 needs this (apparently) svn:r1971	2004-06-16 00:49:27 +00:00
Nick Mathewson	a788981399	Implement code to run tor as an NT service. More testing is needed, as is code to install the service. svn:r1966	2004-06-12 21:43:02 +00:00
Nick Mathewson	125b351970	Break tor_main into startup/loop/shutdown portions, to make NT service refactoring possible. svn:r1965	2004-06-12 19:45:46 +00:00
Nick Mathewson	dbf9fe57ea	Use intptr_t correctly in test.c; try to resolve ia64 warnings svn:r1963	2004-06-08 19:08:45 +00:00
Roger Dingledine	d90cb3504e	provide a prototype for dnsworkers_rotate svn:r1961	2004-06-07 20:00:30 +00:00
Nick Mathewson	184f4e6044	Rotate dnsworkers and cpuworkers on SIGHUP, so they get new config settings too svn:r1950	2004-06-06 03:38:31 +00:00
Nick Mathewson	0d1b4b5024	Unbork windows whitespace svn:r1949	2004-06-05 01:56:54 +00:00
Nick Mathewson	17b5b3685f	Make tor build on win32 again; handle locking for server svn:r1948	2004-06-05 01:50:35 +00:00
Roger Dingledine	42569ffd0f	bump an info message down to a debug svn:r1947	2004-06-03 05:57:27 +00:00
Nick Mathewson	66881d5709	If we are a directory, we should trust ourself. svn:r1943	2004-06-02 20:15:35 +00:00
Nick Mathewson	65e26bae3d	Check directory signatures based on name of signer, not on whom we got the directory from. svn:r1940	2004-06-02 20:00:57 +00:00
Roger Dingledine	011ccbbf8d	crank up some of our constants, for better scalability svn:r1938	2004-06-02 19:44:41 +00:00
Nick Mathewson	605e10a650	Stop multiplying logs on sighup. svn:r1936	2004-06-02 19:18:37 +00:00
Roger Dingledine	69931106f8	be sure to detach streams from the circuit linked list before freeing them also, don't bother marking a conn for close if you're about to free it svn:r1935	2004-06-02 18:32:24 +00:00
Nick Mathewson	0932505829	Only connection_dns_remove resolving exit connections svn:r1934	2004-06-02 18:12:49 +00:00
Roger Dingledine	fbbb4d01c3	bugfix: while closing a circuit, we were freeing the conns that were pending resolve, but not removing them from the pending resolve list svn:r1933	2004-06-02 18:11:28 +00:00
Nick Mathewson	0d20fee2fb	Add more asserts to dns-pending connections; fix a couple seeming bugs. svn:r1931	2004-06-01 22:09:58 +00:00
Nick Mathewson	94782444f8	Check recommended-software string early, before actually parsing the directory. svn:r1930	2004-06-01 18:19:01 +00:00
Roger Dingledine	4181d18b3d	declare the epipe bug a non-bug. now we catch and ignore epipe signals, and when write returns epipe, we simply return -1 and close the socket/connection. svn:r1928	2004-06-01 17:31:13 +00:00
Roger Dingledine	1ef411fefd	use sys/param.h if it's there svn:r1927	2004-06-01 17:03:01 +00:00
Roger Dingledine	834ffa358f	bugfix: if the wedged dir conn has no bytes to flush, then we never close it. svn:r1924	2004-05-28 17:56:17 +00:00
Roger Dingledine	8064807896	dirservers try to reconnect periodically too, in case connections have failed svn:r1922	2004-05-28 15:01:47 +00:00
Roger Dingledine	1841aa456b	rik's patch to not complain about freebsd's bug svn:r1921	2004-05-26 20:27:54 +00:00
Nick Mathewson	9b4e8486ce	Keep temporary log in place while configuring logs svn:r1919	2004-05-24 02:28:15 +00:00
Roger Dingledine	994c9cbd7e	commit two fixes from Thomas Themel svn:r1918	2004-05-22 18:05:20 +00:00
Roger Dingledine	f51061439b	when the dns resolve is cancelled, or fails, be sure to remove conn from circ->resolving_streams otherwise it gets freed and stays there, causing seg faults. svn:r1915	2004-05-21 12:25:15 +00:00
Roger Dingledine	a8417dfac8	fix a double mark-for-close svn:r1913	2004-05-20 22:39:01 +00:00
Nick Mathewson	ccb825128e	Tinker with log behavior: never send error messages about logs into the bitbucket svn:r1912	2004-05-20 19:47:28 +00:00
Roger Dingledine	1c21a02b90	router_choose_random_node() was ignoring its routerlist argument. so now we don't pass it one. svn:r1911	2004-05-20 19:12:28 +00:00
Roger Dingledine	66dd21b7a4	some more patching svn:r1910	2004-05-20 08:41:54 +00:00
Roger Dingledine	034110e761	bugfix: if no loglevel or logfile is specified, then we need to open a default log to stdout. svn:r1909	2004-05-20 08:15:28 +00:00
Roger Dingledine	faf2fdb1e0	don't ever expire dirserver routerinfos! svn:r1908	2004-05-20 06:42:38 +00:00
Roger Dingledine	30a07b2ecd	non-dirservers expire routerinfo's that are more than a day old svn:r1907	2004-05-20 05:10:30 +00:00
Roger Dingledine	b6faca2268	enable checking the socks policy svn:r1906	2004-05-20 04:16:43 +00:00
Nick Mathewson	80365b9897	Allow multiple exit policy lines; mostly add support for AP policies svn:r1905	2004-05-20 02:42:50 +00:00
Nick Mathewson	80be19d9da	Tighten assert_cpath_layer_ok assumptions svn:r1904	2004-05-19 23:51:39 +00:00
Roger Dingledine	b37450ce55	do all the heavy lifting in connection_about_to_close_connection, not in _connection_mark_for_close this will hopefully clean up the huge cyclical function mess svn:r1903	2004-05-19 23:32:20 +00:00
Nick Mathewson	b8f535a2d8	tor_assert, not assert. stdout, not stderr svn:r1902	2004-05-19 21:40:44 +00:00
Nick Mathewson	d95f347b14	Add Port to *bindAddress. svn:r1901	2004-05-19 20:25:44 +00:00
Nick Mathewson	9d2cd7fc6e	Allow multiple logfiles at different severity ranges svn:r1899	2004-05-19 20:07:08 +00:00
Roger Dingledine	41c9b8230d	fix compile error in dirserv (declare variables before the rest of the function) svn:r1896	2004-05-19 19:42:50 +00:00
Nick Mathewson	ba14428d66	Fix segfault svn:r1895	2004-05-19 19:28:24 +00:00
Nick Mathewson	1cfac90984	remove upper limit on number of descriptors/directories in dirserver; use smartlists instead of arrays svn:r1894	2004-05-18 17:41:40 +00:00
Roger Dingledine	d2de7120fa	fix a seg fault, add another XXX for nick ;) svn:r1892	2004-05-18 16:54:04 +00:00
Nick Mathewson	7511fbf993	Resolve some XXXs svn:r1889	2004-05-18 15:35:21 +00:00
Nick Mathewson	a782b83c28	Only try to launch a fixed number of intro circuits for a service per 15-minute period or before all of the intro circuits succeed, whichever comes first svn:r1883	2004-05-18 01:53:53 +00:00
Nick Mathewson	683d06bf44	Fix segfault and logic error in last patch. svn:r1881	2004-05-17 20:41:40 +00:00
Nick Mathewson	50b7ebcf9e	Make directory functions update routerlist, not replace it. Add notion of OR-is-trusted-to-be-a-dirserver. Arma, please review: does this handle being a dirserver right? svn:r1880	2004-05-17 20:31:01 +00:00
Roger Dingledine	04bb8c8046	bugfix: if a circuit if borderline too old, then count it as too old. bugfix: we were retrying the same circuit after getting a resolve failure. so of course the next two tries would fail too. now we try a new circuit each time (at most three times). svn:r1867	2004-05-15 07:21:25 +00:00
Roger Dingledine	d7815e85a7	assert_cpath_ok has always been broken re-disable it. svn:r1864	2004-05-13 07:44:21 +00:00
Roger Dingledine	ef561c0e42	Break files apart into more modules * \file circuitbuild.c * \brief The actual details of building circuits. * \file circuitlist.c * \brief Manage the global circuit list. * \file circuituse.c * \brief Launch the right sort of circuits, attach streams to them. * \file connection_edge.c * \brief Handle edge streams. * \file onion.c * \brief Functions to queue create cells, and handle onionskin * parsing and creation. * \file relay.c * \brief Handle relay cell encryption/decryption, plus packaging and * receiving from circuits. svn:r1863	2004-05-13 07:24:49 +00:00
Roger Dingledine	5ba9235873	clean up directory.c API svn:r1860	2004-05-12 23:48:57 +00:00
Roger Dingledine	630e930799	don't flush the buf from inside connection_write_to_buf svn:r1859	2004-05-12 22:56:26 +00:00
Roger Dingledine	1cf1836990	break connection_edge_end out of connection_mark_for_close svn:r1858	2004-05-12 21:12:33 +00:00
Nick Mathewson	537fb82cbb	Make some functions static svn:r1857	2004-05-12 20:58:27 +00:00
Roger Dingledine	32c42a0ee2	break rend_client_desc_fetched out of connection_mark_for_close svn:r1856	2004-05-12 20:36:44 +00:00
Roger Dingledine	7ee6194f3a	break part of circuit.c into relay.c svn:r1854	2004-05-12 19:49:48 +00:00
Nick Mathewson	9c3fba5c3b	Not every RSA decrypt should warn on failure. svn:r1853	2004-05-12 19:30:28 +00:00
Nick Mathewson	f1bc7af9f5	Make "connected" a different case from "finished_flushing"; always close_immediate whhen connect() fails. svn:r1852	2004-05-12 19:17:09 +00:00
Roger Dingledine	4c9138d640	calling flush_buf and not checking for return value is bad svn:r1851	2004-05-12 18:41:32 +00:00
Roger Dingledine	df4be6a1f7	list in-points to command.c svn:r1849	2004-05-11 03:21:18 +00:00
Nick Mathewson	3e2f889a29	Add an extra flush attempt when closing wedged dir conns, in an attempt to isolate the EPIPE bug svn:r1848	2004-05-11 01:55:32 +00:00
Nick Mathewson	b45fafa3d0	Split directory/router parsing functionality into separate file from routerlist.c svn:r1846	2004-05-10 17:30:51 +00:00
Roger Dingledine	83f06dcc97	always a bit more svn:r1844	2004-05-10 10:31:48 +00:00
Roger Dingledine	3cdf2d67da	it's amazing what a bit of punctuation can do for appearances svn:r1843	2004-05-10 10:27:54 +00:00
Roger Dingledine	6168b3222e	a few more pieces of markup svn:r1841	2004-05-10 08:56:42 +00:00
Roger Dingledine	341d6f2cab	more cleanup, including fleshing out or.h more svn:r1839	2004-05-10 07:37:10 +00:00
Nick Mathewson	720281b32e	Close rogue <b>s svn:r1838	2004-05-10 07:27:29 +00:00
Roger Dingledine	d9fa234fd9	comments and doxygen markup on circuit.c svn:r1837	2004-05-10 07:02:58 +00:00
Nick Mathewson	3bf2c572ad	Doxygen most of or.h svn:r1836	2004-05-10 06:52:01 +00:00
Nick Mathewson	ae2a2072b9	Doxygenate config.c svn:r1834	2004-05-10 04:48:13 +00:00
Roger Dingledine	4845fe7197	comment and doxygenate connection_edge.c svn:r1833	2004-05-10 04:42:22 +00:00
Nick Mathewson	81922a125c	More doxygenation. svn:r1832	2004-05-10 04:34:48 +00:00
Roger Dingledine	397466a23d	give connection.c a skeletal file/brief header svn:r1831	2004-05-10 03:56:58 +00:00
Roger Dingledine	658873eb01	tweak comment in connection_or svn:r1830	2004-05-10 03:54:33 +00:00
Roger Dingledine	9968f1da98	doxygen for tor_main.c svn:r1828	2004-05-10 02:43:41 +00:00
Roger Dingledine	a26265c3cc	remove an orphan function declaration svn:r1827	2004-05-10 02:39:48 +00:00
Roger Dingledine	21e094a5d3	function header comments for onion.c, including doxygen markup svn:r1826	2004-05-10 02:36:04 +00:00
Roger Dingledine	8f6aa6688f	function header comments for connection.c, including doxygen markup svn:r1825	2004-05-10 01:32:57 +00:00
Roger Dingledine	c6d4a00c5f	more doxygen markup plenty more remains svn:r1824	2004-05-09 16:47:25 +00:00
Roger Dingledine	b384c5a18d	bugfix: do directory_send_command only after we've established a socket also many comments, cleaning, etc svn:r1823	2004-05-09 16:33:04 +00:00
Nick Mathewson	93576d5289	Add doxygen markup for util and buffers svn:r1820	2004-05-07 17:04:12 +00:00
Roger Dingledine	fa3db976df	comment the functions in connection_or.c svn:r1818	2004-05-07 08:53:40 +00:00
Roger Dingledine	f1fc4ce22b	comment the functions in command.c this is one of the files nick regarded as scary, so hopefully these will help. svn:r1817	2004-05-07 08:07:41 +00:00
Roger Dingledine	d4efa475a1	forward-port header-length-increase patch svn:r1814	2004-05-06 22:47:48 +00:00
Roger Dingledine	e45fd6cec1	forward-port built-in dirservers string svn:r1813	2004-05-06 22:47:15 +00:00
Roger Dingledine	9bf9ca4d09	bugfix: add a circ->resolving_streams field, and make dns resolving streams not actually in the connection_array until they're done resolving. bugfix: actually complain if we duplicate mark-for-close a circuit add more logging for relay ends that claim dns resolve failed, so we can find out why they're not being retried. svn:r1798	2004-05-06 11:08:04 +00:00
Nick Mathewson	e6477a8e16	Document the rest of main.c svn:r1797	2004-05-05 21:35:12 +00:00
Nick Mathewson	682a805092	Comments for nearly all non-tricky files svn:r1796	2004-05-05 21:32:43 +00:00
Nick Mathewson	6cfdc90d92	Use intptr_t when playing with void*s svn:r1795	2004-05-05 20:27:20 +00:00
Nick Mathewson	e6ac85a8cc	Fix compilation warnings on 64-bit platforms svn:r1793	2004-05-05 20:09:06 +00:00
Nick Mathewson	44defa4b1a	Never list unapproved servers as recommended svn:r1790	2004-05-05 04:55:00 +00:00
Nick Mathewson	924f60288a	More documentation; fix for compilation warning svn:r1789	2004-05-05 02:50:38 +00:00
Nick Mathewson	2ba0776b02	Only connection_add connections once they have conn->s sett; refactor code around this. Should make stuff more bulletproof. svn:r1788	2004-05-05 01:26:57 +00:00
Roger Dingledine	608c156820	must close marked connections at the end of run_scheduled_events. otherwise they might have a socket -1, and if we leave them around they'll muck up poll/select. i think this was the cause of our win32 and os x fakepoll crashes, and probably would cause other errors down the road. svn:r1786	2004-05-05 00:59:42 +00:00
Nick Mathewson	efdb356a81	More documentation svn:r1785	2004-05-05 00:30:43 +00:00
Roger Dingledine	fa6e9efcd0	accept port 81 by default also, since people have been asking for it svn:r1784	2004-05-04 22:46:19 +00:00
Nick Mathewson	89275e7806	Comment router*.c svn:r1783	2004-05-04 18:17:45 +00:00
Nick Mathewson	af08c4f878	Working strerror for windows socket errors, plus some snide comments. svn:r1775	2004-05-02 20:18:21 +00:00
Roger Dingledine	bbbc063ed9	stop the circuit_receive_relay_cell warning mark the circ for close if circuit_extend fails because the next hop is not up yet; don't just return -1 svn:r1765	2004-05-02 03:32:00 +00:00
Roger Dingledine	25909c2c29	patches on patches svn:r1763	2004-05-02 03:15:55 +00:00
Nick Mathewson	f6fe336ad4	Documenmt buffers.c; remove function that nobody ever calls. svn:r1760	2004-05-01 22:08:43 +00:00
Nick Mathewson	6fa2ded74c	Fix windows compile svn:r1757	2004-05-01 20:55:31 +00:00
Nick Mathewson	908ccb9dcd	Handle windows socket errors correctly; comment most of common. svn:r1756	2004-05-01 20:46:28 +00:00
Roger Dingledine	ac4cb9bdd1	fix a seg fault (whoops) svn:r1755	2004-04-30 16:35:48 +00:00
Roger Dingledine	2b5e6aef15	note another bug to be fixed sometime svn:r1754	2004-04-30 05:42:52 +00:00
Roger Dingledine	18f250c364	update the built-in dirservers default svn:r1750	2004-04-29 08:10:13 +00:00
Nick Mathewson	9322641710	Use socketclose on windows as appropriate; end pid files with newline svn:r1745	2004-04-28 21:14:56 +00:00
Roger Dingledine	dd335d9bb2	use tor_lookup_hostname for binding local addresses too svn:r1744	2004-04-28 20:57:03 +00:00
Nick Mathewson	ddb15b8f67	Remove IVs from cipher code, since AES-ctr has none. svn:r1742	2004-04-28 20:31:32 +00:00
Nick Mathewson	7055f837ab	Make Tor build on win32 with VC6 without warnings. svn:r1739	2004-04-28 20:13:21 +00:00
Roger Dingledine	ca8d50abeb	bug resolved (hopefully), so remove comment svn:r1738	2004-04-28 20:12:44 +00:00
Roger Dingledine	22c0cd8a14	clean dns.c better svn:r1737	2004-04-28 20:11:37 +00:00
Roger Dingledine	25d5425fdb	fix a bug in dns.c, note but don't fix another one svn:r1735	2004-04-28 19:55:20 +00:00
Nick Mathewson	ac622d94dc	Workarounds for a couple of pieces of windows strangeness. svn:r1734	2004-04-28 19:35:12 +00:00
Roger Dingledine	8cc9001391	clean some dead code (right?) svn:r1733	2004-04-28 00:05:56 +00:00
Roger Dingledine	158e2cf536	set Content-Type on the directory and hidserv descriptor svn:r1731	2004-04-27 21:48:37 +00:00
Roger Dingledine	9965bd8387	make my assumption explicit svn:r1730	2004-04-27 11:28:45 +00:00
Roger Dingledine	505bb2f4a0	it was the second bug that was nailing us. periodically we expire some circuits if we already have enough, and we were counting rend circs in that number. (the first one wasn't a bug after all) svn:r1729	2004-04-27 11:23:56 +00:00
Roger Dingledine	8e8af6aaee	don't expire joined-rend circs that have an exit connection attached and don't expire non-general excess circuits svn:r1728	2004-04-27 10:16:31 +00:00
Nick Mathewson	06624df622	Log number of bytes pending after read. svn:r1726	2004-04-26 23:05:58 +00:00
Roger Dingledine	d7f4b82373	rendmid says it drops but actually sends nack fix log messages svn:r1725	2004-04-26 23:02:20 +00:00
Nick Mathewson	ad07c62938	Add a macro to catch unhandled openssl errors. svn:r1723	2004-04-26 23:00:07 +00:00
Roger Dingledine	e34c201bb3	and other debugs svn:r1722	2004-04-26 22:22:18 +00:00
Roger Dingledine	80d0b634a4	add a debugging entry, to find the wants-to-read-but-can't bug svn:r1719	2004-04-26 21:15:06 +00:00
Nick Mathewson	f6dbe5a0d4	Refactor crypto error handling to be more like TLS error handling: crypto_perror is a no-no, since an operation can set more than one error. Also, fix a bug in the unix crypto_seed_rng: mixing stdio with /dev/urandom is a bad idea, since fopen can make all kinds of weird extraneous syscalls (mmap, fcntl, stat64, etc.) and since fread tends to buffer data in big chunks, thus depleting the entropy pool. svn:r1717	2004-04-26 18:09:50 +00:00
Roger Dingledine	fff89216a9	tell us when we're rotating things svn:r1712	2004-04-26 09:32:51 +00:00
Roger Dingledine	fb2279b90b	since we don't support truncateds much, don't bother sending them; just close the circ. (this wasn't relevant before, because we were mis-handling destroys.) svn:r1711	2004-04-26 04:32:01 +00:00
Roger Dingledine	bd38df8472	fix a bug that's been lurking since 27 may 03 (!) when passing back a destroy cell, we would use the wrong circ id. how the heck did this work? svn:r1710	2004-04-26 03:42:41 +00:00
Nick Mathewson	75dc76eb3e	Better error msg on unknown circuit id. svn:r1708	2004-04-26 03:00:33 +00:00
Roger Dingledine	10f3b74cb9	tell us the nickname of the OR that hung up on us svn:r1706	2004-04-26 01:50:08 +00:00
Nick Mathewson	568a4d187a	Check for machine/limits.h in addition to sys/limits.h svn:r1705	2004-04-25 23:47:26 +00:00
Roger Dingledine	9e5d2ad91c	don't crash, if a conn that sent a begin has suddenly lost its circuit svn:r1704	2004-04-25 22:48:47 +00:00
Roger Dingledine	482d7e7cd3	resolve a double-mark-for-close when things die inside connection_handle_write svn:r1702	2004-04-25 22:23:54 +00:00
Roger Dingledine	28f034e10a	now assume all routers support rendezvous cells svn:r1699	2004-04-25 21:32:04 +00:00
Roger Dingledine	25d54257fb	use tor_assert remove obsolete BUF_OK macro svn:r1697	2004-04-25 20:37:37 +00:00
Nick Mathewson	0fca143ea1	Remove onion_pkey from connection, since onion keys can change more often than connections. Also add more log messages svn:r1693	2004-04-25 19:04:11 +00:00
Nick Mathewson	cb3897e5ab	remove spurious router_rebuild_descriptor svn:r1692	2004-04-25 19:01:49 +00:00
Roger Dingledine	7fbc35c136	don't build and upload a new desc twice in a row svn:r1691	2004-04-25 05:19:03 +00:00
Roger Dingledine	e355ed0e15	log correctly if decoding onion failed svn:r1690	2004-04-25 04:49:11 +00:00
Roger Dingledine	7e2a2a7f81	bugfix: when rotating onion key, do it (more) correctly svn:r1688	2004-04-25 03:38:19 +00:00
Roger Dingledine	0b31d0d4e8	more touch-ups svn:r1687	2004-04-24 23:32:24 +00:00
Nick Mathewson	3ace033c0c	Spurious link-key should not be an error svn:r1686	2004-04-24 22:50:09 +00:00
Nick Mathewson	220e859912	Note router addr:port in log messages svn:r1685	2004-04-24 22:40:32 +00:00
Nick Mathewson	2e47a0f009	Compare nicknames casei. svn:r1684	2004-04-24 22:34:31 +00:00
Nick Mathewson	c44016e86e	Merge flagday into main branch. svn:r1683	2004-04-24 22:17:50 +00:00
Roger Dingledine	3c250a2fed	only expire wedged dir conns that haven't already been expired svn:r1676	2004-04-20 17:27:54 +00:00
Roger Dingledine	a3200f79cd	the socketpair bug is no longer a bug now it is a documented behavior svn:r1674	2004-04-19 21:25:48 +00:00
Roger Dingledine	5cfec379ae	expire wedged dir conns after 5min without write, not simply after 5min svn:r1673	2004-04-19 20:08:42 +00:00
Roger Dingledine	d40e9f453f	give wedged dir conns a last chance to flush svn:r1671	2004-04-19 01:59:20 +00:00
Roger Dingledine	c4b72a254f	tmp patch to also expire old clean rend_ready circs for now will have to be fixed once we build-and-open rend circs preemptively svn:r1668	2004-04-18 09:27:05 +00:00
Roger Dingledine	e9ebefc8bf	bugfix: you mean we're supposed to reuse fresh descriptors and refetch stale ones, not reuse stale ones and refetch fresh ones? svn:r1667	2004-04-18 09:04:37 +00:00
Roger Dingledine	bce1fc43a2	when you get an intro ack, don't also count it as an intro nack svn:r1666	2004-04-18 08:38:40 +00:00
Roger Dingledine	3fa2925a6a	if an intro circ waiting for an ack dies before getting one, then count it as a nack svn:r1665	2004-04-18 07:37:16 +00:00
Roger Dingledine	8d86f8abf5	reverse the logic, captain svn:r1664	2004-04-18 06:42:13 +00:00
Roger Dingledine	7a7baf0552	expire dir connections that live for more than 5 minutes svn:r1663	2004-04-18 06:35:31 +00:00
Roger Dingledine	14c30fe9fa	bugfix: give dir_conn a state before building the bridge, so it has a state if things fail svn:r1660	2004-04-17 20:19:43 +00:00
Roger Dingledine	65d507b980	log n_circ_ids when attaching rend streams svn:r1657	2004-04-17 10:25:38 +00:00
Roger Dingledine	26dd5c68b0	a ! goes a long way toward more helpful debug messages svn:r1656	2004-04-17 10:04:00 +00:00
Roger Dingledine	bd4a776576	include sys/limits.h if it's found svn:r1654	2004-04-17 06:35:18 +00:00
Roger Dingledine	01e594e512	clean up some warnings svn:r1651	2004-04-17 06:34:20 +00:00
Roger Dingledine	0e94b9ff77	more useful logs to track weasel's bug svn:r1649	2004-04-17 05:17:40 +00:00
Roger Dingledine	f5427463f5	more debugging to hunt for a bug svn:r1647	2004-04-17 01:33:04 +00:00
Roger Dingledine	8d62a36256	bugfix: when you sleep your hidden-service laptop, as soon as it wakes up it tries to upload a service descriptor, but socketpair fails for some reason (localhost not up yet?) now we simply give up on that upload, and we'll try again later. svn:r1646	2004-04-17 00:46:05 +00:00
Roger Dingledine	f36d7b8fea	fix another rare bug: when we had tried all the intro points for a hidden service, we fetched the descriptor again, but we left our introcirc thinking it had already sent an intro, so it kept waiting for a response... svn:r1644	2004-04-16 14:35:28 +00:00
Roger Dingledine	ed24a4f807	fix a pair of duplicate mark-for-closes svn:r1643	2004-04-16 14:26:23 +00:00
Roger Dingledine	f84fa39d87	when alice uses a port that the hidden service doesn't accept, it now sends back an end cell (denied by exit policy). otherwise alice would just have to wait to time out. svn:r1642	2004-04-16 13:49:14 +00:00
Roger Dingledine	a0a6ed85d1	more useful logging for rend services and clients svn:r1641	2004-04-16 11:48:03 +00:00
Roger Dingledine	359c1fb9aa	wait a minute, weasel said there was a memory-stomping bug here let's see if we find it svn:r1639	2004-04-16 08:49:14 +00:00
Roger Dingledine	9c1470840f	i was wrong about one of my invariants now it's commented this should fix asserts when you try an intro point, get a nack, and try a second one and it works. svn:r1637	2004-04-16 08:21:35 +00:00
Roger Dingledine	598d8b8f79	put in an extra assert, might find a bug these way svn:r1636	2004-04-16 04:41:07 +00:00
Roger Dingledine	4c2de3a2b6	compress end-of-second summary into one line svn:r1635	2004-04-15 22:09:14 +00:00
Nick Mathewson	880ffd8f64	Must detach before attaching, or else we infinite-loop svn:r1632	2004-04-15 03:48:26 +00:00
Nick Mathewson	f6dd710aff	Strings need room for a NUL. svn:r1630	2004-04-15 02:02:46 +00:00
Nick Mathewson	3f352719f3	Add a missing return -1 svn:r1629	2004-04-15 01:23:43 +00:00
Roger Dingledine	26c1c8f173	make unattached rend streams expire after a while (60s) (they were darned persistent) also make intro circs that are waiting for acks expire after a while (20s) svn:r1628	2004-04-15 01:08:59 +00:00
Roger Dingledine	ac38746b3b	narrow in closer svn:r1627	2004-04-15 00:03:48 +00:00
Roger Dingledine	b51561f7fb	prune abandoned circs better add debugging info for the bug weasel found svn:r1626	2004-04-14 23:52:29 +00:00
Nick Mathewson	37255d24bc	Retry non-final-hop rendezvous failures svn:r1625	2004-04-14 21:40:50 +00:00
Nick Mathewson	94f126bca3	Never ever leave ri.platform unset. svn:r1624	2004-04-14 19:51:57 +00:00
Roger Dingledine	cda782bac0	make rendezvous points work again (yay. now time to mess them up again.) svn:r1619	2004-04-14 05:18:21 +00:00
Roger Dingledine	49f5e5b4ae	handle more purposes in new_route_len svn:r1618	2004-04-14 05:06:08 +00:00
Roger Dingledine	465f0e528a	call circuit_build_failed() even when the failure is immediate svn:r1617	2004-04-14 04:32:49 +00:00
Nick Mathewson	ddd45a7c0a	Do not segfault on missing intro points. svn:r1616	2004-04-14 04:19:12 +00:00
Roger Dingledine	f07d880f38	remove unused variable svn:r1615	2004-04-13 23:01:10 +00:00
Roger Dingledine	1d7979b460	let introcircs receive acks. rend streams now deal correctly again. (i think) svn:r1614	2004-04-13 22:56:24 +00:00
Nick Mathewson	5514ad715b	Scan list of servers in directory after reloading fingerprint list; remove any servers that are no longer recognized. svn:r1613	2004-04-13 20:06:08 +00:00
Nick Mathewson	baaf58fe1d	only consider uploading descriptors every 5 sec svn:r1612	2004-04-13 19:53:25 +00:00
Nick Mathewson	867832cd07	or, not and svn:r1610	2004-04-13 18:44:42 +00:00
Nick Mathewson	d19abb2402	Handle END_STREAM_REASON_{EXITPOLICY\|RESOLVEFAILED} svn:r1609	2004-04-13 17:49:41 +00:00
Nick Mathewson	11ca973d26	Mark service descriptors as dirty when we have lost an intro point svn:r1608	2004-04-13 17:20:41 +00:00
Nick Mathewson	a2ece0fc08	Separate "start-establishing-introduction" from "upload descriptors"; only upload descriptors containing fully established intro points. svn:r1607	2004-04-13 17:16:47 +00:00
Roger Dingledine	e0ce205a76	clean up circuit rebuilding some; fix some bugs we hadn't hit yet svn:r1606	2004-04-13 05:20:52 +00:00
Nick Mathewson	c9b5ca39de	Handle the rendezvous-circ elements of retrying introductions. svn:r1604	2004-04-13 03:19:58 +00:00
Nick Mathewson	a4d25bdbd9	<arma> you should make r and i and use r for r and i for i svn:r1603	2004-04-13 02:36:37 +00:00
Nick Mathewson	e53ba59250	Handle introduce naks. Arma: Is this right? svn:r1602	2004-04-13 02:31:52 +00:00
Nick Mathewson	8483bace65	Get the rest of intro-ack/nak handling in ... except for the tricky "pick a new intro and re-extend and re-try" part. svn:r1601	2004-04-13 01:41:39 +00:00
Nick Mathewson	9cd163f6ff	Have find_intro_circuit return non-open circs svn:r1600	2004-04-13 01:15:06 +00:00
Nick Mathewson	5af7e27c62	Re-number the new relay command so as to maintain backward compatibility. Doh! svn:r1598	2004-04-13 00:38:16 +00:00
Nick Mathewson	a5bfe84509	ACK/NAK INTRODUCE1 requests. (We do no useful processing on them yet) svn:r1597	2004-04-12 23:33:47 +00:00
Roger Dingledine	f4ff5a75c1	break circuit_build_needed_circs into its own func svn:r1596	2004-04-12 22:47:12 +00:00
Roger Dingledine	c5052bec95	normal circs are 3 hops, but rend/intro circs are 4, because the initiator doesn't get to choose the last hop svn:r1595	2004-04-12 18:40:14 +00:00
Nick Mathewson	fc5a766298	Use service IDs in rendmid. (rendclient and common require no changes, it seems) svn:r1594	2004-04-12 18:10:28 +00:00
Roger Dingledine	2321d21b3b	bump allowed rend desc skew from 60 mins to 90 mins svn:r1593	2004-04-12 09:44:38 +00:00
Nick Mathewson	1dbf61e7e6	Use service id instead of hex id in rendservice.c log messages. Rendcommon and rendclient will follow tomorrow. svn:r1591	2004-04-12 05:12:50 +00:00
Nick Mathewson	c024745bd4	Cosmetic patch for arma's fix for The Bug: Don't set the state to RESOLVEFAILED if the resolve didn't fail; set it to CONNECTING instead. svn:r1590	2004-04-11 17:07:45 +00:00
Roger Dingledine	d8c954e156	continue beating at pieces of The Bug svn:r1588	2004-04-09 21:31:09 +00:00
Roger Dingledine	23c193c065	if dns resolve is valid, but our exit policy rejects it or the connect attempt fails immediately, we were trying to double-remove it from the dns pending list. i think this might have been The Bug. (thanks weasel!) svn:r1587	2004-04-09 21:06:14 +00:00
Roger Dingledine	8f8d185f4b	give better instructions than just 'mail arma' svn:r1586	2004-04-09 20:23:25 +00:00
Roger Dingledine	48e0228f1e	expire old CIRCUIT_PURPOSE_C_REND_READY circs too svn:r1585	2004-04-09 20:08:13 +00:00
Nick Mathewson	4e1b65f53d	Dump introduction point status on kill -USR1 svn:r1584	2004-04-09 20:02:16 +00:00
Nick Mathewson	f9ade70cf9	Resolve init-services-in-do-hup issue svn:r1583	2004-04-09 19:37:50 +00:00
Roger Dingledine	c80b42e17c	don't call rend_services_init right before we fetch the dir, because we call it right after now. svn:r1582	2004-04-09 19:34:55 +00:00
Roger Dingledine	c5bef32d95	call directory_has_arrived has arrived every time we get a new directory, not just the first time svn:r1581	2004-04-09 19:30:38 +00:00
Nick Mathewson	c256f2c3a1	Make comment more sensible. Still uncertain about when to call rend_services_init, though. svn:r1580	2004-04-09 17:54:20 +00:00
Nick Mathewson	e6964ed7e6	set rend exit connection state _before_ calling rend_service_set_connection_addr_port and maybe eventually assert_connection_ok. This solves the other half of the bug weasel found. svn:r1579	2004-04-09 17:51:57 +00:00
Nick Mathewson	facb5d4221	Reload rendezvous service keys on sighup; otherwise, we wind up with a bunch of half-initialized services. This should solve half of weasel's current bug. The crash is the other half. (arma: should we also call rend_services_init on hup?) svn:r1578	2004-04-09 17:48:09 +00:00
Roger Dingledine	4011906b6b	get more serious about hunting The Bug (it has been haunting us since the days of 0.0.2preX) svn:r1576	2004-04-09 09:39:42 +00:00
Nick Mathewson	9b436c7f7a	remove a stray printf svn:r1575	2004-04-08 20:59:48 +00:00
Nick Mathewson	aa7cfd93e5	Fix base32 implementation; make base32 implementation follow standard; add more tests for base32 svn:r1574	2004-04-08 20:56:33 +00:00
Nick Mathewson	d237692396	Fix unit tests (now that platform code works differently) svn:r1573	2004-04-08 20:22:01 +00:00
Roger Dingledine	3b97a54226	when rend_cache_store warns, give more detail svn:r1572	2004-04-08 20:13:28 +00:00
Nick Mathewson	aa2189b406	note which preexisting or connection we found. svn:r1571	2004-04-08 19:49:55 +00:00
Roger Dingledine	eb9f5a561e	circuit-level sendmes weren't working, because the exit thought it was an exit. i overhauled the edge_type mechanism. hopefully this will help. svn:r1570	2004-04-08 09:41:28 +00:00
Roger Dingledine	8e686d0c72	we added more AP conns, oops svn:r1569	2004-04-08 07:25:54 +00:00
Roger Dingledine	4122e2de11	stop being so eager to have rend_cache_store reject the service descriptor svn:r1566	2004-04-08 05:08:27 +00:00
Nick Mathewson	bb46d782ab	Be endianly-correct for rendezvous functionality svn:r1565	2004-04-08 04:47:39 +00:00
Roger Dingledine	15de201041	log which intro points we picked svn:r1564	2004-04-08 04:36:13 +00:00
Nick Mathewson	2a01e3ad10	Launch intro services after launching connections; allow ORs to build circuits through as-yet-unconnectd ORs svn:r1562	2004-04-08 03:53:39 +00:00
Roger Dingledine	299df7117c	don't try to circuit_log_path if you're at the exit edge of a circ svn:r1561	2004-04-08 03:30:47 +00:00
Nick Mathewson	ede1d3e42d	Invert strcasecmp check for supports-rendezvous svn:r1560	2004-04-08 03:21:15 +00:00
Roger Dingledine	3e7c8a40bc	bugfix: alice would crash if bob advertised 0 intro points svn:r1559	2004-04-08 03:18:03 +00:00
Nick Mathewson	40f7324eea	Allow service descriptors with no intro points svn:r1557	2004-04-08 03:02:50 +00:00
Nick Mathewson	8351847afd	Nothing is good enough for you, is it? svn:r1556	2004-04-08 02:50:34 +00:00
Nick Mathewson	14e31fbd71	Use CIRCUIT_IS_ORIGIN in favor of boolean circ->cpath svn:r1555	2004-04-08 02:24:06 +00:00
Roger Dingledine	ad2192c90f	only call circuit_build_failed when we're circ's origin svn:r1554	2004-04-08 02:22:26 +00:00
Roger Dingledine	36d7cc8529	make the max buf size 10 megabytes, not 1 megabyte need to implement flexible buffer sizes soon svn:r1553	2004-04-08 02:19:35 +00:00
Roger Dingledine	4d194ef13f	clean up rend_client_get_random_intro svn:r1552	2004-04-08 02:11:49 +00:00
Nick Mathewson	46c82e7dbe	Set rend_query on exiting streams svn:r1551	2004-04-08 02:10:43 +00:00
Roger Dingledine	584350feb8	don't log info when we asked for log warn svn:r1548	2004-04-08 01:59:31 +00:00
Nick Mathewson	60772ec90c	Split out major functionality of circuit_get_best; rephrase a few booleans svn:r1547	2004-04-08 01:55:21 +00:00
Nick Mathewson	eaf7c61ebc	Do not crash when no desc is found svn:r1546	2004-04-08 01:54:02 +00:00
Roger Dingledine	9d38311ae3	allow for directories >8192 bytes svn:r1545	2004-04-08 01:47:33 +00:00
Roger Dingledine	6cf584b765	clean up choose_good_exit_server() svn:r1542	2004-04-07 23:31:29 +00:00
Roger Dingledine	63cde97253	don't try to build intro circs until you've fetched the directory svn:r1541	2004-04-07 22:48:06 +00:00
Roger Dingledine	e79a578fec	if the rend desc cache entry was fetched more than 15 mins ago, then try to fetch a new one. but if the new fetch fails, use the old one. svn:r1540	2004-04-07 22:41:00 +00:00
Nick Mathewson	09e66bbd14	Freeing the same variable twice in rapid succession can sometimes cause a double-free svn:r1539	2004-04-07 22:25:37 +00:00
Nick Mathewson	6649645f09	Insert a copy of our routerinfo into the routerlist. svn:r1538	2004-04-07 22:18:57 +00:00
Nick Mathewson	b1537e7943	Rebuild and re-upload service descriptors every 15 minutes svn:r1537	2004-04-07 22:06:54 +00:00
Nick Mathewson	b07b2cef29	Remember when we received which service desc. svn:r1536	2004-04-07 22:00:54 +00:00
Nick Mathewson	4d14b786da	Make sure we have our own keys before we initialize our routerlist svn:r1535	2004-04-07 21:44:46 +00:00
Nick Mathewson	10b48fee28	Generating data does no good if you make no use of it svn:r1534	2004-04-07 21:44:24 +00:00
Nick Mathewson	8169da5c30	Don't use Tor version 0.0.5 for intro/rendezvous points. (We don't need to worry about 0.0.4 or earlier, because nobody is running them any more.) svn:r1533	2004-04-07 21:36:03 +00:00
Roger Dingledine	93801ac40d	don't pick myself or my twins as hops when building circuits svn:r1531	2004-04-07 21:12:54 +00:00
Nick Mathewson	2633d353d7	Carefully increment failure counts when appropriate svn:r1530	2004-04-07 20:59:38 +00:00
Roger Dingledine	4df06ab5bb	let bob replenish his intro points and republish service desc as necessary svn:r1528	2004-04-07 20:47:50 +00:00
Roger Dingledine	505797e998	expire open-but-not-yet-acked circs if they're too old svn:r1526	2004-04-07 20:38:23 +00:00
Roger Dingledine	650d483bea	convince ourselves that circuit_failed doesn't have to be any smarter svn:r1525	2004-04-07 20:23:59 +00:00
Nick Mathewson	789df20e7d	There is no need to cast void* to other pointer types. svn:r1524	2004-04-07 20:11:28 +00:00
Nick Mathewson	3d60cd1d61	Delete trailing whitespace and expand tabs; remove unused aes decrypt code svn:r1522	2004-04-07 19:57:40 +00:00
Nick Mathewson	75c19716a8	Put ourself in router list; act accordingly. svn:r1521	2004-04-07 19:46:27 +00:00
Roger Dingledine	4a9587a486	we were uploading our server descriptor to each the dirservers when we boot, and then also on the first iteration of the main loop svn:r1520	2004-04-07 19:30:22 +00:00
Roger Dingledine	3c683a9e7c	let alice reuse recent rendjoin circs svn:r1519	2004-04-07 19:22:55 +00:00
Roger Dingledine	1f0769c470	mark a rend circ dirty when you attach to it svn:r1518	2004-04-07 19:14:45 +00:00
Roger Dingledine	cf67520e95	when counting how many being-built circs will handle a stream, don't count ones that are too old svn:r1517	2004-04-07 19:14:33 +00:00
Roger Dingledine	90caa94662	routerinfo->addr is host order svn:r1515	2004-04-07 06:17:27 +00:00
Nick Mathewson	fdb58e8ea3	Set routerinfo->addr properly for own routerinfo; do casei routerinfo compare svn:r1514	2004-04-06 22:23:12 +00:00
Nick Mathewson	f24519e4b9	Set correct address and port mappings on outgoing rendezvous connections svn:r1513	2004-04-06 22:05:49 +00:00
Roger Dingledine	95f0e36f08	alice just fetched bob's hidden webpage. yay. svn:r1512	2004-04-06 21:52:01 +00:00
Roger Dingledine	d473cf7ee9	set the circ windows on the middle hop of the rend circs svn:r1511	2004-04-06 21:25:11 +00:00
Nick Mathewson	8b371c2aa5	router_choose_random_node wants a smartlist of routers, not of nicknames. svn:r1510	2004-04-06 21:19:59 +00:00
Nick Mathewson	2fc106d210	Force hybrid encryption on for key negotiation svn:r1509	2004-04-06 20:55:46 +00:00
Nick Mathewson	40a5d6055e	Stupid sizeof operator! svn:r1508	2004-04-06 20:45:44 +00:00
Nick Mathewson	2446996f97	Remove vestigial variable svn:r1507	2004-04-06 20:42:25 +00:00
Roger Dingledine	5eca39cdb4	checkpoint commit: rend closer to working, still not there yet svn:r1506	2004-04-06 20:25:18 +00:00
Nick Mathewson	ef438b894c	Set handshake_state to NULL before appending cpath hops svn:r1505	2004-04-06 20:23:58 +00:00
Nick Mathewson	6290d027c9	Continue attack on magic numbers; use new crypto wrappers where possible svn:r1504	2004-04-06 20:16:12 +00:00
Nick Mathewson	257d509b91	Document stuff, reduce magic numbers, add emacs magic svn:r1502	2004-04-06 03:44:36 +00:00
Roger Dingledine	6e6cbaad95	fix the bob-can't-decode-relays bug now alice can send the begin and bob can receive it. svn:r1499	2004-04-05 23:40:59 +00:00
Roger Dingledine	077f133257	don't detach-and-retry rendezvous streams svn:r1498	2004-04-05 22:43:01 +00:00
Nick Mathewson	0f74b68edd	make router_get_by_nickname consider this router. svn:r1497	2004-04-05 22:22:42 +00:00
Roger Dingledine	2bb18e62cb	make rend apconn send to the right cpath layer and fix circuit_log_path to know about rend circs svn:r1496	2004-04-05 22:01:35 +00:00
Nick Mathewson	62b7ae6c9d	More symbolic constants for checking rendezvous1 cell lengths svn:r1495	2004-04-05 21:40:22 +00:00
Nick Mathewson	283593ca1b	Use correct payload lengths when sending RENDEZVOUS1 cells svn:r1494	2004-04-05 21:39:47 +00:00
Nick Mathewson	d371dda8f9	Spec conformance: KH\|"INTRODUCE" is only for establishing intro pt svn:r1493	2004-04-05 21:39:18 +00:00
Nick Mathewson	536a9b6c28	Add a missing offset svn:r1492	2004-04-05 21:31:53 +00:00
Nick Mathewson	5033c366e1	Use symbolic constants; make padding types match. svn:r1491	2004-04-05 21:15:14 +00:00
Nick Mathewson	04e8dc9026	Implement response to RENDEZVOUS2 cell. svn:r1490	2004-04-05 20:53:50 +00:00
Nick Mathewson	b1a8b208ca	Make init_cpath_crypto able to handle both sides of handshake, by adding a "reverse" flag svn:r1489	2004-04-05 20:53:04 +00:00
Nick Mathewson	2d3aea40a4	It's amazing how wrong things look when you invert the booleans on your sanity checks. svn:r1487	2004-04-05 20:34:58 +00:00
Nick Mathewson	7b1939db2d	Slightly more helpful msg on mismatched service pk digest in INTRODUCE2 cell svn:r1486	2004-04-05 20:33:29 +00:00
Nick Mathewson	eafb8186e5	Do first half of Alice-side of DH handshake. svn:r1485	2004-04-05 20:30:53 +00:00
Roger Dingledine	27126e5007	oaep uses 42 more bytes -- stop clobbering buffers also maybe fix some constants here and there -- nick? svn:r1484	2004-04-05 18:22:00 +00:00
Roger Dingledine	92bb5b2860	strdup the intro point when you pick it, so you don't free it and then return it svn:r1483	2004-04-05 17:56:34 +00:00
Roger Dingledine	ac84512489	complain early if we get an unrecognized nickname from bob's rend service descriptor svn:r1482	2004-04-05 17:51:00 +00:00
Nick Mathewson	12ede0a2c4	use the right variable when comparing hashes; maybe fix "Hash of session" bug svn:r1481	2004-04-05 17:36:30 +00:00
Nick Mathewson	41387bea08	Expect a 20-byte nul-padded-and-terminated nickname svn:r1480	2004-04-05 17:28:48 +00:00
Nick Mathewson	1e2b008700	Add some temporary log calls to try to debug the "Hash of session info was not as expected" problem svn:r1479	2004-04-05 17:20:57 +00:00
Roger Dingledine	cebf16eaf0	if a rend stream has already been attached to a rend circ, then don't attach it again (and again, and again, and...) svn:r1477	2004-04-05 15:24:03 +00:00
Roger Dingledine	8a209bc4d3	send a destroy after we send an introduce svn:r1476	2004-04-05 15:17:34 +00:00
Roger Dingledine	5b6099e8a2	more alice-side infrastructure handle rendezvous acks, do rend begin cells right, send an introduction cell (sort of) receive a rendezvous2 cell (sort of) svn:r1475	2004-04-05 07:41:31 +00:00
Roger Dingledine	7793078dff	alice can now look up bob's service descriptor, choose an intro point, connect to it, choose a rend point, connect to it and establish a cookie, get an ack from the rendezvous point, and know when both circs are ready for her. APConns don't use conn->purpose anymore don't initiate a renddesc lookup if one is already in progress also fix a buffer overflow in nickname parsing (only exploitable by the operator though) svn:r1471	2004-04-05 00:47:48 +00:00
Nick Mathewson	a9813f0210	Implement acks svn:r1470	2004-04-03 04:55:22 +00:00
Nick Mathewson	3af1191023	Add func to generate,set,and send rend cookie svn:r1469	2004-04-03 04:22:22 +00:00
Roger Dingledine	86f2ddc88d	nick, can you make and send the rendezvous cookie? svn:r1467	2004-04-03 04:05:30 +00:00
Nick Mathewson	b3c2b62a14	Make "common" no longer depend on or.h svn:r1466	2004-04-03 04:05:12 +00:00
Nick Mathewson	cb07e2ad27	Strdup hates finding 0 bytes. svn:r1465	2004-04-03 03:39:31 +00:00
Nick Mathewson	d93ff0b82f	Handle rendezvous relay cells svn:r1464	2004-04-03 03:37:11 +00:00
Roger Dingledine	7eaa655b6d	publish and fetch the right rendezvous urls svn:r1463	2004-04-03 03:33:57 +00:00
Nick Mathewson	ba196a9d17	Use (set\|get)_uint(16\|32) in lieu of memcpy where reasonable. svn:r1462	2004-04-03 03:07:25 +00:00
Roger Dingledine	8a1ad2b84e	more progress on alice's side svn:r1461	2004-04-03 03:06:06 +00:00
Nick Mathewson	137b577bbd	Refactor the heck out of crypto interface: admit that we will stick with one ciphersuite at a time, make const things const, and stop putting openssl in the headers. svn:r1458	2004-04-03 02:40:30 +00:00
Roger Dingledine	4e996a4ce8	tabs svn:r1456	2004-04-03 02:14:20 +00:00
Roger Dingledine	8c19d6e3d7	alice can intercept y.onion requests, do a lookup on them via tor, and receive a 404 svn:r1455	2004-04-03 01:59:53 +00:00
Nick Mathewson	88e2a09c22	Startup without crashing. svn:r1452	2004-04-03 01:11:04 +00:00
Nick Mathewson	fc4d15baf6	Hide smartlist internals svn:r1451	2004-04-03 00:58:54 +00:00
Roger Dingledine	bbc9484957	fix some bugs; more remain svn:r1450	2004-04-03 00:55:53 +00:00
Roger Dingledine	06c812c2de	remember to lower-case the y in y.onion svn:r1449	2004-04-03 00:27:33 +00:00
Roger Dingledine	2202c2c7ec	AP conns use conn->rend_query now too expose connection_ap_handshake_attach_circuit() svn:r1448	2004-04-02 23:54:48 +00:00
Nick Mathewson	2bc2f1ed03	Finish renaming rend_service field svn:r1447	2004-04-02 23:44:46 +00:00
Roger Dingledine	a8d805e292	break out circ->rend_service (this breaks the compile; must fix things) let alice react when she learns a new rendezvous descriptor let alice launch intro and rend circuits and mark them with her query svn:r1446	2004-04-02 23:38:26 +00:00
Nick Mathewson	e8345bfced	refactor; start adding debugging logs to midpoint rend stuff svn:r1445	2004-04-02 23:30:54 +00:00
Nick Mathewson	25a9bc594f	Finish missing comment :p svn:r1444	2004-04-02 23:04:10 +00:00
Nick Mathewson	08d748b6b3	Implement rennd_services_init svn:r1443	2004-04-02 23:01:00 +00:00
Roger Dingledine	fc3d7383e7	router_choose_random_node can take a smartlist of nodes to exclude svn:r1442	2004-04-02 22:30:39 +00:00
Roger Dingledine	f34e6da3e7	now circuit_get_newest returns an appropriate circ for your purpose connection_ap_handshake_attach_circuit attaches to a circ of the right purpose add a skeletal rendclient.c svn:r1441	2004-04-02 22:23:15 +00:00
Nick Mathewson	4cb21bab48	Make preferred/excluded intro points configurable svn:r1440	2004-04-02 22:06:46 +00:00
Nick Mathewson	a981c4099a	Implement midpoint functionality for rendezvous points. svn:r1439	2004-04-02 21:56:52 +00:00
Nick Mathewson	79fc52170e	For hidden services: handle INTRODUCE2, send ESTABLISH_INTRO, RENDEZVOUS1. Also: - Add a pending final cpath element to build_state - Rename S_RENDEZVOUSING to S_CONNECT_REND - Add [CS]_REND_JOINED - Split out logic to initialize cpath crypto objects. - Have circuits/cpaths remember the KH element from their handshake, so they can use it for other authentication later. (As in ESTABLISH_INTRO) svn:r1438	2004-04-01 22:21:01 +00:00
Nick Mathewson	6b958494f3	refactor to use new digest/checksig wrapper, add emacs magic, untabify svn:r1437	2004-04-01 22:12:00 +00:00
Nick Mathewson	cbbd13f789	Add new functions to wrap digest and sign/checksig. svn:r1436	2004-04-01 22:10:33 +00:00
Roger Dingledine	64cb3a027f	teach directory servers to handle renddesc responses svn:r1434	2004-04-01 21:32:01 +00:00
Roger Dingledine	05b99bcf7d	alice chooses her rendezvous node from all running routers and she can set preferences in her options svn:r1433	2004-04-01 20:33:29 +00:00
Nick Mathewson	103b8ead40	Finish implementing what-bob-does-on-INTRODUCE2 svn:r1432	2004-04-01 20:05:57 +00:00
Roger Dingledine	f05937355e	teach alice to recognize y.onion addresses svn:r1430	2004-04-01 19:39:11 +00:00
Nick Mathewson	7993382ba1	Add some hooks to handle rendezvous-related cells at ORs svn:r1429	2004-04-01 04:07:09 +00:00
Roger Dingledine	cc3c4245cb	let the circuit-launcher choose the exit node (if he wants) svn:r1428	2004-04-01 03:44:49 +00:00
Nick Mathewson	9feb44d3c4	Make it compile. svn:r1427	2004-04-01 03:43:54 +00:00
Nick Mathewson	c671b10695	Add a (also fragmentary) function to handle introduction requests svn:r1426	2004-04-01 03:34:05 +00:00
Roger Dingledine	d01497cf3c	outline what bob does to initialize his hidden services let circuit_launch_new return the circ it just made svn:r1424	2004-04-01 03:23:28 +00:00
Nick Mathewson	35f531b94f	Add helpful hybrid encryption functions svn:r1423	2004-04-01 03:08:35 +00:00
Roger Dingledine	36ff23209b	let alice recognize a y.onion address and, uhm, do something svn:r1422	2004-04-01 02:41:41 +00:00
Roger Dingledine	d13857a3f0	put in hooks for alice and bob logic when circuits finish/fail let you specify the purpose of circuits you launch bugfix: we used to be declaring the first successful circuit too early -- when the first hop finished. now we're more accurate. svn:r1421	2004-04-01 01:57:22 +00:00
Nick Mathewson	6d8be5e6f6	Add relay command types for rendezvous svn:r1419	2004-04-01 01:11:28 +00:00
Roger Dingledine	ee45ae575d	allow conns to demand to be attached to a clean circuit (nobody uses this yet) svn:r1417	2004-03-31 23:06:16 +00:00
Roger Dingledine	a0b0d16981	Add an ap_bridge function to do a socketpair and skip socks. This allows us to do a directory connection through tor just as if we're doing it as an application. Make ap_conns tolerate it when the application sends stuff before The socks handshake is done (it just buffers it). Tell directory_initiate_command the length of the payload (because it might include nuls). Add a directory_has_arrived function to, for example, start building the rendezvous service descriptor. svn:r1412	2004-03-31 22:02:13 +00:00
Nick Mathewson	28adda81e6	Add missing file svn:r1411	2004-03-31 21:54:56 +00:00
Nick Mathewson	bf83b1e345	Add code to configure hidden services, parse configuration, generate keys and service IDs, and store/load them from disk svn:r1410	2004-03-31 21:35:23 +00:00
Nick Mathewson	157cd7fe15	Fix warning svn:r1409	2004-03-31 20:58:35 +00:00
Roger Dingledine	b4a61d1ab1	better way: always nul-terminate. then sometimes use it, sometimes not. svn:r1408	2004-03-31 05:10:34 +00:00
Roger Dingledine	87dbd36a3c	let fetch_from_buf_http tolerate nuls in the http body teach directory.c about which places it needs to nul-terminate body before it uses it, and which places it must not svn:r1407	2004-03-31 05:01:30 +00:00
Nick Mathewson	8fedefe6cb	rename hidserv_xx svn:r1406	2004-03-31 04:10:10 +00:00
Nick Mathewson	b32440a028	Implement hidserv_XX functions; there is still an XXX in directory_handle_command svn:r1404	2004-03-31 03:42:56 +00:00
Nick Mathewson	6ea61d5e0d	Parse and generate service descriptors svn:r1403	2004-03-31 02:07:38 +00:00
Roger Dingledine	670aeb6c8d	add and use stubs for hidserv lookup and store svn:r1402	2004-03-30 23:41:24 +00:00
Nick Mathewson	93ab51e9ac	Make smartlist Do What Arma Expects. svn:r1401	2004-03-30 22:59:00 +00:00
Roger Dingledine	2d3ac08633	Refactor directory servers * read all the time (before we would ignore eof sometimes, oops) * we can handle different urls now * send back 404 for an un-handled url * commands initiated by the client can handle payloads now * introduce conn->purpose to avoid exponential state-space explosion svn:r1400	2004-03-30 22:57:49 +00:00
Nick Mathewson	96a86ef14d	Remove maximum-size field from smartlists svn:r1397	2004-03-30 20:05:52 +00:00
Nick Mathewson	0ba9ab5fb0	Add rendezvous-related metadata and code to circuits. Initially, we thought that a complicated adjunct structure would be necessary, but it doesn't look that way anymore. Of course, I might have forgotten something. svn:r1396	2004-03-30 19:52:42 +00:00
Nick Mathewson	6ea95488d2	Add more key manipulation functions, and base32 functions, to crypto svn:r1395	2004-03-30 19:47:32 +00:00
Roger Dingledine	524312494b	use 'notice' loglevel for things the operator should hear but that aren't warnings svn:r1384	2004-03-30 03:15:53 +00:00
Roger Dingledine	f796957182	don't freak people out as much with the warning message svn:r1378	2004-03-30 00:06:59 +00:00
Roger Dingledine	c09b185f03	re-enable recommendedversion checking (oops, thanks weasel) svn:r1376	2004-03-30 00:02:52 +00:00
Roger Dingledine	83c88c55fd	old or skewed descriptor doesn't mean we failed to parse it svn:r1373	2004-03-29 23:23:01 +00:00
Roger Dingledine	ce08baba1b	refactor directories a smidgen svn:r1371	2004-03-29 22:18:05 +00:00
Roger Dingledine	9723061dd9	first guess at a set of circuit purposes svn:r1370	2004-03-29 22:14:19 +00:00
Roger Dingledine	bcda3ebaef	bugfix: we were closing socks-request connections immediately, rather than flushing them, if they were timing out before we marked them svn:r1366	2004-03-29 20:04:09 +00:00
Roger Dingledine	7118c6177d	clean up a few more bugs svn:r1365	2004-03-29 19:57:50 +00:00
Roger Dingledine	155c777a84	fix typo svn:r1364	2004-03-29 19:53:53 +00:00
Roger Dingledine	0edf0ea7cc	make normal exit nodes less likely to crash from the conn-munging bug but leave dirservers just as likely to crash svn:r1363	2004-03-29 19:51:39 +00:00
Nick Mathewson	6a79b1cb57	Re-enable unit tests for directory generation. svn:r1362	2004-03-29 19:50:59 +00:00
Nick Mathewson	0e6084d751	Remove descriptors that are older than 24 hours from the directory. Use strlcat instead of strncat to generate directories. svn:r1361	2004-03-29 19:28:16 +00:00
Nick Mathewson	47b9d4439a	Possible fix for c99 aliasing warnings svn:r1360	2004-03-29 06:18:04 +00:00
Roger Dingledine	8c3999c964	make it less noisy for normal ORs when a server uses a false nickname svn:r1359	2004-03-28 21:35:02 +00:00
Roger Dingledine	4a5586b8e3	make dns resolves a lot faster (but only enable this once we've found the bug) svn:r1358	2004-03-28 21:16:52 +00:00
Roger Dingledine	2ba9901cb4	oh, i forgot to enable the find-munged-conn function svn:r1357	2004-03-28 21:14:05 +00:00
Roger Dingledine	e6a2e03524	hold socks reply open until flushed (if possible) svn:r1356	2004-03-28 09:48:21 +00:00
Roger Dingledine	f241fdfc73	there is yet another dns-pending-conn-clobbering bug somewhere svn:r1354	2004-03-28 04:54:36 +00:00
Roger Dingledine	56dfc3151f	work around a tsocks bug when an AP connection dies early, be sure to do a socks reject for it. if you just hang up, tsocks goes into an infinite loop. svn:r1352	2004-03-27 05:45:52 +00:00
Roger Dingledine	9ab5f3c067	fix an assert trigger where an OP would fail to handshake, and we'd expect it to have a nickname. svn:r1351	2004-03-27 01:28:14 +00:00
Roger Dingledine	47b40de0aa	only build circuits after we've fetched the directory this resolves a subtle bug where tor clients were preferentially using the directory servers, since when they start building circuits they know only about the directory servers on the other hand, it now takes longer after startup before there's a working circuit. so it goes. svn:r1350	2004-03-27 00:15:09 +00:00
Roger Dingledine	f2a692081f	make it less noisy to consider exit policies svn:r1349	2004-03-27 00:13:27 +00:00
Roger Dingledine	32e268c61b	oops, 0.0.4 is more broken than 0.0.3 maybe this will fix it svn:r1347	2004-03-26 23:37:13 +00:00
Roger Dingledine	45699bb5ee	clean up some 'warn' messages while i'm at it svn:r1342	2004-03-26 22:28:16 +00:00
Roger Dingledine	9c69f14a49	fix two assert triggers (darn it, I hate releasing software) when connecting to a dirserver or OR and the network is down, we would crash. svn:r1340	2004-03-26 22:07:45 +00:00
Roger Dingledine	4d747cd954	a missing comma could wreak all sorts of havoc. svn:r1335	2004-03-26 18:29:05 +00:00
Nick Mathewson	d44e3ad809	Remove unused open circuits when there are too many, not when they are too old. svn:r1332	2004-03-21 06:33:57 +00:00
Nick Mathewson	b3f6b55ea1	Dont expire circuits we didnt originate. This may be redundant somehow, but better safe than sorry. svn:r1331	2004-03-21 05:01:06 +00:00
Nick Mathewson	f608b85ddf	Replace all connection_removes outsice of main.c with connection_mark_for_close svn:r1328	2004-03-21 03:18:45 +00:00
Nick Mathewson	b7c2b18bd6	Add a RunTesting option to try to learn link state by creating test circuits, even when SocksPort is off. svn:r1327	2004-03-21 03:03:10 +00:00
Roger Dingledine	3d2c6c7cfa	catch signals in a more portable way, so solaris can catch them too svn:r1324	2004-03-20 23:27:22 +00:00
Roger Dingledine	ed0ef86c0e	make OR not crash when non-OR connection dies svn:r1319	2004-03-20 20:37:49 +00:00
Roger Dingledine	568a4e0a04	warn and fail if server chose a nickname with illegal characters svn:r1318	2004-03-20 20:28:53 +00:00
Roger Dingledine	4f0bad280d	make servers not crash when they rep-hist-note circuits that don't start at them svn:r1317	2004-03-20 20:21:20 +00:00
Roger Dingledine	66f878513f	deal with hardware word alignment this was causing the seg faults on sparc processors i wonder if i got them all. svn:r1314	2004-03-20 09:30:30 +00:00
Nick Mathewson	2ba2f02181	Integrate the new "rephist" [rep(utation) hist(ory)] module to trace successful/failed connections, successful/failed extends, and connection uptimes. It's still not done: more tests are needed, and not everything calls connection/circuit_mark_for_close properly. This skews the results. Also, there needs to be a 'testing' mode for non-OP ORs, where they periodically build circuits just to test whether extends work. svn:r1313	2004-03-20 04:59:29 +00:00
Nick Mathewson	da9d5ccfda	Add initial history-tracking backend code for reputation module. Not called or tested yet. svn:r1310	2004-03-20 01:48:05 +00:00
Nick Mathewson	b0ef4e1143	Use strmap code for client DNS. svn:r1309	2004-03-20 01:21:19 +00:00
Nick Mathewson	9199696182	Add some wrappers around SPLAY_* for the common map-from-string-to-X case. It will probably be less blindingly fast than using SPLAY_* directly, but only slightly so. svn:r1306	2004-03-19 22:07:24 +00:00
Roger Dingledine	c195f69058	isspace and friends take an int. solaris cares. svn:r1303	2004-03-19 20:50:12 +00:00
Roger Dingledine	208625ae31	clean up some presentation and comments svn:r1294	2004-03-18 19:22:56 +00:00
Roger Dingledine	a346889e94	make directory format tests quiet again svn:r1287	2004-03-15 05:13:25 +00:00
Roger Dingledine	0b9c140102	make it warn about internal IPs not only if we had to guess, but also if they used a hostname rather than an IP svn:r1285	2004-03-15 04:57:24 +00:00
Roger Dingledine	70cc557a18	only complain about private IPs if we had to guess svn:r1279	2004-03-15 04:04:16 +00:00
Roger Dingledine	be18884765	and another one svn:r1278	2004-03-15 04:00:14 +00:00
Roger Dingledine	fdc5751c60	bugfix: address that strcat vulnerability in circuit.c svn:r1273	2004-03-14 22:47:11 +00:00
Roger Dingledine	5d41346b67	prevent servers from publishing an internal IP as their address svn:r1272	2004-03-14 18:12:59 +00:00
Roger Dingledine	74ef3a63ae	bugfix: decrement OR connections from global_bucket too bugfix: don't return immediately for has_pending_tls_data unless the conn is allowed to read svn:r1270	2004-03-14 17:06:29 +00:00
Roger Dingledine	703b2d3cf8	refactor bandwidth-control token buckets this is a checkpoint commit; there still remain some bugs, er, somewhere. svn:r1269	2004-03-14 16:00:52 +00:00
Roger Dingledine	1ae45b771e	don't close all the fd's when you spawn a thread, only when you fork svn:r1267	2004-03-12 21:52:15 +00:00
Roger Dingledine	965a73dc71	bugfix: we were caching transient dns failures svn:r1266	2004-03-12 18:45:42 +00:00
Roger Dingledine	87797bcde5	get rid of those pesky tabs svn:r1264	2004-03-12 13:00:34 +00:00
Roger Dingledine	6af8d0606f	inform unapproved servers when we reject their descriptors svn:r1263	2004-03-12 12:43:13 +00:00
Roger Dingledine	623cb0e311	more details when a conn is closed before it's done flushing svn:r1262	2004-03-12 08:16:48 +00:00
Roger Dingledine	52e813951a	start tracking the 'broken pipe' error svn:r1261	2004-03-11 20:15:53 +00:00
Nick Mathewson	976bacae94	Make all the other read/writes into recv/sends, except when they shouldn't be. svn:r1260	2004-03-11 06:35:03 +00:00
Nick Mathewson	060d721554	UnDOSify CRLF->LF. svn:r1259	2004-03-11 06:22:53 +00:00
Nick Mathewson	9b4203266e	Make OP work on windows! (Also misc logging tweaks) svn:r1258	2004-03-11 06:19:08 +00:00
Nick Mathewson	59e2c77824	Get entropy in windows. svn:r1257	2004-03-11 05:14:06 +00:00
Roger Dingledine	8e4f1f67fa	actually, if recommendedversions is required for dirservers, then require it. svn:r1253	2004-03-10 07:44:31 +00:00
Roger Dingledine	3ba392e69f	give a useful error message to clients when the dirserver hasn't defined any recommended versions svn:r1252	2004-03-10 07:02:56 +00:00
Nick Mathewson	d877aac5ad	Make windows version correct; initialize windows foolishness so that gethostbyname works. svn:r1250	2004-03-10 06:26:38 +00:00
Nick Mathewson	c230132562	Fix some bugs in parse_time svn:r1249	2004-03-09 22:17:35 +00:00
Nick Mathewson	0e5a134709	Fix DOS line endings; autoconfize checks for strptime and inet_aton svn:r1248	2004-03-09 22:09:13 +00:00
Nick Mathewson	2da54de968	Make tor build on windows again. More work still needed svn:r1247	2004-03-09 22:01:17 +00:00
Roger Dingledine	30969421d3	stop troubling router operators with unapproved router connect attempts but give the dirserver operator more information svn:r1246	2004-03-09 14:53:00 +00:00
Roger Dingledine	416993afc1	bugfix: only set conn->hold_open_until_flushed after marking svn:r1245	2004-03-08 01:19:57 +00:00
Roger Dingledine	6e22801e0f	when you get a desc from an unknown router, log its fingerprint svn:r1244	2004-03-08 00:15:40 +00:00
Roger Dingledine	0ab367ed91	re-try streams at most 4 times svn:r1242	2004-03-07 23:50:15 +00:00
Roger Dingledine	10cee8b7f7	fix a rare race condition: when we send a cell and then mark an OR connection expired, we might close it before finishing a flush if the other side isn't reading. svn:r1240	2004-03-06 06:05:00 +00:00
Roger Dingledine	516ef41ac1	if a stream times out after 15s without a connected cell, don't try that circuit again. svn:r1239	2004-03-06 05:10:07 +00:00
Roger Dingledine	c362ed877d	if the directory client hangs up before getting the directory, then give up on him svn:r1238	2004-03-06 05:09:33 +00:00
Roger Dingledine	6c9d78b319	stop asserting that computers always go forward in time it's simply not true svn:r1236	2004-03-06 01:43:37 +00:00
Nick Mathewson	1e5b7bc6f1	New, more flexible directory parsing backend. Uses a bit more RAM, but implements the new spec. Uses more RAM, but not so you would notice. svn:r1235	2004-03-05 05:48:28 +00:00
Roger Dingledine	01e06148a1	make workers explain their death better when tor dies and make them say it at log level info rather than err svn:r1232	2004-03-04 21:26:23 +00:00
Roger Dingledine	8fe504fee6	bugfix: don't pass complex things to the connection_mark_for_close macro svn:r1231	2004-03-04 20:49:38 +00:00
Nick Mathewson	c03e9206ae	Clean up dns->connection_mark_for_close->dns_remove path svn:r1230	2004-03-04 18:43:44 +00:00
Roger Dingledine	89d9d80e76	Store options->Address as IP, not hostname And figure it out while reading config, not every time you rebuild the descriptor svn:r1226	2004-03-04 01:53:56 +00:00
Nick Mathewson	b7633e2e67	Try to find out early if buffers get trashed or double-freed. svn:r1225	2004-03-03 22:49:15 +00:00
Roger Dingledine	5e2e6555a2	and a minor patch svn:r1215	2004-03-03 08:48:32 +00:00
Roger Dingledine	419a672222	holding until flush was borked we were never writing anything when hold_open_until_flushed was set, since conn_write returns early if marked_for_conn is set. seems a bit better now. svn:r1214	2004-03-03 08:46:18 +00:00
Roger Dingledine	6022bfea11	better debugging for lonely flushes svn:r1213	2004-03-03 07:26:58 +00:00
Roger Dingledine	d8e5f3a3a2	close immediately when write() fails too, else things will turn bad svn:r1212	2004-03-03 07:26:34 +00:00
Roger Dingledine	dbdd2eaa2a	don't mark_for_close again when the destroy arrives after the end cell svn:r1211	2004-03-03 07:24:53 +00:00
Roger Dingledine	3c71d09402	use conn->hold_open_until_flushed for streams and also note/fix a variety of other stream-based bugs svn:r1210	2004-03-03 06:26:34 +00:00
Nick Mathewson	f4e4dac801	Implement hold_open_until_flushed. I may have missed something important. svn:r1209	2004-03-03 05:08:01 +00:00
Roger Dingledine	8275e2302c	make socks5 not give a spurious warning also rename AP_CONN_STATE_CONNECTING to _CONNECT_WAIT svn:r1208	2004-03-03 04:54:16 +00:00
Roger Dingledine	77bb3e054e	reenable part of assert_circuit_ok, leave some still disabled svn:r1207	2004-03-03 04:11:18 +00:00
Roger Dingledine	de146de0c5	make circuit-building less noisy when a node in your exclude/exit/entrynodes is down svn:r1206	2004-03-03 03:02:06 +00:00
Nick Mathewson	20ecb66c7d	Fix (maybe) assert_circuit_ok. leave it disabled till arma confirms svn:r1205	2004-03-03 02:24:17 +00:00
Nick Mathewson	5a053a6a81	remove redundant check svn:r1204	2004-03-03 02:14:35 +00:00
Nick Mathewson	6379dbbe2a	warn more when losing data on closed/marked connections. svn:r1203	2004-03-03 02:07:57 +00:00
Roger Dingledine	49281424ae	bugfix: close_immediate called buf_clear but listeners don't have bufs svn:r1202	2004-03-03 01:58:45 +00:00
Nick Mathewson	5985aef18a	Nth time is the charm on list manip. svn:r1201	2004-03-03 01:37:54 +00:00
Roger Dingledine	4f6cf727b9	fix a pair of lurking segfaults svn:r1198	2004-03-02 18:08:07 +00:00
Nick Mathewson	6f3c6d1289	Split out mark_for_close with circuits. Seems to work for me. svn:r1197	2004-03-02 17:48:17 +00:00
Nick Mathewson	a1e4c6dc85	Fix assertion failure spotted by arma. Apparently, when a DNS failure was already cached, then when we tried to mark the exit connection as closed, we'd try to remove it from the pending queue anyway, and hit an assert. Now, we put failed-resolve connections in a separate state so that mark_for_close does the right thing. svn:r1196	2004-03-02 07:24:11 +00:00
Roger Dingledine	b961732246	add --version, note that --help is probably obsolete svn:r1195	2004-03-02 05:19:01 +00:00
Roger Dingledine	1147289dc0	make config_assign fail rather than warn for unrecognized config options svn:r1194	2004-03-02 05:00:50 +00:00
Roger Dingledine	f81ad1550e	note an assert trigger bug nick, want to fix this? :) svn:r1192	2004-03-01 12:37:45 +00:00
Nick Mathewson	5072488a95	make 'make test' exit(1) if a test fails. svn:r1190	2004-03-01 06:45:32 +00:00
Roger Dingledine	2c341cd032	put switch_id and start_daemon earlier svn:r1188	2004-02-29 22:34:38 +00:00
Roger Dingledine	e2881631cf	fix duplicate call to connection_mark_for_close svn:r1187	2004-02-29 22:07:44 +00:00
Roger Dingledine	2ac37c64f2	bugfix: we were checking the wrong thing to see if 'reason' was out of range svn:r1186	2004-02-29 22:04:52 +00:00
Roger Dingledine	8e5c1921fc	when a stream is 15s late, print out the circuit at -l warn svn:r1180	2004-02-29 09:15:29 +00:00
Roger Dingledine	ef5f917e9e	print a statement when the first circ is finished, so the user knows it's working svn:r1179	2004-02-29 03:52:38 +00:00
Roger Dingledine	4716d4d871	bugfix: only warn about an unrouter router after we've fetched a directory svn:r1178	2004-02-29 01:31:33 +00:00
Roger Dingledine	b4338ce704	disable buffer tests, until we rewrite them (one of them fails) svn:r1177	2004-02-29 00:15:20 +00:00
Roger Dingledine	195ee8c845	create a separate connection_edge_destroy() function svn:r1176	2004-02-29 00:11:37 +00:00
Roger Dingledine	62d3df8633	bugfix: when we time out on a stream and detach, send an end first svn:r1175	2004-02-28 23:56:50 +00:00
Roger Dingledine	ae67c48805	bugfix: in some cases, connection_mark_for_close wasn't marking the conn svn:r1174	2004-02-28 23:52:56 +00:00
Roger Dingledine	3fb9c869a8	clearer warning message svn:r1173	2004-02-28 23:31:15 +00:00
Roger Dingledine	c058f87513	disallow changing from ORPort==0 to ORPort>0 on hup svn:r1172	2004-02-28 23:30:41 +00:00

... 48 49 50 51 52 ...

5560 Commits