Roger Dingledine
f2ed011813
We were comparing the raw BridgePassword entry with a base64'ed
...
version of it, when handling a "/tor/networkstatus-bridges"
directory request. Now compare correctly. Noticed by Veracode.
svn:r13609
2008-02-20 02:05:28 +00:00
Roger Dingledine
f34d46e7dd
similarly, don't throw around an int for the uint8_t circ->state
...
svn:r13608
2008-02-20 01:01:09 +00:00
Roger Dingledine
7427cf5d56
don't throw around an int for relay_command if we're going to
...
squeeze it into a uint8_t later. also reported by veracode.
svn:r13607
2008-02-20 00:57:37 +00:00
Roger Dingledine
0977c29196
notice an integer overflow if we ever get source files with more
...
than 65k lines in them. also pointed out by veracode.
svn:r13606
2008-02-20 00:46:09 +00:00
Roger Dingledine
e9474ed28e
if you thought r13604 was a kludge, how about this.
...
svn:r13605
2008-02-20 00:30:41 +00:00
Roger Dingledine
56a7c9238e
be more clear about a possible integer underflow problem. this
...
should probably be fixed better somehow.
svn:r13604
2008-02-20 00:11:52 +00:00
Roger Dingledine
e0beb6cc5e
check return value for crypto_pk_asn1_encode here too. thanks veracode.
...
svn:r13603
2008-02-19 23:59:16 +00:00
Nick Mathewson
260c37c14c
r18236@catbus: nickm | 2008-02-19 18:55:21 -0500
...
Explain why I am right and veracode is wrong in routerparse.c line 1141. Using math!
svn:r13602
2008-02-19 23:57:06 +00:00
Roger Dingledine
913f66278c
rearrange our assert so we don't possibly overflow rh.length before
...
triggering the assert. reported by veracode.
svn:r13601
2008-02-19 23:54:17 +00:00
Nick Mathewson
0399538b90
r18233@catbus: nickm | 2008-02-19 18:46:07 -0500
...
Count sockets returned from socketpair() too. This is probably not the socket counting bug.
svn:r13600
2008-02-19 23:46:08 +00:00
Roger Dingledine
707da4f73f
start checking the return value of crypto_pk_asn1_encode() while
...
we're trying to establish an introduction point. bug reported
by veracode.
svn:r13599
2008-02-19 23:33:02 +00:00
Nick Mathewson
42c4670e27
r18230@catbus: nickm | 2008-02-19 18:29:43 -0500
...
Add a few asserts to catch possible errors found by veracode.
svn:r13598
2008-02-19 23:29:45 +00:00
Roger Dingledine
319c0d8933
is_reverse in our struct is uint8_t. don't make it be an int
...
elsewhere. bug reported by veracode.
svn:r13597
2008-02-19 23:14:34 +00:00
Nick Mathewson
dbcf29d301
r18228@catbus: nickm | 2008-02-19 18:05:53 -0500
...
Chris Palmer notes that almost nobody is using smartlist_set_capacity(). Chris Palmer is right. Remove this basically pointless function.
svn:r13596
2008-02-19 23:05:56 +00:00
Nick Mathewson
9479dd3768
r18226@catbus: nickm | 2008-02-19 18:01:01 -0500
...
Brown-paper-bag time. We were failing to count all the sockets from accept().
svn:r13595
2008-02-19 23:01:07 +00:00
Roger Dingledine
d1a195d3cb
call a "number of characters" a size_t, not an int
...
svn:r13594
2008-02-19 22:52:50 +00:00
Nick Mathewson
632c035ad9
r18221@catbus: nickm | 2008-02-19 17:46:16 -0500
...
New debugging code to figure out what is happending with socket counts.
svn:r13593
2008-02-19 22:46:19 +00:00
Roger Dingledine
c126b79f07
be more explicit about a harmless thing that freaked veracode out
...
svn:r13592
2008-02-19 22:32:32 +00:00
Nick Mathewson
4ccffd7aea
r18218@catbus: nickm | 2008-02-19 17:27:40 -0500
...
When SafeLogging is off, have TLS errors and messages logged with their associated addresses.
svn:r13591
2008-02-19 22:27:44 +00:00
Roger Dingledine
810bfe970c
make explicit that we don't care if a rename() call fails.
...
potential bug reported by veracode.
svn:r13590
2008-02-19 22:25:20 +00:00
Nick Mathewson
749735215b
r18208@catbus: nickm | 2008-02-19 17:02:30 -0500
...
Add some checks in torgzip.c to make sure we never overflow size_t there. Also make sure we do not realloc(list,0) in container.c. Backport candidate.
svn:r13587
2008-02-19 22:05:49 +00:00
Roger Dingledine
23e4c849c9
resolve another edge case in staying dormant
...
svn:r13586
2008-02-19 22:01:45 +00:00
Roger Dingledine
da7f0315e6
maybe it should compile too.
...
svn:r13585
2008-02-19 21:41:43 +00:00
Roger Dingledine
d964beac16
If we only ever used Tor for hidden service lookups or posts, we
...
would stop building circuits and start refusing connections after
24 hours, since we false believed that Tor was dormant. Reported
by nwf; bugfix on 0.1.2.x.
svn:r13583
2008-02-19 21:30:24 +00:00
Roger Dingledine
33c754315b
clear up another connlimit lie
...
svn:r13582
2008-02-19 21:08:27 +00:00
Roger Dingledine
d61835a4ba
clean up the socket counting thing. third time's a charm.
...
svn:r13581
2008-02-19 19:48:07 +00:00
Nick Mathewson
f4dc006fb5
r18198@catbus: nickm | 2008-02-19 14:30:30 -0500
...
Try to *fix* the socket counting problem, and add an info log to detect whether we really fixed it
svn:r13580
2008-02-19 19:30:41 +00:00
Nick Mathewson
b98c437fcc
r18195@catbus: nickm | 2008-02-19 14:11:15 -0500
...
TOR_PERF has not not been a sane thing for ages. Remove it.
svn:r13579
2008-02-19 19:30:37 +00:00
Roger Dingledine
ab4d3888e4
hunt for killerchicken's socket counting problem
...
svn:r13578
2008-02-19 19:27:55 +00:00
Roger Dingledine
be8a85dc1c
document that if you enable TOR_PERF, you won't be compatible with the
...
main Tor network.
svn:r13577
2008-02-19 18:54:44 +00:00
Nick Mathewson
8c6b5d6640
r14246@tombo: nickm | 2008-02-17 19:33:02 -0500
...
Fix a wide line in control.c; make the check-spaces target ignore the openbsd malloc file.
svn:r13566
2008-02-19 05:08:27 +00:00
Nick Mathewson
3277e2a8ca
r18142@catbus: nickm | 2008-02-18 14:24:31 -0500
...
Our preferred spelling for a bitfield is "unsigned int", not "unsigned" or "uint8_t".
svn:r13560
2008-02-18 19:24:33 +00:00
Nick Mathewson
08f7842384
r18139@catbus: nickm | 2008-02-18 13:14:05 -0500
...
Clarify logic in trusted_dirs_load_certs_from_string(); avoid a maybe-impossible maybe-not double-free spotted by lodger.
svn:r13558
2008-02-18 18:14:34 +00:00
Nick Mathewson
5d069a543b
r18138@catbus: nickm | 2008-02-18 13:13:18 -0500
...
Try to make conditional include logic for openbsd malloc not warn on arma's computer. May fix bug 610.
svn:r13557
2008-02-18 18:14:32 +00:00
Andrew Lewman
b9a7649576
update thoughts on documentation license.
...
svn:r13549
2008-02-17 21:44:22 +00:00
Nick Mathewson
9e9b447b87
r14243@tombo: nickm | 2008-02-17 14:51:26 -0500
...
Better debugging to track down bug 606. Also remove a break; that may have been the possible culprit
svn:r13547
2008-02-17 19:51:33 +00:00
Nick Mathewson
952a3cb8fb
r14240@tombo: nickm | 2008-02-17 14:26:52 -0500
...
Add a --with-tcmalloc argument to configure.
svn:r13546
2008-02-17 19:26:55 +00:00
Nick Mathewson
4c1e4821d2
r18123@catbus: nickm | 2008-02-17 14:08:45 -0500
...
Fix capitalization error
svn:r13545
2008-02-17 19:09:02 +00:00
Nick Mathewson
a8b371c333
r14238@tombo: nickm | 2008-02-17 14:03:44 -0500
...
Add openbsd memory allocator discussed in bug 468, to make it easier for linux users to get non-awful allocation patterns. Use --enable-openbsd-malloc to turn it on. Needs more testing.
svn:r13544
2008-02-17 19:03:49 +00:00
Nick Mathewson
faa56a500b
r14236@tombo: nickm | 2008-02-17 13:44:55 -0500
...
Partial fix for bug 586: Add an ephemeral __HashedControlSessionPassword.
svn:r13543
2008-02-17 18:45:07 +00:00
Roger Dingledine
4c1e516a09
cleanups and changelog entry for r13540
...
svn:r13542
2008-02-17 16:52:24 +00:00
Roger Dingledine
256fd43e42
move todo stuff around a bit
...
svn:r13541
2008-02-17 16:50:48 +00:00
Roger Dingledine
bd959adcb7
patch from karsten:
...
Resolved problems with (re-)fetching hidden service descriptors.
Before, v0 descriptors were not fetched at all (fix on 0.2.0.18-alpha),
re-fetching of v2 descriptors did not stop when a v0 descriptor was
received (fix on 0.2.0.18-alpha), and re-fetching of v2 descriptors did
not work in all cases (fix on 0.2.0.19-alpha).
svn:r13540
2008-02-17 16:47:47 +00:00
Nick Mathewson
6366dcd8ee
r14186@tombo: nickm | 2008-02-15 18:38:52 -0500
...
Add an XXXX021 item so we eventually stop calling setuid() and setgid() unnecessarily.
svn:r13533
2008-02-15 23:39:17 +00:00
Nick Mathewson
24e8e1fb36
r14185@tombo: nickm | 2008-02-15 18:05:54 -0500
...
Replace the hefty tor_strpartition with a simple function to replace its only (trivial) use.
svn:r13532
2008-02-15 23:39:14 +00:00
Nick Mathewson
f5ed1f8469
r14183@tombo: nickm | 2008-02-15 17:37:53 -0500
...
Add initial unit tests for test_addr_compare_masked
svn:r13531
2008-02-15 23:39:10 +00:00
Nick Mathewson
ca4eb987c8
r14182@tombo: nickm | 2008-02-15 17:20:51 -0500
...
Defer, downgrade, or address more XXX020s. The remaining ones are all ones we should deal with before release.
svn:r13530
2008-02-15 23:39:08 +00:00
Nick Mathewson
418c2e1b6b
r14181@tombo: nickm | 2008-02-15 16:48:17 -0500
...
Fix all but 2 DOCDOC items; defer many XXX020s (particularly those where fixing them would fix no bugs at the risk of introducing some bugs).
svn:r13529
2008-02-15 23:39:04 +00:00
Roger Dingledine
861c79dc5d
put some external constraints into our todo list
...
svn:r13528
2008-02-15 20:20:24 +00:00
Nick Mathewson
ff64e78b20
r14170@tombo: nickm | 2008-02-15 11:50:38 -0500
...
Fix or downgrade a bunch of xxx020 items.
svn:r13527
2008-02-15 19:20:53 +00:00
