Nick Mathewson
a83650852d
Add another NULL-pointer fix for protover.c.
...
This one can only be exploited if you can generate a correctly
signed consensus, so it's not as bad as 25074.
Fixes bug 25251; also tracked as TROVE-2018-004.
2018-03-01 16:05:17 -05:00
Nick Mathewson
65f2eec694
Correctly handle NULL returns from parse_protocol_list when voting.
...
In some cases we had checked for it, but in others we had not. One
of these cases could have been used to remotely cause
denial-of-service against directory authorities while they attempted
to vote.
Fixes TROVE-2018-001.
2018-03-01 16:05:17 -05:00
Taylor Yu
09484b9449
Document how to allow partial Travis failures
...
Add some commented-out allow_failures clauses to make it easier to
temporarily allow less-critical sub-builds to fail while still
reporting success.
2018-03-01 13:18:33 -06:00
Isis Lovecruft
167da4bc81
rust: Remove extra whitespace from a static log/error message.
2018-02-27 20:43:54 +00:00
teor
01a977b492
Update the primitive types explanation in the Rust coding standards
...
Part of #25368 .
Includes c_double in anticipation of #23061 .
2018-02-27 15:55:13 +11:00
Deepesh Pathak
130e2ffad7
Remove duplicate code between parse_{c,s}method in transport.c
...
- Merged common code in function parse_{c,s}method to a single function
- Removed duplicate code in transport.c
- Fixes #6236
2018-02-24 20:27:08 +05:30
Nick Mathewson
54e25ab124
Remove changes files for items already in 0.3.3.
2018-02-22 09:17:44 -05:00
Nick Mathewson
e87a2759f3
Merge branch 'maint-0.3.3'
2018-02-21 11:56:02 -05:00
Nick Mathewson
d489e4847b
Fix a variable name in tor-rust-dependencies
2018-02-21 11:55:25 -05:00
Nick Mathewson
d2bdb54d37
Wrap GettingStartedRust.md to 72 columns.
2018-02-21 11:55:07 -05:00
Nick Mathewson
bcfb034957
Merge branch 'maint-0.3.1' into maint-0.3.2
2018-02-21 11:53:50 -05:00
Nick Mathewson
62c88a6011
Merge branch 'maint-0.3.3'
2018-02-21 11:53:50 -05:00
Nick Mathewson
8a5cb58ad0
Merge branch 'maint-0.3.2' into maint-0.3.3
2018-02-21 11:53:50 -05:00
Nick Mathewson
ac1942ac58
Update the .gitmodules to refer to project-level tor-rust-dependencies
...
Closes most of #25323 .
2018-02-21 11:53:04 -05:00
Nick Mathewson
fc22bcadb5
Revert 4438ef32's changes to test_address.c
...
Apparently some versions of the mac sdk care about the ordering of
net/if.h wrt other headers.
Fixes bug 25319; bug not in any released tor.
2018-02-21 09:36:37 -05:00
Isis Lovecruft
7759ac8df2
crypto: Remove crypto_rsa.h from crypto_digest.c.
...
* ADD include for "crypto_openssl_mgt.h" so that we have OpenSSL
defined SHA* types and functions.
* FIXES part of #24658 : https://bugs.torproject.org/24658#comment:30
2018-02-20 20:29:54 +00:00
Isis Lovecruft
3e9140e79a
crypto: Remove unnecessary curve25519 header from crypto_digest.h.
...
* ADD includes for "torint.h" and "container.h" to crypto_digest.h.
* ADD includes for "crypto_digest.h" to a couple places in which
crypto_digest_t was then missing.
* FIXES part of #24658 : https://bugs.torproject.org/24658#comment:30
2018-02-20 20:29:54 +00:00
Nick Mathewson
4438ef3288
Remove a bunch of other redundant #includes
...
Folks have found two in the past week or so; we may as well fix the
others.
Found with:
\#!/usr/bin/python3
import re
def findMulti(fname):
includes = set()
with open(fname) as f:
for line in f:
m = re.match(r'^\s*#\s*include\s+["<](\S+)[>"]', line)
if m:
inc = m.group(1)
if inc in includes:
print("{}: {}".format(fname, inc))
includes.add(m.group(1))
import sys
for fname in sys.argv[1:]:
findMulti(fname)
2018-02-20 10:14:15 -05:00
Nick Mathewson
a4ab273a0d
Merge remote-tracking branch 'fristonio/ticket-25261'
2018-02-20 10:03:52 -05:00
Nick Mathewson
5199b9b337
Use autoconf to check for optional zstd functionality.
...
Fixes a bug in our zstd-static code. Bug not in any released
version of Tor.
2018-02-18 16:19:43 -05:00
Fernando Fernandez Mancera
0fad49e1c4
Move crypto_pk_obsolete_* functions into RSA module.
...
We moved the crypto_pk_obselete_* functions into crypto_rsa.[ch] because they fit
better with the RSA module.
Follows #24658 .
Signed-off-by: Fernando Fernandez Mancera <ffmancera@riseup.net>
2018-02-16 18:23:21 +01:00
Fernando Fernandez Mancera
541b6b2433
Remove useless included files in crypto_rsa.[ch].
...
Follows #24658 .
Signed-off-by: Fernando Fernandez Mancera <ffmancera@riseup.net>
2018-02-16 17:49:58 +01:00
Nick Mathewson
e0427b6bf6
Merge branch 'maint-0.3.3'
2018-02-16 09:55:59 -05:00
Nick Mathewson
6384d314fb
Merge branch 'maint-0.3.2' into maint-0.3.3
...
"ours" merge to avoid taking 24902 a second time and having to reconcile
all the merge conflicts.
2018-02-16 09:55:41 -05:00
Nick Mathewson
bd71e0a0c8
Merge branch 'maint-0.3.1' into maint-0.3.2
2018-02-16 09:54:13 -05:00
Nick Mathewson
2bcd264a28
Merge branch 'maint-0.2.9' into maint-0.3.1
2018-02-16 09:48:11 -05:00
Nick Mathewson
cb92d47dec
Merge remote-tracking branch 'dgoulet/ticket24902_029_05' into maint-0.2.9
2018-02-16 09:41:06 -05:00
Nick Mathewson
bbc73c5d1c
Whoops. 256 was not big enough.
2018-02-16 09:40:29 -05:00
Nick Mathewson
a34fc1dad2
Allow checkpointing of non-sha1 digests.
...
This is necessary because apparently v3 rendezvous cpath hops use
sha3, which I had forgotten.
Bugfix on master; bug not in any released Tor.
2018-02-16 09:25:50 -05:00
Nick Mathewson
9f1899fdfd
Merge branch 'maint-0.3.2' into maint-0.3.3
2018-02-16 08:49:08 -05:00
Nick Mathewson
5c48f62e67
Merge branch 'maint-0.3.3'
2018-02-16 08:49:08 -05:00
Nick Mathewson
c67adddacb
Remove changes file for 24898-029 backports in maint-0.3.2
...
These patches were already merged, and so don't need a changes file
in these branches.
2018-02-16 08:48:46 -05:00
Nick Mathewson
8970058af6
Merge branch 'maint-0.3.2' into maint-0.3.3
2018-02-16 08:47:41 -05:00
Nick Mathewson
1527032384
Merge branch 'maint-0.3.3'
2018-02-16 08:47:41 -05:00
Nick Mathewson
c8b087d901
Merge branch 'maint-0.3.1' into maint-0.3.2
2018-02-16 08:47:41 -05:00
Nick Mathewson
3930ffdf63
Merge branch 'maint-0.2.9' into maint-0.3.1
...
"ours" merge to avoid conflicts with the cherry-picked fix for 24898.
2018-02-16 08:47:12 -05:00
Roger Dingledine
d21e5cfc24
stop calling channel_mark_client in response to a create_fast
...
since all it does is produce false positives
this commit should get merged into 0.2.9 and 0.3.0 *and* 0.3.1, even
though the code in the previous commit is already present in 0.3.1. sorry
for the mess.
[Cherry-picked]
2018-02-16 08:46:57 -05:00
Roger Dingledine
2b99350ca4
stop calling channel_mark_client in response to a create_fast
...
since all it does is produce false positives
this commit should get merged into 0.2.9 and 0.3.0 *and* 0.3.1, even
though the code in the previous commit is already present in 0.3.1. sorry
for the mess.
2018-02-16 08:46:31 -05:00
Roger Dingledine
8d5dcdbda2
backport to make channel_is_client() accurate
...
This commit takes a piece of commit af8cadf3a9
and a piece of commit
46fe353f25, with the goal of making channel_is_client() be based on what
sort of connection handshake the other side used, rather than seeing
whether the other side ever sent a create_fast cell to us.
2018-02-16 08:39:10 -05:00
Neel Chauhan
c2fa743806
Remove the return value of node_get_prim_orport() and node_get_prim_dirport()
2018-02-16 08:20:33 -05:00
Nick Mathewson
200fc8c640
Compilation workaround for windows, which lacks O_SYNC
...
Bug not in any released Tor.
2018-02-16 08:16:12 -05:00
Nick Mathewson
5a9ada342f
tor_zstd_format_version shouldn't be built when !HAVE_ZSTD
...
Fixes bug 25276; bugfix not in any released Tor.
2018-02-16 08:06:01 -05:00
Fernando Fernandez Mancera
f9f0dd5b9a
Move the pk-digest functions into crypto_rsa.[ch].
...
We moved the crypto_pk_* digest functions into crypto_rsa.[ch] because they fit
better with the RSA module.
Follows #24658 .
Signed-off-by: Fernando Fernandez Mancera <ffmancera@riseup.net>
2018-02-16 12:04:22 +01:00
Nick Mathewson
b56fd17d00
Merge branch 'maint-0.3.3'
2018-02-15 21:05:12 -05:00
Nick Mathewson
d662d4470a
Merge remote-tracking branch 'dgoulet/ticket24343_033_01' into maint-0.3.3
2018-02-15 21:05:08 -05:00
Nick Mathewson
d9804691df
Merge remote-tracking branch 'ffmancera-1/bug18918'
2018-02-15 21:00:10 -05:00
Nick Mathewson
92a42f795c
Merge branch 'bug23909'
2018-02-15 20:56:23 -05:00
Nick Mathewson
8da6bfa5de
Merge branch 'bug24914'
2018-02-15 20:53:50 -05:00
Nick Mathewson
4d994e7a9c
Fix a stack-protector warning: don't use a variable-length buffer
...
Instead, define a maximum size, and enforce it with an assertion.
2018-02-15 20:52:01 -05:00
Nick Mathewson
ed1d630f0e
Merge branch 'onion_ntor_malloc_less'
2018-02-15 20:40:03 -05:00