nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-15 15:53:31 +01:00
Code Issues Packages Projects Releases Wiki Activity
14,156 Commits 53 Branches 630 Tags 125 MiB
e2b3527106
Commit Graph

9690 Commits

Author SHA1 Message Date
Roger Dingledine
4f23045e58 back out a little bit of r11817 to preserve current behavior. 
some other behavior changes left in.


svn:r11821
 2007-10-09 21:12:48 +00:00
Roger Dingledine
a5851939c0 i heard that users know the phrase 'system clock' better than 'clock'. hm. 
svn:r11820
 2007-10-09 21:11:16 +00:00
Nick Mathewson
97fa3fdf16 r15599@catbus: nickm | 2007-10-09 16:44:36 -0400 
Fix the bug that was making moria1 set valid-after wrong in its votes: we were looking at the preferred timing when we should have been looking at the consensus timing.


svn:r11818
 2007-10-09 20:44:51 +00:00
Nick Mathewson
8b71a76dd3 r15598@catbus: nickm | 2007-10-09 16:37:35 -0400 
Turn all "Is DirPort nonzero? Because if it is, we must be a directory" logic into calls to dirserver_mode().


svn:r11817
 2007-10-09 20:44:47 +00:00
Nick Mathewson
010fd50c36 r15597@catbus: nickm | 2007-10-09 16:17:42 -0400 
Make authority_certs_fetch_missing only fetch certificates which we are not currently downloading; fix XXXX020s in networkstatus.c


svn:r11816
 2007-10-09 20:44:45 +00:00
Nick Mathewson
0827d6f217 r15593@catbus: nickm | 2007-10-09 15:31:10 -0400 
Fix an infinite loop when parsing multiple votes.


svn:r11813
 2007-10-09 19:31:14 +00:00
Nick Mathewson
a2005cd2c1 r15590@catbus: nickm | 2007-10-09 15:14:42 -0400 
Change dirvote_get_vote to take named flags rather than 3 boolean inputs.  Fix a bug that was caused by the order of the boolean inputs in or.h not matching the order of boolean inputs in dirvote.c.


svn:r11812
 2007-10-09 19:14:48 +00:00
Nick Mathewson
40b6a66c89 r15589@catbus: nickm | 2007-10-09 15:08:00 -0400 
Fix dumb typo in vote retrieval: we want to check the pending votes to see what we are missing; not the previous period.


svn:r11811
 2007-10-09 19:14:46 +00:00
Nick Mathewson
a3d4c47515 r15587@catbus: nickm | 2007-10-09 15:05:27 -0400 
When parsing two concatenated networkstatuses (as we do when voting), detect the end of the first one properly.


svn:r11810
 2007-10-09 19:05:38 +00:00
Roger Dingledine
c9f2afd5fa make r11808 build on my 64-bit 
svn:r11809
 2007-10-09 18:43:05 +00:00
Nick Mathewson
23614f9523 r15581@catbus: nickm | 2007-10-09 14:36:47 -0400 
Recompute voting schedule whenever a consensus is set.


svn:r11808
 2007-10-09 18:36:56 +00:00
Nick Mathewson
f1d4e3477b Bugfixes in fetching certificates for a consensus: fetch tor/keys/fp/X, not tor/keys/X. Also, count signatures where no certificate is known as "missing a certificate" not as "unknown authority." 
svn:r11805
 2007-10-09 17:40:23 +00:00
Nick Mathewson
c7981e669f r15574@catbus: nickm | 2007-10-09 13:01:53 -0400 
Fix the "400 OK" issue when replying to a vote.


svn:r11801
 2007-10-09 17:07:13 +00:00
Nick Mathewson
5346a01796 r14813@Kushana: nickm | 2007-10-09 11:10:48 -0400 
Use download_status_t for v2 networkstatuses and certs as well as for routers.  Make functions to manipulate it.  Next steps: use it for consensus networkstatuses, and get consensus download rescheduling working.


svn:r11800
 2007-10-09 15:27:45 +00:00
Nick Mathewson
bb9cc4fb29 r14812@Kushana: nickm | 2007-10-09 10:22:00 -0400 
Merge extra fields in local_routerstatus_t back into routerstatus_t.  See changelog for rationale.


svn:r11799
 2007-10-09 15:27:15 +00:00
Roger Dingledine
11a782a6c3 for once, it was "no-tab man" that struck again. 
svn:r11793
 2007-10-08 21:28:23 +00:00
Nick Mathewson
18ec603861 r14802@Kushana: nickm | 2007-10-08 17:21:30 -0400 
Refactor out about a third of routerlist.c into a new networkstatus.c.  I\m not sure that I got everything that needed to move, but so far so good.


svn:r11791
 2007-10-08 21:21:50 +00:00
Nick Mathewson
13f7f98ad2 r14799@Kushana: nickm | 2007-10-08 15:55:18 -0400 
Add code to download router descriptors listed in a v3 networkstatus consensus.


svn:r11790
 2007-10-08 19:56:57 +00:00
Nick Mathewson
84d7677a8a r14770@Kushana: nickm | 2007-10-08 11:43:02 -0400 
Make router_digest_is_trusted_dir able to check for type.  When looking for a V3 directory, only assume that the V3 authorities and caches have it: previous code assumed that all authorities had it.


svn:r11789
 2007-10-08 17:44:19 +00:00
Nick Mathewson
3f6e3ce61b r14769@Kushana: nickm | 2007-10-07 14:00:17 -0400 
Fetch networkstatus consensus documents as needed.  Disabled for clients until more caches support it.


svn:r11788
 2007-10-08 17:44:09 +00:00
Nick Mathewson
6f7847b378 r15530@catbus: nickm | 2007-10-04 12:16:27 -0400 
Add a bunch of function documentation; clean up a little code; fix some XXXXs; tag the nonsensical EXTRAINFO_PURPOSE_GENERAL as nonsesnse; note another bit of "do not cache special routers" code to nuke.


svn:r11761
 2007-10-04 16:21:58 +00:00
Nick Mathewson
8439c4ec2f r15512@catbus: nickm | 2007-10-02 16:27:43 -0400 
Make some functions static; remove some dead code.


svn:r11750
 2007-10-02 20:35:23 +00:00
Nick Mathewson
f4f780b526 r15510@catbus: nickm | 2007-10-02 16:14:42 -0400 
Add support for more vote URLs that weasel wanted.  Weasel: please test this before I inflict it on anybody else. :)


svn:r11749
 2007-10-02 20:19:43 +00:00
Nick Mathewson
439fe55c6b r15436@catbus: nickm | 2007-10-01 21:17:27 -0400 
Fix disgusting O(n^2) behavior in router_parse_list_from_string.  Noticed by Li-Hui Zhou; found with oprofile.


svn:r11738
 2007-10-02 01:22:42 +00:00
Nick Mathewson
38ac9f6005 r14682@Kushana: nickm | 2007-09-28 15:23:38 -0400 
From little acorns: redo our string and digest hashing code to be faster, since this stuff may be critical-path.


svn:r11700
 2007-09-28 19:23:54 +00:00
Nick Mathewson
b5c8a8ae53 r15422@catbus: nickm | 2007-09-27 16:42:35 -0400 
Use descriptor annotations to record the source, download t time, and purpose of every descriptor we add to the store.  The remaining to-do item is to stop setting do_not_cache on bridges.


svn:r11680
 2007-09-27 20:46:30 +00:00
Nick Mathewson
2050b31bb9 r15421@catbus: nickm | 2007-09-27 15:44:17 -0400 
When we are a bridge directory, add bridges with purpose BRIDGE, not with purpose CONTROLLER.  Roger, is this right?


svn:r11679
 2007-09-27 20:46:28 +00:00
Nick Mathewson
60efd6b726 r15420@catbus: nickm | 2007-09-27 15:40:25 -0400 
Remove annotated_desc_store store (which we never used).  Instead, shift name of router store to cached-descriptors, but initialize it from cached-routers as needed


svn:r11678
 2007-09-27 20:46:24 +00:00
Nick Mathewson
a1c5a807d0 r15418@catbus: nickm | 2007-09-27 12:37:59 -0400 
Fix a stupid logic error in authority_cert_get_by_sk_digest: the presence of an authority lacking a v3 cert does not mean that subsequent authorities lack them too.


svn:r11668
 2007-09-27 16:41:42 +00:00
Nick Mathewson
28946069ee r15412@catbus: nickm | 2007-09-27 12:04:24 -0400 
More annotated-store work: handle annotations in lists correctly.  Add ability to prepend annotations to a routerdesc (and to every rtouredesc in a list), while verifying that the routerdesc is not already annotated.


svn:r11665
 2007-09-27 16:08:10 +00:00
Roger Dingledine
ea47287575 minor typo 
svn:r11658
 2007-09-27 05:20:26 +00:00
Nick Mathewson
034524f4b7 r15400@catbus: nickm | 2007-09-26 12:13:12 -0400 
Backend for descriptor annotations: parse annotations as keywords; only allow them to appear in the cache; do not serve them as part of the descriptor if we are a dirserver.  Still need mechanism to set annotations.  Still need to rename cache file.


svn:r11654
 2007-09-26 16:19:44 +00:00
Nick Mathewson
95d97c722a r15371@catbus: nickm | 2007-09-25 19:53:13 -0400 
Always set status_out when adding a vote.


svn:r11646
 2007-09-25 23:57:12 +00:00
Nick Mathewson
4d44bf1edc r15367@catbus: nickm | 2007-09-25 19:31:11 -0400 
It is amazing how reliable missing svk st are at breaking code.


svn:r11644
 2007-09-25 23:35:28 +00:00
Nick Mathewson
ad11e9d0f1 r15310@catbus: nickm | 2007-09-24 11:36:08 -0400 
Patch from Robert Hogan: fix a couple of status-event related typos. Backport candidate.


svn:r11604
 2007-09-24 15:41:20 +00:00
Nick Mathewson
3a3c1d1d1c r15280@catbus: nickm | 2007-09-22 02:02:00 -0400 
Bump version to 0.2.0.7-alpha-dev


svn:r11576
 2007-09-22 06:06:08 +00:00
Nick Mathewson
921f9f774d r15279@catbus: nickm | 2007-09-22 02:00:06 -0400 
V3 authority work: fetch missing votes and/or signatures as needed.


svn:r11575
 2007-09-22 06:06:05 +00:00
Roger Dingledine
991ebb42de bump to 0.2.0.7-alpha 
svn:r11572
 2007-09-22 00:05:56 +00:00
Roger Dingledine
b40230f45b note another bug i'd like to fix 
svn:r11571
 2007-09-22 00:05:46 +00:00
Roger Dingledine
523ac934de make directories_have_accepted_server_descriptor() able to 
handle non-default values of PublishServerDescriptor.


svn:r11569
 2007-09-21 22:14:39 +00:00
Roger Dingledine
41f3d0eb27 only mess with 'state' in init_keys if we're planning to actually 
run tor. this resolves a segfault in 'tor --list-fingerprints'
introduced by r11437.

backport candidate due to r11438.


svn:r11566
 2007-09-21 21:52:31 +00:00
Nick Mathewson
65cf389998 r15253@catbus: nickm | 2007-09-21 15:03:51 -0400 
Oops; we had vote_delay and dist_delay switched when computing when to generate our consensus.  Harmless so far, but let's get that fixed.


svn:r11558
 2007-09-21 19:11:52 +00:00
Roger Dingledine
193a144c9f Make "UpdateBridgesFromAuthority" torrc option work: when bridge 
users configure that and specify a bridge with an identity
fingerprint, now they will lookup the bridge descriptor at the
default bridge authority via a one-hop tunnel, but once circuits
are established they will switch to a three-hop tunnel for later
connections to the bridge authority.


svn:r11550
 2007-09-21 06:14:36 +00:00
Nick Mathewson
fdf390525c r15233@catbus: nickm | 2007-09-20 18:58:23 -0400 
19:00 < weasel> Sep 21 01:00:01.926 [warn] Consensus published.
 19:00 < weasel> hah
 19:00 < nickm> ha indeed
 19:00 < nickm> a winner is me
 19:00 < weasel> _warn_ :)
 19:01 < nickm> watch out! It could go off at any moment!
 19:01  * weasel backs away


svn:r11546
 2007-09-20 23:02:13 +00:00
Roger Dingledine
90d1345d90 bugfix on r11110: 
Fix a bug that made servers send a "404 Not found" in response to
attempts to fetch their server descriptor. This caused Tor servers
to take many minutes to establish reachability for their DirPort,
and it totally crippled bridges. Bugfix on 0.2.0.5-alpha.



svn:r11545
 2007-09-20 22:08:40 +00:00
Peter Palfrader
3b776b865e Minor whitespace fix 
svn:r11543
 2007-09-20 21:46:10 +00:00
Peter Palfrader
b16224c311 add a v3 authority 
svn:r11542
 2007-09-20 21:36:56 +00:00
Nick Mathewson
fc5dd0cdbb r15231@catbus: nickm | 2007-09-20 16:04:30 -0400 
Patch from karsten: remove cbc and make unit tests handle aes-ctr-with-iv.


svn:r11538
 2007-09-20 20:08:47 +00:00
Nick Mathewson
f0634bb7ca r14532@Kushana: nickm | 2007-09-20 13:25:38 -0400 
Clean up some macros in aes.c


svn:r11537
 2007-09-20 17:28:07 +00:00
Nick Mathewson
262d5ab0a8 r15210@catbus: nickm | 2007-09-20 13:04:05 -0400 
Re-optimize counter-mode: save about 15% on my core2 by (1) not regenerating the entire counter buffer every time we encrypt a block of keystream (2) using the platform-optimized htonl to convert to big-endian (It's a single instruction on 486 and later ) and (3) not even keeping a separate "counter" and "buffer" when the platform is big-endian. The third still needs testing.


svn:r11536
 2007-09-20 17:07:45 +00:00
Roger Dingledine
088c4cd8ce it works better when it compiles 
svn:r11531
 2007-09-20 04:54:50 +00:00
Roger Dingledine
0914883339 Resume listing "AUTHORITY" flag for authorities in network status. 
Bugfix on 0.2.0.3-alpha; reported by Alex de Joode.


svn:r11530
 2007-09-20 04:37:17 +00:00
Roger Dingledine
d4e950ccc8 poke at svn until it compiles. nick, you should decide if this 
is what you meant to do.


svn:r11529
 2007-09-20 03:06:45 +00:00
Nick Mathewson
5f7950e874 r15172@catbus: nickm | 2007-09-19 11:50:02 -0400 
New (untested) code to implement AES-with-IV.  Currently, IVs are generated randomly.  Once tested, should be (almost) a drop-in replacement for the CBC functions.


svn:r11519
 2007-09-19 15:53:41 +00:00
Nick Mathewson
7e93139a85 r15171@catbus: nickm | 2007-09-19 11:44:54 -0400 
Switch our AES implementation from "128 bit counter with to 64 bits set to 0" to a proper implementation of counter mode.  Also, add an aes_set_iv function to initialize the counter to a nonzero value.


svn:r11518
 2007-09-19 15:53:38 +00:00
Nick Mathewson
5e81b0ecb8 r15170@catbus: nickm | 2007-09-19 11:41:50 -0400 
Carry a new evdns function over from libevent: do not rely on compile-time code to set the transaction ID correctly.  This will be important when we finally drop our internal copy of eventdns.c


svn:r11517
 2007-09-19 15:53:36 +00:00
Nick Mathewson
faeedbb8af r15167@catbus: nickm | 2007-09-19 11:19:08 -0400 
Fix unit tests for rendezvous descriptor parsing.


svn:r11516
 2007-09-19 15:53:33 +00:00
Roger Dingledine
53f57dd7c0 Set up moria1 as the first v3 directory authority. 
svn:r11506
 2007-09-19 03:22:01 +00:00
Roger Dingledine
a1e923c50d right before publishing our service descriptor, we were 
rewriting the hexdigest back to an ambiguous nickname.
if this patches it, we should write a changelog and then
backport.


svn:r11500
 2007-09-19 00:30:19 +00:00
Roger Dingledine
2a2cee9e51 Start using the v2 intro format for hidden service connections. Now 
clients specify their chosen rendezvous point by identity digest
rather than by (potentially ambiguous) nickname. This change could
speed up hidden service connections dramatically.


svn:r11499
 2007-09-18 23:48:39 +00:00
Roger Dingledine
82da6c02ba clean up r11496 
svn:r11498
 2007-09-18 23:34:27 +00:00
Roger Dingledine
eb9dc12ce9 Drop support for v1 rendezvous descriptors, since we never used 
them anyway, and the code has probably rotted by now. Based on
patch from Karsten Loesing.


svn:r11496
 2007-09-18 21:17:45 +00:00
Roger Dingledine
1a930cfc70 minor style tweaks 
svn:r11490
 2007-09-18 17:18:14 +00:00
Roger Dingledine
f15a4c8bd7 add some crypto/util functions from karsten, as the first 
step of integrating his new hidden service stuff


svn:r11489
 2007-09-18 17:07:56 +00:00
Nick Mathewson
f45dec1690 r15143@catbus: nickm | 2007-09-18 11:49:46 -0400 
Add getinfo status/good-server-descriptor and status/reachability-succeeded. Patch from Robert Hogan.


svn:r11483
 2007-09-18 15:53:55 +00:00
Nick Mathewson
a2b76befff r15142@catbus: nickm | 2007-09-18 11:43:32 -0400 
Split "Have all the authorities accepted our server descriptor?" into its own function.  Patch from Robert Hogan.


svn:r11482
 2007-09-18 15:53:53 +00:00
Nick Mathewson
eee8d750b6 r15140@catbus: nickm | 2007-09-18 11:34:54 -0400 
Get rid of a needless malloc() when parsing address policies.  Original patch from "Some guy on #tor", via arma.  Altered to have a sufficiently large buffer, and not use the buffer so much, and to save a strlcpy.


svn:r11480
 2007-09-18 15:38:00 +00:00
Roger Dingledine
8f75defd33 Servers used to decline to publish their DirPort if their 
BandwidthRate, RelayBandwidthRate, or MaxAdvertisedBandwidth
were below a threshold. Now they only look at BandwidthRate and
RelayBandwidthRate.


svn:r11465
 2007-09-17 22:22:05 +00:00
Roger Dingledine
ffce9d3368 trivial doxygen thing 
svn:r11463
 2007-09-17 21:59:07 +00:00
Nick Mathewson
8c13967803 r14448@Kushana: nickm | 2007-09-17 14:26:56 -0400 
Unify all of the divergent median/nth-percentile code in container.[ch]


svn:r11457
 2007-09-17 18:27:49 +00:00
Nick Mathewson
93d4ad9743 r14447@Kushana: nickm | 2007-09-17 13:31:50 -0400 
Track weighted fractional uptime in addition to weighted mtbf: we want to use mtbf for stable, but fractional uptime for guard.


svn:r11456
 2007-09-17 18:27:43 +00:00
Nick Mathewson
076b27aff8 r15077@catbus: nickm | 2007-09-15 14:04:19 -0400 
Oops; make Makefile.am work on mingw again.


svn:r11445
 2007-09-15 18:06:23 +00:00
Nick Mathewson
1dbe726f04 r15068@catbus: nickm | 2007-09-14 15:25:02 -0400 
Fix a couple typos in control.c; spotted by Robert Hogan.


svn:r11440
 2007-09-14 19:27:04 +00:00
Nick Mathewson
5fcc48d389 r14425@Kushana: nickm | 2007-09-13 13:00:57 -0400 
Do not load state when options->command is not RUN_TOR. (Resolves bug 499; backport candidate)


svn:r11437
 2007-09-13 17:01:08 +00:00
Nick Mathewson
9b1ad0074b r14392@Kushana: nickm | 2007-09-12 11:04:20 -0400 
Complete implementation of proposal 104: remove bandwidth history lines from router descriptors.


svn:r11434
 2007-09-12 17:33:23 +00:00
Nick Mathewson
71a56aa895 r14391@Kushana: nickm | 2007-09-12 10:56:17 -0400 
Remove some needless complexity from the code to add signatures to a consensus: previously, we had a path to add new signatures, and a second path to replace signatures.  But the second path sufficed as a common case, and the code isn't invoked nearly enough to justify the optimization of having the first path.


svn:r11433
 2007-09-12 17:33:18 +00:00
Nick Mathewson
1647a5764a r15056@catbus: nickm | 2007-09-12 13:15:19 -0400 
Try to fix an automake problem by renaming a variable.


svn:r11432
 2007-09-12 17:17:03 +00:00
Nick Mathewson
e73fb2f102 r15049@catbus: nickm | 2007-09-11 16:05:50 -0400 
When we get a consensus for which we are missing the right certificates, keep it around pending more certificates; do not just drop it.


svn:r11430
 2007-09-11 20:17:28 +00:00
Nick Mathewson
4de4f53abd r15048@catbus: nickm | 2007-09-11 14:20:39 -0400 
Add code to warn about mauthorities on a consensus when they are not what we expect to find.


svn:r11429
 2007-09-11 20:17:25 +00:00
Nick Mathewson
749da8e0e9 r15047@catbus: nickm | 2007-09-11 13:40:54 -0400 
Fix a memory leak when reloading v3 authority certificate and keys.


svn:r11428
 2007-09-11 20:17:24 +00:00
Nick Mathewson
973502d290 r15046@catbus: nickm | 2007-09-11 13:38:36 -0400 
Check V3 authority certificates for expiry, and warn the authority op as they get old.


svn:r11427
 2007-09-11 20:17:22 +00:00
Nick Mathewson
3c7652ccdb r15045@catbus: nickm | 2007-09-11 11:52:29 -0400 
Reject incoming votes when the valid-after time does not match the period that we're trying to vote for.


svn:r11426
 2007-09-11 20:17:20 +00:00
Nick Mathewson
c0130f9611 r15022@catbus: nickm | 2007-09-10 10:31:54 -0400 
remove yet more pointless differences between our eventdns.c and the evdns.c in libevent.


svn:r11425
 2007-09-11 20:17:18 +00:00
Nick Mathewson
5828e4d5c4 r15020@catbus: nickm | 2007-09-10 10:22:31 -0400 
remove more pointless differences between our eventdns.c and the evdns.c in libevent.


svn:r11416
 2007-09-10 14:23:26 +00:00
Nick Mathewson
13b65c4129 r15018@catbus: nickm | 2007-09-10 10:04:16 -0400 
Change comments in eventdns.c to C-style, so we can more easily diff it against the version in libevent to reconcile them (again).


svn:r11415
 2007-09-10 14:05:12 +00:00
Nick Mathewson
a04e584cbc r15005@catbus: nickm | 2007-09-10 09:49:03 -0400 
Undo brokenness from merge conflict.


svn:r11414
 2007-09-10 13:50:00 +00:00
Nick Mathewson
615d19fe4c r15001@catbus: nickm | 2007-09-10 09:44:49 -0400 
Fix a couple of memory leaks in eventdns.c; found by niels.  Not backport candidates, since they only affect DNSPort users.


svn:r11413
 2007-09-10 13:48:01 +00:00
Nick Mathewson
6744ebe7b5 svn:r11412 2007-09-10 13:47:56 +00:00
Nick Mathewson
565f5f32c5 r14363@Kushana: nickm | 2007-09-08 16:25:45 -0400 
Another round of whitespeace fixes.


svn:r11407
 2007-09-08 20:25:57 +00:00
Nick Mathewson
509bc3b4a0 r14359@Kushana: nickm | 2007-09-08 15:07:17 -0400 
Add some generic skew-and-tolerance functions so we can handle time more sanely.


svn:r11406
 2007-09-08 19:08:46 +00:00
Nick Mathewson
eb3f24f027 r14358@Kushana: nickm | 2007-09-08 13:45:16 -0400 
Implement certificate fetch functions.


svn:r11405
 2007-09-08 19:08:39 +00:00
Nick Mathewson
1c8bd05c70 Fix compilation of ntmain.c. 
svn:r11395
 2007-09-06 18:19:09 +00:00
Nick Mathewson
4c4280e249 Make sure that even dumb compilers can tell that bad_cookie and bad_password are set before use. 
svn:r11390
 2007-09-06 18:04:28 +00:00
Nick Mathewson
f17a38ab04 r14940@catbus: nickm | 2007-09-06 13:22:26 -0400 
Move NT services code into its own C file.  Probably will not build happily on win32 yet; more hacking needed.


svn:r11388
 2007-09-06 17:42:05 +00:00
Andrew Lewman
c5b4f779ec Fixed misspelling of "connection" caught by kate. 
svn:r11382
 2007-09-06 00:36:53 +00:00
Nick Mathewson
d57c1c5c56 r14328@Kushana: nickm | 2007-09-04 20:17:34 -0400 
There is no good reason to make hashedcontrolpassword and cookieauthentication mutually exclusive.  So let's not.


svn:r11377
 2007-09-05 00:31:07 +00:00
Nick Mathewson
7c47856c9e r14327@Kushana: nickm | 2007-09-04 20:06:04 -0400 
Better comment in dnsserv.c


svn:r11376
 2007-09-05 00:31:01 +00:00
Nick Mathewson
6ba66c2f42 r14323@kushana: nickm | 2007-09-04 14:27:33 -0400 
Patch from sjmurdoch to fix dnsleak warning when reverse-resolving via socks5.


svn:r11373
 2007-09-04 18:27:40 +00:00
Nick Mathewson
eca3634f62 r14294@Kushana: nickm | 2007-09-01 13:50:03 -0400 
Oops. Initialize "changed" variable when removing obsolete guards.


svn:r11346
 2007-09-01 17:50:29 +00:00
Nick Mathewson
c967fae598 r14880@catbus: nickm | 2007-08-31 11:06:10 -0400 
Refactor store_stats_t to hold a pointer to the proper mmap, and turn it into a full-fledged type.  This sets stuff up nicely for adding a separate "annotated" store.  Add some XXXX NM items that need to be fixed when annotated stores exist


svn:r11338
 2007-08-31 15:08:37 +00:00
Nick Mathewson
2ff871e530 r14871@catbus: nickm | 2007-08-31 10:12:53 -0400 
Check correct circuit type when calling functions from rend_process_relay_cell. Backport candidate.


svn:r11336
 2007-08-31 14:20:44 +00:00
Nick Mathewson
c341bc090e r14869@catbus: nickm | 2007-08-31 08:49:26 -0400 
Fix a segfault in expand_filename("~").  Found by lindi.


svn:r11332
 2007-08-31 12:51:52 +00:00
Nick Mathewson
5da6321b76 r14859@catbus: nickm | 2007-08-30 17:10:15 -0400 
0-pad minutes and seconds when displaying weighted mtbf in info logs.


svn:r11324
 2007-08-30 21:12:34 +00:00
Nick Mathewson
c8e379a4cd r14259@Kushana: nickm | 2007-08-30 02:33:55 -0400 
Teach tor about more libevent versions.  Be more clear that "Known bugs" means "it will crash or something."  Most significantly, stop issuing dire warnings every time we run with kqueue on os x: it seems to have worked for a while now.


svn:r11314
 2007-08-30 06:34:17 +00:00
Nick Mathewson
f189ecbf20 r14832@catbus: nickm | 2007-08-29 15:00:27 -0400 
Use (and debug) new file-writing functions in order to simplify code that formerly built big strings in RAM.


svn:r11301
 2007-08-29 19:02:43 +00:00
Nick Mathewson
8408122222 r14831@catbus: nickm | 2007-08-29 14:17:42 -0400 
Refactor write_chunks_to_file_impl: break out the "pick a temporary name if it makes sense, and open the right filename" logic and the "close the file and unlink or rename if necessary" logic.  This will let us write big files in a smarter way than "Build a big string" or "make a list of chunks", once we get around to using it.


svn:r11300
 2007-08-29 19:02:37 +00:00
Nick Mathewson
91f83cfc2d r14830@catbus: nickm | 2007-08-29 13:50:10 -0400 
Make controllers accept LF as well as CRLF.  Update spec to reflect this.  Remove now-dead code.  Make controller warning about v0 protocol more accurate.


svn:r11299
 2007-08-29 19:02:33 +00:00
Nick Mathewson
4266039c19 r14826@catbus: nickm | 2007-08-29 13:19:55 -0400 
Add a line to the state file for each guard to let us know which version added the guard.  If the line is absent, assume the guard was added by whatever version of Tor last wrote the state file.  Remove guards if the version that added them was using a bad guard selection algorithm.  (Previously, we removed guards if the version that wrote the file was using a bad guard selection algorithm, even if the guards themselves were chosen by a good version.) 


svn:r11298
 2007-08-29 17:22:00 +00:00
Nick Mathewson
a4cc3e4be1 r14821@catbus: nickm | 2007-08-27 19:57:56 -0400 
Check for absent nickname when making extend info.  I still dont know when this happens, but it is easy enough to check for.  Fixes bug 467.


svn:r11293
 2007-08-28 00:00:32 +00:00
Nick Mathewson
7cbe302b3f r14231@Kushana: nickm | 2007-08-27 14:56:14 -0400 
Most configuration options have the same names in or.h and in torrc.  Make the macros reflect this, so that it is easier to fit them onto a line, and so that mismatched options stand out more


svn:r11290
 2007-08-27 18:56:20 +00:00
Nick Mathewson
d3224bad42 r14227@Kushana: nickm | 2007-08-27 11:33:28 -0400 
Add a new ClientDNSRejectInternalAddresses option (default: on) to refuse to believe that any address can map to or from an internal address.  This blocks some kinds of potential browser-based attacks, especially on hosts using DNSPort.  Also clarify behavior in some comments.  Backport candiate?


svn:r11287
 2007-08-27 15:33:58 +00:00
Roger Dingledine
24462ff211 bump to 0.2.0.6-alpha-dev so we're ready to fix more bugs :) 
svn:r11281
 2007-08-27 03:47:36 +00:00
Roger Dingledine
c4ee55ed26 Set up Tonga as the default bridge directory authority. 
svn:r11276
 2007-08-25 22:02:55 +00:00
Roger Dingledine
45bc168b53 bump to 0.2.0.6-alpha in preparation for tomorrow's release 
svn:r11275
 2007-08-25 21:59:14 +00:00
Roger Dingledine
da1485088c formatting cleanups 
svn:r11273
 2007-08-25 21:31:34 +00:00
Roger Dingledine
df98447be5 revert the recommended-guard-version thing. it did not do what we 
want, which is to expire old guards *every* time somebody moves
from an old version to the new one.

also, refine which version numbers count as 'new enough'.


svn:r11272
 2007-08-25 20:34:13 +00:00
Nick Mathewson
7efc165095 r14204@Kushana: nickm | 2007-08-24 10:24:36 -0400 
Fix a bug in last patch; add support for getting extrainfo documents by the control port (since it is silly to tell tools to do it without actually giving them an interface).


svn:r11270
 2007-08-24 14:41:15 +00:00
Nick Mathewson
b9d43e2685 r14203@Kushana: nickm | 2007-08-24 10:15:58 -0400 
Add a hacked-up GETINFO desc/all-recent-extrainfo-hack so that torstat can keep working with a minimum of fuss, until it learns about extrainfo documents.


svn:r11269
 2007-08-24 14:41:10 +00:00
Nick Mathewson
cf2ac9b9e1 r14202@Kushana: nickm | 2007-08-24 09:55:30 -0400 
Add purposes for new things we need to fetch for v3 directory system.


svn:r11268
 2007-08-24 14:41:06 +00:00
Nick Mathewson
c3805e753a r14200@kushana: nickm | 2007-08-24 08:33:41 -0400 
In new code, let's try to prefer named flags to mazes of twisted boolean arguments, all alike.


svn:r11267
 2007-08-24 12:33:53 +00:00
Roger Dingledine
daece599a1 more cleanups on r11258. looks good now. 
svn:r11266
 2007-08-24 10:50:48 +00:00
Roger Dingledine
738ecba367 make the last patch do what i actually want. it was a bit tricky 
since we want the default guardversion to be 0 (which is what it is
if there's no guardversion line), yet when we're validating a freshly
configed and defaulted state, we don't want to complain.


svn:r11264
 2007-08-24 08:12:25 +00:00
Roger Dingledine
9bacf68851 cleanups on r11258 
svn:r11263
 2007-08-24 08:01:47 +00:00
Roger Dingledine
d39c7515d1 patch from mike perry to a) stop overloading guards as much, and 
b) raise the max-believable-bandwidth to 10MB/s.


svn:r11258
 2007-08-24 06:30:34 +00:00
Roger Dingledine
8d524edb83 a single quote != a single double quote. i can't hear the 
circus music from here, perhaps we should move closer.


svn:r11256
 2007-08-23 23:03:32 +00:00
Nick Mathewson
c65131b171 r14185@Kushana: nickm | 2007-08-22 11:07:01 -0400 
Add some voting-related documentation.


svn:r11255
 2007-08-22 15:07:44 +00:00
Nick Mathewson
08e605b4e2 r14184@Kushana: nickm | 2007-08-22 11:06:37 -0400 
Unmap cached-extrainfo on exit. Fixes bug 484.


svn:r11254
 2007-08-22 15:07:29 +00:00
Roger Dingledine
c02fb8997b backport candidate: 
Make it possible to read the PROTOCOLINFO response in a way that
conforms to our control-spec. Reported by Matt Edman.


svn:r11251
 2007-08-22 07:57:10 +00:00
Roger Dingledine
353abd9830 backport candidate: 
Stop leaking part of the descriptor when we run into a particularly
unparseable piece of it. Bugfix on 0.1.2.x.


svn:r11249
 2007-08-22 03:21:51 +00:00
Roger Dingledine
79066b4851 backport candidate: 
Fix a minor memory leak when we fail to find enough suitable
servers to choose a circuit. Bugfix on 0.1.2.x.


svn:r11247
 2007-08-22 03:03:24 +00:00
Nick Mathewson
7dbe7fd4d8 r14758@catbus: nickm | 2007-08-21 01:36:03 -0400 
Finish implementing and documenting proposal 108: Authorities now use MTBF data to set their stability flags, once they have at least 4 days of data to use.


svn:r11240
 2007-08-21 05:37:24 +00:00
Roger Dingledine
8a21232256 Stop putting the authentication cookie in a file called "0" 
in your working directory if you don't specify anything for the
new CookieAuthFile option. Reported by Matt Edman.


svn:r11237
 2007-08-21 03:11:56 +00:00
Peter Palfrader
c7140372cb It works better if we don't print a 404 header after our body 
svn:r11236
 2007-08-20 22:40:09 +00:00
Peter Palfrader
6802923fa7 call it EXPORTMALLINFO, not EXPORTMEMINFO 
svn:r11235
 2007-08-20 22:31:39 +00:00
Peter Palfrader
8aceafc0c8 Appease check-spaces 
svn:r11234
 2007-08-20 22:23:22 +00:00
Peter Palfrader
38cbd7263e We do not mix variable declarations and code 
svn:r11233
 2007-08-20 22:13:14 +00:00
Peter Palfrader
8c3d14cda5 Optionally export mallinfo() output on the DirPort 
svn:r11232
 2007-08-20 22:11:56 +00:00
Peter Palfrader
f99ac7fe52 Remove /tor/dir-all-weaselhack, it's useless without FULL_V1_DIRECTORIES defined 
svn:r11231
 2007-08-20 21:56:33 +00:00
Roger Dingledine
05f12bffe9 Handle unexpected whitespace better in malformed descriptors. Bug 
found using Benedikt Boss's new Tor fuzzer! Bugfix on 0.2.0.x.


svn:r11229
 2007-08-20 20:05:56 +00:00
Roger Dingledine
4ff3343e98 Let directory authorities startup even when they can't generate 
a descriptor immediately, e.g. because they don't know their 
address.


svn:r11228
 2007-08-20 18:29:17 +00:00
Nick Mathewson
df0a141a27 r14740@catbus: nickm | 2007-08-20 13:00:52 -0400 
Only load MTBF data if we are running tor


svn:r11226
 2007-08-20 17:02:04 +00:00
Nick Mathewson
3effc8b267 r14733@catbus: nickm | 2007-08-20 12:32:44 -0400 
Clean up MTBF storage code. Do not count times that we have been down toward the current run.  Handle backward timewarps correctly.  Store MTBF data on exit in addition to periodically.


svn:r11225
 2007-08-20 16:34:17 +00:00
Roger Dingledine
a200f442fb avoid double-punctuation when we're reporting errors from the 
config functions to the controller.


svn:r11221
 2007-08-20 16:13:21 +00:00
Nick Mathewson
76d40372fc r14731@catbus: nickm | 2007-08-20 12:02:09 -0400 
Clean up authdir_X functions a little.


svn:r11220
 2007-08-20 16:03:19 +00:00
Nick Mathewson
9958dc8d53 r14729@catbus: nickm | 2007-08-20 11:58:02 -0400 
Trigger load and save of MTBF data.


svn:r11219
 2007-08-20 15:59:31 +00:00
Nick Mathewson
d3b019a1df r14726@catbus: nickm | 2007-08-20 11:42:07 -0400 
Make v3-only authorities check reachability


svn:r11218
 2007-08-20 15:43:17 +00:00
Nick Mathewson
113367bc01 r14722@catbus: nickm | 2007-08-20 10:54:29 -0400 
Add debugging warning to not abort in the case of bug 483.  This is probably not an actual error case, so we should figure out what is really causing it and do something more sensible.


svn:r11215
 2007-08-20 14:59:05 +00:00
Nick Mathewson
c7ed49e7f8 r14663@catbus: nickm | 2007-08-18 17:50:51 -0400 
Fix an XXX020 in or.h: BRIDGE != CONTROLLER.


svn:r11195
 2007-08-19 15:20:11 +00:00
Roger Dingledine
473ff753f2 bump to 0.2.0.5-alpha since we're getting close 
svn:r11189
 2007-08-19 07:30:29 +00:00
Roger Dingledine
8641439a6e backport candidate (revert part of r9350): 
Expire application streams in all cases if they've been around
longer than SocksTimeout. Right now there are some cases where the
stream will live forever, demanding a new circuit every 15 seconds.
Bugfix on 0.1.2.7-alpha; fixes bug 454; reported by lodger.


svn:r11186
 2007-08-19 07:17:40 +00:00
Roger Dingledine
d6aa617e07 oh, and make it compile too 
svn:r11185
 2007-08-19 07:06:02 +00:00
Roger Dingledine
03560d575e generalize circuit_find_to_cannibalize() so it knows what 
purpose circuit we're planning to become


svn:r11184
 2007-08-19 07:04:24 +00:00
Roger Dingledine
c88803d924 Fix a bug in ADDRMAP controller replies that would sometimes 
try to print a NULL. Patch from tup.


svn:r11181
 2007-08-19 04:58:55 +00:00
Roger Dingledine
7c49a8d03e get rid of a debugging message that non v3-authorities were 
seeing too, and that doesn't seem to be critical


svn:r11179
 2007-08-19 04:28:56 +00:00
Andrew Lewman
b7026ea1b3 Move event.h include down a stanza to make mingw happy. 
svn:r11174
 2007-08-19 02:56:16 +00:00
Roger Dingledine
96cff65f85 backport candidate: 
Refuse to start with certain directory authority keys, and 
encourage people using them to stop.


svn:r11171
 2007-08-19 02:51:54 +00:00
Roger Dingledine
75bd472869 do another cleanup pass on the sample torrc 
svn:r11168
 2007-08-19 00:59:04 +00:00
Nick Mathewson
b45b91a358 r14661@catbus: nickm | 2007-08-18 15:38:08 -0400 
Long overdue test.c refactoring: add --warn/--notice/--info/--debug command line options to set logging levels, and let the user specify which tests to run from the commmand line.


svn:r11167
 2007-08-18 19:39:14 +00:00
Nick Mathewson
676d8622de r14659@catbus: nickm | 2007-08-18 14:19:34 -0400 
When we are loading state info from disk, never believe any date in the future.  Doing so can keep us from retrying guards, rotating onion keys, storing bandwidth info, etc.  Fixes bug 434, and others. Backport candidate, once it has been tested.


svn:r11166
 2007-08-18 18:20:42 +00:00
Nick Mathewson
a237f25f9a r14651@catbus: nickm | 2007-08-17 21:37:03 -0400 
Another attempt to confirm to msvc for bug 482.


svn:r11162
 2007-08-18 01:38:11 +00:00
Peter Palfrader
50c0e6b37f Remove routerlist_check_bug_417() and all its calls. There is still some more debugging code left, marked with XXXs 
svn:r11161
 2007-08-17 22:55:04 +00:00
Peter Palfrader
0713606469 redefine BITARRAY_MASK as a function of BITARRAY_SHIFT 
svn:r11160
 2007-08-17 22:43:00 +00:00
Nick Mathewson
1f244d3943 r14639@catbus: nickm | 2007-08-17 17:45:28 -0400 
Compile without warnings on MinGW, even with --enable-gcc-warnings enabled.


svn:r11157
 2007-08-17 21:46:34 +00:00
Nick Mathewson
f8b3927e07 r14634@catbus: nickm | 2007-08-17 16:43:49 -0400 
Try to fix bug 482: do not rely on s6_addr16 or s6_addr32 on MSVC.  How ugly.


svn:r11155
 2007-08-17 20:44:54 +00:00
Nick Mathewson
b34ed73706 r14630@catbus: nickm | 2007-08-17 16:30:42 -0400 
Functions to save and load MTBF information.


svn:r11153
 2007-08-17 20:31:59 +00:00
Nick Mathewson
31668172ed r14626@catbus: nickm | 2007-08-17 11:20:05 -0400 
Link note_router_reachable and note_router_unreachable to  mtbf code. decouple mtbf from connect/disconnect.  log it in USR1.  do not blow it away on cleanup if we are an authority.


svn:r11151
 2007-08-17 20:31:54 +00:00
Roger Dingledine
3f186e6510 help nick work on proposal 108 
svn:r11148
 2007-08-17 01:29:58 +00:00
Nick Mathewson
357b4645cf r14612@catbus: nickm | 2007-08-16 15:23:35 -0400 
Initial work on proposal 108: have rephist.c track the information we want to be tracking for OR stability.


svn:r11147
 2007-08-16 19:32:29 +00:00
Roger Dingledine
2df9bb937d clean up the cookieauth stuff 
svn:r11146
 2007-08-16 19:27:31 +00:00
Nick Mathewson
718953dbe9 r14606@catbus: nickm | 2007-08-16 13:45:01 -0400 
Implement CookieAuthFile and CookieAuthFileGroupReadable.  Backport candidate.


svn:r11141
 2007-08-16 17:46:01 +00:00
Nick Mathewson
f4398feadb r14600@catbus: nickm | 2007-08-16 13:30:22 -0400 
Implement proposal 119. Backport candidate.


svn:r11138
 2007-08-16 17:31:23 +00:00
Nick Mathewson
3623a12262 r14583@catbus: nickm | 2007-08-15 17:52:35 -0400 
Fix a bug caught by Kate: when we switched from masks to bits in 0.2.0.3-alpha, we added a spurious ! that made us never believe that any address fell inside a virtual address range.  While we're at it, save a trip around the loop in the common case.


svn:r11129
 2007-08-15 21:53:34 +00:00
Nick Mathewson
181ba71a90 r14051@Kushana: nickm | 2007-08-15 15:55:36 -0400 
Fix an XXXX020 and a few DOCDOCs.


svn:r11127
 2007-08-15 19:56:01 +00:00
Nick Mathewson
abad4dfc7a r14050@Kushana: nickm | 2007-08-15 15:21:02 -0400 
Eliminate tons of repeated code in directory_handle_command_get.


svn:r11126
 2007-08-15 19:55:57 +00:00
Nick Mathewson
4135c68853 r14049@Kushana: nickm | 2007-08-15 14:43:56 -0400 
Implement code to serve pending votes, consensuses, and signatures.


svn:r11125
 2007-08-15 19:55:52 +00:00
Nick Mathewson
717f3b8a12 r14047@Kushana: nickm | 2007-08-15 13:57:39 -0400 
fix a really nasty bug in v3 authorities: only set v3_digest in trusted_dir_server_t for v3 authorities.


svn:r11124
 2007-08-15 17:57:47 +00:00
Nick Mathewson
e10041447c r14045@Kushana: nickm | 2007-08-15 13:07:21 -0400 
Add more logs to try to hunt down latest voting bug.


svn:r11123
 2007-08-15 17:07:27 +00:00
Nick Mathewson
38b84d9659 r14043@Kushana: nickm | 2007-08-15 12:12:25 -0400 
Fix consensus signatures: regenerate the entire signature list when we get a new signature, rather than just appending the new signature.  This lets us tentatively accept weird signatures, since we can replace them with better ones later.


svn:r11122
 2007-08-15 16:12:40 +00:00
Nick Mathewson
d5bd7d9fa3 r14032@Kushana: nickm | 2007-08-15 11:35:16 -0400 
Add unit tests for median functions; enforce sensible ranges for intervals and delays.


svn:r11121
 2007-08-15 15:38:58 +00:00
Nick Mathewson
60c2e9d99e r14031@Kushana: nickm | 2007-08-15 11:34:26 -0400 
Fix a segfault in cert retrieval


svn:r11120
 2007-08-15 15:38:53 +00:00
Roger Dingledine
7e5cee8110 this does not actually change anything (i hope), but it makes me a lot 
more comfortable.
nick, can you confirm this?


svn:r11119
 2007-08-15 15:36:34 +00:00
Roger Dingledine
f606d74f56 backport candidate: 
- If we require CookieAuthentication but we fail to write the
  cookie file, we would warn but not exit, and end up in a state
  where no controller could authenticate. Now we exit.
- If we require CookieAuthentication, stop generating a new cookie
  every time we change any piece of our config.


svn:r11117
 2007-08-15 15:26:14 +00:00
Nick Mathewson
484a580698 r14028@Kushana: nickm | 2007-08-14 17:07:51 -0400 
Implement cert-retrieval URLs. (Also, update TODO)


svn:r11112
 2007-08-14 21:09:30 +00:00
Nick Mathewson
486166f9a8 r14020@Kushana: nickm | 2007-08-14 16:07:37 -0400 
return 404 properly when somebody requests a bunch of nonexistent statuses/servers


svn:r11110
 2007-08-14 20:19:58 +00:00
Nick Mathewson
3923eff1e6 r14019@Kushana: nickm | 2007-08-14 15:40:05 -0400 
Save a 4 or 8 bytes per connection in or.h


svn:r11109
 2007-08-14 20:19:51 +00:00
Nick Mathewson
2a31f09af6 r14018@Kushana: nickm | 2007-08-14 15:39:35 -0400 
Resolve XXXX020s in config.c


svn:r11108
 2007-08-14 20:19:46 +00:00
Nick Mathewson
42fa1de585 r14017@Kushana: nickm | 2007-08-14 15:13:14 -0400 
Enable more code for v3 voting timing information.  Also, spec clarification.


svn:r11107
 2007-08-14 20:19:40 +00:00
Nick Mathewson
25d2901857 r14015@Kushana: nickm | 2007-08-14 12:39:04 -0400 
Try to avoid adding duplicate signatures to a consensus.


svn:r11105
 2007-08-14 16:39:18 +00:00
Nick Mathewson
925394022a r14011@Kushana: nickm | 2007-08-14 10:29:49 -0400 
Actually upload signatures when we vote. log more about the signatures we get.  discard pending vote stuff after we publish.


svn:r11104
 2007-08-14 14:30:45 +00:00
Nick Mathewson
944bc41f99 r14010@Kushana: nickm | 2007-08-14 10:20:28 -0400 
Fix a URL in voting


svn:r11103
 2007-08-14 14:30:33 +00:00
Nick Mathewson
3399d63170 r14009@Kushana: nickm | 2007-08-14 10:20:20 -0400 
Fix a logic error in certificate handling


svn:r11102
 2007-08-14 14:30:25 +00:00
Nick Mathewson
817ed1ccbf r14006@kushana: nickm | 2007-08-14 09:34:28 -0400 
re-enable version checking


svn:r11101
 2007-08-14 13:34:41 +00:00
Nick Mathewson
3268ab58f2 r14005@kushana: nickm | 2007-08-14 09:34:19 -0400 
add a warning to find a bug (maybe)


svn:r11100
 2007-08-14 13:34:35 +00:00
Nick Mathewson
cd5eaf53f9 r14003@kushana: nickm | 2007-08-13 22:23:49 -0400 
Resolve a pile of XXXXs in and around voting code


svn:r11099
 2007-08-14 02:23:57 +00:00
Nick Mathewson
7113ab8f90 r14001@kushana: nickm | 2007-08-13 20:06:36 -0400 
Check for *at least* as many signatures as required, not for *more* signatures than required.


svn:r11098
 2007-08-14 00:07:29 +00:00
Nick Mathewson
b6c548094c r13998@kushana: nickm | 2007-08-13 19:20:28 -0400 
Add some insanely verbose log messages on voting authorities.


svn:r11097
 2007-08-13 23:23:06 +00:00
Nick Mathewson
a1ce60f9a6 r14546@catbus: nickm | 2007-08-13 17:19:01 -0400 
Make if-modified-since work on consensuses


svn:r11095
 2007-08-13 21:19:54 +00:00
Nick Mathewson
9356a0b1dd r14544@catbus: nickm | 2007-08-13 17:00:09 -0400 
Give a 200 when a duplicate vote gets uploaded.


svn:r11094
 2007-08-13 21:01:02 +00:00
Nick Mathewson
7d990b5aa1 r13992@Kushana: nickm | 2007-08-13 16:45:22 -0400 
A vote we already have a nd a double-upload are different things.


svn:r11093
 2007-08-13 20:45:36 +00:00
Nick Mathewson
b4adf151d2 r13991@Kushana: nickm | 2007-08-13 16:37:43 -0400 
Do not warn on missing cached consensus.


svn:r11092
 2007-08-13 20:45:27 +00:00
Nick Mathewson
4e4dcb2571 r13989@Kushana: nickm | 2007-08-13 16:31:03 -0400 
Actually store the v3 authority id digest of a trusteddirserver


svn:r11091
 2007-08-13 20:31:08 +00:00
Nick Mathewson
94c90c42e3 r13987@Kushana: nickm | 2007-08-13 16:17:09 -0400 
Stop segfaulting on failed consensus.


svn:r11090
 2007-08-13 20:17:14 +00:00
Nick Mathewson
936edd901d r13985@Kushana: nickm | 2007-08-13 16:05:07 -0400 
Fix some simple logic errors in voting.


svn:r11089
 2007-08-13 20:05:25 +00:00
Nick Mathewson
2d07cce67f r14536@catbus: nickm | 2007-08-13 15:54:17 -0400 
Make voting actually function.


svn:r11088
 2007-08-13 19:55:08 +00:00
Nick Mathewson
89c65f2a4e r14534@catbus: nickm | 2007-08-13 15:15:46 -0400 
Read v3 keys from the right location


svn:r11087
 2007-08-13 19:16:44 +00:00
Nick Mathewson
ce1f01c3e6 r14531@catbus: nickm | 2007-08-13 14:46:25 -0400 
Cache v3 networkstatus consensuses on disk.


svn:r11086
 2007-08-13 18:47:22 +00:00
Nick Mathewson
33cf3ada94 r14526@catbus: nickm | 2007-08-13 14:08:37 -0400 
Make voting interval configurable.


svn:r11083
 2007-08-13 18:09:38 +00:00
Roger Dingledine
762b5c479c less scary log entry 
svn:r11077
 2007-08-11 14:38:11 +00:00
Roger Dingledine
330abbb6c6 logging patch from karsten, slightly modified to compile 
svn:r11074
 2007-08-11 14:13:25 +00:00
Roger Dingledine
5920484083 dirserv.c:782: warning: `set_v1_dirty' might be used uninitialized in this function 
svn:r11068
 2007-08-10 03:07:00 +00:00
Nick Mathewson
5070a1e3ef r14103@catbus: nickm | 2007-08-09 18:30:40 -0400 
Drop v1 directory support: instead, just generate stub v1 directories.  This should save lots and lots of directory bandwidth, and break any code relying on v1 directories, including Tor 0.1.0.x and earlier.


svn:r11067
 2007-08-09 22:32:33 +00:00
Nick Mathewson
da09efe13d r13953@Kushana: nickm | 2007-08-08 07:40:46 -0700 
Fix osx compilation.


svn:r11065
 2007-08-08 14:43:30 +00:00
Nick Mathewson
3fc04529d4 r14093@catbus: nickm | 2007-08-08 01:49:54 -0400 
Include fewer redundant headers; use the compiler search paths better.


svn:r11060
 2007-08-08 05:50:31 +00:00
Nick Mathewson
50f5f63678 r14091@catbus: nickm | 2007-08-08 01:13:17 -0400 
Fix an annoying warning on OpenBSD: only include malloc.h if we are using it.


svn:r11059
 2007-08-08 05:14:03 +00:00
Roger Dingledine
9d2b1004b1 bump to 0.2.0.4-alpha-dev 
svn:r11056
 2007-08-08 04:12:05 +00:00
Nick Mathewson
68e6426c23 r13927@Kushana: nickm | 2007-08-03 00:56:54 -0700 
ratchet down the time spent on threading tests


svn:r11043
 2007-08-03 07:57:41 +00:00
Nick Mathewson
652d4e0248 r13926@Kushana: nickm | 2007-08-03 00:55:23 -0700 
Fix compilation with HAVE_GETADDRINFO unset


svn:r11042
 2007-08-03 07:57:31 +00:00
Nick Mathewson
1c513979fc r13919@Kushana: nickm | 2007-08-02 10:58:31 -0700 
Warn about unsafe ControlPort configurations.


svn:r11038
 2007-08-02 21:03:40 +00:00
Nick Mathewson
ba28346f2f r13907@Kushana: nickm | 2007-08-02 10:29:13 -0700 
Try (once again) to fix mingw build wrt detecting ipv6 types.


svn:r11037
 2007-08-02 17:30:42 +00:00
Roger Dingledine
46c4f8ff42 bump to 0.2.0.4-alpha 
svn:r11022
 2007-08-02 04:49:20 +00:00
Roger Dingledine
659cdae145 a patch on r11016 that makes it work better 
svn:r11018
 2007-08-02 04:28:29 +00:00
Nick Mathewson
322b6f7e65 r13892@Kushana: nickm | 2007-08-01 18:27:13 -0700 
Close immediately after anything but a successful authentication attempt on the control port.  Backport candidate.


svn:r11016
 2007-08-02 01:28:40 +00:00
Nick Mathewson
a4e7dffc94 r13886@Kushana: nickm | 2007-08-01 09:43:06 -0700 
Unit tests and debugging for detached signature manipulation.


svn:r11015
 2007-08-01 16:43:44 +00:00
Nick Mathewson
d5c78593d2 r13873@Kushana: nickm | 2007-07-31 10:54:05 -0700 
Split over-optimized digestmap_set code into a generic part and a digestmap-specific part.


svn:r11012
 2007-08-01 15:57:48 +00:00
Nick Mathewson
484c8b776d r13872@Kushana: nickm | 2007-07-31 08:27:54 -0700 
Rename IN4_ADDR and IN6_ADDR to try to avoid conflicting with Windows definitions.  This may fix the windows build.


svn:r11011
 2007-08-01 15:57:34 +00:00
Nick Mathewson
2872a43386 r13871@Kushana: nickm | 2007-07-31 08:10:58 -0700 
Fix warning aobut unused parameter on platforms without mallinfo.


svn:r11010
 2007-08-01 15:57:07 +00:00
Nick Mathewson
480db0f00a r14034@catbus: nickm | 2007-07-31 05:22:56 -0400 
possible fix for bug 473: always set buf->cur on buf_remove_from_front.


svn:r11004
 2007-07-31 09:31:15 +00:00
Peter Palfrader
ce8edc964c Stop pretending all systems are fast 
svn:r11003
 2007-07-31 06:48:47 +00:00
Roger Dingledine
ec376c5fbd bump to 0.2.0.3-alpha-dev 
svn:r10999
 2007-07-30 23:53:09 +00:00
Roger Dingledine
57c6264ede tweak comment 
svn:r10998
 2007-07-30 23:52:58 +00:00
Nick Mathewson
45c82b1d85 r14024@catbus: nickm | 2007-07-30 14:13:58 -0400 
Glibc (and maybe others) define a mallinfo() that can be used to see how the platform malloc is acting inside.  When we have it, dump its output on dumpmemusage().


svn:r10996
 2007-07-30 18:14:14 +00:00
Nick Mathewson
9fb77a6479 Disable SENTINELS in buffers: it may be responsible for making platform mallocs() be inefficient, and we havent needed it in a long long time. 
svn:r10994
 2007-07-30 17:51:14 +00:00
Nick Mathewson
9260a824ef Yet another buffer RAM patch: tNever ever ever keep a buffer memory chunk around for an empty buffer that could go on the freelist. This wants profiling to make sure that performance doesnt suffer. 
svn:r10993
 2007-07-30 17:47:43 +00:00
Nick Mathewson
34a3a5e2f4 r14016@catbus: nickm | 2007-07-30 13:45:55 -0400 
More documentation


svn:r10992
 2007-07-30 17:46:14 +00:00
Nick Mathewson
23a345b3c2 r14015@catbus: nickm | 2007-07-30 13:18:05 -0400 
Add missing code documentation in src/common


svn:r10991
 2007-07-30 17:46:12 +00:00
Roger Dingledine
5d535a28c9 clean up some bridge log messages 
svn:r10985
 2007-07-30 08:43:02 +00:00
Roger Dingledine
1b01ad6d38 writing instructions before you release means you can make sure 
your instructions don't seg fault


svn:r10984
 2007-07-30 08:42:47 +00:00
Roger Dingledine
e118efb545 bump to 0.2.0.3-alpha 
svn:r10982
 2007-07-30 03:40:51 +00:00
Nick Mathewson
915c4c3ab8 r14001@catbus: nickm | 2007-07-29 21:31:53 -0400 
Try to call time(NULL) a little less.


svn:r10980
 2007-07-30 01:32:12 +00:00
Nick Mathewson
a3b8b2c4e3 r14000@catbus: nickm | 2007-07-29 21:16:45 -0400 
Fix bug 472: do not use spaces in pseudo-address for local link cons.


svn:r10979
 2007-07-30 01:32:07 +00:00
Roger Dingledine
468d922280 start hunting bugs, first in a non-crashy manner 
svn:r10978
 2007-07-30 01:07:06 +00:00
Nick Mathewson
3dbc825f36 r13996@catbus: nickm | 2007-07-29 19:17:53 -0400 
Fix whitespace


svn:r10977
 2007-07-29 23:18:06 +00:00
Nick Mathewson
77508edd36 r13989@catbus: nickm | 2007-07-29 19:11:07 -0400 
More directory voting code.  Now, if everything works, and I haven't forgotten anything, it is possible to set up some v3 authorities and start voting. Of course, I have probably forgotten something, and there are probably bugs in there somewhere too.


svn:r10976
 2007-07-29 23:11:44 +00:00
Nick Mathewson
759ed3ce3f r13988@catbus: nickm | 2007-07-29 16:32:36 -0400 
Cheesy attempt to break some censorware.  Not a long-term fix, but it will be intersting to watch the epidemiology of the workarounds as the censors apply them.


svn:r10975
 2007-07-29 23:11:42 +00:00
Roger Dingledine
ca7c53d3cc Be even more aggressive about separating local traffic from relayed 
traffic when RelayBandwidthRate is set. (Refines proposal 111.)


svn:r10974
 2007-07-29 22:13:44 +00:00
Nick Mathewson
616152486f r13986@catbus: nickm | 2007-07-29 09:15:03 -0400 
Answer comment from Roger.


svn:r10971
 2007-07-29 13:18:52 +00:00
Roger Dingledine
a68e6e23c9 patches on r10968: compare advertised capacity, not bandwidthrate; 
and make the sorting order deterministic to avoid flapping.

also note that we could take the "is_auth" checks out of the
sorting entirely.


svn:r10970
 2007-07-29 05:56:30 +00:00
Nick Mathewson
9031bbd4d8 r13982@catbus: nickm | 2007-07-29 01:31:53 -0400 
Actually, we missed a rule about what routers to prefer: first prefer authority to non-authority, *then* running, *then* bandwidth.


svn:r10969
 2007-07-29 05:32:03 +00:00
Nick Mathewson
1b665b3c7e r13979@catbus: nickm | 2007-07-29 01:20:20 -0400 
Implement proposal 109:  As an authority, never call more than 3 servers per IP Running and Valid.  Prefer Running servers to non-running ones; then prefer high-bandwidth to low-bandwidth.  Needs testing.


svn:r10968
 2007-07-29 05:20:31 +00:00
Roger Dingledine
eca2a30060 make progress towards retrying our bridges when they're all 
down and we get a new socks request


svn:r10967
 2007-07-29 04:38:21 +00:00
Nick Mathewson
964e4a305d r13972@catbus: nickm | 2007-07-29 00:01:38 -0400 
Make our control events for multi-line async replies conform to our old grammar.  Change back to the old grammar (which got "corrected" in r10931).


svn:r10964
 2007-07-29 04:03:25 +00:00
Nick Mathewson
25bd4204d0 r13964@catbus: nickm | 2007-07-28 22:55:10 -0400 
Change "IN_ADDR" macro to "IN4_ADDR" in an attempt to fix mingw compilation


svn:r10963
 2007-07-29 02:55:24 +00:00
Nick Mathewson
d2adb68ed6 r13963@catbus: nickm | 2007-07-28 22:53:32 -0400 
Add support for signature upload


svn:r10962
 2007-07-29 02:55:21 +00:00
Roger Dingledine
9895d840f5 When running with dmalloc, dump more stats on hup and exit. 
svn:r10961
 2007-07-29 01:18:00 +00:00
Nick Mathewson
764bde22de r13960@catbus: nickm | 2007-07-28 18:14:29 -0400 
Start correctly when cached-certs is missing. oops


svn:r10957
 2007-07-28 22:14:42 +00:00
Nick Mathewson
76a408941c r13959@catbus: nickm | 2007-07-28 18:09:56 -0400 
Use the correct formula to calculate exit weights.


svn:r10956
 2007-07-28 22:14:39 +00:00
Nick Mathewson
afe9f33d35 r13956@catbus: nickm | 2007-07-27 20:09:48 -0400 
Better certificate manipulations: extract certificates from incoming votes, forget ones that are very old, and remember to store them on disk.


svn:r10954
 2007-07-28 00:11:34 +00:00
Nick Mathewson
0d274e1db1 r13952@catbus: nickm | 2007-07-27 19:18:46 -0400 
Weasel noticed that many buffers spend their time with empty 4k, 8k, and 16k memory chunks.  Thus, be more aggressive about putting empty chunks on the freelist, regardless of their high water marks.  (Also, run buffer_shrink_freelist on the 8k-chunk freelist.)


svn:r10953
 2007-07-27 23:19:02 +00:00
Nick Mathewson
43f64d09ea r13951@catbus: nickm | 2007-07-27 18:39:28 -0400 
Make it so we can actually compile with FULL_V1_DIRECTORIES disabled.


svn:r10952
 2007-07-27 23:18:58 +00:00
Nick Mathewson
f6229d6432 r13950@catbus: nickm | 2007-07-27 18:15:23 -0400 
Wrap bandwidth usage info in another ifdef so we can easily drop it on august 1 when it is time to finalize proposal 104.


svn:r10951
 2007-07-27 23:18:55 +00:00
Nick Mathewson
0e5d8925d9 r13946@catbus: nickm | 2007-07-27 16:09:31 -0400 
Fix median_int for platforms where sizeof(int)!=sizeof(time_t)


svn:r10949
 2007-07-27 20:09:37 +00:00
Nick Mathewson
a5477c7bb9 r13944@catbus: nickm | 2007-07-27 15:52:35 -0400 
Fix warnings on platforms where rlim values can be signed.
 Add an 8k buffer freelist.
 


svn:r10948
 2007-07-27 19:53:29 +00:00
Nick Mathewson
bc9a7be943 r13939@catbus: nickm | 2007-07-27 14:33:22 -0400 
When dumping memory usage, list bytes used in buffer memory free-lists.


svn:r10947
 2007-07-27 18:33:37 +00:00
Nick Mathewson
65cdda20b3 r13938@catbus: nickm | 2007-07-27 14:26:07 -0400 
More code to handle incoming consensus signatures


svn:r10946
 2007-07-27 18:33:34 +00:00
Nick Mathewson
10f166045b r13937@catbus: nickm | 2007-07-27 12:43:36 -0400 
Maintain a detached-signatures document along with pending consensus document.  Add a dirvote_free_all() to clean up static vars in dirvote.c


svn:r10945
 2007-07-27 18:33:30 +00:00
Nick Mathewson
a65cea38d2 r13936@catbus: nickm | 2007-07-27 12:23:26 -0400 
Code to implement detached signature documents.


svn:r10944
 2007-07-27 18:33:28 +00:00
Nick Mathewson
35561a542c r13934@catbus: nickm | 2007-07-27 10:41:00 -0400 
Fix spelling; add a comment.


svn:r10943
 2007-07-27 14:41:08 +00:00
Peter Palfrader
49db52abe6 Maybe fix #471. Compute the size of bitfields more correctly. Nick, please check. 
svn:r10941
 2007-07-27 04:45:42 +00:00
Peter Palfrader
1f4275451b Resolve a compiler warning about uninitialized use 
svn:r10940
 2007-07-27 01:10:23 +00:00
Nick Mathewson
eed888a2b7 r13927@catbus: nickm | 2007-07-26 17:26:49 -0400 
Fix router_choose_by_bandwidth to no longer be biases by floating-point roundoff issues.  This runs through the list of routers yet another time, and uses an additional bitfield, but this should be okay: the function did not appear in profiles before, and shouldnt start appearing now.


svn:r10939
 2007-07-26 21:26:57 +00:00
Nick Mathewson
b1c873182d r13926@catbus: nickm | 2007-07-26 17:21:06 -0400 
Add a bit-array type with reasonably fast inline functions.


svn:r10938
 2007-07-26 21:26:53 +00:00
Nick Mathewson
6c4864f351 r13924@catbus: nickm | 2007-07-26 16:46:45 -0400 
We can have multiple authority certificates for an authority at a time: make the code reflect that.


svn:r10937
 2007-07-26 20:49:04 +00:00
Nick Mathewson
fb2f3c035b r13921@catbus: nickm | 2007-07-26 16:26:48 -0400 
Code to add signatures to a pending consensus directory.


svn:r10936
 2007-07-26 20:26:59 +00:00
Nick Mathewson
189bc7cf9f r13920@catbus: nickm | 2007-07-26 16:25:25 -0400 
whitespace fixes


svn:r10935
 2007-07-26 20:26:53 +00:00
Nick Mathewson
7f3e2378b6 r13908@catbus: nickm | 2007-07-25 18:55:47 -0400 
Patch from Robert Hogan: set conn->dns_server_port correctly so that we can close dns server ports when they change, thus avoiding crashes and dangling references and other sources of unhappiness.


svn:r10933
 2007-07-25 22:57:07 +00:00
Nick Mathewson
025a81fc18 r13907@catbus: nickm | 2007-07-25 18:51:25 -0400 
Patch from tup: translate LFs to CRLFs in NS replies and
 ensures the data section is properly terminated with "\r\n.\r\n


svn:r10932
 2007-07-25 22:57:02 +00:00
Nick Mathewson
a8821e2d82 r13905@catbus: nickm | 2007-07-25 18:48:44 -0400 
ADDRMAP events should never have specified local time.  Extend them to have the proper gmt time, and make GETINFO address-mappings always do the right thing (since it is new in this version).


svn:r10930
 2007-07-25 22:56:54 +00:00
Nick Mathewson
47f3a40900 r13904@catbus: nickm | 2007-07-25 18:04:46 -0400 
Fix whitespaces and compilation in and around dirvote code.


svn:r10929
 2007-07-25 22:56:50 +00:00
Nick Mathewson
2305c2c7be r13903@catbus: nickm | 2007-07-25 18:03:56 -0400 
Make buffer large enough to hold ip6.arpa addresses.  This code was not actually used yet, so no user-visible bug existed. (Based on patch by croup.)


svn:r10928
 2007-07-25 22:56:47 +00:00
Nick Mathewson
a66f259354 r13902@catbus: nickm | 2007-07-25 17:43:52 -0400 
Some dirvote code to handle generating votes and slinging them around.  More code is still needed.


svn:r10927
 2007-07-25 22:56:44 +00:00
Nick Mathewson
1b7a704c34 r13901@catbus: nickm | 2007-07-25 16:23:51 -0400 
Make all code to generate v1 directories into conditional code.


svn:r10926
 2007-07-25 22:56:40 +00:00
Nick Mathewson
83fa843663 r13900@catbus: nickm | 2007-07-25 16:16:30 -0400 
Better fix for GCC 4.2 warning on routerlist.c


svn:r10925
 2007-07-25 22:56:34 +00:00
Nick Mathewson
1b24067395 r13773@kushana: nickm | 2007-07-23 00:16:44 -0400 
Use tor malloc replacements in eventdns.c for now: there might be goblins there...goblins that only dmalloc can find!


svn:r10912
 2007-07-23 04:18:20 +00:00
Nick Mathewson
4d2f45978f r13875@catbus: nickm | 2007-07-22 18:56:30 -0400 
Once more with feeling.


svn:r10907
 2007-07-22 22:56:33 +00:00
Nick Mathewson
6640fdeeee r13872@catbus: nickm | 2007-07-22 18:51:02 -0400 
esc_router_info static field should not be cleared postfork, to avoid races.


svn:r10906
 2007-07-22 22:51:07 +00:00
Nick Mathewson
701fce8e5c r13858@catbus: nickm | 2007-07-22 18:44:02 -0400 
Fix/note some relatively trivial mem usage issues


svn:r10905
 2007-07-22 22:49:49 +00:00
Roger Dingledine
0104882e9b dump dmalloc stats on sighup 
svn:r10903
 2007-07-22 07:05:43 +00:00
Roger Dingledine
5190916670 free a small static string on exit. 
svn:r10902
 2007-07-22 06:32:28 +00:00
Roger Dingledine
e96d807db4 Revert part of r10874, since it was breaking our load balancing 
(we always picked one router past the one we wanted!) and could
conceivably read past the end of the smartlist too.

Nick, I don't know what gcc 4.2 was worried about, but we need
to find a better fix than this. :)


svn:r10901
 2007-07-22 04:36:33 +00:00
Roger Dingledine
6fc336d217 handle fetching bridge descriptors from the bridge authority too. 
svn:r10898
 2007-07-22 00:16:48 +00:00
Roger Dingledine
56d3119581 Directory authorities now call routers Fast if their bandwidth is 
at least 100KB/s, and consider their bandwidth adequate to be a
Guard if it is at least 250KB/s. This fix complements proposal
107. [Bugfix on 0.1.2.x]


svn:r10897
 2007-07-21 23:40:55 +00:00
Roger Dingledine
a916e07ea6 when requesting tor/server/authority, ask for tor/server/authority.z 
instead. same functionality, saves a bit of bandwidth. and might even
work.


svn:r10896
 2007-07-21 22:04:18 +00:00
Nick Mathewson
8e50aa7341 r13856@catbus: nickm | 2007-07-20 14:30:44 -0400 
slightly smarter heuristic about when to use obsolete ::a.b.c.d format.


svn:r10893
 2007-07-20 18:30:47 +00:00
Nick Mathewson
8ba42a3bde r13850@catbus: nickm | 2007-07-20 12:25:24 -0400 
Fix some bugs in ntop/pton.


svn:r10891
 2007-07-20 16:25:27 +00:00
Nick Mathewson
6223160ab7 r13848@catbus: nickm | 2007-07-19 16:47:16 -0400 
Use our own version of inet_ntop and inet_pton everywhere, to avoid partitioning attacks.


svn:r10888
 2007-07-19 20:47:18 +00:00
Nick Mathewson
3015129a4a r13846@catbus: nickm | 2007-07-19 16:31:41 -0400 
Actually, OSX (and some BSDs) accept [f:f:f:f:f:f:f:f::] as a perfectly fine ipv6 address.


svn:r10887
 2007-07-19 20:31:43 +00:00
Nick Mathewson
31a73c0767 r13844@catbus: nickm | 2007-07-19 16:04:04 -0400 
Same as the last patch, only more so.


svn:r10886
 2007-07-19 20:04:05 +00:00
Nick Mathewson
00420bd084 r13842@catbus: nickm | 2007-07-19 16:02:54 -0400 
OSX writes ::3 as ::0.0.0.3; choose a less ambiguous example.


svn:r10885
 2007-07-19 20:02:56 +00:00
Nick Mathewson
a1f4644a94 r13840@catbus: nickm | 2007-07-19 16:00:43 -0400 
Apparently, this problem can occur on the whole BSD family. "Yay."


svn:r10884
 2007-07-19 20:00:45 +00:00
Nick Mathewson
b2772f93cb r13838@catbus: nickm | 2007-07-19 15:50:16 -0400 
Apparently, OSX does not define s6_addr32 or s6_addr16. How silly.


svn:r10883
 2007-07-19 19:50:20 +00:00
Nick Mathewson
679b55eb1f r13836@catbus: nickm | 2007-07-19 15:43:04 -0400 
Some older GCCs think that iph4 could be used uninitialized. Fix that.


svn:r10882
 2007-07-19 19:43:08 +00:00
Nick Mathewson
4a240552c4 r13834@catbus: nickm | 2007-07-19 15:40:42 -0400 
Another patch from croup: drop support for address masks that do not correspond to bit prefixes.  Nobody has used this for a while, and we have given warnings for a long time.


svn:r10881
 2007-07-19 19:40:45 +00:00
Nick Mathewson
bbbf504281 r13827@catbus: nickm | 2007-07-19 14:42:25 -0400 
Merge in some generic address manipulation code from croup.  Needs some work.


svn:r10880
 2007-07-19 18:46:09 +00:00
Nick Mathewson
70aef18db1 r13826@catbus: nickm | 2007-07-19 12:21:30 -0400 
Fix a copy-and-paste error in dirvote.c


svn:r10879
 2007-07-19 18:46:06 +00:00
Nick Mathewson
5e6f05bc31 r13822@catbus: nickm | 2007-07-18 16:43:39 -0400 
Tweak a couple of loop-related variables to make the gcc 4.2 -Wstrict-overflow warning happy.


svn:r10874
 2007-07-18 20:46:14 +00:00
Nick Mathewson
d920683718 r13821@catbus: nickm | 2007-07-18 16:29:17 -0400 
Initial code to manipulate vote timing correctly.


svn:r10873
 2007-07-18 20:46:12 +00:00
Nick Mathewson
4a9d4c2c5c r13820@catbus: nickm | 2007-07-18 16:07:30 -0400 
Whitespace fix on r10849


svn:r10872
 2007-07-18 20:46:10 +00:00
Peter Palfrader
3052bf6a84 Change routerlist_remove to not take an index argument we do not need anyway. 
Now the only remaining caller of _routerlist_find_elt is an assert()

svn:r10869
 2007-07-18 14:02:47 +00:00
Roger Dingledine
50487c249d timeout and retry schedules for fetching bridge descriptors 
svn:r10867
 2007-07-18 10:06:03 +00:00
Roger Dingledine
5c4d86f512 using fascistfirewall and having your bridge on an unreachable 
port silently didn't mix. now they loudly don't mix.


svn:r10862
 2007-07-18 07:13:15 +00:00
Nick Mathewson
670db47e1b r13801@catbus: nickm | 2007-07-17 13:49:12 -0400 
More tweaks to dir-spec.txt; not complete, but closing in.


svn:r10856
 2007-07-17 17:49:16 +00:00
Roger Dingledine
a1ab2c8087 free bridge list on exit; try harder to free buffer freelists on exit. 
svn:r10854
 2007-07-17 11:33:38 +00:00
Roger Dingledine
b7e4683ff9 bugfix on r10086: 
We had accidentally labelled 0.1.2.x directory servers as not
suitable for begin_dir requests, and had labelled no directory
servers as suitable for uploading extra-info documents. [Bugfix
on 0.2.0.1-alpha]


svn:r10853
 2007-07-17 09:37:00 +00:00
Roger Dingledine
fcbb817db5 free another string, and the buffer freelists, on exit. 
svn:r10851
 2007-07-17 09:26:45 +00:00
Roger Dingledine
ccfda2e3a3 a few fixes for bug 463. needs a changelog. might need more fixes. 
svn:r10849
 2007-07-17 02:53:17 +00:00
Nick Mathewson
ad45ddfb07 r13788@catbus: nickm | 2007-07-16 14:26:25 -0400 
Patch from croup: rewrite the logic of get_next_token() to do the right thing with input that ends at weird places, or aligns with block boundaries after mmap.  should fix bug 455.  Needs fuzzing.


svn:r10847
 2007-07-16 18:26:31 +00:00
Nick Mathewson
6e9f1f76f2 r13784@catbus: nickm | 2007-07-16 13:27:32 -0400 
Apply patch from tup: remove extra space at the end of some circuit-status events, and stop translating CRLF to CRCRLF in control replies.


svn:r10845
 2007-07-16 17:27:35 +00:00
Nick Mathewson
26a25edaec r13777@catbus: nickm | 2007-07-16 12:58:08 -0400 
Patch from tup: new address-mappings/ GETINFO that includes expiry times.


svn:r10844
 2007-07-16 16:58:11 +00:00
Nick Mathewson
483c1e9017 r13774@catbus: nickm | 2007-07-16 12:23:28 -0400 
Tweaks on constrained socket buffers patch from coderman: Add a changelog; rename some variables; fix some long lines and whitespace; make ConstrainedSockSize a memunit; pass setsockopt a void.


svn:r10843
 2007-07-16 16:23:36 +00:00
Nick Mathewson
f4a6673758 r13773@catbus: nickm | 2007-07-16 11:58:25 -0400 
Initial "constrained socket buffers" patch from coderman. needs tweaking.


svn:r10842
 2007-07-16 16:23:34 +00:00
Roger Dingledine
6d2cb32d10 free some more memory on exit 
svn:r10837
 2007-07-16 04:33:47 +00:00
Roger Dingledine
4b719cbae0 stop reading uninitialized/outofbounds memory. possible backport, 
quite related to bug 455.


svn:r10835
 2007-07-16 03:39:21 +00:00
Roger Dingledine
98ce45bebf Backport candidate: 
Fix a potential crash bug when we load many server descriptors at
once and some of them make others of them obsolete. Fixes bug
458. [Bugfix on 0.1.2.x]


svn:r10832
 2007-07-16 00:11:03 +00:00
Roger Dingledine
5ab3f49d93 backport candidate: fix a memory leak from r9039 which had us leaking 
50ish bytes every time we rebuild the cached-router files.


svn:r10830
 2007-07-15 08:34:32 +00:00
Roger Dingledine
2c2f7ee6a4 fix a memory leak from r10504 (i think) 
svn:r10829
 2007-07-15 08:11:56 +00:00
Peter Palfrader
2ce1cb22bd Comment one tor_assert 
svn:r10820
 2007-07-12 17:37:47 +00:00
Roger Dingledine
ef6bc1a451 Keep streamids from different exits on a circuit separate. This 
bug may have allowed other routers on a given circuit to inject
cells into streams. Reported by lodger; fixes bug 446. [Bugfix
on 0.1.2.x]


svn:r10818
 2007-07-12 17:09:19 +00:00
Nick Mathewson
656b7761a8 r13730@catbus: nickm | 2007-07-12 12:32:40 -0400 
Patch from lodger: avoid roundoff-error-induced crash bugs when picking routers by bandwidth.
 Also, remove listed backports for 0.1.2.x; that list is now in TODO.012


svn:r10812
 2007-07-12 16:34:45 +00:00
Peter Palfrader
9ed261cd6a In router_add_to_routerlist() only call router_have_minimum_dir_info() under some circumstances, not always 
svn:r10799
 2007-07-12 15:57:23 +00:00
Roger Dingledine
9bf23e0598 backport candidate: 
When sending destroy cells from a circuit's origin, don't include
the reason for tearing down the circuit. The spec says we didn't,
and now we actually don't. Reported by lodger. [Bugfix on 0.1.2.x]


svn:r10790
 2007-07-11 03:37:45 +00:00
Roger Dingledine
83e8d8d9b9 clean up a comment 
svn:r10789
 2007-07-11 03:28:12 +00:00
Nick Mathewson
39dc589d32 r13691@catbus: nickm | 2007-07-10 18:44:30 -0400 
Fix an assert error in 455 patch.


svn:r10788
 2007-07-10 22:44:32 +00:00
Nick Mathewson
fa1376014b r13689@catbus: nickm | 2007-07-10 17:46:30 -0400 
tweaks to last patch.  from croup.


svn:r10787
 2007-07-10 21:46:33 +00:00
Nick Mathewson
7e20fdbefb r13687@catbus: nickm | 2007-07-10 16:08:14 -0400 
Possible partial fix for bug 455: use eos logic everywhere.


svn:r10786
 2007-07-10 20:08:18 +00:00
Nick Mathewson
d6ba1c3d96 r13676@catbus: nickm | 2007-07-10 13:41:24 -0400 
Man. I thought I removed that code.


svn:r10785
 2007-07-10 17:41:26 +00:00
Nick Mathewson
a8465adaa2 r13667@catbus: nickm | 2007-07-10 13:12:52 -0400 
Patch from tup: add GETINFO status/enough-dir-info


svn:r10782
 2007-07-10 17:14:55 +00:00
Nick Mathewson
74711479eb r13666@catbus: nickm | 2007-07-10 13:10:00 -0400 
Get the RESOLVE controller code working.


svn:r10781
 2007-07-10 17:14:51 +00:00
Nick Mathewson
7705314777 r13637@catbus: nickm | 2007-07-06 14:24:27 -0400 
fix copy-paste error in config message src/or/config.c .  Apply
 initial (but pared-down) version of launch-resolve-via-controller
 patch from Robert Hogan.
 


svn:r10780
 2007-07-10 17:13:24 +00:00
Nick Mathewson
10e5ed1a84 r13602@Kushana: nickm | 2007-07-07 23:44:24 -0400 
Backport candidate: fix a possible buffer overrun when using natd support on old BSDs.  Based on a patch from "Mr. Croup".


svn:r10760
 2007-07-08 03:45:47 +00:00
Peter Palfrader
db3a4bf897 Call router_have_minimum_dir_info() at the beginning of router_add_to_routerlist() since it has side effects 
svn:r10754
 2007-07-06 21:21:09 +00:00
Peter Palfrader
39b1a11f8d Remove two arguments from routerlist_replace(). idx, which is 
the old router's index in the routerlist, can be gotten from the
old routerinfo itself anyway, and make_old always was true.
(There only is one caller of routerlist_replace())


svn:r10753
 2007-07-06 18:40:39 +00:00
Nick Mathewson
e6ba07f8f5 r13634@catbus: nickm | 2007-07-06 14:20:50 -0400 
Fix a crash bug (*the* crash bug?) on authorities.  Backport candidate.


svn:r10752
 2007-07-06 18:20:54 +00:00
Nick Mathewson
92b6e09082 r13633@catbus: nickm | 2007-07-06 11:08:19 -0400 
Call tor_init_threads() from tor_init().


svn:r10751
 2007-07-06 18:20:52 +00:00
Nick Mathewson
73b4428a8b r13631@catbus: nickm | 2007-07-06 10:17:22 -0400 
Try to fix win32 build again.


svn:r10750
 2007-07-06 14:17:30 +00:00
Nick Mathewson
bbc7cf86d5 r13600@Kushana: nickm | 2007-07-05 23:49:47 -0400 
try to fix mingw compile


svn:r10743
 2007-07-06 03:49:57 +00:00
Nick Mathewson
a9469098ca r13596@kushana: nickm | 2007-07-05 10:53:22 -0400 
Argh, re-enable CRITICAL_SECTION code in win32.


svn:r10741
 2007-07-05 14:53:27 +00:00
Nick Mathewson
5c9c420111 svn:r10740 2007-07-05 14:51:10 +00:00
Nick Mathewson
ae4ab0f617 r13454@kushana: nickm | 2007-06-20 14:22:44 -0400 
Switch windows locking implementation to CRITICAL_SECTION, not Mutex: Mutex is heavier-weight, and meant for multi-process situations.


svn:r10739
 2007-07-05 14:51:01 +00:00
Nick Mathewson
04c9ae8164 r13453@kushana: nickm | 2007-06-20 10:01:37 -0400 
Fix a type error in the last checkin.


svn:r10738
 2007-07-05 14:50:13 +00:00
Nick Mathewson
b5c8a6183a r13452@kushana: nickm | 2007-06-20 09:52:55 -0400 
Patch from Robert Hogan: Generate STREAM NEW events for dnsport requests and tunneled directory connections.  Log when we are testing for hijacking.


svn:r10737
 2007-07-05 14:50:05 +00:00
Roger Dingledine
99bfb1bebe If there's a never-before-connected-to guard node in our list, 
never choose any guards past it. This way we don't expand our 
guard list unless we need to. [Bugfix in 0.1.2.x]

I'm not sure if this will solve all our problems, but it is at least
something.



svn:r10730
 2007-07-02 22:15:26 +00:00
Roger Dingledine
5c1daed3ad the non-controversial changes i found in my sandbox 
svn:r10729
 2007-07-02 22:07:53 +00:00
Nick Mathewson
32b165ab61 r13604@catbus: nickm | 2007-07-02 16:58:40 -0400 
Some temporary output to try to figure out where bsd thread unit tests are going wrong


svn:r10728
 2007-07-02 21:08:03 +00:00
Peter Palfrader
64f4cff192 I so wonder how this blows up on the real network - make _routerlist_find_elt be strict about the idx it is passed - if it is not -1 then it has to be correct 
svn:r10727
 2007-07-02 20:17:12 +00:00
Peter Palfrader
d071df748a If we want to be more strict in _routerlist_find_elt I better call it properly 
svn:r10726
 2007-07-02 20:04:26 +00:00
Peter Palfrader
ccefd7404e Don't get private with smartlists when there's a perfectly fine accessor method for num_used 
svn:r10724
 2007-07-02 19:45:44 +00:00
Peter Palfrader
f274c1413e Make it build with -O0 as well 
svn:r10722
 2007-07-02 17:50:57 +00:00
Peter Palfrader
adff891463 Make DEBUG_SMARTLIST work 
svn:r10721
 2007-07-02 17:48:56 +00:00
Peter Palfrader
ea1348360e Three more assertions which hopefully are sane, Nick? They might help track down #417. 
svn:r10720
 2007-07-02 15:13:52 +00:00
Nick Mathewson
1bdcfd9203 r13570@catbus: nickm | 2007-06-30 20:41:05 -0400 
Implement conditions in compat.c; switch windows to use "critical sections" instead of mutexes.  Apparently, mutexes are for IPC and critical sections are for multithreaded.


svn:r10716
 2007-07-01 16:22:45 +00:00
Nick Mathewson
8bebff3deb r13568@catbus: nickm | 2007-06-30 15:18:18 -0400 
allow test_threads() to time out 


svn:r10711
 2007-06-30 19:18:28 +00:00
Nick Mathewson
25a11bf8aa r13555@catbus: nickm | 2007-06-30 14:05:36 -0400 
Split "Util" tests into subgroups so I can see why freebsd trunk is failing.


svn:r10710
 2007-06-30 18:06:00 +00:00
Nick Mathewson
a8a880e418 r13480@catbus: nickm | 2007-06-17 14:39:42 -0400 
Oops; forgot to save a file in the last batch.


svn:r10646
 2007-06-17 18:41:03 +00:00
Nick Mathewson
5adfa09fce r13477@catbus: nickm | 2007-06-17 14:22:03 -0400 
Sun CC likes to give warnings for the do { } while(0) construction for making statement-like macros.  Define STMT_BEGIN/STMT_END macros that do the right thing, and use them everywhere.


svn:r10645
 2007-06-17 18:22:39 +00:00
Nick Mathewson
93f32db438 r13476@catbus: nickm | 2007-06-17 14:04:41 -0400 
Build with fewer compiler warnings on Sun.  (This and previous Sun patches are thanks to the tremendously handy services of unix-center.net.)


svn:r10644
 2007-06-17 18:22:35 +00:00
Nick Mathewson
99792df645 r13473@catbus: nickm | 2007-06-17 13:42:36 -0400 
Fix solaris eventdns.c behavior.  This time, I think I got it.  We were redefining _FILE_OFFSET_BITS, and thereby calling fstat64() on a struct stat, or something like that.


svn:r10643
 2007-06-17 17:43:25 +00:00
Nick Mathewson
721899a447 r13471@catbus: nickm | 2007-06-17 11:59:25 -0400 
Report address and por correctly on requests to dnsport. (Patch from Robert Hogan.)


svn:r10641
 2007-06-17 15:59:27 +00:00
Nick Mathewson
d828915136 r13463@catbus: nickm | 2007-06-17 11:10:17 -0400 
Add a SOURCE_ADDR field to STREAM NEW events so that controllers can match requests to applications. (Patch from Robert Hogan.)


svn:r10639
 2007-06-17 15:10:51 +00:00
Nick Mathewson
3df7fc5e5a r13438@catbus: nickm | 2007-06-15 15:01:42 -0400 
document some functions


svn:r10637
 2007-06-17 15:10:43 +00:00
Nick Mathewson
9e944d07f8 r13418@catbus: nickm | 2007-06-14 13:29:21 -0400 
Adjust networkstatus_compute_consensus to take an argument saying how many voters there _should_ be.


svn:r10634
 2007-06-17 15:10:23 +00:00
Roger Dingledine
237cdfdf48 if we already have a bridge in our state file, it won't be 
in the networkstatuses, so we'll mark it unusable when we
load it, and then when we get a new routerinfo for it, we'll
still think it's unusable. fix that.


svn:r10612
 2007-06-15 18:32:27 +00:00
Roger Dingledine
07ff5c6785 bugfix on r10609: don't fail asserts when closing circuits 
that were connected to an unkeyed connection.


svn:r10611
 2007-06-15 16:21:40 +00:00
Roger Dingledine
2cd293dc8f now we can specify a bridge without specifying its key, 
and we will still connect to it and use it. getting closer!


svn:r10609
 2007-06-15 06:01:04 +00:00
Roger Dingledine
6a2f045163 extra points for making the function name reflect what it does 
svn:r10608
 2007-06-15 04:23:36 +00:00
Roger Dingledine
73f7310d9b Directories no longer return a "304 not modified" when they don't 
have the networkstatus the client asked for. Also fix a memory
leak when returning 304 not modified. [Bugfixes on 0.2.0.2-alpha]


svn:r10607
 2007-06-15 04:20:51 +00:00
Roger Dingledine
9f9ee13dc0 point out a bug in our If-Modified-Since handling in 0.2.0.2-alpha. 
svn:r10605
 2007-06-15 03:14:02 +00:00
Roger Dingledine
3d641bde0e Refine r10571: more work on bridge stuff. 
- Only listen to responses for "authority" fetches if we're configured
    to use Bridges. Otherwise it's safe (and maybe smarter) to silently
    discard them like we used to.
  - React faster to download networkstatuses after the first bridge
    descriptor arrives.
  - Don't do dir fetches before we have any bridges, even when our 
    dirport is open.


svn:r10604
 2007-06-15 02:12:15 +00:00
Nick Mathewson
9a74e881ef r13413@catbus: nickm | 2007-06-13 18:44:28 -0400 
Non-static inline functions cant talk about static variables.


svn:r10599
 2007-06-13 22:44:30 +00:00
Nick Mathewson
a8e88adba4 r13410@catbus: nickm | 2007-06-13 18:39:05 -0400 
Fix compilation on compilers that do not allow you to typedef the same type twice.


svn:r10598
 2007-06-13 22:39:10 +00:00
Nick Mathewson
649a802322 r13409@catbus: nickm | 2007-06-13 18:01:56 -0400 
Test the remainder of the contents of the consensus; fix a bug in geneating addresses on routerstatuses.


svn:r10597
 2007-06-13 22:39:08 +00:00
Nick Mathewson
c2ea3e9aea r13406@catbus: nickm | 2007-06-13 17:05:30 -0400 
Oops; linked connections get read/write events too.


svn:r10596
 2007-06-13 21:05:32 +00:00
Nick Mathewson
6462683669 r13403@catbus: nickm | 2007-06-13 16:15:44 -0400 
Test all of consensus contents, except for routerstatus_list contents. And signatures.


svn:r10593
 2007-06-13 20:17:27 +00:00
Nick Mathewson
4b162fd1f4 r13401@catbus: nickm | 2007-06-13 15:50:16 -0400 
Add dnsport connection to the global connection list. (Bug found by mwenge.)


svn:r10592
 2007-06-13 19:50:18 +00:00
Nick Mathewson
eab7c6890d r13399@catbus: nickm | 2007-06-13 15:17:44 -0400 
Hm. Tor should never need private authority identity keys; thus, I should not actually load the authority identity keys for testing.


svn:r10591
 2007-06-13 19:17:46 +00:00
Nick Mathewson
3fa9a90243 r13396@catbus: nickm | 2007-06-13 15:06:18 -0400 
Set vote_digest field prproperly in networkstatus_vote_t, so that it gets conveyed to the consensus correctly.


svn:r10590
 2007-06-13 19:06:26 +00:00
Nick Mathewson
c3626cdba7 r13395@catbus: nickm | 2007-06-13 15:01:23 -0400 
Unit tests and debugging for generating and parsing consensus networkstatus documents.  Still need to test actual contents.


svn:r10589
 2007-06-13 19:06:23 +00:00
Nick Mathewson
05cf945a1c r13393@catbus: nickm | 2007-06-13 14:29:14 -0400 
More vote unit tests: check that we are parsing routerstatuses correctly.


svn:r10588
 2007-06-13 18:29:16 +00:00
Nick Mathewson
0cf38ddef6 r13387@catbus: nickm | 2007-06-13 14:15:49 -0400 
Unit tests and debugging for vote generation and parsing code.


svn:r10587
 2007-06-13 18:16:05 +00:00
Nick Mathewson
09a370e45f r13386@catbus: nickm | 2007-06-13 14:15:20 -0400 
New helper file for test.c: contains 3 generated certs, signing keys, and id_keys


svn:r10586
 2007-06-13 18:16:01 +00:00
Nick Mathewson
300678221a r13385@catbus: nickm | 2007-06-13 14:14:47 -0400 
In tor-gencert, write BEGIN SIGNATURE, not BEGIN_SIGNATURE.


svn:r10585
 2007-06-13 18:15:59 +00:00
Nick Mathewson
546209a4de r13384@catbus: nickm | 2007-06-13 13:53:26 -0400 
make test_* functions stop conflicting with variables named v1 and v2.


svn:r10584
 2007-06-13 18:15:56 +00:00
Nick Mathewson
3637ee0e59 r13383@catbus: nickm | 2007-06-13 13:53:04 -0400 
Expose a function to parse a private key from a string as CRYPTO_PRIVATE.  For testing.


svn:r10583
 2007-06-13 18:15:53 +00:00
Roger Dingledine
af658b7828 More work towards making bridge users able to connect via bridges: 
- demand options->Bridges and options->TunnelDirConns if 
    options->UseBridges is set.
  - after directory fetches, accept descriptors that aren't referenced by
    our networkstatuses, *if* they're for a configured bridge.
  - delay directory fetching until we have at least one bridge descriptor.
  - learn how to build a one-hop circuit when we have neither routerinfo
    nor routerstatus for our destination.
  - teach directory connections how to pick a bridge as the destination
    directory when doing non-anonymous fetches.
  - tolerate directory commands for which the dir_port is 0.
  - remember descriptors when the requested_resource was "authority", 
    rather than just ignoring them.
  - put bridges on our entry_guards list once we have a descriptor for them.
    When UseBridges is set, only pick entry guards that are bridges. Else
    vice versa.


svn:r10571
 2007-06-12 09:17:23 +00:00
Roger Dingledine
622dd4927e change the BandwidthRate/BandwidthBurst in the torrc 
to RelayBandwidthRate/RelayBandwidthBurst, since that's
what most users will actually want. also flesh out the
torrc.complete entries and fix a few typos. based on
patch from "Armedblowfish".


svn:r10570
 2007-06-12 08:19:02 +00:00
Peter Palfrader
c0b28adc65 Resetting the correct stats 
svn:r10569
 2007-06-12 01:09:53 +00:00
Nick Mathewson
a21381affa r13364@catbus: nickm | 2007-06-11 20:15:53 -0400 
Stop assuming that desc_by_eid_map works: in fact, it kinda doesn't.  Add a big comment explaining why.


svn:r10567
 2007-06-12 00:15:55 +00:00
Nick Mathewson
399890307d r13362@catbus: nickm | 2007-06-11 19:00:23 -0400 
Fix a warning on platforms where sizeof(size_t)==8, but sizeof(unsigned long)<8.


svn:r10566
 2007-06-11 23:00:26 +00:00
Nick Mathewson
dddf065e62 r13358@catbus: nickm | 2007-06-11 18:46:24 -0400 
Fix some dumb copypasta in r10562.


svn:r10565
 2007-06-11 22:46:35 +00:00
Peter Palfrader
f621513cad Remove an #undef, so you can -Ddefine stuff on the command line 
svn:r10564
 2007-06-11 22:32:30 +00:00
Nick Mathewson
367a77459a r13355@catbus: nickm | 2007-06-11 18:19:34 -0400 
Make all the digestmaps inside routerlist_t use the new typechecking wrappers, so we can catch any more bugs like the one fixed by 10561.  This turned up a bug in routerlist_remove: we were extracting a routerinfo_t from desc_digest_map.  Fix that too, though it was probably harmless, since we were only doing a pointer comparison with it.


svn:r10563
 2007-06-11 22:19:40 +00:00
Nick Mathewson
f45732513e r13354@catbus: nickm | 2007-06-11 18:17:40 -0400 
Add typechecking wrappers to digestmap, so we can work with "map from digest to [FOO]" for arbitrary FOOs and still have some typesafety.


svn:r10562
 2007-06-11 22:19:37 +00:00
Nick Mathewson
bde82e737b r13352@catbus: nickm | 2007-06-11 17:42:45 -0400 
Since desc_by_eid_map hold server descriptors, do not add routerinfo_ts.  Bug found by weasel


svn:r10561
 2007-06-11 21:42:48 +00:00
Peter Palfrader
e91cab20dd Reorder routerlist_assert_ok() and routerlist_check_bug_417(), so if the assert_ok triggers we know that our bug_417 is wrong 
svn:r10560
 2007-06-11 19:46:23 +00:00
Nick Mathewson
932f2c79eb r13338@catbus: nickm | 2007-06-10 15:13:32 -0400 
Fix bug in 10533: put "opt v" line at the end of a routerstatus section; overwriting is bad.


svn:r10549
 2007-06-10 19:13:40 +00:00
Roger Dingledine
04995f197d more building blocks towards being able to fetch bridge descriptors 
svn:r10548
 2007-06-10 07:34:21 +00:00
Roger Dingledine
1ae7708ff8 discard the "bridge list" stubs that i hope i never need. 
svn:r10547
 2007-06-10 00:30:14 +00:00
Roger Dingledine
a97c3b8c2d Be clearer on the various roles for auth dir types. 
Bridge authorities no longer write bridge descriptors to their
cached-routers file -- this gets complex because of extrainfo documents.


svn:r10545
 2007-06-09 07:05:19 +00:00
Roger Dingledine
8dfde75ef6 don't complain when approved-routers isn't there and we 
don't need it.


svn:r10544
 2007-06-09 05:28:11 +00:00
Roger Dingledine
eebeda2c71 scrub out some more references to the misnamed 'bridge' concept 
svn:r10543
 2007-06-09 05:17:33 +00:00
Roger Dingledine
15270358eb bump to 0.2.0.2-alpha-dev 
svn:r10542
 2007-06-09 04:35:51 +00:00
Nick Mathewson
19389a3674 r13328@catbus: nickm | 2007-06-08 17:14:55 -0400 
Arg. Irix apparently #defines sa_family to something.  Thus, naming fields or variables "sa_family" will not work.


svn:r10541
 2007-06-08 21:14:58 +00:00
Nick Mathewson
1d6db7ec3d r13325@catbus: nickm | 2007-06-08 15:02:37 -0400 
Parse networkstatuses (v2, vote, and consensus) after generating them, and fail fast if there is a parse error.


svn:r10540
 2007-06-08 19:02:39 +00:00
Nick Mathewson
2bb7005481 r13317@catbus: nickm | 2007-06-08 14:39:59 -0400 
bugfix: we were undercounting the number of authorities that recommended any given version by 1.  Backport candidate.


svn:r10537
 2007-06-08 18:41:19 +00:00
Nick Mathewson
678110570a r13315@catbus: nickm | 2007-06-08 14:33:24 -0400 
Make versions get added to networkstatuses correctly again.


svn:r10535
 2007-06-08 18:41:14 +00:00
Nick Mathewson
171969656c r13314@catbus: nickm | 2007-06-08 14:30:31 -0400 
Enfore that known_flags in networkstatus votes must be unique.


svn:r10534
 2007-06-08 18:41:12 +00:00
Nick Mathewson
7a6f3cd223 r13313@catbus: nickm | 2007-06-08 14:23:11 -0400 
Refactor v3 vote generation code into "build a networkstatus_vote_t" and "format a networkstatus_vote_t".  This should make testing possible.


svn:r10533
 2007-06-08 18:41:09 +00:00
Nick Mathewson
1b200de0ef r13304@catbus: nickm | 2007-06-07 13:25:37 -0400 
Deprecate RedirectExits.


svn:r10526
 2007-06-07 17:26:19 +00:00
Nick Mathewson
529cbe34b0 r13292@catbus: nickm | 2007-06-06 17:34:15 -0400 
Check for non-standard SVK directories properly.  Inspired by debian bug #420899 and related discussion on SVK list.


svn:r10522
 2007-06-07 16:14:55 +00:00
Roger Dingledine
8db1b61a26 avoid leaking memory in a path never followed. pointed out 
by robert watson.


svn:r10521
 2007-06-07 15:07:33 +00:00
Nick Mathewson
6673d445f5 r13283@catbus: nickm | 2007-06-06 01:43:44 -0400 
Fix up a couple of loops flagged by -Wunsafe-loop-optimizations so that they are more readable (and more amenable to compilation)


svn:r10513
 2007-06-06 13:02:22 +00:00
Nick Mathewson
1a29d68081 r13276@catbus: nickm | 2007-06-05 19:45:33 -0400 
Remove another long-dead #if 0 I missed before


svn:r10511
 2007-06-06 04:51:33 +00:00
Nick Mathewson
d3b140b0de r13275@catbus: nickm | 2007-06-05 19:11:05 -0400 
Apply my sekrit "unused macro detector" script to hunt down some macros we didnt use.


svn:r10510
 2007-06-06 04:51:30 +00:00
Nick Mathewson
1866ad3506 r13274@catbus: nickm | 2007-06-05 19:06:30 -0400 
Remove some deadcode that seems unlikely to return


svn:r10509
 2007-06-06 04:51:25 +00:00
Nick Mathewson
0a27f02b9c r13267@catbus: nickm | 2007-06-05 16:54:20 -0400 
Man page and small tweaks for last patch.


svn:r10505
 2007-06-05 20:54:53 +00:00
Nick Mathewson
210beff55a r13266@catbus: nickm | 2007-06-05 16:38:08 -0400 
Patch from peter palfrader: control interface via unix domain socket


svn:r10504
 2007-06-05 20:54:49 +00:00
Nick Mathewson
f0345d46f6 r13256@catbus: nickm | 2007-06-05 10:57:41 -0400 
Mark fields that need to be ipv6-ified.


svn:r10503
 2007-06-05 20:54:23 +00:00
Peter Palfrader
b6c6dd7e55 Change an assert into a tor_assert 
svn:r10495
 2007-06-05 01:09:09 +00:00
Nick Mathewson
23ae5976f3 r13254@catbus: nickm | 2007-06-04 20:13:47 -0400 
When choosing a guard, weight by bandwidth.  Resolves bug 440.


svn:r10493
 2007-06-05 00:15:00 +00:00
Nick Mathewson
2e0713222b r13252@catbus: nickm | 2007-06-04 18:57:21 -0400 
Code to check signatures on consensus directories.


svn:r10492
 2007-06-04 22:57:23 +00:00
Nick Mathewson
8b0e6a4466 r13250@catbus: nickm | 2007-06-04 18:28:55 -0400 
Adapt code to parse v3 networkstatus votes so it can also parse a consensus.  Make networkstatus_vote_t the catch-all type for votes and conensuses.  Correct/clarify the second argument to directory-signature.


svn:r10491
 2007-06-04 22:29:00 +00:00
Nick Mathewson
8d1224eb51 r13248@catbus: nickm | 2007-06-04 15:53:23 -0400 
More code to generate a consensus from a list of votes.  Now, we handle Named, and we actually generate and sign the signed consensus.  Yippee.  Still needs testing.  Still not actually called.


svn:r10490
 2007-06-04 19:54:02 +00:00
Nick Mathewson
bb6f53d60c r13243@catbus: nickm | 2007-06-04 15:17:15 -0400 
Start of code to compute consensus network-status stuff from a bunch of votes.  Strangely, it does not yet feel like an enormous ugly hack. 


svn:r10489
 2007-06-04 19:19:01 +00:00
Peter Palfrader
32d12dcfbc Fix retry_all_listeners() and retry_listeners() description to match code. We are smarter than comparing lengths of want- and have-listeners. 
svn:r10487
 2007-06-04 16:58:57 +00:00
Peter Palfrader
502879e0b4 Remove force flag from retry_all_listeners() and retry_listeners(). It always was 0. 
svn:r10486
 2007-06-04 16:54:42 +00:00
Nick Mathewson
6faa9e2641 r13239@catbus: nickm | 2007-06-04 11:30:37 -0400 
Fix the fix for bug 445: set umask properly.  Also use open+fdopen rather than just umask+fopen, and create authority identity key with mode 400.


svn:r10485
 2007-06-04 15:30:40 +00:00
Roger Dingledine
80e675deb1 Stop tearing down the whole circuit when the user asks for a 
connection to a port that the hidden service didn't configure.
Resolves bug 444.


svn:r10478
 2007-06-04 03:13:13 +00:00
Nick Mathewson
cb0324c400 r13191@catbus: nickm | 2007-06-03 19:38:18 -0400 
Set umask(0700) when starting tor-gencert; resolves bug 445.


svn:r10475
 2007-06-03 23:38:20 +00:00
Nick Mathewson
6d447e04a2 r13189@catbus: nickm | 2007-06-03 19:08:01 -0400 
Oops. Only bind ports and start libevent if we are actually running Tor.


svn:r10474
 2007-06-03 23:08:07 +00:00
Nick Mathewson
d3ee41619c r13186@catbus: nickm | 2007-06-03 19:00:20 -0400 
Bind ports before setuid/setgid.


svn:r10473
 2007-06-03 23:00:26 +00:00
Nick Mathewson
147e439c94 r13174@catbus: nickm | 2007-06-03 17:39:20 -0400 
Patch from robert hogan: avoid crash when DNS port is set more than once.


svn:r10471
 2007-06-03 21:39:24 +00:00
Nick Mathewson
f4ce7f9c9b r13166@catbus: nickm | 2007-06-02 23:02:40 -0400 
First cut at code to parse and validate v3 networkstatus votes.


svn:r10461
 2007-06-03 03:05:10 +00:00
Nick Mathewson
e0d828299a r13165@catbus: nickm | 2007-06-02 22:55:22 -0400 
Remove an obsoleted function


svn:r10460
 2007-06-03 03:05:07 +00:00
Roger Dingledine
0b73569dc6 bump to 0.2.0.2-alpha and declare that today is the day 
svn:r10456
 2007-06-02 23:56:04 +00:00
Nick Mathewson
d216133c8e r13163@catbus: nickm | 2007-06-02 16:41:07 -0400 
We do "-alpha-dev" now, not "-alpha-cvs".


svn:r10455
 2007-06-02 20:41:10 +00:00
Roger Dingledine
f6880cbc6b bump to 0.2.0.1-alpha-cvs while we're in transition 
svn:r10454
 2007-06-02 20:22:42 +00:00
Roger Dingledine
1407cf9de3 fix up a comment 
svn:r10453
 2007-06-02 20:22:31 +00:00
Nick Mathewson
c2dc8f4623 r13158@catbus: nickm | 2007-06-02 11:40:05 -0400 
On systems with svk, do not clobber micro-revision.i when building from a tarball.


svn:r10452
 2007-06-02 15:40:10 +00:00
Nick Mathewson
aee7f01624 r13154@catbus: nickm | 2007-06-02 11:26:44 -0400 
Server-side support for If-Modified-Since in HTTP requsts for v1 stuff, and for network-status documents.


svn:r10451
 2007-06-02 15:26:57 +00:00
Nick Mathewson
8400cecb1d r13148@catbus: nickm | 2007-06-02 10:24:20 -0400 
Fix bug 441, 442, and possibly 417 (again).


svn:r10449
 2007-06-02 14:24:23 +00:00
Nick Mathewson
2ef3e7853b r13144@catbus: nickm | 2007-06-02 08:44:42 -0400 
Add some asserts to catch double-insert on routerlist.


svn:r10445
 2007-06-02 12:44:57 +00:00
Nick Mathewson
5b6d7f10f3 r13143@catbus: nickm | 2007-06-01 16:43:40 -0400 
Try to fix some mipspro compiler warnings. There will still be some left.


svn:r10444
 2007-06-02 12:44:54 +00:00
Nick Mathewson
7c3f418e39 r13139@catbus: nickm | 2007-06-01 14:02:40 -0400 
Add some ;trues, and tabify.


svn:r10441
 2007-06-01 18:02:41 +00:00
Nick Mathewson
6df38f52db r13137@catbus: nickm | 2007-06-01 13:49:34 -0400 
Ah. Of course.  You spell "is there an svn" as 'test -x "`which svn 2>&1`"'.  Perfectly reasonable.  Don't know why I didn't think of it in the first place.


svn:r10440
 2007-06-01 17:49:37 +00:00
Nick Mathewson
0af91800f9 r13131@catbus: nickm | 2007-06-01 06:20:29 -0400 
Test for ~/.svk/local, not ~/.svk.  Eschew use of test -a and test -o.  Bulletproof more against odd shells.


svn:r10439
 2007-06-01 10:20:37 +00:00
Roger Dingledine
e64750e9a3 bump to 0.2.0.1-alpha 
svn:r10437
 2007-06-01 07:33:39 +00:00
Nick Mathewson
6bb65fa371 r13121@catbus: nickm | 2007-05-31 20:06:40 -0400 
Oops. Different inet_ntop implementations seem to differ on whether, in an IPv6 address with a single "0" word, that word should be written as 0, or omitted. Fix the unit tests to account for that.


svn:r10432
 2007-06-01 00:06:45 +00:00
Roger Dingledine
b1ee20f0e8 trivial changes from my sandbox 
svn:r10429
 2007-05-31 23:57:46 +00:00
Nick Mathewson
3b4fa59b60 r13117@catbus: nickm | 2007-05-31 19:40:32 -0400 
Patch from Tup: treat RESOLVED_TYPE_ERROR_TRANSIENT as a SERVERFAILED, and RESOLVED_TYPE_ERROR as NOTEXIST.  Generate transient/nontransient errors more sensibly.  Set flags better on DNS replies.


svn:r10427
 2007-05-31 23:40:35 +00:00
Nick Mathewson
534c55f531 r13111@catbus: nickm | 2007-05-31 15:03:41 -0400 
Cleanup whitespace.


svn:r10425
 2007-05-31 19:03:49 +00:00
Nick Mathewson
71c0a13703 r13110@catbus: nickm | 2007-05-31 15:03:24 -0400 
Fix windows build.


svn:r10424
 2007-05-31 19:03:46 +00:00
Nick Mathewson
884cb0c7a1 r13109@catbus: nickm | 2007-05-31 14:59:30 -0400 
More code for voting and vote parsing (checkpointing)


svn:r10423
 2007-05-31 19:03:44 +00:00
Nick Mathewson
5d4b426a33 r13103@catbus: nickm | 2007-05-31 14:40:18 -0400 
Fix patch r10411; fix from robert hogan.


svn:r10422
 2007-05-31 18:48:31 +00:00
Nick Mathewson
77502ac82d r13102@catbus: nickm | 2007-05-31 13:56:25 -0400 
Make "authdir_newdesc rejected" work again.


svn:r10421
 2007-05-31 18:48:28 +00:00
Nick Mathewson
4061b2cbd1 r13101@catbus: nickm | 2007-05-31 12:57:42 -0400 
Unit tests [and debugging] for tor_inet_ntop() and tor_inet_pton()


svn:r10420
 2007-05-31 18:48:25 +00:00
Nick Mathewson
1cb1ebbfe0 r13090@catbus: nickm | 2007-05-30 03:17:57 -0400 
If the user makes a torrc that exceeds the bandwidth cap by one byte, let them have it.


svn:r10411
 2007-05-30 07:18:00 +00:00
Nick Mathewson
8b1e9398a8 r13079@catbus: nickm | 2007-05-29 17:05:38 -0400 
Oops. Authorities should recommend nodes as exits.


svn:r10403
 2007-05-29 21:05:49 +00:00
Nick Mathewson
4cd93bd9ec r13071@catbus: nickm | 2007-05-29 15:54:46 -0400 
Aaargh.  Revert accidentally-committed debugging code in last patch.


svn:r10400
 2007-05-29 19:54:54 +00:00
Nick Mathewson
1359871c14 r13070@catbus: nickm | 2007-05-29 15:53:21 -0400 
Fix handling of resolves with very long or otherwise malformed addresses, and comment dns_resolve better, and stop making what should be a BUG warning into an assert(0).  This fixes bug 427, which was introduced around 9900/9931/9932.  Not a backport candidate: 0.1.2.x never had this bug.


svn:r10399
 2007-05-29 19:54:51 +00:00
Nick Mathewson
3f9afa0625 r13068@catbus: nickm | 2007-05-29 14:58:13 -0400 
Add some code to mitigate bug 393: Choose at random from multiple hidden service ports with the same virtport.  This allows limited ad-hoc round-robining.


svn:r10398
 2007-05-29 18:58:16 +00:00
Nick Mathewson
e11a92bd54 r13058@catbus: nickm | 2007-05-29 14:39:53 -0400 
Note that the fix for bug 222 should technically be turned into a real fix, not a kludge, one of these days.


svn:r10397
 2007-05-29 18:39:59 +00:00
Nick Mathewson
c5b3a8db84 r13057@catbus: nickm | 2007-05-29 14:39:27 -0400 
fix for bug 439: make _sure_ *msg is set when we leave dirserv_add_multiple_descriptors().


svn:r10396
 2007-05-29 18:39:56 +00:00
Nick Mathewson
e5ed434c42 r13054@catbus: nickm | 2007-05-29 14:20:50 -0400 
An even better workaround for the probably-already-fixed bug 222.


svn:r10395
 2007-05-29 18:21:00 +00:00
Nick Mathewson
9d1af71b70 r13053@catbus: nickm | 2007-05-29 13:35:33 -0400 
Move connection_should_read_from_linked_conn into main.c, which is the only file that uses it.


svn:r10394
 2007-05-29 18:20:56 +00:00
Nick Mathewson
f89a3b1448 r13050@catbus: nickm | 2007-05-29 13:31:11 -0400 
Resolve all but 3 DOCDOCs.


svn:r10393
 2007-05-29 17:31:13 +00:00
Nick Mathewson
69c712f189 r13048@catbus: nickm | 2007-05-29 11:08:53 -0400 
Oops; better version of previous patch that does not get caught in an infinite loop.


svn:r10391
 2007-05-29 15:08:55 +00:00
Nick Mathewson
fd3aa5c85d r13046@catbus: nickm | 2007-05-29 11:07:12 -0400 
Stop adding bogus entries to lists in router_parse_list_from_string(). I wonder which bugs _that_ caused.


svn:r10390
 2007-05-29 15:07:16 +00:00
Nick Mathewson
916e98d3fa r13042@catbus: nickm | 2007-05-29 10:41:10 -0400 
oops; use tor_inet_aton rather than inet_aton in tor_inet_ntop.  Spotted by Li-Hui Zhou.


svn:r10389
 2007-05-29 14:41:24 +00:00
Nick Mathewson
63035cdb33 r13041@catbus: nickm | 2007-05-29 10:40:05 -0400 
More messing around to try to address possible root causes of bug 436.


svn:r10388
 2007-05-29 14:41:20 +00:00
Nick Mathewson
d509efb9b7 r13019@catbus: nickm | 2007-05-27 12:32:55 -0400 
Merge an evdns fix from libevent r357: "evdns_shutdown fix from adam langley.


svn:r10387
 2007-05-29 14:41:16 +00:00
Peter Palfrader
3425f2c11f Segfault less. Somebody needs to look over why exactly this helps. re #436 
svn:r10376
 2007-05-28 21:34:42 +00:00
Roger Dingledine
64b0d7202e also remove these obsolete torrcs 
svn:r10362
 2007-05-27 06:07:51 +00:00
Roger Dingledine
1ab216eb2f what the heck is this obsolete dirservers file still doing here? 
svn:r10361
 2007-05-27 06:06:01 +00:00
Roger Dingledine
c1101fceeb we were leaking a few megabytes a minute checking signatures 
svn:r10359
 2007-05-27 04:38:50 +00:00
Roger Dingledine
e13bf01a9f fix a seg fault when my auth dirserver accepted a posted descriptor 
(dirserv_add_multiple_descriptors doesn't set msg if there's no
failure.)


svn:r10358
 2007-05-27 03:41:09 +00:00
Roger Dingledine
c8fd65a936 If Tor is invoked from something that isn't a shell (e.g. Vidalia), 
now we expand "-f ~/.tor/torrc" correctly. Suggested by Matt Edman.


svn:r10351
 2007-05-26 08:04:15 +00:00
Nick Mathewson
b0be93c8b0 r12988@catbus: nickm | 2007-05-25 20:15:56 -0400 
socklen_t is a silly type anyway. Just use int as the argument for evdns_server_request_get_requesting_addr.


svn:r10347
 2007-05-26 00:15:58 +00:00
Roger Dingledine
0f71ade42f fix compile on bsd 
svn:r10339
 2007-05-25 21:56:47 +00:00
Roger Dingledine
0c047b87f5 polish r9933-r9994 
svn:r10335
 2007-05-25 19:41:31 +00:00
Roger Dingledine
a19d131ed7 i suspect we would trigger asserts if we answer a cached 
resolve request. this should help that.


svn:r10334
 2007-05-25 19:30:07 +00:00
Roger Dingledine
32f5e19168 remove an obsolete notion that we judge runningness based on 
whether we have a connection open to the server right now.


svn:r10333
 2007-05-25 19:22:26 +00:00
Nick Mathewson
368eb6a97a r12964@catbus: nickm | 2007-05-25 14:49:23 -0400 
hack to make reverse lookups work with dnsport.  note that it is a hack. note some trouble spots.


svn:r10332
 2007-05-25 18:49:26 +00:00
Roger Dingledine
ce59d5a632 also change purpose_is_private to purpose_needs_anonymity 
svn:r10331
 2007-05-25 18:40:09 +00:00
Roger Dingledine
6e216ed7ef karsten got confused by private_connection, so try calling 
it anonymized_connection instead.


svn:r10330
 2007-05-25 18:25:33 +00:00
Nick Mathewson
ba4969a59e r12959@catbus: nickm | 2007-05-25 14:22:33 -0400 
The second time that we resolve a.com and get 1.2.3.4, return an A record mapping (a->1.2.3.4), not mapping (1.2.3.4->1.2.3.4).


svn:r10329
 2007-05-25 18:22:43 +00:00
Nick Mathewson
527fbc304e r12958@catbus: nickm | 2007-05-25 14:19:29 -0400 
Fix more dnsport bugs: set state correctly, and actually cache the answers.


svn:r10328
 2007-05-25 18:22:42 +00:00
Nick Mathewson
5f226f130c r12957@catbus: nickm | 2007-05-25 14:11:02 -0400 
Fix a dnsserv bug: mark the connectino as "finished handshaking" once dnsserv_resolved is called.


svn:r10327
 2007-05-25 18:22:39 +00:00
Nick Mathewson
bb524e99c9 r12955@catbus: nickm | 2007-05-25 13:17:30 -0400 
First bare stubs of ipv6 work: commit some (untested, hence doublessly broken) implementations of inet_ntop/pton for systems that lack them.


svn:r10326
 2007-05-25 18:22:37 +00:00
Nick Mathewson
39fe91b9a2 r12946@catbus: nickm | 2007-05-25 10:46:50 -0400 
Add an AutomapHostsOnResolve option.  It seems to work.


svn:r10324
 2007-05-25 14:48:16 +00:00
Nick Mathewson
e9c294654d r12945@catbus: nickm | 2007-05-25 10:37:12 -0400 
Add a "force" option to tor-resolve so we can make it look up .onion addresses if we know that this will create a virtual mapping we want.


svn:r10323
 2007-05-25 14:48:12 +00:00
Roger Dingledine
7127c30f46 irix64's cc doesn't think hibernate_state_t is necessarily an int. 
good point.


svn:r10320
 2007-05-24 23:51:08 +00:00
Roger Dingledine
42d7b0877d forward-port r10318 
svn:r10319
 2007-05-24 23:39:04 +00:00
Nick Mathewson
703bf19620 r12942@catbus: nickm | 2007-05-24 16:31:22 -0400 
Well, that was easier than I thought it would be.  Tor is now a DNS proxy as well as a socks proxy.  Probably some bugs remain, but since it A) has managed to resolve one address for me successfully, and B) will not affect anybody who leaves DNSPort unset, it feel like a good time to commit.


svn:r10317
 2007-05-24 20:31:30 +00:00
Nick Mathewson
17830bc03b r12941@catbus: nickm | 2007-05-24 16:25:00 -0400 
Fix some eventdns dns server bugs, and add a new eventdns function to get the address of whoever requested this lookup.


svn:r10316
 2007-05-24 20:31:27 +00:00
Nick Mathewson
a312afd67e r12936@catbus: nickm | 2007-05-24 14:12:34 -0400 
Review XXXX comments without a version; upgrade some to XXXX020.


svn:r10315
 2007-05-24 18:12:52 +00:00
Nick Mathewson
56aefe8d23 r12935@catbus: nickm | 2007-05-24 14:12:04 -0400 
dir-signing-key should never take arguments.


svn:r10314
 2007-05-24 18:12:44 +00:00
Nick Mathewson
9aaf3d182f r12934@catbus: nickm | 2007-05-24 14:11:18 -0400 
When freeing slack buffers, free the buffers at the end of the freelist first.


svn:r10313
 2007-05-24 18:12:41 +00:00
Nick Mathewson
79707437d9 r12933@catbus: nickm | 2007-05-24 14:10:28 -0400 
Optimize digestmap_set, since it sometimes shows up in profiles.  Seems to work so far, but it isnt the prettiest thing ever.


svn:r10312
 2007-05-24 18:12:38 +00:00
Nick Mathewson
687461d36c r12920@catbus: nickm | 2007-05-24 13:12:52 -0400 
and remove an XXX012.


svn:r10308
 2007-05-24 17:13:08 +00:00
Nick Mathewson
212a3c3478 r12919@catbus: nickm | 2007-05-24 13:04:56 -0400 
backport candidate: Warn when using a version of libevent before 1.3b to run a server on osx or bsd: these versions of libevent interact badly with userspace threads.


svn:r10307
 2007-05-24 17:13:05 +00:00
Nick Mathewson
4c6398a8f0 r12918@catbus: nickm | 2007-05-24 12:52:40 -0400 
Make reset_download_failures() reset extrainfo download status too.


svn:r10306
 2007-05-24 17:13:02 +00:00
Nick Mathewson
3980ebd6a1 r12917@catbus: nickm | 2007-05-24 12:48:47 -0400 
Put the hash-as-signed, not the raw hash, in the signed_descriptor_digest field of our own descriptor. Backport candidate; probably harmless though.


svn:r10305
 2007-05-24 17:13:00 +00:00
Nick Mathewson
d3d86b17a7 r12916@catbus: nickm | 2007-05-24 12:43:45 -0400 
Add math functions to round values to the nearest power of 2.  Make mempools more careful about making sure that the size of their chunks is a little less than a power of 2, not a little more.


svn:r10304
 2007-05-24 17:12:57 +00:00
Nick Mathewson
d0a5c4f984 r12915@catbus: nickm | 2007-05-24 12:12:34 -0400 
Do not send a warning when somebody uploads an extrainfo that we will reject, if it happens to be newer than our current routerdesc.


svn:r10303
 2007-05-24 17:12:54 +00:00
Nick Mathewson
ca9e13f2a0 r12906@catbus: nickm | 2007-05-22 20:43:13 -0400 
s/32/64/;  s/breaks/works/;


svn:r10297
 2007-05-23 00:43:20 +00:00
Roger Dingledine
e583827d60 new ip addresses for moria1 and moria2; new ports for moria2 
svn:r10296
 2007-05-22 23:51:39 +00:00
Nick Mathewson
38300735cd r12902@catbus: nickm | 2007-05-22 14:52:29 -0400 
First draft of code to generate votes. needs testing. does not yet upload or serve votes.  Shares most of its code with the old generate_v2_networkstatus.


svn:r10295
 2007-05-22 18:52:32 +00:00
Nick Mathewson
9e0acc0c11 r12899@catbus: nickm | 2007-05-22 13:51:26 -0400 
Extract common code from networkstatus_getinfo_helper_single() and generate_v2_networkstatus().


svn:r10294
 2007-05-22 17:58:30 +00:00
Nick Mathewson
c9fa4e6583 r12898@catbus: nickm | 2007-05-22 13:11:04 -0400 
More v3 directory code: have authorities load certificates; have everybody store certificates to disk and load them; provide a way to configure v3 authorities.


svn:r10293
 2007-05-22 17:58:25 +00:00
Nick Mathewson
6975a093e9 r12853@catbus: nickm | 2007-05-22 11:36:54 -0400 
Make connection_array into a smartlist.


svn:r10292
 2007-05-22 15:49:14 +00:00
Nick Mathewson
e935d73b34 r12852@catbus: nickm | 2007-05-22 11:00:27 -0400 
Use svn revisions consistently throughout all log messages.


svn:r10291
 2007-05-22 15:48:46 +00:00
Nick Mathewson
4ec5e139c8 r12850@catbus: nickm | 2007-05-21 22:20:42 -0400 
Partial backport candidate: do not rely on finding a \0 after an mmaped() router/extrainfo file.  Also, set journal length correctly when starting up.


svn:r10248
 2007-05-22 02:20:52 +00:00
Nick Mathewson
d23cb33a1a r12846@catbus: nickm | 2007-05-21 21:55:15 -0400 
Oops; it is possible to have an empty store.


svn:r10247
 2007-05-22 01:55:50 +00:00
Nick Mathewson
0cb342e859 r12844@catbus: nickm | 2007-05-21 21:52:19 -0400 
Oops. It compiles better when you spell the fields right.


svn:r10245
 2007-05-22 01:52:22 +00:00
Nick Mathewson
32c8d94c12 r12842@catbus: nickm | 2007-05-21 21:51:45 -0400 
Partial backport candidate. Fix issue noted in r10241: stores were rebuilt too often.  Also notes dropped bytes better.


svn:r10244
 2007-05-22 01:51:53 +00:00
Roger Dingledine
590a98ff37 clean up r10240 so we avoid the exit node itself too 
svn:r10242
 2007-05-22 01:20:23 +00:00
Roger Dingledine
b89ad9eb1b mark a bug for nick to tackle -- we're rebuilding our router store more 
often than we need to. reported by lodger.


svn:r10241
 2007-05-22 01:17:08 +00:00
Roger Dingledine
6ede110c4d When choosing an entry guard for our circuit, avoid using guards 
that are in the same family as the chosen exit -- not just guards
that are exactly the chosen exit. (Reported by lodger.)


svn:r10240
 2007-05-22 01:01:24 +00:00
Roger Dingledine
82054e0dd2 Make the NodeFamilies config option work. (Reported by 
lodger -- it has never actually worked, even though we added it
in Oct 2004.)


svn:r10238
 2007-05-22 00:46:55 +00:00
Nick Mathewson
de5194eeaa r13025@Kushana: nickm | 2007-05-21 17:40:56 -0400 
Bugfix and possible backport candidate: use the same logic as in read_all when reading resolv.conf.  Maybe this fixes bug 433.


svn:r10237
 2007-05-21 21:48:02 +00:00
Peter Palfrader
d2f7a9d0cc Hopefully fix #429 for good by actually using, not just figuring out, the correct mmap 
svn:r10233
 2007-05-21 12:14:45 +00:00
Nick Mathewson
a4f5b99e61 r13023@Kushana: nickm | 2007-05-20 16:16:36 -0400 
More bulletproofing on bug 429


svn:r10231
 2007-05-20 20:16:45 +00:00
Nick Mathewson
21a72520ce r13021@Kushana: nickm | 2007-05-20 14:03:10 -0400 
Provide actual reasons when dropping an uploaded extrainfo for incompatibility; also, clean whitespace.


svn:r10230
 2007-05-20 18:03:26 +00:00
Nick Mathewson
5364833be0 r13017@Kushana: nickm | 2007-05-20 13:40:45 -0400 
Address points in r10227.


svn:r10229
 2007-05-20 17:43:55 +00:00
Nick Mathewson
bc26f28865 svn:r10228 2007-05-20 17:43:29 +00:00
Roger Dingledine
ddd0054a85 point out two remote crash bugs, a memory leak, and a few other 
items we should probably look into.


svn:r10227
 2007-05-20 14:15:23 +00:00
Nick Mathewson
0b661f6575 r12818@catbus: nickm | 2007-05-20 01:15:50 -0400 
Look for extrainfo bodies in the extrainfo mmap, not in the descriptor mmap.  Duh.  Should fix bug 429.


svn:r10226
 2007-05-20 05:15:53 +00:00
Peter Palfrader
6d46ece6ac Fix a loop in routerlist_assert_ok() 
svn:r10224
 2007-05-19 21:14:17 +00:00
Nick Mathewson
5f58bee0b0 r12812@catbus: nickm | 2007-05-19 16:17:36 -0400 
Fix compilation with -O0; add unit tests for swap and shuffle.


svn:r10223
 2007-05-19 20:17:37 +00:00
Nick Mathewson
6f8866a817 r12810@catbus: nickm | 2007-05-19 16:08:42 -0400 
Fix bugs in extrainfo_insert, and change it to use desc_by_eid_map.


svn:r10222
 2007-05-19 20:08:44 +00:00
Nick Mathewson
4d3ec5919e r12808@catbus: nickm | 2007-05-19 14:48:51 -0400 
Fix another consistency error. 


svn:r10221
 2007-05-19 18:48:53 +00:00
Nick Mathewson
48e30ce2c7 r12805@catbus: nickm | 2007-05-19 14:31:00 -0400 
Fix a groovy memory corruption bug in routerlist_replace.


svn:r10220
 2007-05-19 18:31:04 +00:00
Nick Mathewson
07199e3d09 r12804@catbus: nickm | 2007-05-19 14:21:18 -0400 
Disable a blatantly incorrect control event with potential for memory corruption.


svn:r10219
 2007-05-19 18:31:02 +00:00
Nick Mathewson
0a27b53252 r12802@catbus: nickm | 2007-05-19 14:12:27 -0400 
clear some ram when freeing it; add some more checks to assert_routerlist_ok.


svn:r10218
 2007-05-19 18:12:31 +00:00
Nick Mathewson
58d27cfc29 r12800@catbus: nickm | 2007-05-18 20:45:15 -0400 
Possible fix for bug 417 and bug 404: do not insert our routerinfo directly; instead, re-parse it first.


svn:r10217
 2007-05-19 00:45:17 +00:00
Nick Mathewson
61a116b3da r12798@catbus: nickm | 2007-05-18 20:31:54 -0400 
Yet more debugging code to track down 417/404, inspired by a fun core from arma.


svn:r10216
 2007-05-19 00:32:00 +00:00
Nick Mathewson
adf95e7f00 r12794@catbus: nickm | 2007-05-18 20:24:26 -0400 
Make caches-extra-info lines parseable.


svn:r10215
 2007-05-19 00:24:29 +00:00
Roger Dingledine
84c3a19170 found this in my sandbox 
svn:r10214
 2007-05-19 00:14:34 +00:00
Nick Mathewson
7a61357250 r12790@catbus: nickm | 2007-05-18 17:24:26 -0400 
Fix build on gcc 4.2


svn:r10212
 2007-05-18 21:24:37 +00:00
Nick Mathewson
e476e61ce0 r12982@Kushana: nickm | 2007-05-18 15:15:14 -0400 
Partial backport candidate: We had a bug where we were downloading descriptors by descriptor digest, but trying to look them up by identity fingerprint when updating their failure count and next retry time.  (Also use correct backoff logic for extrainfo code.)  Needs testing, doubtless.


svn:r10210
 2007-05-18 21:19:53 +00:00
Nick Mathewson
ec55cf526d r12981@Kushana: nickm | 2007-05-18 14:12:19 -0400 
First cut at code to download extra-info docs.  Also note a bad bug in directory.c (look for the string BUG BUG BUG).


svn:r10209
 2007-05-18 21:19:19 +00:00
Nick Mathewson
a187704872 r12980@Kushana: nickm | 2007-05-18 14:11:05 -0400 
Add a "swap" function to smartlist, add a "shuffle" function for smartlist to crypto.c, and make appropriate hashtable functions be more const.


svn:r10208
 2007-05-18 21:19:14 +00:00
Nick Mathewson
836328be2e r12777@catbus: nickm | 2007-05-16 21:52:23 -0400 
Fix dumb bug introduced in r10199


svn:r10202
 2007-05-17 01:52:26 +00:00
Nick Mathewson
b4bd9f772c r12771@catbus: nickm | 2007-05-16 18:12:32 -0400 
Make -Wstrict-overflow=5 happy with GCC 4.2.  It is kind of a pain, but it does agood job of letting us know where we can make our code better by simplifying dependent conditionals.


svn:r10201
 2007-05-16 22:16:13 +00:00
Nick Mathewson
2988d797eb r12770@catbus: nickm | 2007-05-16 17:49:26 -0400 
Move around field order a little, in order to compact some structures. (Thanks to -Wpadded)


svn:r10200
 2007-05-16 22:15:57 +00:00
Nick Mathewson
807adfc879 r12769@catbus: nickm | 2007-05-16 17:32:01 -0400 
Fix warnings from -Wunsafe-loop-optimizations, which incidentally turned up a logic bug in connection_or_flush_from_first_active_circuit that would overcount the number of cells flushed.


svn:r10199
 2007-05-16 22:15:48 +00:00
Nick Mathewson
b837191fd0 r12768@catbus: nickm | 2007-05-16 17:25:33 -0400 
Fix GCC warnings related to local parameters/variables getting shadowed.


svn:r10198
 2007-05-16 22:15:14 +00:00
Nick Mathewson
e043b86f47 r12764@catbus: nickm | 2007-05-15 17:17:39 -0400 
Enable (and cope with) more GCC 4.2 warnings.


svn:r10196
 2007-05-15 21:17:48 +00:00
Nick Mathewson
bfdc366037 r12763@catbus: nickm | 2007-05-15 05:29:33 -0400 
Make --enable-gcc-warnings happy on the upcoming gcc 4.2


svn:r10195
 2007-05-15 21:17:42 +00:00
Nick Mathewson
ca32b4d5b5 r12761@catbus: nickm | 2007-05-15 03:13:52 -0400 
Be a lot smarter when parsing lists of routers and extrainfos.


svn:r10193
 2007-05-15 07:13:56 +00:00
Nick Mathewson
a7514649c3 r12758@catbus: nickm | 2007-05-14 15:19:29 -0400 
Cleanup, lock-down, and refactor bits of routerparse.c: use a single unified function to check all signatures. Fix all DOCDOCs. Remove some old dead debugging code. Enforce some parsing rules better.


svn:r10192
 2007-05-14 22:51:05 +00:00
Roger Dingledine
37519d993d backport candidate: seems to me that r10153 won't work without 
this patch too.


svn:r10187
 2007-05-14 08:09:12 +00:00
Nick Mathewson
5f9d4d0587 r12750@catbus: nickm | 2007-05-13 10:08:13 -0400 
Fix compilation in connection_edge.c


svn:r10186
 2007-05-13 20:24:43 +00:00
Roger Dingledine
440b7f0c70 polish r9726-r9903 
svn:r10182
 2007-05-13 09:25:06 +00:00
Roger Dingledine
346826d97b If a directory authority is down, skip it when deciding where to get 
networkstatus objects or descriptors. Otherwise we keep asking
every 10 seconds forever.
(adapted from r9880)


svn:r10175
 2007-05-12 23:22:27 +00:00
Nick Mathewson
11f3e894d3 r12708@catbus: nickm | 2007-05-10 15:18:08 -0400 
Patch from shibz: implement a getinfo status/version/... so a controller can tell whether the current version is recommended, whether any versions are good, and how many authorities agree.


svn:r10162
 2007-05-10 19:30:02 +00:00
Nick Mathewson
e3b2a7b53b r12935@Kushana: nickm | 2007-05-10 11:25:09 -0400 
Make buffer unit tests pass again


svn:r10158
 2007-05-10 15:25:40 +00:00
Roger Dingledine
de11011b1b backport candidate: when we have k non-v2 authorities in our 
dirservers lines, we ignored as many as k v2 authorities while
updating our network-statuses.

(not a problem right now since we have zero non-v2 authorities.
but if we ever change that...)


svn:r10157
 2007-05-10 10:01:53 +00:00
Roger Dingledine
4e9a008e66 Backport candidate: if all of our dirservers have given us 
bad or no networkstatuses lately, then stop hammering them
once per minute even if we think they're failed.


svn:r10156
 2007-05-10 09:34:34 +00:00
Roger Dingledine
5ffabd4de4 backport candidate: 
If a directory server runs out of space in the connection table
as it's processing a begin_dir request, it will free the exit stream
but leave it attached to the circuit, leading to unpredictable
behavior. (Reported by seeess, fixes bug 425.)


svn:r10154
 2007-05-10 08:53:05 +00:00
Roger Dingledine
cd23b65a07 Backport candidate: count it as a failure if we fetch a valid 
network-status but we don't want to keep it. Otherwise we'll keep fetching
it and keep not wanting to keep it. Fixes part of bug 422.


svn:r10153
 2007-05-10 05:12:20 +00:00
Roger Dingledine
8e8144cd58 fix a printf size_t/int mismatch from r10150 
svn:r10152
 2007-05-10 04:04:44 +00:00
Roger Dingledine
de6b3512e9 move a few more situations over to the authority_type_t bitfield 
svn:r10151
 2007-05-10 04:01:28 +00:00
Nick Mathewson
34a09c24b5 r12706@catbus: nickm | 2007-05-09 18:39:46 -0400 
Keep two freelists for buffer ram chunks: one of 4k chunks, and one of 16k chunks.  Also, document the whole business.


svn:r10150
 2007-05-09 22:39:49 +00:00
Nick Mathewson
b248ed620f r12704@catbus: nickm | 2007-05-09 17:43:34 -0400 
Periodically clean the freelist of buffer memory chunks.


svn:r10149
 2007-05-09 21:43:41 +00:00
Nick Mathewson
a7696a936d r12700@catbus: nickm | 2007-05-09 17:22:53 -0400 
[Backport candidate] On windows, open cached-routers with the sharing mode "FILE_SHARE_READ so that other processes can read it while Tor is running. (Reported by Janbar). 


svn:r10148
 2007-05-09 21:22:56 +00:00
Nick Mathewson
ceac39aa8a r12697@catbus: nickm | 2007-05-09 00:15:40 -0400 
Change authority_type_t to a set of flags; use it more consistently.


svn:r10144
 2007-05-09 04:15:46 +00:00
Roger Dingledine
66f9240eb5 complain when we try to upload to, say, bridge authorities, 
yet we didn't configure any first.


svn:r10143
 2007-05-09 02:20:03 +00:00
Roger Dingledine
07bf274d98 Interim commit: new config options Bridge and UseBridges. 
It is becoming increasingly clear to me that bridges should
be a special case of entry guards, not a whole separate pile
of nearly identical functions.


svn:r10141
 2007-05-08 11:28:05 +00:00
Roger Dingledine
d136f2a7b2 When we are reporting the DirServer line we just parsed, we were 
logging the second stanza of the key fingerprint, not the first.


svn:r10140
 2007-05-08 10:33:46 +00:00
Roger Dingledine
54f5ab39b3 record the router purpose at each step of the circuit path. 
i have the feeling this will come in handy.


svn:r10139
 2007-05-08 10:11:53 +00:00
Roger Dingledine
1d3bb103a4 clean up some function argument names 
svn:r10138
 2007-05-08 10:01:33 +00:00
Roger Dingledine
a201861dc2 use the new _PublishServerDescriptor to publish descriptors either 
to v2 authorities or to bridge authorities, depending on config.


svn:r10137
 2007-05-08 09:13:30 +00:00
Roger Dingledine
e4f40dd794 Change the PublishServerDescriptor config option from a boolean 
into a string: "v1", "v2", bridge", "". Continue to support
"0" and "1".


svn:r10136
 2007-05-08 09:09:26 +00:00
Nick Mathewson
89753e2163 r12676@catbus: nickm | 2007-05-07 13:11:38 -0400 
When we cannot find a micro-revision number, do not overwrite an already-present micro-revision.i.


svn:r10134
 2007-05-07 17:11:53 +00:00
Roger Dingledine
95ead29574 prepare directory_post_to_dirservers() to hear what sort of 
dir authority we'd like to upload to. at some point we should
pick a config option to say that in, for bridges.


svn:r10129
 2007-05-07 09:28:48 +00:00
Roger Dingledine
f8a8b27dd2 add a 'bridge' flag for dirserver config entries 
svn:r10128
 2007-05-07 08:26:50 +00:00
Roger Dingledine
43411ceed3 Implement "getinfo status/circuit-established" 
svn:r10120
 2007-05-05 22:51:02 +00:00
Roger Dingledine
713626bd73 make it work on windows/etc again, i presume 
svn:r10118
 2007-05-04 10:43:01 +00:00
Roger Dingledine
10efbed2f5 ok, i'm not so good at counting 
svn:r10117
 2007-05-04 10:39:17 +00:00
Roger Dingledine
0ce53ca817 on the theory that my client_used hack is here to stay at least for the 
next little while, make it only take effect _when there's an attached
origin circuit_, rather than from the first attached origin circuit
until death of the conn.


svn:r10116
 2007-05-04 10:34:47 +00:00
Roger Dingledine
462dfe2012 make MaxAdvertisedBandwidth into a legal default 
svn:r10115
 2007-05-04 09:25:23 +00:00
Roger Dingledine
b1d93df038 if you're using relaybandwidthrate and relaybandwidthburst, make 
sure that's reflected in your router descriptor.


svn:r10114
 2007-05-04 09:20:13 +00:00
Roger Dingledine
dc795203aa early skeletal support for running a bridge directory authority 
svn:r10112
 2007-05-04 08:04:27 +00:00
Roger Dingledine
d112e7b1ad fix some code comments, a wrapper, and add a todo item 
svn:r10111
 2007-05-04 07:24:01 +00:00
Roger Dingledine
dfe93fb386 whoops, i missed main.c in my r10092 
svn:r10098
 2007-05-02 21:56:32 +00:00
Nick Mathewson
e2a49ed2f4 r12639@catbus: nickm | 2007-05-02 17:37:49 -0400 
Start implementing key certificate parsing.  Note TODO items for combined 101/103.


svn:r10097
 2007-05-02 21:37:55 +00:00
Nick Mathewson
9279c1d5fe r12638@catbus: nickm | 2007-05-02 17:37:30 -0400 
Remove the "RSA keys are 128-bits" assumption from crypto.c


svn:r10096
 2007-05-02 21:37:53 +00:00
Nick Mathewson
da758f4a18 r12634@catbus: nickm | 2007-05-02 15:13:13 -0400 
Shell tweaks suggested by weasel.


svn:r10094
 2007-05-02 19:13:15 +00:00
Nick Mathewson
744d955bb3 r12632@catbus: nickm | 2007-05-02 14:59:55 -0400 
Fix compilation-breaking r10092.


svn:r10093
 2007-05-02 18:59:57 +00:00
Roger Dingledine
1b95bbdba6 New config option V2AuthoritativeDirectory that all directory 
authorities should set. This will let future authorities choose 
not to serve V2 directory information.

Also, go through and revamp all the authdir_mode stuff so it tries
to do the right thing if you're an auth but not a V1 or V2 auth.


svn:r10092
 2007-05-02 09:12:04 +00:00
Nick Mathewson
47d21abf15 r12627@catbus: nickm | 2007-05-01 16:42:21 -0400 
Oops; downgrade a message to INFO.


svn:r10090
 2007-05-01 20:42:23 +00:00
Nick Mathewson
26abac8c4c r12625@catbus: nickm | 2007-05-01 16:41:23 -0400 
Remove the _UploadExtraInfo option, since I tried turning it on and moria[12] seem not to have exploded.


svn:r10089
 2007-05-01 20:41:27 +00:00
Nick Mathewson
979b90001b r12622@catbus: nickm | 2007-05-01 16:29:19 -0400 
Look at the version in the routerinfo as well as the versino in the networkstatus when deciding whether to upload extrainfo


svn:r10088
 2007-05-01 20:29:32 +00:00
Nick Mathewson
c9c0d2846d r12621@catbus: nickm | 2007-05-01 16:22:56 -0400 
Authority patch; backport candidate: include micro-versions in network status documents.


svn:r10087
 2007-05-01 20:29:26 +00:00
Nick Mathewson
89ab267cfb r12619@catbus: nickm | 2007-05-01 16:13:42 -0400 
Add code to upload extrainfos to authorities running 0.2.0.0-alpha-dev (r10070) or later.


svn:r10086
 2007-05-01 20:13:49 +00:00
Nick Mathewson
0faaa16b0c r12615@catbus: nickm | 2007-05-01 09:48:45 -0400 
Only replace micro-revision.i if it changes.


svn:r10085
 2007-05-01 13:48:49 +00:00
Nick Mathewson
8f94f0540f r12611@catbus: nickm | 2007-04-30 22:49:00 -0400 
For reasons which make sense to somebody, I'm sure, mingw gcc wants the libraries to appear at the end of the command line.  This is done by specifying them with LDADD in Makefile.am, not LDFLAGS.
 If anybody can explain to me why mingw thinks "gcc -o foo foo.o -lbar" is fine, whereas "gcc -lbar -o foo foo.o" is Doubleplusbad UnMingwThink, I'd quite appreciate it.  Until then, I'll just do what seems to work, and hope we don't blunder across any other great slumbering cthonian deities of arbitrary syntax.


svn:r10082
 2007-05-01 02:53:32 +00:00
Nick Mathewson
fa39336e65 r12607@catbus: nickm | 2007-04-30 21:36:28 -0400 
More attempt to fix win32 building.  This time, with extra linking.


svn:r10080
 2007-05-01 01:36:32 +00:00
Nick Mathewson
bbd4ef1cd1 r12605@catbus: nickm | 2007-04-30 21:10:48 -0400 
Add an expiry date to key certificates.


svn:r10079
 2007-05-01 01:10:50 +00:00
Roger Dingledine
e9c4dd1304 more cleanups on the hsusage patch 
svn:r10077
 2007-04-30 23:25:22 +00:00
Roger Dingledine
590c6ff33d identify the exit node correctly when we timeout and detach 
from a circuit, even if the exit node is in the middle.

there are probably a few more places that need this fix too.


svn:r10076
 2007-04-30 23:24:38 +00:00
Nick Mathewson
95734e73ff r12596@catbus: nickm | 2007-04-30 18:42:44 -0400 
New tool to generate key certificates as in proposal 103. needs cleanup


svn:r10075
 2007-04-30 22:43:01 +00:00
Nick Mathewson
6a27dd8284 r12595@catbus: nickm | 2007-04-30 18:32:34 -0400 
Move private function declarations from crypto.c into a new #ifdef CRYPTO_PRIVATE block in crypto.h


svn:r10074
 2007-04-30 22:42:50 +00:00
Nick Mathewson
22f2f30a33 r12591@catbus: nickm | 2007-04-30 16:50:03 -0400 
Minimize the libraries that we link things against: there is no reason to link tor-resolve against zlib, openssl, or libevent, for example.


svn:r10072
 2007-04-30 20:50:09 +00:00
Nick Mathewson
e97a6dd01f r12587@catbus: nickm | 2007-04-30 15:47:39 -0400 
Backport candidate: correctly set the purpose of routers that are inserted by the controller with purpose=controller.


svn:r10071
 2007-04-30 19:48:45 +00:00
Nick Mathewson
0390a0499c r12586@catbus: nickm | 2007-04-30 15:43:05 -0400 
More work for proposal 104: actually cache extrainfo documents to disk, and reload the cache properly.


svn:r10070
 2007-04-30 19:48:39 +00:00
Nick Mathewson
ae40e7f633 r12585@catbus: nickm | 2007-04-30 14:38:37 -0400 
(Needs review.) Allow directory authorities to accept multiple router descriptors and extra info documents in a single POST.  This will make implementing the client side of proposal 104 a lot simpler.


svn:r10069
 2007-04-30 19:48:33 +00:00
Nick Mathewson
b27b09ae1e r12581@catbus: nickm | 2007-04-30 13:39:21 -0400 
Minor cleanups on hidden service usage patch from Karsten: tidy documentation; make free_all idempotent (and safe to call even if we have not yet initialized rephist); and stop using "l" as a variable name (it is too easy to confuse with "1").


svn:r10068
 2007-04-30 17:46:19 +00:00
Nick Mathewson
18ba9fe81f r12580@catbus: nickm | 2007-04-30 13:29:05 -0400 
Initial version of patch from Karsten Loesing: Add an HSAuthorityRecordStats option to track statistics of overall hidden service usage without logging information that would be useful to an attacker.


svn:r10067
 2007-04-30 17:46:13 +00:00
Nick Mathewson
6875559c49 r12579@catbus: nickm | 2007-04-30 13:26:53 -0400 
Oops. Routerlist_check_bug_417 should work even if we are not on a server.


svn:r10066
 2007-04-30 17:46:11 +00:00
Nick Mathewson
f2db099fc0 r12571@catbus: nickm | 2007-04-30 10:51:52 -0400 
Check for more HAVE_* header defines when building eventdns.c


svn:r10063
 2007-04-30 14:52:07 +00:00
Nick Mathewson
ee5a378665 r12570@catbus: nickm | 2007-04-30 10:49:50 -0400 
Add an extra lock to try to get unit tessts passing reliably again.


svn:r10062
 2007-04-30 14:52:05 +00:00
Nick Mathewson
566cdcd0c2 r12569@catbus: nickm | 2007-04-30 10:48:51 -0400 
Do not use micro-revision.i on MSVC; it will only be useful to people who have make.


svn:r10061
 2007-04-30 14:52:02 +00:00
Nick Mathewson
5b26a076c6 Oops; the "not in the routerlist" value for routerinfo_t.routerlist_index is -1, not 0. 
svn:r10060
 2007-04-30 14:32:22 +00:00
Nick Mathewson
65daa191fe r12567@catbus: nickm | 2007-04-30 10:26:35 -0400 
Suggested by weasel: Add a fast function to check for the common failure mode for bug 417/404, and call it a lot.


svn:r10059
 2007-04-30 14:26:38 +00:00
Nick Mathewson
43385b9bc9 r12565@catbus: nickm | 2007-04-30 10:09:07 -0400 
Misc cleanup and bulletproofing on r10056.


svn:r10058
 2007-04-30 14:09:11 +00:00
Nick Mathewson
420df2ce15 r12559@catbus: nickm | 2007-04-30 09:17:54 -0400 
Fix bug 421: Only set the revision number from SVK if we have a runnable svk _and_ a ~/.svk directory.


svn:r10057
 2007-04-30 13:17:57 +00:00
Roger Dingledine
5ba4eaba1c Let the controller specify HOP=%d as an argument to ATTACHSTREAM, 
so we can exit from the middle of the circuit.


svn:r10056
 2007-04-30 11:10:45 +00:00
Roger Dingledine
7fb4365cd3 Add a new config option __DisablePredictedCircuits designed for 
use by the controller, when we don't want Tor to build any circuits
preemptively.


svn:r10054
 2007-04-30 09:18:48 +00:00
Nick Mathewson
313ac313be r12557@catbus: nickm | 2007-04-30 01:36:39 -0400 
Oops; the rest of the last patch. If that one gets backported, this should too.


svn:r10053
 2007-04-30 05:36:41 +00:00
Nick Mathewson
f7acc3cfa0 r12553@catbus: nickm | 2007-04-30 01:32:54 -0400 
Backport candidate:  Add asserts to dirserv_remove_invalid, and fix a bug in dirserv_remove_invalid that could mess with pointers in a freed routerinfo right after it was freed.


svn:r10052
 2007-04-30 05:32:57 +00:00
Roger Dingledine
2d56d883c2 minor cleanups 
svn:r10050
 2007-04-30 04:00:06 +00:00
Nick Mathewson
105d782109 r12546@catbus: nickm | 2007-04-29 21:27:43 -0400 
Correctly report win98se and win95osr2 versions.


svn:r10047
 2007-04-30 01:27:47 +00:00
Nick Mathewson
e0b0c2a4d2 r12544@catbus: nickm | 2007-04-29 21:08:58 -0400 
Fix an assertion when we call tor_free_all before calling do_main_loop(). Discovered by weasel.


svn:r10046
 2007-04-30 01:09:03 +00:00
Roger Dingledine
397afcc3f6 Make PreferTunneledDirConns and TunnelDirConns work even when 
we have no cached directory info. This means Tor clients can now
do all of their connections protected by TLS.


svn:r10035
 2007-04-27 10:26:09 +00:00
Roger Dingledine
3d00738ec7 simplify connection_watch_events() 
hope this doesn't break it


svn:r10025
 2007-04-25 07:20:04 +00:00
Roger Dingledine
7c5f65c226 fix an assert error in r9995 (unlikely to happen, but still) 
svn:r10024
 2007-04-25 07:04:53 +00:00
Roger Dingledine
7b11f2c843 stop generating a 6-gig info-level log file after a day of running 
svn:r10023
 2007-04-25 06:10:16 +00:00
Roger Dingledine
5bdb138d11 cleanups, and note a bug 
svn:r10022
 2007-04-25 06:05:46 +00:00
Nick Mathewson
94eef608ae r12784@Kushana: nickm | 2007-04-23 19:24:09 -0400 
Avoid another assert failure in the new buffer memory code.  (This time, it hit when freeing a 4k buffer with some data on it.)


svn:r10011
 2007-04-23 23:24:53 +00:00
Nick Mathewson
3831d77dba r12782@Kushana: nickm | 2007-04-23 18:20:19 -0400 
Avoid a segfault when freeing a buffer with size 0.


svn:r10010
 2007-04-23 22:20:45 +00:00
Nick Mathewson
2f4784cbd8 r12499@catbus: nickm | 2007-04-23 10:42:23 -0400 
Keep a freelist of unused 4k buffer chunks, rather than wasting 8k for every inactive connection_t.


svn:r10006
 2007-04-23 14:42:27 +00:00
Nick Mathewson
473c266fc2 r12496@catbus: nickm | 2007-04-22 23:04:05 -0400 
When logging memory usage, break down memory used in buffers by buffer type.


svn:r10004
 2007-04-23 03:04:46 +00:00
Nick Mathewson
5cf600b57a r12492@catbus: nickm | 2007-04-22 20:24:02 -0400 
Even more asserts to try to catch bug 404/417.


svn:r10003
 2007-04-23 00:24:06 +00:00
Nick Mathewson
87b5928202 r12485@catbus: nickm | 2007-04-21 13:46:14 -0400 
Document some fields in or.h


svn:r9998
 2007-04-21 17:46:22 +00:00
Nick Mathewson
fb065724f7 r12484@catbus: nickm | 2007-04-21 13:45:58 -0400 
Suppress display of version-detection junk in Makefile.am


svn:r9997
 2007-04-21 17:46:17 +00:00
Nick Mathewson
bbd63a9ae0 r12482@catbus: nickm | 2007-04-21 13:30:24 -0400 
Rename a couple of confusing fields


svn:r9996
 2007-04-21 17:30:42 +00:00
Nick Mathewson
648065fcb4 r12763@Kushana: nickm | 2007-04-20 18:42:58 -0400 
Initial version of code to stop using socket pairs for linked connections.  Superficially, it seems to work, but it probably needs a lot more testing and attention.


svn:r9995
 2007-04-21 17:26:12 +00:00
Nick Mathewson
227b2e0226 r12759@Kushana: nickm | 2007-04-20 08:47:20 -0400 
Track the number of connection_t separately from the number of open sockets.  It is already possible to have connections that do not count: resolving conns, for one.  Once we move from socketpairs to linked conns, and once we do dns proxying, there will be lots of such connections.


svn:r9994
 2007-04-21 17:24:18 +00:00
Nick Mathewson
6ee5bef092 r12458@catbus: nickm | 2007-04-19 15:52:23 -0400 
Fix a bug in displaying memory pool usage.  Also dump cell allocation, and track padded_cell_ts as they are allocated and freed, to make sure we are not leaking cells.


svn:r9992
 2007-04-19 19:52:30 +00:00
Nick Mathewson
7392464b88 r12456@catbus: nickm | 2007-04-19 14:47:01 -0400 
Make dumpmemusage() dump cell pool usage information.


svn:r9991
 2007-04-19 18:47:04 +00:00
Nick Mathewson
bf4f0539cf r12434@catbus: nickm | 2007-04-19 11:23:35 -0400 
When advancing a string pointer, make sure we do not later free the altered pointer.  Fixes bug 416, introduced in r9971.


svn:r9990
 2007-04-19 15:23:38 +00:00
Nick Mathewson
addf2987c5 r12429@catbus: nickm | 2007-04-18 15:28:41 -0400 
Make svn revision number visible in version even if building from a .tar.gz.  This was remarkably painless.


svn:r9988
 2007-04-18 19:28:47 +00:00
Nick Mathewson
a973611834 r12425@catbus: nickm | 2007-04-17 17:16:38 -0400 
Detect the svn version correctly when building from an svk checkout too.  Whee, fun with bash and make.


svn:r9985
 2007-04-17 21:16:40 +00:00
Nick Mathewson
00941b0171 r12418@catbus: nickm | 2007-04-16 20:58:25 -0400 
Twiddle tor_version_as_new_as() so we can check for particular svn revisions.  With unit tests, for added freshness.


svn:r9977
 2007-04-17 00:58:30 +00:00
Nick Mathewson
bfac679cd4 A hack I've been wanting for a while: when building a -dev version 
from an SVN repository, use the current svn revision in the platform
string and in the output of --version.



svn:r9976
 2007-04-16 23:56:31 +00:00
Nick Mathewson
362fbc79d2 r12414@catbus: nickm | 2007-04-16 17:37:17 -0400 
More proposal-104 stuff: actually remember extra-info stuff.


svn:r9975
 2007-04-16 21:37:21 +00:00
Nick Mathewson
17e83a408f Fix some proposal-104 bugs. 
svn:r9972
 2007-04-16 18:54:56 +00:00
Nick Mathewson
6d32d9cb2d r12406@catbus: nickm | 2007-04-16 14:39:33 -0400 
More proposal-104 stuff: add most of the code for authorities to accept and serve extra-info documents.  The back-end to store the things is missing.


svn:r9971
 2007-04-16 18:39:39 +00:00
Nick Mathewson
2bb5e64289 r12403@catbus: nickm | 2007-04-16 13:55:03 -0400 
Code to generate extrainfo whenever routerdesc is regenerated; code to check extrainfo against routerdesc.


svn:r9970
 2007-04-16 17:55:08 +00:00
Nick Mathewson
7fb7658a45 r12401@catbus: nickm | 2007-04-16 12:28:01 -0400 
Enforce checks for number of arguments to items in directory objects more uniformly.


svn:r9968
 2007-04-16 16:28:06 +00:00
Nick Mathewson
a67f8a3787 r12388@catbus: nickm | 2007-04-16 00:17:29 -0400 
Now that the directory parser checks for missing items, the rest of the code can just assert that they are there, rather than checking a second time.


svn:r9966
 2007-04-16 04:18:29 +00:00
Nick Mathewson
cf02ab6d39 r12387@catbus: nickm | 2007-04-16 00:06:40 -0400 
Refactor router/directory parsing backend: use a separate token table for everything that we parse, and enforce the correct count of each item.


svn:r9965
 2007-04-16 04:18:21 +00:00
Nick Mathewson
5b220f65c8 r12385@catbus: nickm | 2007-04-15 22:55:58 -0400 
Initial code to parse extra-info documents as described in proposal 104.  This is making me realize that the parsing code in routerparse.c is a little daft.


svn:r9963
 2007-04-16 04:17:58 +00:00
Nick Mathewson
7467c35249 r12353@catbus: nickm | 2007-04-11 15:58:46 -0400 
Apparently some compilers think that anonymous unions are bad C.  Technically, they're right, so let's name the union in mempool.c.


svn:r9946
 2007-04-11 19:58:51 +00:00
Nick Mathewson
795aa1a196 r12351@catbus: nickm | 2007-04-11 12:09:46 -0400 
More autoconf hacking: use same machinery to find zlib as for openssl and libevent.  Have unified library finder include setup for --with  variable.  Start trying to suggest to the user what packages they should install if finding the library fails.


svn:r9945
 2007-04-11 16:28:44 +00:00
Nick Mathewson
38a5f09502 r12349@catbus: nickm | 2007-04-11 09:18:15 -0400 
Add code to shrink the cell memory pool by discarding empty chunks that have been empty for the last 60 seconds.  Also, instead of having test.c duplicate declarations for exposed functions, put them inside #ifdef foo_PRIVATE blocks in the headers.  This prevents bugs where test.c gets out of sync.


svn:r9944
 2007-04-11 13:18:25 +00:00
Nick Mathewson
1c8f9b319b r12344@catbus: nickm | 2007-04-10 21:27:25 -0400 
Fix documentation and usage of 2nd argument to mp_pool_new.


svn:r9942
 2007-04-11 01:27:33 +00:00
Nick Mathewson
51e4b8d706 r12338@catbus: nickm | 2007-04-10 20:29:05 -0400 
Document memory pool implementation, and tweak it even mor.  See? Programming is fun.


svn:r9940
 2007-04-11 00:30:34 +00:00
Nick Mathewson
28de06b8e6 r12337@catbus: nickm | 2007-04-10 17:55:26 -0400 
Add support for using memory pools to allocate queued cell; pass --disable-cell-pool to configure to disable this.


svn:r9939
 2007-04-11 00:30:29 +00:00
Nick Mathewson
6ba0b0e9f4 r12336@catbus: nickm | 2007-04-10 17:34:25 -0400 
Unit tests and debugging for memory pool implementation.


svn:r9938
 2007-04-11 00:30:25 +00:00
Nick Mathewson
d7359eb996 r12335@catbus: nickm | 2007-04-10 16:53:48 -0400 
Initial version of memory pool logic. Needs unit tests.  Made to be easily separable from Tor.


svn:r9937
 2007-04-11 00:30:22 +00:00
Nick Mathewson
f95d232483 r12332@catbus: nickm | 2007-04-10 12:24:45 -0400 
Yet another attempted Bug 411 fix: Under some circumstances, a circuit can have cells without being active.  The likeliest is that it has been unlinked from all connections in preparation for closing.  Therefore, stop enforcing this non-invariant.


svn:r9936
 2007-04-10 16:24:50 +00:00
Nick Mathewson
58a6761056 r12330@catbus: nickm | 2007-04-09 19:15:42 -0400 
Split type of "packed cell" from "parsed cell"; pack cells before queueing them on circuits.  This will help us avoid dumb errors when we confuse the two types.


svn:r9935
 2007-04-09 23:15:46 +00:00
Nick Mathewson
7529c8f548 r12328@catbus: nickm | 2007-04-09 18:16:31 -0400 
Argh, missed another 9030 bogon.


svn:r9934
 2007-04-09 22:16:33 +00:00
Nick Mathewson
2a07919198 r12326@catbus: nickm | 2007-04-09 17:36:41 -0400 
Clean up crap from 9930.  I can hardly wait till I trust SVK 2.x enough to upgrade.


svn:r9933
 2007-04-09 21:36:45 +00:00
Nick Mathewson
2dc6019edb r12688@Kushana: nickm | 2007-04-09 17:29:12 -0400 
Simplify dns_resolve: use a helper function so that we handle the error/answer/pending cases uniformly in dns_resolve, and everything else in dns_resolve_impl.


svn:r9932
 2007-04-09 21:34:13 +00:00
Nick Mathewson
9c3df07b56 r12687@Kushana: nickm | 2007-04-09 17:05:57 -0400 
Try to fix bug 410: move responsibility for attaching/detaching initial streams from circuits into dns_resolve.  Needs refactoring a little.


svn:r9931
 2007-04-09 21:34:03 +00:00
Nick Mathewson
32506ad282 svn:r9930 2007-04-09 21:33:49 +00:00
Nick Mathewson
98e5d10761 r12318@catbus: nickm | 2007-04-09 16:08:20 -0400 
Fix the first half of bug 411: when we make a circuit active inactive on a connection, it _must_ actually be on that connection.


svn:r9929
 2007-04-09 20:09:28 +00:00
Nick Mathewson
eb95ff9ba9 r12317@catbus: nickm | 2007-04-09 15:50:51 -0400 
Fix second part of bug 411 (which was actually a separate bug): it isnt safe to clear a cell queue while the circuit is active.


svn:r9928
 2007-04-09 20:09:26 +00:00
Roger Dingledine
f36c613dbc fix a memory leak when we ask for "all" networkstatuses and 
we get one we don't recognize.
backport candidate.
backbackport candidate.


svn:r9918
 2007-03-29 07:02:12 +00:00
Nick Mathewson
6589ea2a2f Fix a crash bug in cell queues: It is possible for a connection_write_to_buf to close the connection or otherwise unlink the circuit, which makes the circuit nonactive, which invalidates the pointer from the circuit to the next circuit on the active ring. Also add a bunch of asserts, most #ifdefed out. 
svn:r9915
 2007-03-29 02:41:36 +00:00
Nick Mathewson
d1ad950ca8 Turn bool_neq and bool_eq into macros. 
svn:r9914
 2007-03-29 02:37:06 +00:00
Nick Mathewson
98ae4bbd0f Comment out the "clear queue when sending a destroy" logic: it seems potentially dangerous. (see comment for details) 
svn:r9913
 2007-03-29 02:32:00 +00:00
Nick Mathewson
a25c5d6994 r12654@Kushana: nickm | 2007-03-25 19:03:44 -0400 
Add documentation for cell queue functions; make destroy cells result in cell queues getting cleared before the destroy gets sent.


svn:r9907
 2007-03-26 14:08:35 +00:00
Nick Mathewson
83b2208ea4 r12653@Kushana: nickm | 2007-03-25 18:21:38 -0400 
Add documentation for make_old argument to routerlist functions.


svn:r9906
 2007-03-26 14:08:29 +00:00
Nick Mathewson
d1381aef82 r12652@Kushana: nickm | 2007-03-25 15:01:48 -0400 
A surprisingly simple patch to stop reading on edge connections when their circuits get too full, and start again when they empty out.  This lets us remove the logic to block begin_dir conns when the corresponding or conns get full: it was already broken by cell queues anyway.


svn:r9905
 2007-03-26 14:08:18 +00:00
Nick Mathewson
38c0bb3a99 r12651@Kushana: nickm | 2007-03-24 18:26:42 -0400 
Initial version of circuit-based cell queues.  Instead of hammering or_conns with piles of cells, queue cells on their corresponding circuits, and append them to the or_conn as needed.  This seems to work so far, but needs a bit more work.  This will break the memory-use-limitation patch for begin_dir conns: the solution will be a fun but fiddly.


svn:r9904
 2007-03-26 14:07:59 +00:00
Nick Mathewson
6e51bdd5e4 r12274@catbus: nickm | 2007-03-26 09:29:18 -0400 
Possibly resolve bug reported by xiando.


svn:r9903
 2007-03-26 13:30:17 +00:00
Nick Mathewson
da6bd21b72 r12644@0-41-wifi: nickm | 2007-03-23 16:02:23 -0400 
Eliminate more redundant circuit_t arguments when edge_connection_t is already supplied and the circuit is already attached.


svn:r9900
 2007-03-24 15:58:11 +00:00
Nick Mathewson
306d5400c3 r12643@0-41-wifi: nickm | 2007-03-23 14:56:35 -0400 
Refactor a bunch of functions that take edge_connection_t not to also take a crypt_path_t; the cpath is implicit.


svn:r9899
 2007-03-24 15:57:51 +00:00
Roger Dingledine
2cf63f8a62 Don't save non-general-purpose router descriptors to the disk cache, 
because we have no way of remembering what their purpose was when
we restart.


svn:r9894
 2007-03-21 15:37:30 +00:00
Roger Dingledine
c36a6210a2 put the stopgap on whether we've sent a create cell, not 
whether we've attached a stream.


svn:r9883
 2007-03-20 03:26:51 +00:00
Roger Dingledine
93e7627694 a stopgap measure while we wait for proposal 111: apply the 
stricter rate limiting to all OR conns except those that have
been touched by local circuits.


svn:r9882
 2007-03-20 03:21:51 +00:00
Roger Dingledine
b4f743562f Add a separate set of token buckets for relayed traffic. Right 
now that's just defined as answers to directory requests.


svn:r9881
 2007-03-20 02:55:31 +00:00
Roger Dingledine
4ab0b979b2 temporary hack to solve bug 384, so i can get on with debugging 
other stuff.


svn:r9880
 2007-03-20 02:10:18 +00:00
Roger Dingledine
0724bc113f correct a function comment that's become wrong 
svn:r9879
 2007-03-19 23:32:30 +00:00
Nick Mathewson
141efb86ff r12230@catbus: nickm | 2007-03-17 17:34:32 -0400 
Remove some duplicated code in control.c: unify the "parse space-separated arguments and warn if there are too few" logic into a single helper function.


svn:r9866
 2007-03-17 21:34:41 +00:00
Nick Mathewson
d787ef906a r12229@catbus: nickm | 2007-03-17 17:20:28 -0400 
Add a warning when using obsolete "GUARDS" event.  Also, remove obsolete "if (1) {}"s from control.c: big patch, mostly just dedenting block contents.


svn:r9865
 2007-03-17 21:34:37 +00:00
Nick Mathewson
f8f5ea10de r12191@catbus: nickm | 2007-03-15 15:33:37 -0400 
Check return values from pthread_mutex functions.


svn:r9862
 2007-03-17 21:09:49 +00:00
Roger Dingledine
75754b4d8e other minor fixes lurking in my sandbox 
svn:r9854
 2007-03-17 04:34:31 +00:00
Roger Dingledine
9d7dc1b37b forward-port r9850 and the changelogs 
(it's a band)


svn:r9853
 2007-03-17 04:32:04 +00:00
Roger Dingledine
4813ff04e8 Fix an infinite loop introduced in 0.1.2.7-alpha when we serve 
directory information requested inside Tor connections (i.e. via
begin_dir cells). It only triggered when the same connection was
serving other data at the same time. Reported by seeess.

Backport candidate.


svn:r9841
 2007-03-16 06:55:09 +00:00
Roger Dingledine
d374616301 clean up some minor typos and log confusions 
svn:r9832
 2007-03-15 22:47:21 +00:00
Nick Mathewson
e50e6b4e3c r12182@catbus: nickm | 2007-03-15 10:58:12 -0400 
Clarify section of dir-spec.txt that explains how "v" resolution happens.


svn:r9829
 2007-03-15 16:27:57 +00:00
Roger Dingledine
ad304a5cbb change my mind -- correct the spec to match the code's 
behavior for getinfo addr-mappings/*. this is because
the code and spec have been mismatched since at least
0.1.1.x, so i would be surprised if nobody at all is
relying on the current behavior.

backport candidate.
backbackport candidate.


svn:r9823
 2007-03-15 06:25:00 +00:00
Roger Dingledine
8ca31c8195 Make the response to 'getinfo addr-mappings/*' follow the spec. 
svn:r9822
 2007-03-15 06:10:58 +00:00
Roger Dingledine
c995a36972 typo in error message led to breaking the protocol. also 
pointed out by daejees.


svn:r9819
 2007-03-15 03:15:34 +00:00
Roger Dingledine
5b8adc7c9b Make 'getinfo fingerprint' return a 551 error if we're not a 
server, so we match what the control spec claims we do. Reported
by daejees.


svn:r9818
 2007-03-15 03:11:53 +00:00
Roger Dingledine
5740071674 the spec called it a GUARDS event, but the code called 
it a GUARD event. standardize on GUARD, but support people
asking for GUARDS too. reported by daejees.

backport candidate.


svn:r9817
 2007-03-14 23:50:41 +00:00
Roger Dingledine
bf3b3a44f3 Stop allowing hibernating servers to be "stable" or "fast". 
This is what I meant to do in r9690 but didn't actually do.


svn:r9808
 2007-03-13 01:59:09 +00:00
Nick Mathewson
6363a7ccf5 r12538@Kushana: nickm | 2007-03-11 17:10:22 -0400 
Fix a lame assert, I hope.


svn:r9801
 2007-03-11 21:10:54 +00:00
Roger Dingledine
7fedd6ab4e best not to introduce new technical terms if we don't need to 
svn:r9800
 2007-03-11 20:52:07 +00:00
Nick Mathewson
98c3403ce7 r12535@Kushana: nickm | 2007-03-11 16:34:40 -0400 
Fix a comment and add a couple of  assert to try to track down another assert in routerlist_assert_ok()


svn:r9799
 2007-03-11 20:34:44 +00:00
Nick Mathewson
f25e2167f5 r12533@Kushana: nickm | 2007-03-11 05:01:15 -0400 
Oh. Tor was supposed to compile?


svn:r9797
 2007-03-11 09:05:17 +00:00
Nick Mathewson
97b61b9889 r12519@Kushana: nickm | 2007-03-10 00:57:01 -0500 
Remove a redundant check for event.h; add some comments, and reformat.


svn:r9790
 2007-03-10 07:38:42 +00:00
Roger Dingledine
4ca75ecc49 holy cow, those windows unames are long. don't distract so 
much from the important part of this log message.


svn:r9789
 2007-03-10 06:33:44 +00:00
Roger Dingledine
a247792169 Directory authorities now call routers stable if they have an 
uptime of at least 30 days, even if that's not the median uptime
in the network. Implements proposal 1xx, suggested by Kevin Bauer
and Damon McCoy.


svn:r9788
 2007-03-10 05:43:35 +00:00
Nick Mathewson
02ce8e6b12 r12474@Kushana: nickm | 2007-03-06 16:10:05 -0500 
We have a PATH_SEPARATOR macro.  How about we use it?


svn:r9782
 2007-03-09 21:39:30 +00:00
Nick Mathewson
d62e37b4a9 r12473@Kushana: nickm | 2007-03-06 15:49:45 -0500 
Excise PREDICT and PREDICT_FALSE in favor of PREDICT_LIKELY and PREDICT_UNLIKELY.


svn:r9781
 2007-03-09 21:39:19 +00:00
Roger Dingledine
fe94914b98 Put a platform string (e.g. "Linux i686") in the startup log 
message, so when people paste just their logs, we know if it's
openbsd or windows or what.


svn:r9775
 2007-03-09 08:56:39 +00:00
Roger Dingledine
b97dca4510 forward-port the bugfix from juliusz 
svn:r9772
 2007-03-09 08:48:53 +00:00
Roger Dingledine
064ff7b33d get rid of an info-level log message that occurs many times a 
minute when we haven't needed circuits lately.


svn:r9771
 2007-03-09 08:48:21 +00:00
Nick Mathewson
2036470b62 r12098@catbus: nickm | 2007-03-06 18:48:50 -0500 
Try to make unit tests happier on 64-bit platforms.


svn:r9752
 2007-03-06 23:48:55 +00:00
Nick Mathewson
5d1bee87ff r12468@Kushana: nickm | 2007-03-06 15:24:00 -0500 
More unit tests: gcov is fun.


svn:r9748
 2007-03-06 20:25:44 +00:00
Nick Mathewson
c9e2766e75 r12461@Kushana: nickm | 2007-03-06 13:26:17 -0500 
More autoconf fixes and updates. Maybe the bsd buildbots will be happy again.


svn:r9747
 2007-03-06 20:25:32 +00:00
Roger Dingledine
78cbfcf651 and one more not-really-an-error case 
svn:r9743
 2007-03-06 19:37:18 +00:00
Roger Dingledine
5217d3680e clean up a log message, and stop calling it an error when 
we exit cleanly


svn:r9742
 2007-03-06 19:33:43 +00:00
Nick Mathewson
52713788b4 r12080@catbus: nickm | 2007-03-04 21:40:55 -0500 
Remove dnsworkers and related code. there goes another 550 lines of code.


svn:r9736
 2007-03-05 02:40:58 +00:00
Nick Mathewson
92f62b3684 r12077@catbus: nickm | 2007-03-04 16:08:23 -0500 
Remove support for v0 control protocol from 0.2.0.x trunk; send back error when we receive a v0 control message.  (Leave "if(v1){...}"blocks indented for now so this patch is easier to read.)  ((Finally, the linecount goes _down_ a little.))


svn:r9735
 2007-03-04 21:08:28 +00:00
Nick Mathewson
4a6e29b029 r12076@catbus: nickm | 2007-03-04 15:41:04 -0500 
oops; remove spurious argument from _log_prefix.


svn:r9734
 2007-03-04 21:08:26 +00:00
Nick Mathewson
7fcceb2c25 r12074@catbus: nickm | 2007-03-04 15:11:43 -0500 
Make all LD_BUG log messsages get prefixed with "Bug: ".  Remove manually-generated "Bug: "s from log-messages.  (Apparently, we remembered to add them about 40% of the time.)


svn:r9733
 2007-03-04 20:11:46 +00:00
Nick Mathewson
6b79e252f6 r12063@catbus: nickm | 2007-03-04 14:46:22 -0500 
Bump trunk version to 0.2.0.0-alpha-dev


svn:r9730
 2007-03-04 19:49:06 +00:00
Nick Mathewson
70e5a83a77 r12057@catbus: nickm | 2007-03-04 13:58:32 -0500 
Clarify some log messages; note others that could be improved later.


svn:r9724
 2007-03-04 18:58:38 +00:00
Nick Mathewson
5f9f62daa2 r12053@catbus: nickm | 2007-03-03 16:45:38 -0500 
Remove some XXX012s: leave a check in connection_or_set_identity_digest it costs basically nothing to do on average.  Forget about reinstating the user check on NT Service creation.  Note that a notice message in main.c ("Is something wrong with your network connection?") is really useless.


svn:r9721
 2007-03-03 21:55:31 +00:00
Nick Mathewson
25508347ec r12051@catbus: nickm | 2007-03-03 16:15:52 -0500 
nt_service_is_stopping should not load the NT service library calls: if they are not loaded, we cannot possibly be a service trying to shut own.  Bug found by "norvid" on or-talk.  Also, rename function to something slightly less error-prone.


svn:r9720
 2007-03-03 21:16:07 +00:00
Nick Mathewson
bd9289cf2b svn:r9719 2007-03-03 20:09:15 +00:00
Nick Mathewson
275f39603b r12420@Kushana: nickm | 2007-03-03 15:06:53 -0500 
Bump version to 0.1.2.9-rc-dev


svn:r9718
 2007-03-03 20:09:07 +00:00
Roger Dingledine
629930ad16 bump to 0.1.2.9-rc 
svn:r9705
 2007-03-02 05:18:52 +00:00
Roger Dingledine
6b191f854c resolve another xxx012 
svn:r9701
 2007-03-01 04:40:43 +00:00
Roger Dingledine
dba4e040fc Disable encrypted directory connections when we don't have a server 
descriptor for the destination. We'll get this working again in
the 0.2.0 branch.


svn:r9700
 2007-03-01 04:26:30 +00:00
Roger Dingledine
a46bd9942d bonus points if it builds on 64 bit 
svn:r9698
 2007-03-01 03:59:28 +00:00
Roger Dingledine
b0aaa88433 make the prefertunnel stuff less obviously broken 
svn:r9697
 2007-03-01 03:56:21 +00:00
Nick Mathewson
2780bb74c8 r12014@catbus: nickm | 2007-02-28 19:41:20 -0500 
Niels has accepted the patch from Scott Lamb to implement better signal handling: I can take "get the pthread_sigprocmask situation under control" off my plate.


svn:r9696
 2007-03-01 00:41:35 +00:00
Nick Mathewson
df5a8aa931 r12013@catbus: nickm | 2007-02-28 18:26:13 -0500 
Note a piece of code that needs to get resolved, before we forget it.


svn:r9695
 2007-03-01 00:41:33 +00:00
Nick Mathewson
11d89141ac r12012@catbus: nickm | 2007-02-28 18:25:18 -0500 
Twiddle constants wrt uploading hidden service descriptors.


svn:r9694
 2007-03-01 00:41:28 +00:00
Nick Mathewson
dec9e4f0d8 r12011@catbus: nickm | 2007-02-28 18:13:32 -0500 
Back out insufficiently evidenced FULL_UNROLL in aes.c


svn:r9693
 2007-03-01 00:41:25 +00:00
Nick Mathewson
e2b1a77c3e r12006@catbus: nickm | 2007-02-28 16:06:24 -0500 
On mingw, use "%I64u" to printf/scanf 64-bit integers, instead of the usual GCC "%llu".  This prevents a bug when saving 64-bit int configuration values on mingw; the high-order 32 bits would get truncated.  If the value was then reloaded, disaster would occur. (Fixes bug 400 and maybe also bug 397.)  Backport candidate.


svn:r9691
 2007-02-28 21:07:19 +00:00
Roger Dingledine
b78f67dbf5 - Stop calling servers that have been hibernating for a long time 
"stable". Also, stop letting hibernating or obsolete servers affect 
  uptime and bandwidth cutoffs.
- Stop listing hibernating servers in the v1 directory.


svn:r9690
 2007-02-28 21:06:05 +00:00
Roger Dingledine
9fd669c339 note another wishlist item for the arma 
svn:r9689
 2007-02-28 20:49:09 +00:00
Nick Mathewson
f38240435a r12001@catbus: nickm | 2007-02-28 15:24:12 -0500 
Try to build without warnings on mingw with verbose warnings on.  First attempt.


svn:r9688
 2007-02-28 20:24:27 +00:00
Nick Mathewson
3008c3b768 r12000@catbus: nickm | 2007-02-28 15:12:21 -0500 
Try to fix eventdns bug 326 again, this time by noting that rcode 2 (serverfailed) does not really mean "The server is useless."


svn:r9687
 2007-02-28 20:24:23 +00:00
Roger Dingledine
08c75f4349 avoid a few headaches 
svn:r9686
 2007-02-28 20:24:09 +00:00
Nick Mathewson
dfbced7499 r11998@catbus: nickm | 2007-02-28 13:56:55 -0500 
Correct an MSC_VER check.


svn:r9685
 2007-02-28 18:57:03 +00:00
Nick Mathewson
2ee2e63631 r11996@catbus: nickm | 2007-02-28 13:52:48 -0500 
Add an MSC_VER check I missed.


svn:r9684
 2007-02-28 18:52:57 +00:00
Nick Mathewson
e1176ece5a r11992@catbus: nickm | 2007-02-28 12:46:32 -0500 
compile fix on mingw: mingw does not define _MSC_VER.


svn:r9682
 2007-02-28 17:46:36 +00:00
Nick Mathewson
deef370a1c r11987@catbus: nickm | 2007-02-28 12:34:04 -0500 
add another u64-related unit test.


svn:r9681
 2007-02-28 17:34:07 +00:00
Nick Mathewson
c8659db28d r11982@catbus: nickm | 2007-02-28 11:55:41 -0500 
Add unit tests for tor_parse_uint64


svn:r9678
 2007-02-28 16:56:28 +00:00
Nick Mathewson
dae5fc7982 r11981@catbus: nickm | 2007-02-28 11:55:27 -0500 
Clamp declarable bandwidth at INT32_MAX, not INT_MAX.


svn:r9677
 2007-02-28 16:56:07 +00:00
Nick Mathewson
d6368fd075 r11976@catbus: nickm | 2007-02-27 19:35:59 -0500 
Add some missing (redundant but helpful in most cases) static declarations, and remove a function nobody was calling.


svn:r9672
 2007-02-28 00:36:03 +00:00
Nick Mathewson
1a3e1c5510 r11970@catbus: nickm | 2007-02-27 19:17:27 -0500 
Fix a bug found by Udo van den Heuvel: avoid an assertion failure when a controller sets and clears EntryNodes before the next call to choose_random_entry().  Also make a function static.


svn:r9669
 2007-02-28 00:23:05 +00:00
Nick Mathewson
16f1008d01 Add a missing paren, and the results of an experiment. 
svn:r9664
 2007-02-27 06:00:11 +00:00
Nick Mathewson
9d714e6258 r11959@catbus: nickm | 2007-02-26 22:53:36 -0500 
try to make aes encryption of cells about 30-40% faster where applicable.  offer not available for all architectures or all versions of openssl.


svn:r9663
 2007-02-27 03:53:45 +00:00
Nick Mathewson
4d127acb53 r11958@catbus: nickm | 2007-02-26 22:28:03 -0500 
Add a missing set to onion_key_set_at to avoid premature rotates.


svn:r9662
 2007-02-27 03:53:40 +00:00
Nick Mathewson
230fbd95c0 r11956@catbus: nickm | 2007-02-26 13:33:49 -0500 
Add a quick-and-dirty AES benchmark function to the bottom of aes.c so I can go collecting data.


svn:r9660
 2007-02-26 18:33:55 +00:00
Nick Mathewson
82e2d6001a r11954@catbus: nickm | 2007-02-26 13:01:19 -0500 
Note some optimizations that are probably not worth it for 0.1.2.x based on preliminary profiling.


svn:r9659
 2007-02-26 18:01:23 +00:00
Nick Mathewson
a5b18f8a65 r11952@catbus: nickm | 2007-02-26 12:37:06 -0500 
Bump version to 0.1.2.8-beta-dev


svn:r9658
 2007-02-26 17:37:09 +00:00
Roger Dingledine
38f5fac846 let us call it a beta. perhaps it will break then. 
svn:r9656
 2007-02-26 06:53:19 +00:00
Roger Dingledine
522a97098b more cleanups; getting closer 
svn:r9655
 2007-02-26 05:36:02 +00:00
Roger Dingledine
9e44449946 fix a bug in our logic, but point out that maybe it's moot 
svn:r9654
 2007-02-26 05:33:17 +00:00
Nick Mathewson
333bf44471 r11944@catbus: nickm | 2007-02-25 14:43:18 -0500 
Add a lower-bound on MaxAdvertisedBandwidth.


svn:r9652
 2007-02-25 19:43:23 +00:00
Nick Mathewson
938de88e3b r11942@catbus: nickm | 2007-02-25 11:22:12 -0500 
Fix connection_get_by_type_state_rendquery(): This has been bogus for most of 0.1.2.x.  Thanks to Karsten Loesing for finding the bug; fixes bug 399.


svn:r9651
 2007-02-25 16:22:36 +00:00
Roger Dingledine
5fd4f7c131 the other half of r9572, suggested by seeess: when we receive 
a v1 dir or rr that is too old, don't even cache it.


svn:r9649
 2007-02-25 03:43:00 +00:00
Nick Mathewson
dde4bc1fd3 r11933@catbus: nickm | 2007-02-24 18:55:33 -0500 
Fix a bug in 9572: after we decref a defunct v1 directory, drop the main reference to it.  Should fix bug 396.  Many thanks to seeess for tracking this one down.


svn:r9648
 2007-02-24 23:55:36 +00:00
Roger Dingledine
d6c21ab8a7 tell the user if we're delaying his newnym request. also, pick 
a different set of fenceposts.


svn:r9647
 2007-02-24 21:21:38 +00:00
Nick Mathewson
af57074f08 r11931@catbus: nickm | 2007-02-24 15:28:34 -0500 
crank up the length of the maximum allowed control message.


svn:r9644
 2007-02-24 20:28:41 +00:00
Nick Mathewson
b4243d7dfa r11929@catbus: nickm | 2007-02-24 15:02:43 -0500 
Split possibly long log line.


svn:r9643
 2007-02-24 20:02:47 +00:00
Nick Mathewson
501659e67c r11927@catbus: nickm | 2007-02-24 14:49:31 -0500 
Make sure every error case of router_dump_router_to_string warns about what actually went wrong.


svn:r9642
 2007-02-24 19:49:35 +00:00
Roger Dingledine
fc81b71055 if we can't read bandwidthrate, at least tell us what it was. 
svn:r9640
 2007-02-24 19:29:42 +00:00
Nick Mathewson
cc64d1f111 r11917@catbus: nickm | 2007-02-24 03:18:52 -0500 
Fix another XXX012 in eventdns.c: tell the DNS request about malformed DNS replies.


svn:r9637
 2007-02-24 08:18:59 +00:00
Roger Dingledine
50f22e858a doc pedant 
svn:r9634
 2007-02-24 07:50:38 +00:00
Nick Mathewson
f599adf40a r11909@catbus: nickm | 2007-02-24 02:37:40 -0500 
Move tricky "delete the member of the smartlist currently under iteration" logic into its own happyfun macro.


svn:r9633
 2007-02-24 07:37:45 +00:00
Roger Dingledine
2015479b5a fix crash introduced in r9622 
svn:r9632
 2007-02-24 06:44:40 +00:00
Roger Dingledine
748c502e3a fix a log message that was broken long ago and never noticed 
svn:r9630
 2007-02-24 05:36:45 +00:00
Roger Dingledine
d63c58249e make it stop crashing when i exercise the new entrynodes behavior in 
r9574. this hack is getting pretty darn hackish; perhaps it's time to
not use SMARTLIST_FOREACH in this situation.


svn:r9629
 2007-02-24 04:17:29 +00:00
Roger Dingledine
33430d3a9e bugfix on r9568: we were throwing around an uninitialized 
nickname array, and only treating a server as reachable if
the array magically has the right nickname in it. this was
causing the authorities to label only themselves as running,
and clients were "mysteriously" failing.


svn:r9628
 2007-02-24 01:26:09 +00:00
Roger Dingledine
9946bb7fbd cosmetic, comment, and todo fixes 
svn:r9627
 2007-02-24 01:12:53 +00:00
Nick Mathewson
4e05ccb289 r11900@catbus: nickm | 2007-02-23 18:11:04 -0500 
Fix null-pointer access on update_router_descriptor_cache_downloads.


svn:r9626
 2007-02-23 23:11:08 +00:00
Nick Mathewson
ddc34f6037 r11898@catbus: nickm | 2007-02-23 16:55:43 -0500 
Two XXX012 comments turned out to be bogus; remove them and document why.


svn:r9625
 2007-02-23 21:56:10 +00:00
Nick Mathewson
55cbbdf9bf r11895@catbus: nickm | 2007-02-23 15:12:58 -0500 
Make remap stream events have a souce; make them generated every time we get a successful connected or resolved cell.  Also change reported stream target address to IP consistently when we get the IP from an exit node.


svn:r9624
 2007-02-23 20:13:02 +00:00
Nick Mathewson
f1d207b29a r11885@catbus: nickm | 2007-02-23 13:34:24 -0500 
Fix an XXXX012: make entry guards _really_ get retried when the network comes back online.


svn:r9622
 2007-02-23 18:34:35 +00:00
Nick Mathewson
a98efbf285 r11877@catbus: nickm | 2007-02-22 02:24:50 -0500 
Fix doc about when circuit_build_needed_circs() is called. Resolves another xxxx012.


svn:r9617
 2007-02-22 07:41:14 +00:00
Nick Mathewson
a2a52b4d5f r11876@catbus: nickm | 2007-02-22 02:23:13 -0500 
Fix two XXXX012 issues in routerlist.c: a possible performance issue hasnt shown up on any profiles, so unflag it.  Stop warning when we get a router descriptor that we asked for but no longer want: just drop it (if we are not a cache) or cache if (if we are).


svn:r9616
 2007-02-22 07:41:10 +00:00
Nick Mathewson
b3392559d4 r11873@catbus: nickm | 2007-02-22 01:21:14 -0500 
twiddle signewnym rate-limiting patch so every signal gets handled eventually.  document it in control-spec. add a changelog.


svn:r9615
 2007-02-22 06:21:19 +00:00
Nick Mathewson
fe9224dabc r11872@catbus: nickm | 2007-02-22 01:08:46 -0500 
patch from mwenge: rate-limit newnym.


svn:r9614
 2007-02-22 06:21:16 +00:00
Nick Mathewson
0fb179aa2e r11860@catbus: nickm | 2007-02-21 00:56:15 -0500 
Another optimization suggested by Shark output: shave off >90% of uses of logv by cutting down on calls to log_debug when log actually debugging.  This is showing up in some profiles bug not others, and might be as much as 2.5%.


svn:r9612
 2007-02-21 05:57:12 +00:00
Nick Mathewson
809a4daa52 r11859@catbus: nickm | 2007-02-21 00:53:27 -0500 
Fix use of predict. this should get refactored, but now now.


svn:r9611
 2007-02-21 05:57:08 +00:00
Nick Mathewson
2a4fc8533c r11858@catbus: nickm | 2007-02-21 00:27:44 -0500 
As a trivial optimization, remove a redundant call to router_have_minimum_dir_info.  This might shave 2% on some systems by according to some profilers.


svn:r9610
 2007-02-21 05:56:53 +00:00
Nick Mathewson
275ce1d2a4 r11852@catbus: nickm | 2007-02-20 17:25:17 -0500 
Reverse arguments in memset() call in no-mmap version of tor_munmap_file().  Resolves bug 392.  Spotted by "fookoowa"--thanks!


svn:r9604
 2007-02-20 22:25:20 +00:00
Nick Mathewson
b6e6b7101b r11850@catbus: nickm | 2007-02-20 13:34:13 -0500 
Apply patch from coderman: have posix subthreads mask out signals.  This could prevent some kinds of crashes when subthreads try to handle SIGPIPEs and die in the attempt.  Backport candidate.


svn:r9603
 2007-02-20 18:34:18 +00:00
Nick Mathewson
aade1b9204 r11844@catbus: nickm | 2007-02-17 16:53:42 -0500 
Note a problematic warning.


svn:r9599
 2007-02-17 23:49:50 +00:00
Nick Mathewson
d2893398f6 r11832@catbus: nickm | 2007-02-16 15:31:59 -0500 
Fix 35 remaining DOCDOC comments. Yowza.


svn:r9596
 2007-02-16 20:39:37 +00:00
Nick Mathewson
a3ec172e1a r11827@catbus: nickm | 2007-02-16 15:00:39 -0500 
Try to fix VC++ int conversion warning.


svn:r9595
 2007-02-16 20:01:21 +00:00
Nick Mathewson
11e5656ab7 r11826@catbus: nickm | 2007-02-16 14:58:38 -0500 
Resolve 56 DOCDOC comments.


svn:r9594
 2007-02-16 20:01:02 +00:00
Nick Mathewson
ae7576a19e r11825@catbus: nickm | 2007-02-16 14:04:36 -0500 
Fix DOCDOC items in or.h; rename a couple of macros to be more sensible.


svn:r9593
 2007-02-16 20:00:50 +00:00
Nick Mathewson
d4aaffc6e7 r11824@catbus: nickm | 2007-02-16 13:16:47 -0500 
Move all struct-offset-manipulation macros into util.h, and use them consistently.  Because there are days when "SUBTYPE_P(handle, subtype, _base)" is just easier to read and write than "(basetp*)(((handle) - STRUCT_OFFSET(subtype, _base))".


svn:r9592
 2007-02-16 20:00:43 +00:00
Nick Mathewson
e5d3269b10 r11822@catbus: nickm | 2007-02-16 12:49:20 -0500 
Tech config.c about libevent 1.3, and resolve all docdoc elements in config.c


svn:r9591
 2007-02-16 18:12:47 +00:00
Nick Mathewson
6e35b11851 r11813@catbus: nickm | 2007-02-14 11:42:58 -0500 
Tweak stream_bw patch: Remove a couple of redundant checks, save 8 bytes per edge connection, fix spelling in the changelog; expand spec.


svn:r9586
 2007-02-14 16:46:55 +00:00
Nick Mathewson
4a74812c70 r11812@catbus: nickm | 2007-02-14 11:22:08 -0500 
Apply stream_bw patch from Robert Hogan.


svn:r9585
 2007-02-14 16:46:49 +00:00
Nick Mathewson
a10ccac9cb r11797@catbus: nickm | 2007-02-13 16:17:40 -0500 
Fix a longstanding dnsworker-related bug: when we decide to kill a DNS worker for having been in use too long, and we independently decide to close one of the exit connections waiting for that DNS worker (perhaps because we got an END relay cell), it was possible for us to try to double-free the connection.  We were smart enough to detect this and assert, but not smart enough to fix this bug before now.  This should resolve bug 390.  Backport candidate.


svn:r9581
 2007-02-13 21:18:56 +00:00
Nick Mathewson
1c8a9d37b6 r11791@catbus: nickm | 2007-02-13 11:36:07 -0500 
Try to fix mingw compile error reported by Li-Hui Zhou.


svn:r9578
 2007-02-13 16:36:14 +00:00
Nick Mathewson
d9c095be3e r11787@catbus: nickm | 2007-02-12 21:01:34 -0500 
Always remove expired routers and networkstatus docs before checking whether we have enough information to build circuits. (Fixes bug 373.)


svn:r9575
 2007-02-13 02:01:38 +00:00
Nick Mathewson
3c691b9da6 r11785@catbus: nickm | 2007-02-12 20:27:48 -0500 
Node-picking fixes: Never warn when a down node is listed in a config option (bug 348); always warn when a node in a config option is unnamed.  Also, when entrynodes is configured, then build the guard list as: (parts of EntryNodes that were guards before), (the rest of EntryNodes), (the rest of the old guards).  This last point ensures that EntryNode users will get the EntryNodes they want with the minimum change to their guard list.


svn:r9574
 2007-02-13 01:27:55 +00:00
Nick Mathewson
95b828b685 r11781@catbus: nickm | 2007-02-12 18:31:33 -0500 
Discard any v1 directory info that is so old as to be useless.  (Fixes bug 387)


svn:r9572
 2007-02-12 23:39:24 +00:00
Nick Mathewson
b16c544509 r11779@catbus: nickm | 2007-02-12 16:52:29 -0500 
Do not try to load advapi32.dll except when the user asks us to do something with NT services.  When we _do_ try, always treat failure to load service functions as an exit-worthy error.  Needs testing. (Fixes bug 389)


svn:r9571
 2007-02-12 21:52:32 +00:00
Nick Mathewson
759c58151e r11775@catbus: nickm | 2007-02-12 16:39:09 -0500 
Update copyright dates.


svn:r9570
 2007-02-12 21:39:53 +00:00
Nick Mathewson
30e7c05075 r11774@catbus: nickm | 2007-02-12 16:31:47 -0500 
Handle errors on opening cached-routers* more uniformly and sanely: log not-found errors at level INFO, and all other errors at level WARN.  Needs testing on win32.


svn:r9569
 2007-02-12 21:39:44 +00:00
Nick Mathewson
0c40a080a4 r11773@catbus: nickm | 2007-02-12 15:18:48 -0500 
Implement proposal 106: stop requiring clients to have certificates, and stop checking for nicknames in certificates.  [See proposal 106 for rationale.]  Also improve messages when checking TLS handshake, to re-resolve bug 382.


svn:r9568
 2007-02-12 21:39:33 +00:00
Roger Dingledine
5915eecdb3 be even pickier about our socks command. this resolves a warning 
we get when we hang up on an unhandshaked socks connection. i'm
still seeing these from polipo. darn it.


svn:r9565
 2007-02-12 03:01:36 +00:00
Roger Dingledine
4e67d5196f remove the socks-wait verbose logging. juliusz found and fixed the 
polipo bug.


svn:r9553
 2007-02-11 02:36:51 +00:00
Roger Dingledine
731d37f717 more useful log messages when we give up on a stream 
svn:r9552
 2007-02-11 02:15:42 +00:00
Nick Mathewson
24e7b9b983 r12213@Kushana: nickm | 2007-02-10 16:25:39 -0500 
Refactor setconf implementation to be a little slower, but far less error prone.


svn:r9549
 2007-02-10 21:26:29 +00:00
Nick Mathewson
2c521d9804 r12212@Kushana: nickm | 2007-02-10 16:09:38 -0500 
Remove XXXX012 for apparently resolved bug


svn:r9548
 2007-02-10 21:26:17 +00:00
Roger Dingledine
01ddb05fba Stop crashing when the controller asks us to resetconf more than 
one config option at once. (Vidalia 0.0.11 does this.)
Backport candidate.


svn:r9545
 2007-02-10 07:04:46 +00:00
Roger Dingledine
b3ac3acefc If we start a server with ClientOnly 1, then set ClientOnly to 0 
and hup, stop triggering an assert based on an empty onion_key.


svn:r9540
 2007-02-09 00:22:43 +00:00
Nick Mathewson
ec54857870 r11732@catbus: nickm | 2007-02-08 18:12:54 -0500 
Fix an "uninitialized variable" warning.


svn:r9536
 2007-02-08 23:24:03 +00:00
Nick Mathewson
76f61da37b r11727@catbus: nickm | 2007-02-08 17:07:50 -0500 
Explain that update_router_desciptor_downloads happens every 10 seconds in main.c, and we don't need to call it from directory.c


svn:r9534
 2007-02-08 22:08:04 +00:00
Nick Mathewson
e00a1cbf16 r11726@catbus: nickm | 2007-02-08 16:04:53 -0500 
Resolve some XXXX012 items:
   - Remove PathlenCoinWeight: if we want it again, we can add it
     back in.
   - Ditto with RelayBandwidth*.
   - Decide to leave in the "hey, you didn't set end_reason!" BUG log message,
     but stop telling people to bug me personally.
   - Postpone strengthening assert_connection_ok(): it's important, but 
     it's also a good way to introduce weird bugs.
   - Move some expensive consistency checking from dns_free_all() into
     assert_cache_ok().


svn:r9533
 2007-02-08 22:07:56 +00:00
Roger Dingledine
90b53beec5 add a comment so i stop worrying 
svn:r9532
 2007-02-08 20:27:58 +00:00
Nick Mathewson
a1a9c66ce5 r11717@catbus: nickm | 2007-02-08 14:44:30 -0500 
Clear up some XXX012s in routerlist.c: make smartlist_choose_by_bandwidth handle statuses with no corresponding routers much better.


svn:r9531
 2007-02-08 19:44:55 +00:00
Nick Mathewson
69def349e0 r11716@catbus: nickm | 2007-02-08 14:19:24 -0500 
Warn when we get a v0 control connection.


svn:r9530
 2007-02-08 19:44:48 +00:00
Nick Mathewson
9c081ab976 r11715@catbus: nickm | 2007-02-08 14:07:03 -0500 
Oops; the change in tor_version_is_obsolete broke a unit test.


svn:r9529
 2007-02-08 19:44:36 +00:00
Nick Mathewson
85d3c2fbaf r11702@catbus: nickm | 2007-02-08 02:10:19 -0500 
Wow. Remember when I wrote that script to tell me about macros that were never used?  Good times.


svn:r9525
 2007-02-08 07:24:15 +00:00
Nick Mathewson
1e2d5f30ff r11700@catbus: nickm | 2007-02-08 02:03:50 -0500 
Fix several bugs in computing recommended versions. 1) refactor is-this-version-good handling and which-vesions-are-good handling to be in the same place. 2) a version is recommended if more than half of the versioning authorities like it, not >= half.  3) "NEW_IN_SERIES" should mean, "I don't know of an 0.1.1.x this recent, and there are some 0.1.2.x versions out", not "I don't know of an 0.1.1.x this recent, but I know some older ones."  This should resolve bug 383.


svn:r9523
 2007-02-08 07:24:06 +00:00
Nick Mathewson
a24b9e6a66 r11694@catbus: nickm | 2007-02-07 13:25:01 -0500 
Fix patch for 9510: never call control_event_stream_status on an exit connection. Should fix assert() noticed by xiando.


svn:r9514
 2007-02-07 18:25:04 +00:00
Nick Mathewson
2e6feb646b r11686@catbus: nickm | 2007-02-07 01:50:14 -0500 
Set hibernate_end_time whenever we start hibernating.  This fixes a problem where we would start hibernating upon startup (since it isn't time to wake up yet) but we would wind up setting the "stop hibernating" time not to the wakeup time, but to the end of the interval.  Also, split hibernate_end_time from shutdown_time. Possible fix for bug 362.


svn:r9512
 2007-02-07 06:54:33 +00:00
Nick Mathewson
071738c2d5 r11673@catbus: nickm | 2007-02-06 14:40:07 -0500 
Report stream end events where a resolve succeeded or where we got a socks protocol error correctly, rather than calling both of them "INTERNAL".  Turn ALREADY_SOCKS_REPLIED into a flag rather than a reason.  This will help debug 367 part 2 a little.


svn:r9511
 2007-02-07 06:54:27 +00:00
Nick Mathewson
026c11c42e r11672@catbus: nickm | 2007-02-06 14:16:56 -0500 
Fix third case of bug 367: make circuit get sent along with END_STREAM_REASON_DESTROY stream CLOSED events.


svn:r9510
 2007-02-07 06:54:22 +00:00
Nick Mathewson
e7f558bd27 r11684@catbus: nickm | 2007-02-07 00:46:37 -0500 
Bump version to 0.1.2.7-alpha-dev


svn:r9509
 2007-02-07 05:52:55 +00:00
Roger Dingledine
f1ca295d23 bump to 0.1.2.7-alpha 
svn:r9507
 2007-02-07 05:32:35 +00:00
Nick Mathewson
295f6d4e0f r11676@catbus: nickm | 2007-02-07 00:10:00 -0500 
(Hopefully) final changes for 0.1.2.7-alpha: disable checking for whether the user account in question exists on --service install, since that seems to make windows go boom.  We can figure out why later.  Also, let the admin specify a password for the target user.


svn:r9506
 2007-02-07 05:10:58 +00:00
Roger Dingledine
7828927a58 Only rewrite a conn's address based on X-Forwarded-For: headers 
if it's a parseable public IP address; and stop adding extra quotes
to the resulting address.


svn:r9505
 2007-02-07 03:40:06 +00:00
Roger Dingledine
690c9cc887 make a log message make more sense 
svn:r9504
 2007-02-07 02:55:34 +00:00
Nick Mathewson
534baec4a1 r11674@catbus: nickm | 2007-02-06 17:00:22 -0500 
Remove a now-bogus assert() from nt_service_command_line(), and change option handling.  (Now that we no longer force a -f, it is possible to have no command-line options for Tor-as-service.)


svn:r9503
 2007-02-06 22:00:25 +00:00
Nick Mathewson
c4faebfa6d r11667@catbus: nickm | 2007-02-06 13:36:18 -0500 
The --service install code can no longer default to adding an -f option for the appdata directory of the current user, since the target user probably will not be able to read it.  Instead, warn the user if no explicit torrc filename is given.


svn:r9502
 2007-02-06 18:36:26 +00:00
Nick Mathewson
f4a1c17e5a r11666@catbus: nickm | 2007-02-06 13:17:24 -0500 
Implement an --ignore-missing-torrc option


svn:r9501
 2007-02-06 18:36:21 +00:00
Nick Mathewson
0c4ab00658 r11664@catbus: nickm | 2007-02-06 11:55:37 -0500 
More win32 account flumdummery: when LocalService exists, you can't detect it via LookupAccountName.  The only good test is to see whether we're on win2k or earlier.
 Apparently, somebody wouldn't know where to draw the line between implementation and interface if you gave them tracing paper and a copy of Stevens.


svn:r9499
 2007-02-06 16:55:42 +00:00
Roger Dingledine
da5cd33ab8 stop crashing on nt service install; but matt says still not right 
svn:r9496
 2007-02-06 04:58:56 +00:00
Roger Dingledine
4ba57f68e4 more changes. i'm all caught up now. 
svn:r9495
 2007-02-06 02:49:07 +00:00
Roger Dingledine
9aa8e490f8 cleanups based on looking through svn commits 
svn:r9491
 2007-02-06 00:27:03 +00:00
Nick Mathewson
e0acb45b86 r11650@catbus: nickm | 2007-02-05 17:02:54 -0500 
Resolve (I hope) remaining nt service compilation issues.


svn:r9489
 2007-02-05 22:02:58 +00:00
Nick Mathewson
d930440ae5 r11648@catbus: nickm | 2007-02-05 16:48:50 -0500 
Fix bugs in last nt services patch: syntax, typename.


svn:r9488
 2007-02-05 21:48:53 +00:00
Nick Mathewson
8b238404de r11646@catbus: nickm | 2007-02-05 16:15:48 -0500 
Make default NT service user be LocalService.  Again, I have no idea if this compiles, let alone if it works.


svn:r9487
 2007-02-05 21:15:52 +00:00
Nick Mathewson
337fdb7eb6 r11643@catbus: nickm | 2007-02-05 15:44:59 -0500 
Fix bug 254, sort of: make the default NT service user NetworkService rather than NULL (system).  Also, add a --user argument to --service install so that admins can override this default: this latter point should take care of most of my objections to NetworkService.  I have no idea whether this even compiles.


svn:r9486
 2007-02-05 20:45:02 +00:00
Nick Mathewson
47ff0c7fc1 r11641@catbus: nickm | 2007-02-05 13:59:26 -0500 
Add a REMAP state to stream events so that controllers can learn exactly when the target address for a stream has changed.  May help Vidalia resolve confusions related to bug 375.


svn:r9484
 2007-02-05 19:15:13 +00:00
Nick Mathewson
f02be02356 r11639@catbus: nickm | 2007-02-05 13:33:38 -0500 
Add documentation to src/common/*.h; improve documentation for SMARTLIST_FOREACH; remove never-used options and corresponding tests from tor_strpartition.


svn:r9483
 2007-02-05 18:33:52 +00:00
Nick Mathewson
03ef2156c9 r11637@catbus: nickm | 2007-02-05 12:41:51 -0500 
Fix an XXXX012, and make circuits_pending_or_conns a static variable.  In addition to cleaning up the code, this may also resolve Bug 386 if Roger has the right intuition there.


svn:r9482
 2007-02-05 17:42:40 +00:00
Nick Mathewson
6149ab01f8 r12129@Kushana: nickm | 2007-02-03 09:57:36 -0500 
Update assert_connection_ok() to match the "block tunnelled dir conn if the or conn is full" logic.  This may fix bug 385.


svn:r9479
 2007-02-03 14:57:47 +00:00
Nick Mathewson
275109d8b0 r11631@catbus: nickm | 2007-02-02 15:39:53 -0500 
Add missing return statement.


svn:r9478
 2007-02-02 20:39:55 +00:00
Nick Mathewson
fefba95363 r11629@catbus: nickm | 2007-02-02 15:06:17 -0500 
Removing the last DOCDOC comment hurt so much that I had to use Doxygen to identify undocumented macros and comments, and add 150 more DOCDOCs to point out where they were.  Oops.  Hey, kids!  Fixing some of these could be your first Tor patch!


svn:r9477
 2007-02-02 20:06:43 +00:00
Nick Mathewson
e521c96cb1 r12123@Kushana: nickm | 2007-02-02 13:57:42 -0500 
Resolve remaining DOCDOC comments.


svn:r9476
 2007-02-02 18:58:11 +00:00
Nick Mathewson
07e6eecdb2 r12122@Kushana: nickm | 2007-02-02 10:41:39 -0500 
Fail when we are unable to parse the nameserver configuration.


svn:r9475
 2007-02-02 18:58:04 +00:00
Nick Mathewson
8507699256 r11624@catbus: nickm | 2007-02-01 13:17:35 -0500 
Note a few questionable bits pointed out by RATS.  (And no, RATS, I'm not about to stop having fixed-sized local buffers for you.  I know how to use them, thankyouverymuch.)


svn:r9474
 2007-02-01 18:33:02 +00:00
Nick Mathewson
6f2a92c5b3 r11621@catbus: nickm | 2007-02-01 13:09:18 -0500 
Fix another VC compiler warning.


svn:r9473
 2007-02-01 18:09:34 +00:00
Nick Mathewson
5cb99857bc r11620@catbus: nickm | 2007-02-01 13:06:27 -0500 
Call stat() slightly less often; use fstat() when possible.


svn:r9472
 2007-02-01 18:09:27 +00:00
Nick Mathewson
e7ac17fdf5 r11613@catbus: nickm | 2007-01-30 19:58:03 -0500 
Re-enable server side PTR-record cacheing.


svn:r9468
 2007-01-31 00:58:06 +00:00
Nick Mathewson
49b5e5cf9c r11610@catbus: nickm | 2007-01-30 17:44:02 -0500 
Fix a bug in our assertions related to removing recently-completed DNS lookup attempts on exit.  It is okay to find a cache entry with the same name as a DONE entry, so long it is not the same struct as the DONE entry.


svn:r9467
 2007-01-30 22:44:24 +00:00
Nick Mathewson
76f896e714 r11607@catbus: nickm | 2007-01-30 17:19:27 -0500 
Audit non-const char arguments; make a lot more of them const.


svn:r9466
 2007-01-30 22:19:41 +00:00
Nick Mathewson
1894e7ea01 r11606@catbus: nickm | 2007-01-30 16:52:23 -0500 
Write the entry guards section of path-spec; note a possible bug in cirbuitbuild.c; add a const; defer work on torrc.complete to be part of a bigger config documentation reorg.


svn:r9465
 2007-01-30 22:19:31 +00:00
Nick Mathewson
a701cd7e97 r11591@catbus: nickm | 2007-01-29 17:31:02 -0500 
Add an XXXX comment to dirserv.c so I can take it out of my todo email folder.


svn:r9459
 2007-01-29 23:09:22 +00:00
Nick Mathewson
cd374f810c r11586@catbus: nickm | 2007-01-29 13:13:27 -0500 
Add a couple of fixes I turned up while writing regression tests for libevent: Allow DNS servers on ports other than 53, and handle TTLs correctly on reverse hostname lookups.


svn:r9458
 2007-01-29 18:13:42 +00:00
Nick Mathewson
ac0dbc3d9b r11585@catbus: nickm | 2007-01-29 11:26:03 -0500 
Oops; fix compilation.


svn:r9457
 2007-01-29 18:13:39 +00:00
Nick Mathewson
42d03890b4 r11584@catbus: nickm | 2007-01-29 11:25:40 -0500 
Fix/update some XXX012 points.


svn:r9456
 2007-01-29 18:13:37 +00:00
Nick Mathewson
21f5e06862 r11583@catbus: nickm | 2007-01-29 11:19:48 -0500 
Make man page stop saying that BandwidthRate is for incoming bandwidth only; Add some XXX012s for config options that should maybe die.


svn:r9455
 2007-01-29 18:13:34 +00:00
Roger Dingledine
f58678730c there's such a thing as too much indirection 
svn:r9451
 2007-01-28 08:06:00 +00:00
Roger Dingledine
1fea3a1e59 stop trying to hand 'platform' all around directory.c when we have a 
bit in routerstatus_t that tells us what we need to know.


svn:r9448
 2007-01-27 21:18:08 +00:00
Roger Dingledine
88796acf4b fix all the bugs i could find in nick's bridge dir commit. 
let's hope i got them all.


svn:r9442
 2007-01-27 20:44:09 +00:00
Roger Dingledine
d8d074f2e5 If the user asks to use invalid exit nodes, be willing to use the 
unstable ones.


svn:r9441
 2007-01-27 19:40:49 +00:00
Roger Dingledine
add7d7af19 Bring us one step closer to being able to establish an encrypted 
directory tunnel without knowing a descriptor first. Still not
ready yet. As part of the change, now assume we can use a
create_fast cell if we don't know anything about a router.


svn:r9440
 2007-01-27 19:29:16 +00:00
Roger Dingledine
b323126dda remove an XXX; add two more. 
svn:r9438
 2007-01-27 19:02:37 +00:00
Roger Dingledine
283c61e5d5 If the socks handshake hasn't started, don't send a 
"DNS resolve socks failed" handshake reply; just close it.


svn:r9437
 2007-01-27 18:56:13 +00:00
Roger Dingledine
baeeadb6eb avoid messy crashes (bugfix by nick) 
svn:r9435
 2007-01-27 18:33:33 +00:00
Roger Dingledine
c6fd3c7158 the other half of my patch. more coming later. 
svn:r9434
 2007-01-27 09:24:23 +00:00
Roger Dingledine
9057af692a Weight directory requests by advertised bandwidth. Now we can 
let servers enable write limiting but still allow most clients to
succeed at their directory requests.


svn:r9433
 2007-01-27 09:13:19 +00:00
Nick Mathewson
9984cad6e8 r11552@catbus: nickm | 2007-01-27 03:55:02 -0500 
This one is a little tricky.  Our BEGIN_DIR implementation has a
 problem: the dirserv conns will decide they can flush all their data
 immediately, since the edge_conns will read greedily.
 
 For our 0.1.2 workaround, we track which or_conn a bridged dirserv
 conn is attached to, and stop writing when its outbuf is too full, and
 start writing again when the or_conn's outbuf empties out a little.
 
 This requires a bit of pointer management.  Let's hope it works.
 


svn:r9432
 2007-01-27 08:55:06 +00:00
Nick Mathewson
152547be49 r11548@catbus: nickm | 2007-01-27 00:15:47 -0500 
Fix two assert bugs encountered when trying ipv6 lookups with eventdns code.


svn:r9430
 2007-01-27 05:15:53 +00:00
Roger Dingledine
e9f6456b2c Bugfix: If we're not marking exits as guards, ignore exit bandwidth 
when we're deciding the required bandwidth to become a guard.


svn:r9423
 2007-01-26 09:03:20 +00:00
Roger Dingledine
75a5fde460 Stop saying !is_internal_IP() when we really meant 
connection_is_rate_limited(). One day this will be useful.


svn:r9422
 2007-01-26 08:13:53 +00:00
Roger Dingledine
99c1771432 never refuse directory requests from local addresses 
svn:r9421
 2007-01-26 08:01:29 +00:00
Roger Dingledine
9d5449c52e Inform the server operator when we decide not to advertise a 
DirPort due to AccountingMax enabled or a low BandwidthRate. It
was confusing Zax, so now we're hopefully more helpful.


svn:r9404
 2007-01-25 19:41:15 +00:00
Nick Mathewson
75db2a61cb r11500@catbus: nickm | 2007-01-25 10:37:11 -0500 
Fix argument types in printf: try to make buildbot happier.


svn:r9403
 2007-01-25 15:37:14 +00:00
Roger Dingledine
bf9baa85a8 more hints as arma tracks down a polipo bug 
svn:r9400
 2007-01-24 23:58:41 +00:00
Nick Mathewson
71f47320f8 r11493@catbus: nickm | 2007-01-24 18:41:52 -0500 
Use set_uint16/32 instead of raw assignments in order to make gcc happier.


svn:r9399
 2007-01-24 23:42:00 +00:00
Nick Mathewson
5cd1f0680e r11287@catbus: nickm | 2007-01-23 20:30:04 -0500 
Yet more documentation. (Again, trying to see whether I have buildbot working).


svn:r9396
 2007-01-24 01:30:07 +00:00
Roger Dingledine
c716eefbca start tracking down a funny-looking log message 
svn:r9395
 2007-01-24 01:18:45 +00:00
Nick Mathewson
792f819212 r11285@catbus: nickm | 2007-01-23 19:43:50 -0500 
More documentation. (Again, trying to see whether I have buildbot working).


svn:r9394
 2007-01-24 00:43:52 +00:00
Nick Mathewson
2522c392bd r11283@catbus: nickm | 2007-01-23 19:20:47 -0500 
Add documentation to dns.c (mainly to test new buildbot version)


svn:r9393
 2007-01-24 00:20:49 +00:00
Nick Mathewson
79dd306527 r11278@catbus: nickm | 2007-01-23 14:22:27 -0500 
More doxygen comments: this time mainly around spooling and storing directory information.


svn:r9392
 2007-01-23 19:22:52 +00:00
Nick Mathewson
ba53e0029f r11277@catbus: nickm | 2007-01-23 14:08:08 -0500 
When logging TLS certificate and identity-related errors, scrub IP addresses for incoming connections, and distinguish between incoming and outgoing connections in log messages.  Backport candidate.


svn:r9391
 2007-01-23 19:22:49 +00:00
Nick Mathewson
c0c67d28f5 r9727@catbus: nickm | 2007-01-22 16:12:39 -0500 
Remove redundant check for whether _connection_write_to_buf_impl is called with a zlib and a non-directory connection: TO_DIR_CONN will already assert if it gets a non-dir connection.


svn:r9390
 2007-01-23 19:22:46 +00:00
Nick Mathewson
adc5bb4d04 r9723@catbus: nickm | 2007-01-22 15:47:17 -0500 
Fix an XXXX012 in routerlist.c: when we do not have enough networkstatuses to launch router requests, do not launch router requests. Backport candidate.


svn:r9388
 2007-01-22 20:57:26 +00:00
Roger Dingledine
9f733c31cc minor cleanups 
svn:r9387
 2007-01-22 19:20:33 +00:00
Nick Mathewson
36620ca056 r9718@catbus: nickm | 2007-01-22 14:13:00 -0500 
Free CACHE_STATE_DONE cached_router_t items on dns_free_all().


svn:r9386
 2007-01-22 19:13:02 +00:00
Nick Mathewson
84790d059f r9715@catbus: nickm | 2007-01-22 02:51:04 -0500 
Document a few undocumented functions and arguments.


svn:r9385
 2007-01-22 07:51:06 +00:00
Roger Dingledine
ab838bddb8 Flush local controller connection buffers periodically as we're 
writing to them, so we avoid queueing 4+ megabytes of data before
trying to flush.

Also add a new XXX012.


svn:r9382
 2007-01-22 06:07:51 +00:00
Roger Dingledine
7b5f9887fa resolve an XXX, add a new XXX, simplify some code 
svn:r9381
 2007-01-22 05:59:59 +00:00
Nick Mathewson
033e20ca0b r9709@catbus: nickm | 2007-01-21 21:34:03 -0500 
Fix memory leak on networkstatus 503.


svn:r9380
 2007-01-22 02:34:50 +00:00
Nick Mathewson
e0ae28d0cd r9701@catbus: nickm | 2007-01-21 13:21:25 -0500 
Detect and reject another (harmless) class of DNS replies.  Also, fix a couple of IPv6 bugs in evendns.c


svn:r9379
 2007-01-21 18:21:39 +00:00
Nick Mathewson
ff62a4d91b r9692@catbus: nickm | 2007-01-21 12:04:22 -0500 
Detect pointer loops in DNS requests and replies; avoid infinite loop on such malformed replies.  Fixes bug 380.


svn:r9378
 2007-01-21 17:05:10 +00:00
Roger Dingledine
bcbd289af5 If our system clock jumps back in time, don't publish a negative 
uptime in the descriptor. Also, don't let the global rate limiting
buckets go absurdly negative.


svn:r9377
 2007-01-21 06:24:05 +00:00
Nick Mathewson
ef0720f909 r9689@catbus: nickm | 2007-01-19 22:34:20 -0500 
And remove another strcpy.


svn:r9375
 2007-01-20 03:35:03 +00:00
Nick Mathewson
c57ef84fc5 r11987@Kushana: nickm | 2007-01-19 14:57:28 -0500 
Implement SOCKS_BAD_HOSTNAME status event. Defer remaining status events.  Clean up control-spec.txt a little, and fill in recommendations for events.


svn:r9374
 2007-01-19 21:25:32 +00:00
Nick Mathewson
39e50cbb48 r9776@totoro: nickm | 2007-01-18 14:37:01 -0500 
Yes, apparently saying strcpy in front of openbsd is like saying "intellectual property" in front of RMS.  They both have a point, I guess, even though they extend it to contexts where it is completely irrelevant.


svn:r9370
 2007-01-18 19:37:23 +00:00
Roger Dingledine
060be4c62b man, i could have sworn that compiled 
svn:r9369
 2007-01-18 03:42:45 +00:00
Roger Dingledine
a3eaabfeb2 Be willing to read or write on local connections (e.g. controller 
connections) even when the global rate limiting buckets are empty.


svn:r9368
 2007-01-18 03:38:24 +00:00
Roger Dingledine
cb472fc550 break out the big guns: reject dir requests much more 
aggressively. my vidalia bandwidth graph, when rate limiting
to 32kB/s, has the "write" line constantly at 32kB. I can't
imagine what's going on with the relay latency but it can't
be good.


svn:r9366
 2007-01-17 01:29:54 +00:00
Roger Dingledine
8662f18102 boots and suspenders, or whatever the idiom is 
svn:r9365
 2007-01-17 00:14:43 +00:00
Nick Mathewson
a36ec61fd7 r11983@Kushana: nickm | 2007-01-16 10:28:47 -0500 
Be even more clever about severity of messages from eventdns: NOTICE when the first nameserver comes up; INFO on subsequent ones.


svn:r9364
 2007-01-16 17:39:08 +00:00
Nick Mathewson
093d71762c r11978@Kushana: nickm | 2007-01-15 18:54:25 -0500 
Apparently, the OpenBSD linker thinks it knows C better than I do, and gets to call me names for having strcat and strcpy and sprintf in my code--whether I use them safely or not.  All right, OpenBSD.  You win... this round.


svn:r9360
 2007-01-15 23:56:38 +00:00
Nick Mathewson
11ed4500de r11975@Kushana: nickm | 2007-01-15 17:11:15 -0500 
set or_conn->tls_error to 0 on non-error to avoid looking at stale errors.


svn:r9359
 2007-01-15 22:11:21 +00:00
Nick Mathewson
db6f0f3617 r11973@Kushana: nickm | 2007-01-15 16:43:25 -0500 
Answer questions from r9348.


svn:r9358
 2007-01-15 21:44:59 +00:00
Nick Mathewson
23c18f1dc2 svn:r9357 2007-01-15 21:21:21 +00:00
Nick Mathewson
af857f2da5 r11967@Kushana: nickm | 2007-01-15 16:13:15 -0500 
tidy up more whitespace issues


svn:r9356
 2007-01-15 21:21:14 +00:00
Nick Mathewson
380f8983c7 r11966@Kushana: nickm | 2007-01-15 16:12:17 -0500 
Tidy up ORCONN reason patch from Mike Perry.  Changes: make some of the handling of TLS error codes less error prone.  Enforce house style wrt spaces.  Make it compile with --enable-gcc-warnings.  Only set or_conn->tls_error in the case of an actual error.  Add a changelog entry.


svn:r9355
 2007-01-15 21:21:05 +00:00
Nick Mathewson
ead35ef944 r11957@Kushana: nickm | 2007-01-15 15:25:57 -0500 
Patch from Mike Perry: Track reasons for OR connection failure; display them in control events. Needs review and revision.


svn:r9354
 2007-01-15 21:13:37 +00:00
Roger Dingledine
37b5132ad8 Expire socks connections if they spend too long waiting for the 
handshake to finish. Previously we would let them sit around for
days, if the connecting application didn't close them either.

Also take this opportunity to refactor a duplicate bit of circuituse.c.

And change the semantics of SocksTimeout slightly, but I think it'll
be ok.


svn:r9350
 2007-01-15 09:09:03 +00:00
Roger Dingledine
a9c250837e patch from edmanm to make "-nt-service" command-line work too 
svn:r9349
 2007-01-15 08:52:01 +00:00
Roger Dingledine
cf7069fca4 two more todo items, to make eventdns log messages less loud 
svn:r9348
 2007-01-15 08:40:50 +00:00
Andrew Lewman
930e12920d Update copyright in config.c while I'm there. Update man page to 
reflect all available options to tor binary.


svn:r9341
 2007-01-13 05:09:09 +00:00
Nick Mathewson
c1b5f53679 r11938@Kushana: nickm | 2007-01-11 11:02:28 -0500 
Check addresses for rfc953-saneness at exit too, and give a PROTOCOL_WARN when they fail.  Also provide a mechanism to override this, so blossom can have its @@##$$^.whatever.exit hostnames if it wants.


svn:r9336
 2007-01-11 16:02:39 +00:00
Nick Mathewson
3dfeaaaf6e r11931@Kushana: nickm | 2007-01-11 09:12:49 -0500 
Fix a crash bug in the presence of DNS hijacking.


svn:r9333
 2007-01-11 14:13:13 +00:00
Nick Mathewson
0c77ae2fcb r11930@Kushana: nickm | 2007-01-11 09:05:27 -0500 
fix recently-introduced segfault when not running as a dirserver


svn:r9332
 2007-01-11 14:13:04 +00:00
Roger Dingledine
7beb0fd5dd Make the unit tests work again. 
The foo_init() funcs need to happen before we call
options_act() and friends.


svn:r9331
 2007-01-11 01:41:07 +00:00
Roger Dingledine
35bd6caa1a Fix crash with "tor --list-fingerprint" (reported by seeess). 
svn:r9328
 2007-01-10 23:48:24 +00:00
Nick Mathewson
8835bb844e r11922@Kushana: nickm | 2007-01-10 15:43:18 -0500 
Clear untrusted networkstatuses after 10 days too.  (This is not a terribly awful bug, since we would only ever retain 16 of them, but it still might be nice to backport.)  Resolves part A of bug 372.


svn:r9324
 2007-01-10 20:43:40 +00:00
Nick Mathewson
9937695598 r11919@Kushana: nickm | 2007-01-10 13:32:48 -0500 
Add some defensive programming to eventdns.c in an attempt to catch possible memory stomping bugs.


svn:r9322
 2007-01-10 19:49:21 +00:00
Nick Mathewson
ceefc1e9a7 r11914@dhcp-18-188-69-59: nickm | 2007-01-10 11:20:59 -0500 
Base skew calculation on conn->timestamp_lastwritten, not on now.


svn:r9319
 2007-01-10 16:33:40 +00:00
Roger Dingledine
da7f0b5366 bump to 0.1.2.6-alpha-dev so we're ready for tomorrow's 
surprise release too


svn:r9314
 2007-01-09 05:47:23 +00:00
Roger Dingledine
ca66074106 bump to 0.1.2.6-alpha 
svn:r9311
 2007-01-09 05:24:42 +00:00
Roger Dingledine
794fedb0ad some cleanups. more probably remain, but hey, it's an alpha. 
time to put out the bugfix release.


svn:r9309
 2007-01-09 05:14:34 +00:00
Roger Dingledine
254005fc1b apparently i think of comments with no whitespace around them as 
"read this if you don't understand the code and want some help."
which is not the same as "hey, you think you understand this code,
but you don't."


svn:r9307
 2007-01-09 00:57:36 +00:00
Roger Dingledine
1d8a4cb989 Fix an assert error introduced in 0.1.2.5-alpha: if a single TLS 
connection handles more than 4 gigs in either direction, we assert.


svn:r9306
 2007-01-09 00:50:50 +00:00
Roger Dingledine
c85ff4d6ab Fix an assert error introduced in 0.1.2.5-alpha: if you're an 
advertised exit node, somebody might try to exit from you when
you're bootstrapping and before you've built your descriptor yet.


svn:r9305
 2007-01-09 00:37:13 +00:00
Nick Mathewson
5239602dbc r11873@Kushana: nickm | 2007-01-06 02:32:18 -0500 
Implement DNS-related status events.


svn:r9285
 2007-01-06 07:34:07 +00:00
Nick Mathewson
bc14afe064 r11872@Kushana: nickm | 2007-01-06 02:14:12 -0500 
Implement a control status event for bad libevent version/method combos.  Warn that libevent <1.1 with select() is needlessly slow.  Reply to comment.


svn:r9284
 2007-01-06 07:34:02 +00:00
Nick Mathewson
03d6e98111 r11868@Kushana: nickm | 2007-01-06 01:32:55 -0500 
Document how we set Guard a little better.


svn:r9283
 2007-01-06 06:32:59 +00:00
Nick Mathewson
d6073cc7fa r11864@Kushana: nickm | 2007-01-06 01:25:59 -0500 
Fix an XXXX012 in connection.c: prevent overflows on unfeasibly-high-bandwidth servers on 32-bit architectures.


svn:r9282
 2007-01-06 06:27:15 +00:00
Nick Mathewson
aa7b72c97d r11863@Kushana: nickm | 2007-01-06 01:12:24 -0500 
Fix computation of total_exit_bandwidth; this will cause exits not to get recommended as guards if the total exit bandwidth if they constitute less than a third of total available bandwidth.  There may be problems here with flapping; lets see if they occur in practice.


svn:r9281
 2007-01-06 06:26:53 +00:00
Nick Mathewson
336624ce8f r11862@Kushana: nickm | 2007-01-06 01:05:15 -0500 
Re-enable warning when we resolve an already resolved address.  We only warn here now if the address is not a testing address.  Also, refactor out a function to check whether an address is used for testing.


svn:r9280
 2007-01-06 06:26:46 +00:00
Nick Mathewson
c8466c5919 r11824@Kushana: nickm | 2007-01-03 17:15:28 -0500 
control-spec: upcase arguments in status events; note unimplemented events individually
 r11825@Kushana:  nickm | 2007-01-03 17:41:43 -0500
 Implement EXTERNAL IP server status event.
 r11826@Kushana:  nickm | 2007-01-03 17:47:10 -0500
 Implement BAD_SERVER_DESCRIPTOR server status event.
 r11827@Kushana:  nickm | 2007-01-03 18:01:56 -0500
 Implement SOCKS_UNKNOWN_PROTOCOL and DANGEROUS_SOCKS client events.
 r11828@Kushana:  nickm | 2007-01-03 18:23:22 -0500
 Implement BUG controller events. Also, flush ERR-level status events just like ERR-level log messages.
 r11829@Kushana:  nickm | 2007-01-03 23:37:27 -0500
 Yet more status events: CLOCK_SKEW, GOOD/ACCEPTED_SERVER_DESCRIPTOR, {CHECKING_}REACHABILITY_{SUCCEEDED|FAILED}
 r11833@Kushana:  nickm | 2007-01-05 16:56:37 -0500
 Note some unimplementedness in control-spec.txt


svn:r9279
 2007-01-06 05:42:31 +00:00
Roger Dingledine
6b126ea040 bump to 0.1.2.5-alpha-dev 
svn:r9278
 2007-01-06 05:41:01 +00:00
Roger Dingledine
71ed0314f6 make tor-resolve -x work on intel-endian platforms too 
svn:r9274
 2007-01-06 04:48:34 +00:00
Nick Mathewson
135aed5670 r11850@Kushana: nickm | 2007-01-05 17:12:08 -0500 
Look in netinet/in6.h header when looking for struct in6_addr. (Issue found by saeftl.)


svn:r9272
 2007-01-05 22:12:15 +00:00
Roger Dingledine
48a9fe4bbd be a bit less eager to reject v1 dir requests due to load 
svn:r9271
 2007-01-05 06:59:36 +00:00
Roger Dingledine
ee0d2d486d fix a bug, defer a bug, bump to 0.1.2.5-alpha 
svn:r9270
 2007-01-05 06:30:31 +00:00
Roger Dingledine
658c09c06f more progress and cleanups 
svn:r9269
 2007-01-05 06:03:10 +00:00
Roger Dingledine
466650aa14 when we added orport= to the dirserver line, we started 
freeing the string in the middle. this was probably xiando's
crash bug.


svn:r9265
 2007-01-05 01:23:34 +00:00
Roger Dingledine
7b88380690 Avoid a double-free when parsing malformed DirServer lines. 
svn:r9264
 2007-01-05 01:12:10 +00:00
Roger Dingledine
5e89bc9b4b fix a bug i introduced in r9249; and more cleanups. 
svn:r9263
 2007-01-04 09:12:23 +00:00
Roger Dingledine
a66d86149b avoid a crash-all-the-clients segfault if a rogue dir 
authority leaves a "v" line blank.


svn:r9262
 2007-01-04 06:36:43 +00:00
Roger Dingledine
da2ff14839 Set orport= for 4 of the 5 dir authorities; Fix getinfo ns/all; Fix seg 
fault when starting a server without a fingerprint file present.


svn:r9261
 2007-01-04 05:41:24 +00:00
Roger Dingledine
50f0e36094 man page entries for TunnelDirConns and PreferTunneledDirConns 
and add a todo item for nick in case he gets bored :)


svn:r9260
 2007-01-04 04:35:18 +00:00
Roger Dingledine
88c3c84bda be slightly less eager to yell at a server for being unreachable 
svn:r9259
 2007-01-03 23:58:03 +00:00
Nick Mathewson
2963d4acc2 r11820@Kushana: nickm | 2007-01-03 14:54:05 -0500 
Add (and specify) a BadDirectory flag to networkstatuses, so authorities can tell clients that some caches are broken.  Also, implement an as-yet-unused function to estimate how many bytes will be sent on a directory connection.


svn:r9255
 2007-01-03 19:58:00 +00:00
Nick Mathewson
931e555ef9 r11818@Kushana: nickm | 2007-01-03 08:29:17 -0500 
Fix compile error with warnings enabled: connection_dir_supports_tunnels was redeclared as static.


svn:r9254
 2007-01-03 13:29:30 +00:00
Roger Dingledine
50e36dc11b more cleanups, including a shiny new XXX012 
svn:r9250
 2007-01-03 10:30:26 +00:00
Roger Dingledine
d677332a83 checkpoint as we add PreferTunneledDirConns config option 
svn:r9249
 2007-01-03 06:33:03 +00:00
Nick Mathewson
eebbfbc854 r11806@Kushana: nickm | 2007-01-03 00:12:21 -0500 
Fix unit test broken by r9239.


svn:r9248
 2007-01-03 05:12:26 +00:00
Roger Dingledine
9545bbf57f - When the user uses bad syntax in the Log config line, stop 
suggesting other bad syntax as a replacement.


svn:r9247
 2007-01-03 03:56:17 +00:00
Roger Dingledine
7396b8eecf interim tweaks 
svn:r9246
 2007-01-03 03:45:53 +00:00
Nick Mathewson
f5b984a36f r11800@Kushana: nickm | 2007-01-02 16:46:45 -0500 
Remove an XXXX012 for which the answer is "not really."


svn:r9244
 2007-01-02 21:47:28 +00:00
Nick Mathewson
cbdd21cbf5 r11799@Kushana: nickm | 2007-01-02 16:38:34 -0500 
Simplify and remove most of dirserv_orconn_tls_cone 


svn:r9243
 2007-01-02 21:47:21 +00:00
Nick Mathewson
2caeaf4e2f r11787@Kushana: nickm | 2007-01-02 14:40:14 -0500 
Stop polluting new descriptors with the defaults-to-1 "opt eventdns" entry.


svn:r9239
 2007-01-02 20:08:03 +00:00
Nick Mathewson
75eca91459 r11786@Kushana: nickm | 2007-01-02 14:32:54 -0500 
Add a comment about a possible refactoring in main.c


svn:r9238
 2007-01-02 20:07:54 +00:00
Andrew Lewman
4f565b73ef Fix formatting in eventdns.c. Remove the rest of the osx binary 
uninstaller.


svn:r9235
 2007-01-02 06:26:42 +00:00
Nick Mathewson
722a3ab544 r11784@Kushana: nickm | 2007-01-02 01:13:04 -0500 
Spec-conformance on r9181: make "opt v" strings start with "Tor".


svn:r9233
 2007-01-02 06:13:10 +00:00
Nick Mathewson
6ae3ba9b2d r11777@Kushana: nickm | 2007-01-01 21:01:10 -0500 
Fix an idiot bug in r9181: snprintf returns <0 on error, not !=0.


svn:r9232
 2007-01-02 02:01:15 +00:00
Nick Mathewson
46092f8163 r11765@Kushana: nickm | 2006-12-29 16:04:22 -0500 
Remove duplicated code in dirserv_get_networkstatus_v2; document dirserv_get_networkstatus_v2_fingerprints. Down to 13 XXXX012 items.


svn:r9220
 2006-12-30 02:41:14 +00:00
Nick Mathewson
c54b7c4d56 r11761@Kushana: nickm | 2006-12-29 15:45:56 -0500 
Another cleanup: expand_exit_policy_aliases was totally redundant with respect to router_parse_[private_]addr_policy_private.


svn:r9219
 2006-12-29 20:50:24 +00:00
Nick Mathewson
7ee99ba342 r11759@Kushana: nickm | 2006-12-29 15:21:14 -0500 
Actually, handle_getinfo_helper supports 552 results just fine: just leave *answer unset.


svn:r9217
 2006-12-29 20:49:47 +00:00
Nick Mathewson
e3d5e4fcae Okay, now descriptors seem to be buildable. 
svn:r9216
 2006-12-29 17:10:29 +00:00
Nick Mathewson
2741dd5741 r11755@Kushana: nickm | 2006-12-29 11:49:20 -0500 
Calculate the length of policy strings correctly again.


svn:r9215
 2006-12-29 16:49:33 +00:00
Nick Mathewson
a77bbe2346 r11753@Kushana: nickm | 2006-12-29 11:30:28 -0500 
Fix flipped sign in compare: make descriptors buildable again.


svn:r9214
 2006-12-29 16:31:37 +00:00
Nick Mathewson
6fbf17e7b0 r11749@Kushana: nickm | 2006-12-29 00:51:42 -0500 
Remove dead code; make targets of addressmap commands/configs use AllowNonRFC953Hostnames


svn:r9211
 2006-12-29 05:51:50 +00:00
Nick Mathewson
0e172d9f6e r11745@Kushana: nickm | 2006-12-29 00:00:28 -0500 
Close any directory connection on which we have received 10MB or more of data.  This prevents a malicious directory cache from running us out of memory by spooling an infinite amount of data.  (Not a terribly good attack, but hey, every one helps.)


svn:r9210
 2006-12-29 05:07:25 +00:00
Nick Mathewson
8728e2826f r11744@Kushana: nickm | 2006-12-28 23:43:53 -0500 
Refactor connection_write_to_buf_zlib back into connection_write_to_buf.  Hooray for dumping duplicate code.


svn:r9209
 2006-12-29 05:07:04 +00:00
Nick Mathewson
26c0d6ec58 r11743@Kushana: nickm | 2006-12-28 23:13:21 -0500 
Refactor _connection_controller_force_write back into conncetion_handle_write.  Again, the line count goes down: groovy!


svn:r9208
 2006-12-29 05:06:47 +00:00
Nick Mathewson
361998d0f3 r11741@Kushana: nickm | 2006-12-28 22:41:29 -0500 
Count TLS bytes accurately: previously, we counted only the number of bytes read or transmitted via tls, not the number of extra bytes used to do so.  This has been a lonstanding wart.  The fix "Works for me".


svn:r9207
 2006-12-29 03:42:46 +00:00
Nick Mathewson
7cfdac1bf6 r11737@Kushana: nickm | 2006-12-28 18:32:13 -0500 
Remove some dead code; refactor some duplicated code.


svn:r9206
 2006-12-29 02:49:12 +00:00
Nick Mathewson
b59573949e r11736@Kushana: nickm | 2006-12-28 17:46:23 -0500 
Mark a pile of XXXX comments as targetted for 0.1.2: some because they look important, some because they look easy.


svn:r9205
 2006-12-29 02:47:51 +00:00
Nick Mathewson
0bbbf98be4 r11727@Kushana: nickm | 2006-12-28 16:27:17 -0500 
If we only have a single nameserver, raise the threshold to decide that the nameserver is dead.  (Another fumbling attempt to do something about bug 326.)


svn:r9203
 2006-12-28 21:29:37 +00:00
Nick Mathewson
3996fd1d9d r11726@Kushana: nickm | 2006-12-28 16:24:06 -0500 
Expose a function from eventdns.c to set options without having to make a fake configuration file.  Also, add more settable options


svn:r9202
 2006-12-28 21:29:31 +00:00
Nick Mathewson
460a476efa r11725@Kushana: nickm | 2006-12-28 14:44:56 -0500 
Partial solution to 326: downgrade single-nameserver failures to INFO.


svn:r9201
 2006-12-28 21:29:26 +00:00
Nick Mathewson
d9f1f3533d r11724@Kushana: nickm | 2006-12-28 14:22:35 -0500 
Refactor and unify my-ip-addr-changed logic.  Make change in IP address or in nameservers reset and relaunch DNS hijacking tests.


svn:r9200
 2006-12-28 21:29:20 +00:00
Nick Mathewson
e5f5b96ca6 r11723@Kushana: nickm | 2006-12-28 13:52:48 -0500 
Fix bug 364: check for whether popular hostnames (curently google, yahoo, mit, and slashdot) are getting wildcarded.  If they are, we are probably behind a DNS server that is useless: change our exit policy to reject *:*.


svn:r9199
 2006-12-28 21:29:11 +00:00
Nick Mathewson
4cd302a1eb r11722@Kushana: nickm | 2006-12-28 13:51:42 -0500 
Add a helper function for case-insensitive search through a smartlist


svn:r9198
 2006-12-28 21:29:03 +00:00
Nick Mathewson
e631b0a56f r11719@Kushana: nickm | 2006-12-26 17:41:09 -0500 
Add SOCKS5 and reverse lookup support to C verseion of tor-resolve


svn:r9195
 2006-12-26 22:41:49 +00:00
Nick Mathewson
1df04d70f7 r11718@Kushana: nickm | 2006-12-26 16:57:44 -0500 
Add client-side caching for reverse DNS.


svn:r9194
 2006-12-26 22:41:43 +00:00
Nick Mathewson
58ae3cd648 r11713@Kushana: nickm | 2006-12-24 22:42:08 -0500 
Better handling of internal addresses wrt X-Your-Address-Is (never believe them; never provide them.) Also, report something useful for X-Your-Address-Is with one-hop tunneled connections.


svn:r9191
 2006-12-25 03:42:38 +00:00
Nick Mathewson
3ab84c5f48 r11711@Kushana: nickm | 2006-12-24 21:42:57 -0500 
Stop counting 503s against the total number of failures allowed for a download.


svn:r9190
 2006-12-25 02:47:37 +00:00
Nick Mathewson
a71a5d4bf2 r11706@Kushana: nickm | 2006-12-24 01:50:52 -0500 
Fix 2 bugs in last patch.  (VS has weird ideas about const, and I have weird ideas about block structure.)


svn:r9186
 2006-12-24 06:50:57 +00:00
Nick Mathewson
bae366eff0 r11702@Kushana: nickm | 2006-12-24 01:31:59 -0500 
Patch from Edmanm, slightly modified.  Original change list:
   - Support running the Tor service with a torrc not in the
     same directory as tor.exe (Bug #356) and default to using the torrc
     located in the %appdata%\Tor\ of the user who installed the service
   - Removed the supposedly misleading error message mentioned in Bug #294
   - Fixed some CloseHandle()s that should've been CloseServiceHandle()s
   - Fixed some nt_service_foo() return values to be consistent
   - Resolved some nt_service_foo() DOCDOCs
   - Fixed one trivial typo that I happened to randomly notice
 
 Changes:
   - Make more comments into "imperative" house style.
   - Remove special handling for "-f"; only use --options.
   - Quote all options.
   - Clean up whitespace
 


svn:r9185
 2006-12-24 06:32:24 +00:00
Nick Mathewson
c12a1f1e3a r11701@Kushana: nickm | 2006-12-24 01:24:39 -0500 
fix warning on win32.


svn:r9184
 2006-12-24 06:32:20 +00:00
Nick Mathewson
2e538d9918 r11694@Kushana: nickm | 2006-12-23 23:09:20 -0500 
Add a version entry to networkstatus documents; have this entry get parsed and used to calculate whether begin_dir is supported.


svn:r9181
 2006-12-24 04:09:48 +00:00
Nick Mathewson
339384238c r11693@Kushana: nickm | 2006-12-23 22:42:11 -0500 
Stop requiring the "opt" keyword before unrecognized directory items.


svn:r9180
 2006-12-24 04:09:42 +00:00
Nick Mathewson
baac5389a1 r11690@Kushana: nickm | 2006-12-23 22:09:53 -0500 
Hmm. Maybe I should have been compiling these before I checked them in.


svn:r9178
 2006-12-24 03:09:58 +00:00
Nick Mathewson
d76b2a4ec0 r11688@Kushana: nickm | 2006-12-23 22:08:36 -0500 
Fix "r may be used uninitialized" warning from last patch.


svn:r9177
 2006-12-24 03:08:44 +00:00
Nick Mathewson
bf1014692f r11686@Kushana: nickm | 2006-12-23 22:05:57 -0500 
More changes wrt unnecessary disk writes.


svn:r9176
 2006-12-24 03:06:03 +00:00
Nick Mathewson
f3fd5d9032 r11680@Kushana: nickm | 2006-12-23 21:45:05 -0500 
Remove code to look for keys in their old locations: we havent stored them there since 0.0.7.2.


svn:r9175
 2006-12-24 02:45:53 +00:00
Nick Mathewson
bba5a3533f r11679@Kushana: nickm | 2006-12-23 21:38:41 -0500 
Update the state file less often when AvoidDiskWrites is set.


svn:r9174
 2006-12-24 02:45:46 +00:00
Nick Mathewson
9efdf6acc5 r11677@Kushana: nickm | 2006-12-23 21:17:54 -0500 
Track when we get 503s from directory servers.  Do not use directory servers that have given us a 503 until either an hour has passed, or we are are out of non-busy servers.


svn:r9172
 2006-12-24 02:45:35 +00:00
Nick Mathewson
4d948281c3 r11676@Kushana: nickm | 2006-12-23 20:42:17 -0500 
Add an orport option to dirserver lines so that clients can tell where to connect to open an encrypted tunnel to a dirserver even before they have its descriptor.


svn:r9171
 2006-12-24 02:45:27 +00:00
Roger Dingledine
488b4726a7 reinstate the most important dead chickens for limiting 
impact of directory writes now that we're write limiting.

a few more dead chickens remain.


svn:r9170
 2006-12-23 08:48:16 +00:00
Nick Mathewson
94d7d8d88f r11670@Kushana: nickm | 2006-12-21 12:23:55 -0500 
Clean up logic in parse_port_range(); accept 0 on low end and 65536 on high end for people who are bad at math.


svn:r9169
 2006-12-21 17:38:15 +00:00
Nick Mathewson
ca516311e3 r11668@Kushana: nickm | 2006-12-20 22:22:53 -0500 
Fix bug found by Keith Skinner: Treat malformed max-ports in address ranges as an error, and dont ignore errors with min-ports even if a max-port is present.


svn:r9168
 2006-12-21 03:22:59 +00:00
Nick Mathewson
bf74dcd855 r11658@Kushana: nickm | 2006-12-20 15:58:44 -0500 
Remove long-deprecated log and accounting options.


svn:r9164
 2006-12-20 21:02:10 +00:00
Nick Mathewson
2e1e919d65 r11657@Kushana: nickm | 2006-12-20 15:11:19 -0500 
Fixes to check-docs script; add some docs; mark some options as deprecated in the online docs.


svn:r9163
 2006-12-20 21:02:02 +00:00
Nick Mathewson
e9ad1650c0 r11651@Kushana: nickm | 2006-12-20 12:05:04 -0500 
Add a maintainer script and a new make target "make check-docs" to get a quick dump of which options are undocumented where, and which documentation refers to nonexistent options.


svn:r9160
 2006-12-20 17:05:48 +00:00
Roger Dingledine
00257212c7 Take out the '5 second' timeout from the connection retry 
schedule. Now the first connect attempt will wait a full 10
seconds before switching to a new circuit. Perhaps this will help
a lot. Based on observations from Mike Perry.


svn:r9159
 2006-12-20 09:43:28 +00:00
Roger Dingledine
858d7295e7 minor cleanups 
svn:r9158
 2006-12-20 09:25:58 +00:00
Nick Mathewson
baadf35c63 r11646@Kushana: nickm | 2006-12-19 14:40:38 -0500 
Resolve bug 363: do not fall back to 127.0.0.1 when no nameservers are configured.  Instead, have the admin fix resolv.conf or configure a nameserver.


svn:r9157
 2006-12-19 19:49:03 +00:00
Nick Mathewson
bf6702cf8b r11645@Kushana: nickm | 2006-12-19 14:22:36 -0500 
Reject hostnames with invalid characters, in an attempt to catch more errors earlier.  Add an option to disable this behavior.


svn:r9156
 2006-12-19 19:48:58 +00:00
Nick Mathewson
280692d65f r11643@Kushana: nickm | 2006-12-19 13:15:14 -0500 
Stop recommmending exits as guards when the exit bandwidth is less than a third of the total bandwidth.


svn:r9154
 2006-12-19 19:48:48 +00:00
Roger Dingledine
e66b6f0d50 Reject *:563 (NTTPS) in the default exit policy. We already reject 
NNTP by default, so this seems like a sensible addition.
(suggested by bug 331)


svn:r9149
 2006-12-18 08:25:34 +00:00
Roger Dingledine
ad5ce3c7ed fix whitespace; add a todo item 
svn:r9148
 2006-12-18 08:24:22 +00:00
Nick Mathewson
973baa1673 r11630@Kushana: nickm | 2006-12-17 22:02:24 -0500 
Add a typedef to (try to) make eventdns work on mingw.  Man, I need a buildbot for this.


svn:r9147
 2006-12-18 03:02:30 +00:00
Nick Mathewson
952b34d610 r11627@Kushana: nickm | 2006-12-17 11:37:39 -0500 
Remove an artificial upper bound on expected bandwidth.  More immediately, fix a VC warning.


svn:r9146
 2006-12-17 16:37:46 +00:00
Roger Dingledine
b3b75a3bef write-limiting fix: avoid a rare bug where we don't remember 
that there's stuff on the outbuf we want to flush.


svn:r9142
 2006-12-16 11:36:36 +00:00
Roger Dingledine
0cc7eaf302 remove some dead comments, and resolve some XXXs 
svn:r9141
 2006-12-16 11:34:12 +00:00
Roger Dingledine
f175aca3a8 and then revert half of r9138 
svn:r9140
 2006-12-16 07:04:26 +00:00
Nick Mathewson
80b8abf7be r11618@Kushana: nickm | 2006-12-16 02:00:52 -0500 
Make router_is_me work without calling router_rebuild_descriptor.


svn:r9139
 2006-12-16 07:00:59 +00:00
Roger Dingledine
9cd8feb649 fix an infinite loop and a memory leak in r9131 
svn:r9138
 2006-12-16 06:56:58 +00:00
Nick Mathewson
31e09bb524 r11614@Kushana: nickm | 2006-12-15 17:39:42 -0500 
Implement SETEVENTS GUARD.  Needs review and testing.


svn:r9137
 2006-12-15 22:40:20 +00:00
Nick Mathewson
251f007b75 r11609@Kushana: nickm | 2006-12-15 16:42:21 -0500 
Implement GETINFO fingerprint.


svn:r9136
 2006-12-15 21:51:24 +00:00
Roger Dingledine
ce51a1d349 a changelog for write limiting. also, disable the "advertise dirport 
until we reach our max bandwidth if it's tiny" trick now that we
do the bandwidth self-test on boot.


svn:r9134
 2006-12-15 21:39:35 +00:00
Nick Mathewson
f53a269928 r11598@Kushana: nickm | 2006-12-15 15:59:00 -0500 
Add internal documentation for a bunch of configuration options.  We should do something to keep this list, the canonical list, the tor.1 list, and the torrc.complete list in sync.


svn:r9133
 2006-12-15 21:27:19 +00:00
Nick Mathewson
078aab810b r11597@Kushana: nickm | 2006-12-15 15:49:27 -0500 
Add a rudimentary line-wrapping function for use in dumping comments in config files.


svn:r9132
 2006-12-15 21:26:23 +00:00
Nick Mathewson
ab2fc7bd62 r11596@Kushana: nickm | 2006-12-15 10:57:12 -0500 
Mark some TODO items as done.  Also, never include ourself in our family list.


svn:r9131
 2006-12-15 21:26:15 +00:00
Roger Dingledine
bdf470c263 turn TunnelDirConns on by default. 
that's what alpha releases are for, right?


svn:r9129
 2006-12-15 21:06:21 +00:00
Roger Dingledine
c4ed331d8d oh, and catch the other instance we should fix 
svn:r9122
 2006-12-15 08:14:32 +00:00
Roger Dingledine
0bc0688668 if we rotate our onion key, publish a new descriptor, and 
die soon after, we want to stick with that onion key when
we restart.


svn:r9121
 2006-12-15 07:58:31 +00:00
Nick Mathewson
38bd6837db r11588@Kushana: nickm | 2006-12-15 02:04:32 -0500 
Add a LastRotatedOnionKey variable to the state file, so we can rotate onion keys a week after they change even if we never stay up for a whole week at a time.  Should fix bug 368.


svn:r9120
 2006-12-15 07:04:37 +00:00
Roger Dingledine
2ae9615a0b take the broken obsolete url out again. 
seriously, this line should stay out.
how can we make this happen?


svn:r9119
 2006-12-15 06:22:52 +00:00
Nick Mathewson
62f711fcf3 r11585@Kushana: nickm | 2006-12-15 01:11:49 -0500 
Tabify eventdns so that it matches libevent house style.


svn:r9118
 2006-12-15 06:12:14 +00:00
Nick Mathewson
b16aa6412e r11584@Kushana: nickm | 2006-12-15 01:10:45 -0500 
Try to reconcile (except for whitespace) eventdns with version in libevent, so it is easier for me to send merges.  These changes should be cosmetic. (Ha!)


svn:r9117
 2006-12-15 06:12:01 +00:00
Nick Mathewson
309c579452 r11581@Kushana: nickm | 2006-12-15 00:12:24 -0500 
Make PIDFile work on windows.  Reported by Arrakis.


svn:r9116
 2006-12-15 05:12:52 +00:00
Nick Mathewson
fdb10ff0b5 r11580@Kushana: nickm | 2006-12-15 00:09:46 -0500 
Resolve bug 369: Check for integer underflow when printing "bytes left" accounting numbers.  Also fix a copyright date that I noticed while reading the bug.  Also make a buffer big enough that strings will not get truncated.  All are backport candidates.


svn:r9115
 2006-12-15 05:12:42 +00:00
Roger Dingledine
c44dd3870e clarify our use of local time vs GMT 
svn:r9109
 2006-12-14 23:39:14 +00:00
Roger Dingledine
30e4f4f6ce when we're doing a write split over the end of a circular 
buffer, make sure our tls_get_forced_write_size doesn't
make it write whatever's after the buffer.

this hasn't triggered yet, but it would be rare, so let's
leave it in.


svn:r9107
 2006-12-14 03:26:42 +00:00
Nick Mathewson
c9c8072bd3 r11569@Kushana: nickm | 2006-12-13 17:59:58 -0500 
fix last fix


svn:r9106
 2006-12-13 23:00:05 +00:00
Nick Mathewson
43e06eba8b r11566@Kushana: nickm | 2006-12-13 17:46:24 -0500 
Try to fix an assert failure in new write limiting code: make buffers.c aware of previous "forced" write sizes from tortls.


svn:r9105
 2006-12-13 22:46:42 +00:00
Roger Dingledine
5cce710e2b Some more documentation and specs for CONNECT_DIR and BEGIN_DIR. 
Demand that BEGIN_DIR cells have an empty payload.


svn:r9104
 2006-12-13 22:42:52 +00:00
Roger Dingledine
04409f202d reenable write limiting. nick finally convinced me this was 
a smart move.

more todo sub-items remain for it.


svn:r9101
 2006-12-13 07:08:36 +00:00
Roger Dingledine
97c83a4c09 finish enabling begin-dir cells. require one-hop circs for 
socks-command-connect-dir streams, so we don't open new anonymity
questions.


svn:r9099
 2006-12-13 02:49:45 +00:00
Roger Dingledine
0dbf725927 Infrastructure to test BEGIN_DIR cells. 
New socks command CONNECT_DIR. New config option TunnelDirConns that
builds a circ ending at the directory server and delivers a BEGIN_DIR
cell if it's running 0.1.2.2-alpha or later. We still need to make
one-hop circs when appropriate, while making other conns avoid them.


svn:r9098
 2006-12-13 00:28:56 +00:00
Roger Dingledine
f5164ba61d remove an XXXX that asked to get removed 
svn:r9097
 2006-12-13 00:05:28 +00:00
Roger Dingledine
477438e6c7 a better fix. puts r8446 to bed. 
svn:r9096
 2006-12-12 21:09:30 +00:00
Roger Dingledine
1efd377428 Fix a bug in 0.1.2.2-alpha that prevented clients from asking 
to resolve an address at a given exit node even when they ask for
it by name.


svn:r9095
 2006-12-12 20:23:17 +00:00
Roger Dingledine
7217f3ca47 couldn't handle leaving this typo in 
svn:r9094
 2006-12-12 20:20:48 +00:00
Roger Dingledine
ee144598c8 minor cleanups and notes 
svn:r9093
 2006-12-12 20:19:54 +00:00
Nick Mathewson
9fa707f5d3 r11552@Kushana: nickm | 2006-12-12 13:34:13 -0500 
fix a signed/unsigned comparison in eventdns.c


svn:r9092
 2006-12-12 18:34:22 +00:00
Nick Mathewson
a3a00df69d r11548@Kushana: nickm | 2006-12-12 00:44:51 -0500 
Merge whitespace and other changes from libevent


svn:r9090
 2006-12-12 05:45:19 +00:00
Nick Mathewson
494e45482a r11536@Kushana: nickm | 2006-12-11 22:48:21 -0500 
Add ipv6 functionality to evdns.


svn:r9089
 2006-12-12 03:48:46 +00:00
Nick Mathewson
35d92f8245 r11498@Kushana: nickm | 2006-12-11 21:40:24 -0500 
Document all structures and (non-exported) functions.  External documentation will probably wind up being a manpage, hopefully written by somebody else.


svn:r9087
 2006-12-12 02:57:02 +00:00
Nick Mathewson
097aec8e9d r11497@Kushana: nickm | 2006-12-11 21:17:45 -0500 
Rename nameserver functions: every one should now have "server" in the name.


svn:r9086
 2006-12-12 02:56:54 +00:00
Nick Mathewson
707429e9a3 r11496@Kushana: nickm | 2006-12-11 19:39:37 -0500 
Clean up XXXX comments in evdns code.  Make server_ports actually go away when their refcnt reaches zero.


svn:r9085
 2006-12-12 02:56:47 +00:00
Nick Mathewson
d22deb61d6 r11495@Kushana: nickm | 2006-12-11 19:11:14 -0500 
More evdns: tab fixes.  Dont make users worry about flags.  Set truncated flag correctly when generating responses, rather than just bailing out.


svn:r9084
 2006-12-12 02:56:41 +00:00
Nick Mathewson
abc1304aef r11494@Kushana: nickm | 2006-12-11 14:50:20 -0500 
Export DNS types and classes in eventdns.h so that server code can use them.


svn:r9083
 2006-12-12 02:56:35 +00:00
Nick Mathewson
fc125b1ef4 r11493@Kushana: nickm | 2006-12-11 14:28:42 -0500 
Oops; apparently DNS replies are supposed to include the questions.  Revise "add_ptr_reply" to accept an inaddr_arpa name instead of just the sockaddr_in. Also, add a "-servertest" function to the test code to see whether the DNS server logic is working.


svn:r9082
 2006-12-12 02:56:28 +00:00
Nick Mathewson
e53bca15e7 r11492@Kushana: nickm | 2006-12-11 12:30:23 -0500 
Implement dns server reply retry logic.


svn:r9081
 2006-12-12 02:56:23 +00:00
Nick Mathewson
c58d9494df r11491@Kushana: nickm | 2006-12-11 12:12:57 -0500 
More DNS server hacking: everything except testing, and retries, and documentation, and Tor integration.


svn:r9080
 2006-12-12 02:56:20 +00:00
Nick Mathewson
991308fac9 svn:r9079 2006-12-12 02:56:17 +00:00
Nick Mathewson
ff029a635d svn:r9077 2006-12-12 02:54:48 +00:00
Nick Mathewson
e190acf780 r9254@Kushana: nickm | 2006-10-17 17:23:36 -0400 
Implement dns label compression.  Clients do not need this much; dns servers definitely do.


svn:r9073
 2006-12-12 02:50:17 +00:00
Nick Mathewson
e9d67b1162 r9099@Kushana: nickm | 2006-10-05 17:42:55 -0400 
start fleshing out some logic to build server support into eventdns.  Still needs work and testing.


svn:r9068
 2006-12-12 02:49:45 +00:00
Roger Dingledine
8cf8b8087a when we decide not to mmap, because the file is empty or isn't 
there at all, don't yell so loud.


svn:r9065
 2006-12-11 04:21:10 +00:00
Roger Dingledine
ea93289590 fix another bug in r9052, pointed out by robert hogan 
svn:r9063
 2006-12-10 17:30:33 +00:00
Roger Dingledine
e206d22297 some more cleanups and a bugfix on r9052 
svn:r9062
 2006-12-10 08:04:50 +00:00
Roger Dingledine
733882315d resolve a buffer overflow / crash from r9051 
svn:r9061
 2006-12-10 04:50:33 +00:00
Roger Dingledine
f7319a0b6d correction and cleanups on r9047 
svn:r9060
 2006-12-09 19:40:16 +00:00
Roger Dingledine
29099a98c2 fix xiando's bug -- we were reporting stuff about hibernation 
even though it wasn't enabled.


svn:r9055
 2006-12-09 02:55:40 +00:00
Nick Mathewson
81be0ad1e5 r11486@Kushana: nickm | 2006-12-08 00:58:47 -0500 
Fix a longstanding bug in eventdns related to timeouts:  The timeout count was never actually reset to 0.  Argh.  Now we reset it to zero after we get a successful request, or after we notice that a nameserver is back up, or after we decide the nameserver is down because of timeouts.  This may fix bug 326.


svn:r9054
 2006-12-08 05:59:21 +00:00
Nick Mathewson
cf04e1e6e7 r11479@Kushana: nickm | 2006-12-07 23:38:54 -0500 
Refactor GETINFO into a table-driven dispatch, as suggested by arma.  My brain hurts.


svn:r9052
 2006-12-08 04:39:13 +00:00
Nick Mathewson
1567e13dc8 r11475@Kushana: nickm | 2006-12-07 20:49:21 -0500 
Make GETINFO dir/status/... work even when we are not a directory.  Needs a little cleanup.  Closes bug 263.


svn:r9051
 2006-12-08 01:50:02 +00:00
Roger Dingledine
566543a4f8 more changes on r9041 
svn:r9049
 2006-12-07 20:14:29 +00:00
Nick Mathewson
b4a90ca8a3 r11469@Kushana: nickm | 2006-12-07 15:11:04 -0500 
Round stored/transmitted values for bandwidth usage.  This might make some attacks work less well.  This might well be voodoo, but it gives me a warm fuzzy feeling.


svn:r9048
 2006-12-07 20:11:36 +00:00
Nick Mathewson
7c79495137 r11468@Kushana: nickm | 2006-12-07 14:56:57 -0500 
Revise logic used to flush state to disk. Now, we try to batch non-urgent changes so that we do not do too many writes, and we save very-non-urgent changes every once in a rare while, and we never save more than once per second.


svn:r9047
 2006-12-07 20:11:30 +00:00
Nick Mathewson
c304a10fd3 r11467@Kushana: nickm | 2006-12-07 14:38:54 -0500 
Whitespace cleanup


svn:r9046
 2006-12-07 20:11:24 +00:00
Nick Mathewson
6c8075d8a0 r11462@Kushana: nickm | 2006-12-07 13:42:21 -0500 
Make bandwidth accounting information get stored to the state file as well as bw_accounting.  Read from the state file if it is more recent than bw_accounting, or if bw_accounting is not there.


svn:r9044
 2006-12-07 18:57:37 +00:00
Nick Mathewson
63e4cfbeb6 r11461@Kushana: nickm | 2006-12-07 13:16:45 -0500 
Change logging format of state file to only include non-default values.  Adjust clients to never store bandwidth history in the state file. (Possible backport candidate.)


svn:r9043
 2006-12-07 18:57:29 +00:00
Nick Mathewson
26392fc75d r11458@Kushana: nickm | 2006-12-07 12:04:22 -0500 
Fix bug 338: log verbose nicknames, not just keys, for intro points.  Also, suppress intro point name logging when SafeLogging is 1. (The security part is a possible backport candidate.)


svn:r9041
 2006-12-07 17:04:44 +00:00
Nick Mathewson
8249f5d676 r11456@Kushana: nickm | 2006-12-07 10:09:55 -0500 
oops; removed one unmap too many in the tests.


svn:r9040
 2006-12-07 15:10:36 +00:00
Nick Mathewson
e6c467fe07 r11454@Kushana: nickm | 2006-12-07 10:07:24 -0500 
Apparently, we actually hit the nasty mmap-then-unlink behavior.  Fix it.


svn:r9039
 2006-12-07 15:07:33 +00:00
Nick Mathewson
97e5e78afd r11451@Kushana: nickm | 2006-12-07 10:06:30 -0500 
Apparently Windows takes a dim view of unlinking a file while it is mapped.  Silly windows, did nobody ever tell you about inodes?


svn:r9038
 2006-12-07 15:06:38 +00:00
Nick Mathewson
e8dc71ade4 r11444@Kushana: nickm | 2006-12-07 09:38:52 -0500 
Fix a couple of obvious bugs in tor_mmap_file on Windows: first, fix a boolean error when checking the return value of CreateFileMapping.  Second, CreateFileMapping is documented to return NULL on failure.


svn:r9035
 2006-12-07 14:39:42 +00:00
Roger Dingledine
44c55dad23 Fix an assert failure when the directory authority sets 
AuthDirRejectUnlisted and then receives a descriptor from an
unlisted router (reported by seeess).


svn:r9023
 2006-12-04 18:54:01 +00:00
Roger Dingledine
c9eb1c6d5c bump to 0.1.2.4-alpha-dev 
svn:r9022
 2006-12-04 18:11:31 +00:00
Nick Mathewson
a91c12f2e7 r9855@Kushana: nickm | 2006-12-04 00:55:09 -0500 
Merge circuit_about_to_close_connection and connection_about_to_close_connection.


svn:r9021
 2006-12-04 05:55:40 +00:00
Nick Mathewson
f90cd5bfc0 r9853@Kushana: nickm | 2006-12-04 00:02:03 -0500 
Patch from Fabian Keil: Fix return statement in get_pf_socket()


svn:r9020
 2006-12-04 05:09:09 +00:00
Roger Dingledine
936f075f11 help ftello find its prototype 
svn:r9016
 2006-12-02 23:08:55 +00:00
Roger Dingledine
c5b90daf86 cleanups, bump to 0.1.2.4-alpha 
svn:r9015
 2006-12-02 22:47:46 +00:00
Nick Mathewson
d1fdabf1c7 r9843@Kushana: nickm | 2006-11-30 17:22:25 -0500 
Turn an xxxx0124 into an #ifdef; avoid leaking memory.


svn:r9013
 2006-11-30 22:23:01 +00:00
Roger Dingledine
ab68e312bd actually, i think this fix was closest to what i originally 
intended. this way we don't call resolve-my-address, which
yells and screams if we're using an internal address (mere
clients should not have to care).


svn:r8998
 2006-11-26 20:01:45 +00:00
Nick Mathewson
116ae04c2d r9399@totoro: nickm | 2006-11-26 14:22:17 -0500 
Actually, clients *should* try to guess their addresses.


svn:r8997
 2006-11-26 19:22:25 +00:00
Nick Mathewson
68142b18cd r9396@totoro: nickm | 2006-11-26 13:36:29 -0500 
Fix router_new_address_suggestion() so it only changes last_guessed_ip() when it actually calls resolve_my_address(). (bug found by dev-girl)


svn:r8996
 2006-11-26 18:36:51 +00:00
Nick Mathewson
80cc941c2d r9395@totoro: nickm | 2006-11-26 13:34:12 -0500 
Change vc++ orconfig.h: add definition for SIZEOF_SIZE_T.


svn:r8995
 2006-11-26 18:36:46 +00:00
Nick Mathewson
facc49cf6f r9371@totoro: nickm | 2006-11-21 10:59:28 -0500 
Fix a trivial comment.


svn:r8979
 2006-11-21 23:50:21 +00:00
Roger Dingledine
69ae0a2986 we were leaking all the fingerprints for !reject, !invalid, 
and !badexit lines in the approved-routers file.


svn:r8974
 2006-11-20 16:36:44 +00:00
Nick Mathewson
b1dc014fc6 r9347@totoro: nickm | 2006-11-20 11:24:46 -0500 
11:23 < armadev> typo
 11:23 < nickm> ?
 11:23 < armadev> did you get the coffee yet? :)
 11:23 < nickm> no
 11:23 < armadev> i'm at an advantage..i haven't slept yet


svn:r8972
 2006-11-20 16:26:52 +00:00
Nick Mathewson
b4ea6136a4 r9345@totoro: nickm | 2006-11-20 11:22:10 -0500 
Fix a small and unlikely memory leak in dirserv.c. I think this is not the one arma is looking for.


svn:r8971
 2006-11-20 16:22:46 +00:00
Nick Mathewson
aef64c1277 r9577@Kushana: nickm | 2006-11-20 11:07:28 -0500 
Oops; fix bug in last fix. Time to get some coffee.


svn:r8970
 2006-11-20 16:07:33 +00:00
Nick Mathewson
a667f2e514 r9567@Kushana: nickm | 2006-11-20 11:05:59 -0500 
Fix leak in choose_good_exit_server_general()


svn:r8969
 2006-11-20 16:06:09 +00:00
Nick Mathewson
e2abc727e5 r9561@Kushana: nickm | 2006-11-16 22:32:54 -0500 
Tweaks to test-connection patch:  use ".noconnect" instead of ".test" (since there are lots of ways to test things).  Use a regular sequence of STREAM events (NEW followed by CLOSED) instead of a new event type.  Make the function that checks the address be static and use const and strcasecmpend properly.
 


svn:r8959
 2006-11-17 03:34:58 +00:00
Nick Mathewson
d125c61e02 r9560@Kushana: nickm | 2006-11-16 22:09:12 -0500 
Check in an implementation of "test" connections from Scott Squires:
 these connections immediately close upon reaching Tor.  They're useful
 for apps that want to check whether they're talking to the same Tor as
 a given controller.  (I'll be tweaking this a bit before I push.)
 


svn:r8958
 2006-11-17 03:34:44 +00:00
Nick Mathewson
b052b810e2 r9319@totoro: nickm | 2006-11-14 13:04:50 -0500 
Patch from Zajcev Evgeny to make natd work properly (we needed to allow extra characters after the port number).


svn:r8952
 2006-11-14 18:05:01 +00:00
Nick Mathewson
ad1f019110 r9317@totoro: nickm | 2006-11-13 22:45:33 -0500 
Fix some more mipspro warnings.  Nothing should remain excecpt "conversion from pointer to same-sized integral type."


svn:r8950
 2006-11-14 03:45:48 +00:00
Nick Mathewson
d6cc235eba r9315@totoro: nickm | 2006-11-13 22:40:59 -0500 
Fix a build warning on angela-sid


svn:r8949
 2006-11-14 03:41:05 +00:00
Nick Mathewson
9243e54177 r9313@totoro: nickm | 2006-11-13 20:07:41 -0500 
Try to compile with fewer warnings on irix64's MIPSpro compiler /
 environment, which apparently believes that:
   - off_t can be bigger than size_t.
   - only mean kids assign things they do not subsequently inspect.
 
 I don't try to fix the "error" that makes it say:
 
 cc-3970 cc: WARNING File = main.c, Line = 1277
   conversion from pointer to same-sized integral type (potential portability
           problem)
 
     uintptr_t sig = (uintptr_t)arg;
 
 Because really, what can you do about a compiler that claims to be c99
 but doesn't understand that void* x = NULL; uintptr_t y = (uintptr_t) x;
 is safe?
 


svn:r8948
 2006-11-14 01:07:52 +00:00
Nick Mathewson
0f6402f17b r9309@totoro: nickm | 2006-11-13 19:05:41 -0500 
Whitespace fixes, and clean up code from last natd patch.


svn:r8947
 2006-11-14 00:06:45 +00:00
Nick Mathewson
1913cb915e r9308@totoro: nickm | 2006-11-13 18:41:23 -0500 
Add support for (Free?)BSD's natd, which was an old way to let you
 have your firewall automatically redirect traffic.  (Original patch
 from Zajcev Evgeny, updated for 0.1.2.x by tup.)
 


svn:r8946
 2006-11-14 00:06:31 +00:00
Nick Mathewson
fa6fbbc150 r9307@totoro: nickm | 2006-11-13 18:25:56 -0500 
Patch from tup based on patch from Zajcev Evgeny: Make TransPort work even when the server wants to talk before the client.


svn:r8945
 2006-11-14 00:06:02 +00:00
Roger Dingledine
3d6b97399f Avoid assert failure when our cached-routers file is empty on startup. 
(reported by revstray)


svn:r8928
 2006-11-12 07:09:22 +00:00
Nick Mathewson
0ad2fd1129 r9467@Kushana: nickm | 2006-11-01 18:51:16 -0500 
Allow larger amounts of drift in uptime to be "cosmetic".


svn:r8891
 2006-11-01 23:53:15 +00:00
Nick Mathewson
5d7ca19b44 r9465@auth3-479: nickm | 2006-11-01 13:16:21 -0500 
Add some temporary code to count  how many *distinct* router digests we verify.  (I have a sneaking suspicion that the numbers look way way high.)


svn:r8890
 2006-11-01 18:16:44 +00:00
Peter Palfrader
c195b8f806 r10475@danube: weasel | 2006-11-01 14:33:35 +0100 
Fix copy/paste error


svn:r8889
 2006-11-01 13:33:49 +00:00
Nick Mathewson
31e274ddd3 r9461@Kushana: nickm | 2006-10-31 20:30:12 -0500 
Oops. Fix compile error in last build.


svn:r8888
 2006-11-01 01:30:25 +00:00
Nick Mathewson
9e13a6f31c r9457@Kushana: nickm | 2006-10-31 18:35:17 -0500 
Do not warn when an OR gives us a new circuit end reason. (This will prevent bug 351 from recurring.)


svn:r8887
 2006-10-31 23:35:50 +00:00
Nick Mathewson
1bf1f9d2fc r9449@Kushana: nickm | 2006-10-31 00:12:02 -0500 
Dump breakdown of PK operations when we get a USR2 signal.  This should help us figure out of we are doing some of them for stupid reasons.


svn:r8881
 2006-10-31 19:17:07 +00:00
Roger Dingledine
a5f402e245 and then bump to 0.1.2.3-alpha-dev 
svn:r8863
 2006-10-30 03:29:33 +00:00
Roger Dingledine
bc6eadd20e clean changelog, bump to 0.1.2.3-alpha 
svn:r8860
 2006-10-30 02:55:17 +00:00
Roger Dingledine
8a781f7f34 general cleanups from looking through or-cvs 
svn:r8855
 2006-10-29 07:41:25 +00:00
Roger Dingledine
8f7940348f Avoid an infinite loop on evil controlport input. Fixes bug 350, 
unless it doesn't. (Nick, please confirm.)

Backport candidate.


svn:r8844
 2006-10-28 08:17:02 +00:00
Roger Dingledine
e473ca2427 give a nicer warning message when windows people try to 
configure syslog in their torrc


svn:r8841
 2006-10-27 19:35:12 +00:00
Nick Mathewson
5b72dc77ad r9395@Kushana: nickm | 2006-10-26 22:06:51 -0400 
Fix Bug 349: Have GETINFO network-status return even old routers, and use long nicknames where appropriate.  Document this.


svn:r8834
 2006-10-27 02:07:04 +00:00
Nick Mathewson
3fbb292bff r9389@Kushana: nickm | 2006-10-25 17:46:16 -0400 
Add a CLEARDNSCACHE signal to clear the client-side DNS cache.


svn:r8829
 2006-10-25 21:46:21 +00:00
Nick Mathewson
5c670a186c r9386@Kushana: nickm | 2006-10-25 17:35:38 -0400 
Resolve bug 347: translate v0 controller signal numbers into internal signal numbers; leave v1 signal numbers alone.


svn:r8828
 2006-10-25 21:39:42 +00:00
Nick Mathewson
50771a6b48 r9380@Kushana: nickm | 2006-10-24 21:25:07 -0400 
Add string.h include to compat.h so that strlcpy() and strlcat() will always be defined after including compat.h.  This should resolve warnings on centos.


svn:r8824
 2006-10-25 01:25:17 +00:00
Nick Mathewson
4df90e455c r9164@totoro: nickm | 2006-10-24 17:50:43 -0400 
Oops: 17:50 < armadev> today is opposite day?


svn:r8822
 2006-10-24 21:51:06 +00:00
Nick Mathewson
6b7d1c94da r9162@totoro: nickm | 2006-10-24 17:41:35 -0400 
Make "boolean !=" logic more obvious.


svn:r8821
 2006-10-24 21:41:48 +00:00
Nick Mathewson
a5bf6df14a r9160@totoro: nickm | 2006-10-24 17:38:07 -0400 
More dirserver oops: actually set the digest for a given name in the case when the name is not yet recognized.


svn:r8820
 2006-10-24 21:38:31 +00:00
Nick Mathewson
ba1b04c736 r9158@totoro: nickm | 2006-10-24 16:50:18 -0400 
Oops on last authority patch: handle routers with unrecognized fingerprints correctly


svn:r8819
 2006-10-24 20:51:28 +00:00
Roger Dingledine
6877a7e1ee and update the pile of getinfo strings that's impossible to remember 
to update


svn:r8813
 2006-10-24 04:55:02 +00:00
Nick Mathewson
6c7bf2f830 r9364@Kushana: nickm | 2006-10-23 22:57:48 -0400 
Remove reference to NS_FULL event; add two GETINFO targets.


svn:r8812
 2006-10-24 02:58:03 +00:00
Roger Dingledine
6ecf74af60 and blow away what appears to be some redundant logic 
svn:r8806
 2006-10-23 10:17:52 +00:00
Roger Dingledine
77c8c0ee51 spec and implement some more status events. start to build 
some conventions.


svn:r8805
 2006-10-23 10:16:43 +00:00
Roger Dingledine
2a1c294717 implement a few status events, so we can make sure they work, 
and so vidalia can start handling them if it wants.


svn:r8802
 2006-10-23 05:51:46 +00:00
Roger Dingledine
c804eea39d build on 64-bit again 
svn:r8801
 2006-10-23 05:36:56 +00:00
Roger Dingledine
d48828dbe1 good thing we didn't have to track this bug down the old-fashioned way 
svn:r8800
 2006-10-23 05:29:40 +00:00
Nick Mathewson
4401c47f63 r9347@Kushana: nickm | 2006-10-23 01:24:48 -0400 
Implement status event backend logic.


svn:r8799
 2006-10-23 05:24:57 +00:00
Nick Mathewson
27a3f0da2b r9320@Kushana: nickm | 2006-10-22 15:56:27 -0400 
fix unittests; add more tests for smartlist stuff; make tests cache generated RSA keys (to speed up unittest run time by 30% and encourage people to run them more).


svn:r8796
 2006-10-23 03:48:58 +00:00
Nick Mathewson
ed69c10b3f r9319@Kushana: nickm | 2006-10-22 15:25:18 -0400 
oops; include or.h changes for last patch.


svn:r8795
 2006-10-23 03:48:52 +00:00
Nick Mathewson
42bab1c6d3 r9318@Kushana: nickm | 2006-10-22 15:22:57 -0400 
Let directory authorities set the BadExit flag if they like.  Also, refactor directory authority code so we can believe multiple things about a single router, and do fewer linear searches.


svn:r8794
 2006-10-23 03:48:42 +00:00
Roger Dingledine
07cfeb0198 fix a minor memory leak every time we rebuild the router store, 
fix a rare memory leak if something goes wrong while rebuilding it,
and clean up some code. nick, please confirm.

reported by "fookoowa" in flyspray 346 (yay!)


svn:r8789
 2006-10-22 08:08:10 +00:00
Roger Dingledine
0f33a548c2 fix a string, pointed out by matt edman. 
also fix a bug next to it that i noticed.


svn:r8784
 2006-10-21 02:51:35 +00:00
Roger Dingledine
a0ec758f9e stop writing arbitrary memory out on the controller port. 
it's an ugly patch, but at least this way we can see that
it's fixed. maybe clean up the whole "@" syntax later on.


svn:r8783
 2006-10-20 23:23:19 +00:00
Nick Mathewson
c9a01dea53 r9313@Kushana: nickm | 2006-10-20 17:04:11 -0400 
Oops. Conform to spec.


svn:r8782
 2006-10-20 21:04:44 +00:00
Nick Mathewson
01bc03eff4 r9312@Kushana: nickm | 2006-10-20 14:45:22 -0400 
Add an event type to tell the controller when our opinion of a router status has changed.  I might have missed some cases here.


svn:r8781
 2006-10-20 21:04:39 +00:00
Roger Dingledine
0459db2c0d checkpoint some changes as i read diffs 
svn:r8780
 2006-10-20 19:11:12 +00:00
Nick Mathewson
b27cb38dee r9307@Kushana: nickm | 2006-10-20 13:53:54 -0400 
Have connection_about_to_close use an end_reason field in edge_connection_t to tell what reason to tell the controller for closing the stream.  Set end_reason in connection_edge_end, connection_mark_unattached_ap, and everwhere we set edge_has_sent_end.  Add a changelog entry.


svn:r8779
 2006-10-20 17:54:48 +00:00
Nick Mathewson
8e94097edb r9306@Kushana: nickm | 2006-10-20 13:27:43 -0400 
Enable reasons for stream events in all cases but CLOSED in about_to_close_connection.  That one will take a little longer.


svn:r8778
 2006-10-20 17:54:43 +00:00
Nick Mathewson
12af87539b r9303@Kushana: nickm | 2006-10-20 12:07:34 -0400 
Start implementing reason extension for stream events to match the one one used by circuit events. (Not a complete implementation yet; actual reasons are not passed to control.c)


svn:r8777
 2006-10-20 17:54:36 +00:00
Nick Mathewson
c8c36dd227 r9304@dhcp-18-188-67-85: nickm | 2006-10-20 12:22:46 -0400 
Change HT_INIT from a special-case to a macro-calling-a-function like the rest of ht.h.  This might prevent errors if somebody did, I dunno, "HT_INIT(tp, hashtable++)". Based on a patch from Watson Ladd.


svn:r8776
 2006-10-20 16:22:53 +00:00
Nick Mathewson
2d7cf75e42 r9298@dhcp-18-188-67-85: nickm | 2006-10-20 11:25:07 -0400 
Weasel correctly notes that we should not discard the return value from connection_exit_begin_con.  Right now, the return value is always discardable, so this does not actually cause a bug, but it might later. So fix it.


svn:r8774
 2006-10-20 15:26:02 +00:00
Nick Mathewson
e5f064c983 r9290@31-35-219: nickm | 2006-10-20 10:32:33 -0400 
Add a GETINFO target so controllers can ask Tor for the current state of a router.  (Results given in networkstatus format.)


svn:r8772
 2006-10-20 14:58:29 +00:00
Nick Mathewson
136ed33071 r9289@31-35-219: nickm | 2006-10-20 09:43:22 -0400 
Fix longstanding bug in connection_exit_begin_conn():  Since connection_edge_end() exits when the connection is unattached, we were never sending RELAY_END cells back for failed RELAY_BEGIN attempts. Fix this.  This might make clients that were otherwise timing out either fail faster or retry faster, which is good news for us.


svn:r8770
 2006-10-20 14:57:46 +00:00
Roger Dingledine
dcd33ef599 i saw somebody on #tor paste a string where these were 
null. better safe than sorry.


svn:r8767
 2006-10-20 00:12:02 +00:00
Nick Mathewson
7f8d9e8af2 r9287@Kushana: nickm | 2006-10-19 19:28:31 -0400 
Weasel points out that a routerdesc requested by digest can never change.  Weasel is right.


svn:r8766
 2006-10-19 23:28:38 +00:00
Nick Mathewson
974bdee183 r9277@Kushana: nickm | 2006-10-19 19:03:05 -0400 
Add pragma:no-cache and expires headers so that directory lookups can work better in the presence of caching HTTP proxies. (I would have used Cache-Control, but that is an HTTP/1.1 thing.)  All timeouts are currently wild-assed guesses.


svn:r8765
 2006-10-19 23:05:34 +00:00
Nick Mathewson
f47c49228d r9276@Kushana: nickm | 2006-10-19 17:08:15 -0400 
Add some more unit tests for policies.


svn:r8764
 2006-10-19 23:05:25 +00:00
Nick Mathewson
96caedecc7 r9275@Kushana: nickm | 2006-10-19 16:45:19 -0400 
Split smartlist tests into their own function, and add a couple more.  Re-enable strmap iteration tests.  Remove tests for code that doesnt exist any more (parse_nickname_list, identity ciphers).


svn:r8763
 2006-10-19 23:05:19 +00:00
Nick Mathewson
7551c44a53 r9274@Kushana: nickm | 2006-10-19 16:16:58 -0400 
Add unit tests for tor_mmap_file(); make tor_mmap_t.size always be the size of the file (not the size of the mapping); add an extra argument to read_file_to_str() so it can return the size of the result string.


svn:r8762
 2006-10-19 23:05:02 +00:00
Nick Mathewson
126a3f699a r9273@Kushana: nickm | 2006-10-19 15:43:39 -0400 
Never discard a descriptor for being too old until either it is recommended by no authorities, or until we download a better (more recent and recommended) one for the same router. This will eventually make it possible for servers to publish less often.


svn:r8761
 2006-10-19 23:04:56 +00:00
Nick Mathewson
bfdb93d8bd r9272@Kushana: nickm | 2006-10-19 12:52:37 -0400 
Fix an XXX in handling destroy cells: when we get a destroy cell with reason FOO, do not tell the controller REASON=FOO.  Instead, say REASON=DESTROYED REMOTE_REASON=FOO. Suggested by a conversation with Mike Perry.


svn:r8760
 2006-10-19 23:04:49 +00:00
Nick Mathewson
4443934702 r9091@totoro: nickm | 2006-10-19 11:45:28 -0400 
Change to BadExit logic: Let authorities set an "I list bad exits" flag.  Consider an exit bad if it is listed as bad by more than half of *those* authorities.  This gives us a better migration path.


svn:r8756
 2006-10-19 15:45:48 +00:00
Nick Mathewson
df40c2e1ca r9080@totoro: nickm | 2006-10-19 11:00:16 -0400 
Oops, forgot the patch: Use corect macro to detect cygwin builds (patch from Pei Hanru)


svn:r8754
 2006-10-19 15:02:02 +00:00
Nick Mathewson
3c459a7397 r9077@totoro: nickm | 2006-10-18 11:41:16 -0400 
Another patch from Mike Perry; sprintfing a NULL pointer. (with comment).


svn:r8747
 2006-10-18 15:41:46 +00:00
Nick Mathewson
efbe87cb6c r9062@totoro: nickm | 2006-10-17 11:19:43 -0400 
Fix -Wlots with command.c (a uchar is never -1).  Note also that one of our ifs is very stupid.


svn:r8741
 2006-10-17 15:20:20 +00:00
Nick Mathewson
faf7445255 r9061@totoro: nickm | 2006-10-17 11:18:28 -0400 
Oops. Libevent 1.2 exists.  Add it to our enum, even though we dont care yet.


svn:r8740
 2006-10-17 15:20:15 +00:00
Nick Mathewson
b713b370bf r9060@totoro: nickm | 2006-10-17 11:12:48 -0400 
Apply patch from Mike Perry: add more reasons for circuit destroys. (Slightly tweaked to avoid allocating a number for an "internal" reason.)


svn:r8739
 2006-10-17 15:20:00 +00:00
Roger Dingledine
7d33c4b904 clean up and downgrade some log messages 
svn:r8727
 2006-10-15 07:42:51 +00:00
Roger Dingledine
584d598e8a move the 'time jump' warning back to a higher threshold. 
this still occurs on moria sometimes if it's swapping to death.
so be it.


svn:r8725
 2006-10-15 02:32:16 +00:00
Nick Mathewson
45b16c2d9e r9021@totoro: nickm | 2006-10-13 01:42:45 -0400 
Fix for last patch. "", though empty, is true.  This ain't Python, Nick.


svn:r8701
 2006-10-13 05:42:57 +00:00
Nick Mathewson
d453fd3709 r9019@totoro: nickm | 2006-10-13 01:32:34 -0400 
Fix extraneous space in CIRC events when path is empty.


svn:r8700
 2006-10-13 05:36:00 +00:00
Nick Mathewson
78043b8478 r9017@totoro: nickm | 2006-10-13 01:27:33 -0400 
Second patch to work on circuit close reasons from Mike Perry.  Disabled partially; see comment.  Whitespace cleaned up.


svn:r8699
 2006-10-13 05:27:59 +00:00
Nick Mathewson
eca28f24f5 r9004@totoro: nickm | 2006-10-11 18:05:24 -0400 
Add client support for a 'BadExit' flag, so authorities can say "Server X is a poor choise for your nytimes.com connections, as it seems to direct them to HoorayForMao.com or (more likely) WouldYouLikeToBuyTheseFineEncyclopedias.com"
 


svn:r8690
 2006-10-11 22:06:01 +00:00
Nick Mathewson
97e17d817b r8985@totoro: nickm | 2006-10-10 19:39:57 -0400 
Fix a signed/unsigned compare in eventdns.c


svn:r8685
 2006-10-10 23:46:33 +00:00
Roger Dingledine
552d828def - Stop triggering asserts if the controller tries to extend hidden 
service circuits.
(also found by mwenge)


svn:r8682
 2006-10-09 22:26:21 +00:00
Roger Dingledine
655859f76b When reporting verbose nicknames in entry_guards_getinfo(), avoid 
printing a duplicate "$" in the keys we send. (Reported by mwenge)


svn:r8681
 2006-10-09 21:26:34 +00:00
Roger Dingledine
86263acf95 Security bugfixes: 
When the user sends a NEWNYM signal, clear the client-side DNS
  cache too. Otherwise we continue to act on previous information.


svn:r8679
 2006-10-09 21:11:50 +00:00
Roger Dingledine
81dd9720f2 whitespace tweaks 
svn:r8677
 2006-10-09 20:54:51 +00:00
Nick Mathewson
69e0843f7c r8983@totoro: nickm | 2006-10-09 14:19:18 -0400 
Add missing ! to code to generate short/verbose nicknames for orconn events.


svn:r8674
 2006-10-09 18:19:32 +00:00
Nick Mathewson
26283e69ba r8973@totoro: nickm | 2006-10-09 11:45:47 -0400 
Touch up last patch (to add REASON to CIRC events): make some reasons
 more sensible, send reasons only to controllers that have enabled
 extended events, and clean up whitespace.
 
 


svn:r8672
 2006-10-09 15:47:50 +00:00
Nick Mathewson
b76fd968b4 r8972@totoro: nickm | 2006-10-09 10:36:22 -0400 
Patch from Mike Perry: add a REASON field to closed and failed circ events.


svn:r8671
 2006-10-09 15:47:27 +00:00
Nick Mathewson
17abfa6a6a r8971@totoro: nickm | 2006-10-09 10:16:23 -0400 
Move definition of ssize_t to torint.h


svn:r8670
 2006-10-09 15:47:08 +00:00
Nick Mathewson
829bf4dcd0 r8970@totoro: nickm | 2006-10-09 10:12:53 -0400 
Win32 patch from Matt Edman: fix compilation bugs by casting to int; defining SSIZE_T; defining USE_TWOS_COMPLEMENT in windows orconfig.h; and using the proper names for win32 functions on GetProcAddress. Also fixes bug 295.


svn:r8669
 2006-10-09 15:46:21 +00:00
Roger Dingledine
c639fd8258 was this one we missed? 
svn:r8666
 2006-10-09 06:22:31 +00:00
Nick Mathewson
e618c15aff r8967@totoro: nickm | 2006-10-08 23:38:50 -0400 
Fix some test and warn failures in last commit


svn:r8665
 2006-10-09 03:39:06 +00:00
Nick Mathewson
c6f2d725d0 r8957@totoro: nickm | 2006-10-08 22:35:17 -0400 
The otherwise regrettable MIPSpro C compiler warns about values set but never used, and about mixing enums and ints; these are good warnings, and so should be fixed.  This removes some dead code and some potential bugs. Thanks to pnx.


svn:r8664
 2006-10-09 02:35:51 +00:00
Nick Mathewson
c341255034 r8956@totoro: nickm | 2006-10-08 22:25:27 -0400 
Fix bug with handling EVENT_NEW_DESC with verbose nicknames enabled.  Also, check for tor_vsnprintf failure in controller messages.


svn:r8663
 2006-10-09 02:35:43 +00:00
Roger Dingledine
604b13c910 remove some old debugging code 
svn:r8657
 2006-10-08 23:20:43 +00:00
Nick Mathewson
d1c8fd9759 r8947@totoro: nickm | 2006-10-08 17:04:30 -0400 
Fix signed/unsigned compare warning in eventdns.c


svn:r8654
 2006-10-08 21:05:06 +00:00
Andrew Lewman
5227531744 Remove spurious void which causes builds to fail in mingw. 
svn:r8650
 2006-10-08 18:44:02 +00:00
Andrew Lewman
563be121c2 Add missing return so this builds on mingw. 
svn:r8649
 2006-10-08 18:24:31 +00:00
Roger Dingledine
f0d7a6716f In the hidden service example in torrc.sample, stop recommending 
esoteric and discouraged hidden service options.


svn:r8648
 2006-10-08 07:45:16 +00:00
Roger Dingledine
538c54e376 try dirport reachability testing five times less often. 
it's already so darn thorough per test -- it chews through
like four circuits before giving up.


svn:r8646
 2006-10-08 06:33:02 +00:00
Nick Mathewson
ea00437f74 r8933@totoro: nickm | 2006-10-07 20:33:16 -0400 
whitespace fixes; add changelog for last commit.


svn:r8644
 2006-10-08 00:33:43 +00:00
Nick Mathewson
1c01797c16 r8932@totoro: nickm | 2006-10-07 20:29:03 -0400 
Try to make mingw capable of producing a working tor binary for win98: make all NT-service-related functions get lazy-loaded on demand.  I have no idea if this even compiles.


svn:r8643
 2006-10-08 00:33:35 +00:00
Nick Mathewson
e230fe8ea6 r8926@totoro: nickm | 2006-10-07 15:56:14 -0400 
refactor circuit_list_path and circuit_list_path_verbose into a common _impl function.


svn:r8642
 2006-10-07 19:56:49 +00:00
Roger Dingledine
f787051e85 bump to 0.1.2.2-alpha-dev. time to go wild again. 
svn:r8639
 2006-10-07 19:38:21 +00:00
Nick Mathewson
f07f7a7a12 r8923@totoro: nickm | 2006-10-07 11:44:33 -0400 
More doxygen comments


svn:r8637
 2006-10-07 16:25:28 +00:00
Roger Dingledine
b45c210012 Bump to 0.1.2.2-alpha. Not tagged yet, so somebody can find a 
compile bug on an obscure platform while i'm asleep.


svn:r8634
 2006-10-07 09:30:12 +00:00
Roger Dingledine
9fb98b269c finish poking and prodding. i'm all happy now. 
svn:r8633
 2006-10-07 09:13:30 +00:00
Roger Dingledine
f2bd0e2f16 more minor cleanups 
svn:r8630
 2006-10-07 06:28:50 +00:00
Roger Dingledine
4f3827f1d1 resolve the entryguard uptime/capacity question. and mark a 
new xxx that we'll want to address one day.


svn:r8628
 2006-10-07 02:55:44 +00:00
Roger Dingledine
881d23847a fix something that looked scary to me. i believe this won't 
change any behavior currently, but it will avoiding calling
noop code that might change for the worse some time.

nick, please confirm.


svn:r8623
 2006-10-07 00:52:23 +00:00
Roger Dingledine
06e5b2283c minor cleanups 
svn:r8622
 2006-10-07 00:50:39 +00:00
Roger Dingledine
1cf37f90c4 bugfix and cleanups re: entry guards. 
svn:r8620
 2006-10-06 23:37:07 +00:00
Roger Dingledine
864069f5c7 fix a size_t-to-len compile warning 
svn:r8618
 2006-10-06 22:37:10 +00:00
Roger Dingledine
1d4bd3990f fetch all the v1 directory stuff way less often. plus, move 
around some housecleaning calls so they still occur often.
are some of these redundant or in the wrong order? there are
so many of them, maybe they should be put into a separate
function that has better documentation.


svn:r8607
 2006-10-06 09:04:11 +00:00
Roger Dingledine
d1b9de222e cleanups, closer to a changelog 
svn:r8606
 2006-10-06 07:50:57 +00:00
Roger Dingledine
b6e590a1a5 reapply a patch from adam langley that got clobbered when 
nick merged something back in


svn:r8605
 2006-10-06 06:46:08 +00:00
Roger Dingledine
baf208d7b3 bugfix: When testing reachability of our dirport, don't launch a new 
test if there's already one in progress.


svn:r8604
 2006-10-06 04:02:27 +00:00
Nick Mathewson
c15dc2d94c r9101@Kushana: nickm | 2006-10-05 23:05:11 -0400 
Trivial fix for solaris build.  Libevent will want to use its own fix here, and probably already has.


svn:r8601
 2006-10-06 03:05:19 +00:00
Nick Mathewson
4767d533f7 r9097@Kushana: nickm | 2006-10-05 14:51:57 -0400 
Make eventdns.c formatting a little closer to evdns.c in libevent; add some bulletproofing to APPEND16 macro; clean some messages.


svn:r8600
 2006-10-05 19:22:26 +00:00
Roger Dingledine
64b5fd3194 checkpoint some cleanups 
svn:r8599
 2006-10-05 08:23:21 +00:00
Nick Mathewson
5391ceb21a r9087@Kushana: nickm | 2006-10-04 01:19:15 -0400 
We're trying to catch the kind of jerk who'd hijack zy6pzwohtnlq.test,
 not the kind of lunatic who'd hijack zy6pzwohtnlq%s.test, though
 apparently those exist too.
 


svn:r8595
 2006-10-04 05:19:40 +00:00
Nick Mathewson
50320ac420 r8862@totoro: nickm | 2006-10-03 14:54:14 -0400 
Make verbose names get used (when appropriate and selected) in responses to getinfo requests.


svn:r8593
 2006-10-03 19:00:18 +00:00
Nick Mathewson
4c10464e13 r8861@totoro: nickm | 2006-10-03 14:49:54 -0400 
Fix bug in r8579: TrackHostExits .foo.bar implies TrackHostExits foo.bar; also fix logic error.


svn:r8592
 2006-10-03 19:00:12 +00:00
Nick Mathewson
29fa9eb216 r8860@totoro: nickm | 2006-10-03 14:48:33 -0400 
Use ANSI-style definition syntax in strlcat.c and strlcpy.c so that gcc stops barfing with -Wold-style-definition


svn:r8591
 2006-10-03 19:00:07 +00:00
Nick Mathewson
1ae7282d9b r8857@totoro: nickm | 2006-10-03 13:54:21 -0400 
Implement ORCONN with verbose names.


svn:r8588
 2006-10-03 18:59:52 +00:00
Nick Mathewson
55bd42d50f r8841@totoro: nickm | 2006-10-02 15:59:21 -0400 
Add EXTENDED_EVENTS to the USEFEATURE command; move flag from connection_t into control_conn, since we will probably grow more of these.


svn:r8585
 2006-10-03 18:58:56 +00:00
Nick Mathewson
c796adc7df r8840@totoro: nickm | 2006-10-02 15:56:16 -0400 
Add USEFEATURE to control changes to control protocol.  Use like __future__ directive from Python.  Will spec before pushing changes. No, really. :)


svn:r8584
 2006-10-03 18:58:52 +00:00
Nick Mathewson
eb0f51f2a3 r8839@totoro: nickm | 2006-10-02 15:31:49 -0400 
Make a field longer to accomodate verbose nicknames; note that verbose nicknames will never reach this point.


svn:r8583
 2006-10-03 18:58:47 +00:00
Nick Mathewson
6e0b90a902 r8838@totoro: nickm | 2006-10-02 15:24:39 -0400 
Partial implementation of revised nickname syntax for controllers.  Implement ability to look up routers by "verbose" nicknames; add a per-v1-control-connection flag to turn the feature on in events.  Needs testing, spec, ability to actually turn on the flag, double-checking that we wont overflow any nickname buffers, and changelog.


svn:r8582
 2006-10-03 18:58:40 +00:00
Roger Dingledine
246fecb585 the other half of the is_local_IP patch 
svn:r8581
 2006-10-03 05:45:58 +00:00
Nick Mathewson
4c56ac93ca r8851@totoro: nickm | 2006-10-02 18:13:27 -0400 
Remove/clarify some XXXs for no longer being accurate; for begin things we do not indend to fix; for already being parts of big todo issues (like "/* XXX ipv6 */"); etc. Also fix some spaces.


svn:r8580
 2006-10-02 22:13:42 +00:00
Nick Mathewson
4de9f45d6f r8850@totoro: nickm | 2006-10-02 17:21:11 -0400 
Make TrackExitHosts case-insensitive, and fix the behavior of .suffix TrackExitHosts items to avoid matching in the middle of an address. (Resolves an XXXX)


svn:r8579
 2006-10-02 22:13:37 +00:00
Nick Mathewson
bff83b666c r8846@totoro: nickm | 2006-10-02 16:59:57 -0400 
Move is_local_IP to config.c; have it check for same-/24; make it used only for reachability (not for banwidth, because that is probably not what we want). Fixes an XXX.


svn:r8578
 2006-10-02 21:00:35 +00:00
Nick Mathewson
d75edc35cc r8845@totoro: nickm | 2006-10-02 16:34:58 -0400 
Fix an XXXX: make path_is_relative work on windows even though we never use it there.


svn:r8577
 2006-10-02 21:00:24 +00:00
Nick Mathewson
36adc7cdd9 r8844@totoro: nickm | 2006-10-02 16:32:44 -0400 
Resolve an XXXX: make sure that we are actually on 2s-complement hardware.


svn:r8576
 2006-10-02 21:00:20 +00:00
Nick Mathewson
14f9b537d1 r8835@totoro: nickm | 2006-10-02 12:54:41 -0400 
Improve error messages from AUTHENTICATE attempts to controller.


svn:r8574
 2006-10-02 18:08:46 +00:00
Roger Dingledine
a3efc8e3d1 - V1 authorities should set "HSAuthoritativeDir 1" to continue being 
hidden service authorities too.
- Just because your DirPort is open doesn't mean people should be
  able to remotely teach you about hidden service descriptors. Now
  only accept rendezvous posts if you've got HSAuthoritativeDir set.


svn:r8573
 2006-10-01 22:16:55 +00:00
Nick Mathewson
57ffca883d r8826@totoro: nickm | 2006-10-01 17:58:45 -0400 
Disprefer exit nodes for entry, middle positions (fixes bug 200).  Also, switch to using a uint64_t to hold "total bandwidth for all nodes" under consideration; crypt_rand_int would have died at 2GB/s network capacity.


svn:r8571
 2006-10-01 21:59:09 +00:00
Nick Mathewson
219ad6395c r8825@totoro: nickm | 2006-10-01 17:41:27 -0400 
Add function to return a random uint64_t.


svn:r8570
 2006-10-01 21:59:05 +00:00
Roger Dingledine
3fcf736c83 misc touchups 
svn:r8568
 2006-10-01 21:42:44 +00:00
Nick Mathewson
ce72a9914e r8822@totoro: nickm | 2006-10-01 16:24:22 -0400 
Fix bug 303: reject attempts to use Tor as a one-hop proxy.


svn:r8566
 2006-10-01 20:50:11 +00:00
Roger Dingledine
7ed921708f Track down a seg fault that's been bothering me a while: if you 
enable your dirport as a client, you'll crash.


svn:r8561
 2006-10-01 07:53:17 +00:00
Roger Dingledine
4096e577c5 if we fail to build a circuit to an intended enclave, and it's 
not mandatory that we use that enclave, stop wanting it.


svn:r8559
 2006-10-01 06:41:13 +00:00
Roger Dingledine
96a4cb1dfa touchups 
svn:r8558
 2006-10-01 04:55:12 +00:00
Roger Dingledine
e6f4431722 stop trying to hammer router_rebuild_descriptor() when we don't 
have a public address we like yet.


svn:r8554
 2006-09-30 20:40:26 +00:00
Roger Dingledine
0fb7a7de95 Bugfix: when we tunnel our dir fetches via tor, don't believe 
the X-Forwarded-For header.


svn:r8553
 2006-09-30 20:14:15 +00:00
Nick Mathewson
fc9dd98d4c r8805@totoro: nickm | 2006-09-30 16:07:13 -0400 
Oops; nameserver list is circular.


svn:r8552
 2006-09-30 20:07:37 +00:00
Roger Dingledine
075cb54d9b make hidden service predicted circuits correct rather than 
exactly incorrect. i wonder how much this will help.


svn:r8550
 2006-09-30 19:22:24 +00:00
Nick Mathewson
723ff1c93d r8800@totoro: nickm | 2006-09-29 23:10:49 -0400 
Resolve bug 336: When displaying circuit paths with non-named routers, use their digests, not their nicknames.


svn:r8548
 2006-09-30 03:11:13 +00:00
Nick Mathewson
2cb956d1f5 r9036@Kushana: nickm | 2006-09-29 18:59:51 -0400 
I am glad that arma reviews my patches.


svn:r8546
 2006-09-29 22:59:59 +00:00
Nick Mathewson
c2d304366b r9032@Kushana: nickm | 2006-09-29 18:51:42 -0400 
Now, all log messages should be distinct.


svn:r8545
 2006-09-29 22:51:47 +00:00
Nick Mathewson
7d366f61cb r9025@Kushana: nickm | 2006-09-29 18:33:13 -0400 
Differentiate more duplicated log entries


svn:r8542
 2006-09-29 22:33:40 +00:00
Nick Mathewson
8308a37908 r9023@Kushana: nickm | 2006-09-29 17:27:24 -0400 
Make distinct all non-bug messages at notice or higher that appear 3 or more times.


svn:r8541
 2006-09-29 22:33:34 +00:00
Nick Mathewson
87648bdcf8 r9008@Kushana: nickm | 2006-09-29 13:50:10 -0400 
Doxygen comments for code in common.  Also simplify a few code paths to be more clear/speedy/correct.


svn:r8536
 2006-09-29 18:13:37 +00:00
Nick Mathewson
b21e656eaf r9007@Kushana: nickm | 2006-09-29 13:17:32 -0400 
Make eventdns give strings for DNS errors, not just error numbers.


svn:r8535
 2006-09-29 18:13:33 +00:00
Nick Mathewson
05604c60d4 r9006@Kushana: nickm | 2006-09-29 10:48:23 -0400 
Omit function names from NOTICE, WARN and ERR messages unless they are in LD_BUG.


svn:r8534
 2006-09-29 18:13:29 +00:00
Nick Mathewson
0335bd51d3 r9005@Kushana: nickm | 2006-09-29 10:37:55 -0400 
Implement DESCCHANGED event to tell controller when our router descriptor changes.


svn:r8533
 2006-09-29 18:13:25 +00:00
Nick Mathewson
8992bf6204 r8776@totoro: nickm | 2006-09-29 00:50:46 -0400 
Reserve the nickname "Unnamed" for routers that can't pick a hostname; any
 router can call itself Unnamed; directory servers will never allocate Unnamed
 to any particular router; clients won't believe that any router is the
 canonical Unnamed.
 


svn:r8529
 2006-09-29 04:51:28 +00:00
Nick Mathewson
9dbfb91f17 r8997@Kushana: nickm | 2006-09-28 23:40:22 -0400 
[Needs review.] Add a BEGIN_DIR relay cell type for an easier
 in-protocol way to connect to directory servers through Tor.
 Previously, clients could only connect to director servers over Tor
 from exit nodes, but couldn't get directory information anonymously
 from a non-exit cache without getting a directory server involved.
 
 This needs testing, and needs client-side code to actually exercise it.
 


svn:r8527
 2006-09-29 03:50:11 +00:00
Roger Dingledine
4791a4f1c9 combine the cutoff log entries 
svn:r8524
 2006-09-29 00:19:43 +00:00
Nick Mathewson
907fc6c73e r8977@Kushana: nickm | 2006-09-28 19:56:41 -0400 
Make "is a v1 authority", "is a v2 authority", and "is a hidden service authority" into separate flags so we can eventually migrate more trust away from moria.


svn:r8523
 2006-09-28 23:57:59 +00:00
Nick Mathewson
1a444e089a r8976@Kushana: nickm | 2006-09-28 17:18:57 -0400 
Another tweak to guard logic: ignore check for the Guard flag if a server is listed on EntryNodes.  (Also remove redundant checks for always-set variables.)


svn:r8522
 2006-09-28 23:57:56 +00:00
Nick Mathewson
d174cccd0b r8975@Kushana: nickm | 2006-09-28 17:13:53 -0400 
Document entry-guard related functions


svn:r8521
 2006-09-28 23:57:52 +00:00
Nick Mathewson
d3a06684bc r8974@Kushana: nickm | 2006-09-28 17:05:59 -0400 
Improvement to last entry guards patch: track when we last attempted to connect to a node in our state file along with how long it has been unreachable.  Also clarify behavior of parse_iso_time() when it gets extra characters.


svn:r8520
 2006-09-28 23:57:49 +00:00
Nick Mathewson
9988112c87 r8973@Kushana: nickm | 2006-09-28 16:53:19 -0400 
Refactor entry guard status logic a lot; allow more factors [like not
 having a Guard flag or being listed in ExcludeNodes] to render a guard
 "unlisted" (now called "unusable"); track guard down status (now
 called "unreachable") separately from is_running.


svn:r8519
 2006-09-28 23:57:44 +00:00
Peter Palfrader
bc25e87754 r9897@danube: weasel | 2006-09-29 01:08:44 +0200 
Add a space in a wrapped log message


svn:r8517
 2006-09-28 23:08:54 +00:00
Peter Palfrader
c339bd2713 r9895@danube: weasel | 2006-09-29 01:05:00 +0200 
Restore to previous wording that svk merging made me mess up


svn:r8516
 2006-09-28 23:05:17 +00:00
Peter Palfrader
540fbaae75 r9889@danube: weasel | 2006-09-29 00:57:42 +0200 
bandwidth is not measured in bytes


svn:r8515
 2006-09-28 22:59:36 +00:00
Peter Palfrader
9e6c0b8b3b r9888@danube: weasel | 2006-09-29 00:57:02 +0200 
Also log guard bandwidth cutoff


svn:r8514
 2006-09-28 22:59:25 +00:00
Peter Palfrader
14882b3ec0 r9770@danube: weasel | 2006-09-15 07:20:05 +0200 
router_set_networkstatus() gets a list of status documents we asked for from
 connection_dir_client_reached_eof().  However, as a cache we (sometimes?) just
 ask for "all".  router_set_networkstatus() would freak out over that, meaning
 it would log a warning and drop the status document instead of caching it
 as it is supposed to.  Now we let router_set_networkstatus() know if the
 data comes from an all-request so it can do the right thing.


svn:r8513
 2006-09-28 22:58:58 +00:00
Nick Mathewson
95132f836a r8750@totoro: nickm | 2006-09-27 20:52:01 -0400 
Fix some warnings on mingw; hopefully this should let us build on mingw without warnings.


svn:r8509
 2006-09-28 00:53:02 +00:00
Nick Mathewson
ba7868c7b3 r8969@Kushana: nickm | 2006-09-26 18:00:36 -0400 
Remove a signed/unsigned comparison in eventdns.c


svn:r8508
 2006-09-26 22:03:26 +00:00
Nick Mathewson
cd2425ffa0 r8968@Kushana: nickm | 2006-09-26 17:53:27 -0400 
Fix for reverse dns: only assume we will get an answer when the result was success.


svn:r8507
 2006-09-26 22:03:23 +00:00
Nick Mathewson
49ad1eefa1 Add an EnforceDistinctSubnets option so that clients who know what they are doing (mainly people with private testing networks) can disable our same-/16 detection. 
svn:r8504
 2006-09-25 22:12:54 +00:00
Nick Mathewson
01f9e97d43 Minor fix: add code to eventdns so it can free memory on shutdown. This should help valgrind and dmalloc freak out less. 
svn:r8503
 2006-09-25 20:38:58 +00:00
Nick Mathewson
52e179b942 Trivial fix to make dmalloc happier: release memory held in static member of escaped(). 
svn:r8502
 2006-09-25 18:46:29 +00:00
Nick Mathewson
4fe76e7b6b Free named_server_map on shutdown. 
svn:r8500
 2006-09-25 16:06:39 +00:00
Nick Mathewson
0f8491a254 Backport candidate: remove dangerous free(0) on hashtable init 
svn:r8499
 2006-09-25 16:06:09 +00:00
Nick Mathewson
78c068397a add missing paren in dmalloc tor_free 
svn:r8498
 2006-09-25 15:44:40 +00:00
Roger Dingledine
ad430b9561 checkpoint changelog and general polishing 
svn:r8497
 2006-09-25 05:59:13 +00:00
Roger Dingledine
bc848c8740 add 6697 (ircs) as longlivedport. 
svn:r8496
 2006-09-25 05:24:43 +00:00
Roger Dingledine
bda137501e whitespace cleanups 
svn:r8485
 2006-09-24 20:54:59 +00:00
Nick Mathewson
11b4296b0b Marge changes from libevent evdns to our eventdns. Most are cosmetic, but one or two are stability-related. This should make it easier to push our changes back towards libevent. 
svn:r8482
 2006-09-24 17:52:23 +00:00
Nick Mathewson
d3af1f2189 Backport candidate: Fix a long-standing server-side DNS bug. When a 
client asks us to resolve (not connect to) an address, and we have a
cached answer, give them the cached answer.  Previously, we would give
them no answer at all.



svn:r8478
 2006-09-24 17:05:00 +00:00
Nick Mathewson
4218f09820 r8910@Kushana: nickm | 2006-09-22 12:14:05 -0400 
Instead of just checking known-invalid addresses for DNS hijacking, we
 now check randomly generated addresses, and if too many of them map to
 the same IP, we assume that IP is the destination of a DNS hijack
 attempt.
 
 A little bird tells me that some DNS hijackers think that declining to
 give an A record for RFC2606 addresses (like .invalid and .example)
 makes them more standards compliant.  Standardswise, this is like an
 illicit brothel making sure that nobody has pulled the tags off the
 mattresss, but that doesn't get us out of working around it.
 


svn:r8465
 2006-09-22 20:20:26 +00:00
Nick Mathewson
bde5939ad3 r8909@Kushana: nickm | 2006-09-22 00:38:13 -0400 
Consider changes to has_old_dnsworkers as noncosmetic


svn:r8464
 2006-09-22 20:20:21 +00:00
Roger Dingledine
aa77298819 remove 8888 as a long lived port. i can't remember why it's 
on the list.


svn:r8461
 2006-09-22 19:29:26 +00:00
Nick Mathewson
f0f3bbc63b r8901@Kushana: nickm | 2006-09-21 20:43:48 -0400 
I tracked a bug in server-side reverse DNS to something concerning the caching code. Ive disabled server-side cacheing for reverse DNS answers for now, and I am noting the bug in the TODO.


svn:r8454
 2006-09-22 00:45:08 +00:00
Nick Mathewson
6b3f6afb58 r8895@Kushana: nickm | 2006-09-21 20:05:11 -0400 
Debug client-side reverse dns code.


svn:r8452
 2006-09-22 00:44:07 +00:00
Nick Mathewson
213658f117 r8894@Kushana: nickm | 2006-09-21 18:30:42 -0400 
Specify and implement SOCKS5 interface for reverse hostname lookup.


svn:r8451
 2006-09-22 00:43:55 +00:00
Roger Dingledine
9bc8d69dfc remove some loud log messages 
svn:r8450
 2006-09-22 00:24:27 +00:00
Nick Mathewson
29a756af8e Fix a couple of server-side reverse dns bugs 
svn:r8449
 2006-09-22 00:10:26 +00:00
Nick Mathewson
63395c747c Fix stupid C mistake. Glad I caught that one fast. 
svn:r8448
 2006-09-21 22:57:07 +00:00
Nick Mathewson
58200f06a5 Fix bug in r8440: base32 uses 5 bytes per char, not 4. 
svn:r8447
 2006-09-21 22:24:45 +00:00
Nick Mathewson
4f13cb82fd r8881@Kushana: nickm | 2006-09-21 17:27:59 -0400 
Allow resolve requests to non-exits when they are specifically requested (via resolve foo.bar.exit).


svn:r8446
 2006-09-21 21:49:36 +00:00
Nick Mathewson
59f9487225 r8880@Kushana: nickm | 2006-09-21 17:26:02 -0400 
Trivial patch to appease warn-happy gcc: mark unused parameter


svn:r8445
 2006-09-21 21:49:15 +00:00
Nick Mathewson
adade79f68 r8879@Kushana: nickm | 2006-09-21 17:20:31 -0400 
Oops from earlier patch; add "opt eventdns" to unittests, fix bug in routerdesc generation.


svn:r8444
 2006-09-21 21:49:03 +00:00
Nick Mathewson
7c21dabef1 r8878@Kushana: nickm | 2006-09-21 17:15:47 -0400 
Trivial whitespace cleanups.


svn:r8443
 2006-09-21 21:48:55 +00:00
Nick Mathewson
6a1746f98f r8877@Kushana: nickm | 2006-09-21 17:12:33 -0400 
Consider non-exit servers unsuitable for RESOLVE commands.


svn:r8442
 2006-09-21 21:48:42 +00:00
Nick Mathewson
d273d52979 r8876@Kushana: nickm | 2006-09-21 16:58:46 -0400 
Trivial cleanup: !!x is a weird way to spell x != NULL.


svn:r8441
 2006-09-21 21:48:37 +00:00
Nick Mathewson
e4a9b4de4e r8875@Kushana: nickm | 2006-09-21 16:46:28 -0400 
Resolve bug 330: detect ISPs that want to hijack failing DNS requests and basically domain-squat the entire internet.


svn:r8440
 2006-09-21 21:48:22 +00:00
Nick Mathewson
04bec67574 r8874@Kushana: nickm | 2006-09-21 15:22:27 -0400 
Rename and document SearchDomains and ResolvConf options; warn if ServerDNSResolvConfFile is given but eventdns isnt enabled.


svn:r8439
 2006-09-21 21:48:16 +00:00
Nick Mathewson
083e9c2b59 r8873@Kushana: nickm | 2006-09-21 14:38:22 -0400 
Fix a bug: Remember, each call to escaped() replaces the value returned from the last call to escaped().


svn:r8438
 2006-09-21 21:48:11 +00:00
Nick Mathewson
a942441615 r8872@Kushana: nickm | 2006-09-21 14:00:20 -0400 
Implement server-side reverse DNS using eventdns.  Add an option to routerdescs so we can tell which servers have eventdns enabled.


svn:r8437
 2006-09-21 21:48:06 +00:00
Nick Mathewson
b2cc52fa02 Speed up eat_whitespace by a lot. 
svn:r8434
 2006-09-19 23:55:35 +00:00
Nick Mathewson
6b716fdfb9 NEEDS REVIEW. Act on previous comment, and handle named servers differently: now, we allow multiple servers with the same name in the routerlist even if that name is reserved, but we check whether names are reserved when we try to look up routers by nickname. This is a minor security fix. This makes router_add_to_routerlist O(1). This is a backport candidate. 
svn:r8433
 2006-09-19 23:48:14 +00:00
Nick Mathewson
5ebb949c9f Stop searching routerlist for routers with the same identity as other routers (on router insert): we already have a map for that. (We need to add an index field to routerinfo_t so we can figure out which point in the routerlist to replace.) Also, add a comment to routerlist.c; arma, please advise? 
svn:r8432
 2006-09-19 23:18:30 +00:00
Nick Mathewson
2d4950c837 Malloc and friends are critical-path: Thus, add an it-wont-happen branch prediction for NULL returns, and skip the malloc(0) check on platforms where malloc(0) returns a pointer. 
svn:r8431
 2006-09-19 22:36:48 +00:00
Nick Mathewson
7b0ec744bc Switch routerlist.c to using memcmp on digests rather than crypto_pk_cmp_keys(); speed up find_whitespace a lot (8x for me) by using a switch statement. This should speed parsing a lot of routers at once by a lot. 
svn:r8430
 2006-09-19 22:20:09 +00:00
Roger Dingledine
e9abe750ea eventdns patch from Adam Langley 
svn:r8429
 2006-09-19 21:37:03 +00:00
Nick Mathewson
4bc42f4c18 Fix a bogus free() in eventdns.c. Bug reported by xiando. 
svn:r8428
 2006-09-19 20:45:20 +00:00
Nick Mathewson
93beeac01d Merge in some bsockets calls, all wrapped inside #if defined(USE_BSOCKETS) 
svn:r8427
 2006-09-19 20:41:31 +00:00
Roger Dingledine
0494e271e7 good god, that was a bad idea. i've built 500 circuits in the past 5 
minutes, trying to establish reachability of my unreachable server.


svn:r8415
 2006-09-18 04:59:15 +00:00
Roger Dingledine
4920b9d1cc Fix two bugs: first, "extendcircuit" would crash if you gave it a purpose. 
Second, if you give an unknown purpose, it would say:
552 Unknown purpose "purpose=foo"
Now it just says
552 Unknown purpose "foo"


svn:r8412
 2006-09-18 04:24:41 +00:00
Nick Mathewson
65974f82fa r8839@Kushana: nickm | 2006-09-17 16:11:59 -0400 
Add some client performance XXXXs; try to move some common case tests higher on their decision trees.


svn:r8410
 2006-09-17 20:12:10 +00:00
Roger Dingledine
b049b1b014 build testing circuits more rapidly. this has a failure mode 
where if circuits fail quickly, we'll fail a lot of them very
quickly and not retry for a while. so be it.


svn:r8407
 2006-09-17 06:18:06 +00:00
Roger Dingledine
bfa78b3dea actually, do the bandwidth test anyway, if you've been up at 
least 6 hours at your previous address.


svn:r8403
 2006-09-15 18:07:11 +00:00
Roger Dingledine
a51ec44466 avoid thrashing the bandwidth exercise when we change IPs a lot. 
(we avoid simply by not doing any new tests when we change IPs --
it looks like we retain our previous bandwidth estimates, so there's
no need to do new exercise. though in some cases new exercises may
still be useful. one day we'll do something smarter.)


svn:r8402
 2006-09-15 18:03:53 +00:00
Roger Dingledine
c22dc94fe6 make my bandwidth exercises actually happen 
svn:r8400
 2006-09-15 05:53:00 +00:00
Roger Dingledine
769f9201a6 Send out a burst of long-range drop cells after we've established that 
we're reachable. Spread them over 4 circuits, so hopefully a few will
be fast. This exercises our bandwidth and bootstraps us quicker.


svn:r8399
 2006-09-15 05:30:25 +00:00
Peter Palfrader
ba091ae5d7 r9770@danube: weasel | 2006-09-15 07:20:05 +0200 
router_set_networkstatus() gets a list of status documents we asked for from
 connection_dir_client_reached_eof().  However, as a cache we (sometimes?) just
 ask for "all".  router_set_networkstatus() would freak out over that, meaning
 it would log a warning and drop the status document instead of caching it
 as it is supposed to.  Now we let router_set_networkstatus() know if the
 data comes from an all-request so it can do the right thing.


svn:r8398
 2006-09-15 05:20:16 +00:00
Peter Palfrader
5beb114744 r9767@danube: weasel | 2006-09-15 06:27:48 +0200 
Minor documentation fix


svn:r8397
 2006-09-15 04:29:36 +00:00
Nick Mathewson
e58b9c1151 r8819@Kushana: nickm | 2006-09-15 00:27:45 -0400 
Implement a smartlist_uniq() that will with luck not end the world.


svn:r8396
 2006-09-15 04:27:58 +00:00
Nick Mathewson
ce83f43629 r8817@Kushana: nickm | 2006-09-14 18:31:29 -0400 
Patch from steve hildrey: Generate network status correctly on non-versioning dirservers


svn:r8395
 2006-09-14 22:34:57 +00:00
Peter Palfrader
2cf6cfe189 r9758@danube: weasel | 2006-09-14 07:10:12 +0200 
Add a comment


svn:r8391
 2006-09-14 05:17:02 +00:00
Peter Palfrader
7fcec09560 r9753@danube: weasel | 2006-09-14 07:07:02 +0200 
Remove duplicates from MyFamily


svn:r8390
 2006-09-14 05:07:34 +00:00
Peter Palfrader
9d9e31dcf4 r9752@danube: weasel | 2006-09-14 07:06:49 +0200 
Fix some dead code that is on occasion useful


svn:r8389
 2006-09-14 05:07:26 +00:00
Nick Mathewson
4f888c9dfc r8808@senior-two-eighty: nickm | 2006-09-14 00:59:54 -0400 
House style for no-args functions is old-style C, not C++


svn:r8388
 2006-09-14 05:00:02 +00:00
Peter Palfrader
28cac25d7e r9749@danube: weasel | 2006-09-14 06:53:12 +0200 
Do not graciously increase the size to be mmaped if the current size already is
 at a page_size boundary.  This is important since if a file has a size of zero
 and we mmap() it with length > 0, then accessing the mmaped memory area causes
 a bus error.  However, if we pass a length of 0 to mmap() it will return with -1
 and things work from there.


svn:r8387
 2006-09-14 04:53:42 +00:00
Peter Palfrader
984e8f6efb r9736@danube: weasel | 2006-09-14 05:53:06 +0200 
Refactor dirserv_parse_fingerprint_file(fname) into dirserv_load_fingerprint_file():
 There is not need to put together the path to the approved-routers file in more than one place.


svn:r8386
 2006-09-14 04:53:23 +00:00
Nick Mathewson
1852f503cf r8776@Kushana: nickm | 2006-09-11 22:49:53 -0400 
Avoid crash when telling controller stream-status and a stream is detached.  Fixes bug 334. Backport candidate.


svn:r8370
 2006-09-12 02:50:14 +00:00
Roger Dingledine
e56dbb810f start remembering X-Your-Address-Is hints even if you're 
a client, so you can become a server more smoothly.


svn:r8359
 2006-09-09 19:36:51 +00:00
Roger Dingledine
9af3175687 parameterize the loudness of get_interface_address() 
svn:r8358
 2006-09-09 19:20:27 +00:00
Roger Dingledine
5f6351ceb3 fix typo, add log message 
svn:r8357
 2006-09-09 19:16:07 +00:00
Roger Dingledine
0c3cc15898 fix encoding in "getinfo addr-mappings" response. 
fix error code when "getinfo dir/status/" fails.


svn:r8355
 2006-09-09 03:38:03 +00:00
Roger Dingledine
29b6d6560e add a "getinfo address" controller command. 
svn:r8354
 2006-09-09 03:18:39 +00:00
Roger Dingledine
25cb9453d7 possibly make tor build and run on cygwin again. 
svn:r8353
 2006-09-08 20:48:43 +00:00
Peter Palfrader
fdd56dee69 r9695@danube: weasel | 2006-09-08 18:11:53 +0200 
Make tor build with -O0


svn:r8352
 2006-09-08 16:12:15 +00:00
Mike Chiussi
f9f281251b another typo 
svn:r8351
 2006-09-08 09:05:07 +00:00
Mike Chiussi
1ee88bb01a fixed typo in eventdns.c 
svn:r8350
 2006-09-08 09:02:14 +00:00
Nick Mathewson
c063c7b8cb r8757@Kushana: nickm | 2006-09-07 13:07:46 -0400 
Fix more compile warnings on Woody.


svn:r8349
 2006-09-07 19:00:51 +00:00
Nick Mathewson
8a12d9ae2e r8755@Kushana: nickm | 2006-09-07 12:31:57 -0400 
Tabify eventdns


svn:r8348
 2006-09-07 16:32:06 +00:00
Nick Mathewson
4246490b81 r8753@Kushana: nickm | 2006-09-07 12:23:25 -0400 
Make eventdns spacing consistant


svn:r8347
 2006-09-07 16:24:19 +00:00
Mike Chiussi
5d773af545 undid whitespace changes to dns.c 
svn:r8346
 2006-09-07 06:36:22 +00:00
Mike Chiussi
b931994c6a fixed win32 eventdns snafu 
svn:r8345
 2006-09-07 06:34:20 +00:00
Mike Chiussi
c40acb86f4 - got rid of tabs 
svn:r8344
 2006-09-07 04:02:52 +00:00
Mike Chiussi
3c85780e69 - got rid of tabs (i think) 
svn:r8343
 2006-09-07 03:58:46 +00:00
Mike Chiussi
5af47d1641 - added some debugging lines to load_nameservers_from_registry() 
svn:r8342
 2006-09-07 03:53:14 +00:00
Roger Dingledine
ae67a044f0 clean up some comments 
svn:r8338
 2006-09-07 01:23:15 +00:00
Roger Dingledine
43edbf0461 prefer calling it a client rather than an OP 
svn:r8334
 2006-09-07 01:00:37 +00:00
Mike Chiussi
879fe91d88 rm'ed a tab (sorry) 
svn:r8333
 2006-09-07 00:54:28 +00:00
Mike Chiussi
91d7ad660f - fixed up typos in eventdns.c 
- configure lets user build with eventdns on win32


svn:r8332
 2006-09-07 00:51:20 +00:00
Roger Dingledine
5a8563baed new config option AvoidDiskWrites for people running tors on 
usb keys and other media that degrades when you write.
not implemented yet, so just a reminder.


svn:r8331
 2006-09-07 00:30:29 +00:00
Nick Mathewson
7ed528c5c5 r8733@Kushana: nickm | 2006-09-06 17:35:22 -0400 
Add some missing defines to eventdns.c for windows.


svn:r8330
 2006-09-06 21:35:30 +00:00
Nick Mathewson
1e26233957 r8731@Kushana: nickm | 2006-09-06 16:33:19 -0400 
Try to fix eventdns.c build on windows.


svn:r8329
 2006-09-06 20:33:28 +00:00
Nick Mathewson
e10e921386 r8729@Kushana: nickm | 2006-09-06 16:20:40 -0400 
Fix dns_cancel_pending_resolve() to realize pending resolves have expiry times, and should not be freed except when they fall off the pqueue.


svn:r8328
 2006-09-06 20:22:05 +00:00
Nick Mathewson
365ccf0742 r8725@Kushana: nickm | 2006-09-06 04:39:29 -0400 
spawn_func fixes: have cpuworker_main and dnsworker_main confirm to the right interfaces [casting func to void* is icky].  Also, make pthread_create() build without warnings.


svn:r8327
 2006-09-06 08:42:20 +00:00
Nick Mathewson
000b7b287c r8724@Kushana: nickm | 2006-09-06 04:32:28 -0400 
Fix spaces; restore support for mapping files over 4GB on win32 (?)


svn:r8326
 2006-09-06 08:42:16 +00:00
Mike Chiussi
6ec9c1092a - made configure check if we are building for win32 
- made configure link to required system dll's if building for win32
- added diffs for libevent 1.1b
- forced user to turn off eventdns if win32 is set 
- cleaned up tor_mmap_file()_win32 (not sure if it's stable)
- cleaned up some warnings and typos




svn:r8322
 2006-09-06 01:49:55 +00:00
Roger Dingledine
585ae26783 patch from tup 
svn:r8321
 2006-09-05 14:30:06 +00:00
Nick Mathewson
b40e639f15 r8708@Kushana: nickm | 2006-09-02 20:34:15 -0400 
Fix warnings reported by weasel when compiling Tor on Debian woody.


svn:r8318
 2006-09-03 02:13:52 +00:00
Nick Mathewson
c4ac4bcba3 r8696@Kushana: nickm | 2006-08-31 14:43:44 -0400 
Try to appease some warnings with newer gccs that believe that ignoring a return value is okay, but casting a return value and then ignoring it is a sign of madness.


svn:r8312
 2006-08-31 18:47:54 +00:00
Nick Mathewson
21a7880358 r8695@Kushana: nickm | 2006-08-31 14:35:36 -0400 
Fix two corner cases in router_dir_info_changed().  This should have no observable effect.


svn:r8311
 2006-08-31 18:46:46 +00:00
Nick Mathewson
f170e5798f r8692@Kushana: nickm | 2006-08-31 13:38:07 -0400 
Fix bug 327 (part 2): Cast char to unsigned char before passing to toupper/tolower.  (Follow the same idiom as with isupper and friends, in case we run into the same problem on SGI or whereever it was.)


svn:r8310
 2006-08-31 17:39:51 +00:00
Nick Mathewson
bc0c39f85d r8691@Kushana: nickm | 2006-08-31 13:30:46 -0400 
Fix bug 327 (part 1): Use correct macro to test for GCC 3 or later.


svn:r8309
 2006-08-31 17:39:47 +00:00
Nick Mathewson
921bfdb40a r8687@Kushana: nickm | 2006-08-30 19:33:28 -0400 
Apply patch from Adam Langley: fix assert() in eventdns.c.  [Fuzzing, apparently, is cool.]


svn:r8308
 2006-08-30 23:34:56 +00:00
Nick Mathewson
6c499804bb r8686@Kushana: nickm | 2006-08-30 18:01:35 -0400 
Remove bogus whitespace


svn:r8307
 2006-08-30 23:34:49 +00:00
Nick Mathewson
fee33d2ff1 r8682@Kushana: nickm | 2006-08-29 17:58:59 -0400 
Fix compilation on GCC2 by disabling fun attributes unless __GNUC_MAJOR__ >= 3.


svn:r8303
 2006-08-29 21:59:20 +00:00
Nick Mathewson
8138d1c0a4 r8654@Kushana: nickm | 2006-08-28 16:50:36 -0400 
I bet real programmers even have programs that compile.


svn:r8278
 2006-08-28 20:50:47 +00:00
Nick Mathewson
dc4951314f r8652@Kushana: nickm | 2006-08-28 16:41:44 -0400 
Resolve bug 324: strdup the right variable.


svn:r8277
 2006-08-28 20:42:14 +00:00
Roger Dingledine
2499d1db7c and make the comment better, while i'm at it 
svn:r8273
 2006-08-28 19:02:57 +00:00
Roger Dingledine
2a4d5782ef an even better check -- now servers hang up if they can't write 
for a while, and clients hang up if they can't read for a while.


svn:r8272
 2006-08-28 19:00:17 +00:00
Roger Dingledine
f75ef94f27 fix bug found by Adam J. Richter: directory clients shouldn't 
hang up five minutes after they begin. but directory servers
should still hang up after 5 minutes of failing to deliver
any bytes.


svn:r8271
 2006-08-28 18:51:36 +00:00
Roger Dingledine
a76e032b14 put some symbols on the eventdns logging. leave the haphazard 
formatting alone.


svn:r8270
 2006-08-28 08:24:36 +00:00
Nick Mathewson
6fcdcc7fc7 r8626@Kushana: nickm | 2006-08-27 23:45:46 -0400 
Aw, crap.  Non-gcc bug.  We need regular windows builds.


svn:r8259
 2006-08-28 03:46:21 +00:00
Nick Mathewson
dbe0c6f6ef r8609@Kushana: nickm | 2006-08-27 17:24:27 -0400 
Add some doxygen, concentrated in dns.c


svn:r8256
 2006-08-28 03:16:02 +00:00
Nick Mathewson
54ca0387a5 r8608@Kushana: nickm | 2006-08-27 16:57:47 -0400 
Make it possible to change nameserver options while Tor is running.


svn:r8255
 2006-08-28 03:15:55 +00:00
Nick Mathewson
be7054c626 r8607@Kushana: nickm | 2006-08-27 15:45:42 -0400 
Change configuration strategy for eventdns. Instead of elaborate option set, just allow the user to specify another resolv.conf to use.


svn:r8254
 2006-08-28 03:15:50 +00:00
Nick Mathewson
d62f9a03fb r8605@Kushana: nickm | 2006-08-27 14:01:11 -0400 
divide eventdns log messages into warn and info messages.


svn:r8252
 2006-08-28 03:15:38 +00:00
Roger Dingledine
30b8017005 bump trunk to 0.1.2.1-alpha-dev 
svn:r8251
 2006-08-28 03:01:07 +00:00
Roger Dingledine
389b7999c6 bump to 0.1.2.1-alpha 
(does it work?)


svn:r8244
 2006-08-27 07:03:17 +00:00
Roger Dingledine
e17276b2f1 comment out an unused variable; nick, feel free to excise it further. 
svn:r8241
 2006-08-27 06:58:30 +00:00
Roger Dingledine
94afe807ac stop a big memory leak: we were leaking the whole contents 
of cached-routers.new every time we read it.


svn:r8236
 2006-08-27 02:12:12 +00:00
Roger Dingledine
9f5856c03d stop three memory leaks. nick, fix these if i'm wrong. 
svn:r8235
 2006-08-27 02:07:54 +00:00
Roger Dingledine
24ad1e06cf i'm guessing nick meant to check the return value of dns_init. 
and revise some log severities to match the convention.


svn:r8234
 2006-08-27 01:41:08 +00:00
Roger Dingledine
8297608217 fix typo 
svn:r8233
 2006-08-27 01:33:35 +00:00
Roger Dingledine
c0cb1c7bd2 remove some more vestiges of cvs 
svn:r8229
 2006-08-26 06:51:02 +00:00
Roger Dingledine
171a00ec50 fix a log level -- err is for things that kill tor, warn is for 
things that tor can recover from.

also, avoid situations where people who don't read their logs
accumulate ten thousand useless files in their datadir.


svn:r8227
 2006-08-26 04:48:50 +00:00
Nick Mathewson
fd36eb0788 r8576@Kushana: nickm | 2006-08-25 17:16:01 -0400 
Fix bug 314: Instead of checking address_in_virtualrange, check addressmap_have_mapping().  This should be more accurate.  [Rename to addressmap_have_mapping() from addressmap_already_mapped().]


svn:r8226
 2006-08-25 21:16:22 +00:00
Nick Mathewson
7739c5c49a r8573@Kushana: nickm | 2006-08-25 16:55:19 -0400 
Resolve bug 321 when using dnsworkers: append a period to every address we resolve at the exit node, so that we do not accidentally pick up local addresses, and so that failing searches are retried in the resolver search domains.  (This is already solved for eventdns.)


svn:r8225
 2006-08-25 21:02:01 +00:00
Nick Mathewson
c82c4a9e8b r8572@Kushana: nickm | 2006-08-25 16:35:49 -0400 
Fix for bug 308: When we have a state file we cannot parse, tell the user, and move it aside.


svn:r8224
 2006-08-25 21:01:56 +00:00
Roger Dingledine
0649fa14c1 make our socks5 handling more robust to broken socks clients: 
throw out everything waiting on the buffer in between socks
handshake phases, since they can't possibly (so the theory
goes) have predicted what we plan to respond to them.


svn:r8223
 2006-08-24 04:51:55 +00:00
Roger Dingledine
9ebaf01096 clean up logging conventions in do_list_fingerprint() 
svn:r8222
 2006-08-24 00:54:18 +00:00
Roger Dingledine
41d8d77c8b tor --verify-config now exits with -1(255) or 0 depending on whether 
the config options are bad or good.


svn:r8221
 2006-08-23 23:45:03 +00:00
Nick Mathewson
0f5bfc1521 r7411@Kushana: nickm | 2006-08-17 19:00:25 -0400 
patch suggested by Karsten Loesing: respond to SIGNAL command before we execute the signal, in case the signal shuts us down.


svn:r7072
 2006-08-17 23:00:32 +00:00
Nick Mathewson
ae5ee4c924 r7405@Kushana: nickm | 2006-08-16 14:38:46 -0400 
Implement reverse DNS lookup in eventdns: add new entry point; rename old entry point; revise TODO a little; add facility for parsing dns names.


svn:r7070
 2006-08-16 18:47:24 +00:00
Nick Mathewson
b050ecf86c r7404@Kushana: nickm | 2006-08-16 09:32:19 -0400 
Pass hints to getaddrinfo; fix bug 280 (?)


svn:r7069
 2006-08-16 18:47:19 +00:00
Roger Dingledine
6650470575 automatically avoid picking more than one node from the same 
/16 network when constructing a circuit.


svn:r7068
 2006-08-16 03:44:13 +00:00
Roger Dingledine
d8fc598a2a dns.c:173: warning: control reaches end of non-void function 
svn:r7067
 2006-08-16 02:18:55 +00:00
Nick Mathewson
163dd78282 r7398@Kushana: nickm | 2006-08-15 00:49:50 -0400 
Add missing backslash


svn:r7065
 2006-08-15 04:50:33 +00:00
Nick Mathewson
67b775bc6e r7397@Kushana: nickm | 2006-08-15 00:46:18 -0400 
Fix eventdns version of dns.c. Man, we need to get rid of this eventdns/dnsworker split.


svn:r7064
 2006-08-15 04:50:17 +00:00
Nick Mathewson
7bfb2cf4e8 r7393@Kushana: nickm | 2006-08-14 23:51:07 -0400 
remove extraneous #endif


svn:r7063
 2006-08-15 03:54:13 +00:00
Nick Mathewson
273ee3e814 r7392@Kushana: nickm | 2006-08-14 23:50:32 -0400 
Only do the expensive version of router_have_minimum_dir_info() when the dir info has changed.  Backport candidate, since oprofile suggests that this function and ones it calls account for 25-35% of oprofile samples.


svn:r7062
 2006-08-15 03:54:09 +00:00
Nick Mathewson
bc21df6a5c r7386@Kushana: nickm | 2006-08-14 17:43:44 -0400 
Patch from Adam Langley.
 
  * I meant getaddrinfo_a, not getaddrinfo_r - fixed
  * Added more checks to the parsing code.
  * It seems you switched an alloca to a malloc, but didn't add any frees
 


svn:r7061
 2006-08-14 21:44:45 +00:00
Nick Mathewson
200e24981a r7046@Kushana: nickm | 2006-08-05 13:57:04 -0400 
Make it possible for dns_init() to fail; note failure of eventdns configuratoin.


svn:r7059
 2006-08-14 21:44:34 +00:00
Nick Mathewson
a5c0aa43a0 r7383@Kushana: nickm | 2006-08-14 16:16:03 -0400 
Stop walking entire dns cache for every request, now that we found our hash table bug.


svn:r7057
 2006-08-14 20:16:21 +00:00
Roger Dingledine
5194b91053 avoid complaining about our SOCKS proxy proxy. 
svn:r7053
 2006-08-14 10:00:15 +00:00
Roger Dingledine
4b94dabb53 note a compile warning that we should investigate one day. 
svn:r7052
 2006-08-14 09:44:54 +00:00
Roger Dingledine
9b10f11d39 fix typos and stuff 
svn:r7049
 2006-08-14 08:55:41 +00:00
Roger Dingledine
bf10d8a06a simplify compare_cached_resolves_by_expiry() to make it match 
the idioms of other compare functions. hopefully i didn't
break it?


svn:r7048
 2006-08-14 07:08:29 +00:00
Nick Mathewson
6da96f0ed7 r7369@Kushana: nickm | 2006-08-14 02:03:10 -0400 
Shortening fields is only one part of making structs shorter. You must also consider alignment padding. Whee.


svn:r7045
 2006-08-14 06:03:26 +00:00
Roger Dingledine
2c27cfc38e save 3-7 bytes per edge connection 
svn:r7044
 2006-08-14 05:53:57 +00:00
Roger Dingledine
6fdc63aed2 simplify the connection_write_to_buf_zlib() wrapper. 
svn:r7042
 2006-08-13 23:38:30 +00:00
Nick Mathewson
b68ffcc193 r7341@Kushana: nickm | 2006-08-11 00:51:05 -0700 
Amazing how much difference adding a ! to all your asserts can make.


svn:r7029
 2006-08-11 07:51:34 +00:00
Nick Mathewson
33fc829273 r7337@Kushana: nickm | 2006-08-11 00:42:04 -0700 
Only use __builtin_offsetof with gcc 4 or later


svn:r7028
 2006-08-11 07:42:11 +00:00
Roger Dingledine
f294575469 fix funny-looking assignment that crashes unit tests 
svn:r7027
 2006-08-11 07:41:21 +00:00
Roger Dingledine
5647e5c7e6 fix typo, add explanatory comment 
svn:r7026
 2006-08-11 07:31:16 +00:00
Nick Mathewson
42a5d7a4ba r7335@Kushana: nickm | 2006-08-11 00:13:03 -0700 
fix wide lines


svn:r7025
 2006-08-11 07:17:16 +00:00
Nick Mathewson
9b5a643475 r7328@Kushana: nickm | 2006-08-11 00:04:26 -0700 
remove an assert that can never be false (an array in a non-null struct cannot be null).


svn:r7024
 2006-08-11 07:09:52 +00:00
Nick Mathewson
04bf4b0fc4 r7327@Kushana: nickm | 2006-08-11 00:00:36 -0700 
Fix a pedantic warning


svn:r7023
 2006-08-11 07:09:45 +00:00
Nick Mathewson
ffab3b48a8 r7326@Kushana: nickm | 2006-08-10 23:50:49 -0700 
And another GCC change: predict that tor_frees() are usually real frees, and tor_asserts() usually wont happen. Other test should wait till -fprofile-arcs


svn:r7022
 2006-08-11 07:09:35 +00:00
Nick Mathewson
4eddbcf262 r7325@Kushana: nickm | 2006-08-10 23:37:31 -0700 
Use gcc offsetof where available.


svn:r7021
 2006-08-11 07:09:28 +00:00
Nick Mathewson
09a895e222 r7324@Kushana: nickm | 2006-08-10 23:23:15 -0700 
Add more warnings to the list of those we tolerate. Start using GCC attributes more, for better error checking and better code generation.


svn:r7020
 2006-08-11 07:09:17 +00:00
Nick Mathewson
02d42d9138 Fix crash in first-time option validation. Oops. 
svn:r7018
 2006-08-10 19:56:10 +00:00
Nick Mathewson
7ddd9e8cd9 r7304@Kushana: nickm | 2006-08-10 01:58:05 -0700 
Fix verbose compilation errors; make sure transparent proxy fails when no method is configured.


svn:r7012
 2006-08-10 09:02:26 +00:00
Nick Mathewson
3da737ac98 r7303@Kushana: nickm | 2006-08-10 01:52:19 -0700 
whitespace fixes


svn:r7011
 2006-08-10 09:02:12 +00:00
Nick Mathewson
74df271e00 r7302@Kushana: nickm | 2006-08-10 01:48:44 -0700 
Warn about open TransListenAddress values.


svn:r7010
 2006-08-10 09:02:02 +00:00
Nick Mathewson
cd560d8528 r7301@Kushana: nickm | 2006-08-10 01:41:27 -0700 
Only open /dev/pf once.


svn:r7009
 2006-08-10 09:01:54 +00:00
Nick Mathewson
d893d8c52e r7300@Kushana: nickm | 2006-08-10 01:36:40 -0700 
Distinguish netfilter vs pf at configure time based on headers, not on OS.


svn:r7008
 2006-08-10 09:01:46 +00:00
Nick Mathewson
5cff4164a0 r7299@Kushana: nickm | 2006-08-10 01:08:58 -0700 
Patch from Tup to add support for transparent AP connections: this basically bundles the functionality of trans-proxy-tor into the tor mainline.  Now hosts with compliant pf/netfilter implementations can redirect TCP connections straight to Tor without diverting through SOCKS.


svn:r7007
 2006-08-10 09:01:37 +00:00
Roger Dingledine
8075928b2a a way to make tor more stable in crummy situations 
svn:r7005
 2006-08-10 08:00:54 +00:00
Nick Mathewson
35f0881802 Experimentally re-enable kqueue on OSX when using libevent 1.1b or later. Log when we are doing this, so we can diagnose it when it fails. 
svn:r7004
 2006-08-10 08:00:13 +00:00
Nick Mathewson
f2a0df4d02 Recommend libevent 1.1b for kqueue and win32 methods; deprecate libevent 1.0b harder; make libevent recommendation system saner. 
svn:r7003
 2006-08-10 07:39:47 +00:00
Nick Mathewson
1b7ad5aed3 r7030@Kushana: nickm | 2006-08-04 14:46:52 -0700 
Close an fd leak on failed mmap()


svn:r6988
 2006-08-05 17:53:32 +00:00
Nick Mathewson
7c596c166b r7029@Kushana: nickm | 2006-08-04 14:08:41 -0700 
Remove now-spurious size and data arguments from tor_mmap_file


svn:r6987
 2006-08-05 17:53:21 +00:00
Nick Mathewson
dbac3fb481 r7028@Kushana: nickm | 2006-08-04 13:10:16 -0700 
Make data and size fields visible in tor_mmap_t; hide win magic differently.


svn:r6986
 2006-08-05 17:53:08 +00:00
Nick Mathewson
714d1b66aa r7027@Kushana: nickm | 2006-08-04 13:06:48 -0700 
Oops. Fix downcast macro.


svn:r6985
 2006-08-05 17:52:51 +00:00
Roger Dingledine
bc2e040669 make svn trunk link again. nick can fix this if it's wrong. 
svn:r6982
 2006-08-04 20:30:45 +00:00
Nick Mathewson
db72fb9cdc r7025@Kushana: nickm | 2006-08-04 12:03:22 -0700 
Finish (I hope) windows mmap impl.


svn:r6981
 2006-08-04 19:03:40 +00:00
Nick Mathewson
bf72878cad r7012@Kushana: nickm | 2006-08-03 19:21:25 -0700 
Add an "mmap handle" type to encapsulate bookkeeping elements of mmap issues; add prelim win32 impl


svn:r6980
 2006-08-04 18:32:43 +00:00
Nick Mathewson
abe27b807e svn:r6979 2006-08-04 18:31:13 +00:00
Nick Mathewson
2c33f385f7 r7011@Kushana: nickm | 2006-08-03 13:26:34 -0700 
eventdns: Document functions added to API; make suspended requests go to the front of the queue; check (or explicitly ignore) return values on libevent functions.


svn:r6978
 2006-08-04 18:27:10 +00:00
Nick Mathewson
e8f28a71e8 r7010@Kushana: nickm | 2006-08-03 10:47:36 -0700 
Enable log message format checking in eventdns.c when __GNUC__ is defined.


svn:r6977
 2006-08-04 18:26:40 +00:00
Nick Mathewson
3fa1cdafce r7009@Kushana: nickm | 2006-08-03 10:44:58 -0700 
Add functions to eventdns to allow detecting whether we have any nameservers configured, and to change the list of nameservers after initial configuration.


svn:r6976
 2006-08-04 18:26:13 +00:00
Nick Mathewson
87939813c3 r7008@Kushana: nickm | 2006-08-03 10:03:39 -0700 
Oops. We shouldnt initialize eventdns when we are not being a server and not resolving anything.


svn:r6975
 2006-08-04 18:24:41 +00:00
Nick Mathewson
a122bfb439 r7007@Kushana: nickm | 2006-08-03 09:58:30 -0700 
Export and use eventdns_config_windows_nameservers(); clean up some comments and log messages.


svn:r6974
 2006-08-04 18:24:25 +00:00
Nick Mathewson
19cf66c0f1 Patch from Frediano Ziglio: Windows compilation fixes on eventdns.c. 
svn:r6971
 2006-08-03 07:46:25 +00:00
Roger Dingledine
e64825126b turn future seg faults into asserts 
svn:r6970
 2006-08-03 04:23:45 +00:00
Roger Dingledine
3152d44c3a fix a seg fault on exit for clients; and fix a comment. 
svn:r6969
 2006-08-03 04:22:25 +00:00
Roger Dingledine
74bf8b1289 man, our sample torrc sucked. 
svn:r6964
 2006-08-01 04:08:15 +00:00
Roger Dingledine
ed567c6feb more compile options mean more codepaths 
svn:r6963
 2006-07-31 20:25:57 +00:00
Nick Mathewson
80282d8f55 r6993@Kushana: nickm | 2006-07-31 16:19:21 -0400 
Interesting how much a ! can change the behavior of an assert.


svn:r6962
 2006-07-31 20:19:58 +00:00
Nick Mathewson
b9082682fd r6982@Kushana: nickm | 2006-07-31 13:47:19 -0400 
documentation and naming tweaks in dns.c


svn:r6961
 2006-07-31 18:01:49 +00:00
Nick Mathewson
58c0ac77be r6981@Kushana: nickm | 2006-07-31 13:23:26 -0400 
More asserts for cache correctness.


svn:r6960
 2006-07-31 18:01:45 +00:00
Nick Mathewson
ea0f5ec8ad r6980@Kushana: nickm | 2006-07-31 13:18:22 -0400 
Add a utility function to verify that a string has been through strlower.


svn:r6959
 2006-07-31 18:01:37 +00:00
Nick Mathewson
d934607069 r6979@Kushana: nickm | 2006-07-31 13:16:58 -0400 
Add assert_ok functions for strmap and digestmap; use them in unit test code.


svn:r6958
 2006-07-31 18:01:27 +00:00
Nick Mathewson
3843b1b3d0 r6978@Kushana: nickm | 2006-07-31 13:16:14 -0400 
Add isupper and islower wrappers to compat.h


svn:r6957
 2006-07-31 18:01:22 +00:00
Nick Mathewson
fd0bafb0de r6977@Kushana: nickm | 2006-07-31 13:01:28 -0400 
Solve timing-out pending connections. Add pending resolves to expiry queue; when we find an answer, change the pending resolve to "done" and stick the actual answer in the expiry queue as a new entry.  This uses a little more memory, but makes the code simpler than other solutions.


svn:r6956
 2006-07-31 18:01:18 +00:00
Nick Mathewson
ccf9c1345e svn:r6955 2006-07-31 18:00:47 +00:00
Nick Mathewson
46574319a2 r6959@Kushana: nickm | 2006-07-29 22:33:18 -0400 
start restructuring dns to use priority queues for expiring entries.


svn:r6954
 2006-07-31 18:00:18 +00:00
Nick Mathewson
2fe537c57a r6958@Kushana: nickm | 2006-07-29 18:54:15 -0400 
Looks like we might need a priority queue.


svn:r6953
 2006-07-31 17:59:37 +00:00
Nick Mathewson
8ba913c660 r6952@Kushana: nickm | 2006-07-28 11:09:37 -0400 
Add completely untested find-my-nameservers code for win32.


svn:r6952
 2006-07-31 17:59:11 +00:00
Roger Dingledine
798b580695 fix assert found by DreadWingKnight: now that rendezvous streams 
are attached to p_streams, the p_streams list can consist of both AP
and EXIT conns.


svn:r6945
 2006-07-30 04:54:13 +00:00
Roger Dingledine
2bcb081cb1 defense in depth 
svn:r6939
 2006-07-30 04:32:58 +00:00
Roger Dingledine
c3b79ebf13 a bit more debugging for phobos 
svn:r6937
 2006-07-30 03:34:44 +00:00
Nick Mathewson
84c2a6c16b r6950@Kushana: nickm | 2006-07-28 10:32:08 -0400 
Document split fields better. Now, I think we can take a break from type splitting for a bit.


svn:r6935
 2006-07-28 15:11:28 +00:00
Nick Mathewson
85f381153b r6949@Kushana: nickm | 2006-07-28 10:17:38 -0400 
Shave another 8 bytes from connection_t: turn inbuf_reached_eof into a bit, and lower timestamp_lastempty to or_connection_t


svn:r6934
 2006-07-28 15:11:20 +00:00
Nick Mathewson
6dc13cdbeb r6948@Kushana: nickm | 2006-07-28 10:10:35 -0400 
Identify some likely target fields for lowering; lower global_identifier (since we only use it for AP streams and origin circs).


svn:r6933
 2006-07-28 15:11:11 +00:00
Roger Dingledine
a5e5074807 resolve typo 
svn:r6927
 2006-07-27 19:35:11 +00:00
Nick Mathewson
c2f28615ed More asserts in dns.c 
svn:r6926
 2006-07-27 18:35:56 +00:00
Nick Mathewson
8786b4b88e Fix a bug in HT_REMOVE. 
svn:r6925
 2006-07-27 18:35:25 +00:00
Nick Mathewson
45c3a4365f Get better numbers out of HT_REP_OK 
svn:r6924
 2006-07-27 17:37:37 +00:00
Nick Mathewson
dc2b7e9af0 Add more asserts in dns_found_answer. This may confirm my theory that dns_purge_resolve is the culprit. 
svn:r6922
 2006-07-27 17:16:10 +00:00
Nick Mathewson
5227395aba r6922@Kushana: nickm | 2006-07-26 16:32:24 -0400 
Rename some fields, compress a bitfield, and document some structs and fields


svn:r6919
 2006-07-27 05:03:57 +00:00
Nick Mathewson
dd779d99ea Fix comments that implied that only dir connections had a purpose field, and the code that believed in those comments. 
svn:r6918
 2006-07-27 04:10:51 +00:00
Nick Mathewson
0bc741ba7f r6918@Kushana: nickm | 2006-07-26 15:22:28 -0400 
Fix compilation for eventdns dns.c with split structs.


svn:r6908
 2006-07-26 19:29:30 +00:00
Nick Mathewson
ec82db6995 r6909@Kushana: nickm | 2006-07-26 13:05:58 -0400 
Clean up wide lines from last patch.


svn:r6907
 2006-07-26 19:07:37 +00:00
Nick Mathewson
4ff4577beb r6908@Kushana: nickm | 2006-07-26 12:38:52 -0400 
Refactor connection_t into edge, or, dir, control, and base subtypes.  This might save some RAM on busy exit servers, but really matters most in terms of correctness.


svn:r6906
 2006-07-26 19:07:26 +00:00
Nick Mathewson
18771e851f r6907@Kushana: nickm | 2006-07-25 19:03:43 -0400 
Realign circuit structs to avoid wasted space.


svn:r6905
 2006-07-26 19:07:23 +00:00
Nick Mathewson
e61d28dfb8 r6903@Kushana: nickm | 2006-07-25 18:22:48 -0400 
No circuit can be both an intro point and a rend point, so we can merge both the cookie and the pk digest into one "rend_token" field for or circuits. This saves another 20 bytes per or circuit.


svn:r6904
 2006-07-26 19:05:41 +00:00
Nick Mathewson
a88ec48a39 r6902@Kushana: nickm | 2006-07-25 17:30:27 -0400 
Move rend_query to origin_circuit_t where it belongs; save another 17 bytes per OR circuit.


svn:r6903
 2006-07-26 19:05:34 +00:00
Nick Mathewson
96bcbb1e1c Remove code to special-case "-cvs" ending, since it has not actually mattered since 0.0.9. Perhaps we can special-case even more... 
svn:r6898
 2006-07-25 04:34:14 +00:00
Peter Palfrader
521c006fd5 Remove .cvsignore files from trunk 
svn:r6891
 2006-07-25 01:00:48 +00:00
Roger Dingledine
c9b8458f59 publish a new descriptor after we hup. this is important if our 
config has changed such that we'll want to start advertising our
dirport now, etc.


svn:r6819
 2006-07-23 11:50:03 +00:00
Nick Mathewson
d27cbf5d4b Fix another segfault in assert_circuit_ok. 
svn:r6818
 2006-07-23 08:13:45 +00:00
Nick Mathewson
7239262f71 Don't tell anybody, but we're going OO here. This patch splits 
circuit_t into origin_circuit_t and or_circuit_t.  I fixed some
segaults; there may be more.  We still need to move more rendezvous
stuff into subtypes.

This is a trial run for splitting up connection_t; if the approach is
insane, please say so soon so we can do something smarter.

Also, this discards the old HALF_OPEN code, which nobody seems to
want.


svn:r6817
 2006-07-23 07:37:35 +00:00
Nick Mathewson
6d2eb77555 Whitespace fix 
svn:r6816
 2006-07-23 07:19:49 +00:00
Roger Dingledine
40cc536307 rewrite conn->address for GET commands as well as POST commands. 
svn:r6815
 2006-07-23 06:41:02 +00:00
Roger Dingledine
0b5ad1bcfb use tor_mem_is_zero() in more places. 
svn:r6814
 2006-07-23 05:52:27 +00:00
Nick Mathewson
4280218a42 Delete trailing whitespace in eventdns.c 
svn:r6813
 2006-07-23 05:40:24 +00:00
Nick Mathewson
1c0f02f657 Add (void) lines for unused parameters in eventdns.c 
svn:r6812
 2006-07-23 05:39:37 +00:00
Nick Mathewson
f4e506f423 Remove STRUCT_OFFSET from config.c 
svn:r6811
 2006-07-23 05:33:10 +00:00
Nick Mathewson
35960e1162 Add a mem_is_zero function (I think we will need this) and a STRUCT_OFFSET macro (we already need this). 
svn:r6810
 2006-07-23 05:32:35 +00:00
Roger Dingledine
ee789052b8 whitespace and docs 
svn:r6808
 2006-07-23 05:18:29 +00:00
Roger Dingledine
00aefaab6b think harder about my logic 
svn:r6806
 2006-07-22 07:19:11 +00:00
Roger Dingledine
2d6a4d283b i lied, that won't work at all. maybe this will. 
svn:r6805
 2006-07-22 07:15:34 +00:00
Roger Dingledine
444f096d2d more bulletproof reachability testing 
svn:r6804
 2006-07-22 05:29:31 +00:00
Nick Mathewson
64c14d8ce3 These asserts will either cause spurious crashes or help debug the pend->conn->s == -1 issue. 
svn:r6803
 2006-07-21 22:02:58 +00:00
Nick Mathewson
08a4114abf Another MSVC6 fix. Grnk. 
svn:r6802
 2006-07-21 14:53:23 +00:00
Roger Dingledine
2249180b60 bugfix: if you find yourself reachable, then don't ever make any client 
requests (so you stop predicting circuits), then hup, then later your
IP changes, you won't think circuits are working so you won't try to
test reachability, so you won't publish.


svn:r6800
 2006-07-21 07:55:35 +00:00
Roger Dingledine
4d5fab4f9a tweak 
svn:r6799
 2006-07-21 07:53:21 +00:00
Roger Dingledine
9283ddb760 an entry guard that is "unlisted", as well as not known to be "down", is 
not therefore "up".


svn:r6798
 2006-07-21 07:06:18 +00:00
Roger Dingledine
237c7ecbfd tweak 
svn:r6796
 2006-07-20 23:45:26 +00:00
Roger Dingledine
97a14b2018 tweak 
svn:r6795
 2006-07-20 23:33:11 +00:00
Roger Dingledine
db657ea0af don't squeal if the first few retries fail. 
svn:r6791
 2006-07-18 04:48:59 +00:00
Roger Dingledine
892f671f59 Define a schedule for how long to wait between retrying 
application connections. Rather than waiting a fixed amount of
time between each retry, we wait only 5 seconds for the first,
10 seconds for the second, and 15 seconds for each retry after
that. Hopefully this will improve the expected experience.

Addresses bug 297.


svn:r6790
 2006-07-18 04:42:32 +00:00
Roger Dingledine
e1f30a5f21 when we find our dirport to be reachable, mark our descriptor 
dirty so we'll tell the world. (fixes bug 306 reported by pnx)


svn:r6787
 2006-07-18 03:06:55 +00:00
Roger Dingledine
ac258d2cc8 Start publishing one minute or so after we find our ORPort 
to be reachable. This will help reduce the number of descriptors
we have for ourselves floating around, since it's quite likely
other things (e.g. DirPort) will change during that minute too.


svn:r6786
 2006-07-18 03:06:12 +00:00
Nick Mathewson
7fcb267e24 Oh. And apparently, msvc6 doesnt think very much of doing u64-and-double arithmetic either. 
svn:r6785
 2006-07-18 02:24:01 +00:00
Nick Mathewson
77c28d112b Hm. We probably should define INT64_MAX if we really want it. (Especially since we only want it on one platform, where, coincidentally, it is not defined.) 
svn:r6784
 2006-07-18 02:01:32 +00:00
Roger Dingledine
388ac4126a If we are using an exit enclave and we can't connect, e.g. because 
its webserver is misconfigured to not listen on localhost, then back
off and try connecting from somewhere else before we fail.


svn:r6783
 2006-07-18 00:59:46 +00:00
Roger Dingledine
a8444c6f53 pick a log domain; resolve an xxxx 
svn:r6782
 2006-07-18 00:01:12 +00:00
Roger Dingledine
c85745cfe2 parameterize the loudness of log_addr_has_changed(), since it's the 
only place where we inform the user of a new IP address, if we're
guessing it from external sources.


svn:r6780
 2006-07-17 19:33:54 +00:00
Roger Dingledine
542adb88d7 Make a louder statement the first time we learn a guessed 
IP address.


svn:r6779
 2006-07-17 08:17:51 +00:00
Roger Dingledine
c055a34cdb huge bugfix: we weren't ever writing an http header when sending 
out network statuses! so clients were downloading the whole thing,
and then discarding them because they're malformed.


svn:r6778
 2006-07-17 08:11:27 +00:00
Roger Dingledine
a2a89da693 and don't try to build the descriptor every second, if it's dirty 
but we don't have a known address.


svn:r6777
 2006-07-17 06:59:56 +00:00
Roger Dingledine
42e2057d67 fix some more places where we shouldn't crash if we can't build 
our own descriptor yet.


svn:r6775
 2006-07-17 06:54:28 +00:00
Roger Dingledine
9db7b2c068 Allow servers with no hostname or IP address to learn their IP address 
by asking the directory authorities. This code only kicks in when you
would normally have exited with a "no address" error.

This design is flawed, though, since the X-Your-Address-Is header is not
authenticated, and doing it this way introduces too many new attacks. The
right answer is to give IP address hints inside the HELLO cell; much of
this code can be reused when we switch.


svn:r6774
 2006-07-17 06:35:06 +00:00
Nick Mathewson
e572d5990c MSVC6 is apparently terrified of unnatural cross-breeding between uint64_t and double, and needs more persuasion than usual to cast one to the other. Issue identified by Frediano Ziglio; patch revised for minimal impact on non-MSVC6 compilers. 
svn:r6768
 2006-07-17 00:39:05 +00:00
Roger Dingledine
886b10bbe2 whitespace/etc cleanups 
svn:r6765
 2006-07-16 05:57:11 +00:00
Roger Dingledine
ee5f512e13 parameterize the loudness of resolve_my_address(), and call things 
IP addresses, not IPs.


svn:r6764
 2006-07-15 20:26:05 +00:00
Roger Dingledine
3d79eb52ab stick to nick's nul/null convention 
svn:r6763
 2006-07-15 19:21:30 +00:00
Roger Dingledine
c4411841d2 Avoid an integer underflow when the dir authority decides whether a 
router is stable: we might wrongly label it stable, and compute a slightly
wrong median stability, when a descriptor is published later than now.

Inspired by Matt's Vidalia checkin:
http://trac.vidalia-project.net/changeset/1074


svn:r6758
 2006-07-14 03:14:02 +00:00
Nick Mathewson
a0cf95e1c9 Add some debugging asserts to dns.c; these are too expensive to leave in permanently. 
svn:r6756
 2006-07-11 20:51:58 +00:00
Nick Mathewson
c32e19b4ed OR_CONN_EVENT_NEW: we should probably handle that , should we not? Especially since 23:26 < phobos> nickm: grep -c "Unrecognized status code 4" tor.log 
svn:r6752
 2006-07-11 03:33:16 +00:00
Nick Mathewson
39344fc301 Add a const; fix a (probably harmless) bug when storing a resolve we forgot we asked for. 
svn:r6751
 2006-07-10 18:38:57 +00:00
Nick Mathewson
28a7c8a64c Make compilation work on old MSVCs without GetVertsionEx magic. Patch from Frediano Ziglio. 
svn:r6749
 2006-07-09 22:29:12 +00:00
Nick Mathewson
a7a1d4e3d3 First part of making mmap-based stuff work on win32: save descriptors as "binary" (no LF->CRLF tanslation) so that we can mmap them properly later. Patch from Frediano Ziglio. 
svn:r6748
 2006-07-09 22:28:12 +00:00
Roger Dingledine
51454157a0 Fix a crash if you enable FascistFirewall but not FirewallPorts. 
Reported by Frediano Ziglio.


svn:r6746
 2006-07-08 17:38:46 +00:00
Nick Mathewson
0bbc4aca9b Spellcheck and remove spurious include in eventdns.c 
svn:r6745
 2006-07-07 19:08:44 +00:00
Nick Mathewson
a40ad152b1 When using eventdns: suppress logging of addresses when SafeLogging is active, and make set of nameservers configurable from torrc. 
svn:r6744
 2006-07-07 17:33:30 +00:00
Nick Mathewson
f33c4f9781 eventdns: check for malloc() failures. 
svn:r6743
 2006-07-07 17:31:56 +00:00
Roger Dingledine
85fd582192 rename X-You-Are to something slightly better. 
svn:r6735
 2006-07-06 03:05:01 +00:00
Roger Dingledine
7f01dc9c1c whitespace/tab fixes 
svn:r6734
 2006-07-06 02:45:46 +00:00
Roger Dingledine
fad85f173a when an exit node gets a malformed begin cell, don't complain to 
the node operator, since he can't do anything about it.


svn:r6733
 2006-07-06 02:44:07 +00:00
Nick Mathewson
3c4205c872 Clean up eventdns messages. 
svn:r6730
 2006-07-05 21:42:18 +00:00
Nick Mathewson
54779025e2 Spelling fix. 
svn:r6729
 2006-07-05 21:33:46 +00:00
Nick Mathewson
42ef3bd90c Add plausile logging support to eventdns; stop putting stuff onto stdout. 
svn:r6728
 2006-07-05 21:28:37 +00:00
Roger Dingledine
0ec293b189 actually, that excludenodes fix was redundant. take it out. 
svn:r6727
 2006-07-05 18:19:42 +00:00
Roger Dingledine
98c6bf6192 oops, we were ignoring options->ExcludeNodes when picking entry guards. 
it is still the case that we ignore it with respect to entry guards
that we've already picked.


svn:r6726
 2006-07-04 20:25:17 +00:00
Roger Dingledine
4fc7426b93 Make the X-You-Are header more accurate when there's a proxy in the middle. 
svn:r6722
 2006-07-04 18:18:08 +00:00
Roger Dingledine
12cc290a7d ok, i'm not allowed to say that there. oh well. 
svn:r6720
 2006-07-04 16:11:35 +00:00
Roger Dingledine
579849f600 fix a misleading function comment 
svn:r6717
 2006-07-04 15:52:22 +00:00
Roger Dingledine
5dc1e6f788 if we're the server-side of the tls and there are problems, 
don't yell as loudly.


svn:r6716
 2006-07-04 15:51:59 +00:00
Roger Dingledine
05d0b70573 Get rid of the router_retry_connections notion. Now routers no longer 
try to rebuild long-term connections to directory authorities, and
directory authorities no longer try to rebuild long-term connections to
all servers.

We still don't hang up connections in these two cases though -- we need
to look at it more carefully to avoid flapping, and we likely need to
wait til 0.1.1.x is obsolete.


svn:r6712
 2006-07-04 03:31:27 +00:00
Roger Dingledine
ff1b4764e9 No longer permit create cells to have the wrong circ_id_type. No 
running Tors should still have this bug.


svn:r6711
 2006-07-04 03:27:09 +00:00
Roger Dingledine
35e95d7783 minor fixes 
svn:r6710
 2006-07-04 03:25:07 +00:00
Roger Dingledine
dc79dd6a46 minor fixes 
svn:r6709
 2006-07-04 03:19:59 +00:00
Nick Mathewson
9fce316d1c Oops. Headers work better when named right. 
svn:r6707
 2006-07-01 21:51:21 +00:00
Nick Mathewson
60de51993a Unify HTTP response code into one place so it is easier to add headers. Add an X-You-Are header, which we should probably rename. NOTE that we should not use this field for things where it matters if dirs lie. 
svn:r6705
 2006-06-30 10:50:43 +00:00
Roger Dingledine
d45757ebcb also remove word 'middleman' from a log notice 
svn:r6704
 2006-06-29 13:11:23 +00:00
Roger Dingledine
1f407c174d remove the word 'middleman' from the sample torrc 
svn:r6703
 2006-06-29 13:10:08 +00:00
Nick Mathewson
475eb5d6fe Apparent 311 fix: apparently passing Z_FINISH an empty string is problematic. 
svn:r6702
 2006-06-29 11:19:52 +00:00
Nick Mathewson
05eff35ac6 Harmless: Z_OK is not an acceptable answer to Z_FINISH. 
svn:r6701
 2006-06-29 11:17:36 +00:00
Nick Mathewson
4b49d298eb complete_only == !allow_partial. This enables useful use of partial desc downloads. Backport candidate 
svn:r6700
 2006-06-29 11:04:42 +00:00
Roger Dingledine
c22c7b96f5 tab-man strikes again 
svn:r6699
 2006-06-28 15:39:02 +00:00
Nick Mathewson
8b08ab52fd Fix another idiot bug causing symptom 309. Why cant I program? 
svn:r6698
 2006-06-28 15:36:28 +00:00
Nick Mathewson
96bfefeeb6 Add a check to try to make cache rebuild fail fast if it is going to fail 
svn:r6697
 2006-06-28 11:03:34 +00:00
Nick Mathewson
4dac383f5a Aaand re-disable the bogus test in get_body() 
svn:r6696
 2006-06-28 08:57:41 +00:00
Nick Mathewson
d547ecc916 Make sure that our calculated offsets for routers is correct; again. This time bug 309 may be gone gone gone. 
svn:r6695
 2006-06-28 08:55:53 +00:00
Nick Mathewson
1cd04abf1a Actually enable mmap. That should improve matters. 
svn:r6694
 2006-06-28 08:54:32 +00:00
Nick Mathewson
d3784ff1df Likely fix for bug 309: when we calculate offsets after rebuilding the descriptor cache, do not reset the offset pointer half-way through. 
svn:r6693
 2006-06-27 15:52:51 +00:00
Roger Dingledine
f88d555ce0 refuse to write an iso_time which we can't parse, when dumping 
bandwidth state. this fixes the particular incident in bug 308,
but the general issue remains.


svn:r6684
 2006-06-24 04:57:59 +00:00
Nick Mathewson
b4b8da5d23 Turn a while into a do/while; save a redundant test 
svn:r6683
 2006-06-24 02:10:21 +00:00
Nick Mathewson
06e09cdd47 Apparently, zlib sometimes reports Z_BUF_ERROR on input exhaustion as well as on running out of output space. This could well fix the assert bug reported by weasel and arma. 
svn:r6682
 2006-06-24 02:06:52 +00:00
Nick Mathewson
b82dfdd4a3 Make some more verbose gcc warnings go away. 
svn:r6680
 2006-06-22 07:34:04 +00:00
Nick Mathewson
06ffee3b67 Ooh, that could have been bad. Sort digests as digests, not strings. 
svn:r6679
 2006-06-22 07:29:14 +00:00
Nick Mathewson
52b8dfa95a Fix a bunch of spaces. 
svn:r6678
 2006-06-22 07:25:15 +00:00
Nick Mathewson
89a1453776 Set offset properly when parsing cache. 
svn:r6677
 2006-06-22 07:19:28 +00:00
Nick Mathewson
58b05fc84d #if out test that was failing because of an extra newline. 
svn:r6676
 2006-06-22 07:10:37 +00:00
Nick Mathewson
b7910202a3 Next batch of memory miserdom: mmap cached-routers file. This is sure to break somewhere. 
svn:r6675
 2006-06-22 07:01:54 +00:00
Nick Mathewson
e2697a62ac When requesting or serving resources via fingerprint/digest, request and respond in-order, removing duplicates. 
svn:r6673
 2006-06-21 04:57:12 +00:00
Peter Palfrader
7b6c435066 <nickm> ooh, that log shouldn't be there. can you take it out? 
svn:r6671
 2006-06-20 23:11:15 +00:00
Nick Mathewson
0799154ae1 Fix bug in networkstatus spooling: spool more than the first networkstatus. 
svn:r6670
 2006-06-20 23:06:52 +00:00
Nick Mathewson
0e09b26112 Fishy, but harmless. 
svn:r6669
 2006-06-20 16:48:32 +00:00
Roger Dingledine
ef78e4245f add a note for nick to fix 
svn:r6668
 2006-06-20 13:14:07 +00:00
Nick Mathewson
a9e1a4c33c Ah. We need a new zlib_state for each networkstatus we spool out. 
svn:r6667
 2006-06-20 06:27:13 +00:00
Nick Mathewson
4283b81a48 Start spooling v2 networkstatus docs as well. 
svn:r6664
 2006-06-20 00:48:23 +00:00
Nick Mathewson
3f7f069a05 Fix a tricky crash: making the_directory heap-allocated (so we could refcount it and have multiple instances as neeeded) means that calls to dirserv_regenerate_directory could invalidate the auth_dir value passed to dirserv_pick_cached_dir_obj. Big fun. 
svn:r6663
 2006-06-18 21:30:03 +00:00
Nick Mathewson
2552d5e60f Fix an assert that still isnt the assert we are hunting. 
svn:r6662
 2006-06-18 21:15:01 +00:00
Roger Dingledine
37c441d96f correct a function comment in compute_preferred_testing_list() 
svn:r6660
 2006-06-18 21:07:45 +00:00
Nick Mathewson
f1993b8b30 Become capable of noticing that we are done sending a directory. 
svn:r6659
 2006-06-18 20:58:27 +00:00
Nick Mathewson
5c0d7fb016 Resolve control flow warning. 
svn:r6658
 2006-06-18 20:39:46 +00:00
Nick Mathewson
0932f463ff Ah. That seems to work. 
svn:r6657
 2006-06-18 16:39:26 +00:00
Nick Mathewson
5ba72d0ae5 another write_to_buf_zlib fix. 
svn:r6656
 2006-06-18 16:20:38 +00:00
Nick Mathewson
b5c599412f Backport candidate: implement the "is this uptime change cosmetic" test properly. 
svn:r6654
 2006-06-18 16:05:54 +00:00
Nick Mathewson
a9cffd2ff0 Re-enable buffer RAM guard values. 
svn:r6653
 2006-06-18 15:53:54 +00:00
Nick Mathewson
11c2e97d51 Another _zlib fix. 
svn:r6652
 2006-06-18 09:03:48 +00:00
Nick Mathewson
337ad6420b Make connection_write_to_buf_zlib set outbuf_flushlen right. 
svn:r6651
 2006-06-18 08:53:09 +00:00
Nick Mathewson
537104c908 write_to_buf != connection_write_to_buf. Also, add a connection_write_to_buf_zlib wrapper that sucks. 
svn:r6650
 2006-06-18 08:46:55 +00:00
Nick Mathewson
10b7b57616 Temporarily disable sentinels on buffers 
svn:r6649
 2006-06-18 08:44:34 +00:00
Nick Mathewson
9376d901ed make zlib buffer function set buf_highwater properly 
svn:r6648
 2006-06-18 08:21:27 +00:00
Nick Mathewson
4d02ccfed8 Stop trying to refresh when we are out of data. 
svn:r6647
 2006-06-18 08:19:35 +00:00
Nick Mathewson
b9013cbe98 And actually check the url when it exists. that might work better. 
svn:r6646
 2006-06-18 08:16:05 +00:00
Nick Mathewson
c374340c70 That dir_refresh_src fix will only work if I enable it. 
svn:r6645
 2006-06-18 08:13:45 +00:00
Nick Mathewson
347bcec84a Fix a couple of bugs in last patch. 
svn:r6644
 2006-06-18 08:07:16 +00:00
Nick Mathewson
c58cc8c16c add coverage for a default case 
svn:r6643
 2006-06-18 07:57:47 +00:00
Nick Mathewson
b1a8b7869a Oops. conn->requested_resource is client only. 
svn:r6642
 2006-06-18 07:55:04 +00:00
Nick Mathewson
1d9923da7c Instead of adding servers and v1 directories to buffers en masse, directory servers add them on the fly as their outbufs are depleted. This will save ram on busy dirservers. 
svn:r6641
 2006-06-18 07:38:55 +00:00
Nick Mathewson
73ada60d64 remove non-germane comment 
svn:r6640
 2006-06-18 07:37:21 +00:00
Nick Mathewson
8fa8616ec7 Add tests for several of the more recently committed functions. 
svn:r6639
 2006-06-18 07:35:10 +00:00
Nick Mathewson
f83a628a76 perhaps the reason I rail against cut-and-paste programming so vehemently is that I am so bad at it. 
svn:r6638
 2006-06-18 07:32:31 +00:00
Nick Mathewson
cd38511a1e Part of incremental encryption logic for buffers: there is a subtle yucky point documented in a comment. 
svn:r6637
 2006-06-18 07:27:47 +00:00
Nick Mathewson
630e9cd510 Add some incremental encryption wrappers to torgzip code 
svn:r6636
 2006-06-18 07:24:29 +00:00
Nick Mathewson
af8096815e Add a memdup function to util 
svn:r6635
 2006-06-18 07:22:36 +00:00
Nick Mathewson
78428dccdb Add smartlist_reverse and smartlist_pop_last. 
svn:r6634
 2006-06-18 07:21:35 +00:00
Peter Palfrader
2ff24dbc26 And a minor bugfix to the weaselhack 
svn:r6629
 2006-06-15 23:14:01 +00:00
Roger Dingledine
af0e47c921 fix spacing 
svn:r6628
 2006-06-15 22:59:07 +00:00
Peter Palfrader
bc64becd12 Add a /tor/dir-all-weaselhack directory resource so I do not have to update my scripts 
svn:r6627
 2006-06-15 22:52:56 +00:00
Roger Dingledine
a4c315f3c3 fix recommended url in torrc.sample for server sign-up 
svn:r6626
 2006-06-15 22:32:00 +00:00
Roger Dingledine
4e4cc9aa27 lower the number of seconds before we yell about clock jump. 
and make the yelling only happen if you're a server.


svn:r6625
 2006-06-15 09:03:15 +00:00
Roger Dingledine
de7a9c83d8 upgrade the severity of the 'clock jump' warn, and ask people 
to report if it occurs.


svn:r6623
 2006-06-14 22:28:16 +00:00
Roger Dingledine
09dfe1b265 bugfix: discourage picking directory authorities as our TestVia 
hops, even if they're running the right versions, since we probably
already have a connection established to them.


svn:r6622
 2006-06-14 11:06:43 +00:00
Nick Mathewson
66db3afb74 eventdns: Apply a couple of patches from AGL; start working on windows compat; note some TODOs. 
svn:r6621
 2006-06-13 21:49:56 +00:00
Roger Dingledine
977574e48d back off and add the $ at the beginning of the preferrednodes list 
we generate.


svn:r6620
 2006-06-13 12:57:19 +00:00
Roger Dingledine
2cd349903c be more lax about recognizing valid hexdigests. 
svn:r6619
 2006-06-13 12:05:59 +00:00
Roger Dingledine
b4e415ba3c now we can tell dirserv_dump_directory_to_string() whether we want 
it to include down/invalid descriptors or not.


svn:r6618
 2006-06-13 11:11:19 +00:00
Roger Dingledine
88dadc917c bugfix in exit_policy_is_general_exit() that weasel found. 
this time for sure!


svn:r6617
 2006-06-13 10:48:26 +00:00
Roger Dingledine
23e2c6a7dd first cut at a workaround for the reachability bug: explicitly find a 
server running the right version, if we can, and ask for that one.


svn:r6616
 2006-06-13 10:25:22 +00:00
Roger Dingledine
31b51849b5 export the default exit policy via the control port, so controllers 
don't need to guess what it is / will be later.


svn:r6615
 2006-06-13 09:16:09 +00:00
Roger Dingledine
279e86f3c8 Defense in depth: fix the reachability bug a second way too. 
Now if we establish a connection with the right digest, regardless
of what the addr/port is, and we have pending create cells, use it.


svn:r6614
 2006-06-13 05:51:28 +00:00
Roger Dingledine
a20a384b09 harmless typo 
svn:r6613
 2006-06-13 05:50:24 +00:00
Roger Dingledine
ab61c40661 Fix the bug that was causing servers to not find themselves 
reachable if they changed IP addresses. This happened because
middle servers knew the old descriptor, and kept swapping the
addr/port we asked for with the one they thought was right.

So the create cell never got sent, because it was asking for a
different addr/port than we believed we had connected to.


svn:r6610
 2006-06-13 05:36:35 +00:00
Roger Dingledine
19408cf8d7 reintroduce the logic to exit_policy_is_general_exit() to count 
how many ports are allowd. require two ports open, not just one.


svn:r6609
 2006-06-13 02:48:06 +00:00
Peter Palfrader
cce8ae1190 Make the Exit tag in status documents actually work in head too 
svn:r6608
 2006-06-12 22:03:25 +00:00
Roger Dingledine
87e3800dfc Finally solve the "closing wedged cpuworkers" bug. Woo. 
This happened when we got two create cells in a row from the same TLS
connection. It would hand one to the cpuworker, and then immediately
handle the second one -- after it had registered that the first one was
busy, but before it had updated the timestamp that we use to decide how
*long* it's been busy.


svn:r6606
 2006-06-12 11:59:19 +00:00
Roger Dingledine
cbc4cd93ac allow people to start their tor with runasdaemon set but 
with no logs set at all.


svn:r6604
 2006-06-12 06:03:15 +00:00
Roger Dingledine
14687fc443 take out the reachability bandaid in 0.1.2.x as well. 
maybe we will actually be able to fix it, instead.


svn:r6585
 2006-06-10 00:57:12 +00:00
Roger Dingledine
889b8d5bac Add a new config option TestVia, that lets you specify preferred middle 
hops to use for testing circuits. Perhaps this will let me debug the
reachability problem better.


svn:r6581
 2006-06-10 00:26:39 +00:00
Nick Mathewson
1f585987c4 Another escape() fix, for picky sprintfs. 
svn:r6579
 2006-06-09 17:07:22 +00:00
Nick Mathewson
2936da4c28 Override our notion of printability for esc_for_log. 127 and up are never printable. Take that, locales. 
svn:r6578
 2006-06-09 15:57:58 +00:00
Roger Dingledine
6531a31aad actually, don't fix it that far. we should still do some 
error checking.


svn:r6576
 2006-06-09 09:07:59 +00:00
Roger Dingledine
0071d67efd when only one router is labelled as a guard, and we've 
already picked him, we would cycle endlessly picking him
again, being unhappy about it, and so forth.

now we specifically exclude guards when picking a new guard.


svn:r6575
 2006-06-09 09:02:32 +00:00
Roger Dingledine
30f6c57fd7 and forward-port too. 
svn:r6573
 2006-06-09 06:52:49 +00:00
Roger Dingledine
85d408a573 Bandaid for a seg fault i just got in 0.1.1.20. 
More generally, i reopened bug 222. Whee.


svn:r6571
 2006-06-09 06:35:45 +00:00
Roger Dingledine
a91be49402 fix a bootstrapping check we ignored that prevents us from running 
with only one dir authority.


svn:r6570
 2006-06-09 02:45:39 +00:00
Roger Dingledine
11dcb7f4ae try a better string at the top of torrc's autogenerated torrc. 
svn:r6569
 2006-06-09 02:20:42 +00:00
Roger Dingledine
bb18168fae ok, ok, maybe *this* time my rep_hist_circbuilding_dormant() will work. 
svn:r6568
 2006-06-08 22:36:13 +00:00
Roger Dingledine
18eb8192db remove a bit more obsolete code 
svn:r6566
 2006-06-08 09:35:20 +00:00
Roger Dingledine
a18766e50c ah, that explains why we weren't going dormant with 
respect to descriptor fetches. maybe now it will work.


svn:r6565
 2006-06-08 09:20:58 +00:00
Roger Dingledine
91bd12c20d re-enable per-connection rate limiting. get rid of the "OP bandwidth" 
concept. lay groundwork for "bandwidth classes" -- separate global
buckets that apply depending on what sort of conn it is.


svn:r6563
 2006-06-07 09:18:53 +00:00
Roger Dingledine
741b11df45 put a bandaid in place so servers will have an easier time 
believing that they're reachable. this may help resolve the
servers-on-dynamic-ip-addresses problem.


svn:r6561
 2006-06-07 08:42:24 +00:00
Roger Dingledine
1e9b35aee3 make connection_or_nonopen_was_started_here() based on something less 
voodooey. it turns out we already do keep a flag like that around.


svn:r6560
 2006-06-07 07:11:42 +00:00
Roger Dingledine
8cf45df230 and now the exciting part: there is now no such thing as doing 
a client-only tls, that is, one with no certs.


svn:r6558
 2006-06-07 06:21:11 +00:00
Roger Dingledine
0bfef523df simplify the tortls api: we only support being a "server", that 
is, even tor clients do the same sort of handshake.

this has been true for years, so it's best to get rid of the
stale code.


svn:r6557
 2006-06-07 06:10:54 +00:00
Roger Dingledine
7512be0b65 looks like we missed a piece of the 0.1.1.9 paranoia code. 
hopefully this change is a no-op.


svn:r6556
 2006-06-07 02:57:23 +00:00
Roger Dingledine
96914760bc fix the bug where we sometimes would fail to send some create cells 
once we'd connected to a(nother) tor server.


svn:r6552
 2006-06-06 03:33:24 +00:00
Nick Mathewson
5e4b4451ec Also, add a temporary hack to make sure eventdns.c is distributd. 
svn:r6551
 2006-06-06 00:12:22 +00:00
Roger Dingledine
5c57348acd We got an obscure report of an assert error on a windows Tor server with 
connection_add being called with socket = -1. The only places I can see
where that happen would be if our tor_socketpair succeeds but it hands
back negative values for some of its file descriptors. Perhaps this will
produce more useful assert errors next time.


svn:r6550
 2006-06-06 00:06:52 +00:00
Roger Dingledine
411f37d534 fix typo 
svn:r6549
 2006-06-06 00:05:39 +00:00
Roger Dingledine
07c35b4f52 ship the event*.h files too. perhaps this will make my 'make dist' 
produce a tarball that i can build.


svn:r6548
 2006-06-06 00:04:52 +00:00
Nick Mathewson
2bd7c19b73 Try to log useful messages at info and debug about what we are resolving and what answers we are getting wrt eventdns. 
svn:r6547
 2006-06-05 23:01:22 +00:00
Roger Dingledine
542b8af592 don't tell people that the testing circuit failed if we already 
consider ourselves reachable. this just confuses them.


svn:r6546
 2006-06-05 10:01:52 +00:00
Roger Dingledine
a2fec314b6 scream louder if you've got a pending circuit for a given 
addr/port but the intended n_conn digest is wrong.


svn:r6544
 2006-06-05 09:47:19 +00:00
Roger Dingledine
45065f1466 simplify code now that libevent considers all sockets pollable. 
what we really mean now is ">= 0", which is clearer to test for.


svn:r6543
 2006-06-05 09:08:10 +00:00
Roger Dingledine
4e773352c2 bugfix: if we are making our first ever connection to any entry 
guard, then don't mark it down at first. we had this implemented
but it was disabled due to a bug.


svn:r6541
 2006-06-05 08:58:18 +00:00
Roger Dingledine
8f3bb66ebc simplify some code, since circuit_build_failed() is only called 
on non-open circuits.


svn:r6540
 2006-06-05 08:25:02 +00:00
Roger Dingledine
152d6d13b4 remove some unused code (i think) 
svn:r6539
 2006-06-05 08:02:04 +00:00
Roger Dingledine
bf09898f79 Note a bug that causes servers to sometimes never send the pending 
create cell. Nick, is this a bug? If so, is my fix right?


svn:r6538
 2006-06-05 07:27:48 +00:00
Roger Dingledine
266afcd7d5 bandaid for bug 299. this is still a bug, since we don't 
initialize for hardware acceleration in certain configurations;
but not critical until that is supported.


svn:r6536
 2006-06-05 04:29:03 +00:00
Nick Mathewson
b7ca697faf More eventdns.c patches: use HAVE_ALLOCA_H; print IP addrs as dotted quads. 
svn:r6535
 2006-06-05 01:59:12 +00:00
Nick Mathewson
3db785ef73 Hm. Where did we put that ntohl the last time we were juggling it? (hoop-lah). 
svn:r6534
 2006-06-05 00:32:31 +00:00
Nick Mathewson
008a0c7c46 Some eventdns.c fixes for windows correctness. More will doubtless be needed, especially around the #includes. 
svn:r6533
 2006-06-04 23:23:53 +00:00
Nick Mathewson
853e2d99b6 Add a new warning to our "warn a lot" list: unused parameters. This means we have to explicitly "use" unuseds, but it can catch bugs. (It caught two coding mistakes so far.) 
svn:r6532
 2006-06-04 22:42:13 +00:00
Roger Dingledine
c4647545a0 if we insist on printing pointer values, at least make it stop 
complaining on (my particular) 64 bit platform.


svn:r6530
 2006-06-04 06:17:32 +00:00
Roger Dingledine
603b09b59b punctuation and spelling 
svn:r6529
 2006-06-04 06:16:20 +00:00
Nick Mathewson
c18fab5366 Make eventdns.[ch] into good C90; remove signed/unsigned comparisons. 
svn:r6528
 2006-06-03 22:05:23 +00:00
Nick Mathewson
2700e5a1ab Oops. When we dont get a TTL, we should default to the default, not to the minimum. 
svn:r6527
 2006-06-03 21:47:26 +00:00
Nick Mathewson
c660a0f6a2 More DNS fixes. Send meaningful TTLs back to the client when 
possible.  Cache at the server side independently from the TTL, to
prevent attackers from probing the server to see who has been asking
for what hostnames.  (Hi, Dan Kaminski!)

Also, clean some whitespace.


svn:r6526
 2006-06-03 21:41:14 +00:00
Nick Mathewson
85a25c8a29 Make dns.c use eventdns.c -- but only when you pass the --enable-eventdns argument to configure.in. This will *so* not work on Windows yet. 
svn:r6525
 2006-06-03 20:52:24 +00:00
Nick Mathewson
7cb3232ade Add async dns code from Adam Langley, tweaked to build on OSX. Long-term, we may want to switch to libevnet/c-ares, if they ever handle 10k fd situations properly. This one still needs work too, but at least it is small. This code is disabled by default, and not integrated with dns.c. 
svn:r6524
 2006-06-03 19:49:42 +00:00
Nick Mathewson
86da3e0a0a Patch based on post by Mike C to or-dev; special-case based on use of MSVC, rather than on MS_WINDOWS, so that mingw builds. 
svn:r6523
 2006-06-03 18:52:31 +00:00
Roger Dingledine
8f902e4b58 don't stop fetching server descriptors if we're a server and 
haven't found ourselves reachable yet.


svn:r6522
 2006-06-03 02:56:44 +00:00
Roger Dingledine
1bf0f99b66 connection_t kept the identity_pkey but all it did was store it and 
free it. perhaps we don't need it after all?


svn:r6518
 2006-05-30 06:23:44 +00:00
Roger Dingledine
9000a5aff1 and get grammar right 
svn:r6517
 2006-05-30 06:19:48 +00:00
Roger Dingledine
ae2648fb1c stop fetching descriptors if we're not a dir mirror and we 
haven't tried to establish any circuits lately.


svn:r6516
 2006-05-30 06:19:06 +00:00
Roger Dingledine
1f0e20806b END_CIRC_REASON_OR_IDENTITY apparently means that we were told to 
connect to a different OR than lives on the addr:port we connected
to. we don't actually remember whether that was the case, currently.
so call it END_CIRC_REASON_OR_CONN_CLOSED as a compromise.


svn:r6515
 2006-05-30 06:17:28 +00:00
Roger Dingledine
60abe23158 tentative change: if you have your dirport set, you are a directory 
mirror, whether or not your orport is set.


svn:r6513
 2006-05-30 06:11:36 +00:00
Roger Dingledine
1e4923652b simplify a log message 
svn:r6512
 2006-05-30 05:29:03 +00:00
Nick Mathewson
64d487a2d6 Add a basic mmap function, with a "fake-it" wrapper to do read_file_from_str instead. Based on code from Michael Mohr. 
svn:r6510
 2006-05-28 16:54:39 +00:00
Roger Dingledine
f6ff3e6f0e directory authorities should be more tolerant of failed reachability 
tests before crying foul to the server operator.


svn:r6509
 2006-05-28 16:14:26 +00:00
Roger Dingledine
48be472e4f clean up a comment 
svn:r6508
 2006-05-28 16:07:44 +00:00
Roger Dingledine
7f611f4732 if we're a server and some peer has a broken tls certificate, don't 
shout about it unless we want to hear about protocol violations.


svn:r6507
 2006-05-26 16:32:16 +00:00
Roger Dingledine
82ae38f649 be more verbose about testing reachability of our ORPort. 
svn:r6506
 2006-05-26 16:29:33 +00:00
Roger Dingledine
f579478687 correct a false log message, since we actually reset all our 
downloading stats every hour, and sometimes more often.


svn:r6505
 2006-05-26 16:29:20 +00:00
Roger Dingledine
731f4086c0 resolve an unused variable 
svn:r6503
 2006-05-26 13:51:45 +00:00
Roger Dingledine
a4cdb834b9 Stop being picky about what the arguments to mapaddress look like. 
we were refusing names that had $ in them, which people who specify
$key.exit will be sad about. There are likely other examples.
If people can think of reasons why we should be picky, let me know.


svn:r6496
 2006-05-25 20:06:09 +00:00
Roger Dingledine
3cd01ca9a1 make cookie authentication for the controller work again, maybe. 
it sure doesn't now.


svn:r6494
 2006-05-24 23:03:28 +00:00
Roger Dingledine
6066d68ac3 make options->RedirectExit work again; resolve bug 293. 
svn:r6492
 2006-05-24 11:13:03 +00:00
Roger Dingledine
36712a443b Stop initializing the hardware accelerator engines simply because 
we overloaded the meaning of the argument to crypto_global_init().


svn:r6490
 2006-05-24 00:37:38 +00:00
Roger Dingledine
67a885ecac Claim a commonname of Tor, rather than TOR, in tls handshakes. 
Maybe this will help us win the war of names.


svn:r6489
 2006-05-24 00:21:55 +00:00
Nick Mathewson
89a8411ace Throw out this UNALIGNED_INT_ACCESS_OK nonsense. Even where it works, it is often way way slower than doing the right thing. Backport candidate. 
svn:r6473
 2006-05-23 08:23:03 +00:00
Roger Dingledine
13c4590dd1 ignore RunAsDaemon more thoroughly when we're running on windows. 
svn:r6471
 2006-05-23 07:04:55 +00:00
Roger Dingledine
6b058bd563 add a few more debugging lines to help mikec track down his 
11 minute jump into the future.


svn:r6465
 2006-05-23 03:08:30 +00:00
Nick Mathewson
55c38f88b9 Remove string size limit on NEWDESC messages; solve bug 291. 
svn:r6463
 2006-05-22 23:24:06 +00:00
Peter Palfrader
f7ba9d77e4 All these headers we get via torint.h 
svn:r6452
 2006-05-10 10:24:17 +00:00
Roger Dingledine
295ad74fda Tor servers are also giving spurious "you're invalid" warnings. 
This is because we get a lot of network statuses that don't list
us at all, and we conclude that they all think we're invalid.
The long-term fix is to get better logic, and the short-term fix
is to downgrade the log severity.


svn:r6448
 2006-05-09 09:47:47 +00:00
Roger Dingledine
27624a3024 stop telling people that "tor -h" will help them in any way. 
svn:r6447
 2006-05-08 04:28:49 +00:00
Roger Dingledine
e24e5475fb forward-port the ORPort==0 patch 
svn:r6430
 2006-05-03 18:29:44 +00:00
Nick Mathewson
2b720b5746 Start remembering *where* we are storing routerdescs. This will make us easier to move from a RAM-mirrors-disk model to a RAM-caches-disk model, and save maybe around 10MB on a directory server. 
svn:r6427
 2006-04-29 18:42:26 +00:00
Nick Mathewson
15dbe02c04 shorten some too-wide lines 
svn:r6426
 2006-04-29 17:44:31 +00:00
Roger Dingledine
701341ef8a put one of the XXX's back in 
svn:r6422
 2006-04-25 07:06:48 +00:00
Roger Dingledine
3c86402cc2 petty cleanups 
svn:r6421
 2006-04-25 07:00:04 +00:00
Nick Mathewson
5bce102cd2 Only warn about a down node once 
svn:r6420
 2006-04-25 06:20:47 +00:00
Nick Mathewson
5f9612216c you wanted it spelled properly too? And me not even funded! 
svn:r6418
 2006-04-25 06:02:46 +00:00
Nick Mathewson
d6c04216ef fix a segfault in last bug-285-related commit. 
svn:r6417
 2006-04-25 05:59:31 +00:00
Nick Mathewson
c70f1e7eb3 Possible partial fix for 285; needs review 
svn:r6414
 2006-04-24 17:51:31 +00:00
Roger Dingledine
934e9c49bb Regenerate our local descriptor if it's dirty and some local 
function asks for it. This may resolve bug 286.


svn:r6412
 2006-04-23 23:09:03 +00:00
Roger Dingledine
c74c24a989 make more hibernate log messages use local time. we should audit 
to see what other log messages keep switching back and forth
between GMT and local.


svn:r6411
 2006-04-23 23:05:34 +00:00
Roger Dingledine
2d78d74c80 Raise the timeout for complaining about wedged cpuworkers. 
This value is high because some servers with low memory/cpu
sometimes spend an hour or more swapping, and Tor starves.


svn:r6406
 2006-04-18 19:48:06 +00:00
Roger Dingledine
5721747de2 class B really means /16 here 
svn:r6404
 2006-04-18 05:03:09 +00:00
Nick Mathewson
735a2131b8 require at least 2**16 assignable virtual addresses 
svn:r6402
 2006-04-18 04:57:07 +00:00
Nick Mathewson
8a13a7cfe8 mainline branch. Remove some more dead XXXs. 
svn:r6401
 2006-04-18 03:58:42 +00:00
Nick Mathewson
7484ca06a5 [Forward-port ]Test and document last patch. 
svn:r6400
 2006-04-18 03:51:18 +00:00
Nick Mathewson
0df40a393b [forward-port] Implement an option, VirtualAddrMask, to set which addresses get handed out in response to mapaddress requests. Needs testing and docs! 
svn:r6398
 2006-04-18 03:36:28 +00:00
Nick Mathewson
6ebd886511 forward-port: "Resolve" all XXX011 items, mostly by marking them non-011. 
svn:r6396
 2006-04-18 03:07:24 +00:00
Roger Dingledine
47d3e23155 note another bug: we complain that a router doesn't exist, 
because it's down so we never fetched it so it doesn't exist.


svn:r6394
 2006-04-17 06:46:20 +00:00
Roger Dingledine
34bc0866d4 slightly clearer log message when you use a nickname rather than 
a key for an unnamed server.


svn:r6393
 2006-04-17 06:43:27 +00:00
Roger Dingledine
07ff409876 no need to escape the address for our connections -- they are 
always IP addresses.


svn:r6389
 2006-04-16 22:34:00 +00:00
Roger Dingledine
0cee3e1fc7 if the bottom eighth of the servers by bandwidth is really crummy, 
try the bottom quartile instead.


svn:r6387
 2006-04-15 07:15:23 +00:00
Roger Dingledine
3791d3daaa forward-port the n_named log severity downgrade. 
svn:r6385
 2006-04-14 20:19:33 +00:00
Roger Dingledine
64041d2dbf ok, put moria1 back in, since it's v1 and thus we need to send 
our rendezvous descriptors to it.

eventually we might make a 'v1only' tag that explains it's only
for rendezvous descriptors.


svn:r6382
 2006-04-11 14:12:04 +00:00
Roger Dingledine
e720cc6589 drop moria1 from the list of authorities. 
svn:r6381
 2006-04-10 21:40:43 +00:00
Peter Palfrader
beb9e0721a Stop assuming every authority is a v1 authority 
svn:r6377
 2006-04-10 21:29:29 +00:00
Nick Mathewson
1fbc74661f Remove DER64 functions in trunk: they will never be used again unless the directory authorities switch back to 0.0.9tooearly. 
svn:r6376
 2006-04-10 21:23:00 +00:00
Roger Dingledine
37c77c71f7 0.1.2.0-alpha-cvs! 
svn:r6375
 2006-04-10 20:21:55 +00:00
Roger Dingledine
12d461a245 make DirFetchPeriod and StatusFetchPeriod truly obsolete. 
svn:r6373
 2006-04-10 20:16:46 +00:00
Roger Dingledine
f89b0ea09f be willing to add our own routerinfo into the routerlist. 
this means authorities will include themselves in their
directories and network-statuses.


svn:r6369
 2006-04-10 20:00:31 +00:00
Peter Palfrader
fe6c1b0192 Remove redundant includes. They are all hanled in torint.h which we already do include. 
svn:r6364
 2006-04-10 19:39:26 +00:00
Roger Dingledine
b190c451b8 and one more kick to consider all live network statuses for versions 
svn:r6359
 2006-04-10 08:40:16 +00:00
Roger Dingledine
a9e7737c3a consider all live network statuses we have when deciding whether 
our version is bad. also, unfix one of the unbugs from before.


svn:r6358
 2006-04-10 08:37:16 +00:00
Nick Mathewson
1064bbc62a Fix a wide line 
svn:r6357
 2006-04-10 08:05:00 +00:00
Nick Mathewson
71f1a77371 fix bugs in compute_recommended_versions 
svn:r6356
 2006-04-10 08:02:56 +00:00
Nick Mathewson
53f7a1bb0c In fairness to gcc, a char** is often _not_ usable as a const void **. 
svn:r6355
 2006-04-10 07:50:38 +00:00
Nick Mathewson
eb3e28ba79 Oops. _compare_tor_version_str_ptr wants ptr-to-ptr. Ow. 
svn:r6354
 2006-04-10 07:40:39 +00:00
Roger Dingledine
9a34c32ec3 bump to 0.1.1.18-rc 
svn:r6351
 2006-04-10 05:58:20 +00:00
Roger Dingledine
acc2eb445d and get rid of an extra variable 
svn:r6349
 2006-04-10 05:48:04 +00:00
Roger Dingledine
ac2070b35b stop being so picky about when we can start building circuits. 
now clients are more likely to have circuits up soon after their
tor starts.


svn:r6346
 2006-04-10 05:44:54 +00:00
Nick Mathewson
e258276c2b Change a dumb interface. Also, increment trusted_dir_server_t.n_networkstatus_failures when an all.z download fails entirely or partially. 
svn:r6345
 2006-04-10 01:35:56 +00:00
Roger Dingledine
21263982e4 Don't yell loudly about failed internal/bridge connections. These 
are reachability testing and rendserv upload/downloads, and they
have their own failure messages elsewhere.


svn:r6343
 2006-04-09 21:36:37 +00:00
Roger Dingledine
b6b534c9dd quiet a bootstrapping message 
svn:r6342
 2006-04-09 20:19:56 +00:00
Roger Dingledine
760934b175 fix typo 
svn:r6340
 2006-04-09 10:43:03 +00:00
Roger Dingledine
ed38f46ebc lower the minimum required number of fd's to 1000, so we can 
have some overhead for valgrind on linux, where the default
ulimit -n is 1024.


svn:r6338
 2006-04-09 10:28:00 +00:00
Roger Dingledine
b18d20ce32 Here is an attempted fix for directory mirrors that are frozen 
in fear because they don't have all the networkstatuses. There's
no reason not to proceed if all the other checks are ok -- we just
shouldn't warn about certain things yet.


svn:r6337
 2006-04-09 10:10:09 +00:00
Roger Dingledine
0871f4ef90 Remove about 30% of the v1 directory bulk by not including down or 
invalid nodes.

This will make exitlist's running on v1 not very good. I feel sorry for
them, but not as sorry as I feel for the directory mirrors.


svn:r6332
 2006-04-09 01:00:24 +00:00
Roger Dingledine
d48cdbe2e0 When fetching rendezvous descriptors, we were willing to ask 
v2 authorities too. And of course they did not have a copy.


svn:r6331
 2006-04-09 00:36:15 +00:00
Roger Dingledine
b7cadc0db5 If you're not a versioning dirserver, don't put the string 
"client-versions \nserver-versions \n" in your network status.


svn:r6329
 2006-04-08 21:59:15 +00:00
Roger Dingledine
a589650496 i like the name FetchUselessDescriptors better. 
svn:r6327
 2006-04-08 21:48:14 +00:00
Roger Dingledine
2a94c8b493 add a new config option FetchUselessRouters, off by default, for 
when you plan to run "exitlist" on this client and you want to know
about even the non-running descriptors.


svn:r6326
 2006-04-08 21:35:17 +00:00
Roger Dingledine
3a5758e212 If we think of ourselves as authoritative, even if we're not 
in the DirServers config lines, then we still are. This way we
give ourselves the "Authority" flag in our network-status.


svn:r6325
 2006-04-08 21:19:40 +00:00
Roger Dingledine
24b2e0530a clean up the log lines more, and note a future work. 
svn:r6324
 2006-04-08 21:12:07 +00:00
Roger Dingledine
b5737aab91 add dizum as the fifth authoritative directory server. 
svn:r6323
 2006-04-08 21:03:49 +00:00
Roger Dingledine
f1692ebefc when we do reachability testing and the tls cert at the other 
end disagrees with a descriptor we already have, be more useful
at explaining it.


svn:r6322
 2006-04-08 20:35:19 +00:00
Roger Dingledine
fab1feee26 complain when we hit wsaenobufs on recv or write too. 
perhaps this will help us hunt the bug.


svn:r6321
 2006-04-08 07:54:11 +00:00
Roger Dingledine
557b174b8d Break out the checks to see if a routerstatus is something we 
would use. This way when we're deciding if we have "enough" descriptors
to start building circuits, we can count them accurately.


svn:r6320
 2006-04-08 06:56:38 +00:00
Roger Dingledine
de8ce0aae8 fix a typo that was confusing me 
svn:r6319
 2006-04-08 06:55:10 +00:00
Nick Mathewson
5d466b7611 Fix a couple of things that make GCC complain with verbose warnings on. Also, fix some whitespace. 
svn:r6317
 2006-04-08 05:43:52 +00:00
Nick Mathewson
7a804572ab fix an infinite loop; answer a question 
svn:r6316
 2006-04-07 22:55:46 +00:00
Nick Mathewson
c6d010b218 Dont warn about our own status unless weve tried and failed 4 times (or succeeded) for each authority. 
svn:r6315
 2006-04-07 04:52:32 +00:00
Roger Dingledine
c4fb9d22cf if there's more than one match for router-get-my-nickname, 
try to pick one that's running.


svn:r6313
 2006-04-04 03:46:40 +00:00
Roger Dingledine
0825f61102 fix crash bug reported in flyspray 279. 
svn:r6312
 2006-04-04 03:25:36 +00:00
Roger Dingledine
453062b028 fix typo, remove extraneous variable 
svn:r6311
 2006-04-03 11:24:14 +00:00
Roger Dingledine
7198af7fbe one more edge case that could paralyze a client with fear 
svn:r6310
 2006-04-03 06:59:07 +00:00
Roger Dingledine
a324871603 phrase the threshold comparison in the way we've been 
phrasing it. these are equivalent, right?


svn:r6309
 2006-04-03 06:37:35 +00:00
Roger Dingledine
4b6ff2b084 bugfix in sort_version_list() so it doesn't screw up the sorting. 
svn:r6308
 2006-04-03 06:30:48 +00:00
Nick Mathewson
eba6204315 fix some xxxs. 
svn:r6307
 2006-04-03 06:23:24 +00:00
Roger Dingledine
2cb3aeb4e1 another point that needs more thinking 
svn:r6306
 2006-04-03 06:22:54 +00:00
Roger Dingledine
9549d81d95 two more thresholds to look at 
svn:r6305
 2006-04-03 06:10:33 +00:00
Roger Dingledine
64a40b5137 nick: there *is* no MAX_SERVER_INTERVAL_WITHOUT_REQUEST. true? 
svn:r6300
 2006-04-03 02:20:32 +00:00
Roger Dingledine
7e3a98b489 "" is not a plausible address for addressmaps. 
svn:r6299
 2006-04-03 00:26:51 +00:00
Nick Mathewson
4130460f8e Change networkstatus dl logic: try to have all networkstatuses live; insist on having all of them live or tried-at-least-once. Also, answer a XXXX comment. 
svn:r6297
 2006-04-02 23:02:52 +00:00
Nick Mathewson
d663bfa306 Versions that drop connections for having used idle circs are as bad for stable as for guard 
svn:r6296
 2006-04-02 23:01:01 +00:00
Nick Mathewson
785d25e06c If I could forget that I had enabled StrictExitNodes, others will too. 
svn:r6295
 2006-04-02 22:59:59 +00:00
Roger Dingledine
b34032b87d but the \r\n is handy too i hear. 
svn:r6294
 2006-04-02 22:19:01 +00:00
Roger Dingledine
e84cd412d4 if you give mapaddress no args at all, it should answer 
something more than \r\n.


svn:r6293
 2006-04-02 22:13:34 +00:00
Roger Dingledine
1e04b70d49 make NoPublish (even though deprecated) work again. 
svn:r6287
 2006-04-02 02:59:48 +00:00
Roger Dingledine
dfb3c5f47a if you ask for getinfo dir/status/ but your dirport is off, 
log a complaint.


svn:r6286
 2006-04-01 22:17:37 +00:00
Roger Dingledine
6fb27741ba Fix dirserv_get_networkstatus_v2's api: its function comments 
did not at all match its behavior, and I can't think of a case
when it should return anything other than 0.

This fix may allow getinfo dir/status/foo to work.


svn:r6285
 2006-04-01 22:00:49 +00:00
Roger Dingledine
e754664d62 bugfix: when we fail to bind or listen on an incoming or outgoing 
socket, we should close it before failing. otherwise we just
leak it. (thanks to weasel for finding.)


svn:r6284
 2006-04-01 10:22:57 +00:00
Roger Dingledine
e47075e771 more helpful error message 
svn:r6283
 2006-04-01 09:54:54 +00:00
Roger Dingledine
314f24870d Start sending back 512 and 451 errors if mapaddress fails, 
rather than not sending anything back at all.


svn:r6282
 2006-04-01 09:50:43 +00:00
Roger Dingledine
4c996757ae We can remove about 30% of the v1 directory bulk by taking 
out down or invalid nodes. We should do this once we're ready.


svn:r6273
 2006-03-29 09:21:23 +00:00
Roger Dingledine
db1209a852 Refactor the decision of whether to include a router's descriptor 
in the v1 directory. No actual changes yet.


svn:r6272
 2006-03-29 08:56:39 +00:00
Peter Palfrader
1fa7b3cef7 Avoid warnings about machine/limits.h on Debian GNU/kFreeBSD 
svn:r6271
 2006-03-29 05:14:12 +00:00
Roger Dingledine
1f4d0d2479 When deciding whether a router is Fast or Guard-worthy, consider 
his advertised BandwidthRate and not just the BandwidthCapacity.

This is a bug in 0.1.0.x as well, but let's not bother backporting.


svn:r6266
 2006-03-28 12:01:58 +00:00
Roger Dingledine
e7fbdcf70e bump to 0.1.1.17-rc-cvs 
so much for 'release candidate'


svn:r6265
 2006-03-28 11:30:57 +00:00
Roger Dingledine
26eb815f73 bump to 0.1.1.17-rc 
svn:r6261
 2006-03-28 07:45:23 +00:00
Nick Mathewson
685bceed1c Make the max number of old descriptors to hold rise with the number of authorities. 
svn:r6254
 2006-03-27 17:29:53 +00:00
Peter Palfrader
03302dc67d On our dirport return a robots.txt so maybe google doesn't index all those server descriptors anymore 
svn:r6252
 2006-03-27 07:33:13 +00:00
Nick Mathewson
2421724853 Code to implement networkstatus fetch from controllers. Only works when dirport is set for now; should be good enough to make serifos html front-end not be as wrong. 
svn:r6251
 2006-03-27 06:49:25 +00:00
Roger Dingledine
56df81199a that extra punctuation distracts me 
svn:r6250
 2006-03-27 05:30:16 +00:00
Nick Mathewson
cd271dbca9 re-order to avoid free-then-use. Thank goodness tor_free() zeroes things. 
svn:r6249
 2006-03-27 05:27:47 +00:00
Nick Mathewson
c74bd877e2 Oops. We may not have a networkstatus list when we first parse the cached routers. 
svn:r6248
 2006-03-27 05:12:07 +00:00
Nick Mathewson
3e8c9a485f Fix for "but need_to_mirror=1" annoyance; is bug 273 fixed? 
svn:r6247
 2006-03-27 05:07:57 +00:00
Roger Dingledine
6f08d121d9 Refactor and consolidate addr/exit policies into a new policies.c. 
Fix some minor bugs and memory leaks along the way.


svn:r6246
 2006-03-27 02:25:34 +00:00
Roger Dingledine
e20aad8d46 remove obsolete address policy code 
svn:r6243
 2006-03-26 09:38:17 +00:00
Roger Dingledine
e1c8e3ca6e also send syntax and parse errors back to the controller. 
svn:r6242
 2006-03-26 08:09:19 +00:00
Roger Dingledine
b899b9592a When the controller's *setconf commands fail, collect an error message 
in a string and hand it back. This starts to resolve bug 275.


svn:r6241
 2006-03-26 06:51:26 +00:00
Roger Dingledine
0543900fbf clean up the traces from tracking the 0.1.1.9-alpha stack-smashing bug. 
svn:r6240
 2006-03-26 06:47:51 +00:00
Roger Dingledine
7871ad9116 failing in a support function is a warn, not an err. 
svn:r6239
 2006-03-26 06:47:08 +00:00
Peter Palfrader
e90bebf27b Say private address instead of internal address. 
Both are wrong or at least not entirely correct but nobody would
understand "special-use address as listed in RFC3330" I guess.


svn:r6236
 2006-03-25 21:24:28 +00:00
Roger Dingledine
f2abd7a69b fix a wordo, don't be so quick to yell at servers, and ask a question. 
svn:r6235
 2006-03-24 21:11:14 +00:00
Roger Dingledine
7edfec2ae6 bump up the magic number for how quickly we start notifying 
a server that it's unreachable.


svn:r6234
 2006-03-24 20:57:55 +00:00
Nick Mathewson
6d9632ba23 Check return value from GetVersionEx (even though the MSDN example doesnt) and zero out the LPOSVERSIONINFOEX struct before getting the version. This may fix the "johnboy" [major=-858993460,minor=-858993460] problem. 
svn:r6233
 2006-03-24 05:26:33 +00:00
Peter Palfrader
444e3b8eb2 Note a magic 2 that probably should be replaced now that we have more dirservers 
svn:r6232
 2006-03-23 20:21:54 +00:00
Roger Dingledine
5b87b0bf55 update getinfo info/names to reflect that we now support 
getinfo dir/server/*


svn:r6231
 2006-03-22 21:53:09 +00:00
Roger Dingledine
20e66a799b Resolve problem found by weasel: the v1 directory was including 
servers as much as 48 hours old, because that's how the new
routerlist->routers works. Now only include them if they're
20 hours old or less.


svn:r6230
 2006-03-22 21:32:42 +00:00
Peter Palfrader
58307cd8de Maybe it compiles for devilproxy now 
svn:r6229
 2006-03-22 11:23:00 +00:00
Roger Dingledine
0d7efbe65d Note a vulnerability with our current recommended-version concensus 
building.

Make the warnings about invalid and unnamed nodes scale better, and
update the text of the warnings.

Change router_have_minimum_dir_info() to only be happy when it has
enough network-statuses ("more than half") to be willing to actually
build circuits.

Not yet done: when we fail to get a networkstatus that we wanted, and
!router_have_minimum_dir_info(), we should retry it quicker than a whole
minute from now.


svn:r6227
 2006-03-22 06:22:12 +00:00
Roger Dingledine
51a3981d10 stop caching the v1 directory so often. 
svn:r6226
 2006-03-22 06:18:27 +00:00
Roger Dingledine
6fb2b6785d whoops. inform circuits again when we failed to connect to their 
first hop, so they don't have to time out.


svn:r6225
 2006-03-22 04:09:30 +00:00
Roger Dingledine
1db263ac3c stop writing the "router.desc" file, ever. nothing uses it anymore. 
svn:r6224
 2006-03-22 03:45:17 +00:00
Peter Palfrader
805754fdd9 Log server fingerprint on startup 
svn:r6223
 2006-03-22 03:40:59 +00:00
Roger Dingledine
216e349cb2 parameterize two more timeout constants in circuit-land. 
svn:r6220
 2006-03-22 00:52:37 +00:00
Roger Dingledine
ad236d4b8b freeing is not the same as setting to null 
svn:r6219
 2006-03-22 00:03:51 +00:00
Roger Dingledine
28fafb9022 new config option SocksTimeout: How long do we let a socks connection 
wait unattached before we fail it?

Use this value for controller socks timeout, for normal socks
timeout, and for hidden-service socks timeout.


svn:r6217
 2006-03-21 23:27:43 +00:00
Roger Dingledine
5399e394a8 and dirservers don't call you a guard if you're running a 
buggy version either.


svn:r6216
 2006-03-21 23:10:26 +00:00
Roger Dingledine
f11509e494 when upgrading to newer versions, throw away entry guards 
picked by the old wrong algorithms.


svn:r6215
 2006-03-21 23:06:47 +00:00
Roger Dingledine
8a8a84dd52 don't call circuit_n_conn_done() if the closing conn is already open. 
svn:r6214
 2006-03-21 22:22:48 +00:00
Roger Dingledine
a3329036a8 Bugfix: looks like clients since 0.1.1.10-alpha have been 
expiring connections whenever 5 minutes pass and they *do*
have circuits on them.


svn:r6213
 2006-03-21 21:58:00 +00:00
Roger Dingledine
65b575c03d Be more patient before giving up on in-progress circuits. 
I have absolutely no idea if this change helps or hurts.
Somebody should study this.


svn:r6212
 2006-03-21 21:22:52 +00:00
Nick Mathewson
15e5cf6088 Fix memory leak when uncompressing concatenated zlib streams. Unit tests and tor client work; looks ok. 
svn:r6211
 2006-03-21 20:31:27 +00:00
Roger Dingledine
0e68ec0846 put lefkada on port 80, officially. 
svn:r6209
 2006-03-21 16:57:03 +00:00
Roger Dingledine
073d574a3f Point out a potential DoS flaw in caching untrusted network 
statuses to disk. We should resolve sometime.


svn:r6206
 2006-03-21 05:27:35 +00:00
Roger Dingledine
415c9e878a add lefkada as a fourth auth dir server. 
svn:r6205
 2006-03-21 04:41:20 +00:00
Nick Mathewson
08aba015ab Make guard bandwidth threshold higher than fast bandwidth threshold. 
svn:r6204
 2006-03-20 21:49:55 +00:00
Nick Mathewson
1272485cd4 Make "Fast" based on median capacity, just like "Stable" is based on median uptime. 
svn:r6203
 2006-03-20 21:41:12 +00:00
Roger Dingledine
6449e2f6d6 ok, commenting that out broke things real bad. 
leave it, and accept the memory leak for now.


svn:r6201
 2006-03-20 02:13:35 +00:00
Roger Dingledine
54ced294df Resolve a memory leak on clients. This disables some 
functionality that we might still want. Nick?


svn:r6200
 2006-03-20 00:52:22 +00:00
Roger Dingledine
88b67d48f0 bump to 0.1.1.16-rc-cvs so we can start fixing more bugs 
svn:r6197
 2006-03-19 04:43:36 +00:00
Roger Dingledine
bcc19b0f83 which brings us to 0.1.1.16-rc 
svn:r6195
 2006-03-19 04:02:11 +00:00
Roger Dingledine
d1d0813cf3 Allow non-printable characters for exit streams (both for 
connecting and for resolving). Now we tolerate applications
that don't follow the RFCs. But continue to block malformed
names at the socks side.


svn:r6193
 2006-03-19 03:55:48 +00:00
Roger Dingledine
726e825b09 i'm a little teapot, short and stout 
svn:r6192
 2006-03-19 01:59:02 +00:00
Roger Dingledine
d8195e4128 Implement Jason Holt's SafeSocks config option. 
Also put a URL in the warning message for unsafe socks4 use --
previously we'd only had the URL for unsafe socks5 use. Oops.


svn:r6190
 2006-03-19 01:44:53 +00:00
Roger Dingledine
c06e6ddadd Finish the transition from the word 'verified' to the words 
'named' and 'valid'.


svn:r6188
 2006-03-19 01:21:59 +00:00
Roger Dingledine
7e2aa67fcb simplify when we're picking a default address for 
when people ask for "serifos.exit".


svn:r6187
 2006-03-18 22:54:08 +00:00
Roger Dingledine
868d456c3b make it so there is one place to edit for new dirservers, not two. 
svn:r6186
 2006-03-18 22:37:27 +00:00
Roger Dingledine
cc37c2f71e fix some typos 
svn:r6185
 2006-03-18 09:29:05 +00:00
Roger Dingledine
67b61fe475 authdirs shouldn't complain about unreachability when they 
fetch a descriptor from somebody else. this is not the right
time to increment the failure count.


svn:r6184
 2006-03-18 05:37:15 +00:00
Roger Dingledine
581795f41d auth dir servers were only modifying a server's is_running field 
when they created a network status. so if nobody asked for a
network status, they would never discover that any servers are
is_running, so they could never build a circuit.


svn:r6183
 2006-03-18 01:24:04 +00:00
Roger Dingledine
cf6ba3e76f let an authdir that's not a naming authdir start even 
if it doesn't have an approved-routers file. if it does,
read it and parse it as usual.


svn:r6182
 2006-03-18 00:22:23 +00:00
Roger Dingledine
4f14826cb3 Actually, only v1 auth dir servers need to define recommendedversions. 
But versioning dirservers do need to cause recommendclientversions
and recommendedserverversions to somehow be non-empty.


svn:r6181
 2006-03-17 23:25:40 +00:00
Roger Dingledine
c7839a17f5 when we're an auth dir server but don't claim to be a versioning 
auth dir server, don't demand that we define RecommendedVersions.


svn:r6180
 2006-03-17 23:21:42 +00:00
Roger Dingledine
51fc6799ad right now we don't support entryguards on auth dirservers, 
but that doesn't mean we need to remind them every time
they start up.


svn:r6179
 2006-03-17 23:19:51 +00:00
Roger Dingledine
817556315a Implement router purposes, and don't choose a non-general 
purpose router when picking random nodes for a circuit.

Also implement SETROUTERPURPOSE and modify +POSTDESCRIPTOR.

This concludes bug 250 assuming it all works.


svn:r6178
 2006-03-17 22:08:59 +00:00
Roger Dingledine
7d141c6776 but i made the line too long 
svn:r6176
 2006-03-17 19:25:36 +00:00
Roger Dingledine
f1bcc2d6f8 stop tricking server operators into thinking they got their 
torrc perfect, just because tor could build a circuit.


svn:r6175
 2006-03-17 19:20:07 +00:00
Nick Mathewson
053411e827 Comments: cleanups and additions. 
svn:r6174
 2006-03-17 05:50:41 +00:00
Nick Mathewson
0f0e14c6e3 normalize whitespace. 
svn:r6173
 2006-03-17 04:43:37 +00:00
Nick Mathewson
215e377224 Only warn about lack of name binding for self if we have tried downloading every networkstatus. 
svn:r6172
 2006-03-17 04:41:57 +00:00
Roger Dingledine
9a5df4cef5 resume being printist: if the hostname contains non-printable 
characters, then fail. this time don't even bother telling the
server operator about these cases, because what's he going to do?

if it turns out that some significant population somewhere in the
world uses non-printable hostnames and wants to use tor, then i
hereby assume that they will contact us.


svn:r6171
 2006-03-15 23:36:57 +00:00
Roger Dingledine
0e62befab8 add tor_strisprint() back in, this time with comments. 
svn:r6170
 2006-03-15 23:35:55 +00:00
Roger Dingledine
8d1f65a222 quiet another entry guard log message 
svn:r6169
 2006-03-15 22:48:48 +00:00
Roger Dingledine
4cd4353847 and remove now-extraneous function 
svn:r6168
 2006-03-15 19:17:46 +00:00
Roger Dingledine
e8fd871d8b Stop being printist: just because our local platform doesn't 
consider an alleged destination to be printable doesn't mean
nobody in the world will want to use it.


svn:r6167
 2006-03-15 19:17:34 +00:00
Nick Mathewson
13cf54b9c1 Interim fix for 272: Only warn that we are not named if we have status docs from some naming authorities. 
svn:r6166
 2006-03-15 05:37:27 +00:00
Nick Mathewson
fb7b5545ce Implement GETINFO(dir/server/foo); status will be harder. 
svn:r6165
 2006-03-15 05:06:56 +00:00
Nick Mathewson
d0f24b1e46 (Missing header change) Do not warn about unknown servers in our family when they are given as hex digests. 
svn:r6164
 2006-03-15 05:06:26 +00:00
Nick Mathewson
3c0a5f6365 Do not warn about unknown servers in our family when they are given as hex digests. 
svn:r6163
 2006-03-15 05:04:11 +00:00
Roger Dingledine
903183ea28 if we as a directory mirror don't know of any v1 directory 
authorities, then don't try to cache any v1 directories.


svn:r6162
 2006-03-15 00:10:13 +00:00
Peter Palfrader
a4ec555228 change INET_NTOA_BUF_LEN+1 to INET_NTOA_BUF_LEN 
add a comment in a few places where we add weird numbers to buffer lengths


svn:r6161
 2006-03-14 23:40:37 +00:00
Peter Palfrader
866f6293ff I wonder what an internal internet protocol is 
svn:r6159
 2006-03-14 22:52:20 +00:00
Peter Palfrader
86a964d868 When we try to be a server and Address is not explicitly set 
and our hostname resolves to a private IP address, try
to use an interface address if it has a public address.


svn:r6158
 2006-03-14 22:51:15 +00:00
Peter Palfrader
2ef8f772a1 Fix an off-by-one buffer size in dirserv.c that magically never hit our 
three authorities but broke sjmurdoch's own tor network.


svn:r6157
 2006-03-14 22:43:52 +00:00
Roger Dingledine
499eeced44 when event_add or event_del fail, tell us why. 
svn:r6156
 2006-03-13 19:33:46 +00:00
Peter Palfrader
ebfb3fea6d Fix minor semantic error with no real effect: 
we were doing "is_internal_IP(htonl(in.s_addr))" but in.s_addr is
in network order and is_internal_IP wants host order.  Change to
"is_internal_IP(ntohl(in.s_addr))".


svn:r6155
 2006-03-13 19:09:52 +00:00
Nick Mathewson
0bc19dddf5 Use INLINE (which we define) instead of __inline (which is nonstandard) in ht.h. Resolves bug 270; maybe sun C will work now. 
svn:r6153
 2006-03-13 15:09:49 +00:00
Nick Mathewson
dad60905a8 Be a little more careful when our calculated bandwidth is so high that we could never ever exhaust our bandwidth limit. This should resolve bug 130. 
svn:r6146
 2006-03-13 01:06:55 +00:00
Nick Mathewson
daea6b21a5 Fix bug in close_logs(): when we close and delete logs, remove them all from the global "logfiles" list. This should fix bug 222. 
svn:r6145
 2006-03-13 00:54:21 +00:00
Nick Mathewson
0c132ee2a1 Instead of listing a set of compilers that prefers __func__ to __FUNCTION__, use autoconf. Also, prefer __func__ in our own code: __func__ is a C99 standard, whereas __FUNCTION__ is not. [Fixes bug 254.] 
svn:r6144
 2006-03-13 00:25:36 +00:00
Nick Mathewson
bd8ffccae7 More cleanups noticed by weasel; also, remove macros that nobody uses. 
svn:r6143
 2006-03-12 23:31:16 +00:00
Nick Mathewson
474c60b743 Cleanup on time-relaqted constants. New conventions: 
1) Surround all constants by (parens), whether we'll be using them
     in a denominator or not.
  2) Express all time periods as products (24*60*60), not as multiplied-out
     constants (86400).
  3) Comments like "(60*60) /* one hour */" are as pointless as comments
     like "c = a + b; /* set c to the sum of a and b */".  Remove them.
  4) All time periods should be #defined constants, not given inline.
  5) All time periods should have doxygen comments.
  6) All time periods, unless specified, are in seconds.  It's not necessary
     to say so.

To summarize, the old (lack of) style would allow:

  #define FOO_RETRY_INTERVAL 60*60 /* one hour (seconds) */
  next_try = now + 3600;

The new style is:

  /** How often do we reattempt foo? */
  #define FOO_RETRY_INTERVAL (60*60)

  next_try = now + RETRY_INTERVAL;


svn:r6142
 2006-03-12 22:48:18 +00:00
Roger Dingledine
b67a5ba498 lower the reachability timeout, so we're more likely to act 
quickly if a server stops being reachable.


svn:r6141
 2006-03-12 21:24:03 +00:00
Roger Dingledine
1fc5eb329b We screwed up in anticipating how to add new dirservers: 
Old servers won't realize they're supposed to stay connected
to the new dirservers, so they'll expire connections to them,
but that means the dirservers will list them as unreachable.

So the fix is to stop requiring an open connection when deciding
if a server is reachable. This makes us slightly less accurate,
but at least it will work.


svn:r6140
 2006-03-12 20:57:52 +00:00
Roger Dingledine
ef447507ff a better clean-up 
svn:r6139
 2006-03-12 20:51:02 +00:00
Roger Dingledine
a98b25137c and another fix 
svn:r6138
 2006-03-12 20:48:59 +00:00
Roger Dingledine
98476c71d2 make tor --verify-config closer to working 
svn:r6137
 2006-03-12 20:46:00 +00:00
Roger Dingledine
a4da44c2b9 Now do address rewriting when the controller asks us to attach 
to a particular circuit too. This will let Blossom specify
"moria2.exit" without having to learn what moria2's IP address is.

It may also cause other controller authors some angst. Let us know.


svn:r6136
 2006-03-12 05:04:16 +00:00
Roger Dingledine
d80d5370e0 when we get funny-looking lines on our dirport, shut up about it. 
svn:r6135
 2006-03-12 04:36:17 +00:00
Roger Dingledine
b5c6a990d3 fix assert while attachstream'ing a connect-wait or 
resolve-wait stream.


svn:r6134
 2006-03-12 04:33:29 +00:00
Roger Dingledine
80f0492a65 avoid shadowing a variable so we don't get sad later. 
svn:r6133
 2006-03-12 04:07:21 +00:00
Roger Dingledine
ef8939d5b3 bump to 0.1.1.15-rc-cvs 
svn:r6132
 2006-03-12 03:01:09 +00:00
Roger Dingledine
44ca1a997d bump to 0.1.1.15-rc 
svn:r6126
 2006-03-11 18:44:11 +00:00
Roger Dingledine
0bd46086c3 fix bug reported by gozu: if we get a linelist or linelist_s 
config option from the torrc and it has no value, warn and
skip rather than silently resetting it to its default.


svn:r6125
 2006-03-11 18:40:33 +00:00
Roger Dingledine
c8e2a051ac huge warning sign for esc_router_info() 
svn:r6124
 2006-03-11 17:52:55 +00:00
Nick Mathewson
4d3e709c4b Use escaped() for remaining cases. 
svn:r6117
 2006-03-11 02:21:30 +00:00
Roger Dingledine
86a72f73b9 make entry guard logs even quieter 
svn:r6116
 2006-03-10 16:51:26 +00:00
Roger Dingledine
e11f900a2a stop printing a log message at every iteration through the 
event loop when holding open a conn for flushing but it
doesn't want to flush any more bytes yet.


svn:r6114
 2006-03-09 06:34:33 +00:00
Roger Dingledine
5f8d26496d Let the controller attachstream conns that are in connect_wait 
or resolve_wait: we detach them first and then act as before.
Resolves bug 264.


svn:r6112
 2006-03-09 06:29:53 +00:00
Roger Dingledine
82d1fdbaea don't abandon entry guards until they've been dead a whole month. 
make entry guard log messages quieter.


svn:r6106
 2006-03-09 00:55:55 +00:00
Roger Dingledine
44107f6ec4 Implement NEWNYM. Nick, did I do a bad thing? 
svn:r6105
 2006-03-09 00:18:16 +00:00
Roger Dingledine
0f39033b9f clean up typo 
svn:r6103
 2006-03-09 00:10:28 +00:00
Roger Dingledine
946317ae13 start using OR_CONN_EVENT_NEW. 
also fixes a seg fault in tor (bug 261).


svn:r6101
 2006-03-08 22:29:08 +00:00
Roger Dingledine
8db1e363c9 remove some redundant code now that we compress exit policies 
after parsing them


svn:r6099
 2006-03-08 19:34:34 +00:00
Nick Mathewson
1ce3713889 Possible bug 265 fix: authorities must be more strict than clients about age of acceptable routers; make routers publish every 12 hours; client ROUTER_MAX_AGE must be greater than NETWORKSTATUS_MAX_AGE+authoirty ROUTER_MAX_AGE. 
svn:r6095
 2006-03-08 06:29:52 +00:00
Roger Dingledine
a385b0087f fix infinite loop 
svn:r6090
 2006-03-06 20:01:46 +00:00
Roger Dingledine
a2d71f917e mark bug 261 
svn:r6089
 2006-03-06 19:47:54 +00:00
Nick Mathewson
5dc5380984 Add some "to-be-safe" escaped() wrappers to log statements in rend*.c, though I am not 100% sure that each one is necessary. 
svn:r6088
 2006-03-06 00:25:39 +00:00
Nick Mathewson
5777ee0e1a Add some functions to escape values from the network before sending them to the log. Use them everywhere except for routerinfo->plaftorm, routerinfo->contact_info, and rend*.c. (need sleep now) 
svn:r6087
 2006-03-05 09:50:26 +00:00
Nick Mathewson
6a4e304d9e Allow private:* in routerdescs; not generated yet (because older Tors do not understand it); needs testing. 
svn:r6086
 2006-03-05 05:27:59 +00:00
Roger Dingledine
329af979e0 Add a new circuit purpose 'controller' to let the controller 
ask for a circuit that Tor won't try to use.

Extend the EXTENDCIRCUIT controller command to let you specify
the purpose if you're starting a new circuit.

Add a new SETCIRCUITPURPOSE controller command to let you
change a circuit's purpose after it's been created.


svn:r6075
 2006-02-23 06:51:09 +00:00
Roger Dingledine
2bfd2a2400 clean up a log message 
svn:r6074
 2006-02-21 17:54:56 +00:00
Roger Dingledine
25ed4b66e3 be quieter about hidserv descriptors that are too old or too new. 
we can't do anything about them anyway.


svn:r6073
 2006-02-21 06:23:57 +00:00
Roger Dingledine
dda54db36d bump to 0.1.1.14-alpha-cvs, and we're off. 
svn:r6062
 2006-02-21 04:13:49 +00:00
Roger Dingledine
ae65d595ff bump to 0.1.1.14-alpha 
svn:r6059
 2006-02-21 03:57:44 +00:00
Roger Dingledine
89b07b458b i missed the other half of that grammar fix 
svn:r6058
 2006-02-21 03:55:47 +00:00
Roger Dingledine
16f265fa0d when saveconf fails in controller v1, we were returning a malformed 
error string.


svn:r6053
 2006-02-20 01:24:26 +00:00
Roger Dingledine
498c13b4df make the NoPublish option obsolete. 
svn:r6052
 2006-02-20 01:21:48 +00:00
Roger Dingledine
0408adb728 tweak 
svn:r6051
 2006-02-20 01:15:38 +00:00
Roger Dingledine
276a7bd038 the other half of fixing bug 257. catch an error in more places. 
svn:r6050
 2006-02-20 01:06:27 +00:00
Roger Dingledine
57bcdcecf1 try to address bug 257: if rename() fails during saveconf, tell 
the controller.


svn:r6049
 2006-02-19 23:12:26 +00:00
Roger Dingledine
6a52867846 New config options to address bug 251: 
FetchServerDescriptors and FetchHidServDescriptors for whether
to fetch server info and hidserv info or let the controller do it,
and also PublishServerDescriptor and PublishHidServDescriptors.

Add AllDirActionsPrivate undocumented option -- if you set it, you'll
need the controller to bootstrap you enough to build your first circuits.


svn:r6047
 2006-02-19 22:02:02 +00:00
Peter Palfrader
c4f389420c Improve the "we have been waiting for 1140377851 seconds" log 
svn:r6046
 2006-02-19 19:44:09 +00:00
Roger Dingledine
266254f42b clean up the Reachable*Addresses changes 
svn:r6041
 2006-02-19 08:31:47 +00:00
Peter Palfrader
42f14e8e10 Add function names to log_* on non-gcc 
svn:r6039
 2006-02-18 07:18:14 +00:00
Roger Dingledine
a9fcf4ced2 this is why you're not supposed to cut-and-paste code 
svn:r6037
 2006-02-18 06:46:01 +00:00
Peter Palfrader
4f5e607389 Finish log function renaming for non-GNUC systems 
svn:r6034
 2006-02-18 02:11:48 +00:00
Peter Palfrader
aa5443551d Make it compile with VC7. It does not yet link. 
svn:r6033
 2006-02-18 02:02:21 +00:00
Roger Dingledine
42cd0dcde8 fix typo found in phobos's logs 
svn:r6020
 2006-02-15 03:47:38 +00:00
Roger Dingledine
f6d80d60e0 don't warn when we get a server descriptor from the controller 
but it's too old. that's not something tor should fix.


svn:r6019
 2006-02-15 03:01:53 +00:00
Peter Palfrader
c7f2970777 Just because both are obsolete does not mean we prefer the newer 
svn:r6016
 2006-02-14 17:48:51 +00:00
Peter Palfrader
0bab094d5d Explain why we only expire open connections 
svn:r6015
 2006-02-14 17:30:04 +00:00
Roger Dingledine
ae249fc5a3 document the frequency for reachability testing by the 
directory authorities.


svn:r6014
 2006-02-14 04:33:59 +00:00
Peter Palfrader
84295f9f43 Do not mark connections obsolete before they have done their TLS handshake or are at least 60 seconds old 
svn:r6013
 2006-02-14 04:23:05 +00:00
Peter Palfrader
761da5b97f Our connection_or_get_by_identity_digest() was slightly wrong. If best 
didn't have any circuits on it, but conn had circuits, we would not make
conn our new best unless it was also newer.  Also, restructure the code
a bit to maybe make it clearer.


svn:r6012
 2006-02-14 00:08:19 +00:00
Peter Palfrader
0cc2390f8c Warn if ReachableAddresses is set when also ReachableDirAddresses and ReachableORAddresses are set. 
svn:r6010
 2006-02-13 22:29:37 +00:00
Peter Palfrader
5eea6c76df Split ReachableAddresses into ReachableDirAddresses and ReachableORAddresses 
svn:r6009
 2006-02-13 21:17:20 +00:00
Roger Dingledine
8262b7d1db and resolve long-lines and fix an error string 
svn:r6007
 2006-02-13 10:36:39 +00:00
Roger Dingledine
259c65ab08 the last of the log convention conversion. finally. 
svn:r6005
 2006-02-13 10:33:00 +00:00
Roger Dingledine
aa63a84fe1 the things we do for our windows users. 
i hope they appreciate it.


svn:r6004
 2006-02-13 09:37:53 +00:00
Roger Dingledine
d113b75da6 more log conversions. 
whee.


svn:r6003
 2006-02-13 09:02:35 +00:00
Roger Dingledine
36484f873a convert some more source files to the new log convention 
svn:r6002
 2006-02-13 08:28:42 +00:00
Roger Dingledine
7d80921afa resolve too-long-lines 
svn:r6001
 2006-02-13 08:22:57 +00:00
Roger Dingledine
6ce36ead42 Start the process of converting warn to log_warn and so on. 
This is needed because Windows already has an err() that we
can't clobber. And we need to be able to make the log functions
a macro so we can print the function's name in the log entry.


svn:r6000
 2006-02-13 08:01:59 +00:00
Nick Mathewson
2a4555fedd Style on config_addr_policy_intersectes, which looks ok to me. 
svn:r5998
 2006-02-13 07:16:32 +00:00
Roger Dingledine
350313d77a Let the users set ControlListenAddress in the torrc. 
This can be dangerous, but there are some cases (like a secured
LAN) where it makes sense.


svn:r5997
 2006-02-13 06:25:16 +00:00
Peter Palfrader
6c4d873591 Compress exit policies even more. please review 
svn:r5995
 2006-02-13 01:54:31 +00:00
Nick Mathewson
2cc66125b8 try to fix bug with spurious "everything is broken" warning 
svn:r5994
 2006-02-13 00:26:43 +00:00
Roger Dingledine
b7781ea208 bugfix: we were ignoring the IS_FAST flag in the directory 
status, meaning we were willing to pick trivial-bandwidth nodes
for "fast" connections.


svn:r5992
 2006-02-13 00:09:30 +00:00
Nick Mathewson
dba155ecff Generate 18.0.0.0/8 address policy format in descs when we can; warn when the mask is not reducible to a bit-prefix. 
svn:r5991
 2006-02-12 23:58:22 +00:00
Roger Dingledine
b99f903e34 and don't warn when it happens here either, unless the user 
wants to hear it.


svn:r5990
 2006-02-12 23:44:02 +00:00
Roger Dingledine
53c54b75c9 Correct a function comment. Nick: is this right? 
svn:r5989
 2006-02-12 23:34:03 +00:00
Roger Dingledine
97571a1cb4 don't tell ordinary users about broken directory servers. 
it's a shame that they're broken, but most people are just
confused by the warning.


svn:r5988
 2006-02-12 23:31:47 +00:00
Nick Mathewson
98ec124c6a Drop redundant exit policy entries, not just identical ones. 
svn:r5987
 2006-02-12 22:59:38 +00:00
Nick Mathewson
e7b2d5cd47 Retain unrecognized options in state file, so that we can be forward-compatible. 
svn:r5985
 2006-02-12 22:28:30 +00:00
Nick Mathewson
ae4f0467c8 enforce whitespace style 
svn:r5984
 2006-02-12 22:27:09 +00:00
Roger Dingledine
3c4e68488b Clients now honor the "guard" flag in the router status when 
picking entry guards, rather than looking at is_fast or is_stable.

Now dirservers can change how they define it and clients will
automatically use their new definition.


svn:r5979
 2006-02-12 03:43:39 +00:00
Roger Dingledine
940b0a4d2e write a better note in torrc.sample about whether to set dirport. 
svn:r5978
 2006-02-12 01:12:52 +00:00
Roger Dingledine
b5ac6fc707 more helpful log message when running servers on obsolete windows. 
svn:r5975
 2006-02-12 00:14:58 +00:00
Roger Dingledine
094ccd34a9 bump up the period for forcing a hidden service descriptor upload 
from 20 minutes to 1 hour.


svn:r5972
 2006-02-12 00:12:36 +00:00
Roger Dingledine
981815146a compress exit policies even more -- look for duplicate lines 
and remove them.


svn:r5971
 2006-02-12 00:03:06 +00:00
Roger Dingledine
6c093a17a9 bugfix in config_cmp_addr_policies() -- we were treating a pair 
of exit policies if they were equal even if one said accept and
the other said reject.


svn:r5970
 2006-02-11 23:47:24 +00:00
Roger Dingledine
fdf18fbbdb stop leaking that 
svn:r5969
 2006-02-11 23:16:13 +00:00
Roger Dingledine
e847085c04 When a client asks for an old-style directory and our write bucket 
is empty, don't give it to him. This way small servers can continue
to serve the directory *sometimes*, without getting overloaded.


svn:r5968
 2006-02-11 23:15:40 +00:00
Nick Mathewson
f1b91924b2 Keep running if we ask for an impossible stdout log; just warn. 
svn:r5964
 2006-02-11 21:56:03 +00:00
Nick Mathewson
1dc90be4f0 Retry pending server downloads as well as pending networkstatus downloads when we unexpectedly get an app connection 
svn:r5962
 2006-02-11 21:29:12 +00:00
Nick Mathewson
91847124bf Warn if running obsolete windows as a server. 
svn:r5961
 2006-02-11 21:26:40 +00:00
Roger Dingledine
bb890da4cf bump to 0.1.1.13-alpha-cvs -- progress! 
svn:r5954
 2006-02-10 12:26:28 +00:00
Roger Dingledine
ddb43de2d0 bump to 0.1.1.13-alpha 
svn:r5951
 2006-02-09 22:55:40 +00:00
Roger Dingledine
85a64b4fd0 get our grammar right when complaining about un-recommended versions 
svn:r5950
 2006-02-09 06:08:59 +00:00
Roger Dingledine
5f051574d5 Happy new year! 
svn:r5949
 2006-02-09 05:46:49 +00:00
Roger Dingledine
2e5bd47555 more cleanups on the sample torrc file 
svn:r5947
 2006-02-09 05:18:03 +00:00
Roger Dingledine
fd0fcdf17c stop calling it a "libevent poll" -- the word "poll" has 
other meaning in this context that are confusing.


svn:r5936
 2006-02-09 03:09:52 +00:00
Roger Dingledine
28f3765b5a and maybe some function documentation will help too 
svn:r5935
 2006-02-09 02:59:37 +00:00
Roger Dingledine
dbea401305 correct the comments that don't realize it's the opposite 
svn:r5934
 2006-02-09 02:59:26 +00:00
Roger Dingledine
31f2705d9a and make sure that never happens again 
svn:r5932
 2006-02-09 02:42:33 +00:00
Roger Dingledine
2c221dd8db fix bug 245: When modifying the orconn_circid_map map, we would 
sometimes decrement conn->n_circuits even when there was no circuit
originally. This caused conn->n_circuits to go negative.

We noticed this because we were checking if connections can be
closed based on conn->n_circuits == 0, so we were never closing
any connection that had ever had a circuit on it.


svn:r5931
 2006-02-09 02:42:15 +00:00
Roger Dingledine
1c596156aa tweak comment 
svn:r5930
 2006-02-09 00:08:23 +00:00
Nick Mathewson
e5a574ce2e Move "sort list of versions" logic into routerparse.c; make version-checking code say which versions it would have accepted. (not tested.) 
svn:r5927
 2006-02-06 05:04:27 +00:00
Nick Mathewson
2bb4fd24de char *x = "y"; is not good C. 
svn:r5926
 2006-02-06 05:01:44 +00:00
Nick Mathewson
50e1005327 Only v1 authorities get hidden service descriptors with current protocol 
svn:r5924
 2006-02-06 04:56:18 +00:00
Nick Mathewson
97bff8edaa Fix a const-non-const warning 
svn:r5923
 2006-02-06 04:55:27 +00:00
Roger Dingledine
a9c87fe251 more typos and nits 
svn:r5918
 2006-02-05 05:28:52 +00:00
Nick Mathewson
157e6a025a Stupid cut-and-paste bug. 
svn:r5917
 2006-02-05 05:11:24 +00:00
Roger Dingledine
555a64e06d as soon as we've fetched some more directory info, that's time 
to think about downloading more server descriptors. this way
we don't have a 10 second pause in initial bootstrapping.


svn:r5916
 2006-02-05 03:42:34 +00:00
Roger Dingledine
d602d0d298 cosmetic fix 
svn:r5915
 2006-02-05 03:42:04 +00:00
Roger Dingledine
640882c76c clean up tabs and wide-lines from weasel's commit 
svn:r5914
 2006-02-05 03:23:16 +00:00
Roger Dingledine
6535087845 when building v2 statuses or v1 running-routers, don't admit the 
existence of descriptors older than a day.

we still cache them in case anybody asks, but we don't actively
mention them.


svn:r5913
 2006-02-05 02:33:40 +00:00
Roger Dingledine
53f86cdf5d fix bug: we were caching the newest descriptor for each server, 
well, forever. i imagine this just keeps growing in size.


svn:r5912
 2006-02-05 02:07:28 +00:00
Roger Dingledine
4c1fa73c7e typos and nits 
svn:r5911
 2006-02-05 01:57:27 +00:00
Roger Dingledine
a53a73a782 forward-port the part where ordinary users try to fetch directories 
less often. not critical but might as well stay in sync with stable.


svn:r5910
 2006-02-05 01:57:07 +00:00
Roger Dingledine
640c555f02 Fix a major load balance bug: we were round-robining in 16 KB chunks, and 
servers with bandwidthrate of 20 KB, while downloading a 600 KB directory,
would starve their other connections. Now we try to be a bit more fair.


svn:r5906
 2006-02-04 08:58:51 +00:00
Roger Dingledine
032a01ef64 just because you support the feature does not mean that you 
should put an example in the sample torrc file.

the debug-info lines were causing some people to think that
was a smart loglevel to use, and it also always isn't.


svn:r5905
 2006-02-04 07:45:40 +00:00
Peter Palfrader
94fb3f06b3 Fix compiler warning on 64 bit archs 
svn:r5903
 2006-02-03 22:26:43 +00:00
Peter Palfrader
390bbb0a0c Try to make tor work better through squid: Limit number of descriptors we fetch 
to 96 (was 128 previously).

We limit this number even when we do not have a http proxy explicitly
configured as some people mistakenly believe transparent proxies are a neat
idea.


svn:r5901
 2006-02-03 15:17:48 +00:00
Roger Dingledine
a1dd751f30 when we fail to bind a listener, try to provide a more useful log msg. 
svn:r5900
 2006-02-03 12:26:10 +00:00
Roger Dingledine
6f579deff4 check for EADDRINUSE in a cross-platform way (unless i'm wrong) 
svn:r5899
 2006-02-03 12:25:46 +00:00
Roger Dingledine
1800fbe486 don't warn when we receive a 503 from a dirserver/cache -- this 
will pave the way for them being able to tell us to screw off
if they're busy.


svn:r5898
 2006-02-03 12:08:31 +00:00
Roger Dingledine
0fadf0aad6 Fix bug 225: now "attachstream 0" treats conn like it just connected, 
doing address remapping, handling .exit and .onion idioms, and so on.

Now we are more uniform in making sure that the controller hears about
all new connections, and making sure it hears when they close.


svn:r5897
 2006-02-03 11:37:19 +00:00
Roger Dingledine
418dc7b16e I believe this resolves bug 234, the mysterious crash on 0.1.1.9 
and later servers. I'm not sure yet, but better to have it in CVS
while we speculate that it's the fix.


svn:r5895
 2006-02-02 10:10:07 +00:00
Roger Dingledine
92ef9e37e7 Add a new config option ExitPolicyRejectPrivate which defaults to 1. 
This means all exit policies will begin with rejecting private addresses,
unless the server operator explicitly turns it off.

Also, make our code to remove redundancies in the exit policy smarter,
so it can detect "reject foo, reject bar, reject *" patterns.

Lastly, we can get rid of the "exit policy implicitly accepts" code,
since we make everything more explicit now.


svn:r5888
 2006-02-01 03:53:52 +00:00
Roger Dingledine
bdba6e42dc avoid a minor confusing log message 
svn:r5887
 2006-02-01 03:05:52 +00:00
Peter Palfrader
bf514e5dc5 Try to fix policy_includes_addr_mask_implicitly() 
svn:r5886
 2006-02-01 02:52:55 +00:00
Peter Palfrader
61ea27620a Also catch 0/8 in exit_policy_implicitly_allows_local_networks() 
svn:r5885
 2006-02-01 02:31:27 +00:00
Roger Dingledine
686508a04a don't try to upload hidden service descriptors until we have 
established a circuit.


svn:r5884
 2006-02-01 02:19:46 +00:00
Peter Palfrader
dbf2e10460 Apply Matt Ghali's --with-syslog-facility patch 
svn:r5883
 2006-02-01 02:15:44 +00:00
Roger Dingledine
e05d4e45d2 provide a more useful warn message when our onion queue 
gets full.


svn:r5881
 2006-01-31 08:17:00 +00:00
Roger Dingledine
8fc44169e5 only start testing reachability once we've established a circuit. 
this will make startup on dirservers less noisy.
it may also break things in subtle ways.


svn:r5878
 2006-01-29 01:11:41 +00:00
Roger Dingledine
f8b9a8d457 bump the default bandwidthrate to 3 MB, and burst to 6 MB 
svn:r5874
 2006-01-28 08:28:15 +00:00
Roger Dingledine
35f91db15f a slightly more useful message when you get a sighup 
svn:r5869
 2006-01-26 19:11:06 +00:00
Nick Mathewson
bfe285be61 Add a missing printf arg 
svn:r5861
 2006-01-24 04:01:13 +00:00
Roger Dingledine
2eabf190e9 make it louder when we're running an unrecommended version. 
also, we need to tell them what versions *are* recommended.
i'll add that to the todo.


svn:r5859
 2006-01-24 03:45:58 +00:00
Nick Mathewson
9f42c9d650 Make dirservers generate a separate "guard" flag to mean, "would make a good entry guard". Make clients parse it and vote on it. 
svn:r5856
 2006-01-24 00:31:16 +00:00
Roger Dingledine
f1864dfff3 On systems that don't have getrlimit (like windows), we were artificially 
constraining ourselves to a max of 1024 connections. Now if there is no
getrlimit, just assume that we can handle the whole 15000 connections.

The better answer is to find a getrlimit equivalent on Windows, but hey,
one step at a time.


svn:r5854
 2006-01-23 23:39:13 +00:00
Roger Dingledine
1756ebdd4e Jan 23 02:39:44.856 [warn] rend_mid_rendezvous(): Rejecting RENDEZVOUS1 cell with unrecognized rendezvous cookie AFC097FD. 
This is not anything that the server admin can deal with, so don't
complain this loudly.


svn:r5851
 2006-01-23 09:26:22 +00:00
Roger Dingledine
de13ddd26f Stop complaining loudly whenever some poor client falls off 
the network before we finish writing to him.


svn:r5850
 2006-01-23 09:23:04 +00:00
Nick Mathewson
45757dafb7 Split PARANOIA_B into B1 and B2. 
svn:r5849
 2006-01-22 18:22:04 +00:00
Roger Dingledine
b9540285af remove unused code 
svn:r5847
 2006-01-20 20:54:42 +00:00
Roger Dingledine
f6084cf831 Jan 18 18:42:05.671 [debug] Encountered eof 
Jan 18 18:42:05.671 [debug] Got data, not eof. Leaving on inbuf.

that's not very smart.


svn:r5843
 2006-01-19 11:21:28 +00:00
Roger Dingledine
4a66f5a896 when the controller asks for a signal we don't recognize, don't 
include the whitespace/newline/etc in our complaint.


svn:r5841
 2006-01-19 02:21:24 +00:00
Nick Mathewson
241310bbac Split 0119_PARANOIA into 0119_PARANOIA_[ABC]. A is "this is suspicious, and we have not tried running without this yet". B is "this is suspicious, but the last time we tested, it was okay." C is "How could this possibly be the cause?" 
svn:r5840
 2006-01-17 23:08:38 +00:00
Roger Dingledine
d682c84e79 attempted patch for bug 220: don't assert when we've tried all the 
intro points for a hidden service and we try fetching the service
descriptor again.


svn:r5838
 2006-01-17 04:16:59 +00:00
Roger Dingledine
d5acef191c add another assert to make sure we're not scribbling on the stack. 
svn:r5837
 2006-01-17 04:14:04 +00:00
Roger Dingledine
cca9a2f7b0 oh, and the other bits of the commit 
svn:r5836
 2006-01-17 04:03:23 +00:00
Roger Dingledine
21be9dc3c0 when you tried to set orport through the controller, it would 
trigger an assert because you hadn't made your onion keys yet
you wanted to launch cpu workers.

now init keys first, reset uptime, and tell the user that we're
starting the reachability testing.


svn:r5835
 2006-01-17 04:01:32 +00:00
Roger Dingledine
76f1b7415b try to detect an assert error earlier 
svn:r5834
 2006-01-17 02:31:04 +00:00
Roger Dingledine
1c4822802f take AllowUnverifiedNodes out of the sample torrc 
svn:r5832
 2006-01-17 01:09:58 +00:00
Nick Mathewson
1057516a07 Clients should not download descriptors for non-running descriptors. 
svn:r5830
 2006-01-16 20:52:30 +00:00
Roger Dingledine
f0d4b3d18f turn crypto hardware acceleration off by default, until we find 
somebody smart who can test it for us.


svn:r5829
 2006-01-16 20:08:33 +00:00
Nick Mathewson
2dd566d5d5 Indirect access to the signed_descriptor field to make it easier to keep them lazily on disk. 
svn:r5827
 2006-01-12 18:04:17 +00:00
Roger Dingledine
2c26d77bf0 bump to 0.1.1.12-alpha-cvs 
svn:r5825
 2006-01-12 05:08:20 +00:00
Roger Dingledine
0e51d5d274 When the controller was submitting a descriptor, we were checking to make 
sure some network-status we had referred to it, and refusing it if not.
This is bad for people who want to insert descriptors that aren't part of
the current Tor network. Now we accept them, and also give a more useful
warn message if we ask a dir mirror for a given descriptor and it gives us
one we weren't expecting.


svn:r5824
 2006-01-12 03:43:39 +00:00
Roger Dingledine
aa070a3301 bump to 0.1.1.12-alpha 
ha ha


svn:r5808
 2006-01-11 22:36:32 +00:00
Roger Dingledine
54a7285e99 oh hey. we were hanging up on every tor client because he 
was obsolete as soon as he started. big oops.


svn:r5807
 2006-01-11 22:34:07 +00:00
Nick Mathewson
c562ca494a add missing warning 
svn:r5806
 2006-01-11 20:09:37 +00:00
Nick Mathewson
fefa34d525 Fix double-free of torrc_fname 
svn:r5805
 2006-01-11 20:01:47 +00:00
Nick Mathewson
adbe0f0ada Fix bug 240: dont dump descriptions when not dumping actual config lines. 
svn:r5804
 2006-01-11 19:43:14 +00:00
Nick Mathewson
099b9ce2f9 Fix bug 230: add a rollback function to reverse all changes since the last mark_logs_temp(), and move log initialization into the two-phase part of option setting. 
svn:r5803
 2006-01-11 19:40:14 +00:00
Roger Dingledine
a8bb654c2b bump to 0.1.1.11-alpha-cvs 
svn:r5799
 2006-01-11 06:19:00 +00:00
Roger Dingledine
5ca40affeb we were leaking a smartlist every time we built a circuit 
svn:r5795
 2006-01-11 04:14:10 +00:00
Nick Mathewson
d60faa7c93 Fix another memleak. I love you, valgrind! 
svn:r5794
 2006-01-11 04:09:40 +00:00
Nick Mathewson
8907391ad6 Fix wide lines 
svn:r5793
 2006-01-11 04:04:42 +00:00
Nick Mathewson
5c78c89471 Appease verbose gcc warning: make dirserv_compute_stable_uptime() static. 
svn:r5792
 2006-01-11 03:59:55 +00:00
Roger Dingledine
284fe9cad5 if we learn that a down entry guard is up, count our working entry 
guards correctly when logging.


svn:r5791
 2006-01-11 03:58:59 +00:00
Nick Mathewson
eb78295e4e Fix memory leak in routerlist_remove_old_routers(). 
svn:r5790
 2006-01-11 03:58:07 +00:00
Nick Mathewson
6a9ca9e790 Convert some more ints to long longs in rephist.c, as suggested by windows compiler. 
svn:r5789
 2006-01-11 03:57:01 +00:00
Roger Dingledine
d1baa0c4a6 we were leaking 3KB every time the entry guards changed, every time 
the controller called saveconf, and every 20 minutes.


svn:r5788
 2006-01-11 03:20:53 +00:00
Roger Dingledine
8f271f2f5a we changed the name of AccountingBytesReadInInterval 
change its state file description too


svn:r5785
 2006-01-10 23:26:59 +00:00
Roger Dingledine
906a2c8ef0 bump to 0.1.1.11-alpha in preparation for release 
svn:r5783
 2006-01-10 23:16:36 +00:00
Roger Dingledine
7d1f675c85 entry nodes are now entry guards. 
this is our last easy chance for a wholesale change. heave ho.


svn:r5782
 2006-01-10 22:42:44 +00:00
Nick Mathewson
55ac4f032c Add a (diabled by default) option in crypto.h to disable most of the interesting crypto-related changes made on 0.1.1.9. This will help hunt bug 234. 
svn:r5777
 2006-01-10 21:12:06 +00:00
Roger Dingledine
210d9db54d and even more so 
svn:r5776
 2006-01-10 21:01:30 +00:00
Roger Dingledine
aea0a78254 make entry node logging slightly less chatty. 
still quite chatty. it's an alpha, that's ok.


svn:r5775
 2006-01-10 20:59:39 +00:00
Nick Mathewson
bef879540a #undef FOO is cleaner than #define FOO_XX 
svn:r5774
 2006-01-10 20:50:22 +00:00
Nick Mathewson
4a7ee9bd3d Make unittests pass again. 
svn:r5773
 2006-01-10 20:47:24 +00:00
Roger Dingledine
b2d79f278b or_state_validate() needs an extra arg too or it will crash 
svn:r5772
 2006-01-10 20:38:33 +00:00
Roger Dingledine
f4299f0f44 hack to address bug 238. 
needs a better fix, but not for 0.1.1.11.


svn:r5771
 2006-01-10 20:27:47 +00:00
Roger Dingledine
d114ea7125 implement getinfo desc/all-recent 
closes bug 237.


svn:r5770
 2006-01-10 20:09:31 +00:00
Roger Dingledine
f71273c216 fix bug 235 
svn:r5768
 2006-01-10 20:06:24 +00:00
Nick Mathewson
7fc62029d4 Refuse to use RunAsDaemon when torrc is a relative path. Fixes bug 229. 
svn:r5767
 2006-01-10 20:00:20 +00:00
Nick Mathewson
e1d1ce3da8 Warn about actual offending hiddenservice* config option, now that more than one is possible. Closes bug 239. 
svn:r5766
 2006-01-10 19:28:31 +00:00
Nick Mathewson
2fda7140e8 Fix bug 221 and bug 201: For 221, check return value from connection_add() when adding a rendezvous post connection. For 201, do not include a content-length 0 with a GET request. 
svn:r5765
 2006-01-10 19:24:40 +00:00
Roger Dingledine
c8e6003412 balance the reachability testing so a smidgen of it happens 
every 10 seconds. this way we don't try to do 500 tls's at
once every 20 minutes.


svn:r5763
 2006-01-10 07:21:01 +00:00
Nick Mathewson
43a4f8c7f3 Be more aggressive about throwing away expired router descriptors: they are of no use to anybody. Better still: dont serve expired descriptors by fingerprint. The only people who ask for them are busted 0.1.1.10 Tors that will throw them away and re-request them after 30 minutes. 
svn:r5762
 2006-01-10 04:57:12 +00:00
Nick Mathewson
56c55c343e When picking a random directory, prefer non-authorities if any are known. 
svn:r5761
 2006-01-09 23:39:07 +00:00
Nick Mathewson
bec9b705cc Instrument directory client bytes as well as server bytes. 
svn:r5760
 2006-01-09 23:13:53 +00:00
Nick Mathewson
10100c4315 Make instrmentation code a little cleaner. 
svn:r5759
 2006-01-08 22:19:41 +00:00
Roger Dingledine
fa05c1b21b remove the loud logging of busted rendezvous descriptors 
svn:r5758
 2006-01-08 22:16:30 +00:00
Roger Dingledine
6dcbbda43b remove typo 
svn:r5757
 2006-01-08 22:16:09 +00:00
Nick Mathewson
ff9cfa9644 Instrument how many directory bytes we are serving in what kind of request. 
svn:r5756
 2006-01-08 22:09:54 +00:00
Nick Mathewson
5d709e8517 Fix bug in last commit. Also, fix bug 231: authorities should never treat their own descriptor changes as cosmetic. 
svn:r5755
 2006-01-08 21:33:15 +00:00
Nick Mathewson
e30516f33f Fix bug 236: caches should cache up to 16 unrecognized network-status docs. 
svn:r5754
 2006-01-08 21:26:33 +00:00
Roger Dingledine
1dd8ebf615 bugfix: we were leaving open duplicate connections to other ORs 
for a week, rather than closing them once we detect a duplicate.

also, avoid some duplicate mark-for-closes in connection-housekeeping.


svn:r5752
 2006-01-07 03:56:56 +00:00
Roger Dingledine
9796733e89 "Pending" is a bad term for a circuit that uses your server as its last hop. 
svn:r5751
 2006-01-07 02:31:14 +00:00
Roger Dingledine
d4d7a49411 fix typo 
svn:r5750
 2006-01-07 02:12:38 +00:00
Roger Dingledine
af54b73985 and get the log arguments right 
svn:r5747
 2006-01-07 01:43:09 +00:00
Roger Dingledine
ba339b8a4d a more correct log message 
svn:r5746
 2006-01-07 01:41:17 +00:00
Roger Dingledine
654b61a2e8 Jan 05 19:39:27.356 [warn] connection_edge_process_end_not_open(): 
Got an end because of misc error, but we're not an AP. Closing.


svn:r5744
 2006-01-07 01:02:21 +00:00
Roger Dingledine
f88fa3efc1 helper nodes are dead 
svn:r5743
 2006-01-07 00:41:50 +00:00
Nick Mathewson
50b6b3258d Dont call directory_get_from_dirserver when you have a particular dirserver in mind; remove fetch-from-authority special-case in directory_get_from_dirserver. 
svn:r5741
 2006-01-06 18:19:17 +00:00
Nick Mathewson
f0fb9f6b0c Directory authorities should go to the proper authority when asking for a networkstatus, even when they want a compressed one. (Also, bullet-proof the logic in case we ever accidentally request a networkstatus for a non-authority.) 
svn:r5740
 2006-01-06 18:05:48 +00:00
Nick Mathewson
65f76bad4f Add descriptions for state variables; rename AccountingBytesRead{In}Interval; remove extraneous and unused struct member. 
svn:r5739
 2006-01-06 15:43:03 +00:00
Nick Mathewson
447e6ffffd Fix bug where OPs would try to generate descriptor and crash. 
svn:r5738
 2006-01-06 15:40:34 +00:00
Nick Mathewson
878962bee1 Add reasons to DESTROY and RELAY_TRUNCATED cells. 
svn:r5734
 2006-01-05 21:23:03 +00:00
Roger Dingledine
d8e3bc0288 fix a wrong string 
svn:r5733
 2006-01-05 12:18:34 +00:00
Roger Dingledine
6aaa92f736 short-circuit half the cost of node-picking in the general case. 
svn:r5732
 2006-01-05 10:59:46 +00:00
Roger Dingledine
1107c40dc0 mention a recommended log level in the sample torrc file 
svn:r5731
 2006-01-05 10:37:22 +00:00
Roger Dingledine
f8a59965a1 cleanups, and remove some unreachable code. 
svn:r5727
 2006-01-04 06:43:03 +00:00
Roger Dingledine
485aa9415d authdirs now stop whining so loudly about bad descriptors that they fetch 
from other dirservers. now when there's a log complaint, it's for sure
from a freshly uploaded descriptor.


svn:r5726
 2006-01-04 04:42:10 +00:00
Roger Dingledine
6b2a6a8239 Bugfix: dyndns tor servers were needing to wait 18 hours before they 
could start doing reachability testing using the new IP address and
ports. This is because we were using the internal descriptor to learn
what to test, yet we were only rebuilding the descriptor once we
decided we were reachable.


svn:r5723
 2006-01-03 23:34:42 +00:00
Roger Dingledine
f6f65c66b5 oh, it was supposed to compile? 
svn:r5721
 2006-01-03 13:12:17 +00:00
Roger Dingledine
da06f3553c don't try to build circuits until we have 3 running servers; 
and for networks that are very small, having more than a quarter
of the descriptors is much harder than having equal to or more than
a quarter of the descriptors -- follow the spec.


svn:r5720
 2006-01-03 13:09:49 +00:00
Roger Dingledine
5d28b7b884 we're done with tree.h. long live ht.h. 
svn:r5715
 2006-01-03 12:35:58 +00:00
Roger Dingledine
9af33ef39c when we choose not to use a server descriptor from our cache, don't 
log it so loudly.


svn:r5713
 2006-01-03 10:42:20 +00:00
Roger Dingledine
4f033b0028 make the commenting in the torrc.sample consistent, and try to 
explain in it what comments are.


svn:r5711
 2006-01-03 00:45:12 +00:00
Roger Dingledine
16ee6830b6 only print bandwidth lines to the state file if we're being a server. 
otherwise this is pointless and probably bad for security.


svn:r5704
 2006-01-02 12:19:28 +00:00
Roger Dingledine
1d474e14d7 strictentrynodes means we should clear the current entry_nodes list. 
svn:r5703
 2006-01-02 11:33:14 +00:00
Roger Dingledine
c5a5161fb5 prevent auth dir servers from enabling entry nodes. 
svn:r5702
 2006-01-02 08:40:58 +00:00
Roger Dingledine
358052416d bugfix: only try to use the EntryNodes config option if it is set. 
svn:r5701
 2006-01-02 05:14:21 +00:00
Roger Dingledine
ddf070e204 bugfix: we were failing to parse a tor version that started with 
"Tor ", even though we said we could.


svn:r5699
 2006-01-02 05:11:31 +00:00
Roger Dingledine
ea6ea8ec22 Make UseEntryNodes true by default. Let the fun begin. 
svn:r5698
 2006-01-02 05:00:03 +00:00
Roger Dingledine
aa604ef2c2 bugfix: only try to parse the TorVersion if there is one. 
svn:r5697
 2006-01-02 04:58:12 +00:00
Roger Dingledine
839111b85a tolerate a mal-formed or unrecognized tor version in the state file. 
svn:r5696
 2006-01-02 04:45:18 +00:00
Roger Dingledine
a45b131590 check for integer overflows in more places, when adding elements to 
smartlists. this could possibly prevent a buffer overflow on malicious
huge inputs. i don't see any, but i haven't looked carefully.


svn:r5695
 2006-01-02 04:40:18 +00:00
Roger Dingledine
0bd25f5d43 save and validate TorVersion in the state file. 
svn:r5694
 2006-01-02 04:14:52 +00:00
Roger Dingledine
2efa056777 make the "stable" flag in network-status be the median of the uptimes 
of running valid servers. that way the cutoff adapts to the stability
of the network as a whole.


svn:r5693
 2006-01-02 03:32:55 +00:00
Nick Mathewson
4868d77ab8 Possible fix to state-load bug reported by weasel. 
svn:r5692
 2006-01-02 00:42:19 +00:00
Nick Mathewson
0da2069643 Clearner fix for timegm assert problem. 
svn:r5690
 2006-01-01 23:13:19 +00:00
Nick Mathewson
04db9de847 Fix assertion-trigger bug found by sjmurdoch 
svn:r5689
 2006-01-01 23:09:19 +00:00
Peter Palfrader
3dc69d3add Make tor compile again 
svn:r5688
 2005-12-31 11:52:13 +00:00
Roger Dingledine
6c693dbda6 add a TorVersion state string. 
not yet set to anything.


svn:r5687
 2005-12-31 08:16:07 +00:00
Roger Dingledine
e9e7dc176c Some tor servers process billions of cells in a matter of days. 
These statistics need to be uint64_t's.


svn:r5686
 2005-12-31 08:09:26 +00:00
Roger Dingledine
1a11b97b15 get rid of the special case for 'testing' circuits 
svn:r5684
 2005-12-31 06:37:34 +00:00
Roger Dingledine
5947388968 Finish implementing config's EntryNodes and StrictEntryNodes option. 
The logging is way verbose for now.


svn:r5683
 2005-12-31 06:32:57 +00:00
Roger Dingledine
6005e110b9 whitespace fixes 
svn:r5682
 2005-12-31 06:26:10 +00:00
Roger Dingledine
0dc8e284f8 load balance a bit better by taking some load off the really 
fast servers.
this might slow things down more, or it might not. hm.


svn:r5681
 2005-12-30 04:46:43 +00:00
Roger Dingledine
c051e82f69 fix a typo 
svn:r5680
 2005-12-30 04:44:10 +00:00
Nick Mathewson
fc850273bd Appease some verbose GCC warnings. 
svn:r5679
 2005-12-29 20:25:53 +00:00
Roger Dingledine
2904c6f024 log how big the failed rend descriptor is, and if it's small, log 
a base16 of the whole thing.


svn:r5678
 2005-12-29 04:57:19 +00:00
Roger Dingledine
14ea2e0b56 when we reject a rend descriptor, tell us where it came from. 
svn:r5677
 2005-12-29 04:43:24 +00:00
Roger Dingledine
dbd7b97eff helper nodes are dead. long live entry nodes. 
(config options EntryNodes and StrictEntryNodes still not
implemented.)


svn:r5673
 2005-12-28 09:07:31 +00:00
Roger Dingledine
5d9256a367 but only close the new conn if one of the earlier helper nodes 
that we mark up is actually reachable, fast enough, etc to use.


svn:r5672
 2005-12-28 07:27:41 +00:00
Roger Dingledine
c1145138ea but only close it if we have marked an earlier helper as up. 
that way we don't close it too needlessly.


svn:r5671
 2005-12-28 07:20:33 +00:00
Roger Dingledine
60cd03069a when we connect to a helper node for the first time, close 
that connection and its circuits. this lets us go back to
using the old helper nodes rather than immediately using
the last one in the list.


svn:r5670
 2005-12-28 07:19:55 +00:00
Roger Dingledine
bbc4c8cef8 fix a spacing problem introduced by our 80-column requirement 
svn:r5669
 2005-12-27 10:11:29 +00:00
Roger Dingledine
d2171cb7a4 if the network is down, and we try to connect to a conn because we 
have a circuit in mind, and we timeout (30 seconds) because the
network never answers, we were expiring the circuit, but we weren't
obsoleting the connection or telling the helper functions. now do that.


svn:r5668
 2005-12-27 09:25:50 +00:00
Roger Dingledine
4088f7dfd1 fix typo 
svn:r5667
 2005-12-27 09:04:36 +00:00
Roger Dingledine
f46c135fac when we succeed at connecting to a helper that we've never connected 
to before, mark all the previous helpers as up. This is handy if the
network went away and then returned.


svn:r5666
 2005-12-27 08:54:37 +00:00
Roger Dingledine
25fcb5fa9c helpful log 
svn:r5665
 2005-12-27 08:38:22 +00:00
Roger Dingledine
976bf06463 slightly more accurate log messages 
svn:r5664
 2005-12-27 07:37:21 +00:00
Roger Dingledine
25052c6f4b first cut of the new helper stuff. seems to work in the normal 
case, but many edge cases still need testing.


svn:r5663
 2005-12-27 07:23:52 +00:00
Nick Mathewson
9ef54a3d0c Make directory caches a little less chatty when logging 
svn:r5662
 2005-12-27 06:05:54 +00:00
Nick Mathewson
fa0d5aa894 Make insert_old try hard to never add a duplicate. 
svn:r5661
 2005-12-27 05:58:12 +00:00
Nick Mathewson
ece9865020 Implement new directory logic: download by descriptor digest, not by key digest. Caches try to download all listed digests from authorities; clients try to download "best" digests from caches. 
svn:r5659
 2005-12-27 05:26:03 +00:00
Nick Mathewson
d94b9fd7d2 normalize spaces 
svn:r5658
 2005-12-27 04:52:34 +00:00
Roger Dingledine
94bff33357 and compiling would be good too 
svn:r5657
 2005-12-27 02:48:35 +00:00
Roger Dingledine
370dcbc7ba and some comments 
svn:r5656
 2005-12-27 02:48:02 +00:00
Roger Dingledine
5807bd0635 make it clearer in the auto-generated config file that you 
probably shouldn't be editing this one yourself.


svn:r5655
 2005-12-27 02:46:53 +00:00
Roger Dingledine
b038dc9ecc disambiguate some debug entries 
svn:r5654
 2005-12-26 22:42:22 +00:00
Roger Dingledine
815df977cf comments? i'll show you comments. 
svn:r5652
 2005-12-26 05:52:44 +00:00
Roger Dingledine
40c267a89f prevent a rare infinite loop on two-byte architectures, 
and be more thorough and starting over when the clock jumps.


svn:r5647
 2005-12-25 04:37:33 +00:00
Roger Dingledine
7e0d62b14a stop being sneaky, especially if we're being incorrectly sneaky 
svn:r5646
 2005-12-24 23:39:20 +00:00
Roger Dingledine
b0144276db more comments, and start to use the made_contact entry. 
svn:r5645
 2005-12-24 23:32:35 +00:00
Roger Dingledine
7cc53c2281 clean up some comments 
svn:r5644
 2005-12-24 23:32:15 +00:00
Roger Dingledine
35986a2374 simplify because we weren't using those return values anyway 
svn:r5643
 2005-12-24 22:48:12 +00:00
Roger Dingledine
3a2ce447b4 start to document the helper node functions 
svn:r5642
 2005-12-24 20:07:19 +00:00
Peter Palfrader
4bd65f0f98 Keep bandwidth history accross restarts/crashes 
svn:r5637
 2005-12-23 23:56:42 +00:00
Roger Dingledine
eecb835527 stop shipping tree.h, since we don't use anymore. (woo.) 
svn:r5628
 2005-12-20 07:17:42 +00:00
Roger Dingledine
bb4662365b when we fail three times to resolve or connect, we were telling the 
user it was because we failed to resolve.


svn:r5620
 2005-12-19 21:56:43 +00:00
Roger Dingledine
da01657c34 more asserts in case weasel can trigger them 
svn:r5616
 2005-12-19 00:35:18 +00:00
Roger Dingledine
7cd46d7f95 fix a seg fault when you finish connecting to a server but 
at that moment you dump his server descriptor, and you also
happen to be logging at loglevel info.
(found by weasel)


svn:r5615
 2005-12-18 22:59:47 +00:00
Roger Dingledine
34249e8861 fix segfault when specifying DirServer without nickname 
(reported by weasel)


svn:r5614
 2005-12-18 22:45:27 +00:00
Roger Dingledine
a2186b9999 fix a ! that got left out 
svn:r5612
 2005-12-18 22:34:24 +00:00
Nick Mathewson
6b5fc9d46f Instead of "Network down", say "Is your network connection down?" 
svn:r5607
 2005-12-15 22:10:03 +00:00
Roger Dingledine
a6afef700a nother typo 
svn:r5605
 2005-12-15 21:51:12 +00:00
Roger Dingledine
edde3fcf25 ah ha, that variable was static. not useless after all. 
svn:r5604
 2005-12-15 21:44:23 +00:00
Roger Dingledine
002c9b3589 clean up a lot message, and remove a line that does nothing. 
svn:r5603
 2005-12-15 21:41:27 +00:00
Nick Mathewson
89eded7b17 Add "panic" option to reject all servers not in fingerprint list. 
svn:r5601
 2005-12-15 21:39:38 +00:00
Nick Mathewson
cf8c70b79c fix compile 
svn:r5600
 2005-12-15 21:38:59 +00:00
Nick Mathewson
280c62314e Make clients look at the fast and stable flags in networkstatus, not at the bandwidth and uptime declared in the router descriptors. 
svn:r5599
 2005-12-15 21:30:57 +00:00
Roger Dingledine
3489066433 put back in a todo comment, so we don't forget. 
svn:r5598
 2005-12-15 21:26:52 +00:00
Roger Dingledine
dadcb19d17 fix typo 
svn:r5597
 2005-12-15 21:26:39 +00:00
Nick Mathewson
24e79df0b6 Whitespace fixes; comments. 
svn:r5596
 2005-12-15 21:17:40 +00:00
Nick Mathewson
713c995adb Do not mark directories as down simply because they dont have the router descs we want. 
svn:r5595
 2005-12-15 21:15:16 +00:00
Nick Mathewson
5965b3849e Remove some redundant and obsolete code from routerparse 
svn:r5594
 2005-12-15 20:58:51 +00:00
Nick Mathewson
6b1305aeeb Flip a misplaced not 
svn:r5593
 2005-12-15 20:56:46 +00:00
Nick Mathewson
3ea32f51cb add a few clarifying comments 
svn:r5592
 2005-12-15 20:49:01 +00:00
Nick Mathewson
ce71b17224 Clean fake_status a bit. Switch from has_fetched_directory to have_minimum_dir_info, and make the latter function smarter. 
svn:r5591
 2005-12-15 20:44:15 +00:00
Roger Dingledine
25e1ad02fa implement weasel's suggestion to fix the bug that newly bootstrapped 
tor networks couldn't do hidden services until they had nodes with high
uptime: if you're trying to pick a node for your circuit and you demand
uptime or capacity and nothing works, then abandon your need for uptime
and capacity.


svn:r5589
 2005-12-15 09:53:00 +00:00
Nick Mathewson
7af95e5c06 When we mark a router as down, also mark its local_routerstatus as not running. This way, we do not use directories that are believed to be down. 
svn:r5587
 2005-12-14 22:05:10 +00:00
Nick Mathewson
9482b1b9d5 Choose directory servers from routerstatus list, not from routerinfo list. This way, as soon was we have a networkstatus, we can ask a cache to give us routers, rather than needing to ask the directories. 
svn:r5586
 2005-12-14 22:00:58 +00:00
Nick Mathewson
7e6a41af93 Make hashtables use a little less space on 64-bit architectures. 
svn:r5585
 2005-12-14 21:10:06 +00:00
Nick Mathewson
c02c6b5823 Shave off 8 bytes per connection and 4 bytes per circuit by paying attention to padding warnings, moving fields around, and acknowledging that we have no files with over 64 kilolines. 
svn:r5583
 2005-12-14 21:03:51 +00:00
Nick Mathewson
1af630d32c Bite the bullet and limit all our source lines to 80 characters, the way IBM intended. 
svn:r5582
 2005-12-14 20:40:40 +00:00
Nick Mathewson
7e632a7564 another possible patch related to circuit_free and memory stomping. 
svn:r5580
 2005-12-14 18:55:17 +00:00
Nick Mathewson
4f38670328 Fix a potential memory stomp on servers running hidden services. Found by weasel with valgrind. Backport candidate. 
svn:r5579
 2005-12-14 02:19:27 +00:00
Roger Dingledine
86d69218ef orconn_identity_map was another static variable that started 
out NULL and didn't change until it needed to change.


svn:r5578
 2005-12-14 01:02:35 +00:00
Roger Dingledine
c9f6e6b0a0 sometimes, when we just started tor, we haven't created that 
smartlist yet. so don't free it.


svn:r5577
 2005-12-14 00:52:15 +00:00
Roger Dingledine
d853c9a009 bugfix: when we removed a dead helper node, we never committed that 
change to disk.


svn:r5576
 2005-12-13 02:52:38 +00:00
Roger Dingledine
ea760fa149 extendcircuit and attachstream would complain about not enough 
arguments, but then just keep on going anyway.


svn:r5575
 2005-12-12 16:50:55 +00:00
Nick Mathewson
27a201ac80 Have dirctory authorites note which servers make good V2 directory caches in publishe network-status. 
svn:r5574
 2005-12-12 01:03:28 +00:00
Nick Mathewson
32126cced1 Make directory authorities ignore router uploads that have only cosmetic differences: now regardless of version! 
svn:r5573
 2005-12-12 01:02:08 +00:00
Roger Dingledine
bf4da967c1 Don't use helper nodes for circuits with purpose 'testing'. 
Also, when picking the helper node for a given circuit,
exclude the circuit's exit from your choices.


svn:r5569
 2005-12-11 12:14:26 +00:00
Roger Dingledine
a131783c8b when removing dead helpers, only write or_state to disk once at the 
end, not for every helper you remove.


svn:r5568
 2005-12-11 11:56:17 +00:00
Roger Dingledine
5981169440 mark the helper node as down if we time-out on the circuit handshake 
with him.


svn:r5567
 2005-12-11 11:55:41 +00:00
Roger Dingledine
dded1dd8bd don't mark the helper node as down when we fail to connect to 
our https proxy.


svn:r5566
 2005-12-11 11:54:55 +00:00
Roger Dingledine
9c01fa3d59 fix yet another time comparison bug. we were abandoning helpers 
as soon as they became unavailable. (is this true?)


svn:r5565
 2005-12-11 11:23:36 +00:00
Roger Dingledine
f3349d6ed3 fix an error in reporting why we abandoned a helper node 
svn:r5564
 2005-12-11 11:20:26 +00:00
Roger Dingledine
b974f67c01 choose helper nodes to have high capacity always 
svn:r5563
 2005-12-11 11:20:01 +00:00
Roger Dingledine
77c0f6d456 a first go at fixing a bug matt edman reported: when he tries 
to "setconf log" via the controller, it is friendly and gives
him a log to stdout, even though he didn't ask for one.


svn:r5562
 2005-12-11 10:01:21 +00:00
Roger Dingledine
79f09b2f17 setconf orport=9001 
513 Unrecognized option value

it's not unrecognized. it's unacceptable. (in this case, i still
have to consult the logs to figure out why, but at least i have
an inkling that maybe i should.)


svn:r5561
 2005-12-11 09:33:38 +00:00
Roger Dingledine
46d563fe00 whenever we hupped or did a controller setconf, we were prepending 
another reachableaddresses *:80,*:443 if fascistfirewall was set,
and we were appending another reject *:* regardless.


svn:r5560
 2005-12-11 09:18:25 +00:00
Roger Dingledine
a4e1014f4d i think fascistfirewall still has its uses. it's a synonym 
for a certain reachableaddresses line, but it's easier to
remember and people already understand it. i think we should
think about undeprecating it.


svn:r5559
 2005-12-11 08:59:02 +00:00
Roger Dingledine
c21666ca59 bump to 0.1.1.10-alpha-cvs 
svn:r5558
 2005-12-11 07:33:16 +00:00
Roger Dingledine
eaa864ed17 bump to 0.1.1.10-alpha 
svn:r5553
 2005-12-10 21:15:18 +00:00
Roger Dingledine
defa3804cf explain why 0.1.1.9-alpha-cvs is a special version. 
svn:r5552
 2005-12-10 21:07:21 +00:00
Roger Dingledine
58366ffd24 when we changed from log_fn to debug/info/notice/warn/err, 
we screwed up the formatting in wild and unpredictable ways.

fix it before it becomes convention to format logs in wild and
unpredictable ways.

still need to do src/common/ someday.


svn:r5551
 2005-12-10 09:36:26 +00:00
Roger Dingledine
9b0a40ec78 crank the max line limit down to 150 chars. 
svn:r5550
 2005-12-10 08:27:01 +00:00
Nick Mathewson
39265dd72e In my private little universe, terminals are still 80 columns. Impose a 160-character-per-line limit; this will creep down. 
svn:r5548
 2005-12-09 05:37:26 +00:00
Nick Mathewson
95e471c9a6 Normalize whitespace 
svn:r5547
 2005-12-09 05:22:15 +00:00
Nick Mathewson
33c4445846 For some bizarre reason, MSVC does not implement GCC extensions. Who would have thought? 
svn:r5546
 2005-12-09 05:20:02 +00:00
Nick Mathewson
a1bcdb2f76 util.c:1308: error: conflicting types for "is_internal_IP" 
svn:r5545
 2005-12-09 05:15:36 +00:00
Roger Dingledine
a438f2abcd let the user configure a sockslistenaddress on other private IPs 
besides 127.x.y.z without complaining.
and give a better message in the log.


svn:r5544
 2005-12-09 02:46:46 +00:00
Roger Dingledine
c0a6e2232c let is_internal_IP() know whether you're asking about an IP 
address for connecting or an IP address for binding, because
in the latter, 0.0.0.0 is a special case.


svn:r5543
 2005-12-09 02:45:33 +00:00
Nick Mathewson
d57029ffe8 Make code to handle "private" alias work when assume_action is set. 
svn:r5542
 2005-12-08 23:58:23 +00:00
Roger Dingledine
8730190914 when we're checking reachability, make it clearer in the logs 
what to expect.


svn:r5538
 2005-12-08 21:12:47 +00:00
Roger Dingledine
d3dcea08af remove a redundant memcpy when extending to a new server 
and attaching circuits to it.


svn:r5537
 2005-12-08 20:33:57 +00:00
Nick Mathewson
338f23114f Oops. 0.0.0.0/8 and 169.254.0.0/16 are also special. 
svn:r5536
 2005-12-08 19:58:14 +00:00
Nick Mathewson
2d585941b8 Release memory from conn_circid_circuit_map on exit. 
svn:r5535
 2005-12-08 19:46:22 +00:00
Nick Mathewson
1b770817c0 Add private:* as an alias in configuration for policies. 
svn:r5534
 2005-12-08 19:40:24 +00:00
Nick Mathewson
898968b3ac Warn when binding to a public address for socks. This warning needs to be improved. Also, make options_validate() only warn when an option is changed to a bad value.. (Previously, it warned when an option was bad and any option was changed.) 
svn:r5532
 2005-12-08 18:56:32 +00:00
Nick Mathewson
e9b66ec906 Document CREATE_FAST better in the code. Move our key expansion algorithm into a separate function in crypto.c 
svn:r5530
 2005-12-08 17:38:32 +00:00
Nick Mathewson
617f71e4ba Whitespace normalization 
svn:r5528
 2005-12-08 04:03:12 +00:00
Nick Mathewson
cf5facf3e1 Do not free a constant string. 
svn:r5527
 2005-12-08 04:01:37 +00:00
Nick Mathewson
f031ee8246 Make clients use CREATE_FAST cells. add an option to disable this. 
svn:r5524
 2005-12-07 22:09:02 +00:00
Roger Dingledine
130d0e4d1d fix typo noticed by scrimbly 
svn:r5522
 2005-12-07 19:49:18 +00:00
Roger Dingledine
4902ece698 what the heck is wrong with this little piece of code? 
why can none of us get it right?
it looks so simple.


svn:r5521
 2005-12-07 04:43:39 +00:00
Roger Dingledine
b0ffa34219 tell the controller about new .onion streams too. 
svn:r5520
 2005-12-06 23:43:52 +00:00
Roger Dingledine
485b2cb4dc get rid of nick's crazy voodoo dh checking. 
svn:r5518
 2005-12-06 23:09:44 +00:00
Roger Dingledine
5c0338dca3 the other half of weasel's patch, so old gcc's can build cvs again. 
svn:r5517
 2005-12-06 21:03:48 +00:00
Peter Palfrader
0dbb622f26 Old gccs want you to do your variable declarations first 
svn:r5516
 2005-12-06 17:01:36 +00:00
Roger Dingledine
3347762fa4 when we're giving up on a circuit and retrying on a new one, 
log the name of the exit node. perhaps people will find this
useful, or see patterns, or something.


svn:r5515
 2005-12-06 07:21:17 +00:00
Nick Mathewson
b1d034d2ab Fix bug 212: Directory authorities should not try to download server descriptors that they know they will reject. 
svn:r5514
 2005-12-06 06:55:43 +00:00
Nick Mathewson
d2123388ad Better fix for last bug: avoids trying to double-mark circuits. 
svn:r5511
 2005-12-05 19:45:54 +00:00
Nick Mathewson
fedc9c8a60 We were neglecting to unlink marked circuits from soon-to-close OR connections. 
svn:r5510
 2005-12-05 19:26:09 +00:00
Nick Mathewson
b03e8733f3 Change how OR conns get removed from the identity map; fix some warnings on shutdown. 
svn:r5509
 2005-12-05 19:15:27 +00:00
Nick Mathewson
f0abb1a74b Check magic when removing old connection from map. 
svn:r5508
 2005-12-05 19:01:34 +00:00
Nick Mathewson
835f06a77c Set chosen_exit_name to something we are not about to zero. 
svn:r5507
 2005-12-05 06:16:24 +00:00
Nick Mathewson
98290e4115 When parsing foo.exit, if foo is unknown, and we are leaving circuits unattached, set the chosen_exit field and leave the address empty 
svn:r5504
 2005-12-05 04:38:21 +00:00
Peter Palfrader
1bf56b452e Remove superfluous strdup 
svn:r5503
 2005-12-05 01:30:11 +00:00
Peter Palfrader
7a70a142f4 Also print usernames, not just numeric UIDs when we tell the user that his data directory has the wrong owner 
svn:r5502
 2005-12-05 01:28:10 +00:00
Roger Dingledine
8b0f1f029c give a hint when people are running tor as the wrong user, rather than 
telling them to start chowning random directories.


svn:r5500
 2005-12-05 01:07:58 +00:00
Roger Dingledine
26b49dbc09 Bugfix for trackhostexits: write down the fingerprint of the chosen exit, 
not its nickname, because the chosen exit might not be verified.


svn:r5499
 2005-12-05 00:15:42 +00:00
Roger Dingledine
40cbe550f3 fix a log message to be mildly more helpful 
svn:r5498
 2005-12-04 23:06:48 +00:00
Roger Dingledine
bb8dc691eb Fix another time comparison bug in circuit_stream_is_being_handled(). 
Nick, can you confirm this one?
This is also a backport candidate.


svn:r5497
 2005-12-04 22:23:24 +00:00
Roger Dingledine
ef000fd82e ok, i know this one was a bug. we were expiring open general 
circuits after they had been around for 30 seconds.


svn:r5496
 2005-12-04 22:19:04 +00:00
Roger Dingledine
7d032bd300 take back half of my bugfix. comparing times sucks. 
but leave the other half.


svn:r5495
 2005-12-04 21:59:15 +00:00
Roger Dingledine
d60f514f4c fix the first bug with our optimization to circuit_expire_building(): 
we were killing off rendezvous circuits unless they magically time-warped
to be too old before we got around to killing them, in which case we
would leave them alone. this made it hard to rendezvous with hidden
services.


svn:r5494
 2005-12-04 21:51:50 +00:00
Nick Mathewson
1b0134dda8 Clean up some comments; remove some dead code 
svn:r5493
 2005-12-03 16:32:29 +00:00
Nick Mathewson
61c5a9ae2b Use a switch statement and some mild refactoring to try to speed up circuit_expire_building 
svn:r5492
 2005-12-03 05:29:05 +00:00
Nick Mathewson
979fc3e69d cvs diff -u src/or/circuitlist.c | less almost never does what you want in C. 
svn:r5491
 2005-12-03 03:36:32 +00:00
Nick Mathewson
77a494dd55 Expunge remaining places where we used "tree" to mean "associative array". 
svn:r5490
 2005-12-03 02:21:31 +00:00
Nick Mathewson
148a1e969d Shave off another 4.7%: remove a linear search when figuring out which circuits wanted us to open a given OR connection. 
svn:r5489
 2005-12-03 02:12:37 +00:00
Nick Mathewson
502cb59611 Remove "tree" references from dns. 
svn:r5488
 2005-12-03 02:01:18 +00:00
Nick Mathewson
ce3cdecb9d Make more arguments const; do not call hash tables trees. 
svn:r5487
 2005-12-03 02:00:51 +00:00
Nick Mathewson
4a0b6af935 Ive spent about 10 hours benchmarking permutations on our counter-mode implementation. This is the one that flies. (Avoid OpenSSL; optimizze rijndael calling convention to avoid needing to marshall and unmarshall counter.) This should speed up cell encryption by about 27%. 
svn:r5486
 2005-12-01 18:30:39 +00:00
Nick Mathewson
6443e5ec7f Add a benchmark-aes function to test.c. Off by default. 
svn:r5485
 2005-12-01 04:35:58 +00:00
Nick Mathewson
fea19528a1 assert_buf_ok was showing up in the profile; remove it from critical-path functions, since it hasnt triggered for ages. 
svn:r5479
 2005-11-30 22:48:58 +00:00
Roger Dingledine
a6da372000 and its header 
svn:r5478
 2005-11-30 22:23:27 +00:00
Roger Dingledine
923ad87470 remove another unused function 
svn:r5477
 2005-11-30 22:19:02 +00:00
Roger Dingledine
77a425d8b2 Remove some functions that were around for hupping log files. We handle 
them already in do_hup() by marking our log files as temporary and then
rotating them in options_init_from_torrc().


svn:r5473
 2005-11-30 06:45:30 +00:00
Nick Mathewson
d56a65c497 Fix some verbose warnings and remove an unneeded include. 
svn:r5472
 2005-11-30 06:38:41 +00:00
Nick Mathewson
9cec3a13f5 remove some functions that are not used; #if0 out some files that are not likely to be used. 
svn:r5471
 2005-11-30 06:27:59 +00:00
Nick Mathewson
a6eb8cd2a0 Move connection_or_remove_from_identity_map() to connection_unlink, but dont remove the other; just make it warn. 
svn:r5470
 2005-11-30 04:28:41 +00:00
Nick Mathewson
3bd613b44d Rename connection_get_by_identity_digest to reflect that it is OR-only. Make it use a hashtable instead of a linear search. 
svn:r5469
 2005-11-30 03:01:16 +00:00
Nick Mathewson
6b49a93bd5 Move code to check for zero digests into util.c 
svn:r5468
 2005-11-30 02:47:59 +00:00
Nick Mathewson
447a3a7ff2 Funny. I could have sworn that it compiled. 
svn:r5467
 2005-11-29 17:17:02 +00:00
Nick Mathewson
94e8dcef44 Fix a bug weasel found: when we are an authority and somebody requests "all" statuses, cconsider regenerating our own. 
svn:r5466
 2005-11-29 17:14:10 +00:00
Nick Mathewson
c90d6c7e5f Make arguments to circuit_set_circid_orconn match the connection that is closing in circuit_about_to_close_connection. This accounts for our mysterious "arbitrary ram gets decremented!" bug. 
svn:r5465
 2005-11-29 17:13:34 +00:00
Nick Mathewson
7de0c33857 Avoid a segfault in routerlist_reset_warnings() 
svn:r5464
 2005-11-28 16:29:27 +00:00
Roger Dingledine
1da454a42d when returning a list of circuits, don't return a list of the same 
conn over and over. that's really bad for memory.


svn:r5463
 2005-11-28 02:52:17 +00:00
Roger Dingledine
f94f4c1686 when event_add or event_del fail, tell us why. 
(nick, do i have my libevent strerror dance moves correct?)


svn:r5462
 2005-11-26 09:37:00 +00:00
Roger Dingledine
97f748f680 clean up broken comment 
svn:r5461
 2005-11-26 09:27:36 +00:00
Nick Mathewson
652e1899ac "How about 'never'? Does 'never' work for you?" 
Weasel says circuit_get_by_conn is his main timesink.  Most of its
users were just checking whether OR conns had circuits, so add a
circuit count to OR conns, and check that. One was
circuit_about_to_close_conn, which was doing an O(n^2) series of calls
to get all circs on an OR conn, so make an O(n) function for that.
Finally, circuit_get_by_edge_conn was using it as a sanity test that
has been around for a while but never found any actualy insanity, so
kill that.

circuit_get_by_conn is finally dead, which is good, since it was never
sane to begin with.


svn:r5460
 2005-11-26 01:43:57 +00:00
Nick Mathewson
31d5d96739 Cut down a common call to circuit_get_by_conn by about half. 
svn:r5459
 2005-11-26 00:53:51 +00:00
Nick Mathewson
72cb64406a HT_NEXT invalidates the last iterator; fix rmv-related segfault. 
svn:r5458
 2005-11-26 00:42:25 +00:00
Roger Dingledine
fe221f3dff Start the process of treating internal circuits and exit circuits 
separately. It's important to keep them separate because internal
circuits have their last hops picked like middle hops, rather than like
exit hops. So exiting on them will break the user's expectations.

- Stop cannibalizing internal circuits for general exits, and stop
  cannibalizing exit circuits for rendezvous stuff.

- Don't let new exit streams attach to internal circuits.

- When deciding if we have enough circuits for internal and for exit,
  don't count the wrong ones.

- Treat predicted resolves as predicted port 80 exits.


svn:r5457
 2005-11-25 08:08:56 +00:00
Roger Dingledine
6452aecedb when calling connection_get_by_identity_digest, don't do a memcmp 
for non-OR conns. this should save a bit of time.


svn:r5456
 2005-11-25 06:43:53 +00:00
Roger Dingledine
b6b1b4f283 Bandaid workaround to make cvs not crash tor clients. 
This is not a real fix. I didn't look at the rest of the code.
Nick?


svn:r5455
 2005-11-25 02:16:10 +00:00
Roger Dingledine
2350e487a2 minor cleanup 
svn:r5454
 2005-11-24 06:44:13 +00:00
Roger Dingledine
ea7fe0c267 Fix a bug found by Lasse Overlier: when we were making internal circuits 
(intended to be cannibalized later for rendezvous and introduction
circuits), we were picking them so that they had useful exit nodes. There
was no need for this, and it actually aids some statistical attacks.


svn:r5453
 2005-11-24 06:43:39 +00:00
Roger Dingledine
5b583073a1 remove some more dead code (found while hunting lasse's bug) 
svn:r5452
 2005-11-24 06:06:50 +00:00
Roger Dingledine
23efc30776 get rid of some unused variables 
svn:r5451
 2005-11-24 01:47:05 +00:00
Nick Mathewson
05482a0899 Add functions to return number of elts in associative containers 
svn:r5448
 2005-11-23 07:48:13 +00:00
Roger Dingledine
0118a236a4 comment that scary-looking function. 
svn:r5447
 2005-11-23 07:30:44 +00:00
Nick Mathewson
eb0021b06e Fix dumb logic error that kept some old descripttors from getting the axe. 
svn:r5446
 2005-11-23 07:28:54 +00:00
Nick Mathewson
061ef582a1 Make dropping very old descriptors faster (remove old correctness check). Track bytes dropped that are still in our store or journal, and rebuild when it gets very high. 
svn:r5445
 2005-11-23 07:24:59 +00:00
Nick Mathewson
36109fea33 e more aggressive about calling routerlist_remove_old_routers() 
svn:r5444
 2005-11-23 07:06:36 +00:00
Nick Mathewson
fbf8a8c25f Dump bytes held to store descriptors. 
svn:r5443
 2005-11-23 06:00:58 +00:00
Nick Mathewson
7d7bb95f36 Track how many bytes we have in signed descriptors. Try to make sure we are tracking this right. Somebody should valgrind a dirserver on an example net. There should be code to dump this value. 
svn:r5442
 2005-11-23 05:47:51 +00:00
Nick Mathewson
a39269572f Replace balanced trees with hash tables: this should make stuff significantly faster. 
svn:r5441
 2005-11-23 04:18:45 +00:00
Nick Mathewson
50ce5e1932 Avoid spurious re-launch of first pending requested descriptor 
svn:r5439
 2005-11-22 02:20:05 +00:00
Roger Dingledine
8182eb69cd a smidgen more hint when we fail to seed the rng 
svn:r5438
 2005-11-21 01:12:01 +00:00
Peter Palfrader
a48b722432 Ancient gcc does not like you when you declare variables in the middle of a block 
svn:r5437
 2005-11-20 16:53:49 +00:00
Peter Palfrader
b9d37a2d58 Add a new controller event type that allows controllers to get all 
server descriptors that were uploaded to a router in its role as authoritative
dirserver.


svn:r5436
 2005-11-19 18:35:43 +00:00
Roger Dingledine
f28770b639 be less eager to decide that the entire network is down 
svn:r5434
 2005-11-19 11:04:00 +00:00
Roger Dingledine
859d1c902a and another instance where i was trying to be too sneaky 
svn:r5433
 2005-11-19 10:38:23 +00:00
Roger Dingledine
98f353fa7c actually listen when we try to route our dir connection via tor. 
svn:r5432
 2005-11-19 10:33:34 +00:00
Roger Dingledine
5c949fce51 Start obeying our firewall options more rigorously: 
- If we can't get to a dirserver directly, try going via Tor.
  - Don't ever try to connect (as a client) to a place our firewall
    options forbid.
  - If we specify a proxy and also firewall options, obey the firewall
    options even when we're using the proxy: some proxies can only proxy
    to certain destinations.


svn:r5431
 2005-11-19 10:12:10 +00:00
Roger Dingledine
7aae63994f Recover better from TCP connections to Tor servers that are broken but 
don't tell you (it happens!); and rotate TLS connections once a week.

1) If an OR conn becomes more than a week old, make it obsolete.
2) If it's obsolete and empty, kill it.
3) When an OR makes a second connection to you, allow it.
4) If we want to send a new create cell, but the best conn we've
   got is obsolete, and the router is 0.1.1.9-alpha-cvs or later, ask
   for a new conn instead.
5) When we time out on circuit building on the first hop, make that
   connection obsolete.


svn:r5429
 2005-11-19 06:57:44 +00:00
Roger Dingledine
700c370a3b misc cleanups 
svn:r5428
 2005-11-19 01:56:58 +00:00
Roger Dingledine
f824fb5f83 Bugfix: it looks like some middleman circuits were spending the 
first few moments of their existence in CIRCUIT_STATE_OPEN, then
when Alice sent an extend request for a Tor that they're not connected
to, they switched to CIRCUIT_STATE_OR_WAIT and spent the rest of
their sorry little lives in that state, even when the connection
was established and they were shuttling relay cells back and forth.

And I'm not going to backport this (yet), because somehow it worked!


svn:r5427
 2005-11-19 01:55:58 +00:00
Roger Dingledine
0de8f4ee55 another case (i think) of redundant code. 
svn:r5426
 2005-11-19 01:03:34 +00:00
Roger Dingledine
409294153f remove some redundant (and misleading) code 
svn:r5425
 2005-11-19 00:44:24 +00:00
Peter Palfrader
6734371234 15*60 is 15 minutes, not 5 
svn:r5424
 2005-11-18 21:57:49 +00:00
Peter Palfrader
901712ee59 Remove ip address change flapping detection. It is not really needed and I do not think it works quite right. 
svn:r5423
 2005-11-18 19:28:34 +00:00
Roger Dingledine
4ddf2385a0 if it's not less than three does that mean it's more than two? 
svn:r5422
 2005-11-18 11:35:23 +00:00
Roger Dingledine
9d6d6da883 and code the part where redirectstream can take a port. 
svn:r5421
 2005-11-18 11:32:59 +00:00
Roger Dingledine
afb1c79879 Leave options->DirServers alone -- if the user didn't specify any, 
just add the default ones directly to the trusted dirserver list.
This fixes a bug where people running controllers would setconf or
the equivalent, and Tor would start yelling at them about setting
their own DirServer lines.


svn:r5418
 2005-11-18 02:47:09 +00:00
Roger Dingledine
26d8c3498c and another overly common log entry 
svn:r5417
 2005-11-18 00:35:29 +00:00
Roger Dingledine
aa53190ed5 and another one 
svn:r5416
 2005-11-17 22:23:18 +00:00
Roger Dingledine
9111a3fb48 comment out some really popular log lines 
svn:r5415
 2005-11-17 22:19:35 +00:00
Roger Dingledine
d2b93df26c and now we actually do it, too. 
svn:r5414
 2005-11-17 22:01:46 +00:00
Roger Dingledine
7dbf2511c3 when you type 'getinfo' with no arguments, it doesn't give you 
any answer at all. this is clearly a bug.

the more interesting bug is whether things like setconf, getconf,
and so on should return 250 OK if you give them no arguments. should
we have a new "you didn't ask me anything" response code, or just
leave it as is?


svn:r5412
 2005-11-17 21:45:38 +00:00
Roger Dingledine
af86345b74 we used to kill the circuit when we receive a relay command we 
don't recognize. now we just drop it. perhaps this will make us
more forward-compatible? or perhaps it will bite us? one day we
will find out.


svn:r5405
 2005-11-17 03:40:20 +00:00
Roger Dingledine
298da4497a help the term "OP" become obsolete 
svn:r5403
 2005-11-17 01:17:53 +00:00
Roger Dingledine
279e29a1f2 bugfix: the controller doesn't mention it's a .onion if it is. 
svn:r5400
 2005-11-16 23:54:24 +00:00
Roger Dingledine
c4aa9e7941 Add a new config option TestSocks so people can see if their 
applications are using socks4, socks4a, socks5-with-ip, or
socks5-with-hostname. This way they don't have to keep mucking
with tcpdump and wondering if something got cached somewhere.


svn:r5399
 2005-11-16 23:37:35 +00:00
Nick Mathewson
83d6b0387b Try to build with OpenSSL 0.9.6. Lets pay attention to see if anybody complains. 
svn:r5398
 2005-11-16 05:22:44 +00:00
Nick Mathewson
22aea0757e Verify that router fingerprint lines match identity keys. (We dont use them, but others might.) 
svn:r5389
 2005-11-15 21:24:32 +00:00
Roger Dingledine
74d1ca66c0 another case where the poor server operator doesn't need to 
hear about lexi's bugs.


svn:r5388
 2005-11-15 20:40:32 +00:00
Roger Dingledine
6465b30f21 bump to 0.1.1.9-alpha-cvs 
svn:r5387
 2005-11-15 20:29:56 +00:00
Roger Dingledine
fe7b07754f make it even more clear that i didn't screw up the logic 
svn:r5378
 2005-11-15 09:57:58 +00:00
Roger Dingledine
53269f696d fix logic error: not unnamed is good. 
svn:r5377
 2005-11-15 09:15:43 +00:00
Nick Mathewson
6c361468c1 Loops without an increment step can suck, even on windows. 
svn:r5376
 2005-11-15 03:16:32 +00:00
Nick Mathewson
9b432311c4 Make new logging stuff work on windows; fix a couple of windows typos. 
svn:r5375
 2005-11-15 03:05:23 +00:00
Roger Dingledine
4cd7bddfc3 bump to 0.1.1.9-alpha 
svn:r5374
 2005-11-15 01:47:11 +00:00
Nick Mathewson
e022aa73e6 Hm; looks like the callback business was unnecessary, since DHparams_dup() copies dh->length. 
svn:r5372
 2005-11-14 21:17:38 +00:00
Nick Mathewson
027d0ef18c Use a callback to set our DH parameters; set SSL_OP_SINGLE_DH_USE. 
svn:r5371
 2005-11-14 19:20:47 +00:00
Nick Mathewson
887178e710 Oops. It looks like there *was* an easy way to make openssl do what we wanted. 
svn:r5370
 2005-11-14 19:18:31 +00:00
Nick Mathewson
669fdde91b Fix number in error message 
svn:r5369
 2005-11-14 19:17:28 +00:00
Roger Dingledine
4ea6d71a26 shorten more of the startup log messages 
svn:r5368
 2005-11-14 04:39:49 +00:00
Roger Dingledine
6fc30a65fd when a stream times out, provide less (but better) explanation 
of what happened. don't bother printing the path, since i don't
know of any person who has gotten anything useful out of that.


svn:r5367
 2005-11-14 04:13:43 +00:00
Roger Dingledine
ed4f15b2a7 When logging via syslog, include the pid whenever we provide 
a log entry. Suggested by Todd Fries.


svn:r5366
 2005-11-13 22:28:07 +00:00
Roger Dingledine
014c6bfe00 We were refusing to start if you define SocksListenAddress 
but define SocksPort to be 0. But this is a standard configuration!
So don't fail.


svn:r5361
 2005-11-11 22:41:07 +00:00
Roger Dingledine
5ef2927870 correct nick's comment 
svn:r5360
 2005-11-11 21:44:38 +00:00
Nick Mathewson
f14743a975 Note that much of check_dh_key is voodoo; make x in DH be only 320 bits for DH speed improvement: this wants auditing. [We have blessing from Ian on this.] (Note that DH in SSL is not yet affected.) 
svn:r5359
 2005-11-11 20:18:00 +00:00
Roger Dingledine
a3c53e0af9 speed up the lookup-by-circid-orconn now that it seems that 
our code works.


svn:r5358
 2005-11-11 19:28:32 +00:00
Roger Dingledine
862a997495 when we were cannibalizing a circuit with a particular exit 
node in mind, we weren't checking to see if that exit node
was already present earlier in the circuit. oops.


svn:r5357
 2005-11-11 19:25:30 +00:00
Roger Dingledine
4d1c6bbfc4 fix function comment 
svn:r5356
 2005-11-11 17:16:24 +00:00
Roger Dingledine
c136bbe505 stop discouraging the old *BindAddress config options. we will 
just confuse our users when they upgrade.


svn:r5354
 2005-11-11 17:04:14 +00:00
Roger Dingledine
e6fd88c698 simplify a log entry 
svn:r5353
 2005-11-11 17:03:35 +00:00
Roger Dingledine
c074f528c1 fix a harmless warn and mark two points where we should 
maybe change our approach.


svn:r5352
 2005-11-11 17:01:20 +00:00
Nick Mathewson
b76f61ee66 If we stop knowing about a dirserver between request and answer, do not die. 
svn:r5351
 2005-11-08 22:30:17 +00:00
Peter Palfrader
43c253958e Tor26's IP has changed to 86.59.21.38 
svn:r5350
 2005-11-05 20:20:51 +00:00
Nick Mathewson
75d85c8214 On directory servers, old_routers was wasting hundreds of bytes per superseded router descriptor. Roll the signed descriptor info and identifying info into a cache_info struct, and use only that for old_routers. 
svn:r5349
 2005-11-05 20:15:27 +00:00
Nick Mathewson
757def59b6 Fix bugs in routerlist_remove_old_cached_routers_with_id() 
svn:r5348
 2005-11-04 16:47:26 +00:00
Nick Mathewson
a913cb3536 prevent duplicat mark-for-close 
svn:r5347
 2005-11-04 05:00:12 +00:00
Nick Mathewson
9e82f0cdb7 enable code to remove members of old_routers when it gets big. 
svn:r5345
 2005-11-01 17:34:17 +00:00
Nick Mathewson
80758473f8 fix a signed/unsigned warning 
svn:r5344
 2005-11-01 17:28:49 +00:00
Roger Dingledine
87e8e7b4fa using an unsigned int for something that requires at least 3 bytes 
makes me uncomfortable.


svn:r5340
 2005-11-01 06:15:48 +00:00
Roger Dingledine
40ecaf4857 answer nick's XXX, and muck with some log domain choices 
svn:r5339
 2005-11-01 06:13:12 +00:00
Roger Dingledine
c68cadc0c8 tor_assert had a misleading comment 
svn:r5338
 2005-11-01 06:12:51 +00:00
Roger Dingledine
6dafca62f0 remove redundant checking for . and .. now that 
tor_listdir() checks for this too.


svn:r5337
 2005-11-01 03:50:14 +00:00
Roger Dingledine
1991f6cf48 more doc cleanups and reorganizing 
svn:r5336
 2005-11-01 03:48:51 +00:00
Roger Dingledine
a2a4f4ae61 cleanups and a smidgen more docs 
svn:r5335
 2005-11-01 03:47:55 +00:00
Roger Dingledine
44b3f3060a make circ->onionskin a pointer, not a static array. moria2 was using 
125000 circuit_t's after it had been up for a few weeks, which translates
to 20+ megs of wasted space.


svn:r5333
 2005-10-29 19:13:48 +00:00
Roger Dingledine
bf2be9abd7 Do round-robin writes of at most 16 kB per write. This might 
be more fair on loaded Tor servers, and it might resolve our
Windows crash bug. It might also slow things down.


svn:r5332
 2005-10-29 18:19:37 +00:00
Roger Dingledine
862e8a1bd1 fix typo 
svn:r5331
 2005-10-29 18:00:25 +00:00
Nick Mathewson
f2617c6b79 Free the v2 directory networkstatus on exit. (Not a leak.) 
svn:r5330
 2005-10-29 05:01:12 +00:00
Nick Mathewson
4cb2435388 aaand another leak. Oops, I guess I lied to weasel when I told him there was no leak here. 
svn:r5329
 2005-10-28 19:10:53 +00:00
Nick Mathewson
ed32d85a04 router_add_to_routerlist() really needs to free not-added routers. 
svn:r5328
 2005-10-28 18:44:51 +00:00
Nick Mathewson
76988bafbe Fix bug when parsing list of router descriptors containing a truncated entry. (Found by Lasse) 
svn:r5327
 2005-10-28 15:56:19 +00:00
Nick Mathewson
267af9ecf9 Fix a fun bug that was probably causing unnecessary downloads, and that coupld possibly have caused some segfaults: When post-processing a split fingerprint URL, we were trying to base16_decode() entries already in the fingerprint list, failing, and removing them. Ow. 
svn:r5326
 2005-10-27 23:16:08 +00:00
Nick Mathewson
7643c5254c Fix an annoying rep violation bug 
svn:r5325
 2005-10-27 23:06:09 +00:00
Roger Dingledine
cb785f7b42 fix a url in the sample torrc 
svn:r5324
 2005-10-27 02:36:52 +00:00
Nick Mathewson
e594ce92fe Start making directory caches retain old routerinfo_t. The code to remove old ones is definitely some textbook C problem. 
svn:r5323
 2005-10-27 00:34:39 +00:00
Nick Mathewson
3c36a14ba6 Call ERR_remove_state() on the main thread on shutdown,too 
svn:r5322
 2005-10-26 02:20:48 +00:00
Nick Mathewson
9492424d3f Per comments at the bottom of openssl/FAQ, call even more functions to 
clean up OpenSSL's toys when it's done playing.  (Why isn't there an
OpenSSL_free_everything() function?)


svn:r5321
 2005-10-25 19:01:48 +00:00
Nick Mathewson
b39d03116b remove some commented-out code that may tempt us to do ill 
svn:r5320
 2005-10-25 18:38:44 +00:00
Nick Mathewson
e5633c2e66 fix a nasty corruption bug 
svn:r5319
 2005-10-25 18:33:33 +00:00
Nick Mathewson
35f1b7fa26 fix minor memory leak in config 
svn:r5318
 2005-10-25 18:06:29 +00:00
Nick Mathewson
5d85560d9e Remove last vestiges of old logging interface. 
svn:r5317
 2005-10-25 18:01:01 +00:00
Roger Dingledine
d7e136240a consistency is the hobgoblin of little armas 
svn:r5316
 2005-10-25 17:58:43 +00:00
Nick Mathewson
049f6c0131 Switch remaining files to new log interface. 
svn:r5315
 2005-10-25 17:52:14 +00:00
Nick Mathewson
7a9774eff0 Also here. 
svn:r5314
 2005-10-25 17:42:09 +00:00
Peter Palfrader
0738c24b97 Fix log levels notice and warn for new logging stuff 
svn:r5313
 2005-10-25 17:41:43 +00:00
Nick Mathewson
a38aa81bf8 fix another segv, this time in circid fix. 
svn:r5312
 2005-10-25 15:31:25 +00:00
Nick Mathewson
9b6c5614c6 fix a segv 
svn:r5311
 2005-10-25 15:30:02 +00:00
Nick Mathewson
e7e170a59e Change more files to new loggin interface. 3 left. 
svn:r5310
 2005-10-25 08:20:10 +00:00
Nick Mathewson
932106f54c Efficiency hack: call tor_fix_source_file late, not early. Add "BUG" domain. Domains are now bitmasks... just in case. Make some err msgs non-general. 
svn:r5309
 2005-10-25 07:05:03 +00:00
Nick Mathewson
452f4cfa09 Convert circuituse, command, config, connection, relay, router, test to new logging interface 
svn:r5308
 2005-10-25 07:04:36 +00:00
Nick Mathewson
81dd50a942 Fix memory leak when retrieving networkstatus or routerdesc by malformed fingerprint 
svn:r5307
 2005-10-25 07:03:22 +00:00
Nick Mathewson
91a666064a Fix possible free(NULL) in control.c 
svn:r5306
 2005-10-25 07:02:13 +00:00
Nick Mathewson
26caf69555 Fix possible minor memory leak when parsing helpernode state 
svn:r5305
 2005-10-25 07:00:03 +00:00
Nick Mathewson
f9b0be526e Use LD_BUG as appropriate; convert rend* and router* to new logging interface; use new circ_log_path interface 
svn:r5302
 2005-10-24 19:39:45 +00:00
Nick Mathewson
fa338d85db Fix one possible source of reuse-a-circuit-id bug; convert circuitbuild to new logging 
svn:r5301
 2005-10-24 19:37:45 +00:00
Nick Mathewson
beaf898fe5 add more domains 
svn:r5300
 2005-10-24 19:36:43 +00:00
Nick Mathewson
a20835ac92 Check for even more windows version flags, and note any we do not recognize. 
svn:r5297
 2005-10-24 18:37:09 +00:00
Nick Mathewson
7f20dec1cd When warning about a networkstatus fp, we need to put it in hex. 
svn:r5293
 2005-10-24 03:25:12 +00:00
Nick Mathewson
37708e9b1b Avoid potential infinite recursion when building a descriptor 
svn:r5292
 2005-10-24 03:04:05 +00:00
Roger Dingledine
d6dcd973c3 Oct 19 13:27:24.391 [info] router_reload_networkstatus(): Skipping cached-status file with unexpected name "." 
Oct 19 13:27:24.391 [info] router_reload_networkstatus(): Skipping cached-status file with unexpected name ".."


svn:r5291
 2005-10-20 17:22:00 +00:00
Nick Mathewson
52eaccce44 Crank down the frequency for replacing unchanged descriptors 
svn:r5290
 2005-10-19 16:21:19 +00:00
Nick Mathewson
7b8980a43c Make it compile. appease roger and his thirst for documentation. 
svn:r5289
 2005-10-19 03:08:50 +00:00
Nick Mathewson
74d9c92c49 We need a routerlist_replace as well. This should do something about those annoying mysterious segfaults. 
svn:r5288
 2005-10-19 03:02:28 +00:00
Roger Dingledine
4df1892db1 solve the first half of bug 199: if we don't like the looks 
of an address, but it's the controller's job to handle it,
don't refuse it first.


svn:r5287
 2005-10-19 02:07:11 +00:00
Nick Mathewson
1bd3f6cc9a Update more files to new log stuff. 
svn:r5286
 2005-10-18 22:56:40 +00:00
Nick Mathewson
55f2ab9cc3 Migrate a few more files to domained logging 
svn:r5285
 2005-10-18 22:21:29 +00:00
Nick Mathewson
edf5698474 Start dividing log messages into logging domains. No, LD_ is not the best of identifiers. src/or has not been converted yet. Domains dont do anything yet. 
svn:r5284
 2005-10-18 21:58:19 +00:00
Roger Dingledine
102df4a982 fix some typos 
svn:r5283
 2005-10-18 21:39:00 +00:00
Peter Palfrader
e54efb1655 I think nick meant to compare r2->platform the second time 
svn:r5282
 2005-10-18 21:19:48 +00:00
Peter Palfrader
0d5c007266 Fix tor26's first segfault 
svn:r5281
 2005-10-18 21:19:02 +00:00
Nick Mathewson
d25873ae9c Use a digestmap_t to speed up router_get_by_digest, which was previously a bottleneck (~~27% CPU) 
svn:r5280
 2005-10-18 20:13:09 +00:00
Nick Mathewson
7a19588a43 Use digestmap_t instead of strmap_t where appropriate. Do less hex en/decoding 
svn:r5279
 2005-10-18 20:12:22 +00:00
Nick Mathewson
5828f8920e Add a "Map from digest to void*" abstraction, since we already faked it in 3 places by encoding keys in hex and sticking them in a strmap. 
svn:r5278
 2005-10-18 20:11:39 +00:00
Nick Mathewson
0349598928 stupid gcc. stupid nickm. 
svn:r5277
 2005-10-18 17:52:45 +00:00
Nick Mathewson
3347c1741d Refactor routerlist access slightly: always use router_get_by_routerlist(); change its interface; add modifier functions to add/remove elements from the current routerlist (so we can add indices). 
svn:r5276
 2005-10-18 17:43:54 +00:00
Nick Mathewson
95514b32a5 Make smartlist_foreach always use the fast versions. 
svn:r5275
 2005-10-18 17:38:07 +00:00
Peter Palfrader
d8daa910a6 Make dirserv_get_routerdescs() return better http 404 error messages instead of a generic "Servers unavailable." 
svn:r5274
 2005-10-18 17:09:57 +00:00
Peter Palfrader
551e3402a3 split send_control1_event() into the printf and the print/dispatch part. The 
printf part was and is limited to at most 1024 byte messages, so having the print
part separately available makes sense.


svn:r5273
 2005-10-18 16:45:43 +00:00
Peter Palfrader
00e1709244 Fix download by SD digest 
svn:r5272
 2005-10-18 15:58:40 +00:00
Peter Palfrader
6e8052e0f8 I wonder what a stautus is. 
svn:r5271
 2005-10-18 15:25:10 +00:00
Peter Palfrader
64a631e187 Some http status lines ended in a dot, others did not. Make it all the same and remove the period from all 
svn:r5270
 2005-10-18 14:57:46 +00:00
Peter Palfrader
0186cb283f And close the double quote too 
svn:r5269
 2005-10-18 14:34:49 +00:00
Peter Palfrader
d2f1cd4196 Fix documentation of dirserv_get_routerdescs: 
correct the path for queries by server key, add queries by SD digest


svn:r5268
 2005-10-18 14:33:19 +00:00
Nick Mathewson
48ade882c3 Remove assert in sort-of c-itical path 
svn:r5267
 2005-10-18 05:06:36 +00:00
Nick Mathewson
cf73ff195b Actually, use #defines for common case. Nothing to see here. 
svn:r5266
 2005-10-18 05:03:44 +00:00
Nick Mathewson
768160c872 Inline key smartlist functions; use fast versions by default. 
svn:r5265
 2005-10-18 04:51:07 +00:00
Nick Mathewson
27fcbf87f3 Add a missing struct initializer field 
svn:r5264
 2005-10-17 23:00:08 +00:00
Peter Palfrader
0d9aedfcea Downgrade a few INFO level logs to DEBUG again. Also add two or three new 
logs in cases where a calling function's log was downgraded and we wouldn't
get any log message otherwise.


svn:r5263
 2005-10-17 16:21:42 +00:00
Roger Dingledine
bec2271029 fix a few comments 
svn:r5262
 2005-10-17 08:41:58 +00:00
Roger Dingledine
38c6985fff and update the sample torrc to reflect the *listenaddress notation 
svn:r5261
 2005-10-17 03:23:05 +00:00
Roger Dingledine
fd165329b8 start calling it *ListenAddress rather than *BindAddress, 
since none of our users know what it means to bind an address or port.


svn:r5260
 2005-10-17 03:17:29 +00:00
Nick Mathewson
22c72bd9c5 Add ability to warn when using abbrev mechanism to deprecate option names 
svn:r5259
 2005-10-17 03:06:00 +00:00
Roger Dingledine
435fb973c2 when providing content-type application/octet-stream for providing 
server descriptors with .z, we were leaving out the content-encoding
header. oops. (everything tolerated this just fine, but that doesn't
mean we need to be part of the problem.)


svn:r5258
 2005-10-17 02:32:33 +00:00
Peter Palfrader
7b15f77dd6 Make a few INFO log lines into DEBUG 
svn:r5257
 2005-10-17 02:13:36 +00:00
Roger Dingledine
1be5f4a81b start hunting down why servers keep getting so many duplicate create cells 
svn:r5255
 2005-10-17 01:46:47 +00:00
Roger Dingledine
ae92a91d96 more log uncluttering 
svn:r5254
 2005-10-17 01:29:28 +00:00
Roger Dingledine
03dcef4c78 start the process of reducing clutter in server logs 
svn:r5253
 2005-10-17 00:35:53 +00:00
Roger Dingledine
aca6fb5f5f cut out a warning that doesn't need to warn 
svn:r5252
 2005-10-16 19:47:01 +00:00
Roger Dingledine
2a82182243 remove obsolete IgnoreVersion config from or.h 
svn:r5251
 2005-10-16 18:43:41 +00:00
Nick Mathewson
6101468cbe Enable trivial "download by descriptor digest" functionality. 
svn:r5250
 2005-10-14 04:56:20 +00:00
Nick Mathewson
998cf8d622 Try to extract as many descriptors as possible from truncated http responses. (when DIR_PURPOSE_FETCH_ROUTERDESC) 
svn:r5249
 2005-10-14 02:26:13 +00:00
Nick Mathewson
11b76b9ca5 Allow tor_gzip_uncompress to extract as much as possible from truncated compressed data. Also, fix a bug where truncated compressed data could break tor_gzip_uncompress. [This last part is a backport candidate.] 
svn:r5247
 2005-10-13 22:48:09 +00:00
Peter Palfrader
8808b26206 Check if our IP address has changed every 5 minutes. If it has, update our server descriptor, but not too often 
svn:r5246
 2005-10-12 22:41:16 +00:00
Peter Palfrader
640211e59a Be a bit more verbose in our AUTHENTICATE error messages in the control protocol so the next guy doesn't blame Nick again 
svn:r5245
 2005-10-12 19:45:35 +00:00
Nick Mathewson
aac738d2be When no descriptors changed, do not send a NEWDESC event. 
svn:r5244
 2005-10-12 19:41:16 +00:00
Nick Mathewson
905ef987e2 Make --hash-password not craash on exit. 
svn:r5243
 2005-10-12 19:08:48 +00:00
Nick Mathewson
9a1d204318 Avoid warning on end-of-function 
svn:r5242
 2005-10-12 18:43:03 +00:00
Nick Mathewson
972b7512c7 authorities do not replace server descriptors where nothing semantically relevant has changed since the last upload. 
svn:r5240
 2005-10-12 18:25:25 +00:00
Nick Mathewson
fd9bfef13b Funny. I could have sworn it compiled this morning when I checked it in. 
svn:r5239
 2005-10-12 17:16:25 +00:00
Nick Mathewson
a7ca56b537 More work towards a sane digest-based liveness testing. 
svn:r5238
 2005-10-12 13:49:13 +00:00
Nick Mathewson
2b3a7b818f Add an as-yet-unused "EXTENDED" flag to SETEVENTS to indicate that the client can handle extra labeled info in its events. Add moreinfo to the "what is ready for downloading" msg so we can investigate digest-related download rules 
svn:r5237
 2005-10-12 04:31:44 +00:00
Nick Mathewson
bf9ff1c1e7 Do not check whether DirPort is reachable when we are suppressing it because of hibernation. (Backport candidate) 
svn:r5235
 2005-10-12 04:07:10 +00:00
Nick Mathewson
08e4f132a8 add some docs; if warn_if_unnamed is 0, really do not warn. 
svn:r5234
 2005-10-11 01:57:28 +00:00
Nick Mathewson
c48ccf9db4 Insert a newline between all router descriptors when generating (old style) signed directories, in case somebody was counting on that. 
svn:r5231
 2005-10-08 06:02:41 +00:00
Nick Mathewson
2f49e058d0 Now that directory admins assure me they have adjested teir configs, it is safe to make authorities be non-versioning, non-naming by default. 
svn:r5230
 2005-10-08 05:47:58 +00:00
Nick Mathewson
9bc2467626 Okay, try to use RAND_poll() from OpenSSL where available. 
svn:r5229
 2005-10-08 05:47:15 +00:00
Nick Mathewson
48caf912a6 Bump version to 0.1.1.8-alpha-cvs 
svn:r5228
 2005-10-08 05:43:49 +00:00
Nick Mathewson
d7b04a8788 do not try to download a routerdesc if we would immediately reject it as obsolete. 
svn:r5225
 2005-10-07 22:00:09 +00:00
Nick Mathewson
2572db2472 Warn less about intro nodes by nickname; remember our own intro nodes by key. 
svn:r5224
 2005-10-07 21:38:44 +00:00
Roger Dingledine
2b3e8ab901 bump to 0.1.1.8-alpha 
svn:r5222
 2005-10-07 20:17:39 +00:00
Roger Dingledine
c4757e0705 LOG_ERR is for when we know we're going to exit. use LOG_WARN in other 
cases.


svn:r5220
 2005-10-07 19:53:57 +00:00
Roger Dingledine
78edd804ff fix a malformed warning entry 
svn:r5219
 2005-10-07 19:49:48 +00:00
Nick Mathewson
010bcfa9df Win32 compilation/correctness fixes. 
svn:r5218
 2005-10-07 19:33:47 +00:00
Roger Dingledine
83e119154b doxygen fix 
svn:r5217
 2005-10-07 19:25:01 +00:00
Nick Mathewson
150e5ac098 disable RAND_poll() for the alpha of the day; at least 24 hours of testing is in order for something like that. 
svn:r5216
 2005-10-07 19:17:20 +00:00
Nick Mathewson
a53ecc94f9 Add half our entropy from RAND_poll in OpenSSL. These know how to use egd (if present) openbsd weirdness (if present), vms/os2 weirdness (if we ever port there), and more in the future. 
svn:r5215
 2005-10-07 19:03:09 +00:00
Roger Dingledine
46af2d26d0 you can't declare variables in the middle of a block 
svn:r5214
 2005-10-07 18:56:21 +00:00
Peter Palfrader
14934dece2 Print address too when we say we cannot bind/listen 
svn:r5213
 2005-10-07 18:48:31 +00:00
Nick Mathewson
4c7113d26a Strip extra trailing newlines when parsing router descriptors. 
svn:r5212
 2005-10-07 18:33:30 +00:00
Nick Mathewson
a89daaeca9 Once an hour (not just on startup) give OpenSSL some more entropy. 
Add entropy in 512-bit chunks, not 160-bit chunks.  (This latter
change is voodoo.)


svn:r5211
 2005-10-06 22:22:22 +00:00
Nick Mathewson
cc35e1720f Using RAND_pseudo_bytes instead of RAND_bytes is an accident waiting to happen, and does not really speed us up much when we do it. So stop doing it. 
svn:r5210
 2005-10-06 22:18:01 +00:00
Roger Dingledine
0e5b6a84eb without braces, what will hold up the code? 
svn:r5209
 2005-10-06 05:08:00 +00:00
Nick Mathewson
ba24193ab5 Make doxygen marginally happier 
svn:r5208
 2005-10-06 04:33:40 +00:00
Nick Mathewson
5cf758764e Rate-limit warnings related to unrecognized MyFamily elements. 
svn:r5204
 2005-10-05 23:20:45 +00:00
Nick Mathewson
ba67d14d40 On sighup, if usehelpernodes changed to 1, use new circuits. 
svn:r5203
 2005-10-05 23:02:40 +00:00
Roger Dingledine
f12663a4ce call circuit_expire_all_dirty_circs() on do_hup(). 
there, now we use it.


svn:r5202
 2005-10-05 22:36:33 +00:00
Nick Mathewson
56be5a9706 I *knew* something was wrong here. Flip some comparison operators and make download-rate-limiting sane again. 
svn:r5201
 2005-10-05 22:36:18 +00:00
Nick Mathewson
039edb3dbb Downgrade too-frequent "nothing happened" message from info to debug 
svn:r5200
 2005-10-05 22:32:59 +00:00
Roger Dingledine
c3aac3ff6b infrastructure for the 'change pseudonym' button. 
not used yet.


svn:r5199
 2005-10-05 22:31:21 +00:00
Nick Mathewson
92abf1b653 Make windows platform detection smarter. {Untested.} 
svn:r5198
 2005-10-05 22:04:45 +00:00
Nick Mathewson
1ebbaf5c3a improve INFO-level logging for directory downloads. This is still too chatty, but it will help us analyze things. 
svn:r5197
 2005-10-05 20:45:18 +00:00
Nick Mathewson
370e4abdc9 replace former relaunches of directory downloads with reset of failure count and relaunch of status downloads. Fix memory leak in trusted_dir_server_t. Reset "last download attempted" time when resetting failure counts. 
svn:r5195
 2005-10-05 05:03:52 +00:00
Roger Dingledine
adf04f121e size_t int printf mucking 
svn:r5194
 2005-10-05 04:52:55 +00:00
Nick Mathewson
96c47c8478 Note the two places where clients will still try to fetch old-style (v1) directory info. These should be fixed, I think. 
svn:r5193
 2005-10-05 02:25:59 +00:00
Nick Mathewson
509de69a7e reset warning flags on SIGHUP. arma: is this everything? 
svn:r5192
 2005-10-05 02:20:46 +00:00
Roger Dingledine
be478bb56c stutter therapy lessons 
svn:r5191
 2005-10-05 02:09:27 +00:00
Nick Mathewson
8434595584 Fix verbose compiler warnings, including one in routerlist.c that would have been an actual error. Normalize whitespace. Enforce convention that "address" is a hostname and "addr" is an IPv4 address. 
svn:r5190
 2005-10-05 02:06:36 +00:00
Nick Mathewson
0924094042 resolve some directory-related XXXXs; downgrade naming conflict messages from WARN to INFO for non-authorities; do not repeat naming conflict messages. 
svn:r5189
 2005-10-05 01:53:44 +00:00
Nick Mathewson
1223310b69 Downgrade noisy log messages in preparation for an alpha release. 
svn:r5188
 2005-10-05 01:27:08 +00:00
Nick Mathewson
a608905070 Give a less frequent and more helpful warning on failed serverdesc downloads 
svn:r5187
 2005-10-05 00:22:56 +00:00
Nick Mathewson
42e17182da When we get an EOF or a timeout on a directory connection, note how many bytes of serverdesc we are dropping. This will help us determine whether it is smart to parse incomplete serverdesc responses. 
svn:r5186
 2005-10-04 22:34:09 +00:00
Nick Mathewson
61ea516885 Check for named servers when looking them up by nickname; 
warn when we'recalling a non-named server by its nickname;
don't warn twice about the same name.

Fix a bug in routers_update_status_from_networkstatus that made nearly
all clients never update routerinfo_t.is_named.

Try to list MyFamily elements by key, not by nickname.

Only warn about names that we generated ourself, or got from the local
user.

On TLS handshake, only check the other router's nickname against its
expected nickname if is_named is set.


svn:r5185
 2005-10-04 22:23:31 +00:00
Nick Mathewson
2d203fdcf3 link nicknames to trusted directory servers; log these nicknames when mentioning servers; also, when we get a naming conflict; log which nicknames or keys are supposed to bind. 
svn:r5184
 2005-10-04 21:21:09 +00:00
Nick Mathewson
b10df0d595 cosmetic fix: only have one local to hold smartlist_len(downloadable), not too. 
svn:r5183
 2005-10-04 20:18:26 +00:00
Nick Mathewson
e4a6a03249 switch semantics of authdirinvalid/reject 
svn:r5182
 2005-10-04 19:52:58 +00:00
Roger Dingledine
88c37f2d24 comment cleanups 
svn:r5181
 2005-10-04 06:53:59 +00:00
Nick Mathewson
f8c07e1f33 free EVP cipher information on shutdown to remove some spurious dmalloc complaints. 
svn:r5180
 2005-10-03 21:10:35 +00:00
Nick Mathewson
fd04db90b5 Stop leaking storage for EVP keys. (This would be a critical bug if it had ever appeared in a released version.) 
svn:r5179
 2005-10-03 20:53:27 +00:00
Nick Mathewson
c5ee3e961e Reorganize some quick-and-dirty code to find out what openssl stuff is leaking, using dmalloc. 
svn:r5178
 2005-10-03 20:20:38 +00:00
Nick Mathewson
9e54e2e293 free helper node status info on shutdown 
svn:r5177
 2005-09-30 21:38:57 +00:00
Nick Mathewson
808e584a87 remove a never-used smartlist in routerlist.c 
svn:r5176
 2005-09-30 21:38:45 +00:00
Nick Mathewson
6e4608701d and another leak. 
svn:r5175
 2005-09-30 21:31:26 +00:00
Roger Dingledine
ae30c8101b by convention, addr is a uint32_t and address is a string. 
that's why we hadn't caught that leak.


svn:r5174
 2005-09-30 21:30:04 +00:00
Nick Mathewson
5c5d2e82e6 Fix a leak when launching listeners. 
svn:r5173
 2005-09-30 21:28:00 +00:00
Nick Mathewson
23864ad423 Try to hunt down a few more leaks 
svn:r5172
 2005-09-30 21:22:25 +00:00
Nick Mathewson
80f2e10228 Stop leaking or_state_t on shutdown. 
svn:r5171
 2005-09-30 21:16:47 +00:00
Nick Mathewson
5333a3b838 fix a small filename leak 
svn:r5170
 2005-09-30 21:11:22 +00:00
Nick Mathewson
8408006318 fix a memory leak on exit in routerlist.c 
svn:r5169
 2005-09-30 21:04:52 +00:00
Nick Mathewson
de198d800b Never call free() on tor_malloc()d memory. This is unlikely to be our current leak, but it may help dmalloc work. 
svn:r5168
 2005-09-30 20:47:58 +00:00
Nick Mathewson
fc3c0197f9 Resolve several DOCDOCs. Make non-mirrors only launch routerdesc downloads when they have more than 16 router descriptors to download, or when 10 minutes have passed since the last download. 
svn:r5166
 2005-09-30 20:04:55 +00:00
Roger Dingledine
e28c31ebce we were leaking some memory every time the client changes IPs 
svn:r5165
 2005-09-30 06:03:04 +00:00
Nick Mathewson
ab245746a9 Hey kids, guess why connection_mark_for_close() started giving an assert when called for an even-numbered line? Right, because I made it a bitfield, when it was really a line number. Why did I think it was a bitfield? A stale comment. Let that be a lesson to us all. 
svn:r5164
 2005-09-30 04:43:42 +00:00
Roger Dingledine
13e709a0ff resolve nick's comment 
svn:r5163
 2005-09-30 02:08:57 +00:00
Nick Mathewson
26e7a05725 even better function start checks; give dmalloc a chance of working. 
svn:r5162
 2005-09-30 01:39:24 +00:00
Nick Mathewson
edd15cb781 Note that there is incorrect behavior in directory.c code. Arma, please check this too. 
svn:r5161
 2005-09-30 01:38:09 +00:00
Nick Mathewson
92451f74a8 Reformat inconsistent function declarations. 
svn:r5160
 2005-09-30 01:09:52 +00:00
Roger Dingledine
609af664ac resolve a docdoc 
svn:r5157
 2005-09-30 00:43:40 +00:00
Roger Dingledine
ea18827cee do the other half of dirport reachability testing. 
it should be back and working now.


svn:r5155
 2005-09-29 23:59:36 +00:00
Roger Dingledine
f8d430653e better cleanups as i figure out what's going on 
svn:r5154
 2005-09-29 23:26:42 +00:00
Roger Dingledine
d4d8adaa6d move some code around when we're succeeding or failing at fetching 
server descs.
also clean up some formatting.


svn:r5153
 2005-09-29 23:06:48 +00:00
Roger Dingledine
54a662a542 re-enable dirport testing again 
(still need the other half, to notice when it has worked.)


svn:r5152
 2005-09-29 23:04:01 +00:00
Roger Dingledine
8fc9330686 fix typo 
svn:r5151
 2005-09-29 23:03:34 +00:00
Nick Mathewson
5c53545d81 Add a bunch more warnings to out warning suite; resolve them; pack structs a little better. 
svn:r5150
 2005-09-29 22:59:17 +00:00
Nick Mathewson
c6347cdb0e suppress all our usual compiler warnings, including a longstanding one from tree.h 
svn:r5149
 2005-09-29 20:49:41 +00:00
Roger Dingledine
8ae6e1c226 Be more conservative about whether to advertise our dirport. 
The main change is to not advertise if we're running at capacity and
either a) we could hibernate or b) our capacity is low and we're using
a default dirport.


svn:r5148
 2005-09-29 06:45:03 +00:00
Roger Dingledine
3559f821a1 clean up some doxygen stuff 
svn:r5147
 2005-09-29 02:54:09 +00:00
Nick Mathewson
2999cbf233 Use EVP_CIPHER_CTX version of AES from openssl, so openssl can use engines (if they exist). 
svn:r5146
 2005-09-27 19:39:25 +00:00
Nick Mathewson
126a1e3e32 Fix crash-on-wakeup bug in networkstatus download. 
svn:r5144
 2005-09-26 16:37:39 +00:00
Roger Dingledine
fba01c3cc0 bugfix: we were whining about using socks4 or socks5-with-local-lookup 
even when they used an IP in the "virtual" range we designed exactly
for this case.


svn:r5142
 2005-09-24 21:56:04 +00:00
Nick Mathewson
0873386600 Point readers of the code to opensslv.h, since everybody who sees 0x0090700f looks at me like some kind of loon 
svn:r5140
 2005-09-24 16:39:33 +00:00
Nick Mathewson
d661fde082 Possible fix to make aes build on woody 
svn:r5139
 2005-09-24 16:37:24 +00:00
Nick Mathewson
abb8576538 But, of course, mirrors should get the most up-to-date server in any case. 
svn:r5135
 2005-09-23 21:33:59 +00:00
Nick Mathewson
b726507d36 Log even less verbosely. Also, do not download old (frequently-updating) servers more than once every 2 hours. 
svn:r5134
 2005-09-23 21:25:29 +00:00
Roger Dingledine
31c7f59b25 add MyFamily to the torrc.sample 
svn:r5133
 2005-09-23 20:53:42 +00:00
Nick Mathewson
ebf6476e8e Provide dire warnings to any users who set DirServer; move it out of torrc.sample and into torrc.complete. 
svn:r5132
 2005-09-23 20:44:22 +00:00
Nick Mathewson
18a0a0e458 Oops. It looks like some old GCCs dislike #if inside a macro argument. 
svn:r5131
 2005-09-23 20:31:07 +00:00
Roger Dingledine
0ef18a0fba put a log message so we can start confirming socks5-with-remote-dns 
vs socks5-with-local-dns


svn:r5130
 2005-09-23 19:56:34 +00:00
Nick Mathewson
96988b45b4 Use OpenSSL AES when OpenSSL has version 0.9.7 or later. 
svn:r5129
 2005-09-23 18:50:50 +00:00
Nick Mathewson
06625e779d Decouple router downloads from old directory downloads entirely 
svn:r5128
 2005-09-23 18:49:37 +00:00
Nick Mathewson
c345dab3bd Fix logic error (people who ask authorities should never split; others should always split). Also, fix timing error in main.c so retries really happen. 
svn:r5127
 2005-09-23 18:17:37 +00:00
Nick Mathewson
a1f1c4bf6b Re-enable autosplitting, but authorities and mirrors should not do it, and make the cutoff higher than 1. 
svn:r5126
 2005-09-23 18:08:31 +00:00
Nick Mathewson
f995edd516 Fix at least one overzealous download bug. (tor_malloc_zero new local_routerstatus_t objs); add a pile of logs back in; probe every 10sec; never autolaunch on failure. Let us see if this works better. 
svn:r5125
 2005-09-23 18:05:14 +00:00
Nick Mathewson
9050480339 Fix some compiler warnings 
svn:r5124
 2005-09-23 17:11:20 +00:00
Nick Mathewson
faa4f420de Remove extraneous space on read-history lines. 
svn:r5123
 2005-09-23 17:02:50 +00:00
Roger Dingledine
03d0f62da0 make the numbers in read-history and write-history into uint64s, 
so they don't overflow and publish negatives in the descriptor.
fixes bug 193.


svn:r5119
 2005-09-23 08:29:58 +00:00
Roger Dingledine
512d6ccdc1 and a minor log cleanup 
svn:r5115
 2005-09-23 00:04:53 +00:00
Roger Dingledine
e286c4267e there was no need to die when we failed to spawn a cpuworker. 
it handles it fine if we decide not to die.


svn:r5114
 2005-09-23 00:04:44 +00:00
Roger Dingledine
479886fce2 remove another loud debug msg 
svn:r5113
 2005-09-22 23:56:56 +00:00
Roger Dingledine
d050ff7906 resolve lucky's recent bug: tor was exiting if we failed to spawn 
a new dns worker (e.g. because we were out of fd's).


svn:r5112
 2005-09-22 23:43:41 +00:00
Roger Dingledine
2d6b36a001 get rid of a noisy debug log 
svn:r5111
 2005-09-22 20:51:45 +00:00
Nick Mathewson
cdc912714e I love the smell of C in the morning. Make router-download rules smarter (download more so long as we dont duplicate existing requests; relaunch at staggered intervals); relaunch one a minute or on failure; reset 60 minutes; always open 3 requests if we can; add authority opinion to networkstatus; make naming rule correct. There is a remaining bug where we retry servers too quickly; We need to look at that harder. 
svn:r5110
 2005-09-22 06:34:29 +00:00
Nick Mathewson
6693031947 Use a separate type for "local view of router status". Also, even though I told arma there was no need, replace an ugly O ( n lg n ) algorithm with a nice O ( n ) algorithm when stepping through servers. Some ugliness is just too bad to stand. 
svn:r5109
 2005-09-22 01:51:14 +00:00
Roger Dingledine
959598fae6 content-type bugfixes: 
http://seppia.noreply.org/tor/dir.z was being declared text/plain
and
http://seppia.noreply.org/tor/server/fp/719BE45DE224B607C53707D0E2143E2D423E74CF
was being declared application/octet-stream


svn:r5108
 2005-09-22 00:17:41 +00:00
Roger Dingledine
f011b12df2 bugfix: nobody ever implemented EVENT_ADDRMAP for control protocol 
version 0, so don't let version 0 controllers ask for it.


svn:r5107
 2005-09-21 23:30:15 +00:00
Nick Mathewson
f99b91505b Make write_escaped_data more bulletproof; backport candidate. 
svn:r5106
 2005-09-21 23:13:29 +00:00
Roger Dingledine
1cfcc4b351 clean up misleading comment on authdir_wants_to_reject_router() 
svn:r5105
 2005-09-21 21:10:36 +00:00
Nick Mathewson
72915546cd Only check versions from versioning authdirs. 
svn:r5101
 2005-09-21 02:38:51 +00:00
Nick Mathewson
20b9111266 Implement new version handling code. 
svn:r5100
 2005-09-21 00:41:06 +00:00
Roger Dingledine
94ff09af23 clean up a bit more code 
svn:r5098
 2005-09-20 19:50:43 +00:00
Roger Dingledine
19f04ae9c3 make router_is_general_exit match its documentation 
but it's still wrong maybe


svn:r5095
 2005-09-20 03:40:54 +00:00
Nick Mathewson
dcb6b3df6c bump version to 0.1.1.7-alpha-cvs 
svn:r5093
 2005-09-19 22:02:14 +00:00
Nick Mathewson
837b223c8c remove some debugging garbage 
svn:r5092
 2005-09-18 04:32:58 +00:00
Nick Mathewson
283032960d Make give-up-on-failure actually work: it seems the servers gave me a real test case. 
svn:r5091
 2005-09-18 04:15:39 +00:00
Nick Mathewson
d118d5069a Prevent a "try forever to download an unobtainable descriptor" bug. Still remaining: the "give up forever" bug. 
svn:r5090
 2005-09-18 02:51:12 +00:00
Nick Mathewson
87f6d526fe Refactor new directory code a bit. Keep a big list of rolled-up router status info, including # of download failures (not yet used). Update this list from networkstatuses when they arrive, then update routers from this list. Only download 128 routers at a time, to avoid gargantuan URLs. 
svn:r5089
 2005-09-18 02:24:42 +00:00
Nick Mathewson
e86893e87b Move to new base64 digest functions. Switch to new router digest calculation. Make sure there are no duplicates in router status lists. 
svn:r5088
 2005-09-18 02:22:21 +00:00
Nick Mathewson
f8a80e8d59 Helper functions to perform our truncated base64 encoding on hexdigests. 
svn:r5087
 2005-09-18 02:18:59 +00:00
Nick Mathewson
312af36126 Make smartlist_add_all more efficient. 
svn:r5086
 2005-09-18 02:17:02 +00:00
Nick Mathewson
1fbe499bfe Remove a bunch of #if0d code that I no longer need to look at. 
svn:r5083
 2005-09-16 16:47:20 +00:00
Nick Mathewson
6d15a73548 Resolve/expand some XXXXs and improve a log message or two 
svn:r5082
 2005-09-16 16:41:45 +00:00
Roger Dingledine
cce469c5ce simplify 
svn:r5081
 2005-09-16 06:15:34 +00:00
Nick Mathewson
538740e362 Fix the never-marked-anything-as-running bug. Now Tor builds circuts again. Woo. 
svn:r5080
 2005-09-16 04:53:28 +00:00
Nick Mathewson
d45badd9f4 Add a missing return 
svn:r5079
 2005-09-16 04:52:53 +00:00
Nick Mathewson
1a786a297f Fix the confusing bug where we were downloading only the first n/2-1 of the servers we actually wanted. 
svn:r5078
 2005-09-16 04:43:21 +00:00
Nick Mathewson
9c2ca40df3 Unify our "figure out which fingerprints we were downloading" code. 
svn:r5077
 2005-09-16 04:42:45 +00:00
Nick Mathewson
05bab28c7d Add some (notice, for now) log messages that imply confusing things are happening. 
svn:r5076
 2005-09-15 21:11:48 +00:00
Nick Mathewson
51da58eccf fix braino in dirserv. 
svn:r5075
 2005-09-15 21:10:58 +00:00
Nick Mathewson
e72e76cad6 Make authdirs smarter. Reject/invalidate by key and IP. Remember that not every authdir has to be a naming authdir. 
svn:r5074
 2005-09-15 14:39:05 +00:00
Nick Mathewson
ed21abfe87 And some documentation before bed. 
svn:r5073
 2005-09-15 06:15:31 +00:00
Nick Mathewson
b70c229f6e make some functions static; clean dead networkstatus entries more often. 
svn:r5072
 2005-09-15 05:41:30 +00:00
Nick Mathewson
3dcc4630b9 Make unittests not die 
svn:r5071
 2005-09-15 05:28:18 +00:00
Nick Mathewson
b16048917c Stop downloading directories and download routers instead. This still needs some work, but at last clients are finally on the new architecture. Next comes the tuning and bugfixing. 
svn:r5070
 2005-09-15 05:19:38 +00:00
Nick Mathewson
e83e1df811 separate validation from naming in authoritative directory servers; simplify some router-management code. 
svn:r5069
 2005-09-15 00:51:42 +00:00
Nick Mathewson
d4e0af7822 Fix a bunch of log messages. Deprecate some routerlist fields; remove others, and status_set_at from routerinfo_t. Compress routerlist.c cleanup functions. Update cached networkstatus mtime when we download the same one twice. Change some interfaces. 
svn:r5068
 2005-09-14 23:42:06 +00:00
Nick Mathewson
6973ef9be4 Add a touch_file() function to compat so we can update cache mtimes. 
svn:r5067
 2005-09-14 23:27:52 +00:00
Nick Mathewson
bc0af7046a Oops. directory_set_dirty() needs to mark networkstatus as dirty too. 
svn:r5066
 2005-09-14 23:14:37 +00:00
Nick Mathewson
27bbfe9dcf Would you believe that the software_versions field of routerlist_t was never actually used for anything? 
svn:r5064
 2005-09-14 21:38:05 +00:00
Nick Mathewson
e3adcbdb95 Big commit: clients start downloading and using network-statuses. 
Only caches need to get running-routers; nobody needs to parse, store,
or use it.  Same for the router-status line in the directories.  Add
many #if 0's that can get removed once I'm convinced they don't
contain anything I'm forgetting.

Start all newly-parsed routers as non-running and non-valid; update
them from the list of network statuses.

Update all routers when a new networkstatus comes in.

After 3 tries for a networkstatus, clients give up until they're told
to try again.

     "Let's get those missles ready to **DESTROY THE UNIVERSE**!"
				-TMBG


svn:r5063
 2005-09-14 21:09:25 +00:00
Nick Mathewson
922cee3d0c Clean up a few warnings that make gcc twig out a bit. 
svn:r5062
 2005-09-14 20:59:25 +00:00
Nick Mathewson
d9ee94543e Declare 0.1.1.7 as The Version With The Good Dirservers. 
svn:r5061
 2005-09-14 19:12:35 +00:00
Roger Dingledine
76e6cc0c2b bump to 0.1.1.7-alpha 
svn:r5051
 2005-09-14 03:59:33 +00:00
Roger Dingledine
ca727ba6e1 bugfix: when we try to determine the reachability of our dirport, 
and it doesn't work, don't freak out and mark ourselves as down and
try somewhere else. just calmly fail.


svn:r5050
 2005-09-14 03:49:17 +00:00
Nick Mathewson
7c6679d8dc Add new config.c function to set options that can fail, and roll back if they do. This should solve the setconf-an-impossible-port bug. 
svn:r5046
 2005-09-14 02:36:29 +00:00
Roger Dingledine
93be26a74a stop the call duplication inside config_assign() 
svn:r5045
 2005-09-14 02:35:06 +00:00
Nick Mathewson
6aa8850d90 note that routerstatus_t.entries is sorted. 
svn:r5044
 2005-09-14 02:28:35 +00:00
Roger Dingledine
10893e7254 simplify 
svn:r5043
 2005-09-14 02:18:28 +00:00
Roger Dingledine
c78aafe4b5 and take the bang out 
svn:r5042
 2005-09-14 02:13:35 +00:00
Roger Dingledine
62fe24c40c ok, ok, csv's get replaced even when we assign them from the torrc. 
svn:r5041
 2005-09-14 02:12:29 +00:00
Roger Dingledine
1f930a9a70 checkpoint: clean up and document the three ways to call config_assign() 
and reduce code duplication in config_free() and option_is_same().


svn:r5040
 2005-09-14 02:07:35 +00:00
Roger Dingledine
8585599965 correct "your server is reachable" log entries to indicate that it was 
self-testing that told us so.


svn:r5034
 2005-09-13 21:39:42 +00:00
Roger Dingledine
26cc51ffea a bit more code cleanup 
svn:r5033
 2005-09-13 21:24:51 +00:00
Nick Mathewson
890847d232 I forgot -- smart kids make their code compile. 
svn:r5032
 2005-09-13 21:18:00 +00:00
Nick Mathewson
4efa652a98 add docs, fix whitespace, and make ANY rule in routerparse a little tighter. 
svn:r5031
 2005-09-13 21:14:55 +00:00
Nick Mathewson
76351b8416 Fix DOCDOC entries in routerlist.c. Make more functions use SMARTLIST_FOREACH instead of raw loops. Replace router_list_superseded implementation with one that has a prayer of working. 
svn:r5027
 2005-09-13 15:32:03 +00:00
Nick Mathewson
d9bf9e48c0 Add documentation to a few functions in container.c; reformat function definitions 
svn:r5026
 2005-09-13 15:30:22 +00:00
Nick Mathewson
29c57b54d4 Add functions to extend and compress new router store logic. (Basic idea: use a journal of newly received router descriptors, and periodically replace the old file. This avoids the "too many files" problem and the "too many rewrites" problem.) 
svn:r5025
 2005-09-13 06:21:10 +00:00
Nick Mathewson
d4fb1fcd6c Two new functions like write_bytes_to_file: one takes a list of byte-and-len structs; one appends. 
svn:r5024
 2005-09-13 06:19:31 +00:00
Roger Dingledine
82b3b6249c fix a seg fault if we ask an authdirserver for a descriptor by 
fingerprint but he doesn't know about him.


svn:r5023
 2005-09-13 01:20:26 +00:00
Roger Dingledine
8b0d37096b when the user asked for a rendezvous port that the hidden service 
didn't want to provide, we were sending an IP address back along
with the end cell. fortunately, it was zero. but stop that anyway.


svn:r5022
 2005-09-12 22:05:17 +00:00
Roger Dingledine
569efe61c0 make the patch less likely to bite us later 
svn:r5021
 2005-09-12 21:42:59 +00:00
Nick Mathewson
93c1d37d5f Resolve stack corruption identified by edmanw in connection_edge_end(). Thanks! 
svn:r5020
 2005-09-12 20:57:16 +00:00
Nick Mathewson
39e29738b1 Maybe I should pay more attention to return values and less to clever comments. Fortunately, the aforementioned comments came out against smacking upside the head. 
svn:r5018
 2005-09-12 08:49:21 +00:00
Nick Mathewson
a6271650d5 Versions should be sorted by version. Lexical sorting should be used only as a last resort. 
svn:r5017
 2005-09-12 08:46:37 +00:00
Roger Dingledine
689cb28098 when writing the recommended*versions lines, sort them first. 
this is because weasel put his out of order and told me the code
should take care of it.


svn:r5016
 2005-09-12 08:31:47 +00:00
Nick Mathewson
c1a6940e73 make compile slightly happier on const-zealous compilers 
svn:r5015
 2005-09-12 08:29:53 +00:00
Nick Mathewson
2689cb081b We have so many special cases for smartlists of strings, why not add a sort function? 
svn:r5014
 2005-09-12 08:27:01 +00:00
Roger Dingledine
63bb27f19d be more thorough about noticing when a directory request has failed: 
it has failed not only when the connection attempt fails, but also
if the conn reaches eof before we get a response that we're happy with.


svn:r5013
 2005-09-12 07:36:26 +00:00
Nick Mathewson
3dc5e77b58 Numerous changes to move towards client-side v2 directories. 
connection.c:
- Add some more connection accessor functions to make directory
  download redundancy checking work.

directory.c, or.h, router.c, routerlist.c:
- Start on logic to note when networkstatus downloads fail.

dirserv.c, routerlist.c, routerparse.c:
- Start maintaining an is_named field in routerstatus_t.  Don't
  actually look at it yet.

dirserv.c, routerlist.c:
- Remove expired networkstatus objects.

or.h:
- Make some booleans into bitfields
- Add prototypes

routerlist.c:
- Sort networkstatus list by publication time
- Function to remove old (older than 10 days) networkstatus objects.
- Function to set a list of routerinfo_ts' status info from the
  current set of networkstatus objects.
- Function to tell which routerinfos we need to download based no the
  current set of networkstatus objects.
- Do not launch a networkstatus download if a redundant one is in progress.

routerparse.c:
- Keep router entries in networkstatus sorted by digest.


svn:r5012
 2005-09-12 06:56:42 +00:00
Roger Dingledine
5cebd8df70 remove temporary network-status keyword 
svn:r5007
 2005-09-12 06:14:41 +00:00
Roger Dingledine
89d516f95c clean up the log entry for when a server posts a server descriptor that 
the dirserver doesn't like


svn:r5005
 2005-09-12 06:08:48 +00:00
Nick Mathewson
8d70ae01b8 Fix a memory leak in smartlist_string_remove. 
svn:r5002
 2005-09-12 05:20:29 +00:00
Nick Mathewson
63dfe2447e Fix bug found by "ca": looking up a non-existent stream for a v1 control connection would cause a segfault. (No backport needed since 0.1.0 had only v0 connections.) 
svn:r5001
 2005-09-12 03:32:30 +00:00
Nick Mathewson
24bfac635d Document SMARTLIST_FOREACH macro, along with previously-naughty foo_sl_idx variable. 
svn:r5000
 2005-09-11 23:14:14 +00:00
Roger Dingledine
d7d4d4cbbf fix comment and return value for check_software_version_against_directory() 
svn:r4996
 2005-09-11 22:36:50 +00:00
Roger Dingledine
b0a5ba4248 downgrade the dirserver log messages when whining about unreachability 
svn:r4991
 2005-09-10 20:40:16 +00:00
Roger Dingledine
cfe34812eb bugfix: if you gave tor an odd number of command-line arguments, 
we were silently ignoring the last one. now we complain and fail.


svn:r4988
 2005-09-10 04:40:27 +00:00
Roger Dingledine
e782ee344a bump to 0.1.1.6-alpha-cvs 
svn:r4987
 2005-09-10 03:41:39 +00:00
Roger Dingledine
9b54cd349d break out a new function config_assign_value() that just assigns the 
value it's given, and doesn't do any of their weird clearing or resetting
stuff. use that when we're trying to clear or reset values.


svn:r4984
 2005-09-10 02:42:32 +00:00
Nick Mathewson
a4f32e77ef Fix segfault in win32 unittests. 
svn:r4983
 2005-09-10 02:34:32 +00:00
Roger Dingledine
e58ca648c6 bump to 0.1.1.6-alpha 
this time for sure


svn:r4982
 2005-09-10 01:47:27 +00:00
Nick Mathewson
d26523e089 Use tor_listdir in test.c instead of duplicating ode. 
svn:r4981
 2005-09-10 01:42:42 +00:00
Roger Dingledine
1d9786a392 generalize route length to three plus one if the exit node is risky. 
svn:r4978
 2005-09-10 01:01:40 +00:00
Nick Mathewson
035b1953eb Add sorting/searching to smartlist 
svn:r4977
 2005-09-09 23:12:54 +00:00
Roger Dingledine
cfa321374d reject ports 465 and 587 by default now too 
svn:r4974
 2005-09-09 22:46:43 +00:00
Nick Mathewson
6b479b3cfa Only do openssl accel stuff if version is at least 0.9.7 
svn:r4973
 2005-09-09 22:07:15 +00:00
Nick Mathewson
09d83c564b Add missing arg to windows tor_listdir() 
svn:r4972
 2005-09-09 21:34:59 +00:00
Nick Mathewson
2f6eb10fb4 Implement tor_listdir on windows. Untested. 
svn:r4971
 2005-09-09 21:29:23 +00:00
Nick Mathewson
dcf1e14190 downgrade warning to info 
svn:r4967
 2005-09-09 21:03:57 +00:00
Roger Dingledine
a5ea401b2e a few more hints on a rare but mysterious warning 
svn:r4966
 2005-09-09 20:58:44 +00:00
Nick Mathewson
047e105daf Fix a bug in config_dump: we want to run options_validate on the defaults, not (again, uselessly) on the configuration. This was introduced when we made the config code more generic. 
svn:r4965
 2005-09-09 20:08:26 +00:00
Roger Dingledine
35b78b2d8e clean up the rendezvous warn log msgs, and downgrade some to info 
svn:r4964
 2005-09-09 19:54:28 +00:00
Nick Mathewson
0de64f224e Warn in more detail when network-status serving and fetching fails. Also, fix a small leak. 
svn:r4963
 2005-09-09 19:37:12 +00:00
Roger Dingledine
42f752a0a5 bugfix: we were automatically condemning an exit node (concluding 
its advertised exit policy is different from its real one) as soon
as it refused any requests.
After fixing that bug, another bug appeared: we would try the same
server again and again, since once we learned an IP address for a
hostname, we still kept think of it as the hostname. now pass it to
the remapper before trying to reattach.


svn:r4962
 2005-09-09 06:11:37 +00:00
Roger Dingledine
843550721a stop notifying people about dns worker spawning and culling 
it just freaks them out


svn:r4960
 2005-09-09 02:03:31 +00:00
Roger Dingledine
2065c5f7aa when printing x-forwarded-by headers, don't print the \r 
svn:r4959
 2005-09-09 02:02:20 +00:00
Nick Mathewson
bd911d8612 Fix segfault and memleak when getting many compressed server descs. 
svn:r4956
 2005-09-08 22:00:29 +00:00
Nick Mathewson
659491bbc6 Fix some messages that say "failing". 
svn:r4955
 2005-09-08 21:46:31 +00:00
Nick Mathewson
d410c49965 Clean up some more fingerprint-checking logic 
svn:r4954
 2005-09-08 21:39:39 +00:00
Roger Dingledine
587b513ec0 remove obsolete kludge 
svn:r4953
 2005-09-08 21:36:27 +00:00
Nick Mathewson
9df4716ac3 make it work correctly when we download multiple network-status objects. 
svn:r4952
 2005-09-08 21:28:45 +00:00
Nick Mathewson
4ce0e01848 add conn->requested_resource to connection_t checks. 
svn:r4951
 2005-09-08 21:21:54 +00:00
Nick Mathewson
a938190bdb Iteration is happier when you stop. 
svn:r4950
 2005-09-08 21:20:20 +00:00
Roger Dingledine
e28931dc94 unused variable 
svn:r4949
 2005-09-08 21:12:53 +00:00
Nick Mathewson
4528bbfd9f Resolve some XXXs. Add some others. 
svn:r4947
 2005-09-08 21:01:24 +00:00
Nick Mathewson
c523e106b5 Do not generate more than 2 of each directory type per minute. 
svn:r4946
 2005-09-08 20:47:11 +00:00
Nick Mathewson
18e4d78354 Fix an assert in directory.c. Check received network-status objects against the list we expected to get. Do not let anyone else update our network-status object. 
svn:r4945
 2005-09-08 20:36:40 +00:00
Nick Mathewson
059148f588 Only caches download network-status for now, and they use a different strategy. Add an element to connection_t to remember what we are downloading, and a function to recognize our own fingerprint. 
svn:r4944
 2005-09-08 20:18:15 +00:00
Nick Mathewson
6c4d43c724 Special-case for retrieving own networkstatus by fingerprint: regenerate if dirty! 
svn:r4943
 2005-09-08 19:29:21 +00:00
Roger Dingledine
465aec04c1 when reporting results from a dirserver fetch/post, tell us the 
port for the dirserver too


svn:r4942
 2005-09-08 19:21:48 +00:00
Nick Mathewson
df79dc673b Remove sneaky double declaration. 
svn:r4941
 2005-09-08 19:18:55 +00:00
Nick Mathewson
0f94aa2ea1 Write status to disk in the right place 
svn:r4940
 2005-09-08 19:16:16 +00:00
Nick Mathewson
cc16fb7636 oops -- that log should have been removed 
svn:r4939
 2005-09-08 19:12:55 +00:00
Nick Mathewson
e5f117606f Fix network-status parsing. 
svn:r4938
 2005-09-08 19:10:36 +00:00
Nick Mathewson
b43a720bd4 Fix another reversed inet_aton 
svn:r4937
 2005-09-08 18:53:57 +00:00
Nick Mathewson
1e2f1679c8 Fix some more bugs; add a temporary log. 
svn:r4936
 2005-09-08 18:46:25 +00:00
Nick Mathewson
eab005c948 Ensure case match, not mismatch. 
svn:r4935
 2005-09-08 18:34:41 +00:00
Nick Mathewson
c4b3bf06c6 add strupper function 
svn:r4934
 2005-09-08 18:33:51 +00:00
Nick Mathewson
810572a5de Stop dying when we get a directory from tor26; workaround for change in networkstatus format 
svn:r4933
 2005-09-08 18:24:26 +00:00
Roger Dingledine
4633b271f9 fix spacing 
svn:r4932
 2005-09-08 18:15:57 +00:00
Nick Mathewson
548a863779 Avoid assertion failure 
svn:r4931
 2005-09-08 18:14:23 +00:00
Nick Mathewson
ff9452e900 Clean up should-i-go-to-the-dirserv logic a little: All servers with DirPorts should get their directories from the source 
svn:r4930
 2005-09-08 18:14:01 +00:00
Nick Mathewson
3a99927859 Make directory download code slightly less likely to segfault or assert. 
svn:r4929
 2005-09-08 16:18:28 +00:00
Roger Dingledine
022f23249f make doxygen output look prettier 
svn:r4928
 2005-09-08 07:10:12 +00:00
Roger Dingledine
dbeb8e7863 it really does help with the functions end. 
svn:r4927
 2005-09-08 06:59:58 +00:00
Roger Dingledine
74fb086210 if you give a config option in the torrc or the commandline with no 
value, and reset is false, then it clears it entirely.


svn:r4926
 2005-09-08 06:55:53 +00:00
Roger Dingledine
36fa360c11 and fix grammar 
svn:r4925
 2005-09-08 06:49:23 +00:00
Roger Dingledine
69da0ef757 add punctuation 
svn:r4924
 2005-09-08 06:49:02 +00:00
Roger Dingledine
780261aa2e don't crash now that LongLivedPorts can be null 
svn:r4923
 2005-09-08 06:47:27 +00:00
Nick Mathewson
8f37357193 Make GCC v4 happy with heavy warnings enabled. 
svn:r4922
 2005-09-08 06:37:50 +00:00
Nick Mathewson
f50ddfd4dd Download network-status at regular intervals. The code is probably iffy, and the constants need to be renamed. 
svn:r4921
 2005-09-08 06:22:44 +00:00
Roger Dingledine
2f6664ce80 MonthlyAccountingStart is dead. 
svn:r4920
 2005-09-08 05:38:47 +00:00
Roger Dingledine
c9e1c41873 dirserv_add_descriptor() doesn't chew up its argument anymore, 
so we can stop protecting it.


svn:r4919
 2005-09-08 05:37:22 +00:00
Roger Dingledine
03ddeb2620 strip obsolete code 
svn:r4918
 2005-09-08 05:32:41 +00:00
Roger Dingledine
0ac3c58480 clean up comments for router_is_general_exit() 
svn:r4917
 2005-09-08 05:23:55 +00:00
Roger Dingledine
08348ae66e add a RESETCONF controller command, and make setconf with a null 
option actually mean to set it to ""


svn:r4916
 2005-09-08 03:18:51 +00:00
Roger Dingledine
0a8a8ba546 fix some typos 
svn:r4915
 2005-09-08 03:17:50 +00:00
Nick Mathewson
4aca47268d Logic to launch connections for new directory types. 
svn:r4914
 2005-09-07 20:03:02 +00:00
Nick Mathewson
9e76eae810 add missing return 
svn:r4913
 2005-09-07 17:18:52 +00:00
Nick Mathewson
eac917fd6a clean whitespace. 
svn:r4912
 2005-09-07 17:15:46 +00:00
Nick Mathewson
5c6c88e76d More stuff for new directories. 
- Distinguish v1 authorities (all currently trusted directories) from
  v2 authorities (all trusted directories).
    - Add configuration option for which dirs are v1 authories.
    - Add configuration option for whether to be a v1 authority.
    - Make trusted dirserver selection functions take options to
      choose which functionality we need.
    - Remove option when getting directory cache to see whether they
      support running-routers; they all do now.  Replace it with one
      to see whether caches support v2 stuff.

- Parse, cache, and serve network-status objects properly.

- Serve compressed groups of router descriptors.  The compression logic
  here could be more memory-efficient.

-


svn:r4911
 2005-09-07 16:42:53 +00:00
Roger Dingledine
c384fa706d stop using the v1 rend desc format. we're going to change v1 
some more before we switch to it.


svn:r4909
 2005-09-06 06:14:38 +00:00
Nick Mathewson
1e37ec4782 Comment structs, reload a field, start making network status caches work 
svn:r4908
 2005-09-04 23:12:27 +00:00
Roger Dingledine
d2a5b614eb if you're an auth dir server, start yourself out as verified. 
svn:r4907
 2005-09-03 23:10:28 +00:00
Nick Mathewson
b6a13b6cdf Add directory listing functions to util.[ch]. Watch the features creep! 
svn:r4906
 2005-09-03 04:40:05 +00:00
Roger Dingledine
33b2abbc90 remove redundant logs about unreachable servers 
svn:r4905
 2005-09-03 04:37:30 +00:00
Nick Mathewson
467fd6e4e6 fix order of items in network-status 
svn:r4904
 2005-09-03 02:38:39 +00:00
Nick Mathewson
3485a497fe Fix another ntohl 
svn:r4903
 2005-09-03 02:23:53 +00:00
Nick Mathewson
ae726e659e and another byte counting error. 
svn:r4902
 2005-09-03 02:14:31 +00:00
Nick Mathewson
9b949cc1d2 Excellent. We have at least 8 bytes, so I can safely get the 9th. 
svn:r4901
 2005-09-03 02:12:53 +00:00
Nick Mathewson
bcbff6dcd7 Note to self: htonl(htonl(X)) is *not* "twice as good as htonl(X)". Spotted by arma. 
svn:r4900
 2005-09-03 01:47:39 +00:00
Nick Mathewson
815c092b22 Make structs for (v2) network-status and its per-router components. Add functions to parse them. Re-do the parsing logic a litt.e. Change signatures in or.h to support new DNS TTL logic. 
svn:r4898
 2005-09-02 20:37:31 +00:00
Nick Mathewson
9bc3d34682 Add contact field to generated network-status objects 
svn:r4897
 2005-09-02 20:30:03 +00:00
Nick Mathewson
09e8521236 Make ContactInfo mandatory for authoritative directories. 
svn:r4896
 2005-09-02 20:29:29 +00:00
Nick Mathewson
a6a45b7713 Add TTLs to RESOLVED, CONNECTED, and END_REASON_EXITPOLICY cells. Also, add a missing ntohl in connection_ap_handshake_socks_resolved. 
svn:r4894
 2005-09-02 18:53:31 +00:00
Roger Dingledine
93179f4e7e bugfix: moria2 wasn't listing itself as verified in its directory 
svn:r4893
 2005-09-02 06:19:31 +00:00
Roger Dingledine
ba899d0648 when we're shutting down and we do something like try to post a 
server descriptor or rendezvous descriptor, don't complain that we
seem to be unreachable. of course we are, we're shutting down.


svn:r4892
 2005-09-01 08:19:49 +00:00
Roger Dingledine
1b04f38145 subtle change to avoid some false positives: 
if a server went down for six hours and then came back, we would
complain to it that it's unreachable. now we wait until the third
consecutive descriptor post that we thought it was unreachable,
before complaining to it.


svn:r4891
 2005-09-01 08:13:40 +00:00
Roger Dingledine
3b6ab71929 and notify the dirserver operator whenever we do 
svn:r4890
 2005-08-31 06:18:19 +00:00
Roger Dingledine
711cad94ed when we think a router is unreachable, pass the message back to the 
server's logs, and make it a 'warn'.
also, fix a memory leak for rejected router descriptors.


svn:r4889
 2005-08-31 06:14:37 +00:00
Nick Mathewson
0b92c28d84 Actually set is_hibernating when parsing router descriptors. 
svn:r4888
 2005-08-30 15:04:24 +00:00
Roger Dingledine
6a52aa52fe fix a pair of hard-coded urls 
svn:r4887
 2005-08-30 07:01:30 +00:00
Roger Dingledine
4240410a9d don't whine about reachability if the guy is hibernating now. 
speaking of which, we don't actually parse is_hibernating out
of the router descriptor right now. nick, can you fix this?


svn:r4886
 2005-08-30 06:48:24 +00:00
Roger Dingledine
e9524f9d2d refactor -- no actual changes 
svn:r4885
 2005-08-30 06:43:07 +00:00
Roger Dingledine
a8c0c51e0b a bit of cleanup 
svn:r4884
 2005-08-30 06:01:13 +00:00
Nick Mathewson
0691c7221e Update routerinfo_t.is_running when generating network status on authdirserver. 
svn:r4883
 2005-08-29 18:42:36 +00:00
Nick Mathewson
29a6c17d67 Allow tor_gzip_uncompress to handle multiple concatenated compressed strings. 
svn:r4882
 2005-08-29 18:01:38 +00:00
Nick Mathewson
e3a058f33a Change semantics of set_cached_dir; fix massive authdir memleak. 
svn:r4880
 2005-08-28 04:20:37 +00:00
Nick Mathewson
26d2301c76 Make unit tests (and others) run without launching listeners, creating subdirectories, and so on. 
svn:r4876
 2005-08-26 23:22:27 +00:00
Nick Mathewson
cd2bb915ed Fix a warning, add an assert. 
svn:r4875
 2005-08-26 23:12:13 +00:00
Nick Mathewson
70fe2a6cee Crashing dirservers on startup is often considered bad form. 
svn:r4874
 2005-08-26 23:04:12 +00:00
Nick Mathewson
e863771485 Log when falling back to nonfast/nonstabl routers 
svn:r4869
 2005-08-26 22:16:32 +00:00
Nick Mathewson
ed070b0fdb Set a variable that exists. That works better. 
svn:r4868
 2005-08-26 22:16:09 +00:00
Roger Dingledine
6577e08e38 when we're trying to build a circuit and we're being picky about what 
sort we get but there aren't any suitable servers, try being less picky
rather than simply failing.


svn:r4867
 2005-08-26 22:10:22 +00:00
Nick Mathewson
a74ad8efea Remember to mark v2 networkstatus non-dirty when we generate it; also, fix spaces. 
svn:r4866
 2005-08-26 22:08:24 +00:00
Nick Mathewson
3cc960c7dd Make sure that cached-status directory exists. 
svn:r4865
 2005-08-26 22:03:57 +00:00
Roger Dingledine
77f52e3467 fix some logs and comments 
svn:r4864
 2005-08-26 21:55:38 +00:00
Nick Mathewson
ae4a183ed8 Change the return values on dirserv_add_descriptor 
svn:r4863
 2005-08-26 21:46:24 +00:00
Roger Dingledine
53431a4950 fix compile complaints (and a bug) 
svn:r4862
 2005-08-26 21:30:52 +00:00
Nick Mathewson
e24d540d81 We no longer need dirserv_load_from_directory_string, so dirserv_add_descriptor no longer has to keep track of where each descriptor ends. 
svn:r4861
 2005-08-26 21:28:16 +00:00
Nick Mathewson
208bdf5f27 No need to load cached directory twice 
svn:r4860
 2005-08-26 21:19:58 +00:00
Roger Dingledine
715b972300 disarm a trap 
svn:r4859
 2005-08-26 21:12:53 +00:00
Nick Mathewson
47669fa0fd Fix assert failure on directory startup. 
svn:r4858
 2005-08-26 21:12:34 +00:00
Nick Mathewson
f559c49c39 Make network-status strings wellformed 
svn:r4857
 2005-08-26 21:11:53 +00:00
Nick Mathewson
47aa42fc17 Remove a field that nobody sets or uses. 
svn:r4856
 2005-08-26 21:11:34 +00:00
Nick Mathewson
9a3be928e9 Note that a descriptor has changed when we receive a new directory. 
svn:r4855
 2005-08-26 21:02:18 +00:00
Nick Mathewson
0e649ac60a Remove descriptor_list and use routerlist instead. Make directories manage routerlist a little better. 
svn:r4854
 2005-08-26 20:59:04 +00:00
Roger Dingledine
a47765a16d stop freeing the new global options list whenever we update it. 
svn:r4853
 2005-08-26 20:26:20 +00:00
Roger Dingledine
237f58524f make it clearer which elements of routerinfo_t are for reachability 
testing


svn:r4852
 2005-08-26 20:22:32 +00:00
Roger Dingledine
f3bccdce73 if dirservers set assumereachable, it overrides their individual 
reachability testing


svn:r4851
 2005-08-26 20:08:12 +00:00
Roger Dingledine
61f728f4fe fix an infinite loop at hup 
svn:r4850
 2005-08-26 20:07:55 +00:00
Nick Mathewson
7f78be1659 Clean up the "add myself as a trusted dirserver" code. 
svn:r4849
 2005-08-26 19:31:51 +00:00
Nick Mathewson
43488472ec The circus music begins playing as nickm and arma juggle an ntohl. Hoop-lah! 
svn:r4848
 2005-08-26 19:25:36 +00:00
Nick Mathewson
ee76baae3d move a wandering ntohl 
svn:r4847
 2005-08-26 19:23:52 +00:00
Nick Mathewson
0239249160 Only free strmap if it is allocated. 
svn:r4846
 2005-08-26 18:48:13 +00:00
Nick Mathewson
cf90a36dd1 Add quotes around filenames in src/or 
svn:r4845
 2005-08-26 18:44:26 +00:00
Roger Dingledine
fa507c63e8 put quotes around user-supplied strings so they are more likely to 
realize if they add bad characters (like quotes) to the torrc


svn:r4844
 2005-08-26 18:40:44 +00:00
Nick Mathewson
ff25a7707a fix syntax err 
svn:r4843
 2005-08-26 18:35:52 +00:00
Nick Mathewson
88989be99b More documenting 
svn:r4842
 2005-08-26 18:02:49 +00:00
Nick Mathewson
e204dd5d2a Remove accidentally added printf 
svn:r4841
 2005-08-26 15:35:43 +00:00
Nick Mathewson
d54d7b7ec1 Add some documentation; move the signature generation logic into routerparse.c along with the hash generation logic; make router signing use it as well. 
svn:r4840
 2005-08-26 15:34:53 +00:00
Roger Dingledine
893acb3acc Make a new AssumeReachable config option that will publish anyway. 
Also, let authdirservers start without setting their Address field.
Something is still not working though. Will fix in morning.


svn:r4839
 2005-08-26 07:41:19 +00:00
Roger Dingledine
d5e426ab51 add a tor_dup_addr() function to simplify malloc()+tor_inet_ntoa() 
svn:r4838
 2005-08-26 07:37:07 +00:00
Nick Mathewson
e68bed8782 Fall back to routerlist instead of descriptor_list when we are a cache. 
svn:r4837
 2005-08-25 20:54:12 +00:00
Nick Mathewson
4dc3cb9fd9 Fix a segfault when starting a dir cache 
svn:r4836
 2005-08-25 20:45:53 +00:00
Nick Mathewson
54a6a8f0ef Start implementing the server side of the new directory protocol. 
Probably very buggy, since I can't actually run an authdir.

Features
- Generate and publish new network-status format
- Code to cache and re-serve network-status objects generated by others.
- Publish individual descriptors (by fingerprint, by "all", and by
  "tell me yours.")  [Still needs compression logic]
- Publish client and server recommended versions seprately.
- Add digest of descriptor to routerinfo_t, so we can track them better, and
  length, so we can server them more easily.

Cleanups
- Unify code to sign directory-like things
- Make resolve_my_address() able to tell you which name it wound up resolving.
- Unify code to store and serve directory-like things so it all uses
  cached_dir_t.
- Unify code to set the value of cached_dir_t objects.


svn:r4835
 2005-08-25 20:33:17 +00:00
Roger Dingledine
86f85f240c be much more conservative about logging reachability complaints. 
the ones it logs now are probably genuine problem servers.


svn:r4832
 2005-08-24 14:31:32 +00:00
Roger Dingledine
e54e970a82 ha ha, that infinite loop was fun. 
but dirservers aren't supposed to have infinite loops.


svn:r4831
 2005-08-24 12:14:44 +00:00
Roger Dingledine
a120cc20c1 Dirservers now do their own external reachability testing of each 
Tor server, and only list them as running if they've been found to
be reachable.

Dirservers also log trouble servers, but only start complaining loudly
after they've been up for an hour, to reduce false positives. We still
need to do something about the fact that it is quite loud when there
are many trouble servers.


svn:r4829
 2005-08-24 02:31:02 +00:00
Nick Mathewson
5d590861c4 TOR_ISSPACE, not isspace. 
svn:r4828
 2005-08-24 02:20:31 +00:00
Nick Mathewson
b72ab23ded check [X-]Forwarded-For headers in HTTP requests when generating log messages. Implements feature for bug 181. Arma--please review? 
svn:r4826
 2005-08-23 22:27:17 +00:00
Nick Mathewson
50452c32ec fix bug 180: handle duplicate lines in approved-routers files. 
svn:r4825
 2005-08-23 22:00:35 +00:00
Roger Dingledine
fed90c300f downgrade back to 0.1.1.5-alpha-cvs 
it's going to be another while


svn:r4824
 2005-08-23 10:01:11 +00:00
Roger Dingledine
f35ef825f9 Our logic to decide if the OR we connected to was the right guy 
was brittle and maybe open to a mitm for unverified routers.

Now we be sure to check the digest, and if the nickname he claims is
not a verified one then we don't care what nickname he claims.


svn:r4823
 2005-08-23 09:50:51 +00:00
Roger Dingledine
675f6b5f3c that comma was important 
svn:r4820
 2005-08-23 01:00:30 +00:00
Roger Dingledine
8b766d1b7e fix bad logic that has been lurking for eons, that now prevented us 
from uploading descriptors after the first one.


svn:r4818
 2005-08-23 00:47:44 +00:00
Roger Dingledine
ab112ca6ad and don't print the null string here either 
svn:r4816
 2005-08-22 22:59:54 +00:00
Roger Dingledine
23ed3c9786 whoops, avoid printing a null string sometimes 
svn:r4815
 2005-08-22 22:58:38 +00:00
Roger Dingledine
676b330eb2 Make DirPostPeriod config option obsolete. 
Force new descriptor upload every 18 hours, not 24, to avoid races.
Change rate-limiting on new descriptors due to bandwidth changes, from
45 minutes to 20 minutes.


svn:r4814
 2005-08-22 21:53:12 +00:00
Roger Dingledine
8adcd0bb3b bump version to 0.1.1.6-alpha 
svn:r4813
 2005-08-22 20:12:39 +00:00
Roger Dingledine
fa64d73fc7 fix function headers from the descriptor-frequency commit 
svn:r4809
 2005-08-22 06:45:18 +00:00
Roger Dingledine
435d2d8fde when we begin reachability testing, log the address:port for each 
port we're testing, so people are more likely to notice that they're
using the wrong ip address.


svn:r4808
 2005-08-22 05:46:02 +00:00
Roger Dingledine
d928411acd change log entry for unreachability to explicitly suggest /etc/hosts 
as the culprit


svn:r4807
 2005-08-22 05:33:49 +00:00
Nick Mathewson
dc09c7fc73 Implement new (reduced-frequency) upload rules. arma, you should review this. 
svn:r4806
 2005-08-22 03:10:53 +00:00
Nick Mathewson
9b6eeb81aa Make unit tests run without segfaulting 
svn:r4804
 2005-08-22 00:34:42 +00:00
Nick Mathewson
9321db8c29 Fix bug with tor_memmem finding a match at the end of the string. 
svn:r4803
 2005-08-22 00:34:23 +00:00
Nick Mathewson
7a442c2c48 Make set_options a little smarter: have options_act handle transitions on its own, and only dirty our descriptor when we really want to. 
svn:r4802
 2005-08-22 00:18:45 +00:00
Roger Dingledine
5e76bac1dd the tor-spec says router->address must be an IP address. so refuse 
it if it's not.
(this also fixes some potential security problems with people providing
hostnames as their address and then preferentially resolving them and
partitioning users.)


svn:r4790
 2005-08-16 02:52:27 +00:00
Andrew Lewman
955a10fee0 Initial complete config file. Organized into easily searchable 
sections.


svn:r4789
 2005-08-16 02:14:40 +00:00
Roger Dingledine
04d42ea433 rotate dns and cpu workers if the controller changes options that 
will affect them.


svn:r4787
 2005-08-15 23:46:18 +00:00
Roger Dingledine
b1d3f124c4 Permit transitioning from ORPort=0 to ORPort!=0, and back. 
This is actually a bit more subtle, because we need to rotate
the dnsworkers and cpuworkers if certain options (logs, orport, etc)
change. Maybe set_options() should detect this and notify the caller
that it should rotate them.

Expect some mysterious crashes.


svn:r4786
 2005-08-15 10:30:45 +00:00
Roger Dingledine
10ff723938 initialize the dns worker cache tree whether or not we start 
out as a server.


svn:r4785
 2005-08-15 10:27:37 +00:00
Roger Dingledine
157f013d83 fix typo 
svn:r4784
 2005-08-15 09:25:36 +00:00
Roger Dingledine
00c2ba4841 resolve a XXX 
svn:r4783
 2005-08-15 09:19:55 +00:00
Roger Dingledine
11bc97801d clean up some confusing logs. 
make MonthlyAccountingStart truly obsolete now.


svn:r4782
 2005-08-15 09:17:47 +00:00
Roger Dingledine
79e3f5600a hey, we have a function for that 
svn:r4781
 2005-08-15 08:51:20 +00:00
Roger Dingledine
3728011f36 after failing from resolve failed or misc, reset the num failures. 
svn:r4780
 2005-08-15 03:35:15 +00:00
Roger Dingledine
f57d062d9c Implement exit enclaves: if we know an IP address for the destination, 
and there's a running Tor server at that address which allows exit to
the destination, then extend the circuit to that exit first.
Also, if the user asks for a .exit node, cannibalize general circs for it.


svn:r4779
 2005-08-15 03:25:40 +00:00
Roger Dingledine
121ea4dd93 a url for better reference 
svn:r4778
 2005-08-15 01:03:50 +00:00
Roger Dingledine
cc1b82ade8 when listing min-bandwidth servers in the controller, don't get 
fooled by a low bandwidthrate


svn:r4777
 2005-08-14 08:38:34 +00:00
Roger Dingledine
ff54050fda let unregistered-servers take a parameter (the min bandwidth) 
nick, is this an ugly hack of your protocol?


svn:r4775
 2005-08-13 02:20:00 +00:00
Roger Dingledine
66b21a19db Add a 'quit' command for the controller. 
Add a 'getinfo unregistered-servers' for arma's internal use.


svn:r4774
 2005-08-13 01:55:23 +00:00
Roger Dingledine
6d875b7d58 i'm sick of having my streams fail because of a confused exit node. 
try this band-aid to see if it gets better.


svn:r4773
 2005-08-13 00:31:41 +00:00
Roger Dingledine
87fcd60aa2 predict required circuits better, with an eye toward making 
hidden services faster on the service end.


svn:r4772
 2005-08-13 00:22:07 +00:00
Nick Mathewson
d1c094637d Try to resolve another reported solaris x86 warning 
svn:r4771
 2005-08-12 17:26:43 +00:00
Nick Mathewson
789374dbbd Make GCC very happy, even with lots of warnings set. Also, try to fix some reported Solaris x86 warnings. 
svn:r4770
 2005-08-12 17:24:53 +00:00
Nick Mathewson
21959c1bfd start using new renddesc code 
svn:r4769
 2005-08-12 15:05:05 +00:00
Roger Dingledine
aab541c852 We weren't cannibilizing circuits correctly for 
CIRCUIT_PURPOSE_C_ESTABLISH_REND and CIRCUIT_PURPOSE_S_ESTABLISH_INTRO
so we were being forced to build those from scratch.
This should save us a bit of time. Also fixes bug 173.


svn:r4763
 2005-08-12 01:26:21 +00:00
Roger Dingledine
2caa74e6ff quiet a noisy debug 
svn:r4762
 2005-08-12 00:34:50 +00:00
Nick Mathewson
16528aa070 Add a config-file GETINFO entry; fix a minor memory leak on some SAVECONF calls. 
svn:r4761
 2005-08-10 18:05:20 +00:00
Nick Mathewson
c031d14633 Fix segfault in unit tests 
svn:r4760
 2005-08-09 18:49:43 +00:00
Nick Mathewson
18abdfdf58 Replace ADDR_POLICY_ACCEPT/REJECT with its own enum 
svn:r4756
 2005-08-09 05:22:23 +00:00
Nick Mathewson
05bced6139 check_software_version_against_directory needs a return value. 
svn:r4755
 2005-08-09 05:20:14 +00:00
Nick Mathewson
742796c19f Avoid sending blank lines when GETINFO replies should be empty 
svn:r4754
 2005-08-09 05:16:29 +00:00
Roger Dingledine
f9f600f032 bump to 0.1.1.5-alpha-cvs 
svn:r4753
 2005-08-08 22:34:24 +00:00
Nick Mathewson
943ef5256b fix whitespace issues 
svn:r4752
 2005-08-08 21:59:48 +00:00
Nick Mathewson
249b72f53e Replace (Fascist)Firewall* with a new ReachableAddresses option that understands address policies. 
svn:r4751
 2005-08-08 21:58:48 +00:00
Roger Dingledine
3ac34ae329 get rid of IgnoreVersion and the forced auto-exit mis-feature 
svn:r4746
 2005-08-08 21:52:57 +00:00
Roger Dingledine
588e80fdcd fix a function comment 
svn:r4743
 2005-08-08 17:48:23 +00:00
Nick Mathewson
50cfcbe157 Note which directory server said 400 to a renddesc. 
svn:r4742
 2005-08-08 17:32:17 +00:00
Roger Dingledine
f4eec180a2 disarm a trap that's lying in wait for us 
svn:r4741
 2005-08-08 17:31:57 +00:00
Roger Dingledine
2e918af35d a few typo fixes 
svn:r4738
 2005-08-07 21:58:23 +00:00
Nick Mathewson
01d0788950 Generalize FirewallPorts to FirewallIPs so I can run happily when locked in net 18. 
svn:r4737
 2005-08-07 21:24:00 +00:00
Nick Mathewson
9345323b18 far far cleaner implementation of handshake checking logic. Backport candidate. 
svn:r4736
 2005-08-07 20:36:14 +00:00
Nick Mathewson
4e735da5da Also set event_mask=0 in connection_free_all, and dont send events to marked control conns (for good measure) 
svn:r4729
 2005-08-07 19:27:38 +00:00
Roger Dingledine
5c4da9dec6 incomplete patch for matt's info controller signal term bug 
svn:r4728
 2005-08-07 19:20:55 +00:00
Roger Dingledine
bfe65db284 ok, so now it was just redundant. nick, do you recall what rfc 
you were trying to point to?


svn:r4727
 2005-08-07 17:11:33 +00:00
Nick Mathewson
999b7951c3 Shorten hidden service port config parsing; fix bug 174 
svn:r4725
 2005-08-06 21:35:04 +00:00
Roger Dingledine
b9a7482c02 note another potential security problem with generating key material 
from our DH handshake.


svn:r4724
 2005-08-06 16:50:51 +00:00
Roger Dingledine
261bf4c4d4 rfc 3536 "provides a glossary of terms used in the IETF when discussing 
internationalization."


svn:r4723
 2005-08-05 22:08:57 +00:00
Nick Mathewson
224fecb281 Appease insane windows compiler. (Oh no, an extra semi, the sky is falling!) 
svn:r4722
 2005-08-05 19:25:23 +00:00
Roger Dingledine
1ec3081a84 bump to 0.1.1.5-alpha, though it's not released yet 
svn:r4721
 2005-08-05 19:16:11 +00:00
Nick Mathewson
197eb2b2cb fix harmless copy-and-paste error 
svn:r4718
 2005-08-05 14:59:14 +00:00
Nick Mathewson
ea2aa107a7 cover a few more cases; needs testing and once-over 
svn:r4717
 2005-08-05 14:20:38 +00:00
Nick Mathewson
666ab41e2b parse_addr_port was vague about what to do when port_out was NULL. Make it behave usefully. 
svn:r4716
 2005-08-05 01:51:19 +00:00
Nick Mathewson
52475ee19b Alphebetize config variables 
svn:r4714
 2005-08-05 01:35:43 +00:00
Nick Mathewson
3fa821d911 oops, that array got bigger 
svn:r4708
 2005-08-04 23:18:51 +00:00
Nick Mathewson
7a9eb49f5f Discard special bignum values. 
svn:r4706
 2005-08-04 23:14:42 +00:00
Roger Dingledine
1d3e63158e bump to 0.1.1.4-alpha in preparation for new release 
svn:r4701
 2005-08-04 22:45:54 +00:00
Nick Mathewson
546fba7b04 Fix windows warning 
svn:r4697
 2005-08-04 22:25:39 +00:00
Nick Mathewson
4870877231 Add SOCKSAndDNS link to appropriate log message, since we wind up pointing everybody to it anyway 
svn:r4695
 2005-08-04 20:12:44 +00:00
Nick Mathewson
4cb89fd557 Implement some more GETINFO goodness: expose helper nodes, config options, getinfo keys. 
svn:r4694
 2005-08-04 19:56:41 +00:00
Nick Mathewson
303258972b Fix idiot bug. The "free the IP history" code belons in connection_free_all(), not in connection_free(). You can all mock me now. 
svn:r4691
 2005-08-04 18:29:01 +00:00
Nick Mathewson
11ff0aba80 Make clients regenerate their keys when their IP address changes. 
svn:r4688
 2005-08-03 20:42:17 +00:00
Nick Mathewson
ceb02cee2c If they havent told us by now, they probably never will. 
svn:r4687
 2005-08-03 20:37:13 +00:00
Nick Mathewson
98f1265309 Fix compile failures on tor_gettimeofday() fix for windows 
svn:r4685
 2005-08-03 17:16:48 +00:00
Nick Mathewson
176e9055cc Probably broken attempt to improve tor_gettimeofday granularity on windows. 
svn:r4683
 2005-08-03 16:28:39 +00:00
Nick Mathewson
d90841ff5a Fix bug in state parsing 
svn:r4681
 2005-07-28 19:08:51 +00:00
Nick Mathewson
299af3d393 Possibly broken implementation of persistant state; handles helper nodes; does not handle accounting info yet. 
svn:r4680
 2005-07-28 19:01:48 +00:00
Nick Mathewson
67d8c5af8f define TIME_T_IS_SIGNED on windows 
svn:r4676
 2005-07-25 18:13:05 +00:00
Nick Mathewson
48787c839e Fix logic to set TIME_T_MAX; apparently, everybody had thought of the prospect of a signed time_t but me. 
svn:r4675
 2005-07-25 18:10:08 +00:00
Roger Dingledine
a32f936346 whoops, fix compile 
svn:r4674
 2005-07-25 10:36:01 +00:00
Roger Dingledine
1e0fdcae98 parameterize RephistTrackTime 
svn:r4673
 2005-07-25 10:29:21 +00:00
Roger Dingledine
2fa109102a bump to 0.1.1.3-alpha 
svn:r4672
 2005-07-25 09:12:18 +00:00
Roger Dingledine
44fe2fa7eb better log examples in the torrc 
svn:r4646
 2005-07-23 05:14:33 +00:00
Roger Dingledine
9385a96235 fix typos 
svn:r4645
 2005-07-23 04:35:58 +00:00
Nick Mathewson
bb4ebaac6f document code for hibernation 
svn:r4644
 2005-07-23 04:12:35 +00:00
Roger Dingledine
cfd6514482 and a nearby define 
svn:r4643
 2005-07-23 02:19:43 +00:00
Nick Mathewson
b98e4a0cd7 add parenthesis to U64_PRINTF_ARG macro 
svn:r4642
 2005-07-23 02:12:40 +00:00
Nick Mathewson
2bd6040f62 Rename cross-format config.c stuff to config_* and or_options_t-specific stuff to option[s]_* 
svn:r4641
 2005-07-23 01:58:05 +00:00
Nick Mathewson
3cb7b97660 Fix out-of-place declaration 
svn:r4640
 2005-07-23 01:52:24 +00:00
Nick Mathewson
18c11eb3bc Be consistent about preferring foo* to struct foo* 
svn:r4637
 2005-07-22 21:12:10 +00:00
Nick Mathewson
c252a76f0b Parameterize configuration parsing functions 
svn:r4635
 2005-07-22 20:37:42 +00:00
Nick Mathewson
c3a62c1739 Initial, somewhat dodgy implementation of helper nodes. It has too many XXXXs, it logs too verbosely, and it doesnt do persistence. 
svn:r4633
 2005-07-22 17:32:25 +00:00
Nick Mathewson
5b4e11fa5d Add getinfo logic for accounting; add options for helper nodes 
svn:r4632
 2005-07-22 14:55:09 +00:00
Roger Dingledine
495169d316 the abuse faq moved, so change the url 
svn:r4629
 2005-07-22 06:35:25 +00:00
Roger Dingledine
3333d27f41 we were mangling memory because we weren't allocing enough 
for the hidserv desc
nick can you check that this is enough now?


svn:r4628
 2005-07-22 00:18:25 +00:00
Roger Dingledine
1efeb3908a let hidden service descriptors publish 0 intro points 
nick, please check the logic here


svn:r4627
 2005-07-22 00:14:58 +00:00
Roger Dingledine
11bd4bc521 in circuit_list_path(), don't redundantly print the intended exit 
nickname when the circuit is open.


svn:r4622
 2005-07-20 20:33:13 +00:00
Roger Dingledine
eedb7c243e be consistent about printing out key digest $'s when we're getting a 
different key than we expect


svn:r4609
 2005-07-19 21:26:24 +00:00
Roger Dingledine
f2bc79ba89 forward-port with a different version claim 
svn:r4608
 2005-07-19 21:16:31 +00:00
Roger Dingledine
7ac36a9a74 unit tests to prove i didn't screw up 
svn:r4602
 2005-07-18 23:36:12 +00:00
Roger Dingledine
8c657e4157 cosmetic fixes 
svn:r4601
 2005-07-18 23:33:19 +00:00
Roger Dingledine
e479cc935e stop asserting if we have a controller listening for circuit events 
and we're offline so we fail to make a circuit and it tries to notify
us about the zero-length circuit.


svn:r4600
 2005-07-18 23:18:00 +00:00
Roger Dingledine
bb97d7f4ea slightly cleaner fix 
svn:r4599
 2005-07-18 23:16:09 +00:00
Roger Dingledine
893652da84 bugfixes: smartlist_join_strings2() was underflowing a size_t 
if you gave it an empty smartlist; and it wasn't terminating in
this case even if you asked it to.

this does not appear to be exploitable in any reasonable cases.


svn:r4598
 2005-07-18 23:11:46 +00:00
Roger Dingledine
5fe18894b9 now that we're recommending 0.1.1.x-alpha for win32 and os x users, 
stop printing debug stuff once a minute


svn:r4596
 2005-07-18 19:16:17 +00:00
Roger Dingledine
e8a1b1d6a0 add a trivial tor-counting variable 
svn:r4593
 2005-07-18 06:09:04 +00:00
Roger Dingledine
43a28a4ca9 make event streams work with control v1 too 
svn:r4590
 2005-07-17 22:28:01 +00:00
Roger Dingledine
6ac245793c downgrade a warning that could plausibly happen sometimes now that we 
have controllers.


svn:r4589
 2005-07-17 21:43:47 +00:00
Roger Dingledine
090836d171 correct error message in closestream 
svn:r4588
 2005-07-17 21:36:33 +00:00
Roger Dingledine
ebf13c6282 not not zero means zero 
svn:r4587
 2005-07-17 21:22:18 +00:00
Roger Dingledine
5643532bd9 if the controller asks to extendcircuit to circid 0, we need to 
init the circuit before we can add hops to its cpath.


svn:r4586
 2005-07-17 21:13:36 +00:00
Roger Dingledine
fe7535c5e2 arguments in EXTENDCIRCUIT were reversed 
and an error message was misleading
and we were leaking memory on some errors
more bugs remain


svn:r4585
 2005-07-17 21:06:00 +00:00
Nick Mathewson
2cff73e7a4 Make "Couldnt add router to list" message more descriptive. Make messages consistenly punctuated. 
svn:r4582
 2005-07-15 19:40:38 +00:00
Nick Mathewson
f8b48176ed Fix several bugs in read_escaped_data; add a unit test and a few docs 
svn:r4580
 2005-07-15 19:31:11 +00:00
Roger Dingledine
61f2ea0df0 bump us to 0.1.1.2-alpha-cvs since stuff has changed 
svn:r4579
 2005-07-15 19:18:36 +00:00
Nick Mathewson
441e02d4ac Merge patch from Matt Edman for bug 162 (service never stops) 
svn:r4578
 2005-07-15 19:09:36 +00:00
Roger Dingledine
545c2c6c87 the other half of the bugfix: tolerate a trusted dirserver claiming 
dirport 0 in its descriptor.


svn:r4576
 2005-07-15 18:56:59 +00:00
Roger Dingledine
97174b67c2 if you're an auth dir server, always publish your dirport, 
even if you haven't yet found yourself to be reachable.

this is the cause of Jan Tore Morken's recent or-talk bug.


svn:r4575
 2005-07-15 18:49:35 +00:00
Roger Dingledine
83dc42055d point out some bugs for nick, noticed by whiteout 
svn:r4574
 2005-07-15 18:48:38 +00:00
Roger Dingledine
452c98058f missed one 
svn:r4567
 2005-07-14 23:08:55 +00:00
Roger Dingledine
d8d0feb633 tell us what kind of listener it is, too 
svn:r4566
 2005-07-14 23:07:05 +00:00
Nick Mathewson
f86a1e634f fix opening listener log msg 
svn:r4565
 2005-07-14 23:04:31 +00:00
Nick Mathewson
e94f95a716 Populate address field of listeners with an actually sane value. 
svn:r4564
 2005-07-14 22:56:17 +00:00
Roger Dingledine
c2abcc4f1c bump to 0.1.1.2-alpha 
svn:r4563
 2005-07-14 22:46:42 +00:00
Roger Dingledine
867cbf1022 and here too 
svn:r4561
 2005-07-14 22:38:30 +00:00
Roger Dingledine
ceae96a3a0 put in tor26's new IP address 
svn:r4560
 2005-07-14 22:37:52 +00:00
Nick Mathewson
331942870e fix problems noticed by arma in rendservice.c 
svn:r4558
 2005-07-14 16:41:47 +00:00
Nick Mathewson
149e9a5900 remove pointless XXXX. It was there to remind me to do something I already did. 
svn:r4557
 2005-07-14 16:37:33 +00:00
Roger Dingledine
4a6bf116e7 substantive changes on nick's rendezvous commit. 
nick, can you fix these?


svn:r4554
 2005-07-14 08:45:19 +00:00
Roger Dingledine
2259032ea1 trivial changes on nick's rendezvous commit 
svn:r4553
 2005-07-14 08:43:19 +00:00
Roger Dingledine
19810ba38e make it more pleasant to be told you're using libevent 
svn:r4548
 2005-07-13 21:22:34 +00:00
Roger Dingledine
306f7d320c make a notice-level log make more sense. 
svn:r4547
 2005-07-13 21:12:33 +00:00
Nick Mathewson
97c58f066a whitespace fixes 
svn:r4544
 2005-07-13 17:24:55 +00:00
Nick Mathewson
278bac421f Fix windows compilation 
svn:r4543
 2005-07-13 15:24:33 +00:00
Nick Mathewson
50e11ee16a Fix possible double call to inflateEnd. 
svn:r4540
 2005-07-13 05:26:43 +00:00
Nick Mathewson
cf13b3e4a6 Macro-fu to get DEBUG events working. 
svn:r4539
 2005-07-13 05:14:42 +00:00
Roger Dingledine
4457c181f5 note a worrying double-free possibility in torgzip. 
nick?


svn:r4537
 2005-07-12 23:21:15 +00:00
Roger Dingledine
ddecb1a04d looks like we were never delivering deflated running-routers lists 
svn:r4536
 2005-07-12 22:56:22 +00:00
Roger Dingledine
7c7c95c3f6 anonymous bugfix on our pointer arithmetic 
svn:r4535
 2005-07-12 22:56:06 +00:00
Nick Mathewson
0828feaf7c Add belt-and-suspenders fix to coredump from yesterday; document more functions in buffers.c 
svn:r4532
 2005-07-12 18:19:30 +00:00
Roger Dingledine
8f9790a023 fix a seg fault with autodetecting which controller version is being used 
svn:r4531
 2005-07-12 05:48:15 +00:00
Nick Mathewson
63f9a8baa2 Canonicalize option names even on defaulted options. 
svn:r4530
 2005-07-11 18:11:54 +00:00
Nick Mathewson
50a206e800 Do not reverse command-line configuration options; Use new minimal-listener-close code; Add code to canonicalize configuration names. 
svn:r4529
 2005-07-11 17:35:36 +00:00
Nick Mathewson
658e1196d0 Change retry_listeners: when force is false, close and re-open a minimal set of listeners (i.e., those that do not match the configuration). This fixes a possible bug on some windowses. Maybe. 
svn:r4528
 2005-07-11 17:20:22 +00:00
Nick Mathewson
e1db33971e NT service patch from Matt Edman to improve error messages, lightly cleaned; needs more testing. 
svn:r4527
 2005-07-09 16:37:12 +00:00
Roger Dingledine
2f1f0c8d21 be flexible in what you accept: when people type "tor --install" thinking 
they had typed "tor -install", make it work too.


svn:r4526
 2005-07-09 03:28:58 +00:00
Roger Dingledine
5c1ba5dcf7 fix compile error in cvs 
svn:r4520
 2005-07-02 00:18:09 +00:00
Nick Mathewson
b11e314f2e Be more explicit about which IP we are connecting to; expose future exit policy problems better. 
svn:r4519
 2005-07-01 13:40:29 +00:00
Roger Dingledine
271d49958e fix another compile warn 
svn:r4516
 2005-07-01 02:02:24 +00:00
Roger Dingledine
3bb756b93b forward-port the 0.1.0.11 stuff 
svn:r4515
 2005-07-01 02:01:21 +00:00
Roger Dingledine
055477f121 fix compile error (and likely a a crash bug in resolves) 
svn:r4514
 2005-07-01 01:59:37 +00:00
Nick Mathewson
d85bfe83bf Make errors retrievable from tor_socketpair; resolve bug 163. 
svn:r4509
 2005-06-30 07:17:38 +00:00
Nick Mathewson
584a0ae397 Fix an fd leak in start_daemon 
svn:r4508
 2005-06-30 06:56:00 +00:00
Nick Mathewson
ec83652357 Logic to implement rendezvous/introduction via unknown servers. 
- Add a new extend_info_t datatype to hold information needed to
  extend a circuit (addr,port,keyid,onion_key).  Use it in cpath and
  build_state.  Make appropriate functions take or return it instead of
  routerinfo_t or keyid.

- #if 0 needless check in circuit_get_by_edge_conn; if nobody triggers this
  error in 0.1.0.10, nobody will trigger it.

- Implement new hidden service descriptor format, which contains "extend
  info" for introduction points, along with protocol version list.
  - Parse new format.
  - Generate new format
  - Cache old and new formats alongside each other.
  - Directories serve "old" format if asked in old way, "newest available"
    format if asked in new way.
  - Use new format to find introduction points if possible; otherwise fall
    back.  Keep nickname lists and extendinfo lists in sync.
  - Tests for new format.

- Implement new "v2" INTRODUCE cell format.
  - Accept new format
  - Use new format if we have a versioned service descriptor that says the
    server accepts the new format.

- Add documentation for functions and data types.


svn:r4506
 2005-06-29 21:46:55 +00:00
Nick Mathewson
0505b31933 Bump version to 0.1.1.1-alpha-cvs 
svn:r4505
 2005-06-29 21:46:17 +00:00
Roger Dingledine
6b21c8e74f make the local and private network masks explicit when we complain 
svn:r4501
 2005-06-29 19:15:23 +00:00
Roger Dingledine
caf7af26d7 whitespace fix 
svn:r4500
 2005-06-28 01:53:15 +00:00
Roger Dingledine
0ee665708a clean up some more comments 
svn:r4499
 2005-06-28 01:52:58 +00:00
Nick Mathewson
1647b6f837 Fix libc compilation 
svn:r4497
 2005-06-27 23:40:17 +00:00
Nick Mathewson
806da0d8b2 Compile on win32 
svn:r4496
 2005-06-27 23:35:04 +00:00
Nick Mathewson
30571317dd Fix unit tests that used old signature for add_fingerprint_to_dir 
svn:r4495
 2005-06-27 22:25:09 +00:00
Nick Mathewson
275966abe3 Bump CVS version to 0.1.1.1-alpha 
svn:r4493
 2005-06-27 18:35:10 +00:00
Roger Dingledine
da7d93e88a make the comment next to RunAsDaemon mention that it is a noop on win32 
svn:r4489
 2005-06-26 08:59:01 +00:00
Roger Dingledine
09e87f452d note a bug in our tor_socketpair implementation 
can somebody fix this or create a flyspray entry for it?


svn:r4483
 2005-06-26 05:03:21 +00:00
Nick Mathewson
b759fe4b8d It is not the end of the world when a router descriptor has an unrecognized kwd 
svn:r4480
 2005-06-24 23:42:15 +00:00
Roger Dingledine
00a7a37c94 we were printing the number of idle dns workers incorrectly. 
svn:r4477
 2005-06-23 07:57:43 +00:00
Roger Dingledine
9808fbd884 make the log message less scary when all the dirservers are 
temporarily unreachable


svn:r4476
 2005-06-22 21:59:11 +00:00
Nick Mathewson
3ff473b47b Appease the hungry god of GCC: it wants functions to be static or prototyped! 
svn:r4471
 2005-06-21 01:08:01 +00:00
Nick Mathewson
a37db0da26 Appease the hungry God of GCC: it hates K&R style unspecified args! 
svn:r4470
 2005-06-21 01:07:32 +00:00
Roger Dingledine
419d647353 more cleanups before i go wild 
svn:r4469
 2005-06-21 01:00:42 +00:00
Roger Dingledine
9c67ae34f1 overall cleanup and streamlining and doccing 
also fix a DoS avenue on dirservers


svn:r4468
 2005-06-20 23:04:13 +00:00
Nick Mathewson
2aff87caae Load hardware acceleration options when/where available. Can anybody test this? 
svn:r4467
 2005-06-20 18:56:35 +00:00
Nick Mathewson
5eef9177c5 Appease verbose GCC warnings. 
svn:r4466
 2005-06-20 09:38:29 +00:00
Nick Mathewson
eb327e7660 Add feature to handle unset (default) configuration options in GETCONF control messages 
svn:r4461
 2005-06-19 22:38:36 +00:00
Nick Mathewson
64fc1f7bae Implement all the rest of the new controller protocol, debug a little, add some new features, add ADDRMAP events. 
svn:r4460
 2005-06-19 20:40:41 +00:00
Roger Dingledine
b5fd75a063 forward-port the --hash-password bug, plus other nearby fixes 
svn:r4459
 2005-06-19 08:35:46 +00:00
Roger Dingledine
cc57e1cab1 fix stray funny-character 
svn:r4458
 2005-06-19 08:35:16 +00:00
Nick Mathewson
d38c696d5a The new protocol is implemented. Except for the pesky string unquoting business. And the cleanups. And the docs. And the testing. And the debugging. And the new features. Hm, I think it is time to sleep. 
svn:r4456
 2005-06-18 03:50:08 +00:00
Nick Mathewson
3f2339d1d3 Implement EXTENDCIRCUIT and ATTACHCIRCUIT. Only SETCONFIG and AUTHENTICATE remain. 
svn:r4455
 2005-06-18 03:09:43 +00:00
Nick Mathewson
c2f6fe9b85 Implement even more control functionality 
svn:r4454
 2005-06-18 02:39:25 +00:00
Roger Dingledine
8fdab20704 fix typo 
svn:r4453
 2005-06-18 02:23:11 +00:00
Nick Mathewson
5fee58adfb Add a tor_memmem function 
svn:r4452
 2005-06-18 02:17:11 +00:00
Nick Mathewson
9b4aa8d2ab Implement all the easy bits of the new control protocol 
svn:r4449
 2005-06-17 20:37:21 +00:00
Nick Mathewson
f9f09f1c5e Start implementing framework for revised control spec. 
svn:r4447
 2005-06-17 18:49:55 +00:00
Nick Mathewson
d4972bd2e1 Remove code that has been #if-0ed for a long time. 
svn:r4435
 2005-06-15 18:34:46 +00:00
Roger Dingledine
a3c66475f3 compile fix by agl, for code that is always commented out 
svn:r4427
 2005-06-13 17:33:12 +00:00
Nick Mathewson
2b8fd9ceda Allow a few EINVALs from libevent before dying. Warn on kqueue with libevent before 1.1a 
svn:r4419
 2005-06-13 00:35:19 +00:00
Roger Dingledine
2111c0e263 a bit more cleanup 
svn:r4417
 2005-06-12 04:33:26 +00:00
Roger Dingledine
91b1fb7ff7 some more cleaning and docing 
svn:r4415
 2005-06-11 21:17:38 +00:00
Nick Mathewson
beae4d0d32 whitespace fix 
svn:r4414
 2005-06-11 18:59:24 +00:00
Nick Mathewson
44107b6b13 fix typo in last patch 
svn:r4413
 2005-06-11 18:56:16 +00:00
Nick Mathewson
232861ba42 Docment or add DOCDOC comments to undocumented functions in src/or. Make function definition format uniform. 
svn:r4411
 2005-06-11 18:52:12 +00:00
Roger Dingledine
2587fa09f9 move more docs into our code 
svn:r4406
 2005-06-11 06:07:22 +00:00
Roger Dingledine
fcd0fc3364 flesh out the source file descriptions for doxygen 
svn:r4404
 2005-06-11 05:31:17 +00:00
Roger Dingledine
b349e60543 don't tell people you're publishing the server descriptor if you're 
actually not.


svn:r4387
 2005-06-09 21:23:54 +00:00
Nick Mathewson
0831823763 Change end-of-file NLNL convention. It turns out arma I and I agree. 
svn:r4382
 2005-06-09 19:03:31 +00:00
Nick Mathewson
a6f51001a5 New whitespace normalization rule: no blank line at EOF. 
svn:r4378
 2005-06-09 16:46:51 +00:00
Roger Dingledine
5bca8e8b4d forward-port: 
## If certain IPs and ports are blocked externally, e.g. by your firewall,
## you should update your exit policy to reflect this -- otherwise Tor
## users will be told that those destinations are down.


svn:r4376
 2005-06-09 10:42:25 +00:00
Roger Dingledine
15f937c95e when a dirserver gets a mismatched fingerprint, log the expected 
fp and the received fp


svn:r4372
 2005-06-09 10:21:55 +00:00
Roger Dingledine
cfc89f8753 pay more attention to the ClientOnly config option 
svn:r4367
 2005-06-09 08:54:42 +00:00
Roger Dingledine
d922fa7b10 fix another underflow in keeping stats 
these size_ts are subtle buggers


svn:r4364
 2005-06-09 03:57:54 +00:00
Nick Mathewson
87caad5445 Fix an underflow in buffer use conting. 
svn:r4360
 2005-06-08 21:55:02 +00:00
Roger Dingledine
43709a9c3d clean up the log warn a bit 
svn:r4357
 2005-06-08 20:45:29 +00:00
Nick Mathewson
c45845204a Fix warning about unused function when compiling with ancient libevent 
svn:r4355
 2005-06-08 20:35:28 +00:00
Roger Dingledine
44e85544e4 absolutely refuse to let people pick internal IP addresses if 
they're using the default dirservers.

we're getting a big pile of a dozen or so servers that have picked
private IP addresses despite the warning (presumably they don't even
know they have logs)


svn:r4354
 2005-06-08 20:32:22 +00:00
Nick Mathewson
b0538591c7 Reset buf->highwater every time buf_shrink is called, not just on suffessful shrink. 
svn:r4353
 2005-06-08 20:17:32 +00:00
Roger Dingledine
9ed7b53143 don't upload your descriptor if rebuilding it failed 
svn:r4352
 2005-06-08 19:45:17 +00:00
Nick Mathewson
8b2a7ff9fe Remove extraneous newlines from libevent log messages. Backport candidate? 
svn:r4350
 2005-06-08 17:41:32 +00:00
Roger Dingledine
4c43789435 Some play code to throw away old buffers sometimes rather 
than constantly reallocing them; just in case this is our memory
problem. It looks for now like it isn't, so disabled.


svn:r4349
 2005-06-08 17:27:11 +00:00
Roger Dingledine
eeb6d6dba6 dump periodic memory usage stats 
svn:r4348
 2005-06-08 17:24:58 +00:00
Nick Mathewson
be1c81a767 Fix syntax error. 
svn:r4346
 2005-06-08 16:26:44 +00:00
Nick Mathewson
ec07e1195f add patch for 143 and code to check for known-bad/slow libevent versions. Needs more testing. 
svn:r4344
 2005-06-08 13:53:19 +00:00
Roger Dingledine
aff308e6d9 reenable the part of the code that tries to flush as soon as an OR outbuf 
has a full tls record available. perhaps this will make OR outbufs not grow
as huge except in rare cases, thus saving lots of cpu time plus memory.


svn:r4343
 2005-06-08 04:55:06 +00:00
Roger Dingledine
1a5c5452b4 when you send a USR2 signal, the log message now tells you to send 
a HUP signal if you want to change back to old log levels.


svn:r4332
 2005-06-07 18:16:14 +00:00
Nick Mathewson
621ab95e59 Fix for 152: reject malformed .onion addresses rather then passing them on 
svn:r4329
 2005-06-07 18:01:46 +00:00
Nick Mathewson
2118e5798a Use correct errno from libevent on win32 
svn:r4327
 2005-06-07 17:32:33 +00:00
Nick Mathewson
1d9bc936c2 Adapt patch from Adam Langley: fix possible memory leak in tor_lookup_hostname 
svn:r4326
 2005-06-07 13:45:58 +00:00
Roger Dingledine
51b5b808cb bump cvs to 0.1.1.0-alpha-cvs 
svn:r4323
 2005-06-06 20:27:36 +00:00
Nick Mathewson
e1c8aa8035 Fix win32 compilation: backport candidate 
svn:r4320
 2005-06-06 20:06:10 +00:00
Nick Mathewson
fc40f974c2 When RNG seeding fails, die. Backport candidate 
svn:r4319
 2005-06-06 20:02:33 +00:00
Nick Mathewson
5420aed38e Possible bugfix for 151: backport candidate. 
svn:r4318
 2005-06-06 20:02:09 +00:00
Nick Mathewson
baa10cbbfa Instrument buffers.c and rephist.c memory usage 
svn:r4317
 2005-06-06 17:03:21 +00:00
Roger Dingledine
7c8d5c3178 correct some instructions in the sample torrc 
svn:r4314
 2005-06-06 15:57:53 +00:00
Nick Mathewson
9f24078452 Fix buffer overlow when checking hashed passwords 
svn:r4308
 2005-06-05 14:28:47 +00:00
Nick Mathewson
3c58cdf280 Add unit test for openpgp s2k 
svn:r4306
 2005-06-04 13:43:03 +00:00
Roger Dingledine
4855990d37 clean up a few more log entries 
svn:r4304
 2005-05-27 17:43:43 +00:00
Roger Dingledine
bfc7838b97 downgrade the 'caught sigpipe' notice. 
we're going to pretend like all of these are fine.


svn:r4301
 2005-05-25 02:20:15 +00:00
Roger Dingledine
4f0d7b82ae make lucky's weird libevent poll einprogress bug just warn, not kill tor. 
svn:r4300
 2005-05-24 22:58:57 +00:00
Nick Mathewson
d2cdae221d Fix not-freed-on-exit event 
svn:r4298
 2005-05-24 17:13:15 +00:00
Roger Dingledine
5005f682ae Bugfix: we were checking to see if you want to send a keepalive, based 
on five minutes since last successful write. But if you have bytes queued
already, and they're not getting through, we were adding a new keepalive
every second. This was bad.


svn:r4296
 2005-05-23 22:20:54 +00:00
Roger Dingledine
6cfce54ab0 bump to 0.1.0.8-rc 
svn:r4286
 2005-05-23 05:47:21 +00:00
Roger Dingledine
040a748d87 i screwed up the dirport reachability testing when we don't yet 
have a cached version of the directory. hopefully now fixed.


svn:r4284
 2005-05-23 05:20:52 +00:00
Nick Mathewson
751db63a17 Always disable kqueue on OSX. It seems linked to kernel panics 
svn:r4282
 2005-05-23 04:28:58 +00:00
Roger Dingledine
78f26e8806 test out commit mails again 
svn:r4281
 2005-05-23 03:39:53 +00:00
Roger Dingledine
ee553a9c72 put a tor version at the top of the torrc.sample file 
svn:r4280
 2005-05-23 03:38:32 +00:00
Nick Mathewson
11a64692c3 Make hashed controller password encoding use hex not base64; this makes it possible to write a controller without base64 
svn:r4279
 2005-05-23 02:31:53 +00:00
Roger Dingledine
b86716b839 If a socks connection ends because read fails, don't warn that you're 
not sending a socks reply back. (bug reported by Warren Barrow)


svn:r4277
 2005-05-21 00:15:23 +00:00
Roger Dingledine
d22c141659 we were leaking 616 bytes every time somebody established us as 
an intro point for their hidden service.


svn:r4276
 2005-05-20 22:14:33 +00:00
Roger Dingledine
c95677725a a note for nick about other memory not freed at exit 
svn:r4275
 2005-05-20 22:11:46 +00:00
Roger Dingledine
f0e309e5bd add HttpProxyAuthenticator config option too 
svn:r4272
 2005-05-20 08:51:45 +00:00
Roger Dingledine
208dc969b3 bump to 0.1.0.7-rc-cvs 
svn:r4267
 2005-05-18 04:01:57 +00:00
Roger Dingledine
0fa1890e0e fix the assumption that uninitialized variables are 0 
clean up router_load_single_router() more


svn:r4266
 2005-05-18 03:52:07 +00:00
Roger Dingledine
fe78aac027 fix seg faults when router_load_single_router fails 
svn:r4265
 2005-05-18 03:42:46 +00:00
Nick Mathewson
e7354725bb Handle relay cells with rh.length too large. 
svn:r4264
 2005-05-17 20:00:24 +00:00
Roger Dingledine
9abef5e483 allow the middle hop of the testing circuit to be running 
any version, now that most of them have the bugfix to let
them connect to unknown servers.


svn:r4263
 2005-05-17 19:46:43 +00:00
Roger Dingledine
b7d6b8a397 doxygeny goodness from tyranix 
svn:r4262
 2005-05-17 17:01:36 +00:00
Roger Dingledine
ebee138d75 bump to 0.1.0.7-rc 
svn:r4255
 2005-05-17 04:42:48 +00:00
Roger Dingledine
ec1331d49e fix a comment that tyranix noticed 
svn:r4239
 2005-05-17 01:55:53 +00:00
Roger Dingledine
2812d4a08c free some memory that is still reachable on exit 
svn:r4234
 2005-05-16 10:32:10 +00:00
Nick Mathewson
530da0e772 Normalize whitespace 
svn:r4233
 2005-05-16 01:04:28 +00:00
Roger Dingledine
14b9615d7d bump cvs to 0.1.0.6-rc-cvs 
svn:r4231
 2005-05-15 13:26:08 +00:00
Roger Dingledine
28195a0eb1 clean up some log entries 
svn:r4228
 2005-05-15 05:00:24 +00:00
Roger Dingledine
b7a88ebd15 fix url in comment in torrc 
svn:r4225
 2005-05-15 03:00:00 +00:00
Nick Mathewson
9bc6e3aa6c Add an explanatory comment 
svn:r4222
 2005-05-15 02:05:45 +00:00
Roger Dingledine
7eb559fada bump to 0.1.0.6-rc 
svn:r4217
 2005-05-15 01:00:45 +00:00
Nick Mathewson
c7bc2f9eae Add ENABLE_THREADS macro to windows orconfig.h 
svn:r4212
 2005-05-15 00:17:59 +00:00
Roger Dingledine
3c9ec416f6 fix a case error in suppressing a bogus libevent warning. 
nick, was this lower-case for a reason? have both cases
appeared? or was this just a typo.


svn:r4206
 2005-05-14 05:14:36 +00:00
Roger Dingledine
07230a698c if router_resolve fails on the descriptor the controller 
gives us, we shouldn't leave the routerinfo in the list.


svn:r4205
 2005-05-14 05:01:41 +00:00
Roger Dingledine
b92a77b1d2 move the periodic buffer shrinking interval from 3 mins to 1 min 
svn:r4204
 2005-05-14 01:11:45 +00:00
Nick Mathewson
00f2a09380 Append default exit policy before checking for implicit internal addresses: fix bug 129. 
svn:r4201
 2005-05-14 00:13:17 +00:00
Nick Mathewson
776b411dc9 Fix a segfault 
svn:r4191
 2005-05-11 04:14:17 +00:00
Nick Mathewson
3893b3c7ac Patch for task 133 
svn:r4189
 2005-05-10 22:33:45 +00:00
Nick Mathewson
d0c0d6c86a Apply patch from Geoff for bug 132. Clean it up a little to fix a memory leak and to avoid unnecessary parse/unparse code. 
svn:r4188
 2005-05-10 22:12:48 +00:00
Nick Mathewson
ea5591ee4d Implement --disable-threads 
svn:r4187
 2005-05-10 20:02:52 +00:00
Nick Mathewson
13126eeb0f Patch from goodell for task 131: Do not die on internal address if we are not publishing. 
svn:r4186
 2005-05-09 04:31:00 +00:00
Nick Mathewson
10b2208d93 Make Tor compile with no warnings with gcc4.0 on OSX 
svn:r4184
 2005-05-07 05:55:06 +00:00
Nick Mathewson
6567ec9ccf Functions work better when you call them. Resolve a bug which would prevent unreachable dirports from getting suppressed. 
svn:r4183
 2005-05-07 05:17:36 +00:00
Nick Mathewson
bc51c8b074 Implement --verify-config command-line option to fix bug 69. 
svn:r4182
 2005-05-07 04:49:09 +00:00
Roger Dingledine
cee7c5988c fix massive memory leak 
(50 megabytes over a couple of days, on the dirservers)


svn:r4181
 2005-05-06 08:53:23 +00:00
Roger Dingledine
cc0b19888d log buffer sizes on kill -usr1 too. 
svn:r4180
 2005-05-06 08:32:37 +00:00
Roger Dingledine
1f263bf6f5 whine at you if you're a server and you don't set your contactinfo 
svn:r4178
 2005-05-04 20:45:38 +00:00
Roger Dingledine
68ba303323 fix compile error if you're not multithreaded 
svn:r4177
 2005-05-03 18:44:20 +00:00
Roger Dingledine
6ea839265d remove archaic debugging aid that was probably unsafe 
svn:r4176
 2005-05-03 10:17:38 +00:00
Roger Dingledine
87850c47b0 cleanup now that 0.0.9pre1 is obsolete 
svn:r4175
 2005-05-03 10:12:08 +00:00
Roger Dingledine
5265bbd2b8 first iteration of scrubbing sensitive strings from logs. 
also generally clean up log messages.


svn:r4174
 2005-05-03 10:04:08 +00:00
Nick Mathewson
b35f7dacef Call tor_free_all instead of connections_free_all after forking 
svn:r4173
 2005-05-03 03:51:20 +00:00
Nick Mathewson
8b9ae25224 Change some >=s to >s in buf_resize, so that we do not denormalize buffers on resize. 
svn:r4172
 2005-05-03 03:25:04 +00:00
Nick Mathewson
4666b801fa If DataDir is ~/.tor, and that expands to /.tor, then default to LOCALSTATEDIR/tor instead. 
svn:r4170
 2005-05-03 00:36:57 +00:00
Nick Mathewson
14bac4dad4 Elaborate on buf_shrink comment. 
svn:r4169
 2005-05-02 23:41:39 +00:00
Roger Dingledine
aa6bcd50ca comment buf_shrink 
svn:r4168
 2005-05-02 23:39:09 +00:00
Nick Mathewson
ad547cbb8c Correct and simplify buf_shrink logic 
svn:r4167
 2005-05-02 23:36:13 +00:00
Nick Mathewson
d6a6c8785b When removing all bytes from a buffer, reset buf->cur=buf->mem 
svn:r4166
 2005-05-02 23:32:23 +00:00
Nick Mathewson
a312ce1d3b Change buffer shrinking strategy: only try to shrink once every 3 minutes. Do not try to read over buffer size unless buffer is nearly empty. 
svn:r4165
 2005-05-02 23:17:08 +00:00
Nick Mathewson
9c683c7613 Make buffer shrinking algorithm a little smarter. 
svn:r4164
 2005-05-02 22:49:24 +00:00
Nick Mathewson
830ac87611 Actually, dont send CREATE_FAST cells at all for now 
svn:r4163
 2005-05-02 22:39:59 +00:00
Nick Mathewson
ab34901263 New and frightening code to implement fast-path first-hop CREATE_FAST cells. Watch out when we bump the version to 0.1.0.6-rc! 
svn:r4162
 2005-05-02 22:35:18 +00:00
Roger Dingledine
978648bff8 also print the platform string for rejected descriptors 
svn:r4160
 2005-05-02 22:06:04 +00:00
Roger Dingledine
15c1853bd6 don't print nulls 
svn:r4159
 2005-05-02 21:54:16 +00:00
Roger Dingledine
50505e677e fix a comment 
svn:r4157
 2005-05-02 21:49:04 +00:00
Roger Dingledine
c9e83eb1b4 when we refuse a router descriptor, log contactinfo and source address. 
svn:r4156
 2005-05-02 21:48:54 +00:00
Roger Dingledine
57b7427c2d reformat routerparse a bit 
svn:r4155
 2005-05-02 21:48:25 +00:00
Nick Mathewson
69dc4e1675 Remove support for looking at old directory/routerdesc elements; mark non-new elements optional; switch to new format for dir-signing-key; start accepting newer elements so we can mark them as non-opt later; make tor-spec say the right stuff. 
svn:r4154
 2005-05-02 21:22:31 +00:00
Roger Dingledine
729e720095 workaround for user error: some people were putting "Address " in their 
torrc, and they had a buggy resolver that resolved " " to 0.0.0.0. Oops.


svn:r4150
 2005-04-29 18:52:05 +00:00
Roger Dingledine
3d2fbeb979 bump to 0.1.0.5-rc-cvs 
svn:r4149
 2005-04-28 16:11:48 +00:00
Nick Mathewson
fe65e57ca1 Re-do fragmented control message handling to work with new buf_t system. 
svn:r4144
 2005-04-27 22:01:34 +00:00
Nick Mathewson
d0a9a8bdd3 Appease VC7. It has a strangely puritanical attitude about what programmers are allowed to do a consenting void*. 
svn:r4140
 2005-04-27 20:02:52 +00:00
Nick Mathewson
53607d3bb3 Turn SENTINELS back on; give NOINLINE a name and turn it off. 
svn:r4139
 2005-04-27 19:40:31 +00:00
Roger Dingledine
42d57317cd bump to 0.1.0.5-rc 
svn:r4138
 2005-04-27 19:30:32 +00:00
Roger Dingledine
4c4a14e3cb turn off the mongo debugging stuff, for performance tests 
svn:r4137
 2005-04-27 17:21:42 +00:00
Roger Dingledine
543d31c89a bump the default bandwidthrate from 1mb to 2mb 
svn:r4131
 2005-04-27 04:13:59 +00:00
Nick Mathewson
52376dc9e8 Rename buf->start to buf->cur; fix bug in read_to_buf; still debug with paranoia. 
svn:r4130
 2005-04-27 02:55:21 +00:00
Nick Mathewson
746768df5d Add even more debugging code; temporarily disable inlines in buffers.c 
svn:r4129
 2005-04-27 00:53:44 +00:00
Roger Dingledine
914ee87e07 stop re-reading and re-parsing the directory as soon as we make it. 
it was nice for checking if we've got bugs, but it's really quite
expensive too. it was also nice for updating our routerinfo's
immediately, but we'll update them like everybody else when we fetch
a new dir from somebody else.


svn:r4128
 2005-04-27 00:48:05 +00:00
Roger Dingledine
adaf3d31e6 hidden service client connections were using some of their 
60 seconds fetching the hidserv descriptor, which made them
more likely to fail on the first attempt, yet they work fine
on the second. so now give them extra time for the first try.


svn:r4127
 2005-04-26 22:36:00 +00:00
Roger Dingledine
2a7aec0ffd fix function prototype, fix typo 
svn:r4126
 2005-04-26 21:29:20 +00:00
Nick Mathewson
ecc76d8245 Avoid overflow on wrapping a TLS read. 
svn:r4125
 2005-04-26 21:20:22 +00:00
Nick Mathewson
e6794e5808 Fix unit tests for buffers. 
svn:r4124
 2005-04-26 21:10:31 +00:00
Roger Dingledine
15c7c73c5e bump to 0.1.0.4-rc-cvs while we're testing 
svn:r4123
 2005-04-26 20:59:36 +00:00
Nick Mathewson
9ba2dd7ea1 Clean/renormalize whitespace 
svn:r4122
 2005-04-26 20:55:32 +00:00
Nick Mathewson
ef2409e4ed Change the implementation of buf_t a lot: make it a ring buffer to minimize memmove on flush. This may break the universe, but it is probably Necessary For Perfomance. 
svn:r4121
 2005-04-26 20:53:22 +00:00
Roger Dingledine
4eb3cf9330 a bit more debug info 
svn:r4119
 2005-04-26 20:05:15 +00:00
Roger Dingledine
953cf91ecd add more debugging info to help us find the weird dns freebsd pthreads bug. 
svn:r4117
 2005-04-26 19:08:06 +00:00
Roger Dingledine
509405a5f7 clean up this TOR_FRAGILE business 
svn:r4116
 2005-04-26 18:52:16 +00:00
Roger Dingledine
5e86e87124 Add basic HttpsProxyAuthenticator support, based on patch 
from Adam Langley.


svn:r4115
 2005-04-26 18:33:33 +00:00
Roger Dingledine
4fafa81f32 help debug: when we close a conn due to timeout, tell us its 
file descriptor, not its connectionarray index.


svn:r4113
 2005-04-25 17:24:16 +00:00
Roger Dingledine
662cfc976d only call the connection open once we've decided we like the cert. 
svn:r4112
 2005-04-25 17:23:52 +00:00
Roger Dingledine
f3ea883ccd bugfix: stop trying to print a null pointer if an OR conn fails 
because we didn't like its cert.


svn:r4111
 2005-04-25 15:43:37 +00:00
Roger Dingledine
12ea3a26b2 bugfix: make a debug log stop lying 
svn:r4110
 2005-04-25 15:43:05 +00:00
Roger Dingledine
92b970d2a6 only complain about wedged cpuworkers after an hour, not 100 secs 
svn:r4100
 2005-04-23 20:58:44 +00:00
Nick Mathewson
4fb95f166e Apparently, ASN1 failures are not treated as SSL connection errors, but are just general OpenSSL errors. Or something. Anyway, bulletproof tor_tls_handshake. 
svn:r4098
 2005-04-23 20:35:38 +00:00
Roger Dingledine
6128cdead0 let NumCpus be singular without whining 
svn:r4097
 2005-04-23 19:29:09 +00:00
Roger Dingledine
df18661a28 bump experimental version to 0.1.0.4-rc 
svn:r4096
 2005-04-23 18:31:25 +00:00
Roger Dingledine
cc620c2afb bump to 0.1.0.3-rc-cvs 
svn:r4088
 2005-04-23 16:13:56 +00:00
Roger Dingledine
54fd9df23f LOG_ERR is for when you're planning to die. 
svn:r4087
 2005-04-23 14:35:13 +00:00
Nick Mathewson
5827e2e216 Fix "JAP-client" hideous ASN1 bug, twice. (Fix1: check more thoroughly for TLS errors when handling certs. Fix2: stop assert(0)ing on uncaught TLS errors.) 
svn:r4085
 2005-04-23 14:26:02 +00:00
Roger Dingledine
ad4eca60ec add geoff's NoPublish patch 
svn:r4084
 2005-04-21 10:40:48 +00:00
Nick Mathewson
ce9995a579 Replace an infinite-stack-recursion bug with a generate-infinite-debug-messages bug. Maybe it isnt such a good idea to send LOG_DEBUG messages to the controller after all? 
svn:r4082
 2005-04-17 22:52:02 +00:00
Nick Mathewson
cf84759b4b zero-out errno before calling event_dispatch, just in case we have misdiagnosed poll(2)/EINVAL bug. 
svn:r4081
 2005-04-17 22:38:39 +00:00
Roger Dingledine
769541ff7e be willing to load balance over up to 2mB, not 1mB, of advertised capacity 
svn:r4080
 2005-04-12 22:09:47 +00:00
Roger Dingledine
bf79b5266f those should be notices, not warns 
svn:r4079
 2005-04-12 22:09:04 +00:00
Nick Mathewson
f1dfa30064 Fix postdescriptor behavior: on non-complete success, only say "done" once. 
svn:r4073
 2005-04-11 02:52:09 +00:00
Roger Dingledine
79ce1a42a5 bump to 0.1.0.3-rc 
svn:r4064
 2005-04-08 06:27:51 +00:00
Roger Dingledine
e2cdc87485 remove some redundant code 
svn:r4062
 2005-04-08 06:16:09 +00:00
Nick Mathewson
656e31ba33 If it has not been 100 seconds since we told the cpuworker about an onion, complain! Oh, wait... 
svn:r4059
 2005-04-08 04:59:34 +00:00
Nick Mathewson
f3b833cb47 Make libevent_logging_callback static. 
svn:r4058
 2005-04-08 03:47:18 +00:00
Nick Mathewson
74dc7eedc5 Add kludgy function to force controllers to flush EVENT_ERR_MSG events. 
svn:r4057
 2005-04-08 03:36:39 +00:00
Nick Mathewson
31c12e265f Move a quote, fix a log. 
svn:r4056
 2005-04-08 03:26:44 +00:00
Nick Mathewson
c6769a80fb Fixs a signed/unsigned comparison 
svn:r4055
 2005-04-08 03:26:23 +00:00
Nick Mathewson
6face4f482 Add missing "char" 
svn:r4054
 2005-04-08 03:07:07 +00:00
Roger Dingledine
97637549bb tie MAX_DIR_SIZE to MAX_BUF_SIZE 
resolve bug 80


svn:r4052
 2005-04-07 22:13:17 +00:00
Roger Dingledine
dabafddb82 fix format bug 
svn:r4051
 2005-04-07 22:03:56 +00:00
Roger Dingledine
ec3650f00f only whine about clock skew from the dirserver if he's a trusted 
dirserver.


svn:r4048
 2005-04-07 21:09:19 +00:00
Nick Mathewson
8cc3307e0d Improve conn_*_to_string; add circuit_state_to_string; make skewed-descriptor messages better. 
svn:r4047
 2005-04-07 21:07:19 +00:00
Roger Dingledine
dd98412ce1 allow servers to publish descriptors from 12 hours in the future. 
hopefully this will allow more slack and let crummier servers help
out too.


svn:r4046
 2005-04-07 21:01:00 +00:00
Nick Mathewson
b897cb1ec3 Change conn_(type|state)_to_string from const arrays to switch functions so we (I) will not make Tor crash the next time we (I) add a new state. 
svn:r4045
 2005-04-07 20:25:22 +00:00
Roger Dingledine
6bdfd97272 add function comment 
svn:r4043
 2005-04-07 20:07:34 +00:00
Roger Dingledine
ab8a0bb52c We have a bug that I can't find. Sometimes, very rarely, cpuworkers get 
stuck in the 'busy' state, even though the cpuworker process thinks of
itself as idle. I don't know why. But here's a workaround to kill any
cpuworker that's been busy for more than 100 seconds.


svn:r4042
 2005-04-07 20:02:00 +00:00
Nick Mathewson
c92a2620d4 Try RB_TREE instead of SPLAY_TREE, but with a single-entry caching optimization. 
svn:r4041
 2005-04-07 05:09:19 +00:00
Nick Mathewson
a035b8e3c3 Make compare_orconn_circid_entries marginally faster and inlined, if that helps 
svn:r4040
 2005-04-07 04:50:25 +00:00
Roger Dingledine
8aa0df56f6 Stop putting nodename in the Platform string of server descriptors. 
It doesn't actually help, and it is confusing/upsetting some people.


svn:r4037
 2005-04-06 21:11:05 +00:00
Nick Mathewson
7709547c08 When we connect and finish TLS negotiation with address:port, it is obvious that any other key or nickname we might know about (as an authdirserver) does not actually exist at address:port. 
svn:r4036
 2005-04-06 21:09:47 +00:00
Roger Dingledine
03720b39fd stop wasting time doing a case insensitive comparison for every dns name 
every time we do any lookup. canonicalize the names to lowercase and be
done with it.


svn:r4035
 2005-04-06 20:25:21 +00:00
Roger Dingledine
46089c49c4 blow away most calls to assert_all_pending_dns_resolves_ok, since 
they're eating our cpu.


svn:r4034
 2005-04-06 20:05:34 +00:00
Roger Dingledine
652dde72f1 bugfix: chdir to your datadirectory at the *end* of the 
daemonize process, not the beginning. this was a problem
because the first time you run tor, if your datadir isn't
there, and you have runasdaemon set to 1, it will try to
chdir to it before it tries to create it. oops.


svn:r4033
 2005-04-06 19:07:38 +00:00
Roger Dingledine
8596947ee2 quiet another instance where we whine to an innocent OR operator's 
logs when some other server switches keys unexpectedly.


svn:r4032
 2005-04-06 18:55:14 +00:00
Roger Dingledine
620419b421 oh, and accept() into the right place, too. 
svn:r4029
 2005-04-06 16:16:31 +00:00
Roger Dingledine
70f3b3ef86 Forward-port the checking of 
sin_addr.s_addr == 0 || sin->sin_port == 0.
This just happened on moria2, so I guess it happens rarely
on Linux as well as OS X.
We can't afford to accept OR conns from 0.0.0.0:0, since we
send created cells back to the first addr:port that matches,
and we'd better not send them to the wrong place.
So, let's drop them all for now, and see if we can find a pattern
later.


svn:r4028
 2005-04-06 15:42:35 +00:00
Roger Dingledine
9cbaf4603d fix an assert trigger: when we have the rare case of accepting 
a conn on 0.0.0.0:0, then when we look through the connection array,
we'll find any of the workers. this is no good.


svn:r4027
 2005-04-06 15:19:32 +00:00
Nick Mathewson
88dc243bb5 Rename circuit_get_by_stream to circuit_get_by_edge_conn, and actually start using it. Watch out, kids! 
svn:r4026
 2005-04-06 06:43:21 +00:00
Roger Dingledine
716d9bc99a when using preferred entry or exit nodes, ignore whether 
the circuit wants uptime or capacity. they asked for the
nodes, they get the nodes.


svn:r4025
 2005-04-06 06:17:35 +00:00
Nick Mathewson
4453e3794a Add a pointer from edge connections to their corresponding circuit (ulp!); add some debugging sanity-checking for cirid_orconn_map stuff 
svn:r4024
 2005-04-06 06:13:49 +00:00
Nick Mathewson
2a0b1025e5 Fix bug in last commit when no circid can be found 
svn:r4023
 2005-04-06 05:45:07 +00:00
Nick Mathewson
b34d9adb59 Fix format warning 
svn:r4022
 2005-04-06 05:44:05 +00:00
Roger Dingledine
94cecc712d note some features we intend to add. 
svn:r4021
 2005-04-06 05:35:06 +00:00
Nick Mathewson
b7cdcf3462 Hopefully, this will make ORs much faster, and not break them: keep a big splay tree of (circid,orconn)->circuit mappings to make circuit_get_by_circid_conn much faster. 
svn:r4020
 2005-04-06 05:33:32 +00:00
Roger Dingledine
712d05c19a a bit more data on gene's dns threading bug 
svn:r4019
 2005-04-06 05:32:24 +00:00
Roger Dingledine
5f0a84cbe2 update conn-type-state-strings to handle https states for ORs 
svn:r4018
 2005-04-06 04:55:17 +00:00
Nick Mathewson
3014b03b67 Add missing comma. Oops 
svn:r4017
 2005-04-06 03:20:06 +00:00
Nick Mathewson
88fe4d6292 Handle changed router status correctly when reloading fingerprint file 
svn:r4016
 2005-04-06 01:09:26 +00:00
Nick Mathewson
1b5e2182fa Log msg spelling fix 
svn:r4015
 2005-04-06 00:53:13 +00:00
Roger Dingledine
f860b490be When we're connecting to an OR and he's got a different nickname/key 
than we were expecting, only complain loudly if we're an OP or an
authdirserver. Complaining loudly to OR admins just confuses people.


svn:r4014
 2005-04-06 00:50:40 +00:00
Nick Mathewson
ac268a8340 Fix Tor for no-threading compilation: move connection_unregister from _connection_free to connection_free. 
svn:r4013
 2005-04-06 00:46:57 +00:00
Nick Mathewson
374edd356e Change replacement semantics for directory entries: fix bug 121. 
svn:r4012
 2005-04-06 00:01:35 +00:00
Nick Mathewson
4991290935 Revise control spec and implementation to allow all log messages to be sent to controller with their severities intact. 
svn:r4010
 2005-04-05 22:56:17 +00:00
Nick Mathewson
46be0fa999 Make last fix work on windows too. 
svn:r4009
 2005-04-04 21:53:26 +00:00
Nick Mathewson
0fff263a46 Fix possible bug on threading platforms with running out of fds do to cpuworkers and dnsworkers. 
svn:r4008
 2005-04-04 21:46:08 +00:00
Roger Dingledine
533a3bbe2e don't point to the 0.0.9.x manual only 
svn:r4007
 2005-04-04 18:57:16 +00:00
Roger Dingledine
88c9e3959a put a note in the torrc about abuse potential with the default 
exit policy.


svn:r4006
 2005-04-04 18:56:15 +00:00
Roger Dingledine
f1edeebf7d client now retries when streams end early for 'hibernating' or 
'resource limit' reasons; refactor.


svn:r4004
 2005-04-04 03:30:49 +00:00
Roger Dingledine
823b7d4d8b automatically approve nodes running 0.1.0.2-rc or later 
svn:r4001
 2005-04-03 19:01:47 +00:00
Nick Mathewson
7bf443e985 I hear the smart kinds compile before committing. Then they never miss parens 
svn:r3999
 2005-04-03 06:00:00 +00:00
Nick Mathewson
f696fd98bf Make smartlist_string_remove consistent with smartlist_string 
svn:r3998
 2005-04-03 05:58:23 +00:00
Nick Mathewson
1aedf3daf5 Only warn once per nickname from add_nickname_list_to_smartlist per failure. 
svn:r3997
 2005-04-03 05:53:34 +00:00
Nick Mathewson
ff545c3103 Add useful smartlist_string_remove function. 
svn:r3996
 2005-04-03 05:52:32 +00:00
Nick Mathewson
11d20d78a0 Adjust maximum skew and age for rendezvous descriptors: adjust code to make skew add to age. 
svn:r3995
 2005-04-03 05:36:23 +00:00
Roger Dingledine
658463a751 clean up the circuit-mark-for-close patch 
svn:r3994
 2005-04-03 05:31:41 +00:00
Roger Dingledine
096879687a start sending 'truncated' cells back rather than destroy cells, 
if the circuit closes in front of you.


svn:r3993
 2005-04-03 05:25:26 +00:00
Nick Mathewson
0dc02328af Move most of *_mark_for_close out of macros. 
svn:r3992
 2005-04-03 05:22:33 +00:00
Nick Mathewson
2a332bf0b8 Fix unterminated comment 
svn:r3991
 2005-04-03 05:21:16 +00:00
Nick Mathewson
055ee7c323 Give better warnings if connection_close_unattached_ap gets called twice or called on a marked connection; rename it to connection_mark_unattached_ap. 
svn:r3990
 2005-04-02 22:11:24 +00:00
Nick Mathewson
4a90d37229 Better messages when POSTDESCRIPTOR fails 
svn:r3989
 2005-04-02 22:02:13 +00:00
Roger Dingledine
13e211de17 We're printing the host mask wrong in exit policies in server descriptors. 
I believe this isn't a critical bug tho, since we're still obeying the
exit policy internally.


svn:r3987
 2005-04-02 08:55:31 +00:00
Roger Dingledine
8dbdbfb831 improved log error message 
svn:r3986
 2005-04-02 08:30:40 +00:00
Roger Dingledine
bd82ac06a8 bump to 0.1.0.2-rc-cvs 
svn:r3983
 2005-04-01 20:30:09 +00:00
Nick Mathewson
0e81265359 update copyright notices. 
svn:r3982
 2005-04-01 20:15:56 +00:00
Nick Mathewson
36631d6401 Fix a couple of win32-related build issues when using latest libevent. 
svn:r3978
 2005-04-01 16:48:22 +00:00
Nick Mathewson
0d6c9c47b3 Short-term fix: prevent possible segfault in connection_close_unattached_ap 
svn:r3970
 2005-04-01 16:04:45 +00:00
Roger Dingledine
5de85f54ba bump version to 0.1.0.2-rc 
svn:r3969
 2005-04-01 14:13:31 +00:00
Roger Dingledine
453a822425 when you decide you're reachable, actually publish your descriptor 
right then.


svn:r3968
 2005-04-01 09:28:14 +00:00
Roger Dingledine
1ff62dbd18 require exactly 0.0.9.7 for middle hops of testing circs, for now 
svn:r3967
 2005-04-01 09:23:51 +00:00
Roger Dingledine
e786e5dedb when building testing circuits, always use middle hops 
running at least 0.0.9.7


svn:r3966
 2005-04-01 08:42:26 +00:00
Roger Dingledine
a28ae7a70c fix assert: if our dirport isn't reachable yet, don't trick 
*ourselves* into thinking the dirport is zero. but continue
to tell other people that it is.


svn:r3952
 2005-04-01 07:42:32 +00:00
Roger Dingledine
cd25e56ad2 when the or-connect succeeded and the tls handshake succeeded 
but we didn't like the result, we were closing the connection
without sending any destroys back for the pending circuits. now
send those destroys anyway; i hope this doesn't break too much.


svn:r3951
 2005-04-01 07:25:18 +00:00
Nick Mathewson
73f6c1531e fix typo in earlier libevent mmessage suppress patch 
svn:r3950
 2005-04-01 07:16:52 +00:00
Roger Dingledine
003d9df6b0 authdirservers shouldn't do orport reachability detection, 
since they're in clique mode, so it will be rare to find a
server not already connected to them.


svn:r3949
 2005-04-01 07:09:18 +00:00
Nick Mathewson
410ecfcc71 Add code to suppress spurious libevent log msgs; use it to resolve bug 68. 
svn:r3948
 2005-04-01 07:05:21 +00:00
Nick Mathewson
bc668233ad Improve error msgs in tor-resolve.c; resolve bug 112 
svn:r3947
 2005-04-01 07:04:40 +00:00
Roger Dingledine
2ff2db8d2a fix some log spacing problems 
svn:r3942
 2005-04-01 06:23:21 +00:00
Nick Mathewson
efe9ca659a Use recent libevent features when possible 
svn:r3940
 2005-04-01 02:37:40 +00:00
Nick Mathewson
837d7dff69 Try to make crash-on-shutdown bug harder to trigger. 
svn:r3939
 2005-04-01 02:37:10 +00:00
Nick Mathewson
e04a82ecaf Patch: when extending to an unknown router, compare identity to expected identity; not nickname-to-expected identity. 
svn:r3937
 2005-03-31 23:30:13 +00:00
Roger Dingledine
801d5ef1de spell recommended correctly 
svn:r3936
 2005-03-31 20:52:43 +00:00
Roger Dingledine
1f5c8335e8 still publish your descriptor if orport is reachable but dirport isn't 
when building testing circs for orport testing, require high-bandwidth
nodes, so fewer circs fail. complain about unreachable orport separately
from unreachable dirport.


svn:r3935
 2005-03-31 19:26:33 +00:00
Roger Dingledine
c2a05e1ca9 redo the state descriptors now that we have a controller-wait state 
svn:r3934
 2005-03-31 17:36:24 +00:00
Roger Dingledine
561cd28f99 bump cvs version to 0.1.0.1-rc-cvs 
svn:r3933
 2005-03-31 08:04:01 +00:00
Roger Dingledine
4f5192b280 ...and use it to make sure we only conclude reachability if 
we didn't initiate the conn.


svn:r3932
 2005-03-31 07:46:59 +00:00
Roger Dingledine
4a82ac12b8 add a tor_tls_is_server method to remember if conn->tls 
was an initiator or a receiver


svn:r3931
 2005-03-31 07:46:38 +00:00
Nick Mathewson
1bf1f44e74 Fix bug in redirectstream. 
svn:r3926
 2005-03-31 06:06:02 +00:00
Roger Dingledine
5bdab005c9 mark two more bugs. nick, can you take a look? 
svn:r3920
 2005-03-29 05:27:32 +00:00
Roger Dingledine
20a8eda31b don't check for reachability, and don't whine about it, while we're 
hibernating.


svn:r3919
 2005-03-29 03:48:31 +00:00
Roger Dingledine
7cf33ed495 resolve another 'hasn't sent end yet' bug 
svn:r3911
 2005-03-29 00:35:35 +00:00
Nick Mathewson
1612df7b2c Fix a couple more places where we use ->new_address without checking that it is there. 
svn:r3907
 2005-03-28 02:03:51 +00:00
Roger Dingledine
0e26973c02 make calls to address_is_in_virtual_range more bullet-proof. 
might fix the assert failure i just got.


svn:r3906
 2005-03-28 01:56:12 +00:00
Roger Dingledine
80901fde69 remember some thoughts about using WSAStartup to learn 
how many sockets we get to use on win32.


svn:r3905
 2005-03-28 01:11:02 +00:00
Nick Mathewson
4246f6f8bc Clarify that we don't, and why we don't, need to redefine FD_SETSIZE. 
svn:r3904
 2005-03-28 01:07:14 +00:00
Roger Dingledine
96c331e4ed we seem to have lost our define for FD_SETSIZE on win32 in the change 
from fakepoll to libevent. be sure to define it *before* we include
winsock.


svn:r3903
 2005-03-27 22:52:48 +00:00
Roger Dingledine
9b5432214d but only do the rapid reachability testing if we're hoping to be a server. 
svn:r3902
 2005-03-27 11:52:15 +00:00
Roger Dingledine
452563e157 make slightly clearer that socksport is for local applications 
svn:r3901
 2005-03-27 11:27:16 +00:00
Roger Dingledine
b8fe866a9d forward-port the fixing of the crash bug. 
svn:r3900
 2005-03-27 07:18:30 +00:00
Roger Dingledine
92acd64da0 if your server hasn't found itself to be reachable, complain every 
20 minutes, not just once.


svn:r3897
 2005-03-27 06:50:36 +00:00
Roger Dingledine
7a79acd9f6 clean up socks reply stuff more. 
add a few more reasons so we can be more informative.


svn:r3895
 2005-03-27 06:37:56 +00:00
Nick Mathewson
ce854906db Rename ManageConnections to LeaveStreamsUnattached. Apparently, there was a missing "TorShould" that was mistaken for an "IWantTo". 
svn:r3894
 2005-03-27 06:25:33 +00:00
Roger Dingledine
36baf7219d stop most cases of hanging up on a socks connection without sending 
the socks reject. audit for remaining ones. also make things more
uniform so we always remember to hold-open-until-flushed, etc.


svn:r3891
 2005-03-27 04:55:13 +00:00
Nick Mathewson
efb5db449a Describe where to find torrc on OS X 
svn:r3889
 2005-03-27 01:11:45 +00:00
Roger Dingledine
4533a46e41 move the assert higher up so the error message makes more sense 
next time.


svn:r3887
 2005-03-26 06:27:51 +00:00
Roger Dingledine
fcfe6d2e8b fix assert: stop trying to send a socks reply to an *exit* 
connection when we get an end cell before it's finished opening.


svn:r3886
 2005-03-26 06:27:04 +00:00
Roger Dingledine
b8d38dc57b try harder to establish reachability, in the first 20 minutes 
of uptime.


svn:r3884
 2005-03-26 05:54:50 +00:00
Roger Dingledine
1328383482 make it clearer to the human that his server is testing 
its reachability. tell him when it succeeds, or when 20
minutes pass and it hasn't succeeded yet.


svn:r3882
 2005-03-26 01:43:39 +00:00
Roger Dingledine
570da8a8e8 and fill in another missing socks reply 
svn:r3877
 2005-03-25 11:23:03 +00:00
Roger Dingledine
9b9dbad0b7 fix another case where we need to send a socks reply (reject) 
back before we close the conn.


svn:r3876
 2005-03-25 11:12:14 +00:00
Roger Dingledine
8945df8daa remove dead code 
svn:r3875
 2005-03-25 10:55:49 +00:00
Roger Dingledine
9685164fe5 don't mark a router down just because your httpsproxy is unreachable 
svn:r3874
 2005-03-25 10:55:06 +00:00
Nick Mathewson
d26bcfab92 Note where connection that hasnt sent end was marked. 
svn:r3872
 2005-03-25 05:54:50 +00:00
Roger Dingledine
bd37c9a3bd REUSEADDR on normal places means you can rebind to the port 
right after somebody else has let it go. But REUSEADDR on win32
means to let you bind to the port _even when somebody else
already has it bound_. So, don't do that on Win32.


svn:r3867
 2005-03-24 23:20:06 +00:00
Roger Dingledine
4abb54a876 forward-port the circuit_resume_edge_reading_helper fix. 
svn:r3863
 2005-03-24 21:57:45 +00:00
Roger Dingledine
fa3c9d94bc when you attachstream to a circid of 0, send back an answer 
svn:r3857
 2005-03-24 06:28:21 +00:00
Roger Dingledine
09ef2b7e41 cleanup so connection_ap_handshake_attach_chosen_circuit() always 
gets open circs.


svn:r3856
 2005-03-24 06:18:59 +00:00
Nick Mathewson
13fdf51bc1 Bulletproof connection_ap_handshake_attach_chosen_circuit 
svn:r3855
 2005-03-24 06:05:14 +00:00
Nick Mathewson
8e8915f3ca Fix SOCKS5 bug: Set replylen to 0 after sending hanshake back 
svn:r3850
 2005-03-24 01:11:28 +00:00
Nick Mathewson
0cfdeb01c8 Debug EXTENDCIRCUIT 
svn:r3849
 2005-03-24 01:08:25 +00:00
Roger Dingledine
0dc91fd9c0 fix an assert -- we're not allowed to write onto a conn after we've 
connection_unregistered it. there's still more work to be done here,
since we need to make sure to send back the socks-reply as soon as we
know what it will be -- we can't just wait until connection-about-to-close
to deal with it.


svn:r3847
 2005-03-23 23:19:18 +00:00
Roger Dingledine
fb8a319ffe fix an over-eager assert, to make httpsproxy get a little farther 
svn:r3846
 2005-03-23 22:11:59 +00:00
Roger Dingledine
935d0d9685 bump cvs to 0.1.0.1-rc 
svn:r3845
 2005-03-23 22:00:42 +00:00
Roger Dingledine
a799dad937 forward-port the commenting out of the assert that glenn fink was 
triggering. we still don't know why he was triggering it.


svn:r3841
 2005-03-23 20:42:37 +00:00
Nick Mathewson
4ee6addf57 Fix bug 44: on HUP, if descriptor building fails (say, because router_get_my_address() fails), use old descriptor and warn. 
svn:r3839
 2005-03-23 20:28:40 +00:00
Nick Mathewson
6e4bccc4ac Make GETINFO for "network-status" work on non-authdirs 
svn:r3837
 2005-03-23 19:15:10 +00:00
Nick Mathewson
b9016bd18f Fix several bugs (including some crashes) related to control interface; implement missing desc/name functionality. 
svn:r3836
 2005-03-23 08:40:11 +00:00
Nick Mathewson
0b7a9e2e7b Be willing to cache directories from up to ROUTER_MAX_AGE seconds into the future, now that we are more tolerant of skew. 
svn:r3832
 2005-03-23 06:39:53 +00:00
Nick Mathewson
631ab5c69b Add a magic value to cpath_layer_t to make sure that we can tell valid cpaths from freed ones. I audited this once; it could use another audit. 
svn:r3831
 2005-03-23 06:21:48 +00:00
Nick Mathewson
905c16846a Fix a few more instances of memory not freed on exit (found by weasel). 
svn:r3830
 2005-03-23 06:20:50 +00:00
Nick Mathewson
b7ce4d1d3d Correct fix for self-to-self addressmap; simplify replace-old-entry logic; add missing case. 
svn:r3829
 2005-03-23 05:32:06 +00:00
Roger Dingledine
22386ecf1e whoops, fix seg fault i just introduced 
svn:r3828
 2005-03-23 03:02:44 +00:00
Roger Dingledine
7373042a7b fix assert triggers (bugs 109 and 96), and put in some 
debugging logs to notice future repeat bugs.


svn:r3826
 2005-03-23 02:52:55 +00:00
Roger Dingledine
a523439cbc maybe resolve an assert trigger i just got: 
connection_edge.c:643 address_is_in_virtual_range: Assertion addr failed; aborting.
nick, what do you think?


svn:r3825
 2005-03-23 00:19:51 +00:00
Roger Dingledine
e28b8aaa40 make httpsproxy more likely to work 
(don't let OR conns do tls until they've finished connecting and
doing the proxy dance.)


svn:r3824
 2005-03-22 23:57:18 +00:00
Roger Dingledine
21b1adefbb fix a 32bit/64bit sprintf mixup that weasel pointed out 
svn:r3823
 2005-03-22 23:27:29 +00:00
Roger Dingledine
ad5f5ddf7e remove a duplicate circuit_mark_for_close() when picking 
a path for the circuit fails.


svn:r3822
 2005-03-22 23:20:33 +00:00
Roger Dingledine
6659cd5e8e options->MaxAdvertisedBandwidth only replaces advertised 
bandwidthrate, not advertised bandwidthcapacity


svn:r3818
 2005-03-22 20:41:28 +00:00
Nick Mathewson
ab1d0049a2 Prevent spurious closes when we put stuff on a conn that has not written for a while. 
svn:r3816
 2005-03-22 20:25:51 +00:00
Roger Dingledine
8a763b5ae3 cleanup and a question 
svn:r3815
 2005-03-22 20:04:00 +00:00
Nick Mathewson
7a0072cc1a Specify and implement close-stream and close-circuit control messages 
svn:r3814
 2005-03-22 19:36:38 +00:00
Nick Mathewson
ec81f87018 Implement an option to cap bandwidth-to-advertise. Arma: can you improve the manpage entry by explaining why you would want to do this? 
svn:r3813
 2005-03-22 19:01:46 +00:00
Nick Mathewson
2d662bf773 Clear up a couple of pedantic compiler warnings 
svn:r3812
 2005-03-22 18:56:11 +00:00
Nick Mathewson
2d40991427 Report HTTP reasons to directory clients. (Also, fix format on new TODO items) 
svn:r3811
 2005-03-22 18:43:24 +00:00
Roger Dingledine
d6a0e5bcc9 when reporting events about streams, use the "real" address for 
the stream, including the requested .exit address.


svn:r3810
 2005-03-22 10:34:23 +00:00
Roger Dingledine
e07e0a4732 remove obsolete code 
svn:r3809
 2005-03-22 10:34:00 +00:00
Nick Mathewson
c4470cbedf be more explicit about why we are expiring a conn; improve logic a bit too 
svn:r3808
 2005-03-22 06:21:35 +00:00
Nick Mathewson
f5989afde2 Add opt hibernating; fix bug 78 
svn:r3807
 2005-03-22 06:08:28 +00:00
Roger Dingledine
76a03e8635 handle_control_getinfo() was counting msg_len itself, 
when that's actually smartlist_join_strings2()'s job.


svn:r3806
 2005-03-22 05:41:05 +00:00
Roger Dingledine
248867caf5 bugfix: make smartlist_join_strings2 actually use the separator/terminator 
svn:r3805
 2005-03-22 05:37:59 +00:00
Roger Dingledine
ed9524a626 Remove controller getinfo support for "desc/all-ids". 
Replace it with getinfo "network-status" just like in directories.
This way the controller can learn which servers are running, which
are verified, etc.


svn:r3801
 2005-03-22 03:27:51 +00:00
Roger Dingledine
8d1460c858 tell me the address of the guy who's trying to attack my dirserver 
svn:r3799
 2005-03-22 01:18:50 +00:00
Roger Dingledine
f1ba4296c1 clean up and refactor some more 
svn:r3798
 2005-03-22 01:01:15 +00:00
Roger Dingledine
35953edae0 Implement controller's "extendcircuit" directive. 
Also refactor circuit building so we plan the whole path ahead
of time.


svn:r3797
 2005-03-22 00:42:38 +00:00
Roger Dingledine
5d5b12ce75 make example contactinfo entries slightly more spam resistant, since 
people are seeing spam to their contactinfo addresses now. (yay.)


svn:r3795
 2005-03-21 07:40:25 +00:00
Roger Dingledine
4a497e5030 if our clock jumps forward by 100 seconds or more, assume something 
has gone wrong with our network and abandon all not-yet-used circs.


svn:r3792
 2005-03-19 23:58:42 +00:00
Roger Dingledine
856ab90ca8 stop logging at -l notice every single time a create cell successfully 
gets processed


svn:r3791
 2005-03-19 23:04:15 +00:00
Geoff Goodell
035c8d1b1c added short blurb about ControlPort to sample torrc 
svn:r3790
 2005-03-19 20:50:03 +00:00
Roger Dingledine
fbeaeb138e and forward-port the missing space 
svn:r3789
 2005-03-19 20:30:23 +00:00
Nick Mathewson
b88c4ba11c Turn addr_policy_compare from a tristate to a quadstate; this should help address our "Ah, you allow 1.2.3.4:80. You are a good choice for google.com" problem. 
svn:r3786
 2005-03-19 06:57:16 +00:00
Nick Mathewson
07a7b6af64 Implement redirectstream in control interface. 
svn:r3785
 2005-03-19 06:05:55 +00:00
Roger Dingledine
963ddf2953 fix typo 
svn:r3784
 2005-03-19 05:09:13 +00:00
Nick Mathewson
11aa682812 Split version info into separate spec doc. 
svn:r3783
 2005-03-19 05:07:19 +00:00
Roger Dingledine
ec7f232b24 make hidden services more likely to work from the server-side 
svn:r3781
 2005-03-19 04:38:59 +00:00
Nick Mathewson
b004eda10c Enable NT service code by default 
svn:r3780
 2005-03-19 01:04:05 +00:00
Thomas Sjögren
7c29b65466 removing the warning about port 80. 
svn:r3773
 2005-03-18 16:34:56 +00:00
Thomas Sjögren
b1ceb1fb22 add "warning" about port 80 to torrc.sample.in 
svn:r3772
 2005-03-18 16:30:29 +00:00
Nick Mathewson
df9c8feac7 Commit fixes for several pending tor core tasks: document all DOCDOCed functions; time out uncontrolled unattached streams; feed reasons to SOCKS5 (refactoring connection_ap_handshake_socks_reply in the process); change DirFetchPeriod/StatusFetchPeriod to have a special "Be smart" value. 
svn:r3769
 2005-03-17 12:38:37 +00:00
Nick Mathewson
be38e0a490 Fix a fun windows bug: apparently windows stat wants paths not to end with slash. 
svn:r3766
 2005-03-16 00:04:59 +00:00
Roger Dingledine
229761465c re-enable reachability testing stuff. 
also, consider your ORPort reachable after you've processed a
create cell from any non-local address.


svn:r3763
 2005-03-15 01:44:46 +00:00
Thomas Sjögren
932252f9b4 Show people where they can find the default exit policy. 
svn:r3762
 2005-03-14 23:26:41 +00:00
Roger Dingledine
316afb6d09 fix an assert trigger in cvs: if a resolve request fails, and the circuit 
has vanished in the meantime, then we would both mark it for close
(i.e. put it on the closeable list) and also immediately free it.


svn:r3759
 2005-03-14 04:42:52 +00:00
Nick Mathewson
0197b47ce9 Fix some more obscure compiler warnings 
svn:r3758
 2005-03-14 03:28:46 +00:00
Nick Mathewson
97dad670ea Renormalize whitespace 
svn:r3757
 2005-03-14 03:18:35 +00:00
Nick Mathewson
fd150459b3 Raise common code for "detach this stream and try it with a different circuit" into a separate function; make that function handle controller-managed streams right. 
svn:r3756
 2005-03-14 03:12:59 +00:00
Roger Dingledine
cabb8624e2 bugfix: now that we don't do the client dns thing, our checks 
to see if somebody was contradicting his exit policy were wrong.


svn:r3755
 2005-03-13 05:53:17 +00:00
Roger Dingledine
01f0b31432 ShutdownWaitLength should be an interval, not a uint 
svn:r3753
 2005-03-12 20:16:52 +00:00
Roger Dingledine
fe768d1d2a change SHUTDOWN_WAIT_LENGTH from a fixed 30 secs to a config option 
svn:r3752
 2005-03-12 20:13:38 +00:00
Nick Mathewson
115271f65e Implement the common case of ATTACHSTREAM. 
svn:r3751
 2005-03-12 04:22:01 +00:00
Nick Mathewson
2b7907ef42 Increment step of a for loop should only happen once. 
svn:r3746
 2005-03-11 21:42:32 +00:00
Nick Mathewson
777d3dde0c Get address map resetting implemented. 
svn:r3745
 2005-03-11 21:39:39 +00:00
Nick Mathewson
b17bb918ac Remove unused macro; add a comment on remaining macros. 
svn:r3744
 2005-03-11 21:38:06 +00:00
Roger Dingledine
5254c4e63a remove duplicate function prototype 
svn:r3743
 2005-03-11 20:47:23 +00:00
Geoff Goodell
af15c711c9 redefining default exit policy as per or-talk discussion 
svn:r3739
 2005-03-11 05:07:31 +00:00
Nick Mathewson
99cc6bae0d Fix error codes to work on windows 
svn:r3738
 2005-03-10 18:48:13 +00:00
Nick Mathewson
6394f77edb Initialize msg_len 
svn:r3737
 2005-03-10 18:46:11 +00:00
Nick Mathewson
aaf70df3bd Fix signed/unsigned warning 
svn:r3736
 2005-03-10 18:45:42 +00:00
Nick Mathewson
37a478bd78 Tell windows how big time_t is. 
svn:r3735
 2005-03-10 18:45:18 +00:00
Nick Mathewson
a308353600 Fix const-ness warning 
svn:r3733
 2005-03-10 06:15:46 +00:00
Nick Mathewson
c185825585 Finish implementing GETINFO; make it easy to query address maps. 
svn:r3732
 2005-03-03 06:37:54 +00:00
Nick Mathewson
f90ccf5648 Implement new controller events for changed descriptors and new (not-yet-attached) streams. 
svn:r3731
 2005-03-02 22:29:58 +00:00
Nick Mathewson
4b5e213a0b Separate reverse-virtual-address-map entries into ipv4 and hostname slots. Otherwise if you ask me to map "some IPv4 address" to foo.onion, I might tell you that I already mapped "bar.virtual" to foo.onion 
svn:r3730
 2005-03-02 22:01:10 +00:00
Nick Mathewson
5315b61e13 Fix some log messages to refer to correct control type. 
svn:r3729
 2005-03-02 21:59:36 +00:00
Nick Mathewson
5f8e2c2bc4 Rename unused-address functions to virtual address; this is more accurate. Also, include almost-right implementation of reusing dont-care mappings. (It is still kind of wrong because it does not take type into account.) 
svn:r3728
 2005-03-02 21:02:11 +00:00
Nick Mathewson
b494c2223d Specify and implement fragmented control messages to allow for (among other things) long GETINFO replies. Otherwise we could hit the 64K barrier on questions like "please dump your client-side DNS cache." 
svn:r3726
 2005-03-02 20:22:10 +00:00
Nick Mathewson
65230fd39f Implement "Dont-Care" from addresses to MapAddress control message. For safety, refuse to launch connections to unmapped addresses in the dont-care range. 
svn:r3725
 2005-03-02 19:26:46 +00:00
Nick Mathewson
e14f812a67 Still more code to make sure we send the right number and kind of RELAY END cells 
svn:r3723
 2005-03-02 03:13:05 +00:00
Nick Mathewson
afe414f070 Revise all calls to connection_edge_end to avoid sending MISC, and to take errno into account where possible. 
svn:r3720
 2005-03-01 22:42:31 +00:00
Nick Mathewson
4ddf768a4f Forward-port new reasons; clean up code more; add code to convert new reasons to SOCKS5 reply codes; add code to convert errnos to reasons. New code still needs to get invoked. 
svn:r3719
 2005-03-01 22:16:15 +00:00
Nick Mathewson
83743d64ab Change version parsing logic: a version is "obsolete" if it is not recommended and (1) there is a newer recommended version in the same series, or (2) there are no recommended versions in the same series, but there are some recommended versions in a newer series. A version is "new" if it is newer than any recommended version in the same series. 
svn:r3716
 2005-03-01 01:44:57 +00:00
Nick Mathewson
b7b05dc1b2 make control interface stream IDs monotonically increasing to prevent possible races 
svn:r3715
 2005-03-01 01:15:01 +00:00
Nick Mathewson
349ee1abea Clean up rend cache on shutdown 
svn:r3714
 2005-02-28 22:38:00 +00:00
Roger Dingledine
b961d1c3bd disable the reachability detection stuff in cvs, so people can 
run servers from cvs while i'm gone.


svn:r3712
 2005-02-28 09:39:12 +00:00
Nick Mathewson
c5091e7134 When copying routerinfo, copy descriptor too to prevent later double-free. 
svn:r3711
 2005-02-28 03:37:27 +00:00
Nick Mathewson
97bc49bd72 Try a little harder to avoid openssl SSL* double-free reports. 
svn:r3710
 2005-02-28 02:52:51 +00:00
Nick Mathewson
0a2be3c9d8 Fix strmap_free to release memory actually held by the strmap. 
svn:r3708
 2005-02-28 02:21:40 +00:00
Roger Dingledine
b3177d509e free some more memory at shutdown 
svn:r3707
 2005-02-28 01:59:18 +00:00
Nick Mathewson
bed6c05453 give a better warning when tor points at an https server. 
svn:r3706
 2005-02-28 01:55:09 +00:00
Roger Dingledine
25ff3a5042 fix bug in control mapaddress 
svn:r3705
 2005-02-27 23:20:48 +00:00
Roger Dingledine
3cef60a0f7 fix a minor memory leak 
svn:r3704
 2005-02-27 22:08:01 +00:00
Roger Dingledine
a1f1fa6ab2 Checkpoint in-progress fixes: 
Add 'testing' circuit purpose, for reachability testing.
Notice when our IP changes, and reset stats.
Try to pull down a directory via Tor to see if our DirPort is working.
Try to extend a circuit back to us to see if our ORPort is working.
Only publish a descriptor if they're both reachable.

These mostly work, and I'd better get them in before I cause conflicts.


svn:r3703
 2005-02-27 09:47:01 +00:00
Nick Mathewson
8efb2a957d Make sure that router_get_by_* can always return "me" 
svn:r3702
 2005-02-27 07:23:42 +00:00
Nick Mathewson
2be0508f0d Be specific about which "illegal character" we just saw in the cert. 
svn:r3699
 2005-02-25 21:05:42 +00:00
Nick Mathewson
bbaa3c7792 Implement more control spec functionality 
- Mapaddress
- Postdescriptor
- GetInfo on descriptors

Required changes elsewhere:
- Keep the most recent running_routers_t in the routerlist_t. That way we
  can learn about new routers and remember whether we were last told that
  they were up or down.  Also enables more simplifications.
- Keep the signed descriptor inside routerinfo_t.  This makes
  descriptor_entry_t in dirservers.c unneeded.
- Rename AddressMap (the verb) to MapAddress. Keep AddressMap as a noun.
- Check addresses for plausibility before mapping them.


svn:r3696
 2005-02-25 20:46:13 +00:00
Nick Mathewson
8396105d84 Implement some of GETINFO control message 
svn:r3694
 2005-02-25 06:37:07 +00:00
Nick Mathewson
81d2c2d8e5 Stub functions for new control-spec logic. 
svn:r3693
 2005-02-25 06:16:28 +00:00
Nick Mathewson
26e6eb7539 Check returns from libevent calls better; stop poking at internals of events to see if they are live. 
svn:r3691
 2005-02-25 05:42:01 +00:00
Roger Dingledine
6329811a88 fix a seg fault from tor_free_all 
svn:r3690
 2005-02-24 23:01:26 +00:00
Nick Mathewson
24d7ae6fe8 Insert missing ! in assert_connection_ok; test was accidentally reversed in revision 1.329 yesterday. Should fix bug 102 
svn:r3685
 2005-02-24 17:08:27 +00:00
Roger Dingledine
5b24ca6cde cache .exit address better (i think) 
svn:r3684
 2005-02-24 11:44:08 +00:00
Roger Dingledine
6faaac2706 add support for CONNECTing through https proxies. 
not sure if it works. i don't have an https proxy.


svn:r3682
 2005-02-24 10:56:55 +00:00
Roger Dingledine
8054f82992 stop a potential overflow (pointed out by ilja) 
svn:r3681
 2005-02-24 10:22:00 +00:00
Nick Mathewson
2adee31a26 Improve log message on unrecognized encoding to indicate that we can cope. 
svn:r3676
 2005-02-23 22:14:34 +00:00
Nick Mathewson
22c38b0f9b Clarify comment. Use CONN_IS_EDGE more. Try to be more zealous about calling connection_edge_end when things go bad with edge conns in connection.c 
svn:r3671
 2005-02-23 20:35:26 +00:00
Nick Mathewson
69a36e352e clarify comment 
svn:r3667
 2005-02-23 06:46:54 +00:00
Nick Mathewson
e0387d1322 Addressmap tweak: Make "addressmap x x" remove any mapping from the address x. 
svn:r3666
 2005-02-23 06:40:48 +00:00
Nick Mathewson
2ff6cfccd6 Forward-port fix to make dual-purpose NT executable work. 
svn:r3665
 2005-02-23 05:34:25 +00:00
Roger Dingledine
55c3f15ed1 Forward-port the trick to bump up ConnLimit as far as it can 
go, but not past MAXCONNECTIONS. Also throw away the FAKE_POLL
caveats since 0.1.0 doesn't need it any more.


svn:r3657
 2005-02-22 23:52:44 +00:00
Nick Mathewson
6e6d95b3db Change from inet_ntoa to a threadproof tor_inet_ntoa. 
svn:r3656
 2005-02-22 08:18:36 +00:00
Nick Mathewson
e8da6b26b6 Note a non-bug in read_file_to_str as used. If we start to rely on it behaving differently, we need to change how it behaves. [Noticed by Chris Palmer] 
svn:r3655
 2005-02-22 07:18:46 +00:00
Nick Mathewson
d37f4dd8a9 But on windows, localtime and gmtime _are_ threadsafe. 
svn:r3654
 2005-02-22 07:09:17 +00:00
Nick Mathewson
70c3580f81 Patch to localtime/gmtime handling: use the _r variants where available. Use mutexes to fake _r where necessary. Make mutexes no-ops where no threading is enabled. 
svn:r3653
 2005-02-22 07:03:03 +00:00
Nick Mathewson
d01718841e Remove assumptions that maximum path length is anything like 1024. From comments by Chris Palmer 
svn:r3652
 2005-02-22 06:38:39 +00:00
Nick Mathewson
bb53a0bddd remove spurious semicolons 
svn:r3650
 2005-02-22 04:55:19 +00:00
Nick Mathewson
d060f845f2 Snarf some logic from python, adapted to our own needs, to handle gethostbyname_r correctly across platforms. 
svn:r3649
 2005-02-22 04:50:31 +00:00
Nick Mathewson
a68fcbf807 Initial IRIX compatibility fixes: check for inttypes.h; check for platform cell_t. 
svn:r3648
 2005-02-22 04:26:45 +00:00
Nick Mathewson
c2d5b67dd2 After we successfully connect, try handling pending stuff immediately, rather than waiting for the next call to connection_handle_write. Roger: is this right? 
svn:r3647
 2005-02-22 03:02:33 +00:00
Nick Mathewson
e673536e3f Print uname on start of unittests. 
svn:r3646
 2005-02-22 03:01:31 +00:00
Nick Mathewson
1a55422006 Fix windows build: juggle }s and #endifs around in main.c 
svn:r3645
 2005-02-22 02:57:43 +00:00
Nick Mathewson
6bd81c9ee2 Fix windows build: do not spuriously include openssl where not needed; handle lack of gethostbyname_r properly. 
svn:r3644
 2005-02-22 02:51:55 +00:00
Roger Dingledine
8991af604c make the addressmap internals less noisy 
svn:r3643
 2005-02-22 00:55:50 +00:00
Roger Dingledine
8727acf2f1 Add a new AddressMap directive to rewrite incoming socks addresses. 
Add a new TrackHostExits directive to trigger addressmaps for
certain incoming socks addresses, for sites that break when your exit
keeps changing.
Redo the client-side dns cache so it's just an addressmap too.


svn:r3641
 2005-02-22 00:53:08 +00:00
Roger Dingledine
b5bddd8cfd bugfix: actually use the argument to strmap_free() 
svn:r3640
 2005-02-20 23:12:20 +00:00
Roger Dingledine
38f53cff41 forward-port the onion queue thing 
svn:r3639
 2005-02-20 09:27:48 +00:00
Roger Dingledine
596d65ec3b avoid case (not yet triggered) where smartlists could grow out 
of control


svn:r3636
 2005-02-19 03:02:33 +00:00
Roger Dingledine
cbb4803ec8 forward-port some fixes 
svn:r3631
 2005-02-17 01:12:50 +00:00
Roger Dingledine
797419a62c remove unused code 
svn:r3629
 2005-02-16 02:06:54 +00:00
Nick Mathewson
0289144229 Fix another crash bug found by Jaroslaw--it is possible for dns_resolve to mark a connection to be freed, if the circuit it was attached to fails for some reason. 
svn:r3623
 2005-02-14 21:16:27 +00:00
Nick Mathewson
aac97a3c6a Tell openssl how to use locks and how to find thread ids -- this may prevent race conditions surrounding the error queue. 
svn:r3622
 2005-02-13 22:32:25 +00:00
Nick Mathewson
427e246a10 Add a missing prototype to or.h 
svn:r3621
 2005-02-13 22:31:26 +00:00
Nick Mathewson
d90ab823ea remove redundant unpack in critical path 
svn:r3620
 2005-02-13 16:17:32 +00:00
Nick Mathewson
f6221b695f Apply windows patch from Dmitri Bely 
svn:r3617
 2005-02-12 21:03:37 +00:00
Nick Mathewson
58540dde50 Do not try to double-aquire lock when rotating keys. May fix deadlock bug found by weasel. 
svn:r3616
 2005-02-11 07:56:10 +00:00
Nick Mathewson
5d836c8140 Free tls resources on exit too 
svn:r3615
 2005-02-11 01:41:19 +00:00
Nick Mathewson
f672577bc6 Free even more things on shutdown. Temporarily move tor_free_all out from #ifdef so it gets tested more. 
svn:r3614
 2005-02-11 01:26:47 +00:00
Nick Mathewson
60f234f42b Add more functions to free things to help dmalloc allong. 
svn:r3613
 2005-02-10 23:18:39 +00:00
Roger Dingledine
33569e40d7 if we're hibernating and we get a sigint, exit immediately. 
closes bug 91.


svn:r3611
 2005-02-10 07:34:19 +00:00
Roger Dingledine
236aa86ae7 stop picking unverified dir mirrors, ever. 
it only leads to misery.


svn:r3610
 2005-02-10 07:00:23 +00:00
Roger Dingledine
37ca621301 when a client asks us for a dir mirror and we don't have one, 
launch an attempt to get a fresh one.


svn:r3609
 2005-02-10 06:31:34 +00:00
Roger Dingledine
07a3307460 remove redundant lines 
svn:r3607
 2005-02-09 23:54:30 +00:00
Nick Mathewson
89d422914a Patch from adam langley: always remove sockets from libevent before closing them. Should fix epoll-related bugs. 
svn:r3606
 2005-02-09 23:16:31 +00:00
Roger Dingledine
c5c46d6fb6 don't list version in the win32 service display name or service name, 
since they'll keep changing and people will get messed up about which
one is installed.


svn:r3592
 2005-02-09 02:26:24 +00:00
Nick Mathewson
a64b03a4fd Avoid double-free on tor-resolve failure 
svn:r3567
 2005-02-05 23:55:21 +00:00
Nick Mathewson
bb32fa86d7 Re-normalize whitespace; make "make check-spaces" happy 
svn:r3566
 2005-02-05 21:42:46 +00:00
Nick Mathewson
24ad6542c9 forward-port NT service patch 
svn:r3565
 2005-02-05 21:40:25 +00:00
Nick Mathewson
322c728e97 Fix tor-resolve implementation to prevent crashes and send resolves when we should. 
svn:r3561
 2005-02-05 21:03:24 +00:00
Roger Dingledine
56d4b99491 forward-port the logic skew and double-free thing 
svn:r3549
 2005-02-04 01:49:58 +00:00
Nick Mathewson
915202048e Handle return value from getaddrinfo properly 
svn:r3526
 2005-02-03 23:13:36 +00:00
Roger Dingledine
efa9bb5535 fix the latest bug: don't explode when some router declares a 
bandwidthburst of 500 gigabytes.

this bug seems to have taken down most of the network. oops.


svn:r3523
 2005-02-03 22:58:22 +00:00
Nick Mathewson
a035032f09 Use getaddrinfo and gethostbyname_r where available. Note that these are not necessarily threadsafe: this needs more thinking. Perhaps we should back down on this multithreading idea. 
svn:r3522
 2005-02-03 21:31:04 +00:00
Nick Mathewson
e4b21c97f7 Forward-port SGI Compatibility patches from Jan Schaumann 
svn:r3517
 2005-02-03 19:59:10 +00:00
Roger Dingledine
051cda803e point out a potential thread/process leak problem when we're out of memory 
svn:r3512
 2005-02-03 07:35:24 +00:00
Roger Dingledine
bcece3d8a7 another minor fix 
svn:r3511
 2005-02-03 07:30:00 +00:00
Peter Palfrader
ddd724ef94 Add --with-dmalloc configure option 
svn:r3508
 2005-02-03 07:25:10 +00:00
Peter Palfrader
dfa3a0220f Write a function header for Roger so he can fill it with life 
svn:r3507
 2005-02-03 07:23:48 +00:00
Roger Dingledine
f3b74a2adb http://www.erlenstar.demon.co.uk/unix/faq_2.html says we 
should call _exit, not exit, from child processes.


svn:r3506
 2005-02-03 06:40:06 +00:00
Roger Dingledine
f575d29a59 note a bug that wmf just found 
svn:r3503
 2005-02-02 06:28:45 +00:00
Roger Dingledine
c1656f41b4 bugfix: tor-resolve requests were ignoring .exit if there was 
a working circuit they could use instead.


svn:r3502
 2005-02-02 06:26:52 +00:00
Roger Dingledine
0551e3a814 reject more default filesharing ports by default. 
svn:r3500
 2005-02-02 04:15:40 +00:00
Roger Dingledine
976bee4a3f only check if exit_policy_implicitly_allows if you're a server. 
also, put a comment next to an interesting undocumented 'feature'.


svn:r3499
 2005-02-02 01:59:16 +00:00
Roger Dingledine
0f5a198028 sometimes, a conn on the closeable_lst gets absolutely 
clobbered. maybe this will help me find out why.


svn:r3498
 2005-02-02 00:19:09 +00:00
Roger Dingledine
850c300e46 bump the default rate limit to 1 MB 
svn:r3494
 2005-02-01 13:44:10 +00:00
Roger Dingledine
b90983e44f reject odd-looking addresses at the client, rather than having 
the server drop them because they're malformed.


svn:r3493
 2005-02-01 12:19:44 +00:00
Roger Dingledine
1447145470 give a bit more load to servers that claim to be able to 
handle a whole lot.


svn:r3489
 2005-02-01 02:56:31 +00:00
Roger Dingledine
1e847aebb1 Go into soft hibernation after 95% of the bandwidth is used, 
not 99%. This is especially important for daily hibernators who
have a small accounting max. Hopefully it will result in fewer
cut connections when the hard hibernation starts.


svn:r3488
 2005-02-01 02:45:28 +00:00
Roger Dingledine
2e97593d25 define TOR_FRAGILE if you want tor to give you a core when 
something goes wrong. this should only be used by people actively
tracking bugs.


svn:r3487
 2005-02-01 00:37:16 +00:00
Roger Dingledine
e7e77d6d8e fix an edge case in parsing config options (thanks weasel) 
svn:r3486
 2005-02-01 00:05:57 +00:00
Peter Palfrader
d19aaa9a46 Fix arma's fix for my leak 
svn:r3485
 2005-01-31 23:47:25 +00:00
Roger Dingledine
ab8691c343 fix a minor memory leak found by weasel 
svn:r3484
 2005-01-31 20:38:57 +00:00
Roger Dingledine
d232831135 stop a sigpipe. 
apparently when we get an eof, at least sometimes it *does* mean
you'd better not try writing.


svn:r3481
 2005-01-31 08:12:30 +00:00
Roger Dingledine
9856e328c4 stop logging loudly when a client tries an old onion key. it's 
time to give up on that issue, at least for now.


svn:r3479
 2005-01-31 04:03:57 +00:00
Roger Dingledine
a7138f2535 fix another rogue connection_free that was causing us troubles 
there are no doubt more lurking.


svn:r3478
 2005-01-31 03:47:38 +00:00
Roger Dingledine
a0312f3590 don't double-detach a closing exit conn that's waiting for dns resolve 
svn:r3477
 2005-01-31 01:27:49 +00:00
Roger Dingledine
692a57c8e8 but don't spring the trip on worker children, because it turns 
out they don't actually remove anything before freeing the conns.


svn:r3476
 2005-01-31 01:02:20 +00:00
Roger Dingledine
d6489d8e41 lay a trap for situations where we connection_free something 
that's still on one of the lists.

in particular, this will detect situations where we mark-for-close
and then free it ourselves.


svn:r3475
 2005-01-31 00:33:32 +00:00
Roger Dingledine
75b45bcd4d stop the infinite loop of freeing the same connection_t over and 
over when it's not linked into the connection_array


svn:r3474
 2005-01-31 00:26:09 +00:00
Roger Dingledine
c53c7a0b4c clarify what smartlist_remove promises, since we rely on it. 
svn:r3473
 2005-01-31 00:24:59 +00:00
Roger Dingledine
5d8659429e be less noisy about complaining when a jap client tries to connect 
and we refuse him.


svn:r3472
 2005-01-30 23:52:47 +00:00
Roger Dingledine
3969b6066e Stop crashing when we're asking to close_if_marked a conn that 
hasn't been connection_added yet. This happens when an exit conn
is in dns_wait and we get a relay end cell for it before it finishes.

We were silently leaking each of these marked conns in 0.0.9.x. Now
we actually free them.


svn:r3470
 2005-01-30 21:47:47 +00:00
Roger Dingledine
20ecfc757b be safe: if you got a resolvefailed end cell but you're not an AP, bail. 
svn:r3469
 2005-01-30 21:46:42 +00:00
Roger Dingledine
7ddeb7fae7 try to find the corrupt closeable_connection_lst entry early 
svn:r3468
 2005-01-30 20:31:08 +00:00
Roger Dingledine
e432d2ceea we should handle the case where the client has no cert, for 
backwards compatibility with jap clients.


svn:r3466
 2005-01-30 08:02:33 +00:00
Roger Dingledine
cab0138e4c give a better log message when we don't have a good mirror of 
the directory yet and somebody asks for it.


svn:r3464
 2005-01-30 06:08:42 +00:00
Roger Dingledine
8e7fc8d259 comment about a bug wrt clock skew 
svn:r3461
 2005-01-30 00:07:31 +00:00
Roger Dingledine
d273891107 if we fetch the dir from a mirror that has a wildly skewed 
clock, then don't bother checking recommended-versions: it will
just make us sad.

as a side effect, people running obsolete versions and whose
clocks are wildly skewed will not be auto-shut-down. but they
will still get warns about their clock skew.


svn:r3459
 2005-01-29 11:48:37 +00:00
Roger Dingledine
191e52179c distinguish between "well-formed and rejected" and "not well 
formed", when parsing server descriptors.


svn:r3458
 2005-01-29 11:23:34 +00:00
Roger Dingledine
7fd8dfe6ea accept LDAP (389/tcp) and LDAPS (636/tcp) in default exit policy 
svn:r3457
 2005-01-29 11:16:23 +00:00
Roger Dingledine
82d3894f3e don't let a corrupt directory cache keep us from starting 
svn:r3456
 2005-01-29 11:07:35 +00:00
Roger Dingledine
0b9b97aaf4 forward-port the shutting up 
svn:r3450
 2005-01-28 10:00:29 +00:00
Roger Dingledine
b2fbd834f0 forward-port the dns and maxconn fixes 
svn:r3448
 2005-01-28 08:53:47 +00:00
Roger Dingledine
d7cee9dbf4 make the example log-to-file line use log-level notice rather than 
log-level warn.


svn:r3441
 2005-01-28 05:40:41 +00:00
Nick Mathewson
083b67cda5 Add rudimentary pthread support that needs more testing. 
svn:r3439
 2005-01-27 22:34:48 +00:00
Nick Mathewson
e03f571ee3 Forward-port win32 service patch; try to clean it a touch. 
svn:r3438
 2005-01-27 21:45:32 +00:00
Roger Dingledine
8ebe85333c comment SocksPort better as it pertains to servers 
svn:r3413
 2005-01-22 06:51:31 +00:00
Nick Mathewson
fbb7f869c5 fwd-port win32 isprint fix 
svn:r3410
 2005-01-22 00:42:58 +00:00
Nick Mathewson
1dc4d9a0ce Fix dumb bug in unittests. 
svn:r3409
 2005-01-22 00:42:40 +00:00
Roger Dingledine
2a908e5180 forward-port: fix win32 compile 
svn:r3406
 2005-01-22 00:35:09 +00:00
Nick Mathewson
de9b46ad64 clean a couple of messages 
svn:r3401
 2005-01-21 23:16:07 +00:00
Roger Dingledine
4826718eac special case so we don't yell when an empty http body doesn't specify a 
content-encoding


svn:r3397
 2005-01-21 03:18:49 +00:00
Roger Dingledine
b137f6d19f if we get an incredibly skewed timestamp from a dirserver mirror that 
isn't a verified OR, don't complain very loudly -- it's probably him
that's wrong.


svn:r3395
 2005-01-21 00:45:18 +00:00
Nick Mathewson
8115ca5f99 Log the offending policy, not the first policy 
svn:r3394
 2005-01-20 20:42:45 +00:00
Nick Mathewson
6704093c0d Appease another 64-bit warning 
svn:r3392
 2005-01-20 20:21:34 +00:00
Nick Mathewson
fd41cbcadf Have reason string for serverdesc post requests contain actual serverdesc status. Also fix return values of dirserv_add_descriptor to work as advertised. 
svn:r3391
 2005-01-20 20:18:32 +00:00
Nick Mathewson
5b45527851 Appease weasel's paranoid 64-bit compiler. 
svn:r3389
 2005-01-20 20:16:48 +00:00
Roger Dingledine
a2e441da06 give a header file for ntohs 
svn:r3388
 2005-01-20 20:15:14 +00:00
Roger Dingledine
67f0babfd4 start to fix http status stuff, more work needed 
svn:r3387
 2005-01-20 20:07:36 +00:00
Nick Mathewson
80e8359ccf Give better reason phrases in HTTP status lines. Start resolving task #67. (Messages still need to be better.) 
svn:r3386
 2005-01-20 19:46:02 +00:00
Nick Mathewson
29b6637a62 Compilation fixes for win32 version detection. 
svn:r3385
 2005-01-20 19:03:09 +00:00
Nick Mathewson
432e313c81 Make zlib detection happy on little-endian platforms; fix unit tests. 
svn:r3384
 2005-01-20 19:02:35 +00:00
Nick Mathewson
129e754ae4 Warn when exit policy implicitly allows local addresses. 
svn:r3383
 2005-01-20 18:39:48 +00:00
Roger Dingledine
a6e91f8157 The crowning hidden-service patch: prefer non-internal circuits 
for normal connections, so we don't spend our internal circs on
other stuff and not have them when we need them.


svn:r3380
 2005-01-20 07:02:24 +00:00
Roger Dingledine
38be533c69 Handle unavailable hidden services better. We try each intro point 
until none are left, then we try to refetch the descriptor. If it's
the same one we had before, then close streams right then. Whenever
a new stream arrives, even if it's right after, optimistically try
refetching the descriptor, just in case.


svn:r3379
 2005-01-19 23:15:59 +00:00
Roger Dingledine
ff48179372 make cannibalizing for rend circs prey on the pleb circs first 
if possible, rather than the elite ones.


svn:r3378
 2005-01-19 23:13:20 +00:00
Nick Mathewson
f8c14bbf1f Detect windows platform correctly 
svn:r3377
 2005-01-19 23:10:16 +00:00
Nick Mathewson
2c803bff9a Make detect_compression_method work on platforms with more evil chars. 
svn:r3376
 2005-01-19 23:07:43 +00:00
Nick Mathewson
1eddb28f82 Add unittests for compression detection. Make all rendezvous descriptors "plausible". 
svn:r3375
 2005-01-19 22:47:48 +00:00
Nick Mathewson
69fa5be7b6 Workaround for webservers that lie about Content-Encoding: Tor now tries to autodetect compressed directories and compression itself. (resolves bug 65) 
svn:r3374
 2005-01-19 22:40:33 +00:00
Nick Mathewson
e0bf597665 Give more useful log messages when the tor process closes dns/cpuworker connections. "Error: Success!" makes us seem like crazy people." 
svn:r3373
 2005-01-19 21:34:42 +00:00
Roger Dingledine
75d83827e0 fix another bug where general exit circs were looking at rendezvous 
streams. consolidate the looking into one function so it doesn't
happen again.


svn:r3372
 2005-01-19 17:59:37 +00:00
Roger Dingledine
f2a7ff6801 better comments for exit policies in torrc.sample 
svn:r3371
 2005-01-19 17:26:40 +00:00
Roger Dingledine
cfcc93296c bugfix for cvs: we were needing a rendezvous circ, so we cannibalized 
a general circ, and called rend_client_rendcirc_has_opened(), which
called connection_ap_attach_pending(), which was needing a rendezvous
circ, so it cannibalized a general circuit, and called ...


svn:r3370
 2005-01-19 17:13:11 +00:00
Roger Dingledine
bd2d740b49 make it clearer why FooPort and FooBindAddress are separate 
svn:r3369
 2005-01-19 06:06:04 +00:00
Nick Mathewson
7d4a167c81 Basic windows libevent fixes 
svn:r3366
 2005-01-18 23:44:55 +00:00
Roger Dingledine
4e369bc9e8 allow bandwidthburst to be smaller, but whine if it's small. 
svn:r3364
 2005-01-18 19:34:22 +00:00
Roger Dingledine
ea24dc31bc remove some extra-verbose logs 
svn:r3361
 2005-01-17 18:49:13 +00:00
Roger Dingledine
d2400a5afd Introduce a notion of 'internal' circs, which are chosen without regard 
to the exit policy of the last hop. Intro and rendezvous circs must
be internal circs, to avoid leaking information. Resolve and connect
streams can use internal circs if they want.

New circuit pooling algorithm: make sure to have enough circs around
to satisfy any predicted ports, and also make sure to have 2 internal
circs around if we've required internal circs lately (with high uptime
if we've seen that lately).

Split NewCircuitPeriod config option into NewCircuitPeriod (30 secs),
which describes how often we retry making new circuits if current ones
are dirty, and MaxCircuitDirtiness (10 mins), which describes how long
we're willing to make use of an already-dirty circuit.

Once rendezvous circuits are established, keep using the same circuit as
long as you attach a new stream to it at least every 10 minutes. (So web
browsing doesn't require you to build new rend circs every 30 seconds.)

Cannibalize GENERAL circs to be C_REND, C_INTRO, S_INTRO, and S_REND
circ as necessary, if there are any completed ones lying around when
we try to launch one.

Re-instate the ifdef's to use version-0 style introduce cells, since
there was yet another bug in handling version-1 style. We'll try switching
over again after 0.0.9 is obsolete.

Bugfix: when choosing an exit node for a new non-internal circ, don't take
into account whether it'll be useful for any pending x.onion addresses --
it won't.

Bugfix: we weren't actually publishing the hidden service descriptor when
it became dirty. So we only published it every 20 minutes or so, which
means when you first start your Tor, the hidden service will seem broken.


svn:r3360
 2005-01-17 18:13:09 +00:00
Roger Dingledine
372832d8fe make tor-resolve print the Tor version on --version too 
svn:r3358
 2005-01-16 02:21:14 +00:00
Roger Dingledine
c6771e5ce4 reset published uptime when you wake up from hibernation, 
since if you hibernate daily a published uptime of >1day
will be misleading.


svn:r3356
 2005-01-14 17:49:25 +00:00
Roger Dingledine
dcf8b18215 when the hidden service launches a rendezvous circ, make sure it 
provides good uptime if any virtual_port of the service wants that.


svn:r3355
 2005-01-14 04:35:53 +00:00
Nick Mathewson
a38bccdca7 Move call to event_init() immediately after start_daemon(); move start_daemon earlier. This should fix using libevent with RunAsDaemon. 
svn:r3354
 2005-01-13 21:32:08 +00:00
Roger Dingledine
0aff4ff4cb get rid of 0.0.8 backwards compatibility 
svn:r3353
 2005-01-13 20:22:38 +00:00
Roger Dingledine
22f7934718 start generating version 1 style introduce cells 
svn:r3352
 2005-01-13 20:21:11 +00:00
Roger Dingledine
49fe4cba74 when deciding if a port is handled and the port demands uptime, don't 
consider it handled if there's a circ that fits but isn't high-uptime.


svn:r3349
 2005-01-13 07:23:19 +00:00
Roger Dingledine
abea142665 more cleanup 
svn:r3347
 2005-01-12 12:22:25 +00:00
Roger Dingledine
bafb3e4a5b fix another integer underflow caused by buckets going negative 
svn:r3346
 2005-01-12 12:19:00 +00:00
Roger Dingledine
24a97d2c55 fix up some comments 
svn:r3345
 2005-01-12 12:18:46 +00:00
Roger Dingledine
3809c0ab91 tolerate bandwidtch buckets going negative (i hope) 
svn:r3344
 2005-01-12 10:00:38 +00:00
Nick Mathewson
324b192f68 Make Tor use Niels Provos's libevent instead of it's current 
poll-but-sometimes-select mess.  This will let us use faster async cores
(like epoll, kpoll, and /dev/poll), and hopefully work better on Windows
too.

There are some fairly nasty changes to main.c here; this will almost
certainly break something.  But hey, that's what alphas are for.


svn:r3341
 2005-01-12 06:42:32 +00:00
Roger Dingledine
9b578f2fe2 add more chat and interactive protocols to LongLivedPorts 
svn:r3340
 2005-01-12 05:18:14 +00:00
Roger Dingledine
84c81e0783 Annotate circuits w/ whether they aim to contain high uptime nodes and/or 
high capacity nodes. When building circuits, choose appropriate nodes.

New config option LongLivedPorts to indicate application streams
that will want high uptime circuits.

When attaching a stream to a circuit, pay attention to its requirements.

This means that every single node in an intro rend circuit, not just
the last one, will have a minimum uptime.

Boost the min uptime from an hour to 24 hours.


svn:r3339
 2005-01-12 04:58:23 +00:00
Roger Dingledine
51f47d746e clean up smartlist_string_isin so callers don't have to manage bufs 
themselves


svn:r3338
 2005-01-12 04:53:53 +00:00
Roger Dingledine
70b3208f0a if somebody starts his tor server in jan 2004 and then fixes his 
clock, don't make his published uptime be a year.


svn:r3337
 2005-01-11 11:54:11 +00:00
Roger Dingledine
45eb8d9660 if you're a server and the auth dirservers are down, go to any other 
server. only give up hope on network reachability when no other servers
are reachable either.


svn:r3335
 2005-01-10 17:39:41 +00:00
Roger Dingledine
74bc4e5af0 help avoid overflow from len_in + (len_in/n)*len_ins 
nick, do you think this does it? if so, we should maybe backport too.


svn:r3334
 2005-01-10 16:30:51 +00:00
Roger Dingledine
4b6d55afdf separate time_of_process_start from stats_n_seconds_uptime: 
now we reset uptime when a dir fetch entirely fails. this
hopefully has something to do with stability of being on the
network.


svn:r3333
 2005-01-10 05:10:22 +00:00
Roger Dingledine
3370f53010 it helps to use the correct name for the struct 
svn:r3331
 2005-01-10 04:32:59 +00:00
Roger Dingledine
10a81ccf18 when pruning circuit-wait streams when a dir fetch failed, 
refer in logs to the destination address, not the address of the
application connection.


svn:r3330
 2005-01-10 02:47:50 +00:00
Roger Dingledine
f468ff04ea when we haven't fetched a directory yet, or the last time we 
tried they were all unreachable, assume we are not connected to
the network.

when an application request comes in during this state, be
optimistic and assume we just reconnected. fetch a new directory
and if it works, begin making circuits.


svn:r3327
 2005-01-07 15:57:57 +00:00
Roger Dingledine
608caffc64 fix unit tests: address has to be a non-private IP, and socksport 
needs to be 0.


svn:r3324
 2005-01-07 01:12:30 +00:00
Roger Dingledine
cd1f50d2f0 new config option DirAllowPrivateAddresses for authdirservers. 
now by default they refuse router descriptors that have non-IP
or private-IP addresses.


svn:r3321
 2005-01-06 21:03:27 +00:00
Nick Mathewson
91bafc476e Fix a fun bug: do not rewrite a cached directory back to the cache; otherwise we will think it is recent and not fetch a newer one. 
svn:r3319
 2005-01-06 20:11:52 +00:00
Roger Dingledine
f8b517fa97 finish marking my comment in main.c 
svn:r3318
 2005-01-06 19:20:54 +00:00
Roger Dingledine
1f51809e65 clean up string printing in relay logs 
svn:r3317
 2005-01-06 19:19:13 +00:00
Roger Dingledine
6d2859c2e5 fix trivial typo in log entry 
svn:r3316
 2005-01-06 19:17:01 +00:00
Nick Mathewson
a6e587305f typo spotted by chris 
svn:r3308
 2005-01-05 06:48:39 +00:00
Nick Mathewson
dcd228585d Implement SIGNAL control command. 
svn:r3307
 2005-01-05 06:40:47 +00:00
Nick Mathewson
b4fedc7f14 Stop reversing and re-reversing config lines: keep them in order all the time. Removes needless confusion and fixes bug #50. 
svn:r3305
 2005-01-05 06:05:37 +00:00
Nick Mathewson
e99f79fa4d Remove broken and undocumented wart where multiple CSV config lines are appended rather than replaced. Resolves bug #49 
svn:r3301
 2005-01-05 02:51:04 +00:00
Roger Dingledine
814dd946f0 fix duplicate dns_cancel_pending_resolve reported by Giorgos Pallas 
svn:r3293
 2005-01-04 11:26:08 +00:00
Roger Dingledine
ba7c74e742 bandaid: make Giorgos Pallas's dns assert bug not actually crash on him. 
one day we should try to figure out what's actually going on here.


svn:r3280
 2005-01-04 06:21:06 +00:00
Nick Mathewson
6dd91de3bd Nothing actually _uses_ socks_port, so why publish it? For backward compatibility, publish a socks_port of 0, and never read socks_port. 
svn:r3279
 2005-01-04 05:46:54 +00:00
Roger Dingledine
e6c1ab2daf post 0.0.9.x, demand that servers declare at least 20000 bytes/s 
for bandwidthrate


svn:r3277
 2005-01-04 03:46:50 +00:00
Nick Mathewson
4d30e2f4b8 Make sequence of log messages when starting on win32 with no config file more reasonable. 
svn:r3275
 2005-01-04 02:25:36 +00:00
Roger Dingledine
1f3e77bf92 make the initial temp log only notice-err, not info-err 
svn:r3274
 2005-01-04 02:25:18 +00:00
Roger Dingledine
82c5381ecb forward-port the fix for the compiler warning 
svn:r3273
 2005-01-04 01:16:20 +00:00
Roger Dingledine
d7a0f1a629 update print_usage to use new url 
svn:r3267
 2005-01-03 23:21:32 +00:00
Roger Dingledine
a005509c9d update url for when users try to use socksport as an http proxy 
svn:r3265
 2005-01-03 23:19:15 +00:00
Roger Dingledine
9e6d6c6096 Bugfix: we've been using openssl's BIO_get_mem_data incorrectly. 
We assumed the pem-encoded data written by PEM_write_bio_RSAPrivateKey
is nul-terminated, and at least sometimes, it's not.


svn:r3263
 2005-01-03 22:35:40 +00:00
Roger Dingledine
53c522ee1c make it clearer you can have multiple SocksBindAddress directives 
svn:r3262
 2005-01-03 21:47:59 +00:00
Nick Mathewson
d1fc7ad94b Log when we retry a directory connection 
svn:r3258
 2005-01-03 21:14:09 +00:00
Nick Mathewson
0c4186d6ee Use correct logic to decide whether there are more directory servers to retry. 
svn:r3257
 2005-01-03 20:51:24 +00:00
Nick Mathewson
65c4fa2614 Split mark-dir-failed-and-retry logic into separate function; make it retry runningrouters as well as directory fetches; note that the do-we-need-to-give-up test is wrong. 
svn:r3256
 2005-01-03 20:07:07 +00:00
Nick Mathewson
858eda4736 Fix an unused function warning 
svn:r3255
 2005-01-03 20:03:49 +00:00
Nick Mathewson
5f40d6bf72 Make directory fail-and-retry logic happen in connection_about_to_close(); fixes win32 bug. 
svn:r3253
 2005-01-03 19:51:10 +00:00
Nick Mathewson
b50263f740 More work on task #43: fix race conditions on multithreaded (win32) servers. 
svn:r3251
 2005-01-03 19:07:25 +00:00
Nick Mathewson
ead52e0bdc Possible fix for task #43: when running on a multithreaded environment (currently only windows), threads should not close opposite sides of their socketpairs, and workers should not call connection_free_all(). This may fix win32 servers. 
svn:r3247
 2005-01-03 18:06:51 +00:00
Nick Mathewson
fca7ba9777 Resolve task 42: find where 19-char nicknames were getting truncated when read from certs, and fix it. Also audit use of MAX_NICKNAME_LEN; no other badness found, but some docs/code cleaned up a touch. 
svn:r3244
 2005-01-03 17:53:20 +00:00
Roger Dingledine
59504f4831 bugfix: if a server uploads a descriptor that's unapproved, actually 
tell him so.


svn:r3243
 2005-01-03 17:47:32 +00:00
Roger Dingledine
70075933c6 stop checking for clock skew, even for servers. 
this means we are vulnerable to an attack where somebody recovers
and uses a really old certificate. however, if they do that, they
probably can get our identity key just as easily.


svn:r3241
 2005-01-03 17:10:32 +00:00
Roger Dingledine
fdf8c55f30 clarify the comments about logs in the torrc 
svn:r3239
 2005-01-02 06:34:58 +00:00
Roger Dingledine
b4dad0e6a4 fix the assert bug reported by bassclef@163.com 
svn:r3237
 2005-01-02 06:16:46 +00:00
Roger Dingledine
0d7e8660c7 add a comment to explain what ContactInfo is for 
svn:r3236
 2005-01-01 23:58:16 +00:00
Roger Dingledine
a4ad47df86 Fix a double-mark-for-close bug, where we were finding a conn 
for a cell even if that conn is already marked for close.

Don't back-port to 0.0.9.x, since this fix could have weird implications.


svn:r3235
 2005-01-01 07:54:01 +00:00
Roger Dingledine
35d5a5b712 when a dirserver causes you to give a warn, mention which dirserver it was 
svn:r3234
 2005-01-01 07:40:59 +00:00
Roger Dingledine
e29d7329b3 ...but only if you're a server 
svn:r3233
 2004-12-31 21:49:20 +00:00
Roger Dingledine
95f3e6161b require BandwidthRate to be at least 10kB/s 
svn:r3232
 2004-12-31 21:47:54 +00:00
Roger Dingledine
717fe4993e actually make it stop keeping track of times. whoops. 
svn:r3230
 2004-12-25 07:19:48 +00:00
Roger Dingledine
e1ac30c2bb stop calling assert_connection_ok(conn, time(NULL)) on every single 
conn on every single loop.


svn:r3229
 2004-12-25 06:43:40 +00:00
Roger Dingledine
288f2ed59e stop telling win32 folks they have a bug just because we haven't finished 
making tor work on win32 yet.


svn:r3227
 2004-12-25 06:42:15 +00:00
Roger Dingledine
be72937ab0 initial profiling by phobos says we spend a whole lot of time 
measuring how long each cell takes to process. make that optional.


svn:r3226
 2004-12-25 06:10:34 +00:00
Roger Dingledine
53105cdae5 when you're loading the rendezvous service keys in options_act(), 
don't call it 'reloading'.


svn:r3225
 2004-12-24 20:45:45 +00:00
Roger Dingledine
3a572fcffa don't connection_edge_end() on eof if we're already marked for close, 
because if we are then it's because we already got an end.


svn:r3223
 2004-12-24 09:43:57 +00:00
Nick Mathewson
ded8e79979 remove sentence-fragment comment refering to a design that never happened. 
svn:r3220
 2004-12-24 02:50:27 +00:00
Nick Mathewson
e8585dfe97 Remove length restriction when generating directories. 
svn:r3218
 2004-12-24 02:17:32 +00:00
Nick Mathewson
7117366810 Fix for running-routers length bug 
svn:r3216
 2004-12-24 01:41:52 +00:00
Roger Dingledine
f50b785c3b and forward port the cleanup 
svn:r3211
 2004-12-22 10:04:50 +00:00
Roger Dingledine
18320557a1 fix a crash: if you do socks4 with an IP of 0.0.0.x then we get tricked 
into thinking you're doing socks4a, and we look for the next byte.

thanks to aphex for finding this.


svn:r3207
 2004-12-22 09:52:29 +00:00
Roger Dingledine
c3189c2573 fix an assert on startup when the disk is full and you're logging to a file 
svn:r3204
 2004-12-22 08:16:42 +00:00
Roger Dingledine
cf17d0d29c move network_init from or/main to common/compat 
call network_init in tor-resolve.c too
move tor_lookup_hostname from common/util to common/compat


svn:r3203
 2004-12-22 05:29:06 +00:00
Roger Dingledine
036384fd8e respond to an 009 XXX 
svn:r3201
 2004-12-22 02:55:26 +00:00
Nick Mathewson
c79c4200f4 Fix a bug in last patch; and keep my name out of the assert() call too. 
svn:r3200
 2004-12-22 02:46:28 +00:00
Nick Mathewson
32978afa54 Workaround for brain-damaged __FILE__ handling on MSVC: keep Nick's name out 
of the warning messages.


svn:r3199
 2004-12-22 02:32:26 +00:00
Roger Dingledine
f9fd101869 forward port: 
fix a fencepost: we were blowing away the \n when reporting confvalue items


svn:r3194
 2004-12-21 02:57:25 +00:00
Roger Dingledine
308ffa8a05 When listing circuits that are pending on an opening OR connection, 
if we're an OR we were listing circuits that *end* at us as
being pending on every listener, dns/cpu worker, etc. Stop that.


svn:r3171
 2004-12-17 23:17:00 +00:00
Nick Mathewson
323b3a8dbc Bump repository version to tor-0.1.0.0-alpha-cvs. (First prerelease will be 0.1.0.1-alpha 
svn:r3168
 2004-12-17 21:17:44 +00:00
Roger Dingledine
ee282fc167 mark nickname and ORPort as the two required fields for servers 
svn:r3156
 2004-12-16 21:36:08 +00:00
Nick Mathewson
bbc10c2ea1 Make split(..., NULL) split on horizontal space; fix bug with tabs in config file. 
svn:r3155
 2004-12-16 21:10:51 +00:00
Nick Mathewson
e327b2f3a6 Clarify confusing message 
svn:r3151
 2004-12-16 05:23:48 +00:00
Roger Dingledine
29cf8a0a45 move us to 0.0.9.1 
svn:r3150
 2004-12-15 19:51:35 +00:00
Roger Dingledine
e1bc3f097e bugfix: when we're reporting event circuit status, don't call it a stream. 
while we're at it, include ":port" in the stream event string.


svn:r3148
 2004-12-14 03:36:33 +00:00
Roger Dingledine
b6173b7b68 0.0.9 broke hibernation. darn it. 
svn:r3147
 2004-12-13 19:42:46 +00:00
Nick Mathewson
75cefd8989 Remove bugfixes that did not actually do anything, before we start a cargo cult. 
svn:r3145
 2004-12-13 18:48:12 +00:00
Nick Mathewson
8c85c0bef8 Note that length checking on base64_decode is kinda conservative 
svn:r3144
 2004-12-13 18:38:19 +00:00
Nick Mathewson
1e71b83890 Fix a bug in parsing HashedControlPassword. 
svn:r3143
 2004-12-13 18:32:29 +00:00
Roger Dingledine
6cc7d32afc clarify a log entry 
svn:r3142
 2004-12-13 02:23:22 +00:00
Roger Dingledine
a8582ae223 note a future thing we should do 
svn:r3141
 2004-12-13 01:30:41 +00:00
Roger Dingledine
c0cb824857 move us to 0.0.9 
svn:r3139
 2004-12-13 00:52:35 +00:00
Roger Dingledine
011ad3cba5 clean up logging, 
make it clearer which warns are bugs,
make the control log event match its specification,
point out a bug in how we deal with failure when renewing the tls context.


svn:r3138
 2004-12-13 00:44:39 +00:00
Nick Mathewson
972124aab9 Only launch dns workers when we are actually starting a server. 
svn:r3137
 2004-12-13 00:09:00 +00:00
Roger Dingledine
464338b250 when hibernating, don't advertise any ports 
this is important for the dirport, because clients will still
ask you for a directory, and they'll be sad when you're down.
and do the other ports too, because hey, they're not listening.


svn:r3133
 2004-12-11 23:53:59 +00:00
Roger Dingledine
1477bf18e7 fix header text of torrc.sample 
svn:r3129
 2004-12-10 19:22:15 +00:00
Roger Dingledine
470cdea7f8 make the 64 bit args print correctly on 64 bit archs 
svn:r3123
 2004-12-08 12:30:20 +00:00
Nick Mathewson
fd4c624677 Belt *or* suspenders will be sufficient when casting things to unsigned char. 
svn:r3122
 2004-12-08 07:20:21 +00:00
Roger Dingledine
524a8bdc70 bump to 0.0.9rc7 
svn:r3121
 2004-12-08 01:14:56 +00:00
Nick Mathewson
fe6eb34a10 Solaris CC freaks out if isspace and friends get anything other than an int. We learned that, so we casted. But it is also a bad idea to cast a signed char to an int and expect things to work on win32. Now we cast to unsigned char, then to int, then pass to isspace. Ug 
svn:r3120
 2004-12-08 00:42:50 +00:00
Nick Mathewson
fc8a2596e1 Log contents of bw_accounting when we read it; fix memory leak. 
svn:r3118
 2004-12-07 23:20:10 +00:00
Roger Dingledine
ca95ed74ac resolve tequila's crash bug: you can't free something 
and then keep using it.


svn:r3117
 2004-12-07 21:57:37 +00:00
Roger Dingledine
ad4f440e10 rearrange debug logs to make more sense 
svn:r3116
 2004-12-07 21:57:10 +00:00
Roger Dingledine
33cf6f2f61 clean two more minor memory leaks 
svn:r3115
 2004-12-07 19:42:45 +00:00
Nick Mathewson
06ce31b948 Only set a cookie when we intend to. 
svn:r3114
 2004-12-07 19:36:43 +00:00
Roger Dingledine
e93077c82a fix a minor leak for people offering hidden services 
svn:r3113
 2004-12-07 17:49:14 +00:00
Roger Dingledine
29a8e80326 log bytes written with kill -USR1 too 
svn:r3112
 2004-12-07 16:50:47 +00:00
Roger Dingledine
012255fe60 fix the other half of the pipe race 
svn:r3111
 2004-12-07 16:37:32 +00:00
Roger Dingledine
bd5524bfc7 fix comment 
svn:r3110
 2004-12-07 15:37:35 +00:00
Roger Dingledine
538c3b0c26 avoid a sigpipe from a race: if we get the end right after 
the app has hung up on us, we shouldn't hold-open-until-flush.


svn:r3109
 2004-12-07 15:31:54 +00:00
Roger Dingledine
802d374a99 I'm a bad person. 
Stop treating the uint16_t's as null-terminated strings,
and stop looking at the byte after them to see if it's null,
because sometimes you're not allowed to look there.


svn:r3108
 2004-12-07 15:29:54 +00:00
Roger Dingledine
a2d80ec767 were we on crack?? 
svn:r3107
 2004-12-07 09:18:25 +00:00
Roger Dingledine
41b809d2aa salvage another 300 bytes per hup 
svn:r3106
 2004-12-07 09:11:38 +00:00
Roger Dingledine
d9f86e2782 and bust another memory leak 
svn:r3105
 2004-12-07 08:58:26 +00:00
Roger Dingledine
5d961c2c06 plug another memory leak 
svn:r3104
 2004-12-07 08:51:10 +00:00
Nick Mathewson
a6aa5eebd6 Fix some memory leaks and unlikely segfaults 
svn:r3103
 2004-12-07 07:48:16 +00:00
Roger Dingledine
3ff0077cbb bump us to 0.0.9rc7-cvs 
svn:r3102
 2004-12-07 07:37:01 +00:00
Roger Dingledine
2297c57ba5 note an improvement on our uname we might want to make one day 
svn:r3101
 2004-12-07 07:35:32 +00:00
Roger Dingledine
8f01b643c3 ORPort must be defined if ORBindAddress is defined. 
svn:r3100
 2004-12-07 06:51:46 +00:00
Nick Mathewson
0f49fd3bcd Fix leakable rsa key 
svn:r3099
 2004-12-07 06:48:02 +00:00
Roger Dingledine
e0e40e51ae clean up docs a bit for default log lines. 
svn:r3098
 2004-12-07 06:38:41 +00:00
Roger Dingledine
2ff38fdf83 when recommending new-format log lines, if the upper bound is LOG_ERR, 
leave it implicit.


svn:r3097
 2004-12-07 06:27:39 +00:00
Nick Mathewson
d19648b314 Renormalize whitespace 
svn:r3095
 2004-12-07 05:33:55 +00:00
Nick Mathewson
ac759adb43 Make unit tests work on win32 
svn:r3094
 2004-12-07 05:31:38 +00:00
Nick Mathewson
08e3090aff More win32 fixes: 1) tolerate extra "readable" events better. 2) when being multithreaded, leave parent fdarray open. 
svn:r3092
 2004-12-06 23:19:55 +00:00
Nick Mathewson
249a36586f Fix parse_iso_time on platforms without strptime. 
svn:r3091
 2004-12-06 22:39:10 +00:00
Roger Dingledine
4006246b9e bump us to 0.0.9rc6 
svn:r3089
 2004-12-06 06:27:39 +00:00
Roger Dingledine
f00631e6b9 answer resolved ip in network order 
svn:r3087
 2004-12-06 06:14:45 +00:00
Roger Dingledine
f10f24a61c avoid using uninitialized variable 
svn:r3086
 2004-12-06 06:07:57 +00:00
Roger Dingledine
0859d09352 don't use cache for resolving .foo.exit names, but do reply immediately 
if we're asked to resolve an IP.foo.exit.


svn:r3085
 2004-12-06 06:06:13 +00:00
Roger Dingledine
577665f608 fix indenting 
svn:r3084
 2004-12-06 05:26:19 +00:00
Roger Dingledine
f21564eb29 send an end to the streams we close when we hibernate, rather 
than just chopping them off


svn:r3083
 2004-12-05 13:02:18 +00:00
Roger Dingledine
1c9c813866 check if we have a cached resolve for a tor-resolve address *after* 
we remove the .foo.exit part of the address.


svn:r3082
 2004-12-05 12:47:46 +00:00
Roger Dingledine
5ba3328172 fix a minor leak in my recent commit 
svn:r3081
 2004-12-05 12:35:00 +00:00
Roger Dingledine
469135e7e2 talk about quotas rather than bandwidths, in the logs 
svn:r3080
 2004-12-05 12:26:02 +00:00
Roger Dingledine
50a314c931 int is not necessarily the same size as size_t 
svn:r3079
 2004-12-05 11:58:30 +00:00
Roger Dingledine
ef6c9d18e7 New circuit building strategy: keep a list of ports that we've used in the past 6 hours, and always try to have 2 circuits open or on the way 
that will handle each such port. (We can extend this to include addresses
if exit policies shift to require that.) Seed us with port 80 so web
browsers won't complain that Tor is "slow to start up".

This was necessary because our old circuit building strategy just involved
counting circuits, and as time went by we would build up a big pile of
circuits that had peculiar exit policies (e.g. only exit to 9001-9100)
which would take up space in the circuit pile but never get used.

Fix router_compare_addr_to_addr_policy: it was not treating a port of *
as always matching, so we were picking reject *:* nodes as exit nodes too.

If you haven't used a clean circuit in an hour, throw it away, just to
be on the safe side.

This means after 6 hours a totally unused Tor client will have no
circuits open.


svn:r3078
 2004-12-05 07:10:08 +00:00
Roger Dingledine
32e74d3525 fix comment 
svn:r3077
 2004-12-04 13:58:34 +00:00
Roger Dingledine
02b3229a04 plus add a comment re: the previous bug 
svn:r3076
 2004-12-04 10:18:41 +00:00
Roger Dingledine
52676364b9 bugfix: router_exit_policy_rejects_all() was broken, so we were 
sometimes picking middleman nodes as our last hop, which wasn't
very useful.


svn:r3075
 2004-12-04 08:56:59 +00:00
Roger Dingledine
2532e9405e Now we allow writing to the buffer even when the stream if marked for 
close, if we're planning to wait to flush it.

This is important because we were sending a socks reject back if we're
closing and hadn't already sent one, but it wasn't actually getting
written since the conn was already marked-for-close.


svn:r3074
 2004-12-04 07:13:37 +00:00
Roger Dingledine
5a6e117caf React to eof immediately on non-open edge connections. 
Stop keeping track of num_retries for apconns, since they expire
after 60 seconds anyway.

When warning about retrying or giving up, print the address, so
the user knows which one it's talking about.


svn:r3073
 2004-12-04 03:26:35 +00:00
Roger Dingledine
c644886c38 bugfix: When we were checking to see if an ap_conn should time out 
waiting for its connected cell, we were calculating time from when the
ap_conn was created. So if it waited say 20 seconds before being attached,
then we would immediately decide that the circuit had timed out.

Also, make circuit_dump_by_conn() display actual circuit progress,
including circuits that haven't been attached to the conn yet but
hope to when it finishes connecting.


svn:r3072
 2004-12-04 02:51:11 +00:00
Roger Dingledine
675f60aa13 whoops 
just because it says snprintf doesn't mean it's a noop


svn:r3071
 2004-12-04 01:23:04 +00:00
Nick Mathewson
fc87758ff3 Add function to check that addr_policy_t is okay; change struct addr_policy_t to addr_policy_t. 
svn:r3070
 2004-12-04 01:14:36 +00:00
Roger Dingledine
e694268644 bump us to 0.0.9rc6-cvs 
darn these bugs


svn:r3069
 2004-12-04 00:36:34 +00:00
Roger Dingledine
8d69dc472b make circuit building and router parsing less noisy 
svn:r3068
 2004-12-04 00:25:54 +00:00
Roger Dingledine
f79a7d8d62 while hibernating, hup should not regrow our listeners. 
svn:r3067
 2004-12-03 23:53:35 +00:00
Nick Mathewson
a980446d0c Be more proactive about noticing underflows: size_t values greater than 0x800...00 are likely to be trouble. 
svn:r3064
 2004-12-02 04:33:01 +00:00
Roger Dingledine
db5e100cde clean up 3 more underflow possibilities 
svn:r3063
 2004-12-02 04:31:52 +00:00
Roger Dingledine
0799804c60 fix redundant (and dangerous) NUL termination 
svn:r3062
 2004-12-02 04:16:18 +00:00
Nick Mathewson
e3f6f92cf7 check for duplicate circuit ID _after_ updating circ_id_type. 
svn:r3058
 2004-12-01 04:55:03 +00:00
Roger Dingledine
a3395e893f bump to 0.0.9rc5 
svn:r3056
 2004-12-01 04:32:51 +00:00
Roger Dingledine
82f3ebf195 move StatusFetchPeriod to 15 minutes so it's within bounds by default 
svn:r3055
 2004-12-01 04:27:11 +00:00
Roger Dingledine
ef04cfcbad one more typo 
svn:r3054
 2004-12-01 04:13:15 +00:00
Nick Mathewson
41ba4575b3 Fix windows build. 
svn:r3053
 2004-12-01 03:51:59 +00:00
Nick Mathewson
b457cfb5eb Spell-check strings and comments 
svn:r3052
 2004-12-01 03:48:14 +00:00
Nick Mathewson
6e88abf418 If we are using select, make sure we stay within FD_SETSIZE. 
svn:r3051
 2004-12-01 03:15:59 +00:00
Roger Dingledine
bde1d5bfb2 do even less inside our signal handler, 
just to be extra paranoidly safe


svn:r3050
 2004-12-01 02:54:13 +00:00
Nick Mathewson
a889926e1c Clarify chosen tag progression 
svn:r3047
 2004-11-30 16:07:20 +00:00
Roger Dingledine
3929f58018 clean obsolete circuit_log_path code 
svn:r3046
 2004-11-30 10:47:48 +00:00
Roger Dingledine
eb558d0a84 clean up the other "Tell Roger" log that dfc keeps getting 
svn:r3042
 2004-11-30 09:02:25 +00:00
Roger Dingledine
7a8c1ca1e4 a few minor tweaks 
svn:r3041
 2004-11-30 08:54:08 +00:00
Roger Dingledine
19ada3f7fa write down our "how to have two defaults for dirfetchperiod" 
issue, so we don't forget about it.


svn:r3040
 2004-11-30 08:44:19 +00:00
Roger Dingledine
1d4af1930c Let resolve conns retry/expire also, rather than sticking around forever. 
Put the check-if-requested-exitrouter-will-reject-us code in the
circuit_attach loop, so it gets checked periodically and not just
once at the beginning. This is useful in case the routerlist changes,
but also in case the address gets resolved into something that we learn
we'll reject.


svn:r3039
 2004-11-30 08:39:14 +00:00
Roger Dingledine
d383c23e73 refuse .exit addresses immediately if the requested node would 
refuse the request (e.g. due to exit policy or wrong version)


svn:r3038
 2004-11-30 08:15:09 +00:00
Nick Mathewson
5ec4e75cdb Make tor-resolve accept x.y.exit addresses again 
svn:r3036
 2004-11-30 07:06:05 +00:00
Nick Mathewson
bec7a1c6e8 use shorter minimum key lifetime until 008 is dead 
svn:r3035
 2004-11-30 06:44:07 +00:00
Nick Mathewson
f19e9b8577 doxygen uses backslashes, not forward-slashes 
svn:r3033
 2004-11-30 06:17:35 +00:00
Nick Mathewson
a3477223de clarify why strlcpy is safe in truncated log messages 
svn:r3032
 2004-11-30 06:15:06 +00:00
Nick Mathewson
a5d3325c5c Fix last patch 
svn:r3031
 2004-11-30 06:12:21 +00:00
Nick Mathewson
c8abe1907d Rename parse_address to parse_extended_hostname (since we have other kinds of addresses); make its output an enum; support HEXDIGEST.exit hostnames. 
svn:r3029
 2004-11-30 03:44:10 +00:00
Nick Mathewson
ebab451eed Make version parsing tests pass 
svn:r3028
 2004-11-30 03:41:06 +00:00
Nick Mathewson
fd68834b17 Give an early error if you pass a .onion or a .exit hostname to tor-resolve 
svn:r3027
 2004-11-30 03:12:37 +00:00
Nick Mathewson
ad7db5e43a Add casei versions of strcmpstart/strcmpend 
svn:r3026
 2004-11-30 03:10:56 +00:00
Nick Mathewson
ee7bef1458 Enforce coding style. 
svn:r3025
 2004-11-30 02:26:41 +00:00
Nick Mathewson
e764d00e15 If anybody set DirFetchPostPeriod, give them StatuFetchPeriod instead. Impose minima and maxima for all *Period options; impose even tighter maxima for fetching if we are a caching dirserver. Clip rather than rejecting. arma: are these good? 
svn:r3024
 2004-11-30 02:23:51 +00:00
Nick Mathewson
ce505f5033 note possible alternative for how to do CVS versions; ask arma which he likes. 
svn:r3023
 2004-11-29 23:06:51 +00:00
Nick Mathewson
6507be4290 Implement new version format for post 0.1. 
svn:r3022
 2004-11-29 23:04:26 +00:00
Nick Mathewson
7fbd297532 Suggestion from weasel: Make tor --version --version dump the cvs Id of every file. 
svn:r3019
 2004-11-29 22:25:31 +00:00
Nick Mathewson
aff5122685 Fetch cached running-routers from servers that serve it (that is, authdirservers, and servers running 0.0.9rc5-cvs or later.) 
svn:r3018
 2004-11-29 21:01:34 +00:00
Nick Mathewson
b6b07d1d98 Remove needless -2 in log code. This was not an underflow risk, sinze we only call format_msg from one place, where buf_len==10024 
svn:r3017
 2004-11-29 20:39:55 +00:00
Roger Dingledine
671a2de762 clean up the previous underflow check, and also point out 
yet another one that may be a problem. nick?


svn:r3016
 2004-11-29 08:40:24 +00:00
Roger Dingledine
c1dc17e6e2 put in initial support for ".nickname.exit" addresses, to let alice 
decide what exit node to use; based on a patch by geoff goodell.

needs more work: e.g. it goes bananas building new circuits when the
chosen exit node's exit policy rejects the connection.


svn:r3015
 2004-11-29 08:34:54 +00:00
Nick Mathewson
9ba7311c1c After implementing a feature, remember to disable the error message you used to get when requesting it. 
svn:r3013
 2004-11-29 07:59:00 +00:00
Nick Mathewson
eccfe23a21 Disallow NDEBUG. It is very stupid. 
svn:r3012
 2004-11-29 07:22:57 +00:00
Roger Dingledine
531c060b36 fix integer underflow in tor_vsnprintf() 
(probably exploitable)


svn:r3011
 2004-11-29 06:49:04 +00:00
Roger Dingledine
185f047450 prevent integer underflow 
(not currently exploitable, ilja and i think)


svn:r3010
 2004-11-29 06:43:21 +00:00
Roger Dingledine
9811f68310 bump to 0.0.9rc5-cvs 
svn:r3009
 2004-11-29 01:00:54 +00:00
Roger Dingledine
7fc30fc1e6 accept *:706 (silc) by default 
svn:r3006
 2004-11-28 15:49:12 +00:00
Roger Dingledine
22727b4edc wrong is ok, and right is fine, but in between is apparently 
totally unacceptable to me.


svn:r3005
 2004-11-28 11:39:53 +00:00
Nick Mathewson
f7c6ad065e correct multiple internal spaces 
svn:r3004
 2004-11-28 09:14:07 +00:00
Nick Mathewson
6f5dbefa7e Normalize space: add one between every control keyword and control clause. 
svn:r3003
 2004-11-28 09:05:49 +00:00
Roger Dingledine
67dc7baa59 bump to 0.0.9rc4 
svn:r3001
 2004-11-28 06:44:08 +00:00
Roger Dingledine
dad760ddd1 one of the debugging aids was misleading 
svn:r3000
 2004-11-28 06:33:14 +00:00
Nick Mathewson
32651dd108 connect() on win32 can do more things than we thought? 
svn:r2999
 2004-11-28 05:58:55 +00:00
Nick Mathewson
0702179d28 Very oops. make windows nonblocking sockets nonblocking 
svn:r2998
 2004-11-28 05:57:18 +00:00
Nick Mathewson
f77ff938b7 remember; tor_socket_errno has side effects! 
svn:r2997
 2004-11-28 05:48:02 +00:00
Roger Dingledine
40c97ac504 move the rendezous section of the torrc to the middle, since 
it isn't server-only, and indeed it may be unwise to run a
hidden service on a server.


svn:r2995
 2004-11-27 08:18:22 +00:00
Roger Dingledine
e5e45fe980 inform him more sanely 
svn:r2993
 2004-11-26 04:19:03 +00:00
Roger Dingledine
a7f92d7ffe inform the user that you noticed when he sent a USR2 
svn:r2992
 2004-11-26 04:17:57 +00:00
Roger Dingledine
81dad3e08b that's enough changes to bump to rc4-cvs 
svn:r2991
 2004-11-26 04:08:07 +00:00
Roger Dingledine
f9a0ab62b7 if you want to handle -USR2, you should catch it too. 
svn:r2990
 2004-11-26 04:03:19 +00:00
Roger Dingledine
7c9a707900 remove emacs droppings, since nick says he doesn't need them anymore 
svn:r2989
 2004-11-26 04:00:55 +00:00
Roger Dingledine
02a30a348a give up trying to track down the reason we're calling package_inbuf 
with a package window of 0. it's safe to just catch the error cases
there and do the right thing.


svn:r2988
 2004-11-26 03:43:54 +00:00
Roger Dingledine
179ad27b34 call set_max_file_descriptors() after we configure logs, so 
it doesn't always do loglevel info logs on windows.


svn:r2987
 2004-11-26 03:05:55 +00:00
Roger Dingledine
e24057b2bf when warning that a version is too new, don't use the confusing 
text "is_obsolete_version():".


svn:r2986
 2004-11-25 05:49:13 +00:00
Roger Dingledine
d254aeb09e bump to 0.0.9rc3 
svn:r2984
 2004-11-25 05:40:06 +00:00
Nick Mathewson
f91152ce6a Clarify a bunch of log messages 
svn:r2983
 2004-11-25 04:20:10 +00:00
Peter Palfrader
f2a96ce1fe Flush the logfd after we print "Tor opening log file", so we don't see those messages days later 
svn:r2980
 2004-11-24 08:42:06 +00:00
Roger Dingledine
914d346095 update conn_state_to_string 
svn:r2979
 2004-11-24 07:58:15 +00:00
Roger Dingledine
a2042a8b1d a little help for dfc to debug his "resolve 800 things at once" test 
svn:r2978
 2004-11-24 07:51:30 +00:00
Roger Dingledine
c89afb7917 avoid infinite loop in tor-resolve if tor hangs up on it 
svn:r2977
 2004-11-24 07:45:42 +00:00
Roger Dingledine
83e7043eb8 don't process marked-for-close conns further. 
(fix assert trigger -- if we're lucky.)


svn:r2975
 2004-11-24 06:41:58 +00:00
Roger Dingledine
7d55f3685e make tor-resolve work, uh, more. this time for sure! 
svn:r2974
 2004-11-24 06:16:36 +00:00
Roger Dingledine
cca469ec58 make tor-resolve work again 
svn:r2973
 2004-11-24 06:01:52 +00:00
Roger Dingledine
0eebfe3558 bugfix: let socks do multiple rounds of negotiation again 
(which is needed for socks5)


svn:r2970
 2004-11-24 04:35:28 +00:00
Roger Dingledine
090c84627c patch to nick's patch 
svn:r2969
 2004-11-24 03:58:45 +00:00
Nick Mathewson
74f74a06c6 make nt service version match actual version 
svn:r2968
 2004-11-24 00:55:39 +00:00
Nick Mathewson
e84f964aad bump windows version stuff to 009rc2 
svn:r2967
 2004-11-24 00:33:30 +00:00
Nick Mathewson
1bec1b3d37 Better notice for hibernate interval spans; when estimate is 0, start out awake. 
svn:r2963
 2004-11-23 22:34:23 +00:00
Nick Mathewson
5fa55c8317 Bugfix: when no units are given, default to seconds or bytes. 
svn:r2960
 2004-11-23 10:52:27 +00:00
Roger Dingledine
a284b0db8f another slightly less confusing message 
nick: we need to figure out if we should say anything different
here when the wake-up time and the expected back-to-sleep time
have both passed.


svn:r2956
 2004-11-23 10:05:56 +00:00
Roger Dingledine
b6cb547667 less confusing message upon hibernation 
svn:r2955
 2004-11-23 09:21:03 +00:00
Roger Dingledine
921c40abe7 fail more gracefully next time 
svn:r2954
 2004-11-23 09:01:37 +00:00
Roger Dingledine
57a392d8d8 initialize rephist before we init_from_config, since init_from_config 
can make us init_keys if we're going to hibernate, which makes us build
a router_desc.


svn:r2953
 2004-11-23 09:00:55 +00:00
Roger Dingledine
d7fb38cfe3 update unit tests to reflect changed interface 
svn:r2952
 2004-11-23 08:36:26 +00:00
Roger Dingledine
7ed738b34c fix some typos; move to 0.0.9rc1 
svn:r2951
 2004-11-23 07:37:25 +00:00
Nick Mathewson
f5319a010d Dr. Seuss on iterating circular lists: "It's fun to have fun, but you 
have to know how."


svn:r2948
 2004-11-23 06:08:08 +00:00
Nick Mathewson
0a58bbe0dd Fix critical bug in circuit_list_path: cpath is a circular list! (Also reimplement circuit_log_cpath using circuit_list_cpath). 
svn:r2946
 2004-11-23 00:11:36 +00:00
Nick Mathewson
cd70264377 Clean up some logging and interfaces 
svn:r2945
 2004-11-23 00:08:26 +00:00
Nick Mathewson
22dba27d8d Normalize a few more kinds of whitespace. We now dislike: 
- func (args)
  - if (x){
This doesn't normalize if(x), for(x); while(x), and friends.


svn:r2943
 2004-11-22 23:28:26 +00:00
Nick Mathewson
fe32c2d141 Fix sign-related warnings 
svn:r2942
 2004-11-22 22:50:17 +00:00
Nick Mathewson
d4754b334c Compile cleanly on windows; prevent some insane bandwidth cases (e.g., "BandwidthBurst 1000 TB" from occuring. 
svn:r2941
 2004-11-22 22:24:10 +00:00
Nick Mathewson
983a335f3b Normalize space 
svn:r2939
 2004-11-22 22:13:34 +00:00
Nick Mathewson
f17c08beed Apply NT service patch from Osamu Fujino. This still has some problems (indicated in a comment adapted from the patch submission email), but it is better than before and better than nothing. 
svn:r2938
 2004-11-22 22:10:37 +00:00
Nick Mathewson
956b463dfe Implement weekly/monthly/daily accounting 
svn:r2936
 2004-11-22 21:56:51 +00:00
Nick Mathewson
55df2620c6 Add function to format local time in ISO format 
svn:r2935
 2004-11-22 21:38:44 +00:00
Nick Mathewson
805c9e3673 Absolutely never call close_temp_logs while validating log options. 
svn:r2934
 2004-11-22 20:08:07 +00:00
Roger Dingledine
4f2c2c9948 The crowning bugfix. 
The problem was that with high load, circuit package window was
reaching 0. Whenever we got a circuit-level sendme, we were
reading a lot on each socket, but only writing out a bit. So we
would eventually reach eof. This would be noticed and acted on
even when there are still bytes sitting in the inbuf.


svn:r2932
 2004-11-21 11:30:33 +00:00
Roger Dingledine
27b8797245 clean up some more. 
i think i'm getting closer.


svn:r2931
 2004-11-21 11:20:28 +00:00
Roger Dingledine
310a8da0d2 break reached_eof() out of process_inbuf() 
svn:r2930
 2004-11-21 10:14:57 +00:00
Roger Dingledine
671d84dc2f some more debugging aids 
svn:r2929
 2004-11-21 09:39:01 +00:00
Roger Dingledine
6a516dfdd3 be more greedy about filling up all relay cells. 
this may have some bugs in it still.
and it may end up not being what we want to do.


svn:r2928
 2004-11-21 07:43:12 +00:00
Nick Mathewson
bb18d4238f Dont keep rephist info for routers that havent had activity for 24 hours. 
svn:r2926
 2004-11-21 05:14:46 +00:00
Nick Mathewson
bdb61f2a04 fix typo 
svn:r2925
 2004-11-21 05:06:22 +00:00
Nick Mathewson
36f4e15e81 Call init_keys() where needed; fix hibernate bug. 
svn:r2924
 2004-11-21 04:19:04 +00:00
Nick Mathewson
bfc2e95230 Bump windows version 
svn:r2923
 2004-11-21 04:18:36 +00:00
Roger Dingledine
a4b1eb5630 allow StrictEntryNode and StrictExitNode to be singular 
svn:r2922
 2004-11-20 23:16:03 +00:00
Roger Dingledine
73da4bad46 stop some more seg faults 
svn:r2921
 2004-11-20 12:55:41 +00:00
Roger Dingledine
63353462f8 if your requested exit node has bandwidth 0, pick it anyway 
svn:r2920
 2004-11-20 12:41:05 +00:00
Roger Dingledine
d4ac7300d6 and a comment so i don't try to 'fix' it again later 
svn:r2919
 2004-11-20 12:17:19 +00:00
Roger Dingledine
246b14d8e9 yes, in fact, i broke it. putting back. 
svn:r2918
 2004-11-20 12:16:47 +00:00
Roger Dingledine
6322287dc1 printfs want carriage returns 
svn:r2917
 2004-11-20 08:00:57 +00:00
Roger Dingledine
dd19cf6ba3 kill -USR2 now moves all logs to loglevel debug 
plus fix some typos


svn:r2914
 2004-11-20 07:33:55 +00:00
Roger Dingledine
a30a5bce0f simplify close_temp_logs() 
(nick, did i break this?)


svn:r2913
 2004-11-20 07:08:00 +00:00
Roger Dingledine
a8840db4ac remove another possible sigpipe cause 
svn:r2912
 2004-11-20 06:52:13 +00:00
Nick Mathewson
8acaf8e187 Add "MEMUNIT" and "INTERVAL" types to configuration. Also tweak Accounting setup. More docs needed 
svn:r2911
 2004-11-20 00:37:00 +00:00
Roger Dingledine
2e4763655d bugfix: when our poll is interrupted, we believed the revents values. 
svn:r2907
 2004-11-17 20:26:39 +00:00
Nick Mathewson
647c076c8f add a TODO item and some comment changes. 
svn:r2904
 2004-11-16 03:32:01 +00:00
Roger Dingledine
3e4f30fbb9 bump us to 0.0.9pre6 
svn:r2902
 2004-11-16 03:29:09 +00:00
Roger Dingledine
abdf073f14 minor fixes 
svn:r2901
 2004-11-16 03:12:53 +00:00
Nick Mathewson
89a456a1d4 Fix a fun bug in read_all that was corrupting config files on windows, and probably doing other bad stuff too. 
svn:r2898
 2004-11-16 00:08:56 +00:00
Nick Mathewson
6143c515cd Make log_fn not fail so miserably on VC6 
svn:r2896
 2004-11-15 23:30:26 +00:00
Nick Mathewson
d63d5cb139 Whitespace normalization 
svn:r2895
 2004-11-15 23:29:24 +00:00
Nick Mathewson
5b668d8557 ugly macros to make log_fn play nice on non-GCC compilers. 
svn:r2894
 2004-11-15 21:18:07 +00:00
Nick Mathewson
7a8ac5dfef Tweak on patch to make authoritative directory servers cache 
directories on disk.  Make authdirservers cache *their own*
directories instead of the ones they download.  This gives better
liveness, and marginally better resistance to broken authdirservers.

Authdirservers don't cache running-routers at all: r-r isn't stored to
disk, so there's no point right now.


svn:r2893
 2004-11-15 16:17:59 +00:00
Roger Dingledine
dbd4dadff7 Authoritative dirservers now also cache the directory, since 
they weren't writing anything into their datadirectory, so
when they stop and start, they would know nothing until they
fetched a directory from another authdirserver.


svn:r2891
 2004-11-15 09:38:17 +00:00
Roger Dingledine
50c15943a2 move second stat to a cleaner place 
svn:r2890
 2004-11-15 09:22:01 +00:00
Roger Dingledine
4b76fe8036 Break DirFetchPostPeriod into: 
- DirFetchPeriod for fetching full directory,
  - StatusFetchPeriod for fetching running-routers,
  - DirPostPeriod for posting server descriptor,
  - RendPostPeriod for posting hidden service descriptors.

Also make sure the hidden service descriptors are at a random
offset from each other, to hinder linkability.


svn:r2889
 2004-11-15 09:05:54 +00:00
Roger Dingledine
67aa3b66c5 clean up socks handling, refuse connections to port 0 
svn:r2888
 2004-11-15 07:50:15 +00:00
Roger Dingledine
72dd656b88 a first cut at a print_usage() 
svn:r2887
 2004-11-15 07:29:27 +00:00
Nick Mathewson
c909a8a64b Only record bandwidth usage when accounting is enabled 
svn:r2886
 2004-11-15 04:48:53 +00:00
Nick Mathewson
930464c889 Change "warn if unverified routers are very skewed" to "never warn about unverified router skew" 
svn:r2885
 2004-11-15 04:28:24 +00:00
Nick Mathewson
22a0d82749 Cache running-routers; compress running-routers; serve compressed running-routers.z 
svn:r2883
 2004-11-15 04:04:20 +00:00
Nick Mathewson
076f120951 Patch to patch: do not send both error and done for one command. 
svn:r2882
 2004-11-15 04:02:59 +00:00
Roger Dingledine
ee591be3f2 fix a bug in configuring accounting in options_act() 
svn:r2881
 2004-11-15 04:01:31 +00:00
Roger Dingledine
47993ae6fb some fixes so far 
svn:r2880
 2004-11-15 03:53:03 +00:00
Nick Mathewson
5109159ff9 Fix compilation. Duh. 
svn:r2876
 2004-11-14 22:53:51 +00:00
Nick Mathewson
3e6edf20cc Resolve some hibernating-related XXXX009s. 
svn:r2875
 2004-11-14 22:21:23 +00:00
Nick Mathewson
402c75fb06 Allow more clock skew from unrecognized hosts than from recognized ones. 
svn:r2874
 2004-11-14 22:08:25 +00:00
Nick Mathewson
ffe9b01ad7 Split X509 certificate liveness checks into a separate function 
svn:r2873
 2004-11-14 22:07:48 +00:00
Nick Mathewson
57536f138a Fetch running-routers. 
Split logic to initiate dirfetch, running-routers fetch, and
descriptor post.  arma: There are some XXXs here that raise design
questions which we should solve before the next release.

The biggest problem is this: Right now, the directory is about 50X as
large as running-routers uncompressed, and about 36X as large
compressed.  Assuming:

    - everybody gets the compressed version of everything,

    - everybody gets cached directories from random dirservers and
      uncached r-r from authdirservers

    - everybody downloads r-r at the same rate they now download dirs,

then using r-r from will *increase* authdirserver directory bandwidth usage
if there are significantly more caches than authdirservers.

I think it's safe to leave this in for now, since there aren't 3x36 caching
dirservers, but we should make everybody with a dirport cache running-routers
soon.  But I could be wrong.


svn:r2872
 2004-11-14 21:46:40 +00:00
Nick Mathewson
2078b136f6 Make running-routers fetch (apparently) work 
svn:r2871
 2004-11-14 21:35:30 +00:00
Nick Mathewson
bb80d60fe7 Hibernate if we start tor during the "wait for wakeup-time" phase of an accounting interval. Log our hibernation plans better. 
svn:r2869
 2004-11-14 21:11:06 +00:00
Nick Mathewson
a732727a2b Add simpler option_is_same, as suggested by arma. Finish implementing SAVECONF 
svn:r2868
 2004-11-14 20:51:28 +00:00
Nick Mathewson
270b942edf Note where torrc goes. 
svn:r2865
 2004-11-14 19:08:08 +00:00
Nick Mathewson
26973578bf Fix windows whitespace 
svn:r2860
 2004-11-14 18:21:17 +00:00
Nick Mathewson
aba71028be Add an unreachable return 0. 
svn:r2859
 2004-11-14 18:20:12 +00:00
Nick Mathewson
05d5996410 Fix cast warning in tor-resolve.c 
svn:r2857
 2004-11-14 18:14:15 +00:00
Nick Mathewson
4f835673be Remove redundant declaration 
svn:r2855
 2004-11-14 17:22:10 +00:00
Nick Mathewson
783bbcf471 Fix "implicit declaration of ftello" warning: add AC_FUNC_FSEEKO in configure.in and always include orconfig.h before anything else 
svn:r2854
 2004-11-14 17:21:32 +00:00
Roger Dingledine
846f71dcca make kill -USR1 work again 
svn:r2853
 2004-11-14 13:35:47 +00:00
Roger Dingledine
5dcc6fd8b2 ok ok the stat wasn't redundant 
but the warn was


svn:r2852
 2004-11-14 13:35:39 +00:00
Roger Dingledine
14c7ad409f remove redundant stdio.h 
i guess that wasn't the fix


svn:r2849
 2004-11-14 09:49:27 +00:00
Roger Dingledine
bd4d99b3fe clean up the ftello call a little bit. 
but i'm still getting:
log.c:94: warning: implicit declaration of function `ftello'


svn:r2848
 2004-11-14 09:48:54 +00:00
Roger Dingledine
4564367b2a Remove redundant stat() for reading cached directory, and remove 
confusing warn when the cached directory isn't there yet.


svn:r2847
 2004-11-14 09:40:07 +00:00
Roger Dingledine
3f5c113815 clean a comment 
svn:r2844
 2004-11-14 04:55:02 +00:00
Nick Mathewson
ed4fa18699 normalize whitespace 
svn:r2839
 2004-11-13 23:34:01 +00:00
Nick Mathewson
ae7821bd88 Bump windows version 
svn:r2838
 2004-11-13 23:28:16 +00:00
Nick Mathewson
aab929abe0 Use the data, *then* free it. It works so much better. 
svn:r2837
 2004-11-13 23:27:50 +00:00
Nick Mathewson
dc48e7aeed Document remaining configuration options; add a ccheck for redundant authentication mechanisms in options_validate; add TODO items for post-009 hibernation features 
svn:r2833
 2004-11-13 17:17:04 +00:00
Nick Mathewson
08627d5d87 Track whether descriptor is dirty/uploaded. When any options are set, mark it dirty. Once a minute, regenerate and upload the server descriptor if it is dirty. 
svn:r2832
 2004-11-13 16:53:48 +00:00
Nick Mathewson
0b42e31fe0 Comment a confusing conditional 
svn:r2828
 2004-11-13 02:54:30 +00:00
Roger Dingledine
5864f4ac01 fix a seg fault when fetching rendezvous descs 
svn:r2825
 2004-11-12 21:59:27 +00:00
Nick Mathewson
a3788d5c9d Fix argument to strncpy. 
svn:r2824
 2004-11-12 21:14:51 +00:00
Nick Mathewson
a8f9ba91db Nobody was using the return values from smartlist_(set|del|del_keeporder), so remove them. 
svn:r2823
 2004-11-12 21:14:06 +00:00
Nick Mathewson
238a895e69 Add a FAST_SMARTLIST define to optionally inline smartlist_get and smartlist_len, which are two major profiling offenders. 
svn:r2822
 2004-11-12 20:41:52 +00:00
Nick Mathewson
c466b7e72f Speed up tor_strndup a lot: profiling suggests that our use of strlcpy here was a bad idea. 
svn:r2821
 2004-11-12 20:41:03 +00:00
Nick Mathewson
eabcf6618e Write most of the implementation for SAVECONF. 
svn:r2820
 2004-11-12 20:09:54 +00:00
Nick Mathewson
5109de5626 Rename exit_policy to addr_policy, since it gets used for SOCKS and directory connections too. Make all policies get validated in options_validate, and make SOCKS/directory policies get set in options_act. 
svn:r2819
 2004-11-12 19:39:13 +00:00
Peter Palfrader
a1e7ad4855 Fix two comments in torrc.sample.in directly in the upstream source 
svn:r2812
 2004-11-12 17:04:42 +00:00
Nick Mathewson
60880cda84 Resolve a bunch of FIXME items; mark a lot more for attention; ask for clarification on some. Turn all XXXX008 ("showstopper for 0.0.8 release") items into XXXX009 or XXXX, since plainly they were not showstoppers for 0.0.8. Add/clean some docs. 
svn:r2808
 2004-11-12 16:39:03 +00:00
Nick Mathewson
2a5bcb29e6 Resolve FIXME: Possible solution to note_disconnect problem; needs thought and review. 
svn:r2807
 2004-11-12 05:52:19 +00:00
Nick Mathewson
5d92fbe30e Use autoconf to enable largefile support where necessary. Use ftello where available, since ftell can fail at 2GB. 
svn:r2806
 2004-11-12 05:05:41 +00:00
Nick Mathewson
0faab62cd9 Resolve FIXMES: sometimes an error code is just an error code 
svn:r2805
 2004-11-12 05:03:50 +00:00
Roger Dingledine
90e0ad517e dfc caught a SIGXFSZ error when his debugfile reached 2GB. 
so if they exist, catch them and ignore them.
write() will fail normally and we'll look at errno like
normal human beings.


svn:r2804
 2004-11-12 04:59:37 +00:00
Roger Dingledine
c106ab8315 clean torrc sample 
change log files to end in .log for logrotate to notice
mention that address doesn't need to be defined


svn:r2803
 2004-11-12 04:00:07 +00:00
Roger Dingledine
fde595feb7 when clients do --list-fingerprint, it's misleading to 
give them one, because it will never be the same again


svn:r2800
 2004-11-11 13:24:10 +00:00
Nick Mathewson
6252cba522 apply patch from Andre Eisenbach: include event code with events, as required by control-spec.txt 
svn:r2799
 2004-11-11 00:54:53 +00:00
Nick Mathewson
e69d9647ed Remove XXXX009 comment telling us to do the last (circID-related) fix 
svn:r2798
 2004-11-10 20:19:45 +00:00
Nick Mathewson
954570486f Resolve a FIXME: use identity comparison, not nickname comparison, to 
choose circuit ID types.  This is important because our view of "the
nickname of the router on the other side of this connection" is
skewed, and depends on whether we think the other rotuer is
verified--and there's no way to know whether another router thinks you
are verified.

For backward compatibility, we notice when the other router chooses
the same circuit ID type as us (because it's running an old version),
and switch our type to be polite.


svn:r2797
 2004-11-10 20:14:37 +00:00
Nick Mathewson
ec49905fb8 When we think we have no bandwidth, guess that we will run for 1 day. 
svn:r2795
 2004-11-10 19:32:44 +00:00
Nick Mathewson
9c22b428bf Clarify a warning about /.tor 
svn:r2794
 2004-11-10 14:29:18 +00:00
Nick Mathewson
a43db78e8d Resolve FIXME items: make the kill-unattached-AP timeout symbolic 
svn:r2793
 2004-11-10 14:28:47 +00:00
Nick Mathewson
c9af37d1ba Resolve FIXME items: make circuit_free_cpath_node static 
svn:r2792
 2004-11-10 14:28:04 +00:00
Nick Mathewson
fde4129ac3 Resolve FIXME items: clarify two XXXX comments for 009 
svn:r2791
 2004-11-10 14:27:26 +00:00
Nick Mathewson
aa1c0c4d67 Resolve FIXME items: fix assert failure on malformed socks4a qreuests. (bug reported by Anna Shubina wrt old Netscapes) 
svn:r2790
 2004-11-10 14:26:34 +00:00
Nick Mathewson
8de9cfe184 Resolve FIXME items: make expand_filename handle ~ and ~username 
svn:r2789
 2004-11-10 14:23:31 +00:00
Roger Dingledine
987cb2b93a when you cast MAX_UINT to an int it confuses the users 
svn:r2788
 2004-11-10 09:09:15 +00:00
Nick Mathewson
c1bf171ed8 Fix a few bugs in accounting: parse bw_accounting correctly; set end time of continued interval; record used bandwidth on state change. 
svn:r2785
 2004-11-10 04:19:53 +00:00
Roger Dingledine
646903542a make nick's config patch build 
svn:r2783
 2004-11-10 03:48:38 +00:00
Nick Mathewson
1013abd27f Validate log options during options_validate(). Reject unrecognized log types like "Log notice magic-twanger". Also, make sure User and Group stay the same, and do not crash when somebody tries to change PidFile to NULL. 
svn:r2778
 2004-11-10 03:40:30 +00:00
Roger Dingledine
af9683501c make abbreviations case-insensitive (thanks weasel) 
svn:r2773
 2004-11-10 03:22:49 +00:00
Roger Dingledine
d9a74cd0af make it more obvious that we have just told them their new torrc log line. 
svn:r2772
 2004-11-10 03:08:03 +00:00
Roger Dingledine
c03a3eaed0 weaken our anonymity warning a little bit more 
svn:r2771
 2004-11-10 02:58:27 +00:00
Nick Mathewson
4cdddcc13d Remvove an XXX 
svn:r2769
 2004-11-10 02:02:06 +00:00
Roger Dingledine
ab951fc828 remove extraneous variable 
svn:r2765
 2004-11-10 00:19:18 +00:00
Roger Dingledine
c41c469166 don't ship with the default dirservers listed explicitly. leave them 
unlisted so we can change the default later.


svn:r2762
 2004-11-10 00:14:02 +00:00
Roger Dingledine
7528e8b86a don't check permissions on our datadirectory until we switch uid/gid 
svn:r2759
 2004-11-10 00:11:37 +00:00
Nick Mathewson
5a5be93f80 Normalize whitespace; add a "tell me about all the unnormalized whitespace" target; fix a braino in dirserv.c 
svn:r2758
 2004-11-09 20:04:00 +00:00
Nick Mathewson
d9d053d70b Clean windows a little 
svn:r2757
 2004-11-09 19:30:50 +00:00
Nick Mathewson
7daab4034d Fix windows build for VC6; centralize newline-fiasco-damage-control logic 
svn:r2756
 2004-11-09 19:13:08 +00:00
Nick Mathewson
cd753df7bf Resolve many XXXs and all DOCDOCs 
svn:r2755
 2004-11-09 18:22:17 +00:00
Nick Mathewson
b960574556 Change interface to config_trial_assign even more; have it use get_options() instead 
svn:r2754
 2004-11-09 17:15:17 +00:00
Nick Mathewson
a2079c074f Add some documentation to routerlist 
svn:r2753
 2004-11-09 17:14:15 +00:00
Nick Mathewson
548d4174ef When listing router status, include ourself if we are awake 
svn:r2752
 2004-11-09 17:12:56 +00:00
Roger Dingledine
3ce3d6eead resolve a 64-bit warning 
svn:r2750
 2004-11-09 11:36:38 +00:00
Roger Dingledine
ca070e7de6 bugfix: ^c ought to work even while hibernating 
svn:r2748
 2004-11-09 11:14:34 +00:00
Roger Dingledine
b773045a58 only non-authdirservers cache the dir they just fetched 
svn:r2747
 2004-11-09 10:38:42 +00:00
Roger Dingledine
3235c72f6c control event logs include loglevel notice 
svn:r2746
 2004-11-09 10:32:02 +00:00
Roger Dingledine
a972589bdb allow BandwidthRate and Burst to be abbrevs in the torrc too 
svn:r2744
 2004-11-09 10:30:06 +00:00
Roger Dingledine
8d8d6b5661 raise your hand if you can spell 
svn:r2743
 2004-11-09 10:21:19 +00:00
Roger Dingledine
233f516d61 if you're going to ask it to use a body of length 0, 
don't give it a body.


svn:r2742
 2004-11-09 10:18:41 +00:00
Roger Dingledine
dd3a12c929 fix a memory-squashing bug that was causing an infinite loop 
svn:r2741
 2004-11-09 10:08:42 +00:00
Roger Dingledine
6a504efdd3 mark_logs_temp() before init'ing new ones. 
we were seeing double, triple, etc each time we setconf'ed.


svn:r2738
 2004-11-09 08:01:39 +00:00
Roger Dingledine
3901473bf3 change the interface to config_trial_assign() 
svn:r2737
 2004-11-09 07:55:48 +00:00
Roger Dingledine
2d18d9eefb when you try a new set of options, and you like them, make sure they stick 
svn:r2736
 2004-11-09 07:45:24 +00:00
Roger Dingledine
9f3e3d2b71 stop wanting to split init_keys() 
svn:r2735
 2004-11-09 07:29:05 +00:00
Roger Dingledine
cad26b343d once normalized, DataDirectory is always defined 
svn:r2734
 2004-11-09 07:20:21 +00:00
Nick Mathewson
180e0a9326 Make check_private_dir trimodal (check/create/ignore), not bimodal (create/ignore). 
svn:r2733
 2004-11-09 07:12:31 +00:00
Roger Dingledine
6521c2ce51 Stop using the wrong DataDirectory when we're validating. 
Also validate/normalize the DataDirectory better.


svn:r2732
 2004-11-09 07:05:53 +00:00
Nick Mathewson
48a0b6c476 Separate is-recognized-option from get-option-value, since NULL is ambiguous and returning "" misrepresents. 
svn:r2731
 2004-11-09 06:40:32 +00:00
Roger Dingledine
005b02fd57 when rejecting an old-style router descriptor, tell us its nickname 
svn:r2730
 2004-11-09 06:37:58 +00:00
Roger Dingledine
677124fd0c During options_dup, don't copy LINELIST_S or OBSOLETE options. 
And recognize obsolete options now in config_get_assigned_option().


svn:r2729
 2004-11-09 06:18:17 +00:00
Roger Dingledine
94b9525f6e EntryNodess is not the plural of EntryNodes 
svn:r2728
 2004-11-09 06:09:06 +00:00
Roger Dingledine
3c6b6a53a9 and another 
svn:r2727
 2004-11-09 06:03:20 +00:00
Roger Dingledine
5c2278aea8 fix some dereferences 
svn:r2726
 2004-11-09 05:59:22 +00:00
Roger Dingledine
ef6bdd6c1e make datadirectory work again 
svn:r2724
 2004-11-09 05:35:49 +00:00
Roger Dingledine
6b22360eb8 fix mistake in comments 
svn:r2723
 2004-11-09 05:30:48 +00:00
Nick Mathewson
2677395aaf Normalize DataDirectory in options_validate, making SIGHUP survivable. 
svn:r2722
 2004-11-09 05:26:49 +00:00
Nick Mathewson
a5903b737a Document accounting 
svn:r2721
 2004-11-09 05:18:15 +00:00
Nick Mathewson
929b172955 Stop DataDirectory from changing; also stop using new as an identifier? 
svn:r2717
 2004-11-09 04:46:24 +00:00
Roger Dingledine
90b47172bd Make an options_act() where we do all the things a new options set 
needs.
Still needs more work.


svn:r2716
 2004-11-09 04:28:18 +00:00
Roger Dingledine
3805221262 stop breaking the get_options() abstraction in config.c 
svn:r2715
 2004-11-09 02:12:55 +00:00
Roger Dingledine
e3a067c73a fix comments in hibernate.c 
svn:r2714
 2004-11-09 02:12:41 +00:00
Roger Dingledine
8c7b2ff7ed various fixes 
svn:r2712
 2004-11-09 01:24:10 +00:00
Nick Mathewson
cb5de85585 Separate validate from activate. Document undocumented stuff in config.c. 
svn:r2711
 2004-11-08 23:12:40 +00:00
Roger Dingledine
8b9d7da59f while we hibernate, our declared bandwidth capacity is 0 
svn:r2710
 2004-11-07 23:19:12 +00:00
Nick Mathewson
2640be28fa Document hibernate.c. Also fix handling of corner case where we hit the end of the interval while we are in HIBERNATE_STATE_LOWBANDWIDTH 
svn:r2709
 2004-11-07 23:14:47 +00:00
Nick Mathewson
fc9c6e7c95 Fix compile errors 
svn:r2708
 2004-11-07 23:11:29 +00:00
Nick Mathewson
f9c85c4d1c Make set-option functions distinguish between bad keys and bad values, in case the caller cares 
svn:r2707
 2004-11-07 22:59:30 +00:00
Nick Mathewson
c514a06663 Fix up error codes 
svn:r2706
 2004-11-07 22:58:35 +00:00
Nick Mathewson
0059ee5fea More tests for split 
svn:r2705
 2004-11-07 22:58:16 +00:00
Roger Dingledine
dac5d6715e add saveconf control command. 
allow authentication by localhost, but if tor demands more, require more.


svn:r2704
 2004-11-07 22:37:59 +00:00
Nick Mathewson
66779137bf Add missing dereference; stop throwing zeroes around. 
svn:r2702
 2004-11-07 22:18:00 +00:00
Nick Mathewson
2cacb4e0f9 Document control.c 
svn:r2700
 2004-11-07 21:37:50 +00:00
Roger Dingledine
3236ee3127 allow unauth control connections for now 
let control connections recognize eof


svn:r2699
 2004-11-07 11:33:04 +00:00
Roger Dingledine
394554cfbf Clean up copyrights. 
Break connection_consider_empty_buckets() out of
connection_read_bucket_decrement().


svn:r2698
 2004-11-07 01:33:06 +00:00
Roger Dingledine
efad93feb4 tor --list-fingerprint as a client shouldn't try to print null 
svn:r2697
 2004-11-06 09:22:08 +00:00
Roger Dingledine
53a2b22742 fix the next subtle memory-crunching bug 
now hup works


svn:r2696
 2004-11-06 08:55:22 +00:00
Roger Dingledine
e2e6d19e76 fix subtle bug that was causing logs to not show anything 
svn:r2695
 2004-11-06 07:40:20 +00:00
Roger Dingledine
28a297ebe7 only play the accounting game if it's possible you'll choose to hibernate 
svn:r2694
 2004-11-06 06:56:28 +00:00
Roger Dingledine
865f341708 parse_line_from_file is obsolete. 
svn:r2693
 2004-11-06 05:18:29 +00:00
Roger Dingledine
6c61ed4fb5 Make options no longer a global variable. 
Now we can try setting an option but back out if it fails to parse, or
  if it's disallowed (e.g. changing RunAsDaemon from 1 to 0).
Use parse_line_from_str rather than parse_line_from_file.


svn:r2692
 2004-11-06 05:18:11 +00:00
Nick Mathewson
f490e5cdb6 Update log documentation 
svn:r2691
 2004-11-05 21:22:38 +00:00
Nick Mathewson
7c0792d89a Write hibernation code. Needs docs and tests. 
svn:r2689
 2004-11-05 17:55:34 +00:00
Nick Mathewson
38ed0ce5e6 Unify tor_parse_(numeric); make sure MAX_UINT32 and MAX_UINT64 are defined 
svn:r2688
 2004-11-05 17:54:50 +00:00
Roger Dingledine
0c583a6cf2 clarify it even better 
svn:r2687
 2004-11-05 11:58:34 +00:00
Roger Dingledine
0ab8b8a4e4 resolve misleading torrc comments 
svn:r2686
 2004-11-05 11:55:35 +00:00
Nick Mathewson
2e8353e2f4 Use new log format; convert old format to new format. 
svn:r2684
 2004-11-05 05:50:35 +00:00
Roger Dingledine
2ba3a9de16 make the default default options.FirewallPorts be the default 
svn:r2683
 2004-11-04 23:39:57 +00:00
Nick Mathewson
b56ef496d9 Twiddle header order to compile on OS X again 
svn:r2681
 2004-11-04 22:33:20 +00:00
Nick Mathewson
19868fe968 Move accounting code into hibernate; start adding logic to track bandwidth-per-seconds-active 
svn:r2680
 2004-11-04 22:33:06 +00:00
Nick Mathewson
1b49198081 Support code for resettable options, and option sets. Still needs validate-and-then-replace logic 
svn:r2679
 2004-11-04 22:31:50 +00:00
Nick Mathewson
d9e0f3f9bc Make sure control command bodies are always followed by a NUL 
svn:r2678
 2004-11-04 22:30:49 +00:00
Nick Mathewson
9d604ec615 Add code to read configuration lines from a string as well as a file 
svn:r2676
 2004-11-04 22:29:45 +00:00
Nick Mathewson
831c988ea1 fix problems introduced by rpm spec patch. 
svn:r2675
 2004-11-04 15:34:04 +00:00
Nick Mathewson
69e5e8d0ad Merge RPM spec patch from jbash 
svn:r2674
 2004-11-04 15:17:22 +00:00
Roger Dingledine
f7a30fa73e break out validate_options 
leave options.FirewallPorts NULL if it's NULL


svn:r2673
 2004-11-04 10:23:30 +00:00
Roger Dingledine
cadbae6aa5 make free_options() and init_options() use the big array. 
also remove obsolete config_assign_defaults().


svn:r2672
 2004-11-04 08:26:34 +00:00
Roger Dingledine
59453ac6ef add a ControlPort and control listener conn. 
note that print_usage is obsolete.


svn:r2671
 2004-11-04 06:41:49 +00:00
Nick Mathewson
b74b72a5ce Fix windows build 
svn:r2670
 2004-11-04 04:01:19 +00:00
Roger Dingledine
d0c158c8d6 clarify the bandwidthburst and bandwidthrate are in bytes 
(niels had thought they were in bits, or kb, or something)


svn:r2669
 2004-11-04 03:25:43 +00:00
Roger Dingledine
a4753283dd better interface for connection_ap_handshake_socks_reply() 
make --list-fingerprint print the fingerprint again


svn:r2668
 2004-11-03 23:13:28 +00:00
Nick Mathewson
5b312541d7 fix windows warnings 
svn:r2667
 2004-11-03 21:53:54 +00:00
Nick Mathewson
70f7e32ec6 fix typos 
svn:r2666
 2004-11-03 21:53:12 +00:00
Nick Mathewson
cea9125d71 Implement two flavors of authentication for control connections: one for trusted FS, one for untrusted FS. 
svn:r2664
 2004-11-03 19:49:03 +00:00
Nick Mathewson
871bf904ae Remove extraneous local 
svn:r2663
 2004-11-03 19:15:38 +00:00
Nick Mathewson
d5244e3872 Add a write_bytes_to_file so we can have files with NULs in them. 
svn:r2662
 2004-11-03 19:02:48 +00:00
Nick Mathewson
451f8b5045 - Implement all of control interface except authentication, setconfig, 
and actually making the sockets.
- Make sure that identity-based nicknames start with $.
- Use new string_join interface.


svn:r2661
 2004-11-03 18:33:07 +00:00
Nick Mathewson
86ba00290b Add function to generate/copy the config_lines, given the name of an option 
svn:r2660
 2004-11-03 18:29:29 +00:00
Nick Mathewson
11de62aa60 Add a slightly trickier string-join interface for making NUL-terminated string messages 
svn:r2659
 2004-11-03 18:28:00 +00:00
Nick Mathewson
11979dc1f5 Add a callback log handler type 
svn:r2658
 2004-11-03 18:27:19 +00:00
Nick Mathewson
4fdaa5de51 Streamline the two redundant "Has the second rolled over?" checks in prepare_for_poll and connection_bucket_refill; also, generate BANDWIDTH control events 
svn:r2657
 2004-11-03 16:38:04 +00:00
Roger Dingledine
12e92eb82f connection_read_bucket_decrement() has a side-effect that 
we need to get even if we just read 0 bytes


svn:r2656
 2004-11-03 10:18:31 +00:00
Roger Dingledine
e541319dcb lay the groundwork for a default value for each config option. 
tolerate null exitnodes, entrynodes, etc config options.


svn:r2655
 2004-11-03 10:08:44 +00:00
Roger Dingledine
e761cc9750 my assert.h takes extra pains to be certain to _re-include_ 
itself if you include it twice. this is dumb, but hey.


svn:r2653
 2004-11-03 07:29:03 +00:00
Nick Mathewson
347d3f9d62 Start implementing control interface. 
svn:r2652
 2004-11-03 01:32:26 +00:00
Nick Mathewson
d63d420930 Fix another typo 
svn:r2651
 2004-11-03 01:31:42 +00:00
Nick Mathewson
3e16515343 The spelling is "d-e-f-i-n-e". 
svn:r2650
 2004-11-03 00:02:17 +00:00
Nick Mathewson
8db0abb687 First attempt at hibernation code. It needs more work around the XXXXs, but first I want arma to review the basic approach while I meditate on how to fix them. 
svn:r2649
 2004-11-02 23:47:32 +00:00
Nick Mathewson
a2f6210b3e Add compatibility macros for printf and scanf-ing 64-bit unsigned ints 
svn:r2648
 2004-11-02 22:14:34 +00:00
Nick Mathewson
67f14032b1 Handle strlcat/strlcpy correctly on platforms that have them. 
svn:r2647
 2004-11-02 19:25:52 +00:00
Nick Mathewson
509c0bdc22 untabify. This should hold it. 
svn:r2646
 2004-11-02 03:11:01 +00:00
Nick Mathewson
ad4dc74482 Use a stricter set of warnings; make them all pass. 
svn:r2645
 2004-11-02 03:02:17 +00:00
Roger Dingledine
85c79ffbc7 canonicalize "src" and "dest" arg order in crypto.c (and others) 
svn:r2644
 2004-11-02 02:28:51 +00:00
Nick Mathewson
1433a0b26f Fix signed/unsigned comparison warning 
svn:r2643
 2004-11-01 22:41:32 +00:00
Roger Dingledine
037fba7595 util.c needs ctype.h for tolower and isspace 
svn:r2642
 2004-11-01 21:54:12 +00:00
Roger Dingledine
b390786582 Hidden service operators had a bug in version 1 style INTRODUCE cells 
that made them fail. Fix the bug, and revert clients to use version 0
until 0.0.9pre4 is obsolete.


svn:r2641
 2004-11-01 21:46:27 +00:00
Nick Mathewson
ce79bab7f1 Split util into util (general utilities), container (smartlist and strmap), and compat (cross-platform compatability). 
svn:r2640
 2004-11-01 20:41:47 +00:00
Roger Dingledine
4689243242 make sure options.MaxConn can be reached 
svn:r2638
 2004-11-01 08:24:34 +00:00
Roger Dingledine
282816b498 change min required number of fd's to 1024 
svn:r2636
 2004-11-01 08:09:59 +00:00
Roger Dingledine
790349c645 oh, and add the actual file too 
svn:r2631
 2004-10-31 20:29:25 +00:00
Roger Dingledine
984ffec105 implement first piece of hibernation 
still need to track bandwidth, and make decisions based on bandwidth


svn:r2630
 2004-10-31 20:28:41 +00:00
Nick Mathewson
ae7495dd55 Only tor and test binaries need to link against openssl and zlib; tor-resolve can be smaller. 
svn:r2629
 2004-10-30 19:27:06 +00:00
Nick Mathewson
5bc0dba933 Move all util functions that need openssl into crypto.c; make non-openssl functions that util needs into util. Now openssl can be separated. 
svn:r2628
 2004-10-30 19:26:31 +00:00
Nick Mathewson
9510d9a792 tor --list-fingerprint to print fingerprint and exit 
svn:r2627
 2004-10-30 19:18:37 +00:00
Roger Dingledine
51e16233cb Fix paul gardner's assert bug. Turns out when circuit_launch_by_nickname() 
failed at the first hop, it would try to relaunch another circ right
then, even though the first circuit hadn't been populated yet with its
pending_final_cpath.


svn:r2624
 2004-10-30 05:04:52 +00:00
Nick Mathewson
5c68db8b3d Link tools directory into rest of build system 
svn:r2623
 2004-10-28 20:31:15 +00:00
Nick Mathewson
54b8f7e503 Add a pure-C tor-resolve implementation 
svn:r2620
 2004-10-28 20:28:13 +00:00
Nick Mathewson
11d330be5e Tweaks to prevent obsolete restarting tors from hammering the dirservers. (1) Cache a received directory as soon as the signature checks out. (2) Treat a cached directory as "recent" based on its mtime. (3) If we have a recent directory, we dont need to fetch a newer one for DirFetchPostPeriod. This needs review! 
svn:r2618
 2004-10-28 18:37:52 +00:00
Nick Mathewson
36bbab2f2b Fix in warning fix 
svn:r2617
 2004-10-27 21:54:44 +00:00
Nick Mathewson
f8771625c6 Check return of tor_snprintf 
svn:r2616
 2004-10-27 21:30:47 +00:00
Nick Mathewson
2fbf31533b Tricksy compiler warnings! We hates them, hates them forever, my precious! 
svn:r2615
 2004-10-27 21:14:11 +00:00
Nick Mathewson
ce5709184b Pass with -Wstrict-prototypes 
svn:r2614
 2004-10-27 18:16:37 +00:00
Nick Mathewson
6874c39904 Fix windows build 
svn:r2613
 2004-10-27 18:14:38 +00:00
Nick Mathewson
c5eb95b644 Add ability for some-but-not-all abbrevs to work in config file. Add a bunch of singular/plural abbrevs suggested by arma 
svn:r2612
 2004-10-27 17:37:01 +00:00
Roger Dingledine
75ad4615d1 stop freeing arbitrary memory 
fix a couple of memory leaks


svn:r2611
 2004-10-27 12:34:02 +00:00
Nick Mathewson
6980929e64 Use strlcpy, not strcpy. 
svn:r2610
 2004-10-27 06:48:16 +00:00
Nick Mathewson
44d4516155 Use tor_snprintf, not snprintf 
svn:r2609
 2004-10-27 06:37:34 +00:00
Nick Mathewson
22dc19b590 snprintf wrapper with consistant (though not C99) overflow behavior 
svn:r2606
 2004-10-27 06:26:23 +00:00
Nick Mathewson
06fa8fc05f Avoid strcat; use snprintf or strlcat instead 
svn:r2605
 2004-10-27 06:25:29 +00:00
Nick Mathewson
f67f83b1fa Use strlcpy, not strncpy 
svn:r2603
 2004-10-27 06:03:28 +00:00
Nick Mathewson
bc62f8e983 Replace sprintf with snprintf 
svn:r2602
 2004-10-27 05:53:07 +00:00
Nick Mathewson
5369ee921e Make it compile on Linux 
svn:r2600
 2004-10-27 03:42:09 +00:00
Nick Mathewson
8cefc861d6 Add cvsignore in win32 directory 
svn:r2599
 2004-10-27 03:38:42 +00:00
Nick Mathewson
482c309db9 Document new config code 
svn:r2596
 2004-10-27 03:08:04 +00:00
Nick Mathewson
a24eb4db91 Re-write configuration option lookup code: use a table, not a big if( || || || ||). Deprecate unoffical abbrevs and abbrevs not on the command line. 
svn:r2594
 2004-10-27 02:30:28 +00:00
Nick Mathewson
b90b2bb848 Add and document router-status line using new unified liveness/verifiedness format; continue to generate running-routers; continue to parse running-routers when no router-status line is found 
svn:r2592
 2004-10-27 00:48:51 +00:00
Nick Mathewson
26f3cb8652 Add SysLog option to direct log messages to the system log instead of a FILE*. 
svn:r2591
 2004-10-26 21:48:41 +00:00
Roger Dingledine
0113a643a2 quick-and-dirty dir policy since the dirservers are getting hammered 
nick, could you abstract this sometime so we don't repeat the
sockspolicy code twice?


svn:r2589
 2004-10-25 06:16:26 +00:00
Roger Dingledine
20cdc0a517 fix a memory leak 
svn:r2587
 2004-10-24 23:09:48 +00:00
Roger Dingledine
defe1e5f3c start generating new version of introduce1 cells 
svn:r2586
 2004-10-24 19:08:07 +00:00
Roger Dingledine
0b36c29c4d fix wrong comment 
svn:r2585
 2004-10-24 17:11:44 +00:00
Nick Mathewson
ef4ac65f5e Document the swiss-army-knife that retry_listeners has become 
svn:r2584
 2004-10-24 01:50:33 +00:00
Nick Mathewson
0df2d383d1 Many non-native speakers use Tor. It is our duty to ensure that our log messages set an example of good English spelling. 
svn:r2583
 2004-10-24 01:29:01 +00:00
Nick Mathewson
57f09573f5 Every 60 seconds, check whether the listeners are still alive, and relaunch the dead ones. 
svn:r2581
 2004-10-24 01:22:40 +00:00
Nick Mathewson
04ca660b2a Fix typo in last windows patch 
svn:r2580
 2004-10-24 00:58:29 +00:00
Nick Mathewson
5d53828c57 Handle more errnos from accept() without closing the connection. This may fix a bug that could close OR listeners when (a) TCP connections were hung up before accept() could be called, or (b) during FD exhaustion. 
svn:r2579
 2004-10-24 00:55:18 +00:00
Nick Mathewson
78a2c3aa39 Make windows fall back to CWD if SHGetSpecialFolderLocation is borked 
svn:r2578
 2004-10-24 00:52:10 +00:00
Roger Dingledine
54c432bd93 pay attention to the return value of do_hup, and exit 
when it fails


svn:r2577
 2004-10-23 17:06:25 +00:00
Roger Dingledine
9cc0c3620f ship src/win32/ in the tarball 
svn:r2576
 2004-10-21 00:49:17 +00:00
Nick Mathewson
6899b8001a Check for low _MSC_VER, not high. On windows, always use winsock. 
svn:r2575
 2004-10-20 23:30:38 +00:00
Roger Dingledine
c4c6ee7d61 add winsock if you've got it, regardless of whether you're msv 
svn:r2573
 2004-10-20 23:23:53 +00:00
Nick Mathewson
88cffc3c5f Use bitwise masking to turn off bits, not compare-and-subtract 
svn:r2572
 2004-10-20 23:15:49 +00:00
Roger Dingledine
c3a15d1c74 bcc win32 compiler has no timeval tv_sec 
svn:r2571
 2004-10-20 23:12:37 +00:00
Nick Mathewson
e5049d5aa3 Remove routerinfo_t->is_trusted_dir, and all the twisted machinery used to 
maintain it.

Have clients default to the nickname "client" in their certificates.

Give a less frightening warning on obsolete (pre-0.0.8) routerinfo_t's.


svn:r2568
 2004-10-19 18:19:59 +00:00
Nick Mathewson
62094ebd32 Tolerate NULL nicknames better 
svn:r2567
 2004-10-19 18:17:12 +00:00
Nick Mathewson
c7151d8bed Add "pass" target for RedirectExit, to make it easier to break out of a sequence of rules 
svn:r2566
 2004-10-19 17:46:06 +00:00
Roger Dingledine
97a0a43511 start the process of making 0.0.7* obsolete 
svn:r2565
 2004-10-17 21:51:20 +00:00
Roger Dingledine
640544ae3e use connection_edge_is_rendezvous_stream() more 
svn:r2564
 2004-10-17 21:10:41 +00:00
Roger Dingledine
695cdb10fe whoops, resolve cells were probably broken 
svn:r2562
 2004-10-17 20:31:19 +00:00
Nick Mathewson
b130aa3c8f Fix segfault in unit tests. (Main program is unaffected) 
svn:r2559
 2004-10-17 15:45:54 +00:00
Roger Dingledine
e66d5f897a fix a seg fault with exitredirect 
svn:r2555
 2004-10-17 04:44:02 +00:00
Roger Dingledine
560a4a1407 switch conn->addr and conn->dir_port to reflect the final destination, 
not the http proxy


svn:r2553
 2004-10-17 04:06:48 +00:00
Nick Mathewson
6d1e1b7f46 Unify windows special-dir handling 
svn:r2552
 2004-10-17 03:38:02 +00:00
Nick Mathewson
8d27385c23 Implement RedirectExit. 
svn:r2550
 2004-10-17 01:57:34 +00:00
Roger Dingledine
5efc49600a fix comment that makes no sense 
svn:r2549
 2004-10-16 23:18:58 +00:00
Roger Dingledine
7c3ab346f6 various tweaks and fixes 
svn:r2548
 2004-10-16 22:56:46 +00:00
Roger Dingledine
e9e9a25881 i take back everything i've said about unit tests 
svn:r2547
 2004-10-16 22:56:03 +00:00
Nick Mathewson
a1bf39f698 Code to parse (but not yet actually use) RedirectExit lines 
svn:r2546
 2004-10-16 22:37:08 +00:00
Roger Dingledine
6d873e5743 don't assert multiple things in the same tor_assert() 
svn:r2545
 2004-10-16 22:28:11 +00:00
Roger Dingledine
de65052312 don't assert multiple things in the same tor_assert() 
svn:r2544
 2004-10-16 22:14:52 +00:00
Nick Mathewson
25a046df74 Fix unit tests, make it compile 
svn:r2543
 2004-10-16 21:57:24 +00:00
Nick Mathewson
47dc024f7e Change interface of parse_addr_port() to return address in host order, since most users seem to want that. 
svn:r2542
 2004-10-16 21:53:30 +00:00
Nick Mathewson
8300c4ae6a Make unit tests pass; refactor most of exit policy parfsing out into new function 
svn:r2541
 2004-10-16 21:42:09 +00:00
Nick Mathewson
69d7b468b4 Refactor parse-addr-mask-and-port-range into a separate function 
svn:r2540
 2004-10-16 21:41:12 +00:00
Nick Mathewson
a42adce362 fix memory leak in router.c; start relying on NULL==(zero bytes) 
svn:r2538
 2004-10-16 20:38:57 +00:00
Nick Mathewson
f619c4603e Add an autoconf test to make sure that memset(&ptr, 0, sizeof(ptr)) and ptr=NULL are equivalent 
svn:r2536
 2004-10-16 20:26:12 +00:00
Nick Mathewson
56a592dbe3 Fix memory leak 
svn:r2535
 2004-10-16 08:39:56 +00:00
Nick Mathewson
9d5831341e Implement user-declared node families. 
svn:r2534
 2004-10-15 20:52:09 +00:00
Nick Mathewson
f882bd92ed Remove unused locals 
svn:r2533
 2004-10-15 20:50:43 +00:00
Nick Mathewson
f359389866 Oops; make sure that break; and continue; work within SMARTLIST_FOREACH 
svn:r2532
 2004-10-15 20:49:31 +00:00
Nick Mathewson
99f7955372 Use the real default exit policy, not reject *:* 
svn:r2531
 2004-10-15 19:18:08 +00:00
Nick Mathewson
fa9c121343 Add a comment 
svn:r2530
 2004-10-15 19:17:36 +00:00
Nick Mathewson
28dd458eaf Upload to trusted dir servers based on DirServer config options, not on routerinfos. 
svn:r2529
 2004-10-15 19:04:38 +00:00
Nick Mathewson
01eacbca9e Make RecommendedVersions a CONFIG_TYPE_LINELIST option, and have it tolerate whitespace a little better. 
svn:r2528
 2004-10-15 05:09:48 +00:00
Nick Mathewson
88e0c080cf Ignore fascistfirewall when dealing with service descriptors; obey fascistfirewall when posting server descriptors; ignore fascistfirewall on directory connections when httpproxy is set. 
svn:r2527
 2004-10-15 04:57:36 +00:00
Nick Mathewson
5e80944c52 Use token-pasting magic to make nested SMARTLIST_FOREACH work. 
svn:r2526
 2004-10-15 04:45:47 +00:00
Nick Mathewson
ff38cc06e1 Fix search-and-replace in comments: Friends->family does not imply friendship->familyhip. 
svn:r2525
 2004-10-15 03:55:53 +00:00
Nick Mathewson
2fb08fe46c add documentation for smartlist_join_strings 
svn:r2524
 2004-10-15 03:55:02 +00:00
Nick Mathewson
7fa5d224d4 Implement "families" of coadministered nodes; prevent them all from appearing on the same circuit. 
svn:r2523
 2004-10-15 01:58:11 +00:00
Nick Mathewson
c5964d6738 Basic string-join functionality 
svn:r2521
 2004-10-14 19:51:47 +00:00
Nick Mathewson
9e8e006c1e Update windows ver to 009pre3 
svn:r2519
 2004-10-14 15:42:13 +00:00
Nick Mathewson
0f144d6a04 fix warning on win32 
svn:r2518
 2004-10-14 15:41:41 +00:00
Roger Dingledine
56e151eb41 advertise moria2's dirport as 18.244.0.114:80 
svn:r2511
 2004-10-14 10:05:22 +00:00
Roger Dingledine
cf9664151d bugfix on a really old bug: 
if read() fails on a stream, send back an end cell before you
close it down.


svn:r2509
 2004-10-14 09:28:31 +00:00
Roger Dingledine
572714a458 bugfix: parse_addr_port() bites us again -- it returns addr in network order. 
svn:r2508
 2004-10-14 08:45:07 +00:00
Roger Dingledine
95644480c5 better warn message for the Content-Length attack 
svn:r2495
 2004-10-14 04:50:33 +00:00
Nick Mathewson
55b811a259 Improve warnings for old-style directories. 
svn:r2494
 2004-10-14 04:31:40 +00:00
Nick Mathewson
100b10473a fix tab/space in torgzip.h 
svn:r2493
 2004-10-14 04:31:16 +00:00
Nick Mathewson
a4ef916b8e fix tab/space in torgzip.c 
svn:r2492
 2004-10-14 04:24:42 +00:00
Nick Mathewson
08c33f0b46 Compile without warnings on windows 
svn:r2491
 2004-10-14 04:06:24 +00:00
Nick Mathewson
bd10bf4b5b Try to always dtrt if routerlist==NULL 
svn:r2489
 2004-10-14 03:44:45 +00:00
Roger Dingledine
89280e6c20 rename addr to address to we avoid this bug later 
svn:r2488
 2004-10-14 03:31:40 +00:00
Nick Mathewson
1c9426d6e0 Build without warnings on mac gcc 3.3 
svn:r2487
 2004-10-14 03:18:14 +00:00
Roger Dingledine
3737566465 make it build on amd64 
svn:r2486
 2004-10-14 03:13:08 +00:00
Roger Dingledine
892269bca3 reformat comment and fix typo 
svn:r2485
 2004-10-14 03:01:43 +00:00
Roger Dingledine
69830afc16 and another one 
svn:r2484
 2004-10-14 02:49:48 +00:00
Roger Dingledine
5f4a390b33 oh, and some more in common/ 
svn:r2483
 2004-10-14 02:48:57 +00:00
Roger Dingledine
aebc3a03ba more int to size_t conversions, fixing one or more amd64 bugs 
plus a whitespace patch on config.c from vicman


svn:r2482
 2004-10-14 02:47:09 +00:00
Nick Mathewson
92bb360ad7 Add missing line; add similar check 
svn:r2481
 2004-10-14 02:29:03 +00:00
Nick Mathewson
8b325c142e Patch from "J Doe": Use SHGetSpecialFolderLocation instead of 
SHGetSpecialFolderPath in order to find application data folder.

Apparently, until IE 4 (!?) came out, nobody realized that programmers
might like to get paths as strings.  Clearly, a fancy pseudo-OO list
of "identifiers" is a far more convenient way to deal with these
things.  And while we're being OO, why return object that you can free
with free()?  Instead, let's make the user get a handle to an abstract
allocation object, and ask it to free the fancy list, and then ask it
to release itself.  Won't that be fun and convenient?

Navigating ancient Win32 APIs is like bikini-waxing creatures from HP
Lovecraft: to do a good job you must understand what's going on... but
the understanding itself can blast your sanity.


svn:r2480
 2004-10-14 02:04:43 +00:00
Nick Mathewson
0d5a847f12 Remove need for dirservers file: now, we note trusted dirservers in configuration options, and only need to remember addr:port and key digest for each one. 
svn:r2479
 2004-10-14 01:44:32 +00:00
Nick Mathewson
55634e4eec Fix comment in dirserv.c 
svn:r2470
 2004-10-13 20:28:46 +00:00
Roger Dingledine
2b7b86f5e6 stop trying to print a NULL 
plus make router_nickname_is_approved() more obviously unused


svn:r2469
 2004-10-13 20:17:45 +00:00
Nick Mathewson
e0cce8fba8 Unify tests for "did I originate this nonopen OR connection?" 
svn:r2468
 2004-10-13 20:05:57 +00:00
Nick Mathewson
30dd1c87a5 Add default trusted-dir-server entries only when no dirserver lines are given in the config file 
svn:r2467
 2004-10-13 19:56:42 +00:00
Nick Mathewson
508970f85d fix typo 
svn:r2466
 2004-10-13 19:55:40 +00:00
Nick Mathewson
f14117bffd fix warning about always-false comparison; detect too-large realport better 
svn:r2465
 2004-10-13 19:53:34 +00:00
Nick Mathewson
149f57bdef answer question about rep_hist_note_connect_failed 
svn:r2464
 2004-10-13 19:42:36 +00:00
Nick Mathewson
afd8b650ee hex-to-hex compare makes more sense than hex-to-bin. 
svn:r2463
 2004-10-13 19:17:27 +00:00
Nick Mathewson
df3098367c Make directories get generated properly again; debug key lookup. Also, it is hard to find entries in a table when you never put them there. 
svn:r2462
 2004-10-13 18:28:39 +00:00
Roger Dingledine
918ce7a084 a few more ints to size_ts 
svn:r2461
 2004-10-13 05:54:58 +00:00
Roger Dingledine
a1041154eb fix const char * vs char * issue 
plus unshadow some variables


svn:r2460
 2004-10-13 04:44:37 +00:00
Nick Mathewson
9dc72de41f Omit any exit rules that follow a catch-all rule when writing a router descriptor. 
svn:r2459
 2004-10-13 01:25:42 +00:00
Nick Mathewson
9c49947163 Check fingerprint list before generating running-routers lists; also add as-yet-uncalled function to update an OR connection nickname on the fly 
svn:r2458
 2004-10-13 01:13:37 +00:00
Roger Dingledine
fe54bd00b9 ok, vim isn't the greatest editor in the world 
svn:r2457
 2004-10-12 20:28:53 +00:00
Roger Dingledine
0b4d3c4df7 parse HttpProxy address in config 
fix a potential confusion in fetch_from_buf_http()
make all our int config options non-negative
better bounds checking on options that are ports


svn:r2456
 2004-10-12 20:22:09 +00:00
Roger Dingledine
a7d858bd6e start the great migration from int to size_t 
and clean some deadweight from util.h


svn:r2455
 2004-10-12 20:20:19 +00:00
Nick Mathewson
7cc126e8a9 Appease overzealous gcc 
svn:r2454
 2004-10-12 20:17:45 +00:00
Nick Mathewson
f7404f6bb9 Use tor_parse_long in more places 
svn:r2453
 2004-10-12 19:33:03 +00:00
Nick Mathewson
19da1f36c2 Make a bounds-checking replacement for strtol with slightly easier error-checking in the common case 
svn:r2452
 2004-10-12 19:32:41 +00:00
Roger Dingledine
1c757b917d fix signed/unsigned comparison, plus typo 
svn:r2451
 2004-10-12 19:09:40 +00:00
Nick Mathewson
e7241044e8 Better bounds checking on parsed ints 
svn:r2450
 2004-10-12 19:01:53 +00:00
Nick Mathewson
e8748b3fa0 Add default directory servers 
svn:r2449
 2004-10-12 19:01:28 +00:00
Nick Mathewson
f6fc2b9dd2 Add fix for remote-crash bug. 
svn:r2447
 2004-10-12 18:38:36 +00:00
Roger Dingledine
578a3e25e5 fix a signed/unsigned comparison 
svn:r2446
 2004-10-12 18:32:34 +00:00
Nick Mathewson
79636823b8 Oops, missed one 
svn:r2445
 2004-10-12 16:04:25 +00:00
Nick Mathewson
a91fc48b39 Note byte-order on result for parse_addr_port() 
svn:r2444
 2004-10-12 16:02:15 +00:00
Nick Mathewson
0068415b80 Add an implementation of trusted_dir_server logic to switch towards simply remembering an addr/port/keyid for each trusted dir server 
svn:r2443
 2004-10-12 15:55:20 +00:00
Nick Mathewson
43ef5a3e37 Add long-term format for dir-signing-key fields (commented out) 
svn:r2442
 2004-10-12 15:52:57 +00:00
Nick Mathewson
0383afac9a Use parse_addr_port() function instead of ad-hoc variants 
svn:r2441
 2004-10-12 15:52:09 +00:00
Nick Mathewson
8b037509f3 Add functions to parse addr[:port] consistently 
svn:r2440
 2004-10-12 15:48:30 +00:00
Roger Dingledine
1efad74164 bugfix on my friday commit: make hidden services work again in cvs 
svn:r2439
 2004-10-12 06:03:10 +00:00
Roger Dingledine
24f9946db1 fix paul gardner's assert bug. 
sometimes circuit_get_open_circ_or_launch() can return 0 but not
return a circuit, e.g. because too many circuits have failed recently
so the new one didn't launch. we need to tolerate that.


svn:r2438
 2004-10-11 22:19:12 +00:00
Roger Dingledine
5c53c63aa0 Fix a potential buffer overflow found by Ilja van Sprundel. 
We don't think this is exploitable, but best to fix it anyway.


svn:r2437
 2004-10-11 21:55:19 +00:00
Roger Dingledine
7798e3d770 fix the stale pointer assert bug reported by joe magic 
svn:r2436
 2004-10-11 01:17:42 +00:00
Roger Dingledine
6468e049be when a begin cell has an invalid port, give us a better hint of 
what went wrong


svn:r2435
 2004-10-10 01:47:24 +00:00
Roger Dingledine
1a4cb248f3 interim commit for http proxy support 
svn:r2431
 2004-10-08 05:53:59 +00:00
Roger Dingledine
2bcd0f34f5 fix compile error: move variable declarations before code 
svn:r2430
 2004-10-08 05:43:28 +00:00
Nick Mathewson
6c970aec94 Turn tor_strpartion into a swiss-army-knife function, so it can terminate or not-terminate appropriately. 
svn:r2429
 2004-10-07 21:37:06 +00:00
Nick Mathewson
c7e8c2098a Include a dir-signing-key token in directories to tell the parsing entity which key is being used to sign. This is the first step in obsoleting the dirservers file. 
svn:r2428
 2004-10-07 21:10:40 +00:00
Nick Mathewson
7b98fb58eb More complete docs for crypto.c; factor out string partitioning code 
svn:r2427
 2004-10-07 20:58:53 +00:00
Nick Mathewson
dad7c71686 Workaround for bug on windows where cached-directories get crlf corruption. 
svn:r2426
 2004-10-07 20:22:58 +00:00
Nick Mathewson
3be0bf4b88 Bump windows version 
svn:r2425
 2004-10-07 20:22:03 +00:00
Nick Mathewson
b7bddcac75 Windows requires a different cast uint64_t format 
svn:r2424
 2004-10-07 20:15:56 +00:00
Nick Mathewson
ce3162d035 Make base-64-encoded DER work, including workaround for ugly openssl misfeature that makes base64 decoding fail when you strip out the newlines. 
svn:r2423
 2004-10-07 03:11:42 +00:00
Nick Mathewson
2bba65148b Refactor fingerprint handling: remember hex digests (no spaces) instead of beautified fingerprints 
svn:r2422
 2004-10-06 13:31:48 +00:00
Nick Mathewson
b08ff7b1f7 Fix a couple of typos, one of which conceals a bug in parsing opt keywords with objects 
svn:r2421
 2004-10-06 13:28:34 +00:00
Nick Mathewson
b56bb39ed6 Add a function to remove a set of characters from a string 
svn:r2420
 2004-10-06 13:26:37 +00:00
Nick Mathewson
8cca36d26a Implement (temporarily) a base64-encoded-DER format for RSA keys; make it easier to generate fingerprints with no space 
svn:r2419
 2004-10-06 13:26:10 +00:00
Roger Dingledine
8b02610bd5 when an OR starts up, it loads its directory from cache. 
then it serves *that directory* to others who ask for a copy of the
directory. it's better to serve no directory at all until you have a
fresh copy.


svn:r2418
 2004-10-06 05:05:43 +00:00
Roger Dingledine
980b6169eb use only 0.0.9pre1 and later servers for resolve cells 
svn:r2416
 2004-10-03 19:39:29 +00:00
Roger Dingledine
c205ad05ba better example lines for dirbindaddress and orbindaddress 
svn:r2415
 2004-10-03 19:37:48 +00:00
Nick Mathewson
9e8ae9766e Only check versions against downloaded directories, not cached directories. 
svn:r2413
 2004-10-03 02:37:52 +00:00
Roger Dingledine
5e74ce8d57 better warn message for failed hidserv desc fetch 
svn:r2412
 2004-10-03 00:06:47 +00:00
Roger Dingledine
3f4b544b77 use size_t rather than int for directory lengths in memory 
this might fix a bug with amd64


svn:r2410
 2004-10-01 21:02:12 +00:00
Nick Mathewson
91044765f2 Decode Content-Encoding header correctly. 
svn:r2403
 2004-10-01 04:45:14 +00:00
Roger Dingledine
eff780c815 Fix a rare assert trigger, where routerinfos for entries in our cpath 
would expire while we're building the path.
Thanks to Eugene Armstead for pointing it out.


svn:r2402
 2004-09-30 15:40:05 +00:00
Roger Dingledine
136d4e5739 prefer tor_free to free 
plus complain more loudly when we fail to parse a dir we just fetched


svn:r2401
 2004-09-29 06:52:36 +00:00
Roger Dingledine
6ed095b177 print the IP if a conn fails badly, to see if there are any trends 
svn:r2400
 2004-09-29 05:59:55 +00:00
Roger Dingledine
1c47de319e ha ha, thought the bugs were done 
don't stop writing the compressed directory just because you found a nul


svn:r2399
 2004-09-29 05:48:25 +00:00
Roger Dingledine
a31ba30ae6 if our local cached directory is new enough, go ahead and 
start building circuits while we're fetching a new one


svn:r2394
 2004-09-28 23:27:41 +00:00
Nick Mathewson
11384b6d92 Make sure that routerlists contain only routers; give a better error message if they start with a nonrouter. 
svn:r2393
 2004-09-28 22:49:34 +00:00
Nick Mathewson
0c653e5cc7 cached-directory has a directory, not a router list 
svn:r2392
 2004-09-28 22:43:11 +00:00
Roger Dingledine
4b3001a08c fix some local buffer overflows 
fix a memory leak


svn:r2391
 2004-09-28 22:38:21 +00:00
Nick Mathewson
7eff786e4b Fix messages for _UNRECOGNIZED tokens 
svn:r2390
 2004-09-28 22:35:02 +00:00
Nick Mathewson
d20d10f360 If we are an authoritative dirserver, check out the fingerprint list when setting connection nicknames 
svn:r2389
 2004-09-28 22:24:56 +00:00
Roger Dingledine
d381aa4696 Fix an evil bug: when we failed to write to our log, fputs() 
gave us a sigpipe, and we logged that we were ignoring it,
causing us to fail to log that, and delete the log entry. Then
when the signal handler exited, we proceeded to delete the log
entry that had already been deleted.

Now we make sure to only log inside our signal handler if we'll
be exit()ing right after.


svn:r2388
 2004-09-28 21:14:40 +00:00
Roger Dingledine
1e3b9e7d31 make the warn message better for reading short files 
svn:r2385
 2004-09-28 08:40:03 +00:00
Roger Dingledine
0d2f9b9b4b the tor clients in cvs can't speak to the current tor authdirservers for 
rendezvous publishes and fetches, since they're still running 0.0.8. so
make them speak the old way until we've upgraded the authdirservers.


svn:r2384
 2004-09-28 03:30:28 +00:00
Roger Dingledine
9f9f0e5edd fix another bug with cached compressed directories 
still not working


svn:r2383
 2004-09-27 07:28:48 +00:00
Roger Dingledine
d0edf8e8b5 fix two bugs with cached directories: 
- don't complain that you won't cache it, then cache it anyway.
- change confusing terminology from 'deflate' to 'compress', so
  we'll stop getting our logic backwards. i assume the rfc author
  has shot himself by now.


svn:r2382
 2004-09-27 06:57:16 +00:00
Roger Dingledine
6e7e880438 put my fenceposts back in valid memory space 
svn:r2381
 2004-09-27 06:45:32 +00:00
Roger Dingledine
a2517b4f07 checking only 0.0.7 and 0.0.8 didn't work, because some dirservers 
files have really old descriptors for the authdirservers, so we're
asking them in the new format because they're too old.

now we actually compare the version to a cutoff version, and act
appropriately.

also take this chance to use only >=0.0.8 servers for dns resolves,
because of the recent bugs. we'll bump to >=0.0.9pre1 once there are
some servers running that.


svn:r2380
 2004-09-27 06:00:43 +00:00
Roger Dingledine
a64d093339 post descriptors to 0.0.8 authdirservers the old way, to make the 
transition easier


svn:r2379
 2004-09-27 03:50:58 +00:00
Roger Dingledine
10df7d9afc clients ask 0.0.9-and-later dirservers for a compressed dir 
dirservers rewrite url /foo/ to /tor/foo/, which will help us run things
behind apache once 0.0.8 is obsolete


svn:r2378
 2004-09-27 03:39:30 +00:00
Nick Mathewson
09586ef712 Make read_all distinguish between error and EOF; read_file_to_string should only check bytes read against st_size when in binary mode. 
svn:r2375
 2004-09-26 16:51:31 +00:00
Roger Dingledine
57d7857def don't mind empty exit policy entries 
svn:r2373
 2004-09-23 22:57:32 +00:00
Roger Dingledine
fa0a1ec49f cleanup: use strcmpstart() in more places 
svn:r2372
 2004-09-23 22:18:50 +00:00
Roger Dingledine
09f450104a don't imply to people that they should store their hidden service 
keys in /tmp


svn:r2371
 2004-09-23 20:50:27 +00:00
Roger Dingledine
185b9fddf2 protect dirservers from overzealous descriptor uploading 
wait 10 seconds after directory gets dirty, before regenerating


svn:r2370
 2004-09-23 19:58:44 +00:00
Roger Dingledine
02e3e3327c discourage people from setting their dirfetchpostperiod more often 
than once per minute


svn:r2369
 2004-09-23 19:23:32 +00:00
Roger Dingledine
8385fdb590 make our tor_assert actually work when it's going to be triggered, 
rather than seg fault


svn:r2368
 2004-09-23 05:02:51 +00:00
Roger Dingledine
a1979800ab bugfix on the bugfix 
actually unlink the log entry.

ok, that wasn't cleverly hidden enough. let's try again.


svn:r2367
 2004-09-23 04:59:02 +00:00
Roger Dingledine
8727a28119 bugfix: we were starting to daemonize before we opened our logs, 
so if there were any problems opening logs, we would complain to
stderr (which wouldn't work) and then mysteriously exit.


svn:r2366
 2004-09-23 04:32:43 +00:00
Roger Dingledine
f753f6f0e2 bugfix: when we run out of disk space, or other log writing error, 
don't crash. just stop logging to that log and continue.

nick, can you find the bug i've cleverly hidden in this commit?


svn:r2365
 2004-09-23 03:51:45 +00:00
Roger Dingledine
c0db9fa803 fix confusing cut-n-paste mistake 
svn:r2364
 2004-09-22 04:08:05 +00:00
Roger Dingledine
013104a1e2 people are starting to bump into the limit of 50 dns workers. 
raise it to 100 for now. we need a better solution long-term.
but alas, there are no better solutions that are also portable.
hm.


svn:r2363
 2004-09-22 03:56:41 +00:00
Nick Mathewson
9defe8a307 Attach dummy resolve connections to a circuit *before* calling dns_resolve(). This fixes a bug where cached answers would never be sent in RESOLVED cells. 
svn:r2360
 2004-09-21 18:12:12 +00:00
Nick Mathewson
c20b24c952 clean up/bugfix deflate logic and log messages 
svn:r2359
 2004-09-21 18:09:38 +00:00
Roger Dingledine
d977677aa8 bugfix: when a resolve fails for a begin request, actually send 
the end cell back. also, give a better reason for failure.


svn:r2358
 2004-09-21 17:33:05 +00:00
Roger Dingledine
ff622786f1 slightly better warn message 
svn:r2357
 2004-09-21 17:14:47 +00:00
Nick Mathewson
431b33a2ca Warn the user when we mark ourself as down. 
svn:r2356
 2004-09-21 16:44:20 +00:00
Nick Mathewson
0dcc8c7048 Bugfix: When a dns request failed, we would detach any "resolving" streams from the circuit before we would send a the resolve_failed cells. 
svn:r2355
 2004-09-21 16:42:07 +00:00
Nick Mathewson
93f085c4a2 Stop using openssl functions that rely on stdio; they can apparently lead to linker grief on win32. 
svn:r2354
 2004-09-21 04:55:43 +00:00
Roger Dingledine
802b203ff1 fix a rare seg fault for people running hidden services on 
intermittent connections


svn:r2353
 2004-09-20 03:07:11 +00:00
Roger Dingledine
eade496dcd JI hates people who say "IP" when they mean "IP address" 
svn:r2352
 2004-09-12 15:07:14 +00:00
Roger Dingledine
959199340a don't pick administrative-friends when picking your path 
(just a skeleton for now)


svn:r2349
 2004-09-10 21:40:29 +00:00
Roger Dingledine
8954cd91ce LOG_ERR is for when we're going to exit 
svn:r2348
 2004-09-10 21:39:53 +00:00
Roger Dingledine
a475ccf5b8 we should exit(1) if $HOME doesn't exist and we needed it 
svn:r2344
 2004-09-10 19:16:01 +00:00
Nick Mathewson
8ab26650ee Fix documentation about how not to be an OP 
svn:r2342
 2004-09-10 18:54:21 +00:00
Nick Mathewson
0ef85f6dba Some platforms have weird translations when you open files in "test" mode; make read/write_str_to_file aware. 
svn:r2336
 2004-09-08 07:16:34 +00:00
Nick Mathewson
c66e4c4870 Flush more changes from sandbox 
- make clients cache directories and use them to seed their router lists
   at startup.  This means clients have a datadir again.
 - Introduce a global_write_bucket.  We need to respond better to exhausting
   it.
 - Remove the last vestiges of LinkPadding and TrafficShaping.
 - Configuration infrastructure support for warning on obsolete options.
 - Refactor directory header parsing to use smartlist_split_string.
 - Respond to content-encoding headers by trying to uncompress as appropriate.
 - Reply with a deflated directory when a client asks for "dir.z".
   (We could use allow-encodings instead, but allow-encodings isn't
   specified in HTTP 1.0.)


svn:r2335
 2004-09-08 06:52:33 +00:00
Nick Mathewson
b6798866d0 Idiot-proof uncompress; make sure it always nul-terminates its output. Also, make all compression methods nonzero. 
svn:r2334
 2004-09-08 06:47:33 +00:00
Nick Mathewson
9836ccda8c Move a paren 4 characters to the left; fix a bug in OutboundBindAddress 
svn:r2330
 2004-09-02 23:25:23 +00:00
Nick Mathewson
ecf414f05e Stop using separate defaults for no-config-file and empty-config-file 
svn:r2329
 2004-09-02 22:08:36 +00:00
Nick Mathewson
d6e47bec46 Keep a deflated version of each directory so we can deliver it when requested 
svn:r2328
 2004-09-02 18:57:09 +00:00
Nick Mathewson
bda41ba3fd Use new split function and strcmpstart correctly 
svn:r2327
 2004-09-02 18:39:59 +00:00
Nick Mathewson
4c799ae731 Check for zlib; link with it. 
svn:r2326
 2004-09-02 18:27:09 +00:00
Nick Mathewson
f311206d1d Make split function smarter; add a strcmpstart function so we can stop bungling strcmp(x, y, strlen(y)); 
svn:r2325
 2004-09-02 18:25:50 +00:00
Nick Mathewson
3590eb535a Add basic wrappers for zlib/gzip 
svn:r2324
 2004-09-02 18:22:51 +00:00
Nick Mathewson
6e844ea743 Bump windows version to 0.0.8 
svn:r2319
 2004-08-26 01:27:58 +00:00
Nick Mathewson
31b81650b7 Define LONG_MAX and UINT_MAX when they are missing 
svn:r2317
 2004-08-25 19:16:18 +00:00
Roger Dingledine
f91c552af7 fix a seg fault on solaris 
svn:r2313
 2004-08-25 17:37:00 +00:00
Roger Dingledine
444a01610c make the compile work (and not complain) on sunos 5.9 
svn:r2312
 2004-08-25 17:31:47 +00:00
Roger Dingledine
be7909f670 Fix a symptom for a bug that straycat found. 
Apparently in rare cases poll() is returning POLLIN for an idle
dns worker. It reads no bytes, presumably because the idle dns
worker didn't write anything in the first place. Gosh, who knows.

Now we only trigger the assert if the idle dns worker actually
tries to send an answer to us.


svn:r2311
 2004-08-25 05:26:09 +00:00
Roger Dingledine
d91cacb839 agree with nick: this legal-chars-in-filename stuff gets us nothing 
svn:r2310
 2004-08-24 21:57:12 +00:00
Nick Mathewson
015232bd39 As far as I can tell, CONFIG_LEGAL_FILENAME_CHARACTERS is both pointless and broken. #if it out, pending agreement from arma. This fixes a bug on win32 that rejected paths with a : in them. 
svn:r2309
 2004-08-24 20:48:22 +00:00
Nick Mathewson
4b4bfd500a Improve log message to make it obvious _why_ reading the configuration has failed. 
svn:r2308
 2004-08-24 20:46:42 +00:00
Roger Dingledine
79df0aa18a when picking unverified routers, skip those with bad uptime or 
bad bandwidth, depending on what properties you care about


svn:r2302
 2004-08-20 21:34:36 +00:00
Nick Mathewson
7979c0277d Workaround for oddity in cygwin autoconf 
svn:r2301
 2004-08-19 17:21:17 +00:00
Nick Mathewson
c8b621b147 Increment windows version to 0.0.8rc1 
svn:r2299
 2004-08-18 22:25:50 +00:00
Nick Mathewson
ae46b6b077 Fix some DOCDOCs 
svn:r2295
 2004-08-18 21:56:45 +00:00
Roger Dingledine
cf6159abb9 fix a seg fault on hup when FascistFirewall is defined 
svn:r2294
 2004-08-18 21:46:53 +00:00
Roger Dingledine
8ddc029d07 if options.FascistFirewall but none are running on port 80, try 
the others before giving up.


svn:r2293
 2004-08-18 21:13:58 +00:00
Roger Dingledine
2396c6bf71 remove last vestiges of this 'twin' concept 
svn:r2291
 2004-08-18 20:35:11 +00:00
Roger Dingledine
9504db8ce8 be more aggressive about building circuits when we have no 
open circuits


svn:r2290
 2004-08-18 20:34:43 +00:00
Roger Dingledine
7304ac1d6f tweak the [...truncated] string again 
svn:r2289
 2004-08-18 11:21:50 +00:00
Roger Dingledine
b500104cbe tolerate old 0.0.7 clients that demand a certain ip:port for a router 
even though it's moved on to another one.

also reduce some log verbosity.


svn:r2288
 2004-08-18 11:20:15 +00:00
Roger Dingledine
3937ecfaae when we try to exclude our routerinfo from being picked in the 
path, it fails because we're using a pointer to the routerinfo we
generate, not a pointer to the routerinfo in the routerlist. so look
up the right one and use that.


svn:r2286
 2004-08-18 10:32:50 +00:00
Roger Dingledine
20b8819023 even better, only print extend attempts if there are any. 
svn:r2285
 2004-08-18 09:57:50 +00:00
Roger Dingledine
a447570036 stop taking strlen of an uninitialized buffer 
we were (are?) printing garbage in the rephist stats


svn:r2284
 2004-08-18 09:49:17 +00:00
Roger Dingledine
b885db033e remove crazy notion that clique_mode() means we are 
already connected to everybody we could be connected to.


svn:r2283
 2004-08-18 09:07:11 +00:00
Roger Dingledine
40f9f94794 don't add a spurious newline before [truncated] 
svn:r2282
 2004-08-18 08:52:12 +00:00
Roger Dingledine
765530421e be more aggressive about trying to make circuits: 
try once a second for 30 seconds, and only when the entire previous
period has failed do we pause after MAX_CIRCUIT_FAILURES failures.


svn:r2281
 2004-08-18 08:51:04 +00:00
Roger Dingledine
6d661d1bc0 bugfix: make intro circuits work again 
svn:r2280
 2004-08-18 07:53:43 +00:00
Nick Mathewson
555f8f30f4 Avoid segfault when freeing options_t without firewall_ports 
svn:r2279
 2004-08-18 07:06:53 +00:00
Roger Dingledine
99e367f045 authdirservers don't need to be treated specially on hup for 
making intro points


svn:r2277
 2004-08-18 06:48:45 +00:00
Roger Dingledine
807a484b88 only establish intro points after we've gotten a directory 
svn:r2276
 2004-08-18 06:47:01 +00:00
Roger Dingledine
6e9e467b1d dirservers now don't build circuits until they have fetched a 
directory from somebody else. this means they have time to
build their connections first.


svn:r2275
 2004-08-18 06:29:58 +00:00
Roger Dingledine
b294a037a4 choose exit nodes by bandwidth too 
svn:r2274
 2004-08-18 06:10:12 +00:00
Nick Mathewson
6de61bd694 Revert dumb think-o. Just because _some_ INTRODUCE2 cells are now longer, 
doesn't mean we should raise the _minimum_ size.


svn:r2273
 2004-08-18 05:05:58 +00:00
Nick Mathewson
196e6c1cc2 Support new INTRODUCE2 cell format 
svn:r2270
 2004-08-18 04:48:59 +00:00