David Goulet
df3f2bd9aa
hs-v3: Log reasons why service can't upload descriptor
...
When a service can not upload its descriptor(s), we have no logs on why. This
adds logging for each possible reason for each descriptors.
That logging is emitted every second so it is rate limited for each reason and
per descriptor.
Closes #33400
Signed-off-by: David Goulet <dgoulet@torproject.org>
2020-03-11 15:32:11 +02:00
David Goulet
6684c6e17f
Merge branch 'tor-github/pr/1751'
2020-03-09 09:33:05 -04:00
Neel Chauhan
7d673e70b0
Remove the ClientAutoIPv6ORPort option
2020-03-09 09:33:00 -04:00
Nick Mathewson
8e5c75e896
Merge remote-tracking branch 'tor-github/pr/1772/head'
2020-03-05 09:09:16 -05:00
Nick Mathewson
686494f0f7
Merge branch 'clang_format_prep_3'
2020-03-05 08:23:32 -05:00
George Kadianakis
edc0bf5089
Merge branch 'tor-github/pr/1763'
2020-03-03 14:35:31 +02:00
Nick Mathewson
a5bc08579f
shared_random: Improve fallback for client no-live-consensus case.
...
In this case, when we're looking for the voting interval, we should
try looking at the _latest_ consensus if we have one. When we're
looking for the start of the current voting period, we can use our
existing fallback logic without complaint, since the voting interval
code will already have given us a reasonable voting interval, and we
want to have a round starting time based on the current time.
2020-03-03 14:35:01 +02:00
Nick Mathewson
9a7b10e23f
Comment updates from review.
2020-03-03 14:35:01 +02:00
Nick Mathewson
1b66b39699
Make voting_schedule.h work correctly when dirauth-mode is disabled.
2020-03-03 14:35:01 +02:00
Nick Mathewson
9fb18756df
Stop using all dirauth-only options in shared_random_client.c
...
This is not as clean a patch as I would like: see the comment on
ASSUME_AUTHORITY_SCHEDULING. This issue here is that the unit tests
sometimes assume that we are going to be looking at the dirauth
options and behaving like a dirauth, but without setting the options
to turn is into one.
This isn't an issue for actually running Tor, as far as I can tell
with chutney.
2020-03-03 14:35:01 +02:00
Neel Chauhan
2ef2fef711
Correct spacing in dns_launch_correctness_checks()
2020-02-26 15:48:45 -08:00
Nick Mathewson
6472d9cfdf
Run "make autostyle"
2020-02-26 16:45:33 -05:00
Nick Mathewson
11adf0f46f
Merge remote-tracking branch 'tor-github/pr/1750/head'
2020-02-25 12:58:23 -05:00
Nick Mathewson
7777f1df49
Dirauth-specific function to get voting interval.
2020-02-24 10:55:06 -05:00
Nick Mathewson
d865a50296
Extract most of dirauth_sched_get_next_valid_after_time()
...
Most of this function was about recreating a voting schedule on
demand if it didn't exist yet or was not up-to-date. I've made that
into its own function.
2020-02-24 10:13:07 -05:00
Nick Mathewson
4fb6d8675f
Rename voting_schedule_*() functions.
...
This is an automated commit, generated by this command:
./scripts/maint/rename_c_identifier.py \
voting_schedule_recalculate_timing dirauth_sched_recalculate_timing \
voting_schedule_get_start_of_next_interval voting_sched_get_start_of_interval_after \
voting_schedule_get_next_valid_after_time dirauth_sched_get_next_valid_after_time
2020-02-24 10:07:09 -05:00
Nick Mathewson
b7ba558f56
Move one voting schedule fn into networkstatus.c
...
The 'voting_schdule_get_start_of_next_interval' function isn't
actually dirauth-specific.
2020-02-24 10:04:01 -05:00
Nick Mathewson
e1cf10ceb7
Move voting_schedule.[ch] to src/feature/dirauth/
2020-02-24 10:00:51 -05:00
Nick Mathewson
d4d5d9d1d1
Merge branch 'ticket33316_squashed'
2020-02-24 07:49:45 -05:00
Nick Mathewson
caa392a73a
Merge remote-tracking branch 'tor-github/pr/1685/head'
2020-02-24 07:45:20 -05:00
George Kadianakis
93cb8072be
Final touches to #32709 based on Nick's feedback.
...
- Fix a bug and add unittest.
- Add changes file.
- Add man page entry.
2020-02-24 12:15:35 +02:00
Nick Mathewson
84f2e28204
Use PRIu64 and TOR_PRIuSZ, to fix 32-bit build error.
2020-02-20 20:49:38 -05:00
Nick Mathewson
ce9eeefbcc
Make direclient_dump_total_dls() respect SafeLogging and pass tests.
...
Don't dump totals with anonymous purposes. Additionally, don't dump
headers that have nothing underneath them.
2020-02-20 12:26:32 -05:00
Nick Mathewson
66bbdadbbe
Merge branch 'extract_routerkeys_squashed'
2020-02-20 10:41:12 -05:00
Nick Mathewson
1d068625dd
Move relay_handshake.[ch] into src/feature/relay, and make it optional
2020-02-20 10:41:06 -05:00
Nick Mathewson
e425ffc637
Disable routerkeys.c with --disable-relay-mode.
2020-02-20 10:41:06 -05:00
Nick Mathewson
09fb7987c5
Merge branch 'maint-0.4.3'
2020-02-20 08:50:18 -05:00
Nick Mathewson
f733b8acd6
Merge remote-tracking branch 'tor-github/pr/1719/head' into maint-0.4.3
2020-02-20 08:48:17 -05:00
Nick Mathewson
d559ca3d5a
Move router_reset_reachability() into correct header, add a stub
...
Without this, -O0 builds fail, which is a sign that LTO builds may
fail too.
2020-02-20 08:36:40 -05:00
Nick Mathewson
5149c100ed
run "make autostyle"
2020-02-20 08:33:40 -05:00
Nick Mathewson
b9cc4cc50a
Merge branch 'ticket4631_squashed'
2020-02-20 08:17:47 -05:00
teor
bed3b292ad
dirvote: Improve the posted vote log message
...
Cleanup after 4631.
2020-02-20 08:17:37 -05:00
Nick Mathewson
a65efa7e83
Merge branch 'extract_relay_dns'
2020-02-19 13:58:53 -05:00
Nick Mathewson
65b75ef3d5
Merge branch 'extract_ext_orport'
2020-02-19 13:55:18 -05:00
Nick Mathewson
defd941fe7
Make dns_cancel_pending_resolve() STATIC.
...
It is not called by anything outside of the tests and dns.c.
2020-02-19 12:30:09 -05:00
Nick Mathewson
f739aa7962
Remove assert_all_pending_dns_resolves_ok().
...
It hasn't been used since 2009.
2020-02-19 12:27:49 -05:00
Nick Mathewson
51b470dbc8
dns.h: label functions that are only used inside feature/relay
2020-02-19 12:17:13 -05:00
Nick Mathewson
9b21a5d254
Note module-local functions in ext_orport.h
...
Since these are only used inside the feature/relay module, they
don't need stubs.
2020-02-19 12:12:00 -05:00
Nick Mathewson
df6191f620
Make connection_or_get_by_ext_or_id() testing-only
...
Apparently it is only used by the unit tests: tor doesn't want it at
all.
I've opened a new ticket (33383) to we if we should remove this
whole feature.
2020-02-19 12:11:23 -05:00
teor
15192f88c0
dirvote: Remove an incorrect log message
...
Cleanup after 4631.
2020-02-19 11:09:21 +10:00
Nick Mathewson
e85f46b7be
Do not build selftest.c when running relay mode is disabled.
2020-02-18 13:31:33 -05:00
Nick Mathewson
a1a3a4d585
Make ext_orport.c relay-mode-only.
2020-02-18 13:23:50 -05:00
Nick Mathewson
1f958b6020
Move ext_orport identifier map into ext_orport.c
...
There's no need to move the declarations: those were already in
ext_orport.h.
This shrinks connection_or.c a little.
2020-02-18 13:10:57 -05:00
Nick Mathewson
8ce15933e5
Move some declarations into proto_ext_or.h
...
They are for functions declared in that file.
2020-02-18 13:07:33 -05:00
Nick Mathewson
eb07166eb8
Make sure callers can handle NULL ext-or auth cookie filename
2020-02-18 12:55:57 -05:00
Nick Mathewson
c43a245292
Disable dns.c when relay mode is disabled.
...
This saves about 1% for me on a binary compiled without relay mode.
Closes ticket 33366.
2020-02-18 12:46:10 -05:00
Nick Mathewson
1f06f494c8
Move DNS TTL manipulation code to src/core/or
...
This removes a dependency from the client code on feature/relay.
2020-02-18 12:08:29 -05:00
Nick Mathewson
dcbc45e6b2
Replace identifiers related to clipping DNS ttls.
...
This is an automated commit, generated by this command:
./scripts/maint/rename_c_identifier.py \
MIN_DNS_TTL_AT_EXIT MIN_DNS_TTL \
MAX_DNS_TTL_AT_EXIT MAX_DNS_TTL \
dns_clip_ttl clip_dns_ttl
2020-02-18 12:00:24 -05:00
Nick Mathewson
93af83e16a
Remember dirctory bw usage, and log it in the heartbeat
...
Closes ticket 32720.
2020-02-18 11:25:18 -05:00
George Kadianakis
975102869a
Fix issues pointed out by Nick.
...
- Loose the asserts on num_pkeys.
- Straighten some dangling &.
- Fix some unpredictable memcpys.
2020-02-18 12:37:34 +02:00