236 Commits

Author	SHA1	Message	Date
Nick Mathewson	d3db84c1e7	Make check_subsystem_order work in distcheck builds.	2020-04-07 17:36:02 +10:00
Nick Mathewson	5f49695f94	Make check_subsystem_order work in out-of-tree builds.	2020-04-07 17:35:58 +10:00
Nick Mathewson	978b7ef45c	Teach --check-subsystem-order to take input from stdin	2020-03-26 12:30:30 -04:00
Nick Mathewson	a40d539f7c	Extend includes.py to compare topology with subsystem init order.	2020-03-26 12:17:53 -04:00
teor	a34a88c6f1	practracker: Accept changes ... Accept a smaller file and function. Let router.c grow slightly without warning. Accept an extra comment line. Cleanup after 32588.	2020-03-21 04:10:24 +10:00
teor	5d53b2317f	practracker: Accept larger dirvote file ... Due to improved function comments.	2020-03-21 02:48:51 +10:00
teor	78b2984ac9	practracker: Regenerate exceptions file ... Accept the current state of the tor codebase, including all the files and functions that have increased technical debt over the last few months. Accepts all the current practracker warnings, so that reviewers can focus on new warnings. Closes ticket 33635.	2020-03-19 16:59:52 +10:00
teor	c86d08e3e6	Run "practracker.py --regen-overbroad" ... We've successfully resolved a bunch of technical debt over the last few months. Let's remove the allowances for that debt from the practracker exceptions.	2020-03-17 23:02:16 +10:00
David Goulet	df3f2bd9aa	hs-v3: Log reasons why service can't upload descriptor ... When a service can not upload its descriptor(s), we have no logs on why. This adds logging for each possible reason for each descriptors. That logging is emitted every second so it is rate limited for each reason and per descriptor. Closes #33400 Signed-off-by: David Goulet <dgoulet@torproject.org>	2020-03-11 15:32:11 +02:00
Nick Mathewson	caa392a73a	Merge remote-tracking branch 'tor-github/pr/1685/head'	2020-02-24 07:45:20 -05:00
Nick Mathewson	7ba7f9c0de	Merge branch 'maint-0.4.3'	2020-02-20 10:44:43 -05:00
Nick Mathewson	7b42502869	Merge remote-tracking branch 'tor-github/pr/1757/head' into maint-0.4.3	2020-02-20 10:44:36 -05:00
Nick Mathewson	66bbdadbbe	Merge branch 'extract_routerkeys_squashed'	2020-02-20 10:41:12 -05:00
Nick Mathewson	1d068625dd	Move relay_handshake.[ch] into src/feature/relay, and make it optional	2020-02-20 10:41:06 -05:00
Nick Mathewson	09fb7987c5	Merge branch 'maint-0.4.3'	2020-02-20 08:50:18 -05:00
Nick Mathewson	dd4fa9b468	Extract relay-only handshake code into its own file. ... This is not the only relay-only handshake code, but it is most of such code that is in connection_or.c.	2020-02-19 19:11:57 -05:00
teor	57ff8d4a53	practracker: Read unicode files when using Python 2 ... Allow the "practracker" coding best practices checking script to read unicode files, when using Python 2. We made the script use unicode literals in 0.4.3.1-alpha, but didn't change the codec for opening files. Fixes bug 33374; bugfix on 0.4.3.1-alpha.	2020-02-19 08:22:01 +10:00
teor	d8cbb2965e	Run "practracker --regen-overbroad" ... Closes ticket 33373.	2020-02-19 08:13:02 +10:00
Panagiotis Vasilopoulos	674a821fbb	Stop assuming that /usr/bin/python exists ... Fixes 33192	2020-02-16 21:58:01 +02:00
David Goulet	f0964628e6	Merge branch 'ticket33029_042_01' into ticket33029_043_03 ... Conflicts: doc/tor.1.txt src/app/config/config.c src/app/config/or_options_st.h src/core/mainloop/connection.h Between 042 and 043, the dirauth options were modularized so this merge commit address this by moving the AuthDirRejectUncompressedRequests to the module along with a series of accessors. Signed-off-by: David Goulet <dgoulet@torproject.org>	2020-02-11 10:30:29 -05:00
Nick Mathewson	5e963f97b1	practracker: use shutil.move so --regen will work on windows ... On windows you can't os.rename() a file if the target filename already exists.	2020-02-03 13:36:56 -05:00
Nick Mathewson	ec965ba98b	practracker: integration tests for --regen and --regen-overbroad	2020-02-03 13:11:58 -05:00
Nick Mathewson	2542a24b63	practracker: add a --regen-overbroad option to remove overbroad exceptions. ... Closes ticket 32372.	2020-02-03 13:02:12 -05:00
David Goulet	3484608bda	practracker: Make it happy ... Signed-off-by: David Goulet <dgoulet@torproject.org>	2020-01-21 10:31:29 -05:00
teor	b7cfca1dee	Merge branch 'pr1599_squashed'	2020-01-15 22:31:01 +10:00
teor	b910ae8cd1	practracker: Wrap long lines in the test script	2020-01-15 22:29:52 +10:00
teor	fa038e5617	practracker: Test practracker exit status ... Part of 32705.	2020-01-15 22:29:48 +10:00
teor	eb55d85e75	practracker: Fail tests if any process exits unexpectedly ... Part of 32705.	2020-01-15 22:29:44 +10:00
teor	cda2ff1965	practracker: Capture stderr output in test_practracker.sh ... And canonicalise file paths, so that output is consistent, even in out-of-tree builds. Capturing stderr output produces better diagnostics. Diagnostics for 32705.	2020-01-15 22:29:22 +10:00
teor	8095c785f1	Merge branch 'maint-0.4.2'	2020-01-14 17:41:44 +10:00
teor	7e111d0eaa	practracker: print a notice to stderr when disabled ... When TOR_DISABLE_PRACTRACKER is set, print a message to stderr when skipping practracker checks. Part of 32705.	2020-01-14 17:41:00 +10:00
Nick Mathewson	6b1592b564	test_practracker.sh: never disable practracker ... When practracker is disabled, its output will be empty. We don't want that happening during our tests. Fixes bug 32705; bugfix on 0.4.2.1-alpha, when test_practracker.sh was introduced.	2020-01-13 16:17:51 -05:00
teor	1619f14a04	python: Add __future__ imports for python 3 compatibility ... Except for src/ext, which we may not want to modify. Closes ticket 32732.	2019-12-12 15:58:51 +10:00
Nick Mathewson	fcb5656128	Merge branch 'ticket32609_squashed'	2019-12-04 12:15:28 -05:00
teor	b0f1b760ae	practracker: document !advisory in includes.py	2019-12-04 12:15:22 -05:00
teor	19324ff0ba	practracker: Test for bad ".c" includes in the unit tests ... Part of 32522.	2019-12-04 12:15:22 -05:00
teor	fadd292bf0	practracker/includes.py: Don't read editor temp files ... (Or any files that start with "." or "#".) Obviously correct changes to already-reviewed code.	2019-11-26 17:52:18 +10:00
teor	ab70c315bd	practracker: Fix a typo in a logging function call ... Obviously correct changes to already-reviewed code.	2019-11-26 11:01:34 +10:00
Nick Mathewson	31f8b4fa65	Merge branch 'stream-socks-auth' into bug19859_merged	2019-11-25 07:58:02 -05:00
Nick Mathewson	5060007f4b	Split log configuration out of options_act_reversible().	2019-11-19 16:03:32 -05:00
George Kadianakis	53ac9a9a91	Add changes file for #30381.	2019-11-18 19:21:10 +02:00
teor	3b4a360ed0	practracker: Don't read editor temp files, attempt 2 ... (Or any files that start with "." or "#".) Obviously correct changes to already-reviewed code.	2019-11-14 16:12:19 +10:00
teor	60d5ff303d	practracker: Preserve improvements	2019-11-05 14:28:02 +10:00
teor	bcb38d984d	practracker: Update the exceptions file with improvements ... Regenerate the exceptions file, but only commit the improvements. Includes changes from 32213 and other tickets.	2019-11-05 12:50:08 +10:00
teor	c065ad3e3d	practracker: Rename functions modified by a previous commit ... Part of 32213.	2019-11-05 11:36:26 +10:00
JeremyRand	736322ce61	Bug #19859: Increase function-size exception to 124	2019-11-03 07:11:08 +00:00
teor	18e09913bf	practracker: Don't read editor temp files ... (Or any dot files.) Obviously correct changes to already-reviewed code.	2019-10-28 13:09:58 +10:00
Nick Mathewson	dc6d7f072d	Make foo_validate() functions call config_validate(). ... The former foo_validate() functions are now toplevel legacy_validate_fn callbacks. The new foo_validate() functions now call them. This change lets us remove the old shared_random disk state validation callback entirely.	2019-10-24 20:30:32 -04:00
Nick Mathewson	264c5312eb	Merge branch 'maint-0.4.2'	2019-10-18 12:32:49 -04:00
Alexander Færøy	95e3527df0	Bump practracker exception limit for process_win32_exec(). ... I have added a larger comment there and one line of code, so I think this bump is reasonable. See: https://bugs.torproject.org/31810	2019-10-17 21:12:51 +02:00