Steven Murdoch
d1dd9991cd
Document limitation of log_from_handle with partial reads
2011-08-30 15:02:28 +01:00
Steven Murdoch
da34360952
Factor out and re-write code for splitting lines from a handle
...
Now handles non-printable characters and will not output a spurious
new-line if given a partial line.
2011-08-30 14:55:51 +01:00
Steven Murdoch
bc97f41080
Refactor out command line formatting
...
Now correctly handles whitespace, quotes and backslashes. Passes all unit tests.
2011-08-29 14:37:38 +01:00
Steven Murdoch
93792b5aa6
Add a sanity check
2011-08-29 00:36:41 +01:00
Steven Murdoch
f1ff65dfad
Replace two magic tristates with #define'd names
...
- process_handle_t.status
- return value of tor_get_exit_code()
2011-08-29 00:30:18 +01:00
Steven Murdoch
3f0a197aad
Make signature of tor_spawn_background more conventional
...
Conventionally in Tor, structs are returned as pointers, so change
tor_spawn_background() to return the process handle in a pointer rather
than as return value.
2011-08-28 23:35:02 +01:00
Steven Murdoch
1da5081ae0
Appease "make check-spaces"
2011-08-24 21:34:13 +01:00
Steven Murdoch
50b48c3ea7
Improve comments and fix one bug
2011-08-24 21:33:53 +01:00
Steven Murdoch
476807211c
We don't need to find our own path, just tell Windows to search
2011-08-24 20:50:58 +01:00
Steven Murdoch
6304e088d0
Find test-child.exe by looking in same directory as test.exe
2011-08-24 19:56:38 +01:00
Steven Murdoch
2efafdfe14
Fix compilation errors under *nix
2011-08-23 01:09:24 +01:00
Steven Murdoch
50504fc4cb
Fix test cases to handle MSYS style paths (/c/foo rather than c:/foo)
...
Also fix test case to expect 1 on successfully spawning a subprocess
2011-08-22 20:05:11 +01:00
Steven Murdoch
1ad986335a
Tidy up subprocess code
...
- Better error handling
- Write description of functions
- Don't assume non-negative process return values
2011-08-22 19:43:38 +01:00
Steven Murdoch
f46f6aabb4
Fix some compiler warnings
2011-08-22 18:13:58 +01:00
Steven Murdoch
a78ffd9e45
Revert change to libminiupnpc search path
...
This was supposed to fix an oddity with library searching in autoconf
but it didn't actually fix anything.
2011-08-22 17:55:40 +01:00
Steven Murdoch
6443a756df
Merge branch 'bug1983-port-tor-fw-helper-to-windows' into bug2046
...
Conflicts:
configure.in
src/tools/tor-fw-helper/Makefile.am
src/tools/tor-fw-helper/tor-fw-helper-upnp.c
src/tools/tor-fw-helper/tor-fw-helper.c
2011-08-22 17:53:17 +01:00
Steven Murdoch
850d8c9eb8
Correct reference to libiphlpapi from libiphlapi
2011-08-22 17:38:43 +01:00
Steven Murdoch
c5e74fc60d
Appease "make check spaces"
2011-08-22 16:31:30 +01:00
Nick Mathewson
269c0b4633
Only link ws2_32 and iphlapi on windows.
...
This is a tweak for the tor-fw-helper port to windows.
2011-08-19 13:20:15 -04:00
Steven Murdoch
2ad336f999
Link and build tor-fw-helper on Windows
...
- Update configure script to test for libminiupnpc along with the
libws2_32 and libiphlpapi libraries required by libminiupnpc
- When building tor-fw-helper, link in libiphlpapi
- Link in libminiupnpc statically becasue I could not get the DLL
to link properly
- Call WSAStartup before doing network operations
- Fix up a compiler warning about uninitialized backend_state
N.B. The changes to configure.in and Makefile.am will break on non-
Windows platforms.
2011-08-19 15:22:13 +01:00
Nick Mathewson
df96aed14f
Remove warning about a loop parsing evbuffer socks
...
This behavior is normal when we want more data than the evbuffer
actually has for us. We'll ask for (say) 7 bytes, get only 5
(because that's all there is), try to parse the 5 bytes, and get
told "no, I want 7". One option would be to bail out early whenever
want_length is > buflen, but sometimes we use an over-large
want_length. So instead, let's just remove the warning here: it's
not a bug after all.
2011-08-18 16:15:03 -04:00
Nick Mathewson
263d68aa82
Appease "make check-spaces"
2011-08-18 15:17:37 -04:00
Nick Mathewson
d3653063d3
Automatically use filtering bufferevents with IOCP.
2011-08-18 15:16:05 -04:00
Steven Murdoch
cc5b6d6cee
Merge remote branch 'origin/master' into bug2046
2011-08-18 18:42:02 +01:00
Steven Murdoch
7d015c886a
Complete logging of output from port forwarding helper
2011-08-18 18:41:23 +01:00
Nick Mathewson
52e36feda1
Call evthread_use_windows_threads when running with IOCP on windows
2011-08-17 14:44:16 -04:00
Nick Mathewson
d2cd67c83f
Use evbuffer_copyout() in inspect_evbuffer().
2011-08-17 13:09:05 -04:00
Nick Mathewson
8932919366
Bufferevents now requires Libevent 2.0.13-stable.
...
(Earlier Libevent versions have bufferevent bugs that affect us, and
are missing some APIs that it would be handy to use.)
2011-08-17 12:53:50 -04:00
Nick Mathewson
06be6105e4
Merge remote-tracking branch 'origin/maint-0.2.2'
...
Conflicts:
src/or/config.c
2011-08-17 12:00:44 -04:00
Nick Mathewson
d79d648edc
Don't write ControlPorts to disk till after we setuid and make datadir
...
Fix for bug 3747; bugfix on 0.2.2.26-beta.
2011-08-17 11:22:16 -04:00
Nick Mathewson
14552a12b3
Merge branch 'bug3743'
2011-08-17 10:46:28 -04:00
Nick Mathewson
6650dc932a
Remove a needless config_find_option
2011-08-17 10:46:22 -04:00
Sebastian Hahn
6a06f45b04
Actually pick a random port when "auto" is specified
...
ddc65e2b33
had broken this
2011-08-17 10:41:36 -04:00
Kamran Riaz Khan
e6e804848c
Don't compare LINELIST_S and OBSOLETE config options.
2011-08-16 06:28:38 +05:00
Nick Mathewson
2dc40b9c49
Merge remote-tracking branch 'asn/bug3728'
2011-08-15 11:06:50 -04:00
Nick Mathewson
aeb27526f8
Merge remote-tracking branch 'origin/maint-0.2.2'
2011-08-15 10:54:55 -04:00
Robert Ransom
03f6ee8c5f
Remove extra quotation marks around the result of esc_for_log
2011-08-15 10:54:19 -04:00
Nick Mathewson
0ddc8de0b6
Oops; _actually_ enable microdesc-by-default for clients
...
It turns out that it wasn't enough to set the configuration to
"auto", since the correct behavior for "auto" had been disabled in
microdesc.c. :p
(Hasn't been in a release yet, so doesn't need a changes entry.)
2011-08-15 10:52:23 -04:00
George Kadianakis
ec8d0a6d83
Free global_rate_limit in connection_free_all().
2011-08-13 20:37:13 +02:00
George Kadianakis
a5fd07d178
Move connection_free_all() to the bottom of connection.c to enjoy maximum visibility.
2011-08-13 20:29:22 +02:00
Nick Mathewson
70216cb096
Merge remote-tracking branch 'sebastian/bug3700'
2011-08-11 14:42:15 -04:00
Sebastian Hahn
f137ae896e
Don't warn on http connection to my orport
...
Also remove a few other related warnings that could occur during the ssl
handshake. We do this because the relay operator can't do anything about
them, and they aren't their fault.
2011-08-11 20:37:51 +02:00
Nick Mathewson
8c643b51bf
Merge remote-tracking branch 'origin/maint-0.2.2'
2011-08-11 11:53:03 -04:00
Sebastian Hahn
cd44145c5b
Merge branch 'bug3643'
2011-08-11 07:56:38 +02:00
Sebastian Hahn
92bea30e28
Ignore deprecation warnings on OS X
...
Starting with Lion, Apple decided to deprecate the system openssl. We
can start requiring users to install their own openssl once OS X doesn't
ship with it anymore.
2011-08-10 23:12:09 +02:00
Nick Mathewson
5da9f722f2
Whitespace tweaks
2011-08-10 15:06:45 -04:00
Nick Mathewson
5252c9434f
Fix a const warning in bug1692 code
2011-08-10 15:06:11 -04:00
Nick Mathewson
b76f46c6d8
Merge branch 'bug1692-squashed'
2011-08-10 15:04:36 -04:00
Kamran Riaz Khan
02a735dfa8
Fix condition reported by nickm.
2011-08-10 15:03:25 -04:00
Kamran Riaz Khan
73f07c558b
Return if CONF_CHANGED isn't interesting.
2011-08-10 15:03:25 -04:00