Nick Mathewson
6fbf17e7b0
r11749@Kushana: nickm | 2006-12-29 00:51:42 -0500
...
Remove dead code; make targets of addressmap commands/configs use AllowNonRFC953Hostnames
svn:r9211
2006-12-29 05:51:50 +00:00
Nick Mathewson
361998d0f3
r11741@Kushana: nickm | 2006-12-28 22:41:29 -0500
...
Count TLS bytes accurately: previously, we counted only the number of bytes read or transmitted via tls, not the number of extra bytes used to do so. This has been a lonstanding wart. The fix "Works for me".
svn:r9207
2006-12-29 03:42:46 +00:00
Nick Mathewson
4cd302a1eb
r11722@Kushana: nickm | 2006-12-28 13:51:42 -0500
...
Add a helper function for case-insensitive search through a smartlist
svn:r9198
2006-12-28 21:29:03 +00:00
Nick Mathewson
94d7d8d88f
r11670@Kushana: nickm | 2006-12-21 12:23:55 -0500
...
Clean up logic in parse_port_range(); accept 0 on low end and 65536 on high end for people who are bad at math.
svn:r9169
2006-12-21 17:38:15 +00:00
Nick Mathewson
ca516311e3
r11668@Kushana: nickm | 2006-12-20 22:22:53 -0500
...
Fix bug found by Keith Skinner: Treat malformed max-ports in address ranges as an error, and dont ignore errors with min-ports even if a max-port is present.
svn:r9168
2006-12-21 03:22:59 +00:00
Nick Mathewson
078aab810b
r11597@Kushana: nickm | 2006-12-15 15:49:27 -0500
...
Add a rudimentary line-wrapping function for use in dumping comments in config files.
svn:r9132
2006-12-15 21:26:23 +00:00
Nick Mathewson
309c579452
r11581@Kushana: nickm | 2006-12-15 00:12:24 -0500
...
Make PIDFile work on windows. Reported by Arrakis.
svn:r9116
2006-12-15 05:12:52 +00:00
Nick Mathewson
43e06eba8b
r11566@Kushana: nickm | 2006-12-13 17:46:24 -0500
...
Try to fix an assert failure in new write limiting code: make buffers.c aware of previous "forced" write sizes from tortls.
svn:r9105
2006-12-13 22:46:42 +00:00
Roger Dingledine
8cf8b8087a
when we decide not to mmap, because the file is empty or isn't
...
there at all, don't yell so loud.
svn:r9065
2006-12-11 04:21:10 +00:00
Nick Mathewson
e8dc71ade4
r11444@Kushana: nickm | 2006-12-07 09:38:52 -0500
...
Fix a couple of obvious bugs in tor_mmap_file on Windows: first, fix a boolean error when checking the return value of CreateFileMapping. Second, CreateFileMapping is documented to return NULL on failure.
svn:r9035
2006-12-07 14:39:42 +00:00
Roger Dingledine
936f075f11
help ftello find its prototype
...
svn:r9016
2006-12-02 23:08:55 +00:00
Roger Dingledine
c5b90daf86
cleanups, bump to 0.1.2.4-alpha
...
svn:r9015
2006-12-02 22:47:46 +00:00
Nick Mathewson
facc49cf6f
r9371@totoro: nickm | 2006-11-21 10:59:28 -0500
...
Fix a trivial comment.
svn:r8979
2006-11-21 23:50:21 +00:00
Nick Mathewson
d6cc235eba
r9315@totoro: nickm | 2006-11-13 22:40:59 -0500
...
Fix a build warning on angela-sid
svn:r8949
2006-11-14 03:41:05 +00:00
Nick Mathewson
9243e54177
r9313@totoro: nickm | 2006-11-13 20:07:41 -0500
...
Try to compile with fewer warnings on irix64's MIPSpro compiler /
environment, which apparently believes that:
- off_t can be bigger than size_t.
- only mean kids assign things they do not subsequently inspect.
I don't try to fix the "error" that makes it say:
cc-3970 cc: WARNING File = main.c, Line = 1277
conversion from pointer to same-sized integral type (potential portability
problem)
uintptr_t sig = (uintptr_t)arg;
Because really, what can you do about a compiler that claims to be c99
but doesn't understand that void* x = NULL; uintptr_t y = (uintptr_t) x;
is safe?
svn:r8948
2006-11-14 01:07:52 +00:00
Roger Dingledine
3d6b97399f
Avoid assert failure when our cached-routers file is empty on startup.
...
(reported by revstray)
svn:r8928
2006-11-12 07:09:22 +00:00
Nick Mathewson
50771a6b48
r9380@Kushana: nickm | 2006-10-24 21:25:07 -0400
...
Add string.h include to compat.h so that strlcpy() and strlcat() will always be defined after including compat.h. This should resolve warnings on centos.
svn:r8824
2006-10-25 01:25:17 +00:00
Roger Dingledine
0459db2c0d
checkpoint some changes as i read diffs
...
svn:r8780
2006-10-20 19:11:12 +00:00
Nick Mathewson
c8c36dd227
r9304@dhcp-18-188-67-85: nickm | 2006-10-20 12:22:46 -0400
...
Change HT_INIT from a special-case to a macro-calling-a-function like the rest of ht.h. This might prevent errors if somebody did, I dunno, "HT_INIT(tp, hashtable++)". Based on a patch from Watson Ladd.
svn:r8776
2006-10-20 16:22:53 +00:00
Roger Dingledine
dcd33ef599
i saw somebody on #tor paste a string where these were
...
null. better safe than sorry.
svn:r8767
2006-10-20 00:12:02 +00:00
Nick Mathewson
7551c44a53
r9274@Kushana: nickm | 2006-10-19 16:16:58 -0400
...
Add unit tests for tor_mmap_file(); make tor_mmap_t.size always be the size of the file (not the size of the mapping); add an extra argument to read_file_to_str() so it can return the size of the result string.
svn:r8762
2006-10-19 23:05:02 +00:00
Nick Mathewson
17abfa6a6a
r8971@totoro: nickm | 2006-10-09 10:16:23 -0400
...
Move definition of ssize_t to torint.h
svn:r8670
2006-10-09 15:47:08 +00:00
Nick Mathewson
e618c15aff
r8967@totoro: nickm | 2006-10-08 23:38:50 -0400
...
Fix some test and warn failures in last commit
svn:r8665
2006-10-09 03:39:06 +00:00
Nick Mathewson
c6f2d725d0
r8957@totoro: nickm | 2006-10-08 22:35:17 -0400
...
The otherwise regrettable MIPSpro C compiler warns about values set but never used, and about mixing enums and ints; these are good warnings, and so should be fixed. This removes some dead code and some potential bugs. Thanks to pnx.
svn:r8664
2006-10-09 02:35:51 +00:00
Andrew Lewman
563be121c2
Add missing return so this builds on mingw.
...
svn:r8649
2006-10-08 18:24:31 +00:00
Nick Mathewson
f07f7a7a12
r8923@totoro: nickm | 2006-10-07 11:44:33 -0400
...
More doxygen comments
svn:r8637
2006-10-07 16:25:28 +00:00
Roger Dingledine
f2bd0e2f16
more minor cleanups
...
svn:r8630
2006-10-07 06:28:50 +00:00
Roger Dingledine
881d23847a
fix something that looked scary to me. i believe this won't
...
change any behavior currently, but it will avoiding calling
noop code that might change for the worse some time.
nick, please confirm.
svn:r8623
2006-10-07 00:52:23 +00:00
Roger Dingledine
06e5b2283c
minor cleanups
...
svn:r8622
2006-10-07 00:50:39 +00:00
Nick Mathewson
29fa9eb216
r8860@totoro: nickm | 2006-10-03 14:48:33 -0400
...
Use ANSI-style definition syntax in strlcat.c and strlcpy.c so that gcc stops barfing with -Wold-style-definition
svn:r8591
2006-10-03 19:00:07 +00:00
Nick Mathewson
4c56ac93ca
r8851@totoro: nickm | 2006-10-02 18:13:27 -0400
...
Remove/clarify some XXXs for no longer being accurate; for begin things we do not indend to fix; for already being parts of big todo issues (like "/* XXX ipv6 */"); etc. Also fix some spaces.
svn:r8580
2006-10-02 22:13:42 +00:00
Nick Mathewson
bff83b666c
r8846@totoro: nickm | 2006-10-02 16:59:57 -0400
...
Move is_local_IP to config.c; have it check for same-/24; make it used only for reachability (not for banwidth, because that is probably not what we want). Fixes an XXX.
svn:r8578
2006-10-02 21:00:35 +00:00
Nick Mathewson
d75edc35cc
r8845@totoro: nickm | 2006-10-02 16:34:58 -0400
...
Fix an XXXX: make path_is_relative work on windows even though we never use it there.
svn:r8577
2006-10-02 21:00:24 +00:00
Nick Mathewson
36adc7cdd9
r8844@totoro: nickm | 2006-10-02 16:32:44 -0400
...
Resolve an XXXX: make sure that we are actually on 2s-complement hardware.
svn:r8576
2006-10-02 21:00:20 +00:00
Nick Mathewson
219ad6395c
r8825@totoro: nickm | 2006-10-01 17:41:27 -0400
...
Add function to return a random uint64_t.
svn:r8570
2006-10-01 21:59:05 +00:00
Nick Mathewson
c2d304366b
r9032@Kushana: nickm | 2006-09-29 18:51:42 -0400
...
Now, all log messages should be distinct.
svn:r8545
2006-09-29 22:51:47 +00:00
Nick Mathewson
7d366f61cb
r9025@Kushana: nickm | 2006-09-29 18:33:13 -0400
...
Differentiate more duplicated log entries
svn:r8542
2006-09-29 22:33:40 +00:00
Nick Mathewson
8308a37908
r9023@Kushana: nickm | 2006-09-29 17:27:24 -0400
...
Make distinct all non-bug messages at notice or higher that appear 3 or more times.
svn:r8541
2006-09-29 22:33:34 +00:00
Nick Mathewson
87648bdcf8
r9008@Kushana: nickm | 2006-09-29 13:50:10 -0400
...
Doxygen comments for code in common. Also simplify a few code paths to be more clear/speedy/correct.
svn:r8536
2006-09-29 18:13:37 +00:00
Nick Mathewson
05604c60d4
r9006@Kushana: nickm | 2006-09-29 10:48:23 -0400
...
Omit function names from NOTICE, WARN and ERR messages unless they are in LD_BUG.
svn:r8534
2006-09-29 18:13:29 +00:00
Nick Mathewson
d3a06684bc
r8974@Kushana: nickm | 2006-09-28 17:05:59 -0400
...
Improvement to last entry guards patch: track when we last attempted to connect to a node in our state file along with how long it has been unreachable. Also clarify behavior of parse_iso_time() when it gets extra characters.
svn:r8520
2006-09-28 23:57:49 +00:00
Nick Mathewson
95132f836a
r8750@totoro: nickm | 2006-09-27 20:52:01 -0400
...
Fix some warnings on mingw; hopefully this should let us build on mingw without warnings.
svn:r8509
2006-09-28 00:53:02 +00:00
Nick Mathewson
0f8491a254
Backport candidate: remove dangerous free(0) on hashtable init
...
svn:r8499
2006-09-25 16:06:09 +00:00
Nick Mathewson
78c068397a
add missing paren in dmalloc tor_free
...
svn:r8498
2006-09-25 15:44:40 +00:00
Nick Mathewson
7c21dabef1
r8878@Kushana: nickm | 2006-09-21 17:15:47 -0400
...
Trivial whitespace cleanups.
svn:r8443
2006-09-21 21:48:55 +00:00
Nick Mathewson
b2cc52fa02
Speed up eat_whitespace by a lot.
...
svn:r8434
2006-09-19 23:55:35 +00:00
Nick Mathewson
6b716fdfb9
NEEDS REVIEW. Act on previous comment, and handle named servers differently: now, we allow multiple servers with the same name in the routerlist even if that name is reserved, but we check whether names are reserved when we try to look up routers by nickname. This is a minor security fix. This makes router_add_to_routerlist O(1). This is a backport candidate.
...
svn:r8433
2006-09-19 23:48:14 +00:00
Nick Mathewson
2d4950c837
Malloc and friends are critical-path: Thus, add an it-wont-happen branch prediction for NULL returns, and skip the malloc(0) check on platforms where malloc(0) returns a pointer.
...
svn:r8431
2006-09-19 22:36:48 +00:00
Nick Mathewson
7b0ec744bc
Switch routerlist.c to using memcmp on digests rather than crypto_pk_cmp_keys(); speed up find_whitespace a lot (8x for me) by using a switch statement. This should speed parsing a lot of routers at once by a lot.
...
svn:r8430
2006-09-19 22:20:09 +00:00
Nick Mathewson
93beeac01d
Merge in some bsockets calls, all wrapped inside #if defined(USE_BSOCKETS)
...
svn:r8427
2006-09-19 20:41:31 +00:00
Nick Mathewson
e58b9c1151
r8819@Kushana: nickm | 2006-09-15 00:27:45 -0400
...
Implement a smartlist_uniq() that will with luck not end the world.
svn:r8396
2006-09-15 04:27:58 +00:00
Peter Palfrader
28cac25d7e
r9749@danube: weasel | 2006-09-14 06:53:12 +0200
...
Do not graciously increase the size to be mmaped if the current size already is
at a page_size boundary. This is important since if a file has a size of zero
and we mmap() it with length > 0, then accessing the mmaped memory area causes
a bus error. However, if we pass a length of 0 to mmap() it will return with -1
and things work from there.
svn:r8387
2006-09-14 04:53:42 +00:00
Roger Dingledine
9af3175687
parameterize the loudness of get_interface_address()
...
svn:r8358
2006-09-09 19:20:27 +00:00
Roger Dingledine
5f6351ceb3
fix typo, add log message
...
svn:r8357
2006-09-09 19:16:07 +00:00
Nick Mathewson
365ccf0742
r8725@Kushana: nickm | 2006-09-06 04:39:29 -0400
...
spawn_func fixes: have cpuworker_main and dnsworker_main confirm to the right interfaces [casting func to void* is icky]. Also, make pthread_create() build without warnings.
svn:r8327
2006-09-06 08:42:20 +00:00
Nick Mathewson
000b7b287c
r8724@Kushana: nickm | 2006-09-06 04:32:28 -0400
...
Fix spaces; restore support for mapping files over 4GB on win32 (?)
svn:r8326
2006-09-06 08:42:16 +00:00
Mike Chiussi
6ec9c1092a
- made configure check if we are building for win32
...
- made configure link to required system dll's if building for win32
- added diffs for libevent 1.1b
- forced user to turn off eventdns if win32 is set
- cleaned up tor_mmap_file()_win32 (not sure if it's stable)
- cleaned up some warnings and typos
svn:r8322
2006-09-06 01:49:55 +00:00
Nick Mathewson
c4ac4bcba3
r8696@Kushana: nickm | 2006-08-31 14:43:44 -0400
...
Try to appease some warnings with newer gccs that believe that ignoring a return value is okay, but casting a return value and then ignoring it is a sign of madness.
svn:r8312
2006-08-31 18:47:54 +00:00
Nick Mathewson
f170e5798f
r8692@Kushana: nickm | 2006-08-31 13:38:07 -0400
...
Fix bug 327 (part 2): Cast char to unsigned char before passing to toupper/tolower. (Follow the same idiom as with isupper and friends, in case we run into the same problem on SGI or whereever it was.)
svn:r8310
2006-08-31 17:39:51 +00:00
Nick Mathewson
bc0c39f85d
r8691@Kushana: nickm | 2006-08-31 13:30:46 -0400
...
Fix bug 327 (part 1): Use correct macro to test for GCC 3 or later.
svn:r8309
2006-08-31 17:39:47 +00:00
Nick Mathewson
fee33d2ff1
r8682@Kushana: nickm | 2006-08-29 17:58:59 -0400
...
Fix compilation on GCC2 by disabling fun attributes unless __GNUC_MAJOR__ >= 3.
svn:r8303
2006-08-29 21:59:20 +00:00
Nick Mathewson
6fcdcc7fc7
r8626@Kushana: nickm | 2006-08-27 23:45:46 -0400
...
Aw, crap. Non-gcc bug. We need regular windows builds.
svn:r8259
2006-08-28 03:46:21 +00:00
Roger Dingledine
9f5856c03d
stop three memory leaks. nick, fix these if i'm wrong.
...
svn:r8235
2006-08-27 02:07:54 +00:00
Nick Mathewson
b050ecf86c
r7404@Kushana: nickm | 2006-08-16 09:32:19 -0400
...
Pass hints to getaddrinfo; fix bug 280 (?)
svn:r7069
2006-08-16 18:47:19 +00:00
Roger Dingledine
4b94dabb53
note a compile warning that we should investigate one day.
...
svn:r7052
2006-08-14 09:44:54 +00:00
Nick Mathewson
b68ffcc193
r7341@Kushana: nickm | 2006-08-11 00:51:05 -0700
...
Amazing how much difference adding a ! to all your asserts can make.
svn:r7029
2006-08-11 07:51:34 +00:00
Nick Mathewson
33fc829273
r7337@Kushana: nickm | 2006-08-11 00:42:04 -0700
...
Only use __builtin_offsetof with gcc 4 or later
svn:r7028
2006-08-11 07:42:11 +00:00
Nick Mathewson
42a5d7a4ba
r7335@Kushana: nickm | 2006-08-11 00:13:03 -0700
...
fix wide lines
svn:r7025
2006-08-11 07:17:16 +00:00
Nick Mathewson
ffab3b48a8
r7326@Kushana: nickm | 2006-08-10 23:50:49 -0700
...
And another GCC change: predict that tor_frees() are usually real frees, and tor_asserts() usually wont happen. Other test should wait till -fprofile-arcs
svn:r7022
2006-08-11 07:09:35 +00:00
Nick Mathewson
4eddbcf262
r7325@Kushana: nickm | 2006-08-10 23:37:31 -0700
...
Use gcc offsetof where available.
svn:r7021
2006-08-11 07:09:28 +00:00
Nick Mathewson
09a895e222
r7324@Kushana: nickm | 2006-08-10 23:23:15 -0700
...
Add more warnings to the list of those we tolerate. Start using GCC attributes more, for better error checking and better code generation.
svn:r7020
2006-08-11 07:09:17 +00:00
Nick Mathewson
1b7ad5aed3
r7030@Kushana: nickm | 2006-08-04 14:46:52 -0700
...
Close an fd leak on failed mmap()
svn:r6988
2006-08-05 17:53:32 +00:00
Nick Mathewson
7c596c166b
r7029@Kushana: nickm | 2006-08-04 14:08:41 -0700
...
Remove now-spurious size and data arguments from tor_mmap_file
svn:r6987
2006-08-05 17:53:21 +00:00
Nick Mathewson
dbac3fb481
r7028@Kushana: nickm | 2006-08-04 13:10:16 -0700
...
Make data and size fields visible in tor_mmap_t; hide win magic differently.
svn:r6986
2006-08-05 17:53:08 +00:00
Nick Mathewson
db72fb9cdc
r7025@Kushana: nickm | 2006-08-04 12:03:22 -0700
...
Finish (I hope) windows mmap impl.
svn:r6981
2006-08-04 19:03:40 +00:00
Nick Mathewson
bf72878cad
r7012@Kushana: nickm | 2006-08-03 19:21:25 -0700
...
Add an "mmap handle" type to encapsulate bookkeeping elements of mmap issues; add prelim win32 impl
svn:r6980
2006-08-04 18:32:43 +00:00
Roger Dingledine
e64825126b
turn future seg faults into asserts
...
svn:r6970
2006-08-03 04:23:45 +00:00
Nick Mathewson
80282d8f55
r6993@Kushana: nickm | 2006-07-31 16:19:21 -0400
...
Interesting how much a ! can change the behavior of an assert.
svn:r6962
2006-07-31 20:19:58 +00:00
Nick Mathewson
ea0f5ec8ad
r6980@Kushana: nickm | 2006-07-31 13:18:22 -0400
...
Add a utility function to verify that a string has been through strlower.
svn:r6959
2006-07-31 18:01:37 +00:00
Nick Mathewson
d934607069
r6979@Kushana: nickm | 2006-07-31 13:16:58 -0400
...
Add assert_ok functions for strmap and digestmap; use them in unit test code.
svn:r6958
2006-07-31 18:01:27 +00:00
Nick Mathewson
3843b1b3d0
r6978@Kushana: nickm | 2006-07-31 13:16:14 -0400
...
Add isupper and islower wrappers to compat.h
svn:r6957
2006-07-31 18:01:22 +00:00
Nick Mathewson
2fe537c57a
r6958@Kushana: nickm | 2006-07-29 18:54:15 -0400
...
Looks like we might need a priority queue.
svn:r6953
2006-07-31 17:59:37 +00:00
Nick Mathewson
8786b4b88e
Fix a bug in HT_REMOVE.
...
svn:r6925
2006-07-27 18:35:25 +00:00
Nick Mathewson
45c3a4365f
Get better numbers out of HT_REP_OK
...
svn:r6924
2006-07-27 17:37:37 +00:00
Peter Palfrader
521c006fd5
Remove .cvsignore files from trunk
...
svn:r6891
2006-07-25 01:00:48 +00:00
Nick Mathewson
6d2eb77555
Whitespace fix
...
svn:r6816
2006-07-23 07:19:49 +00:00
Nick Mathewson
35960e1162
Add a mem_is_zero function (I think we will need this) and a STRUCT_OFFSET macro (we already need this).
...
svn:r6810
2006-07-23 05:32:35 +00:00
Nick Mathewson
08a4114abf
Another MSVC6 fix. Grnk.
...
svn:r6802
2006-07-21 14:53:23 +00:00
Nick Mathewson
77c28d112b
Hm. We probably should define INT64_MAX if we really want it. (Especially since we only want it on one platform, where, coincidentally, it is not defined.)
...
svn:r6784
2006-07-18 02:01:32 +00:00
Nick Mathewson
e572d5990c
MSVC6 is apparently terrified of unnatural cross-breeding between uint64_t and double, and needs more persuasion than usual to cast one to the other. Issue identified by Frediano Ziglio; patch revised for minimal impact on non-MSVC6 compilers.
...
svn:r6768
2006-07-17 00:39:05 +00:00
Roger Dingledine
3d79eb52ab
stick to nick's nul/null convention
...
svn:r6763
2006-07-15 19:21:30 +00:00
Nick Mathewson
28a7c8a64c
Make compilation work on old MSVCs without GetVertsionEx magic. Patch from Frediano Ziglio.
...
svn:r6749
2006-07-09 22:29:12 +00:00
Roger Dingledine
fad85f173a
when an exit node gets a malformed begin cell, don't complain to
...
the node operator, since he can't do anything about it.
svn:r6733
2006-07-06 02:44:07 +00:00
Roger Dingledine
12cc290a7d
ok, i'm not allowed to say that there. oh well.
...
svn:r6720
2006-07-04 16:11:35 +00:00
Roger Dingledine
579849f600
fix a misleading function comment
...
svn:r6717
2006-07-04 15:52:22 +00:00
Roger Dingledine
5dc1e6f788
if we're the server-side of the tls and there are problems,
...
don't yell as loudly.
svn:r6716
2006-07-04 15:51:59 +00:00
Roger Dingledine
35e95d7783
minor fixes
...
svn:r6710
2006-07-04 03:25:07 +00:00
Nick Mathewson
05eff35ac6
Harmless: Z_OK is not an acceptable answer to Z_FINISH.
...
svn:r6701
2006-06-29 11:17:36 +00:00
Nick Mathewson
1cd04abf1a
Actually enable mmap. That should improve matters.
...
svn:r6694
2006-06-28 08:54:32 +00:00
Nick Mathewson
06e09cdd47
Apparently, zlib sometimes reports Z_BUF_ERROR on input exhaustion as well as on running out of output space. This could well fix the assert bug reported by weasel and arma.
...
svn:r6682
2006-06-24 02:06:52 +00:00