Nick Mathewson
eb54a856a2
Add test to make sure all confparse variables are well-typed
...
New approach, suggested by Taylor: During testing builds, we
initialize a union member of an appropriate pointer type with the
address of the member field we're trying to test, so we can make
sure that the compiler doesn't warn.
My earlier approach invoked undefined behavior.
2017-09-26 12:24:04 -04:00
Nick Mathewson
ce4ac7aace
add changes file for 23645
2017-09-26 08:57:10 -04:00
Nick Mathewson
1f3db0514e
Merge remote-tracking branch 'asn/ticket23645_032_01'
2017-09-26 08:55:59 -04:00
David Goulet
648d5ea67e
hs: Improve logging
...
Also demote a log message that can occur under natural causes
(if the circuit subsystem is missing descriptors/consensus etc.).
The HS subsystem will naturally retry to connect to intro points,
so no need to make that log user-facing.
2017-09-26 13:55:44 +03:00
David Goulet
4190f602bd
circuit: Log n_circ_id and global identifier of HS circuits
...
So we can track them more easily in the logs and match any open/close/free
with those identifiers.
Part of #23645
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-25 16:21:04 -04:00
David Goulet
767b1815e9
circuit: Log circuit identifiers when cannibalizing
...
This removes the "nickname" of the cannibalized circuit last hop as it is
useless. It now logs the n_circ_id and global identifier so we can match it
with other logging statement.
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-25 16:08:11 -04:00
David Goulet
fb4a82c485
circuit: Keep a copy of n_circ_id for logging
...
Prior to the log statement, the circuit n_circ_id value is zeroed so keep a
copy so we can log it at the end.
Part of #23645
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-25 16:04:30 -04:00
David Goulet
de54e14312
circuit: Closing reason are signed values
...
Part of #23645
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-25 16:01:12 -04:00
Nick Mathewson
45530ed729
Merge branch 'bug22109'
2017-09-25 14:32:04 -04:00
Nick Mathewson
81c4793232
Make testing rend1_payload variables static
...
This fixes a clang warning.
2017-09-25 13:26:43 -04:00
Nick Mathewson
90e8d1f58f
Merge branch 'bug23539_032_01_squashed'
2017-09-25 11:12:56 -04:00
Nick Mathewson
581e2c8b2c
Whitespace fix.
2017-09-25 11:12:45 -04:00
Matt Traudt
7bbc29b0f2
sched: make interval a plain int; initialize with macro
2017-09-25 11:11:30 -04:00
David Goulet
ef2a449cce
sched: Make KISTSchedRunInterval non negative
...
Fixes #23539 .
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-25 11:11:30 -04:00
Nick Mathewson
f82f1f4b8c
fix changes file
2017-09-25 09:29:11 -04:00
Nick Mathewson
777e828ef3
Merge remote-tracking branch 'asn/ticket23420_032_01'
2017-09-25 09:24:36 -04:00
George Kadianakis
03b3f5486a
prop224: Add test for parsing RENDEZVOUS1 cell.
...
Just making sure that added padding does not screw up cell parsing.
2017-09-25 15:00:06 +03:00
Roger Dingledine
a1f31c0671
fix typo
2017-09-22 17:26:29 -04:00
Nick Mathewson
cbea334d6b
Mention even more about changes files in doc/HACKING
2017-09-22 15:14:36 -04:00
Nick Mathewson
22e2c3bf7d
Fix check-spaces and a weird copyright.
2017-09-22 12:20:26 -04:00
Nick Mathewson
230a336798
Use setup_full_capture_of_logs for 21800
...
setup_capture_of_logs() doesn't actually suppress warnings :p
2017-09-22 10:22:47 -04:00
Nick Mathewson
ac3fdb74c2
Remove unused chosen_scheduler_type variable.
2017-09-22 09:56:54 -04:00
Nick Mathewson
122eab78d9
Merge remote-tracking branch 'pastly/bug23552_032_03'
2017-09-22 09:54:41 -04:00
Nick Mathewson
9b02641812
Merge branch 'maint-0.3.0' into maint-0.3.1
2017-09-22 09:09:17 -04:00
Nick Mathewson
cce936aee0
Merge branch 'maint-0.3.1'
2017-09-22 09:09:17 -04:00
David Goulet
dc5c9af6c3
hs: Avoid possible double circuit close on error
...
Fixes #23610
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-22 09:09:13 -04:00
Nick Mathewson
91467e04b1
Merge branch 'bug22805_v2_squashed'
2017-09-22 08:58:17 -04:00
Nick Mathewson
95a7e7e925
Stop using CREATE_FAST as a signifier of clienthood.
...
Relays send it, and we may as well let them. Part of our fix for
22805.
2017-09-22 08:57:45 -04:00
Nick Mathewson
6a75a6fd9a
changes file for bug22805
2017-09-22 08:55:53 -04:00
Nick Mathewson
ceb49c1c5f
Use channel_is_client() accessor in channelpadding.c.
...
Also, allow channel_is_client() to take a const channel.
2017-09-22 08:55:53 -04:00
Nick Mathewson
d1e0e486e9
Stop clearing the is_client flag on channel directly
2017-09-22 08:55:53 -04:00
Nick Mathewson
66aff2d8f3
Remove or_circuit_t.is_first_hop; use channel_is_client() instead
...
The is_first_hop field should have been called used_create_fast,
but everywhere that we wanted to check it, we should have been
checking channel_is_client() instead.
2017-09-22 08:55:53 -04:00
Matt Traudt
88b317ef28
sched: move code to respect comments
...
The diff is confusing, but were two static scheduler functions that
needed moving to static comment block.
No code change. Thanks dgoulet for original commit
2017-09-22 08:52:27 -04:00
Matt Traudt
22699e3f16
sched: only log when scheduler type changes
...
Closes 23552. Thanks dgoulet for original impl
2017-09-22 08:51:22 -04:00
Nick Mathewson
512c57cff9
test_util: capture the log in the correct place.
2017-09-22 08:51:03 -04:00
Nick Mathewson
00d7b60557
Merge branch 'bug21800'
2017-09-21 17:39:54 -04:00
Nick Mathewson
6203047e1f
check-changes fix
2017-09-21 17:34:47 -04:00
Nick Mathewson
bb9b8e65bb
Merge remote-tracking branch 'pastly/bug23581_032_03'
2017-09-21 17:33:10 -04:00
Nick Mathewson
9af06bdd1e
Whoops; only run lintchanges when usepython
2017-09-21 17:32:17 -04:00
Nick Mathewson
2032d7ca6f
Update CodingStandards.md for changes-file stuff
...
'check-changes' is now part of "make check", and must pass.
2017-09-21 16:39:49 -04:00
Nick Mathewson
c3f126f753
Whoops -- put a changes file in the wrong place :(
2017-09-21 16:29:15 -04:00
Nick Mathewson
f118c0216b
Fix warning in bug23610
2017-09-21 16:27:09 -04:00
Nick Mathewson
68df19049b
Merge branch 'ticket23564_squashed'
2017-09-21 16:25:30 -04:00
Nick Mathewson
3c04c8317f
Make check-spaces part of the standard "make check" process
...
To do this, we had to make sure it passes when the changes directory
is empty. I also tried to improve the quality of the output, and
fix some false-positive cases. Let's see how this goes!
Closes ticket 23564.
2017-09-21 16:25:24 -04:00
Nick Mathewson
33d44dc4ac
Capture "Result does not fit in tor_timegm()" warnings in util tests
...
Fixes bug 21800; bugfix on 0.2.9.x
2017-09-21 15:32:16 -04:00
Nick Mathewson
b2f3b3b7eb
Merge remote-tracking branch 'dgoulet/ticket23303_032_01'
2017-09-21 14:43:05 -04:00
Nick Mathewson
e1d8a4bd72
Merge remote-tracking branch 'catalyst-oniongit/bug23611'
2017-09-21 14:42:03 -04:00
Nick Mathewson
c92ecac8bb
Merge branch 'maint-0.3.1'
2017-09-21 14:39:17 -04:00
David Goulet
7f3dc8327a
hs: Avoid possible double circuit close on error
...
Fixes #23610
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-21 14:38:43 -04:00
Taylor Yu
87faed921e
Remove wrong config parameter mention from manpage
...
Don't refer to the obsolete (and misspelled)
UseEntryGuardsAsDirectoryGuards config parameter in the manpage.
2017-09-21 13:31:54 -05:00
