Nick Mathewson
6d33f65638
Use the correct function signatures in test_relaycell.c
...
This is now officially an antipattern: please let's never copy a
function declaration in two places again. That's what headers are
for.
2018-09-18 15:51:11 -04:00
Nick Mathewson
7ace8d5a61
Assert that some trunnel _new() functions return non-NULL
...
The trunnel functions are written under the assumption that their
allocators can fail, so GCC LTO thinks they might return NULL. In
point of fact, they're using tor_malloc() and friends, which can't
fail, but GCC won't necessarily figure that out.
Fixes part of #27772 .
2018-09-18 14:43:57 -04:00
Nick Mathewson
620108ea77
Assert that we aren't returning a pointer to a local variable.
...
GCC got confused here with LTO enabled.
Fixes part of #27772 .
2018-09-18 14:34:49 -04:00
Nick Mathewson
ea5792f333
Make crypto_strongest_rand() non-mockable
...
Instead, have it call a mockable function. We don't want
crypto_strongest_rand() to be mockable, since doing so creates a
type error when we call it from ed25519-donna, which we do not build
in a test mode.
Fixes bug 27728; bugfix on 0.3.5.1-alpha
2018-09-18 12:40:18 -04:00
teor
7bf9c93ab3
Merge remote-tracking branch 'nickm/bug27741_033' into bug27741_035
...
Resolve conflicts due to rustfmt, and run rustfmt on the merged code.
2018-09-18 23:32:57 +10:00
Nick Mathewson
50367d06f2
Merge remote-tracking branch 'tor-github/pr/352'
2018-09-18 08:44:58 -04:00
Nick Mathewson
52191064ac
Merge branch 'maint-0.3.4'
2018-09-18 08:33:13 -04:00
Nick Mathewson
2ddbaf9cdc
Merge branch 'maint-0.3.3' into maint-0.3.4
2018-09-18 08:31:14 -04:00
Nick Mathewson
75b95e1c8e
Merge remote-tracking branch 'onionk/rust-allsupported1' into maint-0.3.3
2018-09-18 08:31:08 -04:00
Nick Mathewson
4199c8b2d0
Merge remote-tracking branch 'github/bug27073_029'
2018-09-18 08:16:42 -04:00
Nick Mathewson
9252814646
Merge remote-tracking branch 'tor-github/pr/344'
2018-09-18 08:15:02 -04:00
Nick Mathewson
5ef998fbf5
Changes file for 27764
2018-09-18 08:12:46 -04:00
Nick Mathewson
50001d1c5b
Merge remote-tracking branch 'asn-github/bug27764'
2018-09-18 08:10:25 -04:00
Nick Mathewson
7ca0f66b82
Bump to 0.3.5.1-alpha-dev
2018-09-18 07:52:27 -04:00
George Kadianakis
43324b0e4d
Fix minor memleak in edge-case of crypto_rsa.c function.
2018-09-18 14:01:15 +03:00
teor
3eafa61f63
check-changes: Warn about bugfixes on future releases
...
Warn when bugfix changes files say that the bug is in a future release.
Closes ticket 27761.
2018-09-18 20:40:50 +10:00
teor
7e862c3ec0
check-changes: Check bugfix version formatting
...
Check that bugfix versions in changes files look like Tor versions
from the versions spec.
Part of ticket 27761.
2018-09-18 20:40:44 +10:00
teor
49ffc03572
Travis: use the Homebrew addon for xz and zstd
...
xz and zstd were added as optional dependencies in 0.3.1.1-alpha.
Implements ticket 27738.
2018-09-18 19:37:16 +10:00
teor
e81001a088
Merge branch 'bug27738-029' into bug27738-032
...
Resolve conflicts due to modified comments, and deleted lines.
2018-09-18 19:34:53 +10:00
teor
e8c7d7d3be
Travis: use the Homebrew addon
...
Use the Travis Homebrew addon to install packages on macOS. The package
list is the same, but the Homebrew addon does not do a `brew update` by
default.
This makes builds faster, at the cost of using slightly older packages.
Implements ticket 27738.
2018-09-18 19:26:54 +10:00
Nick Mathewson
1f9055c884
Merge remote-tracking branch 'teor/ticket27757'
2018-09-17 21:43:34 -04:00
teor
4e50db573a
ChangeLog: add onion service versions to the Tor2web deprecation notice
...
Tor2web was never implemented for v3 onion services.
2018-09-18 11:36:49 +10:00
teor
073953716b
ChangeLog: the ContactInfo UTF-8 requirement is a major UI change
...
(Even if it only affects a few relay operators.)
2018-09-18 11:36:46 +10:00
teor
5b3b7f8e26
ChangeLog: bugfixes are on previous releases, not this release
2018-09-18 11:36:39 +10:00
teor
ab0203dd1e
ChangeLog: delete both consensus flavours to un-break nss
...
The required protocol version check occurs before the consensus flavour
check. So on directory mirrors (and some client configs), alpha users need
to delete both consensus flavours to workaround nss bugs.
Closes ticket 27756.
2018-09-18 10:42:59 +10:00
Mike Perry
8a83c4b613
Merge branch 'bug23512-v4-033' into bug23512-v4-master
2018-09-18 00:17:14 +00:00
Mike Perry
ad10cafd9f
Bug 23512: Test fix: cmux is now allocated by new_fake_channel()
2018-09-17 23:31:48 +00:00
Mike Perry
72cef61028
Merge branch 'bug23512-v4-032' into bug23512-v4-033
2018-09-17 23:31:34 +00:00
Mike Perry
dd15998d28
Remove duplicate TLS define from kist code.
...
Duplicate comes from introducing this define into 0.2.9, which did not yet
have KIST.
2018-09-17 23:21:58 +00:00
Mike Perry
dfd3823047
Bug 23512: Mock assert_circuit_ok in tests.
...
This mocking was not available in 0.2.9.
2018-09-17 23:12:53 +00:00
Mike Perry
36e81e1f59
Merge branch 'bug23512-v4-029' into bug23512-v4-032
2018-09-17 23:12:45 +00:00
Mike Perry
6af352172d
Bug 23512: Test recording bytes in circ queues.
2018-09-17 22:24:25 +00:00
Mike Perry
2ceda207d3
Bug 23512: Changes file.
2018-09-17 22:19:43 +00:00
Mike Perry
bbaa398d26
Bug 23512: Report queued cells on or circs as written.
...
This avoids asymmetry in our public relay stats, which can be exploited for
guard discovery and other attacks.
2018-09-17 22:19:42 +00:00
Mike Perry
7dc435e6bc
Promote rep_hist bw functions to uint64_t.
...
The rest of rephist uses uint64_t internally. Let's make these take it too,
so we don't have to worry about overflowing size_t on 32 bit systems.
2018-09-17 22:19:05 +00:00
Nick Mathewson
aebc98d58c
More changelog edits
2018-09-17 16:35:13 -04:00
Nick Mathewson
3d80246a4e
Write a blurb, pull UI changes to the front, edit
2018-09-17 16:04:30 -04:00
Nick Mathewson
765caaea77
Light edits on changelog. mostly combining sections.
2018-09-17 15:42:29 -04:00
Nick Mathewson
80ad15921c
Remove extraneous argument from Rust protover_compute_vote()
...
This argument was added to match an older idea for the C api, but we
decided not to do it that way in C.
Fixes bug 27741; bugfix on 0.3.3.6 / TROVE-2018-005 fix.
2018-09-17 11:57:56 -04:00
Nick Mathewson
4fd761a418
Make CacheDirectoryGroupReadable an autobool.
...
Since the default cache directory is the same as the default data
directory, we don't want the default CacheDirectoryGroupReadable
value (0) to override an explicitly set "DataDirectoryGroupReadable
1".
To fix this, I'm making CacheDirectoryGroupReadable into an
autobool, and having the default (auto) value mean "Use the value of
DataDirectoryGroupReadable if the directories are the same, and 0
otherwise."
Fixes bug 26913; bugfix on 0.3.3.1-alpha when the CacheDirectory
option was introduced.
2018-09-17 11:44:59 -04:00
Nick Mathewson
f606b3cfd1
Lower the maximum size of a private key file to 16 MB
...
This shouldn't be a user-visible change: nobody has a 16 MB RSA
key that they're trying to use with Tor.
I'm doing this to fix CID 1439330 / ticket 27730, where coverity
complains (on 64-bit) that we are making a comparison that is never
true.
2018-09-17 11:08:56 -04:00
Nick Mathewson
307275a5e4
Bump to 0.3.5.1-alpha
2018-09-17 09:12:42 -04:00
Nick Mathewson
b96e2ab341
Start a changelog for 0.3.5.1-alpha
2018-09-17 09:12:10 -04:00
Nick Mathewson
b729bc202c
Add tortls.h includes to expose critical macro. Fix #27734 .
2018-09-16 22:08:02 -04:00
Nick Mathewson
a8ac21fbb5
Don't try to link C from rust doctests for nss detection
...
This is really annoying, since we can't use cfg(test) for doctests.
2018-09-16 14:34:31 -04:00
Nick Mathewson
078debb0de
Merge branch 'bug25573-034-typefix'
2018-09-16 13:46:12 -04:00
Nick Mathewson
7fd61cf536
Fix duplicate declaration of pathbias_count_valid_cells.
2018-09-16 13:45:43 -04:00
Nick Mathewson
991bec67ee
When Tor is compiled with NSS, don't claim support for LinkAuth=1
...
Closes ticket 27288
2018-09-16 13:28:29 -04:00
traumschule
863e2fcb48
Update description of onion_extend_cpath() ( #27333 )
2018-09-16 04:01:17 +02:00
cypherpunks
1ed5e009cb
rust/protover: reject extra commas
...
The C implementation had gotten this wrong too, in a slightly different way.
Introduced in 5af03c1ef3
.
Fixes #27197 ; bugfix on 0.3.3.3-alpha.
2018-09-15 23:19:31 +00:00