nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-11 13:43:47 +01:00
Code Issues Packages Projects Releases Wiki Activity
4,874 Commits 53 Branches 630 Tags 125 MiB
bf2be9abd7
Commit Graph

2682 Commits

Author SHA1 Message Date
Roger Dingledine
8585599965 correct "your server is reachable" log entries to indicate that it was 
self-testing that told us so.


svn:r5034
 2005-09-13 21:39:42 +00:00
Roger Dingledine
26cc51ffea a bit more code cleanup 
svn:r5033
 2005-09-13 21:24:51 +00:00
Nick Mathewson
890847d232 I forgot -- smart kids make their code compile. 
svn:r5032
 2005-09-13 21:18:00 +00:00
Nick Mathewson
4efa652a98 add docs, fix whitespace, and make ANY rule in routerparse a little tighter. 
svn:r5031
 2005-09-13 21:14:55 +00:00
Nick Mathewson
76351b8416 Fix DOCDOC entries in routerlist.c. Make more functions use SMARTLIST_FOREACH instead of raw loops. Replace router_list_superseded implementation with one that has a prayer of working. 
svn:r5027
 2005-09-13 15:32:03 +00:00
Nick Mathewson
29c57b54d4 Add functions to extend and compress new router store logic. (Basic idea: use a journal of newly received router descriptors, and periodically replace the old file. This avoids the "too many files" problem and the "too many rewrites" problem.) 
svn:r5025
 2005-09-13 06:21:10 +00:00
Roger Dingledine
82b3b6249c fix a seg fault if we ask an authdirserver for a descriptor by 
fingerprint but he doesn't know about him.


svn:r5023
 2005-09-13 01:20:26 +00:00
Roger Dingledine
8b0d37096b when the user asked for a rendezvous port that the hidden service 
didn't want to provide, we were sending an IP address back along
with the end cell. fortunately, it was zero. but stop that anyway.


svn:r5022
 2005-09-12 22:05:17 +00:00
Roger Dingledine
569efe61c0 make the patch less likely to bite us later 
svn:r5021
 2005-09-12 21:42:59 +00:00
Nick Mathewson
93c1d37d5f Resolve stack corruption identified by edmanw in connection_edge_end(). Thanks! 
svn:r5020
 2005-09-12 20:57:16 +00:00
Nick Mathewson
39e29738b1 Maybe I should pay more attention to return values and less to clever comments. Fortunately, the aforementioned comments came out against smacking upside the head. 
svn:r5018
 2005-09-12 08:49:21 +00:00
Nick Mathewson
a6271650d5 Versions should be sorted by version. Lexical sorting should be used only as a last resort. 
svn:r5017
 2005-09-12 08:46:37 +00:00
Roger Dingledine
689cb28098 when writing the recommended*versions lines, sort them first. 
this is because weasel put his out of order and told me the code
should take care of it.


svn:r5016
 2005-09-12 08:31:47 +00:00
Roger Dingledine
63bb27f19d be more thorough about noticing when a directory request has failed: 
it has failed not only when the connection attempt fails, but also
if the conn reaches eof before we get a response that we're happy with.


svn:r5013
 2005-09-12 07:36:26 +00:00
Nick Mathewson
3dc5e77b58 Numerous changes to move towards client-side v2 directories. 
connection.c:
- Add some more connection accessor functions to make directory
  download redundancy checking work.

directory.c, or.h, router.c, routerlist.c:
- Start on logic to note when networkstatus downloads fail.

dirserv.c, routerlist.c, routerparse.c:
- Start maintaining an is_named field in routerstatus_t.  Don't
  actually look at it yet.

dirserv.c, routerlist.c:
- Remove expired networkstatus objects.

or.h:
- Make some booleans into bitfields
- Add prototypes

routerlist.c:
- Sort networkstatus list by publication time
- Function to remove old (older than 10 days) networkstatus objects.
- Function to set a list of routerinfo_ts' status info from the
  current set of networkstatus objects.
- Function to tell which routerinfos we need to download based no the
  current set of networkstatus objects.
- Do not launch a networkstatus download if a redundant one is in progress.

routerparse.c:
- Keep router entries in networkstatus sorted by digest.


svn:r5012
 2005-09-12 06:56:42 +00:00
Roger Dingledine
5cebd8df70 remove temporary network-status keyword 
svn:r5007
 2005-09-12 06:14:41 +00:00
Roger Dingledine
89d516f95c clean up the log entry for when a server posts a server descriptor that 
the dirserver doesn't like


svn:r5005
 2005-09-12 06:08:48 +00:00
Nick Mathewson
63dfe2447e Fix bug found by "ca": looking up a non-existent stream for a v1 control connection would cause a segfault. (No backport needed since 0.1.0 had only v0 connections.) 
svn:r5001
 2005-09-12 03:32:30 +00:00
Roger Dingledine
d7d4d4cbbf fix comment and return value for check_software_version_against_directory() 
svn:r4996
 2005-09-11 22:36:50 +00:00
Roger Dingledine
b0a5ba4248 downgrade the dirserver log messages when whining about unreachability 
svn:r4991
 2005-09-10 20:40:16 +00:00
Roger Dingledine
cfe34812eb bugfix: if you gave tor an odd number of command-line arguments, 
we were silently ignoring the last one. now we complain and fail.


svn:r4988
 2005-09-10 04:40:27 +00:00
Roger Dingledine
9b54cd349d break out a new function config_assign_value() that just assigns the 
value it's given, and doesn't do any of their weird clearing or resetting
stuff. use that when we're trying to clear or reset values.


svn:r4984
 2005-09-10 02:42:32 +00:00
Nick Mathewson
d26523e089 Use tor_listdir in test.c instead of duplicating ode. 
svn:r4981
 2005-09-10 01:42:42 +00:00
Roger Dingledine
1d9786a392 generalize route length to three plus one if the exit node is risky. 
svn:r4978
 2005-09-10 01:01:40 +00:00
Nick Mathewson
035b1953eb Add sorting/searching to smartlist 
svn:r4977
 2005-09-09 23:12:54 +00:00
Roger Dingledine
cfa321374d reject ports 465 and 587 by default now too 
svn:r4974
 2005-09-09 22:46:43 +00:00
Nick Mathewson
dcf1e14190 downgrade warning to info 
svn:r4967
 2005-09-09 21:03:57 +00:00
Roger Dingledine
a5ea401b2e a few more hints on a rare but mysterious warning 
svn:r4966
 2005-09-09 20:58:44 +00:00
Nick Mathewson
047e105daf Fix a bug in config_dump: we want to run options_validate on the defaults, not (again, uselessly) on the configuration. This was introduced when we made the config code more generic. 
svn:r4965
 2005-09-09 20:08:26 +00:00
Roger Dingledine
35b78b2d8e clean up the rendezvous warn log msgs, and downgrade some to info 
svn:r4964
 2005-09-09 19:54:28 +00:00
Nick Mathewson
0de64f224e Warn in more detail when network-status serving and fetching fails. Also, fix a small leak. 
svn:r4963
 2005-09-09 19:37:12 +00:00
Roger Dingledine
42f752a0a5 bugfix: we were automatically condemning an exit node (concluding 
its advertised exit policy is different from its real one) as soon
as it refused any requests.
After fixing that bug, another bug appeared: we would try the same
server again and again, since once we learned an IP address for a
hostname, we still kept think of it as the hostname. now pass it to
the remapper before trying to reattach.


svn:r4962
 2005-09-09 06:11:37 +00:00
Roger Dingledine
843550721a stop notifying people about dns worker spawning and culling 
it just freaks them out


svn:r4960
 2005-09-09 02:03:31 +00:00
Roger Dingledine
2065c5f7aa when printing x-forwarded-by headers, don't print the \r 
svn:r4959
 2005-09-09 02:02:20 +00:00
Nick Mathewson
bd911d8612 Fix segfault and memleak when getting many compressed server descs. 
svn:r4956
 2005-09-08 22:00:29 +00:00
Nick Mathewson
659491bbc6 Fix some messages that say "failing". 
svn:r4955
 2005-09-08 21:46:31 +00:00
Nick Mathewson
d410c49965 Clean up some more fingerprint-checking logic 
svn:r4954
 2005-09-08 21:39:39 +00:00
Roger Dingledine
587b513ec0 remove obsolete kludge 
svn:r4953
 2005-09-08 21:36:27 +00:00
Nick Mathewson
9df4716ac3 make it work correctly when we download multiple network-status objects. 
svn:r4952
 2005-09-08 21:28:45 +00:00
Nick Mathewson
4ce0e01848 add conn->requested_resource to connection_t checks. 
svn:r4951
 2005-09-08 21:21:54 +00:00
Nick Mathewson
a938190bdb Iteration is happier when you stop. 
svn:r4950
 2005-09-08 21:20:20 +00:00
Roger Dingledine
e28931dc94 unused variable 
svn:r4949
 2005-09-08 21:12:53 +00:00
Nick Mathewson
4528bbfd9f Resolve some XXXs. Add some others. 
svn:r4947
 2005-09-08 21:01:24 +00:00
Nick Mathewson
c523e106b5 Do not generate more than 2 of each directory type per minute. 
svn:r4946
 2005-09-08 20:47:11 +00:00
Nick Mathewson
18e4d78354 Fix an assert in directory.c. Check received network-status objects against the list we expected to get. Do not let anyone else update our network-status object. 
svn:r4945
 2005-09-08 20:36:40 +00:00
Nick Mathewson
059148f588 Only caches download network-status for now, and they use a different strategy. Add an element to connection_t to remember what we are downloading, and a function to recognize our own fingerprint. 
svn:r4944
 2005-09-08 20:18:15 +00:00
Nick Mathewson
6c4d43c724 Special-case for retrieving own networkstatus by fingerprint: regenerate if dirty! 
svn:r4943
 2005-09-08 19:29:21 +00:00
Roger Dingledine
465aec04c1 when reporting results from a dirserver fetch/post, tell us the 
port for the dirserver too


svn:r4942
 2005-09-08 19:21:48 +00:00
Nick Mathewson
df79dc673b Remove sneaky double declaration. 
svn:r4941
 2005-09-08 19:18:55 +00:00
Nick Mathewson
0f94aa2ea1 Write status to disk in the right place 
svn:r4940
 2005-09-08 19:16:16 +00:00
Nick Mathewson
cc16fb7636 oops -- that log should have been removed 
svn:r4939
 2005-09-08 19:12:55 +00:00
Nick Mathewson
e5f117606f Fix network-status parsing. 
svn:r4938
 2005-09-08 19:10:36 +00:00
Nick Mathewson
b43a720bd4 Fix another reversed inet_aton 
svn:r4937
 2005-09-08 18:53:57 +00:00
Nick Mathewson
1e2f1679c8 Fix some more bugs; add a temporary log. 
svn:r4936
 2005-09-08 18:46:25 +00:00
Nick Mathewson
eab005c948 Ensure case match, not mismatch. 
svn:r4935
 2005-09-08 18:34:41 +00:00
Nick Mathewson
810572a5de Stop dying when we get a directory from tor26; workaround for change in networkstatus format 
svn:r4933
 2005-09-08 18:24:26 +00:00
Roger Dingledine
4633b271f9 fix spacing 
svn:r4932
 2005-09-08 18:15:57 +00:00
Nick Mathewson
548a863779 Avoid assertion failure 
svn:r4931
 2005-09-08 18:14:23 +00:00
Nick Mathewson
ff9452e900 Clean up should-i-go-to-the-dirserv logic a little: All servers with DirPorts should get their directories from the source 
svn:r4930
 2005-09-08 18:14:01 +00:00
Nick Mathewson
3a99927859 Make directory download code slightly less likely to segfault or assert. 
svn:r4929
 2005-09-08 16:18:28 +00:00
Roger Dingledine
022f23249f make doxygen output look prettier 
svn:r4928
 2005-09-08 07:10:12 +00:00
Roger Dingledine
dbeb8e7863 it really does help with the functions end. 
svn:r4927
 2005-09-08 06:59:58 +00:00
Roger Dingledine
74fb086210 if you give a config option in the torrc or the commandline with no 
value, and reset is false, then it clears it entirely.


svn:r4926
 2005-09-08 06:55:53 +00:00
Roger Dingledine
36fa360c11 and fix grammar 
svn:r4925
 2005-09-08 06:49:23 +00:00
Roger Dingledine
69da0ef757 add punctuation 
svn:r4924
 2005-09-08 06:49:02 +00:00
Nick Mathewson
8f37357193 Make GCC v4 happy with heavy warnings enabled. 
svn:r4922
 2005-09-08 06:37:50 +00:00
Nick Mathewson
f50ddfd4dd Download network-status at regular intervals. The code is probably iffy, and the constants need to be renamed. 
svn:r4921
 2005-09-08 06:22:44 +00:00
Roger Dingledine
2f6664ce80 MonthlyAccountingStart is dead. 
svn:r4920
 2005-09-08 05:38:47 +00:00
Roger Dingledine
c9e1c41873 dirserv_add_descriptor() doesn't chew up its argument anymore, 
so we can stop protecting it.


svn:r4919
 2005-09-08 05:37:22 +00:00
Roger Dingledine
03ddeb2620 strip obsolete code 
svn:r4918
 2005-09-08 05:32:41 +00:00
Roger Dingledine
0ac3c58480 clean up comments for router_is_general_exit() 
svn:r4917
 2005-09-08 05:23:55 +00:00
Roger Dingledine
08348ae66e add a RESETCONF controller command, and make setconf with a null 
option actually mean to set it to ""


svn:r4916
 2005-09-08 03:18:51 +00:00
Roger Dingledine
0a8a8ba546 fix some typos 
svn:r4915
 2005-09-08 03:17:50 +00:00
Nick Mathewson
4aca47268d Logic to launch connections for new directory types. 
svn:r4914
 2005-09-07 20:03:02 +00:00
Nick Mathewson
9e76eae810 add missing return 
svn:r4913
 2005-09-07 17:18:52 +00:00
Nick Mathewson
eac917fd6a clean whitespace. 
svn:r4912
 2005-09-07 17:15:46 +00:00
Nick Mathewson
5c6c88e76d More stuff for new directories. 
- Distinguish v1 authorities (all currently trusted directories) from
  v2 authorities (all trusted directories).
    - Add configuration option for which dirs are v1 authories.
    - Add configuration option for whether to be a v1 authority.
    - Make trusted dirserver selection functions take options to
      choose which functionality we need.
    - Remove option when getting directory cache to see whether they
      support running-routers; they all do now.  Replace it with one
      to see whether caches support v2 stuff.

- Parse, cache, and serve network-status objects properly.

- Serve compressed groups of router descriptors.  The compression logic
  here could be more memory-efficient.

-


svn:r4911
 2005-09-07 16:42:53 +00:00
Roger Dingledine
c384fa706d stop using the v1 rend desc format. we're going to change v1 
some more before we switch to it.


svn:r4909
 2005-09-06 06:14:38 +00:00
Nick Mathewson
1e37ec4782 Comment structs, reload a field, start making network status caches work 
svn:r4908
 2005-09-04 23:12:27 +00:00
Roger Dingledine
d2a5b614eb if you're an auth dir server, start yourself out as verified. 
svn:r4907
 2005-09-03 23:10:28 +00:00
Roger Dingledine
33b2abbc90 remove redundant logs about unreachable servers 
svn:r4905
 2005-09-03 04:37:30 +00:00
Nick Mathewson
467fd6e4e6 fix order of items in network-status 
svn:r4904
 2005-09-03 02:38:39 +00:00
Nick Mathewson
3485a497fe Fix another ntohl 
svn:r4903
 2005-09-03 02:23:53 +00:00
Nick Mathewson
ae726e659e and another byte counting error. 
svn:r4902
 2005-09-03 02:14:31 +00:00
Nick Mathewson
9b949cc1d2 Excellent. We have at least 8 bytes, so I can safely get the 9th. 
svn:r4901
 2005-09-03 02:12:53 +00:00
Nick Mathewson
bcbff6dcd7 Note to self: htonl(htonl(X)) is *not* "twice as good as htonl(X)". Spotted by arma. 
svn:r4900
 2005-09-03 01:47:39 +00:00
Nick Mathewson
815c092b22 Make structs for (v2) network-status and its per-router components. Add functions to parse them. Re-do the parsing logic a litt.e. Change signatures in or.h to support new DNS TTL logic. 
svn:r4898
 2005-09-02 20:37:31 +00:00
Nick Mathewson
9bc3d34682 Add contact field to generated network-status objects 
svn:r4897
 2005-09-02 20:30:03 +00:00
Nick Mathewson
09e8521236 Make ContactInfo mandatory for authoritative directories. 
svn:r4896
 2005-09-02 20:29:29 +00:00
Nick Mathewson
a6a45b7713 Add TTLs to RESOLVED, CONNECTED, and END_REASON_EXITPOLICY cells. Also, add a missing ntohl in connection_ap_handshake_socks_resolved. 
svn:r4894
 2005-09-02 18:53:31 +00:00
Roger Dingledine
93179f4e7e bugfix: moria2 wasn't listing itself as verified in its directory 
svn:r4893
 2005-09-02 06:19:31 +00:00
Roger Dingledine
ba899d0648 when we're shutting down and we do something like try to post a 
server descriptor or rendezvous descriptor, don't complain that we
seem to be unreachable. of course we are, we're shutting down.


svn:r4892
 2005-09-01 08:19:49 +00:00
Roger Dingledine
1b04f38145 subtle change to avoid some false positives: 
if a server went down for six hours and then came back, we would
complain to it that it's unreachable. now we wait until the third
consecutive descriptor post that we thought it was unreachable,
before complaining to it.


svn:r4891
 2005-09-01 08:13:40 +00:00
Roger Dingledine
3b6ab71929 and notify the dirserver operator whenever we do 
svn:r4890
 2005-08-31 06:18:19 +00:00
Roger Dingledine
711cad94ed when we think a router is unreachable, pass the message back to the 
server's logs, and make it a 'warn'.
also, fix a memory leak for rejected router descriptors.


svn:r4889
 2005-08-31 06:14:37 +00:00
Nick Mathewson
0b92c28d84 Actually set is_hibernating when parsing router descriptors. 
svn:r4888
 2005-08-30 15:04:24 +00:00
Roger Dingledine
6a52aa52fe fix a pair of hard-coded urls 
svn:r4887
 2005-08-30 07:01:30 +00:00
Roger Dingledine
4240410a9d don't whine about reachability if the guy is hibernating now. 
speaking of which, we don't actually parse is_hibernating out
of the router descriptor right now. nick, can you fix this?


svn:r4886
 2005-08-30 06:48:24 +00:00
Roger Dingledine
e9524f9d2d refactor -- no actual changes 
svn:r4885
 2005-08-30 06:43:07 +00:00
Roger Dingledine
a8c0c51e0b a bit of cleanup 
svn:r4884
 2005-08-30 06:01:13 +00:00
Nick Mathewson
0691c7221e Update routerinfo_t.is_running when generating network status on authdirserver. 
svn:r4883
 2005-08-29 18:42:36 +00:00
Nick Mathewson
29a6c17d67 Allow tor_gzip_uncompress to handle multiple concatenated compressed strings. 
svn:r4882
 2005-08-29 18:01:38 +00:00
Nick Mathewson
e3a058f33a Change semantics of set_cached_dir; fix massive authdir memleak. 
svn:r4880
 2005-08-28 04:20:37 +00:00
Nick Mathewson
26d2301c76 Make unit tests (and others) run without launching listeners, creating subdirectories, and so on. 
svn:r4876
 2005-08-26 23:22:27 +00:00
Nick Mathewson
cd2bb915ed Fix a warning, add an assert. 
svn:r4875
 2005-08-26 23:12:13 +00:00
Nick Mathewson
70fe2a6cee Crashing dirservers on startup is often considered bad form. 
svn:r4874
 2005-08-26 23:04:12 +00:00
Nick Mathewson
e863771485 Log when falling back to nonfast/nonstabl routers 
svn:r4869
 2005-08-26 22:16:32 +00:00
Nick Mathewson
ed070b0fdb Set a variable that exists. That works better. 
svn:r4868
 2005-08-26 22:16:09 +00:00
Roger Dingledine
6577e08e38 when we're trying to build a circuit and we're being picky about what 
sort we get but there aren't any suitable servers, try being less picky
rather than simply failing.


svn:r4867
 2005-08-26 22:10:22 +00:00
Nick Mathewson
a74ad8efea Remember to mark v2 networkstatus non-dirty when we generate it; also, fix spaces. 
svn:r4866
 2005-08-26 22:08:24 +00:00
Nick Mathewson
3cc960c7dd Make sure that cached-status directory exists. 
svn:r4865
 2005-08-26 22:03:57 +00:00
Roger Dingledine
77f52e3467 fix some logs and comments 
svn:r4864
 2005-08-26 21:55:38 +00:00
Nick Mathewson
ae4a183ed8 Change the return values on dirserv_add_descriptor 
svn:r4863
 2005-08-26 21:46:24 +00:00
Roger Dingledine
53431a4950 fix compile complaints (and a bug) 
svn:r4862
 2005-08-26 21:30:52 +00:00
Nick Mathewson
e24d540d81 We no longer need dirserv_load_from_directory_string, so dirserv_add_descriptor no longer has to keep track of where each descriptor ends. 
svn:r4861
 2005-08-26 21:28:16 +00:00
Nick Mathewson
208bdf5f27 No need to load cached directory twice 
svn:r4860
 2005-08-26 21:19:58 +00:00
Roger Dingledine
715b972300 disarm a trap 
svn:r4859
 2005-08-26 21:12:53 +00:00
Nick Mathewson
47669fa0fd Fix assert failure on directory startup. 
svn:r4858
 2005-08-26 21:12:34 +00:00
Nick Mathewson
f559c49c39 Make network-status strings wellformed 
svn:r4857
 2005-08-26 21:11:53 +00:00
Nick Mathewson
47aa42fc17 Remove a field that nobody sets or uses. 
svn:r4856
 2005-08-26 21:11:34 +00:00
Nick Mathewson
9a3be928e9 Note that a descriptor has changed when we receive a new directory. 
svn:r4855
 2005-08-26 21:02:18 +00:00
Nick Mathewson
0e649ac60a Remove descriptor_list and use routerlist instead. Make directories manage routerlist a little better. 
svn:r4854
 2005-08-26 20:59:04 +00:00
Roger Dingledine
a47765a16d stop freeing the new global options list whenever we update it. 
svn:r4853
 2005-08-26 20:26:20 +00:00
Roger Dingledine
237f58524f make it clearer which elements of routerinfo_t are for reachability 
testing


svn:r4852
 2005-08-26 20:22:32 +00:00
Roger Dingledine
f3bccdce73 if dirservers set assumereachable, it overrides their individual 
reachability testing


svn:r4851
 2005-08-26 20:08:12 +00:00
Roger Dingledine
61f728f4fe fix an infinite loop at hup 
svn:r4850
 2005-08-26 20:07:55 +00:00
Nick Mathewson
7f78be1659 Clean up the "add myself as a trusted dirserver" code. 
svn:r4849
 2005-08-26 19:31:51 +00:00
Nick Mathewson
43488472ec The circus music begins playing as nickm and arma juggle an ntohl. Hoop-lah! 
svn:r4848
 2005-08-26 19:25:36 +00:00
Nick Mathewson
ee76baae3d move a wandering ntohl 
svn:r4847
 2005-08-26 19:23:52 +00:00
Nick Mathewson
0239249160 Only free strmap if it is allocated. 
svn:r4846
 2005-08-26 18:48:13 +00:00
Nick Mathewson
cf90a36dd1 Add quotes around filenames in src/or 
svn:r4845
 2005-08-26 18:44:26 +00:00
Nick Mathewson
ff25a7707a fix syntax err 
svn:r4843
 2005-08-26 18:35:52 +00:00
Nick Mathewson
88989be99b More documenting 
svn:r4842
 2005-08-26 18:02:49 +00:00
Nick Mathewson
e204dd5d2a Remove accidentally added printf 
svn:r4841
 2005-08-26 15:35:43 +00:00
Nick Mathewson
d54d7b7ec1 Add some documentation; move the signature generation logic into routerparse.c along with the hash generation logic; make router signing use it as well. 
svn:r4840
 2005-08-26 15:34:53 +00:00
Roger Dingledine
893acb3acc Make a new AssumeReachable config option that will publish anyway. 
Also, let authdirservers start without setting their Address field.
Something is still not working though. Will fix in morning.


svn:r4839
 2005-08-26 07:41:19 +00:00
Nick Mathewson
e68bed8782 Fall back to routerlist instead of descriptor_list when we are a cache. 
svn:r4837
 2005-08-25 20:54:12 +00:00
Nick Mathewson
4dc3cb9fd9 Fix a segfault when starting a dir cache 
svn:r4836
 2005-08-25 20:45:53 +00:00
Nick Mathewson
54a6a8f0ef Start implementing the server side of the new directory protocol. 
Probably very buggy, since I can't actually run an authdir.

Features
- Generate and publish new network-status format
- Code to cache and re-serve network-status objects generated by others.
- Publish individual descriptors (by fingerprint, by "all", and by
  "tell me yours.")  [Still needs compression logic]
- Publish client and server recommended versions seprately.
- Add digest of descriptor to routerinfo_t, so we can track them better, and
  length, so we can server them more easily.

Cleanups
- Unify code to sign directory-like things
- Make resolve_my_address() able to tell you which name it wound up resolving.
- Unify code to store and serve directory-like things so it all uses
  cached_dir_t.
- Unify code to set the value of cached_dir_t objects.


svn:r4835
 2005-08-25 20:33:17 +00:00
Roger Dingledine
86f85f240c be much more conservative about logging reachability complaints. 
the ones it logs now are probably genuine problem servers.


svn:r4832
 2005-08-24 14:31:32 +00:00
Roger Dingledine
e54e970a82 ha ha, that infinite loop was fun. 
but dirservers aren't supposed to have infinite loops.


svn:r4831
 2005-08-24 12:14:44 +00:00
Roger Dingledine
a120cc20c1 Dirservers now do their own external reachability testing of each 
Tor server, and only list them as running if they've been found to
be reachable.

Dirservers also log trouble servers, but only start complaining loudly
after they've been up for an hour, to reduce false positives. We still
need to do something about the fact that it is quite loud when there
are many trouble servers.


svn:r4829
 2005-08-24 02:31:02 +00:00
Nick Mathewson
5d590861c4 TOR_ISSPACE, not isspace. 
svn:r4828
 2005-08-24 02:20:31 +00:00
Nick Mathewson
b72ab23ded check [X-]Forwarded-For headers in HTTP requests when generating log messages. Implements feature for bug 181. Arma--please review? 
svn:r4826
 2005-08-23 22:27:17 +00:00
Nick Mathewson
50452c32ec fix bug 180: handle duplicate lines in approved-routers files. 
svn:r4825
 2005-08-23 22:00:35 +00:00
Roger Dingledine
f35ef825f9 Our logic to decide if the OR we connected to was the right guy 
was brittle and maybe open to a mitm for unverified routers.

Now we be sure to check the digest, and if the nickname he claims is
not a verified one then we don't care what nickname he claims.


svn:r4823
 2005-08-23 09:50:51 +00:00
Roger Dingledine
675f6b5f3c that comma was important 
svn:r4820
 2005-08-23 01:00:30 +00:00
Roger Dingledine
8b766d1b7e fix bad logic that has been lurking for eons, that now prevented us 
from uploading descriptors after the first one.


svn:r4818
 2005-08-23 00:47:44 +00:00
Roger Dingledine
ab112ca6ad and don't print the null string here either 
svn:r4816
 2005-08-22 22:59:54 +00:00
Roger Dingledine
23ed3c9786 whoops, avoid printing a null string sometimes 
svn:r4815
 2005-08-22 22:58:38 +00:00
Roger Dingledine
676b330eb2 Make DirPostPeriod config option obsolete. 
Force new descriptor upload every 18 hours, not 24, to avoid races.
Change rate-limiting on new descriptors due to bandwidth changes, from
45 minutes to 20 minutes.


svn:r4814
 2005-08-22 21:53:12 +00:00
Roger Dingledine
fa64d73fc7 fix function headers from the descriptor-frequency commit 
svn:r4809
 2005-08-22 06:45:18 +00:00
Roger Dingledine
435d2d8fde when we begin reachability testing, log the address:port for each 
port we're testing, so people are more likely to notice that they're
using the wrong ip address.


svn:r4808
 2005-08-22 05:46:02 +00:00
Roger Dingledine
d928411acd change log entry for unreachability to explicitly suggest /etc/hosts 
as the culprit


svn:r4807
 2005-08-22 05:33:49 +00:00
Nick Mathewson
dc09c7fc73 Implement new (reduced-frequency) upload rules. arma, you should review this. 
svn:r4806
 2005-08-22 03:10:53 +00:00
Nick Mathewson
9b6eeb81aa Make unit tests run without segfaulting 
svn:r4804
 2005-08-22 00:34:42 +00:00
Nick Mathewson
7a442c2c48 Make set_options a little smarter: have options_act handle transitions on its own, and only dirty our descriptor when we really want to. 
svn:r4802
 2005-08-22 00:18:45 +00:00
Roger Dingledine
5e76bac1dd the tor-spec says router->address must be an IP address. so refuse 
it if it's not.
(this also fixes some potential security problems with people providing
hostnames as their address and then preferentially resolving them and
partitioning users.)


svn:r4790
 2005-08-16 02:52:27 +00:00
Roger Dingledine
04d42ea433 rotate dns and cpu workers if the controller changes options that 
will affect them.


svn:r4787
 2005-08-15 23:46:18 +00:00
Roger Dingledine
b1d3f124c4 Permit transitioning from ORPort=0 to ORPort!=0, and back. 
This is actually a bit more subtle, because we need to rotate
the dnsworkers and cpuworkers if certain options (logs, orport, etc)
change. Maybe set_options() should detect this and notify the caller
that it should rotate them.

Expect some mysterious crashes.


svn:r4786
 2005-08-15 10:30:45 +00:00
Roger Dingledine
10ff723938 initialize the dns worker cache tree whether or not we start 
out as a server.


svn:r4785
 2005-08-15 10:27:37 +00:00
Roger Dingledine
157f013d83 fix typo 
svn:r4784
 2005-08-15 09:25:36 +00:00
Roger Dingledine
00c2ba4841 resolve a XXX 
svn:r4783
 2005-08-15 09:19:55 +00:00
Roger Dingledine
11bc97801d clean up some confusing logs. 
make MonthlyAccountingStart truly obsolete now.


svn:r4782
 2005-08-15 09:17:47 +00:00
Roger Dingledine
79e3f5600a hey, we have a function for that 
svn:r4781
 2005-08-15 08:51:20 +00:00
Roger Dingledine
3728011f36 after failing from resolve failed or misc, reset the num failures. 
svn:r4780
 2005-08-15 03:35:15 +00:00
Roger Dingledine
f57d062d9c Implement exit enclaves: if we know an IP address for the destination, 
and there's a running Tor server at that address which allows exit to
the destination, then extend the circuit to that exit first.
Also, if the user asks for a .exit node, cannibalize general circs for it.


svn:r4779
 2005-08-15 03:25:40 +00:00
Roger Dingledine
cc1b82ade8 when listing min-bandwidth servers in the controller, don't get 
fooled by a low bandwidthrate


svn:r4777
 2005-08-14 08:38:34 +00:00
Roger Dingledine
ff54050fda let unregistered-servers take a parameter (the min bandwidth) 
nick, is this an ugly hack of your protocol?


svn:r4775
 2005-08-13 02:20:00 +00:00
Roger Dingledine
66b21a19db Add a 'quit' command for the controller. 
Add a 'getinfo unregistered-servers' for arma's internal use.


svn:r4774
 2005-08-13 01:55:23 +00:00
Roger Dingledine
6d875b7d58 i'm sick of having my streams fail because of a confused exit node. 
try this band-aid to see if it gets better.


svn:r4773
 2005-08-13 00:31:41 +00:00
Roger Dingledine
87fcd60aa2 predict required circuits better, with an eye toward making 
hidden services faster on the service end.


svn:r4772
 2005-08-13 00:22:07 +00:00
Nick Mathewson
789374dbbd Make GCC very happy, even with lots of warnings set. Also, try to fix some reported Solaris x86 warnings. 
svn:r4770
 2005-08-12 17:24:53 +00:00
Nick Mathewson
21959c1bfd start using new renddesc code 
svn:r4769
 2005-08-12 15:05:05 +00:00
Roger Dingledine
aab541c852 We weren't cannibilizing circuits correctly for 
CIRCUIT_PURPOSE_C_ESTABLISH_REND and CIRCUIT_PURPOSE_S_ESTABLISH_INTRO
so we were being forced to build those from scratch.
This should save us a bit of time. Also fixes bug 173.


svn:r4763
 2005-08-12 01:26:21 +00:00
Roger Dingledine
2caa74e6ff quiet a noisy debug 
svn:r4762
 2005-08-12 00:34:50 +00:00
Nick Mathewson
16528aa070 Add a config-file GETINFO entry; fix a minor memory leak on some SAVECONF calls. 
svn:r4761
 2005-08-10 18:05:20 +00:00
Nick Mathewson
c031d14633 Fix segfault in unit tests 
svn:r4760
 2005-08-09 18:49:43 +00:00
Nick Mathewson
18abdfdf58 Replace ADDR_POLICY_ACCEPT/REJECT with its own enum 
svn:r4756
 2005-08-09 05:22:23 +00:00
Nick Mathewson
05bced6139 check_software_version_against_directory needs a return value. 
svn:r4755
 2005-08-09 05:20:14 +00:00
Nick Mathewson
742796c19f Avoid sending blank lines when GETINFO replies should be empty 
svn:r4754
 2005-08-09 05:16:29 +00:00
Nick Mathewson
943ef5256b fix whitespace issues 
svn:r4752
 2005-08-08 21:59:48 +00:00
Nick Mathewson
249b72f53e Replace (Fascist)Firewall* with a new ReachableAddresses option that understands address policies. 
svn:r4751
 2005-08-08 21:58:48 +00:00
Roger Dingledine
3ac34ae329 get rid of IgnoreVersion and the forced auto-exit mis-feature 
svn:r4746
 2005-08-08 21:52:57 +00:00
Roger Dingledine
588e80fdcd fix a function comment 
svn:r4743
 2005-08-08 17:48:23 +00:00
Nick Mathewson
50cfcbe157 Note which directory server said 400 to a renddesc. 
svn:r4742
 2005-08-08 17:32:17 +00:00
Roger Dingledine
2e918af35d a few typo fixes 
svn:r4738
 2005-08-07 21:58:23 +00:00
Nick Mathewson
01d0788950 Generalize FirewallPorts to FirewallIPs so I can run happily when locked in net 18. 
svn:r4737
 2005-08-07 21:24:00 +00:00
Nick Mathewson
4e735da5da Also set event_mask=0 in connection_free_all, and dont send events to marked control conns (for good measure) 
svn:r4729
 2005-08-07 19:27:38 +00:00
Roger Dingledine
5c4da9dec6 incomplete patch for matt's info controller signal term bug 
svn:r4728
 2005-08-07 19:20:55 +00:00
Nick Mathewson
999b7951c3 Shorten hidden service port config parsing; fix bug 174 
svn:r4725
 2005-08-06 21:35:04 +00:00
Nick Mathewson
52475ee19b Alphebetize config variables 
svn:r4714
 2005-08-05 01:35:43 +00:00
Nick Mathewson
4870877231 Add SOCKSAndDNS link to appropriate log message, since we wind up pointing everybody to it anyway 
svn:r4695
 2005-08-04 20:12:44 +00:00
Nick Mathewson
4cb89fd557 Implement some more GETINFO goodness: expose helper nodes, config options, getinfo keys. 
svn:r4694
 2005-08-04 19:56:41 +00:00
Nick Mathewson
303258972b Fix idiot bug. The "free the IP history" code belons in connection_free_all(), not in connection_free(). You can all mock me now. 
svn:r4691
 2005-08-04 18:29:01 +00:00
Nick Mathewson
11ff0aba80 Make clients regenerate their keys when their IP address changes. 
svn:r4688
 2005-08-03 20:42:17 +00:00
Nick Mathewson
ceb02cee2c If they havent told us by now, they probably never will. 
svn:r4687
 2005-08-03 20:37:13 +00:00
Nick Mathewson
d90841ff5a Fix bug in state parsing 
svn:r4681
 2005-07-28 19:08:51 +00:00
Nick Mathewson
299af3d393 Possibly broken implementation of persistant state; handles helper nodes; does not handle accounting info yet. 
svn:r4680
 2005-07-28 19:01:48 +00:00
Roger Dingledine
a32f936346 whoops, fix compile 
svn:r4674
 2005-07-25 10:36:01 +00:00
Roger Dingledine
1e0fdcae98 parameterize RephistTrackTime 
svn:r4673
 2005-07-25 10:29:21 +00:00
Roger Dingledine
9385a96235 fix typos 
svn:r4645
 2005-07-23 04:35:58 +00:00
Nick Mathewson
bb4ebaac6f document code for hibernation 
svn:r4644
 2005-07-23 04:12:35 +00:00
Nick Mathewson
2bd6040f62 Rename cross-format config.c stuff to config_* and or_options_t-specific stuff to option[s]_* 
svn:r4641
 2005-07-23 01:58:05 +00:00
Nick Mathewson
3cb7b97660 Fix out-of-place declaration 
svn:r4640
 2005-07-23 01:52:24 +00:00
Nick Mathewson
18c11eb3bc Be consistent about preferring foo* to struct foo* 
svn:r4637
 2005-07-22 21:12:10 +00:00
Nick Mathewson
c252a76f0b Parameterize configuration parsing functions 
svn:r4635
 2005-07-22 20:37:42 +00:00
Nick Mathewson
c3a62c1739 Initial, somewhat dodgy implementation of helper nodes. It has too many XXXXs, it logs too verbosely, and it doesnt do persistence. 
svn:r4633
 2005-07-22 17:32:25 +00:00
Nick Mathewson
5b4e11fa5d Add getinfo logic for accounting; add options for helper nodes 
svn:r4632
 2005-07-22 14:55:09 +00:00
Roger Dingledine
3333d27f41 we were mangling memory because we weren't allocing enough 
for the hidserv desc
nick can you check that this is enough now?


svn:r4628
 2005-07-22 00:18:25 +00:00
Roger Dingledine
1efeb3908a let hidden service descriptors publish 0 intro points 
nick, please check the logic here


svn:r4627
 2005-07-22 00:14:58 +00:00
Roger Dingledine
11bd4bc521 in circuit_list_path(), don't redundantly print the intended exit 
nickname when the circuit is open.


svn:r4622
 2005-07-20 20:33:13 +00:00
Roger Dingledine
eedb7c243e be consistent about printing out key digest $'s when we're getting a 
different key than we expect


svn:r4609
 2005-07-19 21:26:24 +00:00
Roger Dingledine
7ac36a9a74 unit tests to prove i didn't screw up 
svn:r4602
 2005-07-18 23:36:12 +00:00
Roger Dingledine
e479cc935e stop asserting if we have a controller listening for circuit events 
and we're offline so we fail to make a circuit and it tries to notify
us about the zero-length circuit.


svn:r4600
 2005-07-18 23:18:00 +00:00
Roger Dingledine
5fe18894b9 now that we're recommending 0.1.1.x-alpha for win32 and os x users, 
stop printing debug stuff once a minute


svn:r4596
 2005-07-18 19:16:17 +00:00
Roger Dingledine
e8a1b1d6a0 add a trivial tor-counting variable 
svn:r4593
 2005-07-18 06:09:04 +00:00
Roger Dingledine
43a28a4ca9 make event streams work with control v1 too 
svn:r4590
 2005-07-17 22:28:01 +00:00
Roger Dingledine
6ac245793c downgrade a warning that could plausibly happen sometimes now that we 
have controllers.


svn:r4589
 2005-07-17 21:43:47 +00:00
Roger Dingledine
090836d171 correct error message in closestream 
svn:r4588
 2005-07-17 21:36:33 +00:00
Roger Dingledine
ebf13c6282 not not zero means zero 
svn:r4587
 2005-07-17 21:22:18 +00:00
Roger Dingledine
5643532bd9 if the controller asks to extendcircuit to circid 0, we need to 
init the circuit before we can add hops to its cpath.


svn:r4586
 2005-07-17 21:13:36 +00:00
Roger Dingledine
fe7535c5e2 arguments in EXTENDCIRCUIT were reversed 
and an error message was misleading
and we were leaking memory on some errors
more bugs remain


svn:r4585
 2005-07-17 21:06:00 +00:00
Nick Mathewson
2cff73e7a4 Make "Couldnt add router to list" message more descriptive. Make messages consistenly punctuated. 
svn:r4582
 2005-07-15 19:40:38 +00:00
Nick Mathewson
f8b48176ed Fix several bugs in read_escaped_data; add a unit test and a few docs 
svn:r4580
 2005-07-15 19:31:11 +00:00
Nick Mathewson
441e02d4ac Merge patch from Matt Edman for bug 162 (service never stops) 
svn:r4578
 2005-07-15 19:09:36 +00:00
Roger Dingledine
545c2c6c87 the other half of the bugfix: tolerate a trusted dirserver claiming 
dirport 0 in its descriptor.


svn:r4576
 2005-07-15 18:56:59 +00:00
Roger Dingledine
97174b67c2 if you're an auth dir server, always publish your dirport, 
even if you haven't yet found yourself to be reachable.

this is the cause of Jan Tore Morken's recent or-talk bug.


svn:r4575
 2005-07-15 18:49:35 +00:00
Roger Dingledine
83dc42055d point out some bugs for nick, noticed by whiteout 
svn:r4574
 2005-07-15 18:48:38 +00:00
Roger Dingledine
452c98058f missed one 
svn:r4567
 2005-07-14 23:08:55 +00:00
Roger Dingledine
d8d0feb633 tell us what kind of listener it is, too 
svn:r4566
 2005-07-14 23:07:05 +00:00
Nick Mathewson
f86a1e634f fix opening listener log msg 
svn:r4565
 2005-07-14 23:04:31 +00:00
Nick Mathewson
e94f95a716 Populate address field of listeners with an actually sane value. 
svn:r4564
 2005-07-14 22:56:17 +00:00
Roger Dingledine
ceae96a3a0 put in tor26's new IP address 
svn:r4560
 2005-07-14 22:37:52 +00:00
Nick Mathewson
331942870e fix problems noticed by arma in rendservice.c 
svn:r4558
 2005-07-14 16:41:47 +00:00
Nick Mathewson
149e9a5900 remove pointless XXXX. It was there to remind me to do something I already did. 
svn:r4557
 2005-07-14 16:37:33 +00:00
Roger Dingledine
4a6bf116e7 substantive changes on nick's rendezvous commit. 
nick, can you fix these?


svn:r4554
 2005-07-14 08:45:19 +00:00
Roger Dingledine
2259032ea1 trivial changes on nick's rendezvous commit 
svn:r4553
 2005-07-14 08:43:19 +00:00
Roger Dingledine
19810ba38e make it more pleasant to be told you're using libevent 
svn:r4548
 2005-07-13 21:22:34 +00:00
Roger Dingledine
306f7d320c make a notice-level log make more sense. 
svn:r4547
 2005-07-13 21:12:33 +00:00
Nick Mathewson
97c58f066a whitespace fixes 
svn:r4544
 2005-07-13 17:24:55 +00:00
Nick Mathewson
cf13b3e4a6 Macro-fu to get DEBUG events working. 
svn:r4539
 2005-07-13 05:14:42 +00:00
Roger Dingledine
ddecb1a04d looks like we were never delivering deflated running-routers lists 
svn:r4536
 2005-07-12 22:56:22 +00:00
Roger Dingledine
7c7c95c3f6 anonymous bugfix on our pointer arithmetic 
svn:r4535
 2005-07-12 22:56:06 +00:00
Nick Mathewson
0828feaf7c Add belt-and-suspenders fix to coredump from yesterday; document more functions in buffers.c 
svn:r4532
 2005-07-12 18:19:30 +00:00
Roger Dingledine
8f9790a023 fix a seg fault with autodetecting which controller version is being used 
svn:r4531
 2005-07-12 05:48:15 +00:00
Nick Mathewson
63f9a8baa2 Canonicalize option names even on defaulted options. 
svn:r4530
 2005-07-11 18:11:54 +00:00
Nick Mathewson
50a206e800 Do not reverse command-line configuration options; Use new minimal-listener-close code; Add code to canonicalize configuration names. 
svn:r4529
 2005-07-11 17:35:36 +00:00
Nick Mathewson
658e1196d0 Change retry_listeners: when force is false, close and re-open a minimal set of listeners (i.e., those that do not match the configuration). This fixes a possible bug on some windowses. Maybe. 
svn:r4528
 2005-07-11 17:20:22 +00:00
Nick Mathewson
e1db33971e NT service patch from Matt Edman to improve error messages, lightly cleaned; needs more testing. 
svn:r4527
 2005-07-09 16:37:12 +00:00