nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-11 13:43:47 +01:00
Code Issues Packages Projects Releases Wiki Activity
16,238 Commits 53 Branches 630 Tags 125 MiB
bb2145b45b
Commit Graph

442 Commits

Author SHA1 Message Date
Nick Mathewson
e7ac17fdf5 r11613@catbus: nickm | 2007-01-30 19:58:03 -0500 
Re-enable server side PTR-record cacheing.


svn:r9468
 2007-01-31 00:58:06 +00:00
Nick Mathewson
49b5e5cf9c r11610@catbus: nickm | 2007-01-30 17:44:02 -0500 
Fix a bug in our assertions related to removing recently-completed DNS lookup attempts on exit.  It is okay to find a cache entry with the same name as a DONE entry, so long it is not the same struct as the DONE entry.


svn:r9467
 2007-01-30 22:44:24 +00:00
Nick Mathewson
42d03890b4 r11584@catbus: nickm | 2007-01-29 11:25:40 -0500 
Fix/update some XXX012 points.


svn:r9456
 2007-01-29 18:13:37 +00:00
Nick Mathewson
2522c392bd r11283@catbus: nickm | 2007-01-23 19:20:47 -0500 
Add documentation to dns.c (mainly to test new buildbot version)


svn:r9393
 2007-01-24 00:20:49 +00:00
Roger Dingledine
9f733c31cc minor cleanups 
svn:r9387
 2007-01-22 19:20:33 +00:00
Nick Mathewson
36620ca056 r9718@catbus: nickm | 2007-01-22 14:13:00 -0500 
Free CACHE_STATE_DONE cached_router_t items on dns_free_all().


svn:r9386
 2007-01-22 19:13:02 +00:00
Roger Dingledine
8662f18102 boots and suspenders, or whatever the idiom is 
svn:r9365
 2007-01-17 00:14:43 +00:00
Nick Mathewson
a36ec61fd7 r11983@Kushana: nickm | 2007-01-16 10:28:47 -0500 
Be even more clever about severity of messages from eventdns: NOTICE when the first nameserver comes up; INFO on subsequent ones.


svn:r9364
 2007-01-16 17:39:08 +00:00
Nick Mathewson
db6f0f3617 r11973@Kushana: nickm | 2007-01-15 16:43:25 -0500 
Answer questions from r9348.


svn:r9358
 2007-01-15 21:44:59 +00:00
Roger Dingledine
cf7069fca4 two more todo items, to make eventdns log messages less loud 
svn:r9348
 2007-01-15 08:40:50 +00:00
Nick Mathewson
c1b5f53679 r11938@Kushana: nickm | 2007-01-11 11:02:28 -0500 
Check addresses for rfc953-saneness at exit too, and give a PROTOCOL_WARN when they fail.  Also provide a mechanism to override this, so blossom can have its @@##$$^.whatever.exit hostnames if it wants.


svn:r9336
 2007-01-11 16:02:39 +00:00
Nick Mathewson
3dfeaaaf6e r11931@Kushana: nickm | 2007-01-11 09:12:49 -0500 
Fix a crash bug in the presence of DNS hijacking.


svn:r9333
 2007-01-11 14:13:13 +00:00
Roger Dingledine
794fedb0ad some cleanups. more probably remain, but hey, it's an alpha. 
time to put out the bugfix release.


svn:r9309
 2007-01-09 05:14:34 +00:00
Nick Mathewson
5239602dbc r11873@Kushana: nickm | 2007-01-06 02:32:18 -0500 
Implement DNS-related status events.


svn:r9285
 2007-01-06 07:34:07 +00:00
Nick Mathewson
336624ce8f r11862@Kushana: nickm | 2007-01-06 01:05:15 -0500 
Re-enable warning when we resolve an already resolved address.  We only warn here now if the address is not a testing address.  Also, refactor out a function to check whether an address is used for testing.


svn:r9280
 2007-01-06 06:26:46 +00:00
Roger Dingledine
ee0d2d486d fix a bug, defer a bug, bump to 0.1.2.5-alpha 
svn:r9270
 2007-01-05 06:30:31 +00:00
Nick Mathewson
0bbbf98be4 r11727@Kushana: nickm | 2006-12-28 16:27:17 -0500 
If we only have a single nameserver, raise the threshold to decide that the nameserver is dead.  (Another fumbling attempt to do something about bug 326.)


svn:r9203
 2006-12-28 21:29:37 +00:00
Nick Mathewson
460a476efa r11725@Kushana: nickm | 2006-12-28 14:44:56 -0500 
Partial solution to 326: downgrade single-nameserver failures to INFO.


svn:r9201
 2006-12-28 21:29:26 +00:00
Nick Mathewson
d9f1f3533d r11724@Kushana: nickm | 2006-12-28 14:22:35 -0500 
Refactor and unify my-ip-addr-changed logic.  Make change in IP address or in nameservers reset and relaunch DNS hijacking tests.


svn:r9200
 2006-12-28 21:29:20 +00:00
Nick Mathewson
e5f5b96ca6 r11723@Kushana: nickm | 2006-12-28 13:52:48 -0500 
Fix bug 364: check for whether popular hostnames (curently google, yahoo, mit, and slashdot) are getting wildcarded.  If they are, we are probably behind a DNS server that is useless: change our exit policy to reject *:*.


svn:r9199
 2006-12-28 21:29:11 +00:00
Nick Mathewson
baadf35c63 r11646@Kushana: nickm | 2006-12-19 14:40:38 -0500 
Resolve bug 363: do not fall back to 127.0.0.1 when no nameservers are configured.  Instead, have the admin fix resolv.conf or configure a nameserver.


svn:r9157
 2006-12-19 19:49:03 +00:00
Roger Dingledine
0f33a548c2 fix a string, pointed out by matt edman. 
also fix a bug next to it that i noticed.


svn:r8784
 2006-10-21 02:51:35 +00:00
Nick Mathewson
c8c36dd227 r9304@dhcp-18-188-67-85: nickm | 2006-10-20 12:22:46 -0400 
Change HT_INIT from a special-case to a macro-calling-a-function like the rest of ht.h.  This might prevent errors if somebody did, I dunno, "HT_INIT(tp, hashtable++)". Based on a patch from Watson Ladd.


svn:r8776
 2006-10-20 16:22:53 +00:00
Roger Dingledine
d1b9de222e cleanups, closer to a changelog 
svn:r8606
 2006-10-06 07:50:57 +00:00
Roger Dingledine
64b5fd3194 checkpoint some cleanups 
svn:r8599
 2006-10-05 08:23:21 +00:00
Nick Mathewson
5391ceb21a r9087@Kushana: nickm | 2006-10-04 01:19:15 -0400 
We're trying to catch the kind of jerk who'd hijack zy6pzwohtnlq.test,
 not the kind of lunatic who'd hijack zy6pzwohtnlq%s.test, though
 apparently those exist too.
 


svn:r8595
 2006-10-04 05:19:40 +00:00
Nick Mathewson
7d366f61cb r9025@Kushana: nickm | 2006-09-29 18:33:13 -0400 
Differentiate more duplicated log entries


svn:r8542
 2006-09-29 22:33:40 +00:00
Nick Mathewson
8308a37908 r9023@Kushana: nickm | 2006-09-29 17:27:24 -0400 
Make distinct all non-bug messages at notice or higher that appear 3 or more times.


svn:r8541
 2006-09-29 22:33:34 +00:00
Nick Mathewson
cd2425ffa0 r8968@Kushana: nickm | 2006-09-26 17:53:27 -0400 
Fix for reverse dns: only assume we will get an answer when the result was success.


svn:r8507
 2006-09-26 22:03:23 +00:00
Nick Mathewson
01f9e97d43 Minor fix: add code to eventdns so it can free memory on shutdown. This should help valgrind and dmalloc freak out less. 
svn:r8503
 2006-09-25 20:38:58 +00:00
Roger Dingledine
ad430b9561 checkpoint changelog and general polishing 
svn:r8497
 2006-09-25 05:59:13 +00:00
Roger Dingledine
bda137501e whitespace cleanups 
svn:r8485
 2006-09-24 20:54:59 +00:00
Nick Mathewson
11b4296b0b Marge changes from libevent evdns to our eventdns. Most are cosmetic, but one or two are stability-related. This should make it easier to push our changes back towards libevent. 
svn:r8482
 2006-09-24 17:52:23 +00:00
Nick Mathewson
d3af1f2189 Backport candidate: Fix a long-standing server-side DNS bug. When a 
client asks us to resolve (not connect to) an address, and we have a
cached answer, give them the cached answer.  Previously, we would give
them no answer at all.



svn:r8478
 2006-09-24 17:05:00 +00:00
Nick Mathewson
4218f09820 r8910@Kushana: nickm | 2006-09-22 12:14:05 -0400 
Instead of just checking known-invalid addresses for DNS hijacking, we
 now check randomly generated addresses, and if too many of them map to
 the same IP, we assume that IP is the destination of a DNS hijack
 attempt.
 
 A little bird tells me that some DNS hijackers think that declining to
 give an A record for RFC2606 addresses (like .invalid and .example)
 makes them more standards compliant.  Standardswise, this is like an
 illicit brothel making sure that nobody has pulled the tags off the
 mattresss, but that doesn't get us out of working around it.
 


svn:r8465
 2006-09-22 20:20:26 +00:00
Nick Mathewson
f0f3bbc63b r8901@Kushana: nickm | 2006-09-21 20:43:48 -0400 
I tracked a bug in server-side reverse DNS to something concerning the caching code. Ive disabled server-side cacheing for reverse DNS answers for now, and I am noting the bug in the TODO.


svn:r8454
 2006-09-22 00:45:08 +00:00
Nick Mathewson
29a756af8e Fix a couple of server-side reverse dns bugs 
svn:r8449
 2006-09-22 00:10:26 +00:00
Nick Mathewson
63395c747c Fix stupid C mistake. Glad I caught that one fast. 
svn:r8448
 2006-09-21 22:57:07 +00:00
Nick Mathewson
58200f06a5 Fix bug in r8440: base32 uses 5 bytes per char, not 4. 
svn:r8447
 2006-09-21 22:24:45 +00:00
Nick Mathewson
59f9487225 r8880@Kushana: nickm | 2006-09-21 17:26:02 -0400 
Trivial patch to appease warn-happy gcc: mark unused parameter


svn:r8445
 2006-09-21 21:49:15 +00:00
Nick Mathewson
7c21dabef1 r8878@Kushana: nickm | 2006-09-21 17:15:47 -0400 
Trivial whitespace cleanups.


svn:r8443
 2006-09-21 21:48:55 +00:00
Nick Mathewson
e4a9b4de4e r8875@Kushana: nickm | 2006-09-21 16:46:28 -0400 
Resolve bug 330: detect ISPs that want to hijack failing DNS requests and basically domain-squat the entire internet.


svn:r8440
 2006-09-21 21:48:22 +00:00
Nick Mathewson
04bec67574 r8874@Kushana: nickm | 2006-09-21 15:22:27 -0400 
Rename and document SearchDomains and ResolvConf options; warn if ServerDNSResolvConfFile is given but eventdns isnt enabled.


svn:r8439
 2006-09-21 21:48:16 +00:00
Nick Mathewson
083e9c2b59 r8873@Kushana: nickm | 2006-09-21 14:38:22 -0400 
Fix a bug: Remember, each call to escaped() replaces the value returned from the last call to escaped().


svn:r8438
 2006-09-21 21:48:11 +00:00
Nick Mathewson
a942441615 r8872@Kushana: nickm | 2006-09-21 14:00:20 -0400 
Implement server-side reverse DNS using eventdns.  Add an option to routerdescs so we can tell which servers have eventdns enabled.


svn:r8437
 2006-09-21 21:48:06 +00:00
Mike Chiussi
5d773af545 undid whitespace changes to dns.c 
svn:r8346
 2006-09-07 06:36:22 +00:00
Mike Chiussi
b931994c6a fixed win32 eventdns snafu 
svn:r8345
 2006-09-07 06:34:20 +00:00
Mike Chiussi
c40acb86f4 - got rid of tabs 
svn:r8344
 2006-09-07 04:02:52 +00:00
Mike Chiussi
5af47d1641 - added some debugging lines to load_nameservers_from_registry() 
svn:r8342
 2006-09-07 03:53:14 +00:00
Roger Dingledine
ae67a044f0 clean up some comments 
svn:r8338
 2006-09-07 01:23:15 +00:00
Nick Mathewson
e10e921386 r8729@Kushana: nickm | 2006-09-06 16:20:40 -0400 
Fix dns_cancel_pending_resolve() to realize pending resolves have expiry times, and should not be freed except when they fall off the pqueue.


svn:r8328
 2006-09-06 20:22:05 +00:00
Nick Mathewson
365ccf0742 r8725@Kushana: nickm | 2006-09-06 04:39:29 -0400 
spawn_func fixes: have cpuworker_main and dnsworker_main confirm to the right interfaces [casting func to void* is icky].  Also, make pthread_create() build without warnings.


svn:r8327
 2006-09-06 08:42:20 +00:00
Mike Chiussi
6ec9c1092a - made configure check if we are building for win32 
- made configure link to required system dll's if building for win32
- added diffs for libevent 1.1b
- forced user to turn off eventdns if win32 is set 
- cleaned up tor_mmap_file()_win32 (not sure if it's stable)
- cleaned up some warnings and typos




svn:r8322
 2006-09-06 01:49:55 +00:00
Nick Mathewson
8138d1c0a4 r8654@Kushana: nickm | 2006-08-28 16:50:36 -0400 
I bet real programmers even have programs that compile.


svn:r8278
 2006-08-28 20:50:47 +00:00
Nick Mathewson
dc4951314f r8652@Kushana: nickm | 2006-08-28 16:41:44 -0400 
Resolve bug 324: strdup the right variable.


svn:r8277
 2006-08-28 20:42:14 +00:00
Nick Mathewson
dbe0c6f6ef r8609@Kushana: nickm | 2006-08-27 17:24:27 -0400 
Add some doxygen, concentrated in dns.c


svn:r8256
 2006-08-28 03:16:02 +00:00
Nick Mathewson
54ca0387a5 r8608@Kushana: nickm | 2006-08-27 16:57:47 -0400 
Make it possible to change nameserver options while Tor is running.


svn:r8255
 2006-08-28 03:15:55 +00:00
Nick Mathewson
be7054c626 r8607@Kushana: nickm | 2006-08-27 15:45:42 -0400 
Change configuration strategy for eventdns. Instead of elaborate option set, just allow the user to specify another resolv.conf to use.


svn:r8254
 2006-08-28 03:15:50 +00:00
Nick Mathewson
d62f9a03fb r8605@Kushana: nickm | 2006-08-27 14:01:11 -0400 
divide eventdns log messages into warn and info messages.


svn:r8252
 2006-08-28 03:15:38 +00:00
Roger Dingledine
24ad1e06cf i'm guessing nick meant to check the return value of dns_init. 
and revise some log severities to match the convention.


svn:r8234
 2006-08-27 01:41:08 +00:00
Roger Dingledine
8297608217 fix typo 
svn:r8233
 2006-08-27 01:33:35 +00:00
Nick Mathewson
7739c5c49a r8573@Kushana: nickm | 2006-08-25 16:55:19 -0400 
Resolve bug 321 when using dnsworkers: append a period to every address we resolve at the exit node, so that we do not accidentally pick up local addresses, and so that failing searches are retried in the resolver search domains.  (This is already solved for eventdns.)


svn:r8225
 2006-08-25 21:02:01 +00:00
Nick Mathewson
ae5ee4c924 r7405@Kushana: nickm | 2006-08-16 14:38:46 -0400 
Implement reverse DNS lookup in eventdns: add new entry point; rename old entry point; revise TODO a little; add facility for parsing dns names.


svn:r7070
 2006-08-16 18:47:24 +00:00
Roger Dingledine
d8fc598a2a dns.c:173: warning: control reaches end of non-void function 
svn:r7067
 2006-08-16 02:18:55 +00:00
Nick Mathewson
67b775bc6e r7397@Kushana: nickm | 2006-08-15 00:46:18 -0400 
Fix eventdns version of dns.c. Man, we need to get rid of this eventdns/dnsworker split.


svn:r7064
 2006-08-15 04:50:17 +00:00
Nick Mathewson
7bfb2cf4e8 r7393@Kushana: nickm | 2006-08-14 23:51:07 -0400 
remove extraneous #endif


svn:r7063
 2006-08-15 03:54:13 +00:00
Nick Mathewson
200e24981a r7046@Kushana: nickm | 2006-08-05 13:57:04 -0400 
Make it possible for dns_init() to fail; note failure of eventdns configuratoin.


svn:r7059
 2006-08-14 21:44:34 +00:00
Nick Mathewson
a5c0aa43a0 r7383@Kushana: nickm | 2006-08-14 16:16:03 -0400 
Stop walking entire dns cache for every request, now that we found our hash table bug.


svn:r7057
 2006-08-14 20:16:21 +00:00
Roger Dingledine
bf10d8a06a simplify compare_cached_resolves_by_expiry() to make it match 
the idioms of other compare functions. hopefully i didn't
break it?


svn:r7048
 2006-08-14 07:08:29 +00:00
Roger Dingledine
5647e5c7e6 fix typo, add explanatory comment 
svn:r7026
 2006-08-11 07:31:16 +00:00
Nick Mathewson
04bf4b0fc4 r7327@Kushana: nickm | 2006-08-11 00:00:36 -0700 
Fix a pedantic warning


svn:r7023
 2006-08-11 07:09:45 +00:00
Nick Mathewson
7ddd9e8cd9 r7304@Kushana: nickm | 2006-08-10 01:58:05 -0700 
Fix verbose compilation errors; make sure transparent proxy fails when no method is configured.


svn:r7012
 2006-08-10 09:02:26 +00:00
Nick Mathewson
3da737ac98 r7303@Kushana: nickm | 2006-08-10 01:52:19 -0700 
whitespace fixes


svn:r7011
 2006-08-10 09:02:12 +00:00
Roger Dingledine
bc2e040669 make svn trunk link again. nick can fix this if it's wrong. 
svn:r6982
 2006-08-04 20:30:45 +00:00
Nick Mathewson
3fa1cdafce r7009@Kushana: nickm | 2006-08-03 10:44:58 -0700 
Add functions to eventdns to allow detecting whether we have any nameservers configured, and to change the list of nameservers after initial configuration.


svn:r6976
 2006-08-04 18:26:13 +00:00
Nick Mathewson
87939813c3 r7008@Kushana: nickm | 2006-08-03 10:03:39 -0700 
Oops. We shouldnt initialize eventdns when we are not being a server and not resolving anything.


svn:r6975
 2006-08-04 18:24:41 +00:00
Nick Mathewson
a122bfb439 r7007@Kushana: nickm | 2006-08-03 09:58:30 -0700 
Export and use eventdns_config_windows_nameservers(); clean up some comments and log messages.


svn:r6974
 2006-08-04 18:24:25 +00:00
Roger Dingledine
3152d44c3a fix a seg fault on exit for clients; and fix a comment. 
svn:r6969
 2006-08-03 04:22:25 +00:00
Roger Dingledine
ed567c6feb more compile options mean more codepaths 
svn:r6963
 2006-07-31 20:25:57 +00:00
Nick Mathewson
b9082682fd r6982@Kushana: nickm | 2006-07-31 13:47:19 -0400 
documentation and naming tweaks in dns.c


svn:r6961
 2006-07-31 18:01:49 +00:00
Nick Mathewson
58c0ac77be r6981@Kushana: nickm | 2006-07-31 13:23:26 -0400 
More asserts for cache correctness.


svn:r6960
 2006-07-31 18:01:45 +00:00
Nick Mathewson
fd0bafb0de r6977@Kushana: nickm | 2006-07-31 13:01:28 -0400 
Solve timing-out pending connections. Add pending resolves to expiry queue; when we find an answer, change the pending resolve to "done" and stick the actual answer in the expiry queue as a new entry.  This uses a little more memory, but makes the code simpler than other solutions.


svn:r6956
 2006-07-31 18:01:18 +00:00
Nick Mathewson
ccf9c1345e svn:r6955 2006-07-31 18:00:47 +00:00
Nick Mathewson
46574319a2 r6959@Kushana: nickm | 2006-07-29 22:33:18 -0400 
start restructuring dns to use priority queues for expiring entries.


svn:r6954
 2006-07-31 18:00:18 +00:00
Roger Dingledine
c3b79ebf13 a bit more debugging for phobos 
svn:r6937
 2006-07-30 03:34:44 +00:00
Roger Dingledine
a5e5074807 resolve typo 
svn:r6927
 2006-07-27 19:35:11 +00:00
Nick Mathewson
c2f28615ed More asserts in dns.c 
svn:r6926
 2006-07-27 18:35:56 +00:00
Nick Mathewson
45c3a4365f Get better numbers out of HT_REP_OK 
svn:r6924
 2006-07-27 17:37:37 +00:00
Nick Mathewson
dc2b7e9af0 Add more asserts in dns_found_answer. This may confirm my theory that dns_purge_resolve is the culprit. 
svn:r6922
 2006-07-27 17:16:10 +00:00
Nick Mathewson
0bc741ba7f r6918@Kushana: nickm | 2006-07-26 15:22:28 -0400 
Fix compilation for eventdns dns.c with split structs.


svn:r6908
 2006-07-26 19:29:30 +00:00
Nick Mathewson
ec82db6995 r6909@Kushana: nickm | 2006-07-26 13:05:58 -0400 
Clean up wide lines from last patch.


svn:r6907
 2006-07-26 19:07:37 +00:00
Nick Mathewson
4ff4577beb r6908@Kushana: nickm | 2006-07-26 12:38:52 -0400 
Refactor connection_t into edge, or, dir, control, and base subtypes.  This might save some RAM on busy exit servers, but really matters most in terms of correctness.


svn:r6906
 2006-07-26 19:07:26 +00:00
Nick Mathewson
7239262f71 Don't tell anybody, but we're going OO here. This patch splits 
circuit_t into origin_circuit_t and or_circuit_t.  I fixed some
segaults; there may be more.  We still need to move more rendezvous
stuff into subtypes.

This is a trial run for splitting up connection_t; if the approach is
insane, please say so soon so we can do something smarter.

Also, this discards the old HALF_OPEN code, which nobody seems to
want.


svn:r6817
 2006-07-23 07:37:35 +00:00
Nick Mathewson
64c14d8ce3 These asserts will either cause spurious crashes or help debug the pend->conn->s == -1 issue. 
svn:r6803
 2006-07-21 22:02:58 +00:00
Roger Dingledine
3d79eb52ab stick to nick's nul/null convention 
svn:r6763
 2006-07-15 19:21:30 +00:00
Nick Mathewson
a0cf95e1c9 Add some debugging asserts to dns.c; these are too expensive to leave in permanently. 
svn:r6756
 2006-07-11 20:51:58 +00:00
Nick Mathewson
39344fc301 Add a const; fix a (probably harmless) bug when storing a resolve we forgot we asked for. 
svn:r6751
 2006-07-10 18:38:57 +00:00
Nick Mathewson
a40ad152b1 When using eventdns: suppress logging of addresses when SafeLogging is active, and make set of nameservers configurable from torrc. 
svn:r6744
 2006-07-07 17:33:30 +00:00
Nick Mathewson
3c4205c872 Clean up eventdns messages. 
svn:r6730
 2006-07-05 21:42:18 +00:00
Nick Mathewson
42ef3bd90c Add plausile logging support to eventdns; stop putting stuff onto stdout. 
svn:r6728
 2006-07-05 21:28:37 +00:00
Roger Dingledine
af0e47c921 fix spacing 
svn:r6628
 2006-06-15 22:59:07 +00:00
Roger Dingledine
87e3800dfc Finally solve the "closing wedged cpuworkers" bug. Woo. 
This happened when we got two create cells in a row from the same TLS
connection. It would hand one to the cpuworker, and then immediately
handle the second one -- after it had registered that the first one was
busy, but before it had updated the timestamp that we use to decide how
*long* it's been busy.


svn:r6606
 2006-06-12 11:59:19 +00:00
Roger Dingledine
5c57348acd We got an obscure report of an assert error on a windows Tor server with 
connection_add being called with socket = -1. The only places I can see
where that happen would be if our tor_socketpair succeeds but it hands
back negative values for some of its file descriptors. Perhaps this will
produce more useful assert errors next time.


svn:r6550
 2006-06-06 00:06:52 +00:00
Nick Mathewson
2bd7c19b73 Try to log useful messages at info and debug about what we are resolving and what answers we are getting wrt eventdns. 
svn:r6547
 2006-06-05 23:01:22 +00:00
Nick Mathewson
3db785ef73 Hm. Where did we put that ntohl the last time we were juggling it? (hoop-lah). 
svn:r6534
 2006-06-05 00:32:31 +00:00
Nick Mathewson
853e2d99b6 Add a new warning to our "warn a lot" list: unused parameters. This means we have to explicitly "use" unuseds, but it can catch bugs. (It caught two coding mistakes so far.) 
svn:r6532
 2006-06-04 22:42:13 +00:00
Nick Mathewson
c660a0f6a2 More DNS fixes. Send meaningful TTLs back to the client when 
possible.  Cache at the server side independently from the TTL, to
prevent attackers from probing the server to see who has been asking
for what hostnames.  (Hi, Dan Kaminski!)

Also, clean some whitespace.


svn:r6526
 2006-06-03 21:41:14 +00:00
Nick Mathewson
85a25c8a29 Make dns.c use eventdns.c -- but only when you pass the --enable-eventdns argument to configure.in. This will *so* not work on Windows yet. 
svn:r6525
 2006-06-03 20:52:24 +00:00
Roger Dingledine
6b058bd563 add a few more debugging lines to help mikec track down his 
11 minute jump into the future.


svn:r6465
 2006-05-23 03:08:30 +00:00
Nick Mathewson
6ebd886511 forward-port: "Resolve" all XXX011 items, mostly by marking them non-011. 
svn:r6396
 2006-04-18 03:07:24 +00:00
Roger Dingledine
d1d0813cf3 Allow non-printable characters for exit streams (both for 
connecting and for resolving). Now we tolerate applications
that don't follow the RFCs. But continue to block malformed
names at the socks side.


svn:r6193
 2006-03-19 03:55:48 +00:00
Roger Dingledine
aa63a84fe1 the things we do for our windows users. 
i hope they appreciate it.


svn:r6004
 2006-02-13 09:37:53 +00:00
Roger Dingledine
5f051574d5 Happy new year! 
svn:r5949
 2006-02-09 05:46:49 +00:00
Roger Dingledine
b038dc9ecc disambiguate some debug entries 
svn:r5654
 2005-12-26 22:42:22 +00:00
Nick Mathewson
1af630d32c Bite the bullet and limit all our source lines to 80 characters, the way IBM intended. 
svn:r5582
 2005-12-14 20:40:40 +00:00
Roger Dingledine
58366ffd24 when we changed from log_fn to debug/info/notice/warn/err, 
we screwed up the formatting in wild and unpredictable ways.

fix it before it becomes convention to format logs in wild and
unpredictable ways.

still need to do src/common/ someday.


svn:r5551
 2005-12-10 09:36:26 +00:00
Nick Mathewson
77a494dd55 Expunge remaining places where we used "tree" to mean "associative array". 
svn:r5490
 2005-12-03 02:21:31 +00:00
Nick Mathewson
502cb59611 Remove "tree" references from dns. 
svn:r5488
 2005-12-03 02:01:18 +00:00
Nick Mathewson
a39269572f Replace balanced trees with hash tables: this should make stuff significantly faster. 
svn:r5441
 2005-11-23 04:18:45 +00:00
Nick Mathewson
9492424d3f Per comments at the bottom of openssl/FAQ, call even more functions to 
clean up OpenSSL's toys when it's done playing.  (Why isn't there an
OpenSSL_free_everything() function?)


svn:r5321
 2005-10-25 19:01:48 +00:00
Nick Mathewson
5d85560d9e Remove last vestiges of old logging interface. 
svn:r5317
 2005-10-25 18:01:01 +00:00
Nick Mathewson
049f6c0131 Switch remaining files to new log interface. 
svn:r5315
 2005-10-25 17:52:14 +00:00
Nick Mathewson
92451f74a8 Reformat inconsistent function declarations. 
svn:r5160
 2005-09-30 01:09:52 +00:00
Roger Dingledine
512d6ccdc1 and a minor log cleanup 
svn:r5115
 2005-09-23 00:04:53 +00:00
Roger Dingledine
d050ff7906 resolve lucky's recent bug: tor was exiting if we failed to spawn 
a new dns worker (e.g. because we were out of fd's).


svn:r5112
 2005-09-22 23:43:41 +00:00
Roger Dingledine
843550721a stop notifying people about dns worker spawning and culling 
it just freaks them out


svn:r4960
 2005-09-09 02:03:31 +00:00
Nick Mathewson
a6a45b7713 Add TTLs to RESOLVED, CONNECTED, and END_REASON_EXITPOLICY cells. Also, add a missing ntohl in connection_ap_handshake_socks_resolved. 
svn:r4894
 2005-09-02 18:53:31 +00:00
Roger Dingledine
04d42ea433 rotate dns and cpu workers if the controller changes options that 
will affect them.


svn:r4787
 2005-08-15 23:46:18 +00:00
Roger Dingledine
10ff723938 initialize the dns worker cache tree whether or not we start 
out as a server.


svn:r4785
 2005-08-15 10:27:37 +00:00
Roger Dingledine
87fcd60aa2 predict required circuits better, with an eye toward making 
hidden services faster on the service end.


svn:r4772
 2005-08-13 00:22:07 +00:00
Nick Mathewson
18c11eb3bc Be consistent about preferring foo* to struct foo* 
svn:r4637
 2005-07-22 21:12:10 +00:00
Nick Mathewson
d85bfe83bf Make errors retrievable from tor_socketpair; resolve bug 163. 
svn:r4509
 2005-06-30 07:17:38 +00:00
Roger Dingledine
caf7af26d7 whitespace fix 
svn:r4500
 2005-06-28 01:53:15 +00:00
Roger Dingledine
00a7a37c94 we were printing the number of idle dns workers incorrectly. 
svn:r4477
 2005-06-23 07:57:43 +00:00
Nick Mathewson
232861ba42 Docment or add DOCDOC comments to undocumented functions in src/or. Make function definition format uniform. 
svn:r4411
 2005-06-11 18:52:12 +00:00
Roger Dingledine
fcd0fc3364 flesh out the source file descriptions for doxygen 
svn:r4404
 2005-06-11 05:31:17 +00:00
Nick Mathewson
0831823763 Change end-of-file NLNL convention. It turns out arma I and I agree. 
svn:r4382
 2005-06-09 19:03:31 +00:00
Nick Mathewson
a6f51001a5 New whitespace normalization rule: no blank line at EOF. 
svn:r4378
 2005-06-09 16:46:51 +00:00
Nick Mathewson
10b2208d93 Make Tor compile with no warnings with gcc4.0 on OSX 
svn:r4184
 2005-05-07 05:55:06 +00:00
Roger Dingledine
68ba303323 fix compile error if you're not multithreaded 
svn:r4177
 2005-05-03 18:44:20 +00:00
Roger Dingledine
5265bbd2b8 first iteration of scrubbing sensitive strings from logs. 
also generally clean up log messages.


svn:r4174
 2005-05-03 10:04:08 +00:00
Nick Mathewson
b35f7dacef Call tor_free_all instead of connections_free_all after forking 
svn:r4173
 2005-05-03 03:51:20 +00:00
Roger Dingledine
4eb3cf9330 a bit more debug info 
svn:r4119
 2005-04-26 20:05:15 +00:00
Roger Dingledine
953cf91ecd add more debugging info to help us find the weird dns freebsd pthreads bug. 
svn:r4117
 2005-04-26 19:08:06 +00:00
Roger Dingledine
509405a5f7 clean up this TOR_FRAGILE business 
svn:r4116
 2005-04-26 18:52:16 +00:00
Roger Dingledine
03720b39fd stop wasting time doing a case insensitive comparison for every dns name 
every time we do any lookup. canonicalize the names to lowercase and be
done with it.


svn:r4035
 2005-04-06 20:25:21 +00:00
Nick Mathewson
88dc243bb5 Rename circuit_get_by_stream to circuit_get_by_edge_conn, and actually start using it. Watch out, kids! 
svn:r4026
 2005-04-06 06:43:21 +00:00
Nick Mathewson
4453e3794a Add a pointer from edge connections to their corresponding circuit (ulp!); add some debugging sanity-checking for cirid_orconn_map stuff 
svn:r4024
 2005-04-06 06:13:49 +00:00
Nick Mathewson
b34d9adb59 Fix format warning 
svn:r4022
 2005-04-06 05:44:05 +00:00
Roger Dingledine
712d05c19a a bit more data on gene's dns threading bug 
svn:r4019
 2005-04-06 05:32:24 +00:00
Nick Mathewson
46be0fa999 Make last fix work on windows too. 
svn:r4009
 2005-04-04 21:53:26 +00:00
Nick Mathewson
0fff263a46 Fix possible bug on threading platforms with running out of fds do to cpuworkers and dnsworkers. 
svn:r4008
 2005-04-04 21:46:08 +00:00
Nick Mathewson
0e81265359 update copyright notices. 
svn:r3982
 2005-04-01 20:15:56 +00:00
Roger Dingledine
316afb6d09 fix an assert trigger in cvs: if a resolve request fails, and the circuit 
has vanished in the meantime, then we would both mark it for close
(i.e. put it on the closeable list) and also immediately free it.


svn:r3759
 2005-03-14 04:42:52 +00:00
Nick Mathewson
97dad670ea Renormalize whitespace 
svn:r3757
 2005-03-14 03:18:35 +00:00
Nick Mathewson
afe414f070 Revise all calls to connection_edge_end to avoid sending MISC, and to take errno into account where possible. 
svn:r3720
 2005-03-01 22:42:31 +00:00
Nick Mathewson
f672577bc6 Free even more things on shutdown. Temporarily move tor_free_all out from #ifdef so it gets tested more. 
svn:r3614
 2005-02-11 01:26:47 +00:00
Nick Mathewson
322c728e97 Fix tor-resolve implementation to prevent crashes and send resolves when we should. 
svn:r3561
 2005-02-05 21:03:24 +00:00
Roger Dingledine
56d4b99491 forward-port the logic skew and double-free thing 
svn:r3549
 2005-02-04 01:49:58 +00:00
Roger Dingledine
2e97593d25 define TOR_FRAGILE if you want tor to give you a core when 
something goes wrong. this should only be used by people actively
tracking bugs.


svn:r3487
 2005-02-01 00:37:16 +00:00
Roger Dingledine
b2fbd834f0 forward-port the dns and maxconn fixes 
svn:r3448
 2005-01-28 08:53:47 +00:00
Nick Mathewson
e0bf597665 Give more useful log messages when the tor process closes dns/cpuworker connections. "Error: Success!" makes us seem like crazy people." 
svn:r3373
 2005-01-19 21:34:42 +00:00
Roger Dingledine
814dd946f0 fix duplicate dns_cancel_pending_resolve reported by Giorgos Pallas 
svn:r3293
 2005-01-04 11:26:08 +00:00
Roger Dingledine
ba7c74e742 bandaid: make Giorgos Pallas's dns assert bug not actually crash on him. 
one day we should try to figure out what's actually going on here.


svn:r3280
 2005-01-04 06:21:06 +00:00
Nick Mathewson
b50263f740 More work on task #43: fix race conditions on multithreaded (win32) servers. 
svn:r3251
 2005-01-03 19:07:25 +00:00
Nick Mathewson
ead52e0bdc Possible fix for task #43: when running on a multithreaded environment (currently only windows), threads should not close opposite sides of their socketpairs, and workers should not call connection_free_all(). This may fix win32 servers. 
svn:r3247
 2005-01-03 18:06:51 +00:00
Roger Dingledine
011ad3cba5 clean up logging, 
make it clearer which warns are bugs,
make the control log event match its specification,
point out a bug in how we deal with failure when renewing the tls context.


svn:r3138
 2004-12-13 00:44:39 +00:00
Nick Mathewson
08e3090aff More win32 fixes: 1) tolerate extra "readable" events better. 2) when being multithreaded, leave parent fdarray open. 
svn:r3092
 2004-12-06 23:19:55 +00:00
Nick Mathewson
7fbd297532 Suggestion from weasel: Make tor --version --version dump the cvs Id of every file. 
svn:r3019
 2004-11-29 22:25:31 +00:00
Roger Dingledine
22727b4edc wrong is ok, and right is fine, but in between is apparently 
totally unacceptable to me.


svn:r3005
 2004-11-28 11:39:53 +00:00
Nick Mathewson
6f5dbefa7e Normalize space: add one between every control keyword and control clause. 
svn:r3003
 2004-11-28 09:05:49 +00:00
Roger Dingledine
7c9a707900 remove emacs droppings, since nick says he doesn't need them anymore 
svn:r2989
 2004-11-26 04:00:55 +00:00
Roger Dingledine
310a8da0d2 break reached_eof() out of process_inbuf() 
svn:r2930
 2004-11-21 10:14:57 +00:00
Nick Mathewson
60880cda84 Resolve a bunch of FIXME items; mark a lot more for attention; ask for clarification on some. Turn all XXXX008 ("showstopper for 0.0.8 release") items into XXXX009 or XXXX, since plainly they were not showstoppers for 0.0.8. Add/clean some docs. 
svn:r2808
 2004-11-12 16:39:03 +00:00
Roger Dingledine
394554cfbf Clean up copyrights. 
Break connection_consider_empty_buckets() out of
connection_read_bucket_decrement().


svn:r2698
 2004-11-07 01:33:06 +00:00
Roger Dingledine
6c61ed4fb5 Make options no longer a global variable. 
Now we can try setting an option but back out if it fails to parse, or
  if it's disallowed (e.g. changing RunAsDaemon from 1 to 0).
Use parse_line_from_str rather than parse_line_from_file.


svn:r2692
 2004-11-06 05:18:11 +00:00
Nick Mathewson
6874c39904 Fix windows build 
svn:r2613
 2004-10-27 18:14:38 +00:00
Nick Mathewson
6980929e64 Use strlcpy, not strcpy. 
svn:r2610
 2004-10-27 06:48:16 +00:00
Nick Mathewson
f67f83b1fa Use strlcpy, not strncpy 
svn:r2603
 2004-10-27 06:03:28 +00:00
Roger Dingledine
de65052312 don't assert multiple things in the same tor_assert() 
svn:r2544
 2004-10-16 22:14:52 +00:00
Nick Mathewson
a42adce362 fix memory leak in router.c; start relying on NULL==(zero bytes) 
svn:r2538
 2004-10-16 20:38:57 +00:00
Roger Dingledine
aebc3a03ba more int to size_t conversions, fixing one or more amd64 bugs 
plus a whitespace patch on config.c from vicman


svn:r2482
 2004-10-14 02:47:09 +00:00
Roger Dingledine
013104a1e2 people are starting to bump into the limit of 50 dns workers. 
raise it to 100 for now. we need a better solution long-term.
but alas, there are no better solutions that are also portable.
hm.


svn:r2363
 2004-09-22 03:56:41 +00:00
Nick Mathewson
9defe8a307 Attach dummy resolve connections to a circuit *before* calling dns_resolve(). This fixes a bug where cached answers would never be sent in RESOLVED cells. 
svn:r2360
 2004-09-21 18:12:12 +00:00
Roger Dingledine
d977677aa8 bugfix: when a resolve fails for a begin request, actually send 
the end cell back. also, give a better reason for failure.


svn:r2358
 2004-09-21 17:33:05 +00:00
Nick Mathewson
0dcc8c7048 Bugfix: When a dns request failed, we would detach any "resolving" streams from the circuit before we would send a the resolve_failed cells. 
svn:r2355
 2004-09-21 16:42:07 +00:00
Roger Dingledine
be7909f670 Fix a symptom for a bug that straycat found. 
Apparently in rare cases poll() is returning POLLIN for an idle
dns worker. It reads no bytes, presumably because the idle dns
worker didn't write anything in the first place. Gosh, who knows.

Now we only trigger the assert if the idle dns worker actually
tries to send an answer to us.


svn:r2311
 2004-08-25 05:26:09 +00:00
Roger Dingledine
05790d1722 let children survive sigint, sigterm, etc. 
this was biting us because ^c would get delivered to all of them,
maybe because they were all still listening to stdin?


svn:r2197
 2004-08-08 07:25:45 +00:00
Roger Dingledine
3b00c950c2 note a bug in our dns error handling. we should fix this sometime. 
svn:r2149
 2004-08-05 19:33:54 +00:00
Roger Dingledine
aebec8ab9e stop using atexit() to remove our pid, since it's called 
immediately when we daemonize.

also drop our retry period for hidserv desc uploads from 10m to 5m


svn:r2111
 2004-07-22 22:15:36 +00:00
Nick Mathewson
d5e275ddf4 Fix bug reported by peter palfrader: an empty address is unresolvable, but not an occasion for an assertion failure in a dnsworker. 
svn:r2015
 2004-07-06 23:25:21 +00:00
Nick Mathewson
0f3fcfd1db When tor_lookup_hostname says 0.0.0.0, treat it as an error. 
svn:r2003
 2004-07-04 04:52:43 +00:00
Nick Mathewson
3708886939 Implement RESOLVE/RESOLVED cells and socks resolve code 
svn:r1978
 2004-06-17 18:13:09 +00:00
Nick Mathewson
184f4e6044 Rotate dnsworkers and cpuworkers on SIGHUP, so they get new config settings too 
svn:r1950
 2004-06-06 03:38:31 +00:00
Roger Dingledine
69931106f8 be sure to detach streams from the circuit linked list before freeing them 
also, don't bother marking a conn for close if you're about to free it


svn:r1935
 2004-06-02 18:32:24 +00:00
Nick Mathewson
0932505829 Only connection_dns_remove resolving exit connections 
svn:r1934
 2004-06-02 18:12:49 +00:00
Nick Mathewson
0d20fee2fb Add more asserts to dns-pending connections; fix a couple seeming bugs. 
svn:r1931
 2004-06-01 22:09:58 +00:00
Roger Dingledine
f51061439b when the dns resolve is cancelled, or fails, be sure to remove 
conn from circ->resolving_streams

otherwise it gets freed and stays there, causing seg faults.


svn:r1915
 2004-05-21 12:25:15 +00:00
Roger Dingledine
b37450ce55 do all the heavy lifting in connection_about_to_close_connection, 
not in _connection_mark_for_close

this will hopefully clean up the huge cyclical function mess


svn:r1903
 2004-05-19 23:32:20 +00:00
Roger Dingledine
1cf1836990 break connection_edge_end out of connection_mark_for_close 
svn:r1858
 2004-05-12 21:12:33 +00:00