Commit Graph

10946 Commits

Author SHA1 Message Date
Sebastian Hahn
b792afa919 Fix a memory leak when parsing a ns
Adding the same vote to a networkstatus consensus leads to a memory leak
on the client side. Fix that by only using the first vote from any given
voter, and ignoring the others.

Problem found by Rotor, who also helped writing the patch. Thanks!
2009-09-14 22:25:08 +02:00
Roger Dingledine
fcacf22491 Fix obscure 64-bit big-endian hidserv bug
Fix an obscure bug where hidden services on 64-bit big-endian
systems might mis-read the timestamp in v3 introduce cells, and
refuse to connect back to the client. Discovered by "rotor".
Bugfix on 0.2.1.6-alpha.
2009-09-02 20:36:11 -04:00
Roger Dingledine
3db36d86c4 turns out the packaging changes aren't in 0.2.1.20 2009-09-01 22:46:41 -04:00
Andrew Lewman
5657e803f8 update changelog with bundle details 2009-09-01 22:04:10 +02:00
Nick Mathewson
bddda9bbdb Use an _actual_ fix for the byte-reverse warning.
(Given that we're pretty much assuming that int is 32 bits, and given that
hex values are always unsigned, taking out the "ul" from 0xff000000 should
be fine.)
2009-09-01 15:51:09 -04:00
Nick Mathewson
2f0184ece1 Use a simpler fix for the byte-reversing warning 2009-09-01 15:41:38 -04:00
Sebastian Hahn
aea9cf1011 Fix compile warnings on Snow Leopard
Big thanks to nickm and arma for helping me with this!
2009-09-01 18:36:27 +02:00
Roger Dingledine
075c004095 Add getinfo accepted-server-descriptor. Clean spec.
Add a "getinfo status/accepted-server-descriptor" controller
command, which is the recommended way for controllers to learn
whether our server descriptor has been successfully received by at
least on directory authority. Un-recommend good-server-descriptor
getinfo and status events until we have a better design for them.
2009-08-31 18:37:25 -04:00
Roger Dingledine
4c297f74f7 Only send reachability status events on overall success/failure
We were telling the controller about CHECKING_REACHABILITY and
REACHABILITY_FAILED status events whenever we launch a testing
circuit or notice that one has failed. Instead, only tell the
controller when we want to inform the user of overall success or
overall failure. Bugfix on 0.1.2.6-alpha. Fixes bug 1075. Reported
by SwissTorExit.
2009-08-31 16:14:41 -04:00
Roger Dingledine
64f393d56f Only send netinfo clock_skew to controller if an authority told us so
We were triggering a CLOCK_SKEW controller status event whenever
we connect via the v2 connection protocol to any relay that has
a wrong clock. Instead, we should only inform the controller when
it's a trusted authority that claims our clock is wrong. Bugfix
on 0.2.0.20-rc; starts to fix bug 1074. Reported by SwissTorExit.
2009-08-28 03:42:09 -04:00
Roger Dingledine
d52284559b extremely infinite? who talks like that? 2009-08-27 21:54:41 -04:00
Roger Dingledine
127069f3d2 nobody forward-ported the 0.2.0.35 changelog 2009-08-26 14:11:53 -04:00
Nick Mathewson
937dc4d81c Merge commit 'phobos/vidalia-bundle-updates-maint-0.2.1' into maint-0.2.1 2009-08-25 16:36:39 -04:00
phobos
25f9e20a1c update osx-dmg creation directions for the new methods 2009-08-25 15:58:25 -04:00
Nick Mathewson
9d11827780 Fix a rare infinite-recursion bug when shutting down.
Once we had called log_free_all(), anything that tried to log a
message (like a failed tor_assert()) would fail like this:

   1. The logging call eventually invokes the _log() function.
   2. _log() calls tor_mutex_lock(log_mutex).
   3. tor_mutex_lock(m) calls tor_assert(m).
   4. Since we freed the log_mutex, tor_assert() fails, and tries to
      log its failure.
   5. GOTO 1.

Now we allocate the mutex statically, and never destroy it on
shutdown.

Bugfix on 0.2.0.16-alpha, which introduced the log mutex.

This bug was found by Matt Edman.
2009-08-20 11:55:33 -04:00
Andrew Lewman
c9b8a4a133 update fetch-all with dir auth 2009-08-13 21:13:09 -04:00
Karsten Loesing
a98643c1b5 Fix possible segmentation fault on directory authorities.
The more verbose logs that were added in ee58153 also include a string
that might not have been initialized. This can lead to segfaults, e.g.,
when setting up private Tor networks. Initialize this string with NULL.
2009-08-11 17:33:58 +02:00
Roger Dingledine
e50b7768b9 Send sendmes when we're down 100 cells, not 101.
Send circuit or stream sendme cells when our window has decreased
by 100 cells, not when it has decreased by 101 cells. Bug uncovered
by Karsten when testing the "reduce circuit window" performance
patch. Bugfix on the 54th commit on Tor -- from July 2002,
before the release of Tor 0.0.0. This is the new winner of the
oldest-bug prize.
2009-08-10 04:13:18 -04:00
Roger Dingledine
e53ee805a9 directory-archive scripts now fetch from urras too 2009-08-10 03:06:56 -04:00
Roger Dingledine
8abe3bac7e Set up urras as the seventh v3 directory authority. 2009-08-10 01:32:51 -04:00
Nick Mathewson
c497d21ee1 Merge commit 'karsten/hsauth-manpage-maint-0.2.1' into maint-0.2.1 2009-08-09 18:12:01 -07:00
Andrew Lewman
431202fb63 add geoip file to uninstall 2009-08-03 12:42:29 -04:00
Andrew Lewman
0d12f12cf5 add receipts to be wiped. 2009-08-01 22:41:29 -04:00
Karsten Loesing
fe36f69ce8 Make configuration of hidden services with authorization somewhat clearer. 2009-08-01 11:36:51 +02:00
Nick Mathewson
4577bda766 Cleaner fix for get_effective_bw(rate|burst), with comment on why it is ok. 2009-07-30 10:14:12 -04:00
Nick Mathewson
0f944e496a Merge commit 'debian-tor-0.2.1.19-1' into maint-0.2.1 2009-07-29 18:35:50 -04:00
Peter Palfrader
58ccdfccef Mention that this closes #538960 in the changelog 2009-07-29 12:49:52 +02:00
Peter Palfrader
cd8d488d83 Merge branch 'debian-merge' into debian
* debian-merge:
  New upstream version
  bump to 0.2.1.19
  document my new relay-early behavior
  Changing MaxAdvertisedBW may not need a republish
  Write fingerprint to file and log without spaces
  Don't leak memory if we get too many create cells
  three hacks to workaround bug 1038
2009-07-29 12:18:37 +02:00
Peter Palfrader
3d99723411 New upstream version 2009-07-29 12:18:25 +02:00
Peter Palfrader
5962431a36 Merge commit 'tor-0.2.1.19' into debian-merge
* commit 'tor-0.2.1.19':
  bump to 0.2.1.19
  document my new relay-early behavior
  Changing MaxAdvertisedBW may not need a republish
  Write fingerprint to file and log without spaces
  Don't leak memory if we get too many create cells
  three hacks to workaround bug 1038
2009-07-29 12:18:06 +02:00
Roger Dingledine
6a960d515f credit optimist for the bug 1038 diagnosis
also bring the release notes up to date
2009-07-28 20:44:51 -04:00
Roger Dingledine
6249b0fd77 Fix a signed/unsigned compile warning in 0.2.1.19 2009-07-28 18:34:35 -04:00
Roger Dingledine
69706f99e8 bump to 0.2.1.19 2009-07-28 17:39:51 -04:00
Roger Dingledine
146eae318f document my new relay-early behavior 2009-07-28 17:39:12 -04:00
Sebastian Hahn
3e45445104 Changing MaxAdvertisedBW may not need a republish
Relays no longer publish a new server descriptor if they change
their MaxAdvertisedBandwidth config option but it doesn't end up
changing their advertised bandwidth numbers. Bugfix on 0.2.0.28-rc;
fixes bug 1026. Patch from Sebastian.
2009-07-27 23:53:06 -04:00
Roger Dingledine
a73acdd46f Write fingerprint to file and log without spaces
Now it will look like the fingerprints in our bridges documentation,
and confuse fewer users.
2009-07-27 22:51:20 -04:00
Roger Dingledine
0a4e2397c0 Don't leak memory if we get too many create cells
Specifically, every time we get a create cell but we have so many already
queued that we refuse it.

Bugfix on 0.2.0.19-alpha; fixes bug 1034. Reported by BarkerJr.
2009-07-27 22:38:09 -04:00
Roger Dingledine
2b63fa40e8 three hacks to workaround bug 1038
The problem is that clients and hidden services are receiving
relay_early cells, and they tear down the circuit.

Hack #1 is for rendezvous points to rewrite relay_early cells to
relay cells. That way there are never any incoming relay_early cells.

Hack #2 is for clients and hidden services to never send a relay_early
cell on an established rendezvous circuit. That works around rendezvous
points that haven't upgraded yet.

Hack #3 is for clients and hidden services to not tear down the circuit
when they receive an inbound relay_early cell. We already refuse extend
cells at clients.
2009-07-27 21:58:32 -04:00
Peter Palfrader
f39cee3754 Merge branch 'debian-merge' into debian
* debian-merge:
  New upstream version
  bump to 0.2.1.18
  put in the full 0.2.1 release notes
  add a changelog entry for the upcoming 0.2.1.18
  make phobos's lines start with tabs again
  added LIBS=-lrt to Makefile.am for static libevent in the tor rpms.
  forward-port the 0.2.0.35 release notes
  add blurbs for recent release candidates
  Bump version to 0.2.1.17-rc-dev
2009-07-25 11:15:42 +02:00
Peter Palfrader
805b19e4f1 New upstream version 2009-07-25 11:15:34 +02:00
Peter Palfrader
d7ffd0ed8a Merge commit 'tor-0.2.1.18' into debian-merge
* commit 'tor-0.2.1.18':
  bump to 0.2.1.18
  put in the full 0.2.1 release notes
  add a changelog entry for the upcoming 0.2.1.18
  make phobos's lines start with tabs again
  added LIBS=-lrt to Makefile.am for static libevent in the tor rpms.
  forward-port the 0.2.0.35 release notes
  add blurbs for recent release candidates
  Bump version to 0.2.1.17-rc-dev
2009-07-25 11:10:36 +02:00
Roger Dingledine
52b142219b bump to 0.2.1.18 2009-07-24 17:31:04 -04:00
Roger Dingledine
6b334bb813 put in the full 0.2.1 release notes 2009-07-24 17:25:51 -04:00
Roger Dingledine
575519d9a5 add a changelog entry for the upcoming 0.2.1.18 2009-07-24 17:16:07 -04:00
Roger Dingledine
4b5371686c make phobos's lines start with tabs again
in case Make on openirix128 can't handle it otherwise
2009-07-24 17:15:14 -04:00
Andrew Lewman
be5faae7a9 added LIBS=-lrt to Makefile.am for static libevent in the tor rpms. 2009-07-24 17:07:26 -04:00
Roger Dingledine
6277aee031 forward-port the 0.2.0.35 release notes 2009-07-24 16:54:54 -04:00
Roger Dingledine
b2fa8e8622 add blurbs for recent release candidates 2009-07-24 16:53:40 -04:00
Nick Mathewson
bdd367eb45 Merge commit 'debian-tor-0.2.1.17-rc-1' into maint-0.2.1 2009-07-14 15:35:16 -04:00
Peter Palfrader
95a6623645 Release 0.2.1.17-rc-1 2009-07-13 23:38:13 +02:00