nihilist/tor - tor - Git with a cup of Datura seeds

mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-12 14:13:43 +01:00

Author	SHA1	Message	Date
Nick Mathewson	cefe0a1959	r18255@catbus: nickm \| 2008-02-20 11:44:55 -0500 Add asserts and refactor some comparisons in order to fix some veracode-identified issues. Note a bug in buffers.c svn:r13618	2008-02-20 16:57:39 +00:00
Roger Dingledine	1c8bd320be	pass bucket sizes num_read and num_written around as size_ts rather than ints svn:r13610	2008-02-20 02:17:41 +00:00
Roger Dingledine	f2ed011813	We were comparing the raw BridgePassword entry with a base64'ed version of it, when handling a "/tor/networkstatus-bridges" directory request. Now compare correctly. Noticed by Veracode. svn:r13609	2008-02-20 02:05:28 +00:00
Roger Dingledine	f34d46e7dd	similarly, don't throw around an int for the uint8_t circ->state svn:r13608	2008-02-20 01:01:09 +00:00
Roger Dingledine	7427cf5d56	don't throw around an int for relay_command if we're going to squeeze it into a uint8_t later. also reported by veracode. svn:r13607	2008-02-20 00:57:37 +00:00
Roger Dingledine	0977c29196	notice an integer overflow if we ever get source files with more than 65k lines in them. also pointed out by veracode. svn:r13606	2008-02-20 00:46:09 +00:00
Roger Dingledine	e9474ed28e	if you thought r13604 was a kludge, how about this. svn:r13605	2008-02-20 00:30:41 +00:00
Roger Dingledine	56a7c9238e	be more clear about a possible integer underflow problem. this should probably be fixed better somehow. svn:r13604	2008-02-20 00:11:52 +00:00
Roger Dingledine	e0beb6cc5e	check return value for crypto_pk_asn1_encode here too. thanks veracode. svn:r13603	2008-02-19 23:59:16 +00:00
Nick Mathewson	260c37c14c	r18236@catbus: nickm \| 2008-02-19 18:55:21 -0500 Explain why I am right and veracode is wrong in routerparse.c line 1141. Using math! svn:r13602	2008-02-19 23:57:06 +00:00
Roger Dingledine	913f66278c	rearrange our assert so we don't possibly overflow rh.length before triggering the assert. reported by veracode. svn:r13601	2008-02-19 23:54:17 +00:00
Nick Mathewson	0399538b90	r18233@catbus: nickm \| 2008-02-19 18:46:07 -0500 Count sockets returned from socketpair() too. This is probably not the socket counting bug. svn:r13600	2008-02-19 23:46:08 +00:00
Roger Dingledine	707da4f73f	start checking the return value of crypto_pk_asn1_encode() while we're trying to establish an introduction point. bug reported by veracode. svn:r13599	2008-02-19 23:33:02 +00:00
Nick Mathewson	42c4670e27	r18230@catbus: nickm \| 2008-02-19 18:29:43 -0500 Add a few asserts to catch possible errors found by veracode. svn:r13598	2008-02-19 23:29:45 +00:00
Roger Dingledine	319c0d8933	is_reverse in our struct is uint8_t. don't make it be an int elsewhere. bug reported by veracode. svn:r13597	2008-02-19 23:14:34 +00:00
Nick Mathewson	dbcf29d301	r18228@catbus: nickm \| 2008-02-19 18:05:53 -0500 Chris Palmer notes that almost nobody is using smartlist_set_capacity(). Chris Palmer is right. Remove this basically pointless function. svn:r13596	2008-02-19 23:05:56 +00:00
Nick Mathewson	9479dd3768	r18226@catbus: nickm \| 2008-02-19 18:01:01 -0500 Brown-paper-bag time. We were failing to count all the sockets from accept(). svn:r13595	2008-02-19 23:01:07 +00:00
Roger Dingledine	d1a195d3cb	call a "number of characters" a size_t, not an int svn:r13594	2008-02-19 22:52:50 +00:00
Roger Dingledine	c126b79f07	be more explicit about a harmless thing that freaked veracode out svn:r13592	2008-02-19 22:32:32 +00:00
Nick Mathewson	4ccffd7aea	r18218@catbus: nickm \| 2008-02-19 17:27:40 -0500 When SafeLogging is off, have TLS errors and messages logged with their associated addresses. svn:r13591	2008-02-19 22:27:44 +00:00
Roger Dingledine	810bfe970c	make explicit that we don't care if a rename() call fails. potential bug reported by veracode. svn:r13590	2008-02-19 22:25:20 +00:00
Roger Dingledine	23e4c849c9	resolve another edge case in staying dormant svn:r13586	2008-02-19 22:01:45 +00:00
Roger Dingledine	da7f0315e6	maybe it should compile too. svn:r13585	2008-02-19 21:41:43 +00:00
Roger Dingledine	d964beac16	If we only ever used Tor for hidden service lookups or posts, we would stop building circuits and start refusing connections after 24 hours, since we false believed that Tor was dormant. Reported by nwf; bugfix on 0.1.2.x. svn:r13583	2008-02-19 21:30:24 +00:00
Roger Dingledine	33c754315b	clear up another connlimit lie svn:r13582	2008-02-19 21:08:27 +00:00
Nick Mathewson	b98c437fcc	r18195@catbus: nickm \| 2008-02-19 14:11:15 -0500 TOR_PERF has not not been a sane thing for ages. Remove it. svn:r13579	2008-02-19 19:30:37 +00:00
Roger Dingledine	be8a85dc1c	document that if you enable TOR_PERF, you won't be compatible with the main Tor network. svn:r13577	2008-02-19 18:54:44 +00:00
Nick Mathewson	8c6b5d6640	r14246@tombo: nickm \| 2008-02-17 19:33:02 -0500 Fix a wide line in control.c; make the check-spaces target ignore the openbsd malloc file. svn:r13566	2008-02-19 05:08:27 +00:00
Nick Mathewson	3277e2a8ca	r18142@catbus: nickm \| 2008-02-18 14:24:31 -0500 Our preferred spelling for a bitfield is "unsigned int", not "unsigned" or "uint8_t". svn:r13560	2008-02-18 19:24:33 +00:00
Nick Mathewson	08f7842384	r18139@catbus: nickm \| 2008-02-18 13:14:05 -0500 Clarify logic in trusted_dirs_load_certs_from_string(); avoid a maybe-impossible maybe-not double-free spotted by lodger. svn:r13558	2008-02-18 18:14:34 +00:00
Nick Mathewson	9e9b447b87	r14243@tombo: nickm \| 2008-02-17 14:51:26 -0500 Better debugging to track down bug 606. Also remove a break; that may have been the possible culprit svn:r13547	2008-02-17 19:51:33 +00:00
Nick Mathewson	faa56a500b	r14236@tombo: nickm \| 2008-02-17 13:44:55 -0500 Partial fix for bug 586: Add an ephemeral __HashedControlSessionPassword. svn:r13543	2008-02-17 18:45:07 +00:00
Roger Dingledine	4c1e516a09	cleanups and changelog entry for r13540 svn:r13542	2008-02-17 16:52:24 +00:00
Roger Dingledine	bd959adcb7	patch from karsten: Resolved problems with (re-)fetching hidden service descriptors. Before, v0 descriptors were not fetched at all (fix on 0.2.0.18-alpha), re-fetching of v2 descriptors did not stop when a v0 descriptor was received (fix on 0.2.0.18-alpha), and re-fetching of v2 descriptors did not work in all cases (fix on 0.2.0.19-alpha). svn:r13540	2008-02-17 16:47:47 +00:00
Nick Mathewson	6366dcd8ee	r14186@tombo: nickm \| 2008-02-15 18:38:52 -0500 Add an XXXX021 item so we eventually stop calling setuid() and setgid() unnecessarily. svn:r13533	2008-02-15 23:39:17 +00:00
Nick Mathewson	24e8e1fb36	r14185@tombo: nickm \| 2008-02-15 18:05:54 -0500 Replace the hefty tor_strpartition with a simple function to replace its only (trivial) use. svn:r13532	2008-02-15 23:39:14 +00:00
Nick Mathewson	f5ed1f8469	r14183@tombo: nickm \| 2008-02-15 17:37:53 -0500 Add initial unit tests for test_addr_compare_masked svn:r13531	2008-02-15 23:39:10 +00:00
Nick Mathewson	ca4eb987c8	r14182@tombo: nickm \| 2008-02-15 17:20:51 -0500 Defer, downgrade, or address more XXX020s. The remaining ones are all ones we should deal with before release. svn:r13530	2008-02-15 23:39:08 +00:00
Nick Mathewson	418c2e1b6b	r14181@tombo: nickm \| 2008-02-15 16:48:17 -0500 Fix all but 2 DOCDOC items; defer many XXX020s (particularly those where fixing them would fix no bugs at the risk of introducing some bugs). svn:r13529	2008-02-15 23:39:04 +00:00
Nick Mathewson	ff64e78b20	r14170@tombo: nickm \| 2008-02-15 11:50:38 -0500 Fix or downgrade a bunch of xxx020 items. svn:r13527	2008-02-15 19:20:53 +00:00
Nick Mathewson	275bb57a77	r18068@catbus: nickm \| 2008-02-13 11:33:19 -0500 Patch from karsten: make hidden service code respect SafeLogging. svn:r13493	2008-02-13 16:34:00 +00:00
Nick Mathewson	d48f6425e5	r18066@catbus: nickm \| 2008-02-13 11:22:19 -0500 Bugfix from Karsten: "Reversed r13439; v2 rendezvous descriptors were only re-fetched when a directory connection did not finish, not when a directory correctly replied with an error code like 404; bug found by nwf. svn:r13492	2008-02-13 16:23:28 +00:00
Nick Mathewson	7ae3f6a491	r18056@catbus: nickm \| 2008-02-12 17:21:10 -0500 Add roger's responses from IRC to some XXX020 items. svn:r13487	2008-02-12 22:21:20 +00:00
Roger Dingledine	3abafccd0e	Start choosing which bridge to use proportional to its advertised bandwidth, rather than uniformly at random. This should speed up Tor for bridge users. Also do this for people who set StrictEntryNodes. svn:r13486	2008-02-12 22:02:47 +00:00
Nick Mathewson	f3eaeb99a3	r18051@catbus: nickm \| 2008-02-12 15:20:43 -0500 Re-tune mempool parametes based on testing on peacetime: use smaller chuncks, free them a little more aggressively, and try very hard to concentrate allocations on fuller chunks. Also, lots of new documentation. svn:r13484	2008-02-12 20:20:52 +00:00
Nick Mathewson	aace52320c	r18041@catbus: nickm \| 2008-02-11 23:43:18 -0500 Make version negotiation and handshaking messages more useful and accurate. svn:r13477	2008-02-12 04:43:25 +00:00
Nick Mathewson	8682293388	r18029@catbus: nickm \| 2008-02-11 12:36:39 -0500 Fix command.c compilation with gcc 4.2 warnings enabled. svn:r13475	2008-02-12 04:37:00 +00:00
Roger Dingledine	a89e523f19	note a simplification for the future svn:r13466	2008-02-11 06:34:10 +00:00
Roger Dingledine	28483467d0	Directory mirrors no longer include a guess at the client's IP address if the connection appears to be coming from the same /24 network; it was producing too many wrong guesses. svn:r13464	2008-02-11 05:31:56 +00:00
Nick Mathewson	65ee9dc585	r14108@tombo: nickm \| 2008-02-10 20:09:10 -0500 add some documentation svn:r13462	2008-02-11 01:09:24 +00:00
Nick Mathewson	ab0c85eea6	r14103@tombo: nickm \| 2008-02-10 13:40:09 -0500 Fix some XXX020s in command.c, and make it not-allowed to negotiate v1 using the v2 connection protocol: it is too hard to test, and pointless to support. svn:r13460	2008-02-10 18:40:29 +00:00
Nick Mathewson	b5c03f05d8	r14102@tombo: nickm \| 2008-02-10 13:30:04 -0500 Remove some deadcode. svn:r13459	2008-02-10 18:40:27 +00:00
Nick Mathewson	a4db22f675	r14101@tombo: nickm \| 2008-02-10 13:24:27 -0500 Merge connection_or_act_on_netinfo into command.c; remove some fields from or_handshake_state(). svn:r13458	2008-02-10 18:40:23 +00:00
Roger Dingledine	5a0f214908	patch from tup to fix bug 605 svn:r13453	2008-02-09 22:52:29 +00:00
Roger Dingledine	d2528e6b48	"fix" the unit tests on openbsd/netbsd svn:r13450	2008-02-09 21:41:49 +00:00
Roger Dingledine	965afb4970	cleanups on r13442. oh, and this should be backported too. svn:r13444	2008-02-09 10:46:22 +00:00
Roger Dingledine	b42c9d69f0	Patch from "Andrew S. Lists" to catch when we contact a directory mirror at IP address X and he says we look like we're coming from IP address X. svn:r13442	2008-02-09 10:36:49 +00:00
Roger Dingledine	509d2912dc	doxygen and other cleanups svn:r13440	2008-02-09 03:11:10 +00:00
Nick Mathewson	be1e577d5e	Re-fetch v2 rendezvous descriptor only when first try failed. Patch from karsten. svn:r13439	2008-02-09 02:51:20 +00:00
Roger Dingledine	1f034cc5c7	note a question for nick svn:r13437	2008-02-09 02:34:00 +00:00
Nick Mathewson	8f7fcdd64e	r17991@catbus: nickm \| 2008-02-08 18:41:26 -0500 More protocol negotiation work. Make the negotiation actually complete and set the state to open. Fix a crash bug that occured when we forcibly stopped the connection from writing. svn:r13434	2008-02-08 23:41:29 +00:00
Nick Mathewson	272d37deb3	r17989@catbus: nickm \| 2008-02-08 18:09:23 -0500 Fix a new segfault when poisoning a non-present socks request. svn:r13433	2008-02-08 23:09:26 +00:00
Nick Mathewson	a378bb5f5a	r17985@catbus: nickm \| 2008-02-08 16:30:02 -0500 Bugfix from Karsten Loesing: Retry v2 rend descriptors on intro point failure. svn:r13431	2008-02-08 21:30:07 +00:00
Nick Mathewson	141a5877f3	r14063@tombo: nickm \| 2008-02-08 15:48:32 -0500 Add a bunch more code documentation; change the interface of fetch_var_cell_from_buf() so it takes the current link protocol into account and can't get confused by weird command bytes on v1 connections. svn:r13430	2008-02-08 21:13:15 +00:00
Nick Mathewson	de827f89df	r14062@tombo: nickm \| 2008-02-08 15:17:07 -0500 Change DNs in x509 certificates to be harder to fingerprint. Raise common code. Refactor random hostname generation into crypto.c svn:r13429	2008-02-08 21:13:12 +00:00
Nick Mathewson	809227a121	r14061@tombo: nickm \| 2008-02-08 14:30:42 -0500 Add a couple of (currently disabled) strategies for trying to avoid using too much ram in memory pools: prefer putting new cells in almost-full chunks, and be willing to free the last empty chunk if we have not needed it for a while. Also add better output to mp_pool_log_status to track how many mallocs a given memory pool strategy is saving us, so we can tune the mempool parameters. svn:r13428	2008-02-08 21:13:08 +00:00
Nick Mathewson	5d250d3e1b	r14060@tombo: nickm \| 2008-02-08 13:36:52 -0500 Fix warning in onion.c svn:r13427	2008-02-08 21:13:05 +00:00
Nick Mathewson	8ab4b0d302	r14059@tombo: nickm \| 2008-02-08 13:36:34 -0500 downgrade xxxs in test.c svn:r13426	2008-02-08 21:13:02 +00:00
Nick Mathewson	23a9c9695b	r17968@catbus: nickm \| 2008-02-07 14:11:02 -0500 Clean up IPv6-testing code in test.c; resolve a bunch of XXX020s. svn:r13425	2008-02-08 21:09:35 +00:00
Nick Mathewson	729555e1ca	r17967@catbus: nickm \| 2008-02-07 11:44:51 -0500 Fix some warnings identified by building with -D_FORTIFY_SOURCE=2. Remove a redundant (and nuts) definition of _FORTIFY_SOURCE from eventdns.c. svn:r13424	2008-02-08 21:09:29 +00:00
Nick Mathewson	eecc44dab8	r17963@catbus: nickm \| 2008-02-07 10:14:25 -0500 Be more thorough about memory poisoning and clearing. Add an in-place version of aes_crypt in order to remove a memcpy from relay_crypt_one_payload. svn:r13414	2008-02-07 16:10:33 +00:00
Nick Mathewson	842a33ff20	Update some copyright notices: it is now 2008. svn:r13412	2008-02-07 05:31:47 +00:00
Nick Mathewson	46b1a21dc4	r17955@catbus: nickm \| 2008-02-06 16:53:07 -0500 The SSL portion of the revised handshake now seems to work: I just finally got a client and a server to negotiate versions. Now to make sure certificate verification is really happening, connections are getting opened, etc. svn:r13409	2008-02-06 21:53:13 +00:00
Nick Mathewson	4d70094b6e	r17951@catbus: nickm \| 2008-02-06 14:34:13 -0500 Add more documentation; change the behavior of read_to_buf_tls to be more consistent. Note a longstanding problem with current read/write interfaces. svn:r13407	2008-02-06 19:34:32 +00:00
Nick Mathewson	6e2946fb5d	r17949@catbus: nickm \| 2008-02-06 13:21:12 -0500 Fix bandwidth bucked calculations again, I think. Bugfix on 0.1.2.x. Backport candidate. svn:r13406	2008-02-06 18:21:16 +00:00
Nick Mathewson	a869574c56	r17947@catbus: nickm \| 2008-02-06 11:57:53 -0500 Fix a bunch of DOCDOC items; document the --quiet flag; refactor a couple of XXXX020 items. svn:r13405	2008-02-06 16:58:05 +00:00
Roger Dingledine	f76cdc1a61	misc small fixes svn:r13403	2008-02-06 12:46:46 +00:00
Roger Dingledine	c054f90f02	New config option ServerDNSAllowBrokenResolvConf to start a relay even when the local resolv.conf file is missing, broken, or contains only unusable nameservers. Now I can run a local network on my laptop when I'm on an airplane. svn:r13402	2008-02-06 12:46:17 +00:00
Roger Dingledine	bbcf406d9f	If the networkstatus consensus lists no recommended versions, don't complain to the user and demand that they upgrade to one of "". svn:r13401	2008-02-06 12:45:04 +00:00
Roger Dingledine	e49d712b8a	if i'm a v3 authority, tell myself about my cert when i startup. otherwise i'll keep asking other authorities for it, which probably isn't the best way to get it. this made bootstrapping a new network very hard. svn:r13400	2008-02-06 12:39:25 +00:00
Roger Dingledine	55971c71b6	if we have a networkstatus concensus but only 0 or 1 descriptors, don't declare that we're ready to build circuits yet. we're not. svn:r13399	2008-02-06 12:37:25 +00:00
Roger Dingledine	d1aafdc519	don't fetch or cache running-routers files if there are no v1 authorities svn:r13398	2008-02-06 12:36:04 +00:00
Nick Mathewson	ec6c131da6	r17936@catbus: nickm \| 2008-02-06 00:31:11 -0500 Fix/downgrade some more XXX020s. svn:r13397	2008-02-06 05:31:21 +00:00
Nick Mathewson	368f62c79d	r17933@catbus: nickm \| 2008-02-05 19:54:28 -0500 Stamp out a bunch of atoi users; make more tor_parse_long() users check their outputs. svn:r13395	2008-02-06 00:54:47 +00:00
Nick Mathewson	12071df6c8	r17930@catbus: nickm \| 2008-02-05 18:20:40 -0500 Initial attempts to track down bug 600, and refactor possibly offending code. 1) complain early if circuit state is set to OPEN when an onionskin is pending. 2) refactor onionskin field into one only used when n_conn is pending, and a separate onionskin field waiting for attention by a cpuworker. This might even fix the bug. More likely, it will make it fail with a more useful core. svn:r13394	2008-02-05 23:20:49 +00:00
Nick Mathewson	ff9bd0fd3a	r17929@catbus: nickm \| 2008-02-05 17:10:26 -0500 Fix or downgrade a few XXX020 items. svn:r13393	2008-02-05 23:20:44 +00:00
Nick Mathewson	9c7eaa7a9d	r17918@catbus: nickm \| 2008-02-05 16:39:17 -0500 Remove a few #if-0d items. svn:r13392	2008-02-05 21:39:56 +00:00
Nick Mathewson	7dc70c2405	r17917@catbus: nickm \| 2008-02-05 16:38:15 -0500 Oops; fix compilation of control.c svn:r13391	2008-02-05 21:39:51 +00:00
Nick Mathewson	fac2cd3b03	r17916@catbus: nickm \| 2008-02-05 16:29:35 -0500 Fix some XXX020 items in control.c: add a maximum line length and note that the number of versioning authorities is no longer apparent to clients. svn:r13390	2008-02-05 21:39:49 +00:00
Nick Mathewson	cf6fe27616	r17915@catbus: nickm \| 2008-02-05 16:28:57 -0500 Remove a dead function. svn:r13389	2008-02-05 21:39:46 +00:00
Nick Mathewson	92aaf68d19	r17914@catbus: nickm \| 2008-02-05 16:12:16 -0500 Remove or downgrade some XXX020 items. svn:r13388	2008-02-05 21:39:44 +00:00
Nick Mathewson	c11c48fc78	r17913@catbus: nickm \| 2008-02-05 16:11:33 -0500 Correctly register failures in connection_add() in dnsserv_launch_request() svn:r13387	2008-02-05 21:39:40 +00:00
Nick Mathewson	83e740fa91	r17911@catbus: nickm \| 2008-02-05 15:53:22 -0500 Fix a potential bug that would make authorities fail to vote under bizarre circumstances that probably never happened. svn:r13385	2008-02-05 21:39:36 +00:00
Nick Mathewson	e09c207c3c	r17910@catbus: nickm \| 2008-02-05 15:36:29 -0500 Check for correctness of AuthDir* options in options_validate; check for possible bugs where options_validate() is happy but parse_policies_from_options() is sad. svn:r13384	2008-02-05 21:39:32 +00:00
Nick Mathewson	c8a689c9e8	r17909@catbus: nickm \| 2008-02-05 14:48:22 -0500 As planned, rename networkstatus_vote_t to networkstatus_t, now that v3 networkstatuses are working and standard and v2 networkstatuses are obsolete. svn:r13383	2008-02-05 21:39:29 +00:00
Nick Mathewson	a51deb9a9c	r17903@catbus: nickm \| 2008-02-05 14:40:03 -0500 Remove some dead code; fix some XXX020s; turn some XXX020s into XXXX_IP6s (i.e., "needs to be fixed when we add ipv6 support"). svn:r13382	2008-02-05 19:40:26 +00:00
Nick Mathewson	2866c53eec	r17900@catbus: nickm \| 2008-02-05 14:14:54 -0500 I wonder what the emacs command is for "exchange words?" I know that there _is_ one, because I apparently hit it by accident. svn:r13381	2008-02-05 19:40:21 +00:00
Nick Mathewson	3958d7b16f	r17898@catbus: nickm \| 2008-02-05 14:01:35 -0500 Add (and use) a MAP_DEL_CURRENT macro to augment a non-const variant of MAP_FOREACH. svn:r13379	2008-02-05 19:40:17 +00:00
Nick Mathewson	2502359a5b	r17897@catbus: nickm \| 2008-02-05 13:51:40 -0500 Whitespace cleanups svn:r13378	2008-02-05 19:40:15 +00:00
Roger Dingledine	fdbefc8934	If we're a relay, avoid picking ourselves as an introduction point, a rendezvous point, or as the final hop for internal circuits. Bug reported by taranis and lodger. Bugfix on 0.1.2.x. svn:r13372	2008-02-04 17:25:24 +00:00
Roger Dingledine	426a9bbde1	Don't trigger an assert if we start a directory authority with a private IP address (like 127.0.0.1). svn:r13371	2008-02-04 16:58:50 +00:00
Roger Dingledine	dad9f434e0	correct copyright statement svn:r13370	2008-02-04 16:54:14 +00:00
Nick Mathewson	91bac90310	r17863@catbus: nickm \| 2008-02-01 00:27:07 -0500 Bugfix from weasel: possible fix for 593: make connection_write_to_buf("") work when using zlib compression. svn:r13347	2008-02-01 05:27:12 +00:00
Nick Mathewson	f013fb5e31	r17854@catbus: nickm \| 2008-01-30 17:52:43 -0500 Periodically check whether we have an expired consensus networkstatus. If we do, and we think we have enough directory info, then call router_dir_info_changed(). Fixes bug 401. This bug was deferred from 0.1.2.x, but fixing it there is nontrivial. svn:r13342	2008-01-30 22:52:46 +00:00
Nick Mathewson	1793aeafae	r17852@catbus: nickm \| 2008-01-30 17:23:36 -0500 Correctly insert connections into the identity->connection map when we connect to a bridge without having specified its key. Fixes bug 574. svn:r13341	2008-01-30 22:23:44 +00:00
Roger Dingledine	78633b3a03	suggest a better fix for bug 597 svn:r13340	2008-01-30 20:53:14 +00:00
Nick Mathewson	0b06546620	r17844@catbus: nickm \| 2008-01-30 13:31:37 -0500 Fix bug 597: stop telling people to email Tor-ops. Also give a better suggestion when some other identity has been assigned the nickname we are using. svn:r13337	2008-01-30 18:32:30 +00:00
Roger Dingledine	6dfd2f531c	Revert r13301 and part of r13304. I guess nick's svk messed up. svn:r13305	2008-01-27 01:03:30 +00:00
Nick Mathewson	68cf666d04	Fix bug 571: associate certificates with keys, not dirservers, so that we can have certificates for dirservers we do not recognize. svn:r13304	2008-01-26 23:18:30 +00:00
Nick Mathewson	ad07366da5	Fix compile with warnings enabled svn:r13301	2008-01-26 22:03:13 +00:00
Roger Dingledine	42f90bdc14	"de" means to do something, and "in" means to undo it. right? help prevent future versions of bug 593. svn:r13288	2008-01-26 01:05:16 +00:00
Roger Dingledine	af4b735e9a	move hidden-service stuff out of directory.c svn:r13287	2008-01-26 00:42:13 +00:00
Roger Dingledine	aa25bf1405	a slightly better interface for hid_serv_get_responsible_directories() svn:r13271	2008-01-25 07:22:42 +00:00
Roger Dingledine	5fcc79185f	avoid calling smartlist_get(..., -1) if we have a consensus but no hsdir nodes. svn:r13270	2008-01-25 07:11:32 +00:00
Roger Dingledine	d72ccd95a8	clean out some proposal 114 stuff svn:r13269	2008-01-25 06:47:46 +00:00
Roger Dingledine	1445e17a21	We were computing the wrong Content-Length: header for directory responses that need to be compressed on the fly, causing clients asking for those items to always fail. Bugfix on 0.2.0.x; fixes bug 593. svn:r13268	2008-01-25 01:45:06 +00:00
Roger Dingledine	649a63f435	don't pre-initialize some vars that we assign to right after svn:r13267	2008-01-25 01:34:20 +00:00
Roger Dingledine	d262fff20d	patch "15" from karsten: don't retry a v2 renddesc fetch if we have a perfectly good v0 renddesc. svn:r13265	2008-01-24 22:49:14 +00:00
Roger Dingledine	cbe9863422	patch "14a" from karsten: don't fail if we can't find REND_NUMBER_OF_CONSECUTIVE_REPLICAS v2 hsdirs. svn:r13263	2008-01-24 22:46:29 +00:00
Peter Palfrader	ab79f53206	Some log messages during dirvoting - maybe downgrade to debug if you want svn:r13261	2008-01-24 20:00:37 +00:00
Roger Dingledine	aca8d8fc03	patch from karsten to make vote logs more useful svn:r13260	2008-01-24 19:48:16 +00:00
Roger Dingledine	ba7a37cf94	shrink it even more. coding is fun! svn:r13258	2008-01-24 07:33:28 +00:00
Roger Dingledine	317f9e6551	more shrinking; get rid of selectible_dirs smartlist that was leaking on error cases svn:r13257	2008-01-24 07:22:59 +00:00
Roger Dingledine	529263f8ab	continue r13250 cleanup: remove some duplicate code svn:r13256	2008-01-24 06:58:10 +00:00
Roger Dingledine	4637a61b3c	more cleanup on r13250: no need to log in both places svn:r13253	2008-01-24 05:15:50 +00:00
Roger Dingledine	c973eb5e23	start to clean up r13250: retry v2 renddesc fetches when we fail to reach the dirserver too. svn:r13251	2008-01-24 04:45:30 +00:00
Roger Dingledine	6b1374556e	put in karsten's "patch 14". needs a lot of cleanup and a changelog. svn:r13250	2008-01-24 03:28:50 +00:00
Roger Dingledine	980fcb1ca7	When we get a consensus that's been signed by more people than we expect, don't log about it; it's not a big deal. svn:r13249	2008-01-24 02:31:37 +00:00
Roger Dingledine	e67f23f897	weasel was worried there was a leak here. i don't think there is. but i could be wrong. svn:r13248	2008-01-24 01:14:50 +00:00
Peter Palfrader	12bd40931b	Fix a warning svn:r13243	2008-01-23 09:05:40 +00:00
Peter Palfrader	1d91c156fe	Some people still think letters fall off the side of the code if they go farther than 80 chars svn:r13242	2008-01-23 08:45:14 +00:00
Peter Palfrader	fc91704f78	Log where uploaded consensus signatures come from svn:r13241	2008-01-23 08:38:05 +00:00
Roger Dingledine	9d1832dd5a	Set up dannenberg (run by CCC) as the sixth v3 directory authority. svn:r13231	2008-01-22 22:38:38 +00:00
Roger Dingledine	a49f14d0d4	When we setconf ClientOnly to 1, close any current OR and Dir listeners. Reported by mwenge. svn:r13214	2008-01-21 21:21:19 +00:00
Roger Dingledine	b79850d574	Make "ClientOnly 1" config option disable directory ports too. svn:r13213	2008-01-21 21:00:50 +00:00
Roger Dingledine	ff62154ba3	New config options WarnPlaintextPorts and RejectPlaintextPorts so Tor can warn and/or refuse connections to ports commonly used with vulnerable-plaintext protocols. We still need to figure out some good defaults for them. svn:r13198	2008-01-20 05:54:15 +00:00
Roger Dingledine	a1f2817307	minor cleanups svn:r13190	2008-01-19 20:00:53 +00:00
Roger Dingledine	7dde7b02a2	try to grow a convention about where we put the time_to_foo and FOO_INTERVAL declarations. svn:r13177	2008-01-18 05:00:35 +00:00
Roger Dingledine	43dce232ad	If we've gone 12 hours since our last bandwidth check, and we estimate we have less than 50KB bandwidth capacity but we could handle more, do another bandwidth test. svn:r13176	2008-01-18 04:58:40 +00:00
Roger Dingledine	3d3663a123	Don't answer "/tor/networkstatus-bridges" directory requests if the request isn't encrypted. svn:r13175	2008-01-18 04:51:12 +00:00
Roger Dingledine	6228213647	minor typo svn:r13174	2008-01-18 04:50:15 +00:00
Roger Dingledine	4682e5f924	when we're counting how many descriptors to not download, be a little bit more accurate svn:r13173	2008-01-18 04:47:03 +00:00
Roger Dingledine	06047bcec9	Avoid going directly to the directory authorities even if you're a relay, if you haven't found yourself reachable yet or if you've decided not to advertise your dirport yet. Addresses bug 556. svn:r13172	2008-01-18 04:42:22 +00:00
Roger Dingledine	55e052b0a5	Assert error introduced in r11957: Fix an assert if we post a general-purpose descriptor via the control port but that descriptor isn't mentioned in our current network consensus. Bug reported by Jon McLachlan; bugfix on 0.2.0.9-alpha. svn:r13153	2008-01-17 05:25:21 +00:00
Nick Mathewson	4a3b7496f0	r17639@catbus: nickm \| 2008-01-15 19:09:21 -0500 Fix some hard to trigger but nonetheless real memory leaks spotted by an anonymous contributor. Needs review. Partial backport candidate. svn:r13147	2008-01-16 05:27:19 +00:00
Nick Mathewson	24aae484c9	r17624@catbus: nickm \| 2008-01-15 00:42:01 -0500 Fixes to more anonymously-reported typos and logic errors. svn:r13136	2008-01-15 05:57:19 +00:00
Nick Mathewson	a984011814	r17623@catbus: nickm \| 2008-01-15 00:22:04 -0500 bulletproof option_get_canonical_name() svn:r13135	2008-01-15 05:57:14 +00:00
Nick Mathewson	89dfec02d8	r17614@catbus: nickm \| 2008-01-14 13:55:25 -0500 Add a missing "goto err" when parsing v2 ns docs svn:r13133	2008-01-14 19:00:33 +00:00
Nick Mathewson	581ba51c5c	r17612@catbus: nickm \| 2008-01-14 13:46:04 -0500 Oops; fix compile svn:r13131	2008-01-14 19:00:26 +00:00
Nick Mathewson	3b8f76aa51	r17611@catbus: nickm \| 2008-01-14 13:44:16 -0500 add some missing checks for failing return values. svn:r13130	2008-01-14 19:00:23 +00:00
Nick Mathewson	e49229caf8	r17610@catbus: nickm \| 2008-01-14 13:20:49 -0500 Fix a bogus free() call on a base64 failure in router_append_dirobj_signature(). svn:r13129	2008-01-14 19:00:19 +00:00
Nick Mathewson	edf5e70784	r15891@tombo: nickm \| 2008-01-12 19:20:24 -0500 Basic hacks to get TLS handshakes working: remove dead code; fix post-handshake logic; keep servers from writing while the client is supposed to be renegotiating. This may work. Needs testing. svn:r13122	2008-01-13 00:20:47 +00:00
Nick Mathewson	ae6df065ed	r15890@tombo: nickm \| 2008-01-12 17:19:51 -0500 Add a --disable-buffer-freelists configure argument to build without buffer RAM chunk freelists, so we can benchmark the impact of this. svn:r13121	2008-01-13 00:20:44 +00:00
Nick Mathewson	705b4670d3	r17580@catbus: nickm \| 2008-01-11 20:40:30 -0500 Fix policies.c build on gcc 4.2 with warnings. svn:r13112	2008-01-12 05:52:59 +00:00
Roger Dingledine	4e9a701d4b	fix unit tests after r13092 svn:r13100	2008-01-10 23:11:13 +00:00
Nick Mathewson	b84955285a	r17564@catbus: nickm \| 2008-01-10 13:19:59 -0500 Fix bug in r13094: be sure to set the purpose and send_unencrypted fields correctly in our own routerinfo and extrainfo. svn:r13098	2008-01-10 18:20:04 +00:00
Nick Mathewson	10d86f7615	r17558@catbus: nickm \| 2008-01-10 13:07:41 -0500 If we do not serve v2 directory info, and our cached v2 networkstatus files are very old, remove them. If the directory is old, remove that too. (We already did this for obsolete routers files.) svn:r13096	2008-01-10 18:08:42 +00:00
Roger Dingledine	2ac1e36248	minor cleanups svn:r13095	2008-01-10 17:54:24 +00:00
Nick Mathewson	04263648c4	r17554@catbus: nickm \| 2008-01-10 12:48:29 -0500 Do not send bridge descriptors over unencrypted connections. svn:r13094	2008-01-10 17:48:40 +00:00
Nick Mathewson	29b0f51a73	r17553@catbus: nickm \| 2008-01-10 12:18:27 -0500 Add connection_dir_is_encrypted() so that we can refrain from sending bridge descriptors over an unencrypted link. svn:r13093	2008-01-10 17:48:36 +00:00
Nick Mathewson	59fdab43cd	r17552@catbus: nickm \| 2008-01-10 12:13:43 -0500 Make bridge geoip data get rounded up, not down. svn:r13092	2008-01-10 17:48:32 +00:00
Nick Mathewson	ca5f670fab	r17548@catbus: nickm \| 2008-01-10 11:08:12 -0500 Make proposal-109 behavior optional. svn:r13090	2008-01-10 16:08:47 +00:00
Roger Dingledine	a7eef34a03	Jan 08 19:55:01.865 [notice] Added -2 pending signatures while building consensus. svn:r13080	2008-01-09 01:06:19 +00:00
Roger Dingledine	7d3bf1608b	Set up gabelmoo (run by Karsten Loesing) as the fifth v3 directory authority. svn:r13079	2008-01-08 23:51:48 +00:00
Roger Dingledine	8609c825e9	our defensive programming plan hid a bug. switch to offensive programming. svn:r13078	2008-01-08 23:35:03 +00:00
Roger Dingledine	50f4cd10ad	don't rebuild the router store for all those times when we fetch one descriptor and then we don't like it svn:r13077	2008-01-08 23:31:25 +00:00
Roger Dingledine	58d88dfc7f	make new v3 authorities that aren't in the DirServers list believe in themselves again. bug experienced by karsten. svn:r13076	2008-01-08 23:08:39 +00:00
Nick Mathewson	177d5102d5	r17503@catbus: nickm \| 2008-01-07 14:15:30 -0500 Change set_current_consensus interface to take a flags variable. Do not try to fetch certificates until after we have tried loading the fallback consensus. Should fix bug 583. svn:r13058	2008-01-07 19:15:34 +00:00
Nick Mathewson	a62ab48d30	r17500@catbus: nickm \| 2008-01-07 13:54:51 -0500 More messing about with bug 557 issues: do not let bizarre settings for myfamily or contactinfo muck with generated router descriptors. svn:r13057	2008-01-07 18:54:58 +00:00
Nick Mathewson	dd35fe59c4	r17499@catbus: nickm \| 2008-01-07 13:39:46 -0500 Bugfix on fix for 557: Make values containing special characters work right with getconf, setconf, and saveconf. Document this in control-spec.txt svn:r13056	2008-01-07 18:54:55 +00:00
Nick Mathewson	a63eb68fe1	r17495@catbus: nickm \| 2008-01-07 12:48:56 -0500 Consequence of fix for 539: when a client gets a 503 response with a nontrivial body, pretend it got a 200 response. This lets clients use information erroneously sent to them by old buggy servers. svn:r13054	2008-01-07 17:49:13 +00:00
Roger Dingledine	ea2280ada7	hack at networkstatus.c until we actually try to load our fallback consensus. nick, can you take a closer look at this, and add a changelog entry if it's a valid fix? svn:r13050	2008-01-07 15:41:47 +00:00
Roger Dingledine	5a912aa1c8	cleanups on r13037 svn:r13045	2008-01-06 23:37:48 +00:00
Nick Mathewson	d73b791969	r17473@catbus: nickm \| 2008-01-05 22:15:05 -0500 Add a reverse mapping from SSL to tor_tls_t*: we need this in order to do a couple of things the sensible way from inside callbacks. Also, add a couple of missing cases in connection_or.c svn:r13040	2008-01-06 03:16:11 +00:00
Roger Dingledine	5aa7ce2915	patch from karsten to complain less when a node loses its hsdir status svn:r13037	2008-01-06 01:54:09 +00:00
Nick Mathewson	17036de8b7	r17469@catbus: nickm \| 2008-01-05 20:14:07 -0500 Fix bug 579: Count DNSPort and hidden services when checking whether Tor is going to do anything. Change "no configured ports" from fatal to warning. svn:r13036	2008-01-06 01:14:11 +00:00
Nick Mathewson	614dc52623	r17467@catbus: nickm \| 2008-01-05 19:54:20 -0500 fix whitespace svn:r13035	2008-01-06 00:54:22 +00:00
Nick Mathewson	58de695f90	r15787@tombo: nickm \| 2008-01-02 01:59:07 -0500 Allow config values in quotes to contain special characters, with full C escape syntax. With tests. Addresses bug 557. svn:r13021	2008-01-02 06:59:15 +00:00
Nick Mathewson	86f5180853	r15786@tombo: nickm \| 2008-01-02 01:11:51 -0500 Push the strdups used for parsing configuration lines into parse_line_from_string(). This will make it easier to parse more complex value formats, which in turn will help fix bug 557 svn:r13020	2008-01-02 06:59:12 +00:00
Nick Mathewson	c0ec281565	r15784@tombo: nickm \| 2008-01-02 00:38:06 -0500 Fix bug 575: protect the list of logs with a mutex. I couldn't find any appreciable change in logging performance on osx, but ymmv. You can undef USE_LOG_MUTEX to see if stuff gets faster for you. svn:r13019	2008-01-02 05:38:53 +00:00
Nick Mathewson	feb1c60e9d	r15782@tombo: nickm \| 2008-01-01 23:57:43 -0500 Bugfix for bug 569: do not try to download nonexistant certificates with signing key 000000000000000. svn:r13018	2008-01-02 04:57:48 +00:00
Nick Mathewson	11fff225fa	r15779@tombo: nickm \| 2008-01-01 23:43:24 -0500 Use reference-counting to avoid allocating a zillion little addr_policy_t objects. (This is an old patch that had been sitting on my hard drive for a while.) svn:r13017	2008-01-02 04:43:44 +00:00
Nick Mathewson	48d7adca8a	r15768@tombo: nickm \| 2007-12-31 16:12:09 -0500 Patch from Tup: make NS events work again. svn:r13009	2007-12-31 21:12:16 +00:00
Nick Mathewson	46a27c2f93	r15750@tombo: nickm \| 2007-12-29 19:12:51 -0500 Make HTTP-processing code in buffers.c faster: do not pull up 50K of text into the first chunk if the headers end earlier than that. svn:r13006	2007-12-30 00:13:07 +00:00
Nick Mathewson	cd85eac0d3	r17433@catbus: nickm \| 2007-12-29 12:35:57 -0500 Incomplete code to avoid doing needless pull-ups on HTTP. Also, use memstr instead of strstr to find the content-length header. svn:r13005	2007-12-29 17:36:03 +00:00
Nick Mathewson	f4f5dc4aca	r15745@tombo: nickm \| 2007-12-29 00:15:17 -0500 Try even harder not to allocate chunks bigger than MAX_CHUNK_ALLOC. svn:r13003	2007-12-29 05:16:30 +00:00
Nick Mathewson	bd32982c77	r17426@catbus: nickm \| 2007-12-28 21:12:29 -0500 Remove need for buf_pullup in fetch_line_from_buf(). svn:r13002	2007-12-29 02:33:42 +00:00
Nick Mathewson	d7f5a73173	r17410@catbus: nickm \| 2007-12-27 09:20:27 -0500 Exciting new entries in buf_dump_freelist_sizes() to make sure our freelist sizes are reasonable. svn:r12996	2007-12-27 14:20:30 +00:00
Nick Mathewson	1a2b6c2ae3	r17407@catbus: nickm \| 2007-12-27 00:18:31 -0500 Fix windows compile error svn:r12995	2007-12-27 05:18:36 +00:00
Nick Mathewson	119b4e1edf	r17405@catbus: nickm \| 2007-12-26 22:27:37 -0500 And clean up an assertion failure. svn:r12993	2007-12-27 03:27:48 +00:00
Nick Mathewson	148e2e1c48	r17403@catbus: nickm \| 2007-12-26 22:23:50 -0500 Apparently loops work better when you actually increment/decrement the loop variable. Who knew? svn:r12992	2007-12-27 03:23:57 +00:00
Nick Mathewson	1503021ee5	r15723@tombo: nickm \| 2007-12-26 19:25:51 -0500 Actually trim freelists. svn:r12991	2007-12-27 00:25:54 +00:00
Nick Mathewson	3a5bee150f	r15721@tombo: nickm \| 2007-12-26 17:07:10 -0500 Fix a nasty infinite loop in flush_buf[_tls]. svn:r12990	2007-12-26 22:07:14 +00:00
Nick Mathewson	27220fb395	r15719@tombo: nickm \| 2007-12-26 14:02:12 -0500 More tweaks on 0-byte TLS writes. svn:r12989	2007-12-26 19:02:15 +00:00
Nick Mathewson	80151b42df	r15717@tombo: nickm \| 2007-12-26 13:55:53 -0500 Oops. flush_buf_tls can request more than the requested number of bytes. When that happens, do not let the size_t sz wrap around. svn:r12988	2007-12-26 18:55:56 +00:00
Nick Mathewson	84b6e26c50	r15715@tombo: nickm \| 2007-12-26 13:09:27 -0500 Peacetime managed to run overnight in paranoia mode. Disabling paranoia, so that buffers.c can be a little speedy again. svn:r12987	2007-12-26 18:09:36 +00:00
Nick Mathewson	fb8cbc8642	r15710@tombo: nickm \| 2007-12-25 19:36:03 -0500 Fix in flush_buf_tls: it is okay to flush an empty buffer, since we may have a partial TLS record pending. svn:r12984	2007-12-26 00:36:05 +00:00
Nick Mathewson	a7ef07b4bd	r15693@tombo: nickm \| 2007-12-25 19:11:29 -0500 Here, have some terribly clever new buffer code. It uses a mbuf-like strategy rather than a ring buffer strategy, so it should require far far less extra memory to hold any given amount of data. Also, it avoids access patterns like x=malloc(1024);x=realloc(x,1048576);x=realloc(x,1024);append_to_freelist(x) that might have been contributing to memory fragmentation. I've tested it out a little on peacetime, and it seems to work so far. If you want to benchmark it for speed, make sure to remove the #define PARANOIA; #define NOINLINE macros at the head of the module. svn:r12983	2007-12-26 00:12:08 +00:00
Roger Dingledine	c6788cc0de	The bridge GeoIP stats were counting other relays, for example self-reachability and authority-reachability tests. svn:r12960	2007-12-25 00:07:13 +00:00
Roger Dingledine	5925bc972c	tweaks svn:r12959	2007-12-24 23:51:22 +00:00
Roger Dingledine	15c048bdc5	Fix several remotely triggerable asserts based on DirPort requests for a v2 or v3 networkstatus object before we were prepared. This was particularly bad for 0.2.0.13 and later bridge relays, who would never have a v2 networkstatus and would thus always crash when used. Bugfixes on 0.2.0.x. Estimate the v3 networkstatus size more accurately, rather than estimating it at zero bytes and giving it artificially high priority compared to other directory requests. Bugfix on 0.2.0.x. svn:r12952	2007-12-24 11:25:45 +00:00
Roger Dingledine	4fb573fddd	bugfix on r10612: When we load a bridge descriptor from the cache, and it was previously unreachable, mark it as retriable so we won't just ignore it. Also, try fetching a new copy immediately. svn:r12950	2007-12-24 10:31:39 +00:00
Nick Mathewson	da06bfb80f	r15653@tombo: nickm \| 2007-12-23 14:15:12 -0500 Refactor circuit_launch* functions to take a bitfield of flags rather than 4 separate nonconsecutive flags arguments. Also, note a possible but in circuit_find_to_cannibalize, which seems to be ignoring its purpose argument. svn:r12948	2007-12-23 19:15:22 +00:00
Nick Mathewson	473725e1a4	r15648@tombo: nickm \| 2007-12-23 13:27:30 -0500 Support building for iPhone; patch from cjacker huang. svn:r12946	2007-12-23 18:27:47 +00:00
Roger Dingledine	c10faf5085	fix some irix compile complaints; make "kbytes" work as a memory unit svn:r12936	2007-12-23 04:22:55 +00:00
Roger Dingledine	9dcde682f5	minor other things in my sandbox svn:r12934	2007-12-23 01:28:25 +00:00
Roger Dingledine	61bd5583d9	If we receive a general-purpose descriptor and then receive an identical bridge-purpose descriptor soon after, don't discard the next one as a duplicate. svn:r12933	2007-12-23 01:18:14 +00:00
Roger Dingledine	fe006ad880	and clean up after myself svn:r12930	2007-12-22 11:54:33 +00:00
Roger Dingledine	88503e25c7	If bridge authorities set BridgePassword, they will serve a snapshot of known bridge routerstatuses from their DirPort to anybody who knows that password. Unset by default. svn:r12929	2007-12-22 11:48:17 +00:00
Roger Dingledine	87a616e128	Fix a crash on startup if you install Tor 0.2.0.13-alpha fresh without a datadirectory from a previous Tor install. Reported by Zax. svn:r12928	2007-12-22 11:42:12 +00:00
Roger Dingledine	abf9fadcca	start working on serving bridge status from the dirport, for bridge communities. svn:r12927	2007-12-22 10:54:21 +00:00
Roger Dingledine	ce636beff9	If the user sets RelayBandwidthRate but doesn't set RelayBandwidthBurst, then make them equal rather than erroring out. svn:r12925	2007-12-22 09:13:24 +00:00
Roger Dingledine	be906a836a	If BridgeRelay is set to 1, then the default for PublishServerDescriptor is now "bridge" rather than "v2,v3". svn:r12923	2007-12-22 09:04:46 +00:00
Roger Dingledine	39d910e97b	Make PublishServerDescriptor default to 1, so the default doesn't have to change as we invent new directory protocol versions. svn:r12922	2007-12-22 08:27:42 +00:00
Roger Dingledine	6097e46420	Fix a crash when we load a bridge descriptor from disk but we don't currently have a Bridge line for it in our torrc. Bugfix on 0.2.0.12-alpha. svn:r12921	2007-12-22 06:11:49 +00:00
Roger Dingledine	366c273d27	Make "GETINFO/desc-annotations/id/<OR digest>" actually work. svn:r12919	2007-12-22 05:27:30 +00:00
Roger Dingledine	869858bf57	add a little note about matt's 0.2.0.12-alpha crash svn:r12918	2007-12-22 05:26:36 +00:00
Roger Dingledine	a223f5db03	Fix a crash when accessing hidden services: it would work the first time you use a given introduction point for your service, but on subsequent requests we'd be using garbage memory. Fixed by Karsten Loesing. Bugfix on 0.2.0.12-alpha. svn:r12913	2007-12-21 23:28:23 +00:00
Roger Dingledine	73ff2e5d5e	Fix a crash when we fetch a descriptor that turns out to be unexpected (it used to be in our networkstatus when we started fetching it, but it isn't in our current networkstatus), and we aren't using bridges. Bugfix on 0.2.0.x. svn:r12911	2007-12-21 22:58:22 +00:00
Roger Dingledine	c1af7de6e4	the better fix for the unit tests svn:r12907	2007-12-21 10:44:10 +00:00
Roger Dingledine	46bb4a40ee	Make the unit tests build again. svn:r12905	2007-12-21 10:40:40 +00:00
Roger Dingledine	3f4080d15d	tiny tweaks on r12900 svn:r12901	2007-12-21 09:33:11 +00:00
Roger Dingledine	90fcfade4e	revert r12841 and r12842, and commit karsten's "patch 13" svn:r12900	2007-12-21 09:28:22 +00:00
Roger Dingledine	7b60d6c526	Directory authorities should only automatically download Extra Info documents if they're v1, v2, or v3 authorities. svn:r12898	2007-12-21 06:33:02 +00:00
Roger Dingledine	e2dc45a2e1	some more refactoring svn:r12897	2007-12-21 06:28:59 +00:00
Roger Dingledine	9ebf86bb66	new config option FetchDirInfoEarly for tup/ioerror and the tordnsel svn:r12896	2007-12-21 06:08:00 +00:00
Roger Dingledine	f0e7c4f0da	Only Tors that want to mirror the v2 directory info should create the "cached-status" directory in their datadir. All Tors used to create it. Bugfix on 0.1.2.x. Bridge relays with DirPort set to 0 no longer cache v1 or v2 directory information; there's no point. Bugfix on trunk. svn:r12887	2007-12-20 06:47:59 +00:00
Roger Dingledine	acd8bc1fd9	make r12871 do what i meant svn:r12886	2007-12-20 06:36:44 +00:00
Nick Mathewson	2f922937d3	r17274@catbus: nickm \| 2007-12-20 01:14:09 -0500 Don't try to create the datadir when we are only verifying the configuration or hashing a password. Resolves bug 540. svn:r12884	2007-12-20 06:15:09 +00:00
Nick Mathewson	6de2b484cf	r17270@catbus: nickm \| 2007-12-20 00:04:21 -0500 When we decide to send a 503 in response to a request for server descriptors, disable spooling so that we do not then send the descriptors anyway. Fixes bug 539. svn:r12882	2007-12-20 05:06:02 +00:00
Nick Mathewson	5c33c0632e	r17268@catbus: nickm \| 2007-12-19 23:53:53 -0500 Initialize [un]named_server_map to empty strmaps when router_reload_consensus_networkstatus fails completely. Resolves bug 538. svn:r12881	2007-12-20 04:54:06 +00:00
Roger Dingledine	4aa5e678cd	and the obligatory 'make it compile' follow-up svn:r12872	2007-12-19 05:04:05 +00:00
Roger Dingledine	f405f9b614	Make getinfo ns/purpose/bridge actually work Also, dump our bridge router status entries to disk every 30 minutes. svn:r12871	2007-12-19 04:58:58 +00:00
Nick Mathewson	a697573ce9	r15562@tombo: nickm \| 2007-12-18 23:23:59 -0500 Remove the LearnAuthorityAddrFromCerts option; make it always-on. One option down, ~160 options to go. svn:r12870	2007-12-19 04:24:05 +00:00
Nick Mathewson	95fecd6fbc	r15560@tombo: nickm \| 2007-12-18 23:18:21 -0500 Add a bit of missing documentation. svn:r12869	2007-12-19 04:18:28 +00:00
Nick Mathewson	95d500f33f	r15558@tombo: nickm \| 2007-12-18 22:55:23 -0500 Re-parse annotations in another place. Good catch, arma. svn:r12868	2007-12-19 03:55:40 +00:00
Roger Dingledine	07c7f9e9e7	When we were reading router descriptors from cache, we were ignoring the annotations -- including reading in bridge-purpose descriptors as general-purpose descriptors. svn:r12867	2007-12-19 03:11:02 +00:00
Nick Mathewson	d07122ba47	r17246@catbus: nickm \| 2007-12-18 18:45:17 -0500 Fix some xxx020 items. svn:r12864	2007-12-18 23:45:24 +00:00
Nick Mathewson	076097281d	r17239@catbus: nickm \| 2007-12-18 16:57:02 -0500 Sort GeoIP results in descending order of IP counts. svn:r12863	2007-12-18 23:45:19 +00:00
Roger Dingledine	74d05f4b2c	answer getinfo ns/purpose/bridge queries svn:r12860	2007-12-18 22:39:15 +00:00
Roger Dingledine	b63a247c68	Make bridge authorities test reachability of bridges. Added two XXX020's that we need to think harder about. svn:r12859	2007-12-18 21:37:58 +00:00
Nick Mathewson	d2fe8542df	r17232@catbus: nickm \| 2007-12-18 16:22:10 -0500 Whitespace fix. svn:r12857	2007-12-18 21:27:10 +00:00
Nick Mathewson	5488bc3e16	r17231@catbus: nickm \| 2007-12-18 16:21:55 -0500 Document and clean-up geoip code; give it some unit tests. svn:r12856	2007-12-18 21:27:08 +00:00
Nick Mathewson	b8ac050e85	r15532@tombo: nickm \| 2007-12-17 17:41:05 -0500 clean up whitesapce and debug a little on geoip stuff. svn:r12847	2007-12-17 22:44:18 +00:00
Nick Mathewson	25f78498f9	r15531@tombo: nickm \| 2007-12-17 17:19:24 -0500 Support raw IP-to-country as well as postprocessed format. Include GEOIP summary in extrainfo of bridges. svn:r12846	2007-12-17 22:44:16 +00:00
Nick Mathewson	820159cac5	r15530@tombo: nickm \| 2007-12-17 16:54:03 -0500 First wodge of geoip code so bridges can figure out which countries are blocking them. svn:r12845	2007-12-17 22:44:11 +00:00
Roger Dingledine	b3e6c66a05	and another in the unit tests svn:r12842	2007-12-16 20:47:20 +00:00
Roger Dingledine	e70d9a7f4d	fix another mem leak, and point out another for karsten svn:r12841	2007-12-16 20:46:23 +00:00
Roger Dingledine	98a56a386d	our unit tests leak memory like a sieve. fix two actual memory leaks found while cleaning up a bit. svn:r12829	2007-12-16 08:20:10 +00:00
Roger Dingledine	71c84abdff	cleanups on r12825 svn:r12826	2007-12-15 20:50:56 +00:00
Roger Dingledine	31324f3e7f	apply karsten's "patch 12" svn:r12825	2007-12-15 20:28:09 +00:00
Roger Dingledine	1d8a8063b9	clean up copyrights, and assign 2007 copyrights to The Tor Project, Inc svn:r12786	2007-12-12 21:09:01 +00:00
Roger Dingledine	40efd7d47b	but don't disable all the default v1 authorities quite yet svn:r12778	2007-12-12 04:46:16 +00:00
Roger Dingledine	3b2dd8d763	Three new config options (AlternateDirAuthority, AlternateBridgeAuthority, and AlternateHSAuthority) that let the user selectively replace the default directory authorities, rather than the all-or-nothing replacement that DirServer offers. svn:r12777	2007-12-12 04:38:54 +00:00
Nick Mathewson	3208b102d6	r17089@catbus: nickm \| 2007-12-11 17:33:34 -0500 Patch from mwenge: fix consensus status lookup by nickname when nickname is a hexdigest. svn:r12766	2007-12-11 23:06:45 +00:00
Roger Dingledine	78f532678c	Relays were publishing their server descriptor to v1 and v2 directory authorities, but they didn't try publishing to v3-only authorities. Fix this; and also stop publishing to v1 authorities. svn:r12759	2007-12-11 20:18:12 +00:00
Roger Dingledine	52363d23d7	If we can't expand our list of entry guards (e.g. because we're using bridges or we have StrictEntryNodes set), don't mark relays down when they fail a directory request. Otherwise we're too quick to mark all our entry points down. svn:r12755	2007-12-10 17:16:41 +00:00
Roger Dingledine	ee6ae92670	New config options AuthDirBadDir and AuthDirListBadDirs for authorities to mark certain relays as "bad directories" in the networkstatus documents. Also supports the "!baddir" directive in the approved-routers file. svn:r12754	2007-12-10 16:49:54 +00:00
Roger Dingledine	d95e7c7d67	also clear the hsdir status flag in routerinfo_t when the relay is no longer listed in the relevant networkstatus document. svn:r12752	2007-12-10 16:40:14 +00:00
Roger Dingledine	25a444b698	emo teh svn:r12747	2007-12-09 19:11:22 +00:00
Roger Dingledine	be337eb0ad	fix a memory leak in authority_certs_fetch_missing() every time we try to call it but don't have enough dir info. svn:r12743	2007-12-09 17:43:43 +00:00
Roger Dingledine	6dfd47467e	Allow multiple HashedControlPassword config lines, to support multiple controller passwords. svn:r12732	2007-12-09 04:59:27 +00:00
Roger Dingledine	9b162ef430	only clear the bridge list if options->Bridges is set. this doesn't matter yet so we aren't adding them in other ways yet. svn:r12730	2007-12-09 03:38:57 +00:00
Roger Dingledine	ae1aa5a1bb	Set up lefkada (run by Geoff Goodell) as the fourth v3 directory authority. svn:r12724	2007-12-08 20:16:34 +00:00
Roger Dingledine	2b8ca7b4a4	patch from karsten to clean up documentation and to integrate more fixes into rend-spec.txt. svn:r12715	2007-12-07 21:27:58 +00:00
Nick Mathewson	2e378295d6	r16997@catbus: nickm \| 2007-12-06 18:56:33 -0500 Make http://torproject urls into https://torproject urls. Patch from steve. svn:r12708	2007-12-06 23:56:36 +00:00
Nick Mathewson	92372b156a	r16995@catbus: nickm \| 2007-12-06 18:42:53 -0500 patch from steve: replace more tor.eff.org instances with torproject.org svn:r12707	2007-12-06 23:42:59 +00:00
Roger Dingledine	75c38a2c88	Bridges now behave like clients with respect to time intervals for downloading new consensus documents. Bridge users now wait until the end of the interval, so their bridge will be sure to have a new consensus document. svn:r12696	2007-12-06 17:01:16 +00:00
Roger Dingledine	b277954501	put a note so the distant future developers can simplify tor svn:r12691	2007-12-06 11:19:00 +00:00
Roger Dingledine	a107a1624b	extra points if it compiles svn:r12688	2007-12-06 07:17:05 +00:00
Roger Dingledine	8de470cf69	Add "GETINFO/desc-annotations/id/<OR digest>" so controllers can ask about source, timestamp of arrival, purpose, etc. We need something like this to help Vidalia not do GeoIP lookups on bridge addresses. svn:r12687	2007-12-06 07:15:06 +00:00
Roger Dingledine	3ff63b6f4e	When the DANGEROUS_VERSION controller status event told us we're running an obsolete version, it used the string "OLD" to describe it. Yet the "getinfo" interface used the string "OBSOLETE". Now use "OBSOLETE" in both cases. svn:r12686	2007-12-05 19:32:58 +00:00
Roger Dingledine	343242d9ae	update an XXX020 for nick later svn:r12684	2007-12-05 19:23:03 +00:00
Nick Mathewson	29045d21b3	r15155@tombo: nickm \| 2007-12-05 11:11:14 -0500 Add a missing "not" to check of whether to use revised handshake. svn:r12678	2007-12-05 16:11:33 +00:00
Roger Dingledine	d46b8a3eac	Stop being so aggressive about fetching dir info if your DirPort is on but your ORPort is off. Add a new config option BridgeRelay that specifies you want to be a bridge relay. Right now the only difference is that it makes you answer begin_dir requests, and it makes you cache dir info, even if your DirPort isn't on. Refactor directory_caches_dir_info() into some more functions. svn:r12668	2007-12-04 18:35:03 +00:00
Roger Dingledine	0000c7e6e9	weasel wanted us to log the source of v3 votes we don't like svn:r12665	2007-12-04 15:54:14 +00:00
Nick Mathewson	593ab7e808	r15106@tombo: nickm \| 2007-12-04 00:08:35 -0500 Change tor_addr_t to be a tagged union of in_addr and in6_addr, not of sockaddr_in and sockaddr_in6. It's hardly used in the main code as it is, but let's get it right before it gets popular. svn:r12660	2007-12-04 05:19:56 +00:00
Roger Dingledine	ce2cf88ebf	Stop thinking that 0.1.2.x directory servers can handle "begin_dir" requests. Should ease bugs 406 and 419 where 0.1.2.x relays are crashing or mis-answering these requests. svn:r12658	2007-12-03 22:31:59 +00:00
Roger Dingledine	3229117d3a	minor touchups svn:r12657	2007-12-03 22:04:19 +00:00
Roger Dingledine	07dbaaac16	We were ignoring our RelayBandwidthRate for the first 30 seconds after opening a circuit -- even relayed circuits. Bugfix on 0.2.0.3-alpha. svn:r12638	2007-12-02 11:24:06 +00:00
Roger Dingledine	b54240d38f	Reject uploaded descriptors and extrainfo documents if they're huge. Otherwise we'll cache them all over the network and it'll clog everything up. svn:r12633	2007-12-02 06:11:53 +00:00
Roger Dingledine	1a254477fc	minor cleanups svn:r12631	2007-12-02 04:39:56 +00:00
Roger Dingledine	f901cd064c	clean up the dirserv_add_multiple_descriptors() api svn:r12630	2007-12-02 02:47:42 +00:00
Roger Dingledine	9b1b8199df	backport candidate: Start purging old entries from the "rephist" database, and the hidden service descriptor databases, even when DirPort is zero. svn:r12628	2007-12-01 22:38:58 +00:00
Roger Dingledine	77e607cc0d	Authorities and caches fetch the v2 networkstatus documents less often, now that v3 is encouraged. svn:r12627	2007-12-01 20:04:36 +00:00
Roger Dingledine	c26c54836f	download the (admittedly tiny) v1 dir blobs even less often. we can't make them totally obsolete yet but we can get closer. svn:r12626	2007-12-01 20:02:05 +00:00
Nick Mathewson	4a6d969139	r15094@tombo: nickm \| 2007-12-01 03:46:07 -0500 server-side code (for when v2 negotiation occurred) to check for renegotiation and adjust client ID info accordingly. server-side of new TLS code is now implemented, but needs testing and debugging. svn:r12624	2007-12-01 08:47:13 +00:00
Nick Mathewson	d8ad247dfd	r15088@tombo: nickm \| 2007-11-30 23:47:29 -0500 Add support to get a callback invoked when the client renegotiate a connection. Also, make clients renegotiate. (not enabled yet, until they detect that the server acted like a v2 server) svn:r12623	2007-12-01 08:09:48 +00:00
Nick Mathewson	1789f94668	r15087@tombo: nickm \| 2007-11-30 22:32:26 -0500 Start getting freaky with openssl callbacks in tortls.c: detect client ciphers, and if the list doesn't look like the list current Tors use, present only a single cert do not ask for a client cert. Also, support for client-side renegotiation. None of this is enabled unless you define V2_HANDSHAKE_SERVER. svn:r12622	2007-12-01 08:09:46 +00:00
Roger Dingledine	f8df8d791e	start to refactor dirserver_mode() svn:r12621	2007-12-01 04:58:53 +00:00
Roger Dingledine	6d49465b69	fix two trivial potential onionkey leaks. neither of these should happen in practice. but now they really won't. svn:r12620	2007-12-01 04:40:12 +00:00
Roger Dingledine	c1b4bfdeac	karsten's bugfix on r12607 svn:r12619	2007-11-30 23:45:16 +00:00
Roger Dingledine	30e1a862e7	r12617 broke the compile svn:r12618	2007-11-30 23:32:25 +00:00
Nick Mathewson	f061994487	r16881@catbus: nickm \| 2007-11-30 15:07:42 -0500 Do not keep a string representation of every single addr_policy_t lying around. This might save a few hundred K. svn:r12617	2007-11-30 20:09:09 +00:00
Roger Dingledine	ad0fcef576	other trivial tweaks svn:r12614	2007-11-30 18:53:14 +00:00
Roger Dingledine	fea55c7c2d	two pieces of r12607 for karsten to look at closer svn:r12609	2007-11-29 15:37:17 +00:00
Roger Dingledine	8ac5f24c33	easy tweaks on r12607 svn:r12608	2007-11-29 15:30:32 +00:00
Roger Dingledine	aaf35cccf7	karsten's second refactoring patch svn:r12607	2007-11-29 15:25:04 +00:00
Roger Dingledine	0f22c584cd	doxygen tweaks svn:r12606	2007-11-29 15:23:41 +00:00
Roger Dingledine	7f12ebc3fa	cleanups on r12579 svn:r12580	2007-11-27 21:17:43 +00:00
Roger Dingledine	466abecef4	Our new v2 hidden service descriptor format allows descriptors that have no introduction points. But Tor crashed when we tried to build a descriptor with no intro points (and it would have crashed if we had tried to parse one). Bugfix on 0.2.0.x; patch by Karsten Loesing. svn:r12579	2007-11-27 21:06:34 +00:00
Roger Dingledine	b02e154470	minor cleanups svn:r12571	2007-11-26 06:26:17 +00:00
Roger Dingledine	91bb09cb28	Only update guard status (usable / not usable) once we have enough directory information. This was causing us to always pick two new guards on startup (bugfix on 0.2.0.9-alpha), and it was causing us to discard all our guards on startup if we hadn't been running for a few weeks (bugfix on 0.1.2.x). Fixes bug 448. svn:r12570	2007-11-26 02:18:57 +00:00
Roger Dingledine	2e40510f02	if we think our ip address just changed, log what we thought it changed to. svn:r12551	2007-11-22 01:38:54 +00:00
Roger Dingledine	aaefad64a1	stop lying in the config file comment we write out regarding PublishServerDescriptor. svn:r12550	2007-11-22 00:44:08 +00:00
Roger Dingledine	a54ce34e35	Don't crash if we get an unexpected value for the PublishServerDescriptor config option. Reported by Matt Edman; bugfix on 0.2.0.9-alpha. svn:r12549	2007-11-22 00:43:22 +00:00
Roger Dingledine	094096d320	get rid of the __ConsiderAllRoutersAsHidServDirectories config option svn:r12528	2007-11-17 12:28:18 +00:00
Roger Dingledine	d62ef13d0a	get rid of the separate reachability window for the hsdir flag. svn:r12527	2007-11-17 12:15:32 +00:00
Roger Dingledine	b701583ffa	note a log message that might want to get quieter svn:r12526	2007-11-17 12:11:00 +00:00
Roger Dingledine	c336dedd21	The fix in 0.2.0.12-alpha cleared the "hsdir" flag in v3 network consensus documents when there are too many relays at a single IP address. Now clear it in v2 network status documents too. svn:r12522	2007-11-17 07:00:14 +00:00
Roger Dingledine	6514843026	cleanups, bump to 0.2.0.12-alpha svn:r12516	2007-11-17 02:22:56 +00:00
Roger Dingledine	d6f8ba25c9	back out r12509 and fix a better bug instead: When authorities detected more than two relays running on the same IP address, they were clearing all the status flags but forgetting to clear the "hsdir" flag. So clients were being told that a given relay was the right choice for a v2 hsdir lookup, yet they never had its descriptor because it was marked as 'not running' in the consensus. svn:r12515	2007-11-17 01:53:33 +00:00
Roger Dingledine	d09439872d	If we're using bridges or have strictentrynodes set, and our chosen exit is in the same family as all our bridges/entry guards, then be flexible about families. svn:r12514	2007-11-16 07:37:49 +00:00
Roger Dingledine	b669fb7344	i'm a little teapot, ... svn:r12513	2007-11-16 07:33:57 +00:00
Roger Dingledine	0871e02da8	If we're trying to fetch a bridge descriptor and there's no way the bridge authority could help us (for example, we don't know a digest, or there is no bridge authority), don't be so eager to fall back to asking the bridge authority. svn:r12512	2007-11-16 07:31:51 +00:00
Roger Dingledine	116a0f0f22	minor touchups on or.h svn:r12511	2007-11-16 07:29:01 +00:00
Roger Dingledine	0e442e098c	Nov 16 02:20:50.089 [info] update_consensus_router_descriptor_downloads(): 0 router descriptors downloadable. 0 delayed; 1676 present (0 of those were in old_routers); 0 would_reject; 582 wouldnt_use, 0 in progress. Nov 16 02:20:50.089 [info] launch_router_descriptor_downloads(): There are not many downloadable routerdescs, but we haven't tried downloading descriptors recently. Downloading. Get rid of the second line. svn:r12510	2007-11-16 07:23:25 +00:00
Roger Dingledine	60ee26c873	Karsten: you should look at this and decide if we should skip over non-running hsdirs, or not give them the flag if they're not running, or what. When picking v2 hidden service directories, don't pick ones that aren't listed as Running. svn:r12509	2007-11-16 05:29:27 +00:00
Peter Palfrader	3e9369ebd9	Changing the ExitPolicyRejectPrivate setting should cause us to rebuild the descriptor. svn:r12507	2007-11-15 15:51:17 +00:00
Roger Dingledine	06a1e4124f	Fix a small memory leak whenever we decide against using a newly picked entry guard. Reported by Mike Perry. svn:r12506	2007-11-15 11:14:08 +00:00
Nick Mathewson	e843e05563	r16670@catbus: nickm \| 2007-11-14 14:56:30 -0500 Initial phase of proposal 110: accept RELAY_EARLY cells, and turn them into RELAY cells when sending them on over a v1 OR connection. svn:r12496	2007-11-14 20:01:15 +00:00
Nick Mathewson	d483d3144a	r16669@catbus: nickm \| 2007-11-14 14:50:03 -0500 When we complete an OR handshake, set up all the internal fields and mark the connection as open. svn:r12495	2007-11-14 20:01:12 +00:00
Nick Mathewson	bbb34846b4	r16665@catbus: nickm \| 2007-11-14 13:36:11 -0500 Fix bug spotted by karsten: when we have no consensus, do not try to continue finding directories for a hidden service. svn:r12493	2007-11-14 18:39:15 +00:00
Nick Mathewson	75922ff41f	r16663@catbus: nickm \| 2007-11-13 21:51:28 -0500 Back out parts of r12376: replace file locations in scripts. svn:r12490	2007-11-14 02:55:12 +00:00
Roger Dingledine	c23a22785d	make r12485 more likely to work on tonga too svn:r12486	2007-11-12 19:01:28 +00:00
Nick Mathewson	f7c2d1522e	r16656@catbus: nickm \| 2007-11-12 11:27:00 -0500 Possibly fix bug 548 by making the fix for bug 543 not get invoked on authorities. See changelog and bug 548 entry for rationale. svn:r12485	2007-11-12 16:29:31 +00:00
Nick Mathewson	6deca312a7	r16654@catbus: nickm \| 2007-11-12 10:43:45 -0500 Add explanatory comment. Does not fix bug 548. svn:r12484	2007-11-12 15:46:38 +00:00
Roger Dingledine	609ceadd74	compiling is good too svn:r12480	2007-11-11 18:46:16 +00:00
Roger Dingledine	7870964e0c	Don't reevaluate all the information from our consensus document just because we've downloaded a v2 networkstatus that we intend to cache. Fixes bug 545. svn:r12479	2007-11-11 17:37:59 +00:00
Roger Dingledine	49e9c6d96b	tweak svn:r12478	2007-11-11 17:20:30 +00:00
Roger Dingledine	1b00492c40	a potential solution for bug 549 svn:r12471	2007-11-11 04:36:31 +00:00
Roger Dingledine	0d21995956	another likelier candidate for mike's leak svn:r12470	2007-11-11 04:19:11 +00:00
Roger Dingledine	2b2d111017	a log entry to help us find mike's memory leak svn:r12469	2007-11-11 03:56:34 +00:00
Roger Dingledine	8ca51869fd	Allow people to say PreferTunnelledDirConns rather than PreferTunneledDirConns, for those alternate-spellers out there. svn:r12466	2007-11-11 01:06:16 +00:00
Roger Dingledine	42b8fb5a15	Exit policies now reject connections that are addressed to a relay's public (external) IP address too, unless ExitPolicyRejectPrivate is turned off. We do this because too many relays are running nearby to services that trust them based on network address. svn:r12459	2007-11-10 21:17:51 +00:00
Roger Dingledine	7050df7245	bump to 0.2.0.10-alpha svn:r12455	2007-11-10 07:26:56 +00:00
Nick Mathewson	1bdbd3b98e	r16582@catbus: nickm \| 2007-11-08 13:14:16 -0500 Try to bulletproof the parse logic for router-stability. svn:r12441	2007-11-08 18:15:49 +00:00
Nick Mathewson	e0b9c893bc	r16573@catbus: nickm \| 2007-11-08 11:57:16 -0500 Mess with the formula for the Guard flag again. Now it requires that you be in the most familiar 7/8 of nodes, and have above median wfu for that 7/8th. See spec for details. Also, log thresholds better. svn:r12440	2007-11-08 16:58:59 +00:00
Nick Mathewson	c3a745951b	r16570@catbus: nickm \| 2007-11-08 11:04:20 -0500 Keep track, for each OR connection, of the last time we added a non-padding cell to its outbuf. Use this timestamp, not "lastwritten" to tell if it is time to close a circuitless connection. (We can'tuse lastwritten, since lastwritten is updated when ever the connection flushes anything, and by that point we can no longer tell what is a padding cell and what is not.) svn:r12437	2007-11-08 16:19:07 +00:00
Nick Mathewson	17a34e4a43	r16569@catbus: nickm \| 2007-11-08 10:51:11 -0500 More log messages about certificate downloads; try to track down bug 546.2 svn:r12436	2007-11-08 16:19:04 +00:00
Roger Dingledine	1d61b54227	make the complaints about missing v2hidserv directories quieter, at least until we're supposed to have any of them. svn:r12431	2007-11-08 04:21:35 +00:00
Roger Dingledine	e12cf29960	Don't stop fetching descriptors when FetchUselessDescriptors is set, even if we stop asking for circuits. Bugfix on 0.1.2.x; reported by tup and ioerror. svn:r12430	2007-11-08 04:19:51 +00:00
Nick Mathewson	d279fb82e2	r16550@catbus: nickm \| 2007-11-07 16:50:02 -0500 "And $499 for knowing where to hit it." Fix bug 546. svn:r12425	2007-11-07 21:51:21 +00:00
Roger Dingledine	473a054b4c	Set up ides (run by Mike Perry) as the third v3 directory authority. svn:r12423	2007-11-07 21:20:45 +00:00
Roger Dingledine	1621b1e09b	start hunting a bug where bridge users don't always put their un-keyed connections onto the orconn_identity_map. svn:r12418	2007-11-07 18:26:46 +00:00
Nick Mathewson	f18e94116b	r16533@catbus: nickm \| 2007-11-07 12:42:58 -0500 Fix another "TLS error. breaking connection".~ svn:r12416	2007-11-07 17:44:15 +00:00
Nick Mathewson	45b0ee42a3	r16531@catbus: nickm \| 2007-11-07 12:39:56 -0500 Initialize re-parsed routerinfos with routerlist_index -1, since they are not yet inserted into the routerlist. Fixes another crash. svn:r12415	2007-11-07 17:41:14 +00:00
Nick Mathewson	dc2ab2f4e2	r16529@catbus: nickm \| 2007-11-07 12:28:52 -0500 And make it compile too. svn:r12414	2007-11-07 17:30:08 +00:00
Nick Mathewson	9b2d86d83d	r16527@catbus: nickm \| 2007-11-07 12:27:59 -0500 Re-set all of the indices immediately after sorting old_routers. Fixes a crash. svn:r12413	2007-11-07 17:29:16 +00:00
Nick Mathewson	bed01a9003	r16525@catbus: nickm \| 2007-11-07 12:10:01 -0500 Clean up log messages from bug 543 fix, and make old_routers also keep track of their indices. This will probably crash some until all the bugs are fixed. svn:r12412	2007-11-07 17:11:23 +00:00
Nick Mathewson	0e993e6008	r16523@catbus: nickm \| 2007-11-07 11:35:49 -0500 Improve "tls error. breaking" message a little. svn:r12411	2007-11-07 16:37:08 +00:00
Nick Mathewson	381619a973	Fix typo. svn:r12409	2007-11-07 15:22:46 +00:00
Nick Mathewson	acaa9a7f69	r16518@catbus: nickm \| 2007-11-07 10:18:31 -0500 First attempt at fixing bug 543. Needs testing. Too slow. svn:r12408	2007-11-07 15:19:53 +00:00
Nick Mathewson	bc4cefcd7e	r16471@catbus: nickm \| 2007-11-06 15:50:42 -0500 Detect whether any of the descriptors we want are in old_routers. Possibly useful in tracking down bug 543. svn:r12404	2007-11-06 20:51:45 +00:00
Nick Mathewson	47fd6f7267	r16464@catbus: nickm \| 2007-11-06 14:53:28 -0500 Also avoid overflow on or_conn->read_bucket svn:r12401	2007-11-06 19:54:32 +00:00
Nick Mathewson	be1a5191f8	r16462@catbus: nickm \| 2007-11-06 14:40:58 -0500 Fix bug 544: do not allow buckets to overflow. Backportable. svn:r12400	2007-11-06 19:42:37 +00:00
Nick Mathewson	28dd56f982	r16459@catbus: nickm \| 2007-11-06 13:26:11 -0500 Fix "0 request for 0 router" message. svn:r12399	2007-11-06 18:27:14 +00:00
Nick Mathewson	6bc071f765	r16456@catbus: nickm \| 2007-11-06 12:59:04 -0500 Fix a dumb bug in networkstatus_free_all() svn:r12397	2007-11-06 18:00:09 +00:00
Nick Mathewson	e047f7f865	r16455@catbus: nickm \| 2007-11-06 12:48:00 -0500 Parse CERT cells and act correctly when we get them. svn:r12396	2007-11-06 18:00:07 +00:00
Nick Mathewson	af60d79f5d	r16452@catbus: nickm \| 2007-11-06 09:20:08 -0500 Fix warning about overflow optimization. svn:r12395	2007-11-06 14:21:08 +00:00
Nick Mathewson	95c7b8cc64	r14729@31-33-67: nickm \| 2007-11-05 18:54:50 -0500 Send and Parse CERT cells correctly. Still need to understand the certs inside. svn:r12392	2007-11-05 23:55:43 +00:00
Nick Mathewson	6fcda5299f	r14727@31-33-67: nickm \| 2007-11-05 18:34:35 -0500 Make VERSIONS variable-length. svn:r12391	2007-11-05 23:34:39 +00:00
Nick Mathewson	9a20a64b62	r16438@catbus: nickm \| 2007-11-05 16:45:45 -0500 Initial code for variable-length cells. CERT and VERSIONS need to use them. svn:r12390	2007-11-05 21:46:35 +00:00
Nick Mathewson	42f7ae3eae	r16435@catbus: nickm \| 2007-11-05 14:23:07 -0500 Patch from karsten: tidy up v2 hidden service directory logic, and fix a few bugs. svn:r12388	2007-11-05 19:23:57 +00:00
Nick Mathewson	dec5fcd611	r16434@catbus: nickm \| 2007-11-05 14:22:40 -0500 Oops; fix compile svn:r12387	2007-11-05 19:23:55 +00:00
Nick Mathewson	85654f4ab9	r16432@catbus: nickm \| 2007-11-05 14:18:57 -0500 Send and parse link_auth cells properly. svn:r12386	2007-11-05 19:19:46 +00:00
Nick Mathewson	44eab517fc	r16414@catbus: nickm \| 2007-11-05 13:14:46 -0500 Function to process link auth cells; stub function for cert cell processing svn:r12385	2007-11-05 18:15:56 +00:00
Nick Mathewson	ea1bea5830	r16411@catbus: nickm \| 2007-11-05 11:27:37 -0500 Remember X509 certificates in the context. Store peer/self certificate digests in handshake state. svn:r12382	2007-11-05 18:15:50 +00:00
Nick Mathewson	22c31d91ab	r16410@catbus: nickm \| 2007-11-05 10:54:29 -0500 Code to remember client_random and server_random values, and to compute hmac using TLS master secret. svn:r12381	2007-11-05 18:15:47 +00:00
Nick Mathewson	e94fad36ac	r16409@catbus: nickm \| 2007-11-05 10:38:25 -0500 Split handshake state into its own structure. Revise versions and netinfo code to use this structure. svn:r12380	2007-11-05 18:15:44 +00:00
Nick Mathewson	b4a50343d7	r16407@catbus: nickm \| 2007-11-05 10:02:22 -0500 Add a log message when we start retrieving networkstatus svn:r12378	2007-11-05 18:15:39 +00:00
Nick Mathewson	446c351393	r14702@tombo: nickm \| 2007-11-04 15:48:56 -0500 Define SHARE_DATADIR, LOCALSTATEDIR, and BINDIR in Makefile.am as autoconf recommends. Do not move CONFDIR yet, since we seem to support overriding it in a weird way. Resolves bug 542. svn:r12376	2007-11-04 20:49:02 +00:00
Roger Dingledine	735498cb27	add the other v3 dir bugfixes. my bridge is now working again even when my datadir starts empty. phew. svn:r12372	2007-11-04 02:36:09 +00:00
Nick Mathewson	928c584ec2	r14700@tombo: nickm \| 2007-11-03 22:29:21 -0400 Fix sign error in networkstatus_note_certs_arrived(). svn:r12371	2007-11-04 02:29:27 +00:00
Roger Dingledine	5bf61633e3	avoid sending a request for "keys/fp" (for which we'll get a 400 bad request) if we need more v3 certs but we've already got pending requests for all of them. svn:r12370	2007-11-04 02:06:09 +00:00
Roger Dingledine	9ef72079ae	fix an assert error on startup if we didn't already have the consensus and certs cached in our datadirectory: we were caching the consensus in consensus_waiting_for_certs but then free'ing it right after. more bugs remain here, i think. svn:r12369	2007-11-04 01:26:00 +00:00
Roger Dingledine	e9af56cf2f	If bridge users set UpdateBridgesFromAuthority, but the digest they ask for is a 404 from the bridge authority, they now fall back to trying the bridge directly. svn:r12368	2007-11-04 00:15:42 +00:00
Roger Dingledine	fb7b680a04	always use begin_dir for publishing and fetching bridge descriptors, no matter our config svn:r12365	2007-11-03 22:34:31 +00:00
Roger Dingledine	fcc115e763	Raise the default BandwidthRate/BandwidthBurst to 5MB/10MB, to accommodate the growing number of servers that use the default and are reaching it. svn:r12364	2007-11-03 22:08:52 +00:00
Nick Mathewson	bf2717ff3d	r14678@tombo: nickm \| 2007-11-03 16:12:31 -0400 Try to make hidden service directory lookup functions a bit more efficient: go for fewer O(n) operations, and look at the consensus rather than the routerinfo list. svn:r12361	2007-11-03 20:12:41 +00:00
Nick Mathewson	c217be996d	r14677@tombo: nickm \| 2007-11-03 15:16:27 -0400 Add a smartlist_bsearch_idx function that gives more useful output than regular bsearch for the value-not-found case. svn:r12360	2007-11-03 20:12:38 +00:00
Roger Dingledine	d4e339ed87	Nov 03 11:15:13.103 [info] connection_dir_client_reached_eof(): Received consensus directory (size 330543) from server '86.59.21.38:80' Nov 03 11:15:13.129 [info] networkstatus_set_current_consensus(): Got a consensus we already have Nov 03 11:15:13.129 [warn] Unable to load consensus directory dowloaded from server '86.59.21.38:80' svn:r12359	2007-11-03 15:55:15 +00:00
Roger Dingledine	23fdfd4dcf	Stop leaking conn->nickname every time we make a connection to a Tor relay without knowing its expected identity digest (e.g. when using bridges). Bugfix on 0.2.0.3-alpha. svn:r12355	2007-11-03 14:44:53 +00:00
Nick Mathewson	3a6287615b	r16367@catbus: nickm \| 2007-11-02 13:13:15 -0400 Space fixes. svn:r12345	2007-11-02 17:16:34 +00:00
Nick Mathewson	6aeca5237d	r14631@tombo: nickm \| 2007-11-02 00:18:17 -0400 Better log messages for "not enough to build a circuit" message. svn:r12324	2007-11-02 04:18:28 +00:00
Nick Mathewson	832ef9562f	r14623@tombo: nickm \| 2007-11-01 22:25:18 -0400 More tweaks from karsten, with some cleanup and commentary. svn:r12319	2007-11-02 02:25:28 +00:00
Nick Mathewson	e3cb1e4559	r16337@catbus: nickm \| 2007-11-01 14:18:58 -0400 Remove superseded assert in directory.c svn:r12317	2007-11-01 18:22:04 +00:00
Roger Dingledine	e5ec8248e8	make r12272 compile on 64-bit svn:r12315	2007-11-01 13:48:12 +00:00
Roger Dingledine	4ead38a4e9	fix compile errors on r12310 (thanks karsten) svn:r12314	2007-11-01 13:40:29 +00:00
Nick Mathewson	37c44b81df	r16326@catbus: nickm \| 2007-11-01 00:56:45 -0400 As an authority, send back an X-Descriptor-Not-New header when we accept but do not store a descriptor. Partial implementation of fix for bug 535. svn:r12310	2007-11-01 05:01:24 +00:00
Nick Mathewson	2645219b4c	r16322@catbus: nickm \| 2007-11-01 00:26:15 -0400 Implement --quiet. svn:r12306	2007-11-01 04:38:43 +00:00
Nick Mathewson	401b5c26de	r16320@catbus: nickm \| 2007-11-01 00:11:20 -0400 Learn new addresses for authorities from their certificates. svn:r12305	2007-11-01 04:14:23 +00:00
Nick Mathewson	d1df046e3b	r16314@catbus: nickm \| 2007-10-31 23:40:08 -0400 Clients download and cache new hidden descriptor format. svn:r12302	2007-11-01 03:43:02 +00:00
Nick Mathewson	5da5d2bd79	r16302@catbus: nickm \| 2007-10-31 16:45:16 -0400 Clean spaces. svn:r12301	2007-10-31 20:48:10 +00:00
Nick Mathewson	fcd42ebef4	r16301@catbus: nickm \| 2007-10-31 16:43:49 -0400 A couple of small tweaks to karsten's latest patch, and note an issue with using a bitmap to represent a single int. svn:r12300	2007-10-31 20:48:08 +00:00
Nick Mathewson	779b615bc2	r16300@catbus: nickm \| 2007-10-31 15:36:41 -0400 Next patch from Karsten: rename some macros, tunnel dir connections, generate (and upload) multiple descriptors as appropriate. svn:r12299	2007-10-31 20:48:06 +00:00
Nick Mathewson	17266cc44a	r16287@catbus: nickm \| 2007-10-31 00:53:53 -0400 HMAC-SHA-1 implementation, with unit tests based on vectors from RVFC2202. Steven's stuff will need this. svn:r12289	2007-10-31 04:56:59 +00:00
Nick Mathewson	7e80640b97	r16285@catbus: nickm \| 2007-10-30 17:43:25 -0400 Implement (but do not enable) link connection version negotiation svn:r12286	2007-10-30 21:46:02 +00:00
Nick Mathewson	57f7c852f8	r16282@catbus: nickm \| 2007-10-30 14:28:58 -0400 Implement lots of proposal 105. None of it is enabled yet. svn:r12285	2007-10-30 18:31:30 +00:00
Nick Mathewson	c0c2001a5b	r16279@catbus: nickm \| 2007-10-30 11:14:29 -0400 Improved skew reporting: "You are 365 days in the duture" is more useful than "You are 525600 minutes in the future". Also, when we get something that proves we are at least an hour in the past, tell the controller "CLOCK_SKEW MIN_SKEW=-3600" rather than just "CLOCK_SKEW" svn:r12283	2007-10-30 15:17:07 +00:00
Nick Mathewson	7709fb7143	r16278@catbus: nickm \| 2007-10-30 09:46:28 -0400 Accept future networkstatus documents, but warn about skew when we get them. svn:r12282	2007-10-30 15:17:01 +00:00
Nick Mathewson	024798ee4c	r16263@catbus: nickm \| 2007-10-29 15:08:17 -0400 Tidy last patch a bit. svn:r12273	2007-10-29 19:10:47 +00:00
Nick Mathewson	e136f00ca8	r16262@catbus: nickm \| 2007-10-29 13:21:35 -0400 Patch from Karsten: Code to act as (and use) v2 hidden service directories. svn:r12272	2007-10-29 19:10:42 +00:00
Nick Mathewson	1c451b9db9	r16252@catbus: nickm \| 2007-10-29 11:13:03 -0400 Change symbol from DATADIR to SHARE_DATADIR, since DATADIR conflicts with objidl.h in mingw. svn:r12268	2007-10-29 15:15:49 +00:00
Nick Mathewson	30e73f3a5e	r16248@catbus: nickm \| 2007-10-28 19:42:14 -0400 Do not count a server as having any WFU until we have known about it for 18 hours (weighted). svn:r12261	2007-10-28 23:44:57 +00:00
Nick Mathewson	f09d53bbf1	r16246@catbus: nickm \| 2007-10-28 19:34:58 -0400 Implement a FallbackNetworkstatusFile (default to $prefix/share/tor/fallback-consensus) to that we know about lots of directory servers and routers when we start up the first time. svn:r12259	2007-10-28 23:44:53 +00:00
Nick Mathewson	20b1085989	r16242@catbus: nickm \| 2007-10-28 16:28:13 -0400 Implement if-modified-since for consensus networkstatuses so that we do not download duplicates needlessly. svn:r12258	2007-10-28 20:30:21 +00:00
Peter Palfrader	471163ffd5	Downgrade the mismatched fpr warning to info svn:r12257	2007-10-28 20:01:22 +00:00
Nick Mathewson	66a39ac358	r16238@catbus: nickm \| 2007-10-28 15:46:10 -0400 Whitespace fix. svn:r12256	2007-10-28 19:48:19 +00:00
Nick Mathewson	d94a978b32	r16237@catbus: nickm \| 2007-10-28 15:45:25 -0400 Tidy v2 hidden service descriptor format code: fix memory leaks, fix reference problems, note magic numbers, note questions, remove redundant checks, remove a possible stack smashing bug when encoding a descriptor with no protocols supported. svn:r12255	2007-10-28 19:48:16 +00:00
Nick Mathewson	c58675ca72	r16236@catbus: nickm \| 2007-10-28 14:36:30 -0400 Patch from Karsten Loesing: encode and parse v2 rendezvous descriptors. svn:r12254	2007-10-28 19:48:14 +00:00
Nick Mathewson	665aa7659c	r16234@catbus: nickm \| 2007-10-28 14:27:22 -0400 Clean up a couple of comments from r12244. svn:r12253	2007-10-28 18:29:29 +00:00
Roger Dingledine	e5885deab5	Separate "SOCKS_COMMAND_CONNECT_DIR" into two flags in edge_connection_t: want_onehop if it must attach to a circuit with only one hop (e.g. for the current tunnelled connections that use begin_dir), and use_begindir if we mean to use a BEGIN_DIR relay command to establish the stream rather than the normal BEGIN. Now we can make anonymized begin_dir connections for (e.g.) more secure hidden service posting and fetching. svn:r12244	2007-10-28 08:16:19 +00:00
Roger Dingledine	6ca7c118ec	we need to send nick to the chalkboard to type 'un' 1000 times: Stop servers from crashing if they set a Family option (or maybe in other situations too). Bugfix on 0.2.0.9-alpha; reported by Fabian Keil. svn:r12235	2007-10-27 21:40:32 +00:00
Roger Dingledine	a92b2083d2	don't warn so loudly when we couldn't load the unverified-consensus file. we can live without it. svn:r12221	2007-10-27 10:40:08 +00:00
Nick Mathewson	8fa7071121	r16195@catbus: nickm \| 2007-10-26 18:48:52 -0400 base "Guard" flag on WFU rather than MTBF. Note an issue in the TODO. Roger: thoughts? svn:r12219	2007-10-26 22:50:42 +00:00
Nick Mathewson	2c1d7cf674	r16194@catbus: nickm \| 2007-10-26 18:37:02 -0400 Keep circuitless TLS connections open for 1.5 x MaxCircuitDirtiness: this ensures that we don't thrash closing and repoening connections to our guards. svn:r12218	2007-10-26 22:50:40 +00:00
Nick Mathewson	2ac37c8b01	r16174@catbus: nickm \| 2007-10-26 10:55:26 -0400 Better log on vote from unknown authority. Make get_by_v3_authority_id retrun only v3 authorities. svn:r12203	2007-10-26 14:57:26 +00:00
Roger Dingledine	4cbaa51aa2	the other half of the question for nick svn:r12196	2007-10-26 01:37:16 +00:00
Roger Dingledine	e4230d100a	ask nick about a possible bug svn:r12193	2007-10-25 20:59:24 +00:00
Nick Mathewson	d5a0eeb57e	r16157@catbus: nickm \| 2007-10-25 10:36:34 -0400 Free v2_network_status_map on exit. svn:r12189	2007-10-25 14:37:49 +00:00
Nick Mathewson	73c1cfe80b	r16154@catbus: nickm \| 2007-10-25 10:29:47 -0400 Fix more memory leaks, with help from dmalloc. svn:r12188	2007-10-25 14:31:15 +00:00
Nick Mathewson	53e6233985	r16153@catbus: nickm \| 2007-10-25 10:21:42 -0400 do not set authority cert bodies twice: fixes memory leak bug 536. svn:r12187	2007-10-25 14:31:13 +00:00
Roger Dingledine	f37185bf0b	Stop leaking memory every time we parse a v3 certificate. Bugfix on 0.2.0.1-alpha. svn:r12185	2007-10-25 13:18:37 +00:00
Roger Dingledine	4ef1c459ba	Refuse to start if both ORPort and UseBridges are set. Bugfix on 0.2.0.x. svn:r12182	2007-10-25 04:40:27 +00:00
Nick Mathewson	0421e14c21	r16130@catbus: nickm \| 2007-10-24 23:28:00 -0400 Fix null-pointer dereference in set_current_consensus. svn:r12174	2007-10-25 03:29:11 +00:00
Roger Dingledine	0491f2a99c	more cleanups svn:r12172	2007-10-25 03:03:52 +00:00
Nick Mathewson	beb73c90ab	r16124@catbus: nickm \| 2007-10-24 22:11:09 -0400 We want to extend the valid_until for "reasonably live", not the valid_after time svn:r12169	2007-10-25 02:12:16 +00:00
Nick Mathewson	93331ebf69	r16115@catbus: nickm \| 2007-10-24 21:52:33 -0400 Tolerate a slightly dead consensus when deciding whether to download descriptors and build circuits. svn:r12167	2007-10-25 01:53:49 +00:00
Nick Mathewson	e0204f2119	r16112@catbus: nickm \| 2007-10-24 15:52:03 -0400 Fix logic for downloading consensuses: make getting an duplicate or not-currently-valid consensus count as a failure. Make running out of time to get certificates count as a failure. Delay while fetching certificates. svn:r12159	2007-10-24 19:53:11 +00:00
Nick Mathewson	9767415dca	r16111@catbus: nickm \| 2007-10-24 15:03:57 -0400 Allow multiple download schedules to exist. At the moment, we use one for consensus, and the other one for everything else. svn:r12158	2007-10-24 19:53:08 +00:00
Nick Mathewson	02e7a83f91	r16108@catbus: nickm \| 2007-10-24 14:41:12 -0400 Refactor the arguments for router_pick_{directory_\|trusteddir}server[_impl] so that they all take the same flags, and so that their flags have names. Fix their documentation too. svn:r12157	2007-10-24 18:42:16 +00:00
Nick Mathewson	5b65103bb9	r16101@catbus: nickm \| 2007-10-24 11:44:40 -0400 Detect mmap failures from empty descriptor files, and only warn if the file was not supposed to be empty. Fixes bug 533 svn:r12154	2007-10-24 15:45:45 +00:00
Roger Dingledine	7a35dad007	Authorities no longer send back "400 you're unreachable please fix it" errors to Tor servers that aren't online all the time. We're supposed to tolerate these servers now. svn:r12136	2007-10-24 03:34:03 +00:00
Roger Dingledine	f43b9638e4	Don't complain that "your server has not managed to confirm that its ports are reachable" if we haven't been able to build any circuits yet. Bug found by spending four hours without a v3 consensus. svn:r12133	2007-10-23 15:44:13 +00:00
Roger Dingledine	cb2b49c9c4	When there's no concensus, we were forming a vote every 30 minutes, but writing the "valid-after" line in our vote based on our configured V3AuthVotingInterval: so unless the intervals matched up, we immediately rejected our own vote because it didn't start at the voting interval that caused us to construct a vote. This caused log entries like: Oct 23 01:16:16.303 [notice] Choosing expected valid-after time as 2007-10-23 05:30:00: consensus_set=0, interval=1800 ... Oct 23 01:20:01.203 [notice] Choosing valid-after time in vote as 2007-10-23 06:00:00: consensus_set=0, interval=3600 Oct 23 01:20:01.290 [warn] Rejecting vote with valid-after time of 2007-10-23 06:00:00; we were expecting 2007-10-23 05:30:00 Oct 23 01:20:01.291 [warn] Couldn't store my own vote! (I told myself, 'Bad valid-after time'.) Nick, you should look at this, as it's your design. :) svn:r12129	2007-10-23 06:38:16 +00:00
Nick Mathewson	03eb85b122	r16057@catbus: nickm \| 2007-10-23 00:08:31 -0400 What the heck is wrong with me that I can not type un? svn:r12128	2007-10-23 04:09:18 +00:00
Nick Mathewson	6f7518c501	r16054@catbus: nickm \| 2007-10-22 20:22:13 -0400 Make authorities start accepting (and advertising their acceptance of) consensus method 2. If all goes well, we'll have a working Unnamed flag. Otherwise, we'll have a fun backtrace. svn:r12113	2007-10-23 00:23:33 +00:00
Nick Mathewson	64b4b5a04e	r16051@catbus: nickm \| 2007-10-22 18:53:53 -0400 fix a dumb bug in r12102. svn:r12111	2007-10-22 22:54:28 +00:00
Nick Mathewson	9ec9266374	r16049@catbus: nickm \| 2007-10-22 15:31:16 -0400 fix trunk compile svn:r12110	2007-10-22 19:31:50 +00:00
Nick Mathewson	246cb2071f	r16047@catbus: nickm \| 2007-10-22 14:00:46 -0400 Resolve some XXX020s in networkstatus.c svn:r12109	2007-10-22 18:21:22 +00:00
Nick Mathewson	4165d53daf	r16045@catbus: nickm \| 2007-10-22 13:35:02 -0400 Oops; fix a typo that would have messed with the Unnamed implementation. svn:r12108	2007-10-22 17:43:07 +00:00
Nick Mathewson	09bce19884	r16042@catbus: nickm \| 2007-10-22 13:30:49 -0400 Move functions into and out of dirvote.c so that it contains all the v3 authority functionality, and no non-authority functionality. svn:r12107	2007-10-22 17:31:26 +00:00
Nick Mathewson	4bab46d5d7	r16041@catbus: nickm \| 2007-10-22 13:02:14 -0400 Reattempt certificate downloads immediately on failure, as appropriate. svn:r12106	2007-10-22 17:31:22 +00:00
Nick Mathewson	25a68907a1	r16035@catbus: nickm \| 2007-10-22 12:31:22 -0400 fix compile svn:r12105	2007-10-22 16:32:10 +00:00
Nick Mathewson	f06ac50d45	r16034@catbus: nickm \| 2007-10-22 12:30:38 -0400 Move an XXX020 to the logical place. svn:r12104	2007-10-22 16:32:08 +00:00
Nick Mathewson	7b80011990	r16033@catbus: nickm \| 2007-10-22 12:26:13 -0400 Download some XXXX020s in dirvote.c and mark some functions that may not belong there. svn:r12103	2007-10-22 16:32:06 +00:00
Nick Mathewson	c47eb2c8d9	r16032@catbus: nickm \| 2007-10-22 11:56:53 -0400 When our directory status or our v3 authority status changes, reschedule operations as appropriate. (Fixes some xxxx020 items) svn:r12102	2007-10-22 16:32:04 +00:00
Nick Mathewson	db05869466	r16031@catbus: nickm \| 2007-10-22 11:45:00 -0400 Remove an unused and unneeded layer of abstraction: we only have one store for routers. (I had thought we might need a second one for annotated routers, but that's silly. svn:r12101	2007-10-22 16:32:01 +00:00
Nick Mathewson	b481036266	r16014@catbus: nickm \| 2007-10-21 20:29:14 -0400 Fix a unit test in test_crypto_base32_decode that would fail one time in 32. svn:r12087	2007-10-22 00:29:39 +00:00
Nick Mathewson	4a8cf7b517	r15995@catbus: nickm \| 2007-10-21 00:40:46 -0400 More fixes for bad behavior when downloading extrainfos: do not download an ei if we lack the key to verify it, and do not download it if we already got it and found (weirdly) that it didn't match the corresponding server descriptor. svn:r12071	2007-10-21 04:41:00 +00:00
Roger Dingledine	b4a28f8b83	Bugfix on r7072, which turned out to basically be a no-op: Respond to INT and TERM SIGNAL commands before we execute the signal, in case the signal shuts us down. We had a patch in 0.1.2.1-alpha that tried to do this by queueing the response on the connection's buffer before shutting down, but that really isn't the same thing. Bug located by Matt Edman. This is a bug in 0.1.2.x too, but there's no way we should backport this fix. Speaking of which, can somebody double-check it? :) svn:r12070	2007-10-21 04:15:28 +00:00
Nick Mathewson	5ada3cc09a	r15991@catbus: nickm \| 2007-10-20 20:08:29 -0400 Fix a nasty bug in DownloadExtraInfo implementation where we would discard, download, discard, download ad infinitum. svn:r12069	2007-10-21 00:08:35 +00:00
Nick Mathewson	dc4e710e27	r15976@catbus: nickm \| 2007-10-20 19:44:47 -0400 Prioritize fetching descriptors and networkstatus docs over fetching more extrainfo docs. svn:r12067	2007-10-20 23:45:07 +00:00
Nick Mathewson	9b5af75835	r15974@catbus: nickm \| 2007-10-19 16:47:27 -0400 When we decode to use consensus method 2 or later, compute Unnamed and Named more or less as described in 122. Don't actually use consensus method 2 yet, so we can be sure we didn't screw up v1.. svn:r12055	2007-10-19 20:48:46 +00:00
Nick Mathewson	5f8f498207	r15968@catbus: nickm \| 2007-10-19 14:39:51 -0400 Implement code to compute which method to use to compute a consensus. Also, fix leak in consensus calculation. svn:r12054	2007-10-19 18:56:30 +00:00
Nick Mathewson	b0a18d1bfa	r15967@catbus: nickm \| 2007-10-19 14:14:47 -0400 Change meaning of "freefn" argument to smartlist_uniq so that we can remove duplicates from a list without freeing them. svn:r12053	2007-10-19 18:56:28 +00:00
Nick Mathewson	6ca4eebb57	r15966@catbus: nickm \| 2007-10-19 13:56:28 -0400 Voting side of proposal 122 svn:r12052	2007-10-19 18:56:26 +00:00
Nick Mathewson	7bb202fd19	r15965@catbus: nickm \| 2007-10-19 13:32:11 -0400 Client-side implementation for proposal 122. svn:r12051	2007-10-19 18:56:24 +00:00
Nick Mathewson	ee2b770dee	r15964@catbus: nickm \| 2007-10-19 12:43:49 -0400 Sort out that need_to_mirror is for routerstatuses in v2 networkstatuses only. svn:r12050	2007-10-19 18:56:21 +00:00
Nick Mathewson	24317c75a9	r15961@catbus: nickm \| 2007-10-19 12:40:15 -0400 Learn the difference between "mismatched vote digest" and "mismatched vote times": the latter is more informative. svn:r12049	2007-10-19 16:41:32 +00:00
Nick Mathewson	53f9fe7dc5	r15960@catbus: nickm \| 2007-10-19 12:30:17 -0400 Make authority_certs_fetch_missing() honor should_delay_dir_fetches() svn:r12048	2007-10-19 16:41:30 +00:00
Nick Mathewson	140ef7d0f8	r15957@catbus: nickm \| 2007-10-19 12:22:18 -0400 Report our IP address in our vote if it turns out that our hostname isn't a fqdn. svn:r12047	2007-10-19 16:28:13 +00:00
Nick Mathewson	106e01db3d	r15956@catbus: nickm \| 2007-10-19 11:18:14 -0400 Encode address in certificates. Also, make it possible to create certs reusing an old key. svn:r12046	2007-10-19 16:28:10 +00:00
Nick Mathewson	29dfdac923	r15939@catbus: nickm \| 2007-10-18 22:14:15 -0400 Remember the valid-until time of the most recent consensus that listed a router, and (if we are a cache) never delete the routerdesc until that conensus is expired. This is way easier than retaining multiple consensuses. (Of course, the info isn't retained across restarts, but that only affects a few caches at a time.) svn:r12041	2007-10-19 02:15:47 +00:00
Peter Palfrader	829801c476	Call routers_update_all_from_networkstatus() from router_reload_consensus_networkstatus() so that we warn about old versions when we startup Tor, not when we fetch the next consensus document svn:r12038	2007-10-19 00:29:16 +00:00
Roger Dingledine	85e746d060	revert a tiny bit of r12035 svn:r12037	2007-10-18 23:18:28 +00:00
Roger Dingledine	0a865bc277	various fixes from reading or-cvs the past few days svn:r12035	2007-10-18 23:14:58 +00:00
Nick Mathewson	5bfb422157	r15934@catbus: nickm \| 2007-10-18 15:32:56 -0400 When we have plenty of directory information, don't try to launch descriptor downloads quite so eagerly. svn:r12033	2007-10-18 19:51:14 +00:00
Nick Mathewson	db2c5132c9	r15919@catbus: nickm \| 2007-10-18 10:57:47 -0400 Add a log message to router_remove_old_routers to try to figure out why peacetime has such a big cache. svn:r12024	2007-10-18 14:58:45 +00:00
Nick Mathewson	5ff0e4ed56	r15917@catbus: nickm \| 2007-10-18 10:50:01 -0400 Better log messages about extrainfo downloads. svn:r12023	2007-10-18 14:50:59 +00:00
Nick Mathewson	192e3d71d4	r15915@catbus: nickm \| 2007-10-18 10:26:44 -0400 Stop incessant notices about when we think the expected valid-after time should be, if we are not an authority. svn:r12022	2007-10-18 14:27:42 +00:00
Nick Mathewson	959c4963b2	r15913@catbus: nickm \| 2007-10-18 10:22:19 -0400 Fix segfault in init_keys() svn:r12021	2007-10-18 14:23:19 +00:00
Nick Mathewson	8f21a0a0b7	r15907@catbus: nickm \| 2007-10-18 10:18:53 -0400 Fix up logic for choosing the time at which to download a consensus: Never attempt it when the current consensus is still the most recent. svn:r12020	2007-10-18 14:19:56 +00:00
Nick Mathewson	c96167a6bd	r15906@catbus: nickm \| 2007-10-18 10:00:08 -0400 Remove the obsolete warned_conflicts field: a v3 consensus cannot conflict with itself. svn:r12019	2007-10-18 14:19:53 +00:00
Nick Mathewson	59b1b08753	r15905@catbus: nickm \| 2007-10-18 09:58:54 -0400 Document some functions while I can still rememberf what they do. Fix up some whitespace. svn:r12018	2007-10-18 14:19:51 +00:00
Nick Mathewson	35abfa1f77	r15899@catbus: nickm \| 2007-10-18 07:49:15 -0400 "if (!router_get_trusted_dirservers())" is a bad test: router_get_trusted_dirservers() always returns a list. Instead, check for whether the list is empty. svn:r12013	2007-10-18 11:50:20 +00:00
Nick Mathewson	54ac72f6b0	r15887@catbus: nickm \| 2007-10-17 17:25:32 -0400 When a networkstatus consensus download fails, do not wait 60 seconds to decide whether to retry. (Also, log the time at which we'll try to replace the current networkstatus.) svn:r12005	2007-10-17 21:26:22 +00:00
Nick Mathewson	088c1fac39	r15886@catbus: nickm \| 2007-10-17 17:21:10 -0400 Treat it as an error when a v3 authority cant load its keys or certificates svn:r12004	2007-10-17 21:26:19 +00:00
Nick Mathewson	e3113502ad	r15882@catbus: nickm \| 2007-10-17 15:23:05 -0400 oprofile was telling me that a fair bit of our time in openssl was spent in base64_decode, so replace base64_decode with an all-at-once fairly optimized implementation. For decoding keys and digests, it seems 3-3.5x faster than calling out to openssl. (Yes, I wrote it from scratch.) svn:r12002	2007-10-17 19:23:56 +00:00
Nick Mathewson	e8bd32b347	r15880@catbus: nickm \| 2007-10-17 14:56:51 -0400 Patch from robert hogan: do not reset trusted dir server list when we get a config option. svn:r12001	2007-10-17 19:23:52 +00:00
Nick Mathewson	f988f93b1a	r15877@catbus: nickm \| 2007-10-17 12:54:56 -0400 Make unverified-consensus get removed when it is accepted or rejected. Make a new get_datadir_fname*() set of functions to eliminate the common code of "get the options, get the datadir, append some stuff". svn:r12000	2007-10-17 16:55:44 +00:00
Nick Mathewson	4088a90d55	r15876@catbus: nickm \| 2007-10-17 12:39:05 -0400 Treat certificates as reason to note directory info as arrived svn:r11999	2007-10-17 16:55:41 +00:00
Nick Mathewson	c23409080e	r15871@catbus: nickm \| 2007-10-16 14:47:00 -0400 Add a debugging info msg to routerlist svn:r11995	2007-10-16 18:47:32 +00:00
Nick Mathewson	9d7eba6ecc	r15868@catbus: nickm \| 2007-10-16 14:18:29 -0400 Remove nearly all calls to routerlist_remove_old(). Backport candidate. svn:r11994	2007-10-16 18:19:02 +00:00
Nick Mathewson	29173560b8	r15862@catbus: nickm \| 2007-10-16 13:19:29 -0400 Correct mismatches between DirServer lines and authority configuration. svn:r11992	2007-10-16 17:22:37 +00:00
Nick Mathewson	0dab1a14a5	r15860@catbus: nickm \| 2007-10-16 13:09:57 -0400 Avoid an infinite loop in networkstatus_reset_download_failures(). svn:r11990	2007-10-16 17:21:03 +00:00
Nick Mathewson	58ecc39141	r15859@catbus: nickm \| 2007-10-16 13:09:28 -0400 Reset the is_named flag only on non-naming directories. svn:r11989	2007-10-16 17:21:01 +00:00
Nick Mathewson	0d26b623ee	r15853@catbus: nickm \| 2007-10-16 11:32:55 -0400 Fix "Error adding vote: OK" message. svn:r11986	2007-10-16 15:34:14 +00:00
Nick Mathewson	c5fb1c19eb	r15849@catbus: nickm \| 2007-10-16 10:24:38 -0400 Correct and additional fix to bug 529. svn:r11985	2007-10-16 14:25:16 +00:00
Nick Mathewson	03ce9d3ee7	r15848@catbus: nickm \| 2007-10-16 10:17:02 -0400 Only drop routers for not appearing in the consensus if their purpose is GENERAL. svn:r11984	2007-10-16 14:25:14 +00:00
Nick Mathewson	9ca2625833	r15847@catbus: nickm \| 2007-10-16 10:15:07 -0400 Fix the simpler bit of bug 529: update routerinfo_t.is_named from the consensus. svn:r11983	2007-10-16 14:25:13 +00:00
Nick Mathewson	f3c7eeb4a0	r15843@catbus: nickm \| 2007-10-16 09:58:49 -0400 Clean up our code to fix a warning under gcc 4.2 svn:r11982	2007-10-16 13:59:37 +00:00
Roger Dingledine	5aa76cdaa8	Correctly check for bad options to the "PublishServerDescriptor" config option. Bugfix on 0.2.0.1-alpha; reported by Matt Edman. svn:r11968	2007-10-16 03:26:39 +00:00
Nick Mathewson	dbdaa610ee	r15814@catbus: nickm \| 2007-10-15 22:15:19 -0400 Fix last patch. svn:r11961	2007-10-16 02:15:41 +00:00
Roger Dingledine	e477a3860a	two ugly hacks to make my tor client start again. nick, these are for you. svn:r11960	2007-10-16 02:06:30 +00:00
Nick Mathewson	9b3957e755	r15809@catbus: nickm \| 2007-10-15 19:44:13 -0400 Do not call the more interesting parts of routers_update_all_from_networkstatus if there is no live networkstatus. svn:r11958	2007-10-15 23:44:32 +00:00
Nick Mathewson	3ad6dc0e2e	r15806@catbus: nickm \| 2007-10-15 19:14:57 -0400 Implement v3 networkstatus client code. Remove v2 networkstatus client code, except as needed for caches to fetch and serve v2 networkstatues and the routers they list. svn:r11957	2007-10-15 23:15:24 +00:00
Nick Mathewson	738d178f77	Make last commit compile svn:r11953	2007-10-15 20:39:58 +00:00
Nick Mathewson	da955df111	Add some debugging logs related to dir vote timing. svn:r11952	2007-10-15 20:37:59 +00:00
Nick Mathewson	516b913d5c	r15793@catbus: nickm \| 2007-10-15 15:50:52 -0400 Do not set "have published consensus" to 1 after we recalculate timing. svn:r11951	2007-10-15 19:51:14 +00:00
Nick Mathewson	7f9e9c816c	r15790@catbus: nickm \| 2007-10-15 11:38:28 -0400 Fix bug 528: fix memory leak in base32_decode(). While there, also make base32_decode() accept upper-case inputs. svn:r11946	2007-10-15 15:38:44 +00:00
Nick Mathewson	161b85d588	r15781@catbus: nickm \| 2007-10-15 10:59:26 -0400 Make discard_old_votes part of the consensus publishing process, so we conform to spec, and so we avoid a weird bugs where publishing sets the consensus, setting the consensus makes us reschedule, and rescheduling makes us delay vote-discarding. svn:r11944	2007-10-15 14:59:48 +00:00
Nick Mathewson	c8ad4f58ee	r15780@catbus: nickm \| 2007-10-15 10:35:16 -0400 Fix the implementation of "download votes by digest". svn:r11943	2007-10-15 14:59:44 +00:00
Nick Mathewson	09dfe31ff4	r15750@catbus: nickm \| 2007-10-13 20:06:47 -0400 Eventually delete the obsolete cached-routers and cached-routers.new files, so they don't sit around on disk forever. svn:r11918	2007-10-14 00:13:06 +00:00
Nick Mathewson	1b45314775	r15749@catbus: nickm \| 2007-10-13 20:06:06 -0400 Remove support for long-obsolete bw_accounting file. svn:r11917	2007-10-14 00:13:04 +00:00
Roger Dingledine	39902e93f7	Stop publishing a new server descriptor just because we HUP or when we find our DirPort to be reachable but won't actually publish it. Extra descriptors without any real changes are dropped by the authorities, and can screw up our "publish every 18 hours" schedule. svn:r11915	2007-10-13 22:31:35 +00:00
Roger Dingledine	d9ba4d3e8b	note a bug in directories_have_accepted_server_descriptor() pointed out by weasel svn:r11914	2007-10-13 22:01:24 +00:00
Roger Dingledine	e269feea77	stop handling 403 responses from directory authorities/mirrors. we haven't issued those in years. svn:r11913	2007-10-13 21:57:02 +00:00
Nick Mathewson	29fc92ef86	r15732@catbus: nickm \| 2007-10-12 17:28:24 -0400 Start roughing out the functions that we'll use to replace the old ugly v2 networkstatus manipulation code". svn:r11904	2007-10-12 21:33:39 +00:00
Nick Mathewson	783402f63a	r15731@catbus: nickm \| 2007-10-12 17:27:48 -0400 Move "sort a list of routerinfo_t" into its own function in routerlist.c svn:r11903	2007-10-12 21:33:37 +00:00
Nick Mathewson	a009014eb3	r15730@catbus: nickm \| 2007-10-12 16:47:47 -0400 Note a way to make routerlist_remove_old_routrs get called way less. svn:r11902	2007-10-12 21:33:35 +00:00
Nick Mathewson	de08405bdb	r15721@catbus: nickm \| 2007-10-12 13:30:48 -0400 Base vote timing only on a currently live consensus. svn:r11896	2007-10-12 17:43:09 +00:00
Nick Mathewson	8fdfdc5bbb	r15719@catbus: nickm \| 2007-10-12 13:07:45 -0400 Add the routers in the latest consensus to the list of routers to retain when removing old ones. svn:r11895	2007-10-12 17:13:09 +00:00
Roger Dingledine	b60e138586	fix two instances of double-frees. may fix bug 527. svn:r11893	2007-10-12 09:09:46 +00:00
Roger Dingledine	3977ccbc80	Controllers should now specify cache=no or cache=yes when using the +POSTDESCRIPTOR command. svn:r11892	2007-10-12 07:57:29 +00:00
Roger Dingledine	ad8757fbeb	Disable the SETROUTERPURPOSE controller command: it is now obsolete. svn:r11891	2007-10-11 22:19:47 +00:00
Roger Dingledine	5c4a00e796	minor cleanups svn:r11890	2007-10-11 22:19:18 +00:00
Roger Dingledine	3d9bf8c912	note a design flaw that i should fix somehow svn:r11889	2007-10-11 22:16:05 +00:00
Nick Mathewson	3100712c34	r15703@catbus: nickm \| 2007-10-11 17:30:34 -0400 Fix for the reported case of bug 438: check families as well as identities in circuit_find_to_cannibalize(). Code audit still pending. ;) svn:r11886	2007-10-11 21:40:35 +00:00
Nick Mathewson	b62d379f92	r15689@catbus: nickm \| 2007-10-11 16:40:25 -0400 Fix bug 451. This was a nasty bug, so let's fix it twice: first, by banning recursive calls to connection_handle_write from connection_flushed_some; and second, by not calling connection_finished_flushing() on a closed connection. Backport candidate. svn:r11882	2007-10-11 20:45:26 +00:00
Nick Mathewson	ff2820c1ba	r14892@Kushana: nickm \| 2007-10-11 14:00:33 -0400 Fix a bunch of XXX020s: treat some 403s as INFO severity; remove some dead code; share the retry path for consensus routerdescs that are also listed in the v2 networkstatus; check even more aspects of votes when parsing them. svn:r11871	2007-10-11 18:01:12 +00:00
Nick Mathewson	007d76543d	r14887@Kushana: nickm \| 2007-10-11 11:19:39 -0400 Fix some XXX020s in dirserv.c svn:r11870	2007-10-11 16:06:51 +00:00
Nick Mathewson	52ca3a7610	r14886@Kushana: nickm \| 2007-10-11 11:02:53 -0400 Move prototypes around in or.h so that the functions from routerlist.c which moved to networkstatus.c are all grouped in the right section. svn:r11869	2007-10-11 16:06:47 +00:00
Nick Mathewson	6670122619	r14885@Kushana: nickm \| 2007-10-11 10:36:16 -0400 Document minimal values for voting times. Use a macro instead of a magic number. Remove an "enforce this" xxxx020 that was already enforced. svn:r11868	2007-10-11 16:06:42 +00:00
Nick Mathewson	0a1dd92d3e	r14884@Kushana: nickm \| 2007-10-11 10:30:58 -0400 More fixes for cacheing bridge descs:Remove obsolete EXTRAINFO_PURPOSE_GENERAL; remove purpose argument from signed_desc_append_to_journal. svn:r11867	2007-10-11 16:06:37 +00:00
Nick Mathewson	9a56b17c54	r15679@catbus: nickm \| 2007-10-11 09:51:33 -0400 Remove code to generate v1 directories. svn:r11866	2007-10-11 13:56:33 +00:00
Roger Dingledine	541aa72155	Bugfix on r11138: Fix a minor memory leak whenever a controller sends the PROTOCOLINFO command. Bugfix on 0.2.0.5-alpha. Backport candidate. svn:r11864	2007-10-11 03:27:47 +00:00
Roger Dingledine	900ddcb8fd	bugfix on r11298: Fix a minor memory leak whenever we parse guards from our state file. Bugfix on 0.2.0.7-alpha. svn:r11862	2007-10-11 02:03:53 +00:00
Nick Mathewson	487f985f5b	r15670@catbus: nickm \| 2007-10-10 20:08:14 -0400 Restore a removed assert. svn:r11861	2007-10-11 00:13:06 +00:00
Nick Mathewson	a718fcb1c0	r15663@catbus: nickm \| 2007-10-10 16:35:58 -0400 Resolve some more voting-related XXXXs. svn:r11860	2007-10-11 00:13:03 +00:00
Nick Mathewson	0452a965da	r15662@catbus: nickm \| 2007-10-10 16:27:58 -0400 Removee a misleading log message. svn:r11859	2007-10-11 00:13:00 +00:00
Roger Dingledine	8e8d2defe3	bugfix on r11480: Stop calling tor_strlower() on uninitialized memory in some cases. svn:r11858	2007-10-10 23:44:10 +00:00
Roger Dingledine	dd920354c2	let bridge authorities write bridge descriptors to their cached-descriptors* files. nick, did i get this right? svn:r11855	2007-10-10 23:11:53 +00:00
Roger Dingledine	919f421c6c	get rid of the spurious "Freeing linked %s connection" complaints. they happen whenever we fail to establish a connection. svn:r11854	2007-10-10 22:59:34 +00:00
Nick Mathewson	17f3d2807d	r15660@catbus: nickm \| 2007-10-10 16:25:09 -0400 Fix compilation on last patch. svn:r11853	2007-10-10 20:29:52 +00:00
Nick Mathewson	dace37aee8	r15656@catbus: nickm \| 2007-10-10 16:23:18 -0400 Fix the implementation of if-modified-since for certificates so that it applies to all types of certificate requests. Note that the kind of consensus that matters already has a working if-modified-since. svn:r11852	2007-10-10 20:28:01 +00:00
Roger Dingledine	d9a99b9ba6	get r11842 closer to what i want svn:r11851	2007-10-10 20:13:52 +00:00
Nick Mathewson	976c8f8a71	r15646@catbus: nickm \| 2007-10-10 16:01:54 -0400 Fix some memory leaks when serving v3 networkstatus documents and v3 certs. Generate 503 correctly when serving v3 networkstatus documents and v3 certs. svn:r11850	2007-10-10 20:06:38 +00:00
Roger Dingledine	f6b25613b8	Tweak the implementation of proposal 109 slightly: allow at most two Tor servers on the same IP address, except if it's the location of a directory authority, in which case allow five. svn:r11842	2007-10-10 19:53:08 +00:00
Nick Mathewson	55520a2d95	r15636@catbus: nickm \| 2007-10-10 15:28:12 -0400 Retry consensus and certificate downloads properly. Do not fail when there are no certificates to download. Do not download certificates we already have when retrying. svn:r11841	2007-10-10 19:33:19 +00:00
Nick Mathewson	f05685a8eb	r15635@catbus: nickm \| 2007-10-10 15:27:07 -0400 Remove extraneous whitespace svn:r11840	2007-10-10 19:33:14 +00:00
Nick Mathewson	b5301d81db	r15634@catbus: nickm \| 2007-10-10 14:26:49 -0400 Resolve/ignore some XXXXs, and be even more careful about listing a server as a v3 authority. svn:r11839	2007-10-10 19:33:11 +00:00
Nick Mathewson	b599d4264f	r15633@catbus: nickm \| 2007-10-10 14:16:54 -0400 Fix a spelling mistake. svn:r11838	2007-10-10 19:33:06 +00:00
Nick Mathewson	45b987d891	r15632@catbus: nickm \| 2007-10-10 13:48:44 -0400 Merge networkstatus_add_signatures_impl into the only function that calls it. svn:r11837	2007-10-10 19:33:01 +00:00
Nick Mathewson	daf4c11f1a	r15630@catbus: nickm \| 2007-10-10 13:39:44 -0400 Save weighted-fractional-uptime to disk as well as MTBF. Bump the version on rouer-stability: downgrading to versions earlier than this one will lose your WFU data. svn:r11835	2007-10-10 17:48:58 +00:00
Peter Palfrader	1a94e84661	Say "using socksX _to_ port y" instead of "socksX _on_ port y". it confuses weasel less svn:r11834	2007-10-10 15:44:34 +00:00
Nick Mathewson	9ed39643fa	r15626@catbus: nickm \| 2007-10-10 11:02:32 -0400 Resolve bug 516: Never report our bandwidth-history as over RelayBandwidthRate*NUM_SECS_BW_SUM_INTERVAL. svn:r11833	2007-10-10 15:07:19 +00:00
Nick Mathewson	cb0dbbcfa5	r15621@catbus: nickm \| 2007-10-10 00:37:25 -0400 Turns out, Bug 463 was just another "warn about something that is no big deal" thing. Downgrade, comment, and resolve. svn:r11829	2007-10-10 04:37:38 +00:00
Nick Mathewson	1f4eafdb91	r15619@catbus: nickm \| 2007-10-10 00:23:45 -0400 Fix bug 483: downgrade a harmless "Hey your accept() implementation sucks" warning to an info. svn:r11828	2007-10-10 04:24:02 +00:00
Nick Mathewson	72f352880c	r15608@catbus: nickm \| 2007-10-09 19:01:50 -0400 Give better messages and return values from signature uploads and downlaods; also, log actual errors when we screw up. svn:r11823	2007-10-09 23:02:02 +00:00
Roger Dingledine	4f23045e58	back out a little bit of r11817 to preserve current behavior. some other behavior changes left in. svn:r11821	2007-10-09 21:12:48 +00:00
Roger Dingledine	a5851939c0	i heard that users know the phrase 'system clock' better than 'clock'. hm. svn:r11820	2007-10-09 21:11:16 +00:00
Nick Mathewson	97fa3fdf16	r15599@catbus: nickm \| 2007-10-09 16:44:36 -0400 Fix the bug that was making moria1 set valid-after wrong in its votes: we were looking at the preferred timing when we should have been looking at the consensus timing. svn:r11818	2007-10-09 20:44:51 +00:00
Nick Mathewson	8b71a76dd3	r15598@catbus: nickm \| 2007-10-09 16:37:35 -0400 Turn all "Is DirPort nonzero? Because if it is, we must be a directory" logic into calls to dirserver_mode(). svn:r11817	2007-10-09 20:44:47 +00:00
Nick Mathewson	010fd50c36	r15597@catbus: nickm \| 2007-10-09 16:17:42 -0400 Make authority_certs_fetch_missing only fetch certificates which we are not currently downloading; fix XXXX020s in networkstatus.c svn:r11816	2007-10-09 20:44:45 +00:00
Nick Mathewson	0827d6f217	r15593@catbus: nickm \| 2007-10-09 15:31:10 -0400 Fix an infinite loop when parsing multiple votes. svn:r11813	2007-10-09 19:31:14 +00:00
Nick Mathewson	a2005cd2c1	r15590@catbus: nickm \| 2007-10-09 15:14:42 -0400 Change dirvote_get_vote to take named flags rather than 3 boolean inputs. Fix a bug that was caused by the order of the boolean inputs in or.h not matching the order of boolean inputs in dirvote.c. svn:r11812	2007-10-09 19:14:48 +00:00
Nick Mathewson	40b6a66c89	r15589@catbus: nickm \| 2007-10-09 15:08:00 -0400 Fix dumb typo in vote retrieval: we want to check the pending votes to see what we are missing; not the previous period. svn:r11811	2007-10-09 19:14:46 +00:00
Nick Mathewson	a3d4c47515	r15587@catbus: nickm \| 2007-10-09 15:05:27 -0400 When parsing two concatenated networkstatuses (as we do when voting), detect the end of the first one properly. svn:r11810	2007-10-09 19:05:38 +00:00
Roger Dingledine	c9f2afd5fa	make r11808 build on my 64-bit svn:r11809	2007-10-09 18:43:05 +00:00
Nick Mathewson	23614f9523	r15581@catbus: nickm \| 2007-10-09 14:36:47 -0400 Recompute voting schedule whenever a consensus is set. svn:r11808	2007-10-09 18:36:56 +00:00
Nick Mathewson	f1d4e3477b	Bugfixes in fetching certificates for a consensus: fetch tor/keys/fp/X, not tor/keys/X. Also, count signatures where no certificate is known as "missing a certificate" not as "unknown authority." svn:r11805	2007-10-09 17:40:23 +00:00
Nick Mathewson	c7981e669f	r15574@catbus: nickm \| 2007-10-09 13:01:53 -0400 Fix the "400 OK" issue when replying to a vote. svn:r11801	2007-10-09 17:07:13 +00:00
Nick Mathewson	5346a01796	r14813@Kushana: nickm \| 2007-10-09 11:10:48 -0400 Use download_status_t for v2 networkstatuses and certs as well as for routers. Make functions to manipulate it. Next steps: use it for consensus networkstatuses, and get consensus download rescheduling working. svn:r11800	2007-10-09 15:27:45 +00:00
Nick Mathewson	bb9cc4fb29	r14812@Kushana: nickm \| 2007-10-09 10:22:00 -0400 Merge extra fields in local_routerstatus_t back into routerstatus_t. See changelog for rationale. svn:r11799	2007-10-09 15:27:15 +00:00
Roger Dingledine	11a782a6c3	for once, it was "no-tab man" that struck again. svn:r11793	2007-10-08 21:28:23 +00:00
Nick Mathewson	18ec603861	r14802@Kushana: nickm \| 2007-10-08 17:21:30 -0400 Refactor out about a third of routerlist.c into a new networkstatus.c. I\m not sure that I got everything that needed to move, but so far so good. svn:r11791	2007-10-08 21:21:50 +00:00
Nick Mathewson	13f7f98ad2	r14799@Kushana: nickm \| 2007-10-08 15:55:18 -0400 Add code to download router descriptors listed in a v3 networkstatus consensus. svn:r11790	2007-10-08 19:56:57 +00:00
Nick Mathewson	84d7677a8a	r14770@Kushana: nickm \| 2007-10-08 11:43:02 -0400 Make router_digest_is_trusted_dir able to check for type. When looking for a V3 directory, only assume that the V3 authorities and caches have it: previous code assumed that all authorities had it. svn:r11789	2007-10-08 17:44:19 +00:00
Nick Mathewson	3f6e3ce61b	r14769@Kushana: nickm \| 2007-10-07 14:00:17 -0400 Fetch networkstatus consensus documents as needed. Disabled for clients until more caches support it. svn:r11788	2007-10-08 17:44:09 +00:00
Nick Mathewson	6f7847b378	r15530@catbus: nickm \| 2007-10-04 12:16:27 -0400 Add a bunch of function documentation; clean up a little code; fix some XXXXs; tag the nonsensical EXTRAINFO_PURPOSE_GENERAL as nonsesnse; note another bit of "do not cache special routers" code to nuke. svn:r11761	2007-10-04 16:21:58 +00:00
Nick Mathewson	8439c4ec2f	r15512@catbus: nickm \| 2007-10-02 16:27:43 -0400 Make some functions static; remove some dead code. svn:r11750	2007-10-02 20:35:23 +00:00
Nick Mathewson	f4f780b526	r15510@catbus: nickm \| 2007-10-02 16:14:42 -0400 Add support for more vote URLs that weasel wanted. Weasel: please test this before I inflict it on anybody else. :) svn:r11749	2007-10-02 20:19:43 +00:00
Nick Mathewson	439fe55c6b	r15436@catbus: nickm \| 2007-10-01 21:17:27 -0400 Fix disgusting O(n^2) behavior in router_parse_list_from_string. Noticed by Li-Hui Zhou; found with oprofile. svn:r11738	2007-10-02 01:22:42 +00:00
Nick Mathewson	b5c8a8ae53	r15422@catbus: nickm \| 2007-09-27 16:42:35 -0400 Use descriptor annotations to record the source, download t time, and purpose of every descriptor we add to the store. The remaining to-do item is to stop setting do_not_cache on bridges. svn:r11680	2007-09-27 20:46:30 +00:00
Nick Mathewson	2050b31bb9	r15421@catbus: nickm \| 2007-09-27 15:44:17 -0400 When we are a bridge directory, add bridges with purpose BRIDGE, not with purpose CONTROLLER. Roger, is this right? svn:r11679	2007-09-27 20:46:28 +00:00
Nick Mathewson	60efd6b726	r15420@catbus: nickm \| 2007-09-27 15:40:25 -0400 Remove annotated_desc_store store (which we never used). Instead, shift name of router store to cached-descriptors, but initialize it from cached-routers as needed svn:r11678	2007-09-27 20:46:24 +00:00
Nick Mathewson	a1c5a807d0	r15418@catbus: nickm \| 2007-09-27 12:37:59 -0400 Fix a stupid logic error in authority_cert_get_by_sk_digest: the presence of an authority lacking a v3 cert does not mean that subsequent authorities lack them too. svn:r11668	2007-09-27 16:41:42 +00:00
Nick Mathewson	28946069ee	r15412@catbus: nickm \| 2007-09-27 12:04:24 -0400 More annotated-store work: handle annotations in lists correctly. Add ability to prepend annotations to a routerdesc (and to every rtouredesc in a list), while verifying that the routerdesc is not already annotated. svn:r11665	2007-09-27 16:08:10 +00:00
Roger Dingledine	ea47287575	minor typo svn:r11658	2007-09-27 05:20:26 +00:00
Nick Mathewson	034524f4b7	r15400@catbus: nickm \| 2007-09-26 12:13:12 -0400 Backend for descriptor annotations: parse annotations as keywords; only allow them to appear in the cache; do not serve them as part of the descriptor if we are a dirserver. Still need mechanism to set annotations. Still need to rename cache file. svn:r11654	2007-09-26 16:19:44 +00:00
Nick Mathewson	95d97c722a	r15371@catbus: nickm \| 2007-09-25 19:53:13 -0400 Always set status_out when adding a vote. svn:r11646	2007-09-25 23:57:12 +00:00
Nick Mathewson	4d44bf1edc	r15367@catbus: nickm \| 2007-09-25 19:31:11 -0400 It is amazing how reliable missing svk st are at breaking code. svn:r11644	2007-09-25 23:35:28 +00:00
Nick Mathewson	ad11e9d0f1	r15310@catbus: nickm \| 2007-09-24 11:36:08 -0400 Patch from Robert Hogan: fix a couple of status-event related typos. Backport candidate. svn:r11604	2007-09-24 15:41:20 +00:00
Nick Mathewson	921f9f774d	r15279@catbus: nickm \| 2007-09-22 02:00:06 -0400 V3 authority work: fetch missing votes and/or signatures as needed. svn:r11575	2007-09-22 06:06:05 +00:00
Roger Dingledine	b40230f45b	note another bug i'd like to fix svn:r11571	2007-09-22 00:05:46 +00:00
Roger Dingledine	523ac934de	make directories_have_accepted_server_descriptor() able to handle non-default values of PublishServerDescriptor. svn:r11569	2007-09-21 22:14:39 +00:00
Roger Dingledine	41f3d0eb27	only mess with 'state' in init_keys if we're planning to actually run tor. this resolves a segfault in 'tor --list-fingerprints' introduced by r11437. backport candidate due to r11438. svn:r11566	2007-09-21 21:52:31 +00:00
Nick Mathewson	65cf389998	r15253@catbus: nickm \| 2007-09-21 15:03:51 -0400 Oops; we had vote_delay and dist_delay switched when computing when to generate our consensus. Harmless so far, but let's get that fixed. svn:r11558	2007-09-21 19:11:52 +00:00
Roger Dingledine	193a144c9f	Make "UpdateBridgesFromAuthority" torrc option work: when bridge users configure that and specify a bridge with an identity fingerprint, now they will lookup the bridge descriptor at the default bridge authority via a one-hop tunnel, but once circuits are established they will switch to a three-hop tunnel for later connections to the bridge authority. svn:r11550	2007-09-21 06:14:36 +00:00
Nick Mathewson	fdf390525c	r15233@catbus: nickm \| 2007-09-20 18:58:23 -0400 19:00 < weasel> Sep 21 01:00:01.926 [warn] Consensus published. 19:00 < weasel> hah 19:00 < nickm> ha indeed 19:00 < nickm> a winner is me 19:00 < weasel> _warn_ :) 19:01 < nickm> watch out! It could go off at any moment! 19:01 * weasel backs away svn:r11546	2007-09-20 23:02:13 +00:00
Roger Dingledine	90d1345d90	bugfix on r11110: Fix a bug that made servers send a "404 Not found" in response to attempts to fetch their server descriptor. This caused Tor servers to take many minutes to establish reachability for their DirPort, and it totally crippled bridges. Bugfix on 0.2.0.5-alpha. svn:r11545	2007-09-20 22:08:40 +00:00
Peter Palfrader	3b776b865e	Minor whitespace fix svn:r11543	2007-09-20 21:46:10 +00:00
Peter Palfrader	b16224c311	add a v3 authority svn:r11542	2007-09-20 21:36:56 +00:00
Nick Mathewson	fc5dd0cdbb	r15231@catbus: nickm \| 2007-09-20 16:04:30 -0400 Patch from karsten: remove cbc and make unit tests handle aes-ctr-with-iv. svn:r11538	2007-09-20 20:08:47 +00:00
Roger Dingledine	088c4cd8ce	it works better when it compiles svn:r11531	2007-09-20 04:54:50 +00:00
Roger Dingledine	0914883339	Resume listing "AUTHORITY" flag for authorities in network status. Bugfix on 0.2.0.3-alpha; reported by Alex de Joode. svn:r11530	2007-09-20 04:37:17 +00:00
Nick Mathewson	5e81b0ecb8	r15170@catbus: nickm \| 2007-09-19 11:41:50 -0400 Carry a new evdns function over from libevent: do not rely on compile-time code to set the transaction ID correctly. This will be important when we finally drop our internal copy of eventdns.c svn:r11517	2007-09-19 15:53:36 +00:00
Nick Mathewson	faeedbb8af	r15167@catbus: nickm \| 2007-09-19 11:19:08 -0400 Fix unit tests for rendezvous descriptor parsing. svn:r11516	2007-09-19 15:53:33 +00:00
Roger Dingledine	53f57dd7c0	Set up moria1 as the first v3 directory authority. svn:r11506	2007-09-19 03:22:01 +00:00
Roger Dingledine	a1e923c50d	right before publishing our service descriptor, we were rewriting the hexdigest back to an ambiguous nickname. if this patches it, we should write a changelog and then backport. svn:r11500	2007-09-19 00:30:19 +00:00
Roger Dingledine	2a2cee9e51	Start using the v2 intro format for hidden service connections. Now clients specify their chosen rendezvous point by identity digest rather than by (potentially ambiguous) nickname. This change could speed up hidden service connections dramatically. svn:r11499	2007-09-18 23:48:39 +00:00
Roger Dingledine	82da6c02ba	clean up r11496 svn:r11498	2007-09-18 23:34:27 +00:00
Roger Dingledine	eb9dc12ce9	Drop support for v1 rendezvous descriptors, since we never used them anyway, and the code has probably rotted by now. Based on patch from Karsten Loesing. svn:r11496	2007-09-18 21:17:45 +00:00
Roger Dingledine	f15a4c8bd7	add some crypto/util functions from karsten, as the first step of integrating his new hidden service stuff svn:r11489	2007-09-18 17:07:56 +00:00
Nick Mathewson	f45dec1690	r15143@catbus: nickm \| 2007-09-18 11:49:46 -0400 Add getinfo status/good-server-descriptor and status/reachability-succeeded. Patch from Robert Hogan. svn:r11483	2007-09-18 15:53:55 +00:00
Nick Mathewson	a2b76befff	r15142@catbus: nickm \| 2007-09-18 11:43:32 -0400 Split "Have all the authorities accepted our server descriptor?" into its own function. Patch from Robert Hogan. svn:r11482	2007-09-18 15:53:53 +00:00
Nick Mathewson	eee8d750b6	r15140@catbus: nickm \| 2007-09-18 11:34:54 -0400 Get rid of a needless malloc() when parsing address policies. Original patch from "Some guy on #tor", via arma. Altered to have a sufficiently large buffer, and not use the buffer so much, and to save a strlcpy. svn:r11480	2007-09-18 15:38:00 +00:00
Roger Dingledine	8f75defd33	Servers used to decline to publish their DirPort if their BandwidthRate, RelayBandwidthRate, or MaxAdvertisedBandwidth were below a threshold. Now they only look at BandwidthRate and RelayBandwidthRate. svn:r11465	2007-09-17 22:22:05 +00:00
Roger Dingledine	ffce9d3368	trivial doxygen thing svn:r11463	2007-09-17 21:59:07 +00:00
Nick Mathewson	8c13967803	r14448@Kushana: nickm \| 2007-09-17 14:26:56 -0400 Unify all of the divergent median/nth-percentile code in container.[ch] svn:r11457	2007-09-17 18:27:49 +00:00
Nick Mathewson	93d4ad9743	r14447@Kushana: nickm \| 2007-09-17 13:31:50 -0400 Track weighted fractional uptime in addition to weighted mtbf: we want to use mtbf for stable, but fractional uptime for guard. svn:r11456	2007-09-17 18:27:43 +00:00
Nick Mathewson	076b27aff8	r15077@catbus: nickm \| 2007-09-15 14:04:19 -0400 Oops; make Makefile.am work on mingw again. svn:r11445	2007-09-15 18:06:23 +00:00
Nick Mathewson	1dbe726f04	r15068@catbus: nickm \| 2007-09-14 15:25:02 -0400 Fix a couple typos in control.c; spotted by Robert Hogan. svn:r11440	2007-09-14 19:27:04 +00:00
Nick Mathewson	5fcc48d389	r14425@Kushana: nickm \| 2007-09-13 13:00:57 -0400 Do not load state when options->command is not RUN_TOR. (Resolves bug 499; backport candidate) svn:r11437	2007-09-13 17:01:08 +00:00
Nick Mathewson	9b1ad0074b	r14392@Kushana: nickm \| 2007-09-12 11:04:20 -0400 Complete implementation of proposal 104: remove bandwidth history lines from router descriptors. svn:r11434	2007-09-12 17:33:23 +00:00
Nick Mathewson	71a56aa895	r14391@Kushana: nickm \| 2007-09-12 10:56:17 -0400 Remove some needless complexity from the code to add signatures to a consensus: previously, we had a path to add new signatures, and a second path to replace signatures. But the second path sufficed as a common case, and the code isn't invoked nearly enough to justify the optimization of having the first path. svn:r11433	2007-09-12 17:33:18 +00:00
Nick Mathewson	1647a5764a	r15056@catbus: nickm \| 2007-09-12 13:15:19 -0400 Try to fix an automake problem by renaming a variable. svn:r11432	2007-09-12 17:17:03 +00:00
Nick Mathewson	e73fb2f102	r15049@catbus: nickm \| 2007-09-11 16:05:50 -0400 When we get a consensus for which we are missing the right certificates, keep it around pending more certificates; do not just drop it. svn:r11430	2007-09-11 20:17:28 +00:00
Nick Mathewson	4de4f53abd	r15048@catbus: nickm \| 2007-09-11 14:20:39 -0400 Add code to warn about mauthorities on a consensus when they are not what we expect to find. svn:r11429	2007-09-11 20:17:25 +00:00
Nick Mathewson	749da8e0e9	r15047@catbus: nickm \| 2007-09-11 13:40:54 -0400 Fix a memory leak when reloading v3 authority certificate and keys. svn:r11428	2007-09-11 20:17:24 +00:00
Nick Mathewson	973502d290	r15046@catbus: nickm \| 2007-09-11 13:38:36 -0400 Check V3 authority certificates for expiry, and warn the authority op as they get old. svn:r11427	2007-09-11 20:17:22 +00:00
Nick Mathewson	3c7652ccdb	r15045@catbus: nickm \| 2007-09-11 11:52:29 -0400 Reject incoming votes when the valid-after time does not match the period that we're trying to vote for. svn:r11426	2007-09-11 20:17:20 +00:00
Nick Mathewson	c0130f9611	r15022@catbus: nickm \| 2007-09-10 10:31:54 -0400 remove yet more pointless differences between our eventdns.c and the evdns.c in libevent. svn:r11425	2007-09-11 20:17:18 +00:00
Nick Mathewson	5828e4d5c4	r15020@catbus: nickm \| 2007-09-10 10:22:31 -0400 remove more pointless differences between our eventdns.c and the evdns.c in libevent. svn:r11416	2007-09-10 14:23:26 +00:00
Nick Mathewson	13b65c4129	r15018@catbus: nickm \| 2007-09-10 10:04:16 -0400 Change comments in eventdns.c to C-style, so we can more easily diff it against the version in libevent to reconcile them (again). svn:r11415	2007-09-10 14:05:12 +00:00
Nick Mathewson	a04e584cbc	r15005@catbus: nickm \| 2007-09-10 09:49:03 -0400 Undo brokenness from merge conflict. svn:r11414	2007-09-10 13:50:00 +00:00
Nick Mathewson	615d19fe4c	r15001@catbus: nickm \| 2007-09-10 09:44:49 -0400 Fix a couple of memory leaks in eventdns.c; found by niels. Not backport candidates, since they only affect DNSPort users. svn:r11413	2007-09-10 13:48:01 +00:00
Nick Mathewson	6744ebe7b5	svn:r11412	2007-09-10 13:47:56 +00:00
Nick Mathewson	565f5f32c5	r14363@Kushana: nickm \| 2007-09-08 16:25:45 -0400 Another round of whitespeace fixes. svn:r11407	2007-09-08 20:25:57 +00:00
Nick Mathewson	eb3f24f027	r14358@Kushana: nickm \| 2007-09-08 13:45:16 -0400 Implement certificate fetch functions. svn:r11405	2007-09-08 19:08:39 +00:00
Nick Mathewson	1c8bd05c70	Fix compilation of ntmain.c. svn:r11395	2007-09-06 18:19:09 +00:00
Nick Mathewson	4c4280e249	Make sure that even dumb compilers can tell that bad_cookie and bad_password are set before use. svn:r11390	2007-09-06 18:04:28 +00:00
Nick Mathewson	f17a38ab04	r14940@catbus: nickm \| 2007-09-06 13:22:26 -0400 Move NT services code into its own C file. Probably will not build happily on win32 yet; more hacking needed. svn:r11388	2007-09-06 17:42:05 +00:00
Andrew Lewman	c5b4f779ec	Fixed misspelling of "connection" caught by kate. svn:r11382	2007-09-06 00:36:53 +00:00
Nick Mathewson	d57c1c5c56	r14328@Kushana: nickm \| 2007-09-04 20:17:34 -0400 There is no good reason to make hashedcontrolpassword and cookieauthentication mutually exclusive. So let's not. svn:r11377	2007-09-05 00:31:07 +00:00
Nick Mathewson	7c47856c9e	r14327@Kushana: nickm \| 2007-09-04 20:06:04 -0400 Better comment in dnsserv.c svn:r11376	2007-09-05 00:31:01 +00:00
Nick Mathewson	eca3634f62	r14294@Kushana: nickm \| 2007-09-01 13:50:03 -0400 Oops. Initialize "changed" variable when removing obsolete guards. svn:r11346	2007-09-01 17:50:29 +00:00
Nick Mathewson	c967fae598	r14880@catbus: nickm \| 2007-08-31 11:06:10 -0400 Refactor store_stats_t to hold a pointer to the proper mmap, and turn it into a full-fledged type. This sets stuff up nicely for adding a separate "annotated" store. Add some XXXX NM items that need to be fixed when annotated stores exist svn:r11338	2007-08-31 15:08:37 +00:00
Nick Mathewson	2ff871e530	r14871@catbus: nickm \| 2007-08-31 10:12:53 -0400 Check correct circuit type when calling functions from rend_process_relay_cell. Backport candidate. svn:r11336	2007-08-31 14:20:44 +00:00
Nick Mathewson	5da6321b76	r14859@catbus: nickm \| 2007-08-30 17:10:15 -0400 0-pad minutes and seconds when displaying weighted mtbf in info logs. svn:r11324	2007-08-30 21:12:34 +00:00
Nick Mathewson	c8e379a4cd	r14259@Kushana: nickm \| 2007-08-30 02:33:55 -0400 Teach tor about more libevent versions. Be more clear that "Known bugs" means "it will crash or something." Most significantly, stop issuing dire warnings every time we run with kqueue on os x: it seems to have worked for a while now. svn:r11314	2007-08-30 06:34:17 +00:00
Nick Mathewson	f189ecbf20	r14832@catbus: nickm \| 2007-08-29 15:00:27 -0400 Use (and debug) new file-writing functions in order to simplify code that formerly built big strings in RAM. svn:r11301	2007-08-29 19:02:43 +00:00
Nick Mathewson	91f83cfc2d	r14830@catbus: nickm \| 2007-08-29 13:50:10 -0400 Make controllers accept LF as well as CRLF. Update spec to reflect this. Remove now-dead code. Make controller warning about v0 protocol more accurate. svn:r11299	2007-08-29 19:02:33 +00:00
Nick Mathewson	4266039c19	r14826@catbus: nickm \| 2007-08-29 13:19:55 -0400 Add a line to the state file for each guard to let us know which version added the guard. If the line is absent, assume the guard was added by whatever version of Tor last wrote the state file. Remove guards if the version that added them was using a bad guard selection algorithm. (Previously, we removed guards if the version that wrote the file was using a bad guard selection algorithm, even if the guards themselves were chosen by a good version.) svn:r11298	2007-08-29 17:22:00 +00:00
Nick Mathewson	a4cc3e4be1	r14821@catbus: nickm \| 2007-08-27 19:57:56 -0400 Check for absent nickname when making extend info. I still dont know when this happens, but it is easy enough to check for. Fixes bug 467. svn:r11293	2007-08-28 00:00:32 +00:00
Nick Mathewson	7cbe302b3f	r14231@Kushana: nickm \| 2007-08-27 14:56:14 -0400 Most configuration options have the same names in or.h and in torrc. Make the macros reflect this, so that it is easier to fit them onto a line, and so that mismatched options stand out more svn:r11290	2007-08-27 18:56:20 +00:00
Nick Mathewson	d3224bad42	r14227@Kushana: nickm \| 2007-08-27 11:33:28 -0400 Add a new ClientDNSRejectInternalAddresses option (default: on) to refuse to believe that any address can map to or from an internal address. This blocks some kinds of potential browser-based attacks, especially on hosts using DNSPort. Also clarify behavior in some comments. Backport candiate? svn:r11287	2007-08-27 15:33:58 +00:00
Roger Dingledine	c4ee55ed26	Set up Tonga as the default bridge directory authority. svn:r11276	2007-08-25 22:02:55 +00:00
Roger Dingledine	da1485088c	formatting cleanups svn:r11273	2007-08-25 21:31:34 +00:00
Roger Dingledine	df98447be5	revert the recommended-guard-version thing. it did not do what we want, which is to expire old guards every time somebody moves from an old version to the new one. also, refine which version numbers count as 'new enough'. svn:r11272	2007-08-25 20:34:13 +00:00
Nick Mathewson	7efc165095	r14204@Kushana: nickm \| 2007-08-24 10:24:36 -0400 Fix a bug in last patch; add support for getting extrainfo documents by the control port (since it is silly to tell tools to do it without actually giving them an interface). svn:r11270	2007-08-24 14:41:15 +00:00
Nick Mathewson	b9d43e2685	r14203@Kushana: nickm \| 2007-08-24 10:15:58 -0400 Add a hacked-up GETINFO desc/all-recent-extrainfo-hack so that torstat can keep working with a minimum of fuss, until it learns about extrainfo documents. svn:r11269	2007-08-24 14:41:10 +00:00
Nick Mathewson	cf2ac9b9e1	r14202@Kushana: nickm \| 2007-08-24 09:55:30 -0400 Add purposes for new things we need to fetch for v3 directory system. svn:r11268	2007-08-24 14:41:06 +00:00
Nick Mathewson	c3805e753a	r14200@kushana: nickm \| 2007-08-24 08:33:41 -0400 In new code, let's try to prefer named flags to mazes of twisted boolean arguments, all alike. svn:r11267	2007-08-24 12:33:53 +00:00
Roger Dingledine	daece599a1	more cleanups on r11258. looks good now. svn:r11266	2007-08-24 10:50:48 +00:00
Roger Dingledine	738ecba367	make the last patch do what i actually want. it was a bit tricky since we want the default guardversion to be 0 (which is what it is if there's no guardversion line), yet when we're validating a freshly configed and defaulted state, we don't want to complain. svn:r11264	2007-08-24 08:12:25 +00:00
Roger Dingledine	9bacf68851	cleanups on r11258 svn:r11263	2007-08-24 08:01:47 +00:00
Roger Dingledine	d39c7515d1	patch from mike perry to a) stop overloading guards as much, and b) raise the max-believable-bandwidth to 10MB/s. svn:r11258	2007-08-24 06:30:34 +00:00
Roger Dingledine	8d524edb83	a single quote != a single double quote. i can't hear the circus music from here, perhaps we should move closer. svn:r11256	2007-08-23 23:03:32 +00:00
Nick Mathewson	c65131b171	r14185@Kushana: nickm \| 2007-08-22 11:07:01 -0400 Add some voting-related documentation. svn:r11255	2007-08-22 15:07:44 +00:00
Nick Mathewson	08e605b4e2	r14184@Kushana: nickm \| 2007-08-22 11:06:37 -0400 Unmap cached-extrainfo on exit. Fixes bug 484. svn:r11254	2007-08-22 15:07:29 +00:00
Roger Dingledine	c02fb8997b	backport candidate: Make it possible to read the PROTOCOLINFO response in a way that conforms to our control-spec. Reported by Matt Edman. svn:r11251	2007-08-22 07:57:10 +00:00
Roger Dingledine	353abd9830	backport candidate: Stop leaking part of the descriptor when we run into a particularly unparseable piece of it. Bugfix on 0.1.2.x. svn:r11249	2007-08-22 03:21:51 +00:00
Roger Dingledine	79066b4851	backport candidate: Fix a minor memory leak when we fail to find enough suitable servers to choose a circuit. Bugfix on 0.1.2.x. svn:r11247	2007-08-22 03:03:24 +00:00
Nick Mathewson	7dbe7fd4d8	r14758@catbus: nickm \| 2007-08-21 01:36:03 -0400 Finish implementing and documenting proposal 108: Authorities now use MTBF data to set their stability flags, once they have at least 4 days of data to use. svn:r11240	2007-08-21 05:37:24 +00:00
Roger Dingledine	8a21232256	Stop putting the authentication cookie in a file called "0" in your working directory if you don't specify anything for the new CookieAuthFile option. Reported by Matt Edman. svn:r11237	2007-08-21 03:11:56 +00:00
Peter Palfrader	c7140372cb	It works better if we don't print a 404 header after our body svn:r11236	2007-08-20 22:40:09 +00:00
Peter Palfrader	6802923fa7	call it EXPORTMALLINFO, not EXPORTMEMINFO svn:r11235	2007-08-20 22:31:39 +00:00
Peter Palfrader	8aceafc0c8	Appease check-spaces svn:r11234	2007-08-20 22:23:22 +00:00
Peter Palfrader	38cbd7263e	We do not mix variable declarations and code svn:r11233	2007-08-20 22:13:14 +00:00
Peter Palfrader	8c3d14cda5	Optionally export mallinfo() output on the DirPort svn:r11232	2007-08-20 22:11:56 +00:00
Peter Palfrader	f99ac7fe52	Remove /tor/dir-all-weaselhack, it's useless without FULL_V1_DIRECTORIES defined svn:r11231	2007-08-20 21:56:33 +00:00
Roger Dingledine	4ff3343e98	Let directory authorities startup even when they can't generate a descriptor immediately, e.g. because they don't know their address. svn:r11228	2007-08-20 18:29:17 +00:00
Nick Mathewson	df0a141a27	r14740@catbus: nickm \| 2007-08-20 13:00:52 -0400 Only load MTBF data if we are running tor svn:r11226	2007-08-20 17:02:04 +00:00
Nick Mathewson	3effc8b267	r14733@catbus: nickm \| 2007-08-20 12:32:44 -0400 Clean up MTBF storage code. Do not count times that we have been down toward the current run. Handle backward timewarps correctly. Store MTBF data on exit in addition to periodically. svn:r11225	2007-08-20 16:34:17 +00:00
Roger Dingledine	a200f442fb	avoid double-punctuation when we're reporting errors from the config functions to the controller. svn:r11221	2007-08-20 16:13:21 +00:00
Nick Mathewson	76d40372fc	r14731@catbus: nickm \| 2007-08-20 12:02:09 -0400 Clean up authdir_X functions a little. svn:r11220	2007-08-20 16:03:19 +00:00
Nick Mathewson	9958dc8d53	r14729@catbus: nickm \| 2007-08-20 11:58:02 -0400 Trigger load and save of MTBF data. svn:r11219	2007-08-20 15:59:31 +00:00
Nick Mathewson	d3b019a1df	r14726@catbus: nickm \| 2007-08-20 11:42:07 -0400 Make v3-only authorities check reachability svn:r11218	2007-08-20 15:43:17 +00:00
Nick Mathewson	113367bc01	r14722@catbus: nickm \| 2007-08-20 10:54:29 -0400 Add debugging warning to not abort in the case of bug 483. This is probably not an actual error case, so we should figure out what is really causing it and do something more sensible. svn:r11215	2007-08-20 14:59:05 +00:00
Nick Mathewson	c7ed49e7f8	r14663@catbus: nickm \| 2007-08-18 17:50:51 -0400 Fix an XXX020 in or.h: BRIDGE != CONTROLLER. svn:r11195	2007-08-19 15:20:11 +00:00
Roger Dingledine	473ff753f2	bump to 0.2.0.5-alpha since we're getting close svn:r11189	2007-08-19 07:30:29 +00:00
Roger Dingledine	8641439a6e	backport candidate (revert part of r9350): Expire application streams in all cases if they've been around longer than SocksTimeout. Right now there are some cases where the stream will live forever, demanding a new circuit every 15 seconds. Bugfix on 0.1.2.7-alpha; fixes bug 454; reported by lodger. svn:r11186	2007-08-19 07:17:40 +00:00
Roger Dingledine	d6aa617e07	oh, and make it compile too svn:r11185	2007-08-19 07:06:02 +00:00
Roger Dingledine	03560d575e	generalize circuit_find_to_cannibalize() so it knows what purpose circuit we're planning to become svn:r11184	2007-08-19 07:04:24 +00:00
Roger Dingledine	c88803d924	Fix a bug in ADDRMAP controller replies that would sometimes try to print a NULL. Patch from tup. svn:r11181	2007-08-19 04:58:55 +00:00
Roger Dingledine	7c49a8d03e	get rid of a debugging message that non v3-authorities were seeing too, and that doesn't seem to be critical svn:r11179	2007-08-19 04:28:56 +00:00
Andrew Lewman	b7026ea1b3	Move event.h include down a stanza to make mingw happy. svn:r11174	2007-08-19 02:56:16 +00:00
Roger Dingledine	96cff65f85	backport candidate: Refuse to start with certain directory authority keys, and encourage people using them to stop. svn:r11171	2007-08-19 02:51:54 +00:00
Nick Mathewson	b45b91a358	r14661@catbus: nickm \| 2007-08-18 15:38:08 -0400 Long overdue test.c refactoring: add --warn/--notice/--info/--debug command line options to set logging levels, and let the user specify which tests to run from the commmand line. svn:r11167	2007-08-18 19:39:14 +00:00
Nick Mathewson	676d8622de	r14659@catbus: nickm \| 2007-08-18 14:19:34 -0400 When we are loading state info from disk, never believe any date in the future. Doing so can keep us from retrying guards, rotating onion keys, storing bandwidth info, etc. Fixes bug 434, and others. Backport candidate, once it has been tested. svn:r11166	2007-08-18 18:20:42 +00:00
Peter Palfrader	50c0e6b37f	Remove routerlist_check_bug_417() and all its calls. There is still some more debugging code left, marked with XXXs svn:r11161	2007-08-17 22:55:04 +00:00
Nick Mathewson	1f244d3943	r14639@catbus: nickm \| 2007-08-17 17:45:28 -0400 Compile without warnings on MinGW, even with --enable-gcc-warnings enabled. svn:r11157	2007-08-17 21:46:34 +00:00
Nick Mathewson	f8b3927e07	r14634@catbus: nickm \| 2007-08-17 16:43:49 -0400 Try to fix bug 482: do not rely on s6_addr16 or s6_addr32 on MSVC. How ugly. svn:r11155	2007-08-17 20:44:54 +00:00
Nick Mathewson	b34ed73706	r14630@catbus: nickm \| 2007-08-17 16:30:42 -0400 Functions to save and load MTBF information. svn:r11153	2007-08-17 20:31:59 +00:00
Nick Mathewson	31668172ed	r14626@catbus: nickm \| 2007-08-17 11:20:05 -0400 Link note_router_reachable and note_router_unreachable to mtbf code. decouple mtbf from connect/disconnect. log it in USR1. do not blow it away on cleanup if we are an authority. svn:r11151	2007-08-17 20:31:54 +00:00
Roger Dingledine	3f186e6510	help nick work on proposal 108 svn:r11148	2007-08-17 01:29:58 +00:00
Nick Mathewson	357b4645cf	r14612@catbus: nickm \| 2007-08-16 15:23:35 -0400 Initial work on proposal 108: have rephist.c track the information we want to be tracking for OR stability. svn:r11147	2007-08-16 19:32:29 +00:00
Roger Dingledine	2df9bb937d	clean up the cookieauth stuff svn:r11146	2007-08-16 19:27:31 +00:00
Nick Mathewson	718953dbe9	r14606@catbus: nickm \| 2007-08-16 13:45:01 -0400 Implement CookieAuthFile and CookieAuthFileGroupReadable. Backport candidate. svn:r11141	2007-08-16 17:46:01 +00:00
Nick Mathewson	f4398feadb	r14600@catbus: nickm \| 2007-08-16 13:30:22 -0400 Implement proposal 119. Backport candidate. svn:r11138	2007-08-16 17:31:23 +00:00
Nick Mathewson	3623a12262	r14583@catbus: nickm \| 2007-08-15 17:52:35 -0400 Fix a bug caught by Kate: when we switched from masks to bits in 0.2.0.3-alpha, we added a spurious ! that made us never believe that any address fell inside a virtual address range. While we're at it, save a trip around the loop in the common case. svn:r11129	2007-08-15 21:53:34 +00:00
Nick Mathewson	181ba71a90	r14051@Kushana: nickm \| 2007-08-15 15:55:36 -0400 Fix an XXXX020 and a few DOCDOCs. svn:r11127	2007-08-15 19:56:01 +00:00
Nick Mathewson	abad4dfc7a	r14050@Kushana: nickm \| 2007-08-15 15:21:02 -0400 Eliminate tons of repeated code in directory_handle_command_get. svn:r11126	2007-08-15 19:55:57 +00:00
Nick Mathewson	4135c68853	r14049@Kushana: nickm \| 2007-08-15 14:43:56 -0400 Implement code to serve pending votes, consensuses, and signatures. svn:r11125	2007-08-15 19:55:52 +00:00
Nick Mathewson	717f3b8a12	r14047@Kushana: nickm \| 2007-08-15 13:57:39 -0400 fix a really nasty bug in v3 authorities: only set v3_digest in trusted_dir_server_t for v3 authorities. svn:r11124	2007-08-15 17:57:47 +00:00
Nick Mathewson	e10041447c	r14045@Kushana: nickm \| 2007-08-15 13:07:21 -0400 Add more logs to try to hunt down latest voting bug. svn:r11123	2007-08-15 17:07:27 +00:00
Nick Mathewson	38b84d9659	r14043@Kushana: nickm \| 2007-08-15 12:12:25 -0400 Fix consensus signatures: regenerate the entire signature list when we get a new signature, rather than just appending the new signature. This lets us tentatively accept weird signatures, since we can replace them with better ones later. svn:r11122	2007-08-15 16:12:40 +00:00
Nick Mathewson	d5bd7d9fa3	r14032@Kushana: nickm \| 2007-08-15 11:35:16 -0400 Add unit tests for median functions; enforce sensible ranges for intervals and delays. svn:r11121	2007-08-15 15:38:58 +00:00
Nick Mathewson	60c2e9d99e	r14031@Kushana: nickm \| 2007-08-15 11:34:26 -0400 Fix a segfault in cert retrieval svn:r11120	2007-08-15 15:38:53 +00:00
Roger Dingledine	7e5cee8110	this does not actually change anything (i hope), but it makes me a lot more comfortable. nick, can you confirm this? svn:r11119	2007-08-15 15:36:34 +00:00
Roger Dingledine	f606d74f56	backport candidate: - If we require CookieAuthentication but we fail to write the cookie file, we would warn but not exit, and end up in a state where no controller could authenticate. Now we exit. - If we require CookieAuthentication, stop generating a new cookie every time we change any piece of our config. svn:r11117	2007-08-15 15:26:14 +00:00
Nick Mathewson	484a580698	r14028@Kushana: nickm \| 2007-08-14 17:07:51 -0400 Implement cert-retrieval URLs. (Also, update TODO) svn:r11112	2007-08-14 21:09:30 +00:00
Nick Mathewson	486166f9a8	r14020@Kushana: nickm \| 2007-08-14 16:07:37 -0400 return 404 properly when somebody requests a bunch of nonexistent statuses/servers svn:r11110	2007-08-14 20:19:58 +00:00
Nick Mathewson	3923eff1e6	r14019@Kushana: nickm \| 2007-08-14 15:40:05 -0400 Save a 4 or 8 bytes per connection in or.h svn:r11109	2007-08-14 20:19:51 +00:00
Nick Mathewson	2a31f09af6	r14018@Kushana: nickm \| 2007-08-14 15:39:35 -0400 Resolve XXXX020s in config.c svn:r11108	2007-08-14 20:19:46 +00:00
Nick Mathewson	42fa1de585	r14017@Kushana: nickm \| 2007-08-14 15:13:14 -0400 Enable more code for v3 voting timing information. Also, spec clarification. svn:r11107	2007-08-14 20:19:40 +00:00
Nick Mathewson	25d2901857	r14015@Kushana: nickm \| 2007-08-14 12:39:04 -0400 Try to avoid adding duplicate signatures to a consensus. svn:r11105	2007-08-14 16:39:18 +00:00
Nick Mathewson	925394022a	r14011@Kushana: nickm \| 2007-08-14 10:29:49 -0400 Actually upload signatures when we vote. log more about the signatures we get. discard pending vote stuff after we publish. svn:r11104	2007-08-14 14:30:45 +00:00
Nick Mathewson	944bc41f99	r14010@Kushana: nickm \| 2007-08-14 10:20:28 -0400 Fix a URL in voting svn:r11103	2007-08-14 14:30:33 +00:00
Nick Mathewson	3399d63170	r14009@Kushana: nickm \| 2007-08-14 10:20:20 -0400 Fix a logic error in certificate handling svn:r11102	2007-08-14 14:30:25 +00:00
Nick Mathewson	817ed1ccbf	r14006@kushana: nickm \| 2007-08-14 09:34:28 -0400 re-enable version checking svn:r11101	2007-08-14 13:34:41 +00:00
Nick Mathewson	3268ab58f2	r14005@kushana: nickm \| 2007-08-14 09:34:19 -0400 add a warning to find a bug (maybe) svn:r11100	2007-08-14 13:34:35 +00:00
Nick Mathewson	cd5eaf53f9	r14003@kushana: nickm \| 2007-08-13 22:23:49 -0400 Resolve a pile of XXXXs in and around voting code svn:r11099	2007-08-14 02:23:57 +00:00
Nick Mathewson	7113ab8f90	r14001@kushana: nickm \| 2007-08-13 20:06:36 -0400 Check for at least as many signatures as required, not for more signatures than required. svn:r11098	2007-08-14 00:07:29 +00:00
Nick Mathewson	b6c548094c	r13998@kushana: nickm \| 2007-08-13 19:20:28 -0400 Add some insanely verbose log messages on voting authorities. svn:r11097	2007-08-13 23:23:06 +00:00
Nick Mathewson	a1ce60f9a6	r14546@catbus: nickm \| 2007-08-13 17:19:01 -0400 Make if-modified-since work on consensuses svn:r11095	2007-08-13 21:19:54 +00:00
Nick Mathewson	9356a0b1dd	r14544@catbus: nickm \| 2007-08-13 17:00:09 -0400 Give a 200 when a duplicate vote gets uploaded. svn:r11094	2007-08-13 21:01:02 +00:00
Nick Mathewson	7d990b5aa1	r13992@Kushana: nickm \| 2007-08-13 16:45:22 -0400 A vote we already have a nd a double-upload are different things. svn:r11093	2007-08-13 20:45:36 +00:00
Nick Mathewson	b4adf151d2	r13991@Kushana: nickm \| 2007-08-13 16:37:43 -0400 Do not warn on missing cached consensus. svn:r11092	2007-08-13 20:45:27 +00:00
Nick Mathewson	4e4dcb2571	r13989@Kushana: nickm \| 2007-08-13 16:31:03 -0400 Actually store the v3 authority id digest of a trusteddirserver svn:r11091	2007-08-13 20:31:08 +00:00
Nick Mathewson	94c90c42e3	r13987@Kushana: nickm \| 2007-08-13 16:17:09 -0400 Stop segfaulting on failed consensus. svn:r11090	2007-08-13 20:17:14 +00:00
Nick Mathewson	936edd901d	r13985@Kushana: nickm \| 2007-08-13 16:05:07 -0400 Fix some simple logic errors in voting. svn:r11089	2007-08-13 20:05:25 +00:00
Nick Mathewson	2d07cce67f	r14536@catbus: nickm \| 2007-08-13 15:54:17 -0400 Make voting actually function. svn:r11088	2007-08-13 19:55:08 +00:00
Nick Mathewson	89c65f2a4e	r14534@catbus: nickm \| 2007-08-13 15:15:46 -0400 Read v3 keys from the right location svn:r11087	2007-08-13 19:16:44 +00:00
Nick Mathewson	ce1f01c3e6	r14531@catbus: nickm \| 2007-08-13 14:46:25 -0400 Cache v3 networkstatus consensuses on disk. svn:r11086	2007-08-13 18:47:22 +00:00
Nick Mathewson	33cf3ada94	r14526@catbus: nickm \| 2007-08-13 14:08:37 -0400 Make voting interval configurable. svn:r11083	2007-08-13 18:09:38 +00:00
Roger Dingledine	762b5c479c	less scary log entry svn:r11077	2007-08-11 14:38:11 +00:00
Roger Dingledine	330abbb6c6	logging patch from karsten, slightly modified to compile svn:r11074	2007-08-11 14:13:25 +00:00
Roger Dingledine	5920484083	dirserv.c:782: warning: `set_v1_dirty' might be used uninitialized in this function svn:r11068	2007-08-10 03:07:00 +00:00
Nick Mathewson	5070a1e3ef	r14103@catbus: nickm \| 2007-08-09 18:30:40 -0400 Drop v1 directory support: instead, just generate stub v1 directories. This should save lots and lots of directory bandwidth, and break any code relying on v1 directories, including Tor 0.1.0.x and earlier. svn:r11067	2007-08-09 22:32:33 +00:00
Nick Mathewson	da09efe13d	r13953@Kushana: nickm \| 2007-08-08 07:40:46 -0700 Fix osx compilation. svn:r11065	2007-08-08 14:43:30 +00:00
Nick Mathewson	3fc04529d4	r14093@catbus: nickm \| 2007-08-08 01:49:54 -0400 Include fewer redundant headers; use the compiler search paths better. svn:r11060	2007-08-08 05:50:31 +00:00
Nick Mathewson	68e6426c23	r13927@Kushana: nickm \| 2007-08-03 00:56:54 -0700 ratchet down the time spent on threading tests svn:r11043	2007-08-03 07:57:41 +00:00
Nick Mathewson	1c513979fc	r13919@Kushana: nickm \| 2007-08-02 10:58:31 -0700 Warn about unsafe ControlPort configurations. svn:r11038	2007-08-02 21:03:40 +00:00
Roger Dingledine	659cdae145	a patch on r11016 that makes it work better svn:r11018	2007-08-02 04:28:29 +00:00
Nick Mathewson	322b6f7e65	r13892@Kushana: nickm \| 2007-08-01 18:27:13 -0700 Close immediately after anything but a successful authentication attempt on the control port. Backport candidate. svn:r11016	2007-08-02 01:28:40 +00:00
Nick Mathewson	a4e7dffc94	r13886@Kushana: nickm \| 2007-08-01 09:43:06 -0700 Unit tests and debugging for detached signature manipulation. svn:r11015	2007-08-01 16:43:44 +00:00
Nick Mathewson	484c8b776d	r13872@Kushana: nickm \| 2007-07-31 08:27:54 -0700 Rename IN4_ADDR and IN6_ADDR to try to avoid conflicting with Windows definitions. This may fix the windows build. svn:r11011	2007-08-01 15:57:34 +00:00
Nick Mathewson	480db0f00a	r14034@catbus: nickm \| 2007-07-31 05:22:56 -0400 possible fix for bug 473: always set buf->cur on buf_remove_from_front. svn:r11004	2007-07-31 09:31:15 +00:00
Peter Palfrader	ce8edc964c	Stop pretending all systems are fast svn:r11003	2007-07-31 06:48:47 +00:00
Roger Dingledine	57c6264ede	tweak comment svn:r10998	2007-07-30 23:52:58 +00:00
Nick Mathewson	45c82b1d85	r14024@catbus: nickm \| 2007-07-30 14:13:58 -0400 Glibc (and maybe others) define a mallinfo() that can be used to see how the platform malloc is acting inside. When we have it, dump its output on dumpmemusage(). svn:r10996	2007-07-30 18:14:14 +00:00
Nick Mathewson	9fb77a6479	Disable SENTINELS in buffers: it may be responsible for making platform mallocs() be inefficient, and we havent needed it in a long long time. svn:r10994	2007-07-30 17:51:14 +00:00
Nick Mathewson	9260a824ef	Yet another buffer RAM patch: tNever ever ever keep a buffer memory chunk around for an empty buffer that could go on the freelist. This wants profiling to make sure that performance doesnt suffer. svn:r10993	2007-07-30 17:47:43 +00:00
Nick Mathewson	34a3a5e2f4	r14016@catbus: nickm \| 2007-07-30 13:45:55 -0400 More documentation svn:r10992	2007-07-30 17:46:14 +00:00
Roger Dingledine	5d535a28c9	clean up some bridge log messages svn:r10985	2007-07-30 08:43:02 +00:00
Roger Dingledine	1b01ad6d38	writing instructions before you release means you can make sure your instructions don't seg fault svn:r10984	2007-07-30 08:42:47 +00:00
Nick Mathewson	915c4c3ab8	r14001@catbus: nickm \| 2007-07-29 21:31:53 -0400 Try to call time(NULL) a little less. svn:r10980	2007-07-30 01:32:12 +00:00
Nick Mathewson	a3b8b2c4e3	r14000@catbus: nickm \| 2007-07-29 21:16:45 -0400 Fix bug 472: do not use spaces in pseudo-address for local link cons. svn:r10979	2007-07-30 01:32:07 +00:00
Roger Dingledine	468d922280	start hunting bugs, first in a non-crashy manner svn:r10978	2007-07-30 01:07:06 +00:00
Nick Mathewson	3dbc825f36	r13996@catbus: nickm \| 2007-07-29 19:17:53 -0400 Fix whitespace svn:r10977	2007-07-29 23:18:06 +00:00
Nick Mathewson	77508edd36	r13989@catbus: nickm \| 2007-07-29 19:11:07 -0400 More directory voting code. Now, if everything works, and I haven't forgotten anything, it is possible to set up some v3 authorities and start voting. Of course, I have probably forgotten something, and there are probably bugs in there somewhere too. svn:r10976	2007-07-29 23:11:44 +00:00
Roger Dingledine	ca7c53d3cc	Be even more aggressive about separating local traffic from relayed traffic when RelayBandwidthRate is set. (Refines proposal 111.) svn:r10974	2007-07-29 22:13:44 +00:00
Nick Mathewson	616152486f	r13986@catbus: nickm \| 2007-07-29 09:15:03 -0400 Answer comment from Roger. svn:r10971	2007-07-29 13:18:52 +00:00
Roger Dingledine	a68e6e23c9	patches on r10968: compare advertised capacity, not bandwidthrate; and make the sorting order deterministic to avoid flapping. also note that we could take the "is_auth" checks out of the sorting entirely. svn:r10970	2007-07-29 05:56:30 +00:00
Nick Mathewson	9031bbd4d8	r13982@catbus: nickm \| 2007-07-29 01:31:53 -0400 Actually, we missed a rule about what routers to prefer: first prefer authority to non-authority, then running, then bandwidth. svn:r10969	2007-07-29 05:32:03 +00:00
Nick Mathewson	1b665b3c7e	r13979@catbus: nickm \| 2007-07-29 01:20:20 -0400 Implement proposal 109: As an authority, never call more than 3 servers per IP Running and Valid. Prefer Running servers to non-running ones; then prefer high-bandwidth to low-bandwidth. Needs testing. svn:r10968	2007-07-29 05:20:31 +00:00
Roger Dingledine	eca2a30060	make progress towards retrying our bridges when they're all down and we get a new socks request svn:r10967	2007-07-29 04:38:21 +00:00
Nick Mathewson	964e4a305d	r13972@catbus: nickm \| 2007-07-29 00:01:38 -0400 Make our control events for multi-line async replies conform to our old grammar. Change back to the old grammar (which got "corrected" in r10931). svn:r10964	2007-07-29 04:03:25 +00:00
Nick Mathewson	d2adb68ed6	r13963@catbus: nickm \| 2007-07-28 22:53:32 -0400 Add support for signature upload svn:r10962	2007-07-29 02:55:21 +00:00
Roger Dingledine	9895d840f5	When running with dmalloc, dump more stats on hup and exit. svn:r10961	2007-07-29 01:18:00 +00:00
Nick Mathewson	764bde22de	r13960@catbus: nickm \| 2007-07-28 18:14:29 -0400 Start correctly when cached-certs is missing. oops svn:r10957	2007-07-28 22:14:42 +00:00
Nick Mathewson	76a408941c	r13959@catbus: nickm \| 2007-07-28 18:09:56 -0400 Use the correct formula to calculate exit weights. svn:r10956	2007-07-28 22:14:39 +00:00
Nick Mathewson	afe9f33d35	r13956@catbus: nickm \| 2007-07-27 20:09:48 -0400 Better certificate manipulations: extract certificates from incoming votes, forget ones that are very old, and remember to store them on disk. svn:r10954	2007-07-28 00:11:34 +00:00
Nick Mathewson	0d274e1db1	r13952@catbus: nickm \| 2007-07-27 19:18:46 -0400 Weasel noticed that many buffers spend their time with empty 4k, 8k, and 16k memory chunks. Thus, be more aggressive about putting empty chunks on the freelist, regardless of their high water marks. (Also, run buffer_shrink_freelist on the 8k-chunk freelist.) svn:r10953	2007-07-27 23:19:02 +00:00
Nick Mathewson	43f64d09ea	r13951@catbus: nickm \| 2007-07-27 18:39:28 -0400 Make it so we can actually compile with FULL_V1_DIRECTORIES disabled. svn:r10952	2007-07-27 23:18:58 +00:00
Nick Mathewson	f6229d6432	r13950@catbus: nickm \| 2007-07-27 18:15:23 -0400 Wrap bandwidth usage info in another ifdef so we can easily drop it on august 1 when it is time to finalize proposal 104. svn:r10951	2007-07-27 23:18:55 +00:00
Nick Mathewson	0e5d8925d9	r13946@catbus: nickm \| 2007-07-27 16:09:31 -0400 Fix median_int for platforms where sizeof(int)!=sizeof(time_t) svn:r10949	2007-07-27 20:09:37 +00:00
Nick Mathewson	a5477c7bb9	r13944@catbus: nickm \| 2007-07-27 15:52:35 -0400 Fix warnings on platforms where rlim values can be signed. Add an 8k buffer freelist. svn:r10948	2007-07-27 19:53:29 +00:00
Nick Mathewson	bc9a7be943	r13939@catbus: nickm \| 2007-07-27 14:33:22 -0400 When dumping memory usage, list bytes used in buffer memory free-lists. svn:r10947	2007-07-27 18:33:37 +00:00
Nick Mathewson	65cdda20b3	r13938@catbus: nickm \| 2007-07-27 14:26:07 -0400 More code to handle incoming consensus signatures svn:r10946	2007-07-27 18:33:34 +00:00
Nick Mathewson	10f166045b	r13937@catbus: nickm \| 2007-07-27 12:43:36 -0400 Maintain a detached-signatures document along with pending consensus document. Add a dirvote_free_all() to clean up static vars in dirvote.c svn:r10945	2007-07-27 18:33:30 +00:00
Nick Mathewson	a65cea38d2	r13936@catbus: nickm \| 2007-07-27 12:23:26 -0400 Code to implement detached signature documents. svn:r10944	2007-07-27 18:33:28 +00:00
Peter Palfrader	1f4275451b	Resolve a compiler warning about uninitialized use svn:r10940	2007-07-27 01:10:23 +00:00
Nick Mathewson	eed888a2b7	r13927@catbus: nickm \| 2007-07-26 17:26:49 -0400 Fix router_choose_by_bandwidth to no longer be biases by floating-point roundoff issues. This runs through the list of routers yet another time, and uses an additional bitfield, but this should be okay: the function did not appear in profiles before, and shouldnt start appearing now. svn:r10939	2007-07-26 21:26:57 +00:00
Nick Mathewson	b1c873182d	r13926@catbus: nickm \| 2007-07-26 17:21:06 -0400 Add a bit-array type with reasonably fast inline functions. svn:r10938	2007-07-26 21:26:53 +00:00
Nick Mathewson	6c4864f351	r13924@catbus: nickm \| 2007-07-26 16:46:45 -0400 We can have multiple authority certificates for an authority at a time: make the code reflect that. svn:r10937	2007-07-26 20:49:04 +00:00
Nick Mathewson	fb2f3c035b	r13921@catbus: nickm \| 2007-07-26 16:26:48 -0400 Code to add signatures to a pending consensus directory. svn:r10936	2007-07-26 20:26:59 +00:00
Nick Mathewson	189bc7cf9f	r13920@catbus: nickm \| 2007-07-26 16:25:25 -0400 whitespace fixes svn:r10935	2007-07-26 20:26:53 +00:00
Nick Mathewson	7f3e2378b6	r13908@catbus: nickm \| 2007-07-25 18:55:47 -0400 Patch from Robert Hogan: set conn->dns_server_port correctly so that we can close dns server ports when they change, thus avoiding crashes and dangling references and other sources of unhappiness. svn:r10933	2007-07-25 22:57:07 +00:00
Nick Mathewson	025a81fc18	r13907@catbus: nickm \| 2007-07-25 18:51:25 -0400 Patch from tup: translate LFs to CRLFs in NS replies and ensures the data section is properly terminated with "\r\n.\r\n svn:r10932	2007-07-25 22:57:02 +00:00
Nick Mathewson	a8821e2d82	r13905@catbus: nickm \| 2007-07-25 18:48:44 -0400 ADDRMAP events should never have specified local time. Extend them to have the proper gmt time, and make GETINFO address-mappings always do the right thing (since it is new in this version). svn:r10930	2007-07-25 22:56:54 +00:00
Nick Mathewson	47f3a40900	r13904@catbus: nickm \| 2007-07-25 18:04:46 -0400 Fix whitespaces and compilation in and around dirvote code. svn:r10929	2007-07-25 22:56:50 +00:00
Nick Mathewson	2305c2c7be	r13903@catbus: nickm \| 2007-07-25 18:03:56 -0400 Make buffer large enough to hold ip6.arpa addresses. This code was not actually used yet, so no user-visible bug existed. (Based on patch by croup.) svn:r10928	2007-07-25 22:56:47 +00:00
Nick Mathewson	a66f259354	r13902@catbus: nickm \| 2007-07-25 17:43:52 -0400 Some dirvote code to handle generating votes and slinging them around. More code is still needed. svn:r10927	2007-07-25 22:56:44 +00:00
Nick Mathewson	1b7a704c34	r13901@catbus: nickm \| 2007-07-25 16:23:51 -0400 Make all code to generate v1 directories into conditional code. svn:r10926	2007-07-25 22:56:40 +00:00
Nick Mathewson	83fa843663	r13900@catbus: nickm \| 2007-07-25 16:16:30 -0400 Better fix for GCC 4.2 warning on routerlist.c svn:r10925	2007-07-25 22:56:34 +00:00
Nick Mathewson	1b24067395	r13773@kushana: nickm \| 2007-07-23 00:16:44 -0400 Use tor malloc replacements in eventdns.c for now: there might be goblins there...goblins that only dmalloc can find! svn:r10912	2007-07-23 04:18:20 +00:00
Nick Mathewson	4d2f45978f	r13875@catbus: nickm \| 2007-07-22 18:56:30 -0400 Once more with feeling. svn:r10907	2007-07-22 22:56:33 +00:00
Nick Mathewson	6640fdeeee	r13872@catbus: nickm \| 2007-07-22 18:51:02 -0400 esc_router_info static field should not be cleared postfork, to avoid races. svn:r10906	2007-07-22 22:51:07 +00:00
Nick Mathewson	701fce8e5c	r13858@catbus: nickm \| 2007-07-22 18:44:02 -0400 Fix/note some relatively trivial mem usage issues svn:r10905	2007-07-22 22:49:49 +00:00
Roger Dingledine	0104882e9b	dump dmalloc stats on sighup svn:r10903	2007-07-22 07:05:43 +00:00
Roger Dingledine	5190916670	free a small static string on exit. svn:r10902	2007-07-22 06:32:28 +00:00
Roger Dingledine	e96d807db4	Revert part of r10874, since it was breaking our load balancing (we always picked one router past the one we wanted!) and could conceivably read past the end of the smartlist too. Nick, I don't know what gcc 4.2 was worried about, but we need to find a better fix than this. :) svn:r10901	2007-07-22 04:36:33 +00:00
Roger Dingledine	6fc336d217	handle fetching bridge descriptors from the bridge authority too. svn:r10898	2007-07-22 00:16:48 +00:00
Roger Dingledine	56d3119581	Directory authorities now call routers Fast if their bandwidth is at least 100KB/s, and consider their bandwidth adequate to be a Guard if it is at least 250KB/s. This fix complements proposal 107. [Bugfix on 0.1.2.x] svn:r10897	2007-07-21 23:40:55 +00:00
Roger Dingledine	a916e07ea6	when requesting tor/server/authority, ask for tor/server/authority.z instead. same functionality, saves a bit of bandwidth. and might even work. svn:r10896	2007-07-21 22:04:18 +00:00
Nick Mathewson	6223160ab7	r13848@catbus: nickm \| 2007-07-19 16:47:16 -0400 Use our own version of inet_ntop and inet_pton everywhere, to avoid partitioning attacks. svn:r10888	2007-07-19 20:47:18 +00:00
Nick Mathewson	3015129a4a	r13846@catbus: nickm \| 2007-07-19 16:31:41 -0400 Actually, OSX (and some BSDs) accept [f:f:f:f:f:f:f:f::] as a perfectly fine ipv6 address. svn:r10887	2007-07-19 20:31:43 +00:00
Nick Mathewson	31a73c0767	r13844@catbus: nickm \| 2007-07-19 16:04:04 -0400 Same as the last patch, only more so. svn:r10886	2007-07-19 20:04:05 +00:00
Nick Mathewson	00420bd084	r13842@catbus: nickm \| 2007-07-19 16:02:54 -0400 OSX writes ::3 as ::0.0.0.3; choose a less ambiguous example. svn:r10885	2007-07-19 20:02:56 +00:00
Nick Mathewson	a1f4644a94	r13840@catbus: nickm \| 2007-07-19 16:00:43 -0400 Apparently, this problem can occur on the whole BSD family. "Yay." svn:r10884	2007-07-19 20:00:45 +00:00
Nick Mathewson	4a240552c4	r13834@catbus: nickm \| 2007-07-19 15:40:42 -0400 Another patch from croup: drop support for address masks that do not correspond to bit prefixes. Nobody has used this for a while, and we have given warnings for a long time. svn:r10881	2007-07-19 19:40:45 +00:00
Nick Mathewson	bbbf504281	r13827@catbus: nickm \| 2007-07-19 14:42:25 -0400 Merge in some generic address manipulation code from croup. Needs some work. svn:r10880	2007-07-19 18:46:09 +00:00
Nick Mathewson	70aef18db1	r13826@catbus: nickm \| 2007-07-19 12:21:30 -0400 Fix a copy-and-paste error in dirvote.c svn:r10879	2007-07-19 18:46:06 +00:00
Nick Mathewson	5e6f05bc31	r13822@catbus: nickm \| 2007-07-18 16:43:39 -0400 Tweak a couple of loop-related variables to make the gcc 4.2 -Wstrict-overflow warning happy. svn:r10874	2007-07-18 20:46:14 +00:00
Nick Mathewson	d920683718	r13821@catbus: nickm \| 2007-07-18 16:29:17 -0400 Initial code to manipulate vote timing correctly. svn:r10873	2007-07-18 20:46:12 +00:00
Nick Mathewson	4a9d4c2c5c	r13820@catbus: nickm \| 2007-07-18 16:07:30 -0400 Whitespace fix on r10849 svn:r10872	2007-07-18 20:46:10 +00:00
Peter Palfrader	3052bf6a84	Change routerlist_remove to not take an index argument we do not need anyway. Now the only remaining caller of _routerlist_find_elt is an assert() svn:r10869	2007-07-18 14:02:47 +00:00
Roger Dingledine	50487c249d	timeout and retry schedules for fetching bridge descriptors svn:r10867	2007-07-18 10:06:03 +00:00
Roger Dingledine	5c4d86f512	using fascistfirewall and having your bridge on an unreachable port silently didn't mix. now they loudly don't mix. svn:r10862	2007-07-18 07:13:15 +00:00
Nick Mathewson	670db47e1b	r13801@catbus: nickm \| 2007-07-17 13:49:12 -0400 More tweaks to dir-spec.txt; not complete, but closing in. svn:r10856	2007-07-17 17:49:16 +00:00
Roger Dingledine	a1ab2c8087	free bridge list on exit; try harder to free buffer freelists on exit. svn:r10854	2007-07-17 11:33:38 +00:00
Roger Dingledine	b7e4683ff9	bugfix on r10086: We had accidentally labelled 0.1.2.x directory servers as not suitable for begin_dir requests, and had labelled no directory servers as suitable for uploading extra-info documents. [Bugfix on 0.2.0.1-alpha] svn:r10853	2007-07-17 09:37:00 +00:00
Roger Dingledine	fcbb817db5	free another string, and the buffer freelists, on exit. svn:r10851	2007-07-17 09:26:45 +00:00
Roger Dingledine	ccfda2e3a3	a few fixes for bug 463. needs a changelog. might need more fixes. svn:r10849	2007-07-17 02:53:17 +00:00
Nick Mathewson	ad45ddfb07	r13788@catbus: nickm \| 2007-07-16 14:26:25 -0400 Patch from croup: rewrite the logic of get_next_token() to do the right thing with input that ends at weird places, or aligns with block boundaries after mmap. should fix bug 455. Needs fuzzing. svn:r10847	2007-07-16 18:26:31 +00:00
Nick Mathewson	6e9f1f76f2	r13784@catbus: nickm \| 2007-07-16 13:27:32 -0400 Apply patch from tup: remove extra space at the end of some circuit-status events, and stop translating CRLF to CRCRLF in control replies. svn:r10845	2007-07-16 17:27:35 +00:00
Nick Mathewson	26a25edaec	r13777@catbus: nickm \| 2007-07-16 12:58:08 -0400 Patch from tup: new address-mappings/ GETINFO that includes expiry times. svn:r10844	2007-07-16 16:58:11 +00:00
Nick Mathewson	483c1e9017	r13774@catbus: nickm \| 2007-07-16 12:23:28 -0400 Tweaks on constrained socket buffers patch from coderman: Add a changelog; rename some variables; fix some long lines and whitespace; make ConstrainedSockSize a memunit; pass setsockopt a void. svn:r10843	2007-07-16 16:23:36 +00:00
Nick Mathewson	f4a6673758	r13773@catbus: nickm \| 2007-07-16 11:58:25 -0400 Initial "constrained socket buffers" patch from coderman. needs tweaking. svn:r10842	2007-07-16 16:23:34 +00:00
Roger Dingledine	6d2cb32d10	free some more memory on exit svn:r10837	2007-07-16 04:33:47 +00:00
Roger Dingledine	4b719cbae0	stop reading uninitialized/outofbounds memory. possible backport, quite related to bug 455. svn:r10835	2007-07-16 03:39:21 +00:00
Roger Dingledine	98ce45bebf	Backport candidate: Fix a potential crash bug when we load many server descriptors at once and some of them make others of them obsolete. Fixes bug 458. [Bugfix on 0.1.2.x] svn:r10832	2007-07-16 00:11:03 +00:00
Roger Dingledine	5ab3f49d93	backport candidate: fix a memory leak from r9039 which had us leaking 50ish bytes every time we rebuild the cached-router files. svn:r10830	2007-07-15 08:34:32 +00:00
Roger Dingledine	2c2f7ee6a4	fix a memory leak from r10504 (i think) svn:r10829	2007-07-15 08:11:56 +00:00
Peter Palfrader	2ce1cb22bd	Comment one tor_assert svn:r10820	2007-07-12 17:37:47 +00:00
Roger Dingledine	ef6bc1a451	Keep streamids from different exits on a circuit separate. This bug may have allowed other routers on a given circuit to inject cells into streams. Reported by lodger; fixes bug 446. [Bugfix on 0.1.2.x] svn:r10818	2007-07-12 17:09:19 +00:00
Nick Mathewson	656b7761a8	r13730@catbus: nickm \| 2007-07-12 12:32:40 -0400 Patch from lodger: avoid roundoff-error-induced crash bugs when picking routers by bandwidth. Also, remove listed backports for 0.1.2.x; that list is now in TODO.012 svn:r10812	2007-07-12 16:34:45 +00:00
Peter Palfrader	9ed261cd6a	In router_add_to_routerlist() only call router_have_minimum_dir_info() under some circumstances, not always svn:r10799	2007-07-12 15:57:23 +00:00
Roger Dingledine	9bf23e0598	backport candidate: When sending destroy cells from a circuit's origin, don't include the reason for tearing down the circuit. The spec says we didn't, and now we actually don't. Reported by lodger. [Bugfix on 0.1.2.x] svn:r10790	2007-07-11 03:37:45 +00:00
Roger Dingledine	83e8d8d9b9	clean up a comment svn:r10789	2007-07-11 03:28:12 +00:00
Nick Mathewson	39dc589d32	r13691@catbus: nickm \| 2007-07-10 18:44:30 -0400 Fix an assert error in 455 patch. svn:r10788	2007-07-10 22:44:32 +00:00
Nick Mathewson	fa1376014b	r13689@catbus: nickm \| 2007-07-10 17:46:30 -0400 tweaks to last patch. from croup. svn:r10787	2007-07-10 21:46:33 +00:00
Nick Mathewson	7e20fdbefb	r13687@catbus: nickm \| 2007-07-10 16:08:14 -0400 Possible partial fix for bug 455: use eos logic everywhere. svn:r10786	2007-07-10 20:08:18 +00:00
Nick Mathewson	d6ba1c3d96	r13676@catbus: nickm \| 2007-07-10 13:41:24 -0400 Man. I thought I removed that code. svn:r10785	2007-07-10 17:41:26 +00:00
Nick Mathewson	a8465adaa2	r13667@catbus: nickm \| 2007-07-10 13:12:52 -0400 Patch from tup: add GETINFO status/enough-dir-info svn:r10782	2007-07-10 17:14:55 +00:00
Nick Mathewson	74711479eb	r13666@catbus: nickm \| 2007-07-10 13:10:00 -0400 Get the RESOLVE controller code working. svn:r10781	2007-07-10 17:14:51 +00:00
Nick Mathewson	7705314777	r13637@catbus: nickm \| 2007-07-06 14:24:27 -0400 fix copy-paste error in config message src/or/config.c . Apply initial (but pared-down) version of launch-resolve-via-controller patch from Robert Hogan. svn:r10780	2007-07-10 17:13:24 +00:00
Nick Mathewson	10e5ed1a84	r13602@Kushana: nickm \| 2007-07-07 23:44:24 -0400 Backport candidate: fix a possible buffer overrun when using natd support on old BSDs. Based on a patch from "Mr. Croup". svn:r10760	2007-07-08 03:45:47 +00:00
Peter Palfrader	db3a4bf897	Call router_have_minimum_dir_info() at the beginning of router_add_to_routerlist() since it has side effects svn:r10754	2007-07-06 21:21:09 +00:00
Peter Palfrader	39b1a11f8d	Remove two arguments from routerlist_replace(). idx, which is the old router's index in the routerlist, can be gotten from the old routerinfo itself anyway, and make_old always was true. (There only is one caller of routerlist_replace()) svn:r10753	2007-07-06 18:40:39 +00:00
Nick Mathewson	e6ba07f8f5	r13634@catbus: nickm \| 2007-07-06 14:20:50 -0400 Fix a crash bug (the crash bug?) on authorities. Backport candidate. svn:r10752	2007-07-06 18:20:54 +00:00
Nick Mathewson	92b6e09082	r13633@catbus: nickm \| 2007-07-06 11:08:19 -0400 Call tor_init_threads() from tor_init(). svn:r10751	2007-07-06 18:20:52 +00:00
Nick Mathewson	04c9ae8164	r13453@kushana: nickm \| 2007-06-20 10:01:37 -0400 Fix a type error in the last checkin. svn:r10738	2007-07-05 14:50:13 +00:00
Nick Mathewson	b5c8a6183a	r13452@kushana: nickm \| 2007-06-20 09:52:55 -0400 Patch from Robert Hogan: Generate STREAM NEW events for dnsport requests and tunneled directory connections. Log when we are testing for hijacking. svn:r10737	2007-07-05 14:50:05 +00:00
Roger Dingledine	99bfb1bebe	If there's a never-before-connected-to guard node in our list, never choose any guards past it. This way we don't expand our guard list unless we need to. [Bugfix in 0.1.2.x] I'm not sure if this will solve all our problems, but it is at least something. svn:r10730	2007-07-02 22:15:26 +00:00
Roger Dingledine	5c1daed3ad	the non-controversial changes i found in my sandbox svn:r10729	2007-07-02 22:07:53 +00:00
Nick Mathewson	32b165ab61	r13604@catbus: nickm \| 2007-07-02 16:58:40 -0400 Some temporary output to try to figure out where bsd thread unit tests are going wrong svn:r10728	2007-07-02 21:08:03 +00:00
Peter Palfrader	64f4cff192	I so wonder how this blows up on the real network - make _routerlist_find_elt be strict about the idx it is passed - if it is not -1 then it has to be correct svn:r10727	2007-07-02 20:17:12 +00:00
Peter Palfrader	d071df748a	If we want to be more strict in _routerlist_find_elt I better call it properly svn:r10726	2007-07-02 20:04:26 +00:00
Peter Palfrader	ccefd7404e	Don't get private with smartlists when there's a perfectly fine accessor method for num_used svn:r10724	2007-07-02 19:45:44 +00:00
Peter Palfrader	ea1348360e	Three more assertions which hopefully are sane, Nick? They might help track down #417 . svn:r10720	2007-07-02 15:13:52 +00:00
Nick Mathewson	8bebff3deb	r13568@catbus: nickm \| 2007-06-30 15:18:18 -0400 allow test_threads() to time out svn:r10711	2007-06-30 19:18:28 +00:00
Nick Mathewson	25a11bf8aa	r13555@catbus: nickm \| 2007-06-30 14:05:36 -0400 Split "Util" tests into subgroups so I can see why freebsd trunk is failing. svn:r10710	2007-06-30 18:06:00 +00:00
Nick Mathewson	a8a880e418	r13480@catbus: nickm \| 2007-06-17 14:39:42 -0400 Oops; forgot to save a file in the last batch. svn:r10646	2007-06-17 18:41:03 +00:00
Nick Mathewson	5adfa09fce	r13477@catbus: nickm \| 2007-06-17 14:22:03 -0400 Sun CC likes to give warnings for the do { } while(0) construction for making statement-like macros. Define STMT_BEGIN/STMT_END macros that do the right thing, and use them everywhere. svn:r10645	2007-06-17 18:22:39 +00:00
Nick Mathewson	93f32db438	r13476@catbus: nickm \| 2007-06-17 14:04:41 -0400 Build with fewer compiler warnings on Sun. (This and previous Sun patches are thanks to the tremendously handy services of unix-center.net.) svn:r10644	2007-06-17 18:22:35 +00:00
Nick Mathewson	99792df645	r13473@catbus: nickm \| 2007-06-17 13:42:36 -0400 Fix solaris eventdns.c behavior. This time, I think I got it. We were redefining _FILE_OFFSET_BITS, and thereby calling fstat64() on a struct stat, or something like that. svn:r10643	2007-06-17 17:43:25 +00:00
Nick Mathewson	721899a447	r13471@catbus: nickm \| 2007-06-17 11:59:25 -0400 Report address and por correctly on requests to dnsport. (Patch from Robert Hogan.) svn:r10641	2007-06-17 15:59:27 +00:00
Nick Mathewson	d828915136	r13463@catbus: nickm \| 2007-06-17 11:10:17 -0400 Add a SOURCE_ADDR field to STREAM NEW events so that controllers can match requests to applications. (Patch from Robert Hogan.) svn:r10639	2007-06-17 15:10:51 +00:00
Nick Mathewson	3df7fc5e5a	r13438@catbus: nickm \| 2007-06-15 15:01:42 -0400 document some functions svn:r10637	2007-06-17 15:10:43 +00:00
Nick Mathewson	9e944d07f8	r13418@catbus: nickm \| 2007-06-14 13:29:21 -0400 Adjust networkstatus_compute_consensus to take an argument saying how many voters there _should_ be. svn:r10634	2007-06-17 15:10:23 +00:00
Roger Dingledine	237cdfdf48	if we already have a bridge in our state file, it won't be in the networkstatuses, so we'll mark it unusable when we load it, and then when we get a new routerinfo for it, we'll still think it's unusable. fix that. svn:r10612	2007-06-15 18:32:27 +00:00
Roger Dingledine	07ff5c6785	bugfix on r10609: don't fail asserts when closing circuits that were connected to an unkeyed connection. svn:r10611	2007-06-15 16:21:40 +00:00
Roger Dingledine	2cd293dc8f	now we can specify a bridge without specifying its key, and we will still connect to it and use it. getting closer! svn:r10609	2007-06-15 06:01:04 +00:00
Roger Dingledine	6a2f045163	extra points for making the function name reflect what it does svn:r10608	2007-06-15 04:23:36 +00:00
Roger Dingledine	73f7310d9b	Directories no longer return a "304 not modified" when they don't have the networkstatus the client asked for. Also fix a memory leak when returning 304 not modified. [Bugfixes on 0.2.0.2-alpha] svn:r10607	2007-06-15 04:20:51 +00:00
Roger Dingledine	9f9ee13dc0	point out a bug in our If-Modified-Since handling in 0.2.0.2-alpha. svn:r10605	2007-06-15 03:14:02 +00:00
Roger Dingledine	3d641bde0e	Refine r10571: more work on bridge stuff. - Only listen to responses for "authority" fetches if we're configured to use Bridges. Otherwise it's safe (and maybe smarter) to silently discard them like we used to. - React faster to download networkstatuses after the first bridge descriptor arrives. - Don't do dir fetches before we have any bridges, even when our dirport is open. svn:r10604	2007-06-15 02:12:15 +00:00
Nick Mathewson	9a74e881ef	r13413@catbus: nickm \| 2007-06-13 18:44:28 -0400 Non-static inline functions cant talk about static variables. svn:r10599	2007-06-13 22:44:30 +00:00
Nick Mathewson	649a802322	r13409@catbus: nickm \| 2007-06-13 18:01:56 -0400 Test the remainder of the contents of the consensus; fix a bug in geneating addresses on routerstatuses. svn:r10597	2007-06-13 22:39:08 +00:00
Nick Mathewson	c2ea3e9aea	r13406@catbus: nickm \| 2007-06-13 17:05:30 -0400 Oops; linked connections get read/write events too. svn:r10596	2007-06-13 21:05:32 +00:00
Nick Mathewson	6462683669	r13403@catbus: nickm \| 2007-06-13 16:15:44 -0400 Test all of consensus contents, except for routerstatus_list contents. And signatures. svn:r10593	2007-06-13 20:17:27 +00:00
Nick Mathewson	4b162fd1f4	r13401@catbus: nickm \| 2007-06-13 15:50:16 -0400 Add dnsport connection to the global connection list. (Bug found by mwenge.) svn:r10592	2007-06-13 19:50:18 +00:00
Nick Mathewson	eab7c6890d	r13399@catbus: nickm \| 2007-06-13 15:17:44 -0400 Hm. Tor should never need private authority identity keys; thus, I should not actually load the authority identity keys for testing. svn:r10591	2007-06-13 19:17:46 +00:00
Nick Mathewson	3fa9a90243	r13396@catbus: nickm \| 2007-06-13 15:06:18 -0400 Set vote_digest field prproperly in networkstatus_vote_t, so that it gets conveyed to the consensus correctly. svn:r10590	2007-06-13 19:06:26 +00:00
Nick Mathewson	c3626cdba7	r13395@catbus: nickm \| 2007-06-13 15:01:23 -0400 Unit tests and debugging for generating and parsing consensus networkstatus documents. Still need to test actual contents. svn:r10589	2007-06-13 19:06:23 +00:00
Nick Mathewson	05cf945a1c	r13393@catbus: nickm \| 2007-06-13 14:29:14 -0400 More vote unit tests: check that we are parsing routerstatuses correctly. svn:r10588	2007-06-13 18:29:16 +00:00
Nick Mathewson	0cf38ddef6	r13387@catbus: nickm \| 2007-06-13 14:15:49 -0400 Unit tests and debugging for vote generation and parsing code. svn:r10587	2007-06-13 18:16:05 +00:00
Nick Mathewson	09a370e45f	r13386@catbus: nickm \| 2007-06-13 14:15:20 -0400 New helper file for test.c: contains 3 generated certs, signing keys, and id_keys svn:r10586	2007-06-13 18:16:01 +00:00
Roger Dingledine	af658b7828	More work towards making bridge users able to connect via bridges: - demand options->Bridges and options->TunnelDirConns if options->UseBridges is set. - after directory fetches, accept descriptors that aren't referenced by our networkstatuses, if they're for a configured bridge. - delay directory fetching until we have at least one bridge descriptor. - learn how to build a one-hop circuit when we have neither routerinfo nor routerstatus for our destination. - teach directory connections how to pick a bridge as the destination directory when doing non-anonymous fetches. - tolerate directory commands for which the dir_port is 0. - remember descriptors when the requested_resource was "authority", rather than just ignoring them. - put bridges on our entry_guards list once we have a descriptor for them. When UseBridges is set, only pick entry guards that are bridges. Else vice versa. svn:r10571	2007-06-12 09:17:23 +00:00
Peter Palfrader	c0b28adc65	Resetting the correct stats svn:r10569	2007-06-12 01:09:53 +00:00
Nick Mathewson	a21381affa	r13364@catbus: nickm \| 2007-06-11 20:15:53 -0400 Stop assuming that desc_by_eid_map works: in fact, it kinda doesn't. Add a big comment explaining why. svn:r10567	2007-06-12 00:15:55 +00:00
Peter Palfrader	f621513cad	Remove an #undef, so you can -Ddefine stuff on the command line svn:r10564	2007-06-11 22:32:30 +00:00
Nick Mathewson	367a77459a	r13355@catbus: nickm \| 2007-06-11 18:19:34 -0400 Make all the digestmaps inside routerlist_t use the new typechecking wrappers, so we can catch any more bugs like the one fixed by 10561. This turned up a bug in routerlist_remove: we were extracting a routerinfo_t from desc_digest_map. Fix that too, though it was probably harmless, since we were only doing a pointer comparison with it. svn:r10563	2007-06-11 22:19:40 +00:00
Nick Mathewson	bde82e737b	r13352@catbus: nickm \| 2007-06-11 17:42:45 -0400 Since desc_by_eid_map hold server descriptors, do not add routerinfo_ts. Bug found by weasel svn:r10561	2007-06-11 21:42:48 +00:00
Peter Palfrader	e91cab20dd	Reorder routerlist_assert_ok() and routerlist_check_bug_417(), so if the assert_ok triggers we know that our bug_417 is wrong svn:r10560	2007-06-11 19:46:23 +00:00
Nick Mathewson	932f2c79eb	r13338@catbus: nickm \| 2007-06-10 15:13:32 -0400 Fix bug in 10533: put "opt v" line at the end of a routerstatus section; overwriting is bad. svn:r10549	2007-06-10 19:13:40 +00:00
Roger Dingledine	04995f197d	more building blocks towards being able to fetch bridge descriptors svn:r10548	2007-06-10 07:34:21 +00:00
Roger Dingledine	1ae7708ff8	discard the "bridge list" stubs that i hope i never need. svn:r10547	2007-06-10 00:30:14 +00:00
Roger Dingledine	a97c3b8c2d	Be clearer on the various roles for auth dir types. Bridge authorities no longer write bridge descriptors to their cached-routers file -- this gets complex because of extrainfo documents. svn:r10545	2007-06-09 07:05:19 +00:00
Roger Dingledine	8dfde75ef6	don't complain when approved-routers isn't there and we don't need it. svn:r10544	2007-06-09 05:28:11 +00:00
Roger Dingledine	eebeda2c71	scrub out some more references to the misnamed 'bridge' concept svn:r10543	2007-06-09 05:17:33 +00:00
Nick Mathewson	19389a3674	r13328@catbus: nickm \| 2007-06-08 17:14:55 -0400 Arg. Irix apparently #defines sa_family to something. Thus, naming fields or variables "sa_family" will not work. svn:r10541	2007-06-08 21:14:58 +00:00
Nick Mathewson	1d6db7ec3d	r13325@catbus: nickm \| 2007-06-08 15:02:37 -0400 Parse networkstatuses (v2, vote, and consensus) after generating them, and fail fast if there is a parse error. svn:r10540	2007-06-08 19:02:39 +00:00
Nick Mathewson	2bb7005481	r13317@catbus: nickm \| 2007-06-08 14:39:59 -0400 bugfix: we were undercounting the number of authorities that recommended any given version by 1. Backport candidate. svn:r10537	2007-06-08 18:41:19 +00:00
Nick Mathewson	678110570a	r13315@catbus: nickm \| 2007-06-08 14:33:24 -0400 Make versions get added to networkstatuses correctly again. svn:r10535	2007-06-08 18:41:14 +00:00
Nick Mathewson	171969656c	r13314@catbus: nickm \| 2007-06-08 14:30:31 -0400 Enfore that known_flags in networkstatus votes must be unique. svn:r10534	2007-06-08 18:41:12 +00:00
Nick Mathewson	7a6f3cd223	r13313@catbus: nickm \| 2007-06-08 14:23:11 -0400 Refactor v3 vote generation code into "build a networkstatus_vote_t" and "format a networkstatus_vote_t". This should make testing possible. svn:r10533	2007-06-08 18:41:09 +00:00
Nick Mathewson	1b200de0ef	r13304@catbus: nickm \| 2007-06-07 13:25:37 -0400 Deprecate RedirectExits. svn:r10526	2007-06-07 17:26:19 +00:00
Nick Mathewson	529cbe34b0	r13292@catbus: nickm \| 2007-06-06 17:34:15 -0400 Check for non-standard SVK directories properly. Inspired by debian bug #420899 and related discussion on SVK list. svn:r10522	2007-06-07 16:14:55 +00:00
Roger Dingledine	8db1b61a26	avoid leaking memory in a path never followed. pointed out by robert watson. svn:r10521	2007-06-07 15:07:33 +00:00
Nick Mathewson	6673d445f5	r13283@catbus: nickm \| 2007-06-06 01:43:44 -0400 Fix up a couple of loops flagged by -Wunsafe-loop-optimizations so that they are more readable (and more amenable to compilation) svn:r10513	2007-06-06 13:02:22 +00:00
Nick Mathewson	1a29d68081	r13276@catbus: nickm \| 2007-06-05 19:45:33 -0400 Remove another long-dead #if 0 I missed before svn:r10511	2007-06-06 04:51:33 +00:00
Nick Mathewson	d3b140b0de	r13275@catbus: nickm \| 2007-06-05 19:11:05 -0400 Apply my sekrit "unused macro detector" script to hunt down some macros we didnt use. svn:r10510	2007-06-06 04:51:30 +00:00
Nick Mathewson	1866ad3506	r13274@catbus: nickm \| 2007-06-05 19:06:30 -0400 Remove some deadcode that seems unlikely to return svn:r10509	2007-06-06 04:51:25 +00:00
Nick Mathewson	0a27f02b9c	r13267@catbus: nickm \| 2007-06-05 16:54:20 -0400 Man page and small tweaks for last patch. svn:r10505	2007-06-05 20:54:53 +00:00
Nick Mathewson	210beff55a	r13266@catbus: nickm \| 2007-06-05 16:38:08 -0400 Patch from peter palfrader: control interface via unix domain socket svn:r10504	2007-06-05 20:54:49 +00:00
Nick Mathewson	f0345d46f6	r13256@catbus: nickm \| 2007-06-05 10:57:41 -0400 Mark fields that need to be ipv6-ified. svn:r10503	2007-06-05 20:54:23 +00:00
Peter Palfrader	b6c6dd7e55	Change an assert into a tor_assert svn:r10495	2007-06-05 01:09:09 +00:00
Nick Mathewson	23ae5976f3	r13254@catbus: nickm \| 2007-06-04 20:13:47 -0400 When choosing a guard, weight by bandwidth. Resolves bug 440. svn:r10493	2007-06-05 00:15:00 +00:00
Nick Mathewson	2e0713222b	r13252@catbus: nickm \| 2007-06-04 18:57:21 -0400 Code to check signatures on consensus directories. svn:r10492	2007-06-04 22:57:23 +00:00
Nick Mathewson	8b0e6a4466	r13250@catbus: nickm \| 2007-06-04 18:28:55 -0400 Adapt code to parse v3 networkstatus votes so it can also parse a consensus. Make networkstatus_vote_t the catch-all type for votes and conensuses. Correct/clarify the second argument to directory-signature. svn:r10491	2007-06-04 22:29:00 +00:00
Nick Mathewson	8d1224eb51	r13248@catbus: nickm \| 2007-06-04 15:53:23 -0400 More code to generate a consensus from a list of votes. Now, we handle Named, and we actually generate and sign the signed consensus. Yippee. Still needs testing. Still not actually called. svn:r10490	2007-06-04 19:54:02 +00:00
Nick Mathewson	bb6f53d60c	r13243@catbus: nickm \| 2007-06-04 15:17:15 -0400 Start of code to compute consensus network-status stuff from a bunch of votes. Strangely, it does not yet feel like an enormous ugly hack. svn:r10489	2007-06-04 19:19:01 +00:00
Peter Palfrader	32d12dcfbc	Fix retry_all_listeners() and retry_listeners() description to match code. We are smarter than comparing lengths of want- and have-listeners. svn:r10487	2007-06-04 16:58:57 +00:00
Peter Palfrader	502879e0b4	Remove force flag from retry_all_listeners() and retry_listeners(). It always was 0. svn:r10486	2007-06-04 16:54:42 +00:00
Roger Dingledine	80e675deb1	Stop tearing down the whole circuit when the user asks for a connection to a port that the hidden service didn't configure. Resolves bug 444. svn:r10478	2007-06-04 03:13:13 +00:00
Nick Mathewson	6d447e04a2	r13189@catbus: nickm \| 2007-06-03 19:08:01 -0400 Oops. Only bind ports and start libevent if we are actually running Tor. svn:r10474	2007-06-03 23:08:07 +00:00
Nick Mathewson	d3ee41619c	r13186@catbus: nickm \| 2007-06-03 19:00:20 -0400 Bind ports before setuid/setgid. svn:r10473	2007-06-03 23:00:26 +00:00
Nick Mathewson	147e439c94	r13174@catbus: nickm \| 2007-06-03 17:39:20 -0400 Patch from robert hogan: avoid crash when DNS port is set more than once. svn:r10471	2007-06-03 21:39:24 +00:00
Nick Mathewson	f4ce7f9c9b	r13166@catbus: nickm \| 2007-06-02 23:02:40 -0400 First cut at code to parse and validate v3 networkstatus votes. svn:r10461	2007-06-03 03:05:10 +00:00
Nick Mathewson	e0d828299a	r13165@catbus: nickm \| 2007-06-02 22:55:22 -0400 Remove an obsoleted function svn:r10460	2007-06-03 03:05:07 +00:00
Roger Dingledine	1407cf9de3	fix up a comment svn:r10453	2007-06-02 20:22:31 +00:00
Nick Mathewson	c2dc8f4623	r13158@catbus: nickm \| 2007-06-02 11:40:05 -0400 On systems with svk, do not clobber micro-revision.i when building from a tarball. svn:r10452	2007-06-02 15:40:10 +00:00
Nick Mathewson	aee7f01624	r13154@catbus: nickm \| 2007-06-02 11:26:44 -0400 Server-side support for If-Modified-Since in HTTP requsts for v1 stuff, and for network-status documents. svn:r10451	2007-06-02 15:26:57 +00:00
Nick Mathewson	8400cecb1d	r13148@catbus: nickm \| 2007-06-02 10:24:20 -0400 Fix bug 441, 442, and possibly 417 (again). svn:r10449	2007-06-02 14:24:23 +00:00
Nick Mathewson	2ef3e7853b	r13144@catbus: nickm \| 2007-06-02 08:44:42 -0400 Add some asserts to catch double-insert on routerlist. svn:r10445	2007-06-02 12:44:57 +00:00
Nick Mathewson	5b6d7f10f3	r13143@catbus: nickm \| 2007-06-01 16:43:40 -0400 Try to fix some mipspro compiler warnings. There will still be some left. svn:r10444	2007-06-02 12:44:54 +00:00
Nick Mathewson	7c3f418e39	r13139@catbus: nickm \| 2007-06-01 14:02:40 -0400 Add some ;trues, and tabify. svn:r10441	2007-06-01 18:02:41 +00:00
Nick Mathewson	6df38f52db	r13137@catbus: nickm \| 2007-06-01 13:49:34 -0400 Ah. Of course. You spell "is there an svn" as 'test -x "`which svn 2>&1`"'. Perfectly reasonable. Don't know why I didn't think of it in the first place. svn:r10440	2007-06-01 17:49:37 +00:00
Nick Mathewson	0af91800f9	r13131@catbus: nickm \| 2007-06-01 06:20:29 -0400 Test for ~/.svk/local, not ~/.svk. Eschew use of test -a and test -o. Bulletproof more against odd shells. svn:r10439	2007-06-01 10:20:37 +00:00
Nick Mathewson	6bb65fa371	r13121@catbus: nickm \| 2007-05-31 20:06:40 -0400 Oops. Different inet_ntop implementations seem to differ on whether, in an IPv6 address with a single "0" word, that word should be written as 0, or omitted. Fix the unit tests to account for that. svn:r10432	2007-06-01 00:06:45 +00:00
Roger Dingledine	b1ee20f0e8	trivial changes from my sandbox svn:r10429	2007-05-31 23:57:46 +00:00
Nick Mathewson	3b4fa59b60	r13117@catbus: nickm \| 2007-05-31 19:40:32 -0400 Patch from Tup: treat RESOLVED_TYPE_ERROR_TRANSIENT as a SERVERFAILED, and RESOLVED_TYPE_ERROR as NOTEXIST. Generate transient/nontransient errors more sensibly. Set flags better on DNS replies. svn:r10427	2007-05-31 23:40:35 +00:00
Nick Mathewson	534c55f531	r13111@catbus: nickm \| 2007-05-31 15:03:41 -0400 Cleanup whitespace. svn:r10425	2007-05-31 19:03:49 +00:00
Nick Mathewson	884cb0c7a1	r13109@catbus: nickm \| 2007-05-31 14:59:30 -0400 More code for voting and vote parsing (checkpointing) svn:r10423	2007-05-31 19:03:44 +00:00
Nick Mathewson	5d4b426a33	r13103@catbus: nickm \| 2007-05-31 14:40:18 -0400 Fix patch r10411; fix from robert hogan. svn:r10422	2007-05-31 18:48:31 +00:00
Nick Mathewson	77502ac82d	r13102@catbus: nickm \| 2007-05-31 13:56:25 -0400 Make "authdir_newdesc rejected" work again. svn:r10421	2007-05-31 18:48:28 +00:00
Nick Mathewson	4061b2cbd1	r13101@catbus: nickm \| 2007-05-31 12:57:42 -0400 Unit tests [and debugging] for tor_inet_ntop() and tor_inet_pton() svn:r10420	2007-05-31 18:48:25 +00:00
Nick Mathewson	1cb1ebbfe0	r13090@catbus: nickm \| 2007-05-30 03:17:57 -0400 If the user makes a torrc that exceeds the bandwidth cap by one byte, let them have it. svn:r10411	2007-05-30 07:18:00 +00:00
Nick Mathewson	8b1e9398a8	r13079@catbus: nickm \| 2007-05-29 17:05:38 -0400 Oops. Authorities should recommend nodes as exits. svn:r10403	2007-05-29 21:05:49 +00:00
Nick Mathewson	4cd93bd9ec	r13071@catbus: nickm \| 2007-05-29 15:54:46 -0400 Aaargh. Revert accidentally-committed debugging code in last patch. svn:r10400	2007-05-29 19:54:54 +00:00
Nick Mathewson	1359871c14	r13070@catbus: nickm \| 2007-05-29 15:53:21 -0400 Fix handling of resolves with very long or otherwise malformed addresses, and comment dns_resolve better, and stop making what should be a BUG warning into an assert(0). This fixes bug 427, which was introduced around 9900/9931/9932. Not a backport candidate: 0.1.2.x never had this bug. svn:r10399	2007-05-29 19:54:51 +00:00
Nick Mathewson	3f9afa0625	r13068@catbus: nickm \| 2007-05-29 14:58:13 -0400 Add some code to mitigate bug 393: Choose at random from multiple hidden service ports with the same virtport. This allows limited ad-hoc round-robining. svn:r10398	2007-05-29 18:58:16 +00:00
Nick Mathewson	c5b3a8db84	r13057@catbus: nickm \| 2007-05-29 14:39:27 -0400 fix for bug 439: make _sure_ *msg is set when we leave dirserv_add_multiple_descriptors(). svn:r10396	2007-05-29 18:39:56 +00:00
Nick Mathewson	9d1af71b70	r13053@catbus: nickm \| 2007-05-29 13:35:33 -0400 Move connection_should_read_from_linked_conn into main.c, which is the only file that uses it. svn:r10394	2007-05-29 18:20:56 +00:00
Nick Mathewson	f89a3b1448	r13050@catbus: nickm \| 2007-05-29 13:31:11 -0400 Resolve all but 3 DOCDOCs. svn:r10393	2007-05-29 17:31:13 +00:00
Nick Mathewson	69c712f189	r13048@catbus: nickm \| 2007-05-29 11:08:53 -0400 Oops; better version of previous patch that does not get caught in an infinite loop. svn:r10391	2007-05-29 15:08:55 +00:00
Nick Mathewson	fd3aa5c85d	r13046@catbus: nickm \| 2007-05-29 11:07:12 -0400 Stop adding bogus entries to lists in router_parse_list_from_string(). I wonder which bugs _that_ caused. svn:r10390	2007-05-29 15:07:16 +00:00
Nick Mathewson	63035cdb33	r13041@catbus: nickm \| 2007-05-29 10:40:05 -0400 More messing around to try to address possible root causes of bug 436. svn:r10388	2007-05-29 14:41:20 +00:00
Nick Mathewson	d509efb9b7	r13019@catbus: nickm \| 2007-05-27 12:32:55 -0400 Merge an evdns fix from libevent r357: "evdns_shutdown fix from adam langley. svn:r10387	2007-05-29 14:41:16 +00:00
Peter Palfrader	3425f2c11f	Segfault less. Somebody needs to look over why exactly this helps. re #436 svn:r10376	2007-05-28 21:34:42 +00:00
Roger Dingledine	c1101fceeb	we were leaking a few megabytes a minute checking signatures svn:r10359	2007-05-27 04:38:50 +00:00
Roger Dingledine	e13bf01a9f	fix a seg fault when my auth dirserver accepted a posted descriptor (dirserv_add_multiple_descriptors doesn't set msg if there's no failure.) svn:r10358	2007-05-27 03:41:09 +00:00
Roger Dingledine	c8fd65a936	If Tor is invoked from something that isn't a shell (e.g. Vidalia), now we expand "-f ~/.tor/torrc" correctly. Suggested by Matt Edman. svn:r10351	2007-05-26 08:04:15 +00:00
Nick Mathewson	b0be93c8b0	r12988@catbus: nickm \| 2007-05-25 20:15:56 -0400 socklen_t is a silly type anyway. Just use int as the argument for evdns_server_request_get_requesting_addr. svn:r10347	2007-05-26 00:15:58 +00:00
Roger Dingledine	0f71ade42f	fix compile on bsd svn:r10339	2007-05-25 21:56:47 +00:00
Roger Dingledine	0c047b87f5	polish r9933-r9994 svn:r10335	2007-05-25 19:41:31 +00:00
Roger Dingledine	a19d131ed7	i suspect we would trigger asserts if we answer a cached resolve request. this should help that. svn:r10334	2007-05-25 19:30:07 +00:00
Roger Dingledine	32f5e19168	remove an obsolete notion that we judge runningness based on whether we have a connection open to the server right now. svn:r10333	2007-05-25 19:22:26 +00:00
Nick Mathewson	368eb6a97a	r12964@catbus: nickm \| 2007-05-25 14:49:23 -0400 hack to make reverse lookups work with dnsport. note that it is a hack. note some trouble spots. svn:r10332	2007-05-25 18:49:26 +00:00
Roger Dingledine	ce59d5a632	also change purpose_is_private to purpose_needs_anonymity svn:r10331	2007-05-25 18:40:09 +00:00
Roger Dingledine	6e216ed7ef	karsten got confused by private_connection, so try calling it anonymized_connection instead. svn:r10330	2007-05-25 18:25:33 +00:00
Nick Mathewson	ba4969a59e	r12959@catbus: nickm \| 2007-05-25 14:22:33 -0400 The second time that we resolve a.com and get 1.2.3.4, return an A record mapping (a->1.2.3.4), not mapping (1.2.3.4->1.2.3.4). svn:r10329	2007-05-25 18:22:43 +00:00
Nick Mathewson	527fbc304e	r12958@catbus: nickm \| 2007-05-25 14:19:29 -0400 Fix more dnsport bugs: set state correctly, and actually cache the answers. svn:r10328	2007-05-25 18:22:42 +00:00
Nick Mathewson	5f226f130c	r12957@catbus: nickm \| 2007-05-25 14:11:02 -0400 Fix a dnsserv bug: mark the connectino as "finished handshaking" once dnsserv_resolved is called. svn:r10327	2007-05-25 18:22:39 +00:00
Nick Mathewson	39fe91b9a2	r12946@catbus: nickm \| 2007-05-25 10:46:50 -0400 Add an AutomapHostsOnResolve option. It seems to work. svn:r10324	2007-05-25 14:48:16 +00:00
Roger Dingledine	7127c30f46	irix64's cc doesn't think hibernate_state_t is necessarily an int. good point. svn:r10320	2007-05-24 23:51:08 +00:00
Roger Dingledine	42d7b0877d	forward-port r10318 svn:r10319	2007-05-24 23:39:04 +00:00
Nick Mathewson	703bf19620	r12942@catbus: nickm \| 2007-05-24 16:31:22 -0400 Well, that was easier than I thought it would be. Tor is now a DNS proxy as well as a socks proxy. Probably some bugs remain, but since it A) has managed to resolve one address for me successfully, and B) will not affect anybody who leaves DNSPort unset, it feel like a good time to commit. svn:r10317	2007-05-24 20:31:30 +00:00
Nick Mathewson	17830bc03b	r12941@catbus: nickm \| 2007-05-24 16:25:00 -0400 Fix some eventdns dns server bugs, and add a new eventdns function to get the address of whoever requested this lookup. svn:r10316	2007-05-24 20:31:27 +00:00
Nick Mathewson	a312afd67e	r12936@catbus: nickm \| 2007-05-24 14:12:34 -0400 Review XXXX comments without a version; upgrade some to XXXX020. svn:r10315	2007-05-24 18:12:52 +00:00
Nick Mathewson	56aefe8d23	r12935@catbus: nickm \| 2007-05-24 14:12:04 -0400 dir-signing-key should never take arguments. svn:r10314	2007-05-24 18:12:44 +00:00
Nick Mathewson	9aaf3d182f	r12934@catbus: nickm \| 2007-05-24 14:11:18 -0400 When freeing slack buffers, free the buffers at the end of the freelist first. svn:r10313	2007-05-24 18:12:41 +00:00
Nick Mathewson	687461d36c	r12920@catbus: nickm \| 2007-05-24 13:12:52 -0400 and remove an XXX012. svn:r10308	2007-05-24 17:13:08 +00:00
Nick Mathewson	212a3c3478	r12919@catbus: nickm \| 2007-05-24 13:04:56 -0400 backport candidate: Warn when using a version of libevent before 1.3b to run a server on osx or bsd: these versions of libevent interact badly with userspace threads. svn:r10307	2007-05-24 17:13:05 +00:00
Nick Mathewson	4c6398a8f0	r12918@catbus: nickm \| 2007-05-24 12:52:40 -0400 Make reset_download_failures() reset extrainfo download status too. svn:r10306	2007-05-24 17:13:02 +00:00
Nick Mathewson	3980ebd6a1	r12917@catbus: nickm \| 2007-05-24 12:48:47 -0400 Put the hash-as-signed, not the raw hash, in the signed_descriptor_digest field of our own descriptor. Backport candidate; probably harmless though. svn:r10305	2007-05-24 17:13:00 +00:00
Nick Mathewson	d3d86b17a7	r12916@catbus: nickm \| 2007-05-24 12:43:45 -0400 Add math functions to round values to the nearest power of 2. Make mempools more careful about making sure that the size of their chunks is a little less than a power of 2, not a little more. svn:r10304	2007-05-24 17:12:57 +00:00
Nick Mathewson	d0a5c4f984	r12915@catbus: nickm \| 2007-05-24 12:12:34 -0400 Do not send a warning when somebody uploads an extrainfo that we will reject, if it happens to be newer than our current routerdesc. svn:r10303	2007-05-24 17:12:54 +00:00
Nick Mathewson	ca9e13f2a0	r12906@catbus: nickm \| 2007-05-22 20:43:13 -0400 s/32/64/; s/breaks/works/; svn:r10297	2007-05-23 00:43:20 +00:00
Roger Dingledine	e583827d60	new ip addresses for moria1 and moria2; new ports for moria2 svn:r10296	2007-05-22 23:51:39 +00:00
Nick Mathewson	38300735cd	r12902@catbus: nickm \| 2007-05-22 14:52:29 -0400 First draft of code to generate votes. needs testing. does not yet upload or serve votes. Shares most of its code with the old generate_v2_networkstatus. svn:r10295	2007-05-22 18:52:32 +00:00
Nick Mathewson	9e0acc0c11	r12899@catbus: nickm \| 2007-05-22 13:51:26 -0400 Extract common code from networkstatus_getinfo_helper_single() and generate_v2_networkstatus(). svn:r10294	2007-05-22 17:58:30 +00:00
Nick Mathewson	c9fa4e6583	r12898@catbus: nickm \| 2007-05-22 13:11:04 -0400 More v3 directory code: have authorities load certificates; have everybody store certificates to disk and load them; provide a way to configure v3 authorities. svn:r10293	2007-05-22 17:58:25 +00:00
Nick Mathewson	6975a093e9	r12853@catbus: nickm \| 2007-05-22 11:36:54 -0400 Make connection_array into a smartlist. svn:r10292	2007-05-22 15:49:14 +00:00
Nick Mathewson	e935d73b34	r12852@catbus: nickm \| 2007-05-22 11:00:27 -0400 Use svn revisions consistently throughout all log messages. svn:r10291	2007-05-22 15:48:46 +00:00
Nick Mathewson	4ec5e139c8	r12850@catbus: nickm \| 2007-05-21 22:20:42 -0400 Partial backport candidate: do not rely on finding a \0 after an mmaped() router/extrainfo file. Also, set journal length correctly when starting up. svn:r10248	2007-05-22 02:20:52 +00:00
Nick Mathewson	d23cb33a1a	r12846@catbus: nickm \| 2007-05-21 21:55:15 -0400 Oops; it is possible to have an empty store. svn:r10247	2007-05-22 01:55:50 +00:00
Nick Mathewson	0cb342e859	r12844@catbus: nickm \| 2007-05-21 21:52:19 -0400 Oops. It compiles better when you spell the fields right. svn:r10245	2007-05-22 01:52:22 +00:00
Nick Mathewson	32c8d94c12	r12842@catbus: nickm \| 2007-05-21 21:51:45 -0400 Partial backport candidate. Fix issue noted in r10241: stores were rebuilt too often. Also notes dropped bytes better. svn:r10244	2007-05-22 01:51:53 +00:00
Roger Dingledine	590a98ff37	clean up r10240 so we avoid the exit node itself too svn:r10242	2007-05-22 01:20:23 +00:00
Roger Dingledine	b89ad9eb1b	mark a bug for nick to tackle -- we're rebuilding our router store more often than we need to. reported by lodger. svn:r10241	2007-05-22 01:17:08 +00:00
Roger Dingledine	6ede110c4d	When choosing an entry guard for our circuit, avoid using guards that are in the same family as the chosen exit -- not just guards that are exactly the chosen exit. (Reported by lodger.) svn:r10240	2007-05-22 01:01:24 +00:00
Roger Dingledine	82054e0dd2	Make the NodeFamilies config option work. (Reported by lodger -- it has never actually worked, even though we added it in Oct 2004.) svn:r10238	2007-05-22 00:46:55 +00:00
Nick Mathewson	de5194eeaa	r13025@Kushana: nickm \| 2007-05-21 17:40:56 -0400 Bugfix and possible backport candidate: use the same logic as in read_all when reading resolv.conf. Maybe this fixes bug 433. svn:r10237	2007-05-21 21:48:02 +00:00
Peter Palfrader	d2f7a9d0cc	Hopefully fix #429 for good by actually using, not just figuring out, the correct mmap svn:r10233	2007-05-21 12:14:45 +00:00
Nick Mathewson	a4f5b99e61	r13023@Kushana: nickm \| 2007-05-20 16:16:36 -0400 More bulletproofing on bug 429 svn:r10231	2007-05-20 20:16:45 +00:00
Nick Mathewson	21a72520ce	r13021@Kushana: nickm \| 2007-05-20 14:03:10 -0400 Provide actual reasons when dropping an uploaded extrainfo for incompatibility; also, clean whitespace. svn:r10230	2007-05-20 18:03:26 +00:00
Nick Mathewson	5364833be0	r13017@Kushana: nickm \| 2007-05-20 13:40:45 -0400 Address points in r10227. svn:r10229	2007-05-20 17:43:55 +00:00
Nick Mathewson	bc26f28865	svn:r10228	2007-05-20 17:43:29 +00:00
Roger Dingledine	ddd0054a85	point out two remote crash bugs, a memory leak, and a few other items we should probably look into. svn:r10227	2007-05-20 14:15:23 +00:00
Nick Mathewson	0b661f6575	r12818@catbus: nickm \| 2007-05-20 01:15:50 -0400 Look for extrainfo bodies in the extrainfo mmap, not in the descriptor mmap. Duh. Should fix bug 429. svn:r10226	2007-05-20 05:15:53 +00:00
Peter Palfrader	6d46ece6ac	Fix a loop in routerlist_assert_ok() svn:r10224	2007-05-19 21:14:17 +00:00
Nick Mathewson	5f58bee0b0	r12812@catbus: nickm \| 2007-05-19 16:17:36 -0400 Fix compilation with -O0; add unit tests for swap and shuffle. svn:r10223	2007-05-19 20:17:37 +00:00
Nick Mathewson	6f8866a817	r12810@catbus: nickm \| 2007-05-19 16:08:42 -0400 Fix bugs in extrainfo_insert, and change it to use desc_by_eid_map. svn:r10222	2007-05-19 20:08:44 +00:00
Nick Mathewson	4d3ec5919e	r12808@catbus: nickm \| 2007-05-19 14:48:51 -0400 Fix another consistency error. svn:r10221	2007-05-19 18:48:53 +00:00
Nick Mathewson	48e30ce2c7	r12805@catbus: nickm \| 2007-05-19 14:31:00 -0400 Fix a groovy memory corruption bug in routerlist_replace. svn:r10220	2007-05-19 18:31:04 +00:00
Nick Mathewson	07199e3d09	r12804@catbus: nickm \| 2007-05-19 14:21:18 -0400 Disable a blatantly incorrect control event with potential for memory corruption. svn:r10219	2007-05-19 18:31:02 +00:00
Nick Mathewson	0a27b53252	r12802@catbus: nickm \| 2007-05-19 14:12:27 -0400 clear some ram when freeing it; add some more checks to assert_routerlist_ok. svn:r10218	2007-05-19 18:12:31 +00:00
Nick Mathewson	58d27cfc29	r12800@catbus: nickm \| 2007-05-18 20:45:15 -0400 Possible fix for bug 417 and bug 404: do not insert our routerinfo directly; instead, re-parse it first. svn:r10217	2007-05-19 00:45:17 +00:00
Nick Mathewson	61a116b3da	r12798@catbus: nickm \| 2007-05-18 20:31:54 -0400 Yet more debugging code to track down 417/404, inspired by a fun core from arma. svn:r10216	2007-05-19 00:32:00 +00:00
Nick Mathewson	adf95e7f00	r12794@catbus: nickm \| 2007-05-18 20:24:26 -0400 Make caches-extra-info lines parseable. svn:r10215	2007-05-19 00:24:29 +00:00
Roger Dingledine	84c3a19170	found this in my sandbox svn:r10214	2007-05-19 00:14:34 +00:00
Nick Mathewson	e476e61ce0	r12982@Kushana: nickm \| 2007-05-18 15:15:14 -0400 Partial backport candidate: We had a bug where we were downloading descriptors by descriptor digest, but trying to look them up by identity fingerprint when updating their failure count and next retry time. (Also use correct backoff logic for extrainfo code.) Needs testing, doubtless. svn:r10210	2007-05-18 21:19:53 +00:00
Nick Mathewson	ec55cf526d	r12981@Kushana: nickm \| 2007-05-18 14:12:19 -0400 First cut at code to download extra-info docs. Also note a bad bug in directory.c (look for the string BUG BUG BUG). svn:r10209	2007-05-18 21:19:19 +00:00
Nick Mathewson	b4bd9f772c	r12771@catbus: nickm \| 2007-05-16 18:12:32 -0400 Make -Wstrict-overflow=5 happy with GCC 4.2. It is kind of a pain, but it does agood job of letting us know where we can make our code better by simplifying dependent conditionals. svn:r10201	2007-05-16 22:16:13 +00:00
Nick Mathewson	2988d797eb	r12770@catbus: nickm \| 2007-05-16 17:49:26 -0400 Move around field order a little, in order to compact some structures. (Thanks to -Wpadded) svn:r10200	2007-05-16 22:15:57 +00:00
Nick Mathewson	807adfc879	r12769@catbus: nickm \| 2007-05-16 17:32:01 -0400 Fix warnings from -Wunsafe-loop-optimizations, which incidentally turned up a logic bug in connection_or_flush_from_first_active_circuit that would overcount the number of cells flushed. svn:r10199	2007-05-16 22:15:48 +00:00
Nick Mathewson	b837191fd0	r12768@catbus: nickm \| 2007-05-16 17:25:33 -0400 Fix GCC warnings related to local parameters/variables getting shadowed. svn:r10198	2007-05-16 22:15:14 +00:00
Nick Mathewson	e043b86f47	r12764@catbus: nickm \| 2007-05-15 17:17:39 -0400 Enable (and cope with) more GCC 4.2 warnings. svn:r10196	2007-05-15 21:17:48 +00:00
Nick Mathewson	bfdc366037	r12763@catbus: nickm \| 2007-05-15 05:29:33 -0400 Make --enable-gcc-warnings happy on the upcoming gcc 4.2 svn:r10195	2007-05-15 21:17:42 +00:00
Nick Mathewson	ca32b4d5b5	r12761@catbus: nickm \| 2007-05-15 03:13:52 -0400 Be a lot smarter when parsing lists of routers and extrainfos. svn:r10193	2007-05-15 07:13:56 +00:00
Nick Mathewson	a7514649c3	r12758@catbus: nickm \| 2007-05-14 15:19:29 -0400 Cleanup, lock-down, and refactor bits of routerparse.c: use a single unified function to check all signatures. Fix all DOCDOCs. Remove some old dead debugging code. Enforce some parsing rules better. svn:r10192	2007-05-14 22:51:05 +00:00
Roger Dingledine	37519d993d	backport candidate: seems to me that r10153 won't work without this patch too. svn:r10187	2007-05-14 08:09:12 +00:00
Nick Mathewson	5f9d4d0587	r12750@catbus: nickm \| 2007-05-13 10:08:13 -0400 Fix compilation in connection_edge.c svn:r10186	2007-05-13 20:24:43 +00:00
Roger Dingledine	440b7f0c70	polish r9726-r9903 svn:r10182	2007-05-13 09:25:06 +00:00
Roger Dingledine	346826d97b	If a directory authority is down, skip it when deciding where to get networkstatus objects or descriptors. Otherwise we keep asking every 10 seconds forever. (adapted from r9880) svn:r10175	2007-05-12 23:22:27 +00:00
Nick Mathewson	11f3e894d3	r12708@catbus: nickm \| 2007-05-10 15:18:08 -0400 Patch from shibz: implement a getinfo status/version/... so a controller can tell whether the current version is recommended, whether any versions are good, and how many authorities agree. svn:r10162	2007-05-10 19:30:02 +00:00
Nick Mathewson	e3b2a7b53b	r12935@Kushana: nickm \| 2007-05-10 11:25:09 -0400 Make buffer unit tests pass again svn:r10158	2007-05-10 15:25:40 +00:00
Roger Dingledine	de11011b1b	backport candidate: when we have k non-v2 authorities in our dirservers lines, we ignored as many as k v2 authorities while updating our network-statuses. (not a problem right now since we have zero non-v2 authorities. but if we ever change that...) svn:r10157	2007-05-10 10:01:53 +00:00
Roger Dingledine	4e9a008e66	Backport candidate: if all of our dirservers have given us bad or no networkstatuses lately, then stop hammering them once per minute even if we think they're failed. svn:r10156	2007-05-10 09:34:34 +00:00
Roger Dingledine	5ffabd4de4	backport candidate: If a directory server runs out of space in the connection table as it's processing a begin_dir request, it will free the exit stream but leave it attached to the circuit, leading to unpredictable behavior. (Reported by seeess, fixes bug 425.) svn:r10154	2007-05-10 08:53:05 +00:00
Roger Dingledine	cd23b65a07	Backport candidate: count it as a failure if we fetch a valid network-status but we don't want to keep it. Otherwise we'll keep fetching it and keep not wanting to keep it. Fixes part of bug 422. svn:r10153	2007-05-10 05:12:20 +00:00
Roger Dingledine	8e8144cd58	fix a printf size_t/int mismatch from r10150 svn:r10152	2007-05-10 04:04:44 +00:00
Roger Dingledine	de6b3512e9	move a few more situations over to the authority_type_t bitfield svn:r10151	2007-05-10 04:01:28 +00:00
Nick Mathewson	34a09c24b5	r12706@catbus: nickm \| 2007-05-09 18:39:46 -0400 Keep two freelists for buffer ram chunks: one of 4k chunks, and one of 16k chunks. Also, document the whole business. svn:r10150	2007-05-09 22:39:49 +00:00
Nick Mathewson	b248ed620f	r12704@catbus: nickm \| 2007-05-09 17:43:34 -0400 Periodically clean the freelist of buffer memory chunks. svn:r10149	2007-05-09 21:43:41 +00:00
Nick Mathewson	ceac39aa8a	r12697@catbus: nickm \| 2007-05-09 00:15:40 -0400 Change authority_type_t to a set of flags; use it more consistently. svn:r10144	2007-05-09 04:15:46 +00:00
Roger Dingledine	66f9240eb5	complain when we try to upload to, say, bridge authorities, yet we didn't configure any first. svn:r10143	2007-05-09 02:20:03 +00:00
Roger Dingledine	07bf274d98	Interim commit: new config options Bridge and UseBridges. It is becoming increasingly clear to me that bridges should be a special case of entry guards, not a whole separate pile of nearly identical functions. svn:r10141	2007-05-08 11:28:05 +00:00
Roger Dingledine	d136f2a7b2	When we are reporting the DirServer line we just parsed, we were logging the second stanza of the key fingerprint, not the first. svn:r10140	2007-05-08 10:33:46 +00:00
Roger Dingledine	54f5ab39b3	record the router purpose at each step of the circuit path. i have the feeling this will come in handy. svn:r10139	2007-05-08 10:11:53 +00:00
Roger Dingledine	1d3bb103a4	clean up some function argument names svn:r10138	2007-05-08 10:01:33 +00:00
Roger Dingledine	a201861dc2	use the new _PublishServerDescriptor to publish descriptors either to v2 authorities or to bridge authorities, depending on config. svn:r10137	2007-05-08 09:13:30 +00:00
Roger Dingledine	e4f40dd794	Change the PublishServerDescriptor config option from a boolean into a string: "v1", "v2", bridge", "". Continue to support "0" and "1". svn:r10136	2007-05-08 09:09:26 +00:00
Nick Mathewson	89753e2163	r12676@catbus: nickm \| 2007-05-07 13:11:38 -0400 When we cannot find a micro-revision number, do not overwrite an already-present micro-revision.i. svn:r10134	2007-05-07 17:11:53 +00:00
Roger Dingledine	95ead29574	prepare directory_post_to_dirservers() to hear what sort of dir authority we'd like to upload to. at some point we should pick a config option to say that in, for bridges. svn:r10129	2007-05-07 09:28:48 +00:00
Roger Dingledine	f8a8b27dd2	add a 'bridge' flag for dirserver config entries svn:r10128	2007-05-07 08:26:50 +00:00
Roger Dingledine	43411ceed3	Implement "getinfo status/circuit-established" svn:r10120	2007-05-05 22:51:02 +00:00
Roger Dingledine	713626bd73	make it work on windows/etc again, i presume svn:r10118	2007-05-04 10:43:01 +00:00
Roger Dingledine	10efbed2f5	ok, i'm not so good at counting svn:r10117	2007-05-04 10:39:17 +00:00
Roger Dingledine	0ce53ca817	on the theory that my client_used hack is here to stay at least for the next little while, make it only take effect _when there's an attached origin circuit_, rather than from the first attached origin circuit until death of the conn. svn:r10116	2007-05-04 10:34:47 +00:00
Roger Dingledine	462dfe2012	make MaxAdvertisedBandwidth into a legal default svn:r10115	2007-05-04 09:25:23 +00:00
Roger Dingledine	b1d93df038	if you're using relaybandwidthrate and relaybandwidthburst, make sure that's reflected in your router descriptor. svn:r10114	2007-05-04 09:20:13 +00:00
Roger Dingledine	dc795203aa	early skeletal support for running a bridge directory authority svn:r10112	2007-05-04 08:04:27 +00:00
Roger Dingledine	d112e7b1ad	fix some code comments, a wrapper, and add a todo item svn:r10111	2007-05-04 07:24:01 +00:00
Roger Dingledine	dfe93fb386	whoops, i missed main.c in my r10092 svn:r10098	2007-05-02 21:56:32 +00:00
Nick Mathewson	e2a49ed2f4	r12639@catbus: nickm \| 2007-05-02 17:37:49 -0400 Start implementing key certificate parsing. Note TODO items for combined 101/103. svn:r10097	2007-05-02 21:37:55 +00:00
Nick Mathewson	da758f4a18	r12634@catbus: nickm \| 2007-05-02 15:13:13 -0400 Shell tweaks suggested by weasel. svn:r10094	2007-05-02 19:13:15 +00:00
Nick Mathewson	744d955bb3	r12632@catbus: nickm \| 2007-05-02 14:59:55 -0400 Fix compilation-breaking r10092. svn:r10093	2007-05-02 18:59:57 +00:00
Roger Dingledine	1b95bbdba6	New config option V2AuthoritativeDirectory that all directory authorities should set. This will let future authorities choose not to serve V2 directory information. Also, go through and revamp all the authdir_mode stuff so it tries to do the right thing if you're an auth but not a V1 or V2 auth. svn:r10092	2007-05-02 09:12:04 +00:00
Nick Mathewson	47d21abf15	r12627@catbus: nickm \| 2007-05-01 16:42:21 -0400 Oops; downgrade a message to INFO. svn:r10090	2007-05-01 20:42:23 +00:00
Nick Mathewson	26abac8c4c	r12625@catbus: nickm \| 2007-05-01 16:41:23 -0400 Remove the _UploadExtraInfo option, since I tried turning it on and moria[12] seem not to have exploded. svn:r10089	2007-05-01 20:41:27 +00:00
Nick Mathewson	979b90001b	r12622@catbus: nickm \| 2007-05-01 16:29:19 -0400 Look at the version in the routerinfo as well as the versino in the networkstatus when deciding whether to upload extrainfo svn:r10088	2007-05-01 20:29:32 +00:00
Nick Mathewson	c9c0d2846d	r12621@catbus: nickm \| 2007-05-01 16:22:56 -0400 Authority patch; backport candidate: include micro-versions in network status documents. svn:r10087	2007-05-01 20:29:26 +00:00
Nick Mathewson	89ab267cfb	r12619@catbus: nickm \| 2007-05-01 16:13:42 -0400 Add code to upload extrainfos to authorities running 0.2.0.0-alpha-dev (r10070) or later. svn:r10086	2007-05-01 20:13:49 +00:00
Nick Mathewson	0faaa16b0c	r12615@catbus: nickm \| 2007-05-01 09:48:45 -0400 Only replace micro-revision.i if it changes. svn:r10085	2007-05-01 13:48:49 +00:00
Nick Mathewson	8f94f0540f	r12611@catbus: nickm \| 2007-04-30 22:49:00 -0400 For reasons which make sense to somebody, I'm sure, mingw gcc wants the libraries to appear at the end of the command line. This is done by specifying them with LDADD in Makefile.am, not LDFLAGS. If anybody can explain to me why mingw thinks "gcc -o foo foo.o -lbar" is fine, whereas "gcc -lbar -o foo foo.o" is Doubleplusbad UnMingwThink, I'd quite appreciate it. Until then, I'll just do what seems to work, and hope we don't blunder across any other great slumbering cthonian deities of arbitrary syntax. svn:r10082	2007-05-01 02:53:32 +00:00
Nick Mathewson	fa39336e65	r12607@catbus: nickm \| 2007-04-30 21:36:28 -0400 More attempt to fix win32 building. This time, with extra linking. svn:r10080	2007-05-01 01:36:32 +00:00
Roger Dingledine	e9c4dd1304	more cleanups on the hsusage patch svn:r10077	2007-04-30 23:25:22 +00:00
Roger Dingledine	590c6ff33d	identify the exit node correctly when we timeout and detach from a circuit, even if the exit node is in the middle. there are probably a few more places that need this fix too. svn:r10076	2007-04-30 23:24:38 +00:00
Nick Mathewson	22f2f30a33	r12591@catbus: nickm \| 2007-04-30 16:50:03 -0400 Minimize the libraries that we link things against: there is no reason to link tor-resolve against zlib, openssl, or libevent, for example. svn:r10072	2007-04-30 20:50:09 +00:00
Nick Mathewson	e97a6dd01f	r12587@catbus: nickm \| 2007-04-30 15:47:39 -0400 Backport candidate: correctly set the purpose of routers that are inserted by the controller with purpose=controller. svn:r10071	2007-04-30 19:48:45 +00:00
Nick Mathewson	0390a0499c	r12586@catbus: nickm \| 2007-04-30 15:43:05 -0400 More work for proposal 104: actually cache extrainfo documents to disk, and reload the cache properly. svn:r10070	2007-04-30 19:48:39 +00:00
Nick Mathewson	ae40e7f633	r12585@catbus: nickm \| 2007-04-30 14:38:37 -0400 (Needs review.) Allow directory authorities to accept multiple router descriptors and extra info documents in a single POST. This will make implementing the client side of proposal 104 a lot simpler. svn:r10069	2007-04-30 19:48:33 +00:00
Nick Mathewson	b27b09ae1e	r12581@catbus: nickm \| 2007-04-30 13:39:21 -0400 Minor cleanups on hidden service usage patch from Karsten: tidy documentation; make free_all idempotent (and safe to call even if we have not yet initialized rephist); and stop using "l" as a variable name (it is too easy to confuse with "1"). svn:r10068	2007-04-30 17:46:19 +00:00
Nick Mathewson	18ba9fe81f	r12580@catbus: nickm \| 2007-04-30 13:29:05 -0400 Initial version of patch from Karsten Loesing: Add an HSAuthorityRecordStats option to track statistics of overall hidden service usage without logging information that would be useful to an attacker. svn:r10067	2007-04-30 17:46:13 +00:00
Nick Mathewson	6875559c49	r12579@catbus: nickm \| 2007-04-30 13:26:53 -0400 Oops. Routerlist_check_bug_417 should work even if we are not on a server. svn:r10066	2007-04-30 17:46:11 +00:00
Nick Mathewson	f2db099fc0	r12571@catbus: nickm \| 2007-04-30 10:51:52 -0400 Check for more HAVE_* header defines when building eventdns.c svn:r10063	2007-04-30 14:52:07 +00:00
Nick Mathewson	ee5a378665	r12570@catbus: nickm \| 2007-04-30 10:49:50 -0400 Add an extra lock to try to get unit tessts passing reliably again. svn:r10062	2007-04-30 14:52:05 +00:00
Nick Mathewson	566cdcd0c2	r12569@catbus: nickm \| 2007-04-30 10:48:51 -0400 Do not use micro-revision.i on MSVC; it will only be useful to people who have make. svn:r10061	2007-04-30 14:52:02 +00:00
Nick Mathewson	5b26a076c6	Oops; the "not in the routerlist" value for routerinfo_t.routerlist_index is -1, not 0. svn:r10060	2007-04-30 14:32:22 +00:00
Nick Mathewson	65daa191fe	r12567@catbus: nickm \| 2007-04-30 10:26:35 -0400 Suggested by weasel: Add a fast function to check for the common failure mode for bug 417/404, and call it a lot. svn:r10059	2007-04-30 14:26:38 +00:00
Nick Mathewson	43385b9bc9	r12565@catbus: nickm \| 2007-04-30 10:09:07 -0400 Misc cleanup and bulletproofing on r10056. svn:r10058	2007-04-30 14:09:11 +00:00
Nick Mathewson	420df2ce15	r12559@catbus: nickm \| 2007-04-30 09:17:54 -0400 Fix bug 421: Only set the revision number from SVK if we have a runnable svk _and_ a ~/.svk directory. svn:r10057	2007-04-30 13:17:57 +00:00
Roger Dingledine	5ba4eaba1c	Let the controller specify HOP=%d as an argument to ATTACHSTREAM, so we can exit from the middle of the circuit. svn:r10056	2007-04-30 11:10:45 +00:00
Roger Dingledine	7fb4365cd3	Add a new config option __DisablePredictedCircuits designed for use by the controller, when we don't want Tor to build any circuits preemptively. svn:r10054	2007-04-30 09:18:48 +00:00
Nick Mathewson	313ac313be	r12557@catbus: nickm \| 2007-04-30 01:36:39 -0400 Oops; the rest of the last patch. If that one gets backported, this should too. svn:r10053	2007-04-30 05:36:41 +00:00
Nick Mathewson	f7acc3cfa0	r12553@catbus: nickm \| 2007-04-30 01:32:54 -0400 Backport candidate: Add asserts to dirserv_remove_invalid, and fix a bug in dirserv_remove_invalid that could mess with pointers in a freed routerinfo right after it was freed. svn:r10052	2007-04-30 05:32:57 +00:00
Roger Dingledine	2d56d883c2	minor cleanups svn:r10050	2007-04-30 04:00:06 +00:00
Nick Mathewson	e0b0c2a4d2	r12544@catbus: nickm \| 2007-04-29 21:08:58 -0400 Fix an assertion when we call tor_free_all before calling do_main_loop(). Discovered by weasel. svn:r10046	2007-04-30 01:09:03 +00:00
Roger Dingledine	397afcc3f6	Make PreferTunneledDirConns and TunnelDirConns work even when we have no cached directory info. This means Tor clients can now do all of their connections protected by TLS. svn:r10035	2007-04-27 10:26:09 +00:00
Roger Dingledine	3d00738ec7	simplify connection_watch_events() hope this doesn't break it svn:r10025	2007-04-25 07:20:04 +00:00
Roger Dingledine	7c5f65c226	fix an assert error in r9995 (unlikely to happen, but still) svn:r10024	2007-04-25 07:04:53 +00:00
Roger Dingledine	7b11f2c843	stop generating a 6-gig info-level log file after a day of running svn:r10023	2007-04-25 06:10:16 +00:00
Roger Dingledine	5bdb138d11	cleanups, and note a bug svn:r10022	2007-04-25 06:05:46 +00:00
Nick Mathewson	94eef608ae	r12784@Kushana: nickm \| 2007-04-23 19:24:09 -0400 Avoid another assert failure in the new buffer memory code. (This time, it hit when freeing a 4k buffer with some data on it.) svn:r10011	2007-04-23 23:24:53 +00:00
Nick Mathewson	3831d77dba	r12782@Kushana: nickm \| 2007-04-23 18:20:19 -0400 Avoid a segfault when freeing a buffer with size 0. svn:r10010	2007-04-23 22:20:45 +00:00
Nick Mathewson	2f4784cbd8	r12499@catbus: nickm \| 2007-04-23 10:42:23 -0400 Keep a freelist of unused 4k buffer chunks, rather than wasting 8k for every inactive connection_t. svn:r10006	2007-04-23 14:42:27 +00:00
Nick Mathewson	473c266fc2	r12496@catbus: nickm \| 2007-04-22 23:04:05 -0400 When logging memory usage, break down memory used in buffers by buffer type. svn:r10004	2007-04-23 03:04:46 +00:00
Nick Mathewson	5cf600b57a	r12492@catbus: nickm \| 2007-04-22 20:24:02 -0400 Even more asserts to try to catch bug 404/417. svn:r10003	2007-04-23 00:24:06 +00:00
Nick Mathewson	87b5928202	r12485@catbus: nickm \| 2007-04-21 13:46:14 -0400 Document some fields in or.h svn:r9998	2007-04-21 17:46:22 +00:00
Nick Mathewson	fb065724f7	r12484@catbus: nickm \| 2007-04-21 13:45:58 -0400 Suppress display of version-detection junk in Makefile.am svn:r9997	2007-04-21 17:46:17 +00:00
Nick Mathewson	bbd63a9ae0	r12482@catbus: nickm \| 2007-04-21 13:30:24 -0400 Rename a couple of confusing fields svn:r9996	2007-04-21 17:30:42 +00:00
Nick Mathewson	648065fcb4	r12763@Kushana: nickm \| 2007-04-20 18:42:58 -0400 Initial version of code to stop using socket pairs for linked connections. Superficially, it seems to work, but it probably needs a lot more testing and attention. svn:r9995	2007-04-21 17:26:12 +00:00
Nick Mathewson	227b2e0226	r12759@Kushana: nickm \| 2007-04-20 08:47:20 -0400 Track the number of connection_t separately from the number of open sockets. It is already possible to have connections that do not count: resolving conns, for one. Once we move from socketpairs to linked conns, and once we do dns proxying, there will be lots of such connections. svn:r9994	2007-04-21 17:24:18 +00:00
Nick Mathewson	6ee5bef092	r12458@catbus: nickm \| 2007-04-19 15:52:23 -0400 Fix a bug in displaying memory pool usage. Also dump cell allocation, and track padded_cell_ts as they are allocated and freed, to make sure we are not leaking cells. svn:r9992	2007-04-19 19:52:30 +00:00
Nick Mathewson	7392464b88	r12456@catbus: nickm \| 2007-04-19 14:47:01 -0400 Make dumpmemusage() dump cell pool usage information. svn:r9991	2007-04-19 18:47:04 +00:00
Nick Mathewson	bf4f0539cf	r12434@catbus: nickm \| 2007-04-19 11:23:35 -0400 When advancing a string pointer, make sure we do not later free the altered pointer. Fixes bug 416, introduced in r9971. svn:r9990	2007-04-19 15:23:38 +00:00
Nick Mathewson	addf2987c5	r12429@catbus: nickm \| 2007-04-18 15:28:41 -0400 Make svn revision number visible in version even if building from a .tar.gz. This was remarkably painless. svn:r9988	2007-04-18 19:28:47 +00:00
Nick Mathewson	a973611834	r12425@catbus: nickm \| 2007-04-17 17:16:38 -0400 Detect the svn version correctly when building from an svk checkout too. Whee, fun with bash and make. svn:r9985	2007-04-17 21:16:40 +00:00
Nick Mathewson	00941b0171	r12418@catbus: nickm \| 2007-04-16 20:58:25 -0400 Twiddle tor_version_as_new_as() so we can check for particular svn revisions. With unit tests, for added freshness. svn:r9977	2007-04-17 00:58:30 +00:00
Nick Mathewson	bfac679cd4	A hack I've been wanting for a while: when building a -dev version from an SVN repository, use the current svn revision in the platform string and in the output of --version. svn:r9976	2007-04-16 23:56:31 +00:00
Nick Mathewson	362fbc79d2	r12414@catbus: nickm \| 2007-04-16 17:37:17 -0400 More proposal-104 stuff: actually remember extra-info stuff. svn:r9975	2007-04-16 21:37:21 +00:00
Nick Mathewson	17e83a408f	Fix some proposal-104 bugs. svn:r9972	2007-04-16 18:54:56 +00:00
Nick Mathewson	6d32d9cb2d	r12406@catbus: nickm \| 2007-04-16 14:39:33 -0400 More proposal-104 stuff: add most of the code for authorities to accept and serve extra-info documents. The back-end to store the things is missing. svn:r9971	2007-04-16 18:39:39 +00:00
Nick Mathewson	2bb5e64289	r12403@catbus: nickm \| 2007-04-16 13:55:03 -0400 Code to generate extrainfo whenever routerdesc is regenerated; code to check extrainfo against routerdesc. svn:r9970	2007-04-16 17:55:08 +00:00
Nick Mathewson	7fb7658a45	r12401@catbus: nickm \| 2007-04-16 12:28:01 -0400 Enforce checks for number of arguments to items in directory objects more uniformly. svn:r9968	2007-04-16 16:28:06 +00:00
Nick Mathewson	a67f8a3787	r12388@catbus: nickm \| 2007-04-16 00:17:29 -0400 Now that the directory parser checks for missing items, the rest of the code can just assert that they are there, rather than checking a second time. svn:r9966	2007-04-16 04:18:29 +00:00
Nick Mathewson	cf02ab6d39	r12387@catbus: nickm \| 2007-04-16 00:06:40 -0400 Refactor router/directory parsing backend: use a separate token table for everything that we parse, and enforce the correct count of each item. svn:r9965	2007-04-16 04:18:21 +00:00
Nick Mathewson	5b220f65c8	r12385@catbus: nickm \| 2007-04-15 22:55:58 -0400 Initial code to parse extra-info documents as described in proposal 104. This is making me realize that the parsing code in routerparse.c is a little daft. svn:r9963	2007-04-16 04:17:58 +00:00
Nick Mathewson	795aa1a196	r12351@catbus: nickm \| 2007-04-11 12:09:46 -0400 More autoconf hacking: use same machinery to find zlib as for openssl and libevent. Have unified library finder include setup for --with variable. Start trying to suggest to the user what packages they should install if finding the library fails. svn:r9945	2007-04-11 16:28:44 +00:00
Nick Mathewson	38a5f09502	r12349@catbus: nickm \| 2007-04-11 09:18:15 -0400 Add code to shrink the cell memory pool by discarding empty chunks that have been empty for the last 60 seconds. Also, instead of having test.c duplicate declarations for exposed functions, put them inside #ifdef foo_PRIVATE blocks in the headers. This prevents bugs where test.c gets out of sync. svn:r9944	2007-04-11 13:18:25 +00:00
Nick Mathewson	1c8f9b319b	r12344@catbus: nickm \| 2007-04-10 21:27:25 -0400 Fix documentation and usage of 2nd argument to mp_pool_new. svn:r9942	2007-04-11 01:27:33 +00:00
Nick Mathewson	51e4b8d706	r12338@catbus: nickm \| 2007-04-10 20:29:05 -0400 Document memory pool implementation, and tweak it even mor. See? Programming is fun. svn:r9940	2007-04-11 00:30:34 +00:00
Nick Mathewson	28de06b8e6	r12337@catbus: nickm \| 2007-04-10 17:55:26 -0400 Add support for using memory pools to allocate queued cell; pass --disable-cell-pool to configure to disable this. svn:r9939	2007-04-11 00:30:29 +00:00
Nick Mathewson	6ba0b0e9f4	r12336@catbus: nickm \| 2007-04-10 17:34:25 -0400 Unit tests and debugging for memory pool implementation. svn:r9938	2007-04-11 00:30:25 +00:00
Nick Mathewson	f95d232483	r12332@catbus: nickm \| 2007-04-10 12:24:45 -0400 Yet another attempted Bug 411 fix: Under some circumstances, a circuit can have cells without being active. The likeliest is that it has been unlinked from all connections in preparation for closing. Therefore, stop enforcing this non-invariant. svn:r9936	2007-04-10 16:24:50 +00:00
Nick Mathewson	58a6761056	r12330@catbus: nickm \| 2007-04-09 19:15:42 -0400 Split type of "packed cell" from "parsed cell"; pack cells before queueing them on circuits. This will help us avoid dumb errors when we confuse the two types. svn:r9935	2007-04-09 23:15:46 +00:00
Nick Mathewson	7529c8f548	r12328@catbus: nickm \| 2007-04-09 18:16:31 -0400 Argh, missed another 9030 bogon. svn:r9934	2007-04-09 22:16:33 +00:00
Nick Mathewson	2a07919198	r12326@catbus: nickm \| 2007-04-09 17:36:41 -0400 Clean up crap from 9930. I can hardly wait till I trust SVK 2.x enough to upgrade. svn:r9933	2007-04-09 21:36:45 +00:00
Nick Mathewson	2dc6019edb	r12688@Kushana: nickm \| 2007-04-09 17:29:12 -0400 Simplify dns_resolve: use a helper function so that we handle the error/answer/pending cases uniformly in dns_resolve, and everything else in dns_resolve_impl. svn:r9932	2007-04-09 21:34:13 +00:00
Nick Mathewson	9c3df07b56	r12687@Kushana: nickm \| 2007-04-09 17:05:57 -0400 Try to fix bug 410: move responsibility for attaching/detaching initial streams from circuits into dns_resolve. Needs refactoring a little. svn:r9931	2007-04-09 21:34:03 +00:00
Nick Mathewson	32506ad282	svn:r9930	2007-04-09 21:33:49 +00:00
Nick Mathewson	98e5d10761	r12318@catbus: nickm \| 2007-04-09 16:08:20 -0400 Fix the first half of bug 411: when we make a circuit active inactive on a connection, it _must_ actually be on that connection. svn:r9929	2007-04-09 20:09:28 +00:00
Nick Mathewson	eb95ff9ba9	r12317@catbus: nickm \| 2007-04-09 15:50:51 -0400 Fix second part of bug 411 (which was actually a separate bug): it isnt safe to clear a cell queue while the circuit is active. svn:r9928	2007-04-09 20:09:26 +00:00
Roger Dingledine	f36c613dbc	fix a memory leak when we ask for "all" networkstatuses and we get one we don't recognize. backport candidate. backbackport candidate. svn:r9918	2007-03-29 07:02:12 +00:00
Nick Mathewson	6589ea2a2f	Fix a crash bug in cell queues: It is possible for a connection_write_to_buf to close the connection or otherwise unlink the circuit, which makes the circuit nonactive, which invalidates the pointer from the circuit to the next circuit on the active ring. Also add a bunch of asserts, most #ifdefed out. svn:r9915	2007-03-29 02:41:36 +00:00
Nick Mathewson	d1ad950ca8	Turn bool_neq and bool_eq into macros. svn:r9914	2007-03-29 02:37:06 +00:00
Nick Mathewson	98ae4bbd0f	Comment out the "clear queue when sending a destroy" logic: it seems potentially dangerous. (see comment for details) svn:r9913	2007-03-29 02:32:00 +00:00
Nick Mathewson	a25c5d6994	r12654@Kushana: nickm \| 2007-03-25 19:03:44 -0400 Add documentation for cell queue functions; make destroy cells result in cell queues getting cleared before the destroy gets sent. svn:r9907	2007-03-26 14:08:35 +00:00
Nick Mathewson	83b2208ea4	r12653@Kushana: nickm \| 2007-03-25 18:21:38 -0400 Add documentation for make_old argument to routerlist functions. svn:r9906	2007-03-26 14:08:29 +00:00
Nick Mathewson	d1381aef82	r12652@Kushana: nickm \| 2007-03-25 15:01:48 -0400 A surprisingly simple patch to stop reading on edge connections when their circuits get too full, and start again when they empty out. This lets us remove the logic to block begin_dir conns when the corresponding or conns get full: it was already broken by cell queues anyway. svn:r9905	2007-03-26 14:08:18 +00:00
Nick Mathewson	38c0bb3a99	r12651@Kushana: nickm \| 2007-03-24 18:26:42 -0400 Initial version of circuit-based cell queues. Instead of hammering or_conns with piles of cells, queue cells on their corresponding circuits, and append them to the or_conn as needed. This seems to work so far, but needs a bit more work. This will break the memory-use-limitation patch for begin_dir conns: the solution will be a fun but fiddly. svn:r9904	2007-03-26 14:07:59 +00:00
Nick Mathewson	6e51bdd5e4	r12274@catbus: nickm \| 2007-03-26 09:29:18 -0400 Possibly resolve bug reported by xiando. svn:r9903	2007-03-26 13:30:17 +00:00
Nick Mathewson	da6bd21b72	r12644@0-41-wifi: nickm \| 2007-03-23 16:02:23 -0400 Eliminate more redundant circuit_t arguments when edge_connection_t is already supplied and the circuit is already attached. svn:r9900	2007-03-24 15:58:11 +00:00
Nick Mathewson	306d5400c3	r12643@0-41-wifi: nickm \| 2007-03-23 14:56:35 -0400 Refactor a bunch of functions that take edge_connection_t not to also take a crypt_path_t; the cpath is implicit. svn:r9899	2007-03-24 15:57:51 +00:00
Roger Dingledine	2cf63f8a62	Don't save non-general-purpose router descriptors to the disk cache, because we have no way of remembering what their purpose was when we restart. svn:r9894	2007-03-21 15:37:30 +00:00
Roger Dingledine	c36a6210a2	put the stopgap on whether we've sent a create cell, not whether we've attached a stream. svn:r9883	2007-03-20 03:26:51 +00:00
Roger Dingledine	93e7627694	a stopgap measure while we wait for proposal 111: apply the stricter rate limiting to all OR conns except those that have been touched by local circuits. svn:r9882	2007-03-20 03:21:51 +00:00
Roger Dingledine	b4f743562f	Add a separate set of token buckets for relayed traffic. Right now that's just defined as answers to directory requests. svn:r9881	2007-03-20 02:55:31 +00:00
Roger Dingledine	4ab0b979b2	temporary hack to solve bug 384, so i can get on with debugging other stuff. svn:r9880	2007-03-20 02:10:18 +00:00
Roger Dingledine	0724bc113f	correct a function comment that's become wrong svn:r9879	2007-03-19 23:32:30 +00:00
Nick Mathewson	141efb86ff	r12230@catbus: nickm \| 2007-03-17 17:34:32 -0400 Remove some duplicated code in control.c: unify the "parse space-separated arguments and warn if there are too few" logic into a single helper function. svn:r9866	2007-03-17 21:34:41 +00:00
Nick Mathewson	d787ef906a	r12229@catbus: nickm \| 2007-03-17 17:20:28 -0400 Add a warning when using obsolete "GUARDS" event. Also, remove obsolete "if (1) {}"s from control.c: big patch, mostly just dedenting block contents. svn:r9865	2007-03-17 21:34:37 +00:00
Roger Dingledine	75754b4d8e	other minor fixes lurking in my sandbox svn:r9854	2007-03-17 04:34:31 +00:00
Roger Dingledine	9d7dc1b37b	forward-port r9850 and the changelogs (it's a band) svn:r9853	2007-03-17 04:32:04 +00:00
Roger Dingledine	4813ff04e8	Fix an infinite loop introduced in 0.1.2.7-alpha when we serve directory information requested inside Tor connections (i.e. via begin_dir cells). It only triggered when the same connection was serving other data at the same time. Reported by seeess. Backport candidate. svn:r9841	2007-03-16 06:55:09 +00:00
Roger Dingledine	d374616301	clean up some minor typos and log confusions svn:r9832	2007-03-15 22:47:21 +00:00
Nick Mathewson	e50e6b4e3c	r12182@catbus: nickm \| 2007-03-15 10:58:12 -0400 Clarify section of dir-spec.txt that explains how "v" resolution happens. svn:r9829	2007-03-15 16:27:57 +00:00
Roger Dingledine	ad304a5cbb	change my mind -- correct the spec to match the code's behavior for getinfo addr-mappings/*. this is because the code and spec have been mismatched since at least 0.1.1.x, so i would be surprised if nobody at all is relying on the current behavior. backport candidate. backbackport candidate. svn:r9823	2007-03-15 06:25:00 +00:00
Roger Dingledine	8ca31c8195	Make the response to 'getinfo addr-mappings/*' follow the spec. svn:r9822	2007-03-15 06:10:58 +00:00
Roger Dingledine	c995a36972	typo in error message led to breaking the protocol. also pointed out by daejees. svn:r9819	2007-03-15 03:15:34 +00:00
Roger Dingledine	5b8adc7c9b	Make 'getinfo fingerprint' return a 551 error if we're not a server, so we match what the control spec claims we do. Reported by daejees. svn:r9818	2007-03-15 03:11:53 +00:00
Roger Dingledine	5740071674	the spec called it a GUARDS event, but the code called it a GUARD event. standardize on GUARD, but support people asking for GUARDS too. reported by daejees. backport candidate. svn:r9817	2007-03-14 23:50:41 +00:00
Roger Dingledine	bf3b3a44f3	Stop allowing hibernating servers to be "stable" or "fast". This is what I meant to do in r9690 but didn't actually do. svn:r9808	2007-03-13 01:59:09 +00:00
Nick Mathewson	6363a7ccf5	r12538@Kushana: nickm \| 2007-03-11 17:10:22 -0400 Fix a lame assert, I hope. svn:r9801	2007-03-11 21:10:54 +00:00
Roger Dingledine	7fedd6ab4e	best not to introduce new technical terms if we don't need to svn:r9800	2007-03-11 20:52:07 +00:00
Nick Mathewson	98c3403ce7	r12535@Kushana: nickm \| 2007-03-11 16:34:40 -0400 Fix a comment and add a couple of assert to try to track down another assert in routerlist_assert_ok() svn:r9799	2007-03-11 20:34:44 +00:00
Nick Mathewson	97b61b9889	r12519@Kushana: nickm \| 2007-03-10 00:57:01 -0500 Remove a redundant check for event.h; add some comments, and reformat. svn:r9790	2007-03-10 07:38:42 +00:00
Roger Dingledine	4ca75ecc49	holy cow, those windows unames are long. don't distract so much from the important part of this log message. svn:r9789	2007-03-10 06:33:44 +00:00
Roger Dingledine	a247792169	Directory authorities now call routers stable if they have an uptime of at least 30 days, even if that's not the median uptime in the network. Implements proposal 1xx, suggested by Kevin Bauer and Damon McCoy. svn:r9788	2007-03-10 05:43:35 +00:00
Nick Mathewson	02ce8e6b12	r12474@Kushana: nickm \| 2007-03-06 16:10:05 -0500 We have a PATH_SEPARATOR macro. How about we use it? svn:r9782	2007-03-09 21:39:30 +00:00
Roger Dingledine	fe94914b98	Put a platform string (e.g. "Linux i686") in the startup log message, so when people paste just their logs, we know if it's openbsd or windows or what. svn:r9775	2007-03-09 08:56:39 +00:00
Roger Dingledine	b97dca4510	forward-port the bugfix from juliusz svn:r9772	2007-03-09 08:48:53 +00:00
Roger Dingledine	064ff7b33d	get rid of an info-level log message that occurs many times a minute when we haven't needed circuits lately. svn:r9771	2007-03-09 08:48:21 +00:00
Nick Mathewson	2036470b62	r12098@catbus: nickm \| 2007-03-06 18:48:50 -0500 Try to make unit tests happier on 64-bit platforms. svn:r9752	2007-03-06 23:48:55 +00:00
Nick Mathewson	5d1bee87ff	r12468@Kushana: nickm \| 2007-03-06 15:24:00 -0500 More unit tests: gcov is fun. svn:r9748	2007-03-06 20:25:44 +00:00
Nick Mathewson	c9e2766e75	r12461@Kushana: nickm \| 2007-03-06 13:26:17 -0500 More autoconf fixes and updates. Maybe the bsd buildbots will be happy again. svn:r9747	2007-03-06 20:25:32 +00:00
Roger Dingledine	78cbfcf651	and one more not-really-an-error case svn:r9743	2007-03-06 19:37:18 +00:00
Roger Dingledine	5217d3680e	clean up a log message, and stop calling it an error when we exit cleanly svn:r9742	2007-03-06 19:33:43 +00:00
Nick Mathewson	52713788b4	r12080@catbus: nickm \| 2007-03-04 21:40:55 -0500 Remove dnsworkers and related code. there goes another 550 lines of code. svn:r9736	2007-03-05 02:40:58 +00:00
Nick Mathewson	92f62b3684	r12077@catbus: nickm \| 2007-03-04 16:08:23 -0500 Remove support for v0 control protocol from 0.2.0.x trunk; send back error when we receive a v0 control message. (Leave "if(v1){...}"blocks indented for now so this patch is easier to read.) ((Finally, the linecount goes _down_ a little.)) svn:r9735	2007-03-04 21:08:28 +00:00
Nick Mathewson	7fcceb2c25	r12074@catbus: nickm \| 2007-03-04 15:11:43 -0500 Make all LD_BUG log messsages get prefixed with "Bug: ". Remove manually-generated "Bug: "s from log-messages. (Apparently, we remembered to add them about 40% of the time.) svn:r9733	2007-03-04 20:11:46 +00:00
Nick Mathewson	70e5a83a77	r12057@catbus: nickm \| 2007-03-04 13:58:32 -0500 Clarify some log messages; note others that could be improved later. svn:r9724	2007-03-04 18:58:38 +00:00
Nick Mathewson	5f9f62daa2	r12053@catbus: nickm \| 2007-03-03 16:45:38 -0500 Remove some XXX012s: leave a check in connection_or_set_identity_digest it costs basically nothing to do on average. Forget about reinstating the user check on NT Service creation. Note that a notice message in main.c ("Is something wrong with your network connection?") is really useless. svn:r9721	2007-03-03 21:55:31 +00:00
Nick Mathewson	25508347ec	r12051@catbus: nickm \| 2007-03-03 16:15:52 -0500 nt_service_is_stopping should not load the NT service library calls: if they are not loaded, we cannot possibly be a service trying to shut own. Bug found by "norvid" on or-talk. Also, rename function to something slightly less error-prone. svn:r9720	2007-03-03 21:16:07 +00:00
Roger Dingledine	6b191f854c	resolve another xxx012 svn:r9701	2007-03-01 04:40:43 +00:00
Roger Dingledine	dba4e040fc	Disable encrypted directory connections when we don't have a server descriptor for the destination. We'll get this working again in the 0.2.0 branch. svn:r9700	2007-03-01 04:26:30 +00:00
Roger Dingledine	a46bd9942d	bonus points if it builds on 64 bit svn:r9698	2007-03-01 03:59:28 +00:00
Roger Dingledine	b0aaa88433	make the prefertunnel stuff less obviously broken svn:r9697	2007-03-01 03:56:21 +00:00
Nick Mathewson	2780bb74c8	r12014@catbus: nickm \| 2007-02-28 19:41:20 -0500 Niels has accepted the patch from Scott Lamb to implement better signal handling: I can take "get the pthread_sigprocmask situation under control" off my plate. svn:r9696	2007-03-01 00:41:35 +00:00
Nick Mathewson	df5a8aa931	r12013@catbus: nickm \| 2007-02-28 18:26:13 -0500 Note a piece of code that needs to get resolved, before we forget it. svn:r9695	2007-03-01 00:41:33 +00:00
Nick Mathewson	11d89141ac	r12012@catbus: nickm \| 2007-02-28 18:25:18 -0500 Twiddle constants wrt uploading hidden service descriptors. svn:r9694	2007-03-01 00:41:28 +00:00
Roger Dingledine	b78f67dbf5	- Stop calling servers that have been hibernating for a long time "stable". Also, stop letting hibernating or obsolete servers affect uptime and bandwidth cutoffs. - Stop listing hibernating servers in the v1 directory. svn:r9690	2007-02-28 21:06:05 +00:00
Roger Dingledine	9fd669c339	note another wishlist item for the arma svn:r9689	2007-02-28 20:49:09 +00:00
Nick Mathewson	f38240435a	r12001@catbus: nickm \| 2007-02-28 15:24:12 -0500 Try to build without warnings on mingw with verbose warnings on. First attempt. svn:r9688	2007-02-28 20:24:27 +00:00
Nick Mathewson	3008c3b768	r12000@catbus: nickm \| 2007-02-28 15:12:21 -0500 Try to fix eventdns bug 326 again, this time by noting that rcode 2 (serverfailed) does not really mean "The server is useless." svn:r9687	2007-02-28 20:24:23 +00:00
Roger Dingledine	08c75f4349	avoid a few headaches svn:r9686	2007-02-28 20:24:09 +00:00
Nick Mathewson	2ee2e63631	r11996@catbus: nickm \| 2007-02-28 13:52:48 -0500 Add an MSC_VER check I missed. svn:r9684	2007-02-28 18:52:57 +00:00
Nick Mathewson	deef370a1c	r11987@catbus: nickm \| 2007-02-28 12:34:04 -0500 add another u64-related unit test. svn:r9681	2007-02-28 17:34:07 +00:00
Nick Mathewson	c8659db28d	r11982@catbus: nickm \| 2007-02-28 11:55:41 -0500 Add unit tests for tor_parse_uint64 svn:r9678	2007-02-28 16:56:28 +00:00
Nick Mathewson	dae5fc7982	r11981@catbus: nickm \| 2007-02-28 11:55:27 -0500 Clamp declarable bandwidth at INT32_MAX, not INT_MAX. svn:r9677	2007-02-28 16:56:07 +00:00
Nick Mathewson	d6368fd075	r11976@catbus: nickm \| 2007-02-27 19:35:59 -0500 Add some missing (redundant but helpful in most cases) static declarations, and remove a function nobody was calling. svn:r9672	2007-02-28 00:36:03 +00:00
Nick Mathewson	1a3e1c5510	r11970@catbus: nickm \| 2007-02-27 19:17:27 -0500 Fix a bug found by Udo van den Heuvel: avoid an assertion failure when a controller sets and clears EntryNodes before the next call to choose_random_entry(). Also make a function static. svn:r9669	2007-02-28 00:23:05 +00:00
Nick Mathewson	4d127acb53	r11958@catbus: nickm \| 2007-02-26 22:28:03 -0500 Add a missing set to onion_key_set_at to avoid premature rotates. svn:r9662	2007-02-27 03:53:40 +00:00
Nick Mathewson	82e2d6001a	r11954@catbus: nickm \| 2007-02-26 13:01:19 -0500 Note some optimizations that are probably not worth it for 0.1.2.x based on preliminary profiling. svn:r9659	2007-02-26 18:01:23 +00:00
Roger Dingledine	522a97098b	more cleanups; getting closer svn:r9655	2007-02-26 05:36:02 +00:00
Roger Dingledine	9e44449946	fix a bug in our logic, but point out that maybe it's moot svn:r9654	2007-02-26 05:33:17 +00:00
Nick Mathewson	333bf44471	r11944@catbus: nickm \| 2007-02-25 14:43:18 -0500 Add a lower-bound on MaxAdvertisedBandwidth. svn:r9652	2007-02-25 19:43:23 +00:00
Nick Mathewson	938de88e3b	r11942@catbus: nickm \| 2007-02-25 11:22:12 -0500 Fix connection_get_by_type_state_rendquery(): This has been bogus for most of 0.1.2.x. Thanks to Karsten Loesing for finding the bug; fixes bug 399. svn:r9651	2007-02-25 16:22:36 +00:00
Roger Dingledine	5fd4f7c131	the other half of r9572, suggested by seeess: when we receive a v1 dir or rr that is too old, don't even cache it. svn:r9649	2007-02-25 03:43:00 +00:00
Nick Mathewson	dde4bc1fd3	r11933@catbus: nickm \| 2007-02-24 18:55:33 -0500 Fix a bug in 9572: after we decref a defunct v1 directory, drop the main reference to it. Should fix bug 396. Many thanks to seeess for tracking this one down. svn:r9648	2007-02-24 23:55:36 +00:00
Roger Dingledine	d6c21ab8a7	tell the user if we're delaying his newnym request. also, pick a different set of fenceposts. svn:r9647	2007-02-24 21:21:38 +00:00
Nick Mathewson	af57074f08	r11931@catbus: nickm \| 2007-02-24 15:28:34 -0500 crank up the length of the maximum allowed control message. svn:r9644	2007-02-24 20:28:41 +00:00
Nick Mathewson	b4243d7dfa	r11929@catbus: nickm \| 2007-02-24 15:02:43 -0500 Split possibly long log line. svn:r9643	2007-02-24 20:02:47 +00:00
Nick Mathewson	501659e67c	r11927@catbus: nickm \| 2007-02-24 14:49:31 -0500 Make sure every error case of router_dump_router_to_string warns about what actually went wrong. svn:r9642	2007-02-24 19:49:35 +00:00
Roger Dingledine	fc81b71055	if we can't read bandwidthrate, at least tell us what it was. svn:r9640	2007-02-24 19:29:42 +00:00
Nick Mathewson	cc64d1f111	r11917@catbus: nickm \| 2007-02-24 03:18:52 -0500 Fix another XXX012 in eventdns.c: tell the DNS request about malformed DNS replies. svn:r9637	2007-02-24 08:18:59 +00:00
Roger Dingledine	50f22e858a	doc pedant svn:r9634	2007-02-24 07:50:38 +00:00
Nick Mathewson	f599adf40a	r11909@catbus: nickm \| 2007-02-24 02:37:40 -0500 Move tricky "delete the member of the smartlist currently under iteration" logic into its own happyfun macro. svn:r9633	2007-02-24 07:37:45 +00:00
Roger Dingledine	2015479b5a	fix crash introduced in r9622 svn:r9632	2007-02-24 06:44:40 +00:00
Roger Dingledine	748c502e3a	fix a log message that was broken long ago and never noticed svn:r9630	2007-02-24 05:36:45 +00:00
Roger Dingledine	d63c58249e	make it stop crashing when i exercise the new entrynodes behavior in r9574. this hack is getting pretty darn hackish; perhaps it's time to not use SMARTLIST_FOREACH in this situation. svn:r9629	2007-02-24 04:17:29 +00:00
Roger Dingledine	33430d3a9e	bugfix on r9568: we were throwing around an uninitialized nickname array, and only treating a server as reachable if the array magically has the right nickname in it. this was causing the authorities to label only themselves as running, and clients were "mysteriously" failing. svn:r9628	2007-02-24 01:26:09 +00:00
Roger Dingledine	9946bb7fbd	cosmetic, comment, and todo fixes svn:r9627	2007-02-24 01:12:53 +00:00
Nick Mathewson	4e05ccb289	r11900@catbus: nickm \| 2007-02-23 18:11:04 -0500 Fix null-pointer access on update_router_descriptor_cache_downloads. svn:r9626	2007-02-23 23:11:08 +00:00
Nick Mathewson	ddc34f6037	r11898@catbus: nickm \| 2007-02-23 16:55:43 -0500 Two XXX012 comments turned out to be bogus; remove them and document why. svn:r9625	2007-02-23 21:56:10 +00:00
Nick Mathewson	55cbbdf9bf	r11895@catbus: nickm \| 2007-02-23 15:12:58 -0500 Make remap stream events have a souce; make them generated every time we get a successful connected or resolved cell. Also change reported stream target address to IP consistently when we get the IP from an exit node. svn:r9624	2007-02-23 20:13:02 +00:00
Nick Mathewson	f1d207b29a	r11885@catbus: nickm \| 2007-02-23 13:34:24 -0500 Fix an XXXX012: make entry guards _really_ get retried when the network comes back online. svn:r9622	2007-02-23 18:34:35 +00:00
Nick Mathewson	a98efbf285	r11877@catbus: nickm \| 2007-02-22 02:24:50 -0500 Fix doc about when circuit_build_needed_circs() is called. Resolves another xxxx012. svn:r9617	2007-02-22 07:41:14 +00:00
Nick Mathewson	a2a52b4d5f	r11876@catbus: nickm \| 2007-02-22 02:23:13 -0500 Fix two XXXX012 issues in routerlist.c: a possible performance issue hasnt shown up on any profiles, so unflag it. Stop warning when we get a router descriptor that we asked for but no longer want: just drop it (if we are not a cache) or cache if (if we are). svn:r9616	2007-02-22 07:41:10 +00:00
Nick Mathewson	b3392559d4	r11873@catbus: nickm \| 2007-02-22 01:21:14 -0500 twiddle signewnym rate-limiting patch so every signal gets handled eventually. document it in control-spec. add a changelog. svn:r9615	2007-02-22 06:21:19 +00:00
Nick Mathewson	fe9224dabc	r11872@catbus: nickm \| 2007-02-22 01:08:46 -0500 patch from mwenge: rate-limit newnym. svn:r9614	2007-02-22 06:21:16 +00:00
Nick Mathewson	809a4daa52	r11859@catbus: nickm \| 2007-02-21 00:53:27 -0500 Fix use of predict. this should get refactored, but now now. svn:r9611	2007-02-21 05:57:08 +00:00
Nick Mathewson	2a4fc8533c	r11858@catbus: nickm \| 2007-02-21 00:27:44 -0500 As a trivial optimization, remove a redundant call to router_have_minimum_dir_info. This might shave 2% on some systems by according to some profilers. svn:r9610	2007-02-21 05:56:53 +00:00
Nick Mathewson	aade1b9204	r11844@catbus: nickm \| 2007-02-17 16:53:42 -0500 Note a problematic warning. svn:r9599	2007-02-17 23:49:50 +00:00
Nick Mathewson	d2893398f6	r11832@catbus: nickm \| 2007-02-16 15:31:59 -0500 Fix 35 remaining DOCDOC comments. Yowza. svn:r9596	2007-02-16 20:39:37 +00:00
Nick Mathewson	a3ec172e1a	r11827@catbus: nickm \| 2007-02-16 15:00:39 -0500 Try to fix VC++ int conversion warning. svn:r9595	2007-02-16 20:01:21 +00:00
Nick Mathewson	11e5656ab7	r11826@catbus: nickm \| 2007-02-16 14:58:38 -0500 Resolve 56 DOCDOC comments. svn:r9594	2007-02-16 20:01:02 +00:00
Nick Mathewson	ae7576a19e	r11825@catbus: nickm \| 2007-02-16 14:04:36 -0500 Fix DOCDOC items in or.h; rename a couple of macros to be more sensible. svn:r9593	2007-02-16 20:00:50 +00:00
Nick Mathewson	d4aaffc6e7	r11824@catbus: nickm \| 2007-02-16 13:16:47 -0500 Move all struct-offset-manipulation macros into util.h, and use them consistently. Because there are days when "SUBTYPE_P(handle, subtype, _base)" is just easier to read and write than "(basetp*)(((handle) - STRUCT_OFFSET(subtype, _base))". svn:r9592	2007-02-16 20:00:43 +00:00
Nick Mathewson	e5d3269b10	r11822@catbus: nickm \| 2007-02-16 12:49:20 -0500 Tech config.c about libevent 1.3, and resolve all docdoc elements in config.c svn:r9591	2007-02-16 18:12:47 +00:00
Nick Mathewson	6e35b11851	r11813@catbus: nickm \| 2007-02-14 11:42:58 -0500 Tweak stream_bw patch: Remove a couple of redundant checks, save 8 bytes per edge connection, fix spelling in the changelog; expand spec. svn:r9586	2007-02-14 16:46:55 +00:00
Nick Mathewson	4a74812c70	r11812@catbus: nickm \| 2007-02-14 11:22:08 -0500 Apply stream_bw patch from Robert Hogan. svn:r9585	2007-02-14 16:46:49 +00:00
Nick Mathewson	a10ccac9cb	r11797@catbus: nickm \| 2007-02-13 16:17:40 -0500 Fix a longstanding dnsworker-related bug: when we decide to kill a DNS worker for having been in use too long, and we independently decide to close one of the exit connections waiting for that DNS worker (perhaps because we got an END relay cell), it was possible for us to try to double-free the connection. We were smart enough to detect this and assert, but not smart enough to fix this bug before now. This should resolve bug 390. Backport candidate. svn:r9581	2007-02-13 21:18:56 +00:00
Nick Mathewson	d9c095be3e	r11787@catbus: nickm \| 2007-02-12 21:01:34 -0500 Always remove expired routers and networkstatus docs before checking whether we have enough information to build circuits. (Fixes bug 373.) svn:r9575	2007-02-13 02:01:38 +00:00
Nick Mathewson	3c691b9da6	r11785@catbus: nickm \| 2007-02-12 20:27:48 -0500 Node-picking fixes: Never warn when a down node is listed in a config option (bug 348); always warn when a node in a config option is unnamed. Also, when entrynodes is configured, then build the guard list as: (parts of EntryNodes that were guards before), (the rest of EntryNodes), (the rest of the old guards). This last point ensures that EntryNode users will get the EntryNodes they want with the minimum change to their guard list. svn:r9574	2007-02-13 01:27:55 +00:00
Nick Mathewson	95b828b685	r11781@catbus: nickm \| 2007-02-12 18:31:33 -0500 Discard any v1 directory info that is so old as to be useless. (Fixes bug 387) svn:r9572	2007-02-12 23:39:24 +00:00
Nick Mathewson	b16c544509	r11779@catbus: nickm \| 2007-02-12 16:52:29 -0500 Do not try to load advapi32.dll except when the user asks us to do something with NT services. When we _do_ try, always treat failure to load service functions as an exit-worthy error. Needs testing. (Fixes bug 389) svn:r9571	2007-02-12 21:52:32 +00:00
Nick Mathewson	759c58151e	r11775@catbus: nickm \| 2007-02-12 16:39:09 -0500 Update copyright dates. svn:r9570	2007-02-12 21:39:53 +00:00
Nick Mathewson	30e7c05075	r11774@catbus: nickm \| 2007-02-12 16:31:47 -0500 Handle errors on opening cached-routers* more uniformly and sanely: log not-found errors at level INFO, and all other errors at level WARN. Needs testing on win32. svn:r9569	2007-02-12 21:39:44 +00:00
Nick Mathewson	0c40a080a4	r11773@catbus: nickm \| 2007-02-12 15:18:48 -0500 Implement proposal 106: stop requiring clients to have certificates, and stop checking for nicknames in certificates. [See proposal 106 for rationale.] Also improve messages when checking TLS handshake, to re-resolve bug 382. svn:r9568	2007-02-12 21:39:33 +00:00
Roger Dingledine	5915eecdb3	be even pickier about our socks command. this resolves a warning we get when we hang up on an unhandshaked socks connection. i'm still seeing these from polipo. darn it. svn:r9565	2007-02-12 03:01:36 +00:00
Roger Dingledine	4e67d5196f	remove the socks-wait verbose logging. juliusz found and fixed the polipo bug. svn:r9553	2007-02-11 02:36:51 +00:00
Roger Dingledine	731d37f717	more useful log messages when we give up on a stream svn:r9552	2007-02-11 02:15:42 +00:00
Nick Mathewson	24e7b9b983	r12213@Kushana: nickm \| 2007-02-10 16:25:39 -0500 Refactor setconf implementation to be a little slower, but far less error prone. svn:r9549	2007-02-10 21:26:29 +00:00
Nick Mathewson	2c521d9804	r12212@Kushana: nickm \| 2007-02-10 16:09:38 -0500 Remove XXXX012 for apparently resolved bug svn:r9548	2007-02-10 21:26:17 +00:00
Roger Dingledine	01ddb05fba	Stop crashing when the controller asks us to resetconf more than one config option at once. (Vidalia 0.0.11 does this.) Backport candidate. svn:r9545	2007-02-10 07:04:46 +00:00
Roger Dingledine	b3ac3acefc	If we start a server with ClientOnly 1, then set ClientOnly to 0 and hup, stop triggering an assert based on an empty onion_key. svn:r9540	2007-02-09 00:22:43 +00:00
Nick Mathewson	ec54857870	r11732@catbus: nickm \| 2007-02-08 18:12:54 -0500 Fix an "uninitialized variable" warning. svn:r9536	2007-02-08 23:24:03 +00:00
Nick Mathewson	76f61da37b	r11727@catbus: nickm \| 2007-02-08 17:07:50 -0500 Explain that update_router_desciptor_downloads happens every 10 seconds in main.c, and we don't need to call it from directory.c svn:r9534	2007-02-08 22:08:04 +00:00
Nick Mathewson	e00a1cbf16	r11726@catbus: nickm \| 2007-02-08 16:04:53 -0500 Resolve some XXXX012 items: - Remove PathlenCoinWeight: if we want it again, we can add it back in. - Ditto with RelayBandwidth*. - Decide to leave in the "hey, you didn't set end_reason!" BUG log message, but stop telling people to bug me personally. - Postpone strengthening assert_connection_ok(): it's important, but it's also a good way to introduce weird bugs. - Move some expensive consistency checking from dns_free_all() into assert_cache_ok(). svn:r9533	2007-02-08 22:07:56 +00:00
Roger Dingledine	90b53beec5	add a comment so i stop worrying svn:r9532	2007-02-08 20:27:58 +00:00
Nick Mathewson	a1a9c66ce5	r11717@catbus: nickm \| 2007-02-08 14:44:30 -0500 Clear up some XXX012s in routerlist.c: make smartlist_choose_by_bandwidth handle statuses with no corresponding routers much better. svn:r9531	2007-02-08 19:44:55 +00:00
Nick Mathewson	69def349e0	r11716@catbus: nickm \| 2007-02-08 14:19:24 -0500 Warn when we get a v0 control connection. svn:r9530	2007-02-08 19:44:48 +00:00
Nick Mathewson	9c081ab976	r11715@catbus: nickm \| 2007-02-08 14:07:03 -0500 Oops; the change in tor_version_is_obsolete broke a unit test. svn:r9529	2007-02-08 19:44:36 +00:00
Nick Mathewson	85d3c2fbaf	r11702@catbus: nickm \| 2007-02-08 02:10:19 -0500 Wow. Remember when I wrote that script to tell me about macros that were never used? Good times. svn:r9525	2007-02-08 07:24:15 +00:00
Nick Mathewson	1e2d5f30ff	r11700@catbus: nickm \| 2007-02-08 02:03:50 -0500 Fix several bugs in computing recommended versions. 1) refactor is-this-version-good handling and which-vesions-are-good handling to be in the same place. 2) a version is recommended if more than half of the versioning authorities like it, not >= half. 3) "NEW_IN_SERIES" should mean, "I don't know of an 0.1.1.x this recent, and there are some 0.1.2.x versions out", not "I don't know of an 0.1.1.x this recent, but I know some older ones." This should resolve bug 383. svn:r9523	2007-02-08 07:24:06 +00:00
Nick Mathewson	a24b9e6a66	r11694@catbus: nickm \| 2007-02-07 13:25:01 -0500 Fix patch for 9510: never call control_event_stream_status on an exit connection. Should fix assert() noticed by xiando. svn:r9514	2007-02-07 18:25:04 +00:00
Nick Mathewson	2e6feb646b	r11686@catbus: nickm \| 2007-02-07 01:50:14 -0500 Set hibernate_end_time whenever we start hibernating. This fixes a problem where we would start hibernating upon startup (since it isn't time to wake up yet) but we would wind up setting the "stop hibernating" time not to the wakeup time, but to the end of the interval. Also, split hibernate_end_time from shutdown_time. Possible fix for bug 362. svn:r9512	2007-02-07 06:54:33 +00:00
Nick Mathewson	071738c2d5	r11673@catbus: nickm \| 2007-02-06 14:40:07 -0500 Report stream end events where a resolve succeeded or where we got a socks protocol error correctly, rather than calling both of them "INTERNAL". Turn ALREADY_SOCKS_REPLIED into a flag rather than a reason. This will help debug 367 part 2 a little. svn:r9511	2007-02-07 06:54:27 +00:00
Nick Mathewson	026c11c42e	r11672@catbus: nickm \| 2007-02-06 14:16:56 -0500 Fix third case of bug 367: make circuit get sent along with END_STREAM_REASON_DESTROY stream CLOSED events. svn:r9510	2007-02-07 06:54:22 +00:00
Nick Mathewson	295f6d4e0f	r11676@catbus: nickm \| 2007-02-07 00:10:00 -0500 (Hopefully) final changes for 0.1.2.7-alpha: disable checking for whether the user account in question exists on --service install, since that seems to make windows go boom. We can figure out why later. Also, let the admin specify a password for the target user. svn:r9506	2007-02-07 05:10:58 +00:00
Roger Dingledine	7828927a58	Only rewrite a conn's address based on X-Forwarded-For: headers if it's a parseable public IP address; and stop adding extra quotes to the resulting address. svn:r9505	2007-02-07 03:40:06 +00:00
Roger Dingledine	690c9cc887	make a log message make more sense svn:r9504	2007-02-07 02:55:34 +00:00
Nick Mathewson	534baec4a1	r11674@catbus: nickm \| 2007-02-06 17:00:22 -0500 Remove a now-bogus assert() from nt_service_command_line(), and change option handling. (Now that we no longer force a -f, it is possible to have no command-line options for Tor-as-service.) svn:r9503	2007-02-06 22:00:25 +00:00
Nick Mathewson	c4faebfa6d	r11667@catbus: nickm \| 2007-02-06 13:36:18 -0500 The --service install code can no longer default to adding an -f option for the appdata directory of the current user, since the target user probably will not be able to read it. Instead, warn the user if no explicit torrc filename is given. svn:r9502	2007-02-06 18:36:26 +00:00
Nick Mathewson	f4a1c17e5a	r11666@catbus: nickm \| 2007-02-06 13:17:24 -0500 Implement an --ignore-missing-torrc option svn:r9501	2007-02-06 18:36:21 +00:00
Nick Mathewson	0c4ab00658	r11664@catbus: nickm \| 2007-02-06 11:55:37 -0500 More win32 account flumdummery: when LocalService exists, you can't detect it via LookupAccountName. The only good test is to see whether we're on win2k or earlier. Apparently, somebody wouldn't know where to draw the line between implementation and interface if you gave them tracing paper and a copy of Stevens. svn:r9499	2007-02-06 16:55:42 +00:00
Roger Dingledine	da5cd33ab8	stop crashing on nt service install; but matt says still not right svn:r9496	2007-02-06 04:58:56 +00:00
Roger Dingledine	4ba57f68e4	more changes. i'm all caught up now. svn:r9495	2007-02-06 02:49:07 +00:00
Roger Dingledine	9aa8e490f8	cleanups based on looking through svn commits svn:r9491	2007-02-06 00:27:03 +00:00
Nick Mathewson	e0acb45b86	r11650@catbus: nickm \| 2007-02-05 17:02:54 -0500 Resolve (I hope) remaining nt service compilation issues. svn:r9489	2007-02-05 22:02:58 +00:00
Nick Mathewson	d930440ae5	r11648@catbus: nickm \| 2007-02-05 16:48:50 -0500 Fix bugs in last nt services patch: syntax, typename. svn:r9488	2007-02-05 21:48:53 +00:00
Nick Mathewson	8b238404de	r11646@catbus: nickm \| 2007-02-05 16:15:48 -0500 Make default NT service user be LocalService. Again, I have no idea if this compiles, let alone if it works. svn:r9487	2007-02-05 21:15:52 +00:00
Nick Mathewson	337fdb7eb6	r11643@catbus: nickm \| 2007-02-05 15:44:59 -0500 Fix bug 254, sort of: make the default NT service user NetworkService rather than NULL (system). Also, add a --user argument to --service install so that admins can override this default: this latter point should take care of most of my objections to NetworkService. I have no idea whether this even compiles. svn:r9486	2007-02-05 20:45:02 +00:00
Nick Mathewson	47ff0c7fc1	r11641@catbus: nickm \| 2007-02-05 13:59:26 -0500 Add a REMAP state to stream events so that controllers can learn exactly when the target address for a stream has changed. May help Vidalia resolve confusions related to bug 375. svn:r9484	2007-02-05 19:15:13 +00:00
Nick Mathewson	f02be02356	r11639@catbus: nickm \| 2007-02-05 13:33:38 -0500 Add documentation to src/common/*.h; improve documentation for SMARTLIST_FOREACH; remove never-used options and corresponding tests from tor_strpartition. svn:r9483	2007-02-05 18:33:52 +00:00
Nick Mathewson	03ef2156c9	r11637@catbus: nickm \| 2007-02-05 12:41:51 -0500 Fix an XXXX012, and make circuits_pending_or_conns a static variable. In addition to cleaning up the code, this may also resolve Bug 386 if Roger has the right intuition there. svn:r9482	2007-02-05 17:42:40 +00:00
Nick Mathewson	6149ab01f8	r12129@Kushana: nickm \| 2007-02-03 09:57:36 -0500 Update assert_connection_ok() to match the "block tunnelled dir conn if the or conn is full" logic. This may fix bug 385. svn:r9479	2007-02-03 14:57:47 +00:00
Nick Mathewson	275109d8b0	r11631@catbus: nickm \| 2007-02-02 15:39:53 -0500 Add missing return statement. svn:r9478	2007-02-02 20:39:55 +00:00
Nick Mathewson	fefba95363	r11629@catbus: nickm \| 2007-02-02 15:06:17 -0500 Removing the last DOCDOC comment hurt so much that I had to use Doxygen to identify undocumented macros and comments, and add 150 more DOCDOCs to point out where they were. Oops. Hey, kids! Fixing some of these could be your first Tor patch! svn:r9477	2007-02-02 20:06:43 +00:00
Nick Mathewson	e521c96cb1	r12123@Kushana: nickm \| 2007-02-02 13:57:42 -0500 Resolve remaining DOCDOC comments. svn:r9476	2007-02-02 18:58:11 +00:00
Nick Mathewson	07e6eecdb2	r12122@Kushana: nickm \| 2007-02-02 10:41:39 -0500 Fail when we are unable to parse the nameserver configuration. svn:r9475	2007-02-02 18:58:04 +00:00
Nick Mathewson	8507699256	r11624@catbus: nickm \| 2007-02-01 13:17:35 -0500 Note a few questionable bits pointed out by RATS. (And no, RATS, I'm not about to stop having fixed-sized local buffers for you. I know how to use them, thankyouverymuch.) svn:r9474	2007-02-01 18:33:02 +00:00
Nick Mathewson	6f2a92c5b3	r11621@catbus: nickm \| 2007-02-01 13:09:18 -0500 Fix another VC compiler warning. svn:r9473	2007-02-01 18:09:34 +00:00
Nick Mathewson	5cb99857bc	r11620@catbus: nickm \| 2007-02-01 13:06:27 -0500 Call stat() slightly less often; use fstat() when possible. svn:r9472	2007-02-01 18:09:27 +00:00
Nick Mathewson	e7ac17fdf5	r11613@catbus: nickm \| 2007-01-30 19:58:03 -0500 Re-enable server side PTR-record cacheing. svn:r9468	2007-01-31 00:58:06 +00:00
Nick Mathewson	49b5e5cf9c	r11610@catbus: nickm \| 2007-01-30 17:44:02 -0500 Fix a bug in our assertions related to removing recently-completed DNS lookup attempts on exit. It is okay to find a cache entry with the same name as a DONE entry, so long it is not the same struct as the DONE entry. svn:r9467	2007-01-30 22:44:24 +00:00
Nick Mathewson	76f896e714	r11607@catbus: nickm \| 2007-01-30 17:19:27 -0500 Audit non-const char arguments; make a lot more of them const. svn:r9466	2007-01-30 22:19:41 +00:00
Nick Mathewson	1894e7ea01	r11606@catbus: nickm \| 2007-01-30 16:52:23 -0500 Write the entry guards section of path-spec; note a possible bug in cirbuitbuild.c; add a const; defer work on torrc.complete to be part of a bigger config documentation reorg. svn:r9465	2007-01-30 22:19:31 +00:00
Nick Mathewson	a701cd7e97	r11591@catbus: nickm \| 2007-01-29 17:31:02 -0500 Add an XXXX comment to dirserv.c so I can take it out of my todo email folder. svn:r9459	2007-01-29 23:09:22 +00:00
Nick Mathewson	cd374f810c	r11586@catbus: nickm \| 2007-01-29 13:13:27 -0500 Add a couple of fixes I turned up while writing regression tests for libevent: Allow DNS servers on ports other than 53, and handle TTLs correctly on reverse hostname lookups. svn:r9458	2007-01-29 18:13:42 +00:00
Nick Mathewson	ac0dbc3d9b	r11585@catbus: nickm \| 2007-01-29 11:26:03 -0500 Oops; fix compilation. svn:r9457	2007-01-29 18:13:39 +00:00
Nick Mathewson	42d03890b4	r11584@catbus: nickm \| 2007-01-29 11:25:40 -0500 Fix/update some XXX012 points. svn:r9456	2007-01-29 18:13:37 +00:00
Nick Mathewson	21f5e06862	r11583@catbus: nickm \| 2007-01-29 11:19:48 -0500 Make man page stop saying that BandwidthRate is for incoming bandwidth only; Add some XXX012s for config options that should maybe die. svn:r9455	2007-01-29 18:13:34 +00:00
Roger Dingledine	f58678730c	there's such a thing as too much indirection svn:r9451	2007-01-28 08:06:00 +00:00
Roger Dingledine	1fea3a1e59	stop trying to hand 'platform' all around directory.c when we have a bit in routerstatus_t that tells us what we need to know. svn:r9448	2007-01-27 21:18:08 +00:00
Roger Dingledine	88796acf4b	fix all the bugs i could find in nick's bridge dir commit. let's hope i got them all. svn:r9442	2007-01-27 20:44:09 +00:00
Roger Dingledine	d8d074f2e5	If the user asks to use invalid exit nodes, be willing to use the unstable ones. svn:r9441	2007-01-27 19:40:49 +00:00
Roger Dingledine	add7d7af19	Bring us one step closer to being able to establish an encrypted directory tunnel without knowing a descriptor first. Still not ready yet. As part of the change, now assume we can use a create_fast cell if we don't know anything about a router. svn:r9440	2007-01-27 19:29:16 +00:00
Roger Dingledine	b323126dda	remove an XXX; add two more. svn:r9438	2007-01-27 19:02:37 +00:00
Roger Dingledine	283c61e5d5	If the socks handshake hasn't started, don't send a "DNS resolve socks failed" handshake reply; just close it. svn:r9437	2007-01-27 18:56:13 +00:00
Roger Dingledine	baeeadb6eb	avoid messy crashes (bugfix by nick) svn:r9435	2007-01-27 18:33:33 +00:00
Roger Dingledine	c6fd3c7158	the other half of my patch. more coming later. svn:r9434	2007-01-27 09:24:23 +00:00
Roger Dingledine	9057af692a	Weight directory requests by advertised bandwidth. Now we can let servers enable write limiting but still allow most clients to succeed at their directory requests. svn:r9433	2007-01-27 09:13:19 +00:00
Nick Mathewson	9984cad6e8	r11552@catbus: nickm \| 2007-01-27 03:55:02 -0500 This one is a little tricky. Our BEGIN_DIR implementation has a problem: the dirserv conns will decide they can flush all their data immediately, since the edge_conns will read greedily. For our 0.1.2 workaround, we track which or_conn a bridged dirserv conn is attached to, and stop writing when its outbuf is too full, and start writing again when the or_conn's outbuf empties out a little. This requires a bit of pointer management. Let's hope it works. svn:r9432	2007-01-27 08:55:06 +00:00
Nick Mathewson	152547be49	r11548@catbus: nickm \| 2007-01-27 00:15:47 -0500 Fix two assert bugs encountered when trying ipv6 lookups with eventdns code. svn:r9430	2007-01-27 05:15:53 +00:00
Roger Dingledine	e9f6456b2c	Bugfix: If we're not marking exits as guards, ignore exit bandwidth when we're deciding the required bandwidth to become a guard. svn:r9423	2007-01-26 09:03:20 +00:00
Roger Dingledine	75a5fde460	Stop saying !is_internal_IP() when we really meant connection_is_rate_limited(). One day this will be useful. svn:r9422	2007-01-26 08:13:53 +00:00
Roger Dingledine	99c1771432	never refuse directory requests from local addresses svn:r9421	2007-01-26 08:01:29 +00:00
Roger Dingledine	9d5449c52e	Inform the server operator when we decide not to advertise a DirPort due to AccountingMax enabled or a low BandwidthRate. It was confusing Zax, so now we're hopefully more helpful. svn:r9404	2007-01-25 19:41:15 +00:00
Nick Mathewson	75db2a61cb	r11500@catbus: nickm \| 2007-01-25 10:37:11 -0500 Fix argument types in printf: try to make buildbot happier. svn:r9403	2007-01-25 15:37:14 +00:00
Roger Dingledine	bf9baa85a8	more hints as arma tracks down a polipo bug svn:r9400	2007-01-24 23:58:41 +00:00
Nick Mathewson	71f47320f8	r11493@catbus: nickm \| 2007-01-24 18:41:52 -0500 Use set_uint16/32 instead of raw assignments in order to make gcc happier. svn:r9399	2007-01-24 23:42:00 +00:00
Nick Mathewson	5cd1f0680e	r11287@catbus: nickm \| 2007-01-23 20:30:04 -0500 Yet more documentation. (Again, trying to see whether I have buildbot working). svn:r9396	2007-01-24 01:30:07 +00:00
Roger Dingledine	c716eefbca	start tracking down a funny-looking log message svn:r9395	2007-01-24 01:18:45 +00:00
Nick Mathewson	792f819212	r11285@catbus: nickm \| 2007-01-23 19:43:50 -0500 More documentation. (Again, trying to see whether I have buildbot working). svn:r9394	2007-01-24 00:43:52 +00:00
Nick Mathewson	2522c392bd	r11283@catbus: nickm \| 2007-01-23 19:20:47 -0500 Add documentation to dns.c (mainly to test new buildbot version) svn:r9393	2007-01-24 00:20:49 +00:00
Nick Mathewson	79dd306527	r11278@catbus: nickm \| 2007-01-23 14:22:27 -0500 More doxygen comments: this time mainly around spooling and storing directory information. svn:r9392	2007-01-23 19:22:52 +00:00
Nick Mathewson	ba53e0029f	r11277@catbus: nickm \| 2007-01-23 14:08:08 -0500 When logging TLS certificate and identity-related errors, scrub IP addresses for incoming connections, and distinguish between incoming and outgoing connections in log messages. Backport candidate. svn:r9391	2007-01-23 19:22:49 +00:00
Nick Mathewson	c0c67d28f5	r9727@catbus: nickm \| 2007-01-22 16:12:39 -0500 Remove redundant check for whether _connection_write_to_buf_impl is called with a zlib and a non-directory connection: TO_DIR_CONN will already assert if it gets a non-dir connection. svn:r9390	2007-01-23 19:22:46 +00:00
Nick Mathewson	adc5bb4d04	r9723@catbus: nickm \| 2007-01-22 15:47:17 -0500 Fix an XXXX012 in routerlist.c: when we do not have enough networkstatuses to launch router requests, do not launch router requests. Backport candidate. svn:r9388	2007-01-22 20:57:26 +00:00
Roger Dingledine	9f733c31cc	minor cleanups svn:r9387	2007-01-22 19:20:33 +00:00
Nick Mathewson	36620ca056	r9718@catbus: nickm \| 2007-01-22 14:13:00 -0500 Free CACHE_STATE_DONE cached_router_t items on dns_free_all(). svn:r9386	2007-01-22 19:13:02 +00:00
Nick Mathewson	84790d059f	r9715@catbus: nickm \| 2007-01-22 02:51:04 -0500 Document a few undocumented functions and arguments. svn:r9385	2007-01-22 07:51:06 +00:00
Roger Dingledine	ab838bddb8	Flush local controller connection buffers periodically as we're writing to them, so we avoid queueing 4+ megabytes of data before trying to flush. Also add a new XXX012. svn:r9382	2007-01-22 06:07:51 +00:00
Roger Dingledine	7b5f9887fa	resolve an XXX, add a new XXX, simplify some code svn:r9381	2007-01-22 05:59:59 +00:00
Nick Mathewson	033e20ca0b	r9709@catbus: nickm \| 2007-01-21 21:34:03 -0500 Fix memory leak on networkstatus 503. svn:r9380	2007-01-22 02:34:50 +00:00
Nick Mathewson	e0ae28d0cd	r9701@catbus: nickm \| 2007-01-21 13:21:25 -0500 Detect and reject another (harmless) class of DNS replies. Also, fix a couple of IPv6 bugs in evendns.c svn:r9379	2007-01-21 18:21:39 +00:00
Nick Mathewson	ff62a4d91b	r9692@catbus: nickm \| 2007-01-21 12:04:22 -0500 Detect pointer loops in DNS requests and replies; avoid infinite loop on such malformed replies. Fixes bug 380. svn:r9378	2007-01-21 17:05:10 +00:00
Roger Dingledine	bcbd289af5	If our system clock jumps back in time, don't publish a negative uptime in the descriptor. Also, don't let the global rate limiting buckets go absurdly negative. svn:r9377	2007-01-21 06:24:05 +00:00
Nick Mathewson	c57ef84fc5	r11987@Kushana: nickm \| 2007-01-19 14:57:28 -0500 Implement SOCKS_BAD_HOSTNAME status event. Defer remaining status events. Clean up control-spec.txt a little, and fill in recommendations for events. svn:r9374	2007-01-19 21:25:32 +00:00
Roger Dingledine	060be4c62b	man, i could have sworn that compiled svn:r9369	2007-01-18 03:42:45 +00:00
Roger Dingledine	a3eaabfeb2	Be willing to read or write on local connections (e.g. controller connections) even when the global rate limiting buckets are empty. svn:r9368	2007-01-18 03:38:24 +00:00
Roger Dingledine	cb472fc550	break out the big guns: reject dir requests much more aggressively. my vidalia bandwidth graph, when rate limiting to 32kB/s, has the "write" line constantly at 32kB. I can't imagine what's going on with the relay latency but it can't be good. svn:r9366	2007-01-17 01:29:54 +00:00
Roger Dingledine	8662f18102	boots and suspenders, or whatever the idiom is svn:r9365	2007-01-17 00:14:43 +00:00
Nick Mathewson	a36ec61fd7	r11983@Kushana: nickm \| 2007-01-16 10:28:47 -0500 Be even more clever about severity of messages from eventdns: NOTICE when the first nameserver comes up; INFO on subsequent ones. svn:r9364	2007-01-16 17:39:08 +00:00
Nick Mathewson	093d71762c	r11978@Kushana: nickm \| 2007-01-15 18:54:25 -0500 Apparently, the OpenBSD linker thinks it knows C better than I do, and gets to call me names for having strcat and strcpy and sprintf in my code--whether I use them safely or not. All right, OpenBSD. You win... this round. svn:r9360	2007-01-15 23:56:38 +00:00
Nick Mathewson	11ed4500de	r11975@Kushana: nickm \| 2007-01-15 17:11:15 -0500 set or_conn->tls_error to 0 on non-error to avoid looking at stale errors. svn:r9359	2007-01-15 22:11:21 +00:00
Nick Mathewson	db6f0f3617	r11973@Kushana: nickm \| 2007-01-15 16:43:25 -0500 Answer questions from r9348. svn:r9358	2007-01-15 21:44:59 +00:00
Nick Mathewson	23c18f1dc2	svn:r9357	2007-01-15 21:21:21 +00:00
Nick Mathewson	af857f2da5	r11967@Kushana: nickm \| 2007-01-15 16:13:15 -0500 tidy up more whitespace issues svn:r9356	2007-01-15 21:21:14 +00:00
Nick Mathewson	380f8983c7	r11966@Kushana: nickm \| 2007-01-15 16:12:17 -0500 Tidy up ORCONN reason patch from Mike Perry. Changes: make some of the handling of TLS error codes less error prone. Enforce house style wrt spaces. Make it compile with --enable-gcc-warnings. Only set or_conn->tls_error in the case of an actual error. Add a changelog entry. svn:r9355	2007-01-15 21:21:05 +00:00
Nick Mathewson	ead35ef944	r11957@Kushana: nickm \| 2007-01-15 15:25:57 -0500 Patch from Mike Perry: Track reasons for OR connection failure; display them in control events. Needs review and revision. svn:r9354	2007-01-15 21:13:37 +00:00
Roger Dingledine	37b5132ad8	Expire socks connections if they spend too long waiting for the handshake to finish. Previously we would let them sit around for days, if the connecting application didn't close them either. Also take this opportunity to refactor a duplicate bit of circuituse.c. And change the semantics of SocksTimeout slightly, but I think it'll be ok. svn:r9350	2007-01-15 09:09:03 +00:00
Roger Dingledine	a9c250837e	patch from edmanm to make "-nt-service" command-line work too svn:r9349	2007-01-15 08:52:01 +00:00
Roger Dingledine	cf7069fca4	two more todo items, to make eventdns log messages less loud svn:r9348	2007-01-15 08:40:50 +00:00
Andrew Lewman	930e12920d	Update copyright in config.c while I'm there. Update man page to reflect all available options to tor binary. svn:r9341	2007-01-13 05:09:09 +00:00
Nick Mathewson	c1b5f53679	r11938@Kushana: nickm \| 2007-01-11 11:02:28 -0500 Check addresses for rfc953-saneness at exit too, and give a PROTOCOL_WARN when they fail. Also provide a mechanism to override this, so blossom can have its @@##$$^.whatever.exit hostnames if it wants. svn:r9336	2007-01-11 16:02:39 +00:00
Nick Mathewson	3dfeaaaf6e	r11931@Kushana: nickm \| 2007-01-11 09:12:49 -0500 Fix a crash bug in the presence of DNS hijacking. svn:r9333	2007-01-11 14:13:13 +00:00
Nick Mathewson	0c77ae2fcb	r11930@Kushana: nickm \| 2007-01-11 09:05:27 -0500 fix recently-introduced segfault when not running as a dirserver svn:r9332	2007-01-11 14:13:04 +00:00
Roger Dingledine	7beb0fd5dd	Make the unit tests work again. The foo_init() funcs need to happen before we call options_act() and friends. svn:r9331	2007-01-11 01:41:07 +00:00
Roger Dingledine	35bd6caa1a	Fix crash with "tor --list-fingerprint" (reported by seeess). svn:r9328	2007-01-10 23:48:24 +00:00
Nick Mathewson	8835bb844e	r11922@Kushana: nickm \| 2007-01-10 15:43:18 -0500 Clear untrusted networkstatuses after 10 days too. (This is not a terribly awful bug, since we would only ever retain 16 of them, but it still might be nice to backport.) Resolves part A of bug 372. svn:r9324	2007-01-10 20:43:40 +00:00
Nick Mathewson	9937695598	r11919@Kushana: nickm \| 2007-01-10 13:32:48 -0500 Add some defensive programming to eventdns.c in an attempt to catch possible memory stomping bugs. svn:r9322	2007-01-10 19:49:21 +00:00
Nick Mathewson	ceefc1e9a7	r11914@dhcp-18-188-69-59: nickm \| 2007-01-10 11:20:59 -0500 Base skew calculation on conn->timestamp_lastwritten, not on now. svn:r9319	2007-01-10 16:33:40 +00:00
Roger Dingledine	794fedb0ad	some cleanups. more probably remain, but hey, it's an alpha. time to put out the bugfix release. svn:r9309	2007-01-09 05:14:34 +00:00
Roger Dingledine	c85ff4d6ab	Fix an assert error introduced in 0.1.2.5-alpha: if you're an advertised exit node, somebody might try to exit from you when you're bootstrapping and before you've built your descriptor yet. svn:r9305	2007-01-09 00:37:13 +00:00
Nick Mathewson	5239602dbc	r11873@Kushana: nickm \| 2007-01-06 02:32:18 -0500 Implement DNS-related status events. svn:r9285	2007-01-06 07:34:07 +00:00
Nick Mathewson	bc14afe064	r11872@Kushana: nickm \| 2007-01-06 02:14:12 -0500 Implement a control status event for bad libevent version/method combos. Warn that libevent <1.1 with select() is needlessly slow. Reply to comment. svn:r9284	2007-01-06 07:34:02 +00:00
Nick Mathewson	03d6e98111	r11868@Kushana: nickm \| 2007-01-06 01:32:55 -0500 Document how we set Guard a little better. svn:r9283	2007-01-06 06:32:59 +00:00
Nick Mathewson	d6073cc7fa	r11864@Kushana: nickm \| 2007-01-06 01:25:59 -0500 Fix an XXXX012 in connection.c: prevent overflows on unfeasibly-high-bandwidth servers on 32-bit architectures. svn:r9282	2007-01-06 06:27:15 +00:00
Nick Mathewson	aa7b72c97d	r11863@Kushana: nickm \| 2007-01-06 01:12:24 -0500 Fix computation of total_exit_bandwidth; this will cause exits not to get recommended as guards if the total exit bandwidth if they constitute less than a third of total available bandwidth. There may be problems here with flapping; lets see if they occur in practice. svn:r9281	2007-01-06 06:26:53 +00:00
Nick Mathewson	336624ce8f	r11862@Kushana: nickm \| 2007-01-06 01:05:15 -0500 Re-enable warning when we resolve an already resolved address. We only warn here now if the address is not a testing address. Also, refactor out a function to check whether an address is used for testing. svn:r9280	2007-01-06 06:26:46 +00:00
Nick Mathewson	c8466c5919	r11824@Kushana: nickm \| 2007-01-03 17:15:28 -0500 control-spec: upcase arguments in status events; note unimplemented events individually r11825@Kushana: nickm \| 2007-01-03 17:41:43 -0500 Implement EXTERNAL IP server status event. r11826@Kushana: nickm \| 2007-01-03 17:47:10 -0500 Implement BAD_SERVER_DESCRIPTOR server status event. r11827@Kushana: nickm \| 2007-01-03 18:01:56 -0500 Implement SOCKS_UNKNOWN_PROTOCOL and DANGEROUS_SOCKS client events. r11828@Kushana: nickm \| 2007-01-03 18:23:22 -0500 Implement BUG controller events. Also, flush ERR-level status events just like ERR-level log messages. r11829@Kushana: nickm \| 2007-01-03 23:37:27 -0500 Yet more status events: CLOCK_SKEW, GOOD/ACCEPTED_SERVER_DESCRIPTOR, {CHECKING_}REACHABILITY_{SUCCEEDED\|FAILED} r11833@Kushana: nickm \| 2007-01-05 16:56:37 -0500 Note some unimplementedness in control-spec.txt svn:r9279	2007-01-06 05:42:31 +00:00
Nick Mathewson	135aed5670	r11850@Kushana: nickm \| 2007-01-05 17:12:08 -0500 Look in netinet/in6.h header when looking for struct in6_addr. (Issue found by saeftl.) svn:r9272	2007-01-05 22:12:15 +00:00
Roger Dingledine	48a9fe4bbd	be a bit less eager to reject v1 dir requests due to load svn:r9271	2007-01-05 06:59:36 +00:00
Roger Dingledine	ee0d2d486d	fix a bug, defer a bug, bump to 0.1.2.5-alpha svn:r9270	2007-01-05 06:30:31 +00:00
Roger Dingledine	658c09c06f	more progress and cleanups svn:r9269	2007-01-05 06:03:10 +00:00
Roger Dingledine	466650aa14	when we added orport= to the dirserver line, we started freeing the string in the middle. this was probably xiando's crash bug. svn:r9265	2007-01-05 01:23:34 +00:00
Roger Dingledine	7b88380690	Avoid a double-free when parsing malformed DirServer lines. svn:r9264	2007-01-05 01:12:10 +00:00
Roger Dingledine	5e89bc9b4b	fix a bug i introduced in r9249; and more cleanups. svn:r9263	2007-01-04 09:12:23 +00:00
Roger Dingledine	a66d86149b	avoid a crash-all-the-clients segfault if a rogue dir authority leaves a "v" line blank. svn:r9262	2007-01-04 06:36:43 +00:00
Roger Dingledine	da2ff14839	Set orport= for 4 of the 5 dir authorities; Fix getinfo ns/all; Fix seg fault when starting a server without a fingerprint file present. svn:r9261	2007-01-04 05:41:24 +00:00
Roger Dingledine	50f0e36094	man page entries for TunnelDirConns and PreferTunneledDirConns and add a todo item for nick in case he gets bored :) svn:r9260	2007-01-04 04:35:18 +00:00
Roger Dingledine	88c3c84bda	be slightly less eager to yell at a server for being unreachable svn:r9259	2007-01-03 23:58:03 +00:00
Nick Mathewson	2963d4acc2	r11820@Kushana: nickm \| 2007-01-03 14:54:05 -0500 Add (and specify) a BadDirectory flag to networkstatuses, so authorities can tell clients that some caches are broken. Also, implement an as-yet-unused function to estimate how many bytes will be sent on a directory connection. svn:r9255	2007-01-03 19:58:00 +00:00
Nick Mathewson	931e555ef9	r11818@Kushana: nickm \| 2007-01-03 08:29:17 -0500 Fix compile error with warnings enabled: connection_dir_supports_tunnels was redeclared as static. svn:r9254	2007-01-03 13:29:30 +00:00
Roger Dingledine	50e36dc11b	more cleanups, including a shiny new XXX012 svn:r9250	2007-01-03 10:30:26 +00:00
Roger Dingledine	d677332a83	checkpoint as we add PreferTunneledDirConns config option svn:r9249	2007-01-03 06:33:03 +00:00
Nick Mathewson	eebbfbc854	r11806@Kushana: nickm \| 2007-01-03 00:12:21 -0500 Fix unit test broken by r9239. svn:r9248	2007-01-03 05:12:26 +00:00
Roger Dingledine	9545bbf57f	- When the user uses bad syntax in the Log config line, stop suggesting other bad syntax as a replacement. svn:r9247	2007-01-03 03:56:17 +00:00
Roger Dingledine	7396b8eecf	interim tweaks svn:r9246	2007-01-03 03:45:53 +00:00
Nick Mathewson	f5b984a36f	r11800@Kushana: nickm \| 2007-01-02 16:46:45 -0500 Remove an XXXX012 for which the answer is "not really." svn:r9244	2007-01-02 21:47:28 +00:00
Nick Mathewson	cbdd21cbf5	r11799@Kushana: nickm \| 2007-01-02 16:38:34 -0500 Simplify and remove most of dirserv_orconn_tls_cone svn:r9243	2007-01-02 21:47:21 +00:00
Nick Mathewson	2caeaf4e2f	r11787@Kushana: nickm \| 2007-01-02 14:40:14 -0500 Stop polluting new descriptors with the defaults-to-1 "opt eventdns" entry. svn:r9239	2007-01-02 20:08:03 +00:00
Nick Mathewson	75eca91459	r11786@Kushana: nickm \| 2007-01-02 14:32:54 -0500 Add a comment about a possible refactoring in main.c svn:r9238	2007-01-02 20:07:54 +00:00
Andrew Lewman	4f565b73ef	Fix formatting in eventdns.c. Remove the rest of the osx binary uninstaller. svn:r9235	2007-01-02 06:26:42 +00:00
Nick Mathewson	722a3ab544	r11784@Kushana: nickm \| 2007-01-02 01:13:04 -0500 Spec-conformance on r9181: make "opt v" strings start with "Tor". svn:r9233	2007-01-02 06:13:10 +00:00
Nick Mathewson	6ae3ba9b2d	r11777@Kushana: nickm \| 2007-01-01 21:01:10 -0500 Fix an idiot bug in r9181: snprintf returns <0 on error, not !=0. svn:r9232	2007-01-02 02:01:15 +00:00
Nick Mathewson	46092f8163	r11765@Kushana: nickm \| 2006-12-29 16:04:22 -0500 Remove duplicated code in dirserv_get_networkstatus_v2; document dirserv_get_networkstatus_v2_fingerprints. Down to 13 XXXX012 items. svn:r9220	2006-12-30 02:41:14 +00:00
Nick Mathewson	c54b7c4d56	r11761@Kushana: nickm \| 2006-12-29 15:45:56 -0500 Another cleanup: expand_exit_policy_aliases was totally redundant with respect to router_parse_[private_]addr_policy_private. svn:r9219	2006-12-29 20:50:24 +00:00
Nick Mathewson	7ee99ba342	r11759@Kushana: nickm \| 2006-12-29 15:21:14 -0500 Actually, handle_getinfo_helper supports 552 results just fine: just leave *answer unset. svn:r9217	2006-12-29 20:49:47 +00:00
Nick Mathewson	e3d5e4fcae	Okay, now descriptors seem to be buildable. svn:r9216	2006-12-29 17:10:29 +00:00
Nick Mathewson	2741dd5741	r11755@Kushana: nickm \| 2006-12-29 11:49:20 -0500 Calculate the length of policy strings correctly again. svn:r9215	2006-12-29 16:49:33 +00:00
Nick Mathewson	a77bbe2346	r11753@Kushana: nickm \| 2006-12-29 11:30:28 -0500 Fix flipped sign in compare: make descriptors buildable again. svn:r9214	2006-12-29 16:31:37 +00:00
Nick Mathewson	6fbf17e7b0	r11749@Kushana: nickm \| 2006-12-29 00:51:42 -0500 Remove dead code; make targets of addressmap commands/configs use AllowNonRFC953Hostnames svn:r9211	2006-12-29 05:51:50 +00:00
Nick Mathewson	0e172d9f6e	r11745@Kushana: nickm \| 2006-12-29 00:00:28 -0500 Close any directory connection on which we have received 10MB or more of data. This prevents a malicious directory cache from running us out of memory by spooling an infinite amount of data. (Not a terribly good attack, but hey, every one helps.) svn:r9210	2006-12-29 05:07:25 +00:00
Nick Mathewson	8728e2826f	r11744@Kushana: nickm \| 2006-12-28 23:43:53 -0500 Refactor connection_write_to_buf_zlib back into connection_write_to_buf. Hooray for dumping duplicate code. svn:r9209	2006-12-29 05:07:04 +00:00
Nick Mathewson	26c0d6ec58	r11743@Kushana: nickm \| 2006-12-28 23:13:21 -0500 Refactor _connection_controller_force_write back into conncetion_handle_write. Again, the line count goes down: groovy! svn:r9208	2006-12-29 05:06:47 +00:00
Nick Mathewson	361998d0f3	r11741@Kushana: nickm \| 2006-12-28 22:41:29 -0500 Count TLS bytes accurately: previously, we counted only the number of bytes read or transmitted via tls, not the number of extra bytes used to do so. This has been a lonstanding wart. The fix "Works for me". svn:r9207	2006-12-29 03:42:46 +00:00
Nick Mathewson	7cfdac1bf6	r11737@Kushana: nickm \| 2006-12-28 18:32:13 -0500 Remove some dead code; refactor some duplicated code. svn:r9206	2006-12-29 02:49:12 +00:00
Nick Mathewson	b59573949e	r11736@Kushana: nickm \| 2006-12-28 17:46:23 -0500 Mark a pile of XXXX comments as targetted for 0.1.2: some because they look important, some because they look easy. svn:r9205	2006-12-29 02:47:51 +00:00
Nick Mathewson	0bbbf98be4	r11727@Kushana: nickm \| 2006-12-28 16:27:17 -0500 If we only have a single nameserver, raise the threshold to decide that the nameserver is dead. (Another fumbling attempt to do something about bug 326.) svn:r9203	2006-12-28 21:29:37 +00:00
Nick Mathewson	3996fd1d9d	r11726@Kushana: nickm \| 2006-12-28 16:24:06 -0500 Expose a function from eventdns.c to set options without having to make a fake configuration file. Also, add more settable options svn:r9202	2006-12-28 21:29:31 +00:00
Nick Mathewson	460a476efa	r11725@Kushana: nickm \| 2006-12-28 14:44:56 -0500 Partial solution to 326: downgrade single-nameserver failures to INFO. svn:r9201	2006-12-28 21:29:26 +00:00
Nick Mathewson	d9f1f3533d	r11724@Kushana: nickm \| 2006-12-28 14:22:35 -0500 Refactor and unify my-ip-addr-changed logic. Make change in IP address or in nameservers reset and relaunch DNS hijacking tests. svn:r9200	2006-12-28 21:29:20 +00:00
Nick Mathewson	e5f5b96ca6	r11723@Kushana: nickm \| 2006-12-28 13:52:48 -0500 Fix bug 364: check for whether popular hostnames (curently google, yahoo, mit, and slashdot) are getting wildcarded. If they are, we are probably behind a DNS server that is useless: change our exit policy to reject :. svn:r9199	2006-12-28 21:29:11 +00:00
Nick Mathewson	1df04d70f7	r11718@Kushana: nickm \| 2006-12-26 16:57:44 -0500 Add client-side caching for reverse DNS. svn:r9194	2006-12-26 22:41:43 +00:00
Nick Mathewson	58ae3cd648	r11713@Kushana: nickm \| 2006-12-24 22:42:08 -0500 Better handling of internal addresses wrt X-Your-Address-Is (never believe them; never provide them.) Also, report something useful for X-Your-Address-Is with one-hop tunneled connections. svn:r9191	2006-12-25 03:42:38 +00:00
Nick Mathewson	3ab84c5f48	r11711@Kushana: nickm \| 2006-12-24 21:42:57 -0500 Stop counting 503s against the total number of failures allowed for a download. svn:r9190	2006-12-25 02:47:37 +00:00
Nick Mathewson	a71a5d4bf2	r11706@Kushana: nickm \| 2006-12-24 01:50:52 -0500 Fix 2 bugs in last patch. (VS has weird ideas about const, and I have weird ideas about block structure.) svn:r9186	2006-12-24 06:50:57 +00:00
Nick Mathewson	bae366eff0	r11702@Kushana: nickm \| 2006-12-24 01:31:59 -0500 Patch from Edmanm, slightly modified. Original change list: - Support running the Tor service with a torrc not in the same directory as tor.exe (Bug #356) and default to using the torrc located in the %appdata%\Tor\ of the user who installed the service - Removed the supposedly misleading error message mentioned in Bug #294 - Fixed some CloseHandle()s that should've been CloseServiceHandle()s - Fixed some nt_service_foo() return values to be consistent - Resolved some nt_service_foo() DOCDOCs - Fixed one trivial typo that I happened to randomly notice Changes: - Make more comments into "imperative" house style. - Remove special handling for "-f"; only use --options. - Quote all options. - Clean up whitespace svn:r9185	2006-12-24 06:32:24 +00:00
Nick Mathewson	c12a1f1e3a	r11701@Kushana: nickm \| 2006-12-24 01:24:39 -0500 fix warning on win32. svn:r9184	2006-12-24 06:32:20 +00:00
Nick Mathewson	2e538d9918	r11694@Kushana: nickm \| 2006-12-23 23:09:20 -0500 Add a version entry to networkstatus documents; have this entry get parsed and used to calculate whether begin_dir is supported. svn:r9181	2006-12-24 04:09:48 +00:00
Nick Mathewson	339384238c	r11693@Kushana: nickm \| 2006-12-23 22:42:11 -0500 Stop requiring the "opt" keyword before unrecognized directory items. svn:r9180	2006-12-24 04:09:42 +00:00
Nick Mathewson	baac5389a1	r11690@Kushana: nickm \| 2006-12-23 22:09:53 -0500 Hmm. Maybe I should have been compiling these before I checked them in. svn:r9178	2006-12-24 03:09:58 +00:00
Nick Mathewson	d76b2a4ec0	r11688@Kushana: nickm \| 2006-12-23 22:08:36 -0500 Fix "r may be used uninitialized" warning from last patch. svn:r9177	2006-12-24 03:08:44 +00:00
Nick Mathewson	bf1014692f	r11686@Kushana: nickm \| 2006-12-23 22:05:57 -0500 More changes wrt unnecessary disk writes. svn:r9176	2006-12-24 03:06:03 +00:00
Nick Mathewson	f3fd5d9032	r11680@Kushana: nickm \| 2006-12-23 21:45:05 -0500 Remove code to look for keys in their old locations: we havent stored them there since 0.0.7.2. svn:r9175	2006-12-24 02:45:53 +00:00
Nick Mathewson	bba5a3533f	r11679@Kushana: nickm \| 2006-12-23 21:38:41 -0500 Update the state file less often when AvoidDiskWrites is set. svn:r9174	2006-12-24 02:45:46 +00:00
Nick Mathewson	9efdf6acc5	r11677@Kushana: nickm \| 2006-12-23 21:17:54 -0500 Track when we get 503s from directory servers. Do not use directory servers that have given us a 503 until either an hour has passed, or we are are out of non-busy servers. svn:r9172	2006-12-24 02:45:35 +00:00
Nick Mathewson	4d948281c3	r11676@Kushana: nickm \| 2006-12-23 20:42:17 -0500 Add an orport option to dirserver lines so that clients can tell where to connect to open an encrypted tunnel to a dirserver even before they have its descriptor. svn:r9171	2006-12-24 02:45:27 +00:00
Roger Dingledine	488b4726a7	reinstate the most important dead chickens for limiting impact of directory writes now that we're write limiting. a few more dead chickens remain. svn:r9170	2006-12-23 08:48:16 +00:00
Nick Mathewson	bf74dcd855	r11658@Kushana: nickm \| 2006-12-20 15:58:44 -0500 Remove long-deprecated log and accounting options. svn:r9164	2006-12-20 21:02:10 +00:00
Nick Mathewson	2e1e919d65	r11657@Kushana: nickm \| 2006-12-20 15:11:19 -0500 Fixes to check-docs script; add some docs; mark some options as deprecated in the online docs. svn:r9163	2006-12-20 21:02:02 +00:00
Nick Mathewson	e9ad1650c0	r11651@Kushana: nickm \| 2006-12-20 12:05:04 -0500 Add a maintainer script and a new make target "make check-docs" to get a quick dump of which options are undocumented where, and which documentation refers to nonexistent options. svn:r9160	2006-12-20 17:05:48 +00:00
Roger Dingledine	00257212c7	Take out the '5 second' timeout from the connection retry schedule. Now the first connect attempt will wait a full 10 seconds before switching to a new circuit. Perhaps this will help a lot. Based on observations from Mike Perry. svn:r9159	2006-12-20 09:43:28 +00:00
Roger Dingledine	858d7295e7	minor cleanups svn:r9158	2006-12-20 09:25:58 +00:00
Nick Mathewson	baadf35c63	r11646@Kushana: nickm \| 2006-12-19 14:40:38 -0500 Resolve bug 363: do not fall back to 127.0.0.1 when no nameservers are configured. Instead, have the admin fix resolv.conf or configure a nameserver. svn:r9157	2006-12-19 19:49:03 +00:00
Nick Mathewson	bf6702cf8b	r11645@Kushana: nickm \| 2006-12-19 14:22:36 -0500 Reject hostnames with invalid characters, in an attempt to catch more errors earlier. Add an option to disable this behavior. svn:r9156	2006-12-19 19:48:58 +00:00
Nick Mathewson	280692d65f	r11643@Kushana: nickm \| 2006-12-19 13:15:14 -0500 Stop recommmending exits as guards when the exit bandwidth is less than a third of the total bandwidth. svn:r9154	2006-12-19 19:48:48 +00:00
Roger Dingledine	e66b6f0d50	Reject *:563 (NTTPS) in the default exit policy. We already reject NNTP by default, so this seems like a sensible addition. (suggested by bug 331) svn:r9149	2006-12-18 08:25:34 +00:00
Roger Dingledine	ad5ce3c7ed	fix whitespace; add a todo item svn:r9148	2006-12-18 08:24:22 +00:00
Nick Mathewson	973baa1673	r11630@Kushana: nickm \| 2006-12-17 22:02:24 -0500 Add a typedef to (try to) make eventdns work on mingw. Man, I need a buildbot for this. svn:r9147	2006-12-18 03:02:30 +00:00
Nick Mathewson	952b34d610	r11627@Kushana: nickm \| 2006-12-17 11:37:39 -0500 Remove an artificial upper bound on expected bandwidth. More immediately, fix a VC warning. svn:r9146	2006-12-17 16:37:46 +00:00
Roger Dingledine	b3b75a3bef	write-limiting fix: avoid a rare bug where we don't remember that there's stuff on the outbuf we want to flush. svn:r9142	2006-12-16 11:36:36 +00:00
Roger Dingledine	0cc7eaf302	remove some dead comments, and resolve some XXXs svn:r9141	2006-12-16 11:34:12 +00:00
Roger Dingledine	f175aca3a8	and then revert half of r9138 svn:r9140	2006-12-16 07:04:26 +00:00
Nick Mathewson	80b8abf7be	r11618@Kushana: nickm \| 2006-12-16 02:00:52 -0500 Make router_is_me work without calling router_rebuild_descriptor. svn:r9139	2006-12-16 07:00:59 +00:00
Roger Dingledine	9cd8feb649	fix an infinite loop and a memory leak in r9131 svn:r9138	2006-12-16 06:56:58 +00:00
Nick Mathewson	31e09bb524	r11614@Kushana: nickm \| 2006-12-15 17:39:42 -0500 Implement SETEVENTS GUARD. Needs review and testing. svn:r9137	2006-12-15 22:40:20 +00:00
Nick Mathewson	251f007b75	r11609@Kushana: nickm \| 2006-12-15 16:42:21 -0500 Implement GETINFO fingerprint. svn:r9136	2006-12-15 21:51:24 +00:00
Roger Dingledine	ce51a1d349	a changelog for write limiting. also, disable the "advertise dirport until we reach our max bandwidth if it's tiny" trick now that we do the bandwidth self-test on boot. svn:r9134	2006-12-15 21:39:35 +00:00
Nick Mathewson	f53a269928	r11598@Kushana: nickm \| 2006-12-15 15:59:00 -0500 Add internal documentation for a bunch of configuration options. We should do something to keep this list, the canonical list, the tor.1 list, and the torrc.complete list in sync. svn:r9133	2006-12-15 21:27:19 +00:00
Nick Mathewson	078aab810b	r11597@Kushana: nickm \| 2006-12-15 15:49:27 -0500 Add a rudimentary line-wrapping function for use in dumping comments in config files. svn:r9132	2006-12-15 21:26:23 +00:00
Nick Mathewson	ab2fc7bd62	r11596@Kushana: nickm \| 2006-12-15 10:57:12 -0500 Mark some TODO items as done. Also, never include ourself in our family list. svn:r9131	2006-12-15 21:26:15 +00:00
Roger Dingledine	bdf470c263	turn TunnelDirConns on by default. that's what alpha releases are for, right? svn:r9129	2006-12-15 21:06:21 +00:00
Roger Dingledine	c4ed331d8d	oh, and catch the other instance we should fix svn:r9122	2006-12-15 08:14:32 +00:00
Roger Dingledine	0bc0688668	if we rotate our onion key, publish a new descriptor, and die soon after, we want to stick with that onion key when we restart. svn:r9121	2006-12-15 07:58:31 +00:00
Nick Mathewson	38bd6837db	r11588@Kushana: nickm \| 2006-12-15 02:04:32 -0500 Add a LastRotatedOnionKey variable to the state file, so we can rotate onion keys a week after they change even if we never stay up for a whole week at a time. Should fix bug 368. svn:r9120	2006-12-15 07:04:37 +00:00
Roger Dingledine	2ae9615a0b	take the broken obsolete url out again. seriously, this line should stay out. how can we make this happen? svn:r9119	2006-12-15 06:22:52 +00:00
Nick Mathewson	62f711fcf3	r11585@Kushana: nickm \| 2006-12-15 01:11:49 -0500 Tabify eventdns so that it matches libevent house style. svn:r9118	2006-12-15 06:12:14 +00:00
Nick Mathewson	b16aa6412e	r11584@Kushana: nickm \| 2006-12-15 01:10:45 -0500 Try to reconcile (except for whitespace) eventdns with version in libevent, so it is easier for me to send merges. These changes should be cosmetic. (Ha!) svn:r9117	2006-12-15 06:12:01 +00:00
Nick Mathewson	fdb10ff0b5	r11580@Kushana: nickm \| 2006-12-15 00:09:46 -0500 Resolve bug 369: Check for integer underflow when printing "bytes left" accounting numbers. Also fix a copyright date that I noticed while reading the bug. Also make a buffer big enough that strings will not get truncated. All are backport candidates. svn:r9115	2006-12-15 05:12:42 +00:00
Roger Dingledine	c44dd3870e	clarify our use of local time vs GMT svn:r9109	2006-12-14 23:39:14 +00:00
Roger Dingledine	30e4f4f6ce	when we're doing a write split over the end of a circular buffer, make sure our tls_get_forced_write_size doesn't make it write whatever's after the buffer. this hasn't triggered yet, but it would be rare, so let's leave it in. svn:r9107	2006-12-14 03:26:42 +00:00
Nick Mathewson	c9c8072bd3	r11569@Kushana: nickm \| 2006-12-13 17:59:58 -0500 fix last fix svn:r9106	2006-12-13 23:00:05 +00:00
Nick Mathewson	43e06eba8b	r11566@Kushana: nickm \| 2006-12-13 17:46:24 -0500 Try to fix an assert failure in new write limiting code: make buffers.c aware of previous "forced" write sizes from tortls. svn:r9105	2006-12-13 22:46:42 +00:00
Roger Dingledine	5cce710e2b	Some more documentation and specs for CONNECT_DIR and BEGIN_DIR. Demand that BEGIN_DIR cells have an empty payload. svn:r9104	2006-12-13 22:42:52 +00:00
Roger Dingledine	04409f202d	reenable write limiting. nick finally convinced me this was a smart move. more todo sub-items remain for it. svn:r9101	2006-12-13 07:08:36 +00:00
Roger Dingledine	97c83a4c09	finish enabling begin-dir cells. require one-hop circs for socks-command-connect-dir streams, so we don't open new anonymity questions. svn:r9099	2006-12-13 02:49:45 +00:00
Roger Dingledine	0dbf725927	Infrastructure to test BEGIN_DIR cells. New socks command CONNECT_DIR. New config option TunnelDirConns that builds a circ ending at the directory server and delivers a BEGIN_DIR cell if it's running 0.1.2.2-alpha or later. We still need to make one-hop circs when appropriate, while making other conns avoid them. svn:r9098	2006-12-13 00:28:56 +00:00
Roger Dingledine	f5164ba61d	remove an XXXX that asked to get removed svn:r9097	2006-12-13 00:05:28 +00:00
Roger Dingledine	477438e6c7	a better fix. puts r8446 to bed. svn:r9096	2006-12-12 21:09:30 +00:00
Roger Dingledine	1efd377428	Fix a bug in 0.1.2.2-alpha that prevented clients from asking to resolve an address at a given exit node even when they ask for it by name. svn:r9095	2006-12-12 20:23:17 +00:00
Roger Dingledine	7217f3ca47	couldn't handle leaving this typo in svn:r9094	2006-12-12 20:20:48 +00:00
Roger Dingledine	ee144598c8	minor cleanups and notes svn:r9093	2006-12-12 20:19:54 +00:00
Nick Mathewson	9fa707f5d3	r11552@Kushana: nickm \| 2006-12-12 13:34:13 -0500 fix a signed/unsigned comparison in eventdns.c svn:r9092	2006-12-12 18:34:22 +00:00
Nick Mathewson	a3a00df69d	r11548@Kushana: nickm \| 2006-12-12 00:44:51 -0500 Merge whitespace and other changes from libevent svn:r9090	2006-12-12 05:45:19 +00:00
Nick Mathewson	494e45482a	r11536@Kushana: nickm \| 2006-12-11 22:48:21 -0500 Add ipv6 functionality to evdns. svn:r9089	2006-12-12 03:48:46 +00:00
Nick Mathewson	35d92f8245	r11498@Kushana: nickm \| 2006-12-11 21:40:24 -0500 Document all structures and (non-exported) functions. External documentation will probably wind up being a manpage, hopefully written by somebody else. svn:r9087	2006-12-12 02:57:02 +00:00
Nick Mathewson	097aec8e9d	r11497@Kushana: nickm \| 2006-12-11 21:17:45 -0500 Rename nameserver functions: every one should now have "server" in the name. svn:r9086	2006-12-12 02:56:54 +00:00
Nick Mathewson	707429e9a3	r11496@Kushana: nickm \| 2006-12-11 19:39:37 -0500 Clean up XXXX comments in evdns code. Make server_ports actually go away when their refcnt reaches zero. svn:r9085	2006-12-12 02:56:47 +00:00
Nick Mathewson	d22deb61d6	r11495@Kushana: nickm \| 2006-12-11 19:11:14 -0500 More evdns: tab fixes. Dont make users worry about flags. Set truncated flag correctly when generating responses, rather than just bailing out. svn:r9084	2006-12-12 02:56:41 +00:00
Nick Mathewson	abc1304aef	r11494@Kushana: nickm \| 2006-12-11 14:50:20 -0500 Export DNS types and classes in eventdns.h so that server code can use them. svn:r9083	2006-12-12 02:56:35 +00:00
Nick Mathewson	fc125b1ef4	r11493@Kushana: nickm \| 2006-12-11 14:28:42 -0500 Oops; apparently DNS replies are supposed to include the questions. Revise "add_ptr_reply" to accept an inaddr_arpa name instead of just the sockaddr_in. Also, add a "-servertest" function to the test code to see whether the DNS server logic is working. svn:r9082	2006-12-12 02:56:28 +00:00
Nick Mathewson	e53bca15e7	r11492@Kushana: nickm \| 2006-12-11 12:30:23 -0500 Implement dns server reply retry logic. svn:r9081	2006-12-12 02:56:23 +00:00
Nick Mathewson	c58d9494df	r11491@Kushana: nickm \| 2006-12-11 12:12:57 -0500 More DNS server hacking: everything except testing, and retries, and documentation, and Tor integration. svn:r9080	2006-12-12 02:56:20 +00:00
Nick Mathewson	991308fac9	svn:r9079	2006-12-12 02:56:17 +00:00
Nick Mathewson	ff029a635d	svn:r9077	2006-12-12 02:54:48 +00:00
Nick Mathewson	e190acf780	r9254@Kushana: nickm \| 2006-10-17 17:23:36 -0400 Implement dns label compression. Clients do not need this much; dns servers definitely do. svn:r9073	2006-12-12 02:50:17 +00:00
Nick Mathewson	e9d67b1162	r9099@Kushana: nickm \| 2006-10-05 17:42:55 -0400 start fleshing out some logic to build server support into eventdns. Still needs work and testing. svn:r9068	2006-12-12 02:49:45 +00:00
Roger Dingledine	ea93289590	fix another bug in r9052, pointed out by robert hogan svn:r9063	2006-12-10 17:30:33 +00:00
Roger Dingledine	e206d22297	some more cleanups and a bugfix on r9052 svn:r9062	2006-12-10 08:04:50 +00:00
Roger Dingledine	733882315d	resolve a buffer overflow / crash from r9051 svn:r9061	2006-12-10 04:50:33 +00:00
Roger Dingledine	f7319a0b6d	correction and cleanups on r9047 svn:r9060	2006-12-09 19:40:16 +00:00
Roger Dingledine	29099a98c2	fix xiando's bug -- we were reporting stuff about hibernation even though it wasn't enabled. svn:r9055	2006-12-09 02:55:40 +00:00
Nick Mathewson	81be0ad1e5	r11486@Kushana: nickm \| 2006-12-08 00:58:47 -0500 Fix a longstanding bug in eventdns related to timeouts: The timeout count was never actually reset to 0. Argh. Now we reset it to zero after we get a successful request, or after we notice that a nameserver is back up, or after we decide the nameserver is down because of timeouts. This may fix bug 326. svn:r9054	2006-12-08 05:59:21 +00:00
Nick Mathewson	cf04e1e6e7	r11479@Kushana: nickm \| 2006-12-07 23:38:54 -0500 Refactor GETINFO into a table-driven dispatch, as suggested by arma. My brain hurts. svn:r9052	2006-12-08 04:39:13 +00:00
Nick Mathewson	1567e13dc8	r11475@Kushana: nickm \| 2006-12-07 20:49:21 -0500 Make GETINFO dir/status/... work even when we are not a directory. Needs a little cleanup. Closes bug 263. svn:r9051	2006-12-08 01:50:02 +00:00
Roger Dingledine	566543a4f8	more changes on r9041 svn:r9049	2006-12-07 20:14:29 +00:00
Nick Mathewson	b4a90ca8a3	r11469@Kushana: nickm \| 2006-12-07 15:11:04 -0500 Round stored/transmitted values for bandwidth usage. This might make some attacks work less well. This might well be voodoo, but it gives me a warm fuzzy feeling. svn:r9048	2006-12-07 20:11:36 +00:00
Nick Mathewson	7c79495137	r11468@Kushana: nickm \| 2006-12-07 14:56:57 -0500 Revise logic used to flush state to disk. Now, we try to batch non-urgent changes so that we do not do too many writes, and we save very-non-urgent changes every once in a rare while, and we never save more than once per second. svn:r9047	2006-12-07 20:11:30 +00:00
Nick Mathewson	c304a10fd3	r11467@Kushana: nickm \| 2006-12-07 14:38:54 -0500 Whitespace cleanup svn:r9046	2006-12-07 20:11:24 +00:00
Nick Mathewson	6c8075d8a0	r11462@Kushana: nickm \| 2006-12-07 13:42:21 -0500 Make bandwidth accounting information get stored to the state file as well as bw_accounting. Read from the state file if it is more recent than bw_accounting, or if bw_accounting is not there. svn:r9044	2006-12-07 18:57:37 +00:00
Nick Mathewson	63e4cfbeb6	r11461@Kushana: nickm \| 2006-12-07 13:16:45 -0500 Change logging format of state file to only include non-default values. Adjust clients to never store bandwidth history in the state file. (Possible backport candidate.) svn:r9043	2006-12-07 18:57:29 +00:00
Nick Mathewson	26392fc75d	r11458@Kushana: nickm \| 2006-12-07 12:04:22 -0500 Fix bug 338: log verbose nicknames, not just keys, for intro points. Also, suppress intro point name logging when SafeLogging is 1. (The security part is a possible backport candidate.) svn:r9041	2006-12-07 17:04:44 +00:00
Nick Mathewson	8249f5d676	r11456@Kushana: nickm \| 2006-12-07 10:09:55 -0500 oops; removed one unmap too many in the tests. svn:r9040	2006-12-07 15:10:36 +00:00
Nick Mathewson	e6c467fe07	r11454@Kushana: nickm \| 2006-12-07 10:07:24 -0500 Apparently, we actually hit the nasty mmap-then-unlink behavior. Fix it. svn:r9039	2006-12-07 15:07:33 +00:00
Nick Mathewson	97e5e78afd	r11451@Kushana: nickm \| 2006-12-07 10:06:30 -0500 Apparently Windows takes a dim view of unlinking a file while it is mapped. Silly windows, did nobody ever tell you about inodes? svn:r9038	2006-12-07 15:06:38 +00:00
Roger Dingledine	44c55dad23	Fix an assert failure when the directory authority sets AuthDirRejectUnlisted and then receives a descriptor from an unlisted router (reported by seeess). svn:r9023	2006-12-04 18:54:01 +00:00
Nick Mathewson	a91c12f2e7	r9855@Kushana: nickm \| 2006-12-04 00:55:09 -0500 Merge circuit_about_to_close_connection and connection_about_to_close_connection. svn:r9021	2006-12-04 05:55:40 +00:00
Nick Mathewson	f90cd5bfc0	r9853@Kushana: nickm \| 2006-12-04 00:02:03 -0500 Patch from Fabian Keil: Fix return statement in get_pf_socket() svn:r9020	2006-12-04 05:09:09 +00:00
Roger Dingledine	c5b90daf86	cleanups, bump to 0.1.2.4-alpha svn:r9015	2006-12-02 22:47:46 +00:00
Nick Mathewson	d1fdabf1c7	r9843@Kushana: nickm \| 2006-11-30 17:22:25 -0500 Turn an xxxx0124 into an #ifdef; avoid leaking memory. svn:r9013	2006-11-30 22:23:01 +00:00
Roger Dingledine	ab68e312bd	actually, i think this fix was closest to what i originally intended. this way we don't call resolve-my-address, which yells and screams if we're using an internal address (mere clients should not have to care). svn:r8998	2006-11-26 20:01:45 +00:00
Nick Mathewson	116ae04c2d	r9399@totoro: nickm \| 2006-11-26 14:22:17 -0500 Actually, clients should try to guess their addresses. svn:r8997	2006-11-26 19:22:25 +00:00
Nick Mathewson	68142b18cd	r9396@totoro: nickm \| 2006-11-26 13:36:29 -0500 Fix router_new_address_suggestion() so it only changes last_guessed_ip() when it actually calls resolve_my_address(). (bug found by dev-girl) svn:r8996	2006-11-26 18:36:51 +00:00
Roger Dingledine	69ae0a2986	we were leaking all the fingerprints for !reject, !invalid, and !badexit lines in the approved-routers file. svn:r8974	2006-11-20 16:36:44 +00:00
Nick Mathewson	b1dc014fc6	r9347@totoro: nickm \| 2006-11-20 11:24:46 -0500 11:23 < armadev> typo 11:23 < nickm> ? 11:23 < armadev> did you get the coffee yet? :) 11:23 < nickm> no 11:23 < armadev> i'm at an advantage..i haven't slept yet svn:r8972	2006-11-20 16:26:52 +00:00
Nick Mathewson	b4ea6136a4	r9345@totoro: nickm \| 2006-11-20 11:22:10 -0500 Fix a small and unlikely memory leak in dirserv.c. I think this is not the one arma is looking for. svn:r8971	2006-11-20 16:22:46 +00:00
Nick Mathewson	aef64c1277	r9577@Kushana: nickm \| 2006-11-20 11:07:28 -0500 Oops; fix bug in last fix. Time to get some coffee. svn:r8970	2006-11-20 16:07:33 +00:00
Nick Mathewson	a667f2e514	r9567@Kushana: nickm \| 2006-11-20 11:05:59 -0500 Fix leak in choose_good_exit_server_general() svn:r8969	2006-11-20 16:06:09 +00:00
Nick Mathewson	e2abc727e5	r9561@Kushana: nickm \| 2006-11-16 22:32:54 -0500 Tweaks to test-connection patch: use ".noconnect" instead of ".test" (since there are lots of ways to test things). Use a regular sequence of STREAM events (NEW followed by CLOSED) instead of a new event type. Make the function that checks the address be static and use const and strcasecmpend properly. svn:r8959	2006-11-17 03:34:58 +00:00
Nick Mathewson	d125c61e02	r9560@Kushana: nickm \| 2006-11-16 22:09:12 -0500 Check in an implementation of "test" connections from Scott Squires: these connections immediately close upon reaching Tor. They're useful for apps that want to check whether they're talking to the same Tor as a given controller. (I'll be tweaking this a bit before I push.) svn:r8958	2006-11-17 03:34:44 +00:00
Nick Mathewson	b052b810e2	r9319@totoro: nickm \| 2006-11-14 13:04:50 -0500 Patch from Zajcev Evgeny to make natd work properly (we needed to allow extra characters after the port number). svn:r8952	2006-11-14 18:05:01 +00:00
Nick Mathewson	ad1f019110	r9317@totoro: nickm \| 2006-11-13 22:45:33 -0500 Fix some more mipspro warnings. Nothing should remain excecpt "conversion from pointer to same-sized integral type." svn:r8950	2006-11-14 03:45:48 +00:00
Nick Mathewson	9243e54177	r9313@totoro: nickm \| 2006-11-13 20:07:41 -0500 Try to compile with fewer warnings on irix64's MIPSpro compiler / environment, which apparently believes that: - off_t can be bigger than size_t. - only mean kids assign things they do not subsequently inspect. I don't try to fix the "error" that makes it say: cc-3970 cc: WARNING File = main.c, Line = 1277 conversion from pointer to same-sized integral type (potential portability problem) uintptr_t sig = (uintptr_t)arg; Because really, what can you do about a compiler that claims to be c99 but doesn't understand that void* x = NULL; uintptr_t y = (uintptr_t) x; is safe? svn:r8948	2006-11-14 01:07:52 +00:00
Nick Mathewson	0f6402f17b	r9309@totoro: nickm \| 2006-11-13 19:05:41 -0500 Whitespace fixes, and clean up code from last natd patch. svn:r8947	2006-11-14 00:06:45 +00:00
Nick Mathewson	1913cb915e	r9308@totoro: nickm \| 2006-11-13 18:41:23 -0500 Add support for (Free?)BSD's natd, which was an old way to let you have your firewall automatically redirect traffic. (Original patch from Zajcev Evgeny, updated for 0.1.2.x by tup.) svn:r8946	2006-11-14 00:06:31 +00:00
Nick Mathewson	fa6fbbc150	r9307@totoro: nickm \| 2006-11-13 18:25:56 -0500 Patch from tup based on patch from Zajcev Evgeny: Make TransPort work even when the server wants to talk before the client. svn:r8945	2006-11-14 00:06:02 +00:00
Nick Mathewson	0ad2fd1129	r9467@Kushana: nickm \| 2006-11-01 18:51:16 -0500 Allow larger amounts of drift in uptime to be "cosmetic". svn:r8891	2006-11-01 23:53:15 +00:00
Nick Mathewson	5d7ca19b44	r9465@auth3-479: nickm \| 2006-11-01 13:16:21 -0500 Add some temporary code to count how many distinct router digests we verify. (I have a sneaking suspicion that the numbers look way way high.) svn:r8890	2006-11-01 18:16:44 +00:00
Peter Palfrader	c195b8f806	r10475@danube: weasel \| 2006-11-01 14:33:35 +0100 Fix copy/paste error svn:r8889	2006-11-01 13:33:49 +00:00
Nick Mathewson	31e274ddd3	r9461@Kushana: nickm \| 2006-10-31 20:30:12 -0500 Oops. Fix compile error in last build. svn:r8888	2006-11-01 01:30:25 +00:00
Nick Mathewson	9e13a6f31c	r9457@Kushana: nickm \| 2006-10-31 18:35:17 -0500 Do not warn when an OR gives us a new circuit end reason. (This will prevent bug 351 from recurring.) svn:r8887	2006-10-31 23:35:50 +00:00
Nick Mathewson	1bf1f9d2fc	r9449@Kushana: nickm \| 2006-10-31 00:12:02 -0500 Dump breakdown of PK operations when we get a USR2 signal. This should help us figure out of we are doing some of them for stupid reasons. svn:r8881	2006-10-31 19:17:07 +00:00
Roger Dingledine	8a781f7f34	general cleanups from looking through or-cvs svn:r8855	2006-10-29 07:41:25 +00:00
Roger Dingledine	8f7940348f	Avoid an infinite loop on evil controlport input. Fixes bug 350, unless it doesn't. (Nick, please confirm.) Backport candidate. svn:r8844	2006-10-28 08:17:02 +00:00
Roger Dingledine	e473ca2427	give a nicer warning message when windows people try to configure syslog in their torrc svn:r8841	2006-10-27 19:35:12 +00:00
Nick Mathewson	5b72dc77ad	r9395@Kushana: nickm \| 2006-10-26 22:06:51 -0400 Fix Bug 349: Have GETINFO network-status return even old routers, and use long nicknames where appropriate. Document this. svn:r8834	2006-10-27 02:07:04 +00:00
Nick Mathewson	3fbb292bff	r9389@Kushana: nickm \| 2006-10-25 17:46:16 -0400 Add a CLEARDNSCACHE signal to clear the client-side DNS cache. svn:r8829	2006-10-25 21:46:21 +00:00
Nick Mathewson	5c670a186c	r9386@Kushana: nickm \| 2006-10-25 17:35:38 -0400 Resolve bug 347: translate v0 controller signal numbers into internal signal numbers; leave v1 signal numbers alone. svn:r8828	2006-10-25 21:39:42 +00:00
Nick Mathewson	4df90e455c	r9164@totoro: nickm \| 2006-10-24 17:50:43 -0400 Oops: 17:50 < armadev> today is opposite day? svn:r8822	2006-10-24 21:51:06 +00:00
Nick Mathewson	6b7d1c94da	r9162@totoro: nickm \| 2006-10-24 17:41:35 -0400 Make "boolean !=" logic more obvious. svn:r8821	2006-10-24 21:41:48 +00:00
Nick Mathewson	a5bf6df14a	r9160@totoro: nickm \| 2006-10-24 17:38:07 -0400 More dirserver oops: actually set the digest for a given name in the case when the name is not yet recognized. svn:r8820	2006-10-24 21:38:31 +00:00
Nick Mathewson	ba1b04c736	r9158@totoro: nickm \| 2006-10-24 16:50:18 -0400 Oops on last authority patch: handle routers with unrecognized fingerprints correctly svn:r8819	2006-10-24 20:51:28 +00:00
Roger Dingledine	6877a7e1ee	and update the pile of getinfo strings that's impossible to remember to update svn:r8813	2006-10-24 04:55:02 +00:00
Nick Mathewson	6c7bf2f830	r9364@Kushana: nickm \| 2006-10-23 22:57:48 -0400 Remove reference to NS_FULL event; add two GETINFO targets. svn:r8812	2006-10-24 02:58:03 +00:00
Roger Dingledine	6ecf74af60	and blow away what appears to be some redundant logic svn:r8806	2006-10-23 10:17:52 +00:00
Roger Dingledine	77c8c0ee51	spec and implement some more status events. start to build some conventions. svn:r8805	2006-10-23 10:16:43 +00:00
Roger Dingledine	2a1c294717	implement a few status events, so we can make sure they work, and so vidalia can start handling them if it wants. svn:r8802	2006-10-23 05:51:46 +00:00
Roger Dingledine	c804eea39d	build on 64-bit again svn:r8801	2006-10-23 05:36:56 +00:00
Roger Dingledine	d48828dbe1	good thing we didn't have to track this bug down the old-fashioned way svn:r8800	2006-10-23 05:29:40 +00:00
Nick Mathewson	4401c47f63	r9347@Kushana: nickm \| 2006-10-23 01:24:48 -0400 Implement status event backend logic. svn:r8799	2006-10-23 05:24:57 +00:00
Nick Mathewson	27a3f0da2b	r9320@Kushana: nickm \| 2006-10-22 15:56:27 -0400 fix unittests; add more tests for smartlist stuff; make tests cache generated RSA keys (to speed up unittest run time by 30% and encourage people to run them more). svn:r8796	2006-10-23 03:48:58 +00:00
Nick Mathewson	ed69c10b3f	r9319@Kushana: nickm \| 2006-10-22 15:25:18 -0400 oops; include or.h changes for last patch. svn:r8795	2006-10-23 03:48:52 +00:00
Nick Mathewson	42bab1c6d3	r9318@Kushana: nickm \| 2006-10-22 15:22:57 -0400 Let directory authorities set the BadExit flag if they like. Also, refactor directory authority code so we can believe multiple things about a single router, and do fewer linear searches. svn:r8794	2006-10-23 03:48:42 +00:00
Roger Dingledine	07cfeb0198	fix a minor memory leak every time we rebuild the router store, fix a rare memory leak if something goes wrong while rebuilding it, and clean up some code. nick, please confirm. reported by "fookoowa" in flyspray 346 (yay!) svn:r8789	2006-10-22 08:08:10 +00:00
Roger Dingledine	0f33a548c2	fix a string, pointed out by matt edman. also fix a bug next to it that i noticed. svn:r8784	2006-10-21 02:51:35 +00:00
Roger Dingledine	a0ec758f9e	stop writing arbitrary memory out on the controller port. it's an ugly patch, but at least this way we can see that it's fixed. maybe clean up the whole "@" syntax later on. svn:r8783	2006-10-20 23:23:19 +00:00
Nick Mathewson	c9a01dea53	r9313@Kushana: nickm \| 2006-10-20 17:04:11 -0400 Oops. Conform to spec. svn:r8782	2006-10-20 21:04:44 +00:00
Nick Mathewson	01bc03eff4	r9312@Kushana: nickm \| 2006-10-20 14:45:22 -0400 Add an event type to tell the controller when our opinion of a router status has changed. I might have missed some cases here. svn:r8781	2006-10-20 21:04:39 +00:00
Roger Dingledine	0459db2c0d	checkpoint some changes as i read diffs svn:r8780	2006-10-20 19:11:12 +00:00
Nick Mathewson	b27cb38dee	r9307@Kushana: nickm \| 2006-10-20 13:53:54 -0400 Have connection_about_to_close use an end_reason field in edge_connection_t to tell what reason to tell the controller for closing the stream. Set end_reason in connection_edge_end, connection_mark_unattached_ap, and everwhere we set edge_has_sent_end. Add a changelog entry. svn:r8779	2006-10-20 17:54:48 +00:00
Nick Mathewson	8e94097edb	r9306@Kushana: nickm \| 2006-10-20 13:27:43 -0400 Enable reasons for stream events in all cases but CLOSED in about_to_close_connection. That one will take a little longer. svn:r8778	2006-10-20 17:54:43 +00:00
Nick Mathewson	12af87539b	r9303@Kushana: nickm \| 2006-10-20 12:07:34 -0400 Start implementing reason extension for stream events to match the one one used by circuit events. (Not a complete implementation yet; actual reasons are not passed to control.c) svn:r8777	2006-10-20 17:54:36 +00:00
Nick Mathewson	c8c36dd227	r9304@dhcp-18-188-67-85: nickm \| 2006-10-20 12:22:46 -0400 Change HT_INIT from a special-case to a macro-calling-a-function like the rest of ht.h. This might prevent errors if somebody did, I dunno, "HT_INIT(tp, hashtable++)". Based on a patch from Watson Ladd. svn:r8776	2006-10-20 16:22:53 +00:00
Nick Mathewson	2d7cf75e42	r9298@dhcp-18-188-67-85: nickm \| 2006-10-20 11:25:07 -0400 Weasel correctly notes that we should not discard the return value from connection_exit_begin_con. Right now, the return value is always discardable, so this does not actually cause a bug, but it might later. So fix it. svn:r8774	2006-10-20 15:26:02 +00:00
Nick Mathewson	e5f064c983	r9290@31-35-219: nickm \| 2006-10-20 10:32:33 -0400 Add a GETINFO target so controllers can ask Tor for the current state of a router. (Results given in networkstatus format.) svn:r8772	2006-10-20 14:58:29 +00:00
Nick Mathewson	136ed33071	r9289@31-35-219: nickm \| 2006-10-20 09:43:22 -0400 Fix longstanding bug in connection_exit_begin_conn(): Since connection_edge_end() exits when the connection is unattached, we were never sending RELAY_END cells back for failed RELAY_BEGIN attempts. Fix this. This might make clients that were otherwise timing out either fail faster or retry faster, which is good news for us. svn:r8770	2006-10-20 14:57:46 +00:00
Nick Mathewson	7f8d9e8af2	r9287@Kushana: nickm \| 2006-10-19 19:28:31 -0400 Weasel points out that a routerdesc requested by digest can never change. Weasel is right. svn:r8766	2006-10-19 23:28:38 +00:00
Nick Mathewson	974bdee183	r9277@Kushana: nickm \| 2006-10-19 19:03:05 -0400 Add pragma:no-cache and expires headers so that directory lookups can work better in the presence of caching HTTP proxies. (I would have used Cache-Control, but that is an HTTP/1.1 thing.) All timeouts are currently wild-assed guesses. svn:r8765	2006-10-19 23:05:34 +00:00
Nick Mathewson	f47c49228d	r9276@Kushana: nickm \| 2006-10-19 17:08:15 -0400 Add some more unit tests for policies. svn:r8764	2006-10-19 23:05:25 +00:00
Nick Mathewson	96caedecc7	r9275@Kushana: nickm \| 2006-10-19 16:45:19 -0400 Split smartlist tests into their own function, and add a couple more. Re-enable strmap iteration tests. Remove tests for code that doesnt exist any more (parse_nickname_list, identity ciphers). svn:r8763	2006-10-19 23:05:19 +00:00
Nick Mathewson	7551c44a53	r9274@Kushana: nickm \| 2006-10-19 16:16:58 -0400 Add unit tests for tor_mmap_file(); make tor_mmap_t.size always be the size of the file (not the size of the mapping); add an extra argument to read_file_to_str() so it can return the size of the result string. svn:r8762	2006-10-19 23:05:02 +00:00
Nick Mathewson	126a3f699a	r9273@Kushana: nickm \| 2006-10-19 15:43:39 -0400 Never discard a descriptor for being too old until either it is recommended by no authorities, or until we download a better (more recent and recommended) one for the same router. This will eventually make it possible for servers to publish less often. svn:r8761	2006-10-19 23:04:56 +00:00
Nick Mathewson	bfdb93d8bd	r9272@Kushana: nickm \| 2006-10-19 12:52:37 -0400 Fix an XXX in handling destroy cells: when we get a destroy cell with reason FOO, do not tell the controller REASON=FOO. Instead, say REASON=DESTROYED REMOTE_REASON=FOO. Suggested by a conversation with Mike Perry. svn:r8760	2006-10-19 23:04:49 +00:00
Nick Mathewson	4443934702	r9091@totoro: nickm \| 2006-10-19 11:45:28 -0400 Change to BadExit logic: Let authorities set an "I list bad exits" flag. Consider an exit bad if it is listed as bad by more than half of those authorities. This gives us a better migration path. svn:r8756	2006-10-19 15:45:48 +00:00
Nick Mathewson	df40c2e1ca	r9080@totoro: nickm \| 2006-10-19 11:00:16 -0400 Oops, forgot the patch: Use corect macro to detect cygwin builds (patch from Pei Hanru) svn:r8754	2006-10-19 15:02:02 +00:00
Nick Mathewson	3c459a7397	r9077@totoro: nickm \| 2006-10-18 11:41:16 -0400 Another patch from Mike Perry; sprintfing a NULL pointer. (with comment). svn:r8747	2006-10-18 15:41:46 +00:00
Nick Mathewson	efbe87cb6c	r9062@totoro: nickm \| 2006-10-17 11:19:43 -0400 Fix -Wlots with command.c (a uchar is never -1). Note also that one of our ifs is very stupid. svn:r8741	2006-10-17 15:20:20 +00:00
Nick Mathewson	faf7445255	r9061@totoro: nickm \| 2006-10-17 11:18:28 -0400 Oops. Libevent 1.2 exists. Add it to our enum, even though we dont care yet. svn:r8740	2006-10-17 15:20:15 +00:00
Nick Mathewson	b713b370bf	r9060@totoro: nickm \| 2006-10-17 11:12:48 -0400 Apply patch from Mike Perry: add more reasons for circuit destroys. (Slightly tweaked to avoid allocating a number for an "internal" reason.) svn:r8739	2006-10-17 15:20:00 +00:00
Roger Dingledine	7d33c4b904	clean up and downgrade some log messages svn:r8727	2006-10-15 07:42:51 +00:00
Roger Dingledine	584d598e8a	move the 'time jump' warning back to a higher threshold. this still occurs on moria sometimes if it's swapping to death. so be it. svn:r8725	2006-10-15 02:32:16 +00:00
Nick Mathewson	45b16c2d9e	r9021@totoro: nickm \| 2006-10-13 01:42:45 -0400 Fix for last patch. "", though empty, is true. This ain't Python, Nick. svn:r8701	2006-10-13 05:42:57 +00:00
Nick Mathewson	d453fd3709	r9019@totoro: nickm \| 2006-10-13 01:32:34 -0400 Fix extraneous space in CIRC events when path is empty. svn:r8700	2006-10-13 05:36:00 +00:00
Nick Mathewson	78043b8478	r9017@totoro: nickm \| 2006-10-13 01:27:33 -0400 Second patch to work on circuit close reasons from Mike Perry. Disabled partially; see comment. Whitespace cleaned up. svn:r8699	2006-10-13 05:27:59 +00:00
Nick Mathewson	eca28f24f5	r9004@totoro: nickm \| 2006-10-11 18:05:24 -0400 Add client support for a 'BadExit' flag, so authorities can say "Server X is a poor choise for your nytimes.com connections, as it seems to direct them to HoorayForMao.com or (more likely) WouldYouLikeToBuyTheseFineEncyclopedias.com" svn:r8690	2006-10-11 22:06:01 +00:00
Nick Mathewson	97e17d817b	r8985@totoro: nickm \| 2006-10-10 19:39:57 -0400 Fix a signed/unsigned compare in eventdns.c svn:r8685	2006-10-10 23:46:33 +00:00
Roger Dingledine	552d828def	- Stop triggering asserts if the controller tries to extend hidden service circuits. (also found by mwenge) svn:r8682	2006-10-09 22:26:21 +00:00
Roger Dingledine	655859f76b	When reporting verbose nicknames in entry_guards_getinfo(), avoid printing a duplicate "$" in the keys we send. (Reported by mwenge) svn:r8681	2006-10-09 21:26:34 +00:00
Roger Dingledine	86263acf95	Security bugfixes: When the user sends a NEWNYM signal, clear the client-side DNS cache too. Otherwise we continue to act on previous information. svn:r8679	2006-10-09 21:11:50 +00:00
Roger Dingledine	81dd9720f2	whitespace tweaks svn:r8677	2006-10-09 20:54:51 +00:00
Nick Mathewson	69e0843f7c	r8983@totoro: nickm \| 2006-10-09 14:19:18 -0400 Add missing ! to code to generate short/verbose nicknames for orconn events. svn:r8674	2006-10-09 18:19:32 +00:00
Nick Mathewson	26283e69ba	r8973@totoro: nickm \| 2006-10-09 11:45:47 -0400 Touch up last patch (to add REASON to CIRC events): make some reasons more sensible, send reasons only to controllers that have enabled extended events, and clean up whitespace. svn:r8672	2006-10-09 15:47:50 +00:00
Nick Mathewson	b76fd968b4	r8972@totoro: nickm \| 2006-10-09 10:36:22 -0400 Patch from Mike Perry: add a REASON field to closed and failed circ events. svn:r8671	2006-10-09 15:47:27 +00:00
Nick Mathewson	17abfa6a6a	r8971@totoro: nickm \| 2006-10-09 10:16:23 -0400 Move definition of ssize_t to torint.h svn:r8670	2006-10-09 15:47:08 +00:00
Nick Mathewson	829bf4dcd0	r8970@totoro: nickm \| 2006-10-09 10:12:53 -0400 Win32 patch from Matt Edman: fix compilation bugs by casting to int; defining SSIZE_T; defining USE_TWOS_COMPLEMENT in windows orconfig.h; and using the proper names for win32 functions on GetProcAddress. Also fixes bug 295. svn:r8669	2006-10-09 15:46:21 +00:00
Roger Dingledine	c639fd8258	was this one we missed? svn:r8666	2006-10-09 06:22:31 +00:00
Nick Mathewson	e618c15aff	r8967@totoro: nickm \| 2006-10-08 23:38:50 -0400 Fix some test and warn failures in last commit svn:r8665	2006-10-09 03:39:06 +00:00
Nick Mathewson	c6f2d725d0	r8957@totoro: nickm \| 2006-10-08 22:35:17 -0400 The otherwise regrettable MIPSpro C compiler warns about values set but never used, and about mixing enums and ints; these are good warnings, and so should be fixed. This removes some dead code and some potential bugs. Thanks to pnx. svn:r8664	2006-10-09 02:35:51 +00:00
Nick Mathewson	c341255034	r8956@totoro: nickm \| 2006-10-08 22:25:27 -0400 Fix bug with handling EVENT_NEW_DESC with verbose nicknames enabled. Also, check for tor_vsnprintf failure in controller messages. svn:r8663	2006-10-09 02:35:43 +00:00
Roger Dingledine	604b13c910	remove some old debugging code svn:r8657	2006-10-08 23:20:43 +00:00
Nick Mathewson	d1c8fd9759	r8947@totoro: nickm \| 2006-10-08 17:04:30 -0400 Fix signed/unsigned compare warning in eventdns.c svn:r8654	2006-10-08 21:05:06 +00:00
Andrew Lewman	5227531744	Remove spurious void which causes builds to fail in mingw. svn:r8650	2006-10-08 18:44:02 +00:00
Roger Dingledine	538c54e376	try dirport reachability testing five times less often. it's already so darn thorough per test -- it chews through like four circuits before giving up. svn:r8646	2006-10-08 06:33:02 +00:00
Nick Mathewson	ea00437f74	r8933@totoro: nickm \| 2006-10-07 20:33:16 -0400 whitespace fixes; add changelog for last commit. svn:r8644	2006-10-08 00:33:43 +00:00
Nick Mathewson	1c01797c16	r8932@totoro: nickm \| 2006-10-07 20:29:03 -0400 Try to make mingw capable of producing a working tor binary for win98: make all NT-service-related functions get lazy-loaded on demand. I have no idea if this even compiles. svn:r8643	2006-10-08 00:33:35 +00:00
Nick Mathewson	e230fe8ea6	r8926@totoro: nickm \| 2006-10-07 15:56:14 -0400 refactor circuit_list_path and circuit_list_path_verbose into a common _impl function. svn:r8642	2006-10-07 19:56:49 +00:00
Nick Mathewson	f07f7a7a12	r8923@totoro: nickm \| 2006-10-07 11:44:33 -0400 More doxygen comments svn:r8637	2006-10-07 16:25:28 +00:00
Roger Dingledine	9fb98b269c	finish poking and prodding. i'm all happy now. svn:r8633	2006-10-07 09:13:30 +00:00
Roger Dingledine	f2bd0e2f16	more minor cleanups svn:r8630	2006-10-07 06:28:50 +00:00
Roger Dingledine	4f3827f1d1	resolve the entryguard uptime/capacity question. and mark a new xxx that we'll want to address one day. svn:r8628	2006-10-07 02:55:44 +00:00
Roger Dingledine	06e5b2283c	minor cleanups svn:r8622	2006-10-07 00:50:39 +00:00
Roger Dingledine	1cf37f90c4	bugfix and cleanups re: entry guards. svn:r8620	2006-10-06 23:37:07 +00:00
Roger Dingledine	864069f5c7	fix a size_t-to-len compile warning svn:r8618	2006-10-06 22:37:10 +00:00
Roger Dingledine	1d4bd3990f	fetch all the v1 directory stuff way less often. plus, move around some housecleaning calls so they still occur often. are some of these redundant or in the wrong order? there are so many of them, maybe they should be put into a separate function that has better documentation. svn:r8607	2006-10-06 09:04:11 +00:00
Roger Dingledine	d1b9de222e	cleanups, closer to a changelog svn:r8606	2006-10-06 07:50:57 +00:00
Roger Dingledine	b6e590a1a5	reapply a patch from adam langley that got clobbered when nick merged something back in svn:r8605	2006-10-06 06:46:08 +00:00
Roger Dingledine	baf208d7b3	bugfix: When testing reachability of our dirport, don't launch a new test if there's already one in progress. svn:r8604	2006-10-06 04:02:27 +00:00
Nick Mathewson	c15dc2d94c	r9101@Kushana: nickm \| 2006-10-05 23:05:11 -0400 Trivial fix for solaris build. Libevent will want to use its own fix here, and probably already has. svn:r8601	2006-10-06 03:05:19 +00:00
Nick Mathewson	4767d533f7	r9097@Kushana: nickm \| 2006-10-05 14:51:57 -0400 Make eventdns.c formatting a little closer to evdns.c in libevent; add some bulletproofing to APPEND16 macro; clean some messages. svn:r8600	2006-10-05 19:22:26 +00:00
Roger Dingledine	64b5fd3194	checkpoint some cleanups svn:r8599	2006-10-05 08:23:21 +00:00
Nick Mathewson	5391ceb21a	r9087@Kushana: nickm \| 2006-10-04 01:19:15 -0400 We're trying to catch the kind of jerk who'd hijack zy6pzwohtnlq.test, not the kind of lunatic who'd hijack zy6pzwohtnlq%s.test, though apparently those exist too. svn:r8595	2006-10-04 05:19:40 +00:00
Nick Mathewson	50320ac420	r8862@totoro: nickm \| 2006-10-03 14:54:14 -0400 Make verbose names get used (when appropriate and selected) in responses to getinfo requests. svn:r8593	2006-10-03 19:00:18 +00:00
Nick Mathewson	4c10464e13	r8861@totoro: nickm \| 2006-10-03 14:49:54 -0400 Fix bug in r8579: TrackHostExits .foo.bar implies TrackHostExits foo.bar; also fix logic error. svn:r8592	2006-10-03 19:00:12 +00:00
Nick Mathewson	1ae7282d9b	r8857@totoro: nickm \| 2006-10-03 13:54:21 -0400 Implement ORCONN with verbose names. svn:r8588	2006-10-03 18:59:52 +00:00
Nick Mathewson	55bd42d50f	r8841@totoro: nickm \| 2006-10-02 15:59:21 -0400 Add EXTENDED_EVENTS to the USEFEATURE command; move flag from connection_t into control_conn, since we will probably grow more of these. svn:r8585	2006-10-03 18:58:56 +00:00
Nick Mathewson	c796adc7df	r8840@totoro: nickm \| 2006-10-02 15:56:16 -0400 Add USEFEATURE to control changes to control protocol. Use like __future__ directive from Python. Will spec before pushing changes. No, really. :) svn:r8584	2006-10-03 18:58:52 +00:00
Nick Mathewson	eb0f51f2a3	r8839@totoro: nickm \| 2006-10-02 15:31:49 -0400 Make a field longer to accomodate verbose nicknames; note that verbose nicknames will never reach this point. svn:r8583	2006-10-03 18:58:47 +00:00
Nick Mathewson	6e0b90a902	r8838@totoro: nickm \| 2006-10-02 15:24:39 -0400 Partial implementation of revised nickname syntax for controllers. Implement ability to look up routers by "verbose" nicknames; add a per-v1-control-connection flag to turn the feature on in events. Needs testing, spec, ability to actually turn on the flag, double-checking that we wont overflow any nickname buffers, and changelog. svn:r8582	2006-10-03 18:58:40 +00:00
Roger Dingledine	246fecb585	the other half of the is_local_IP patch svn:r8581	2006-10-03 05:45:58 +00:00
Nick Mathewson	4c56ac93ca	r8851@totoro: nickm \| 2006-10-02 18:13:27 -0400 Remove/clarify some XXXs for no longer being accurate; for begin things we do not indend to fix; for already being parts of big todo issues (like "/* XXX ipv6 */"); etc. Also fix some spaces. svn:r8580	2006-10-02 22:13:42 +00:00
Nick Mathewson	4de9f45d6f	r8850@totoro: nickm \| 2006-10-02 17:21:11 -0400 Make TrackExitHosts case-insensitive, and fix the behavior of .suffix TrackExitHosts items to avoid matching in the middle of an address. (Resolves an XXXX) svn:r8579	2006-10-02 22:13:37 +00:00
Nick Mathewson	bff83b666c	r8846@totoro: nickm \| 2006-10-02 16:59:57 -0400 Move is_local_IP to config.c; have it check for same-/24; make it used only for reachability (not for banwidth, because that is probably not what we want). Fixes an XXX. svn:r8578	2006-10-02 21:00:35 +00:00
Nick Mathewson	14f9b537d1	r8835@totoro: nickm \| 2006-10-02 12:54:41 -0400 Improve error messages from AUTHENTICATE attempts to controller. svn:r8574	2006-10-02 18:08:46 +00:00
Roger Dingledine	a3efc8e3d1	- V1 authorities should set "HSAuthoritativeDir 1" to continue being hidden service authorities too. - Just because your DirPort is open doesn't mean people should be able to remotely teach you about hidden service descriptors. Now only accept rendezvous posts if you've got HSAuthoritativeDir set. svn:r8573	2006-10-01 22:16:55 +00:00
Nick Mathewson	57ffca883d	r8826@totoro: nickm \| 2006-10-01 17:58:45 -0400 Disprefer exit nodes for entry, middle positions (fixes bug 200). Also, switch to using a uint64_t to hold "total bandwidth for all nodes" under consideration; crypt_rand_int would have died at 2GB/s network capacity. svn:r8571	2006-10-01 21:59:09 +00:00
Roger Dingledine	3fcf736c83	misc touchups svn:r8568	2006-10-01 21:42:44 +00:00
Nick Mathewson	ce72a9914e	r8822@totoro: nickm \| 2006-10-01 16:24:22 -0400 Fix bug 303: reject attempts to use Tor as a one-hop proxy. svn:r8566	2006-10-01 20:50:11 +00:00
Roger Dingledine	7ed921708f	Track down a seg fault that's been bothering me a while: if you enable your dirport as a client, you'll crash. svn:r8561	2006-10-01 07:53:17 +00:00
Roger Dingledine	4096e577c5	if we fail to build a circuit to an intended enclave, and it's not mandatory that we use that enclave, stop wanting it. svn:r8559	2006-10-01 06:41:13 +00:00
Roger Dingledine	96a4cb1dfa	touchups svn:r8558	2006-10-01 04:55:12 +00:00
Roger Dingledine	e6f4431722	stop trying to hammer router_rebuild_descriptor() when we don't have a public address we like yet. svn:r8554	2006-09-30 20:40:26 +00:00
Roger Dingledine	0fb7a7de95	Bugfix: when we tunnel our dir fetches via tor, don't believe the X-Forwarded-For header. svn:r8553	2006-09-30 20:14:15 +00:00
Nick Mathewson	fc9dd98d4c	r8805@totoro: nickm \| 2006-09-30 16:07:13 -0400 Oops; nameserver list is circular. svn:r8552	2006-09-30 20:07:37 +00:00
Roger Dingledine	075cb54d9b	make hidden service predicted circuits correct rather than exactly incorrect. i wonder how much this will help. svn:r8550	2006-09-30 19:22:24 +00:00
Nick Mathewson	723ff1c93d	r8800@totoro: nickm \| 2006-09-29 23:10:49 -0400 Resolve bug 336: When displaying circuit paths with non-named routers, use their digests, not their nicknames. svn:r8548	2006-09-30 03:11:13 +00:00
Nick Mathewson	2cb956d1f5	r9036@Kushana: nickm \| 2006-09-29 18:59:51 -0400 I am glad that arma reviews my patches. svn:r8546	2006-09-29 22:59:59 +00:00
Nick Mathewson	c2d304366b	r9032@Kushana: nickm \| 2006-09-29 18:51:42 -0400 Now, all log messages should be distinct. svn:r8545	2006-09-29 22:51:47 +00:00
Nick Mathewson	7d366f61cb	r9025@Kushana: nickm \| 2006-09-29 18:33:13 -0400 Differentiate more duplicated log entries svn:r8542	2006-09-29 22:33:40 +00:00
Nick Mathewson	8308a37908	r9023@Kushana: nickm \| 2006-09-29 17:27:24 -0400 Make distinct all non-bug messages at notice or higher that appear 3 or more times. svn:r8541	2006-09-29 22:33:34 +00:00
Nick Mathewson	b21e656eaf	r9007@Kushana: nickm \| 2006-09-29 13:17:32 -0400 Make eventdns give strings for DNS errors, not just error numbers. svn:r8535	2006-09-29 18:13:33 +00:00
Nick Mathewson	0335bd51d3	r9005@Kushana: nickm \| 2006-09-29 10:37:55 -0400 Implement DESCCHANGED event to tell controller when our router descriptor changes. svn:r8533	2006-09-29 18:13:25 +00:00
Nick Mathewson	8992bf6204	r8776@totoro: nickm \| 2006-09-29 00:50:46 -0400 Reserve the nickname "Unnamed" for routers that can't pick a hostname; any router can call itself Unnamed; directory servers will never allocate Unnamed to any particular router; clients won't believe that any router is the canonical Unnamed. svn:r8529	2006-09-29 04:51:28 +00:00
Nick Mathewson	9dbfb91f17	r8997@Kushana: nickm \| 2006-09-28 23:40:22 -0400 [Needs review.] Add a BEGIN_DIR relay cell type for an easier in-protocol way to connect to directory servers through Tor. Previously, clients could only connect to director servers over Tor from exit nodes, but couldn't get directory information anonymously from a non-exit cache without getting a directory server involved. This needs testing, and needs client-side code to actually exercise it. svn:r8527	2006-09-29 03:50:11 +00:00
Roger Dingledine	4791a4f1c9	combine the cutoff log entries svn:r8524	2006-09-29 00:19:43 +00:00
Nick Mathewson	907fc6c73e	r8977@Kushana: nickm \| 2006-09-28 19:56:41 -0400 Make "is a v1 authority", "is a v2 authority", and "is a hidden service authority" into separate flags so we can eventually migrate more trust away from moria. svn:r8523	2006-09-28 23:57:59 +00:00
Nick Mathewson	1a444e089a	r8976@Kushana: nickm \| 2006-09-28 17:18:57 -0400 Another tweak to guard logic: ignore check for the Guard flag if a server is listed on EntryNodes. (Also remove redundant checks for always-set variables.) svn:r8522	2006-09-28 23:57:56 +00:00
Nick Mathewson	d174cccd0b	r8975@Kushana: nickm \| 2006-09-28 17:13:53 -0400 Document entry-guard related functions svn:r8521	2006-09-28 23:57:52 +00:00
Nick Mathewson	d3a06684bc	r8974@Kushana: nickm \| 2006-09-28 17:05:59 -0400 Improvement to last entry guards patch: track when we last attempted to connect to a node in our state file along with how long it has been unreachable. Also clarify behavior of parse_iso_time() when it gets extra characters. svn:r8520	2006-09-28 23:57:49 +00:00
Nick Mathewson	9988112c87	r8973@Kushana: nickm \| 2006-09-28 16:53:19 -0400 Refactor entry guard status logic a lot; allow more factors [like not having a Guard flag or being listed in ExcludeNodes] to render a guard "unlisted" (now called "unusable"); track guard down status (now called "unreachable") separately from is_running. svn:r8519	2006-09-28 23:57:44 +00:00
Peter Palfrader	bc25e87754	r9897@danube: weasel \| 2006-09-29 01:08:44 +0200 Add a space in a wrapped log message svn:r8517	2006-09-28 23:08:54 +00:00
Peter Palfrader	c339bd2713	r9895@danube: weasel \| 2006-09-29 01:05:00 +0200 Restore to previous wording that svk merging made me mess up svn:r8516	2006-09-28 23:05:17 +00:00
Peter Palfrader	540fbaae75	r9889@danube: weasel \| 2006-09-29 00:57:42 +0200 bandwidth is not measured in bytes svn:r8515	2006-09-28 22:59:36 +00:00
Peter Palfrader	9e6c0b8b3b	r9888@danube: weasel \| 2006-09-29 00:57:02 +0200 Also log guard bandwidth cutoff svn:r8514	2006-09-28 22:59:25 +00:00
Peter Palfrader	14882b3ec0	r9770@danube: weasel \| 2006-09-15 07:20:05 +0200 router_set_networkstatus() gets a list of status documents we asked for from connection_dir_client_reached_eof(). However, as a cache we (sometimes?) just ask for "all". router_set_networkstatus() would freak out over that, meaning it would log a warning and drop the status document instead of caching it as it is supposed to. Now we let router_set_networkstatus() know if the data comes from an all-request so it can do the right thing. svn:r8513	2006-09-28 22:58:58 +00:00
Nick Mathewson	95132f836a	r8750@totoro: nickm \| 2006-09-27 20:52:01 -0400 Fix some warnings on mingw; hopefully this should let us build on mingw without warnings. svn:r8509	2006-09-28 00:53:02 +00:00
Nick Mathewson	ba7868c7b3	r8969@Kushana: nickm \| 2006-09-26 18:00:36 -0400 Remove a signed/unsigned comparison in eventdns.c svn:r8508	2006-09-26 22:03:26 +00:00
Nick Mathewson	cd2425ffa0	r8968@Kushana: nickm \| 2006-09-26 17:53:27 -0400 Fix for reverse dns: only assume we will get an answer when the result was success. svn:r8507	2006-09-26 22:03:23 +00:00
Nick Mathewson	49ad1eefa1	Add an EnforceDistinctSubnets option so that clients who know what they are doing (mainly people with private testing networks) can disable our same-/16 detection. svn:r8504	2006-09-25 22:12:54 +00:00
Nick Mathewson	01f9e97d43	Minor fix: add code to eventdns so it can free memory on shutdown. This should help valgrind and dmalloc freak out less. svn:r8503	2006-09-25 20:38:58 +00:00
Nick Mathewson	52e179b942	Trivial fix to make dmalloc happier: release memory held in static member of escaped(). svn:r8502	2006-09-25 18:46:29 +00:00
Nick Mathewson	4fe76e7b6b	Free named_server_map on shutdown. svn:r8500	2006-09-25 16:06:39 +00:00
Roger Dingledine	ad430b9561	checkpoint changelog and general polishing svn:r8497	2006-09-25 05:59:13 +00:00
Roger Dingledine	bc848c8740	add 6697 (ircs) as longlivedport. svn:r8496	2006-09-25 05:24:43 +00:00
Roger Dingledine	bda137501e	whitespace cleanups svn:r8485	2006-09-24 20:54:59 +00:00
Nick Mathewson	11b4296b0b	Marge changes from libevent evdns to our eventdns. Most are cosmetic, but one or two are stability-related. This should make it easier to push our changes back towards libevent. svn:r8482	2006-09-24 17:52:23 +00:00
Nick Mathewson	d3af1f2189	Backport candidate: Fix a long-standing server-side DNS bug. When a client asks us to resolve (not connect to) an address, and we have a cached answer, give them the cached answer. Previously, we would give them no answer at all. svn:r8478	2006-09-24 17:05:00 +00:00
Nick Mathewson	4218f09820	r8910@Kushana: nickm \| 2006-09-22 12:14:05 -0400 Instead of just checking known-invalid addresses for DNS hijacking, we now check randomly generated addresses, and if too many of them map to the same IP, we assume that IP is the destination of a DNS hijack attempt. A little bird tells me that some DNS hijackers think that declining to give an A record for RFC2606 addresses (like .invalid and .example) makes them more standards compliant. Standardswise, this is like an illicit brothel making sure that nobody has pulled the tags off the mattresss, but that doesn't get us out of working around it. svn:r8465	2006-09-22 20:20:26 +00:00
Nick Mathewson	bde5939ad3	r8909@Kushana: nickm \| 2006-09-22 00:38:13 -0400 Consider changes to has_old_dnsworkers as noncosmetic svn:r8464	2006-09-22 20:20:21 +00:00
Roger Dingledine	aa77298819	remove 8888 as a long lived port. i can't remember why it's on the list. svn:r8461	2006-09-22 19:29:26 +00:00
Nick Mathewson	f0f3bbc63b	r8901@Kushana: nickm \| 2006-09-21 20:43:48 -0400 I tracked a bug in server-side reverse DNS to something concerning the caching code. Ive disabled server-side cacheing for reverse DNS answers for now, and I am noting the bug in the TODO. svn:r8454	2006-09-22 00:45:08 +00:00
Nick Mathewson	6b3f6afb58	r8895@Kushana: nickm \| 2006-09-21 20:05:11 -0400 Debug client-side reverse dns code. svn:r8452	2006-09-22 00:44:07 +00:00
Nick Mathewson	213658f117	r8894@Kushana: nickm \| 2006-09-21 18:30:42 -0400 Specify and implement SOCKS5 interface for reverse hostname lookup. svn:r8451	2006-09-22 00:43:55 +00:00
Roger Dingledine	9bc8d69dfc	remove some loud log messages svn:r8450	2006-09-22 00:24:27 +00:00
Nick Mathewson	29a756af8e	Fix a couple of server-side reverse dns bugs svn:r8449	2006-09-22 00:10:26 +00:00
Nick Mathewson	63395c747c	Fix stupid C mistake. Glad I caught that one fast. svn:r8448	2006-09-21 22:57:07 +00:00
Nick Mathewson	58200f06a5	Fix bug in r8440: base32 uses 5 bytes per char, not 4. svn:r8447	2006-09-21 22:24:45 +00:00
Nick Mathewson	4f13cb82fd	r8881@Kushana: nickm \| 2006-09-21 17:27:59 -0400 Allow resolve requests to non-exits when they are specifically requested (via resolve foo.bar.exit). svn:r8446	2006-09-21 21:49:36 +00:00
Nick Mathewson	59f9487225	r8880@Kushana: nickm \| 2006-09-21 17:26:02 -0400 Trivial patch to appease warn-happy gcc: mark unused parameter svn:r8445	2006-09-21 21:49:15 +00:00
Nick Mathewson	adade79f68	r8879@Kushana: nickm \| 2006-09-21 17:20:31 -0400 Oops from earlier patch; add "opt eventdns" to unittests, fix bug in routerdesc generation. svn:r8444	2006-09-21 21:49:03 +00:00
Nick Mathewson	7c21dabef1	r8878@Kushana: nickm \| 2006-09-21 17:15:47 -0400 Trivial whitespace cleanups. svn:r8443	2006-09-21 21:48:55 +00:00
Nick Mathewson	6a1746f98f	r8877@Kushana: nickm \| 2006-09-21 17:12:33 -0400 Consider non-exit servers unsuitable for RESOLVE commands. svn:r8442	2006-09-21 21:48:42 +00:00
Nick Mathewson	d273d52979	r8876@Kushana: nickm \| 2006-09-21 16:58:46 -0400 Trivial cleanup: !!x is a weird way to spell x != NULL. svn:r8441	2006-09-21 21:48:37 +00:00
Nick Mathewson	e4a9b4de4e	r8875@Kushana: nickm \| 2006-09-21 16:46:28 -0400 Resolve bug 330: detect ISPs that want to hijack failing DNS requests and basically domain-squat the entire internet. svn:r8440	2006-09-21 21:48:22 +00:00
Nick Mathewson	04bec67574	r8874@Kushana: nickm \| 2006-09-21 15:22:27 -0400 Rename and document SearchDomains and ResolvConf options; warn if ServerDNSResolvConfFile is given but eventdns isnt enabled. svn:r8439	2006-09-21 21:48:16 +00:00
Nick Mathewson	083e9c2b59	r8873@Kushana: nickm \| 2006-09-21 14:38:22 -0400 Fix a bug: Remember, each call to escaped() replaces the value returned from the last call to escaped(). svn:r8438	2006-09-21 21:48:11 +00:00
Nick Mathewson	a942441615	r8872@Kushana: nickm \| 2006-09-21 14:00:20 -0400 Implement server-side reverse DNS using eventdns. Add an option to routerdescs so we can tell which servers have eventdns enabled. svn:r8437	2006-09-21 21:48:06 +00:00
Nick Mathewson	6b716fdfb9	NEEDS REVIEW. Act on previous comment, and handle named servers differently: now, we allow multiple servers with the same name in the routerlist even if that name is reserved, but we check whether names are reserved when we try to look up routers by nickname. This is a minor security fix. This makes router_add_to_routerlist O(1). This is a backport candidate. svn:r8433	2006-09-19 23:48:14 +00:00
Nick Mathewson	5ebb949c9f	Stop searching routerlist for routers with the same identity as other routers (on router insert): we already have a map for that. (We need to add an index field to routerinfo_t so we can figure out which point in the routerlist to replace.) Also, add a comment to routerlist.c; arma, please advise? svn:r8432	2006-09-19 23:18:30 +00:00
Nick Mathewson	7b0ec744bc	Switch routerlist.c to using memcmp on digests rather than crypto_pk_cmp_keys(); speed up find_whitespace a lot (8x for me) by using a switch statement. This should speed parsing a lot of routers at once by a lot. svn:r8430	2006-09-19 22:20:09 +00:00
Roger Dingledine	e9abe750ea	eventdns patch from Adam Langley svn:r8429	2006-09-19 21:37:03 +00:00
Nick Mathewson	4bc42f4c18	Fix a bogus free() in eventdns.c. Bug reported by xiando. svn:r8428	2006-09-19 20:45:20 +00:00
Nick Mathewson	93beeac01d	Merge in some bsockets calls, all wrapped inside #if defined(USE_BSOCKETS) svn:r8427	2006-09-19 20:41:31 +00:00
Roger Dingledine	0494e271e7	good god, that was a bad idea. i've built 500 circuits in the past 5 minutes, trying to establish reachability of my unreachable server. svn:r8415	2006-09-18 04:59:15 +00:00
Roger Dingledine	4920b9d1cc	Fix two bugs: first, "extendcircuit" would crash if you gave it a purpose. Second, if you give an unknown purpose, it would say: 552 Unknown purpose "purpose=foo" Now it just says 552 Unknown purpose "foo" svn:r8412	2006-09-18 04:24:41 +00:00
Nick Mathewson	65974f82fa	r8839@Kushana: nickm \| 2006-09-17 16:11:59 -0400 Add some client performance XXXXs; try to move some common case tests higher on their decision trees. svn:r8410	2006-09-17 20:12:10 +00:00
Roger Dingledine	b049b1b014	build testing circuits more rapidly. this has a failure mode where if circuits fail quickly, we'll fail a lot of them very quickly and not retry for a while. so be it. svn:r8407	2006-09-17 06:18:06 +00:00
Roger Dingledine	bfa78b3dea	actually, do the bandwidth test anyway, if you've been up at least 6 hours at your previous address. svn:r8403	2006-09-15 18:07:11 +00:00
Roger Dingledine	a51ec44466	avoid thrashing the bandwidth exercise when we change IPs a lot. (we avoid simply by not doing any new tests when we change IPs -- it looks like we retain our previous bandwidth estimates, so there's no need to do new exercise. though in some cases new exercises may still be useful. one day we'll do something smarter.) svn:r8402	2006-09-15 18:03:53 +00:00
Roger Dingledine	c22dc94fe6	make my bandwidth exercises actually happen svn:r8400	2006-09-15 05:53:00 +00:00
Roger Dingledine	769f9201a6	Send out a burst of long-range drop cells after we've established that we're reachable. Spread them over 4 circuits, so hopefully a few will be fast. This exercises our bandwidth and bootstraps us quicker. svn:r8399	2006-09-15 05:30:25 +00:00
Peter Palfrader	ba091ae5d7	r9770@danube: weasel \| 2006-09-15 07:20:05 +0200 router_set_networkstatus() gets a list of status documents we asked for from connection_dir_client_reached_eof(). However, as a cache we (sometimes?) just ask for "all". router_set_networkstatus() would freak out over that, meaning it would log a warning and drop the status document instead of caching it as it is supposed to. Now we let router_set_networkstatus() know if the data comes from an all-request so it can do the right thing. svn:r8398	2006-09-15 05:20:16 +00:00
Peter Palfrader	5beb114744	r9767@danube: weasel \| 2006-09-15 06:27:48 +0200 Minor documentation fix svn:r8397	2006-09-15 04:29:36 +00:00
Nick Mathewson	e58b9c1151	r8819@Kushana: nickm \| 2006-09-15 00:27:45 -0400 Implement a smartlist_uniq() that will with luck not end the world. svn:r8396	2006-09-15 04:27:58 +00:00
Nick Mathewson	ce83f43629	r8817@Kushana: nickm \| 2006-09-14 18:31:29 -0400 Patch from steve hildrey: Generate network status correctly on non-versioning dirservers svn:r8395	2006-09-14 22:34:57 +00:00
Peter Palfrader	2cf6cfe189	r9758@danube: weasel \| 2006-09-14 07:10:12 +0200 Add a comment svn:r8391	2006-09-14 05:17:02 +00:00
Peter Palfrader	7fcec09560	r9753@danube: weasel \| 2006-09-14 07:07:02 +0200 Remove duplicates from MyFamily svn:r8390	2006-09-14 05:07:34 +00:00
Peter Palfrader	9d9e31dcf4	r9752@danube: weasel \| 2006-09-14 07:06:49 +0200 Fix some dead code that is on occasion useful svn:r8389	2006-09-14 05:07:26 +00:00
Nick Mathewson	4f888c9dfc	r8808@senior-two-eighty: nickm \| 2006-09-14 00:59:54 -0400 House style for no-args functions is old-style C, not C++ svn:r8388	2006-09-14 05:00:02 +00:00
Peter Palfrader	984e8f6efb	r9736@danube: weasel \| 2006-09-14 05:53:06 +0200 Refactor dirserv_parse_fingerprint_file(fname) into dirserv_load_fingerprint_file(): There is not need to put together the path to the approved-routers file in more than one place. svn:r8386	2006-09-14 04:53:23 +00:00
Nick Mathewson	1852f503cf	r8776@Kushana: nickm \| 2006-09-11 22:49:53 -0400 Avoid crash when telling controller stream-status and a stream is detached. Fixes bug 334. Backport candidate. svn:r8370	2006-09-12 02:50:14 +00:00
Roger Dingledine	e56dbb810f	start remembering X-Your-Address-Is hints even if you're a client, so you can become a server more smoothly. svn:r8359	2006-09-09 19:36:51 +00:00
Roger Dingledine	9af3175687	parameterize the loudness of get_interface_address() svn:r8358	2006-09-09 19:20:27 +00:00
Roger Dingledine	5f6351ceb3	fix typo, add log message svn:r8357	2006-09-09 19:16:07 +00:00
Roger Dingledine	0c3cc15898	fix encoding in "getinfo addr-mappings" response. fix error code when "getinfo dir/status/" fails. svn:r8355	2006-09-09 03:38:03 +00:00
Roger Dingledine	29b6d6560e	add a "getinfo address" controller command. svn:r8354	2006-09-09 03:18:39 +00:00
Roger Dingledine	25cb9453d7	possibly make tor build and run on cygwin again. svn:r8353	2006-09-08 20:48:43 +00:00
Peter Palfrader	fdd56dee69	r9695@danube: weasel \| 2006-09-08 18:11:53 +0200 Make tor build with -O0 svn:r8352	2006-09-08 16:12:15 +00:00
Mike Chiussi	f9f281251b	another typo svn:r8351	2006-09-08 09:05:07 +00:00
Mike Chiussi	1ee88bb01a	fixed typo in eventdns.c svn:r8350	2006-09-08 09:02:14 +00:00
Nick Mathewson	c063c7b8cb	r8757@Kushana: nickm \| 2006-09-07 13:07:46 -0400 Fix more compile warnings on Woody. svn:r8349	2006-09-07 19:00:51 +00:00
Nick Mathewson	8a12d9ae2e	r8755@Kushana: nickm \| 2006-09-07 12:31:57 -0400 Tabify eventdns svn:r8348	2006-09-07 16:32:06 +00:00
Nick Mathewson	4246490b81	r8753@Kushana: nickm \| 2006-09-07 12:23:25 -0400 Make eventdns spacing consistant svn:r8347	2006-09-07 16:24:19 +00:00
Mike Chiussi	5d773af545	undid whitespace changes to dns.c svn:r8346	2006-09-07 06:36:22 +00:00
Mike Chiussi	b931994c6a	fixed win32 eventdns snafu svn:r8345	2006-09-07 06:34:20 +00:00
Mike Chiussi	c40acb86f4	- got rid of tabs svn:r8344	2006-09-07 04:02:52 +00:00
Mike Chiussi	3c85780e69	- got rid of tabs (i think) svn:r8343	2006-09-07 03:58:46 +00:00
Mike Chiussi	5af47d1641	- added some debugging lines to load_nameservers_from_registry() svn:r8342	2006-09-07 03:53:14 +00:00
Roger Dingledine	ae67a044f0	clean up some comments svn:r8338	2006-09-07 01:23:15 +00:00
Roger Dingledine	43edbf0461	prefer calling it a client rather than an OP svn:r8334	2006-09-07 01:00:37 +00:00
Mike Chiussi	879fe91d88	rm'ed a tab (sorry) svn:r8333	2006-09-07 00:54:28 +00:00
Mike Chiussi	91d7ad660f	- fixed up typos in eventdns.c - configure lets user build with eventdns on win32 svn:r8332	2006-09-07 00:51:20 +00:00
Roger Dingledine	5a8563baed	new config option AvoidDiskWrites for people running tors on usb keys and other media that degrades when you write. not implemented yet, so just a reminder. svn:r8331	2006-09-07 00:30:29 +00:00
Nick Mathewson	7ed528c5c5	r8733@Kushana: nickm \| 2006-09-06 17:35:22 -0400 Add some missing defines to eventdns.c for windows. svn:r8330	2006-09-06 21:35:30 +00:00
Nick Mathewson	1e26233957	r8731@Kushana: nickm \| 2006-09-06 16:33:19 -0400 Try to fix eventdns.c build on windows. svn:r8329	2006-09-06 20:33:28 +00:00
Nick Mathewson	e10e921386	r8729@Kushana: nickm \| 2006-09-06 16:20:40 -0400 Fix dns_cancel_pending_resolve() to realize pending resolves have expiry times, and should not be freed except when they fall off the pqueue. svn:r8328	2006-09-06 20:22:05 +00:00
Nick Mathewson	365ccf0742	r8725@Kushana: nickm \| 2006-09-06 04:39:29 -0400 spawn_func fixes: have cpuworker_main and dnsworker_main confirm to the right interfaces [casting func to void* is icky]. Also, make pthread_create() build without warnings. svn:r8327	2006-09-06 08:42:20 +00:00
Nick Mathewson	000b7b287c	r8724@Kushana: nickm \| 2006-09-06 04:32:28 -0400 Fix spaces; restore support for mapping files over 4GB on win32 (?) svn:r8326	2006-09-06 08:42:16 +00:00
Mike Chiussi	6ec9c1092a	- made configure check if we are building for win32 - made configure link to required system dll's if building for win32 - added diffs for libevent 1.1b - forced user to turn off eventdns if win32 is set - cleaned up tor_mmap_file()_win32 (not sure if it's stable) - cleaned up some warnings and typos svn:r8322	2006-09-06 01:49:55 +00:00
Roger Dingledine	585ae26783	patch from tup svn:r8321	2006-09-05 14:30:06 +00:00
Nick Mathewson	b40e639f15	r8708@Kushana: nickm \| 2006-09-02 20:34:15 -0400 Fix warnings reported by weasel when compiling Tor on Debian woody. svn:r8318	2006-09-03 02:13:52 +00:00
Nick Mathewson	21a7880358	r8695@Kushana: nickm \| 2006-08-31 14:35:36 -0400 Fix two corner cases in router_dir_info_changed(). This should have no observable effect. svn:r8311	2006-08-31 18:46:46 +00:00
Nick Mathewson	f170e5798f	r8692@Kushana: nickm \| 2006-08-31 13:38:07 -0400 Fix bug 327 (part 2): Cast char to unsigned char before passing to toupper/tolower. (Follow the same idiom as with isupper and friends, in case we run into the same problem on SGI or whereever it was.) svn:r8310	2006-08-31 17:39:51 +00:00
Nick Mathewson	921bfdb40a	r8687@Kushana: nickm \| 2006-08-30 19:33:28 -0400 Apply patch from Adam Langley: fix assert() in eventdns.c. [Fuzzing, apparently, is cool.] svn:r8308	2006-08-30 23:34:56 +00:00
Nick Mathewson	6c499804bb	r8686@Kushana: nickm \| 2006-08-30 18:01:35 -0400 Remove bogus whitespace svn:r8307	2006-08-30 23:34:49 +00:00
Nick Mathewson	8138d1c0a4	r8654@Kushana: nickm \| 2006-08-28 16:50:36 -0400 I bet real programmers even have programs that compile. svn:r8278	2006-08-28 20:50:47 +00:00
Nick Mathewson	dc4951314f	r8652@Kushana: nickm \| 2006-08-28 16:41:44 -0400 Resolve bug 324: strdup the right variable. svn:r8277	2006-08-28 20:42:14 +00:00
Roger Dingledine	2499d1db7c	and make the comment better, while i'm at it svn:r8273	2006-08-28 19:02:57 +00:00
Roger Dingledine	2a4d5782ef	an even better check -- now servers hang up if they can't write for a while, and clients hang up if they can't read for a while. svn:r8272	2006-08-28 19:00:17 +00:00
Roger Dingledine	f75ef94f27	fix bug found by Adam J. Richter: directory clients shouldn't hang up five minutes after they begin. but directory servers should still hang up after 5 minutes of failing to deliver any bytes. svn:r8271	2006-08-28 18:51:36 +00:00
Roger Dingledine	a76e032b14	put some symbols on the eventdns logging. leave the haphazard formatting alone. svn:r8270	2006-08-28 08:24:36 +00:00
Nick Mathewson	dbe0c6f6ef	r8609@Kushana: nickm \| 2006-08-27 17:24:27 -0400 Add some doxygen, concentrated in dns.c svn:r8256	2006-08-28 03:16:02 +00:00
Nick Mathewson	54ca0387a5	r8608@Kushana: nickm \| 2006-08-27 16:57:47 -0400 Make it possible to change nameserver options while Tor is running. svn:r8255	2006-08-28 03:15:55 +00:00
Nick Mathewson	be7054c626	r8607@Kushana: nickm \| 2006-08-27 15:45:42 -0400 Change configuration strategy for eventdns. Instead of elaborate option set, just allow the user to specify another resolv.conf to use. svn:r8254	2006-08-28 03:15:50 +00:00
Nick Mathewson	d62f9a03fb	r8605@Kushana: nickm \| 2006-08-27 14:01:11 -0400 divide eventdns log messages into warn and info messages. svn:r8252	2006-08-28 03:15:38 +00:00
Roger Dingledine	e17276b2f1	comment out an unused variable; nick, feel free to excise it further. svn:r8241	2006-08-27 06:58:30 +00:00
Roger Dingledine	94afe807ac	stop a big memory leak: we were leaking the whole contents of cached-routers.new every time we read it. svn:r8236	2006-08-27 02:12:12 +00:00
Roger Dingledine	9f5856c03d	stop three memory leaks. nick, fix these if i'm wrong. svn:r8235	2006-08-27 02:07:54 +00:00
Roger Dingledine	24ad1e06cf	i'm guessing nick meant to check the return value of dns_init. and revise some log severities to match the convention. svn:r8234	2006-08-27 01:41:08 +00:00
Roger Dingledine	8297608217	fix typo svn:r8233	2006-08-27 01:33:35 +00:00
Roger Dingledine	c0cb1c7bd2	remove some more vestiges of cvs svn:r8229	2006-08-26 06:51:02 +00:00
Roger Dingledine	171a00ec50	fix a log level -- err is for things that kill tor, warn is for things that tor can recover from. also, avoid situations where people who don't read their logs accumulate ten thousand useless files in their datadir. svn:r8227	2006-08-26 04:48:50 +00:00
Nick Mathewson	fd36eb0788	r8576@Kushana: nickm \| 2006-08-25 17:16:01 -0400 Fix bug 314: Instead of checking address_in_virtualrange, check addressmap_have_mapping(). This should be more accurate. [Rename to addressmap_have_mapping() from addressmap_already_mapped().] svn:r8226	2006-08-25 21:16:22 +00:00
Nick Mathewson	7739c5c49a	r8573@Kushana: nickm \| 2006-08-25 16:55:19 -0400 Resolve bug 321 when using dnsworkers: append a period to every address we resolve at the exit node, so that we do not accidentally pick up local addresses, and so that failing searches are retried in the resolver search domains. (This is already solved for eventdns.) svn:r8225	2006-08-25 21:02:01 +00:00
Nick Mathewson	c82c4a9e8b	r8572@Kushana: nickm \| 2006-08-25 16:35:49 -0400 Fix for bug 308: When we have a state file we cannot parse, tell the user, and move it aside. svn:r8224	2006-08-25 21:01:56 +00:00
Roger Dingledine	0649fa14c1	make our socks5 handling more robust to broken socks clients: throw out everything waiting on the buffer in between socks handshake phases, since they can't possibly (so the theory goes) have predicted what we plan to respond to them. svn:r8223	2006-08-24 04:51:55 +00:00
Roger Dingledine	9ebaf01096	clean up logging conventions in do_list_fingerprint() svn:r8222	2006-08-24 00:54:18 +00:00
Roger Dingledine	41d8d77c8b	tor --verify-config now exits with -1(255) or 0 depending on whether the config options are bad or good. svn:r8221	2006-08-23 23:45:03 +00:00
Nick Mathewson	0f5bfc1521	r7411@Kushana: nickm \| 2006-08-17 19:00:25 -0400 patch suggested by Karsten Loesing: respond to SIGNAL command before we execute the signal, in case the signal shuts us down. svn:r7072	2006-08-17 23:00:32 +00:00
Nick Mathewson	ae5ee4c924	r7405@Kushana: nickm \| 2006-08-16 14:38:46 -0400 Implement reverse DNS lookup in eventdns: add new entry point; rename old entry point; revise TODO a little; add facility for parsing dns names. svn:r7070	2006-08-16 18:47:24 +00:00
Roger Dingledine	6650470575	automatically avoid picking more than one node from the same /16 network when constructing a circuit. svn:r7068	2006-08-16 03:44:13 +00:00
Roger Dingledine	d8fc598a2a	dns.c:173: warning: control reaches end of non-void function svn:r7067	2006-08-16 02:18:55 +00:00
Nick Mathewson	163dd78282	r7398@Kushana: nickm \| 2006-08-15 00:49:50 -0400 Add missing backslash svn:r7065	2006-08-15 04:50:33 +00:00
Nick Mathewson	67b775bc6e	r7397@Kushana: nickm \| 2006-08-15 00:46:18 -0400 Fix eventdns version of dns.c. Man, we need to get rid of this eventdns/dnsworker split. svn:r7064	2006-08-15 04:50:17 +00:00
Nick Mathewson	7bfb2cf4e8	r7393@Kushana: nickm \| 2006-08-14 23:51:07 -0400 remove extraneous #endif svn:r7063	2006-08-15 03:54:13 +00:00
Nick Mathewson	273ee3e814	r7392@Kushana: nickm \| 2006-08-14 23:50:32 -0400 Only do the expensive version of router_have_minimum_dir_info() when the dir info has changed. Backport candidate, since oprofile suggests that this function and ones it calls account for 25-35% of oprofile samples. svn:r7062	2006-08-15 03:54:09 +00:00
Nick Mathewson	bc21df6a5c	r7386@Kushana: nickm \| 2006-08-14 17:43:44 -0400 Patch from Adam Langley. * I meant getaddrinfo_a, not getaddrinfo_r - fixed * Added more checks to the parsing code. * It seems you switched an alloca to a malloc, but didn't add any frees svn:r7061	2006-08-14 21:44:45 +00:00
Nick Mathewson	200e24981a	r7046@Kushana: nickm \| 2006-08-05 13:57:04 -0400 Make it possible for dns_init() to fail; note failure of eventdns configuratoin. svn:r7059	2006-08-14 21:44:34 +00:00
Nick Mathewson	a5c0aa43a0	r7383@Kushana: nickm \| 2006-08-14 16:16:03 -0400 Stop walking entire dns cache for every request, now that we found our hash table bug. svn:r7057	2006-08-14 20:16:21 +00:00
Roger Dingledine	5194b91053	avoid complaining about our SOCKS proxy proxy. svn:r7053	2006-08-14 10:00:15 +00:00
Roger Dingledine	9b10f11d39	fix typos and stuff svn:r7049	2006-08-14 08:55:41 +00:00
Roger Dingledine	bf10d8a06a	simplify compare_cached_resolves_by_expiry() to make it match the idioms of other compare functions. hopefully i didn't break it? svn:r7048	2006-08-14 07:08:29 +00:00
Nick Mathewson	6da96f0ed7	r7369@Kushana: nickm \| 2006-08-14 02:03:10 -0400 Shortening fields is only one part of making structs shorter. You must also consider alignment padding. Whee. svn:r7045	2006-08-14 06:03:26 +00:00
Roger Dingledine	2c27cfc38e	save 3-7 bytes per edge connection svn:r7044	2006-08-14 05:53:57 +00:00
Roger Dingledine	6fdc63aed2	simplify the connection_write_to_buf_zlib() wrapper. svn:r7042	2006-08-13 23:38:30 +00:00
Roger Dingledine	f294575469	fix funny-looking assignment that crashes unit tests svn:r7027	2006-08-11 07:41:21 +00:00
Roger Dingledine	5647e5c7e6	fix typo, add explanatory comment svn:r7026	2006-08-11 07:31:16 +00:00
Nick Mathewson	9b5a643475	r7328@Kushana: nickm \| 2006-08-11 00:04:26 -0700 remove an assert that can never be false (an array in a non-null struct cannot be null). svn:r7024	2006-08-11 07:09:52 +00:00
Nick Mathewson	04bf4b0fc4	r7327@Kushana: nickm \| 2006-08-11 00:00:36 -0700 Fix a pedantic warning svn:r7023	2006-08-11 07:09:45 +00:00
Nick Mathewson	09a895e222	r7324@Kushana: nickm \| 2006-08-10 23:23:15 -0700 Add more warnings to the list of those we tolerate. Start using GCC attributes more, for better error checking and better code generation. svn:r7020	2006-08-11 07:09:17 +00:00
Nick Mathewson	02d42d9138	Fix crash in first-time option validation. Oops. svn:r7018	2006-08-10 19:56:10 +00:00
Nick Mathewson	7ddd9e8cd9	r7304@Kushana: nickm \| 2006-08-10 01:58:05 -0700 Fix verbose compilation errors; make sure transparent proxy fails when no method is configured. svn:r7012	2006-08-10 09:02:26 +00:00
Nick Mathewson	3da737ac98	r7303@Kushana: nickm \| 2006-08-10 01:52:19 -0700 whitespace fixes svn:r7011	2006-08-10 09:02:12 +00:00
Nick Mathewson	74df271e00	r7302@Kushana: nickm \| 2006-08-10 01:48:44 -0700 Warn about open TransListenAddress values. svn:r7010	2006-08-10 09:02:02 +00:00
Nick Mathewson	cd560d8528	r7301@Kushana: nickm \| 2006-08-10 01:41:27 -0700 Only open /dev/pf once. svn:r7009	2006-08-10 09:01:54 +00:00
Nick Mathewson	d893d8c52e	r7300@Kushana: nickm \| 2006-08-10 01:36:40 -0700 Distinguish netfilter vs pf at configure time based on headers, not on OS. svn:r7008	2006-08-10 09:01:46 +00:00
Nick Mathewson	5cff4164a0	r7299@Kushana: nickm \| 2006-08-10 01:08:58 -0700 Patch from Tup to add support for transparent AP connections: this basically bundles the functionality of trans-proxy-tor into the tor mainline. Now hosts with compliant pf/netfilter implementations can redirect TCP connections straight to Tor without diverting through SOCKS. svn:r7007	2006-08-10 09:01:37 +00:00
Roger Dingledine	8075928b2a	a way to make tor more stable in crummy situations svn:r7005	2006-08-10 08:00:54 +00:00
Nick Mathewson	35f0881802	Experimentally re-enable kqueue on OSX when using libevent 1.1b or later. Log when we are doing this, so we can diagnose it when it fails. svn:r7004	2006-08-10 08:00:13 +00:00
Nick Mathewson	f2a0df4d02	Recommend libevent 1.1b for kqueue and win32 methods; deprecate libevent 1.0b harder; make libevent recommendation system saner. svn:r7003	2006-08-10 07:39:47 +00:00
Nick Mathewson	7c596c166b	r7029@Kushana: nickm \| 2006-08-04 14:08:41 -0700 Remove now-spurious size and data arguments from tor_mmap_file svn:r6987	2006-08-05 17:53:21 +00:00
Nick Mathewson	714d1b66aa	r7027@Kushana: nickm \| 2006-08-04 13:06:48 -0700 Oops. Fix downcast macro. svn:r6985	2006-08-05 17:52:51 +00:00
Roger Dingledine	bc2e040669	make svn trunk link again. nick can fix this if it's wrong. svn:r6982	2006-08-04 20:30:45 +00:00
Nick Mathewson	bf72878cad	r7012@Kushana: nickm \| 2006-08-03 19:21:25 -0700 Add an "mmap handle" type to encapsulate bookkeeping elements of mmap issues; add prelim win32 impl svn:r6980	2006-08-04 18:32:43 +00:00
Nick Mathewson	abe27b807e	svn:r6979	2006-08-04 18:31:13 +00:00
Nick Mathewson	2c33f385f7	r7011@Kushana: nickm \| 2006-08-03 13:26:34 -0700 eventdns: Document functions added to API; make suspended requests go to the front of the queue; check (or explicitly ignore) return values on libevent functions. svn:r6978	2006-08-04 18:27:10 +00:00
Nick Mathewson	e8f28a71e8	r7010@Kushana: nickm \| 2006-08-03 10:47:36 -0700 Enable log message format checking in eventdns.c when __GNUC__ is defined. svn:r6977	2006-08-04 18:26:40 +00:00
Nick Mathewson	3fa1cdafce	r7009@Kushana: nickm \| 2006-08-03 10:44:58 -0700 Add functions to eventdns to allow detecting whether we have any nameservers configured, and to change the list of nameservers after initial configuration. svn:r6976	2006-08-04 18:26:13 +00:00
Nick Mathewson	87939813c3	r7008@Kushana: nickm \| 2006-08-03 10:03:39 -0700 Oops. We shouldnt initialize eventdns when we are not being a server and not resolving anything. svn:r6975	2006-08-04 18:24:41 +00:00
Nick Mathewson	a122bfb439	r7007@Kushana: nickm \| 2006-08-03 09:58:30 -0700 Export and use eventdns_config_windows_nameservers(); clean up some comments and log messages. svn:r6974	2006-08-04 18:24:25 +00:00
Nick Mathewson	19cf66c0f1	Patch from Frediano Ziglio: Windows compilation fixes on eventdns.c. svn:r6971	2006-08-03 07:46:25 +00:00
Roger Dingledine	3152d44c3a	fix a seg fault on exit for clients; and fix a comment. svn:r6969	2006-08-03 04:22:25 +00:00
Roger Dingledine	ed567c6feb	more compile options mean more codepaths svn:r6963	2006-07-31 20:25:57 +00:00
Nick Mathewson	b9082682fd	r6982@Kushana: nickm \| 2006-07-31 13:47:19 -0400 documentation and naming tweaks in dns.c svn:r6961	2006-07-31 18:01:49 +00:00
Nick Mathewson	58c0ac77be	r6981@Kushana: nickm \| 2006-07-31 13:23:26 -0400 More asserts for cache correctness. svn:r6960	2006-07-31 18:01:45 +00:00
Nick Mathewson	d934607069	r6979@Kushana: nickm \| 2006-07-31 13:16:58 -0400 Add assert_ok functions for strmap and digestmap; use them in unit test code. svn:r6958	2006-07-31 18:01:27 +00:00
Nick Mathewson	fd0bafb0de	r6977@Kushana: nickm \| 2006-07-31 13:01:28 -0400 Solve timing-out pending connections. Add pending resolves to expiry queue; when we find an answer, change the pending resolve to "done" and stick the actual answer in the expiry queue as a new entry. This uses a little more memory, but makes the code simpler than other solutions. svn:r6956	2006-07-31 18:01:18 +00:00
Nick Mathewson	ccf9c1345e	svn:r6955	2006-07-31 18:00:47 +00:00
Nick Mathewson	46574319a2	r6959@Kushana: nickm \| 2006-07-29 22:33:18 -0400 start restructuring dns to use priority queues for expiring entries. svn:r6954	2006-07-31 18:00:18 +00:00
Nick Mathewson	2fe537c57a	r6958@Kushana: nickm \| 2006-07-29 18:54:15 -0400 Looks like we might need a priority queue. svn:r6953	2006-07-31 17:59:37 +00:00
Nick Mathewson	8ba913c660	r6952@Kushana: nickm \| 2006-07-28 11:09:37 -0400 Add completely untested find-my-nameservers code for win32. svn:r6952	2006-07-31 17:59:11 +00:00
Roger Dingledine	798b580695	fix assert found by DreadWingKnight: now that rendezvous streams are attached to p_streams, the p_streams list can consist of both AP and EXIT conns. svn:r6945	2006-07-30 04:54:13 +00:00
Roger Dingledine	2bcb081cb1	defense in depth svn:r6939	2006-07-30 04:32:58 +00:00
Roger Dingledine	c3b79ebf13	a bit more debugging for phobos svn:r6937	2006-07-30 03:34:44 +00:00
Nick Mathewson	84c2a6c16b	r6950@Kushana: nickm \| 2006-07-28 10:32:08 -0400 Document split fields better. Now, I think we can take a break from type splitting for a bit. svn:r6935	2006-07-28 15:11:28 +00:00
Nick Mathewson	85f381153b	r6949@Kushana: nickm \| 2006-07-28 10:17:38 -0400 Shave another 8 bytes from connection_t: turn inbuf_reached_eof into a bit, and lower timestamp_lastempty to or_connection_t svn:r6934	2006-07-28 15:11:20 +00:00
Nick Mathewson	6dc13cdbeb	r6948@Kushana: nickm \| 2006-07-28 10:10:35 -0400 Identify some likely target fields for lowering; lower global_identifier (since we only use it for AP streams and origin circs). svn:r6933	2006-07-28 15:11:11 +00:00
Roger Dingledine	a5e5074807	resolve typo svn:r6927	2006-07-27 19:35:11 +00:00
Nick Mathewson	c2f28615ed	More asserts in dns.c svn:r6926	2006-07-27 18:35:56 +00:00
Nick Mathewson	45c3a4365f	Get better numbers out of HT_REP_OK svn:r6924	2006-07-27 17:37:37 +00:00
Nick Mathewson	dc2b7e9af0	Add more asserts in dns_found_answer. This may confirm my theory that dns_purge_resolve is the culprit. svn:r6922	2006-07-27 17:16:10 +00:00
Nick Mathewson	5227395aba	r6922@Kushana: nickm \| 2006-07-26 16:32:24 -0400 Rename some fields, compress a bitfield, and document some structs and fields svn:r6919	2006-07-27 05:03:57 +00:00
Nick Mathewson	dd779d99ea	Fix comments that implied that only dir connections had a purpose field, and the code that believed in those comments. svn:r6918	2006-07-27 04:10:51 +00:00
Nick Mathewson	0bc741ba7f	r6918@Kushana: nickm \| 2006-07-26 15:22:28 -0400 Fix compilation for eventdns dns.c with split structs. svn:r6908	2006-07-26 19:29:30 +00:00
Nick Mathewson	ec82db6995	r6909@Kushana: nickm \| 2006-07-26 13:05:58 -0400 Clean up wide lines from last patch. svn:r6907	2006-07-26 19:07:37 +00:00
Nick Mathewson	4ff4577beb	r6908@Kushana: nickm \| 2006-07-26 12:38:52 -0400 Refactor connection_t into edge, or, dir, control, and base subtypes. This might save some RAM on busy exit servers, but really matters most in terms of correctness. svn:r6906	2006-07-26 19:07:26 +00:00
Nick Mathewson	18771e851f	r6907@Kushana: nickm \| 2006-07-25 19:03:43 -0400 Realign circuit structs to avoid wasted space. svn:r6905	2006-07-26 19:07:23 +00:00
Nick Mathewson	e61d28dfb8	r6903@Kushana: nickm \| 2006-07-25 18:22:48 -0400 No circuit can be both an intro point and a rend point, so we can merge both the cookie and the pk digest into one "rend_token" field for or circuits. This saves another 20 bytes per or circuit. svn:r6904	2006-07-26 19:05:41 +00:00
Nick Mathewson	a88ec48a39	r6902@Kushana: nickm \| 2006-07-25 17:30:27 -0400 Move rend_query to origin_circuit_t where it belongs; save another 17 bytes per OR circuit. svn:r6903	2006-07-26 19:05:34 +00:00
Nick Mathewson	96bcbb1e1c	Remove code to special-case "-cvs" ending, since it has not actually mattered since 0.0.9. Perhaps we can special-case even more... svn:r6898	2006-07-25 04:34:14 +00:00
Peter Palfrader	521c006fd5	Remove .cvsignore files from trunk svn:r6891	2006-07-25 01:00:48 +00:00
Roger Dingledine	c9b8458f59	publish a new descriptor after we hup. this is important if our config has changed such that we'll want to start advertising our dirport now, etc. svn:r6819	2006-07-23 11:50:03 +00:00
Nick Mathewson	d27cbf5d4b	Fix another segfault in assert_circuit_ok. svn:r6818	2006-07-23 08:13:45 +00:00
Nick Mathewson	7239262f71	Don't tell anybody, but we're going OO here. This patch splits circuit_t into origin_circuit_t and or_circuit_t. I fixed some segaults; there may be more. We still need to move more rendezvous stuff into subtypes. This is a trial run for splitting up connection_t; if the approach is insane, please say so soon so we can do something smarter. Also, this discards the old HALF_OPEN code, which nobody seems to want. svn:r6817	2006-07-23 07:37:35 +00:00
Roger Dingledine	40cc536307	rewrite conn->address for GET commands as well as POST commands. svn:r6815	2006-07-23 06:41:02 +00:00
Roger Dingledine	0b5ad1bcfb	use tor_mem_is_zero() in more places. svn:r6814	2006-07-23 05:52:27 +00:00
Nick Mathewson	4280218a42	Delete trailing whitespace in eventdns.c svn:r6813	2006-07-23 05:40:24 +00:00
Nick Mathewson	1c0f02f657	Add (void) lines for unused parameters in eventdns.c svn:r6812	2006-07-23 05:39:37 +00:00
Nick Mathewson	f4e506f423	Remove STRUCT_OFFSET from config.c svn:r6811	2006-07-23 05:33:10 +00:00
Roger Dingledine	ee789052b8	whitespace and docs svn:r6808	2006-07-23 05:18:29 +00:00
Roger Dingledine	00aefaab6b	think harder about my logic svn:r6806	2006-07-22 07:19:11 +00:00
Roger Dingledine	2d6a4d283b	i lied, that won't work at all. maybe this will. svn:r6805	2006-07-22 07:15:34 +00:00
Roger Dingledine	444f096d2d	more bulletproof reachability testing svn:r6804	2006-07-22 05:29:31 +00:00
Nick Mathewson	64c14d8ce3	These asserts will either cause spurious crashes or help debug the pend->conn->s == -1 issue. svn:r6803	2006-07-21 22:02:58 +00:00
Roger Dingledine	2249180b60	bugfix: if you find yourself reachable, then don't ever make any client requests (so you stop predicting circuits), then hup, then later your IP changes, you won't think circuits are working so you won't try to test reachability, so you won't publish. svn:r6800	2006-07-21 07:55:35 +00:00
Roger Dingledine	4d5fab4f9a	tweak svn:r6799	2006-07-21 07:53:21 +00:00
Roger Dingledine	9283ddb760	an entry guard that is "unlisted", as well as not known to be "down", is not therefore "up". svn:r6798	2006-07-21 07:06:18 +00:00
Roger Dingledine	237c7ecbfd	tweak svn:r6796	2006-07-20 23:45:26 +00:00
Roger Dingledine	97a14b2018	tweak svn:r6795	2006-07-20 23:33:11 +00:00
Roger Dingledine	db657ea0af	don't squeal if the first few retries fail. svn:r6791	2006-07-18 04:48:59 +00:00
Roger Dingledine	892f671f59	Define a schedule for how long to wait between retrying application connections. Rather than waiting a fixed amount of time between each retry, we wait only 5 seconds for the first, 10 seconds for the second, and 15 seconds for each retry after that. Hopefully this will improve the expected experience. Addresses bug 297. svn:r6790	2006-07-18 04:42:32 +00:00
Roger Dingledine	e1f30a5f21	when we find our dirport to be reachable, mark our descriptor dirty so we'll tell the world. (fixes bug 306 reported by pnx) svn:r6787	2006-07-18 03:06:55 +00:00
Roger Dingledine	ac258d2cc8	Start publishing one minute or so after we find our ORPort to be reachable. This will help reduce the number of descriptors we have for ourselves floating around, since it's quite likely other things (e.g. DirPort) will change during that minute too. svn:r6786	2006-07-18 03:06:12 +00:00
Nick Mathewson	7fcb267e24	Oh. And apparently, msvc6 doesnt think very much of doing u64-and-double arithmetic either. svn:r6785	2006-07-18 02:24:01 +00:00
Roger Dingledine	388ac4126a	If we are using an exit enclave and we can't connect, e.g. because its webserver is misconfigured to not listen on localhost, then back off and try connecting from somewhere else before we fail. svn:r6783	2006-07-18 00:59:46 +00:00
Roger Dingledine	a8444c6f53	pick a log domain; resolve an xxxx svn:r6782	2006-07-18 00:01:12 +00:00
Roger Dingledine	c85745cfe2	parameterize the loudness of log_addr_has_changed(), since it's the only place where we inform the user of a new IP address, if we're guessing it from external sources. svn:r6780	2006-07-17 19:33:54 +00:00
Roger Dingledine	542adb88d7	Make a louder statement the first time we learn a guessed IP address. svn:r6779	2006-07-17 08:17:51 +00:00
Roger Dingledine	c055a34cdb	huge bugfix: we weren't ever writing an http header when sending out network statuses! so clients were downloading the whole thing, and then discarding them because they're malformed. svn:r6778	2006-07-17 08:11:27 +00:00
Roger Dingledine	a2a89da693	and don't try to build the descriptor every second, if it's dirty but we don't have a known address. svn:r6777	2006-07-17 06:59:56 +00:00
Roger Dingledine	42e2057d67	fix some more places where we shouldn't crash if we can't build our own descriptor yet. svn:r6775	2006-07-17 06:54:28 +00:00
Roger Dingledine	9db7b2c068	Allow servers with no hostname or IP address to learn their IP address by asking the directory authorities. This code only kicks in when you would normally have exited with a "no address" error. This design is flawed, though, since the X-Your-Address-Is header is not authenticated, and doing it this way introduces too many new attacks. The right answer is to give IP address hints inside the HELLO cell; much of this code can be reused when we switch. svn:r6774	2006-07-17 06:35:06 +00:00
Nick Mathewson	e572d5990c	MSVC6 is apparently terrified of unnatural cross-breeding between uint64_t and double, and needs more persuasion than usual to cast one to the other. Issue identified by Frediano Ziglio; patch revised for minimal impact on non-MSVC6 compilers. svn:r6768	2006-07-17 00:39:05 +00:00
Roger Dingledine	886b10bbe2	whitespace/etc cleanups svn:r6765	2006-07-16 05:57:11 +00:00
Roger Dingledine	ee5f512e13	parameterize the loudness of resolve_my_address(), and call things IP addresses, not IPs. svn:r6764	2006-07-15 20:26:05 +00:00
Roger Dingledine	3d79eb52ab	stick to nick's nul/null convention svn:r6763	2006-07-15 19:21:30 +00:00
Roger Dingledine	c4411841d2	Avoid an integer underflow when the dir authority decides whether a router is stable: we might wrongly label it stable, and compute a slightly wrong median stability, when a descriptor is published later than now. Inspired by Matt's Vidalia checkin: http://trac.vidalia-project.net/changeset/1074 svn:r6758	2006-07-14 03:14:02 +00:00
Nick Mathewson	a0cf95e1c9	Add some debugging asserts to dns.c; these are too expensive to leave in permanently. svn:r6756	2006-07-11 20:51:58 +00:00
Nick Mathewson	c32e19b4ed	OR_CONN_EVENT_NEW: we should probably handle that , should we not? Especially since 23:26 < phobos> nickm: grep -c "Unrecognized status code 4" tor.log svn:r6752	2006-07-11 03:33:16 +00:00
Nick Mathewson	39344fc301	Add a const; fix a (probably harmless) bug when storing a resolve we forgot we asked for. svn:r6751	2006-07-10 18:38:57 +00:00
Nick Mathewson	a7a1d4e3d3	First part of making mmap-based stuff work on win32: save descriptors as "binary" (no LF->CRLF tanslation) so that we can mmap them properly later. Patch from Frediano Ziglio. svn:r6748	2006-07-09 22:28:12 +00:00
Roger Dingledine	51454157a0	Fix a crash if you enable FascistFirewall but not FirewallPorts. Reported by Frediano Ziglio. svn:r6746	2006-07-08 17:38:46 +00:00
Nick Mathewson	0bbc4aca9b	Spellcheck and remove spurious include in eventdns.c svn:r6745	2006-07-07 19:08:44 +00:00
Nick Mathewson	a40ad152b1	When using eventdns: suppress logging of addresses when SafeLogging is active, and make set of nameservers configurable from torrc. svn:r6744	2006-07-07 17:33:30 +00:00
Nick Mathewson	f33c4f9781	eventdns: check for malloc() failures. svn:r6743	2006-07-07 17:31:56 +00:00
Roger Dingledine	85fd582192	rename X-You-Are to something slightly better. svn:r6735	2006-07-06 03:05:01 +00:00
Roger Dingledine	7f01dc9c1c	whitespace/tab fixes svn:r6734	2006-07-06 02:45:46 +00:00
Roger Dingledine	fad85f173a	when an exit node gets a malformed begin cell, don't complain to the node operator, since he can't do anything about it. svn:r6733	2006-07-06 02:44:07 +00:00
Nick Mathewson	3c4205c872	Clean up eventdns messages. svn:r6730	2006-07-05 21:42:18 +00:00
Nick Mathewson	54779025e2	Spelling fix. svn:r6729	2006-07-05 21:33:46 +00:00
Nick Mathewson	42ef3bd90c	Add plausile logging support to eventdns; stop putting stuff onto stdout. svn:r6728	2006-07-05 21:28:37 +00:00
Roger Dingledine	0ec293b189	actually, that excludenodes fix was redundant. take it out. svn:r6727	2006-07-05 18:19:42 +00:00
Roger Dingledine	98c6bf6192	oops, we were ignoring options->ExcludeNodes when picking entry guards. it is still the case that we ignore it with respect to entry guards that we've already picked. svn:r6726	2006-07-04 20:25:17 +00:00
Roger Dingledine	4fc7426b93	Make the X-You-Are header more accurate when there's a proxy in the middle. svn:r6722	2006-07-04 18:18:08 +00:00
Roger Dingledine	05d0b70573	Get rid of the router_retry_connections notion. Now routers no longer try to rebuild long-term connections to directory authorities, and directory authorities no longer try to rebuild long-term connections to all servers. We still don't hang up connections in these two cases though -- we need to look at it more carefully to avoid flapping, and we likely need to wait til 0.1.1.x is obsolete. svn:r6712	2006-07-04 03:31:27 +00:00
Roger Dingledine	ff1b4764e9	No longer permit create cells to have the wrong circ_id_type. No running Tors should still have this bug. svn:r6711	2006-07-04 03:27:09 +00:00
Roger Dingledine	dc79dd6a46	minor fixes svn:r6709	2006-07-04 03:19:59 +00:00
Nick Mathewson	9fce316d1c	Oops. Headers work better when named right. svn:r6707	2006-07-01 21:51:21 +00:00
Nick Mathewson	60de51993a	Unify HTTP response code into one place so it is easier to add headers. Add an X-You-Are header, which we should probably rename. NOTE that we should not use this field for things where it matters if dirs lie. svn:r6705	2006-06-30 10:50:43 +00:00
Roger Dingledine	d45757ebcb	also remove word 'middleman' from a log notice svn:r6704	2006-06-29 13:11:23 +00:00
Nick Mathewson	475eb5d6fe	Apparent 311 fix: apparently passing Z_FINISH an empty string is problematic. svn:r6702	2006-06-29 11:19:52 +00:00
Nick Mathewson	4b49d298eb	complete_only == !allow_partial. This enables useful use of partial desc downloads. Backport candidate svn:r6700	2006-06-29 11:04:42 +00:00
Roger Dingledine	c22c7b96f5	tab-man strikes again svn:r6699	2006-06-28 15:39:02 +00:00
Nick Mathewson	8b08ab52fd	Fix another idiot bug causing symptom 309. Why cant I program? svn:r6698	2006-06-28 15:36:28 +00:00
Nick Mathewson	96bfefeeb6	Add a check to try to make cache rebuild fail fast if it is going to fail svn:r6697	2006-06-28 11:03:34 +00:00
Nick Mathewson	4dac383f5a	Aaand re-disable the bogus test in get_body() svn:r6696	2006-06-28 08:57:41 +00:00
Nick Mathewson	d547ecc916	Make sure that our calculated offsets for routers is correct; again. This time bug 309 may be gone gone gone. svn:r6695	2006-06-28 08:55:53 +00:00
Nick Mathewson	d3784ff1df	Likely fix for bug 309: when we calculate offsets after rebuilding the descriptor cache, do not reset the offset pointer half-way through. svn:r6693	2006-06-27 15:52:51 +00:00
Roger Dingledine	f88d555ce0	refuse to write an iso_time which we can't parse, when dumping bandwidth state. this fixes the particular incident in bug 308, but the general issue remains. svn:r6684	2006-06-24 04:57:59 +00:00
Nick Mathewson	b4b8da5d23	Turn a while into a do/while; save a redundant test svn:r6683	2006-06-24 02:10:21 +00:00
Nick Mathewson	b82dfdd4a3	Make some more verbose gcc warnings go away. svn:r6680	2006-06-22 07:34:04 +00:00
Nick Mathewson	52b8dfa95a	Fix a bunch of spaces. svn:r6678	2006-06-22 07:25:15 +00:00
Nick Mathewson	89a1453776	Set offset properly when parsing cache. svn:r6677	2006-06-22 07:19:28 +00:00
Nick Mathewson	58b05fc84d	#if out test that was failing because of an extra newline. svn:r6676	2006-06-22 07:10:37 +00:00
Nick Mathewson	b7910202a3	Next batch of memory miserdom: mmap cached-routers file. This is sure to break somewhere. svn:r6675	2006-06-22 07:01:54 +00:00
Nick Mathewson	e2697a62ac	When requesting or serving resources via fingerprint/digest, request and respond in-order, removing duplicates. svn:r6673	2006-06-21 04:57:12 +00:00
Peter Palfrader	7b6c435066	<nickm> ooh, that log shouldn't be there. can you take it out? svn:r6671	2006-06-20 23:11:15 +00:00
Nick Mathewson	0799154ae1	Fix bug in networkstatus spooling: spool more than the first networkstatus. svn:r6670	2006-06-20 23:06:52 +00:00
Nick Mathewson	0e09b26112	Fishy, but harmless. svn:r6669	2006-06-20 16:48:32 +00:00
Roger Dingledine	ef78e4245f	add a note for nick to fix svn:r6668	2006-06-20 13:14:07 +00:00
Nick Mathewson	a9e1a4c33c	Ah. We need a new zlib_state for each networkstatus we spool out. svn:r6667	2006-06-20 06:27:13 +00:00
Nick Mathewson	4283b81a48	Start spooling v2 networkstatus docs as well. svn:r6664	2006-06-20 00:48:23 +00:00
Nick Mathewson	3f7f069a05	Fix a tricky crash: making the_directory heap-allocated (so we could refcount it and have multiple instances as neeeded) means that calls to dirserv_regenerate_directory could invalidate the auth_dir value passed to dirserv_pick_cached_dir_obj. Big fun. svn:r6663	2006-06-18 21:30:03 +00:00
Nick Mathewson	2552d5e60f	Fix an assert that still isnt the assert we are hunting. svn:r6662	2006-06-18 21:15:01 +00:00
Roger Dingledine	37c441d96f	correct a function comment in compute_preferred_testing_list() svn:r6660	2006-06-18 21:07:45 +00:00
Nick Mathewson	f1993b8b30	Become capable of noticing that we are done sending a directory. svn:r6659	2006-06-18 20:58:27 +00:00
Nick Mathewson	5c0d7fb016	Resolve control flow warning. svn:r6658	2006-06-18 20:39:46 +00:00
Nick Mathewson	0932f463ff	Ah. That seems to work. svn:r6657	2006-06-18 16:39:26 +00:00
Nick Mathewson	5ba72d0ae5	another write_to_buf_zlib fix. svn:r6656	2006-06-18 16:20:38 +00:00
Nick Mathewson	b5c599412f	Backport candidate: implement the "is this uptime change cosmetic" test properly. svn:r6654	2006-06-18 16:05:54 +00:00
Nick Mathewson	a9cffd2ff0	Re-enable buffer RAM guard values. svn:r6653	2006-06-18 15:53:54 +00:00
Nick Mathewson	11c2e97d51	Another _zlib fix. svn:r6652	2006-06-18 09:03:48 +00:00
Nick Mathewson	337ad6420b	Make connection_write_to_buf_zlib set outbuf_flushlen right. svn:r6651	2006-06-18 08:53:09 +00:00
Nick Mathewson	537104c908	write_to_buf != connection_write_to_buf. Also, add a connection_write_to_buf_zlib wrapper that sucks. svn:r6650	2006-06-18 08:46:55 +00:00
Nick Mathewson	10b7b57616	Temporarily disable sentinels on buffers svn:r6649	2006-06-18 08:44:34 +00:00
Nick Mathewson	9376d901ed	make zlib buffer function set buf_highwater properly svn:r6648	2006-06-18 08:21:27 +00:00
Nick Mathewson	4d02ccfed8	Stop trying to refresh when we are out of data. svn:r6647	2006-06-18 08:19:35 +00:00
Nick Mathewson	b9013cbe98	And actually check the url when it exists. that might work better. svn:r6646	2006-06-18 08:16:05 +00:00
Nick Mathewson	c374340c70	That dir_refresh_src fix will only work if I enable it. svn:r6645	2006-06-18 08:13:45 +00:00
Nick Mathewson	347bcec84a	Fix a couple of bugs in last patch. svn:r6644	2006-06-18 08:07:16 +00:00
Nick Mathewson	c58cc8c16c	add coverage for a default case svn:r6643	2006-06-18 07:57:47 +00:00
Nick Mathewson	b1a8b7869a	Oops. conn->requested_resource is client only. svn:r6642	2006-06-18 07:55:04 +00:00
Nick Mathewson	1d9923da7c	Instead of adding servers and v1 directories to buffers en masse, directory servers add them on the fly as their outbufs are depleted. This will save ram on busy dirservers. svn:r6641	2006-06-18 07:38:55 +00:00
Nick Mathewson	8fa8616ec7	Add tests for several of the more recently committed functions. svn:r6639	2006-06-18 07:35:10 +00:00
Nick Mathewson	cd38511a1e	Part of incremental encryption logic for buffers: there is a subtle yucky point documented in a comment. svn:r6637	2006-06-18 07:27:47 +00:00
Peter Palfrader	2ff24dbc26	And a minor bugfix to the weaselhack svn:r6629	2006-06-15 23:14:01 +00:00
Roger Dingledine	af0e47c921	fix spacing svn:r6628	2006-06-15 22:59:07 +00:00
Peter Palfrader	bc64becd12	Add a /tor/dir-all-weaselhack directory resource so I do not have to update my scripts svn:r6627	2006-06-15 22:52:56 +00:00
Roger Dingledine	4e4cc9aa27	lower the number of seconds before we yell about clock jump. and make the yelling only happen if you're a server. svn:r6625	2006-06-15 09:03:15 +00:00
Roger Dingledine	de7a9c83d8	upgrade the severity of the 'clock jump' warn, and ask people to report if it occurs. svn:r6623	2006-06-14 22:28:16 +00:00
Roger Dingledine	09dfe1b265	bugfix: discourage picking directory authorities as our TestVia hops, even if they're running the right versions, since we probably already have a connection established to them. svn:r6622	2006-06-14 11:06:43 +00:00
Nick Mathewson	66db3afb74	eventdns: Apply a couple of patches from AGL; start working on windows compat; note some TODOs. svn:r6621	2006-06-13 21:49:56 +00:00
Roger Dingledine	977574e48d	back off and add the $ at the beginning of the preferrednodes list we generate. svn:r6620	2006-06-13 12:57:19 +00:00
Roger Dingledine	2cd349903c	be more lax about recognizing valid hexdigests. svn:r6619	2006-06-13 12:05:59 +00:00
Roger Dingledine	b4e415ba3c	now we can tell dirserv_dump_directory_to_string() whether we want it to include down/invalid descriptors or not. svn:r6618	2006-06-13 11:11:19 +00:00
Roger Dingledine	88dadc917c	bugfix in exit_policy_is_general_exit() that weasel found. this time for sure! svn:r6617	2006-06-13 10:48:26 +00:00
Roger Dingledine	23e2c6a7dd	first cut at a workaround for the reachability bug: explicitly find a server running the right version, if we can, and ask for that one. svn:r6616	2006-06-13 10:25:22 +00:00
Roger Dingledine	31b51849b5	export the default exit policy via the control port, so controllers don't need to guess what it is / will be later. svn:r6615	2006-06-13 09:16:09 +00:00
Roger Dingledine	279e86f3c8	Defense in depth: fix the reachability bug a second way too. Now if we establish a connection with the right digest, regardless of what the addr/port is, and we have pending create cells, use it. svn:r6614	2006-06-13 05:51:28 +00:00
Roger Dingledine	a20a384b09	harmless typo svn:r6613	2006-06-13 05:50:24 +00:00
Roger Dingledine	ab61c40661	Fix the bug that was causing servers to not find themselves reachable if they changed IP addresses. This happened because middle servers knew the old descriptor, and kept swapping the addr/port we asked for with the one they thought was right. So the create cell never got sent, because it was asking for a different addr/port than we believed we had connected to. svn:r6610	2006-06-13 05:36:35 +00:00
Roger Dingledine	19408cf8d7	reintroduce the logic to exit_policy_is_general_exit() to count how many ports are allowd. require two ports open, not just one. svn:r6609	2006-06-13 02:48:06 +00:00
Peter Palfrader	cce8ae1190	Make the Exit tag in status documents actually work in head too svn:r6608	2006-06-12 22:03:25 +00:00
Roger Dingledine	87e3800dfc	Finally solve the "closing wedged cpuworkers" bug. Woo. This happened when we got two create cells in a row from the same TLS connection. It would hand one to the cpuworker, and then immediately handle the second one -- after it had registered that the first one was busy, but before it had updated the timestamp that we use to decide how long it's been busy. svn:r6606	2006-06-12 11:59:19 +00:00
Roger Dingledine	cbc4cd93ac	allow people to start their tor with runasdaemon set but with no logs set at all. svn:r6604	2006-06-12 06:03:15 +00:00
Roger Dingledine	14687fc443	take out the reachability bandaid in 0.1.2.x as well. maybe we will actually be able to fix it, instead. svn:r6585	2006-06-10 00:57:12 +00:00
Roger Dingledine	889b8d5bac	Add a new config option TestVia, that lets you specify preferred middle hops to use for testing circuits. Perhaps this will let me debug the reachability problem better. svn:r6581	2006-06-10 00:26:39 +00:00
Roger Dingledine	6531a31aad	actually, don't fix it that far. we should still do some error checking. svn:r6576	2006-06-09 09:07:59 +00:00
Roger Dingledine	0071d67efd	when only one router is labelled as a guard, and we've already picked him, we would cycle endlessly picking him again, being unhappy about it, and so forth. now we specifically exclude guards when picking a new guard. svn:r6575	2006-06-09 09:02:32 +00:00
Roger Dingledine	30f6c57fd7	and forward-port too. svn:r6573	2006-06-09 06:52:49 +00:00
Roger Dingledine	a91be49402	fix a bootstrapping check we ignored that prevents us from running with only one dir authority. svn:r6570	2006-06-09 02:45:39 +00:00
Roger Dingledine	11dcb7f4ae	try a better string at the top of torrc's autogenerated torrc. svn:r6569	2006-06-09 02:20:42 +00:00
Roger Dingledine	bb18168fae	ok, ok, maybe this time my rep_hist_circbuilding_dormant() will work. svn:r6568	2006-06-08 22:36:13 +00:00
Roger Dingledine	18eb8192db	remove a bit more obsolete code svn:r6566	2006-06-08 09:35:20 +00:00
Roger Dingledine	a18766e50c	ah, that explains why we weren't going dormant with respect to descriptor fetches. maybe now it will work. svn:r6565	2006-06-08 09:20:58 +00:00
Roger Dingledine	91bd12c20d	re-enable per-connection rate limiting. get rid of the "OP bandwidth" concept. lay groundwork for "bandwidth classes" -- separate global buckets that apply depending on what sort of conn it is. svn:r6563	2006-06-07 09:18:53 +00:00
Roger Dingledine	741b11df45	put a bandaid in place so servers will have an easier time believing that they're reachable. this may help resolve the servers-on-dynamic-ip-addresses problem. svn:r6561	2006-06-07 08:42:24 +00:00
Roger Dingledine	1e9b35aee3	make connection_or_nonopen_was_started_here() based on something less voodooey. it turns out we already do keep a flag like that around. svn:r6560	2006-06-07 07:11:42 +00:00
Roger Dingledine	8cf45df230	and now the exciting part: there is now no such thing as doing a client-only tls, that is, one with no certs. svn:r6558	2006-06-07 06:21:11 +00:00
Roger Dingledine	0bfef523df	simplify the tortls api: we only support being a "server", that is, even tor clients do the same sort of handshake. this has been true for years, so it's best to get rid of the stale code. svn:r6557	2006-06-07 06:10:54 +00:00
Roger Dingledine	96914760bc	fix the bug where we sometimes would fail to send some create cells once we'd connected to a(nother) tor server. svn:r6552	2006-06-06 03:33:24 +00:00
Nick Mathewson	5e4b4451ec	Also, add a temporary hack to make sure eventdns.c is distributd. svn:r6551	2006-06-06 00:12:22 +00:00
Roger Dingledine	5c57348acd	We got an obscure report of an assert error on a windows Tor server with connection_add being called with socket = -1. The only places I can see where that happen would be if our tor_socketpair succeeds but it hands back negative values for some of its file descriptors. Perhaps this will produce more useful assert errors next time. svn:r6550	2006-06-06 00:06:52 +00:00
Roger Dingledine	411f37d534	fix typo svn:r6549	2006-06-06 00:05:39 +00:00
Roger Dingledine	07c35b4f52	ship the event*.h files too. perhaps this will make my 'make dist' produce a tarball that i can build. svn:r6548	2006-06-06 00:04:52 +00:00
Nick Mathewson	2bd7c19b73	Try to log useful messages at info and debug about what we are resolving and what answers we are getting wrt eventdns. svn:r6547	2006-06-05 23:01:22 +00:00
Roger Dingledine	542b8af592	don't tell people that the testing circuit failed if we already consider ourselves reachable. this just confuses them. svn:r6546	2006-06-05 10:01:52 +00:00
Roger Dingledine	a2fec314b6	scream louder if you've got a pending circuit for a given addr/port but the intended n_conn digest is wrong. svn:r6544	2006-06-05 09:47:19 +00:00
Roger Dingledine	45065f1466	simplify code now that libevent considers all sockets pollable. what we really mean now is ">= 0", which is clearer to test for. svn:r6543	2006-06-05 09:08:10 +00:00
Roger Dingledine	4e773352c2	bugfix: if we are making our first ever connection to any entry guard, then don't mark it down at first. we had this implemented but it was disabled due to a bug. svn:r6541	2006-06-05 08:58:18 +00:00
Roger Dingledine	8f3bb66ebc	simplify some code, since circuit_build_failed() is only called on non-open circuits. svn:r6540	2006-06-05 08:25:02 +00:00
Roger Dingledine	152d6d13b4	remove some unused code (i think) svn:r6539	2006-06-05 08:02:04 +00:00
Roger Dingledine	bf09898f79	Note a bug that causes servers to sometimes never send the pending create cell. Nick, is this a bug? If so, is my fix right? svn:r6538	2006-06-05 07:27:48 +00:00
Nick Mathewson	b7ca697faf	More eventdns.c patches: use HAVE_ALLOCA_H; print IP addrs as dotted quads. svn:r6535	2006-06-05 01:59:12 +00:00
Nick Mathewson	3db785ef73	Hm. Where did we put that ntohl the last time we were juggling it? (hoop-lah). svn:r6534	2006-06-05 00:32:31 +00:00
Nick Mathewson	008a0c7c46	Some eventdns.c fixes for windows correctness. More will doubtless be needed, especially around the #includes. svn:r6533	2006-06-04 23:23:53 +00:00
Nick Mathewson	853e2d99b6	Add a new warning to our "warn a lot" list: unused parameters. This means we have to explicitly "use" unuseds, but it can catch bugs. (It caught two coding mistakes so far.) svn:r6532	2006-06-04 22:42:13 +00:00
Roger Dingledine	c4647545a0	if we insist on printing pointer values, at least make it stop complaining on (my particular) 64 bit platform. svn:r6530	2006-06-04 06:17:32 +00:00
Roger Dingledine	603b09b59b	punctuation and spelling svn:r6529	2006-06-04 06:16:20 +00:00
Nick Mathewson	c18fab5366	Make eventdns.[ch] into good C90; remove signed/unsigned comparisons. svn:r6528	2006-06-03 22:05:23 +00:00
Nick Mathewson	2700e5a1ab	Oops. When we dont get a TTL, we should default to the default, not to the minimum. svn:r6527	2006-06-03 21:47:26 +00:00
Nick Mathewson	c660a0f6a2	More DNS fixes. Send meaningful TTLs back to the client when possible. Cache at the server side independently from the TTL, to prevent attackers from probing the server to see who has been asking for what hostnames. (Hi, Dan Kaminski!) Also, clean some whitespace. svn:r6526	2006-06-03 21:41:14 +00:00
Nick Mathewson	85a25c8a29	Make dns.c use eventdns.c -- but only when you pass the --enable-eventdns argument to configure.in. This will so not work on Windows yet. svn:r6525	2006-06-03 20:52:24 +00:00
Nick Mathewson	7cb3232ade	Add async dns code from Adam Langley, tweaked to build on OSX. Long-term, we may want to switch to libevnet/c-ares, if they ever handle 10k fd situations properly. This one still needs work too, but at least it is small. This code is disabled by default, and not integrated with dns.c. svn:r6524	2006-06-03 19:49:42 +00:00
Roger Dingledine	8f902e4b58	don't stop fetching server descriptors if we're a server and haven't found ourselves reachable yet. svn:r6522	2006-06-03 02:56:44 +00:00
Roger Dingledine	1bf0f99b66	connection_t kept the identity_pkey but all it did was store it and free it. perhaps we don't need it after all? svn:r6518	2006-05-30 06:23:44 +00:00
Roger Dingledine	9000a5aff1	and get grammar right svn:r6517	2006-05-30 06:19:48 +00:00
Roger Dingledine	ae2648fb1c	stop fetching descriptors if we're not a dir mirror and we haven't tried to establish any circuits lately. svn:r6516	2006-05-30 06:19:06 +00:00
Roger Dingledine	1f0e20806b	END_CIRC_REASON_OR_IDENTITY apparently means that we were told to connect to a different OR than lives on the addr:port we connected to. we don't actually remember whether that was the case, currently. so call it END_CIRC_REASON_OR_CONN_CLOSED as a compromise. svn:r6515	2006-05-30 06:17:28 +00:00
Roger Dingledine	60abe23158	tentative change: if you have your dirport set, you are a directory mirror, whether or not your orport is set. svn:r6513	2006-05-30 06:11:36 +00:00
Roger Dingledine	1e4923652b	simplify a log message svn:r6512	2006-05-30 05:29:03 +00:00
Roger Dingledine	f6ff3e6f0e	directory authorities should be more tolerant of failed reachability tests before crying foul to the server operator. svn:r6509	2006-05-28 16:14:26 +00:00
Roger Dingledine	48be472e4f	clean up a comment svn:r6508	2006-05-28 16:07:44 +00:00
Roger Dingledine	7f611f4732	if we're a server and some peer has a broken tls certificate, don't shout about it unless we want to hear about protocol violations. svn:r6507	2006-05-26 16:32:16 +00:00
Roger Dingledine	82ae38f649	be more verbose about testing reachability of our ORPort. svn:r6506	2006-05-26 16:29:33 +00:00
Roger Dingledine	f579478687	correct a false log message, since we actually reset all our downloading stats every hour, and sometimes more often. svn:r6505	2006-05-26 16:29:20 +00:00
Roger Dingledine	3cd01ca9a1	make cookie authentication for the controller work again, maybe. it sure doesn't now. svn:r6494	2006-05-24 23:03:28 +00:00
Roger Dingledine	6066d68ac3	make options->RedirectExit work again; resolve bug 293. svn:r6492	2006-05-24 11:13:03 +00:00
Roger Dingledine	13c4590dd1	ignore RunAsDaemon more thoroughly when we're running on windows. svn:r6471	2006-05-23 07:04:55 +00:00
Roger Dingledine	6b058bd563	add a few more debugging lines to help mikec track down his 11 minute jump into the future. svn:r6465	2006-05-23 03:08:30 +00:00
Nick Mathewson	55c38f88b9	Remove string size limit on NEWDESC messages; solve bug 291. svn:r6463	2006-05-22 23:24:06 +00:00
Roger Dingledine	295ad74fda	Tor servers are also giving spurious "you're invalid" warnings. This is because we get a lot of network statuses that don't list us at all, and we conclude that they all think we're invalid. The long-term fix is to get better logic, and the short-term fix is to downgrade the log severity. svn:r6448	2006-05-09 09:47:47 +00:00
Roger Dingledine	27624a3024	stop telling people that "tor -h" will help them in any way. svn:r6447	2006-05-08 04:28:49 +00:00
Roger Dingledine	e24e5475fb	forward-port the ORPort==0 patch svn:r6430	2006-05-03 18:29:44 +00:00
Nick Mathewson	2b720b5746	Start remembering where we are storing routerdescs. This will make us easier to move from a RAM-mirrors-disk model to a RAM-caches-disk model, and save maybe around 10MB on a directory server. svn:r6427	2006-04-29 18:42:26 +00:00
Nick Mathewson	15dbe02c04	shorten some too-wide lines svn:r6426	2006-04-29 17:44:31 +00:00
Roger Dingledine	701341ef8a	put one of the XXX's back in svn:r6422	2006-04-25 07:06:48 +00:00
Roger Dingledine	3c86402cc2	petty cleanups svn:r6421	2006-04-25 07:00:04 +00:00
Nick Mathewson	5bce102cd2	Only warn about a down node once svn:r6420	2006-04-25 06:20:47 +00:00
Nick Mathewson	5f9612216c	you wanted it spelled properly too? And me not even funded! svn:r6418	2006-04-25 06:02:46 +00:00
Nick Mathewson	d6c04216ef	fix a segfault in last bug-285-related commit. svn:r6417	2006-04-25 05:59:31 +00:00
Nick Mathewson	c70f1e7eb3	Possible partial fix for 285; needs review svn:r6414	2006-04-24 17:51:31 +00:00
Roger Dingledine	934e9c49bb	Regenerate our local descriptor if it's dirty and some local function asks for it. This may resolve bug 286. svn:r6412	2006-04-23 23:09:03 +00:00
Roger Dingledine	c74c24a989	make more hibernate log messages use local time. we should audit to see what other log messages keep switching back and forth between GMT and local. svn:r6411	2006-04-23 23:05:34 +00:00
Roger Dingledine	2d78d74c80	Raise the timeout for complaining about wedged cpuworkers. This value is high because some servers with low memory/cpu sometimes spend an hour or more swapping, and Tor starves. svn:r6406	2006-04-18 19:48:06 +00:00
Roger Dingledine	5721747de2	class B really means /16 here svn:r6404	2006-04-18 05:03:09 +00:00
Nick Mathewson	735a2131b8	require at least 2**16 assignable virtual addresses svn:r6402	2006-04-18 04:57:07 +00:00
Nick Mathewson	7484ca06a5	[Forward-port ]Test and document last patch. svn:r6400	2006-04-18 03:51:18 +00:00
Nick Mathewson	0df40a393b	[forward-port] Implement an option, VirtualAddrMask, to set which addresses get handed out in response to mapaddress requests. Needs testing and docs! svn:r6398	2006-04-18 03:36:28 +00:00
Nick Mathewson	6ebd886511	forward-port: "Resolve" all XXX011 items, mostly by marking them non-011. svn:r6396	2006-04-18 03:07:24 +00:00
Roger Dingledine	47d3e23155	note another bug: we complain that a router doesn't exist, because it's down so we never fetched it so it doesn't exist. svn:r6394	2006-04-17 06:46:20 +00:00
Roger Dingledine	34bc0866d4	slightly clearer log message when you use a nickname rather than a key for an unnamed server. svn:r6393	2006-04-17 06:43:27 +00:00
Roger Dingledine	07ff409876	no need to escape the address for our connections -- they are always IP addresses. svn:r6389	2006-04-16 22:34:00 +00:00
Roger Dingledine	0cee3e1fc7	if the bottom eighth of the servers by bandwidth is really crummy, try the bottom quartile instead. svn:r6387	2006-04-15 07:15:23 +00:00
Roger Dingledine	3791d3daaa	forward-port the n_named log severity downgrade. svn:r6385	2006-04-14 20:19:33 +00:00
Roger Dingledine	64041d2dbf	ok, put moria1 back in, since it's v1 and thus we need to send our rendezvous descriptors to it. eventually we might make a 'v1only' tag that explains it's only for rendezvous descriptors. svn:r6382	2006-04-11 14:12:04 +00:00
Roger Dingledine	e720cc6589	drop moria1 from the list of authorities. svn:r6381	2006-04-10 21:40:43 +00:00
Peter Palfrader	beb9e0721a	Stop assuming every authority is a v1 authority svn:r6377	2006-04-10 21:29:29 +00:00
Nick Mathewson	1fbc74661f	Remove DER64 functions in trunk: they will never be used again unless the directory authorities switch back to 0.0.9tooearly. svn:r6376	2006-04-10 21:23:00 +00:00
Roger Dingledine	12d461a245	make DirFetchPeriod and StatusFetchPeriod truly obsolete. svn:r6373	2006-04-10 20:16:46 +00:00
Roger Dingledine	f89b0ea09f	be willing to add our own routerinfo into the routerlist. this means authorities will include themselves in their directories and network-statuses. svn:r6369	2006-04-10 20:00:31 +00:00
Peter Palfrader	fe6c1b0192	Remove redundant includes. They are all hanled in torint.h which we already do include. svn:r6364	2006-04-10 19:39:26 +00:00
Roger Dingledine	b190c451b8	and one more kick to consider all live network statuses for versions svn:r6359	2006-04-10 08:40:16 +00:00
Roger Dingledine	a9e7737c3a	consider all live network statuses we have when deciding whether our version is bad. also, unfix one of the unbugs from before. svn:r6358	2006-04-10 08:37:16 +00:00
Nick Mathewson	1064bbc62a	Fix a wide line svn:r6357	2006-04-10 08:05:00 +00:00
Nick Mathewson	71f1a77371	fix bugs in compute_recommended_versions svn:r6356	2006-04-10 08:02:56 +00:00
Nick Mathewson	53f7a1bb0c	In fairness to gcc, a char is often _not_ usable as a const void . svn:r6355	2006-04-10 07:50:38 +00:00
Nick Mathewson	eb3e28ba79	Oops. _compare_tor_version_str_ptr wants ptr-to-ptr. Ow. svn:r6354	2006-04-10 07:40:39 +00:00
Roger Dingledine	acc2eb445d	and get rid of an extra variable svn:r6349	2006-04-10 05:48:04 +00:00
Roger Dingledine	ac2070b35b	stop being so picky about when we can start building circuits. now clients are more likely to have circuits up soon after their tor starts. svn:r6346	2006-04-10 05:44:54 +00:00
Nick Mathewson	e258276c2b	Change a dumb interface. Also, increment trusted_dir_server_t.n_networkstatus_failures when an all.z download fails entirely or partially. svn:r6345	2006-04-10 01:35:56 +00:00
Roger Dingledine	21263982e4	Don't yell loudly about failed internal/bridge connections. These are reachability testing and rendserv upload/downloads, and they have their own failure messages elsewhere. svn:r6343	2006-04-09 21:36:37 +00:00
Roger Dingledine	b6b534c9dd	quiet a bootstrapping message svn:r6342	2006-04-09 20:19:56 +00:00
Roger Dingledine	760934b175	fix typo svn:r6340	2006-04-09 10:43:03 +00:00
Roger Dingledine	ed38f46ebc	lower the minimum required number of fd's to 1000, so we can have some overhead for valgrind on linux, where the default ulimit -n is 1024. svn:r6338	2006-04-09 10:28:00 +00:00
Roger Dingledine	b18d20ce32	Here is an attempted fix for directory mirrors that are frozen in fear because they don't have all the networkstatuses. There's no reason not to proceed if all the other checks are ok -- we just shouldn't warn about certain things yet. svn:r6337	2006-04-09 10:10:09 +00:00
Roger Dingledine	0871f4ef90	Remove about 30% of the v1 directory bulk by not including down or invalid nodes. This will make exitlist's running on v1 not very good. I feel sorry for them, but not as sorry as I feel for the directory mirrors. svn:r6332	2006-04-09 01:00:24 +00:00
Roger Dingledine	d48cdbe2e0	When fetching rendezvous descriptors, we were willing to ask v2 authorities too. And of course they did not have a copy. svn:r6331	2006-04-09 00:36:15 +00:00
Roger Dingledine	b7cadc0db5	If you're not a versioning dirserver, don't put the string "client-versions \nserver-versions \n" in your network status. svn:r6329	2006-04-08 21:59:15 +00:00
Roger Dingledine	a589650496	i like the name FetchUselessDescriptors better. svn:r6327	2006-04-08 21:48:14 +00:00
Roger Dingledine	2a94c8b493	add a new config option FetchUselessRouters, off by default, for when you plan to run "exitlist" on this client and you want to know about even the non-running descriptors. svn:r6326	2006-04-08 21:35:17 +00:00
Roger Dingledine	3a5758e212	If we think of ourselves as authoritative, even if we're not in the DirServers config lines, then we still are. This way we give ourselves the "Authority" flag in our network-status. svn:r6325	2006-04-08 21:19:40 +00:00
Roger Dingledine	24b2e0530a	clean up the log lines more, and note a future work. svn:r6324	2006-04-08 21:12:07 +00:00
Roger Dingledine	b5737aab91	add dizum as the fifth authoritative directory server. svn:r6323	2006-04-08 21:03:49 +00:00
Roger Dingledine	f1692ebefc	when we do reachability testing and the tls cert at the other end disagrees with a descriptor we already have, be more useful at explaining it. svn:r6322	2006-04-08 20:35:19 +00:00
Roger Dingledine	fab1feee26	complain when we hit wsaenobufs on recv or write too. perhaps this will help us hunt the bug. svn:r6321	2006-04-08 07:54:11 +00:00
Roger Dingledine	557b174b8d	Break out the checks to see if a routerstatus is something we would use. This way when we're deciding if we have "enough" descriptors to start building circuits, we can count them accurately. svn:r6320	2006-04-08 06:56:38 +00:00
Roger Dingledine	de8ce0aae8	fix a typo that was confusing me svn:r6319	2006-04-08 06:55:10 +00:00
Nick Mathewson	5d466b7611	Fix a couple of things that make GCC complain with verbose warnings on. Also, fix some whitespace. svn:r6317	2006-04-08 05:43:52 +00:00
Nick Mathewson	7a804572ab	fix an infinite loop; answer a question svn:r6316	2006-04-07 22:55:46 +00:00
Nick Mathewson	c6d010b218	Dont warn about our own status unless weve tried and failed 4 times (or succeeded) for each authority. svn:r6315	2006-04-07 04:52:32 +00:00
Roger Dingledine	c4fb9d22cf	if there's more than one match for router-get-my-nickname, try to pick one that's running. svn:r6313	2006-04-04 03:46:40 +00:00
Roger Dingledine	0825f61102	fix crash bug reported in flyspray 279. svn:r6312	2006-04-04 03:25:36 +00:00
Roger Dingledine	453062b028	fix typo, remove extraneous variable svn:r6311	2006-04-03 11:24:14 +00:00
Roger Dingledine	7198af7fbe	one more edge case that could paralyze a client with fear svn:r6310	2006-04-03 06:59:07 +00:00
Roger Dingledine	a324871603	phrase the threshold comparison in the way we've been phrasing it. these are equivalent, right? svn:r6309	2006-04-03 06:37:35 +00:00
Roger Dingledine	4b6ff2b084	bugfix in sort_version_list() so it doesn't screw up the sorting. svn:r6308	2006-04-03 06:30:48 +00:00
Nick Mathewson	eba6204315	fix some xxxs. svn:r6307	2006-04-03 06:23:24 +00:00
Roger Dingledine	2cb3aeb4e1	another point that needs more thinking svn:r6306	2006-04-03 06:22:54 +00:00
Roger Dingledine	9549d81d95	two more thresholds to look at svn:r6305	2006-04-03 06:10:33 +00:00
Roger Dingledine	64a40b5137	nick: there is no MAX_SERVER_INTERVAL_WITHOUT_REQUEST. true? svn:r6300	2006-04-03 02:20:32 +00:00
Nick Mathewson	4130460f8e	Change networkstatus dl logic: try to have all networkstatuses live; insist on having all of them live or tried-at-least-once. Also, answer a XXXX comment. svn:r6297	2006-04-02 23:02:52 +00:00
Nick Mathewson	d663bfa306	Versions that drop connections for having used idle circs are as bad for stable as for guard svn:r6296	2006-04-02 23:01:01 +00:00
Nick Mathewson	785d25e06c	If I could forget that I had enabled StrictExitNodes, others will too. svn:r6295	2006-04-02 22:59:59 +00:00
Roger Dingledine	b34032b87d	but the \r\n is handy too i hear. svn:r6294	2006-04-02 22:19:01 +00:00
Roger Dingledine	e84cd412d4	if you give mapaddress no args at all, it should answer something more than \r\n. svn:r6293	2006-04-02 22:13:34 +00:00
Roger Dingledine	1e04b70d49	make NoPublish (even though deprecated) work again. svn:r6287	2006-04-02 02:59:48 +00:00
Roger Dingledine	dfb3c5f47a	if you ask for getinfo dir/status/ but your dirport is off, log a complaint. svn:r6286	2006-04-01 22:17:37 +00:00
Roger Dingledine	6fb27741ba	Fix dirserv_get_networkstatus_v2's api: its function comments did not at all match its behavior, and I can't think of a case when it should return anything other than 0. This fix may allow getinfo dir/status/foo to work. svn:r6285	2006-04-01 22:00:49 +00:00
Roger Dingledine	e754664d62	bugfix: when we fail to bind or listen on an incoming or outgoing socket, we should close it before failing. otherwise we just leak it. (thanks to weasel for finding.) svn:r6284	2006-04-01 10:22:57 +00:00
Roger Dingledine	e47075e771	more helpful error message svn:r6283	2006-04-01 09:54:54 +00:00
Roger Dingledine	314f24870d	Start sending back 512 and 451 errors if mapaddress fails, rather than not sending anything back at all. svn:r6282	2006-04-01 09:50:43 +00:00
Roger Dingledine	4c996757ae	We can remove about 30% of the v1 directory bulk by taking out down or invalid nodes. We should do this once we're ready. svn:r6273	2006-03-29 09:21:23 +00:00
Roger Dingledine	db1209a852	Refactor the decision of whether to include a router's descriptor in the v1 directory. No actual changes yet. svn:r6272	2006-03-29 08:56:39 +00:00
Roger Dingledine	1f4d0d2479	When deciding whether a router is Fast or Guard-worthy, consider his advertised BandwidthRate and not just the BandwidthCapacity. This is a bug in 0.1.0.x as well, but let's not bother backporting. svn:r6266	2006-03-28 12:01:58 +00:00
Nick Mathewson	685bceed1c	Make the max number of old descriptors to hold rise with the number of authorities. svn:r6254	2006-03-27 17:29:53 +00:00
Peter Palfrader	03302dc67d	On our dirport return a robots.txt so maybe google doesn't index all those server descriptors anymore svn:r6252	2006-03-27 07:33:13 +00:00
Nick Mathewson	2421724853	Code to implement networkstatus fetch from controllers. Only works when dirport is set for now; should be good enough to make serifos html front-end not be as wrong. svn:r6251	2006-03-27 06:49:25 +00:00
Roger Dingledine	56df81199a	that extra punctuation distracts me svn:r6250	2006-03-27 05:30:16 +00:00
Nick Mathewson	cd271dbca9	re-order to avoid free-then-use. Thank goodness tor_free() zeroes things. svn:r6249	2006-03-27 05:27:47 +00:00
Nick Mathewson	c74bd877e2	Oops. We may not have a networkstatus list when we first parse the cached routers. svn:r6248	2006-03-27 05:12:07 +00:00
Nick Mathewson	3e8c9a485f	Fix for "but need_to_mirror=1" annoyance; is bug 273 fixed? svn:r6247	2006-03-27 05:07:57 +00:00
Roger Dingledine	6f08d121d9	Refactor and consolidate addr/exit policies into a new policies.c. Fix some minor bugs and memory leaks along the way. svn:r6246	2006-03-27 02:25:34 +00:00
Roger Dingledine	e20aad8d46	remove obsolete address policy code svn:r6243	2006-03-26 09:38:17 +00:00
Roger Dingledine	e1c8e3ca6e	also send syntax and parse errors back to the controller. svn:r6242	2006-03-26 08:09:19 +00:00
Roger Dingledine	b899b9592a	When the controller's *setconf commands fail, collect an error message in a string and hand it back. This starts to resolve bug 275. svn:r6241	2006-03-26 06:51:26 +00:00
Peter Palfrader	e90bebf27b	Say private address instead of internal address. Both are wrong or at least not entirely correct but nobody would understand "special-use address as listed in RFC3330" I guess. svn:r6236	2006-03-25 21:24:28 +00:00
Roger Dingledine	f2abd7a69b	fix a wordo, don't be so quick to yell at servers, and ask a question. svn:r6235	2006-03-24 21:11:14 +00:00
Roger Dingledine	7edfec2ae6	bump up the magic number for how quickly we start notifying a server that it's unreachable. svn:r6234	2006-03-24 20:57:55 +00:00
Peter Palfrader	444e3b8eb2	Note a magic 2 that probably should be replaced now that we have more dirservers svn:r6232	2006-03-23 20:21:54 +00:00
Roger Dingledine	5b87b0bf55	update getinfo info/names to reflect that we now support getinfo dir/server/* svn:r6231	2006-03-22 21:53:09 +00:00
Roger Dingledine	20e66a799b	Resolve problem found by weasel: the v1 directory was including servers as much as 48 hours old, because that's how the new routerlist->routers works. Now only include them if they're 20 hours old or less. svn:r6230	2006-03-22 21:32:42 +00:00
Peter Palfrader	58307cd8de	Maybe it compiles for devilproxy now svn:r6229	2006-03-22 11:23:00 +00:00
Roger Dingledine	0d7efbe65d	Note a vulnerability with our current recommended-version concensus building. Make the warnings about invalid and unnamed nodes scale better, and update the text of the warnings. Change router_have_minimum_dir_info() to only be happy when it has enough network-statuses ("more than half") to be willing to actually build circuits. Not yet done: when we fail to get a networkstatus that we wanted, and !router_have_minimum_dir_info(), we should retry it quicker than a whole minute from now. svn:r6227	2006-03-22 06:22:12 +00:00
Roger Dingledine	51a3981d10	stop caching the v1 directory so often. svn:r6226	2006-03-22 06:18:27 +00:00
Roger Dingledine	6fb2b6785d	whoops. inform circuits again when we failed to connect to their first hop, so they don't have to time out. svn:r6225	2006-03-22 04:09:30 +00:00
Roger Dingledine	1db263ac3c	stop writing the "router.desc" file, ever. nothing uses it anymore. svn:r6224	2006-03-22 03:45:17 +00:00
Peter Palfrader	805754fdd9	Log server fingerprint on startup svn:r6223	2006-03-22 03:40:59 +00:00
Roger Dingledine	216e349cb2	parameterize two more timeout constants in circuit-land. svn:r6220	2006-03-22 00:52:37 +00:00
Roger Dingledine	ad236d4b8b	freeing is not the same as setting to null svn:r6219	2006-03-22 00:03:51 +00:00
Roger Dingledine	28fafb9022	new config option SocksTimeout: How long do we let a socks connection wait unattached before we fail it? Use this value for controller socks timeout, for normal socks timeout, and for hidden-service socks timeout. svn:r6217	2006-03-21 23:27:43 +00:00
Roger Dingledine	5399e394a8	and dirservers don't call you a guard if you're running a buggy version either. svn:r6216	2006-03-21 23:10:26 +00:00
Roger Dingledine	f11509e494	when upgrading to newer versions, throw away entry guards picked by the old wrong algorithms. svn:r6215	2006-03-21 23:06:47 +00:00
Roger Dingledine	8a8a84dd52	don't call circuit_n_conn_done() if the closing conn is already open. svn:r6214	2006-03-21 22:22:48 +00:00
Roger Dingledine	a3329036a8	Bugfix: looks like clients since 0.1.1.10-alpha have been expiring connections whenever 5 minutes pass and they do have circuits on them. svn:r6213	2006-03-21 21:58:00 +00:00
Roger Dingledine	65b575c03d	Be more patient before giving up on in-progress circuits. I have absolutely no idea if this change helps or hurts. Somebody should study this. svn:r6212	2006-03-21 21:22:52 +00:00
Roger Dingledine	0e68ec0846	put lefkada on port 80, officially. svn:r6209	2006-03-21 16:57:03 +00:00
Roger Dingledine	073d574a3f	Point out a potential DoS flaw in caching untrusted network statuses to disk. We should resolve sometime. svn:r6206	2006-03-21 05:27:35 +00:00
Roger Dingledine	415c9e878a	add lefkada as a fourth auth dir server. svn:r6205	2006-03-21 04:41:20 +00:00
Nick Mathewson	08aba015ab	Make guard bandwidth threshold higher than fast bandwidth threshold. svn:r6204	2006-03-20 21:49:55 +00:00
Nick Mathewson	1272485cd4	Make "Fast" based on median capacity, just like "Stable" is based on median uptime. svn:r6203	2006-03-20 21:41:12 +00:00
Roger Dingledine	d1d0813cf3	Allow non-printable characters for exit streams (both for connecting and for resolving). Now we tolerate applications that don't follow the RFCs. But continue to block malformed names at the socks side. svn:r6193	2006-03-19 03:55:48 +00:00
Roger Dingledine	726e825b09	i'm a little teapot, short and stout svn:r6192	2006-03-19 01:59:02 +00:00
Roger Dingledine	d8195e4128	Implement Jason Holt's SafeSocks config option. Also put a URL in the warning message for unsafe socks4 use -- previously we'd only had the URL for unsafe socks5 use. Oops. svn:r6190	2006-03-19 01:44:53 +00:00
Roger Dingledine	c06e6ddadd	Finish the transition from the word 'verified' to the words 'named' and 'valid'. svn:r6188	2006-03-19 01:21:59 +00:00
Roger Dingledine	7e2aa67fcb	simplify when we're picking a default address for when people ask for "serifos.exit". svn:r6187	2006-03-18 22:54:08 +00:00
Roger Dingledine	868d456c3b	make it so there is one place to edit for new dirservers, not two. svn:r6186	2006-03-18 22:37:27 +00:00
Roger Dingledine	cc37c2f71e	fix some typos svn:r6185	2006-03-18 09:29:05 +00:00
Roger Dingledine	67b61fe475	authdirs shouldn't complain about unreachability when they fetch a descriptor from somebody else. this is not the right time to increment the failure count. svn:r6184	2006-03-18 05:37:15 +00:00
Roger Dingledine	581795f41d	auth dir servers were only modifying a server's is_running field when they created a network status. so if nobody asked for a network status, they would never discover that any servers are is_running, so they could never build a circuit. svn:r6183	2006-03-18 01:24:04 +00:00
Roger Dingledine	cf6ba3e76f	let an authdir that's not a naming authdir start even if it doesn't have an approved-routers file. if it does, read it and parse it as usual. svn:r6182	2006-03-18 00:22:23 +00:00
Roger Dingledine	4f14826cb3	Actually, only v1 auth dir servers need to define recommendedversions. But versioning dirservers do need to cause recommendclientversions and recommendedserverversions to somehow be non-empty. svn:r6181	2006-03-17 23:25:40 +00:00
Roger Dingledine	c7839a17f5	when we're an auth dir server but don't claim to be a versioning auth dir server, don't demand that we define RecommendedVersions. svn:r6180	2006-03-17 23:21:42 +00:00
Roger Dingledine	51fc6799ad	right now we don't support entryguards on auth dirservers, but that doesn't mean we need to remind them every time they start up. svn:r6179	2006-03-17 23:19:51 +00:00
Roger Dingledine	817556315a	Implement router purposes, and don't choose a non-general purpose router when picking random nodes for a circuit. Also implement SETROUTERPURPOSE and modify +POSTDESCRIPTOR. This concludes bug 250 assuming it all works. svn:r6178	2006-03-17 22:08:59 +00:00
Roger Dingledine	7d141c6776	but i made the line too long svn:r6176	2006-03-17 19:25:36 +00:00
Roger Dingledine	f1bcc2d6f8	stop tricking server operators into thinking they got their torrc perfect, just because tor could build a circuit. svn:r6175	2006-03-17 19:20:07 +00:00
Nick Mathewson	053411e827	Comments: cleanups and additions. svn:r6174	2006-03-17 05:50:41 +00:00
Nick Mathewson	0f0e14c6e3	normalize whitespace. svn:r6173	2006-03-17 04:43:37 +00:00
Nick Mathewson	215e377224	Only warn about lack of name binding for self if we have tried downloading every networkstatus. svn:r6172	2006-03-17 04:41:57 +00:00
Roger Dingledine	9a5df4cef5	resume being printist: if the hostname contains non-printable characters, then fail. this time don't even bother telling the server operator about these cases, because what's he going to do? if it turns out that some significant population somewhere in the world uses non-printable hostnames and wants to use tor, then i hereby assume that they will contact us. svn:r6171	2006-03-15 23:36:57 +00:00
Roger Dingledine	8d1f65a222	quiet another entry guard log message svn:r6169	2006-03-15 22:48:48 +00:00
Roger Dingledine	e8fd871d8b	Stop being printist: just because our local platform doesn't consider an alleged destination to be printable doesn't mean nobody in the world will want to use it. svn:r6167	2006-03-15 19:17:34 +00:00
Nick Mathewson	13cf54b9c1	Interim fix for 272: Only warn that we are not named if we have status docs from some naming authorities. svn:r6166	2006-03-15 05:37:27 +00:00
Nick Mathewson	fb7b5545ce	Implement GETINFO(dir/server/foo); status will be harder. svn:r6165	2006-03-15 05:06:56 +00:00
Nick Mathewson	d0f24b1e46	(Missing header change) Do not warn about unknown servers in our family when they are given as hex digests. svn:r6164	2006-03-15 05:06:26 +00:00
Nick Mathewson	3c0a5f6365	Do not warn about unknown servers in our family when they are given as hex digests. svn:r6163	2006-03-15 05:04:11 +00:00
Roger Dingledine	903183ea28	if we as a directory mirror don't know of any v1 directory authorities, then don't try to cache any v1 directories. svn:r6162	2006-03-15 00:10:13 +00:00
Peter Palfrader	a4ec555228	change INET_NTOA_BUF_LEN+1 to INET_NTOA_BUF_LEN add a comment in a few places where we add weird numbers to buffer lengths svn:r6161	2006-03-14 23:40:37 +00:00
Peter Palfrader	866f6293ff	I wonder what an internal internet protocol is svn:r6159	2006-03-14 22:52:20 +00:00
Peter Palfrader	86a964d868	When we try to be a server and Address is not explicitly set and our hostname resolves to a private IP address, try to use an interface address if it has a public address. svn:r6158	2006-03-14 22:51:15 +00:00
Peter Palfrader	2ef8f772a1	Fix an off-by-one buffer size in dirserv.c that magically never hit our three authorities but broke sjmurdoch's own tor network. svn:r6157	2006-03-14 22:43:52 +00:00
Roger Dingledine	499eeced44	when event_add or event_del fail, tell us why. svn:r6156	2006-03-13 19:33:46 +00:00
Peter Palfrader	ebfb3fea6d	Fix minor semantic error with no real effect: we were doing "is_internal_IP(htonl(in.s_addr))" but in.s_addr is in network order and is_internal_IP wants host order. Change to "is_internal_IP(ntohl(in.s_addr))". svn:r6155	2006-03-13 19:09:52 +00:00
Nick Mathewson	dad60905a8	Be a little more careful when our calculated bandwidth is so high that we could never ever exhaust our bandwidth limit. This should resolve bug 130. svn:r6146	2006-03-13 01:06:55 +00:00
Nick Mathewson	bd8ffccae7	More cleanups noticed by weasel; also, remove macros that nobody uses. svn:r6143	2006-03-12 23:31:16 +00:00
Nick Mathewson	474c60b743	Cleanup on time-relaqted constants. New conventions: 1) Surround all constants by (parens), whether we'll be using them in a denominator or not. 2) Express all time periods as products (246060), not as multiplied-out constants (86400). 3) Comments like "(6060) / one hour /" are as pointless as comments like "c = a + b; / set c to the sum of a and b /". Remove them. 4) All time periods should be #defined constants, not given inline. 5) All time periods should have doxygen comments. 6) All time periods, unless specified, are in seconds. It's not necessary to say so. To summarize, the old (lack of) style would allow: #define FOO_RETRY_INTERVAL 6060 /* one hour (seconds) / next_try = now + 3600; The new style is: /* How often do we reattempt foo? / #define FOO_RETRY_INTERVAL (6060) next_try = now + RETRY_INTERVAL; svn:r6142	2006-03-12 22:48:18 +00:00
Roger Dingledine	b67a5ba498	lower the reachability timeout, so we're more likely to act quickly if a server stops being reachable. svn:r6141	2006-03-12 21:24:03 +00:00
Roger Dingledine	1fc5eb329b	We screwed up in anticipating how to add new dirservers: Old servers won't realize they're supposed to stay connected to the new dirservers, so they'll expire connections to them, but that means the dirservers will list them as unreachable. So the fix is to stop requiring an open connection when deciding if a server is reachable. This makes us slightly less accurate, but at least it will work. svn:r6140	2006-03-12 20:57:52 +00:00
Roger Dingledine	ef447507ff	a better clean-up svn:r6139	2006-03-12 20:51:02 +00:00
Roger Dingledine	a98b25137c	and another fix svn:r6138	2006-03-12 20:48:59 +00:00
Roger Dingledine	98476c71d2	make tor --verify-config closer to working svn:r6137	2006-03-12 20:46:00 +00:00
Roger Dingledine	a4da44c2b9	Now do address rewriting when the controller asks us to attach to a particular circuit too. This will let Blossom specify "moria2.exit" without having to learn what moria2's IP address is. It may also cause other controller authors some angst. Let us know. svn:r6136	2006-03-12 05:04:16 +00:00
Roger Dingledine	d80d5370e0	when we get funny-looking lines on our dirport, shut up about it. svn:r6135	2006-03-12 04:36:17 +00:00
Roger Dingledine	b5c6a990d3	fix assert while attachstream'ing a connect-wait or resolve-wait stream. svn:r6134	2006-03-12 04:33:29 +00:00
Roger Dingledine	80f0492a65	avoid shadowing a variable so we don't get sad later. svn:r6133	2006-03-12 04:07:21 +00:00
Roger Dingledine	0bd46086c3	fix bug reported by gozu: if we get a linelist or linelist_s config option from the torrc and it has no value, warn and skip rather than silently resetting it to its default. svn:r6125	2006-03-11 18:40:33 +00:00
Roger Dingledine	c8e2a051ac	huge warning sign for esc_router_info() svn:r6124	2006-03-11 17:52:55 +00:00
Nick Mathewson	4d3e709c4b	Use escaped() for remaining cases. svn:r6117	2006-03-11 02:21:30 +00:00
Roger Dingledine	86a72f73b9	make entry guard logs even quieter svn:r6116	2006-03-10 16:51:26 +00:00
Roger Dingledine	e11f900a2a	stop printing a log message at every iteration through the event loop when holding open a conn for flushing but it doesn't want to flush any more bytes yet. svn:r6114	2006-03-09 06:34:33 +00:00
Roger Dingledine	5f8d26496d	Let the controller attachstream conns that are in connect_wait or resolve_wait: we detach them first and then act as before. Resolves bug 264. svn:r6112	2006-03-09 06:29:53 +00:00
Roger Dingledine	82d1fdbaea	don't abandon entry guards until they've been dead a whole month. make entry guard log messages quieter. svn:r6106	2006-03-09 00:55:55 +00:00
Roger Dingledine	44107f6ec4	Implement NEWNYM. Nick, did I do a bad thing? svn:r6105	2006-03-09 00:18:16 +00:00
Roger Dingledine	0f39033b9f	clean up typo svn:r6103	2006-03-09 00:10:28 +00:00
Roger Dingledine	946317ae13	start using OR_CONN_EVENT_NEW. also fixes a seg fault in tor (bug 261). svn:r6101	2006-03-08 22:29:08 +00:00
Roger Dingledine	8db1e363c9	remove some redundant code now that we compress exit policies after parsing them svn:r6099	2006-03-08 19:34:34 +00:00
Nick Mathewson	1ce3713889	Possible bug 265 fix: authorities must be more strict than clients about age of acceptable routers; make routers publish every 12 hours; client ROUTER_MAX_AGE must be greater than NETWORKSTATUS_MAX_AGE+authoirty ROUTER_MAX_AGE. svn:r6095	2006-03-08 06:29:52 +00:00
Roger Dingledine	a2d71f917e	mark bug 261 svn:r6089	2006-03-06 19:47:54 +00:00
Nick Mathewson	5dc5380984	Add some "to-be-safe" escaped() wrappers to log statements in rend*.c, though I am not 100% sure that each one is necessary. svn:r6088	2006-03-06 00:25:39 +00:00
Nick Mathewson	5777ee0e1a	Add some functions to escape values from the network before sending them to the log. Use them everywhere except for routerinfo->plaftorm, routerinfo->contact_info, and rend*.c. (need sleep now) svn:r6087	2006-03-05 09:50:26 +00:00
Nick Mathewson	6a4e304d9e	Allow private:* in routerdescs; not generated yet (because older Tors do not understand it); needs testing. svn:r6086	2006-03-05 05:27:59 +00:00
Roger Dingledine	329af979e0	Add a new circuit purpose 'controller' to let the controller ask for a circuit that Tor won't try to use. Extend the EXTENDCIRCUIT controller command to let you specify the purpose if you're starting a new circuit. Add a new SETCIRCUITPURPOSE controller command to let you change a circuit's purpose after it's been created. svn:r6075	2006-02-23 06:51:09 +00:00
Roger Dingledine	2bfd2a2400	clean up a log message svn:r6074	2006-02-21 17:54:56 +00:00
Roger Dingledine	25ed4b66e3	be quieter about hidserv descriptors that are too old or too new. we can't do anything about them anyway. svn:r6073	2006-02-21 06:23:57 +00:00
Roger Dingledine	89b07b458b	i missed the other half of that grammar fix svn:r6058	2006-02-21 03:55:47 +00:00
Roger Dingledine	16f265fa0d	when saveconf fails in controller v1, we were returning a malformed error string. svn:r6053	2006-02-20 01:24:26 +00:00
Roger Dingledine	498c13b4df	make the NoPublish option obsolete. svn:r6052	2006-02-20 01:21:48 +00:00
Roger Dingledine	0408adb728	tweak svn:r6051	2006-02-20 01:15:38 +00:00
Roger Dingledine	276a7bd038	the other half of fixing bug 257. catch an error in more places. svn:r6050	2006-02-20 01:06:27 +00:00
Roger Dingledine	57bcdcecf1	try to address bug 257: if rename() fails during saveconf, tell the controller. svn:r6049	2006-02-19 23:12:26 +00:00
Roger Dingledine	6a52867846	New config options to address bug 251: FetchServerDescriptors and FetchHidServDescriptors for whether to fetch server info and hidserv info or let the controller do it, and also PublishServerDescriptor and PublishHidServDescriptors. Add AllDirActionsPrivate undocumented option -- if you set it, you'll need the controller to bootstrap you enough to build your first circuits. svn:r6047	2006-02-19 22:02:02 +00:00
Peter Palfrader	c4f389420c	Improve the "we have been waiting for 1140377851 seconds" log svn:r6046	2006-02-19 19:44:09 +00:00
Roger Dingledine	266254f42b	clean up the Reachable*Addresses changes svn:r6041	2006-02-19 08:31:47 +00:00
Roger Dingledine	a9fcf4ced2	this is why you're not supposed to cut-and-paste code svn:r6037	2006-02-18 06:46:01 +00:00
Peter Palfrader	aa5443551d	Make it compile with VC7. It does not yet link. svn:r6033	2006-02-18 02:02:21 +00:00
Roger Dingledine	42cd0dcde8	fix typo found in phobos's logs svn:r6020	2006-02-15 03:47:38 +00:00
Roger Dingledine	f6d80d60e0	don't warn when we get a server descriptor from the controller but it's too old. that's not something tor should fix. svn:r6019	2006-02-15 03:01:53 +00:00
Peter Palfrader	c7f2970777	Just because both are obsolete does not mean we prefer the newer svn:r6016	2006-02-14 17:48:51 +00:00
Peter Palfrader	0bab094d5d	Explain why we only expire open connections svn:r6015	2006-02-14 17:30:04 +00:00
Roger Dingledine	ae249fc5a3	document the frequency for reachability testing by the directory authorities. svn:r6014	2006-02-14 04:33:59 +00:00
Peter Palfrader	84295f9f43	Do not mark connections obsolete before they have done their TLS handshake or are at least 60 seconds old svn:r6013	2006-02-14 04:23:05 +00:00
Peter Palfrader	761da5b97f	Our connection_or_get_by_identity_digest() was slightly wrong. If best didn't have any circuits on it, but conn had circuits, we would not make conn our new best unless it was also newer. Also, restructure the code a bit to maybe make it clearer. svn:r6012	2006-02-14 00:08:19 +00:00
Peter Palfrader	0cc2390f8c	Warn if ReachableAddresses is set when also ReachableDirAddresses and ReachableORAddresses are set. svn:r6010	2006-02-13 22:29:37 +00:00
Peter Palfrader	5eea6c76df	Split ReachableAddresses into ReachableDirAddresses and ReachableORAddresses svn:r6009	2006-02-13 21:17:20 +00:00
Roger Dingledine	259c65ab08	the last of the log convention conversion. finally. svn:r6005	2006-02-13 10:33:00 +00:00
Roger Dingledine	aa63a84fe1	the things we do for our windows users. i hope they appreciate it. svn:r6004	2006-02-13 09:37:53 +00:00
Roger Dingledine	d113b75da6	more log conversions. whee. svn:r6003	2006-02-13 09:02:35 +00:00
Roger Dingledine	36484f873a	convert some more source files to the new log convention svn:r6002	2006-02-13 08:28:42 +00:00
Roger Dingledine	7d80921afa	resolve too-long-lines svn:r6001	2006-02-13 08:22:57 +00:00
Nick Mathewson	2a4555fedd	Style on config_addr_policy_intersectes, which looks ok to me. svn:r5998	2006-02-13 07:16:32 +00:00
Roger Dingledine	350313d77a	Let the users set ControlListenAddress in the torrc. This can be dangerous, but there are some cases (like a secured LAN) where it makes sense. svn:r5997	2006-02-13 06:25:16 +00:00
Peter Palfrader	6c4d873591	Compress exit policies even more. please review svn:r5995	2006-02-13 01:54:31 +00:00
Nick Mathewson	2cc66125b8	try to fix bug with spurious "everything is broken" warning svn:r5994	2006-02-13 00:26:43 +00:00
Roger Dingledine	b7781ea208	bugfix: we were ignoring the IS_FAST flag in the directory status, meaning we were willing to pick trivial-bandwidth nodes for "fast" connections. svn:r5992	2006-02-13 00:09:30 +00:00
Nick Mathewson	dba155ecff	Generate 18.0.0.0/8 address policy format in descs when we can; warn when the mask is not reducible to a bit-prefix. svn:r5991	2006-02-12 23:58:22 +00:00
Roger Dingledine	b99f903e34	and don't warn when it happens here either, unless the user wants to hear it. svn:r5990	2006-02-12 23:44:02 +00:00
Roger Dingledine	97571a1cb4	don't tell ordinary users about broken directory servers. it's a shame that they're broken, but most people are just confused by the warning. svn:r5988	2006-02-12 23:31:47 +00:00
Nick Mathewson	98ec124c6a	Drop redundant exit policy entries, not just identical ones. svn:r5987	2006-02-12 22:59:38 +00:00
Nick Mathewson	e7b2d5cd47	Retain unrecognized options in state file, so that we can be forward-compatible. svn:r5985	2006-02-12 22:28:30 +00:00
Nick Mathewson	ae4f0467c8	enforce whitespace style svn:r5984	2006-02-12 22:27:09 +00:00
Roger Dingledine	3c4e68488b	Clients now honor the "guard" flag in the router status when picking entry guards, rather than looking at is_fast or is_stable. Now dirservers can change how they define it and clients will automatically use their new definition. svn:r5979	2006-02-12 03:43:39 +00:00
Roger Dingledine	b5ac6fc707	more helpful log message when running servers on obsolete windows. svn:r5975	2006-02-12 00:14:58 +00:00
Roger Dingledine	094ccd34a9	bump up the period for forcing a hidden service descriptor upload from 20 minutes to 1 hour. svn:r5972	2006-02-12 00:12:36 +00:00
Roger Dingledine	981815146a	compress exit policies even more -- look for duplicate lines and remove them. svn:r5971	2006-02-12 00:03:06 +00:00
Roger Dingledine	6c093a17a9	bugfix in config_cmp_addr_policies() -- we were treating a pair of exit policies if they were equal even if one said accept and the other said reject. svn:r5970	2006-02-11 23:47:24 +00:00
Roger Dingledine	fdf18fbbdb	stop leaking that svn:r5969	2006-02-11 23:16:13 +00:00
Roger Dingledine	e847085c04	When a client asks for an old-style directory and our write bucket is empty, don't give it to him. This way small servers can continue to serve the directory sometimes, without getting overloaded. svn:r5968	2006-02-11 23:15:40 +00:00
Nick Mathewson	f1b91924b2	Keep running if we ask for an impossible stdout log; just warn. svn:r5964	2006-02-11 21:56:03 +00:00
Nick Mathewson	1dc90be4f0	Retry pending server downloads as well as pending networkstatus downloads when we unexpectedly get an app connection svn:r5962	2006-02-11 21:29:12 +00:00
Nick Mathewson	91847124bf	Warn if running obsolete windows as a server. svn:r5961	2006-02-11 21:26:40 +00:00
Roger Dingledine	85a64b4fd0	get our grammar right when complaining about un-recommended versions svn:r5950	2006-02-09 06:08:59 +00:00
Roger Dingledine	5f051574d5	Happy new year! svn:r5949	2006-02-09 05:46:49 +00:00
Roger Dingledine	fd0fcdf17c	stop calling it a "libevent poll" -- the word "poll" has other meaning in this context that are confusing. svn:r5936	2006-02-09 03:09:52 +00:00
Roger Dingledine	dbea401305	correct the comments that don't realize it's the opposite svn:r5934	2006-02-09 02:59:26 +00:00
Roger Dingledine	31f2705d9a	and make sure that never happens again svn:r5932	2006-02-09 02:42:33 +00:00
Roger Dingledine	2c221dd8db	fix bug 245: When modifying the orconn_circid_map map, we would sometimes decrement conn->n_circuits even when there was no circuit originally. This caused conn->n_circuits to go negative. We noticed this because we were checking if connections can be closed based on conn->n_circuits == 0, so we were never closing any connection that had ever had a circuit on it. svn:r5931	2006-02-09 02:42:15 +00:00
Roger Dingledine	1c596156aa	tweak comment svn:r5930	2006-02-09 00:08:23 +00:00
Nick Mathewson	e5a574ce2e	Move "sort list of versions" logic into routerparse.c; make version-checking code say which versions it would have accepted. (not tested.) svn:r5927	2006-02-06 05:04:27 +00:00
Nick Mathewson	2bb4fd24de	char *x = "y"; is not good C. svn:r5926	2006-02-06 05:01:44 +00:00
Nick Mathewson	50e1005327	Only v1 authorities get hidden service descriptors with current protocol svn:r5924	2006-02-06 04:56:18 +00:00
Nick Mathewson	97bff8edaa	Fix a const-non-const warning svn:r5923	2006-02-06 04:55:27 +00:00
Roger Dingledine	a9c87fe251	more typos and nits svn:r5918	2006-02-05 05:28:52 +00:00
Nick Mathewson	157e6a025a	Stupid cut-and-paste bug. svn:r5917	2006-02-05 05:11:24 +00:00
Roger Dingledine	555a64e06d	as soon as we've fetched some more directory info, that's time to think about downloading more server descriptors. this way we don't have a 10 second pause in initial bootstrapping. svn:r5916	2006-02-05 03:42:34 +00:00
Roger Dingledine	d602d0d298	cosmetic fix svn:r5915	2006-02-05 03:42:04 +00:00
Roger Dingledine	640882c76c	clean up tabs and wide-lines from weasel's commit svn:r5914	2006-02-05 03:23:16 +00:00
Roger Dingledine	6535087845	when building v2 statuses or v1 running-routers, don't admit the existence of descriptors older than a day. we still cache them in case anybody asks, but we don't actively mention them. svn:r5913	2006-02-05 02:33:40 +00:00
Roger Dingledine	53f86cdf5d	fix bug: we were caching the newest descriptor for each server, well, forever. i imagine this just keeps growing in size. svn:r5912	2006-02-05 02:07:28 +00:00
Roger Dingledine	4c1fa73c7e	typos and nits svn:r5911	2006-02-05 01:57:27 +00:00
Roger Dingledine	a53a73a782	forward-port the part where ordinary users try to fetch directories less often. not critical but might as well stay in sync with stable. svn:r5910	2006-02-05 01:57:07 +00:00
Roger Dingledine	640c555f02	Fix a major load balance bug: we were round-robining in 16 KB chunks, and servers with bandwidthrate of 20 KB, while downloading a 600 KB directory, would starve their other connections. Now we try to be a bit more fair. svn:r5906	2006-02-04 08:58:51 +00:00
Peter Palfrader	94fb3f06b3	Fix compiler warning on 64 bit archs svn:r5903	2006-02-03 22:26:43 +00:00
Peter Palfrader	390bbb0a0c	Try to make tor work better through squid: Limit number of descriptors we fetch to 96 (was 128 previously). We limit this number even when we do not have a http proxy explicitly configured as some people mistakenly believe transparent proxies are a neat idea. svn:r5901	2006-02-03 15:17:48 +00:00
Roger Dingledine	a1dd751f30	when we fail to bind a listener, try to provide a more useful log msg. svn:r5900	2006-02-03 12:26:10 +00:00
Roger Dingledine	1800fbe486	don't warn when we receive a 503 from a dirserver/cache -- this will pave the way for them being able to tell us to screw off if they're busy. svn:r5898	2006-02-03 12:08:31 +00:00
Roger Dingledine	0fadf0aad6	Fix bug 225: now "attachstream 0" treats conn like it just connected, doing address remapping, handling .exit and .onion idioms, and so on. Now we are more uniform in making sure that the controller hears about all new connections, and making sure it hears when they close. svn:r5897	2006-02-03 11:37:19 +00:00
Roger Dingledine	92ef9e37e7	Add a new config option ExitPolicyRejectPrivate which defaults to 1. This means all exit policies will begin with rejecting private addresses, unless the server operator explicitly turns it off. Also, make our code to remove redundancies in the exit policy smarter, so it can detect "reject foo, reject bar, reject *" patterns. Lastly, we can get rid of the "exit policy implicitly accepts" code, since we make everything more explicit now. svn:r5888	2006-02-01 03:53:52 +00:00
Roger Dingledine	bdba6e42dc	avoid a minor confusing log message svn:r5887	2006-02-01 03:05:52 +00:00
Peter Palfrader	bf514e5dc5	Try to fix policy_includes_addr_mask_implicitly() svn:r5886	2006-02-01 02:52:55 +00:00
Peter Palfrader	61ea27620a	Also catch 0/8 in exit_policy_implicitly_allows_local_networks() svn:r5885	2006-02-01 02:31:27 +00:00
Roger Dingledine	686508a04a	don't try to upload hidden service descriptors until we have established a circuit. svn:r5884	2006-02-01 02:19:46 +00:00
Roger Dingledine	e05d4e45d2	provide a more useful warn message when our onion queue gets full. svn:r5881	2006-01-31 08:17:00 +00:00
Roger Dingledine	8fc44169e5	only start testing reachability once we've established a circuit. this will make startup on dirservers less noisy. it may also break things in subtle ways. svn:r5878	2006-01-29 01:11:41 +00:00
Roger Dingledine	f8b9a8d457	bump the default bandwidthrate to 3 MB, and burst to 6 MB svn:r5874	2006-01-28 08:28:15 +00:00
Roger Dingledine	35f91db15f	a slightly more useful message when you get a sighup svn:r5869	2006-01-26 19:11:06 +00:00
Nick Mathewson	bfe285be61	Add a missing printf arg svn:r5861	2006-01-24 04:01:13 +00:00
Roger Dingledine	2eabf190e9	make it louder when we're running an unrecommended version. also, we need to tell them what versions are recommended. i'll add that to the todo. svn:r5859	2006-01-24 03:45:58 +00:00
Nick Mathewson	9f42c9d650	Make dirservers generate a separate "guard" flag to mean, "would make a good entry guard". Make clients parse it and vote on it. svn:r5856	2006-01-24 00:31:16 +00:00
Roger Dingledine	1756ebdd4e	Jan 23 02:39:44.856 [warn] rend_mid_rendezvous(): Rejecting RENDEZVOUS1 cell with unrecognized rendezvous cookie AFC097FD. This is not anything that the server admin can deal with, so don't complain this loudly. svn:r5851	2006-01-23 09:26:22 +00:00
Roger Dingledine	de13ddd26f	Stop complaining loudly whenever some poor client falls off the network before we finish writing to him. svn:r5850	2006-01-23 09:23:04 +00:00
Roger Dingledine	b9540285af	remove unused code svn:r5847	2006-01-20 20:54:42 +00:00
Roger Dingledine	f6084cf831	Jan 18 18:42:05.671 [debug] Encountered eof Jan 18 18:42:05.671 [debug] Got data, not eof. Leaving on inbuf. that's not very smart. svn:r5843	2006-01-19 11:21:28 +00:00
Roger Dingledine	4a66f5a896	when the controller asks for a signal we don't recognize, don't include the whitespace/newline/etc in our complaint. svn:r5841	2006-01-19 02:21:24 +00:00
Roger Dingledine	d682c84e79	attempted patch for bug 220: don't assert when we've tried all the intro points for a hidden service and we try fetching the service descriptor again. svn:r5838	2006-01-17 04:16:59 +00:00
Roger Dingledine	d5acef191c	add another assert to make sure we're not scribbling on the stack. svn:r5837	2006-01-17 04:14:04 +00:00
Roger Dingledine	cca9a2f7b0	oh, and the other bits of the commit svn:r5836	2006-01-17 04:03:23 +00:00
Roger Dingledine	21be9dc3c0	when you tried to set orport through the controller, it would trigger an assert because you hadn't made your onion keys yet you wanted to launch cpu workers. now init keys first, reset uptime, and tell the user that we're starting the reachability testing. svn:r5835	2006-01-17 04:01:32 +00:00
Roger Dingledine	76f1b7415b	try to detect an assert error earlier svn:r5834	2006-01-17 02:31:04 +00:00
Nick Mathewson	1057516a07	Clients should not download descriptors for non-running descriptors. svn:r5830	2006-01-16 20:52:30 +00:00
Roger Dingledine	f0d4b3d18f	turn crypto hardware acceleration off by default, until we find somebody smart who can test it for us. svn:r5829	2006-01-16 20:08:33 +00:00
Nick Mathewson	2dd566d5d5	Indirect access to the signed_descriptor field to make it easier to keep them lazily on disk. svn:r5827	2006-01-12 18:04:17 +00:00
Roger Dingledine	0e51d5d274	When the controller was submitting a descriptor, we were checking to make sure some network-status we had referred to it, and refusing it if not. This is bad for people who want to insert descriptors that aren't part of the current Tor network. Now we accept them, and also give a more useful warn message if we ask a dir mirror for a given descriptor and it gives us one we weren't expecting. svn:r5824	2006-01-12 03:43:39 +00:00
Roger Dingledine	54a7285e99	oh hey. we were hanging up on every tor client because he was obsolete as soon as he started. big oops. svn:r5807	2006-01-11 22:34:07 +00:00
Nick Mathewson	c562ca494a	add missing warning svn:r5806	2006-01-11 20:09:37 +00:00
Nick Mathewson	fefa34d525	Fix double-free of torrc_fname svn:r5805	2006-01-11 20:01:47 +00:00
Nick Mathewson	adbe0f0ada	Fix bug 240: dont dump descriptions when not dumping actual config lines. svn:r5804	2006-01-11 19:43:14 +00:00
Nick Mathewson	099b9ce2f9	Fix bug 230: add a rollback function to reverse all changes since the last mark_logs_temp(), and move log initialization into the two-phase part of option setting. svn:r5803	2006-01-11 19:40:14 +00:00
Roger Dingledine	5ca40affeb	we were leaking a smartlist every time we built a circuit svn:r5795	2006-01-11 04:14:10 +00:00
Nick Mathewson	d60faa7c93	Fix another memleak. I love you, valgrind! svn:r5794	2006-01-11 04:09:40 +00:00
Nick Mathewson	8907391ad6	Fix wide lines svn:r5793	2006-01-11 04:04:42 +00:00
Nick Mathewson	5c78c89471	Appease verbose gcc warning: make dirserv_compute_stable_uptime() static. svn:r5792	2006-01-11 03:59:55 +00:00
Roger Dingledine	284fe9cad5	if we learn that a down entry guard is up, count our working entry guards correctly when logging. svn:r5791	2006-01-11 03:58:59 +00:00
Nick Mathewson	eb78295e4e	Fix memory leak in routerlist_remove_old_routers(). svn:r5790	2006-01-11 03:58:07 +00:00
Nick Mathewson	6a9ca9e790	Convert some more ints to long longs in rephist.c, as suggested by windows compiler. svn:r5789	2006-01-11 03:57:01 +00:00
Roger Dingledine	d1baa0c4a6	we were leaking 3KB every time the entry guards changed, every time the controller called saveconf, and every 20 minutes. svn:r5788	2006-01-11 03:20:53 +00:00
Roger Dingledine	8f271f2f5a	we changed the name of AccountingBytesReadInInterval change its state file description too svn:r5785	2006-01-10 23:26:59 +00:00
Roger Dingledine	7d1f675c85	entry nodes are now entry guards. this is our last easy chance for a wholesale change. heave ho. svn:r5782	2006-01-10 22:42:44 +00:00
Roger Dingledine	210d9db54d	and even more so svn:r5776	2006-01-10 21:01:30 +00:00
Roger Dingledine	aea0a78254	make entry node logging slightly less chatty. still quite chatty. it's an alpha, that's ok. svn:r5775	2006-01-10 20:59:39 +00:00
Nick Mathewson	bef879540a	#undef FOO is cleaner than #define FOO_XX svn:r5774	2006-01-10 20:50:22 +00:00
Nick Mathewson	4a7ee9bd3d	Make unittests pass again. svn:r5773	2006-01-10 20:47:24 +00:00
Roger Dingledine	b2d79f278b	or_state_validate() needs an extra arg too or it will crash svn:r5772	2006-01-10 20:38:33 +00:00
Roger Dingledine	f4299f0f44	hack to address bug 238. needs a better fix, but not for 0.1.1.11. svn:r5771	2006-01-10 20:27:47 +00:00
Roger Dingledine	d114ea7125	implement getinfo desc/all-recent closes bug 237. svn:r5770	2006-01-10 20:09:31 +00:00
Roger Dingledine	f71273c216	fix bug 235 svn:r5768	2006-01-10 20:06:24 +00:00
Nick Mathewson	7fc62029d4	Refuse to use RunAsDaemon when torrc is a relative path. Fixes bug 229. svn:r5767	2006-01-10 20:00:20 +00:00
Nick Mathewson	e1d1ce3da8	Warn about actual offending hiddenservice* config option, now that more than one is possible. Closes bug 239. svn:r5766	2006-01-10 19:28:31 +00:00
Nick Mathewson	2fda7140e8	Fix bug 221 and bug 201: For 221, check return value from connection_add() when adding a rendezvous post connection. For 201, do not include a content-length 0 with a GET request. svn:r5765	2006-01-10 19:24:40 +00:00
Roger Dingledine	c8e6003412	balance the reachability testing so a smidgen of it happens every 10 seconds. this way we don't try to do 500 tls's at once every 20 minutes. svn:r5763	2006-01-10 07:21:01 +00:00
Nick Mathewson	43a4f8c7f3	Be more aggressive about throwing away expired router descriptors: they are of no use to anybody. Better still: dont serve expired descriptors by fingerprint. The only people who ask for them are busted 0.1.1.10 Tors that will throw them away and re-request them after 30 minutes. svn:r5762	2006-01-10 04:57:12 +00:00
Nick Mathewson	56c55c343e	When picking a random directory, prefer non-authorities if any are known. svn:r5761	2006-01-09 23:39:07 +00:00
Nick Mathewson	bec9b705cc	Instrument directory client bytes as well as server bytes. svn:r5760	2006-01-09 23:13:53 +00:00
Nick Mathewson	10100c4315	Make instrmentation code a little cleaner. svn:r5759	2006-01-08 22:19:41 +00:00
Roger Dingledine	fa05c1b21b	remove the loud logging of busted rendezvous descriptors svn:r5758	2006-01-08 22:16:30 +00:00
Roger Dingledine	6dcbbda43b	remove typo svn:r5757	2006-01-08 22:16:09 +00:00
Nick Mathewson	ff9cfa9644	Instrument how many directory bytes we are serving in what kind of request. svn:r5756	2006-01-08 22:09:54 +00:00
Nick Mathewson	5d709e8517	Fix bug in last commit. Also, fix bug 231: authorities should never treat their own descriptor changes as cosmetic. svn:r5755	2006-01-08 21:33:15 +00:00
Nick Mathewson	e30516f33f	Fix bug 236: caches should cache up to 16 unrecognized network-status docs. svn:r5754	2006-01-08 21:26:33 +00:00
Roger Dingledine	1dd8ebf615	bugfix: we were leaving open duplicate connections to other ORs for a week, rather than closing them once we detect a duplicate. also, avoid some duplicate mark-for-closes in connection-housekeeping. svn:r5752	2006-01-07 03:56:56 +00:00
Roger Dingledine	9796733e89	"Pending" is a bad term for a circuit that uses your server as its last hop. svn:r5751	2006-01-07 02:31:14 +00:00
Roger Dingledine	d4d7a49411	fix typo svn:r5750	2006-01-07 02:12:38 +00:00
Roger Dingledine	af54b73985	and get the log arguments right svn:r5747	2006-01-07 01:43:09 +00:00
Roger Dingledine	ba339b8a4d	a more correct log message svn:r5746	2006-01-07 01:41:17 +00:00
Roger Dingledine	654b61a2e8	Jan 05 19:39:27.356 [warn] connection_edge_process_end_not_open(): Got an end because of misc error, but we're not an AP. Closing. svn:r5744	2006-01-07 01:02:21 +00:00
Roger Dingledine	f88fa3efc1	helper nodes are dead svn:r5743	2006-01-07 00:41:50 +00:00
Nick Mathewson	50b6b3258d	Dont call directory_get_from_dirserver when you have a particular dirserver in mind; remove fetch-from-authority special-case in directory_get_from_dirserver. svn:r5741	2006-01-06 18:19:17 +00:00
Nick Mathewson	f0fb9f6b0c	Directory authorities should go to the proper authority when asking for a networkstatus, even when they want a compressed one. (Also, bullet-proof the logic in case we ever accidentally request a networkstatus for a non-authority.) svn:r5740	2006-01-06 18:05:48 +00:00
Nick Mathewson	65f76bad4f	Add descriptions for state variables; rename AccountingBytesRead{In}Interval; remove extraneous and unused struct member. svn:r5739	2006-01-06 15:43:03 +00:00
Nick Mathewson	447e6ffffd	Fix bug where OPs would try to generate descriptor and crash. svn:r5738	2006-01-06 15:40:34 +00:00
Nick Mathewson	878962bee1	Add reasons to DESTROY and RELAY_TRUNCATED cells. svn:r5734	2006-01-05 21:23:03 +00:00
Roger Dingledine	d8e3bc0288	fix a wrong string svn:r5733	2006-01-05 12:18:34 +00:00
Roger Dingledine	6aaa92f736	short-circuit half the cost of node-picking in the general case. svn:r5732	2006-01-05 10:59:46 +00:00
Roger Dingledine	f8a59965a1	cleanups, and remove some unreachable code. svn:r5727	2006-01-04 06:43:03 +00:00
Roger Dingledine	485aa9415d	authdirs now stop whining so loudly about bad descriptors that they fetch from other dirservers. now when there's a log complaint, it's for sure from a freshly uploaded descriptor. svn:r5726	2006-01-04 04:42:10 +00:00
Roger Dingledine	6b2a6a8239	Bugfix: dyndns tor servers were needing to wait 18 hours before they could start doing reachability testing using the new IP address and ports. This is because we were using the internal descriptor to learn what to test, yet we were only rebuilding the descriptor once we decided we were reachable. svn:r5723	2006-01-03 23:34:42 +00:00
Roger Dingledine	f6f65c66b5	oh, it was supposed to compile? svn:r5721	2006-01-03 13:12:17 +00:00
Roger Dingledine	da06f3553c	don't try to build circuits until we have 3 running servers; and for networks that are very small, having more than a quarter of the descriptors is much harder than having equal to or more than a quarter of the descriptors -- follow the spec. svn:r5720	2006-01-03 13:09:49 +00:00
Roger Dingledine	5d28b7b884	we're done with tree.h. long live ht.h. svn:r5715	2006-01-03 12:35:58 +00:00
Roger Dingledine	9af33ef39c	when we choose not to use a server descriptor from our cache, don't log it so loudly. svn:r5713	2006-01-03 10:42:20 +00:00
Roger Dingledine	16ee6830b6	only print bandwidth lines to the state file if we're being a server. otherwise this is pointless and probably bad for security. svn:r5704	2006-01-02 12:19:28 +00:00
Roger Dingledine	1d474e14d7	strictentrynodes means we should clear the current entry_nodes list. svn:r5703	2006-01-02 11:33:14 +00:00
Roger Dingledine	c5a5161fb5	prevent auth dir servers from enabling entry nodes. svn:r5702	2006-01-02 08:40:58 +00:00
Roger Dingledine	358052416d	bugfix: only try to use the EntryNodes config option if it is set. svn:r5701	2006-01-02 05:14:21 +00:00
Roger Dingledine	ddf070e204	bugfix: we were failing to parse a tor version that started with "Tor ", even though we said we could. svn:r5699	2006-01-02 05:11:31 +00:00
Roger Dingledine	ea6ea8ec22	Make UseEntryNodes true by default. Let the fun begin. svn:r5698	2006-01-02 05:00:03 +00:00
Roger Dingledine	aa604ef2c2	bugfix: only try to parse the TorVersion if there is one. svn:r5697	2006-01-02 04:58:12 +00:00
Roger Dingledine	839111b85a	tolerate a mal-formed or unrecognized tor version in the state file. svn:r5696	2006-01-02 04:45:18 +00:00
Roger Dingledine	0bd25f5d43	save and validate TorVersion in the state file. svn:r5694	2006-01-02 04:14:52 +00:00
Roger Dingledine	2efa056777	make the "stable" flag in network-status be the median of the uptimes of running valid servers. that way the cutoff adapts to the stability of the network as a whole. svn:r5693	2006-01-02 03:32:55 +00:00
Nick Mathewson	4868d77ab8	Possible fix to state-load bug reported by weasel. svn:r5692	2006-01-02 00:42:19 +00:00
Peter Palfrader	3dc69d3add	Make tor compile again svn:r5688	2005-12-31 11:52:13 +00:00
Roger Dingledine	6c693dbda6	add a TorVersion state string. not yet set to anything. svn:r5687	2005-12-31 08:16:07 +00:00
Roger Dingledine	e9e7dc176c	Some tor servers process billions of cells in a matter of days. These statistics need to be uint64_t's. svn:r5686	2005-12-31 08:09:26 +00:00
Roger Dingledine	1a11b97b15	get rid of the special case for 'testing' circuits svn:r5684	2005-12-31 06:37:34 +00:00
Roger Dingledine	5947388968	Finish implementing config's EntryNodes and StrictEntryNodes option. The logging is way verbose for now. svn:r5683	2005-12-31 06:32:57 +00:00
Roger Dingledine	0dc8e284f8	load balance a bit better by taking some load off the really fast servers. this might slow things down more, or it might not. hm. svn:r5681	2005-12-30 04:46:43 +00:00
Roger Dingledine	c051e82f69	fix a typo svn:r5680	2005-12-30 04:44:10 +00:00
Nick Mathewson	fc850273bd	Appease some verbose GCC warnings. svn:r5679	2005-12-29 20:25:53 +00:00
Roger Dingledine	2904c6f024	log how big the failed rend descriptor is, and if it's small, log a base16 of the whole thing. svn:r5678	2005-12-29 04:57:19 +00:00
Roger Dingledine	14ea2e0b56	when we reject a rend descriptor, tell us where it came from. svn:r5677	2005-12-29 04:43:24 +00:00
Roger Dingledine	dbd7b97eff	helper nodes are dead. long live entry nodes. (config options EntryNodes and StrictEntryNodes still not implemented.) svn:r5673	2005-12-28 09:07:31 +00:00
Roger Dingledine	5d9256a367	but only close the new conn if one of the earlier helper nodes that we mark up is actually reachable, fast enough, etc to use. svn:r5672	2005-12-28 07:27:41 +00:00
Roger Dingledine	c1145138ea	but only close it if we have marked an earlier helper as up. that way we don't close it too needlessly. svn:r5671	2005-12-28 07:20:33 +00:00
Roger Dingledine	60cd03069a	when we connect to a helper node for the first time, close that connection and its circuits. this lets us go back to using the old helper nodes rather than immediately using the last one in the list. svn:r5670	2005-12-28 07:19:55 +00:00
Roger Dingledine	bbc4c8cef8	fix a spacing problem introduced by our 80-column requirement svn:r5669	2005-12-27 10:11:29 +00:00
Roger Dingledine	d2171cb7a4	if the network is down, and we try to connect to a conn because we have a circuit in mind, and we timeout (30 seconds) because the network never answers, we were expiring the circuit, but we weren't obsoleting the connection or telling the helper functions. now do that. svn:r5668	2005-12-27 09:25:50 +00:00
Roger Dingledine	4088f7dfd1	fix typo svn:r5667	2005-12-27 09:04:36 +00:00
Roger Dingledine	f46c135fac	when we succeed at connecting to a helper that we've never connected to before, mark all the previous helpers as up. This is handy if the network went away and then returned. svn:r5666	2005-12-27 08:54:37 +00:00
Roger Dingledine	25fcb5fa9c	helpful log svn:r5665	2005-12-27 08:38:22 +00:00
Roger Dingledine	976bf06463	slightly more accurate log messages svn:r5664	2005-12-27 07:37:21 +00:00
Roger Dingledine	25052c6f4b	first cut of the new helper stuff. seems to work in the normal case, but many edge cases still need testing. svn:r5663	2005-12-27 07:23:52 +00:00
Nick Mathewson	9ef54a3d0c	Make directory caches a little less chatty when logging svn:r5662	2005-12-27 06:05:54 +00:00
Nick Mathewson	fa0d5aa894	Make insert_old try hard to never add a duplicate. svn:r5661	2005-12-27 05:58:12 +00:00
Nick Mathewson	ece9865020	Implement new directory logic: download by descriptor digest, not by key digest. Caches try to download all listed digests from authorities; clients try to download "best" digests from caches. svn:r5659	2005-12-27 05:26:03 +00:00
Nick Mathewson	d94b9fd7d2	normalize spaces svn:r5658	2005-12-27 04:52:34 +00:00
Roger Dingledine	94bff33357	and compiling would be good too svn:r5657	2005-12-27 02:48:35 +00:00
Roger Dingledine	370dcbc7ba	and some comments svn:r5656	2005-12-27 02:48:02 +00:00
Roger Dingledine	5807bd0635	make it clearer in the auto-generated config file that you probably shouldn't be editing this one yourself. svn:r5655	2005-12-27 02:46:53 +00:00
Roger Dingledine	b038dc9ecc	disambiguate some debug entries svn:r5654	2005-12-26 22:42:22 +00:00
Roger Dingledine	815df977cf	comments? i'll show you comments. svn:r5652	2005-12-26 05:52:44 +00:00
Roger Dingledine	40c267a89f	prevent a rare infinite loop on two-byte architectures, and be more thorough and starting over when the clock jumps. svn:r5647	2005-12-25 04:37:33 +00:00
Roger Dingledine	7e0d62b14a	stop being sneaky, especially if we're being incorrectly sneaky svn:r5646	2005-12-24 23:39:20 +00:00
Roger Dingledine	b0144276db	more comments, and start to use the made_contact entry. svn:r5645	2005-12-24 23:32:35 +00:00
Roger Dingledine	7cc53c2281	clean up some comments svn:r5644	2005-12-24 23:32:15 +00:00
Roger Dingledine	35986a2374	simplify because we weren't using those return values anyway svn:r5643	2005-12-24 22:48:12 +00:00
Roger Dingledine	3a2ce447b4	start to document the helper node functions svn:r5642	2005-12-24 20:07:19 +00:00
Peter Palfrader	4bd65f0f98	Keep bandwidth history accross restarts/crashes svn:r5637	2005-12-23 23:56:42 +00:00
Roger Dingledine	eecb835527	stop shipping tree.h, since we don't use anymore. (woo.) svn:r5628	2005-12-20 07:17:42 +00:00
Roger Dingledine	bb4662365b	when we fail three times to resolve or connect, we were telling the user it was because we failed to resolve. svn:r5620	2005-12-19 21:56:43 +00:00
Roger Dingledine	da01657c34	more asserts in case weasel can trigger them svn:r5616	2005-12-19 00:35:18 +00:00
Roger Dingledine	7cd46d7f95	fix a seg fault when you finish connecting to a server but at that moment you dump his server descriptor, and you also happen to be logging at loglevel info. (found by weasel) svn:r5615	2005-12-18 22:59:47 +00:00
Roger Dingledine	34249e8861	fix segfault when specifying DirServer without nickname (reported by weasel) svn:r5614	2005-12-18 22:45:27 +00:00
Roger Dingledine	a2186b9999	fix a ! that got left out svn:r5612	2005-12-18 22:34:24 +00:00
Nick Mathewson	6b5fc9d46f	Instead of "Network down", say "Is your network connection down?" svn:r5607	2005-12-15 22:10:03 +00:00
Roger Dingledine	a6afef700a	nother typo svn:r5605	2005-12-15 21:51:12 +00:00
Roger Dingledine	edde3fcf25	ah ha, that variable was static. not useless after all. svn:r5604	2005-12-15 21:44:23 +00:00
Roger Dingledine	002c9b3589	clean up a lot message, and remove a line that does nothing. svn:r5603	2005-12-15 21:41:27 +00:00
Nick Mathewson	89eded7b17	Add "panic" option to reject all servers not in fingerprint list. svn:r5601	2005-12-15 21:39:38 +00:00
Nick Mathewson	cf8c70b79c	fix compile svn:r5600	2005-12-15 21:38:59 +00:00
Nick Mathewson	280c62314e	Make clients look at the fast and stable flags in networkstatus, not at the bandwidth and uptime declared in the router descriptors. svn:r5599	2005-12-15 21:30:57 +00:00
Roger Dingledine	3489066433	put back in a todo comment, so we don't forget. svn:r5598	2005-12-15 21:26:52 +00:00
Roger Dingledine	dadcb19d17	fix typo svn:r5597	2005-12-15 21:26:39 +00:00
Nick Mathewson	24e79df0b6	Whitespace fixes; comments. svn:r5596	2005-12-15 21:17:40 +00:00
Nick Mathewson	713c995adb	Do not mark directories as down simply because they dont have the router descs we want. svn:r5595	2005-12-15 21:15:16 +00:00
Nick Mathewson	5965b3849e	Remove some redundant and obsolete code from routerparse svn:r5594	2005-12-15 20:58:51 +00:00
Nick Mathewson	6b1305aeeb	Flip a misplaced not svn:r5593	2005-12-15 20:56:46 +00:00
Nick Mathewson	3ea32f51cb	add a few clarifying comments svn:r5592	2005-12-15 20:49:01 +00:00
Nick Mathewson	ce71b17224	Clean fake_status a bit. Switch from has_fetched_directory to have_minimum_dir_info, and make the latter function smarter. svn:r5591	2005-12-15 20:44:15 +00:00
Roger Dingledine	25e1ad02fa	implement weasel's suggestion to fix the bug that newly bootstrapped tor networks couldn't do hidden services until they had nodes with high uptime: if you're trying to pick a node for your circuit and you demand uptime or capacity and nothing works, then abandon your need for uptime and capacity. svn:r5589	2005-12-15 09:53:00 +00:00
Nick Mathewson	7af95e5c06	When we mark a router as down, also mark its local_routerstatus as not running. This way, we do not use directories that are believed to be down. svn:r5587	2005-12-14 22:05:10 +00:00
Nick Mathewson	9482b1b9d5	Choose directory servers from routerstatus list, not from routerinfo list. This way, as soon was we have a networkstatus, we can ask a cache to give us routers, rather than needing to ask the directories. svn:r5586	2005-12-14 22:00:58 +00:00
Nick Mathewson	c02c6b5823	Shave off 8 bytes per connection and 4 bytes per circuit by paying attention to padding warnings, moving fields around, and acknowledging that we have no files with over 64 kilolines. svn:r5583	2005-12-14 21:03:51 +00:00
Nick Mathewson	1af630d32c	Bite the bullet and limit all our source lines to 80 characters, the way IBM intended. svn:r5582	2005-12-14 20:40:40 +00:00
Nick Mathewson	7e632a7564	another possible patch related to circuit_free and memory stomping. svn:r5580	2005-12-14 18:55:17 +00:00
Nick Mathewson	4f38670328	Fix a potential memory stomp on servers running hidden services. Found by weasel with valgrind. Backport candidate. svn:r5579	2005-12-14 02:19:27 +00:00
Roger Dingledine	86d69218ef	orconn_identity_map was another static variable that started out NULL and didn't change until it needed to change. svn:r5578	2005-12-14 01:02:35 +00:00
Roger Dingledine	c9f6e6b0a0	sometimes, when we just started tor, we haven't created that smartlist yet. so don't free it. svn:r5577	2005-12-14 00:52:15 +00:00
Roger Dingledine	d853c9a009	bugfix: when we removed a dead helper node, we never committed that change to disk. svn:r5576	2005-12-13 02:52:38 +00:00
Roger Dingledine	ea760fa149	extendcircuit and attachstream would complain about not enough arguments, but then just keep on going anyway. svn:r5575	2005-12-12 16:50:55 +00:00
Nick Mathewson	27a201ac80	Have dirctory authorites note which servers make good V2 directory caches in publishe network-status. svn:r5574	2005-12-12 01:03:28 +00:00
Nick Mathewson	32126cced1	Make directory authorities ignore router uploads that have only cosmetic differences: now regardless of version! svn:r5573	2005-12-12 01:02:08 +00:00
Roger Dingledine	bf4da967c1	Don't use helper nodes for circuits with purpose 'testing'. Also, when picking the helper node for a given circuit, exclude the circuit's exit from your choices. svn:r5569	2005-12-11 12:14:26 +00:00
Roger Dingledine	a131783c8b	when removing dead helpers, only write or_state to disk once at the end, not for every helper you remove. svn:r5568	2005-12-11 11:56:17 +00:00
Roger Dingledine	5981169440	mark the helper node as down if we time-out on the circuit handshake with him. svn:r5567	2005-12-11 11:55:41 +00:00
Roger Dingledine	dded1dd8bd	don't mark the helper node as down when we fail to connect to our https proxy. svn:r5566	2005-12-11 11:54:55 +00:00
Roger Dingledine	9c01fa3d59	fix yet another time comparison bug. we were abandoning helpers as soon as they became unavailable. (is this true?) svn:r5565	2005-12-11 11:23:36 +00:00
Roger Dingledine	f3349d6ed3	fix an error in reporting why we abandoned a helper node svn:r5564	2005-12-11 11:20:26 +00:00
Roger Dingledine	b974f67c01	choose helper nodes to have high capacity always svn:r5563	2005-12-11 11:20:01 +00:00
Roger Dingledine	77c0f6d456	a first go at fixing a bug matt edman reported: when he tries to "setconf log" via the controller, it is friendly and gives him a log to stdout, even though he didn't ask for one. svn:r5562	2005-12-11 10:01:21 +00:00
Roger Dingledine	79f09b2f17	setconf orport=9001 513 Unrecognized option value it's not unrecognized. it's unacceptable. (in this case, i still have to consult the logs to figure out why, but at least i have an inkling that maybe i should.) svn:r5561	2005-12-11 09:33:38 +00:00
Roger Dingledine	46d563fe00	whenever we hupped or did a controller setconf, we were prepending another reachableaddresses :80,:443 if fascistfirewall was set, and we were appending another reject : regardless. svn:r5560	2005-12-11 09:18:25 +00:00
Roger Dingledine	a4e1014f4d	i think fascistfirewall still has its uses. it's a synonym for a certain reachableaddresses line, but it's easier to remember and people already understand it. i think we should think about undeprecating it. svn:r5559	2005-12-11 08:59:02 +00:00
Roger Dingledine	defa3804cf	explain why 0.1.1.9-alpha-cvs is a special version. svn:r5552	2005-12-10 21:07:21 +00:00
Roger Dingledine	58366ffd24	when we changed from log_fn to debug/info/notice/warn/err, we screwed up the formatting in wild and unpredictable ways. fix it before it becomes convention to format logs in wild and unpredictable ways. still need to do src/common/ someday. svn:r5551	2005-12-10 09:36:26 +00:00
Roger Dingledine	9b0a40ec78	crank the max line limit down to 150 chars. svn:r5550	2005-12-10 08:27:01 +00:00
Nick Mathewson	39265dd72e	In my private little universe, terminals are still 80 columns. Impose a 160-character-per-line limit; this will creep down. svn:r5548	2005-12-09 05:37:26 +00:00
Nick Mathewson	95e471c9a6	Normalize whitespace svn:r5547	2005-12-09 05:22:15 +00:00
Nick Mathewson	33c4445846	For some bizarre reason, MSVC does not implement GCC extensions. Who would have thought? svn:r5546	2005-12-09 05:20:02 +00:00
Roger Dingledine	a438f2abcd	let the user configure a sockslistenaddress on other private IPs besides 127.x.y.z without complaining. and give a better message in the log. svn:r5544	2005-12-09 02:46:46 +00:00
Nick Mathewson	d57029ffe8	Make code to handle "private" alias work when assume_action is set. svn:r5542	2005-12-08 23:58:23 +00:00
Roger Dingledine	8730190914	when we're checking reachability, make it clearer in the logs what to expect. svn:r5538	2005-12-08 21:12:47 +00:00
Roger Dingledine	d3dcea08af	remove a redundant memcpy when extending to a new server and attaching circuits to it. svn:r5537	2005-12-08 20:33:57 +00:00
Nick Mathewson	338f23114f	Oops. 0.0.0.0/8 and 169.254.0.0/16 are also special. svn:r5536	2005-12-08 19:58:14 +00:00
Nick Mathewson	2d585941b8	Release memory from conn_circid_circuit_map on exit. svn:r5535	2005-12-08 19:46:22 +00:00
Nick Mathewson	1b770817c0	Add private:* as an alias in configuration for policies. svn:r5534	2005-12-08 19:40:24 +00:00
Nick Mathewson	898968b3ac	Warn when binding to a public address for socks. This warning needs to be improved. Also, make options_validate() only warn when an option is changed to a bad value.. (Previously, it warned when an option was bad and any option was changed.) svn:r5532	2005-12-08 18:56:32 +00:00
Nick Mathewson	e9b66ec906	Document CREATE_FAST better in the code. Move our key expansion algorithm into a separate function in crypto.c svn:r5530	2005-12-08 17:38:32 +00:00
Nick Mathewson	617f71e4ba	Whitespace normalization svn:r5528	2005-12-08 04:03:12 +00:00
Nick Mathewson	f031ee8246	Make clients use CREATE_FAST cells. add an option to disable this. svn:r5524	2005-12-07 22:09:02 +00:00
Roger Dingledine	4902ece698	what the heck is wrong with this little piece of code? why can none of us get it right? it looks so simple. svn:r5521	2005-12-07 04:43:39 +00:00
Roger Dingledine	b0ffa34219	tell the controller about new .onion streams too. svn:r5520	2005-12-06 23:43:52 +00:00
Roger Dingledine	5c0338dca3	the other half of weasel's patch, so old gcc's can build cvs again. svn:r5517	2005-12-06 21:03:48 +00:00
Peter Palfrader	0dbb622f26	Old gccs want you to do your variable declarations first svn:r5516	2005-12-06 17:01:36 +00:00
Roger Dingledine	3347762fa4	when we're giving up on a circuit and retrying on a new one, log the name of the exit node. perhaps people will find this useful, or see patterns, or something. svn:r5515	2005-12-06 07:21:17 +00:00
Nick Mathewson	b1d034d2ab	Fix bug 212: Directory authorities should not try to download server descriptors that they know they will reject. svn:r5514	2005-12-06 06:55:43 +00:00
Nick Mathewson	d2123388ad	Better fix for last bug: avoids trying to double-mark circuits. svn:r5511	2005-12-05 19:45:54 +00:00
Nick Mathewson	fedc9c8a60	We were neglecting to unlink marked circuits from soon-to-close OR connections. svn:r5510	2005-12-05 19:26:09 +00:00
Nick Mathewson	b03e8733f3	Change how OR conns get removed from the identity map; fix some warnings on shutdown. svn:r5509	2005-12-05 19:15:27 +00:00
Nick Mathewson	f0abb1a74b	Check magic when removing old connection from map. svn:r5508	2005-12-05 19:01:34 +00:00
Nick Mathewson	835f06a77c	Set chosen_exit_name to something we are not about to zero. svn:r5507	2005-12-05 06:16:24 +00:00
Nick Mathewson	98290e4115	When parsing foo.exit, if foo is unknown, and we are leaving circuits unattached, set the chosen_exit field and leave the address empty svn:r5504	2005-12-05 04:38:21 +00:00
Roger Dingledine	26b49dbc09	Bugfix for trackhostexits: write down the fingerprint of the chosen exit, not its nickname, because the chosen exit might not be verified. svn:r5499	2005-12-05 00:15:42 +00:00
Roger Dingledine	40cbe550f3	fix a log message to be mildly more helpful svn:r5498	2005-12-04 23:06:48 +00:00
Roger Dingledine	bb8dc691eb	Fix another time comparison bug in circuit_stream_is_being_handled(). Nick, can you confirm this one? This is also a backport candidate. svn:r5497	2005-12-04 22:23:24 +00:00
Roger Dingledine	ef000fd82e	ok, i know this one was a bug. we were expiring open general circuits after they had been around for 30 seconds. svn:r5496	2005-12-04 22:19:04 +00:00
Roger Dingledine	7d032bd300	take back half of my bugfix. comparing times sucks. but leave the other half. svn:r5495	2005-12-04 21:59:15 +00:00
Roger Dingledine	d60f514f4c	fix the first bug with our optimization to circuit_expire_building(): we were killing off rendezvous circuits unless they magically time-warped to be too old before we got around to killing them, in which case we would leave them alone. this made it hard to rendezvous with hidden services. svn:r5494	2005-12-04 21:51:50 +00:00
Nick Mathewson	1b0134dda8	Clean up some comments; remove some dead code svn:r5493	2005-12-03 16:32:29 +00:00
Nick Mathewson	61c5a9ae2b	Use a switch statement and some mild refactoring to try to speed up circuit_expire_building svn:r5492	2005-12-03 05:29:05 +00:00
Nick Mathewson	979fc3e69d	cvs diff -u src/or/circuitlist.c \| less almost never does what you want in C. svn:r5491	2005-12-03 03:36:32 +00:00
Nick Mathewson	77a494dd55	Expunge remaining places where we used "tree" to mean "associative array". svn:r5490	2005-12-03 02:21:31 +00:00
Nick Mathewson	148a1e969d	Shave off another 4.7%: remove a linear search when figuring out which circuits wanted us to open a given OR connection. svn:r5489	2005-12-03 02:12:37 +00:00
Nick Mathewson	502cb59611	Remove "tree" references from dns. svn:r5488	2005-12-03 02:01:18 +00:00
Nick Mathewson	6443e5ec7f	Add a benchmark-aes function to test.c. Off by default. svn:r5485	2005-12-01 04:35:58 +00:00
Nick Mathewson	fea19528a1	assert_buf_ok was showing up in the profile; remove it from critical-path functions, since it hasnt triggered for ages. svn:r5479	2005-11-30 22:48:58 +00:00
Nick Mathewson	d56a65c497	Fix some verbose warnings and remove an unneeded include. svn:r5472	2005-11-30 06:38:41 +00:00
Nick Mathewson	9cec3a13f5	remove some functions that are not used; #if0 out some files that are not likely to be used. svn:r5471	2005-11-30 06:27:59 +00:00
Nick Mathewson	a6eb8cd2a0	Move connection_or_remove_from_identity_map() to connection_unlink, but dont remove the other; just make it warn. svn:r5470	2005-11-30 04:28:41 +00:00
Nick Mathewson	3bd613b44d	Rename connection_get_by_identity_digest to reflect that it is OR-only. Make it use a hashtable instead of a linear search. svn:r5469	2005-11-30 03:01:16 +00:00
Nick Mathewson	447a3a7ff2	Funny. I could have sworn that it compiled. svn:r5467	2005-11-29 17:17:02 +00:00
Nick Mathewson	94e8dcef44	Fix a bug weasel found: when we are an authority and somebody requests "all" statuses, cconsider regenerating our own. svn:r5466	2005-11-29 17:14:10 +00:00
Nick Mathewson	c90d6c7e5f	Make arguments to circuit_set_circid_orconn match the connection that is closing in circuit_about_to_close_connection. This accounts for our mysterious "arbitrary ram gets decremented!" bug. svn:r5465	2005-11-29 17:13:34 +00:00
Nick Mathewson	7de0c33857	Avoid a segfault in routerlist_reset_warnings() svn:r5464	2005-11-28 16:29:27 +00:00
Roger Dingledine	1da454a42d	when returning a list of circuits, don't return a list of the same conn over and over. that's really bad for memory. svn:r5463	2005-11-28 02:52:17 +00:00
Roger Dingledine	f94f4c1686	when event_add or event_del fail, tell us why. (nick, do i have my libevent strerror dance moves correct?) svn:r5462	2005-11-26 09:37:00 +00:00
Roger Dingledine	97f748f680	clean up broken comment svn:r5461	2005-11-26 09:27:36 +00:00
Nick Mathewson	652e1899ac	"How about 'never'? Does 'never' work for you?" Weasel says circuit_get_by_conn is his main timesink. Most of its users were just checking whether OR conns had circuits, so add a circuit count to OR conns, and check that. One was circuit_about_to_close_conn, which was doing an O(n^2) series of calls to get all circs on an OR conn, so make an O(n) function for that. Finally, circuit_get_by_edge_conn was using it as a sanity test that has been around for a while but never found any actualy insanity, so kill that. circuit_get_by_conn is finally dead, which is good, since it was never sane to begin with. svn:r5460	2005-11-26 01:43:57 +00:00
Nick Mathewson	31d5d96739	Cut down a common call to circuit_get_by_conn by about half. svn:r5459	2005-11-26 00:53:51 +00:00
Roger Dingledine	fe221f3dff	Start the process of treating internal circuits and exit circuits separately. It's important to keep them separate because internal circuits have their last hops picked like middle hops, rather than like exit hops. So exiting on them will break the user's expectations. - Stop cannibalizing internal circuits for general exits, and stop cannibalizing exit circuits for rendezvous stuff. - Don't let new exit streams attach to internal circuits. - When deciding if we have enough circuits for internal and for exit, don't count the wrong ones. - Treat predicted resolves as predicted port 80 exits. svn:r5457	2005-11-25 08:08:56 +00:00
Roger Dingledine	6452aecedb	when calling connection_get_by_identity_digest, don't do a memcmp for non-OR conns. this should save a bit of time. svn:r5456	2005-11-25 06:43:53 +00:00
Roger Dingledine	2350e487a2	minor cleanup svn:r5454	2005-11-24 06:44:13 +00:00
Roger Dingledine	ea7fe0c267	Fix a bug found by Lasse Overlier: when we were making internal circuits (intended to be cannibalized later for rendezvous and introduction circuits), we were picking them so that they had useful exit nodes. There was no need for this, and it actually aids some statistical attacks. svn:r5453	2005-11-24 06:43:39 +00:00
Roger Dingledine	5b583073a1	remove some more dead code (found while hunting lasse's bug) svn:r5452	2005-11-24 06:06:50 +00:00
Roger Dingledine	23efc30776	get rid of some unused variables svn:r5451	2005-11-24 01:47:05 +00:00
Roger Dingledine	0118a236a4	comment that scary-looking function. svn:r5447	2005-11-23 07:30:44 +00:00
Nick Mathewson	eb0021b06e	Fix dumb logic error that kept some old descripttors from getting the axe. svn:r5446	2005-11-23 07:28:54 +00:00
Nick Mathewson	061ef582a1	Make dropping very old descriptors faster (remove old correctness check). Track bytes dropped that are still in our store or journal, and rebuild when it gets very high. svn:r5445	2005-11-23 07:24:59 +00:00
Nick Mathewson	36109fea33	e more aggressive about calling routerlist_remove_old_routers() svn:r5444	2005-11-23 07:06:36 +00:00
Nick Mathewson	fbf8a8c25f	Dump bytes held to store descriptors. svn:r5443	2005-11-23 06:00:58 +00:00
Nick Mathewson	7d7bb95f36	Track how many bytes we have in signed descriptors. Try to make sure we are tracking this right. Somebody should valgrind a dirserver on an example net. There should be code to dump this value. svn:r5442	2005-11-23 05:47:51 +00:00
Nick Mathewson	a39269572f	Replace balanced trees with hash tables: this should make stuff significantly faster. svn:r5441	2005-11-23 04:18:45 +00:00
Nick Mathewson	50ce5e1932	Avoid spurious re-launch of first pending requested descriptor svn:r5439	2005-11-22 02:20:05 +00:00
Peter Palfrader	a48b722432	Ancient gcc does not like you when you declare variables in the middle of a block svn:r5437	2005-11-20 16:53:49 +00:00
Peter Palfrader	b9d37a2d58	Add a new controller event type that allows controllers to get all server descriptors that were uploaded to a router in its role as authoritative dirserver. svn:r5436	2005-11-19 18:35:43 +00:00
Roger Dingledine	f28770b639	be less eager to decide that the entire network is down svn:r5434	2005-11-19 11:04:00 +00:00
Roger Dingledine	859d1c902a	and another instance where i was trying to be too sneaky svn:r5433	2005-11-19 10:38:23 +00:00
Roger Dingledine	98f353fa7c	actually listen when we try to route our dir connection via tor. svn:r5432	2005-11-19 10:33:34 +00:00
Roger Dingledine	5c949fce51	Start obeying our firewall options more rigorously: - If we can't get to a dirserver directly, try going via Tor. - Don't ever try to connect (as a client) to a place our firewall options forbid. - If we specify a proxy and also firewall options, obey the firewall options even when we're using the proxy: some proxies can only proxy to certain destinations. svn:r5431	2005-11-19 10:12:10 +00:00
Roger Dingledine	7aae63994f	Recover better from TCP connections to Tor servers that are broken but don't tell you (it happens!); and rotate TLS connections once a week. 1) If an OR conn becomes more than a week old, make it obsolete. 2) If it's obsolete and empty, kill it. 3) When an OR makes a second connection to you, allow it. 4) If we want to send a new create cell, but the best conn we've got is obsolete, and the router is 0.1.1.9-alpha-cvs or later, ask for a new conn instead. 5) When we time out on circuit building on the first hop, make that connection obsolete. svn:r5429	2005-11-19 06:57:44 +00:00
Roger Dingledine	700c370a3b	misc cleanups svn:r5428	2005-11-19 01:56:58 +00:00
Roger Dingledine	f824fb5f83	Bugfix: it looks like some middleman circuits were spending the first few moments of their existence in CIRCUIT_STATE_OPEN, then when Alice sent an extend request for a Tor that they're not connected to, they switched to CIRCUIT_STATE_OR_WAIT and spent the rest of their sorry little lives in that state, even when the connection was established and they were shuttling relay cells back and forth. And I'm not going to backport this (yet), because somehow it worked! svn:r5427	2005-11-19 01:55:58 +00:00
Roger Dingledine	0de8f4ee55	another case (i think) of redundant code. svn:r5426	2005-11-19 01:03:34 +00:00
Roger Dingledine	409294153f	remove some redundant (and misleading) code svn:r5425	2005-11-19 00:44:24 +00:00
Peter Palfrader	6734371234	15*60 is 15 minutes, not 5 svn:r5424	2005-11-18 21:57:49 +00:00
Peter Palfrader	901712ee59	Remove ip address change flapping detection. It is not really needed and I do not think it works quite right. svn:r5423	2005-11-18 19:28:34 +00:00
Roger Dingledine	4ddf2385a0	if it's not less than three does that mean it's more than two? svn:r5422	2005-11-18 11:35:23 +00:00
Roger Dingledine	9d6d6da883	and code the part where redirectstream can take a port. svn:r5421	2005-11-18 11:32:59 +00:00
Roger Dingledine	afb1c79879	Leave options->DirServers alone -- if the user didn't specify any, just add the default ones directly to the trusted dirserver list. This fixes a bug where people running controllers would setconf or the equivalent, and Tor would start yelling at them about setting their own DirServer lines. svn:r5418	2005-11-18 02:47:09 +00:00
Roger Dingledine	26d8c3498c	and another overly common log entry svn:r5417	2005-11-18 00:35:29 +00:00
Roger Dingledine	aa53190ed5	and another one svn:r5416	2005-11-17 22:23:18 +00:00
Roger Dingledine	9111a3fb48	comment out some really popular log lines svn:r5415	2005-11-17 22:19:35 +00:00
Roger Dingledine	d2b93df26c	and now we actually do it, too. svn:r5414	2005-11-17 22:01:46 +00:00
Roger Dingledine	7dbf2511c3	when you type 'getinfo' with no arguments, it doesn't give you any answer at all. this is clearly a bug. the more interesting bug is whether things like setconf, getconf, and so on should return 250 OK if you give them no arguments. should we have a new "you didn't ask me anything" response code, or just leave it as is? svn:r5412	2005-11-17 21:45:38 +00:00
Roger Dingledine	af86345b74	we used to kill the circuit when we receive a relay command we don't recognize. now we just drop it. perhaps this will make us more forward-compatible? or perhaps it will bite us? one day we will find out. svn:r5405	2005-11-17 03:40:20 +00:00
Roger Dingledine	298da4497a	help the term "OP" become obsolete svn:r5403	2005-11-17 01:17:53 +00:00
Roger Dingledine	279e29a1f2	bugfix: the controller doesn't mention it's a .onion if it is. svn:r5400	2005-11-16 23:54:24 +00:00
Roger Dingledine	c4aa9e7941	Add a new config option TestSocks so people can see if their applications are using socks4, socks4a, socks5-with-ip, or socks5-with-hostname. This way they don't have to keep mucking with tcpdump and wondering if something got cached somewhere. svn:r5399	2005-11-16 23:37:35 +00:00
Nick Mathewson	22aea0757e	Verify that router fingerprint lines match identity keys. (We dont use them, but others might.) svn:r5389	2005-11-15 21:24:32 +00:00
Roger Dingledine	74d1ca66c0	another case where the poor server operator doesn't need to hear about lexi's bugs. svn:r5388	2005-11-15 20:40:32 +00:00
Roger Dingledine	fe7b07754f	make it even more clear that i didn't screw up the logic svn:r5378	2005-11-15 09:57:58 +00:00
Roger Dingledine	53269f696d	fix logic error: not unnamed is good. svn:r5377	2005-11-15 09:15:43 +00:00
Nick Mathewson	9b432311c4	Make new logging stuff work on windows; fix a couple of windows typos. svn:r5375	2005-11-15 03:05:23 +00:00
Nick Mathewson	669fdde91b	Fix number in error message svn:r5369	2005-11-14 19:17:28 +00:00
Roger Dingledine	4ea6d71a26	shorten more of the startup log messages svn:r5368	2005-11-14 04:39:49 +00:00
Roger Dingledine	6fc30a65fd	when a stream times out, provide less (but better) explanation of what happened. don't bother printing the path, since i don't know of any person who has gotten anything useful out of that. svn:r5367	2005-11-14 04:13:43 +00:00
Roger Dingledine	014c6bfe00	We were refusing to start if you define SocksListenAddress but define SocksPort to be 0. But this is a standard configuration! So don't fail. svn:r5361	2005-11-11 22:41:07 +00:00
Roger Dingledine	a3c53e0af9	speed up the lookup-by-circid-orconn now that it seems that our code works. svn:r5358	2005-11-11 19:28:32 +00:00
Roger Dingledine	862a997495	when we were cannibalizing a circuit with a particular exit node in mind, we weren't checking to see if that exit node was already present earlier in the circuit. oops. svn:r5357	2005-11-11 19:25:30 +00:00
Roger Dingledine	4d1c6bbfc4	fix function comment svn:r5356	2005-11-11 17:16:24 +00:00
Roger Dingledine	c136bbe505	stop discouraging the old *BindAddress config options. we will just confuse our users when they upgrade. svn:r5354	2005-11-11 17:04:14 +00:00
Roger Dingledine	e6fd88c698	simplify a log entry svn:r5353	2005-11-11 17:03:35 +00:00
Roger Dingledine	c074f528c1	fix a harmless warn and mark two points where we should maybe change our approach. svn:r5352	2005-11-11 17:01:20 +00:00
Nick Mathewson	b76f61ee66	If we stop knowing about a dirserver between request and answer, do not die. svn:r5351	2005-11-08 22:30:17 +00:00
Peter Palfrader	43c253958e	Tor26's IP has changed to 86.59.21.38 svn:r5350	2005-11-05 20:20:51 +00:00
Nick Mathewson	75d85c8214	On directory servers, old_routers was wasting hundreds of bytes per superseded router descriptor. Roll the signed descriptor info and identifying info into a cache_info struct, and use only that for old_routers. svn:r5349	2005-11-05 20:15:27 +00:00
Nick Mathewson	757def59b6	Fix bugs in routerlist_remove_old_cached_routers_with_id() svn:r5348	2005-11-04 16:47:26 +00:00
Nick Mathewson	a913cb3536	prevent duplicat mark-for-close svn:r5347	2005-11-04 05:00:12 +00:00
Nick Mathewson	9e82f0cdb7	enable code to remove members of old_routers when it gets big. svn:r5345	2005-11-01 17:34:17 +00:00
Nick Mathewson	80758473f8	fix a signed/unsigned warning svn:r5344	2005-11-01 17:28:49 +00:00
Roger Dingledine	40ecaf4857	answer nick's XXX, and muck with some log domain choices svn:r5339	2005-11-01 06:13:12 +00:00
Roger Dingledine	6dafca62f0	remove redundant checking for . and .. now that tor_listdir() checks for this too. svn:r5337	2005-11-01 03:50:14 +00:00
Roger Dingledine	1991f6cf48	more doc cleanups and reorganizing svn:r5336	2005-11-01 03:48:51 +00:00
Roger Dingledine	44b3f3060a	make circ->onionskin a pointer, not a static array. moria2 was using 125000 circuit_t's after it had been up for a few weeks, which translates to 20+ megs of wasted space. svn:r5333	2005-10-29 19:13:48 +00:00
Roger Dingledine	bf2be9abd7	Do round-robin writes of at most 16 kB per write. This might be more fair on loaded Tor servers, and it might resolve our Windows crash bug. It might also slow things down. svn:r5332	2005-10-29 18:19:37 +00:00
Roger Dingledine	862e8a1bd1	fix typo svn:r5331	2005-10-29 18:00:25 +00:00
Nick Mathewson	f2617c6b79	Free the v2 directory networkstatus on exit. (Not a leak.) svn:r5330	2005-10-29 05:01:12 +00:00
Nick Mathewson	4cb2435388	aaand another leak. Oops, I guess I lied to weasel when I told him there was no leak here. svn:r5329	2005-10-28 19:10:53 +00:00
Nick Mathewson	ed32d85a04	router_add_to_routerlist() really needs to free not-added routers. svn:r5328	2005-10-28 18:44:51 +00:00
Nick Mathewson	76988bafbe	Fix bug when parsing list of router descriptors containing a truncated entry. (Found by Lasse) svn:r5327	2005-10-28 15:56:19 +00:00
Nick Mathewson	267af9ecf9	Fix a fun bug that was probably causing unnecessary downloads, and that coupld possibly have caused some segfaults: When post-processing a split fingerprint URL, we were trying to base16_decode() entries already in the fingerprint list, failing, and removing them. Ow. svn:r5326	2005-10-27 23:16:08 +00:00
Nick Mathewson	7643c5254c	Fix an annoying rep violation bug svn:r5325	2005-10-27 23:06:09 +00:00
Nick Mathewson	e594ce92fe	Start making directory caches retain old routerinfo_t. The code to remove old ones is definitely some textbook C problem. svn:r5323	2005-10-27 00:34:39 +00:00
Nick Mathewson	9492424d3f	Per comments at the bottom of openssl/FAQ, call even more functions to clean up OpenSSL's toys when it's done playing. (Why isn't there an OpenSSL_free_everything() function?) svn:r5321	2005-10-25 19:01:48 +00:00
Nick Mathewson	b39d03116b	remove some commented-out code that may tempt us to do ill svn:r5320	2005-10-25 18:38:44 +00:00
Nick Mathewson	e5633c2e66	fix a nasty corruption bug svn:r5319	2005-10-25 18:33:33 +00:00
Nick Mathewson	35f1b7fa26	fix minor memory leak in config svn:r5318	2005-10-25 18:06:29 +00:00
Nick Mathewson	5d85560d9e	Remove last vestiges of old logging interface. svn:r5317	2005-10-25 18:01:01 +00:00
Nick Mathewson	049f6c0131	Switch remaining files to new log interface. svn:r5315	2005-10-25 17:52:14 +00:00
Nick Mathewson	a38aa81bf8	fix another segv, this time in circid fix. svn:r5312	2005-10-25 15:31:25 +00:00
Nick Mathewson	9b6c5614c6	fix a segv svn:r5311	2005-10-25 15:30:02 +00:00
Nick Mathewson	e7e170a59e	Change more files to new loggin interface. 3 left. svn:r5310	2005-10-25 08:20:10 +00:00
Nick Mathewson	932106f54c	Efficiency hack: call tor_fix_source_file late, not early. Add "BUG" domain. Domains are now bitmasks... just in case. Make some err msgs non-general. svn:r5309	2005-10-25 07:05:03 +00:00
Nick Mathewson	452f4cfa09	Convert circuituse, command, config, connection, relay, router, test to new logging interface svn:r5308	2005-10-25 07:04:36 +00:00
Nick Mathewson	81dd50a942	Fix memory leak when retrieving networkstatus or routerdesc by malformed fingerprint svn:r5307	2005-10-25 07:03:22 +00:00
Nick Mathewson	91a666064a	Fix possible free(NULL) in control.c svn:r5306	2005-10-25 07:02:13 +00:00
Nick Mathewson	26caf69555	Fix possible minor memory leak when parsing helpernode state svn:r5305	2005-10-25 07:00:03 +00:00
Nick Mathewson	f9b0be526e	Use LD_BUG as appropriate; convert rend* and router* to new logging interface; use new circ_log_path interface svn:r5302	2005-10-24 19:39:45 +00:00
Nick Mathewson	fa338d85db	Fix one possible source of reuse-a-circuit-id bug; convert circuitbuild to new logging svn:r5301	2005-10-24 19:37:45 +00:00
Nick Mathewson	7f20dec1cd	When warning about a networkstatus fp, we need to put it in hex. svn:r5293	2005-10-24 03:25:12 +00:00
Nick Mathewson	37708e9b1b	Avoid potential infinite recursion when building a descriptor svn:r5292	2005-10-24 03:04:05 +00:00
Roger Dingledine	d6dcd973c3	Oct 19 13:27:24.391 [info] router_reload_networkstatus(): Skipping cached-status file with unexpected name "." Oct 19 13:27:24.391 [info] router_reload_networkstatus(): Skipping cached-status file with unexpected name ".." svn:r5291	2005-10-20 17:22:00 +00:00
Nick Mathewson	52eaccce44	Crank down the frequency for replacing unchanged descriptors svn:r5290	2005-10-19 16:21:19 +00:00
Nick Mathewson	7b8980a43c	Make it compile. appease roger and his thirst for documentation. svn:r5289	2005-10-19 03:08:50 +00:00
Nick Mathewson	74d9c92c49	We need a routerlist_replace as well. This should do something about those annoying mysterious segfaults. svn:r5288	2005-10-19 03:02:28 +00:00
Roger Dingledine	4df1892db1	solve the first half of bug 199: if we don't like the looks of an address, but it's the controller's job to handle it, don't refuse it first. svn:r5287	2005-10-19 02:07:11 +00:00
Nick Mathewson	1bd3f6cc9a	Update more files to new log stuff. svn:r5286	2005-10-18 22:56:40 +00:00
Nick Mathewson	55f2ab9cc3	Migrate a few more files to domained logging svn:r5285	2005-10-18 22:21:29 +00:00
Nick Mathewson	edf5698474	Start dividing log messages into logging domains. No, LD_ is not the best of identifiers. src/or has not been converted yet. Domains dont do anything yet. svn:r5284	2005-10-18 21:58:19 +00:00
Roger Dingledine	102df4a982	fix some typos svn:r5283	2005-10-18 21:39:00 +00:00
Peter Palfrader	e54efb1655	I think nick meant to compare r2->platform the second time svn:r5282	2005-10-18 21:19:48 +00:00
Peter Palfrader	0d5c007266	Fix tor26's first segfault svn:r5281	2005-10-18 21:19:02 +00:00
Nick Mathewson	d25873ae9c	Use a digestmap_t to speed up router_get_by_digest, which was previously a bottleneck (~~27% CPU) svn:r5280	2005-10-18 20:13:09 +00:00
Nick Mathewson	7a19588a43	Use digestmap_t instead of strmap_t where appropriate. Do less hex en/decoding svn:r5279	2005-10-18 20:12:22 +00:00
Nick Mathewson	3347c1741d	Refactor routerlist access slightly: always use router_get_by_routerlist(); change its interface; add modifier functions to add/remove elements from the current routerlist (so we can add indices). svn:r5276	2005-10-18 17:43:54 +00:00
Peter Palfrader	d8daa910a6	Make dirserv_get_routerdescs() return better http 404 error messages instead of a generic "Servers unavailable." svn:r5274	2005-10-18 17:09:57 +00:00
Peter Palfrader	551e3402a3	split send_control1_event() into the printf and the print/dispatch part. The printf part was and is limited to at most 1024 byte messages, so having the print part separately available makes sense. svn:r5273	2005-10-18 16:45:43 +00:00
Peter Palfrader	00e1709244	Fix download by SD digest svn:r5272	2005-10-18 15:58:40 +00:00
Peter Palfrader	6e8052e0f8	I wonder what a stautus is. svn:r5271	2005-10-18 15:25:10 +00:00
Peter Palfrader	64a631e187	Some http status lines ended in a dot, others did not. Make it all the same and remove the period from all svn:r5270	2005-10-18 14:57:46 +00:00
Peter Palfrader	0186cb283f	And close the double quote too svn:r5269	2005-10-18 14:34:49 +00:00
Peter Palfrader	d2f1cd4196	Fix documentation of dirserv_get_routerdescs: correct the path for queries by server key, add queries by SD digest svn:r5268	2005-10-18 14:33:19 +00:00
Nick Mathewson	27fcbf87f3	Add a missing struct initializer field svn:r5264	2005-10-17 23:00:08 +00:00
Peter Palfrader	0d9aedfcea	Downgrade a few INFO level logs to DEBUG again. Also add two or three new logs in cases where a calling function's log was downgraded and we wouldn't get any log message otherwise. svn:r5263	2005-10-17 16:21:42 +00:00
Roger Dingledine	bec2271029	fix a few comments svn:r5262	2005-10-17 08:41:58 +00:00
Roger Dingledine	fd165329b8	start calling it ListenAddress rather than BindAddress, since none of our users know what it means to bind an address or port. svn:r5260	2005-10-17 03:17:29 +00:00
Nick Mathewson	22c72bd9c5	Add ability to warn when using abbrev mechanism to deprecate option names svn:r5259	2005-10-17 03:06:00 +00:00
Roger Dingledine	435fb973c2	when providing content-type application/octet-stream for providing server descriptors with .z, we were leaving out the content-encoding header. oops. (everything tolerated this just fine, but that doesn't mean we need to be part of the problem.) svn:r5258	2005-10-17 02:32:33 +00:00
Peter Palfrader	7b15f77dd6	Make a few INFO log lines into DEBUG svn:r5257	2005-10-17 02:13:36 +00:00
Roger Dingledine	1be5f4a81b	start hunting down why servers keep getting so many duplicate create cells svn:r5255	2005-10-17 01:46:47 +00:00
Roger Dingledine	ae92a91d96	more log uncluttering svn:r5254	2005-10-17 01:29:28 +00:00
Roger Dingledine	03dcef4c78	start the process of reducing clutter in server logs svn:r5253	2005-10-17 00:35:53 +00:00
Roger Dingledine	aca6fb5f5f	cut out a warning that doesn't need to warn svn:r5252	2005-10-16 19:47:01 +00:00
Roger Dingledine	2a82182243	remove obsolete IgnoreVersion config from or.h svn:r5251	2005-10-16 18:43:41 +00:00
Nick Mathewson	6101468cbe	Enable trivial "download by descriptor digest" functionality. svn:r5250	2005-10-14 04:56:20 +00:00
Nick Mathewson	998cf8d622	Try to extract as many descriptors as possible from truncated http responses. (when DIR_PURPOSE_FETCH_ROUTERDESC) svn:r5249	2005-10-14 02:26:13 +00:00
Nick Mathewson	11b76b9ca5	Allow tor_gzip_uncompress to extract as much as possible from truncated compressed data. Also, fix a bug where truncated compressed data could break tor_gzip_uncompress. [This last part is a backport candidate.] svn:r5247	2005-10-13 22:48:09 +00:00
Peter Palfrader	8808b26206	Check if our IP address has changed every 5 minutes. If it has, update our server descriptor, but not too often svn:r5246	2005-10-12 22:41:16 +00:00
Peter Palfrader	640211e59a	Be a bit more verbose in our AUTHENTICATE error messages in the control protocol so the next guy doesn't blame Nick again svn:r5245	2005-10-12 19:45:35 +00:00
Nick Mathewson	aac738d2be	When no descriptors changed, do not send a NEWDESC event. svn:r5244	2005-10-12 19:41:16 +00:00
Nick Mathewson	905ef987e2	Make --hash-password not craash on exit. svn:r5243	2005-10-12 19:08:48 +00:00
Nick Mathewson	9a1d204318	Avoid warning on end-of-function svn:r5242	2005-10-12 18:43:03 +00:00
Nick Mathewson	972b7512c7	authorities do not replace server descriptors where nothing semantically relevant has changed since the last upload. svn:r5240	2005-10-12 18:25:25 +00:00
Nick Mathewson	fd9bfef13b	Funny. I could have sworn it compiled this morning when I checked it in. svn:r5239	2005-10-12 17:16:25 +00:00
Nick Mathewson	a7ca56b537	More work towards a sane digest-based liveness testing. svn:r5238	2005-10-12 13:49:13 +00:00
Nick Mathewson	2b3a7b818f	Add an as-yet-unused "EXTENDED" flag to SETEVENTS to indicate that the client can handle extra labeled info in its events. Add moreinfo to the "what is ready for downloading" msg so we can investigate digest-related download rules svn:r5237	2005-10-12 04:31:44 +00:00
Nick Mathewson	bf9ff1c1e7	Do not check whether DirPort is reachable when we are suppressing it because of hibernation. (Backport candidate) svn:r5235	2005-10-12 04:07:10 +00:00
Nick Mathewson	08e4f132a8	add some docs; if warn_if_unnamed is 0, really do not warn. svn:r5234	2005-10-11 01:57:28 +00:00
Nick Mathewson	c48ccf9db4	Insert a newline between all router descriptors when generating (old style) signed directories, in case somebody was counting on that. svn:r5231	2005-10-08 06:02:41 +00:00
Nick Mathewson	2f49e058d0	Now that directory admins assure me they have adjested teir configs, it is safe to make authorities be non-versioning, non-naming by default. svn:r5230	2005-10-08 05:47:58 +00:00
Nick Mathewson	d7b04a8788	do not try to download a routerdesc if we would immediately reject it as obsolete. svn:r5225	2005-10-07 22:00:09 +00:00
Nick Mathewson	2572db2472	Warn less about intro nodes by nickname; remember our own intro nodes by key. svn:r5224	2005-10-07 21:38:44 +00:00
Roger Dingledine	78edd804ff	fix a malformed warning entry svn:r5219	2005-10-07 19:49:48 +00:00
Roger Dingledine	83e119154b	doxygen fix svn:r5217	2005-10-07 19:25:01 +00:00
Roger Dingledine	46af2d26d0	you can't declare variables in the middle of a block svn:r5214	2005-10-07 18:56:21 +00:00
Peter Palfrader	14934dece2	Print address too when we say we cannot bind/listen svn:r5213	2005-10-07 18:48:31 +00:00
Nick Mathewson	4c7113d26a	Strip extra trailing newlines when parsing router descriptors. svn:r5212	2005-10-07 18:33:30 +00:00
Nick Mathewson	a89daaeca9	Once an hour (not just on startup) give OpenSSL some more entropy. Add entropy in 512-bit chunks, not 160-bit chunks. (This latter change is voodoo.) svn:r5211	2005-10-06 22:22:22 +00:00
Nick Mathewson	cc35e1720f	Using RAND_pseudo_bytes instead of RAND_bytes is an accident waiting to happen, and does not really speed us up much when we do it. So stop doing it. svn:r5210	2005-10-06 22:18:01 +00:00
Roger Dingledine	0e5b6a84eb	without braces, what will hold up the code? svn:r5209	2005-10-06 05:08:00 +00:00
Nick Mathewson	ba24193ab5	Make doxygen marginally happier svn:r5208	2005-10-06 04:33:40 +00:00
Nick Mathewson	5cf758764e	Rate-limit warnings related to unrecognized MyFamily elements. svn:r5204	2005-10-05 23:20:45 +00:00
Nick Mathewson	ba67d14d40	On sighup, if usehelpernodes changed to 1, use new circuits. svn:r5203	2005-10-05 23:02:40 +00:00
Roger Dingledine	f12663a4ce	call circuit_expire_all_dirty_circs() on do_hup(). there, now we use it. svn:r5202	2005-10-05 22:36:33 +00:00
Nick Mathewson	56be5a9706	I knew something was wrong here. Flip some comparison operators and make download-rate-limiting sane again. svn:r5201	2005-10-05 22:36:18 +00:00
Nick Mathewson	039edb3dbb	Downgrade too-frequent "nothing happened" message from info to debug svn:r5200	2005-10-05 22:32:59 +00:00
Roger Dingledine	c3aac3ff6b	infrastructure for the 'change pseudonym' button. not used yet. svn:r5199	2005-10-05 22:31:21 +00:00
Nick Mathewson	1ebbaf5c3a	improve INFO-level logging for directory downloads. This is still too chatty, but it will help us analyze things. svn:r5197	2005-10-05 20:45:18 +00:00
Nick Mathewson	370e4abdc9	replace former relaunches of directory downloads with reset of failure count and relaunch of status downloads. Fix memory leak in trusted_dir_server_t. Reset "last download attempted" time when resetting failure counts. svn:r5195	2005-10-05 05:03:52 +00:00
Roger Dingledine	adf04f121e	size_t int printf mucking svn:r5194	2005-10-05 04:52:55 +00:00
Nick Mathewson	96c47c8478	Note the two places where clients will still try to fetch old-style (v1) directory info. These should be fixed, I think. svn:r5193	2005-10-05 02:25:59 +00:00
Nick Mathewson	509de69a7e	reset warning flags on SIGHUP. arma: is this everything? svn:r5192	2005-10-05 02:20:46 +00:00
Roger Dingledine	be478bb56c	stutter therapy lessons svn:r5191	2005-10-05 02:09:27 +00:00
Nick Mathewson	8434595584	Fix verbose compiler warnings, including one in routerlist.c that would have been an actual error. Normalize whitespace. Enforce convention that "address" is a hostname and "addr" is an IPv4 address. svn:r5190	2005-10-05 02:06:36 +00:00
Nick Mathewson	0924094042	resolve some directory-related XXXXs; downgrade naming conflict messages from WARN to INFO for non-authorities; do not repeat naming conflict messages. svn:r5189	2005-10-05 01:53:44 +00:00
Nick Mathewson	1223310b69	Downgrade noisy log messages in preparation for an alpha release. svn:r5188	2005-10-05 01:27:08 +00:00
Nick Mathewson	a608905070	Give a less frequent and more helpful warning on failed serverdesc downloads svn:r5187	2005-10-05 00:22:56 +00:00
Nick Mathewson	42e17182da	When we get an EOF or a timeout on a directory connection, note how many bytes of serverdesc we are dropping. This will help us determine whether it is smart to parse incomplete serverdesc responses. svn:r5186	2005-10-04 22:34:09 +00:00
Nick Mathewson	61ea516885	Check for named servers when looking them up by nickname; warn when we'recalling a non-named server by its nickname; don't warn twice about the same name. Fix a bug in routers_update_status_from_networkstatus that made nearly all clients never update routerinfo_t.is_named. Try to list MyFamily elements by key, not by nickname. Only warn about names that we generated ourself, or got from the local user. On TLS handshake, only check the other router's nickname against its expected nickname if is_named is set. svn:r5185	2005-10-04 22:23:31 +00:00
Nick Mathewson	2d203fdcf3	link nicknames to trusted directory servers; log these nicknames when mentioning servers; also, when we get a naming conflict; log which nicknames or keys are supposed to bind. svn:r5184	2005-10-04 21:21:09 +00:00
Nick Mathewson	b10df0d595	cosmetic fix: only have one local to hold smartlist_len(downloadable), not too. svn:r5183	2005-10-04 20:18:26 +00:00
Nick Mathewson	e4a6a03249	switch semantics of authdirinvalid/reject svn:r5182	2005-10-04 19:52:58 +00:00
Roger Dingledine	88c37f2d24	comment cleanups svn:r5181	2005-10-04 06:53:59 +00:00
Nick Mathewson	c5ee3e961e	Reorganize some quick-and-dirty code to find out what openssl stuff is leaking, using dmalloc. svn:r5178	2005-10-03 20:20:38 +00:00
Nick Mathewson	9e54e2e293	free helper node status info on shutdown svn:r5177	2005-09-30 21:38:57 +00:00
Nick Mathewson	808e584a87	remove a never-used smartlist in routerlist.c svn:r5176	2005-09-30 21:38:45 +00:00
Nick Mathewson	6e4608701d	and another leak. svn:r5175	2005-09-30 21:31:26 +00:00
Roger Dingledine	ae30c8101b	by convention, addr is a uint32_t and address is a string. that's why we hadn't caught that leak. svn:r5174	2005-09-30 21:30:04 +00:00
Nick Mathewson	5c5d2e82e6	Fix a leak when launching listeners. svn:r5173	2005-09-30 21:28:00 +00:00
Nick Mathewson	23864ad423	Try to hunt down a few more leaks svn:r5172	2005-09-30 21:22:25 +00:00
Nick Mathewson	80f2e10228	Stop leaking or_state_t on shutdown. svn:r5171	2005-09-30 21:16:47 +00:00
Nick Mathewson	5333a3b838	fix a small filename leak svn:r5170	2005-09-30 21:11:22 +00:00
Nick Mathewson	8408006318	fix a memory leak on exit in routerlist.c svn:r5169	2005-09-30 21:04:52 +00:00
Nick Mathewson	de198d800b	Never call free() on tor_malloc()d memory. This is unlikely to be our current leak, but it may help dmalloc work. svn:r5168	2005-09-30 20:47:58 +00:00
Nick Mathewson	fc3c0197f9	Resolve several DOCDOCs. Make non-mirrors only launch routerdesc downloads when they have more than 16 router descriptors to download, or when 10 minutes have passed since the last download. svn:r5166	2005-09-30 20:04:55 +00:00
Roger Dingledine	e28c31ebce	we were leaking some memory every time the client changes IPs svn:r5165	2005-09-30 06:03:04 +00:00
Nick Mathewson	ab245746a9	Hey kids, guess why connection_mark_for_close() started giving an assert when called for an even-numbered line? Right, because I made it a bitfield, when it was really a line number. Why did I think it was a bitfield? A stale comment. Let that be a lesson to us all. svn:r5164	2005-09-30 04:43:42 +00:00
Roger Dingledine	13e709a0ff	resolve nick's comment svn:r5163	2005-09-30 02:08:57 +00:00
Nick Mathewson	26e7a05725	even better function start checks; give dmalloc a chance of working. svn:r5162	2005-09-30 01:39:24 +00:00
Nick Mathewson	edd15cb781	Note that there is incorrect behavior in directory.c code. Arma, please check this too. svn:r5161	2005-09-30 01:38:09 +00:00
Nick Mathewson	92451f74a8	Reformat inconsistent function declarations. svn:r5160	2005-09-30 01:09:52 +00:00
Roger Dingledine	609af664ac	resolve a docdoc svn:r5157	2005-09-30 00:43:40 +00:00
Roger Dingledine	ea18827cee	do the other half of dirport reachability testing. it should be back and working now. svn:r5155	2005-09-29 23:59:36 +00:00
Roger Dingledine	f8d430653e	better cleanups as i figure out what's going on svn:r5154	2005-09-29 23:26:42 +00:00
Roger Dingledine	d4d8adaa6d	move some code around when we're succeeding or failing at fetching server descs. also clean up some formatting. svn:r5153	2005-09-29 23:06:48 +00:00
Roger Dingledine	54a662a542	re-enable dirport testing again (still need the other half, to notice when it has worked.) svn:r5152	2005-09-29 23:04:01 +00:00
Roger Dingledine	8fc9330686	fix typo svn:r5151	2005-09-29 23:03:34 +00:00
Nick Mathewson	5c53545d81	Add a bunch more warnings to out warning suite; resolve them; pack structs a little better. svn:r5150	2005-09-29 22:59:17 +00:00
Nick Mathewson	c6347cdb0e	suppress all our usual compiler warnings, including a longstanding one from tree.h svn:r5149	2005-09-29 20:49:41 +00:00
Roger Dingledine	8ae6e1c226	Be more conservative about whether to advertise our dirport. The main change is to not advertise if we're running at capacity and either a) we could hibernate or b) our capacity is low and we're using a default dirport. svn:r5148	2005-09-29 06:45:03 +00:00
Roger Dingledine	3559f821a1	clean up some doxygen stuff svn:r5147	2005-09-29 02:54:09 +00:00
Nick Mathewson	126a1e3e32	Fix crash-on-wakeup bug in networkstatus download. svn:r5144	2005-09-26 16:37:39 +00:00
Roger Dingledine	fba01c3cc0	bugfix: we were whining about using socks4 or socks5-with-local-lookup even when they used an IP in the "virtual" range we designed exactly for this case. svn:r5142	2005-09-24 21:56:04 +00:00
Nick Mathewson	abb8576538	But, of course, mirrors should get the most up-to-date server in any case. svn:r5135	2005-09-23 21:33:59 +00:00
Nick Mathewson	b726507d36	Log even less verbosely. Also, do not download old (frequently-updating) servers more than once every 2 hours. svn:r5134	2005-09-23 21:25:29 +00:00
Nick Mathewson	ebf6476e8e	Provide dire warnings to any users who set DirServer; move it out of torrc.sample and into torrc.complete. svn:r5132	2005-09-23 20:44:22 +00:00
Nick Mathewson	18a0a0e458	Oops. It looks like some old GCCs dislike #if inside a macro argument. svn:r5131	2005-09-23 20:31:07 +00:00

... 53 54 55 56 57 ...

7989 Commits