Nick Mathewson
b36e311eab
Fill in the missing documentation on the new functions
2017-03-16 14:42:56 -04:00
Nick Mathewson
12d428aaff
Prop140: Fix a crash bug.
...
Found while fuzzing: this could occur if we tried to copy a
nonexistent "line 0" while applying a diff.
2017-03-16 14:42:56 -04:00
Nick Mathewson
653c6d129e
Make consensus diff sha3 operations mockable.
...
(We'll want this for fuzzing)
2017-03-16 14:40:33 -04:00
Nick Mathewson
6a36e5ff3b
String-based API for consensus diffs.
...
Also, add very strict split/join functions, and totally forbid
nonempty files that end with somethig besides a newline. This
change is necessary to ensure that diff/apply are actually reliable
inverse operations.
2017-03-16 14:39:54 -04:00
Nick Mathewson
eff9fbd17d
Fix an abstraction violation.
...
Don't alias the insides of smartlist_t; that way lies madness.
2017-03-16 14:38:29 -04:00
Nick Mathewson
69b3e11e59
Use "const" in consdiff.[ch]
2017-03-16 14:38:29 -04:00
Nick Mathewson
3647751c2a
prop140: Use sha3-256, not sha2-256
...
This is a protocol update from recent prop140 changes.
Also, per #21673 , we need to check the entire document, including
signatures.
2017-03-16 14:38:29 -04:00
Nick Mathewson
e1418c09fc
Fix an unreachable memory leak.
...
Also add a missing newline.
2017-03-16 14:38:29 -04:00
Nick Mathewson
f193b666cd
Remove digest[12]_hex
2017-03-16 14:38:29 -04:00
Nick Mathewson
c6046f4db8
Tweak&test log messages on apply_diff
2017-03-16 14:38:29 -04:00
Nick Mathewson
5766eed38f
Fixes when applying diffs: Allow 2-line diffs, fix bogus free
...
The 2-line diff changs is needed to make the unit tests actually
test the cases that they thought they were testing.
The bogus free was found while testing those cases
2017-03-16 14:38:29 -04:00
Nick Mathewson
ab1fd85c99
Mark some warnings as bugs, and as (hopefully) unreachable.
2017-03-16 14:38:28 -04:00
Nick Mathewson
06017f35e8
Fix some logging on failed apply_ed_diff
2017-03-16 14:38:28 -04:00
Nick Mathewson
97620cf18f
No need to end a log message with newline.
2017-03-16 14:38:28 -04:00
Nick Mathewson
360d043ac7
Use "STATIC" to export consdiff fns for testing
...
Previously test_consdiff.c just did #include "consdiff.c", which is
not great style, and messes up coverage testing.
2017-03-16 14:38:28 -04:00
Daniel Martí
590ffdb2c9
Consensus diff backend from Daniel Martí GSOC project.
...
(This commit was extracted by nickm based on the final outcome of
the project, taking only the changes in the files touched by this
commit from the consdiff_rebased branch. The directory-system
changes are going to get worked on separately.)
2017-03-16 14:38:28 -04:00
