George Kadianakis
27f24484d4
prob-distr: Some more comments about the initializers.
...
Based on patches and review comments by Riastradh and Catalyst.
Co-authored-by: Taylor R Campbell <campbell+tor@mumble.net>
Co-authored-by: Taylor Yu <catalyst@torproject.org>
2019-03-26 09:39:40 -04:00
George Kadianakis
08176c2396
prob-distr: Silence some coverity warnings.
2019-03-26 09:39:37 -04:00
George Kadianakis
d11976b8bd
Merge branch 'tor-github/pr/709'
2019-03-26 15:34:54 +02:00
George Kadianakis
2790ee3685
Merge branch 'maint-0.4.0'
2019-03-26 15:16:37 +02:00
George Kadianakis
06951cb3fc
Merge branch 'tor-github/pr/847' into maint-0.4.0
2019-03-26 15:16:21 +02:00
Nick Mathewson
39e4494344
practracker: update usage note in docstring
2019-03-26 08:42:14 -04:00
teor
613c5ff357
Merge remote-tracking branch 'tor-github/pr/724'
2019-03-26 19:31:17 +10:00
teor
0642650865
Merge branch 'maint-0.4.0'
2019-03-26 19:16:06 +10:00
teor
4258728d56
Merge remote-tracking branch 'tor-github/pr/852' into maint-0.4.0
2019-03-26 19:15:46 +10:00
rl1987
4e6ba575a6
Add header guards to ptr_helpers.h
2019-03-26 09:49:32 +02:00
juga0
6ecf9590ea
changes: add file for #21377
2019-03-26 17:41:21 +10:00
juga0
da7a8d7624
dircache: fix identation and remove unneded goto
2019-03-26 17:41:17 +10:00
juga0
892b918b66
bwauth: remove declaring args, they are now in use
2019-03-26 17:41:13 +10:00
juga0
a4bf3be8bc
test: check that .../bandwidth.z is compressed
2019-03-26 17:41:09 +10:00
juga0
fb4a40c32c
test: Check bw file cache lifetime
2019-03-26 17:41:06 +10:00
juga0
7627134743
bwauth: increment bw file cache lifetime
...
Increment bw file cache lifetime when serving it by HTTP.
And add a constant to define that lifetime.
2019-03-26 17:41:02 +10:00
juga0
4d3502e45b
bwauth: check and use compression serving bw file
2019-03-26 17:40:58 +10:00
juga0
b75e2539f9
bwauth: check if a bw file could be read
...
Before serving it by HTTP.
2019-03-26 17:40:54 +10:00
juga0
ee09e5d7ea
bwauth: use flag to do not warn when file is missing
...
Use flag to do not warn when the bandwidth file is missing trying
to serve it by http.
Also remove double space in the assignement.
2019-03-26 17:40:50 +10:00
juga0
3eacae42b2
Serve bandwidth file used in the next vote
...
When a directory authority is using a bandwidth file to obtain the
bandwidth values that will be included in the next vote, serve this
bandwidth file at /tor/status-vote/next/bandwidth.z.
2019-03-26 17:40:45 +10:00
teor
3d38d0ca24
Merge branch 'maint-0.4.0'
2019-03-26 16:57:04 +10:00
teor
828033001b
Merge remote-tracking branch 'tor-github/pr/848' into maint-0.4.0
2019-03-26 16:56:45 +10:00
teor
ec736f8729
Merge remote-tracking branch 'tor-github/pr/833'
2019-03-26 13:02:37 +10:00
teor
d482913e69
Merge remote-tracking branch 'tor-github/pr/834'
2019-03-26 12:55:48 +10:00
rl1987
669ec64325
Fix CID 1444119
...
Let's use the same function exit point for BUG() codepath that we're using
for every other exit condition. That way, we're not forgetting to clean up
the memarea.
2019-03-26 12:24:45 +10:00
teor
3af9a51118
test/dir: add a 4th argument to dirserv_read_measured_bandwidths()
...
Part of 29806.
2019-03-26 11:49:33 +10:00
teor
b76ae3898d
Merge branch 'ticket29806_035_squashed_merged' into ticket29806_040_squashed_merged
2019-03-26 11:48:52 +10:00
George Kadianakis
473decb246
Merge branch 'tor-github/pr/839'
2019-03-26 01:17:58 +02:00
Nick Mathewson
ddb31dd583
Rename one case of c_type to c_ptr_type.
2019-03-25 16:35:34 -04:00
Nick Mathewson
3f0bfe1d29
Rename DISPATCH_DEFINE_TYPE() to DISPATCH_REGISTER_TYPE()
...
Also fix a grammar error in a comment.
2019-03-25 16:35:34 -04:00
Nick Mathewson
28fd4996ac
Various documentation notes and tweaks for pubsub
2019-03-25 16:35:34 -04:00
Nick Mathewson
a8ca464cee
Log warning messages _before_ exiting because of earlier dcfg failure
...
This helps diagnostics.
2019-03-25 16:35:34 -04:00
Nick Mathewson
47de9c7b0a
Use actual pointers in dispatch_cfg.c.
...
Previously, I had used integers encoded as pointers. This
introduced a flaw: NULL represented both the integer zero, and the
absence of a setting. This in turn made the checks in
cfg_msg_set_{type,chan}() not actually check for an altered value if
the previous value had been set to zero.
Also, I had previously kept a pointer to a dispatch_fypefns_t rather
than making a copy of it. This meant that if the dispatch_typefns_t
were changed between defining the typefns and creating the
dispatcher, we'd get the modified version.
Found while investigating coverage in pubsub_add_{pub,sub}_()
2019-03-25 16:35:34 -04:00
Nick Mathewson
8d70f21717
Add a test for pubsub_items_clear_bindings()
2019-03-25 16:35:34 -04:00
Nick Mathewson
b11b4b7bb7
Add test for dispatch_send() fast path.
2019-03-25 16:35:34 -04:00
Nick Mathewson
ab6ddc7a33
practracker: split shutdown code out of main.c
...
This is necessary to get the number of includes in main.c back under
control. (In the future, we could just use the subsystem manager for
this kind of stuff.)
2019-03-25 16:35:34 -04:00
Nick Mathewson
4bdff5e3e9
practracker compliance: split lint_message into more logical parts
2019-03-25 16:35:34 -04:00
Nick Mathewson
d976cda49f
pubsub: add test for items_out in builder_finalize()
2019-03-25 16:35:34 -04:00
Nick Mathewson
3552cd69bd
coverage: Exclude lines in pubsub_pub that can only be reached on bug
2019-03-25 16:35:34 -04:00
Nick Mathewson
2e7f80d5f4
pubsub_check.c: Stop accepting NULL prefix, which we never send.
...
(Our code to handle it was broken, too)
2019-03-25 16:35:34 -04:00
Nick Mathewson
c40bcab85d
dispatch: Test behavior of formatting type with no set fmt function.
2019-03-25 16:35:34 -04:00
Nick Mathewson
f74301f8fd
Unit test for namemap_fmt_name()
2019-03-25 16:35:34 -04:00
Nick Mathewson
9fb511526a
pubsub test: add a test to make sure typefns can't be changed.
2019-03-25 16:35:34 -04:00
Nick Mathewson
beedadbeac
Try a different approach to making publish function seem used.
...
We want the DISPATCH_ADD_PUB() macro to count as making a
DECLARE_PUBLISH() invocation "used", so let's try a new approach
that preserves that idea. The old one apparently did not work for
some versions of osx clang.
2019-03-25 16:35:34 -04:00
Nick Mathewson
94feec59cf
move pubsub_connector_t typedef to pubsub_connect.h
2019-03-25 16:35:34 -04:00
Nick Mathewson
22ad8658cd
Correct doxygen @file directives
2019-03-25 16:35:34 -04:00
Nick Mathewson
3d6bf7b36e
Document several issues found by Taylor
2019-03-25 16:35:34 -04:00
Nick Mathewson
b4f28b9df8
pubsub: install libevent events separately from the_dispatcher.
...
Also, add documentation, and fix a free-on-error bug.
2019-03-25 16:35:34 -04:00
Nick Mathewson
6d1abd37e2
Connect the mainloop pubsub dispatcher on startup; free it on shutdown.
2019-03-25 16:35:33 -04:00
Nick Mathewson
02e0a39d39
Add msgtypes.h include to pubsub_build.h
...
(The header won't compile without it.)
2019-03-25 16:35:33 -04:00
