Nick Mathewson
f4ded2cdc9
Fix an always-false check with an assertion
...
In validate_recommended_package_line, at this point in the function,
n_entries is always >= 1. Coverity doesn't like us checking it for
0.
CID 1268063.
2015-09-01 09:52:46 -04:00
Nick Mathewson
b977a570c4
Fix a false-positive in coverity scan with an assertion
...
CID 1301373
2015-09-01 09:50:33 -04:00
Nick Mathewson
f64ef65b9d
Fix code for checking expired certificates on load
...
Fixes CID 1306915, which noticed that the check was dead.
2015-09-01 09:47:51 -04:00
Nick Mathewson
53c99cce5e
Add a comment about CID 1311630 and why we won't worry about it.
2015-09-01 09:43:37 -04:00
Nick Mathewson
a55f257d6a
Simplify API for find_rp_for_intro()
...
The function now unconditionally allocates a new extend_info_t.
This should convince coverity that we're not leaking memory.
(CID 1311875)
2015-09-01 09:30:48 -04:00
Nick Mathewson
2c5fec15f7
Merge remote-tracking branch 'sebastian/channel_free_list'
2015-09-01 09:19:00 -04:00
Sebastian Hahn
6034e21331
Include doc/TUNING in our release tarballs
2015-09-01 09:15:11 -04:00
Sebastian Hahn
bbb73eaf31
properly delete current channel in channel_free_list
...
channel_unregister() removes channels from the current smartlist while
we're in a SMORTLIST_FOREACH loop. This only works by accident.
2015-09-01 15:10:10 +02:00
Nick Mathewson
b79e90f6ba
Fail in configure when openssl is too old. #16901 .
2015-09-01 09:02:12 -04:00
rl1987
54565ca804
Remove -F from tor-resolve(1) usage message.
2015-08-30 21:57:24 +03:00
teor (Tim Wilson-Brown)
d9948dfc9d
Autodetect CHUTNEY_PATH if chutney is next to tor
...
If the chutney and tor sources are side-by-side in the same
parent directory, autodetect the chutney path.
Closes ticket 16903. Patch by "teor".
2015-08-27 10:31:35 +10:00
Nick Mathewson
b531fc7d9a
Fix some memory issues in test_dns.c
2015-08-26 11:41:25 -04:00
Nick Mathewson
92a596d0fc
Resolve check-spaces in test_dns.c
2015-08-26 11:38:44 -04:00
Nick Mathewson
31ef90b0d0
fix compilation warnings in test_dns.c
2015-08-26 11:38:04 -04:00
Nick Mathewson
e8675dc7fc
Merge remote-tracking branch 'rl1987/test_dns_resolve_rebased'
2015-08-26 11:32:40 -04:00
Nick Mathewson
1eb2106375
Document callgraph analysis code
2015-08-25 11:53:20 -04:00
Nick Mathewson
f8a5106823
Make test_checkdir.c dirent include consistent with other files
2015-08-25 11:46:29 -04:00
Donncha O'Cearbhaill
1d205163e8
Generate service descriptors when PublishHidServDescriptors = 0
...
Removes a check to PublishHidServDescriptors in
rend_consider_services_upload(). This allows descriptors to be
generated and stored in the local cache when PublishHidServDescriptor = 0.
Keep the PublishHidServDescriptors option check in
rend_consider_descriptor_republication(). We will never need to republish
a descriptor if we are not publishing descriptors to the HSDirs.
2015-08-25 17:30:11 +02:00
Donncha O'Cearbhaill
e0b82e5968
Store service descriptors in the service descriptor cache
...
Service descriptors are now generated regardless of the the
PublishHidServDescriptors option. The generated descriptors are stored
in the service descriptor cache.
The PublishHidServDescriptors = 1 option now prevents descriptor
publication to the HSDirs rather than descriptor generation.
2015-08-25 17:30:11 +02:00
Donncha O'Cearbhaill
968cb95602
Preparatory indentation changes
...
Deindent a block of code inside the PublishHidServDescriptors option
check in upload_service_descriptor(). Stylistic commit to make the
subsequent reworking of this code cleaner.
2015-08-25 17:30:11 +02:00
Donncha O'Cearbhaill
af3be650e3
Add a HS_DESC CREATED control event
...
The HS_DESC CREATED event should be emmited when a new service descriptor
is generated for a local rendevous service. This event is documented
in the control spec.
This commit resolves ticket #16291 .
2015-08-25 17:30:02 +02:00
Donncha O'Cearbhaill
1a75e6da00
Create a service-side descriptor cache
...
Adds a service descriptor cache which is indexed by service ID. This
descriptor cache is used to store service descriptors generated by a
local rendevous service.
The service-side cach can be queried by calling rend_cache_lookup_entry()
with the 'service' argument set to 1.
2015-08-25 16:44:31 +02:00
Donncha O'Cearbhaill
5eff39c846
Fix typo
2015-08-25 16:43:15 +02:00
Nick Mathewson
2afbe0ae28
Expand changes file
2015-08-25 09:37:52 -04:00
Andreas Stieger
19df037e53
Log malformed hostnames in socks5 request respecting SafeLogging
2015-08-25 09:36:34 -04:00
rl1987
99a03b2389
Adding changes file.
2015-08-23 16:06:41 +03:00
rl1987
77a5ca901f
Unit test dns_resolve(), dns_clip_ttl(), dns_get_expiry_ttl().
2015-08-23 16:02:39 +03:00
Nick Mathewson
80a45835c4
Is this the syntax that will make freebsd make happy?
2015-08-21 12:03:05 -04:00
Nick Mathewson
848d21c246
Do not try to chmod test_keygen.sh: It is not generated by configure.
2015-08-21 11:10:49 -04:00
Nick Mathewson
3b6d2f9bf4
Merge branch 'workqueue_squashed'
2015-08-21 10:37:01 -04:00
Sebastian Hahn
1633d1ad1d
Remove tor-fw-helper more thoroughly
2015-08-21 10:36:53 -04:00
Sebastian Hahn
5cf24ff3af
Fix a bunch of check-spaces complaints
2015-08-21 10:36:53 -04:00
Sebastian Hahn
38601f06b7
Observe workqueue_reply_t in check-spaces
2015-08-21 10:36:53 -04:00
Sebastian Hahn
32220d38c0
Ensure worker threads actually exit when it is time
...
This includes a small refactoring to use a new enum (workqueue_reply_t)
for the return values instead of just ints.
2015-08-21 10:36:53 -04:00
Nick Mathewson
b58dfba76f
Rename EVENT_SIGNAL -> EVENT_GOT_SIGNAL
...
This avoids a conflict with a macro decl from libevent 1.x.
Fixes bug 16867; bug not in any released Tor.
2015-08-20 18:42:20 -04:00
Sebastian Hahn
2657ea802b
New testcase exposing bug during threadpool shutdown
...
We don't want to accept any work after one of our worker functions has
returned WQ_RPL_SHUTDOWN. This testcase currently fails, because we do
not actually stop any of the worker threads.
2015-08-20 20:00:05 +02:00
Nick Mathewson
037e8763a7
Reload Ed25519 keys on sighup.
...
Closes ticket 16790.
2015-08-19 13:37:21 -04:00
Nick Mathewson
428bb2d1c8
Merge branch 'ed25519_keygen_squashed'
2015-08-19 13:36:59 -04:00
Nick Mathewson
8589c47049
changes file for ed25519_keygen branch
2015-08-19 13:36:51 -04:00
Nick Mathewson
426ef9c8eb
More log messages for keygen problems
2015-08-19 13:36:51 -04:00
Nick Mathewson
c88a8a7ca3
Explain better why we are about to load the master key.
2015-08-19 13:36:51 -04:00
Nick Mathewson
a1b5e8b30b
Don' call failure to get keys a bug; it's possible now.
2015-08-19 13:36:50 -04:00
Nick Mathewson
76ec891572
When we infer the master key from the certificate, save it to disk.
2015-08-19 13:36:50 -04:00
Nick Mathewson
5d76acfcb3
Document test_keygen.sh a little more
2015-08-19 13:36:50 -04:00
Nick Mathewson
138b28dc35
Add test_keygen tests for all log outputs; improve keygen outputs.
2015-08-19 13:36:50 -04:00
Nick Mathewson
a1e543f908
Suppress fingerprint display in test_keygen.sh
2015-08-19 13:36:50 -04:00
Nick Mathewson
4ce0b7e916
Integreate test_keygen.sh into 'make check'.
2015-08-19 13:36:50 -04:00
Nick Mathewson
8f6f1544c9
Resolve failing test_keygen tests.
2015-08-19 13:36:50 -04:00
Nick Mathewson
f362e7a873
Checkpoint work on ed25519 keygen improvements.
...
Needs changes file, documentation, test integration, more tests.
2015-08-19 13:36:49 -04:00
Nick Mathewson
2f5202c636
Merge remote-tracking branch 'teor/feature14882-TestingDirAuthVoteIsStrict-v3'
2015-08-18 09:53:50 -04:00
