Nick Mathewson
2170171d84
Merge branch 'ticket13172'
2014-11-12 13:25:17 -05:00
Nick Mathewson
d85270e13c
Reenhappy make check-spaces
2014-11-12 13:15:10 -05:00
Nick Mathewson
81433e7432
Merge remote-tracking branch 'rl1987/bug13644'
2014-11-12 13:12:14 -05:00
Nick Mathewson
ccc54d545e
tweak 9812 changes file
2014-11-12 10:28:33 -05:00
Nick Mathewson
99e2a325f6
Merge remote-tracking branch 'rl1987/bug9812'
2014-11-12 10:27:12 -05:00
Nick Mathewson
a87c697fb1
Merge remote-tracking branch 'public/bug13698_024_v1'
2014-11-12 10:23:55 -05:00
Nick Mathewson
5e4174f3b4
Revise changes file
2014-11-12 10:23:24 -05:00
rl1987
032560fc75
Adding changes file for 13644.
2014-11-11 21:01:30 +02:00
rl1987
a6520ed537
Renaming ROUTER_WAS_NOT_NEW to ROUTER_IS_ALREADY_KNOWN.
2014-11-11 20:56:40 +02:00
rl1987
f9d73eea9c
Comment possible values of was_router_added_t.
2014-11-11 20:37:39 +02:00
David Goulet
34eb007d22
Fix: don't report timeout when closing parallel intro points
...
When closing parallel introduction points, the given reason (timeout)
was actually changed to "no reason" thus when the circuit purpose was
CIRCUIT_PURPOSE_C_INTRODUCE_ACK_WAIT, we were reporting an introduction
point failure and flagging it "unreachable". After three times, that
intro point gets removed from the rend cache object.
In the case of CIRCUIT_PURPOSE_C_INTRODUCING, the intro point was
flagged has "timed out" and thus not used until the connection to the HS
is closed where that flag gets reset.
This commit adds an internal circuit reason called
END_CIRC_REASON_IP_NOW_REDUNDANT which tells the closing circuit
mechanism to not report any intro point failure.
This has been observed while opening hundreds of connections to an HS on
different circuit for each connection. This fix makes this use case to
work like a charm.
Fixes #13698 .
Signed-off-by: David Goulet <dgoulet@ev0ke.net>
2014-11-10 15:02:54 -05:00
Nick Mathewson
26e7e519dc
Document networkstatus-bridges
...
Closes 13713; patch from 'tom'
2014-11-10 09:03:11 -05:00
rl1987
e395783f23
Adding changes file for 9812.
2014-11-09 17:55:35 +02:00
rl1987
7025f2dc59
Print a warning when extra info document is found incompatible with router descriptor.
2014-11-09 17:41:18 +02:00
rl1987
4b18d8931b
Downgrade RSA signature verification failure error message to info loglevel.
2014-11-09 17:39:23 +02:00
rl1987
7f7df97579
Fixing typo in manpage.
2014-11-09 16:34:34 +02:00
David Goulet
151f5f90b8
Wrong format in log statement
...
Fixes bug 13701.
2014-11-07 11:44:41 -05:00
Nick Mathewson
5b1971c7f3
test_checkdir.c: Perhaps this is what will make this test pass on windows?
2014-11-07 09:28:49 -05:00
Nick Mathewson
85a76cd4eb
test_checkdir.c: try to make it pass on windows
...
also fix memory-leak on failing tests.
2014-11-07 08:54:44 -05:00
Nick Mathewson
00f5909876
Define macros meaning <,>,==,!=,<=,>=
...
This lets us avoid putting operators directly in macro arguments,
and thus will help us unconfuse coccinelle.
For ticket 13172.
2014-11-06 11:21:13 -05:00
Nick Mathewson
68af1e7e9b
Throw identify-node-by-nickname down the memory hole
...
Authorities are no longer voting on Named, so specifying nodes by
nickname isn't a clever thing to do. (Not that it ever was!) So
remove the documentation that suggests that you should do it.
Additionally, add proper cross-references to our __node__ lists, and
explain about the optional $ before identity digests.
Also, the oxford comma: endorsed by Steven Pinker, my spouse, and my
11th grade English teacher.
Closes 13381.
2014-11-06 11:10:58 -05:00
Nick Mathewson
4ae729683d
Try to fix test_checkdir windows compilation more
2014-11-05 14:51:17 -05:00
Nick Mathewson
bb54d008c2
Try to fix test_checkdir windows compilation
2014-11-05 14:39:09 -05:00
Nick Mathewson
1dcc492295
chgrp the testing tempdir to ourself to clear the sticky bit
...
Closes 13678. Doesn't actually matter for older tors.
2014-11-05 14:28:34 -05:00
Nick Mathewson
8f645befba
11291: Fix warnings, add changes file, rename 'mask'.
2014-11-05 14:12:18 -05:00
Nick Mathewson
4df419a4b1
Merge remote-tracking branch 'meejah/ticket-11291-extra-utests'
...
Conflicts:
src/or/config.c
2014-11-05 14:11:47 -05:00
Nick Mathewson
3d8cb10732
Changes file for Andrea's work on 6456
2014-11-04 09:59:25 -05:00
Nick Mathewson
ce147d33f5
Fix a wide line I introduced
2014-11-04 09:56:46 -05:00
Nick Mathewson
07e06b335d
Fix unused-argument warnings
2014-11-04 09:54:51 -05:00
Nick Mathewson
9619c395ac
Merge remote-tracking branch 'andrea/ticket6456'
...
Somewhat tricky conflicts:
src/or/config.c
Also, s/test_assert/tt_assert in test_config.c
2014-11-04 09:52:04 -05:00
Nick Mathewson
b1ca05d273
Update verbiage in README to mention autogen.sh
...
Closes ticket 13190
2014-11-04 09:01:46 -05:00
Nick Mathewson
60c86a3b79
Merge branch 'bug13315_squashed'
...
Conflicts:
src/or/buffers.c
2014-11-04 00:48:25 -05:00
Nick Mathewson
74cbd8d559
fix indentation
2014-11-04 00:46:32 -05:00
Nick Mathewson
254ab5a8de
Use correct argument types for inet_pton.
...
(I blame whoever decided that using a void* for a union was a good
idea.)
2014-11-04 00:45:14 -05:00
rl1987
51e2473618
Sending 'Not allowed' error message before closing the connection.
2014-11-04 00:37:24 -05:00
rl1987
fc9591da72
Adding changes file for 13315.
2014-11-04 00:37:24 -05:00
rl1987
0da4ddda4f
Checking if FQDN is actually IPv6 address string and handling that case.
2014-11-04 00:37:24 -05:00
rl1987
2f1068e68a
Adding helper function that checks if string is a valid IPv6 address.
2014-11-04 00:37:21 -05:00
rl1987
2862b769de
Validating SOCKS5 hostname more correctly.
2014-11-04 00:36:42 -05:00
rl1987
e8e45ff13e
Introducing helper function to validate IPv4 address strings.
2014-11-04 00:36:37 -05:00
rl1987
1ea9a6fd72
Introducing helper function to validate DNS name strings.
2014-11-04 00:35:43 -05:00
Nick Mathewson
593909ea70
Merge remote-tracking branch 'public/bug13214_025_squashed'
2014-11-04 00:24:56 -05:00
Nick Mathewson
b10e5ac7b8
Check descriptor ID in addition to HS ID when saving a v2 hs descriptor
...
Fixes bug 13214; reported by 'special'.
2014-11-04 00:24:15 -05:00
David Goulet
71355e1db9
Add comments and rename intro_nodes list in rend_services_introduce()
...
(No changes file needed: this patch just adds comments and renames
variables. This is ticket 13646. message taken from the ticket. -Nick)
2014-11-04 00:19:31 -05:00
Nick Mathewson
415a841378
Remove smartlist_choose_node_by_bandwidth()
...
We were only using it when smartlist_choose_node_by_bandwidth_weights
failed. But that function could only fail in the presence of
buggy/ancient authorities or in the absence of a consensus. Either
way, it's better to use sensible defaults and a nicer algorithm.
2014-11-03 13:30:19 -05:00
Nick Mathewson
a142fc29af
Use tor_malloc_zero(x), not tor_calloc(x,sizeof(char))
...
(Also, fixes a wide line.)
2014-11-02 12:08:51 -05:00
Nick Mathewson
1b93195a81
Merge branch 'calloc2'
2014-11-02 12:03:11 -05:00
Nick Mathewson
bbd8d07167
Apply new calloc coccinelle patch
2014-11-02 11:56:02 -05:00
Nick Mathewson
ded33cb2c7
Use the | trick to save a comparison in our calloc check.
2014-11-02 11:54:42 -05:00
Nick Mathewson
0d8abf5365
Switch to a < comparison for our calloc check; explain how it works
2014-11-02 11:54:42 -05:00
