nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-11 13:43:47 +01:00
Code Issues Packages Projects Releases Wiki Activity
23,723 Commits 53 Branches 630 Tags 125 MiB
a23fd15786
Commit Graph

876 Commits

Author SHA1 Message Date
Hans Jerry Illikainen
a23fd15786 Fix unreachable heap corruption in base64_decode() 
Give size_mul_check() external linkage and use it in base64_decode() to
avoid a potential integer wrap.

Closes #19222
 2016-12-23 09:47:09 -05:00
Nick Mathewson
2cee38f76a Merge branch 'prop271_030_v1_squashed' 2016-12-16 11:20:59 -05:00
teor
1e8f68a9c7 Add an extra warning message to check_private_dir 2016-12-01 09:51:19 -05:00
Nick Mathewson
539eba0a4b Teach parse_iso_time about the spaceless variant. 
(We previously added support for generating the spaceless
2016-11-14T19:58:12 variant, but not for actually parsing it.)
 2016-11-30 14:42:52 -05:00
Fabian Keil
db2dd8434e finish_writing_to_file_impl(): Remove temporary file if replacing the existing one failed 
Signed-off-by: David Goulet <dgoulet@torproject.org>
 2016-11-16 11:25:26 -05:00
Nick Mathewson
3e3040a5d9 Merge branch 'maint-0.2.9' 
Conflicts:
	src/or/rendservice.c
 2016-11-07 16:31:40 -05:00
teor
2f48693663
Improve comments in check_private_dir and onion poisoning 
Comment changes only
 2016-11-02 14:11:26 +11:00
overcaffeinated
265d5446fa Automated change to use smartlist_add_strdup 
Use the following coccinelle script to change uses of
smartlist_add(sl, tor_strdup(str)) to
smartlist_add_strdup(sl, string) (coccinelle script from nickm
via bug 20048):

@@
expression a;
expression b;
@@
- smartlist_add
+ smartlist_add_strdup
   (a,
- tor_strdup(
   b
- )
  )
 2016-10-27 10:26:06 +01:00
overcaffeinated
b8b8b6b70e Add implementation of smartlist_add_strdup 
Add smartlist_add_strdup(sl, string) - replaces the use of
smartlist_add(sl, tor_strdup(string)). Fixes bug 20048.
 2016-10-27 10:12:28 +01:00
Nick Mathewson
af70e43131 Merge remote-tracking branch 'public/spaces_in_unix_addrs' 2016-10-14 10:21:41 -04:00
paolo.ingls@gmail.com
ab78a4df93 torrc parsing b0rks on carriage-return 
(Specifically, carriage return after a quoted value in a config
line. Fixes bug 19167; bugfix on 0.2.0.16-alpha when we introduced
support for quoted values. Unit tests, changes file, and this
parenthetical by nickm.)
 2016-10-11 09:25:22 -04:00
Nick Mathewson
05aed5b635 Allow a unix: address to contain a C-style quoted string. 
Feature 18753 -- all this to allow spaces.
 2016-10-04 15:43:20 -04:00
Nick Mathewson
64521a9d35 Merge remote-tracking branch 'public/solaris_warnings_028' 2016-09-11 16:52:24 -04:00
Nick Mathewson
5927ed8d33 checkSpace.pl now forbids more identifiers. 
The functions it warns about are:
  assert, memcmp, strcat, strcpy, sprintf, malloc, free, realloc,
  strdup, strndup, calloc.

Also, fix a few lingering instances of these in the code. Use other
conventions to indicate _intended_ use of assert and
malloc/realloc/etc.
 2016-09-06 12:35:37 -04:00
Nick Mathewson
dffc6910b1 Three more -Wshadow fixes. 2016-07-28 11:24:03 -04:00
Nick Mathewson
94bff894f9 Fix a large pile of solaris warnings for bug 19767. 
In nearly all cases, this is a matter of making sure that we include
orconfig.h before we include any standard c headers.
 2016-07-28 10:47:46 -04:00
Nick Mathewson
9fe6fea1cc Fix a huge pile of -Wshadow warnings. 
These appeared on some of the Jenkins platforms. Apparently some
GCCs care when you shadow globals, and some don't.
 2016-07-28 10:22:10 -04:00
Nick Mathewson
a8676b1ede Merge branch 'bug18902_squashed' 2016-07-28 06:59:03 -04:00
Nick Mathewson
4757303873 Fix all -Wshadow warnings on Linux 
This is a partial fix for 18902.
 2016-07-28 06:58:44 -04:00
Nick Mathewson
09c25697d7 Add a function to simplify a fraction. 
Apparently remembering euclid's algorithm does pay off sooner or later.
 2016-07-26 11:23:34 -04:00
Nick Mathewson
fb7f90c181 Tweaks on 19435 fix: 
* Raise limit: 16k isn't all that high.
   * Don't log when limit exceded; log later on.
   * Say "over" when we log more than we say we log.
   * Add target version to changes file
 2016-07-26 09:59:48 -04:00
Ivan Markin
77459b97aa Fix integer overflow in the rate-limiter (#19435). 2016-07-26 09:49:40 -04:00
Nick Mathewson
1135405c8c Fix a variable-shadowing bug in check_private_dir 
We introduded a shadowed variable, thereby causing a log message to
be wrong. Fixes 19578. I believe the bug was introduced by
54d7d31cba in 0.2.2.29-beta.
 2016-07-05 13:43:58 -04:00
Nick Mathewson
aaa3129043 Merge remote-tracking branch 'dgoulet/ticket16943_029_05-squashed' 
Trivial Conflicts:
	src/or/or.h
	src/or/routerparse.c
 2016-07-01 15:29:05 -04:00
Nick Mathewson
c6846d7bf0 Merge remote-tracking branch 'andrea/bug18322_v3_squashed' 2016-06-30 11:18:00 -04:00
Andrea Shepard
f99c9df02b Make things mockable for dump_desc_populate_fifo_from_directory() unit test 2016-06-30 07:03:26 +00:00
Andrea Shepard
42f089473a Unit test for dump_desc_populate_one_file() 2016-06-30 07:03:26 +00:00
Andrea Shepard
38cced90ef Move unparseable descriptor dumps into subdirectory of DataDir 2016-06-30 07:03:25 +00:00
Andrea Shepard
17ed2fed68 Expose dump_desc() to the test suite and make things it calls mockable 2016-06-30 07:03:24 +00:00
teor (Tim Wilson-Brown)
aae14f8346
Fix bug19483: avoid range checks when they are always true 
Some compilers are smart enough to work out that comparisons to
LONG_MAX are a no-op on L64.
 2016-06-30 09:29:14 +10:00
teor (Tim Wilson-Brown)
4234ca3bf2
Improve overflow checks in tv_udiff and tv_mdiff 
Validate that tv_usec inputs to tv_udiff and tv_mdiff are in range.

Do internal calculations in tv_udiff and tv_mdiff in 64-bit,
which makes the function less prone to integer overflow,
particularly on platforms where long and time_t are 32-bit,
but tv_sec is 64-bit, like some BSD configurations.

Check every addition and subtraction that could overflow.
 2016-06-29 17:23:24 +10:00
teor (Tim Wilson-Brown)
2e51608a8b
Fix an integer overflow bug in the tv_mdiff range check 
The temporary second used for rounding can cause overflow,
depending on the order the compiler performs the operations.
 2016-06-29 12:53:50 +10:00
David Goulet
9744a40f7a Add tor_htonll/ntohll functions 
Signed-off-by: David Goulet <dgoulet@ev0ke.net>
 2016-06-20 15:26:58 -04:00
Nick Mathewson
1160ac1283 Changes file for 19063; use the BUG macro 2016-06-19 12:38:15 -04:00
U+039b
58e6a6aaeb Fix #19063: Add check in utility macro 2016-06-19 12:34:49 -04:00
cypherpunks
94762e37b9 Use the Autoconf macro AC_USE_SYSTEM_EXTENSIONS 
The Autoconf macro AC_USE_SYSTEM_EXTENSIONS defines preprocessor macros
which turn on extensions to C and POSIX. The macro also makes it easier
for developers to use the extensions without needing (or forgetting) to
define them manually.

The macro can be safely used because it was introduced in Autoconf 2.60
and Tor requires Autoconf 2.63 and above.
 2016-06-17 10:17:44 -04:00
Nick Mathewson
a8c766220f Mark an abort() as unreachable. 2016-06-16 15:53:05 -04:00
Nick Mathewson
128ab31c64 Mark code unreachable in unescape_string() 
Also, add tests for it in case someday it does become reachable.
 2016-06-16 15:36:08 -04:00
Nick Mathewson
5c596cdbc0 Tests for message rate-limiting 
Also note a bug in the rate-limiting message.
 2016-06-16 11:54:50 -04:00
Nick Mathewson
9b0bd65f22 I believe I found some dead code in our time parsing functions 2016-06-16 11:14:12 -04:00
Nick Mathewson
79370914d1 tests for size_mul_check__() 
it's important, and we should make sure we got it right.
 2016-06-16 10:43:01 -04:00
Nick Mathewson
41cb26c169 Correct the rounding behavior on tv_mdiff. 
Fix for bug 19428.
 2016-06-16 10:16:04 -04:00
Nick Mathewson
d1ab295d7b add LCOV_EXCL for unreachable exit() blocks in src/common 2016-06-16 09:50:52 -04:00
Nick Mathewson
7b54d7ebbd Mark src/common tor_assert(0)/tor_fragile_assert() unreached for coverage 
I audited this to make sure I was only marking ones that really
should be unreachable.
 2016-06-15 17:28:26 -04:00
Nick Mathewson
493499a339 Add -Wfloat-conversion for GCC >= 4.9 
This caught quite a few minor issues in our unit tests and elsewhere
in our code.
 2016-06-11 10:11:52 -04:00
Nick Mathewson
ce1dbbc4fd Enable the -Waggregate-return warning 
Suppress it in the one spot in the code where we actually do want to
allow an aggregate return in order to call the mallinfo() API.
 2016-05-27 11:26:14 -04:00
Nick Mathewson
f2205071f0 Remove round_int64_to_next_multiple_of: It is now unused. 2016-05-19 21:21:24 -04:00
Nick Mathewson
7bc9d1e002 Merge branch 'maint-0.2.8' 2016-05-12 15:33:56 -04:00
Nick Mathewson
e8cc9f3edf Merge branch 'maint-0.2.7' into maint-0.2.8 2016-05-12 15:33:47 -04:00
Nick Mathewson
4165b1a0da Merge branch 'bug18977_026_v2' into maint-0.2.7 2016-05-12 15:33:35 -04:00