23707 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Nick Mathewson	62477906e9	Fix remaining case of circpathbias inspecting entryguard internals	2016-11-30 14:42:52 -05:00
Nick Mathewson	823357dbe4	Add an entry_guard_describe() function ... This function helpfully removes all but one remaining use of an entry_guard_t private field in pathbias.c	2016-11-30 14:42:52 -05:00
Nick Mathewson	be447bc770	Move path-bias fields into a separate structure ... (Other than the field movement, the code changes here are just search-and-replace)	2016-11-30 14:42:52 -05:00
Nick Mathewson	22f2f13f81	prop271: make entry_guard_t mostly-private ... The entry_guard_t structure should really be opaque, so that we can change its contents and have the rest of Tor not care. This commit makes it "mostly opaque" -- circpathbias.c can still see inside it. (I'm making circpathbias.c exempt since it's the only part of Tor outside of entrynodes.c that made serious use of entry_guard_t internals.)	2016-11-30 14:42:52 -05:00
teor	04f7944891	Stop discarding downloaded full descriptors when using microdescs for circuits ... This affects clients with FetchUselessDescriptors 1. It might also cause subtle bugs on directory mirrors and authorities, causing them to consider all full descriptors as failed or old.	2016-11-30 12:20:28 +11:00
teor	e061cf4d1d	Remove an unneccessary FetchUselessDescriptors check in client_would_use_router	2016-11-30 11:43:04 +11:00
teor	24e293c3c6	Man page update and changes file for 20667	2016-11-30 11:18:38 +11:00
teor	65d793fab2	Fetch unknown certificates if FetchUselessDescriptors is true	2016-11-30 11:07:48 +11:00
teor	e5c608e535	Stop discarding consensus flavors and descriptors we wanted to fetch ... Instead, fetch and store consensus flavors and descriptors we wanted to fetch. And serve them if we are a directory cache (or authority).	2016-11-30 11:06:36 +11:00
s7r	215cc0d527	Improve log messages related to identity key ... Improve the messages logged when Tor wants or needs to load the master ed25519 identity key so the user is explicitly informed when further action is required or not. Fixes ticket #20650.	2016-11-27 13:07:43 +00:00
Chelsea H. Komlo	1ca777474b	adds changes file	2016-11-24 12:15:00 -05:00
Chelsea H. Komlo	e01b09d5ce	crypto_digest512 returns expected error value of -1	2016-11-24 12:14:54 -05:00
Chelsea H. Komlo	9d9110f65d	crypto_digest256 returns expected error value of -1	2016-11-24 12:13:07 -05:00
Chelsea H. Komlo	276d07a88a	crypto_digest returns expected error value of -1	2016-11-24 10:01:03 -05:00
Chelsea H. Komlo	2331e70d2d	fix up spacing/style in needs_circuits_for_build	2016-11-24 09:33:40 -05:00
Chelsea H. Komlo	f83ed31089	adding better comments for defines	2016-11-24 09:33:38 -05:00
Chelsea H. Komlo	b252773fe9	re-add check for if circuit is an origin circuit	2016-11-24 09:33:32 -05:00
Chelsea H. Komlo	c86bbdd3ae	adding documentation to extracted unit test helper	2016-11-24 08:12:36 -05:00
Chelsea H. Komlo	118bba7622	Refactor to remove unnecessary check in circuit_is_available_for_use	2016-11-24 08:12:33 -05:00
Chelsea H. Komlo	cfb8363da9	extract magic numbers in circuituse.c	2016-11-24 08:12:32 -05:00
Chelsea H. Komlo	afb6ae7b0f	Refactor circuit_predict_and_launch_new	2016-11-24 08:12:30 -05:00
Chelsea H. Komlo	b95998ef0c	moving useful test helper to test_helpers.h	2016-11-24 08:12:27 -05:00
Nick Mathewson	16fcbd21c9	Try to work around breakage in the OSX 10.12 SDK. ... Apple is supposed to decorate their function declarations with macros to indicate which OSX version introduced them, so that you can tell the compiler that you want to build against certain versions of OSX. But they forgot to do that for clock_gettime() and getentropy(), both of which they introduced in 10.12. This patch adds a kludge to the configure.ac script where, if we detect that we are targeting OSX 10.11 or earlier, we don't even probe to see if the two offending functions are present. Closes ticket 20235.	2016-11-22 19:24:13 -05:00
Nick Mathewson	4614f8e681	Merge remote-tracking branch 'teor/fix-mingw-pagesize'	2016-11-22 18:29:50 -05:00
Nick Mathewson	c35d481f56	Merge branch 'maint-0.2.9'	2016-11-21 12:44:21 -05:00
Nick Mathewson	e2c881487c	Merge remote-tracking branch 'arma/bug20423' into maint-0.2.9	2016-11-21 12:40:08 -05:00
overcaffeinated	6dc25e79b9	Fix typo ... Remove stray 'To run'	2016-11-21 12:15:44 -05:00
teor	1d1d37bbc6	Refactor rend_service_check_dir_and_add ... Make the function flatter, and prepare for #20559. No behaviour change.	2016-11-18 13:35:54 +11:00
teor	8bdedab8da	Refactor duplicate code out of rend_config_services ... Put that code in rend_service_check_dir_and_add. No behaviour change. This is a defence in depth measure against similar bugs to 20529.	2016-11-18 13:35:09 +11:00
teor	98057d274c	Create HS directories in rend_config_services, then check before use ... (We only create HS directories if we are acting on the config.) Log a BUG warning if the directories aren't present immediately before they are used, then fail.	2016-11-18 13:34:24 +11:00
Nick Mathewson	ded58777c5	Merge remote-tracking branch 'dgoulet/bug20629_030_01'	2016-11-17 20:12:13 -05:00
Nick Mathewson	b5d738e481	Merge remote-tracking branch 'public/bug20558'	2016-11-17 20:10:40 -05:00
Nick Mathewson	a742637f5a	Merge remote-tracking branch 'public/bug20630'	2016-11-17 20:09:44 -05:00
Nick Mathewson	427dcb29b5	Merge branch 'maint-0.2.9'	2016-11-17 20:08:15 -05:00
Nick Mathewson	b7db39e88a	Merge remote-tracking branch 'dgoulet/bug20646_030_01'	2016-11-17 20:08:00 -05:00
Ivan Markin	fe711c2944	Fix and simplify error handling code in rend_service_parse_port_config()	2016-11-17 20:06:37 -05:00
Ivan Markin	a847e16cbb	Fix comment for rend_service_parse_port_config()	2016-11-17 20:05:19 -05:00
Nick Mathewson	8a767ba7fb	Merge remote-tracking branch 'teor/bug20634_029' into maint-0.2.9	2016-11-17 20:02:59 -05:00
Roger Dingledine	f12aad7f09	don't attempt a resolve when the cached answer will do ... For relays that don't know their own address, avoid attempting a local hostname resolve for each descriptor we download. Also cut down on the number of "Success: chose address 'x.x.x.x'" log lines. Fixes bugs 20423 and 20610; bugfix on 0.2.8.1-alpha.	2016-11-16 16:22:11 -05:00
Roger Dingledine	3bb40b213b	refactor router_pick_published_address to have another arg ... no change in behavior except fewer log entries in the case where we use a cached result.	2016-11-16 16:13:03 -05:00
David Goulet	6b13612eef	doc: Add change file for bug #20646 ... Signed-off-by: David Goulet <dgoulet@torproject.org>	2016-11-16 11:28:24 -05:00
Fabian Keil	db2dd8434e	finish_writing_to_file_impl(): Remove temporary file if replacing the existing one failed ... Signed-off-by: David Goulet <dgoulet@torproject.org>	2016-11-16 11:25:26 -05:00
teor	44f3563d87	Changes file for bug 20634	2016-11-16 13:14:03 +11:00
teor	150a2b39b0	fixup! Add expect_log_msg_containing_either3() and expect_log_msg_containing_either4() ... Fix typos: * extra '(' * use assert_log_predicate (without 3 or 4 at the end) Tidy whitespace. Wrap long lines.	2016-11-16 13:14:00 +11:00
Neel Chauhan	0825fc6af9	Add all four error messages to test_address_get_if_addrs6_list_no_internal()	2016-11-16 12:57:13 +11:00
Neel Chauhan	01492d3869	Add all four error messages to test_address_get_if_addrs6_list_internal()	2016-11-16 12:57:09 +11:00
Neel Chauhan	cccc08ad56	Add expect_log_msg_containing_either3() and expect_log_msg_containing_either4()	2016-11-16 12:57:05 +11:00
Nick Mathewson	9a790f7325	Merge branch 'maint-0.2.9'	2016-11-14 10:37:29 -05:00
Fabian Keil	caf7422871	Fix grammar in HiddenServiceSingleHopMode description	2016-11-14 10:28:02 -05:00
Nick Mathewson	307d244640	Fix a "shouldn't have reached this" warning in connection_edge.c ... This was bug 20630; bugfix on f3e158ed where I thought I was committing a documentation-only fix but instead messed up the control flow too.	2016-11-14 09:16:57 -05:00