nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-14 07:03:44 +01:00
Code Issues Packages Projects Releases Wiki Activity
6,451 Commits 53 Branches 630 Tags 125 MiB
9af3175687
Commit Graph

4302 Commits

Author SHA1 Message Date
Peter Palfrader
521c006fd5 Remove .cvsignore files from trunk 
svn:r6891
 2006-07-25 01:00:48 +00:00
Roger Dingledine
c9b8458f59 publish a new descriptor after we hup. this is important if our 
config has changed such that we'll want to start advertising our
dirport now, etc.


svn:r6819
 2006-07-23 11:50:03 +00:00
Nick Mathewson
d27cbf5d4b Fix another segfault in assert_circuit_ok. 
svn:r6818
 2006-07-23 08:13:45 +00:00
Nick Mathewson
7239262f71 Don't tell anybody, but we're going OO here. This patch splits 
circuit_t into origin_circuit_t and or_circuit_t.  I fixed some
segaults; there may be more.  We still need to move more rendezvous
stuff into subtypes.

This is a trial run for splitting up connection_t; if the approach is
insane, please say so soon so we can do something smarter.

Also, this discards the old HALF_OPEN code, which nobody seems to
want.


svn:r6817
 2006-07-23 07:37:35 +00:00
Nick Mathewson
6d2eb77555 Whitespace fix 
svn:r6816
 2006-07-23 07:19:49 +00:00
Roger Dingledine
40cc536307 rewrite conn->address for GET commands as well as POST commands. 
svn:r6815
 2006-07-23 06:41:02 +00:00
Roger Dingledine
0b5ad1bcfb use tor_mem_is_zero() in more places. 
svn:r6814
 2006-07-23 05:52:27 +00:00
Nick Mathewson
4280218a42 Delete trailing whitespace in eventdns.c 
svn:r6813
 2006-07-23 05:40:24 +00:00
Nick Mathewson
1c0f02f657 Add (void) lines for unused parameters in eventdns.c 
svn:r6812
 2006-07-23 05:39:37 +00:00
Nick Mathewson
f4e506f423 Remove STRUCT_OFFSET from config.c 
svn:r6811
 2006-07-23 05:33:10 +00:00
Nick Mathewson
35960e1162 Add a mem_is_zero function (I think we will need this) and a STRUCT_OFFSET macro (we already need this). 
svn:r6810
 2006-07-23 05:32:35 +00:00
Roger Dingledine
ee789052b8 whitespace and docs 
svn:r6808
 2006-07-23 05:18:29 +00:00
Roger Dingledine
00aefaab6b think harder about my logic 
svn:r6806
 2006-07-22 07:19:11 +00:00
Roger Dingledine
2d6a4d283b i lied, that won't work at all. maybe this will. 
svn:r6805
 2006-07-22 07:15:34 +00:00
Roger Dingledine
444f096d2d more bulletproof reachability testing 
svn:r6804
 2006-07-22 05:29:31 +00:00
Nick Mathewson
64c14d8ce3 These asserts will either cause spurious crashes or help debug the pend->conn->s == -1 issue. 
svn:r6803
 2006-07-21 22:02:58 +00:00
Nick Mathewson
08a4114abf Another MSVC6 fix. Grnk. 
svn:r6802
 2006-07-21 14:53:23 +00:00
Roger Dingledine
2249180b60 bugfix: if you find yourself reachable, then don't ever make any client 
requests (so you stop predicting circuits), then hup, then later your
IP changes, you won't think circuits are working so you won't try to
test reachability, so you won't publish.


svn:r6800
 2006-07-21 07:55:35 +00:00
Roger Dingledine
4d5fab4f9a tweak 
svn:r6799
 2006-07-21 07:53:21 +00:00
Roger Dingledine
9283ddb760 an entry guard that is "unlisted", as well as not known to be "down", is 
not therefore "up".


svn:r6798
 2006-07-21 07:06:18 +00:00
Roger Dingledine
237c7ecbfd tweak 
svn:r6796
 2006-07-20 23:45:26 +00:00
Roger Dingledine
97a14b2018 tweak 
svn:r6795
 2006-07-20 23:33:11 +00:00
Roger Dingledine
db657ea0af don't squeal if the first few retries fail. 
svn:r6791
 2006-07-18 04:48:59 +00:00
Roger Dingledine
892f671f59 Define a schedule for how long to wait between retrying 
application connections. Rather than waiting a fixed amount of
time between each retry, we wait only 5 seconds for the first,
10 seconds for the second, and 15 seconds for each retry after
that. Hopefully this will improve the expected experience.

Addresses bug 297.


svn:r6790
 2006-07-18 04:42:32 +00:00
Roger Dingledine
e1f30a5f21 when we find our dirport to be reachable, mark our descriptor 
dirty so we'll tell the world. (fixes bug 306 reported by pnx)


svn:r6787
 2006-07-18 03:06:55 +00:00
Roger Dingledine
ac258d2cc8 Start publishing one minute or so after we find our ORPort 
to be reachable. This will help reduce the number of descriptors
we have for ourselves floating around, since it's quite likely
other things (e.g. DirPort) will change during that minute too.


svn:r6786
 2006-07-18 03:06:12 +00:00
Nick Mathewson
7fcb267e24 Oh. And apparently, msvc6 doesnt think very much of doing u64-and-double arithmetic either. 
svn:r6785
 2006-07-18 02:24:01 +00:00
Nick Mathewson
77c28d112b Hm. We probably should define INT64_MAX if we really want it. (Especially since we only want it on one platform, where, coincidentally, it is not defined.) 
svn:r6784
 2006-07-18 02:01:32 +00:00
Roger Dingledine
388ac4126a If we are using an exit enclave and we can't connect, e.g. because 
its webserver is misconfigured to not listen on localhost, then back
off and try connecting from somewhere else before we fail.


svn:r6783
 2006-07-18 00:59:46 +00:00
Roger Dingledine
a8444c6f53 pick a log domain; resolve an xxxx 
svn:r6782
 2006-07-18 00:01:12 +00:00
Roger Dingledine
c85745cfe2 parameterize the loudness of log_addr_has_changed(), since it's the 
only place where we inform the user of a new IP address, if we're
guessing it from external sources.


svn:r6780
 2006-07-17 19:33:54 +00:00
Roger Dingledine
542adb88d7 Make a louder statement the first time we learn a guessed 
IP address.


svn:r6779
 2006-07-17 08:17:51 +00:00
Roger Dingledine
c055a34cdb huge bugfix: we weren't ever writing an http header when sending 
out network statuses! so clients were downloading the whole thing,
and then discarding them because they're malformed.


svn:r6778
 2006-07-17 08:11:27 +00:00
Roger Dingledine
a2a89da693 and don't try to build the descriptor every second, if it's dirty 
but we don't have a known address.


svn:r6777
 2006-07-17 06:59:56 +00:00
Roger Dingledine
42e2057d67 fix some more places where we shouldn't crash if we can't build 
our own descriptor yet.


svn:r6775
 2006-07-17 06:54:28 +00:00
Roger Dingledine
9db7b2c068 Allow servers with no hostname or IP address to learn their IP address 
by asking the directory authorities. This code only kicks in when you
would normally have exited with a "no address" error.

This design is flawed, though, since the X-Your-Address-Is header is not
authenticated, and doing it this way introduces too many new attacks. The
right answer is to give IP address hints inside the HELLO cell; much of
this code can be reused when we switch.


svn:r6774
 2006-07-17 06:35:06 +00:00
Nick Mathewson
e572d5990c MSVC6 is apparently terrified of unnatural cross-breeding between uint64_t and double, and needs more persuasion than usual to cast one to the other. Issue identified by Frediano Ziglio; patch revised for minimal impact on non-MSVC6 compilers. 
svn:r6768
 2006-07-17 00:39:05 +00:00
Roger Dingledine
886b10bbe2 whitespace/etc cleanups 
svn:r6765
 2006-07-16 05:57:11 +00:00
Roger Dingledine
ee5f512e13 parameterize the loudness of resolve_my_address(), and call things 
IP addresses, not IPs.


svn:r6764
 2006-07-15 20:26:05 +00:00
Roger Dingledine
3d79eb52ab stick to nick's nul/null convention 
svn:r6763
 2006-07-15 19:21:30 +00:00
Roger Dingledine
c4411841d2 Avoid an integer underflow when the dir authority decides whether a 
router is stable: we might wrongly label it stable, and compute a slightly
wrong median stability, when a descriptor is published later than now.

Inspired by Matt's Vidalia checkin:
http://trac.vidalia-project.net/changeset/1074


svn:r6758
 2006-07-14 03:14:02 +00:00
Nick Mathewson
a0cf95e1c9 Add some debugging asserts to dns.c; these are too expensive to leave in permanently. 
svn:r6756
 2006-07-11 20:51:58 +00:00
Nick Mathewson
c32e19b4ed OR_CONN_EVENT_NEW: we should probably handle that , should we not? Especially since 23:26 < phobos> nickm: grep -c "Unrecognized status code 4" tor.log 
svn:r6752
 2006-07-11 03:33:16 +00:00
Nick Mathewson
39344fc301 Add a const; fix a (probably harmless) bug when storing a resolve we forgot we asked for. 
svn:r6751
 2006-07-10 18:38:57 +00:00
Nick Mathewson
28a7c8a64c Make compilation work on old MSVCs without GetVertsionEx magic. Patch from Frediano Ziglio. 
svn:r6749
 2006-07-09 22:29:12 +00:00
Nick Mathewson
a7a1d4e3d3 First part of making mmap-based stuff work on win32: save descriptors as "binary" (no LF->CRLF tanslation) so that we can mmap them properly later. Patch from Frediano Ziglio. 
svn:r6748
 2006-07-09 22:28:12 +00:00
Roger Dingledine
51454157a0 Fix a crash if you enable FascistFirewall but not FirewallPorts. 
Reported by Frediano Ziglio.


svn:r6746
 2006-07-08 17:38:46 +00:00
Nick Mathewson
0bbc4aca9b Spellcheck and remove spurious include in eventdns.c 
svn:r6745
 2006-07-07 19:08:44 +00:00
Nick Mathewson
a40ad152b1 When using eventdns: suppress logging of addresses when SafeLogging is active, and make set of nameservers configurable from torrc. 
svn:r6744
 2006-07-07 17:33:30 +00:00
Nick Mathewson
f33c4f9781 eventdns: check for malloc() failures. 
svn:r6743
 2006-07-07 17:31:56 +00:00
Roger Dingledine
85fd582192 rename X-You-Are to something slightly better. 
svn:r6735
 2006-07-06 03:05:01 +00:00
Roger Dingledine
7f01dc9c1c whitespace/tab fixes 
svn:r6734
 2006-07-06 02:45:46 +00:00
Roger Dingledine
fad85f173a when an exit node gets a malformed begin cell, don't complain to 
the node operator, since he can't do anything about it.


svn:r6733
 2006-07-06 02:44:07 +00:00
Nick Mathewson
3c4205c872 Clean up eventdns messages. 
svn:r6730
 2006-07-05 21:42:18 +00:00
Nick Mathewson
54779025e2 Spelling fix. 
svn:r6729
 2006-07-05 21:33:46 +00:00
Nick Mathewson
42ef3bd90c Add plausile logging support to eventdns; stop putting stuff onto stdout. 
svn:r6728
 2006-07-05 21:28:37 +00:00
Roger Dingledine
0ec293b189 actually, that excludenodes fix was redundant. take it out. 
svn:r6727
 2006-07-05 18:19:42 +00:00
Roger Dingledine
98c6bf6192 oops, we were ignoring options->ExcludeNodes when picking entry guards. 
it is still the case that we ignore it with respect to entry guards
that we've already picked.


svn:r6726
 2006-07-04 20:25:17 +00:00
Roger Dingledine
4fc7426b93 Make the X-You-Are header more accurate when there's a proxy in the middle. 
svn:r6722
 2006-07-04 18:18:08 +00:00
Roger Dingledine
12cc290a7d ok, i'm not allowed to say that there. oh well. 
svn:r6720
 2006-07-04 16:11:35 +00:00
Roger Dingledine
579849f600 fix a misleading function comment 
svn:r6717
 2006-07-04 15:52:22 +00:00
Roger Dingledine
5dc1e6f788 if we're the server-side of the tls and there are problems, 
don't yell as loudly.


svn:r6716
 2006-07-04 15:51:59 +00:00
Roger Dingledine
05d0b70573 Get rid of the router_retry_connections notion. Now routers no longer 
try to rebuild long-term connections to directory authorities, and
directory authorities no longer try to rebuild long-term connections to
all servers.

We still don't hang up connections in these two cases though -- we need
to look at it more carefully to avoid flapping, and we likely need to
wait til 0.1.1.x is obsolete.


svn:r6712
 2006-07-04 03:31:27 +00:00
Roger Dingledine
ff1b4764e9 No longer permit create cells to have the wrong circ_id_type. No 
running Tors should still have this bug.


svn:r6711
 2006-07-04 03:27:09 +00:00
Roger Dingledine
35e95d7783 minor fixes 
svn:r6710
 2006-07-04 03:25:07 +00:00
Roger Dingledine
dc79dd6a46 minor fixes 
svn:r6709
 2006-07-04 03:19:59 +00:00
Nick Mathewson
9fce316d1c Oops. Headers work better when named right. 
svn:r6707
 2006-07-01 21:51:21 +00:00
Nick Mathewson
60de51993a Unify HTTP response code into one place so it is easier to add headers. Add an X-You-Are header, which we should probably rename. NOTE that we should not use this field for things where it matters if dirs lie. 
svn:r6705
 2006-06-30 10:50:43 +00:00
Roger Dingledine
d45757ebcb also remove word 'middleman' from a log notice 
svn:r6704
 2006-06-29 13:11:23 +00:00
Roger Dingledine
1f407c174d remove the word 'middleman' from the sample torrc 
svn:r6703
 2006-06-29 13:10:08 +00:00
Nick Mathewson
475eb5d6fe Apparent 311 fix: apparently passing Z_FINISH an empty string is problematic. 
svn:r6702
 2006-06-29 11:19:52 +00:00
Nick Mathewson
05eff35ac6 Harmless: Z_OK is not an acceptable answer to Z_FINISH. 
svn:r6701
 2006-06-29 11:17:36 +00:00
Nick Mathewson
4b49d298eb complete_only == !allow_partial. This enables useful use of partial desc downloads. Backport candidate 
svn:r6700
 2006-06-29 11:04:42 +00:00
Roger Dingledine
c22c7b96f5 tab-man strikes again 
svn:r6699
 2006-06-28 15:39:02 +00:00
Nick Mathewson
8b08ab52fd Fix another idiot bug causing symptom 309. Why cant I program? 
svn:r6698
 2006-06-28 15:36:28 +00:00
Nick Mathewson
96bfefeeb6 Add a check to try to make cache rebuild fail fast if it is going to fail 
svn:r6697
 2006-06-28 11:03:34 +00:00
Nick Mathewson
4dac383f5a Aaand re-disable the bogus test in get_body() 
svn:r6696
 2006-06-28 08:57:41 +00:00
Nick Mathewson
d547ecc916 Make sure that our calculated offsets for routers is correct; again. This time bug 309 may be gone gone gone. 
svn:r6695
 2006-06-28 08:55:53 +00:00
Nick Mathewson
1cd04abf1a Actually enable mmap. That should improve matters. 
svn:r6694
 2006-06-28 08:54:32 +00:00
Nick Mathewson
d3784ff1df Likely fix for bug 309: when we calculate offsets after rebuilding the descriptor cache, do not reset the offset pointer half-way through. 
svn:r6693
 2006-06-27 15:52:51 +00:00
Roger Dingledine
f88d555ce0 refuse to write an iso_time which we can't parse, when dumping 
bandwidth state. this fixes the particular incident in bug 308,
but the general issue remains.


svn:r6684
 2006-06-24 04:57:59 +00:00
Nick Mathewson
b4b8da5d23 Turn a while into a do/while; save a redundant test 
svn:r6683
 2006-06-24 02:10:21 +00:00
Nick Mathewson
06e09cdd47 Apparently, zlib sometimes reports Z_BUF_ERROR on input exhaustion as well as on running out of output space. This could well fix the assert bug reported by weasel and arma. 
svn:r6682
 2006-06-24 02:06:52 +00:00
Nick Mathewson
b82dfdd4a3 Make some more verbose gcc warnings go away. 
svn:r6680
 2006-06-22 07:34:04 +00:00
Nick Mathewson
06ffee3b67 Ooh, that could have been bad. Sort digests as digests, not strings. 
svn:r6679
 2006-06-22 07:29:14 +00:00
Nick Mathewson
52b8dfa95a Fix a bunch of spaces. 
svn:r6678
 2006-06-22 07:25:15 +00:00
Nick Mathewson
89a1453776 Set offset properly when parsing cache. 
svn:r6677
 2006-06-22 07:19:28 +00:00
Nick Mathewson
58b05fc84d #if out test that was failing because of an extra newline. 
svn:r6676
 2006-06-22 07:10:37 +00:00
Nick Mathewson
b7910202a3 Next batch of memory miserdom: mmap cached-routers file. This is sure to break somewhere. 
svn:r6675
 2006-06-22 07:01:54 +00:00
Nick Mathewson
e2697a62ac When requesting or serving resources via fingerprint/digest, request and respond in-order, removing duplicates. 
svn:r6673
 2006-06-21 04:57:12 +00:00
Peter Palfrader
7b6c435066 <nickm> ooh, that log shouldn't be there. can you take it out? 
svn:r6671
 2006-06-20 23:11:15 +00:00
Nick Mathewson
0799154ae1 Fix bug in networkstatus spooling: spool more than the first networkstatus. 
svn:r6670
 2006-06-20 23:06:52 +00:00
Nick Mathewson
0e09b26112 Fishy, but harmless. 
svn:r6669
 2006-06-20 16:48:32 +00:00
Roger Dingledine
ef78e4245f add a note for nick to fix 
svn:r6668
 2006-06-20 13:14:07 +00:00
Nick Mathewson
a9e1a4c33c Ah. We need a new zlib_state for each networkstatus we spool out. 
svn:r6667
 2006-06-20 06:27:13 +00:00
Nick Mathewson
4283b81a48 Start spooling v2 networkstatus docs as well. 
svn:r6664
 2006-06-20 00:48:23 +00:00
Nick Mathewson
3f7f069a05 Fix a tricky crash: making the_directory heap-allocated (so we could refcount it and have multiple instances as neeeded) means that calls to dirserv_regenerate_directory could invalidate the auth_dir value passed to dirserv_pick_cached_dir_obj. Big fun. 
svn:r6663
 2006-06-18 21:30:03 +00:00
Nick Mathewson
2552d5e60f Fix an assert that still isnt the assert we are hunting. 
svn:r6662
 2006-06-18 21:15:01 +00:00
Roger Dingledine
37c441d96f correct a function comment in compute_preferred_testing_list() 
svn:r6660
 2006-06-18 21:07:45 +00:00
Nick Mathewson
f1993b8b30 Become capable of noticing that we are done sending a directory. 
svn:r6659
 2006-06-18 20:58:27 +00:00
Nick Mathewson
5c0d7fb016 Resolve control flow warning. 
svn:r6658
 2006-06-18 20:39:46 +00:00
Nick Mathewson
0932f463ff Ah. That seems to work. 
svn:r6657
 2006-06-18 16:39:26 +00:00
Nick Mathewson
5ba72d0ae5 another write_to_buf_zlib fix. 
svn:r6656
 2006-06-18 16:20:38 +00:00
Nick Mathewson
b5c599412f Backport candidate: implement the "is this uptime change cosmetic" test properly. 
svn:r6654
 2006-06-18 16:05:54 +00:00
Nick Mathewson
a9cffd2ff0 Re-enable buffer RAM guard values. 
svn:r6653
 2006-06-18 15:53:54 +00:00
Nick Mathewson
11c2e97d51 Another _zlib fix. 
svn:r6652
 2006-06-18 09:03:48 +00:00
Nick Mathewson
337ad6420b Make connection_write_to_buf_zlib set outbuf_flushlen right. 
svn:r6651
 2006-06-18 08:53:09 +00:00
Nick Mathewson
537104c908 write_to_buf != connection_write_to_buf. Also, add a connection_write_to_buf_zlib wrapper that sucks. 
svn:r6650
 2006-06-18 08:46:55 +00:00
Nick Mathewson
10b7b57616 Temporarily disable sentinels on buffers 
svn:r6649
 2006-06-18 08:44:34 +00:00
Nick Mathewson
9376d901ed make zlib buffer function set buf_highwater properly 
svn:r6648
 2006-06-18 08:21:27 +00:00
Nick Mathewson
4d02ccfed8 Stop trying to refresh when we are out of data. 
svn:r6647
 2006-06-18 08:19:35 +00:00
Nick Mathewson
b9013cbe98 And actually check the url when it exists. that might work better. 
svn:r6646
 2006-06-18 08:16:05 +00:00
Nick Mathewson
c374340c70 That dir_refresh_src fix will only work if I enable it. 
svn:r6645
 2006-06-18 08:13:45 +00:00
Nick Mathewson
347bcec84a Fix a couple of bugs in last patch. 
svn:r6644
 2006-06-18 08:07:16 +00:00
Nick Mathewson
c58cc8c16c add coverage for a default case 
svn:r6643
 2006-06-18 07:57:47 +00:00
Nick Mathewson
b1a8b7869a Oops. conn->requested_resource is client only. 
svn:r6642
 2006-06-18 07:55:04 +00:00
Nick Mathewson
1d9923da7c Instead of adding servers and v1 directories to buffers en masse, directory servers add them on the fly as their outbufs are depleted. This will save ram on busy dirservers. 
svn:r6641
 2006-06-18 07:38:55 +00:00
Nick Mathewson
73ada60d64 remove non-germane comment 
svn:r6640
 2006-06-18 07:37:21 +00:00
Nick Mathewson
8fa8616ec7 Add tests for several of the more recently committed functions. 
svn:r6639
 2006-06-18 07:35:10 +00:00
Nick Mathewson
f83a628a76 perhaps the reason I rail against cut-and-paste programming so vehemently is that I am so bad at it. 
svn:r6638
 2006-06-18 07:32:31 +00:00
Nick Mathewson
cd38511a1e Part of incremental encryption logic for buffers: there is a subtle yucky point documented in a comment. 
svn:r6637
 2006-06-18 07:27:47 +00:00
Nick Mathewson
630e9cd510 Add some incremental encryption wrappers to torgzip code 
svn:r6636
 2006-06-18 07:24:29 +00:00
Nick Mathewson
af8096815e Add a memdup function to util 
svn:r6635
 2006-06-18 07:22:36 +00:00
Nick Mathewson
78428dccdb Add smartlist_reverse and smartlist_pop_last. 
svn:r6634
 2006-06-18 07:21:35 +00:00
Peter Palfrader
2ff24dbc26 And a minor bugfix to the weaselhack 
svn:r6629
 2006-06-15 23:14:01 +00:00
Roger Dingledine
af0e47c921 fix spacing 
svn:r6628
 2006-06-15 22:59:07 +00:00
Peter Palfrader
bc64becd12 Add a /tor/dir-all-weaselhack directory resource so I do not have to update my scripts 
svn:r6627
 2006-06-15 22:52:56 +00:00
Roger Dingledine
a4c315f3c3 fix recommended url in torrc.sample for server sign-up 
svn:r6626
 2006-06-15 22:32:00 +00:00
Roger Dingledine
4e4cc9aa27 lower the number of seconds before we yell about clock jump. 
and make the yelling only happen if you're a server.


svn:r6625
 2006-06-15 09:03:15 +00:00
Roger Dingledine
de7a9c83d8 upgrade the severity of the 'clock jump' warn, and ask people 
to report if it occurs.


svn:r6623
 2006-06-14 22:28:16 +00:00
Roger Dingledine
09dfe1b265 bugfix: discourage picking directory authorities as our TestVia 
hops, even if they're running the right versions, since we probably
already have a connection established to them.


svn:r6622
 2006-06-14 11:06:43 +00:00
Nick Mathewson
66db3afb74 eventdns: Apply a couple of patches from AGL; start working on windows compat; note some TODOs. 
svn:r6621
 2006-06-13 21:49:56 +00:00
Roger Dingledine
977574e48d back off and add the $ at the beginning of the preferrednodes list 
we generate.


svn:r6620
 2006-06-13 12:57:19 +00:00
Roger Dingledine
2cd349903c be more lax about recognizing valid hexdigests. 
svn:r6619
 2006-06-13 12:05:59 +00:00
Roger Dingledine
b4e415ba3c now we can tell dirserv_dump_directory_to_string() whether we want 
it to include down/invalid descriptors or not.


svn:r6618
 2006-06-13 11:11:19 +00:00
Roger Dingledine
88dadc917c bugfix in exit_policy_is_general_exit() that weasel found. 
this time for sure!


svn:r6617
 2006-06-13 10:48:26 +00:00
Roger Dingledine
23e2c6a7dd first cut at a workaround for the reachability bug: explicitly find a 
server running the right version, if we can, and ask for that one.


svn:r6616
 2006-06-13 10:25:22 +00:00
Roger Dingledine
31b51849b5 export the default exit policy via the control port, so controllers 
don't need to guess what it is / will be later.


svn:r6615
 2006-06-13 09:16:09 +00:00
Roger Dingledine
279e86f3c8 Defense in depth: fix the reachability bug a second way too. 
Now if we establish a connection with the right digest, regardless
of what the addr/port is, and we have pending create cells, use it.


svn:r6614
 2006-06-13 05:51:28 +00:00
Roger Dingledine
a20a384b09 harmless typo 
svn:r6613
 2006-06-13 05:50:24 +00:00
Roger Dingledine
ab61c40661 Fix the bug that was causing servers to not find themselves 
reachable if they changed IP addresses. This happened because
middle servers knew the old descriptor, and kept swapping the
addr/port we asked for with the one they thought was right.

So the create cell never got sent, because it was asking for a
different addr/port than we believed we had connected to.


svn:r6610
 2006-06-13 05:36:35 +00:00
Roger Dingledine
19408cf8d7 reintroduce the logic to exit_policy_is_general_exit() to count 
how many ports are allowd. require two ports open, not just one.


svn:r6609
 2006-06-13 02:48:06 +00:00
Peter Palfrader
cce8ae1190 Make the Exit tag in status documents actually work in head too 
svn:r6608
 2006-06-12 22:03:25 +00:00
Roger Dingledine
87e3800dfc Finally solve the "closing wedged cpuworkers" bug. Woo. 
This happened when we got two create cells in a row from the same TLS
connection. It would hand one to the cpuworker, and then immediately
handle the second one -- after it had registered that the first one was
busy, but before it had updated the timestamp that we use to decide how
*long* it's been busy.


svn:r6606
 2006-06-12 11:59:19 +00:00
Roger Dingledine
cbc4cd93ac allow people to start their tor with runasdaemon set but 
with no logs set at all.


svn:r6604
 2006-06-12 06:03:15 +00:00
Roger Dingledine
14687fc443 take out the reachability bandaid in 0.1.2.x as well. 
maybe we will actually be able to fix it, instead.


svn:r6585
 2006-06-10 00:57:12 +00:00
Roger Dingledine
889b8d5bac Add a new config option TestVia, that lets you specify preferred middle 
hops to use for testing circuits. Perhaps this will let me debug the
reachability problem better.


svn:r6581
 2006-06-10 00:26:39 +00:00
Nick Mathewson
1f585987c4 Another escape() fix, for picky sprintfs. 
svn:r6579
 2006-06-09 17:07:22 +00:00
Nick Mathewson
2936da4c28 Override our notion of printability for esc_for_log. 127 and up are never printable. Take that, locales. 
svn:r6578
 2006-06-09 15:57:58 +00:00
Roger Dingledine
6531a31aad actually, don't fix it that far. we should still do some 
error checking.


svn:r6576
 2006-06-09 09:07:59 +00:00
Roger Dingledine
0071d67efd when only one router is labelled as a guard, and we've 
already picked him, we would cycle endlessly picking him
again, being unhappy about it, and so forth.

now we specifically exclude guards when picking a new guard.


svn:r6575
 2006-06-09 09:02:32 +00:00
Roger Dingledine
30f6c57fd7 and forward-port too. 
svn:r6573
 2006-06-09 06:52:49 +00:00
Roger Dingledine
85d408a573 Bandaid for a seg fault i just got in 0.1.1.20. 
More generally, i reopened bug 222. Whee.


svn:r6571
 2006-06-09 06:35:45 +00:00
Roger Dingledine
a91be49402 fix a bootstrapping check we ignored that prevents us from running 
with only one dir authority.


svn:r6570
 2006-06-09 02:45:39 +00:00
Roger Dingledine
11dcb7f4ae try a better string at the top of torrc's autogenerated torrc. 
svn:r6569
 2006-06-09 02:20:42 +00:00
Roger Dingledine
bb18168fae ok, ok, maybe *this* time my rep_hist_circbuilding_dormant() will work. 
svn:r6568
 2006-06-08 22:36:13 +00:00
Roger Dingledine
18eb8192db remove a bit more obsolete code 
svn:r6566
 2006-06-08 09:35:20 +00:00
Roger Dingledine
a18766e50c ah, that explains why we weren't going dormant with 
respect to descriptor fetches. maybe now it will work.


svn:r6565
 2006-06-08 09:20:58 +00:00
Roger Dingledine
91bd12c20d re-enable per-connection rate limiting. get rid of the "OP bandwidth" 
concept. lay groundwork for "bandwidth classes" -- separate global
buckets that apply depending on what sort of conn it is.


svn:r6563
 2006-06-07 09:18:53 +00:00
Roger Dingledine
741b11df45 put a bandaid in place so servers will have an easier time 
believing that they're reachable. this may help resolve the
servers-on-dynamic-ip-addresses problem.


svn:r6561
 2006-06-07 08:42:24 +00:00
Roger Dingledine
1e9b35aee3 make connection_or_nonopen_was_started_here() based on something less 
voodooey. it turns out we already do keep a flag like that around.


svn:r6560
 2006-06-07 07:11:42 +00:00
Roger Dingledine
8cf45df230 and now the exciting part: there is now no such thing as doing 
a client-only tls, that is, one with no certs.


svn:r6558
 2006-06-07 06:21:11 +00:00
Roger Dingledine
0bfef523df simplify the tortls api: we only support being a "server", that 
is, even tor clients do the same sort of handshake.

this has been true for years, so it's best to get rid of the
stale code.


svn:r6557
 2006-06-07 06:10:54 +00:00
Roger Dingledine
7512be0b65 looks like we missed a piece of the 0.1.1.9 paranoia code. 
hopefully this change is a no-op.


svn:r6556
 2006-06-07 02:57:23 +00:00
Roger Dingledine
96914760bc fix the bug where we sometimes would fail to send some create cells 
once we'd connected to a(nother) tor server.


svn:r6552
 2006-06-06 03:33:24 +00:00
Nick Mathewson
5e4b4451ec Also, add a temporary hack to make sure eventdns.c is distributd. 
svn:r6551
 2006-06-06 00:12:22 +00:00
Roger Dingledine
5c57348acd We got an obscure report of an assert error on a windows Tor server with 
connection_add being called with socket = -1. The only places I can see
where that happen would be if our tor_socketpair succeeds but it hands
back negative values for some of its file descriptors. Perhaps this will
produce more useful assert errors next time.


svn:r6550
 2006-06-06 00:06:52 +00:00
Roger Dingledine
411f37d534 fix typo 
svn:r6549
 2006-06-06 00:05:39 +00:00
Roger Dingledine
07c35b4f52 ship the event*.h files too. perhaps this will make my 'make dist' 
produce a tarball that i can build.


svn:r6548
 2006-06-06 00:04:52 +00:00
Nick Mathewson
2bd7c19b73 Try to log useful messages at info and debug about what we are resolving and what answers we are getting wrt eventdns. 
svn:r6547
 2006-06-05 23:01:22 +00:00
Roger Dingledine
542b8af592 don't tell people that the testing circuit failed if we already 
consider ourselves reachable. this just confuses them.


svn:r6546
 2006-06-05 10:01:52 +00:00
Roger Dingledine
a2fec314b6 scream louder if you've got a pending circuit for a given 
addr/port but the intended n_conn digest is wrong.


svn:r6544
 2006-06-05 09:47:19 +00:00
Roger Dingledine
45065f1466 simplify code now that libevent considers all sockets pollable. 
what we really mean now is ">= 0", which is clearer to test for.


svn:r6543
 2006-06-05 09:08:10 +00:00
Roger Dingledine
4e773352c2 bugfix: if we are making our first ever connection to any entry 
guard, then don't mark it down at first. we had this implemented
but it was disabled due to a bug.


svn:r6541
 2006-06-05 08:58:18 +00:00
Roger Dingledine
8f3bb66ebc simplify some code, since circuit_build_failed() is only called 
on non-open circuits.


svn:r6540
 2006-06-05 08:25:02 +00:00
Roger Dingledine
152d6d13b4 remove some unused code (i think) 
svn:r6539
 2006-06-05 08:02:04 +00:00
Roger Dingledine
bf09898f79 Note a bug that causes servers to sometimes never send the pending 
create cell. Nick, is this a bug? If so, is my fix right?


svn:r6538
 2006-06-05 07:27:48 +00:00
Roger Dingledine
266afcd7d5 bandaid for bug 299. this is still a bug, since we don't 
initialize for hardware acceleration in certain configurations;
but not critical until that is supported.


svn:r6536
 2006-06-05 04:29:03 +00:00
Nick Mathewson
b7ca697faf More eventdns.c patches: use HAVE_ALLOCA_H; print IP addrs as dotted quads. 
svn:r6535
 2006-06-05 01:59:12 +00:00
Nick Mathewson
3db785ef73 Hm. Where did we put that ntohl the last time we were juggling it? (hoop-lah). 
svn:r6534
 2006-06-05 00:32:31 +00:00
Nick Mathewson
008a0c7c46 Some eventdns.c fixes for windows correctness. More will doubtless be needed, especially around the #includes. 
svn:r6533
 2006-06-04 23:23:53 +00:00
Nick Mathewson
853e2d99b6 Add a new warning to our "warn a lot" list: unused parameters. This means we have to explicitly "use" unuseds, but it can catch bugs. (It caught two coding mistakes so far.) 
svn:r6532
 2006-06-04 22:42:13 +00:00
Roger Dingledine
c4647545a0 if we insist on printing pointer values, at least make it stop 
complaining on (my particular) 64 bit platform.


svn:r6530
 2006-06-04 06:17:32 +00:00
Roger Dingledine
603b09b59b punctuation and spelling 
svn:r6529
 2006-06-04 06:16:20 +00:00
Nick Mathewson
c18fab5366 Make eventdns.[ch] into good C90; remove signed/unsigned comparisons. 
svn:r6528
 2006-06-03 22:05:23 +00:00
Nick Mathewson
2700e5a1ab Oops. When we dont get a TTL, we should default to the default, not to the minimum. 
svn:r6527
 2006-06-03 21:47:26 +00:00
Nick Mathewson
c660a0f6a2 More DNS fixes. Send meaningful TTLs back to the client when 
possible.  Cache at the server side independently from the TTL, to
prevent attackers from probing the server to see who has been asking
for what hostnames.  (Hi, Dan Kaminski!)

Also, clean some whitespace.


svn:r6526
 2006-06-03 21:41:14 +00:00
Nick Mathewson
85a25c8a29 Make dns.c use eventdns.c -- but only when you pass the --enable-eventdns argument to configure.in. This will *so* not work on Windows yet. 
svn:r6525
 2006-06-03 20:52:24 +00:00
Nick Mathewson
7cb3232ade Add async dns code from Adam Langley, tweaked to build on OSX. Long-term, we may want to switch to libevnet/c-ares, if they ever handle 10k fd situations properly. This one still needs work too, but at least it is small. This code is disabled by default, and not integrated with dns.c. 
svn:r6524
 2006-06-03 19:49:42 +00:00
Nick Mathewson
86da3e0a0a Patch based on post by Mike C to or-dev; special-case based on use of MSVC, rather than on MS_WINDOWS, so that mingw builds. 
svn:r6523
 2006-06-03 18:52:31 +00:00
Roger Dingledine
8f902e4b58 don't stop fetching server descriptors if we're a server and 
haven't found ourselves reachable yet.


svn:r6522
 2006-06-03 02:56:44 +00:00
Roger Dingledine
1bf0f99b66 connection_t kept the identity_pkey but all it did was store it and 
free it. perhaps we don't need it after all?


svn:r6518
 2006-05-30 06:23:44 +00:00
Roger Dingledine
9000a5aff1 and get grammar right 
svn:r6517
 2006-05-30 06:19:48 +00:00
Roger Dingledine
ae2648fb1c stop fetching descriptors if we're not a dir mirror and we 
haven't tried to establish any circuits lately.


svn:r6516
 2006-05-30 06:19:06 +00:00
Roger Dingledine
1f0e20806b END_CIRC_REASON_OR_IDENTITY apparently means that we were told to 
connect to a different OR than lives on the addr:port we connected
to. we don't actually remember whether that was the case, currently.
so call it END_CIRC_REASON_OR_CONN_CLOSED as a compromise.


svn:r6515
 2006-05-30 06:17:28 +00:00
Roger Dingledine
60abe23158 tentative change: if you have your dirport set, you are a directory 
mirror, whether or not your orport is set.


svn:r6513
 2006-05-30 06:11:36 +00:00
Roger Dingledine
1e4923652b simplify a log message 
svn:r6512
 2006-05-30 05:29:03 +00:00
Nick Mathewson
64d487a2d6 Add a basic mmap function, with a "fake-it" wrapper to do read_file_from_str instead. Based on code from Michael Mohr. 
svn:r6510
 2006-05-28 16:54:39 +00:00
Roger Dingledine
f6ff3e6f0e directory authorities should be more tolerant of failed reachability 
tests before crying foul to the server operator.


svn:r6509
 2006-05-28 16:14:26 +00:00
Roger Dingledine
48be472e4f clean up a comment 
svn:r6508
 2006-05-28 16:07:44 +00:00