Roger Dingledine
b1971d89c8
properly free the return values of rate_limit_log()
...
resolves bug 7022.
2012-10-03 13:15:27 -04:00
Roger Dingledine
05f6f8f26d
actually use the rate-limiting string
...
previously we just allocated the string and then freed it.
2012-10-03 13:03:09 -04:00
Roger Dingledine
3d31771da9
Free some more still-in-use memory at exit
2012-10-03 12:46:09 -04:00
Roger Dingledine
65e85dba1b
reformat; no actual changes
2012-10-02 21:03:01 -04:00
Roger Dingledine
0ca47825a7
and make the last commit compile
2012-10-02 20:50:57 -04:00
Nick Mathewson
78e8eb5f2d
Fix compilation error left over from 1cbf45bed1. (Bug 7021)
2012-10-02 20:48:30 -04:00
Roger Dingledine
57b13ad5cc
more consistently use [gs]et_uint8
2012-10-02 20:39:58 -04:00
Nick Mathewson
a80d8e09d3
The --version option should imply --quiet.
...
Patch from 'maker'.
2012-10-01 11:01:18 -04:00
Nick Mathewson
f128baf36c
Add missing declaration so 6876 compiles
2012-09-28 12:03:37 -04:00
Nick Mathewson
5f494a363a
Merge remote-tracking branch 'linus/enh6876_2'
2012-09-28 11:57:36 -04:00
Nick Mathewson
95d9f7e9cc
Merge remote-tracking branch 'rransom/warn-about-hses-without-guards'
2012-09-25 12:39:00 -04:00
Roger Dingledine
dc014c9747
Merge branch 'maint-0.2.3'
2012-09-22 09:31:09 -04:00
Roger Dingledine
c88a4c51b4
add faravahar as our ninth v3 dir auth
2012-09-22 09:10:37 -04:00
Roger Dingledine
a2f57b9799
bump to 0.2.4.3-alpha-dev
2012-09-22 08:09:17 -04:00
Roger Dingledine
3355976bb4
bump to 0.2.4.3-alpha
2012-09-22 06:11:28 -04:00
Roger Dingledine
622f90904c
4aff97cfc didn't update the 'last modified' timestamp
2012-09-22 06:11:05 -04:00
Roger Dingledine
e132704466
fold in changes files
2012-09-22 06:06:36 -04:00
Nick Mathewson
9d4c53534d
Remove the testing_since* fields
...
They weren't actually used since 7a35dad00
2012-09-21 22:05:09 -04:00
Nick Mathewson
cf182efe0d
Fix comment in crypto.h; bug 6830
2012-09-21 21:55:06 -04:00
Nick Mathewson
b7fdb3a927
add changes file and whitespace fixes for bug 4020
2012-09-21 19:48:38 -04:00
Tom Fitzhenry
655782f302
Reinstate address in warning message when binding non-locally
...
bug4020
Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
2012-09-21 19:44:49 -04:00
Linus Nordberg
613079fbc4
Don't leak msg when parse_virtual_addr_network() fails.
2012-09-20 17:15:15 +02:00
Linus Nordberg
1cbf45bed1
Make option OutboundBindAddress accept IPv6 addresses too.
...
Implements ticket 6786.
2012-09-20 17:09:25 +02:00
Nick Mathewson
cff3b8c93c
Make ./configure -q really silent
...
Our updateVersions script was being verbose, which might have made
sense back when I wrote it, but doesn't any more.
Final fix for bug 6599
2012-09-19 11:47:59 -04:00
Linus Nordberg
ce553d4982
Have node_get_pref_orport() return an IPv6 OR port when UseBridges is set.
...
We used to never return an IPv6 address unless ClientUseIPv6 was
set. We should allow clients running with bridges use IPv6 OR ports
even without setting ClientUseIPv6. Configuring an IPv6 address in a
Bridge line should imply that.
Fixes th second part of #6757 .
2012-09-19 17:18:06 +02:00
Linus Nordberg
9c5ba489d3
Set (and reset) node_t.ipv6_preferred for bridges based on Bridge lines.
...
We used to set it only when ClientPreferIPv6ORPort was set which seems
wrong.
Fixes one part of #6757 .
2012-09-19 17:12:22 +02:00
Nick Mathewson
0e0a167742
Merge branch 'bug6843'
2012-09-19 09:01:15 -04:00
Nick Mathewson
f612a9eb1b
Merge remote-tracking branch 'origin/maint-0.2.3'
2012-09-19 08:26:07 -04:00
Nick Mathewson
b9c86948e4
Clarify that hidden services are TCP only
...
Also remove some trailing whitespace.
Patch from maker; fixes bug 6024.
2012-09-19 08:19:21 -04:00
Robert Ransom
38609f1354
Fix comment typo
2012-09-18 16:50:54 -04:00
Robert Ransom
130e899fbb
Warn if HSes are configured on a client with UseEntryGuards disabled
2012-09-18 16:50:00 -04:00
Robert Ransom
d1c4cf2f5a
Correct comment explaining why tor2web mode should disable entry guards
2012-09-18 16:38:01 -04:00
Nick Mathewson
9d3e497edb
Note a bug number for 6888
2012-09-18 16:22:12 -04:00
Mike Perry
acda1735fd
Disable Guard usage for Tor2webMode.
...
Tor2webMode is fingerprintable by hidden services through repeated
usage of the same three guard nodes for its rend and intro points.
2012-09-18 16:21:35 -04:00
Nick Mathewson
704fd8bb02
Bump bug 6866 log messages back up to notice for 0.2.4
2012-09-18 16:21:24 -04:00
Nick Mathewson
920c76a2fc
Merge remote-tracking branch 'origin/maint-0.2.3'
2012-09-18 16:20:01 -04:00
Nick Mathewson
aca325eb0c
Whitespace fixes
2012-09-18 16:16:17 -04:00
Nick Mathewson
f675e0a33e
specify a version for the bug6884 changes file
2012-09-18 15:54:36 -04:00
Linus Nordberg
a989dbc3dc
Print the correct address family in log printout.
...
Look at the address family of the preferred OR port rather than the
node.ipv6_preferred flag since the logic has changed with new
ClientUseIPv6 config option.
Fixes ticket 6884.
2012-09-18 14:41:14 +02:00
Mike Perry
4bfed4378d
Bug 6866: Convert pathbias asserts into log messages.
...
Asserts were hit by Tor2Web mode.
2012-09-17 18:25:28 -07:00
Nick Mathewson
5dfec9f833
Merge remote-tracking branch 'linus/bug6880'
2012-09-17 16:05:09 -04:00
Linus Nordberg
bee1e46bd1
Don't do reachability testing over IPv6 unless AuthDirPublishIPv6 is set.
...
This affects both directory authorities and bridge authoritites.
2012-09-17 22:01:58 +02:00
Robert Ransom
1e5cd1c7d6
Fix comment typo in tor_memeq
2012-09-17 11:13:09 -04:00
Nick Mathewson
757b3b259e
Add unit test for crypto_pk_cmp_keys and NULL
2012-09-17 11:04:56 -04:00
Robert Ransom
cd884c764b
Fix documentation for crypto_pk_cmp_keys
...
Now that crypto_pk_cmp_keys might return the result of tor_memcmp, there
is no guarantee that it will only return -1, 0, or 1. (It currently does
only return -1, 0, or 1, but that's a lucky accident due to details of the
current implementation of tor_memcmp and the particular input given to it.)
Fortunately, none of crypto_pk_cmp_keys's callers rely on this behaviour,
so changing its documentation is sufficient.
2012-09-17 11:02:53 -04:00
Robert Ransom
62babcaf0a
Implement and use crypto_pk_eq_keys
2012-09-17 11:02:53 -04:00
Robert Ransom
f3916a6855
Make crypto_pk_cmp_keys do something sane for NULL keys
...
Fixes bug 4283; bugfix on r76
(Git commit 01aadefbfc
2012-09-17 11:02:52 -04:00
Nick Mathewson
32d9cea289
Merge remote-tracking branch 'public/bug6853'
2012-09-17 10:50:48 -04:00
Nick Mathewson
5511d21d2b
Merge branch 'bug6861_typofix'
2012-09-17 10:28:35 -04:00
Nick Mathewson
96d2a21683
Avoid sign-extending when computing rend auth type.
...
Right-shifting negative values has implementation-defined behavior.
On all the platforms we work on right now, the behavior is to
sign-extend the input. That isn't what we wanted in
auth_type_val = (descriptor_cookie_tmp[16] >> 4) + 1;
Fix for 6861; bugfix on 0.2.1.5-alpha; reported pseudonymously.
The broken behavior didn't actually hurt anything, I think, since the
only way to get sign-extension to happen would be to have the top bit
of descriptor_cookie_tmp[16] set, which would make the value of
descriptor_cookie_tmp[16] >> 4 somewhere between 0b11111111 and
0b11111000 (that is, between -1 and -8). So auth_type_val would be
between -7 and 0. And the immediate next line does:
if (auth_type_val < 1 || auth_type_val > 2) {
So the incorrectly computed auth_type_val would be rejected as
invalid, just as a correctly computed auth_type_val would be.
Still, this stuff shouldn't sit around the codebase.
2012-09-17 10:28:14 -04:00
