822 Commits

Author	SHA1	Message	Date
Nick Mathewson	f39ba52029	checkSpace: be more careful about bad function headers. ... Previously we would forbid macro indentations like this: FOO({ int x; }) But clang-format sometimes generates those.	2020-02-06 14:54:04 -05:00
Nick Mathewson	c8fae6b5c8	checkSpace: don't treat an unindented label as starting a function.	2020-02-06 14:33:05 -05:00
Nick Mathewson	8d6f27cea5	checkSpace.pl: Allow space between iteration macros and (). ... Clang-format wants to put these in, and they do make sense for consistency. Also allow more types.	2020-02-06 14:33:05 -05:00
Nick Mathewson	bfa7607385	checkSpace.pl: Use a data structure for a list of non-function names	2020-02-06 14:33:05 -05:00
Nick Mathewson	1f1d943999	checkspace: allow spaces in cpp directives.	2020-02-06 14:33:05 -05:00
Nick Mathewson	15819cde61	checkSpace.pl: allow {{, ){, and ({.	2020-02-06 14:33:05 -05:00
Nick Mathewson	f1d371bf32	checkSpace: remove the nosplabel test.	2020-02-06 14:33:05 -05:00
Nick Mathewson	573ab70bfe	Temporary clang-format configuration and script. ... The format is the same as in my previous efforts here. The script is a little tricky, since it invokes both clang-format and codetool, and it makes sure that files do not have a changed mtime unless there is actually some change in the file.	2020-02-06 14:33:05 -05:00
Nick Mathewson	5bd86b50b5	codetool: post-processor for clang-format ... This code transformer makes a couple of changes that we want for our source code, and can be expanded to handle more.	2020-02-06 14:04:19 -05:00
Nick Mathewson	b7bbff0c9c	Merge remote-tracking branch 'public/practracker_regen_overbroad_2'	2020-02-06 08:27:12 -05:00
Nick Mathewson	5e963f97b1	practracker: use shutil.move so --regen will work on windows ... On windows you can't os.rename() a file if the target filename already exists.	2020-02-03 13:36:56 -05:00
Nick Mathewson	ec965ba98b	practracker: integration tests for --regen and --regen-overbroad	2020-02-03 13:11:58 -05:00
Nick Mathewson	2542a24b63	practracker: add a --regen-overbroad option to remove overbroad exceptions. ... Closes ticket 32372.	2020-02-03 13:02:12 -05:00
Christian Clauss	472d58372b	Remove unused import UserDict ... Fixes: https://trac.torproject.org/projects/tor/ticket/32791#comment:3 Unblocks: #1686	2020-02-03 17:55:58 +02:00
cclauss	3208a74f90	Use print() function in both Python 2 and Python 3	2020-01-28 01:38:54 +01:00
Nick Mathewson	cda10a2e89	Git hooks: remove support for 0.2.9 directory layout. ... We no longer will be pushing or committing things in branches that use src/common or src/or. Resolves ticket 32957.	2020-01-23 10:28:09 -05:00
David Goulet	3484608bda	practracker: Make it happy ... Signed-off-by: David Goulet <dgoulet@torproject.org>	2020-01-21 10:31:29 -05:00
teor	28c8c63de9	add_c_file: Replace asserts with exceptions ... Closes 32962.	2020-01-20 13:27:40 +10:00
teor	2c75d4a8d0	add_c_file: Improve script documentation ... Part of 32962.	2020-01-20 13:20:14 +10:00
teor	0418bc0cb2	add_c_file: Improve tor source directory checks ... Check that the script isn't in a tor build directory, by looking for a src/include.am file. Part of 32962.	2020-01-20 13:04:02 +10:00
teor	eb336e23a6	add_c_file: Rename variables based on the type of path ... * fname for generic file paths * tor_fname for paths relative to the top-level tor directory * src_fname for paths relative to tor's src directory With prefixes as required to disambiguate different paths of the same type. Part of 32962.	2020-01-16 09:27:57 +10:00
teor	b828588499	add_c_file: Simplify some usage of srcdir_file() ... Part of 32962.	2020-01-16 09:26:08 +10:00
teor	3d50efcf98	add_c_file: Document the paths used by each part of the script ... Most paths are relative to the top-level tor directory, but the paths in the C and H files are relative to tor's src directory. Part of 32962.	2020-01-16 09:26:04 +10:00
teor	207d2625ed	add_c_file: Improve path handling and canonicalisation ... * distinguish between paths relative to the top-level tor directory, and paths relative to tor's src directory * canonicalise paths before using them * check that the script is run from the top-level tor directory * check that the file is being created in tor's src directory Part of 32962.	2020-01-16 09:25:58 +10:00
Nick Mathewson	4f45ad1394	add_c_file: tolerate ./ in filenames.	2020-01-16 09:23:54 +10:00
Nick Mathewson	ef1744e2c9	add_c_file: handle adding to the end of a list correctly. ... Fixes bug 32962.	2020-01-16 09:23:49 +10:00
Nick Mathewson	5e70c27e85	Merge remote-tracking branch 'tor-github/pr/1657'	2020-01-15 13:10:14 -05:00
teor	b7cfca1dee	Merge branch 'pr1599_squashed'	2020-01-15 22:31:01 +10:00
teor	b910ae8cd1	practracker: Wrap long lines in the test script	2020-01-15 22:29:52 +10:00
teor	fa038e5617	practracker: Test practracker exit status ... Part of 32705.	2020-01-15 22:29:48 +10:00
teor	eb55d85e75	practracker: Fail tests if any process exits unexpectedly ... Part of 32705.	2020-01-15 22:29:44 +10:00
teor	cda2ff1965	practracker: Capture stderr output in test_practracker.sh ... And canonicalise file paths, so that output is consistent, even in out-of-tree builds. Capturing stderr output produces better diagnostics. Diagnostics for 32705.	2020-01-15 22:29:22 +10:00
teor	c80694decc	scripts/git: Improve branch list comments ... Hopefully, these explanations make it easier to get the next branch transition right. Part of 32772.	2020-01-15 12:28:00 +10:00
teor	536eeb4589	scripts/git: Fix git-merge-forward after removing 0.2.9 ... We need a test branch for the earliest maint branch (maint-0.3.5), but we can't merge forward into it, because there is no previous active maint branch. Also, edit a git-push-all comment that still said "029". Bugfix on 32772; bug not in any released version of tor.	2020-01-15 12:22:38 +10:00
David Goulet	b958529dbf	Merge branch 'tor-github/pr/1633'	2020-01-14 14:03:21 -05:00
teor	8095c785f1	Merge branch 'maint-0.4.2'	2020-01-14 17:41:44 +10:00
teor	7e111d0eaa	practracker: print a notice to stderr when disabled ... When TOR_DISABLE_PRACTRACKER is set, print a message to stderr when skipping practracker checks. Part of 32705.	2020-01-14 17:41:00 +10:00
Nick Mathewson	6b1592b564	test_practracker.sh: never disable practracker ... When practracker is disabled, its output will be empty. We don't want that happening during our tests. Fixes bug 32705; bugfix on 0.4.2.1-alpha, when test_practracker.sh was introduced.	2020-01-13 16:17:51 -05:00
Nick Mathewson	73ac1add3f	Split core/include.am into per-subdirectory include.am files ... Closes ticket 32137.	2020-01-13 09:34:17 -05:00
rl1987	c0dd214c8a	Remove 0.2.9 from git scripts	2019-12-30 12:41:08 +07:00
teor	ac3a9aaf0d	Makefile/git scripts: Add comments to keep owned file lists in sync	2019-12-20 09:35:18 +10:00
teor	5c98a42f49	Merge remote-tracking branch 'tor-github/pr/1584'	2019-12-19 19:33:29 +10:00
teor	1619f14a04	python: Add __future__ imports for python 3 compatibility ... Except for src/ext, which we may not want to modify. Closes ticket 32732.	2019-12-12 15:58:51 +10:00
Nick Mathewson	e93801bfe6	Port changelog tools to python 3 ... Closes ticket 32704.	2019-12-09 10:53:48 -05:00
teor	9a556dee81	cocci: Require spatch >= 1.0.4 to run checks ... No changes file required: not in any released version of tor. Fixes bug 32663.	2019-12-05 10:27:47 +10:00
Nick Mathewson	fcb5656128	Merge branch 'ticket32609_squashed'	2019-12-04 12:15:28 -05:00
teor	b0f1b760ae	practracker: document !advisory in includes.py	2019-12-04 12:15:22 -05:00
teor	8861ad85d0	git scripts: Add the checkSpace.pl unit tests ... Extra testing after 32613.	2019-12-04 12:15:22 -05:00
teor	19324ff0ba	practracker: Test for bad ".c" includes in the unit tests ... Part of 32522.	2019-12-04 12:15:22 -05:00
teor	5ce45ac907	Makefile/git scripts: Add the practracker unit tests ... Add a check-practracker-unit-test target, and run it as part of "make check". Add the practracker unit tests to scripts/git/pre-commit.git-hook. Part of 32609.	2019-12-04 12:15:22 -05:00
Nick Mathewson	8a10a74870	Have checkSpaceTest.sh exit as skipped when on Windows ... Managing line-ending issues for this one isn't worth it.	2019-12-03 12:56:50 +10:00
Nick Mathewson	bd61a4e848	Add a simple test for checkSpace.pl ... This script is not expected to work on windows due to line-ending issues, so I'm not making it get run on an automated basis. We should use it when editing checkSpace.pl. Closes ticket 32613.	2019-12-03 12:56:46 +10:00
Nick Mathewson	2aaa7ae6e2	checkSpace.pl: make output more uniform. ... There were lots of slight differences in indentation and formatting among the in-file error messages.	2019-11-26 12:58:25 -05:00
teor	fadd292bf0	practracker/includes.py: Don't read editor temp files ... (Or any files that start with "." or "#".) Obviously correct changes to already-reviewed code.	2019-11-26 17:52:18 +10:00
teor	0ce11433c0	check-spaces: Fix an outdated comment	2019-11-26 11:02:28 +10:00
teor	ab70c315bd	practracker: Fix a typo in a logging function call ... Obviously correct changes to already-reviewed code.	2019-11-26 11:01:34 +10:00
Nick Mathewson	31f8b4fa65	Merge branch 'stream-socks-auth' into bug19859_merged	2019-11-25 07:58:02 -05:00
Nick Mathewson	d9d75d4ae1	rename_c_identifier: don't crash when doing only one replacement.	2019-11-23 15:30:18 -05:00
Nick Mathewson	5060007f4b	Split log configuration out of options_act_reversible().	2019-11-19 16:03:32 -05:00
George Kadianakis	53ac9a9a91	Add changes file for #30381.	2019-11-18 19:21:10 +02:00
David Goulet	1371d29e5b	Merge branch 'tor-github/pr/1489'	2019-11-14 10:37:14 -05:00
teor	3b4a360ed0	practracker: Don't read editor temp files, attempt 2 ... (Or any files that start with "." or "#".) Obviously correct changes to already-reviewed code.	2019-11-14 16:12:19 +10:00
teor	7ee1e16c6f	scripts/git: Stop failing when upstream branches don't exist ... If you add a custom remote, or a new branch, and don't fetch first, then the script would fail when checking for unchanged branches. Instead, skip the check: a new branch is definitely a change.	2019-11-07 12:04:51 +10:00
teor	3864536b7c	scripts/git: Remove extra printfs from a bad merge	2019-11-07 12:04:22 +10:00
teor	e6b5a1ff93	shellcheck: Fix minor issues in some scripts ... Fix minor issues in git-push-all.sh, git-setup-dirs.sh and test_parseconf.sh. Fixes bug 32402; not in any released version of tor. Obviously correct changes to already reviewed code.	2019-11-06 16:21:01 +10:00
teor	f7b45975bf	Merge branch 'bug32402_042' into bug32402_master ... Merge changes from master with shellcheck fixes.	2019-11-06 16:14:06 +10:00
teor	7f23d47f72	shellcheck: Fix issues in the git-*.sh scripts ... Fixes bug 32402; bugfix on 0.4.2.1-alpha. Obviously correct changes to already reviewed code.	2019-11-06 16:09:31 +10:00
teor	57baea701f	shellcheck: Start checking most scripts for errors ... This check was accidentally disabled by a bad find command. Fixes bug 32402; bugfix on 0.4.2.1-alpha. Obviously correct changes to already reviewed code.	2019-11-06 15:49:50 +10:00
teor	60d5ff303d	practracker: Preserve improvements	2019-11-05 14:28:02 +10:00
teor	6169469546	Merge remote-tracking branch 'tor-github/pr/1477'	2019-11-05 14:23:10 +10:00
teor	bcb38d984d	practracker: Update the exceptions file with improvements ... Regenerate the exceptions file, but only commit the improvements. Includes changes from 32213 and other tickets.	2019-11-05 12:50:08 +10:00
teor	81972353cb	scripts: Fix update_versions.py for out-of-tree builds ... Fixes bug 32371; bugfix on 0.4.0.1-alpha.	2019-11-05 12:00:59 +10:00
teor	c065ad3e3d	practracker: Rename functions modified by a previous commit ... Part of 32213.	2019-11-05 11:36:26 +10:00
JeremyRand	736322ce61	Bug #19859: Increase function-size exception to 124	2019-11-03 07:11:08 +00:00
teor	1ffb3b549f	scripts/git: Add TOR_EXTRA_REMOTE_* for an extra git remote ... When running git-setup-dirs.sh. Part of 32347.	2019-10-31 14:59:19 +10:00
teor	38e8cca6a1	scripts/git: Add TOR_EXTRA_CLONE_ARGS for git clone ... When running git-setup-dirs.sh. Part of 32347.	2019-10-31 14:59:16 +10:00
teor	995618ec61	scripts/git: Make a master symlink in the worktree directory ... When running git-setup-dirs.sh. Part of 32347.	2019-10-31 14:59:12 +10:00
teor	e046903f93	scripts/git: Restore a dropped check for pre-commit in pre-push ... Bugfix on 31919; not in any released version of Tor.	2019-10-31 14:51:31 +10:00
teor	7e73c0d5a1	scripts/git: Print the correct path in git-setup-dirs.sh	2019-10-31 14:39:49 +10:00
teor	cb7340abf1	scripts/git: Don't use spaces in git URLs	2019-10-31 13:56:59 +10:00
teor	3479024cb1	scripts: Change to the top source directory as needed ... Bugfix on 31919; not in any released version of tor.	2019-10-28 13:28:50 +10:00
teor	18e09913bf	practracker: Don't read editor temp files ... (Or any dot files.) Obviously correct changes to already-reviewed code.	2019-10-28 13:09:58 +10:00
teor	68befa3b84	scripts/git: Fix a shellcheck error in pre-commit.git-hook ... Some versions of shellcheck do not detect this error. Bugfix on 31919; not in any released version of tor.	2019-10-28 13:04:29 +10:00
Nick Mathewson	e7993dc046	Merge branch 'ticket31241_v3'	2019-10-25 08:10:39 -04:00
teor	00c3fba61c	scripts/maint: Stop assuming that python3 is in /usr/bin ... Obviously correct fix to rename_c_identifier.py. Bugfix on 32237; not in any released version of tor.	2019-10-25 16:46:54 +10:00
teor	f40eb2ead6	Merge remote-tracking branch 'tor-github/pr/1462'	2019-10-25 16:14:37 +10:00
Nick Mathewson	dc6d7f072d	Make foo_validate() functions call config_validate(). ... The former foo_validate() functions are now toplevel legacy_validate_fn callbacks. The new foo_validate() functions now call them. This change lets us remove the old shared_random disk state validation callback entirely.	2019-10-24 20:30:32 -04:00
teor	b3d035d5c4	Merge remote-tracking branch 'tor-github/pr/1463'	2019-10-25 10:27:41 +10:00
Nick Mathewson	fcdb66acd3	Add a script to rename C identifiers, and optionally add a commit message ... This script should "pay for itself" if it prevents one bug caused by careless search-replace-commit loops.	2019-10-24 08:20:31 -04:00
teor	1094389d82	scripts/git: Make spaces consistent in pre-push.git-hook ... Part of 31919.	2019-10-24 14:10:30 +10:00
teor	b4b316631d	scripts/git: Only check modified files in existing git hook checks ... Part of 31919.	2019-10-24 14:10:26 +10:00
teor	b9a2286765	scripts/git: Add check_cocci_parse.sh to the pre-commit hook ... But only check modified files, which dramatically speeds up check_cocci_parse.sh. Part of 31919.	2019-10-24 14:09:53 +10:00
teor	71b8b7ee2d	scripts/cocci: Check owned src in check_cocci_parse.sh by default ... Check the tor-owned sources in an 0.3.5 directory layout, if no files are provided on the command line. Part of 31919.	2019-10-24 14:09:45 +10:00
teor	330717f018	scripts/cocci: Add check_cocci_parse.sh and default exceptions ... Add check_cocci_parse.sh, which is a thin wrapper around try_parse.sh. Add a default exceptions file, and use it in check_cocci_parse.sh. Part of 31919.	2019-10-24 11:40:58 +10:00
teor	87ee49e016	scripts/cocci: Remove unused arguments from try_parse.sh spatch ... Part of 31919.	2019-10-24 11:40:54 +10:00
teor	9a96068a0b	scripts/cocci: Add an exceptions file to try_parse.sh ... Set $TOR_COCCI_EXCEPTIONS_FILE to the name of an exceptions file, containing a list of filename patterns matched by 'grep -f'. Part of 31919.	2019-10-24 11:40:51 +10:00
teor	20606b8a15	Merge remote-tracking branch 'tor-github/pr/1447'	2019-10-24 10:00:47 +10:00
teor	f43a7a4d96	scripts/git: Avoid sleeping before the last push in git-push-all.sh ... Change the loop order, so that we only sleep between pushes, and avoid sleeping after all the pushes are done. (In rare cases, there may still be an extra sleep.) Part of 32216.	2019-10-23 13:28:37 +10:00
teor	4f6f006c99	scripts/git: Make git-push-all.sh skip more branches that match upstream ... The script now skips master, maint-* and release-* branches that match upstream, not just test branches. And fix "no branches" bugs that this change makes happen more often. Part of 32216.	2019-10-23 13:28:15 +10:00
teor	9a3b768fae	scripts/git: Pass all unrecognised arguments to git-push-all.sh ... This makes the behaviour of git-push-all.sh -n identical to the other git scripts. Part of 32216.	2019-10-23 13:04:28 +10:00